run resume code only for S1-S4 states
Jung-uk Kim
jkim at FreeBSD.org
Wed Apr 15 09:30:19 PDT 2009
On Wednesday 15 April 2009 12:11 pm, Andriy Gapon wrote:
> on 15/04/2009 19:08 Jung-uk Kim said the following:
> > Actually, my patch was more complex, e.g., I added more code to
> > make sure power/sleep button events get ignored and cleared when
> > it is not in S0 state, etc. Probably I needed to track the
> > current state because of it. I think you may ignore it for now
> > if it is not needed anywhere else.
>
> Interesting. I think that I will go with the current patch (modulo
> break->goto changes), if my mentors approve. But I would like to
> see your patch :-)
I am not sure I still have it. It wasn't finished (thus not
committed) because it was a lot more complex than I originally
thought. We really have to consolidate ACPI state tracking in one
variable outside of ACPI softc so that it can be atomically tracked
without complex locking/unlocking layers of various locks, e.g.,
acpi_button from DSDT, fixed buttons from FADT, acpi, giant, etc. :-(
Jung-uk Kim
More information about the freebsd-acpi
mailing list