kern/121504: [patch] Correctly set hw.acpi.osname on certain machines

[Anish Mistry]

The following reply was made to PR kern/121504; it has been noted by GNATS.

From: Anish Mistry <amistry at am-productions.biz>
To: John Baldwin <jhb at freebsd.org>
Cc: bug-followup at freebsd.org, njl at freebsd.org
Subject: Re: kern/121504: [patch] Correctly set hw.acpi.osname on certain machines
Date: Mon, 10 Mar 2008 15:09:04 -0400

 --nextPart11816881.8XfUQkhbdk
 Content-Type: text/plain;
   charset="iso-8859-1"
 Content-Transfer-Encoding: quoted-printable
 Content-Disposition: inline
 
 On Monday 10 March 2008, John Baldwin wrote:
 > This is not the correct patch.  The _OSI method does not return an
 > OS name like _OS.  Instead, it is a function that returns a boolean
 > (True/False) to say if a given OS name is supported (OS name is
 > passed as an argument).  The proper fix is to say that the osname
 > is supported in the
 > AcpiOsValidateInterface() method.  Something like this should work:
 >
 > Index: Osd/OsdMemory.c
 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 > RCS file: /usr/cvs/src/sys/dev/acpica/Osd/OsdMemory.c,v
 > retrieving revision 1.15
 > diff -u -r1.15 OsdMemory.c
 > --- Osd/OsdMemory.c	22 Mar 2007 18:16:41 -0000	1.15
 > +++ Osd/OsdMemory.c	10 Mar 2008 16:20:03 -0000
 > @@ -77,6 +77,9 @@
 >  ACPI_STATUS
 >  AcpiOsValidateInterface (char *Interface)
 >  {
 > +
 > +    if (strcmp(Interface, acpi_osname) =3D=3D 0)
 > +	return (AE_OK);
 >      return (AE_SUPPORT);
 >  }
 
 I get acpi_osname undeclared on compile.
 
 
 =2D-=20
 Anish Mistry
 amistry at am-productions.biz
 AM Productions http://am-productions.biz/
 
 --nextPart11816881.8XfUQkhbdk
 Content-Type: application/pgp-signature; name=signature.asc 
 Content-Description: This is a digitally signed message part.
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.8 (FreeBSD)
 
 iEYEABECAAYFAkfVh1EACgkQxqA5ziudZT2+3ACffUTYiddpl9B116V1ir7UF8AM
 I+kAoKZfbYaukN3CA6ATmaOYbtmRSFeB
 =29gj
 -----END PGP SIGNATURE-----
 
 --nextPart11816881.8XfUQkhbdk--