acpi_throttle: quirk based on pci info

Nate Lawson nate at root.org
Fri Feb 22 22:08:13 UTC 2008


Andriy Gapon wrote:
> on 22/02/2008 17:56 Andriy Gapon said the following:
>> Please find attached a patch that makes sure that acpi_thermal is
>> initialized after PCI bus is available, so that it is possible to decide
>> about hardware quirks based on PCI information.
>> The code uses the same approach as ichss does.
>> The patch is tested to work.
> 
> Oops! I attached on older version of the patch, sorry.
> Correct patch is here.
> (parent of acpi_throttle is cpu, not acpi)
> 
>> NOTE: This patch in contaminated! It contains code that forces throttle
>> duty width to be 3 bits for PIIX4E and PIIX4M. This is in accordance
>> with the chipsets specifications. Some motherboard/bios vendors lie
>> about this value in FADT.
>> If not accepted, this quirk can be easily stripped from the patch as its
>> code is contained in distinct hunks.

I'm going to think about this a little before saying it should be 
committed in current form.  The C2 fix is fine.

Thanks,
-- 
Nate


More information about the freebsd-acpi mailing list