APM Patch - review

Liam J. Foy liamfoy at sepulcrum.org
Wed May 26 23:48:14 PDT 2004


On Wed, 26 May 2004 22:08:26 -0700 (PDT)
Nate Lawson <nate at root.org> wrote:

> On Tue, 25 May 2004, Grover, Andrew wrote:
> > Valid values for remaining battery life are 0xFF, and 0-100.
> >
> > -1, 255 and 0xFF are the SAME when looking at an 8 bit value. Since this
> > 8 bit value was sign-extended to 32 bits to go into ai_batt_time, if it
> > was 0xFF, it is now 0xFFFFFFFF, and you will never see 0x000000FF.
> 
> Correct.  Liam, can you add a printf for the unknown case (%x) that gives
> the actual value?
Nate, to do you mean add a printf to the unknown case to print the value instead
of have "invalud value (%x)" etc?

Or do you mean add printf in order for me to see what happening?
> 
> -Nate


More information about the freebsd-acpi mailing list