Improper failure declarations for cmbat

Kevin Oberman oberman at es.net
Mon Dec 20 08:37:43 PST 2004


> Date: Sun, 19 Dec 2004 21:04:13 -0800
> From: Nate Lawson <nate at root.org>
> 
> Kevin Oberman wrote:
> > I have an IBM T30 with 2 batteries. Yesterday I was running on battery
> > for a while and completely exhausted the secondary battery. The primary
> > never dropped below about 75%.
> > 
> > When the secondary dropped, acpi_cmbat1 started spitting out large
> > numbers of errors.
> > acpi_cmbat1: critically low charge!
> > While the messages are correct, they are not really appropriate when the
> > primary battery is fully charged and is both annoying and fills up the
> > log, possibly causing "real" messages to be missed. I would suggest that
> > no battery critical warning be issued unless all batteries are critical.
> 
> Thanks for the bug report.  I just committed a small fix to only report 
> the message once.  Checking all batteries is a larger change that we can 
> examine in the future.

Nate,

Thanks for the quick fix!

I don't see and MFC entry on the patch. Would that be possible (in a few
days, of course)?
-- 
R. Kevin Oberman, Network Engineer
Energy Sciences Network (ESnet)
Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab)
E-mail: oberman at es.net			Phone: +1 510 486-8634


More information about the freebsd-acpi mailing list