git: 6bf9668d9d02 - stable/13 - mrsas: unbreak i386 build

Justin Hibbits chmeeedalf at gmail.com
Fri Feb 5 17:24:58 UTC 2021


Feb 5, 2021 11:14:34 Andriy Gapon <avg at FreeBSD.org>:

> On 05/02/2021 19:12, Justin Hibbits wrote:
>> Feb 5, 2021 10:56:13 Andriy Gapon <avg at FreeBSD.org>:
>>
>>> On 05/02/2021 18:52, Alfredo Dal'Ava Junior wrote:
>>>> The branch stable/13 has been updated by alfredo:
>>>>
>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=6bf9668d9d02bdf3e0dafc4ba1010ef6a9b12247
>>>>
>>>> commit 6bf9668d9d02bdf3e0dafc4ba1010ef6a9b12247
>>>> Author:     Alfredo Dal'Ava Junior <alfredo at FreeBSD.org>
>>>> AuthorDate: 2021-02-05 18:43:48 +0000
>>>> Commit:     Alfredo Dal'Ava Junior <alfredo at FreeBSD.org>
>>>> CommitDate: 2021-02-05 19:50:21 +0000
>>>>
>>>>     mrsas: unbreak i386 build
>>>>    
>>>>     Fix build regression introduced by
>>>>     e34a057ca6ebdf8e30ec8b0dc21d18eb450bf36a
>>>>    
>>>>     Reviewed by:    jhibbits
>>> Was it?  I do not see an approval in the review request.
>> Yes,  it was reviewed by me,  since he took exactly what I suggested, and we discussed over IRC.
>>
>
> My apologies then.
> I was confused by the fact that you commented in phabricator but accepted over
> IRC (which I didn't know).
>
> --
> Andriy Gapon

Fully understandable,  especially given the timing of the review to commit,  and in relation to the release process going on.

- Justin


More information about the dev-commits-src-branches mailing list