git: 872a0097fd81 - stable/13 - tmpfs: drop acq fence now that vn_load_v_data_smr has consume semantics
Mateusz Guzik
mjg at FreeBSD.org
Mon Feb 1 12:46:39 UTC 2021
The branch stable/13 has been updated by mjg:
URL: https://cgit.FreeBSD.org/src/commit/?id=872a0097fd81235cea5730e642daf725e8bf8afc
commit 872a0097fd81235cea5730e642daf725e8bf8afc
Author: Mateusz Guzik <mjg at FreeBSD.org>
AuthorDate: 2021-01-25 20:17:48 +0000
Commit: Mateusz Guzik <mjg at FreeBSD.org>
CommitDate: 2021-02-01 12:39:16 +0000
tmpfs: drop acq fence now that vn_load_v_data_smr has consume semantics
(cherry picked from commit c09f7992714559eaa874f13ea4a1d648f199cd08)
---
sys/fs/tmpfs/tmpfs_subr.c | 3 ---
sys/fs/tmpfs/tmpfs_vnops.c | 1 -
2 files changed, 4 deletions(-)
diff --git a/sys/fs/tmpfs/tmpfs_subr.c b/sys/fs/tmpfs/tmpfs_subr.c
index 3b3581fc81f6..84473a439c43 100644
--- a/sys/fs/tmpfs/tmpfs_subr.c
+++ b/sys/fs/tmpfs/tmpfs_subr.c
@@ -356,9 +356,6 @@ tmpfs_alloc_node(struct mount *mp, struct tmpfs_mount *tmp, enum vtype type,
* pointer to also get the above content in a stable manner.
* Worst case tn_link_smr flag may be set to true despite being stale,
* while the target buffer is already cleared out.
- *
- * TODO: Since there is no load consume primitive provided
- * right now, the load is performed with an acquire fence.
*/
atomic_store_ptr(&nnode->tn_link_target, symlink);
atomic_store_char((char *)&nnode->tn_link_smr, symlink_smr);
diff --git a/sys/fs/tmpfs/tmpfs_vnops.c b/sys/fs/tmpfs/tmpfs_vnops.c
index bc4caa4adecb..7be2655dcf0b 100644
--- a/sys/fs/tmpfs/tmpfs_vnops.c
+++ b/sys/fs/tmpfs/tmpfs_vnops.c
@@ -1471,7 +1471,6 @@ tmpfs_fplookup_symlink(struct vop_fplookup_symlink_args *v)
vp = v->a_vp;
node = VP_TO_TMPFS_NODE_SMR(vp);
- atomic_thread_fence_acq();
if (__predict_false(node == NULL))
return (EAGAIN);
if (!atomic_load_char(&node->tn_link_smr))
More information about the dev-commits-src-branches
mailing list