cvs commit: src/include readpassphrase.h

[Sean C. Farley]

On Fri, 9 May 2008, Daniel O'Connor wrote:

> On Fri, 9 May 2008, Sean Farley wrote:
>> scf         2008-05-08 23:57:29 UTC
>>
>>   FreeBSD src repository
>>
>>   Modified files:
>>     include              readpassphrase.h
>>   Log:
>>   Define the size_t type since readpassphrase(3) requires it in its
>>   definition and sys/types.h is not listed within the synopsis of the
>>   man page.
>
> Surely it would be better to amend the documentation?

I had difficulty deciding on this.  It was either change the code to
follow the specification (man page) or update the documentation.  What
tipped it toward patching the code was the assumption that the man page
may be correct for some OS's and coders may have written their code
based on the man page.  Of course, they probably have already included
sys/types.h (or any header that defines size_t) to get it to compile.

Questions:
1. Does the fact that it is not a system call mean that it should not
    define size_t?
2. Are string.h and strings.h, for example, exceptions due to legacy?

I am open to changing the man page.  Does anyone know if other *BSD
systems also need sys/types.h with this program[1]?

Sean
   1. http://www.farley.org/freebsd/tmp/readpassphrase.c
-- 
scf at FreeBSD.org