cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c

Kris Kennaway kris at FreeBSD.org
Mon Jan 14 14:46:45 PST 2008


David Schultz wrote:
> On Mon, Jan 14, 2008, Kris Kennaway wrote:
>> David O'Brien wrote:
>>
>>>> If we have to special case ports to deal with variant zipfiles that 
>>>> cannot be processed by /usr/bin/unzip then it gets messier because we 
>>>> have to account for some ports being satisfied with USE_ZIP=yes meaning 
>>>> /usr/bin/unzip and some still requiring /usr/ports/archivers/unzip.  I'd 
>>>> prefer not to have to add those workarounds.
>>> This seems quite easy...
>>>
>>> For those four-ish ports 's/USE_ZIP/USE_INFOZIP/'
>> That's what I meant by "special case".  I don't like adding special case 
>> variables to bsd.*.mk for the benefit of a tiny number of ports; that 
>> file is already cluttered enough.
> 
> Given how little time it took Tim to get libarchive from a simple
> prototype that supported tar files to a 23k line library that
> supports dozens of variant archive formats, I suspect that the
> limitation and the corresponding hack will be temporary. :) And if
> it is just a small number of ports, it could be set up as an
> extract dependency in the individual port makefiles, right?  It's
> not as though InfoZIP is going to change a lot in the near future.
> 
> 

No, you'd have to duplicate the do-extract code (or add a special 
variable for those 4 ports).  I'd much rather wait to see what Tim and 
Dag-Erling can come up with.

Kris


More information about the cvs-src mailing list