cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c

Peter Jeremy peterjeremy at optushome.com.au
Thu Jan 10 10:32:00 PST 2008


On Thu, Jan 10, 2008 at 08:59:59AM +0000, Robert Watson wrote:
>In the past, we've had several subtle bugs crop up as a result of changing 
>to ANSI C function prototypes, which no longer automatically promote 
>arguments to int from shorter types

I hadn't considered that but it _is_ the sort of thing that comparing
object files would detect - if you make a supposedly stylistic change
and the generated code changes then it's time to take a much more
careful look into what you are doing.

> (I think it's that way around).
That would be correct - I know Sun Studio 11 (at least) warns about the
situation where mixing ANSI and K&R prototypes/definitions causes type
mismatches due to implicit promotion.  I thought gcc did as well.

-- 
Peter Jeremy
Please excuse any delays as the result of my ISP's inability to implement
an MTA that is either RFC2821-compliant or matches their claimed behaviour.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080110/08c2987d/attachment.pgp


More information about the cvs-src mailing list