From edwin at mavetju.org Tue Jan 1 00:07:15 2008 From: edwin at mavetju.org (Edwin Groothuis) Date: Tue Jan 1 00:07:22 2008 Subject: cvs commit: src/share/zoneinfo europe southamerica zone.tab In-Reply-To: <200801010747.m017lg7T045831@repoman.freebsd.org> References: <200801010747.m017lg7T045831@repoman.freebsd.org> Message-ID: <20080101075026.GB7176@k7.mavetju> On Tue, Jan 01, 2008 at 07:47:42AM +0000, Edwin Groothuis wrote: > edwin 2008-01-01 07:47:42 UTC > > FreeBSD src repository > > Modified files: > share/zoneinfo europe southamerica zone.tab > Log: > MFV of tzdata2007k. > > - Adjust Argentinian DST times. > - Add SJ on the right location. That one was Approved by: grog@ (implicit) Edwin -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://www.mavetju.org/weblog/ From edwin at mavetju.org Tue Jan 1 00:07:15 2008 From: edwin at mavetju.org (Edwin Groothuis) Date: Tue Jan 1 00:07:23 2008 Subject: cvs commit: src/share/zoneinfo - Imported sources In-Reply-To: <200801010745.m017jBNf045644@repoman.freebsd.org> References: <200801010745.m017jBNf045644@repoman.freebsd.org> Message-ID: <20080101074945.GA7176@k7.mavetju> On Tue, Jan 01, 2008 at 07:45:11AM +0000, Edwin Groothuis wrote: > MFV of tzdata2007k That was an import of vendor sources. -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://www.mavetju.org/weblog/ From imp at bsdimp.com Tue Jan 1 01:31:50 2008 From: imp at bsdimp.com (M. Warner Losh) Date: Tue Jan 1 01:31:54 2008 Subject: cvs commit: src/lib/libarchive Makefile archive.h.in archive_entry.c archive_entry.h archive_entry_link_resolver.c archive_entry_private.h archive_entry_strmode.c archive_platform.h archive_read.c archive_read_support_compression_none.c archive_read_support_format_all.c ... In-Reply-To: <4779D924.8020708@freebsd.org> References: <20071231001554.GB987@zaphod.nitro.dk> <20071231.203352.-165197022.imp@bsdimp.com> <4779D924.8020708@freebsd.org> Message-ID: <20080101.023143.-160243128.imp@bsdimp.com> In message: <4779D924.8020708@freebsd.org> Tim Kientzle writes: : M. Warner Losh wrote: : > In message: <20071231001554.GB987@zaphod.nitro.dk> : > "Simon L. Nielsen" writes: : > : > * New read support: mtree format : > : : > : This sounds interesting but I can't really figure out what it : > : does... ? :) (and I couldn't find any mention in the updated manual : > : pages.) : > : > Any chance our 'install' tools can be made to copy the files w/o the : > right permissions and 'log' the right stuff to an mtree formatted : > file? That would make building a distribution as a mere mortal : > possible... : : Yep. ;-) That's a major motivation of this work. : In fact, you don't even need to copy the files : anywhere. The approach I'm considering would : have "make buildworld" write out entries of this : form during the build: : : /bin/ls uid=0 mode=0555 contents=/usr/obj/usr/src/bin/ls : : Then "make installworld" becomes essentially just: : : tar -xUvf world.mtree -C ${DESTDIR} : : or you can create a distribution tarball with: : : tar -czf world.tgz @world.mtree I mostly like this idea, save for one problem: install will strip the symbols from /usr/obj/usr/src/bin/ls before installing it into $DESTDIR/bin/ls. : In particular, I like that this approach uses exactly : the same machinery for local installs or distribution : building, varying only in the very last step. : : The code I just committed to -CURRENT is sufficient to : begin experimenting with this approach; you just need : to be careful to include "#mtree" as the first line : (to please libarchive's auto-format detection). : The use of full pathnames in mtree files is another : idea I copied from the NetBSD folks; I've documented : this as "mtree v2" in the mtree.5 manpage. : : There are still a lot of details to work out, but I : hope this is sufficient for someone else to begin : experimenting with the next step, which is figuring out : the appropriate ways to change our distribution build. Yes. Any ideas how long the experimentation will last? Warner From imp at FreeBSD.org Tue Jan 1 01:36:00 2008 From: imp at FreeBSD.org (Warner Losh) Date: Tue Jan 1 01:36:01 2008 Subject: cvs commit: src COPYRIGHT Message-ID: <200801010935.m019Zxf7097621@repoman.freebsd.org> imp 2008-01-01 09:35:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) . COPYRIGHT Log: MFC: Happy New Year Approved by: re@ Revision Changes Path 1.8.2.1 +1 -1 src/COPYRIGHT From imp at FreeBSD.org Tue Jan 1 01:36:30 2008 From: imp at FreeBSD.org (Warner Losh) Date: Tue Jan 1 01:36:33 2008 Subject: cvs commit: src COPYRIGHT Message-ID: <200801010936.m019aUMf097663@repoman.freebsd.org> imp 2008-01-01 09:36:30 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) . COPYRIGHT Log: MFC new year Approved by: re@ Revision Changes Path 1.8.4.1 +1 -1 src/COPYRIGHT From imp at FreeBSD.org Tue Jan 1 01:37:14 2008 From: imp at FreeBSD.org (Warner Losh) Date: Tue Jan 1 01:37:15 2008 Subject: cvs commit: src COPYRIGHT Message-ID: <200801010937.m019b9Qn097709@repoman.freebsd.org> imp 2008-01-01 09:37:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) . COPYRIGHT Log: MFC: Happy new year Approved by: re@ Revision Changes Path 1.6.2.2.2.1 +1 -1 src/COPYRIGHT From imp at bsdimp.com Tue Jan 1 01:46:53 2008 From: imp at bsdimp.com (M. Warner Losh) Date: Tue Jan 1 01:46:58 2008 Subject: cvs commit: src/sys/netinet sctp_bsd_addr.c In-Reply-To: <20080101161858.A10345@delplex.bde.org> References: <200712311219.08286.jhb@freebsd.org> <20071231.203720.1306324107.imp@bsdimp.com> <20080101161858.A10345@delplex.bde.org> Message-ID: <20080101.024546.1079618522.imp@bsdimp.com> In message: <20080101161858.A10345@delplex.bde.org> Bruce Evans writes: : On Mon, 31 Dec 2007, M. Warner Losh wrote: : : > In message: <200712311219.08286.jhb@freebsd.org> : > John Baldwin writes: : : > : The more correct fix though is to do a 'sched_prio()' at the start of the : > : thread's main loop to set the priority and then not adjust it via msleep(). : > : Kernel threads really should never pass a priority to msleep() but always '0' : > : (which means "don't change my priority"). : > : > Not PZERO? When should one use PZERO and when should one use a bare : > '0'? Can this information be added to the man page? : : PZERO is compatibility cruft which should never be used. Just a few : places in kern still use it to invent a priority when no suitable : priority (like PSOCK or PRIBIO) is already #defined. It isn't clear : where these invented priorities are suitable. Do we want to document the other Pxxxx priorities? : Otherwise, PZERO has a completely different meaning from either priority : 0 (maximal) or the bare 0 arg to msleep. It means some middle priority, : or the bias from priority 0 to get to that middle priority, so that : after subtracting it, 0 becomes the middle priority. The bare 0 is : actualy priority 0 (maximal) overloaded to mean "don't change the : priority". This overloading doesn't lose anything except clarity since : nothing is permitted to wake up at maximal priority after a sleep. : (Maximal priority is reserved for realtime priority ithreads and even : much lower priority ithreads are not permitted to sleep, and non-interrupt : threads aren't permitted to run at ithread priorities except temporarily : for priority propagation.) So would the following be a reasonable change to sleep.9? Index: sleep.9 =================================================================== RCS file: /home/ncvs/src/share/man/man9/sleep.9,v retrieving revision 1.61 diff -u -r1.61 sleep.9 --- sleep.9 30 Mar 2007 18:07:26 -0000 1.61 +++ sleep.9 1 Jan 2008 09:44:01 -0000 @@ -93,6 +93,10 @@ runnable with the specified .Fa priority when it resumes. +.Dv PZERO +should never be used, as it is for compatibility only. +A new priority of 0 means to use the thread's current priority when +it is made runnable again. If .Fa priority includes the Warner From imp at FreeBSD.org Tue Jan 1 02:04:11 2008 From: imp at FreeBSD.org (Warner Losh) Date: Tue Jan 1 02:04:13 2008 Subject: cvs commit: src/usr.bin/colldef parse.y scan.l Message-ID: <200801011004.m01A4Aov009378@repoman.freebsd.org> imp 2008-01-01 10:04:10 UTC FreeBSD src repository Modified files: usr.bin/colldef parse.y scan.l Log: follow style(9) more closely and list sys/types.h first after sys/defs.h. Submitted by: max@ Revision Changes Path 1.36 +1 -1 src/usr.bin/colldef/parse.y 1.21 +1 -1 src/usr.bin/colldef/scan.l From weongyo at FreeBSD.org Tue Jan 1 02:25:01 2008 From: weongyo at FreeBSD.org (Weongyo Jeong) Date: Tue Jan 1 02:25:04 2008 Subject: cvs commit: src/share/misc committers-src.dot Message-ID: <200801011025.m01AP1BY017414@repoman.freebsd.org> weongyo 2008-01-01 10:25:01 UTC FreeBSD src repository Modified files: share/misc committers-src.dot Log: Add myself and my mentor Approved by: thompsa (mentor) Revision Changes Path 1.68 +3 -0 src/share/misc/committers-src.dot From weongyo at FreeBSD.org Tue Jan 1 02:29:22 2008 From: weongyo at FreeBSD.org (Weongyo Jeong) Date: Tue Jan 1 02:29:23 2008 Subject: cvs commit: src/usr.bin/calendar/calendars calendar.freebsd Message-ID: <200801011029.m01ATMdv017547@repoman.freebsd.org> weongyo 2008-01-01 10:29:22 UTC FreeBSD src repository Modified files: usr.bin/calendar/calendars calendar.freebsd Log: Add my birthday to the calendar. Approved by: thompsa (mentor) Revision Changes Path 1.223 +1 -0 src/usr.bin/calendar/calendars/calendar.freebsd From danfe at FreeBSD.org Tue Jan 1 02:42:55 2008 From: danfe at FreeBSD.org (Alexey Dokuchaev) Date: Tue Jan 1 02:42:57 2008 Subject: cvs commit: src/games/fortune/datfiles gerrold.limerick In-Reply-To: <200712311838.lBVIcXqe082807@repoman.freebsd.org> References: <200712311838.lBVIcXqe082807@repoman.freebsd.org> Message-ID: <20080101104254.GB73979@FreeBSD.org> On Mon, Dec 31, 2007 at 06:38:32PM +0000, Doug Barton wrote: > dougb 2007-12-31 18:38:32 UTC > > FreeBSD src repository > > Modified files: > games/fortune/datfiles gerrold.limerick > Log: > Fix a few small typos, and remove one duplicate. > > I'm intentionally not sorting this file since it won't be added to. ^^^^^^^^^^^^^^^^^^^^^^^^^^ Not quite sure what you've meant by this. Can you elaborate, please? Thanks. ./danfe From Alexander at Leidinger.net Tue Jan 1 03:21:56 2008 From: Alexander at Leidinger.net (Alexander Leidinger) Date: Tue Jan 1 03:22:02 2008 Subject: cvs commit: src/lib/libarchive Makefile archive.h.in archive_entry.c archive_entry.h archive_entry_link_resolver.c archive_entry_private.h archive_entry_strmode.c archive_platform.h archive_read.c archive_read_support_compression_none.c archive_read_support_format_all.c ... In-Reply-To: <20080101.023143.-160243128.imp@bsdimp.com> References: <20071231001554.GB987@zaphod.nitro.dk> <20071231.203352.-165197022.imp@bsdimp.com> <4779D924.8020708@freebsd.org> <20080101.023143.-160243128.imp@bsdimp.com> Message-ID: <20080101121521.679e50b1@deskjail> Quoting "M. Warner Losh" (Tue, 01 Jan 2008 02:31:43 -0700 (MST)): > In message: <4779D924.8020708@freebsd.org> > Tim Kientzle writes: > : M. Warner Losh wrote: > : > In message: <20071231001554.GB987@zaphod.nitro.dk> > : > "Simon L. Nielsen" writes: > : > : > * New read support: mtree format > : > : > : > : This sounds interesting but I can't really figure out what it > : > : does... ? :) (and I couldn't find any mention in the updated manual > : > : pages.) > : > > : > Any chance our 'install' tools can be made to copy the files w/o the > : > right permissions and 'log' the right stuff to an mtree formatted > : > file? That would make building a distribution as a mere mortal > : > possible... > : > : Yep. ;-) That's a major motivation of this work. > : In fact, you don't even need to copy the files > : anywhere. The approach I'm considering would > : have "make buildworld" write out entries of this > : form during the build: > : > : /bin/ls uid=0 mode=0555 contents=/usr/obj/usr/src/bin/ls > : > : Then "make installworld" becomes essentially just: > : > : tar -xUvf world.mtree -C ${DESTDIR} > : > : or you can create a distribution tarball with: > : > : tar -czf world.tgz @world.mtree > > I mostly like this idea, save for one problem: install will strip the > symbols from /usr/obj/usr/src/bin/ls before installing it into > $DESTDIR/bin/ls. > > : In particular, I like that this approach uses exactly > : the same machinery for local installs or distribution > : building, varying only in the very last step. > : > : The code I just committed to -CURRENT is sufficient to > : begin experimenting with this approach; you just need > : to be careful to include "#mtree" as the first line > : (to please libarchive's auto-format detection). > : The use of full pathnames in mtree files is another > : idea I copied from the NetBSD folks; I've documented > : this as "mtree v2" in the mtree.5 manpage. > : > : There are still a lot of details to work out, but I > : hope this is sufficient for someone else to begin > : experimenting with the next step, which is figuring out > : the appropriate ways to change our distribution build. > > Yes. Any ideas how long the experimentation will last? Do you want an entry for this on the ideas list page? If yes, could you please come up with a suitable text (if you also do the markup, just go ahead an commit it, else I can do the markup and the commit). Bye, Alexander. -- Is truth not truth for all? -- Natira, "For the World is Hollow and I have Touched the Sky", stardate 5476.4. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 From rrs at cisco.com Tue Jan 1 04:22:09 2008 From: rrs at cisco.com (Randall Stewart) Date: Tue Jan 1 04:22:15 2008 Subject: cvs commit: src/sys/netinet sctp_bsd_addr.c In-Reply-To: <20080101.024546.1079618522.imp@bsdimp.com> References: <200712311219.08286.jhb@freebsd.org> <20071231.203720.1306324107.imp@bsdimp.com> <20080101161858.A10345@delplex.bde.org> <20080101.024546.1079618522.imp@bsdimp.com> Message-ID: <477A2D6D.9030403@cisco.com> M. Warner Losh wrote: > In message: <20080101161858.A10345@delplex.bde.org> > Bruce Evans writes: > : On Mon, 31 Dec 2007, M. Warner Losh wrote: > : > : > In message: <200712311219.08286.jhb@freebsd.org> > : > John Baldwin writes: > : > : > : The more correct fix though is to do a 'sched_prio()' at the start of the > : > : thread's main loop to set the priority and then not adjust it via msleep(). > : > : Kernel threads really should never pass a priority to msleep() but always '0' > : > : (which means "don't change my priority"). > : > > : > Not PZERO? When should one use PZERO and when should one use a bare > : > '0'? Can this information be added to the man page? > : > : PZERO is compatibility cruft which should never be used. Just a few > : places in kern still use it to invent a priority when no suitable > : priority (like PSOCK or PRIBIO) is already #defined. It isn't clear > : where these invented priorities are suitable. > > Do we want to document the other Pxxxx priorities? > > : Otherwise, PZERO has a completely different meaning from either priority > : 0 (maximal) or the bare 0 arg to msleep. It means some middle priority, > : or the bias from priority 0 to get to that middle priority, so that > : after subtracting it, 0 becomes the middle priority. The bare 0 is > : actualy priority 0 (maximal) overloaded to mean "don't change the > : priority". This overloading doesn't lose anything except clarity since > : nothing is permitted to wake up at maximal priority after a sleep. > : (Maximal priority is reserved for realtime priority ithreads and even > : much lower priority ithreads are not permitted to sleep, and non-interrupt > : threads aren't permitted to run at ithread priorities except temporarily > : for priority propagation.) > > So would the following be a reasonable change to sleep.9? > > Index: sleep.9 > =================================================================== > RCS file: /home/ncvs/src/share/man/man9/sleep.9,v > retrieving revision 1.61 > diff -u -r1.61 sleep.9 > --- sleep.9 30 Mar 2007 18:07:26 -0000 1.61 > +++ sleep.9 1 Jan 2008 09:44:01 -0000 > @@ -93,6 +93,10 @@ > runnable with the specified > .Fa priority > when it resumes. > +.Dv PZERO > +should never be used, as it is for compatibility only. > +A new priority of 0 means to use the thread's current priority when > +it is made runnable again. > If > .Fa priority > includes the > > Warner > That sure would have been nice to read in the manual page .. I would have not changed this at all if I would have had that to read :-( I was pinged on xchat over an issue where the sctp worker thread was hanging... and in the process I was told that 0 was max priority.. which really concerned me... 0 having a special meaning of.. "don't change my priority" means the old code was fine :-0 Not that having a mid-range lower priority is a bad thing for this task... R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 803-317-4952 (cell) From imp at bsdimp.com Tue Jan 1 09:50:41 2008 From: imp at bsdimp.com (M. Warner Losh) Date: Tue Jan 1 09:50:48 2008 Subject: cvs commit: src/sys/netinet sctp_bsd_addr.c In-Reply-To: <477A2D6D.9030403@cisco.com> References: <20080101161858.A10345@delplex.bde.org> <20080101.024546.1079618522.imp@bsdimp.com> <477A2D6D.9030403@cisco.com> Message-ID: <20080101.104934.1346822828.imp@bsdimp.com> In message: <477A2D6D.9030403@cisco.com> Randall Stewart writes: : M. Warner Losh wrote: : > In message: <20080101161858.A10345@delplex.bde.org> : > Bruce Evans writes: : > : On Mon, 31 Dec 2007, M. Warner Losh wrote: : > : : > : > In message: <200712311219.08286.jhb@freebsd.org> : > : > John Baldwin writes: : > : : > : > : The more correct fix though is to do a 'sched_prio()' at the start of the : > : > : thread's main loop to set the priority and then not adjust it via msleep(). : > : > : Kernel threads really should never pass a priority to msleep() but always '0' : > : > : (which means "don't change my priority"). : > : > : > : > Not PZERO? When should one use PZERO and when should one use a bare : > : > '0'? Can this information be added to the man page? : > : : > : PZERO is compatibility cruft which should never be used. Just a few : > : places in kern still use it to invent a priority when no suitable : > : priority (like PSOCK or PRIBIO) is already #defined. It isn't clear : > : where these invented priorities are suitable. : > : > Do we want to document the other Pxxxx priorities? : > : > : Otherwise, PZERO has a completely different meaning from either priority : > : 0 (maximal) or the bare 0 arg to msleep. It means some middle priority, : > : or the bias from priority 0 to get to that middle priority, so that : > : after subtracting it, 0 becomes the middle priority. The bare 0 is : > : actualy priority 0 (maximal) overloaded to mean "don't change the : > : priority". This overloading doesn't lose anything except clarity since : > : nothing is permitted to wake up at maximal priority after a sleep. : > : (Maximal priority is reserved for realtime priority ithreads and even : > : much lower priority ithreads are not permitted to sleep, and non-interrupt : > : threads aren't permitted to run at ithread priorities except temporarily : > : for priority propagation.) : > : > So would the following be a reasonable change to sleep.9? : > : > Index: sleep.9 : > =================================================================== : > RCS file: /home/ncvs/src/share/man/man9/sleep.9,v : > retrieving revision 1.61 : > diff -u -r1.61 sleep.9 : > --- sleep.9 30 Mar 2007 18:07:26 -0000 1.61 : > +++ sleep.9 1 Jan 2008 09:44:01 -0000 : > @@ -93,6 +93,10 @@ : > runnable with the specified : > .Fa priority : > when it resumes. : > +.Dv PZERO : > +should never be used, as it is for compatibility only. : > +A new priority of 0 means to use the thread's current priority when : > +it is made runnable again. : > If : > .Fa priority : > includes the : > : > Warner : > : That sure would have been nice to read in the manual page .. I would : have not changed this at all if I would have had that to read :-( : : I was pinged on xchat over an issue where the sctp worker thread : was hanging... and in the process I was told that 0 was max : priority.. which really concerned me... 0 having a special : meaning of.. "don't change my priority" means the old code : was fine :-0 : : Not that having a mid-range lower priority is a bad thing : for this task... I had someone point out that I wasn't using PZERO in the code I wrote at work, so I went through and changed all the drivers there to use PZERO always. The fact it is compatibility shimming wasn't clear at all, hence my desire to document it :0 Warner From des at des.no Tue Jan 1 11:49:48 2008 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Tue Jan 1 11:49:52 2008 Subject: cvs commit: src/games/fortune/datfiles gerrold.limerick In-Reply-To: <20080101104254.GB73979@FreeBSD.org> (Alexey Dokuchaev's message of "Tue\, 1 Jan 2008 10\:42\:54 +0000") References: <200712311838.lBVIcXqe082807@repoman.freebsd.org> <20080101104254.GB73979@FreeBSD.org> Message-ID: <86hchxs4vh.fsf@ds4.des.no> Alexey Dokuchaev writes: > On Mon, Dec 31, 2007 at 06:38:32PM +0000, Doug Barton wrote: > > Log: > > Fix a few small typos, and remove one duplicate. > > > > I'm intentionally not sorting this file since it won't be added to. > Not quite sure what you've meant by this. Can you elaborate, please? The file in question contains limericks by David Gerrold, committed seven years ago with the author's permission. Additions to this file would necessarily be more limericks by the same author, whose permission would again have to be sought. Therefore, future additions to this file are not likely. Since the benefit of sorting a fortune file is to make additions easier, doing so in this case would cause repo churn for no practical benefit, so Doug decided not to sort it. Unfortunately, the bandwidth saved by his decision was probably more than offset by that consumed by this thread. DES -- Dag-Erling Sm?rgrav - des@des.no From alc at FreeBSD.org Tue Jan 1 12:36:05 2008 From: alc at FreeBSD.org (Alan Cox) Date: Tue Jan 1 12:36:08 2008 Subject: cvs commit: src/sys/vm pmap.h Message-ID: <200801012036.m01Ka5qP075605@repoman.freebsd.org> alc 2008-01-01 20:36:05 UTC FreeBSD src repository Modified files: sys/vm pmap.h Log: Correct a style error that was introduced in revision 1.77. Revision Changes Path 1.82 +1 -1 src/sys/vm/pmap.h From imp at FreeBSD.org Tue Jan 1 13:37:10 2008 From: imp at FreeBSD.org (Warner Losh) Date: Tue Jan 1 13:37:12 2008 Subject: cvs commit: src/share/man/man4 ed.4 Message-ID: <200801012137.m01LbAfa023553@repoman.freebsd.org> imp 2008-01-01 21:37:09 UTC FreeBSD src repository Modified files: share/man/man4 ed.4 Log: Sync to the new PCI device IDs that I added to if_ed_pci.c. Bump date. Revision Changes Path 1.54 +8 -2 src/share/man/man4/ed.4 From imp at FreeBSD.org Tue Jan 1 13:41:39 2008 From: imp at FreeBSD.org (Warner Losh) Date: Tue Jan 1 13:41:41 2008 Subject: cvs commit: src/share/man/man4 ed.4 Message-ID: <200801012141.m01LfdsU024256@repoman.freebsd.org> imp 2008-01-01 21:41:39 UTC FreeBSD src repository Modified files: share/man/man4 ed.4 Log: Forgot to mention RLT80x9 support that was added some time ago. Revision Changes Path 1.55 +3 -0 src/share/man/man4/ed.4 From kientzle at FreeBSD.org Tue Jan 1 14:20:12 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Tue Jan 1 14:20:14 2008 Subject: cvs commit: CVSROOT exclude Message-ID: <200801012220.m01MKCrE042428@repoman.freebsd.org> kientzle 2008-01-01 22:20:11 UTC FreeBSD src repository Modified files: . exclude Log: The .uu files in libarchive/test don't require $FreeBSD$ keywords. Revision Changes Path 1.152 +1 -0 CVSROOT/exclude From kientzle at FreeBSD.org Tue Jan 1 14:28:06 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Tue Jan 1 14:28:07 2008 Subject: cvs commit: src/lib/libarchive/test Makefile README main.c read_open_memory.c test.h test_compat_gtar.c test_compat_gtar_1.tgz.uu test_compat_zip.c test_compat_zip_1.zip.uu test_empty_write.c test_entry_strmode.c test_read_format_cpio_odc.c ... Message-ID: <200801012228.m01MS5Am050529@repoman.freebsd.org> kientzle 2008-01-01 22:28:05 UTC FreeBSD src repository Modified files: lib/libarchive/test Makefile README main.c read_open_memory.c test.h test_read_format_cpio_odc.c test_read_format_gtar_sparse.c test_read_format_isorr_bz2.c test_read_format_zip.c test_read_pax_truncated.c test_tar_filenames.c test_write_disk_perms.c test_write_format_cpio.c Added files: lib/libarchive/test test_compat_gtar.c test_compat_gtar_1.tgz.uu test_compat_zip.c test_compat_zip_1.zip.uu test_empty_write.c test_entry_strmode.c test_read_format_gtar_sparse_1_13.tgz.uu test_read_format_gtar_sparse_1_17.tgz.uu test_read_format_gtar_sparse_1_17_posix00.tgz.uu test_read_format_gtar_sparse_1_17_posix01.tgz.uu test_read_format_gtar_sparse_1_17_posix10.tgz.uu test_read_format_gtar_sparse_1_17_posix10_modified.tar.uu test_read_format_mtree.c test_tar_large.c test_write_format_cpio_newc.c test_write_format_cpio_odc.c Log: Extensive improvements to the libarchive_test test program that exercises and verifies the libarchive APIs: * Improved error reporting; hexdumps are now provided for many file/memory content differences. * Overall status more clearly counts "tests" and "assertions" * Reference files can now be stored on disk instead of having to be compiled into the test program itself. A couple of tests have been converted to this more natural structure. * Several memory leaks corrected so that leaks within libarchive itself can be more easily detected and diagnosed. * New test: GNU tar compatibility * New test: Zip compatibility * New test: Zero-byte writes to a compressed archive entry * New test: archive_entry_strmode() format verification * New test: mtree reader * New test: write/read of large (2G - 1TB) entries to tar archives (thanks to recent performance work, this test only requires a few seconds) * New test: detailed format verification of cpio odc and newc writers * Many minor additions/improvements to existing tests as well. Revision Changes Path 1.12 +62 -16 src/lib/libarchive/test/Makefile 1.3 +10 -2 src/lib/libarchive/test/README 1.9 +353 -54 src/lib/libarchive/test/main.c 1.2 +1 -1 src/lib/libarchive/test/read_open_memory.c 1.7 +64 -40 src/lib/libarchive/test/test.h 1.1 +110 -0 src/lib/libarchive/test/test_compat_gtar.c (new) 1.1 +9 -0 src/lib/libarchive/test/test_compat_gtar_1.tgz.uu (new) 1.1 +69 -0 src/lib/libarchive/test/test_compat_zip.c (new) 1.1 +14 -0 src/lib/libarchive/test/test_compat_zip_1.zip.uu (new) 1.1 +118 -0 src/lib/libarchive/test/test_empty_write.c (new) 1.1 +48 -0 src/lib/libarchive/test/test_entry_strmode.c (new) 1.2 +1 -1 src/lib/libarchive/test/test_read_format_cpio_odc.c 1.7 +47 -652 src/lib/libarchive/test/test_read_format_gtar_sparse.c 1.1 +26 -0 src/lib/libarchive/test/test_read_format_gtar_sparse_1_13.tgz.uu (new) 1.1 +26 -0 src/lib/libarchive/test/test_read_format_gtar_sparse_1_17.tgz.uu (new) 1.1 +29 -0 src/lib/libarchive/test/test_read_format_gtar_sparse_1_17_posix00.tgz.uu (new) 1.1 +27 -0 src/lib/libarchive/test/test_read_format_gtar_sparse_1_17_posix01.tgz.uu (new) 1.1 +27 -0 src/lib/libarchive/test/test_read_format_gtar_sparse_1_17_posix10.tgz.uu (new) 1.1 +1369 -0 src/lib/libarchive/test/test_read_format_gtar_sparse_1_17_posix10_modified.tar.uu (new) 1.3 +3 -0 src/lib/libarchive/test/test_read_format_isorr_bz2.c 1.1 +113 -0 src/lib/libarchive/test/test_read_format_mtree.c (new) 1.3 +6 -0 src/lib/libarchive/test/test_read_format_zip.c 1.2 +2 -2 src/lib/libarchive/test/test_read_pax_truncated.c 1.8 +1 -1 src/lib/libarchive/test/test_tar_filenames.c 1.1 +309 -0 src/lib/libarchive/test/test_tar_large.c (new) 1.8 +19 -14 src/lib/libarchive/test/test_write_disk_perms.c 1.4 +63 -7 src/lib/libarchive/test/test_write_format_cpio.c 1.1 +172 -0 src/lib/libarchive/test/test_write_format_cpio_newc.c (new) 1.1 +224 -0 src/lib/libarchive/test/test_write_format_cpio_odc.c (new) From imp at FreeBSD.org Tue Jan 1 14:29:22 2008 From: imp at FreeBSD.org (Warner Losh) Date: Tue Jan 1 14:29:24 2008 Subject: cvs commit: src/share/man/man4/man4.i386 ep.4 Message-ID: <200801012229.m01MTMfS051206@repoman.freebsd.org> imp 2008-01-01 22:29:22 UTC FreeBSD src repository Modified files: share/man/man4/man4.i386 ep.4 Log: Minor nits. Add xr to sn. Revision Changes Path 1.46 +3 -2 src/share/man/man4/man4.i386/ep.4 From kientzle at freebsd.org Tue Jan 1 14:31:28 2008 From: kientzle at freebsd.org (Tim Kientzle) Date: Tue Jan 1 14:31:35 2008 Subject: cvs commit: src/lib/libarchive/test Makefile README main.c read_open_memory.c test.h test_compat_gtar.c test_compat_gtar_1.tgz.uu test_compat_zip.c test_compat_zip_1.zip.uu test_empty_write.c test_entry_strmode.c test_read_format_cpio_odc.c ... In-Reply-To: <200801012228.m01MS5Am050529@repoman.freebsd.org> References: <200801012228.m01MS5Am050529@repoman.freebsd.org> Message-ID: <477ABF3E.7060900@freebsd.org> Tim Kientzle wrote: > kientzle 2008-01-01 22:28:05 UTC > > Log: > Extensive improvements to the libarchive_test test program that > exercises and verifies the libarchive APIs ... These tests have been run on i386 and amd64 extensively; if anyone has a chance to "make test" in this directory on other platforms, I'd appreciate reports. (I'm especially worried about ARM; GCC's odd packing on ARM could break some of my coding assumptions.) Tim Kientzle From brde at optusnet.com.au Tue Jan 1 15:39:42 2008 From: brde at optusnet.com.au (Bruce Evans) Date: Tue Jan 1 15:39:50 2008 Subject: cvs commit: src/sys/netinet sctp_bsd_addr.c In-Reply-To: <20080101.024546.1079618522.imp@bsdimp.com> References: <200712311219.08286.jhb@freebsd.org> <20071231.203720.1306324107.imp@bsdimp.com> <20080101161858.A10345@delplex.bde.org> <20080101.024546.1079618522.imp@bsdimp.com> Message-ID: <20080102092953.J12725@delplex.bde.org> On Tue, 1 Jan 2008, M. Warner Losh wrote: > In message: <20080101161858.A10345@delplex.bde.org> > Bruce Evans writes: > : PZERO is compatibility cruft which should never be used. Just a few > ... > > Do we want to document the other Pxxxx priorities? Maybe, but not in sleep.9. I just learn about them from *.[ch]. > : Otherwise, PZERO has a completely different meaning from either priority > : 0 (maximal) or the bare 0 arg to msleep. It means some middle priority, > ... > So would the following be a reasonable change to sleep.9? > > Index: sleep.9 > =================================================================== > RCS file: /home/ncvs/src/share/man/man9/sleep.9,v > retrieving revision 1.61 > diff -u -r1.61 sleep.9 > --- sleep.9 30 Mar 2007 18:07:26 -0000 1.61 > +++ sleep.9 1 Jan 2008 09:44:01 -0000 > @@ -93,6 +93,10 @@ > runnable with the specified > .Fa priority > when it resumes. > +.Dv PZERO > +should never be used, as it is for compatibility only. > +A new priority of 0 means to use the thread's current priority when > +it is made runnable again. > If > .Fa priority > includes the Not quite. The sentence about PZERO doesn't belong here. The 2 sentences bfore the PZERO sentence already completely document the specialness of priority 0: % .Pp % The parameter % .Fa priority % specifies a new priority for the thread as well as some optional flags. % If the new priority is not 0, % then the thread will be made % runnable with the specified % .Fa priority % when it resumes. If this is not clear, then I think it should be made clearer by rewording it and not by tacking on a modifying clause. My attempt: %%% .Pp The parameter .Fa priority encodes the new priority for the thread and some optional flags. The thread will be made runnable with the new priority when it resumes. The new priority is determined from .Fa priority by first masking out the flags using the .Dv PRIMASK mask. If the the result of this is nonzero, then it gives the new priority; otherwise, the new priority is same as the current priority. %%% BTW, grep shows that PZERO is only documented in spl.9 of all places, only in examples using the even-more-deprecated tsleep(), while sleep.9 doesn't have any examples. Bruce From bmah at FreeBSD.org Tue Jan 1 15:58:19 2008 From: bmah at FreeBSD.org (Bruce A. Mah) Date: Tue Jan 1 15:58:21 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml Message-ID: <200801012358.m01NwJgm086806@repoman.freebsd.org> bmah 2008-01-01 23:58:19 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes article.sgml Log: New release notes: ddb(4) capture, ddb(4) scripting, textdump(4), ncurses 5.6-20071222, tzdata2007k. Bump copyright date while here. Revision Changes Path 1.1078 +29 -1 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml From kientzle at FreeBSD.org Tue Jan 1 16:19:50 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Tue Jan 1 16:19:52 2008 Subject: cvs commit: src/usr.bin/tar COPYING Message-ID: <200801020019.m020Jnol095471@repoman.freebsd.org> kientzle 2008-01-02 00:19:49 UTC FreeBSD src repository Modified files: usr.bin/tar COPYING Log: Include Guido's copyright for the fnmatch() code I cribbed from. (It's in the C source, just wasn't in the COPYING file until now.) Revision Changes Path 1.3 +36 -1 src/usr.bin/tar/COPYING From kientzle at FreeBSD.org Tue Jan 1 16:21:27 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Tue Jan 1 16:21:29 2008 Subject: cvs commit: src/usr.bin/tar bsdtar.h read.c util.c Message-ID: <200801020021.m020LR8L096170@repoman.freebsd.org> kientzle 2008-01-02 00:21:27 UTC FreeBSD src repository Modified files: usr.bin/tar bsdtar.h read.c util.c Log: Use archive_entry_strmode() instead of a local bsdtar_strmode(). (This does a couple of things that the standard library's strmode() doesn't; it proved useful in bsdcpio as well, so I pushed it down into libarchive.) Revision Changes Path 1.29 +0 -1 src/usr.bin/tar/bsdtar.h 1.35 +3 -2 src/usr.bin/tar/read.c 1.18 +0 -50 src/usr.bin/tar/util.c From kientzle at FreeBSD.org Tue Jan 1 16:23:01 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Tue Jan 1 16:23:03 2008 Subject: cvs commit: src/usr.bin/tar bsdtar_platform.h Message-ID: <200801020023.m020N0Fh096950@repoman.freebsd.org> kientzle 2008-01-02 00:23:00 UTC FreeBSD src repository Modified files: usr.bin/tar bsdtar_platform.h Log: Include a suitable stub definition of __FBSDID() for non-FreeBSD platforms. Revision Changes Path 1.25 +2 -1 src/usr.bin/tar/bsdtar_platform.h From kientzle at FreeBSD.org Tue Jan 1 16:24:10 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Tue Jan 1 16:24:11 2008 Subject: cvs commit: src/usr.bin/tar bsdtar.1 Message-ID: <200801020024.m020OA2c098024@repoman.freebsd.org> kientzle 2008-01-02 00:24:10 UTC FreeBSD src repository Modified files: usr.bin/tar bsdtar.1 Log: Fill in the approximate date when tar(1) first appeared. Revision Changes Path 1.36 +1 -1 src/usr.bin/tar/bsdtar.1 From kientzle at FreeBSD.org Tue Jan 1 16:27:15 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Tue Jan 1 16:27:16 2008 Subject: cvs commit: src/usr.bin/tar Makefile bsdtar.c config_freebsd.h Message-ID: <200801020027.m020REoS099213@repoman.freebsd.org> kientzle 2008-01-02 00:27:14 UTC FreeBSD src repository Modified files: usr.bin/tar Makefile bsdtar.c config_freebsd.h Log: A couple of miscellaneous fixes: * prototypes for optarg/optind on platforms that don't already have them * Disambiguate version number macros * Remove unnecessary PACKAGE_NAME macro * Hook for forthcoming bsdtar test suite * Sync version number up with the portable distribution Revision Changes Path 1.33 +5 -2 src/usr.bin/tar/Makefile 1.78 +11 -1 src/usr.bin/tar/bsdtar.c 1.2 +2 -1 src/usr.bin/tar/config_freebsd.h From kientzle at FreeBSD.org Tue Jan 1 16:28:44 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Tue Jan 1 16:28:47 2008 Subject: cvs commit: src/usr.bin/tar/test config.sh test-acl.sh test-basic.sh test-deep-dir.sh test-flags.sh test-nodump.sh test-overwrite.sh test-utf8.sh Message-ID: <200801020028.m020SiHg099287@repoman.freebsd.org> kientzle 2008-01-02 00:28:44 UTC FreeBSD src repository Removed files: usr.bin/tar/test config.sh test-acl.sh test-basic.sh test-deep-dir.sh test-flags.sh test-nodump.sh test-overwrite.sh test-utf8.sh Log: Remove the old bsdtar test scripts; something much better is almost ready to commit. Revision Changes Path 1.3 +0 -74 src/usr.bin/tar/test/config.sh (dead) 1.2 +0 -76 src/usr.bin/tar/test/test-acl.sh (dead) 1.6 +0 -432 src/usr.bin/tar/test/test-basic.sh (dead) 1.2 +0 -60 src/usr.bin/tar/test/test-deep-dir.sh (dead) 1.2 +0 -74 src/usr.bin/tar/test/test-flags.sh (dead) 1.2 +0 -52 src/usr.bin/tar/test/test-nodump.sh (dead) 1.2 +0 -51 src/usr.bin/tar/test/test-overwrite.sh (dead) 1.2 +0 -40 src/usr.bin/tar/test/test-utf8.sh (dead) From obrien at FreeBSD.org Tue Jan 1 17:19:18 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Tue Jan 1 17:19:20 2008 Subject: cvs commit: src/sys/ufs/ffs ffs_vnops.c Message-ID: <200801020119.m021JHrI027984@repoman.freebsd.org> obrien 2008-01-02 01:19:17 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_vnops.c Log: style(9) Revision Changes Path 1.175 +17 -17 src/sys/ufs/ffs/ffs_vnops.c From obrien at FreeBSD.org Tue Jan 1 17:45:32 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Tue Jan 1 17:45:34 2008 Subject: cvs commit: src/sys/cam cam_xpt.c Message-ID: <200801020145.m021jVck038228@repoman.freebsd.org> obrien 2008-01-02 01:45:31 UTC FreeBSD src repository Modified files: sys/cam cam_xpt.c Log: style(9) Revision Changes Path 1.193 +73 -73 src/sys/cam/cam_xpt.c From scottl at samsco.org Tue Jan 1 17:59:25 2008 From: scottl at samsco.org (Scott Long) Date: Tue Jan 1 17:59:29 2008 Subject: cvs commit: src/sys/cam cam_xpt.c In-Reply-To: <200801020145.m021jVck038228@repoman.freebsd.org> References: <200801020145.m021jVck038228@repoman.freebsd.org> Message-ID: <477AEFF9.7000804@samsco.org> David E. O'Brien wrote: > obrien 2008-01-02 01:45:31 UTC > > FreeBSD src repository > > Modified files: > sys/cam cam_xpt.c > Log: > style(9) > > Revision Changes Path > 1.193 +73 -73 src/sys/cam/cam_xpt.c Thanks for making CAM merges harder now than they were before. A normal, well adjusted team player would have asked the person/people working in this area if it was ok to do something like this. What a circus. I await your indignant rules lawyering. Scott From alc at FreeBSD.org Tue Jan 1 20:43:48 2008 From: alc at FreeBSD.org (Alan Cox) Date: Tue Jan 1 20:43:50 2008 Subject: cvs commit: src/sys/vm vm_page.c Message-ID: <200801020443.m024hmGw015649@repoman.freebsd.org> alc 2008-01-02 04:43:47 UTC FreeBSD src repository Modified files: sys/vm vm_page.c Log: Defer setting either PG_CACHED or PG_FREE until after the free page queues lock is acquired. Otherwise, the state of a reservation's pages' flags and its population count can be inconsistent. That could result in a page being freed twice. Reported by: kris Revision Changes Path 1.366 +3 -3 src/sys/vm/vm_page.c From obrien at FreeBSD.org Tue Jan 1 23:21:08 2008 From: obrien at FreeBSD.org (David O'Brien) Date: Tue Jan 1 23:21:13 2008 Subject: cvs commit: CVSROOT exclude In-Reply-To: <200801012220.m01MKCrE042428@repoman.freebsd.org> References: <200801012220.m01MKCrE042428@repoman.freebsd.org> Message-ID: <20080102072108.GA3141@dragon.NUXI.org> On Tue, Jan 01, 2008 at 10:20:11PM +0000, Tim Kientzle wrote: > kientzle 2008-01-01 22:20:11 UTC > Log: > The .uu files in libarchive/test don't require $FreeBSD$ keywords. However, the $FreeBSD$ in uuencoded files do not cause a problem. Since having the keyword makes it easier to see what revision of the file this is - would you consider adding them to the .uu files? Just about all the other .uu files in the tree have $FreeBSD$ in them. -- -- David (obrien@FreeBSD.org) From imp at bsdimp.com Tue Jan 1 23:29:27 2008 From: imp at bsdimp.com (M. Warner Losh) Date: Tue Jan 1 23:29:33 2008 Subject: cvs commit: src/sys/cam cam_xpt.c In-Reply-To: <477AEFF9.7000804@samsco.org> References: <200801020145.m021jVck038228@repoman.freebsd.org> <477AEFF9.7000804@samsco.org> Message-ID: <20080102.002807.-1183026224.imp@bsdimp.com> In message: <477AEFF9.7000804@samsco.org> Scott Long writes: : David E. O'Brien wrote: : > obrien 2008-01-02 01:45:31 UTC : > : > FreeBSD src repository : > : > Modified files: : > sys/cam cam_xpt.c : > Log: : > style(9) : > : > Revision Changes Path : > 1.193 +73 -73 src/sys/cam/cam_xpt.c : : Thanks for making CAM merges harder now than they were before. A : normal, well adjusted team player would have asked the person/people : working in this area if it was ok to do something like this. What a : circus. I await your indignant rules lawyering. Just back it out. cvs update -j 1.193 -j 1.192 -kk cam_xpt.c cvs commit -m"Backout style(9), there's locking changes in flight..." then merging your changes will easy to merge. Sure it tosses David's work, but locking changes are much more important than style changes or pissing contests. Warner From obrien at FreeBSD.org Wed Jan 2 00:13:54 2008 From: obrien at FreeBSD.org (David O'Brien) Date: Wed Jan 2 00:14:00 2008 Subject: cvs commit: src/sys/cam cam_xpt.c In-Reply-To: <477AEFF9.7000804@samsco.org> References: <200801020145.m021jVck038228@repoman.freebsd.org> <477AEFF9.7000804@samsco.org> Message-ID: <20080102081353.GE3141@dragon.NUXI.org> On Tue, Jan 01, 2008 at 06:59:21PM -0700, Scott Long wrote: > David E. O'Brien wrote: >> obrien 2008-01-02 01:45:31 UTC >> FreeBSD src repository >> Modified files: >> sys/cam cam_xpt.c Log: >> style(9) >> Revision Changes Path >> 1.193 +73 -73 src/sys/cam/cam_xpt.c > > Thanks for making CAM merges harder now than they were before. Have you done a 'cvs update' in your sources to see if they actually conflict? SURELY it is not beyond you to :%s/[]*$//g in vi? (I'm sure Emacs can do do this just as easily, if you're that kind of guy). > A normal, well adjusted team player Thank you for the personal attack - I guess I get the prize for the first attack from you of the new year. > would have asked the person/people working in this area if it was ok to > do something like this. Lets see - this file had 5 commits in the past 6 months. You you did the last one. It was revision 1.192 on 2007/12/16 - a one line addition. The previous commit you made was revision 1.189 on 2007/06/17 - a change of +3 -2. So that does not indicate you're in the middle of some major maintenance here. Between those two commits were two other changes - one by julian and one by imp. The commit before your 1.189 was a one liner by dwmalone. Neither of these commits had "Approved by: scottl" on them. I wonder if you complained to them about committing without running it by you first. > What a circus. I await your indignant rules lawyering. Personally I think you're just bitching at me for the F of it - due to some personal need to boost yourself and put down others... -- -- David (obrien@FreeBSD.org) From alc at FreeBSD.org Wed Jan 2 00:54:40 2008 From: alc at FreeBSD.org (Alan Cox) Date: Wed Jan 2 00:54:41 2008 Subject: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c Message-ID: <200801020854.m028seVE031353@repoman.freebsd.org> alc 2008-01-02 08:54:39 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c sys/i386/i386 pmap.c Log: Provide a legitimate pindex to vm_page_alloc() in pmap_growkernel() instead of writing apologetic comments. As it turns out, I need every kernel page table page to have a legitimate pindex to support superpage promotion on kernel memory. Correct a nearby style error: Pointers should be compared to NULL. Revision Changes Path 1.600 +3 -6 src/sys/amd64/amd64/pmap.c 1.603 +2 -5 src/sys/i386/i386/pmap.c From jhb at FreeBSD.org Wed Jan 2 09:09:16 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Wed Jan 2 09:09:18 2008 Subject: cvs commit: src/sys/kern subr_smp.c Message-ID: <200801021709.m02H9GOd050440@repoman.freebsd.org> jhb 2008-01-02 17:09:16 UTC FreeBSD src repository Modified files: sys/kern subr_smp.c Log: A few whitespace fixes. Revision Changes Path 1.203 +11 -12 src/sys/kern/subr_smp.c From jhb at freebsd.org Wed Jan 2 10:05:08 2008 From: jhb at freebsd.org (John Baldwin) Date: Wed Jan 2 10:05:17 2008 Subject: cvs commit: src/sys/netinet sctp_bsd_addr.c In-Reply-To: <20080101.024546.1079618522.imp@bsdimp.com> References: <200712311219.08286.jhb@freebsd.org> <20080101161858.A10345@delplex.bde.org> <20080101.024546.1079618522.imp@bsdimp.com> Message-ID: <200801021217.22195.jhb@freebsd.org> On Tuesday 01 January 2008 04:45:46 am M. Warner Losh wrote: > In message: <20080101161858.A10345@delplex.bde.org> > Bruce Evans writes: > : On Mon, 31 Dec 2007, M. Warner Losh wrote: > : > : > In message: <200712311219.08286.jhb@freebsd.org> > : > John Baldwin writes: > : > : > : The more correct fix though is to do a 'sched_prio()' at the start of the > : > : thread's main loop to set the priority and then not adjust it via msleep(). > : > : Kernel threads really should never pass a priority to msleep() but always '0' > : > : (which means "don't change my priority"). > : > > : > Not PZERO? When should one use PZERO and when should one use a bare > : > '0'? Can this information be added to the man page? > : > : PZERO is compatibility cruft which should never be used. Just a few > : places in kern still use it to invent a priority when no suitable > : priority (like PSOCK or PRIBIO) is already #defined. It isn't clear > : where these invented priorities are suitable. > > Do we want to document the other Pxxxx priorities? Also, PZERO is meant to be a base for userland priorities (threads in userland should be <= PZERO except for real time threads) and is an actual priority value. 0 means "don't change anything." > : Otherwise, PZERO has a completely different meaning from either priority > : 0 (maximal) or the bare 0 arg to msleep. It means some middle priority, > : or the bias from priority 0 to get to that middle priority, so that > : after subtracting it, 0 becomes the middle priority. The bare 0 is > : actualy priority 0 (maximal) overloaded to mean "don't change the > : priority". This overloading doesn't lose anything except clarity since > : nothing is permitted to wake up at maximal priority after a sleep. > : (Maximal priority is reserved for realtime priority ithreads and even > : much lower priority ithreads are not permitted to sleep, and non-interrupt > : threads aren't permitted to run at ithread priorities except temporarily > : for priority propagation.) > > So would the following be a reasonable change to sleep.9? > > Index: sleep.9 > =================================================================== > RCS file: /home/ncvs/src/share/man/man9/sleep.9,v > retrieving revision 1.61 > diff -u -r1.61 sleep.9 > --- sleep.9 30 Mar 2007 18:07:26 -0000 1.61 > +++ sleep.9 1 Jan 2008 09:44:01 -0000 > @@ -93,6 +93,10 @@ > runnable with the specified > .Fa priority > when it resumes. > +.Dv PZERO > +should never be used, as it is for compatibility only. > +A new priority of 0 means to use the thread's current priority when > +it is made runnable again. > If > .Fa priority > includes the The manpage already says that priority 0 doesn't change the priority (look at the first half of the sentence before your new one). I'm not sure PZERO deserves special mention. You could perhaps add a new section after 'DESCRIPTION' that covers the various Pxxx priorities that are often used for *sleep() routines such as PZERO, PSOCK, PVM, etc. -- John Baldwin From obrien at FreeBSD.org Wed Jan 2 10:48:28 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Wed Jan 2 10:48:29 2008 Subject: cvs commit: src/sys/kern kern_tc.c Message-ID: <200801021848.m02ImRp1093748@repoman.freebsd.org> obrien 2008-01-02 18:48:27 UTC FreeBSD src repository Modified files: sys/kern kern_tc.c Log: Note what is too {short,long}. Revision Changes Path 1.179 +2 -2 src/sys/kern/kern_tc.c From phk at FreeBSD.org Wed Jan 2 12:31:15 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Wed Jan 2 12:31:18 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h Message-ID: <200801022031.m02KVEts046726@repoman.freebsd.org> phk 2008-01-02 20:31:14 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.h Log: Follow the current fashion of gratuitously stomping into other peoples code with irrelevant changes[1]: Use bus_{read|write_*() instead of bus_space_{read|write}_*() for purely stylistic reasons. Due to compiler optimizations and inlining, this is for all practical purposes without effect in the compiled code. [1] NB: Approved by: sos Revision Changes Path 1.127 +14 -36 src/sys/dev/ata/ata-all.h From phk at FreeBSD.org Wed Jan 2 12:33:55 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Wed Jan 2 12:33:57 2008 Subject: cvs commit: src/sys/dev/ata ata-disk.c Message-ID: <200801022033.m02KXsWD049168@repoman.freebsd.org> phk 2008-01-02 20:33:54 UTC FreeBSD src repository Modified files: sys/dev/ata ata-disk.c Log: If the disk reports that it support the Compact Flash Association command set, announce BIO_DELETE capability and issue ATA_CFA_ERASE when we get one. Once we issue more BIO_DELETE, this will improve lifetime, and possibly write speed of Flash based devices which have usable flash adaptation layers. For now, about the only usage is the newfs(1) -E flag. Approved by: sos Revision Changes Path 1.206 +9 -0 src/sys/dev/ata/ata-disk.c From nate at root.org Wed Jan 2 12:59:50 2008 From: nate at root.org (Nate Lawson) Date: Wed Jan 2 12:59:58 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h In-Reply-To: <20080102203119.BFF8616A55D@hub.freebsd.org> References: <20080102203119.BFF8616A55D@hub.freebsd.org> Message-ID: <477BFB9D.8070201@root.org> Poul-Henning Kamp wrote: > phk 2008-01-02 20:31:14 UTC > > FreeBSD src repository > > Modified files: > sys/dev/ata ata-all.h > Log: > Follow the current fashion of gratuitously stomping into other > peoples code with irrelevant changes[1]: > > Use bus_{read|write_*() instead of bus_space_{read|write}_*() for > purely stylistic reasons. > > Due to compiler optimizations and inlining, this is for all practical > purposes without effect in the compiled code. Ok, but this still doesn't address the performance loss fixed by this 3-year-old patch: http://lists.freebsd.org/pipermail/freebsd-current/2005-January/044858.html > Revision Changes Path > 1.127 +14 -36 src/sys/dev/ata/ata-all.h > > > Index: src/sys/dev/ata/ata-all.h > diff -u src/sys/dev/ata/ata-all.h:1.126 src/sys/dev/ata/ata-all.h:1.127 > --- src/sys/dev/ata/ata-all.h:1.126 Thu Dec 13 11:47:36 2007 > +++ src/sys/dev/ata/ata-all.h Wed Jan 2 20:31:14 2008 > @@ -579,56 +579,34 @@ > > /* macros to hide busspace uglyness */ > #define ATA_INB(res, offset) \ > - bus_space_read_1(rman_get_bustag((res)), \ > - rman_get_bushandle((res)), (offset)) > + bus_read_1((res), (offset)) -- Nate From phk at phk.freebsd.dk Wed Jan 2 13:15:04 2008 From: phk at phk.freebsd.dk (Poul-Henning Kamp) Date: Wed Jan 2 13:15:07 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h In-Reply-To: Your message of "Wed, 02 Jan 2008 13:01:17 PST." <477BFB9D.8070201@root.org> Message-ID: <1429.1199308501@critter.freebsd.dk> In message <477BFB9D.8070201@root.org>, Nate Lawson writes: >Poul-Henning Kamp wrote: >Ok, but this still doesn't address the performance loss fixed by this >3-year-old patch: I think your patch is wrong because it moves the responsibility for the performance in the wrong direction: We shouldn't have to care about this in every single device driver. When I created bus_{read|write}_* that was mostly to reduce the risk of repetive strain injuries for device driver writers, but it was also an attempt to move the responsibility in the right direction. rman and bus_space was sort of conceived separately, but it is time they realize that they are indeed a couple so everybody don't have to pretend how surprised they are to see them together at this instant. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From nate at root.org Wed Jan 2 13:17:52 2008 From: nate at root.org (Nate Lawson) Date: Wed Jan 2 13:17:56 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h In-Reply-To: <1429.1199308501@critter.freebsd.dk> References: <1429.1199308501@critter.freebsd.dk> Message-ID: <477BFFD6.1080502@root.org> Poul-Henning Kamp wrote: > In message <477BFB9D.8070201@root.org>, Nate Lawson writes: >> Poul-Henning Kamp wrote: > >> Ok, but this still doesn't address the performance loss fixed by this >> 3-year-old patch: > > I think your patch is wrong because it moves the responsibility for > the performance in the wrong direction: We shouldn't have to care > about this in every single device driver. > > When I created bus_{read|write}_* that was mostly to reduce the > risk of repetive strain injuries for device driver writers, but > it was also an attempt to move the responsibility in the right > direction. > > rman and bus_space was sort of conceived separately, but it is > time they realize that they are indeed a couple so everybody don't > have to pretend how surprised they are to see them together at > this instant. I'm happy to see this encapsulated, as long as it gets rid of the unnecessary overhead of what should be merely a structure member dereference. Thanks, -- Nate From obrien at FreeBSD.org Wed Jan 2 15:26:12 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Wed Jan 2 15:26:14 2008 Subject: cvs commit: src/usr.bin/netstat atalk.c bpf.c if.c inet.c inet6.c ipsec.c ipx.c main.c mbuf.c mcast.c mroute.c mroute6.c netgraph.c netstat.h pfkey.c route.c sctp.c unix.c Message-ID: <200801022326.m02NQC7H031951@repoman.freebsd.org> obrien 2008-01-02 23:26:12 UTC FreeBSD src repository Modified files: usr.bin/netstat atalk.c bpf.c if.c inet.c inet6.c ipsec.c ipx.c main.c mbuf.c mcast.c mroute.c mroute6.c netgraph.c netstat.h pfkey.c route.c sctp.c unix.c Log: style(9) + kread is not a boolean, so check it as such + fix $FreeBSD$ Ids + denote copyrights with /*- + misc whitespace changes. Revision Changes Path 1.27 +2 -2 src/usr.bin/netstat/atalk.c 1.10 +5 -3 src/usr.bin/netstat/bpf.c 1.70 +19 -18 src/usr.bin/netstat/if.c 1.80 +35 -35 src/usr.bin/netstat/inet.c 1.30 +57 -57 src/usr.bin/netstat/inet6.c 1.18 +12 -15 src/usr.bin/netstat/ipsec.c 1.28 +7 -7 src/usr.bin/netstat/ipx.c 1.88 +28 -28 src/usr.bin/netstat/main.c 1.54 +2 -2 src/usr.bin/netstat/mbuf.c 1.10 +2 -2 src/usr.bin/netstat/mcast.c 1.31 +4 -4 src/usr.bin/netstat/mroute.c 1.22 +2 -3 src/usr.bin/netstat/mroute6.c 1.14 +3 -3 src/usr.bin/netstat/netgraph.c 1.52 +6 -6 src/usr.bin/netstat/netstat.h 1.6 +9 -12 src/usr.bin/netstat/pfkey.c 1.83 +18 -18 src/usr.bin/netstat/route.c 1.9 +36 -37 src/usr.bin/netstat/sctp.c 1.21 +3 -3 src/usr.bin/netstat/unix.c From sobomax at FreeBSD.org Wed Jan 2 15:55:50 2008 From: sobomax at FreeBSD.org (Maxim Sobolev) Date: Wed Jan 2 15:55:55 2008 Subject: cvs commit: src/share/zoneinfo europe southamerica zone.tab In-Reply-To: <200801010747.m017lg7T045831@repoman.freebsd.org> References: <200801010747.m017lg7T045831@repoman.freebsd.org> Message-ID: <477C245A.1070502@FreeBSD.org> Can you please get this merged into RELENG_6_3 and RELENG_7_0? This is quite critical for many users, for example we've got a call from one customer already. Thanks! -Maxim Edwin Groothuis wrote: > edwin 2008-01-01 07:47:42 UTC > > FreeBSD src repository > > Modified files: > share/zoneinfo europe southamerica zone.tab > Log: > MFV of tzdata2007k. > > - Adjust Argentinian DST times. > - Add SJ on the right location. > > Revision Changes Path > 1.36 +1 -2 src/share/zoneinfo/europe > 1.33 +40 -12 src/share/zoneinfo/southamerica > 1.24 +2 -3 src/share/zoneinfo/zone.tab > From edwin at mavetju.org Wed Jan 2 16:16:15 2008 From: edwin at mavetju.org (Edwin Groothuis) Date: Wed Jan 2 16:16:20 2008 Subject: cvs commit: src/share/zoneinfo europe southamerica zone.tab In-Reply-To: <477C245A.1070502@FreeBSD.org> References: <200801010747.m017lg7T045831@repoman.freebsd.org> <477C245A.1070502@FreeBSD.org> Message-ID: <20080103001613.GA37353@k7.mavetju> On Wed, Jan 02, 2008 at 03:55:06PM -0800, Maxim Sobolev wrote: > Can you please get this merged into RELENG_6_3 and RELENG_7_0? This is > quite critical for many users, for example we've got a call from one > customer already. I will poke re@ about it, but in case of emergency install misc/zoneinfo. Edwin -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://www.mavetju.org/weblog/ From jasone at FreeBSD.org Wed Jan 2 16:18:04 2008 From: jasone at FreeBSD.org (Jason Evans) Date: Wed Jan 2 16:18:06 2008 Subject: cvs commit: src/usr.bin/truss syscalls.c Message-ID: <200801030018.m030I4iL052548@repoman.freebsd.org> jasone 2008-01-03 00:18:04 UTC FreeBSD src repository Modified files: usr.bin/truss syscalls.c Log: The break() system call takes a pointer argument, not an integer. This change fixes output for break() on LP64 systems. Revision Changes Path 1.56 +1 -1 src/usr.bin/truss/syscalls.c From jeff at FreeBSD.org Wed Jan 2 17:27:00 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Wed Jan 2 17:27:02 2008 Subject: cvs commit: src/sys/kern kern_descrip.c Message-ID: <200801030126.m031QxBr088419@repoman.freebsd.org> jeff 2008-01-03 01:26:59 UTC FreeBSD src repository Modified files: sys/kern kern_descrip.c Log: - In sysctl_kern_file skip fdps with negative lastfiles. This can happen if there are no files open. Accounting for these can eventually return a negative value for olenp causing sysctl to crash with a bad malloc. Reported by: Pawel Worach Revision Changes Path 1.316 +2 -1 src/sys/kern/kern_descrip.c From imp at FreeBSD.org Wed Jan 2 22:31:42 2008 From: imp at FreeBSD.org (Warner Losh) Date: Wed Jan 2 22:31:45 2008 Subject: cvs commit: src/sys/arm/arm pmap.c Message-ID: <200801030631.m036VfBY015787@repoman.freebsd.org> imp 2008-01-03 06:31:41 UTC FreeBSD src repository Modified files: sys/arm/arm pmap.c Log: Modernize comment about diagnostic. Revision Changes Path 1.94 +1 -2 src/sys/arm/arm/pmap.c From imp at FreeBSD.org Wed Jan 2 22:35:05 2008 From: imp at FreeBSD.org (Warner Losh) Date: Wed Jan 2 22:35:07 2008 Subject: cvs commit: src/sys/ia64/ia64 pmap.c Message-ID: <200801030635.m036Z44Q018535@repoman.freebsd.org> imp 2008-01-03 06:35:04 UTC FreeBSD src repository Modified files: sys/ia64/ia64 pmap.c Log: Fix obsolete comment. pmap_remove_all is the function we're in. Revision Changes Path 1.194 +1 -2 src/sys/ia64/ia64/pmap.c From imp at FreeBSD.org Wed Jan 2 22:43:47 2008 From: imp at FreeBSD.org (Warner Losh) Date: Wed Jan 2 22:43:48 2008 Subject: cvs commit: src/sys/ia64/ia64 pmap.c Message-ID: <200801030643.m036hlYo020781@repoman.freebsd.org> imp 2008-01-03 06:43:47 UTC FreeBSD src repository Modified files: sys/ia64/ia64 pmap.c Log: Use correct function name in panic message Revision Changes Path 1.195 +1 -1 src/sys/ia64/ia64/pmap.c From imp at FreeBSD.org Wed Jan 2 22:44:13 2008 From: imp at FreeBSD.org (Warner Losh) Date: Wed Jan 2 22:44:15 2008 Subject: cvs commit: src/sys/arm/arm pmap.c Message-ID: <200801030644.m036iCqu021256@repoman.freebsd.org> imp 2008-01-03 06:44:12 UTC FreeBSD src repository Modified files: sys/arm/arm pmap.c Log: Use correct function name in panic message Revision Changes Path 1.95 +1 -1 src/sys/arm/arm/pmap.c From alc at FreeBSD.org Wed Jan 2 23:34:35 2008 From: alc at FreeBSD.org (Alan Cox) Date: Wed Jan 2 23:34:36 2008 Subject: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/arm/arm pmap.c src/sys/i386/i386 pmap.c src/sys/ia64/ia64 pmap.c src/sys/powerpc/powerpc pmap_dispatch.c src/sys/sparc64/sparc64 pmap.c src/sys/sun4v/sun4v pmap.c src/sys/vm pmap.h vm_fault.c ... Message-ID: <200801030734.m037YZQV041957@repoman.freebsd.org> alc 2008-01-03 07:34:34 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c sys/arm/arm pmap.c sys/i386/i386 pmap.c sys/ia64/ia64 pmap.c sys/powerpc/powerpc pmap_dispatch.c sys/sparc64/sparc64 pmap.c sys/sun4v/sun4v pmap.c sys/vm pmap.h vm_fault.c vm_kern.c Log: Add an access type parameter to pmap_enter(). It will be used to implement superpage promotion. Correct a style error in kmem_malloc(): pmap_enter()'s last parameter is a Boolean. Revision Changes Path 1.601 +2 -2 src/sys/amd64/amd64/pmap.c 1.96 +2 -2 src/sys/arm/arm/pmap.c 1.604 +2 -2 src/sys/i386/i386/pmap.c 1.196 +2 -2 src/sys/ia64/ia64/pmap.c 1.12 +2 -2 src/sys/powerpc/powerpc/pmap_dispatch.c 1.170 +2 -2 src/sys/sparc64/sparc64/pmap.c 1.42 +2 -2 src/sys/sun4v/sun4v/pmap.c 1.83 +2 -2 src/sys/vm/pmap.h 1.239 +5 -4 src/sys/vm/vm_fault.c 1.130 +2 -1 src/sys/vm/vm_kern.c From kib at FreeBSD.org Thu Jan 3 04:28:58 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Thu Jan 3 04:29:01 2008 Subject: cvs commit: src/sys/ufs/ffs ffs_balloc.c Message-ID: <200801031228.m03CSwTu079901@repoman.freebsd.org> kib 2008-01-03 12:28:58 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_balloc.c Log: ffs_balloc_ufsX() routines, in the case of recovering from the failed allocation, free the indirect blocks before clearing the disk pointers, that could lead to the softupdate inconsistencies in the case of the machine or disk crash at the wrong time. Rearrange the recover code to do the ffs_blkfree() after the second ffs_syncvnode(), that clears the pointers chain. Proposed and reviewed by: tegge Tested by: Peter Holm MFC after: 3 weeks Revision Changes Path 1.53 +16 -12 src/sys/ufs/ffs/ffs_balloc.c From kib at FreeBSD.org Thu Jan 3 04:31:45 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Thu Jan 3 04:31:47 2008 Subject: cvs commit: src/sys/dev/snp snp.c Message-ID: <200801031231.m03CVji4080919@repoman.freebsd.org> kib 2008-01-03 12:31:45 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/snp snp.c Log: MFC rev. 1.106: Do not allow the SNPSTTY ioctl for the snoop device that has a tty attached. Otherwise, the snp->snp_tty would be overwritten, while the tty line discipline still set to the snpdisc. Then snplwrite() causes panic because ttytosnp() cannot find the snp. (And do it at the proper place, from rev. 1.107). MFC rev. 1.107: The snp_target == NULL implies the snp_tty == NULL. Remove the code that is put under snp_target == NULL and snp_tty != NULL clause. In snpclose(), do the snp_detach() before scheduling the snp device destruction. Otherwise, after the return from snpclose(), the snp device is already removed from the snp_list, but tty is still in snooped state. Any attempt to do i/o on such tty cause panic because ttytosnp() returns NULL. Approved by: re (kensmith) Revision Changes Path 1.105.2.1 +7 -9 src/sys/dev/snp/snp.c From kib at FreeBSD.org Thu Jan 3 04:40:56 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Thu Jan 3 04:40:58 2008 Subject: cvs commit: src/sys/compat/linux linux_file.c Message-ID: <200801031240.m03CeuDI084047@repoman.freebsd.org> kib 2008-01-03 12:40:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/compat/linux linux_file.c Log: MFC rev. 1.107: Plug the leaks in the present implementation of the linux_openat(). Approved by: re (kensmith) Revision Changes Path 1.105.2.1 +19 -12 src/sys/compat/linux/linux_file.c From bz at FreeBSD.org Thu Jan 3 07:19:31 2008 From: bz at FreeBSD.org (Bjoern A. Zeeb) Date: Thu Jan 3 07:19:39 2008 Subject: cvs commit: src/sys/kern uipc_debug.c Message-ID: <200801031519.m03FJVPw059426@repoman.freebsd.org> bz 2008-01-03 15:19:31 UTC FreeBSD src repository Modified files: sys/kern uipc_debug.c Log: Add missing sb_sndptr* fields to db_print_sockbuf(). While here change %d to %u for u_ints. Discussed with: rwatson, kmacy Revision Changes Path 1.3 +9 -5 src/sys/kern/uipc_debug.c From des at FreeBSD.org Thu Jan 3 09:54:27 2008 From: des at FreeBSD.org (Dag-Erling Smorgrav) Date: Thu Jan 3 09:54:29 2008 Subject: cvs commit: src/lib/libarchive archive_read.c archive_read_private.h archive_read_support_format_zip.c Message-ID: <200801031754.m03HsRwZ035708@repoman.freebsd.org> des 2008-01-03 17:54:27 UTC FreeBSD src repository Modified files: lib/libarchive archive_read.c archive_read_private.h archive_read_support_format_zip.c Log: Add an internal utility function to simplify the many, many places where the number of bytes read is actually not important as long as we have at least what we ask for. Illustrate its benefits by using it throughout the ZIP support code, except for the few cases where it doesn't apply. Approved by: kientzle Revision Changes Path 1.37 +11 -0 src/lib/libarchive/archive_read.c 1.4 +3 -0 src/lib/libarchive/archive_read_private.h 1.18 +10 -25 src/lib/libarchive/archive_read_support_format_zip.c From des at FreeBSD.org Thu Jan 3 10:30:38 2008 From: des at FreeBSD.org (Dag-Erling Smorgrav) Date: Thu Jan 3 10:30:40 2008 Subject: cvs commit: src/lib/libarchive archive_endian.h archive_read_support_format_zip.c Message-ID: <200801031830.m03IUb9K049549@repoman.freebsd.org> des 2008-01-03 18:30:37 UTC FreeBSD src repository Modified files: lib/libarchive archive_read_support_format_zip.c Added files: lib/libarchive archive_endian.h Log: Crib {be,le}{16,32,64}{dec,enc} from src/sys/sys/endian.h and use it instead of home-rolled [iu][248] in the ZIP support code. Approved by: kientzle Revision Changes Path 1.1 +142 -0 src/lib/libarchive/archive_endian.h (new) 1.19 +22 -57 src/lib/libarchive/archive_read_support_format_zip.c From des at des.no Thu Jan 3 10:34:32 2008 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Thu Jan 3 10:34:35 2008 Subject: cvs commit: src/sys/dev/ata ata-disk.c In-Reply-To: <200801022033.m02KXsWD049168@repoman.freebsd.org> (Poul-Henning Kamp's message of "Wed\, 2 Jan 2008 20\:33\:54 +0000 \(UTC\)") References: <200801022033.m02KXsWD049168@repoman.freebsd.org> Message-ID: <86bq82ep1t.fsf@ds4.des.no> Poul-Henning Kamp writes: > Log: > If the disk reports that it support the Compact Flash Association command > set, announce BIO_DELETE capability and issue ATA_CFA_ERASE when we get one. > > Once we issue more BIO_DELETE, this will improve lifetime, and > possibly write speed of Flash based devices which have usable flash > adaptation layers. > > For now, about the only usage is the newfs(1) -E flag. Is 'fsck -E' also in the pipeline? DES -- Dag-Erling Sm?rgrav - des@des.no From danger at FreeBSD.org Thu Jan 3 12:54:45 2008 From: danger at FreeBSD.org (Daniel Gerzo) Date: Thu Jan 3 12:54:48 2008 Subject: cvs commit: src/share/man/man5 boot.config.5 Message-ID: <200801032054.m03KsZaH023021@repoman.freebsd.org> danger 2008-01-03 20:54:35 UTC FreeBSD src repository (doc committer) Modified files: share/man/man5 boot.config.5 Log: - loader(8) is not a part of boot(8) and is not its second stage. Reported by: Yoshihiko Sarumaru Reviewed by: trhodes MFC-after: 3 days Revision Changes Path 1.2 +5 -5 src/share/man/man5/boot.config.5 From phk at phk.freebsd.dk Thu Jan 3 14:48:57 2008 From: phk at phk.freebsd.dk (Poul-Henning Kamp) Date: Thu Jan 3 14:49:01 2008 Subject: cvs commit: src/sys/dev/ata ata-disk.c In-Reply-To: Your message of "Thu, 03 Jan 2008 19:34:22 +0100." <86bq82ep1t.fsf@ds4.des.no> Message-ID: <2773.1199400535@critter.freebsd.dk> In message <86bq82ep1t.fsf@ds4.des.no>, =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= wr ites: >> Once we issue more BIO_DELETE, this will improve lifetime, and >> possibly write speed of Flash based devices which have usable flash >> adaptation layers. >> >> For now, about the only usage is the newfs(1) -E flag. > >Is 'fsck -E' also in the pipeline? Eventually, yes. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From jasone at FreeBSD.org Thu Jan 3 15:22:13 2008 From: jasone at FreeBSD.org (Jason Evans) Date: Thu Jan 3 15:22:16 2008 Subject: cvs commit: src/lib/libc/stdlib malloc.3 malloc.c Message-ID: <200801032322.m03NMDI6073073@repoman.freebsd.org> jasone 2008-01-03 23:22:13 UTC FreeBSD src repository Modified files: lib/libc/stdlib malloc.3 malloc.c Log: Enable both sbrk(2)- and mmap(2)-based memory acquisition methods by default. This has the disadvantage of rendering the datasize resource limit irrelevant, but without this change, legitimate uses of more memory than will fit in the data segment are thwarted by default. Fix chunk_alloc_mmap() to work correctly if initial mapping is not chunk-aligned and mapping extension fails. Revision Changes Path 1.76 +12 -12 src/lib/libc/stdlib/malloc.3 1.161 +8 -7 src/lib/libc/stdlib/malloc.c From obrien at FreeBSD.org Thu Jan 3 18:45:15 2008 From: obrien at FreeBSD.org (David O'Brien) Date: Thu Jan 3 18:45:17 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-chipset.c ata-dma.c ata-lowlevel.c In-Reply-To: <200712131147.lBDBlaFi066300@repoman.freebsd.org> References: <200712131147.lBDBlaFi066300@repoman.freebsd.org> Message-ID: <20080104024514.GA35785@dragon.NUXI.org> On Thu, Dec 13, 2007 at 11:47:36AM +0000, Sren Schmidt wrote: > sos 2007-12-13 11:47:36 UTC > Modified files: > sys/dev/ata ata-all.h ata-chipset.c ata-dma.c > ata-lowlevel.c > Log: > Implement a workaround of the datacorruption problem on serverworks > HT1000 chipsets. The HT1000 DMA engine seems to not always like 64K > transfers and sometimes barfs data all over memory leading to instant > chrash and burn. Oh, will you be requesting to MFC this to 7.0 and releng6? From obrien at FreeBSD.org Thu Jan 3 19:08:50 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Thu Jan 3 19:08:51 2008 Subject: cvs commit: src/usr.bin/netstat inet.c Message-ID: <200801040308.m0438og8005003@repoman.freebsd.org> obrien 2008-01-04 03:08:49 UTC FreeBSD src repository Modified files: usr.bin/netstat inet.c Log: more style(9) Revision Changes Path 1.81 +70 -69 src/usr.bin/netstat/inet.c From obrien at FreeBSD.org Thu Jan 3 19:09:29 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Thu Jan 3 19:09:31 2008 Subject: cvs commit: src/usr.bin/netstat inet.c Message-ID: <200801040309.m0439S5C005045@repoman.freebsd.org> obrien 2008-01-04 03:09:28 UTC FreeBSD src repository Modified files: usr.bin/netstat inet.c Log: Make a few messages more consistant with the others. Revision Changes Path 1.82 +2 -2 src/usr.bin/netstat/inet.c From obrien at FreeBSD.org Thu Jan 3 19:21:22 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Thu Jan 3 19:21:24 2008 Subject: cvs commit: src/usr.bin/netstat inet.c Message-ID: <200801040321.m043LLEG005701@repoman.freebsd.org> obrien 2008-01-04 03:21:21 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/netstat inet.c Log: MFC: rev. 1.76: 'netstat -A -p tcp' prints the Tcpcb pointer in the 1st col Revision Changes Path 1.70.2.5 +1 -1 src/usr.bin/netstat/inet.c From kib at FreeBSD.org Thu Jan 3 20:33:19 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Thu Jan 3 20:33:37 2008 Subject: cvs commit: src/sys/vm vm_map.c Message-ID: <200801040433.m044XDjC010097@repoman.freebsd.org> kib 2008-01-04 04:33:13 UTC FreeBSD src repository Modified files: sys/vm vm_map.c Log: In the vm_map_stack(), check for the specified stack region wraparound. Reported and tested by: Peter Holm Reviewed by: alc MFC after: 3 days Revision Changes Path 1.392 +3 -1 src/sys/vm/vm_map.c From kib at FreeBSD.org Thu Jan 3 20:53:22 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Thu Jan 3 20:53:24 2008 Subject: cvs commit: src/sys/dev/snp snp.c Message-ID: <200801040453.m044rMsf020436@repoman.freebsd.org> kib 2008-01-04 04:53:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/dev/snp snp.c Log: MFC rev. 1.106: Do not allow the SNPSTTY ioctl for the snoop device that has a tty attached. Otherwise, the snp->snp_tty would be overwritten, while the tty line discipline still set to the snpdisc. Then snplwrite() causes panic because ttytosnp() cannot find the snp. (And do it at the proper place, from rev. 1.107). MFC rev. 1.107: The snp_target == NULL implies the snp_tty == NULL. Remove the code that is put under snp_target == NULL and snp_tty != NULL clause. In snpclose(), do the snp_detach() before scheduling the snp device destruction. Otherwise, after the return from snpclose(), the snp device is already removed from the snp_list, but tty is still in snooped state. Any attempt to do i/o on such tty cause panic because ttytosnp() returns NULL. Approved by: re (kensmith) Revision Changes Path 1.105.4.1 +7 -9 src/sys/dev/snp/snp.c From kib at FreeBSD.org Thu Jan 3 20:56:08 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Thu Jan 3 20:56:10 2008 Subject: cvs commit: src/sys/compat/linux linux_file.c Message-ID: <200801040456.m044u7KM020586@repoman.freebsd.org> kib 2008-01-04 04:56:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/compat/linux linux_file.c Log: MFC rev. 1.107: Plug the leaks in the present implementation of the linux_openat(). Approved by: re (kensmith) Revision Changes Path 1.105.4.1 +19 -12 src/sys/compat/linux/linux_file.c From imp at FreeBSD.org Fri Jan 4 00:19:53 2008 From: imp at FreeBSD.org (Warner Losh) Date: Fri Jan 4 00:19:56 2008 Subject: cvs commit: src/share/man/man4 pci.4 Message-ID: <200801040819.m048JrYC054457@repoman.freebsd.org> imp 2008-01-04 08:19:52 UTC FreeBSD src repository Modified files: share/man/man4 pci.4 Log: Modernize this man page a little by describing the pci driver of today, rather than details relevant only to the 3.x pci driver. Revision Changes Path 1.20 +14 -6 src/share/man/man4/pci.4 From imp at FreeBSD.org Fri Jan 4 00:26:23 2008 From: imp at FreeBSD.org (Warner Losh) Date: Fri Jan 4 00:26:25 2008 Subject: cvs commit: src/share/man/man4 Makefile pcib.4 Message-ID: <200801040826.m048QN40054802@repoman.freebsd.org> imp 2008-01-04 08:26:23 UTC FreeBSD src repository Modified files: share/man/man4 Makefile Added files: share/man/man4 pcib.4 Log: Dummy man page for pcib. We should write a real one and I hope this gets the ball rolling. Revision Changes Path 1.402 +1 -0 src/share/man/man4/Makefile 1.1 +41 -0 src/share/man/man4/pcib.4 (new) From gabor at FreeBSD.org Fri Jan 4 04:55:02 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 04:55:05 2008 Subject: cvs commit: src/share/man/man4 edsc.4 Message-ID: <200801041255.m04Ct2pk092187@repoman.freebsd.org> gabor 2008-01-04 12:55:02 UTC FreeBSD src repository (doc,ports committer) Modified files: share/man/man4 edsc.4 Log: - This driver will first appear in 6.3, not 7.0 MFC after: 0 days Revision Changes Path 1.2 +1 -1 src/share/man/man4/edsc.4 From gabor at FreeBSD.org Fri Jan 4 04:55:24 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 04:55:25 2008 Subject: cvs commit: src/share/man/man4 ipmi.4 Message-ID: <200801041255.m04CtOes092230@repoman.freebsd.org> gabor 2008-01-04 12:55:24 UTC FreeBSD src repository (doc,ports committer) Modified files: share/man/man4 ipmi.4 Log: - This driver will first appear in 6.3, not 7.0 MFC after: 0 days Revision Changes Path 1.9 +1 -1 src/share/man/man4/ipmi.4 From gabor at FreeBSD.org Fri Jan 4 04:55:55 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 04:55:57 2008 Subject: cvs commit: src/share/man/man4 mxge.4 Message-ID: <200801041255.m04CtsX9092284@repoman.freebsd.org> gabor 2008-01-04 12:55:54 UTC FreeBSD src repository (doc,ports committer) Modified files: share/man/man4 mxge.4 Log: - This driver will first appear in 6.3, not 7.0 MFC after: 0 days Revision Changes Path 1.8 +1 -1 src/share/man/man4/mxge.4 From gabor at FreeBSD.org Fri Jan 4 04:56:25 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 04:56:27 2008 Subject: cvs commit: src/share/man/man4 snd_envy24.4 Message-ID: <200801041256.m04CuO69092318@repoman.freebsd.org> gabor 2008-01-04 12:56:24 UTC FreeBSD src repository (doc,ports committer) Modified files: share/man/man4 snd_envy24.4 Log: - This driver will first appear in 6.3, not 7.0 MFC after: 0 days Revision Changes Path 1.4 +1 -1 src/share/man/man4/snd_envy24.4 From gabor at FreeBSD.org Fri Jan 4 04:56:46 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 04:56:48 2008 Subject: cvs commit: src/share/man/man4 snd_envy24ht.4 Message-ID: <200801041256.m04Cujcn092365@repoman.freebsd.org> gabor 2008-01-04 12:56:45 UTC FreeBSD src repository (doc,ports committer) Modified files: share/man/man4 snd_envy24ht.4 Log: - This driver will first appear in 6.3, not 7.0 MFC after: 0 days Revision Changes Path 1.3 +1 -1 src/share/man/man4/snd_envy24ht.4 From gabor at FreeBSD.org Fri Jan 4 04:57:06 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 04:57:08 2008 Subject: cvs commit: src/share/man/man4 snd_hda.4 Message-ID: <200801041257.m04Cv6Ok092413@repoman.freebsd.org> gabor 2008-01-04 12:57:06 UTC FreeBSD src repository (doc,ports committer) Modified files: share/man/man4 snd_hda.4 Log: - This driver will first appear in 6.3, not 7.0 MFC after: 0 days Revision Changes Path 1.13 +1 -1 src/share/man/man4/snd_hda.4 From gabor at FreeBSD.org Fri Jan 4 04:57:35 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 04:57:36 2008 Subject: cvs commit: src/share/man/man4 snd_spicds.4 Message-ID: <200801041257.m04CvY88092446@repoman.freebsd.org> gabor 2008-01-04 12:57:34 UTC FreeBSD src repository (doc,ports committer) Modified files: share/man/man4 snd_spicds.4 Log: - This driver will first appear in 6.3, not 7.0 MFC after: 0 days Revision Changes Path 1.4 +1 -1 src/share/man/man4/snd_spicds.4 From gabor at FreeBSD.org Fri Jan 4 04:58:10 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 04:58:11 2008 Subject: cvs commit: src/share/man/man5 linsysfs.5 Message-ID: <200801041258.m04CwAkU092488@repoman.freebsd.org> gabor 2008-01-04 12:58:10 UTC FreeBSD src repository (doc,ports committer) Modified files: share/man/man5 linsysfs.5 Log: - This driver will has already appeared in 6.2 MFC after: 0 days Revision Changes Path 1.7 +1 -1 src/share/man/man5/linsysfs.5 From gabor at FreeBSD.org Fri Jan 4 04:59:34 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 04:59:36 2008 Subject: cvs commit: src/share/man/man4 edsc.4 Message-ID: <200801041259.m04CxYon092542@repoman.freebsd.org> gabor 2008-01-04 12:59:34 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6) share/man/man4 edsc.4 Log: MFC r1.2 - This driver will first appear in 6.3, not 7.0 Revision Changes Path 1.1.2.2 +1 -1 src/share/man/man4/edsc.4 From gabor at FreeBSD.org Fri Jan 4 04:59:57 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 04:59:58 2008 Subject: cvs commit: src/share/man/man4 ipmi.4 Message-ID: <200801041259.m04Cxuuj092576@repoman.freebsd.org> gabor 2008-01-04 12:59:56 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6) share/man/man4 ipmi.4 Log: MFC r1.9 - This driver will first appear in 6.3, not 7.0 Revision Changes Path 1.4.2.3 +1 -1 src/share/man/man4/ipmi.4 From gabor at FreeBSD.org Fri Jan 4 05:00:16 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:00:19 2008 Subject: cvs commit: src/share/man/man4 mxge.4 Message-ID: <200801041300.m04D0GRZ092676@repoman.freebsd.org> gabor 2008-01-04 13:00:16 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6) share/man/man4 mxge.4 Log: MFC r1.8 - This driver will first appear in 6.3, not 7.0 Revision Changes Path 1.7.2.2 +1 -1 src/share/man/man4/mxge.4 From gabor at FreeBSD.org Fri Jan 4 05:00:40 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:00:42 2008 Subject: cvs commit: src/share/man/man4 snd_envy24.4 Message-ID: <200801041300.m04D0exY092715@repoman.freebsd.org> gabor 2008-01-04 13:00:40 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6) share/man/man4 snd_envy24.4 Log: MFC r1.4 - This driver will first appear in 6.3, not 7.0 Revision Changes Path 1.3.2.2 +1 -1 src/share/man/man4/snd_envy24.4 From gabor at FreeBSD.org Fri Jan 4 05:01:04 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:01:06 2008 Subject: cvs commit: src/share/man/man4 snd_envy24ht.4 Message-ID: <200801041301.m04D14rm092782@repoman.freebsd.org> gabor 2008-01-04 13:01:04 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6) share/man/man4 snd_envy24ht.4 Log: MFC r1.3 - This driver will first appear in 6.3, not 7.0 Revision Changes Path 1.1.2.3 +1 -1 src/share/man/man4/snd_envy24ht.4 From gabor at FreeBSD.org Fri Jan 4 05:01:39 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:01:41 2008 Subject: cvs commit: src/share/man/man4 snd_hda.4 Message-ID: <200801041301.m04D1csU092812@repoman.freebsd.org> gabor 2008-01-04 13:01:38 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6) share/man/man4 snd_hda.4 Log: MFC r1.13 - This driver will first appear in 6.3, not 7.0 Revision Changes Path 1.10.2.2 +1 -1 src/share/man/man4/snd_hda.4 From gabor at FreeBSD.org Fri Jan 4 05:02:05 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:02:07 2008 Subject: cvs commit: src/share/man/man4 snd_spicds.4 Message-ID: <200801041302.m04D24fk092850@repoman.freebsd.org> gabor 2008-01-04 13:02:04 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6) share/man/man4 snd_spicds.4 Log: MFC r1.4 - This driver will first appear in 6.3, not 7.0 Revision Changes Path 1.2.2.2 +1 -1 src/share/man/man4/snd_spicds.4 From gabor at FreeBSD.org Fri Jan 4 05:02:43 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:02:45 2008 Subject: cvs commit: src/share/man/man5 linsysfs.5 Message-ID: <200801041302.m04D2gtS092889@repoman.freebsd.org> gabor 2008-01-04 13:02:42 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6) share/man/man5 linsysfs.5 Log: MFC r1.7 - This driver has already appeared in 6.2 Revision Changes Path 1.2.2.2 +1 -1 src/share/man/man5/linsysfs.5 From gabor at FreeBSD.org Fri Jan 4 05:03:47 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:03:49 2008 Subject: cvs commit: src/share/man/man4 edsc.4 Message-ID: <200801041303.m04D3lZC094105@repoman.freebsd.org> gabor 2008-01-04 13:03:47 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6_3) share/man/man4 edsc.4 Log: MFC r1.2 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.1.2.1.2.1 +1 -1 src/share/man/man4/edsc.4 From gabor at FreeBSD.org Fri Jan 4 05:04:17 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:04:19 2008 Subject: cvs commit: src/share/man/man4 ipmi.4 Message-ID: <200801041304.m04D4HCu094143@repoman.freebsd.org> gabor 2008-01-04 13:04:17 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6_3) share/man/man4 ipmi.4 Log: MFC r1.9 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.4.2.2.2.1 +1 -1 src/share/man/man4/ipmi.4 From gabor at FreeBSD.org Fri Jan 4 05:04:56 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:04:58 2008 Subject: cvs commit: src/share/man/man4 mxge.4 Message-ID: <200801041304.m04D4tbN094188@repoman.freebsd.org> gabor 2008-01-04 13:04:55 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6_3) share/man/man4 mxge.4 Log: MFC r1.8 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.7.2.1.2.1 +1 -1 src/share/man/man4/mxge.4 From gabor at FreeBSD.org Fri Jan 4 05:05:31 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:05:33 2008 Subject: cvs commit: src/share/man/man4 snd_envy24.4 Message-ID: <200801041305.m04D5VFC094323@repoman.freebsd.org> gabor 2008-01-04 13:05:31 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6_3) share/man/man4 snd_envy24.4 Log: MFC r1.4 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.3.2.1.2.1 +1 -1 src/share/man/man4/snd_envy24.4 From gabor at FreeBSD.org Fri Jan 4 05:05:59 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:06:00 2008 Subject: cvs commit: src/share/man/man4 snd_envy24ht.4 Message-ID: <200801041305.m04D5wAl094376@repoman.freebsd.org> gabor 2008-01-04 13:05:58 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6_3) share/man/man4 snd_envy24ht.4 Log: MFC r1.3 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.1.2.2.2.1 +1 -1 src/share/man/man4/snd_envy24ht.4 From gabor at FreeBSD.org Fri Jan 4 05:06:21 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:06:22 2008 Subject: cvs commit: src/share/man/man4 snd_hda.4 Message-ID: <200801041306.m04D6LId094412@repoman.freebsd.org> gabor 2008-01-04 13:06:21 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6_3) share/man/man4 snd_hda.4 Log: MFC r1.13 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.10.2.1.2.1 +1 -1 src/share/man/man4/snd_hda.4 From gabor at FreeBSD.org Fri Jan 4 05:06:52 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:06:53 2008 Subject: cvs commit: src/share/man/man4 snd_spicds.4 Message-ID: <200801041306.m04D6p0c094450@repoman.freebsd.org> gabor 2008-01-04 13:06:51 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6_3) share/man/man4 snd_spicds.4 Log: MFC r1.4 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.2.2.1.2.1 +1 -1 src/share/man/man4/snd_spicds.4 From gabor at FreeBSD.org Fri Jan 4 05:07:27 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:07:30 2008 Subject: cvs commit: src/share/man/man5 linsysfs.5 Message-ID: <200801041307.m04D7RG6094488@repoman.freebsd.org> gabor 2008-01-04 13:07:27 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6_3) share/man/man5 linsysfs.5 Log: MFC r1.7 - This driver has already appeared in 6.2 Approved by: re (hrs) Revision Changes Path 1.2.2.1.4.1 +1 -1 src/share/man/man5/linsysfs.5 From gabor at FreeBSD.org Fri Jan 4 05:08:15 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:08:17 2008 Subject: cvs commit: src/share/man/man4 edsc.4 Message-ID: <200801041308.m04D8EaZ094547@repoman.freebsd.org> gabor 2008-01-04 13:08:14 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7) share/man/man4 edsc.4 Log: MFC r1.2 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.1.4.1 +1 -1 src/share/man/man4/edsc.4 From gabor at FreeBSD.org Fri Jan 4 05:08:39 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:08:41 2008 Subject: cvs commit: src/share/man/man4 ipmi.4 Message-ID: <200801041308.m04D8dJa094591@repoman.freebsd.org> gabor 2008-01-04 13:08:39 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7) share/man/man4 ipmi.4 Log: MFC r1.9 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.8.2.1 +1 -1 src/share/man/man4/ipmi.4 From gabor at FreeBSD.org Fri Jan 4 05:09:05 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:09:07 2008 Subject: cvs commit: src/share/man/man4 mxge.4 Message-ID: <200801041309.m04D94c9094708@repoman.freebsd.org> gabor 2008-01-04 13:09:04 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7) share/man/man4 mxge.4 Log: MFC r1.8 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.7.4.1 +1 -1 src/share/man/man4/mxge.4 From gabor at FreeBSD.org Fri Jan 4 05:09:31 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:09:33 2008 Subject: cvs commit: src/share/man/man4 snd_envy24.4 Message-ID: <200801041309.m04D9VYx094739@repoman.freebsd.org> gabor 2008-01-04 13:09:31 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7) share/man/man4 snd_envy24.4 Log: MFC r1.4 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.3.4.1 +1 -1 src/share/man/man4/snd_envy24.4 From gabor at FreeBSD.org Fri Jan 4 05:09:53 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:09:55 2008 Subject: cvs commit: src/share/man/man4 snd_envy24ht.4 Message-ID: <200801041309.m04D9reQ094772@repoman.freebsd.org> gabor 2008-01-04 13:09:53 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7) share/man/man4 snd_envy24ht.4 Log: MFC r1.3 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.2.2.1 +1 -1 src/share/man/man4/snd_envy24ht.4 From gabor at FreeBSD.org Fri Jan 4 05:10:25 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:10:26 2008 Subject: cvs commit: src/share/man/man4 snd_hda.4 Message-ID: <200801041310.m04DAOZu094863@repoman.freebsd.org> gabor 2008-01-04 13:10:24 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7) share/man/man4 snd_hda.4 Log: MFC r1.13 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.12.2.1 +1 -1 src/share/man/man4/snd_hda.4 From gabor at FreeBSD.org Fri Jan 4 05:10:47 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:10:49 2008 Subject: cvs commit: src/share/man/man4 snd_spicds.4 Message-ID: <200801041310.m04DAk8a094928@repoman.freebsd.org> gabor 2008-01-04 13:10:46 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7) share/man/man4 snd_spicds.4 Log: MFC r1.4 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.3.2.1 +1 -1 src/share/man/man4/snd_spicds.4 From gabor at FreeBSD.org Fri Jan 4 05:11:17 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:11:18 2008 Subject: cvs commit: src/share/man/man5 linsysfs.5 Message-ID: <200801041311.m04DBGD6094999@repoman.freebsd.org> gabor 2008-01-04 13:11:16 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7) share/man/man5 linsysfs.5 Log: MFC r1.7 - This driver has already appeared in 6.2 Approved by: re (hrs) Revision Changes Path 1.6.2.1 +1 -1 src/share/man/man5/linsysfs.5 From gabor at FreeBSD.org Fri Jan 4 05:12:00 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:12:02 2008 Subject: cvs commit: src/share/man/man4 edsc.4 Message-ID: <200801041311.m04DBxsE095051@repoman.freebsd.org> gabor 2008-01-04 13:11:59 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7_0) share/man/man4 edsc.4 Log: MFC r1.2 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.1.6.1 +1 -1 src/share/man/man4/edsc.4 From gabor at FreeBSD.org Fri Jan 4 05:12:20 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:12:26 2008 Subject: cvs commit: src/share/man/man4 ipmi.4 Message-ID: <200801041312.m04DCJ2q095086@repoman.freebsd.org> gabor 2008-01-04 13:12:19 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7_0) share/man/man4 ipmi.4 Log: MFC r1.9 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.8.4.1 +1 -1 src/share/man/man4/ipmi.4 From gabor at FreeBSD.org Fri Jan 4 05:12:48 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:12:51 2008 Subject: cvs commit: src/share/man/man4 mxge.4 Message-ID: <200801041312.m04DCmpr095125@repoman.freebsd.org> gabor 2008-01-04 13:12:48 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7_0) share/man/man4 mxge.4 Log: MFC r.18 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.7.6.1 +1 -1 src/share/man/man4/mxge.4 From gabor at FreeBSD.org Fri Jan 4 05:13:19 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:13:21 2008 Subject: cvs commit: src/share/man/man4 snd_envy24.4 Message-ID: <200801041313.m04DDJjw095171@repoman.freebsd.org> gabor 2008-01-04 13:13:19 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7_0) share/man/man4 snd_envy24.4 Log: MFC r1.4 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.3.6.1 +1 -1 src/share/man/man4/snd_envy24.4 From gabor at FreeBSD.org Fri Jan 4 05:13:44 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:13:46 2008 Subject: cvs commit: src/share/man/man4 snd_envy24ht.4 Message-ID: <200801041313.m04DDi3c095207@repoman.freebsd.org> gabor 2008-01-04 13:13:44 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7_0) share/man/man4 snd_envy24ht.4 Log: MFC r1.3 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.2.4.1 +1 -1 src/share/man/man4/snd_envy24ht.4 From gabor at FreeBSD.org Fri Jan 4 05:14:07 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:14:10 2008 Subject: cvs commit: src/share/man/man4 snd_hda.4 Message-ID: <200801041314.m04DE6wV095291@repoman.freebsd.org> gabor 2008-01-04 13:14:06 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7_0) share/man/man4 snd_hda.4 Log: MFC r1.13 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.12.4.1 +1 -1 src/share/man/man4/snd_hda.4 From gabor at FreeBSD.org Fri Jan 4 05:14:33 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:14:35 2008 Subject: cvs commit: src/share/man/man4 snd_spicds.4 Message-ID: <200801041314.m04DEWaQ095423@repoman.freebsd.org> gabor 2008-01-04 13:14:32 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7_0) share/man/man4 snd_spicds.4 Log: MFC r1.4 - This driver will first appear in 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.3.4.1 +1 -1 src/share/man/man4/snd_spicds.4 From gabor at FreeBSD.org Fri Jan 4 05:15:03 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:15:03 2008 Subject: cvs commit: src/share/man/man5 linsysfs.5 Message-ID: <200801041315.m04DF2DB095506@repoman.freebsd.org> gabor 2008-01-04 13:15:02 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7_0) share/man/man5 linsysfs.5 Log: MFC r1.7 - This driver has already appeared in 6.2 Approved by: re (hrs) Revision Changes Path 1.6.4.1 +1 -1 src/share/man/man5/linsysfs.5 From gabor at FreeBSD.org Fri Jan 4 05:20:50 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:20:53 2008 Subject: cvs commit: src/usr.sbin/pkg_install/version pkg_version.1 Message-ID: <200801041320.m04DKoL3095920@repoman.freebsd.org> gabor 2008-01-04 13:20:50 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7) usr.sbin/pkg_install/version pkg_version.1 Log: MFC r1.39 - Adjust INDEX file name to INDEX-7 so that it matches the major FreeBSD version number, as it is named after that Approved by: re (hrs) Revision Changes Path 1.36.2.1 +5 -5 src/usr.sbin/pkg_install/version/pkg_version.1 From gabor at FreeBSD.org Fri Jan 4 05:22:19 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:22:25 2008 Subject: cvs commit: src/usr.sbin/pkg_install/version pkg_version.1 Message-ID: <200801041322.m04DM9Kq096026@repoman.freebsd.org> gabor 2008-01-04 13:22:09 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7_0) usr.sbin/pkg_install/version pkg_version.1 Log: MFC r1.39 - Adjust INDEX file name to INDEX-7 so that it matches the major FreeBSD version number, as it is named after that Approved by: re (hrs) Revision Changes Path 1.36.4.1 +5 -5 src/usr.sbin/pkg_install/version/pkg_version.1 From gabor at FreeBSD.org Fri Jan 4 05:31:07 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:31:09 2008 Subject: cvs commit: src/share/man/man7 ports.7 Message-ID: <200801041331.m04DV7mZ096574@repoman.freebsd.org> gabor 2008-01-04 13:31:07 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7) share/man/man7 ports.7 Log: MFC r1.62: - Document icase variable of make search, which can be used to control case-sensitivity r1.63: - Document PORT_DBDIR r1.64: - Remove incomplete sentence fragment Approved by: re (hrs) Revision Changes Path 1.61.2.1 +23 -4 src/share/man/man7/ports.7 From gabor at FreeBSD.org Fri Jan 4 05:31:52 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:31:55 2008 Subject: cvs commit: src/share/man/man7 ports.7 Message-ID: <200801041331.m04DVqo7096630@repoman.freebsd.org> gabor 2008-01-04 13:31:52 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7_0) share/man/man7 ports.7 Log: MFC r1.62: - Document icase variable of make search, which can be used to control case-sensitivity r1.63: - Document PORT_DBDIR r1.64: - Remove incomplete sentence fragment Approved by: re (hrs) Revision Changes Path 1.61.4.1 +23 -4 src/share/man/man7/ports.7 From gabor at FreeBSD.org Fri Jan 4 05:32:33 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:32:34 2008 Subject: cvs commit: src/share/man/man7 ports.7 Message-ID: <200801041332.m04DWWOi096680@repoman.freebsd.org> gabor 2008-01-04 13:32:32 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6) share/man/man7 ports.7 Log: MFC r1.62: - Document icase variable of make search, which can be used to control case-sensitivity r1.63: - Document PORT_DBDIR r1.64: - Remove incomplete sentence fragment Revision Changes Path 1.50.2.7 +23 -4 src/share/man/man7/ports.7 From gabor at FreeBSD.org Fri Jan 4 05:33:01 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Fri Jan 4 05:33:04 2008 Subject: cvs commit: src/share/man/man7 ports.7 Message-ID: <200801041333.m04DX1Kx096735@repoman.freebsd.org> gabor 2008-01-04 13:33:01 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6_3) share/man/man7 ports.7 Log: MFC r1.62: - Document icase variable of make search, which can be used to control case-sensitivity r1.63: - Document PORT_DBDIR r1.64: - Remove incomplete sentence fragment Approved by: re (hrs) Revision Changes Path 1.50.2.6.2.1 +23 -4 src/share/man/man7/ports.7 From brix at FreeBSD.org Fri Jan 4 09:02:27 2008 From: brix at FreeBSD.org (Henrik Brix Andersen) Date: Fri Jan 4 09:02:30 2008 Subject: cvs commit: src/share/man/man4 edsc.4 In-Reply-To: <200801041255.m04Ct2pk092187@repoman.freebsd.org> References: <200801041255.m04Ct2pk092187@repoman.freebsd.org> Message-ID: <20080104164700.GA51866@tirith.brixandersen.dk> On Fri, Jan 04, 2008 at 12:55:02PM +0000, Gabor Kovesdan wrote: > gabor 2008-01-04 12:55:02 UTC > > FreeBSD src repository (doc,ports committer) > > Modified files: > share/man/man4 edsc.4 > Log: > - This driver will first appear in 6.3, not 7.0 > > MFC after: 0 days Is it just me, or wasn't ipmi(4) part of FreeBSD 6.2? http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/ipmi/ipmi.c?only_with_tag=RELENG_6_2_0_RELEASE Brix -- Henrik Brix Andersen -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 209 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080104/9ff1fb3f/attachment.pgp From kientzle at freebsd.org Fri Jan 4 09:50:43 2008 From: kientzle at freebsd.org (Tim Kientzle) Date: Fri Jan 4 09:50:48 2008 Subject: cvs commit: src/lib/libarchive archive_endian.h archive_read_support_format_zip.c In-Reply-To: <200801031830.m03IUb9K049549@repoman.freebsd.org> References: <200801031830.m03IUb9K049549@repoman.freebsd.org> Message-ID: <477E71F1.4080301@freebsd.org> Dag-Erling Smorgrav wrote: > des 2008-01-03 18:30:37 UTC > > FreeBSD src repository > > Modified files: > lib/libarchive archive_read_support_format_zip.c > Added files: > lib/libarchive archive_endian.h > Log: > Crib {be,le}{16,32,64}{dec,enc} from src/sys/sys/endian.h and use it instead > of home-rolled [iu][248] in the ZIP support code. > > Approved by: kientzle > > Revision Changes Path > 1.1 +142 -0 src/lib/libarchive/archive_endian.h (new) > 1.19 +22 -57 src/lib/libarchive/archive_read_support_format_zip.c Is this really right? > +be32dec(const void *pp) > +{ > + unsigned char const *p = (unsigned char const *)pp; The "const *" is harmless enough, but dropping the leading "const" doesn't seem right at all: 'pp' is a pointer to const data, 'p' points to modifiable data. Tim Kientzle From joerg at britannica.bec.de Fri Jan 4 10:42:43 2008 From: joerg at britannica.bec.de (Joerg Sonnenberger) Date: Fri Jan 4 10:42:46 2008 Subject: cvs commit: src/lib/libarchive archive_endian.h archive_read_support_format_zip.c In-Reply-To: <477E71F1.4080301@freebsd.org> References: <200801031830.m03IUb9K049549@repoman.freebsd.org> <477E71F1.4080301@freebsd.org> Message-ID: <20080104181728.GM971@britannica.bec.de> On Fri, Jan 04, 2008 at 09:50:41AM -0800, Tim Kientzle wrote: >> +be32dec(const void *pp) >> +{ >> + unsigned char const *p = (unsigned char const *)pp; > > The "const *" is harmless enough, but dropping the > leading "const" doesn't seem right at all: 'pp' > is a pointer to const data, 'p' points to > modifiable data. This is just reordered. unsigned char const * == const unsigned char *. Joerg From brde at optusnet.com.au Fri Jan 4 17:04:24 2008 From: brde at optusnet.com.au (Bruce Evans) Date: Fri Jan 4 17:04:31 2008 Subject: cvs commit: src/lib/libarchive archive_endian.h archive_read_support_format_zip.c In-Reply-To: <477E71F1.4080301@freebsd.org> References: <200801031830.m03IUb9K049549@repoman.freebsd.org> <477E71F1.4080301@freebsd.org> Message-ID: <20080105115225.T23063@delplex.bde.org> On Fri, 4 Jan 2008, Tim Kientzle wrote: > Dag-Erling Smorgrav wrote: >> ... >> 1.1 +142 -0 src/lib/libarchive/archive_endian.h (new) >> 1.19 +22 -57 src/lib/libarchive/archive_read_support_format_zip.c > > Is this really right? > >> +be32dec(const void *pp) >> +{ >> + unsigned char const *p = (unsigned char const *)pp; > > The "const *" is harmless enough, but dropping the > leading "const" doesn't seem right at all: 'pp' > is a pointer to const data, 'p' points to > modifiable data. Um, both point to const data. `unsigned char * const p' would point to non-const data, and casting to that should cause a diagnostic. This is just a style bug -- the const qualifier is placed in the usual but confusing place for pp and in the unusual but easier to understand place for p. Other bugs in the above include namespace pollution (at least for the original copy in ) -- both p and pp are in the application namespace. This bug is missing in older MD endian.h code. Bruce From jeff at FreeBSD.org Fri Jan 4 20:47:32 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Fri Jan 4 20:47:34 2008 Subject: cvs commit: src/sys/kern sched_ule.c Message-ID: <200801050447.m054lV7N014780@repoman.freebsd.org> jeff 2008-01-05 04:47:31 UTC FreeBSD src repository Modified files: sys/kern sched_ule.c Log: - Restore timeslicing code for all bit SCHED_FIFO priority classes. Reported by: Peter Jeremy Revision Changes Path 1.221 +9 -10 src/sys/kern/sched_ule.c From peter at FreeBSD.org Sat Jan 5 00:35:57 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Sat Jan 5 00:36:00 2008 Subject: cvs commit: src/sys/kern imgact_elf.c Message-ID: <200801050835.m058Zuo3039115@repoman.freebsd.org> peter 2008-01-05 08:35:56 UTC FreeBSD src repository Modified files: sys/kern imgact_elf.c Log: Fall back to the binary-specified interpreter (ld-elf.so.1) if the ABI override binary isn't found. This could probably be smoother, but it is what I did in p4 change #126891 on 2007/09/27. It should solve the "ld-elf32.so.1"-in-chroot problem. Revision Changes Path 1.183 +10 -4 src/sys/kern/imgact_elf.c From bde at FreeBSD.org Sat Jan 5 00:54:52 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Sat Jan 5 00:54:54 2008 Subject: cvs commit: src/sys/kern vfs_vnops.c Message-ID: <200801050854.m058sqBj050791@repoman.freebsd.org> bde 2008-01-05 08:54:52 UTC FreeBSD src repository Modified files: sys/kern vfs_vnops.c Log: In sequential_heuristic(): - spell 16384 as 16384 and not as BKVASIZE. 16384 is (not quite) just a magic size that works well in practice. BKVASIZE should be MAXBSIZE (65536), but is 16384 because i386's don't have enough kva for it to be MAXBSIZE; 16384 works (not so well) for it for much the same reasons that it works well in the heuristic. - expand and/or add comments about this and other details. - don't explicitly inline this function. - fix some other style bugs. Revision Changes Path 1.255 +20 -13 src/sys/kern/vfs_vnops.c From kib at FreeBSD.org Sat Jan 5 04:36:35 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Sat Jan 5 04:36:37 2008 Subject: cvs commit: src/sys/compat/linux linux_stats.c Message-ID: <200801051236.m05CaZjs088208@repoman.freebsd.org> kib 2008-01-05 12:36:35 UTC FreeBSD src repository Modified files: sys/compat/linux linux_stats.c Log: After applying LCONVPATH() to the path, do use the converted path instead of original user-mode string in the linux_stat() and linux_lstat() syscalls. Tested by: Peter Holm MFC after: 3 days Revision Changes Path 1.90 +13 -9 src/sys/compat/linux/linux_stats.c From grog at FreeBSD.org Sat Jan 5 13:39:22 2008 From: grog at FreeBSD.org (Greg Lehey) Date: Sat Jan 5 13:39:24 2008 Subject: cvs commit: src/share/man/man9 style.9 Message-ID: <200801052139.m05LdMpW032336@repoman.freebsd.org> grog 2008-01-05 21:39:22 UTC FreeBSD src repository Modified files: share/man/man9 style.9 Log: "redacted" replaced for clarity. Revision Changes Path 1.124 +1 -1 src/share/man/man9/style.9 From marius at FreeBSD.org Sat Jan 5 14:58:51 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Sat Jan 5 14:58:53 2008 Subject: cvs commit: src/contrib/gcc gthr-posix.h Message-ID: <200801052258.m05MwpUL045503@repoman.freebsd.org> marius 2008-01-05 22:58:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) contrib/gcc gthr-posix.h Log: On FreeBSD GCC 4.2.x checks for the existence of pthread_cancel() in order to determine whether a program is running with multithreading support. This check causes __gthread_active_p() to always return 1 however, regardless of whether the program was actually compiled with -pthread or not, due to the fact that the FreeBSD libc contains a pthread_cancel() stub. Fix this by using the __gthread_active_p() version that GCC uses for Solaris and which actively checks for a working POSIX threads implementation (if such functions exist) instead of checking for the mere existence of corresponding functions. On platforms without TLS support, i.e. on arm and sparc64 due to the lack of GNU TLS support for these archs in binutils 2.15., the false positives returned by __gthread_active_p() for non-threaded programs cause the exception handling implementation GCC uses in this case to crash. This is because GCC assumes that the POSIX threading functions actually work when __gthread_active_p() returns 1 while in fact the corresponding stubs in libc just immediately return. Given that __gthread_active_p() is also used in a couple of other places besides exception handling, this bug has great potential to also cause problems in other areas and on all archs. This is committed to RELENG_7 directly in order to get a fix into RELENG_7_0 as soon as possible while allowing to loop the official fix back into the vendor branch and not taking gthr-posix.h off the vendor branch in HEAD. PR: 119289 Reviewed by: obrien (plus style fix) Approved by: re (kensmith) Revision Changes Path 1.1.1.8.2.1 +7 -4 src/contrib/gcc/gthr-posix.h From marius at FreeBSD.org Sat Jan 5 15:05:00 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Sat Jan 5 15:05:02 2008 Subject: cvs commit: src/contrib/gcc gthr-posix.h Message-ID: <200801052305.m05N50pX048001@repoman.freebsd.org> marius 2008-01-05 23:05:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) contrib/gcc gthr-posix.h Log: Merge from RELENG_7: 1.1.1.8.2.1 On FreeBSD GCC 4.2.x checks for the existence of pthread_cancel() in order to determine whether a program is running with multithreading support. This check causes __gthread_active_p() to always return 1 however, regardless of whether the program was actually compiled with -pthread or not, due to the fact that the FreeBSD libc contains a pthread_cancel() stub. Fix this by using the __gthread_active_p() version that GCC uses for Solaris and which actively checks for a working POSIX threads implementation (if such functions exist) instead of checking for the mere existence of corresponding functions. On platforms without TLS support, i.e. on arm and sparc64 due to the lack of GNU TLS support for these archs in binutils 2.15., the false positives returned by __gthread_active_p() for non-threaded programs cause the exception handling implementation GCC uses in this case to crash. This is because GCC assumes that the POSIX threading functions actually work when __gthread_active_p() returns 1 while in fact the corresponding stubs in libc just immediately return. Given that __gthread_active_p() is also used in a couple of other places besides exception handling, this bug has great potential to also cause problems in other areas and on all archs. Approved by: re (kensmith) Revision Changes Path 1.1.1.8.4.1 +7 -4 src/contrib/gcc/gthr-posix.h From brueffer at FreeBSD.org Sat Jan 5 15:21:34 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Sat Jan 5 15:21:36 2008 Subject: cvs commit: src/share/man/man4 pci.4 Message-ID: <200801052321.m05NLXu3072184@repoman.freebsd.org> brueffer 2008-01-05 23:21:32 UTC FreeBSD src repository Modified files: share/man/man4 pci.4 Log: Clean up after previous commit (typo fixes, removed contractions, utilized .Tn and capitalized PCI). Revision Changes Path 1.21 +18 -6 src/share/man/man4/pci.4 From brueffer at FreeBSD.org Sat Jan 5 15:28:00 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Sat Jan 5 15:28:02 2008 Subject: cvs commit: src/share/man/man4 pcib.4 Message-ID: <200801052328.m05NS03o073088@repoman.freebsd.org> brueffer 2008-01-05 23:27:59 UTC FreeBSD src repository Modified files: share/man/man4 pcib.4 Log: Use our standard section 4 SYNOPSIS, utilize .Tn and fix capitalization. Revision Changes Path 1.2 +11 -3 src/share/man/man4/pcib.4 From brueffer at FreeBSD.org Sat Jan 5 15:41:16 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Sat Jan 5 15:41:19 2008 Subject: cvs commit: src/share/man/man4 ng_pppoe.4 Message-ID: <200801052341.m05NfFZQ075050@repoman.freebsd.org> brueffer 2008-01-05 23:41:15 UTC FreeBSD src repository Modified files: share/man/man4 ng_pppoe.4 Log: mdoc and language fixes for the previous commit, also bump .Dd. Revision Changes Path 1.41 +5 -4 src/share/man/man4/ng_pppoe.4 From edwin at FreeBSD.org Sat Jan 5 23:13:36 2008 From: edwin at FreeBSD.org (Edwin Groothuis) Date: Sat Jan 5 23:13:39 2008 Subject: cvs commit: src/share/misc iso3166 Message-ID: <200801060713.m067DZJB059447@repoman.freebsd.org> edwin 2008-01-06 07:13:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) share/misc iso3166 Log: Update iso3166 with the data from Newsletter VI-1 2007-09-21: Added SAINT BARTHELEMY (BL) and SAINT MARTIN (MF). Approved by: re (ken smith) Revision Changes Path 1.13.2.2 +5 -0 src/share/misc/iso3166 From edwin at FreeBSD.org Sat Jan 5 23:22:12 2008 From: edwin at FreeBSD.org (Edwin Groothuis) Date: Sat Jan 5 23:22:14 2008 Subject: cvs commit: src/share/misc iso3166 Message-ID: <200801060722.m067MCbn060760@repoman.freebsd.org> edwin 2008-01-06 07:22:12 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/misc iso3166 Log: Update iso3166 with the data from Newsletter VI-1 2007-09-21: Added SAINT BARTHELEMY (BL) and SAINT MARTIN (MF). MFC of rev 1.17 Approved by: re (ken smith) Revision Changes Path 1.13.8.3 +5 -0 src/share/misc/iso3166 From edwin at FreeBSD.org Sat Jan 5 23:23:48 2008 From: edwin at FreeBSD.org (Edwin Groothuis) Date: Sat Jan 5 23:23:50 2008 Subject: cvs commit: src/share/misc iso3166 Message-ID: <200801060723.m067NlmC061157@repoman.freebsd.org> edwin 2008-01-06 07:23:47 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) share/misc iso3166 Log: Update iso3166 with the data from Newsletter VI-1 2007-09-21: Added SAINT BARTHELEMY (BL) and SAINT MARTIN (MF). MFC of rev 1.17 Approved by: re (ken smith) Revision Changes Path 1.13.8.2.4.1 +5 -0 src/share/misc/iso3166 From edwin at FreeBSD.org Sat Jan 5 23:25:02 2008 From: edwin at FreeBSD.org (Edwin Groothuis) Date: Sat Jan 5 23:25:04 2008 Subject: cvs commit: src/share/misc iso3166 Message-ID: <200801060725.m067P0K1061212@repoman.freebsd.org> edwin 2008-01-06 07:25:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/misc iso3166 Log: Update iso3166 with the data from Newsletter VI-1 2007-09-21: Added SAINT BARTHELEMY (BL) and SAINT MARTIN (MF). MFC of rev 1.17 Approved by: re (ken smith) Revision Changes Path 1.15.2.1 +5 -0 src/share/misc/iso3166 From edwin at FreeBSD.org Sat Jan 5 23:25:43 2008 From: edwin at FreeBSD.org (Edwin Groothuis) Date: Sat Jan 5 23:25:46 2008 Subject: cvs commit: src/share/misc iso3166 Message-ID: <200801060725.m067Ph59061293@repoman.freebsd.org> edwin 2008-01-06 07:25:43 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) share/misc iso3166 Log: Update iso3166 with the data from Newsletter VI-1 2007-09-21: Added SAINT BARTHELEMY (BL) and SAINT MARTIN (MF). MFC of rev 1.17 Approved by: re (ken smith) Revision Changes Path 1.15.4.1 +5 -0 src/share/misc/iso3166 From edwin at FreeBSD.org Sat Jan 5 23:30:04 2008 From: edwin at FreeBSD.org (Edwin Groothuis) Date: Sat Jan 5 23:30:07 2008 Subject: cvs commit: src/share/zoneinfo asia backward europe northamerica southamerica zone.tab Message-ID: <200801060730.m067U4ED061459@repoman.freebsd.org> edwin 2008-01-06 07:30:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) share/zoneinfo asia backward europe northamerica southamerica zone.tab Log: MFC of tzdata2007k. Approved by: re (ken smith) Revision Changes Path 1.24.4.10 +10 -1 src/share/zoneinfo/asia 1.1.2.10.4.7 +2 -1 src/share/zoneinfo/backward 1.27.4.8 +1 -2 src/share/zoneinfo/europe 1.23.4.10 +5 -1 src/share/zoneinfo/northamerica 1.22.4.10 +48 -22 src/share/zoneinfo/southamerica 1.16.4.6 +4 -3 src/share/zoneinfo/zone.tab From edwin at FreeBSD.org Sat Jan 5 23:33:14 2008 From: edwin at FreeBSD.org (Edwin Groothuis) Date: Sat Jan 5 23:33:17 2008 Subject: cvs commit: src/share/zoneinfo asia backward europe northamerica southamerica zone.tab Message-ID: <200801060733.m067XEc7062692@repoman.freebsd.org> edwin 2008-01-06 07:33:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/zoneinfo asia backward europe northamerica southamerica zone.tab Log: MFC of tzdata2007k. Approved by: re (ken smith) Revision Changes Path 1.25.2.7 +10 -1 src/share/zoneinfo/asia 1.1.2.11.2.6 +2 -1 src/share/zoneinfo/backward 1.29.2.6 +1 -2 src/share/zoneinfo/europe 1.25.2.6 +5 -1 src/share/zoneinfo/northamerica 1.24.2.7 +48 -22 src/share/zoneinfo/southamerica 1.17.2.5 +4 -3 src/share/zoneinfo/zone.tab From edwin at FreeBSD.org Sat Jan 5 23:34:16 2008 From: edwin at FreeBSD.org (Edwin Groothuis) Date: Sat Jan 5 23:34:18 2008 Subject: cvs commit: src/share/zoneinfo asia backward europe northamerica southamerica zone.tab Message-ID: <200801060734.m067YGh3062776@repoman.freebsd.org> edwin 2008-01-06 07:34:16 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) share/zoneinfo asia backward europe northamerica southamerica zone.tab Log: MFC of tzdata2007k. Approved by: re (ken smith) Revision Changes Path 1.25.2.6.2.1 +10 -1 src/share/zoneinfo/asia 1.1.2.11.2.5.2.1 +2 -1 src/share/zoneinfo/backward 1.29.2.5.2.1 +1 -2 src/share/zoneinfo/europe 1.25.2.5.2.1 +5 -1 src/share/zoneinfo/northamerica 1.24.2.6.2.1 +48 -22 src/share/zoneinfo/southamerica 1.17.2.4.2.1 +4 -3 src/share/zoneinfo/zone.tab From edwin at FreeBSD.org Sat Jan 5 23:35:14 2008 From: edwin at FreeBSD.org (Edwin Groothuis) Date: Sat Jan 5 23:35:16 2008 Subject: cvs commit: src/share/zoneinfo asia backward europe northamerica southamerica zone.tab Message-ID: <200801060735.m067ZEMP062890@repoman.freebsd.org> edwin 2008-01-06 07:35:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/zoneinfo asia backward europe northamerica southamerica zone.tab Log: MFC of tzdata2007k. Approved by: re (ken smith) Revision Changes Path 1.33.2.1 +10 -1 src/share/zoneinfo/asia 1.1.2.17.2.1 +2 -1 src/share/zoneinfo/backward 1.35.2.1 +1 -2 src/share/zoneinfo/europe 1.33.2.1 +5 -1 src/share/zoneinfo/northamerica 1.31.2.1 +48 -22 src/share/zoneinfo/southamerica 1.22.2.1 +4 -3 src/share/zoneinfo/zone.tab From edwin at FreeBSD.org Sat Jan 5 23:36:09 2008 From: edwin at FreeBSD.org (Edwin Groothuis) Date: Sat Jan 5 23:36:11 2008 Subject: cvs commit: src/share/zoneinfo asia backward europe northamerica southamerica zone.tab Message-ID: <200801060736.m067a9Rl062937@repoman.freebsd.org> edwin 2008-01-06 07:36:08 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) share/zoneinfo asia backward europe northamerica southamerica zone.tab Log: MFC of tzdata2007k. Approved by: re (ken smith) Revision Changes Path 1.33.4.1 +10 -1 src/share/zoneinfo/asia 1.1.2.17.4.1 +2 -1 src/share/zoneinfo/backward 1.35.4.1 +1 -2 src/share/zoneinfo/europe 1.33.4.1 +5 -1 src/share/zoneinfo/northamerica 1.31.4.1 +48 -22 src/share/zoneinfo/southamerica 1.22.4.1 +4 -3 src/share/zoneinfo/zone.tab From edwin at mavetju.org Sat Jan 5 23:37:17 2008 From: edwin at mavetju.org (Edwin Groothuis) Date: Sat Jan 5 23:37:23 2008 Subject: cvs commit: src/share/zoneinfo europe southamerica zone.tab In-Reply-To: <477C245A.1070502@FreeBSD.org> References: <200801010747.m017lg7T045831@repoman.freebsd.org> <477C245A.1070502@FreeBSD.org> Message-ID: <20080106073714.GA95177@k7.mavetju> On Wed, Jan 02, 2008 at 03:55:06PM -0800, Maxim Sobolev wrote: > Can you please get this merged into RELENG_6_3 and RELENG_7_0? This is > quite critical for many users, for example we've got a call from one > customer already. Done now. Edwin -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://www.mavetju.org/weblog/ From phk at FreeBSD.org Sun Jan 6 04:12:47 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Sun Jan 6 04:12:49 2008 Subject: cvs commit: src/usr.sbin/gstat gstat.c Message-ID: <200801061212.m06CCjON027649@repoman.freebsd.org> phk 2008-01-06 12:12:44 UTC FreeBSD src repository Modified files: usr.sbin/gstat gstat.c Log: When the ms/req fields exceed 1 second, drop the fractions to fit more digits. This is unfortunately necessary with some flash based devices which can get hundreds of seconds behind with softupdates enabled. Revision Changes Path 1.15 +12 -3 src/usr.sbin/gstat/gstat.c From cperciva at freebsd.org Sun Jan 6 05:39:58 2008 From: cperciva at freebsd.org (Colin Percival) Date: Sun Jan 6 05:40:03 2008 Subject: cvs commit: src/usr.sbin/gstat gstat.c In-Reply-To: <200801061212.m06CCjON027649@repoman.freebsd.org> References: <200801061212.m06CCjON027649@repoman.freebsd.org> Message-ID: <4780CC1B.8090708@freebsd.org> Poul-Henning Kamp wrote: > When the ms/req fields exceed 1 second, drop the fractions to fit more digits. > > This is unfortunately necessary with some flash based devices which can > get hundreds of seconds behind with softupdates enabled. I'm curious, why is this an issue with flash devices? Given their famous ability to perform large numbers of transactions per second, I would have expected flash-based drives to be the least likely to have this problem. Colin Percival From des at des.no Sun Jan 6 09:07:00 2008 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Sun Jan 6 09:07:04 2008 Subject: cvs commit: src/usr.sbin/gstat gstat.c In-Reply-To: <4780CC1B.8090708@freebsd.org> (Colin Percival's message of "Sun\, 06 Jan 2008 04\:39\:55 -0800") References: <200801061212.m06CCjON027649@repoman.freebsd.org> <4780CC1B.8090708@freebsd.org> Message-ID: <86d4se6fyt.fsf@ds4.des.no> Colin Percival writes: > I'm curious, why is this an issue with flash devices? Given their famous > ability to perform large numbers of transactions per second, I would have > expected flash-based drives to be the least likely to have this problem. three words: erase before write DES -- Dag-Erling Sm?rgrav - des@des.no From phk at phk.freebsd.dk Sun Jan 6 09:13:02 2008 From: phk at phk.freebsd.dk (Poul-Henning Kamp) Date: Sun Jan 6 09:13:06 2008 Subject: cvs commit: src/usr.sbin/gstat gstat.c In-Reply-To: Your message of "Sun, 06 Jan 2008 04:39:55 PST." <4780CC1B.8090708@freebsd.org> Message-ID: <1767.1199639579@critter.freebsd.dk> In message <4780CC1B.8090708@freebsd.org>, Colin Percival writes: >Poul-Henning Kamp wrote: >> When the ms/req fields exceed 1 second, drop the fractions to fit more digits. >> >> This is unfortunately necessary with some flash based devices which can >> get hundreds of seconds behind with softupdates enabled. > >I'm curious, why is this an issue with flash devices? Given their famous >ability to perform large numbers of transactions per second, I would have >expected flash-based drives to be the least likely to have this problem. The problem is flash-devices which are built (mostly) for cameras, their (cheap-ass) flash-adaptation-layer performs great for physically sequential writes for big files, and they fall totally apart with random writes to things like UFS/FFS inodes and bitmaps. Pretty much all of the layout optimizations in UFS/FFS are pessimizations for Flash devices. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From imp at bsdimp.com Sun Jan 6 09:15:54 2008 From: imp at bsdimp.com (M. Warner Losh) Date: Sun Jan 6 09:15:57 2008 Subject: cvs commit: src/usr.sbin/gstat gstat.c In-Reply-To: <4780CC1B.8090708@freebsd.org> References: <200801061212.m06CCjON027649@repoman.freebsd.org> <4780CC1B.8090708@freebsd.org> Message-ID: <20080106.101458.1645169504.imp@bsdimp.com> In message: <4780CC1B.8090708@freebsd.org> Colin Percival writes: : Poul-Henning Kamp wrote: : > When the ms/req fields exceed 1 second, drop the fractions to fit more digits. : > : > This is unfortunately necessary with some flash based devices which can : > get hundreds of seconds behind with softupdates enabled. : : I'm curious, why is this an issue with flash devices? Given their famous : ability to perform large numbers of transactions per second, I would have : expected flash-based drives to be the least likely to have this problem. Flash is fast for read, but not so fast for write. Maybe some of the cool SSD drives solve this problem, but raw flash devices are relatively slow. Of course, there's a large range of performance in even the SD/CF cards in the market today. Also, our USB stack can cause backlogs when writing to even disks that are several seconds. Especially when large numbers of writes hit it. Warner From phk at phk.freebsd.dk Sun Jan 6 09:22:40 2008 From: phk at phk.freebsd.dk (Poul-Henning Kamp) Date: Sun Jan 6 09:23:01 2008 Subject: cvs commit: src/usr.sbin/gstat gstat.c In-Reply-To: Your message of "Sun, 06 Jan 2008 18:06:50 +0100." <86d4se6fyt.fsf@ds4.des.no> Message-ID: <1877.1199640153@critter.freebsd.dk> In message <86d4se6fyt.fsf@ds4.des.no>, =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= wr ites: >Colin Percival writes: >> I'm curious, why is this an issue with flash devices? Given their famous >> ability to perform large numbers of transactions per second, I would have >> expected flash-based drives to be the least likely to have this problem. > >three words: erase before write That's not all of it, but it would most likely help, yes. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From alc at FreeBSD.org Sun Jan 6 10:51:05 2008 From: alc at FreeBSD.org (Alan Cox) Date: Sun Jan 6 10:51:07 2008 Subject: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/amd64/include pmap.h src/sys/i386/i386 pmap.c src/sys/i386/include pmap.h Message-ID: <200801061851.m06Ip5Vh035949@repoman.freebsd.org> alc 2008-01-06 18:51:04 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c sys/amd64/include pmap.h sys/i386/i386 pmap.c sys/i386/include pmap.h Log: Shrink the size of struct vm_page on amd64 and i386 by eliminating pv_list_count from struct md_page. Ever since Peter rewrote the pv entry allocator for amd64 and i386 pv_list_count has been correctly maintained but otherwise unused. Revision Changes Path 1.602 +0 -7 src/sys/amd64/amd64/pmap.c 1.139 +0 -1 src/sys/amd64/include/pmap.h 1.605 +0 -7 src/sys/i386/i386/pmap.c 1.130 +0 -1 src/sys/i386/include/pmap.h From peter at FreeBSD.org Sun Jan 6 16:01:20 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Sun Jan 6 16:01:21 2008 Subject: cvs commit: CVSROOT config Message-ID: <200801070001.m0701J6A015527@repoman.freebsd.org> peter 2008-01-07 00:01:19 UTC FreeBSD src repository Modified files: . config Log: Add cvs-1.12-friendly $FreeBSD$ expansion controls. This is believed to not interfere with our cvs-1.11, but it (and cvsup) will ignore it. PR: 71098 Submitted by: Jeroen Ruigrok van der Werven Revision Changes Path 1.4 +5 -1 CVSROOT/config From cognet at FreeBSD.org Sun Jan 6 16:36:10 2008 From: cognet at FreeBSD.org (Olivier Houchard) Date: Sun Jan 6 16:36:13 2008 Subject: cvs commit: src/sys/arm/at91 if_ate.c Message-ID: <200801070036.m070a9UT022699@repoman.freebsd.org> cognet 2008-01-07 00:36:09 UTC FreeBSD src repository Modified files: sys/arm/at91 if_ate.c Log: Add a missing \n. Revision Changes Path 1.23 +1 -1 src/sys/arm/at91/if_ate.c From kmacy at FreeBSD.org Sun Jan 6 17:18:17 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sun Jan 6 17:18:20 2008 Subject: cvs commit: src/sys/dev/cxgb/sys mvec.h uipc_mvec.c Message-ID: <200801070118.m071IG7o038642@repoman.freebsd.org> kmacy 2008-01-07 01:18:16 UTC FreeBSD src repository Modified files: sys/dev/cxgb/sys mvec.h uipc_mvec.c Log: Fix mvec code to handle the case of the packet zone this was missed in the initial import Revision Changes Path 1.9 +1 -0 src/sys/dev/cxgb/sys/mvec.h 1.16 +15 -4 src/sys/dev/cxgb/sys/uipc_mvec.c From davidxu at FreeBSD.org Sun Jan 6 18:26:30 2008 From: davidxu at FreeBSD.org (David Xu) Date: Sun Jan 6 18:26:32 2008 Subject: cvs commit: src/lib/libthr/thread thr_sem.c Message-ID: <200801070226.m072QTfe062447@repoman.freebsd.org> davidxu 2008-01-07 02:26:29 UTC FreeBSD src repository Modified files: lib/libthr/thread thr_sem.c Log: sem_post() requires to return -1 on error. Revision Changes Path 1.13 +2 -2 src/lib/libthr/thread/thr_sem.c From peter at FreeBSD.org Sun Jan 6 19:39:45 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Sun Jan 6 19:39:47 2008 Subject: cvs commit: CVSROOT approvecheck Message-ID: <200801070339.m073di3A075051@repoman.freebsd.org> peter 2008-01-07 03:39:44 UTC FreeBSD src repository Modified files: . approvecheck Log: So, it turns out that the information in the PR referenced in the previous commit was in error. cvs-1.11 does NOT like the cvs-1.12 keywords config hooks and has a fatal error. PR: 71098 Submitted by: Jeroen Ruigrok van der Werven Pointy hat to: peter (for believing the submitter) Revision Changes Path 1.3 +9 -7 CVSROOT/approvecheck From peter at FreeBSD.org Sun Jan 6 19:43:23 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Sun Jan 6 19:43:25 2008 Subject: cvs commit: CVSROOT config Message-ID: <200801070343.m073hMPS076036@repoman.freebsd.org> peter 2008-01-07 03:43:22 UTC FreeBSD src repository Modified files: . config Log: So, it turns out that the information in the PR referenced in the previous commit was not entirely correct. cvs-1.11 does object to the cvs-1.12 style keywords config hooks. It doesn't explode, but it yells loudly. Comment out. PR: 71098 Revision Changes Path 1.5 +2 -2 CVSROOT/config From peter at wemm.org Sun Jan 6 20:11:56 2008 From: peter at wemm.org (Peter Wemm) Date: Sun Jan 6 20:11:59 2008 Subject: cvs commit: CVSROOT approvecheck In-Reply-To: <200801070339.m073di3A075051@repoman.freebsd.org> References: <200801070339.m073di3A075051@repoman.freebsd.org> Message-ID: On 1/6/08, Peter Wemm wrote: > > peter 2008-01-07 03:39:44 UTC > > Modified files: > . approvecheck Oops. This never happened. Pointy hat to me! -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From peter at FreeBSD.org Sun Jan 6 23:47:22 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Sun Jan 6 23:47:24 2008 Subject: cvs commit: src/contrib/cvs/src parseinfo.c Message-ID: <200801070747.m077lLvK031681@repoman.freebsd.org> peter 2008-01-07 07:47:21 UTC FreeBSD src repository Modified files: contrib/cvs/src parseinfo.c Log: Add a forward compatability hook so that current cvs can recognize future CVSROOT/config file options that control keyword expansion. cvs-1.12 has its own $Id$ expansion controls and they're configured in CVSROOT/config rather than CVSROOT/options. The problem is that current cvs-1.11.x doesn't understand the future keywords..... Add trivial forward support for the new keywords for when cvs-1.12 hits the tree down the road. CVSROOT/options won't be going away - cvsup uses it. Revision Changes Path 1.4 +10 -0 src/contrib/cvs/src/parseinfo.c From peter at FreeBSD.org Mon Jan 7 01:02:04 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Mon Jan 7 01:02:06 2008 Subject: cvs commit: src/contrib/cvs/src parseinfo.c Message-ID: <200801070902.m07923fS058164@repoman.freebsd.org> peter 2008-01-07 09:02:02 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) contrib/cvs/src parseinfo.c Log: MFC: rev 1.4: forward compatability with cvs-1.12 repository Approved by: re (kensmith) Revision Changes Path 1.3.18.1 +11 -1 src/contrib/cvs/src/parseinfo.c From peter at FreeBSD.org Mon Jan 7 01:07:34 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Mon Jan 7 01:07:36 2008 Subject: cvs commit: src/contrib/cvs/src parseinfo.c Message-ID: <200801070907.m0797YeS059922@repoman.freebsd.org> peter 2008-01-07 09:07:34 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) contrib/cvs/src parseinfo.c Log: MFC: rev 1.4: forward compatability with cvs-1.12 repository Approved by: re (kensmith) Revision Changes Path 1.3.22.1 +11 -1 src/contrib/cvs/src/parseinfo.c From peter at FreeBSD.org Mon Jan 7 01:08:05 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Mon Jan 7 01:08:07 2008 Subject: cvs commit: src/contrib/cvs/src parseinfo.c Message-ID: <200801070908.m07985wP059972@repoman.freebsd.org> peter 2008-01-07 09:08:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) contrib/cvs/src parseinfo.c Log: MFC: rev 1.4: forward compatability with cvs-1.12 repository Approved by: re (kensmith) Revision Changes Path 1.3.8.1 +11 -1 src/contrib/cvs/src/parseinfo.c From peter at FreeBSD.org Mon Jan 7 01:08:53 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Mon Jan 7 01:08:56 2008 Subject: cvs commit: src/contrib/cvs/src parseinfo.c Message-ID: <200801070908.m0798rpX060023@repoman.freebsd.org> peter 2008-01-07 09:08:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) contrib/cvs/src parseinfo.c Log: MFC: rev 1.4: forward compatability with cvs-1.12 repository Approved by: re (kensmith) Revision Changes Path 1.3.20.1 +11 -1 src/contrib/cvs/src/parseinfo.c From peter at FreeBSD.org Mon Jan 7 01:09:25 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Mon Jan 7 01:09:26 2008 Subject: cvs commit: src/contrib/cvs/src parseinfo.c Message-ID: <200801070909.m0799PnS060061@repoman.freebsd.org> peter 2008-01-07 09:09:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) contrib/cvs/src parseinfo.c Log: MFC: rev 1.4: forward compatability with cvs-1.12 repository Revision Changes Path 1.3.2.1 +11 -1 src/contrib/cvs/src/parseinfo.c From peter at FreeBSD.org Mon Jan 7 01:10:09 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Mon Jan 7 01:10:11 2008 Subject: cvs commit: src/contrib/cvs/src parseinfo.c Message-ID: <200801070910.m079A8sW060155@repoman.freebsd.org> peter 2008-01-07 09:10:08 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) contrib/cvs/src parseinfo.c Log: MFC: rev 1.4: forward compatability with cvs-1.12 repository Revision Changes Path 1.1.1.7.2.6 +11 -1 src/contrib/cvs/src/parseinfo.c From peter at FreeBSD.org Mon Jan 7 01:11:24 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Mon Jan 7 01:11:27 2008 Subject: cvs commit: src/contrib/cvs/src parseinfo.c Message-ID: <200801070911.m079BON6060710@repoman.freebsd.org> peter 2008-01-07 09:11:23 UTC FreeBSD src repository Modified files: (Branch: RELENG_3) contrib/cvs/src parseinfo.c Log: MFC: rev 1.4: forward compatability with cvs-1.12 repository Revision Changes Path 1.1.1.5.2.3 +10 -0 src/contrib/cvs/src/parseinfo.c From kevlo at FreeBSD.org Mon Jan 7 01:14:38 2008 From: kevlo at FreeBSD.org (Kevin Lo) Date: Mon Jan 7 01:14:42 2008 Subject: cvs commit: src/sys/dev/usb if_rum.c usbdevs Message-ID: <200801070914.m079EcAO061499@repoman.freebsd.org> kevlo 2008-01-07 09:14:38 UTC FreeBSD src repository Modified files: sys/dev/usb if_rum.c usbdevs Log: Add the SparkLAN RT2573, found in HP s3200n Obtained from: OpenBSD Revision Changes Path 1.16 +1 -0 src/sys/dev/usb/if_rum.c 1.337 +4 -0 src/sys/dev/usb/usbdevs From des at FreeBSD.org Mon Jan 7 01:46:40 2008 From: des at FreeBSD.org (Dag-Erling Smorgrav) Date: Mon Jan 7 01:46:43 2008 Subject: cvs commit: src/sys/dev/ichwd ichwd.c ichwd.h Message-ID: <200801070946.m079kdUb066402@repoman.freebsd.org> des 2008-01-07 09:46:39 UTC FreeBSD src repository Modified files: sys/dev/ichwd ichwd.c ichwd.h Log: Add support for ICH8M. PR: kern/119351 Submitted by: Takeharu KATO MFC after: 1 week Revision Changes Path 1.14 +1 -0 src/sys/dev/ichwd/ichwd.c 1.8 +1 -0 src/sys/dev/ichwd/ichwd.h From marck at rinet.ru Mon Jan 7 02:14:38 2008 From: marck at rinet.ru (Dmitry Morozovsky) Date: Mon Jan 7 02:14:45 2008 Subject: cvs commit: src/contrib/cvs/src parseinfo.c In-Reply-To: <200801070747.m077lLvK031681@repoman.freebsd.org> References: <200801070747.m077lLvK031681@repoman.freebsd.org> Message-ID: <20080107125523.K55592@woozle.rinet.ru> Dear Peter, On Mon, 7 Jan 2008, Peter Wemm wrote: PW> peter 2008-01-07 07:47:21 UTC PW> PW> FreeBSD src repository PW> PW> Modified files: PW> contrib/cvs/src parseinfo.c PW> Log: PW> Add a forward compatability hook so that current cvs can recognize future PW> CVSROOT/config file options that control keyword expansion. cvs-1.12 has PW> its own $Id$ expansion controls and they're configured in CVSROOT/config PW> rather than CVSROOT/options. The problem is that current cvs-1.11.x PW> doesn't understand the future keywords..... PW> PW> Add trivial forward support for the new keywords for when cvs-1.12 PW> hits the tree down the road. CVSROOT/options won't be going away - cvsup PW> uses it. As you finally touch the beast [tm], would you please consider fixing long-standed bug (see attachment) I reported to CVSHome long ago? Thank you in advance. Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] [ FreeBSD committer: marck@FreeBSD.org ] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------ -------------- next part -------------- A non-text attachment was scrubbed... Name: cvs-update-entries.patch Type: text/x-diff Size: 1152 bytes Desc: Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080107/6dca0640/cvs-update-entries.bin From schweikh at FreeBSD.org Mon Jan 7 02:31:18 2008 From: schweikh at FreeBSD.org (Jens Schweikhardt) Date: Mon Jan 7 02:31:24 2008 Subject: cvs commit: src/games/fortune/datfiles limerick Message-ID: <200801071031.m07AVICh082383@repoman.freebsd.org> schweikh 2008-01-07 10:31:17 UTC FreeBSD src repository Modified files: games/fortune/datfiles limerick Log: Typo; s/relied/replied Revision Changes Path 1.15 +1 -1 src/games/fortune/datfiles/limerick From weongyo at FreeBSD.org Mon Jan 7 03:31:55 2008 From: weongyo at FreeBSD.org (Weongyo Jeong) Date: Mon Jan 7 03:31:57 2008 Subject: cvs commit: src/sys/dev/usb if_zyd.c Message-ID: <200801071131.m07BVtlW094396@repoman.freebsd.org> weongyo 2008-01-07 11:31:55 UTC FreeBSD src repository Modified files: sys/dev/usb if_zyd.c Log: Fix incorrect dependencies of zyd(4). Approved by: thompsa (mentor) Revision Changes Path 1.12 +3 -3 src/sys/dev/usb/if_zyd.c From gabor at FreeBSD.org Mon Jan 7 06:40:58 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Mon Jan 7 06:41:03 2008 Subject: cvs commit: src/share/man/man4 edsc.4 In-Reply-To: <20080104164700.GA51866@tirith.brixandersen.dk> References: <200801041255.m04Ct2pk092187@repoman.freebsd.org> <20080104164700.GA51866@tirith.brixandersen.dk> Message-ID: <47823606.8030108@FreeBSD.org> Henrik Brix Andersen escribi?: > On Fri, Jan 04, 2008 at 12:55:02PM +0000, Gabor Kovesdan wrote: > >> gabor 2008-01-04 12:55:02 UTC >> >> FreeBSD src repository (doc,ports committer) >> >> Modified files: >> share/man/man4 edsc.4 >> Log: >> - This driver will first appear in 6.3, not 7.0 >> >> MFC after: 0 days >> > > Is it just me, or wasn't ipmi(4) part of FreeBSD 6.2? > > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/ipmi/ipmi.c?only_with_tag=RELENG_6_2_0_RELEASE > > Brix > Thanks for noting this. I've just mailed re@ for approval to change it again. Cheers, -- Gabor Kovesdan FreeBSD Volunteer EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org WEB: http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org From gabor at FreeBSD.org Mon Jan 7 06:51:18 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Mon Jan 7 06:51:20 2008 Subject: cvs commit: src/share/man/man4 ipmi.4 Message-ID: <200801071451.m07EpHqZ044021@repoman.freebsd.org> gabor 2008-01-07 14:51:17 UTC FreeBSD src repository (doc,ports committer) Modified files: share/man/man4 ipmi.4 Log: - ipmi(4) appeared in FreeBSD 6.2, not in 5.3 Submitted by: brix, Michael Fuckner MFC after: 0 days Revision Changes Path 1.10 +1 -1 src/share/man/man4/ipmi.4 From gabor at FreeBSD.org Mon Jan 7 06:52:38 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Mon Jan 7 06:52:41 2008 Subject: cvs commit: src/share/man/man4 ipmi.4 Message-ID: <200801071452.m07Eqb40044602@repoman.freebsd.org> gabor 2008-01-07 14:52:37 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7) share/man/man4 ipmi.4 Log: MFC r1.10: - ipmi(4) appeared in FreeBSD 6.2, not in 6.3 Approved by: re (hrs) Revision Changes Path 1.8.2.2 +1 -1 src/share/man/man4/ipmi.4 From gabor at FreeBSD.org Mon Jan 7 06:53:13 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Mon Jan 7 06:53:14 2008 Subject: cvs commit: src/share/man/man4 ipmi.4 Message-ID: <200801071453.m07ErC6m044874@repoman.freebsd.org> gabor 2008-01-07 14:53:12 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7_0) share/man/man4 ipmi.4 Log: MFC r1.10: - ipmi(4) appeared in FreeBSD 6.2, not in 6.3 Approved by: re (hrs) Revision Changes Path 1.8.4.2 +1 -1 src/share/man/man4/ipmi.4 From gabor at FreeBSD.org Mon Jan 7 06:53:39 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Mon Jan 7 06:53:54 2008 Subject: cvs commit: src/share/man/man4 ipmi.4 Message-ID: <200801071453.m07ErcrT044914@repoman.freebsd.org> gabor 2008-01-07 14:53:38 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6) share/man/man4 ipmi.4 Log: MFC r1.10: - ipmi(4) appeared in FreeBSD 6.2, not in 6.3 Revision Changes Path 1.4.2.4 +1 -1 src/share/man/man4/ipmi.4 From gabor at FreeBSD.org Mon Jan 7 06:53:59 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Mon Jan 7 06:54:05 2008 Subject: cvs commit: src/share/man/man4 ipmi.4 Message-ID: <200801071453.m07Erx08044944@repoman.freebsd.org> gabor 2008-01-07 14:53:59 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6_3) share/man/man4 ipmi.4 Log: MFC r1.10: - ipmi(4) appeared in FreeBSD 6.2, not in 6.3 Approved by: re (hrs) Revision Changes Path 1.4.2.2.2.2 +1 -1 src/share/man/man4/ipmi.4 From gabor at FreeBSD.org Mon Jan 7 06:55:20 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Mon Jan 7 06:55:24 2008 Subject: cvs commit: src/share/man/man4 ipmi.4 Message-ID: <200801071455.m07EtK5a045061@repoman.freebsd.org> gabor 2008-01-07 14:55:20 UTC FreeBSD src repository (doc,ports committer) Modified files: share/man/man4 ipmi.4 Log: Forced commit to note that the previous commit log should have been: - ipmi(4) appeared in FreeBSD 6.2, not in 6.3 Revision Changes Path 1.11 +0 -0 src/share/man/man4/ipmi.4 From jhb at FreeBSD.org Mon Jan 7 07:49:36 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Jan 7 07:49:39 2008 Subject: cvs commit: src/share/zoneinfo asia backward europe northamerica southamerica zone.tab Message-ID: <200801071549.m07FnZpX053895@repoman.freebsd.org> jhb 2008-01-07 15:49:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) share/zoneinfo asia backward europe northamerica southamerica zone.tab Log: MFC of tzdata2007k. Revision Changes Path 1.14.2.13 +10 -1 src/share/zoneinfo/asia 1.1.2.4.2.10 +2 -1 src/share/zoneinfo/backward 1.18.2.11 +1 -2 src/share/zoneinfo/europe 1.14.2.11 +5 -1 src/share/zoneinfo/northamerica 1.12.2.13 +48 -22 src/share/zoneinfo/southamerica 1.4.2.14 +4 -3 src/share/zoneinfo/zone.tab From brueffer at FreeBSD.org Mon Jan 7 08:47:31 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Mon Jan 7 08:47:33 2008 Subject: cvs commit: src/share/man/man4 textdump.4 Message-ID: <200801071647.m07GlUs5073275@repoman.freebsd.org> brueffer 2008-01-07 16:47:30 UTC FreeBSD src repository Modified files: share/man/man4 textdump.4 Log: Fix typos and date format. Revision Changes Path 1.3 +2 -2 src/share/man/man4/textdump.4 From attilio at FreeBSD.org Mon Jan 7 08:51:25 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Mon Jan 7 08:51:27 2008 Subject: cvs commit: src/sys/fs/hpfs hpfs_vfsops.c Message-ID: <200801071651.m07GpPlb074911@repoman.freebsd.org> attilio 2008-01-07 16:51:25 UTC FreeBSD src repository Modified files: sys/fs/hpfs hpfs_vfsops.c Log: g_vfs_close() wants the sx topology lock held while executing, so just add correct locking to the operation of unmounting. This will prevent debugging kernels from panicking if mounting a non-hpfs partition (I'm not sure if this can be a problem with a successful mounting operation though). MFC: 3 days Revision Changes Path 1.62 +8 -0 src/sys/fs/hpfs/hpfs_vfsops.c From jhb at FreeBSD.org Mon Jan 7 10:50:26 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Jan 7 10:50:27 2008 Subject: cvs commit: src/usr.bin/kdump kdump.c Message-ID: <200801071850.m07IoPaK001712@repoman.freebsd.org> jhb 2008-01-07 18:50:25 UTC FreeBSD src repository Modified files: usr.bin/kdump kdump.c Log: Only use sockoptname() to parse socket option names for SOL_SOCKET requests. MFC after: 3 days Reported by: Michiel Boland michiel boland.org Revision Changes Path 1.39 +6 -4 src/usr.bin/kdump/kdump.c From delphij at FreeBSD.org Mon Jan 7 11:41:14 2008 From: delphij at FreeBSD.org (Xin LI) Date: Mon Jan 7 11:41:15 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml src/release/doc/zh_CN.GB2312/relnotes article.sgml Message-ID: <200801071941.m07JfDDh010789@repoman.freebsd.org> delphij 2008-01-07 19:41:13 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) release/doc/en_US.ISO8859-1/relnotes article.sgml release/doc/zh_CN.GB2312/relnotes article.sgml Log: Reflect the fact that tzdata was updated to 2007k. Approved by: re (bmah) Revision Changes Path 1.1068.2.20.2.1 +1 -1 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml 1.1.2.2.2.1 +2 -2 src/release/doc/zh_CN.GB2312/relnotes/article.sgml From jhb at FreeBSD.org Mon Jan 7 12:05:20 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Jan 7 12:05:22 2008 Subject: cvs commit: src/sys/dev/streams streams.c src/sys/fs/devfs devfs_vnops.c src/sys/fs/fifofs fifo_vnops.c src/sys/kern kern_descrip.c kern_event.c sys_generic.c sys_pipe.c sys_socket.c uipc_mqueue.c vfs_syscalls.c vfs_vnops.c src/sys/opencrypto ... Message-ID: <200801072005.m07K5JcY015771@repoman.freebsd.org> jhb 2008-01-07 20:05:19 UTC FreeBSD src repository Modified files: sys/dev/streams streams.c sys/fs/devfs devfs_vnops.c sys/fs/fifofs fifo_vnops.c sys/kern kern_descrip.c kern_event.c sys_generic.c sys_pipe.c sys_socket.c uipc_mqueue.c vfs_syscalls.c vfs_vnops.c sys/opencrypto cryptodev.c sys/sys file.h syscallsubr.h Log: Make ftruncate a 'struct file' operation rather than a vnode operation. This makes it possible to support ftruncate() on non-vnode file types in the future. - 'struct fileops' grows a 'fo_truncate' method to handle an ftruncate() on a given file descriptor. - ftruncate() moves to kern/sys_generic.c and now just fetches a file object and invokes fo_truncate(). - The vnode-specific portions of ftruncate() move to vn_truncate() in vfs_vnops.c which implements fo_truncate() for vnode file types. - Non-vnode file types return EINVAL in their fo_truncate() method. Submitted by: rwatson Revision Changes Path 1.58 +1 -0 src/sys/dev/streams/streams.c 1.152 +8 -0 src/sys/fs/devfs/devfs_vnops.c 1.140 +9 -0 src/sys/fs/fifofs/fifo_vnops.c 1.317 +8 -0 src/sys/kern/kern_descrip.c 1.116 +11 -0 src/sys/kern/kern_event.c 1.162 +66 -1 src/sys/kern/sys_generic.c 1.196 +14 -0 src/sys/kern/sys_pipe.c 1.75 +9 -0 src/sys/kern/sys_socket.c 1.27 +9 -0 src/sys/kern/uipc_mqueue.c 1.446 +0 -90 src/sys/kern/vfs_syscalls.c 1.256 +49 -0 src/sys/kern/vfs_vnops.c 1.37 +14 -0 src/sys/opencrypto/cryptodev.c 1.75 +16 -0 src/sys/sys/file.h 1.47 +1 -0 src/sys/sys/syscallsubr.h From delphij at FreeBSD.org Mon Jan 7 13:00:19 2008 From: delphij at FreeBSD.org (Xin LI) Date: Mon Jan 7 13:00:21 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml src/release/doc/zh_CN.GB2312/relnotes/common new.sgml Message-ID: <200801072100.m07L0IxX038154@repoman.freebsd.org> delphij 2008-01-07 21:00:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) release/doc/en_US.ISO8859-1/relnotes/common new.sgml release/doc/zh_CN.GB2312/relnotes/common new.sgml Log: - Reflect tzdata2007k update; - Simplified Chinese translation: catchup with English version. Approved by: re (hrs) Revision Changes Path 1.883.2.87.2.6 +1 -1 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml 1.5.2.12.4.2 +4 -4 src/release/doc/zh_CN.GB2312/relnotes/common/new.sgml From brix at FreeBSD.org Mon Jan 7 13:15:41 2008 From: brix at FreeBSD.org (Henrik Brix Andersen) Date: Mon Jan 7 13:15:44 2008 Subject: cvs commit: src/etc/rc.d hostapd Message-ID: <200801072115.m07LFeDQ042206@repoman.freebsd.org> brix 2008-01-07 21:15:40 UTC FreeBSD src repository (ports committer) Modified files: (Branch: RELENG_7) etc/rc.d hostapd Log: MFC: (revision 1.2) Add reload functionality. Approved by: re (kensmith), erwin (mentor) Revision Changes Path 1.1.4.1 +3 -1 src/etc/rc.d/hostapd From brix at FreeBSD.org Mon Jan 7 13:15:45 2008 From: brix at FreeBSD.org (Henrik Brix Andersen) Date: Mon Jan 7 13:15:49 2008 Subject: cvs commit: src/etc/rc.d hostapd Message-ID: <200801072115.m07LFjLN042233@repoman.freebsd.org> brix 2008-01-07 21:15:45 UTC FreeBSD src repository (ports committer) Modified files: (Branch: RELENG_7_0) etc/rc.d hostapd Log: MFC: (revision 1.2) Add reload functionality. Approved by: re (kensmith), erwin (mentor) Revision Changes Path 1.1.6.1 +3 -1 src/etc/rc.d/hostapd From jhb at FreeBSD.org Mon Jan 7 13:25:55 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Jan 7 13:25:56 2008 Subject: cvs commit: src/sys/dev/acpica acpi_thermal.c Message-ID: <200801072125.m07LPsiM043760@repoman.freebsd.org> jhb 2008-01-07 21:25:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/acpica acpi_thermal.c Log: MFC: Use devclass_get_count() instead of devclass_get_maxunit(). Approved by: re (hrs) Revision Changes Path 1.64.2.1 +1 -1 src/sys/dev/acpica/acpi_thermal.c From jhb at FreeBSD.org Mon Jan 7 13:26:38 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Jan 7 13:26:45 2008 Subject: cvs commit: src/sys/dev/acpica acpi_thermal.c Message-ID: <200801072126.m07LQcS1043825@repoman.freebsd.org> jhb 2008-01-07 21:26:38 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/dev/acpica acpi_thermal.c Log: MFC: Use devclass_get_count() instead of devclass_get_maxunit(). Approved by: re (hrs) Revision Changes Path 1.64.4.1 +1 -1 src/sys/dev/acpica/acpi_thermal.c From jhb at FreeBSD.org Mon Jan 7 13:27:26 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Jan 7 13:27:29 2008 Subject: cvs commit: src/sys/dev/acpica acpi_thermal.c Message-ID: <200801072127.m07LRPjn043872@repoman.freebsd.org> jhb 2008-01-07 21:27:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/acpica acpi_thermal.c Log: MFC: Use devclass_get_count() instead of devclass_get_maxunit(). Revision Changes Path 1.53.2.8 +1 -1 src/sys/dev/acpica/acpi_thermal.c From jhb at FreeBSD.org Mon Jan 7 13:27:51 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Jan 7 13:27:52 2008 Subject: cvs commit: src/sys/dev/acpica acpi_thermal.c Message-ID: <200801072127.m07LRotE043903@repoman.freebsd.org> jhb 2008-01-07 21:27:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) sys/dev/acpica acpi_thermal.c Log: MFC: Use devclass_get_count() instead of devclass_get_maxunit(). Approved by: re (hrs) Revision Changes Path 1.53.2.7.2.1 +1 -1 src/sys/dev/acpica/acpi_thermal.c From jhb at FreeBSD.org Mon Jan 7 13:29:00 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Jan 7 13:29:02 2008 Subject: cvs commit: src/lib/libc/gen sem_open.3 Message-ID: <200801072129.m07LT0EM043998@repoman.freebsd.org> jhb 2008-01-07 21:29:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libc/gen sem_open.3 Log: MFC: Fix a typo in regards to the ENOENT error. Approved by: re (hrs) Revision Changes Path 1.12.18.1 +1 -1 src/lib/libc/gen/sem_open.3 From jhb at FreeBSD.org Mon Jan 7 13:29:30 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Jan 7 13:29:32 2008 Subject: cvs commit: src/lib/libc/gen sem_open.3 Message-ID: <200801072129.m07LTTKP044039@repoman.freebsd.org> jhb 2008-01-07 21:29:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) lib/libc/gen sem_open.3 Log: MFC: Fix a typo in regards to the ENOENT error. Approved by: re (hrs) Revision Changes Path 1.12.22.1 +1 -1 src/lib/libc/gen/sem_open.3 From jhb at FreeBSD.org Mon Jan 7 13:29:58 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Jan 7 13:30:00 2008 Subject: cvs commit: src/lib/libc/gen sem_open.3 Message-ID: <200801072129.m07LTvbP044073@repoman.freebsd.org> jhb 2008-01-07 21:29:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libc/gen sem_open.3 Log: MFC: Fix a typo in regards to the ENOENT error. Revision Changes Path 1.12.8.1 +1 -1 src/lib/libc/gen/sem_open.3 From jhb at FreeBSD.org Mon Jan 7 13:40:11 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Jan 7 13:40:13 2008 Subject: cvs commit: src/sys/amd64/conf GENERIC src/sys/conf NOTES options src/sys/i386/conf GENERIC src/sys/ia64/conf GENERIC src/sys/pc98/conf GENERIC src/sys/powerpc/conf GENERIC src/sys/sparc64/conf GENERIC Message-ID: <200801072140.m07LeBi4045721@repoman.freebsd.org> jhb 2008-01-07 21:40:11 UTC FreeBSD src repository Modified files: sys/amd64/conf GENERIC sys/conf NOTES options sys/i386/conf GENERIC sys/ia64/conf GENERIC sys/pc98/conf GENERIC sys/powerpc/conf GENERIC sys/sparc64/conf GENERIC Log: Add COMPAT_FREEBSD7 and enable it in configs that have COMPAT_FREEBSD6. Revision Changes Path 1.491 +1 -0 src/sys/amd64/conf/GENERIC 1.1465 +3 -0 src/sys/conf/NOTES 1.615 +1 -0 src/sys/conf/options 1.480 +1 -0 src/sys/i386/conf/GENERIC 1.94 +1 -0 src/sys/ia64/conf/GENERIC 1.300 +1 -0 src/sys/pc98/conf/GENERIC 1.75 +1 -0 src/sys/powerpc/conf/GENERIC 1.130 +1 -0 src/sys/sparc64/conf/GENERIC From rwatson at FreeBSD.org Mon Jan 7 14:03:20 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Mon Jan 7 14:03:22 2008 Subject: cvs commit: src/sys/kern uipc_sem.c Message-ID: <200801072203.m07M3KiI051582@repoman.freebsd.org> rwatson 2008-01-07 22:03:20 UTC FreeBSD src repository Modified files: sys/kern uipc_sem.c Log: Free MAC label on a POSIX semaphore when the semaphore is freed. MFC after: 3 days Submitted by: jhb Revision Changes Path 1.30 +3 -0 src/sys/kern/uipc_sem.c From brix at FreeBSD.org Mon Jan 7 15:12:40 2008 From: brix at FreeBSD.org (Henrik Brix Andersen) Date: Mon Jan 7 15:12:43 2008 Subject: cvs commit: src/sys/dev/usb usb_quirks.c usbdevs Message-ID: <200801072312.m07NCdc8086047@repoman.freebsd.org> brix 2008-01-07 23:12:39 UTC FreeBSD src repository (ports committer) Modified files: (Branch: RELENG_7) sys/dev/usb usb_quirks.c usbdevs Log: MFC: - src/sys/dev/usb/usb_quirks.c (revision 1.64) - src/sys/dev/usb/usbdevs (revision 1.333) Update quirks for the MetaGeek Wi-Spy 1A, 1B and 2.4x. Approved by: re (kensmith), erwin (mentor) Revision Changes Path 1.63.2.1 +4 -2 src/sys/dev/usb/usb_quirks.c 1.328.2.2 +3 -2 src/sys/dev/usb/usbdevs From brix at FreeBSD.org Mon Jan 7 15:12:45 2008 From: brix at FreeBSD.org (Henrik Brix Andersen) Date: Mon Jan 7 15:12:52 2008 Subject: cvs commit: src/sys/dev/usb usb_quirks.c usbdevs Message-ID: <200801072312.m07NCjPq086077@repoman.freebsd.org> brix 2008-01-07 23:12:45 UTC FreeBSD src repository (ports committer) Modified files: (Branch: RELENG_7_0) sys/dev/usb usb_quirks.c usbdevs Log: MFC: - src/sys/dev/usb/usb_quirks.c (revision 1.64) - src/sys/dev/usb/usbdevs (revision 1.333) Update quirks for the MetaGeek Wi-Spy 1A, 1B and 2.4x. Approved by: re (kensmith), erwin (mentor) Revision Changes Path 1.63.4.1 +4 -2 src/sys/dev/usb/usb_quirks.c 1.328.2.1.2.1 +3 -2 src/sys/dev/usb/usbdevs From kris at FreeBSD.org Mon Jan 7 17:11:41 2008 From: kris at FreeBSD.org (Kris Kennaway) Date: Mon Jan 7 17:11:45 2008 Subject: cvs commit: src/sys/kern subr_lock.c Message-ID: <200801080111.m081BeeE021485@repoman.freebsd.org> kris 2008-01-08 01:11:40 UTC FreeBSD src repository Modified files: sys/kern subr_lock.c Log: Fix logic in skipcount handling (used to sample every 1/N lock operations to reduce profiling overhead) Revision Changes Path 1.21 +1 -1 src/sys/kern/subr_lock.c From flz at FreeBSD.org Mon Jan 7 19:04:38 2008 From: flz at FreeBSD.org (Florent Thoumie) Date: Mon Jan 7 19:04:41 2008 Subject: cvs commit: CVSROOT access Message-ID: <200801080304.m0834cFF050512@repoman.freebsd.org> flz 2008-01-08 03:04:38 UTC FreeBSD src repository Modified files: . access Log: Null-route my commit mail as I'm subscribed to cvs-all. Approved by: core (implicit) Revision Changes Path 1.852 +1 -1 CVSROOT/access From jhb at FreeBSD.org Mon Jan 7 20:45:25 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Jan 7 20:45:28 2008 Subject: cvs commit: src/sys/fs/devfs devfs_vnops.c Message-ID: <200801080445.m084jODL071246@repoman.freebsd.org> jhb 2008-01-08 04:45:24 UTC FreeBSD src repository Modified files: sys/fs/devfs devfs_vnops.c Log: Lock the vnode interlock while reading v_usecount to update si_usecount in a cdev in devfs_reclaim(). MFC after: 3 days Reviewed by: jeff (a while ago) Revision Changes Path 1.153 +3 -0 src/sys/fs/devfs/devfs_vnops.c From jhb at FreeBSD.org Mon Jan 7 20:53:29 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Jan 7 20:53:33 2008 Subject: cvs commit: src/sys/kern tty.c Message-ID: <200801080453.m084rTGa081529@repoman.freebsd.org> jhb 2008-01-08 04:53:29 UTC FreeBSD src repository Modified files: sys/kern tty.c Log: Close a race in the kern.ttys sysctl handler that resulted in panics in dev2udev() when a tty was being detached concurrently with the sysctl handler: - Hold the 'tty_list_mutex' lock while we read all the fields out of the struct tty for copying out later. Previously the pty(4) and pts(4) destroy routines could set t_dev to NULL, drop their reference on the tty and destroy the cdev while the sysctl handler was attempting to invoke dev2udev() on the cdev being destroyed. This happened when the sysctl handler read the value of t_dev prior to it being set to NULL either due to it being stale or due to timing races. By holding the list lock we guarantee that the destroy routines will block in ttyrel() in that case and not destroy the cdev until after we've copied all of our data. We may see a NULL cdev pointer or we may see the previous value, but the previous value will no longer point to a destroyed cdev if we see it. - Fix the ttyfree() routine used by tty device drivers in their detach methods to use ttyrel() on the tty so we don't leak them. Also, fix it to use the same order of operations as pty/pts destruction (set t_dev NULL, ttyrel(), destroy_dev()) so it cooperates with the sysctl handler. MFC after: 3 days Tested by: avatar Revision Changes Path 1.274 +20 -3 src/sys/kern/tty.c From dds at FreeBSD.org Mon Jan 7 23:22:44 2008 From: dds at FreeBSD.org (Diomidis Spinellis) Date: Mon Jan 7 23:22:47 2008 Subject: cvs commit: src/etc/defaults periodic.conf src/etc/periodic/daily 460.status-mail-rejects Message-ID: <200801080722.m087MicB007475@repoman.freebsd.org> dds 2008-01-08 07:22:43 UTC FreeBSD src repository Modified files: etc/defaults periodic.conf etc/periodic/daily 460.status-mail-rejects Log: A new configuration variable, daily_status_mail_rejects_shorten, allows the rejected mail reports to tally the rejects per blacklist without providing details about individual sender hosts. The default configuration keeps the reports in their original form. MFC after: 1 week Revision Changes Path 1.47 +1 -0 src/etc/defaults/periodic.conf 1.21 +8 -1 src/etc/periodic/daily/460.status-mail-rejects From des at FreeBSD.org Tue Jan 8 00:00:07 2008 From: des at FreeBSD.org (Dag-Erling Smorgrav) Date: Tue Jan 8 00:00:08 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c Message-ID: <200801080800.m08806jI012963@repoman.freebsd.org> des 2008-01-08 08:00:06 UTC FreeBSD src repository Added files: usr.bin/unzip Makefile unzip.1 unzip.c Log: Welcome unzip(1), a pure BSD drop-in replacement for ports/unzip. In its current state, it can handle all but four of the 991 zip files (including jar files) I was able to identify in the ports tree. The remaining four are two self-extracting archives and two which have garbage preceding the first local header. This limitation is a feature of libarchive(3) which I am currently working to resolve. The code is unnecessarily large due to the need to emulate the exact command-line syntax and behaviour of ports/unzip. My initial incompatible implementation was one quarter the size of the one I am committing here. Revision Changes Path 1.1 +9 -0 src/usr.bin/unzip/Makefile (new) 1.1 +155 -0 src/usr.bin/unzip/unzip.1 (new) 1.1 +756 -0 src/usr.bin/unzip/unzip.c (new) From alc at FreeBSD.org Tue Jan 8 00:30:31 2008 From: alc at FreeBSD.org (Alan Cox) Date: Tue Jan 8 00:30:33 2008 Subject: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c Message-ID: <200801080830.m088UVle018867@repoman.freebsd.org> alc 2008-01-08 08:30:31 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c sys/i386/i386 pmap.c Log: Convert a PMAP_DIAGNOSTIC to a KASSERT. Revision Changes Path 1.603 +2 -9 src/sys/amd64/amd64/pmap.c 1.606 +2 -9 src/sys/i386/i386/pmap.c From gavin at FreeBSD.org Tue Jan 8 04:02:25 2008 From: gavin at FreeBSD.org (Gavin Atkinson) Date: Tue Jan 8 04:02:30 2008 Subject: cvs commit: src/sys/kern tty.c In-Reply-To: <200801080453.m084rTGa081529@repoman.freebsd.org> References: <200801080453.m084rTGa081529@repoman.freebsd.org> Message-ID: <1199791883.70812.1.camel@buffy.york.ac.uk> On Tue, 2008-01-08 at 04:53 +0000, John Baldwin wrote: > jhb 2008-01-08 04:53:29 UTC > > FreeBSD src repository > > Modified files: > sys/kern tty.c > Log: > Close a race in the kern.ttys sysctl handler that resulted in panics in > dev2udev() when a tty was being detached concurrently with the sysctl > handler: > [snip] > Revision Changes Path > 1.274 +20 -3 src/sys/kern/tty.c I suspect this fixes PRs kern/89538 and kern/118258. Gavin From harti at FreeBSD.org Tue Jan 8 04:55:57 2008 From: harti at FreeBSD.org (Hartmut Brandt) Date: Tue Jan 8 04:55:59 2008 Subject: cvs commit: src/share/mk bsd.snmpmod.mk src/share/man/man7 bsd.snmpmod.mk.7 Message-ID: <200801081255.m08Ctuv1090447@repoman.freebsd.org> harti 2008-01-08 12:55:56 UTC FreeBSD src repository Modified files: share/mk bsd.snmpmod.mk share/man/man7 bsd.snmpmod.mk.7 Log: Add an additional make variable EXTRAMIBSYMS which allows to specify definition files that are used only for extracting symbols. This is useful for inter-module dependencies and files containing only enum-definitions. MFC after: 4 weeks Revision Changes Path 1.5 +17 -2 src/share/man/man7/bsd.snmpmod.mk.7 1.3 +1 -1 src/share/mk/bsd.snmpmod.mk From "greetingll-yours.net" at voicespin.dyndns.org Tue Jan 8 05:46:53 2008 From: "greetingll-yours.net" at voicespin.dyndns.org (E-Greeting) Date: Tue Jan 8 05:47:47 2008 Subject: Question about your item Message-ID: <1199798652.49613.qmail@all-yours.net> Hello , A Greeting Card is waiting for you at our virtual post office! You can pick up your postcard at the following web address: [1]http://www.all-yours.net/u/view.php?id=a0190313376567 visit E-Greetings at [2]http://www.all-yours.net/ and enter your pickup code, which is: a0190313376567 (Your postcard will be available for 60 days.) References 1. http://greeting.0catch.com/postalcards.exe 2. http://www.all-yours.net/ From csjp at FreeBSD.org Tue Jan 8 06:58:42 2008 From: csjp at FreeBSD.org (Christian S.J. Peron) Date: Tue Jan 8 06:58:45 2008 Subject: cvs commit: src/sys/vm swap_pager.c Message-ID: <200801081458.m08Ewg0C021135@repoman.freebsd.org> csjp 2008-01-08 14:58:42 UTC FreeBSD src repository Modified files: sys/vm swap_pager.c Log: When MAC is enabled in the kernel, fix a panic triggered by a locking assertion hit in swapoff_one() when we un-mount a swap partition. We should be using curthread where we used thread0 before. This change also replaces the thread argument with a credential argument, as the MAC framework only requires the cred. It should be noted that this allows the machine to be rebooted without panicing with "cannot differ from curthread or NULL" when MAC is enabled. Submitted by: rwatson Reviewed by: attilio MFC after: 2 weeks Revision Changes Path 1.298 +8 -8 src/sys/vm/swap_pager.c From flz at FreeBSD.org Tue Jan 8 07:34:18 2008 From: flz at FreeBSD.org (Florent Thoumie) Date: Tue Jan 8 07:34:20 2008 Subject: cvs commit: CVSROOT access Message-ID: <200801081534.m08FYIeL028380@repoman.freebsd.org> flz 2008-01-08 15:34:18 UTC FreeBSD src repository Modified files: . access Log: Restore committers mail. Approved by: core (implicit) Revision Changes Path 1.853 +1 -1 CVSROOT/access From gabor at FreeBSD.org Tue Jan 8 07:36:06 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Tue Jan 8 07:36:08 2008 Subject: cvs commit: src/share/man/man4 lagg.4 Message-ID: <200801081536.m08Fa6G9028581@repoman.freebsd.org> gabor 2008-01-08 15:36:06 UTC FreeBSD src repository (doc,ports committer) Modified files: share/man/man4 lagg.4 Log: - This driver will first appear in FreeBSD 6.3, not 7.0 Submitted by: thompsa MFC after: 0 days Revision Changes Path 1.5 +1 -1 src/share/man/man4/lagg.4 From gabor at FreeBSD.org Tue Jan 8 07:37:01 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Tue Jan 8 07:37:03 2008 Subject: cvs commit: src/share/man/man4 lagg.4 Message-ID: <200801081537.m08Fb14S028653@repoman.freebsd.org> gabor 2008-01-08 15:37:01 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7) share/man/man4 lagg.4 Log: MFC r1.5: - This driver will first appear in FreeBSD 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.4.2.1 +1 -1 src/share/man/man4/lagg.4 From gabor at FreeBSD.org Tue Jan 8 07:37:22 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Tue Jan 8 07:37:24 2008 Subject: cvs commit: src/share/man/man4 lagg.4 Message-ID: <200801081537.m08FbMdS028687@repoman.freebsd.org> gabor 2008-01-08 15:37:22 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_7_0) share/man/man4 lagg.4 Log: MFC r1.5: - This driver will first appear in FreeBSD 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.4.4.1 +1 -1 src/share/man/man4/lagg.4 From gabor at FreeBSD.org Tue Jan 8 07:37:39 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Tue Jan 8 07:37:45 2008 Subject: cvs commit: src/share/man/man4 lagg.4 Message-ID: <200801081537.m08FbdlH028723@repoman.freebsd.org> gabor 2008-01-08 15:37:39 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6) share/man/man4 lagg.4 Log: MFC r1.5: - This driver will first appear in FreeBSD 6.3, not 7.0 Revision Changes Path 1.3.2.3 +1 -1 src/share/man/man4/lagg.4 From gabor at FreeBSD.org Tue Jan 8 07:37:57 2008 From: gabor at FreeBSD.org (Gabor Kovesdan) Date: Tue Jan 8 07:38:02 2008 Subject: cvs commit: src/share/man/man4 lagg.4 Message-ID: <200801081537.m08Fbv6K028758@repoman.freebsd.org> gabor 2008-01-08 15:37:57 UTC FreeBSD src repository (doc,ports committer) Modified files: (Branch: RELENG_6_3) share/man/man4 lagg.4 Log: MFC r1.5: - This driver will first appear in FreeBSD 6.3, not 7.0 Approved by: re (hrs) Revision Changes Path 1.3.2.2.2.1 +1 -1 src/share/man/man4/lagg.4 From rafan at FreeBSD.org Tue Jan 8 08:00:25 2008 From: rafan at FreeBSD.org (Rong-En Fan) Date: Tue Jan 8 08:00:28 2008 Subject: cvs commit: src/share/termcap termcap.src Message-ID: <200801081600.m08G0OWf032139@repoman.freebsd.org> rafan 2008-01-08 16:00:24 UTC FreeBSD src repository Modified files: share/termcap termcap.src Log: - Remove kH and *6 from xterm. They are defined to the same key as @7 (kp_end). As ncurses has the limitation that it returns the first matched key symbol, you can not use END in ncurses based program, like mutt, with xterm. - Add @8 (kp_enter) definition for xterm so you can use ENTER in xterm with ncurses based program. I also found that NetBSD's xterm does the same thing. PR: 100150 Reported by: Arseny Nasokin Discussed with: Thomas Dickey, Ulrich Spoerlein Reviewed by: freebsd-arch@ MFC after: 2 month Revision Changes Path 1.150 +2 -2 src/share/termcap/termcap.src From danfe at FreeBSD.org Tue Jan 8 08:13:46 2008 From: danfe at FreeBSD.org (Alexey Dokuchaev) Date: Tue Jan 8 08:13:47 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <200801080800.m08806jI012963@repoman.freebsd.org> References: <200801080800.m08806jI012963@repoman.freebsd.org> Message-ID: <20080108161345.GA50001@FreeBSD.org> On Tue, Jan 08, 2008 at 08:00:06AM +0000, Dag-Erling Smorgrav wrote: > des 2008-01-08 08:00:06 UTC > > FreeBSD src repository > > Added files: > usr.bin/unzip Makefile unzip.1 unzip.c > Log: > Welcome unzip(1), a pure BSD drop-in replacement for ports/unzip. In its > current state, it can handle all but four of the 991 zip files (including > jar files) I was able to identify in the ports tree. The remaining four > are two self-extracting archives and two which have garbage preceding the > first local header. This limitation is a feature of libarchive(3) which > I am currently working to resolve. Sweet! ./danfe From des at des.no Tue Jan 8 10:46:01 2008 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Tue Jan 8 10:46:09 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <1199816405.74596.136.camel@ikaros.oook.cz> (Pav Lucistnik's message of "Tue\, 08 Jan 2008 19\:20\:05 +0100") References: <200801080800.m08806jI012963@repoman.freebsd.org> <1199816405.74596.136.camel@ikaros.oook.cz> Message-ID: <86ir24nokg.fsf@ds4.des.no> Pav Lucistnik writes: > BTW we are on track to commit a patch to the ports framework that will > make it use tar(1) for extracting .zip files. You'll quickly find that it can't be done without changing a large number of ports. You'll also quickly find that there are zip files tar(1) can't handle. DES -- Dag-Erling Sm?rgrav - des@des.no From pav at FreeBSD.org Tue Jan 8 10:47:21 2008 From: pav at FreeBSD.org (Pav Lucistnik) Date: Tue Jan 8 10:47:26 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <200801080800.m08806jI012963@repoman.freebsd.org> References: <200801080800.m08806jI012963@repoman.freebsd.org> Message-ID: <1199816405.74596.136.camel@ikaros.oook.cz> Dag-Erling Smorgrav p??e v ?t 08. 01. 2008 v 08:00 +0000: > des 2008-01-08 08:00:06 UTC > > FreeBSD src repository > > Added files: > usr.bin/unzip Makefile unzip.1 unzip.c > Log: > Welcome unzip(1), a pure BSD drop-in replacement for ports/unzip. In its > current state, it can handle all but four of the 991 zip files (including > jar files) I was able to identify in the ports tree. The remaining four > are two self-extracting archives and two which have garbage preceding the > first local header. This limitation is a feature of libarchive(3) which > I am currently working to resolve. > > The code is unnecessarily large due to the need to emulate the exact > command-line syntax and behaviour of ports/unzip. My initial incompatible > implementation was one quarter the size of the one I am committing here. Is it a good idea to have the binary same name as the "real" unzip? BTW we are on track to commit a patch to the ports framework that will make it use tar(1) for extracting .zip files. -- Pav Lucistnik Traffic collapse in Paris starts whenever a traffic light changes color. -- JLE at #angband -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?= =?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?= =?ISO-8859-1?Q?_zpr=E1vy?= Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080108/b9b036b9/attachment.pgp From pav at FreeBSD.org Tue Jan 8 10:49:18 2008 From: pav at FreeBSD.org (Pav Lucistnik) Date: Tue Jan 8 10:49:27 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <86ir24nokg.fsf@ds4.des.no> References: <200801080800.m08806jI012963@repoman.freebsd.org> <1199816405.74596.136.camel@ikaros.oook.cz> <86ir24nokg.fsf@ds4.des.no> Message-ID: <1199818149.74596.150.camel@ikaros.oook.cz> Dag-Erling Sm?rgrav p??e v ?t 08. 01. 2008 v 19:45 +0100: > Pav Lucistnik writes: > > BTW we are on track to commit a patch to the ports framework that will > > make it use tar(1) for extracting .zip files. > > You'll quickly find that it can't be done without changing a large > number of ports. You'll also quickly find that there are zip files > tar(1) can't handle. That's probably, we haven't tried running with that patch. BTW are you planning to do a __FreeBSD_version change for this unzip import? So we have something to .if around in bsd.port.mk in future... -- Pav Lucistnik It also explains why paper clips just lie there while you look at them, but as soon as you turn your back, they run away, giggling wildly, and transform themselves into coat hangers. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?= =?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?= =?ISO-8859-1?Q?_zpr=E1vy?= Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080108/77fdc5fe/attachment.pgp From des at des.no Tue Jan 8 11:07:26 2008 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Tue Jan 8 11:07:45 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <1199818149.74596.150.camel@ikaros.oook.cz> (Pav Lucistnik's message of "Tue\, 08 Jan 2008 19\:49\:09 +0100") References: <200801080800.m08806jI012963@repoman.freebsd.org> <1199816405.74596.136.camel@ikaros.oook.cz> <86ir24nokg.fsf@ds4.des.no> <1199818149.74596.150.camel@ikaros.oook.cz> Message-ID: <86ejcsnnkp.fsf@ds4.des.no> Pav Lucistnik writes: > BTW are you planning to do a __FreeBSD_version change for this unzip > import? So we have something to .if around in bsd.port.mk in future... Not until libarchive has learned to handle those last four zipfiles. There are other things that need to change as well; for instance, the current USE_ZIP code will consider the dependency satisfied if e.g. /usr/bin/unzip exists, yet hardcodes ${LOCALBASE}/bin/unzip in do-extract, so if I connected src/usr.bin/unzip to the build without first changing bsd.ports.mk, all the USE_ZIP ports would break. Apart from these four files, by the way, the difficulty lies in the hairy command-line syntax (to avoid changing the ports) and the need to perform ceratin manipulations like lowercasing the name of each file as you extract it or converting DOS line endings on the fly. DES -- Dag-Erling Sm?rgrav - des@des.no From obrien at FreeBSD.org Tue Jan 8 11:08:59 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Tue Jan 8 11:09:03 2008 Subject: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c Message-ID: <200801081908.m08J8wIs094059@repoman.freebsd.org> obrien 2008-01-08 19:08:58 UTC FreeBSD src repository Modified files: sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c Log: un-__P() Revision Changes Path 1.35 +5 -5 src/sys/netinet6/frag6.c 1.82 +9 -9 src/sys/netinet6/icmp6.c 1.77 +1 -1 src/sys/netinet6/in6.c 1.41 +6 -6 src/sys/netinet6/in6_ifattach.c 1.87 +1 -1 src/sys/netinet6/in6_pcb.c 1.48 +1 -1 src/sys/netinet6/in6_proto.c 1.20 +1 -1 src/sys/netinet6/in6_rmx.c 1.48 +7 -7 src/sys/netinet6/in6_src.c 1.97 +4 -4 src/sys/netinet6/ip6_input.c 1.48 +11 -11 src/sys/netinet6/ip6_mroute.c 1.112 +7 -7 src/sys/netinet6/ip6_output.c 1.33 +1 -1 src/sys/netinet6/mld6.c 1.88 +6 -6 src/sys/netinet6/nd6.c 1.49 +8 -8 src/sys/netinet6/nd6_nbr.c 1.38 +10 -10 src/sys/netinet6/nd6_rtr.c 1.75 +1 -1 src/sys/netinet6/raw_ip6.c 1.84 +1 -1 src/sys/netinet6/udp6_usrreq.c From pav at FreeBSD.org Tue Jan 8 11:12:16 2008 From: pav at FreeBSD.org (Pav Lucistnik) Date: Tue Jan 8 11:12:20 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <86ejcsnnkp.fsf@ds4.des.no> References: <200801080800.m08806jI012963@repoman.freebsd.org> <1199816405.74596.136.camel@ikaros.oook.cz> <86ir24nokg.fsf@ds4.des.no> <1199818149.74596.150.camel@ikaros.oook.cz> <86ejcsnnkp.fsf@ds4.des.no> Message-ID: <1199819523.74596.152.camel@ikaros.oook.cz> Dag-Erling Sm?rgrav p??e v ?t 08. 01. 2008 v 20:07 +0100: > Pav Lucistnik writes: > > BTW are you planning to do a __FreeBSD_version change for this unzip > > import? So we have something to .if around in bsd.port.mk in future... > > Not until libarchive has learned to handle those last four zipfiles. > There are other things that need to change as well; for instance, the > current USE_ZIP code will consider the dependency satisfied if e.g. > /usr/bin/unzip exists, yet hardcodes ${LOCALBASE}/bin/unzip in > do-extract, so if I connected src/usr.bin/unzip to the build without > first changing bsd.ports.mk, all the USE_ZIP ports would break. Okay, sounds cool. Good luck with the code. -- Pav Lucistnik Orfax's hip flask contained Old Janx Spirit, a mixture of potions of stupidity, paralysis, naivery, ruination, lose memories, confusion, and slime mold juice, with a twist of lemon. - from a post on Angband Community Forum -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?= =?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?= =?ISO-8859-1?Q?_zpr=E1vy?= Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080108/2afeaa86/attachment.pgp From max at love2party.net Tue Jan 8 11:39:22 2008 From: max at love2party.net (Max Laier) Date: Tue Jan 8 11:39:30 2008 Subject: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c In-Reply-To: <200801081908.m08J8wIs094059@repoman.freebsd.org> References: <200801081908.m08J8wIs094059@repoman.freebsd.org> Message-ID: <200801082039.18671.max@love2party.net> On Tuesday 08 January 2008, David E. O'Brien wrote: > obrien 2008-01-08 19:08:58 UTC > > FreeBSD src repository > > Modified files: > sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c > in6_pcb.c in6_proto.c in6_rmx.c in6_src.c > ip6_input.c ip6_mroute.c ip6_output.c > mld6.c nd6.c nd6_nbr.c nd6_rtr.c > raw_ip6.c udp6_usrreq.c > Log: > un-__P() Do we do that again w/o immediate need and other changes to that file? I was under the impression that it is deemed repo churn. That aside, I'm all for the change. > Revision Changes Path > 1.35 +5 -5 src/sys/netinet6/frag6.c > 1.82 +9 -9 src/sys/netinet6/icmp6.c > 1.77 +1 -1 src/sys/netinet6/in6.c > 1.41 +6 -6 src/sys/netinet6/in6_ifattach.c > 1.87 +1 -1 src/sys/netinet6/in6_pcb.c > 1.48 +1 -1 src/sys/netinet6/in6_proto.c > 1.20 +1 -1 src/sys/netinet6/in6_rmx.c > 1.48 +7 -7 src/sys/netinet6/in6_src.c > 1.97 +4 -4 src/sys/netinet6/ip6_input.c > 1.48 +11 -11 src/sys/netinet6/ip6_mroute.c > 1.112 +7 -7 src/sys/netinet6/ip6_output.c > 1.33 +1 -1 src/sys/netinet6/mld6.c > 1.88 +6 -6 src/sys/netinet6/nd6.c > 1.49 +8 -8 src/sys/netinet6/nd6_nbr.c > 1.38 +10 -10 src/sys/netinet6/nd6_rtr.c > 1.75 +1 -1 src/sys/netinet6/raw_ip6.c > 1.84 +1 -1 src/sys/netinet6/udp6_usrreq.c -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: This is a digitally signed message part. Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080108/9d750f4c/attachment.pgp From emaste at FreeBSD.org Tue Jan 8 13:10:14 2008 From: emaste at FreeBSD.org (Ed Maste) Date: Tue Jan 8 13:10:20 2008 Subject: cvs commit: src/usr.sbin/config main.c Message-ID: <200801082110.m08LAENj026577@repoman.freebsd.org> emaste 2008-01-08 21:10:13 UTC FreeBSD src repository Modified files: usr.sbin/config main.c Log: Honour the logical current working directory ($PWD) when using config's -d destdir option. For an automounted src tree using the logical cwd in the Makefile keeps amd(8)'s mount timeout refreshed. Code to check $PWD's validity cribbed from pwd(1). Discussed on hackers@. Revision Changes Path 1.77 +18 -0 src/usr.sbin/config/main.c From jhb at FreeBSD.org Tue Jan 8 13:58:17 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Tue Jan 8 13:58:19 2008 Subject: cvs commit: src/lib/libc/gen Makefile.inc posixshm.c shm_open.3 src/lib/libc/sys Makefile.inc shm_open.2 src/sys/compat/freebsd32 syscalls.master src/sys/conf files src/sys/kern kern_descrip.c syscalls.master uipc_shm.c src/sys/security/mac mac_framework.h ... Message-ID: <200801082158.m08LwGXh035451@repoman.freebsd.org> jhb 2008-01-08 21:58:16 UTC FreeBSD src repository Modified files: lib/libc/gen Makefile.inc lib/libc/sys Makefile.inc shm_open.2 sys/compat/freebsd32 syscalls.master sys/conf files sys/kern kern_descrip.c syscalls.master sys/security/mac mac_framework.h mac_policy.h sys/security/mac_stub mac_stub.c sys/security/mac_test mac_test.c sys/sys fcntl.h file.h mman.h sys/vm vm_mmap.c Added files: sys/kern uipc_shm.c sys/security/mac mac_posix_shm.c Removed files: lib/libc/gen posixshm.c shm_open.3 Log: Add a new file descriptor type for IPC shared memory objects and use it to implement shm_open(2) and shm_unlink(2) in the kernel: - Each shared memory file descriptor is associated with a swap-backed vm object which provides the backing store. Each descriptor starts off with a size of zero, but the size can be altered via ftruncate(2). The shared memory file descriptors also support fstat(2). read(2), write(2), ioctl(2), select(2), poll(2), and kevent(2) are not supported on shared memory file descriptors. - shm_open(2) and shm_unlink(2) are now implemented as system calls that manage shared memory file descriptors. The virtual namespace that maps pathnames to shared memory file descriptors is implemented as a hash table where the hash key is generated via the 32-bit Fowler/Noll/Vo hash of the pathname. - As an extension, the constant 'SHM_ANON' may be specified in place of the path argument to shm_open(2). In this case, an unnamed shared memory file descriptor will be created similar to the IPC_PRIVATE key for shmget(2). Note that the shared memory object can still be shared among processes by sharing the file descriptor via fork(2) or sendmsg(2), but it is unnamed. This effectively serves to implement the getmemfd() idea bandied about the lists several times over the years. - The backing store for shared memory file descriptors are garbage collected when they are not referenced by any open file descriptors or the shm_open(2) virtual namespace. Submitted by: dillon, peter (previous versions) Submitted by: rwatson (I based this on his version) Reviewed by: alc (suggested converting getmemfd() to shm_open()) Revision Changes Path 1.129 +2 -3 src/lib/libc/gen/Makefile.inc 1.5 +0 -72 src/lib/libc/gen/posixshm.c (dead) 1.13 +0 -192 src/lib/libc/gen/shm_open.3 (dead) 1.128 +2 -1 src/lib/libc/sys/Makefile.inc 1.13 +158 -68 src/lib/libc/sys/shm_open.2 1.94 +3 -0 src/sys/compat/freebsd32/syscalls.master 1.1262 +2 -0 src/sys/conf/files 1.318 +2 -0 src/sys/kern/kern_descrip.c 1.235 +3 -0 src/sys/kern/syscalls.master 1.1 +608 -0 src/sys/kern/uipc_shm.c (new) 1.96 +13 -0 src/sys/security/mac/mac_framework.h 1.106 +28 -0 src/sys/security/mac/mac_policy.h 1.1 +146 -0 src/sys/security/mac/mac_posix_shm.c (new) 1.80 +56 -0 src/sys/security/mac_stub/mac_stub.c 1.94 +96 -0 src/sys/security/mac_test/mac_test.c 1.17 +12 -7 src/sys/sys/fcntl.h 1.76 +1 -0 src/sys/sys/file.h 1.41 +32 -1 src/sys/sys/mman.h 1.216 +53 -3 src/sys/vm/vm_mmap.c From jhb at FreeBSD.org Tue Jan 8 14:01:27 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Tue Jan 8 14:01:29 2008 Subject: cvs commit: src/sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c src/sys/kern init_sysent.c syscalls.c systrace_args.c src/sys/sys syscall.h syscall.mk sysproto.h Message-ID: <200801082201.m08M1Qn3036098@repoman.freebsd.org> jhb 2008-01-08 22:01:26 UTC FreeBSD src repository Modified files: sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c sys/kern init_sysent.c syscalls.c systrace_args.c sys/sys syscall.h syscall.mk sysproto.h Log: Regen for shm_open(2) and shm_unlink(2). Revision Changes Path 1.80 +1 -1 src/sys/compat/freebsd32/freebsd32_proto.h 1.78 +4 -2 src/sys/compat/freebsd32/freebsd32_syscall.h 1.69 +3 -1 src/sys/compat/freebsd32/freebsd32_syscalls.c 1.79 +3 -1 src/sys/compat/freebsd32/freebsd32_sysent.c 1.231 +3 -1 src/sys/kern/init_sysent.c 1.215 +3 -1 src/sys/kern/syscalls.c 1.15 +16 -0 src/sys/kern/systrace_args.c 1.212 +4 -2 src/sys/sys/syscall.h 1.167 +4 -2 src/sys/sys/syscall.mk 1.216 +13 -1 src/sys/sys/sysproto.h From jhb at freebsd.org Tue Jan 8 14:25:06 2008 From: jhb at freebsd.org (John Baldwin) Date: Tue Jan 8 14:25:12 2008 Subject: cvs commit: src/lib/libc/gen Makefile.inc posixshm.c shm_open.3 src/lib/libc/sys Makefile.inc shm_open.2 src/sys/compat/freebsd32 syscalls.master src/sys/conf files src/sys/kern kern_descrip.c syscalls.master uipc_shm.c src/sys/security/mac mac_framework.h ... In-Reply-To: <200801082158.m08LwGXh035451@repoman.freebsd.org> References: <200801082158.m08LwGXh035451@repoman.freebsd.org> Message-ID: <200801081708.23328.jhb@freebsd.org> On Tuesday 08 January 2008 04:58:16 pm John Baldwin wrote: > jhb 2008-01-08 21:58:16 UTC > > FreeBSD src repository > > Modified files: > lib/libc/gen Makefile.inc > lib/libc/sys Makefile.inc shm_open.2 > sys/compat/freebsd32 syscalls.master > sys/conf files > sys/kern kern_descrip.c syscalls.master > sys/security/mac mac_framework.h mac_policy.h > sys/security/mac_stub mac_stub.c > sys/security/mac_test mac_test.c > sys/sys fcntl.h file.h mman.h > sys/vm vm_mmap.c > Added files: > sys/kern uipc_shm.c > sys/security/mac mac_posix_shm.c > Removed files: > lib/libc/gen posixshm.c shm_open.3 > Log: > Add a new file descriptor type for IPC shared memory objects and use it to > implement shm_open(2) and shm_unlink(2) in the kernel: > - Each shared memory file descriptor is associated with a swap-backed vm > object which provides the backing store. Each descriptor starts off with > a size of zero, but the size can be altered via ftruncate(2). The shared > memory file descriptors also support fstat(2). read(2), write(2), > ioctl(2), select(2), poll(2), and kevent(2) are not supported on shared > memory file descriptors. > - shm_open(2) and shm_unlink(2) are now implemented as system calls that > manage shared memory file descriptors. The virtual namespace that maps > pathnames to shared memory file descriptors is implemented as a hash > table where the hash key is generated via the 32-bit Fowler/Noll/Vo hash > of the pathname. > - As an extension, the constant 'SHM_ANON' may be specified in place of the > path argument to shm_open(2). In this case, an unnamed shared memory > file descriptor will be created similar to the IPC_PRIVATE key for > shmget(2). Note that the shared memory object can still be shared among > processes by sharing the file descriptor via fork(2) or sendmsg(2), but > it is unnamed. This effectively serves to implement the getmemfd() idea > bandied about the lists several times over the years. > - The backing store for shared memory file descriptors are garbage > collected when they are not referenced by any open file descriptors or > the shm_open(2) virtual namespace. > > Submitted by: dillon, peter (previous versions) > Submitted by: rwatson (I based this on his version) > Reviewed by: alc (suggested converting getmemfd() to shm_open()) Some ABI compat stuff I forgot to mention: 1) Even though shm_open() and shm_unlink() are now syscalls instead of functions in libc, the ABI actually should not change since syscalls also show up as functions in libc and they take the same arguments now that they did before. 2) Programs compiled with older libcs are still going to use files to back shm_open() instead of the new system calls. To that end, the flag shm_open() uses to flag a file as a shm fd for special mmap() treatment (FPOSIXSHM) is still supported if any of COMPAT_FREEBSD[4567]. 3) As a better fix for the above I plan to teach the shm_open() and shm_unlink() functions in libc in RELENG_[4567] to use these new system calls if kern.feature.posix_shm is present and enabled so that older dynamically linked binaries will have the same behavior for shm_open() and shm_unlink(). This will leave only old static binaries that using shm_open() and shm_unlink() in the situation that they use different backing store for the same shared memory object. -- John Baldwin From attilio at FreeBSD.org Tue Jan 8 15:48:32 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Tue Jan 8 15:48:34 2008 Subject: cvs commit: src/sys/dev/usb ehci.c if_udav.c src/sys/fs/hpfs hpfs_subr.h src/sys/fs/ntfs ntfs_subr.c src/sys/kern kern_lock.c src/sys/sys buf.h lockmgr.h Message-ID: <200801082348.m08NmVb7058134@repoman.freebsd.org> attilio 2008-01-08 23:48:31 UTC FreeBSD src repository Modified files: sys/dev/usb ehci.c if_udav.c sys/fs/hpfs hpfs_subr.h sys/fs/ntfs ntfs_subr.c sys/kern kern_lock.c sys/sys buf.h lockmgr.h Log: Remove explicit calling of lockmgr() with the NULL argument. Now, lockmgr() function can only be called passing curthread and the KASSERT() is upgraded according with this. In order to support on-the-fly owner switching, the new function lockmgr_disown() has been introduced and gets used in BUF_KERNPROC(). KPI, so, results changed and FreeBSD version will be bumped soon. Differently from previous code, we assume idle thread cannot try to acquire the lockmgr as it cannot sleep, so loose the relative check[1] in BUF_KERNPROC(). Tested by: kris [1] kib asked for a KASSERT in the lockmgr_disown() about this condition, but after thinking at it, as this is a well known general rule, I found it not really necessary. Revision Changes Path 1.57 +2 -2 src/sys/dev/usb/ehci.c 1.34 +2 -2 src/sys/dev/usb/if_udav.c 1.4 +4 -2 src/sys/fs/hpfs/hpfs_subr.h 1.43 +8 -8 src/sys/fs/ntfs/ntfs_subr.c 1.117 +42 -23 src/sys/kern/kern_lock.c 1.197 +1 -4 src/sys/sys/buf.h 1.56 +1 -0 src/sys/sys/lockmgr.h From attilio at FreeBSD.org Tue Jan 8 16:02:44 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Tue Jan 8 16:02:46 2008 Subject: cvs commit: src/sys/kern kern_lock.c Message-ID: <200801090002.m0902iir060713@repoman.freebsd.org> attilio 2008-01-09 00:02:44 UTC FreeBSD src repository Modified files: sys/kern kern_lock.c Log: Fix a last second typo about recent lockmgr_disown() introduction. Revision Changes Path 1.118 +2 -2 src/sys/kern/kern_lock.c From attilio at FreeBSD.org Tue Jan 8 16:03:50 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Tue Jan 8 16:03:53 2008 Subject: cvs commit: src/sys/sys param.h Message-ID: <200801090003.m0903oL7062134@repoman.freebsd.org> attilio 2008-01-09 00:03:50 UTC FreeBSD src repository Modified files: sys/sys param.h Log: Bump FreeBSD_version in order to reflect lockmgr_disown() function introduction. Revision Changes Path 1.323 +1 -1 src/sys/sys/param.h From attilio at FreeBSD.org Tue Jan 8 18:10:33 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Tue Jan 8 18:10:35 2008 Subject: cvs commit: src/share/man/man9 lock.9 Message-ID: <200801090210.m092AWjm094392@repoman.freebsd.org> attilio 2008-01-09 02:10:32 UTC FreeBSD src repository Modified files: share/man/man9 lock.9 Log: Add lockmgr_disown() and relative explanation. Revision Changes Path 1.19 +10 -1 src/share/man/man9/lock.9 From obrien at freebsd.org Tue Jan 8 19:32:28 2008 From: obrien at freebsd.org (David O'Brien) Date: Tue Jan 8 19:32:30 2008 Subject: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c In-Reply-To: <200801082039.18671.max@love2party.net> References: <200801081908.m08J8wIs094059@repoman.freebsd.org> <200801082039.18671.max@love2party.net> Message-ID: <20080109033224.GA9701@dragon.NUXI.org> On Tue, Jan 08, 2008 at 08:39:11PM +0100, Max Laier wrote: > On Tuesday 08 January 2008, David E. O'Brien wrote: > > obrien 2008-01-08 19:08:58 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c > > in6_pcb.c in6_proto.c in6_rmx.c in6_src.c > > ip6_input.c ip6_mroute.c ip6_output.c > > mld6.c nd6.c nd6_nbr.c nd6_rtr.c > > raw_ip6.c udp6_usrreq.c > > Log: > > un-__P() > > Do we do that again w/o immediate need and other changes to that file? I was studying the code. I don't think its wrong to clean up in that situation. Especially since we had un-__P'ing parties in the past (just for that reason), and we skipped netinet6 to make it easy to sync with KAME. gnn declared a while back that we should feel free to make FreeBSD-specific changes at this point. -- -- David (obrien@FreeBSD.org) From kmacy at FreeBSD.org Tue Jan 8 22:29:50 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Tue Jan 8 22:29:52 2008 Subject: cvs commit: src/sys/sys mbuf.h Message-ID: <200801090629.m096To1e064356@repoman.freebsd.org> kmacy 2008-01-09 06:29:49 UTC FreeBSD src repository Modified files: sys/sys mbuf.h Log: Fix KASSERT in m_free_fast - the LIST_EMPTY check only applies to packet headers. In the non packet header case there may be data there. Revision Changes Path 1.219 +5 -2 src/sys/sys/mbuf.h From peter at wemm.org Tue Jan 8 22:31:51 2008 From: peter at wemm.org (Peter Wemm) Date: Tue Jan 8 22:31:55 2008 Subject: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c In-Reply-To: <200801082039.18671.max@love2party.net> References: <200801081908.m08J8wIs094059@repoman.freebsd.org> <200801082039.18671.max@love2party.net> Message-ID: On Jan 8, 2008 11:39 AM, Max Laier wrote: > On Tuesday 08 January 2008, David E. O'Brien wrote: > > obrien 2008-01-08 19:08:58 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c > > in6_pcb.c in6_proto.c in6_rmx.c in6_src.c > > ip6_input.c ip6_mroute.c ip6_output.c > > mld6.c nd6.c nd6_nbr.c nd6_rtr.c > > raw_ip6.c udp6_usrreq.c > > Log: > > un-__P() > > Do we do that again w/o immediate need and other changes to that file? I > was under the impression that it is deemed repo churn. That aside, I'm > all for the change. > Once apon a time (before cvsup) we used CTM - CVS-through-email - as the only way to get the cvs repository. The previous state of the tree was stored and a series of diffs were generated relative to the last run. The more that was touched, the larger the email update. When I first started developing on freebsd, that was how I got it. CTM chunks over a UUCP link. Other folks with real internet connections (ppp or maybe even a 64K link.. perhaps even a (gasp!) T1 link at the unimaginable speed of 1.5mbit/sec - they used this thing called 'SUP'. If you changed one character in a file, it downloaded the entire file from scratch. Those were the days that the 'avoid needless changes' policy was really critical. Roto-tilling the tree was painful for people downstream. Now, we have cvsup, anoncvs and rsync. It is a night-and-day difference. For the most part, we can afford cosmetic fixes and cleanups. There are people still getting CTM deltas, but it isn't as bad as SUP (which died the death it deserved). The main remaining constraints are concessions to the limitations of our SCM system and politeness to other developers. We need to avoid trivial changes for: 1) code that involves branches due to the suckiness of cvs, and 2) merge conflicts cause everybody pain. It is no fun getting 100 conflicts because somebody just did a de-__P() sweep. Having said that, we have grown overly sensitive to both 1) and 2). 1) will be fixed soon enough, and 2) is mostly a big deal only on stuff that other people are actively developing on. I'm not sure that we have too much activity in the ipv6 stack, and it certainly isn't vendor code anymore (the vendor has gone away). Now doing a roto-till of something like __P() in the ipv4 stack wouldn't be such a hot idea because there are lots of projects in progress that are already stomping on each other's toes. There isn't much room for gratuitous changes in there. However, ipv6 previously missed the tree-wide de-__P() sweep because (at the time) it was vendor code. For what its worth, I'm glad it was cleaned up. Also, I think we've gone too far in avoiding changes to vendor branched code "at all costs". It isn't *that* broken. I like what NetBSD(?) does these days by using the new -X flag(?) to cvs import, which takes the files off the vendor branch INSTANTLY. This is a very good thing as it gets the pain out of the way and fills a few huge holes in the vendor branch metadata. PS: and a pox on anybody who uses this as an excuse to revive the VCS bikeshed. If you do, I will forward a copy of every single email message that has been said on the subject since 1995. Individually. -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From kmacy at FreeBSD.org Wed Jan 9 00:01:09 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Wed Jan 9 00:01:14 2008 Subject: cvs commit: src/sys/dev/cxgb/sys mvec.h Message-ID: <200801090801.m09818jw016039@repoman.freebsd.org> kmacy 2008-01-09 08:01:08 UTC FreeBSD src repository Modified files: sys/dev/cxgb/sys mvec.h Log: EXT_PACKET is one of the valid mbuf types Revision Changes Path 1.10 +1 -0 src/sys/dev/cxgb/sys/mvec.h From kmacy at FreeBSD.org Wed Jan 9 00:01:43 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Wed Jan 9 00:01:46 2008 Subject: cvs commit: src/sys/dev/cxgb/sys uipc_mvec.c Message-ID: <200801090801.m0981hP8016561@repoman.freebsd.org> kmacy 2008-01-09 08:01:43 UTC FreeBSD src repository Modified files: sys/dev/cxgb/sys uipc_mvec.c Log: don't decrement ref count below 1 for EXT_PACKET Revision Changes Path 1.17 +1 -1 src/sys/dev/cxgb/sys/uipc_mvec.c From brueffer at FreeBSD.org Wed Jan 9 00:08:56 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Wed Jan 9 00:08:58 2008 Subject: cvs commit: src/share/man/man9 lock.9 Message-ID: <200801090808.m0988ufp019357@repoman.freebsd.org> brueffer 2008-01-09 08:08:56 UTC FreeBSD src repository Modified files: share/man/man9 lock.9 Log: Fix typos. Revision Changes Path 1.20 +3 -3 src/share/man/man9/lock.9 From kmacy at FreeBSD.org Wed Jan 9 00:12:26 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Wed Jan 9 00:12:29 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_adapter.h Message-ID: <200801090812.m098CP0b021025@repoman.freebsd.org> kmacy 2008-01-09 08:12:25 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_adapter.h Log: make nqsets a uint32_t so that sysctl will work add 2 fields for allowing queue dumping Revision Changes Path 1.23 +3 -1 src/sys/dev/cxgb/cxgb_adapter.h From delphij at FreeBSD.org Wed Jan 9 00:54:48 2008 From: delphij at FreeBSD.org (Xin LI) Date: Wed Jan 9 00:54:52 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-chipset.c ata-dma.c ata-lowlevel.c Message-ID: <200801090854.m098smom039312@repoman.freebsd.org> delphij 2008-01-09 08:54:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/ata ata-all.h ata-chipset.c ata-dma.c ata-lowlevel.c Log: MFC important fixes by sos@: Implement a workaround of the datacorruption problem on ServerWorks HT1000 chipsets. The HT1000 DMA engine seems to not always like 64K transfers and sometimes barfs data all over memory leading to instant chrash and burn. Also fix 48bit adressing issues, apparently newer chips needs 16bit writes and not the usual fifo thing. HW donated by: Travis Mikalson at TerraNovaNet Original work: sos Approved by: re (kensmith) Revision Changes Path 1.124.2.2 +2 -0 src/sys/dev/ata/ata-all.h 1.202.2.6 +141 -25 src/sys/dev/ata/ata-chipset.c 1.147.2.2 +1 -1 src/sys/dev/ata/ata-dma.c 1.79.2.1 +89 -67 src/sys/dev/ata/ata-lowlevel.c From delphij at FreeBSD.org Wed Jan 9 00:55:10 2008 From: delphij at FreeBSD.org (Xin LI) Date: Wed Jan 9 00:55:14 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-chipset.c ata-dma.c ata-lowlevel.c Message-ID: <200801090855.m098tAcT039405@repoman.freebsd.org> delphij 2008-01-09 08:55:10 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/dev/ata ata-all.h ata-chipset.c ata-dma.c ata-lowlevel.c Log: MFC important fixes by sos@: Implement a workaround of the datacorruption problem on ServerWorks HT1000 chipsets. The HT1000 DMA engine seems to not always like 64K transfers and sometimes barfs data all over memory leading to instant chrash and burn. Also fix 48bit adressing issues, apparently newer chips needs 16bit writes and not the usual fifo thing. HW donated by: Travis Mikalson at TerraNovaNet Original work: sos Approved by: re (kensmith) Revision Changes Path 1.124.2.1.2.1 +2 -0 src/sys/dev/ata/ata-all.h 1.202.2.5.2.1 +141 -25 src/sys/dev/ata/ata-chipset.c 1.147.2.1.2.1 +1 -1 src/sys/dev/ata/ata-dma.c 1.79.4.1 +89 -67 src/sys/dev/ata/ata-lowlevel.c From delphij at FreeBSD.org Wed Jan 9 00:55:51 2008 From: delphij at FreeBSD.org (Xin LI) Date: Wed Jan 9 00:55:53 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-chipset.c ata-dma.c ata-lowlevel.c Message-ID: <200801090855.m098tpW3039462@repoman.freebsd.org> delphij 2008-01-09 08:55:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/ata ata-all.h ata-chipset.c ata-dma.c ata-lowlevel.c Log: MFC important fixes by sos@: Implement a workaround of the datacorruption problem on ServerWorks HT1000 chipsets. The HT1000 DMA engine seems to not always like 64K transfers and sometimes barfs data all over memory leading to instant chrash and burn. Also fix 48bit adressing issues, apparently newer chips needs 16bit writes and not the usual fifo thing. HW donated by: Travis Mikalson at TerraNovaNet Original work: sos Revision Changes Path 1.103.2.14 +2 -0 src/sys/dev/ata/ata-all.h 1.126.2.26 +141 -25 src/sys/dev/ata/ata-chipset.c 1.137.2.5 +1 -1 src/sys/dev/ata/ata-dma.c 1.69.2.6 +89 -67 src/sys/dev/ata/ata-lowlevel.c From ru at FreeBSD.org Wed Jan 9 01:38:56 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Wed Jan 9 01:39:00 2008 Subject: cvs commit: src/usr.sbin/pkg_install/add pkg_add.1 Message-ID: <200801090938.m099ct4E058989@repoman.freebsd.org> ru 2008-01-09 09:38:54 UTC FreeBSD src repository Modified files: usr.sbin/pkg_install/add pkg_add.1 Log: Revise the TECHNICAL DETAILS section. Reviewed by: skv Revision Changes Path 1.75 +87 -68 src/usr.sbin/pkg_install/add/pkg_add.1 From bde at FreeBSD.org Wed Jan 9 02:42:48 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Wed Jan 9 02:42:49 2008 Subject: cvs commit: src/sys/amd64/include ieeefp.h Message-ID: <200801091042.m09Agm1H073369@repoman.freebsd.org> bde 2008-01-09 10:42:47 UTC FreeBSD src repository Modified files: sys/amd64/include ieeefp.h Log: Improve some comments. Revision Changes Path 1.15 +13 -14 src/sys/amd64/include/ieeefp.h From bde at FreeBSD.org Wed Jan 9 05:35:32 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Wed Jan 9 05:35:35 2008 Subject: cvs commit: src/sys/amd64/include ieeefp.h Message-ID: <200801091335.m09DZW7j026436@repoman.freebsd.org> bde 2008-01-09 13:35:31 UTC FreeBSD src repository Modified files: sys/amd64/include ieeefp.h Log: Fix some style bugs (mainly, use explicit shifts when accessing bit-fields even if the shift count happens to be 0, sort declarations, and spell __inline normally). Revision Changes Path 1.16 +31 -31 src/sys/amd64/include/ieeefp.h From bde at FreeBSD.org Wed Jan 9 07:03:03 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Wed Jan 9 07:03:06 2008 Subject: cvs commit: src/sys/amd64/include ieeefp.h Message-ID: <200801091503.m09F33EV044513@repoman.freebsd.org> bde 2008-01-09 15:03:03 UTC FreeBSD src repository Modified files: sys/amd64/include ieeefp.h Log: Simplify the ifdefs: - fix this to compile with C++ by casting ints to enums in a few places and by using the correct parameter type for _fpsetprec(). Remove __cplusplus ifdefs which disabled the buggy code. - remove __CC_SUPPORTS___INLINE ifdefs. `__inline' vs `inline', and either of these #defined away, are supposed to be handled by very old ifdefs in . Thus the __CC_SUPPORTS___INLINE macro is not needed here (or anywhere else that it used). It is less needed here than in most places, since this file is userland-only and userland is far from supporting INTEL_COMPILER. The __CC_SUPPORTS___INLINE__ macro which was used here is even less needed. It is to support spelling `inline' as `__inline__' instead of the usual spelling `__inline'. Fix some style bugs that I missed in the previous commit (remove unused asms and sort more variables). Revision Changes Path 1.17 +14 -21 src/sys/amd64/include/ieeefp.h From kib at FreeBSD.org Wed Jan 9 07:19:23 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Wed Jan 9 07:19:25 2008 Subject: cvs commit: src/sys/vm vm_map.c Message-ID: <200801091519.m09FJNUS047116@repoman.freebsd.org> kib 2008-01-09 15:19:23 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/vm vm_map.c Log: MFC rev. 1.392: In the vm_map_stack(), check for the specified stack region wraparound. Approved by: re (kensmith) Revision Changes Path 1.388.2.2 +3 -1 src/sys/vm/vm_map.c From mux at FreeBSD.org Wed Jan 9 07:22:06 2008 From: mux at FreeBSD.org (Maxime Henrion) Date: Wed Jan 9 07:22:09 2008 Subject: cvs commit: src/sys/net route.c route.h Message-ID: <200801091522.m09FM6jB048235@repoman.freebsd.org> mux 2008-01-09 15:22:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/net route.c route.h Log: MFC route.c@1.125 and route.h@1.68: Add a workaround for a deadlock between the rt_setgate() and rt_check() functions. It is easily triggered by running routed, and, I expect, by running any other daemon that uses routing sockets. Approved by: re (kensmith) Revision Changes Path 1.120.2.2 +10 -1 src/sys/net/route.c 1.65.2.1 +1 -0 src/sys/net/route.h From mux at FreeBSD.org Wed Jan 9 07:23:36 2008 From: mux at FreeBSD.org (Maxime Henrion) Date: Wed Jan 9 07:23:39 2008 Subject: cvs commit: src/sys/net route.c route.h Message-ID: <200801091523.m09FNaqT048674@repoman.freebsd.org> mux 2008-01-09 15:23:36 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/net route.c route.h Log: MFC route.c@1.125 and route.h@1.68: Add a workaround for a deadlock between the rt_setgate() and rt_check() functions. It is easily triggered by running routed, and, I expect, by running any other daemon that uses routing sockets. Approved by: re (kensmith) Revision Changes Path 1.120.2.1.2.1 +10 -1 src/sys/net/route.c 1.65.4.1 +1 -0 src/sys/net/route.h From kib at FreeBSD.org Wed Jan 9 07:30:35 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Wed Jan 9 07:30:37 2008 Subject: cvs commit: src/sys/compat/linux linux_stats.c Message-ID: <200801091530.m09FUYxP049224@repoman.freebsd.org> kib 2008-01-09 15:30:34 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/compat/linux linux_stats.c Log: MFC rev. 1.89, 1.90: Apply the LCONVPATH() to the (old) linux_stat() and linux_lstat() syscalls. Approved by: re (kensmith) Revision Changes Path 1.88.2.1 +21 -8 src/sys/compat/linux/linux_stats.c From mux at FreeBSD.org Wed Jan 9 07:38:50 2008 From: mux at FreeBSD.org (Maxime Henrion) Date: Wed Jan 9 07:38:53 2008 Subject: cvs commit: src/sys/net route.c route.h Message-ID: <200801091538.m09Fcn0w050430@repoman.freebsd.org> mux 2008-01-09 15:38:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/net route.c route.h Log: MFC route.c@1.125 and route.h@1.68: Add a workaround for a deadlock between the rt_setgate() and rt_check() functions. It is easily triggered by running routed, and, I expect, by running any other daemon that uses routing sockets. Revision Changes Path 1.109.2.5 +10 -1 src/sys/net/route.c 1.63.2.2 +1 -0 src/sys/net/route.h From kib at FreeBSD.org Wed Jan 9 07:59:16 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Wed Jan 9 07:59:17 2008 Subject: cvs commit: src/sys/vm vm_map.c Message-ID: <200801091559.m09FxFuj053279@repoman.freebsd.org> kib 2008-01-09 15:59:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/vm vm_map.c Log: MFC rev. 1.392: In the vm_map_stack(), check for the specified stack region wraparound. Approved by: re (kensmith) Revision Changes Path 1.388.2.1.2.1 +3 -1 src/sys/vm/vm_map.c From kib at FreeBSD.org Wed Jan 9 08:03:02 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Wed Jan 9 08:03:03 2008 Subject: cvs commit: src/sys/compat/linux linux_stats.c Message-ID: <200801091603.m09G323L054713@repoman.freebsd.org> kib 2008-01-09 16:03:02 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/compat/linux linux_stats.c Log: MFC rev. 1.89, 1.90: Apply the LCONVPATH() to the (old) linux_stat() and linux_lstat() syscalls. Approved by: re (kensmith) Revision Changes Path 1.88.4.1 +21 -8 src/sys/compat/linux/linux_stats.c From kib at FreeBSD.org Wed Jan 9 08:07:32 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Wed Jan 9 08:07:36 2008 Subject: cvs commit: src/sys/compat/linux linux_stats.c Message-ID: <200801091607.m09G7WdO055884@repoman.freebsd.org> kib 2008-01-09 16:07:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/compat/linux linux_stats.c Log: MFC rev. 1.89, 1.90: Apply the LCONVPATH() to the (old) linux_stat() and linux_lstat() syscalls. Revision Changes Path 1.72.2.8 +21 -8 src/sys/compat/linux/linux_stats.c From kib at FreeBSD.org Wed Jan 9 08:08:40 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Wed Jan 9 08:08:41 2008 Subject: cvs commit: src/sys/vm vm_map.c Message-ID: <200801091608.m09G8dHo055952@repoman.freebsd.org> kib 2008-01-09 16:08:39 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/vm vm_map.c Log: MFC rev. 1.392: In the vm_map_stack(), check for the specified stack region wraparound. Revision Changes Path 1.366.2.8 +3 -1 src/sys/vm/vm_map.c From mike at sentex.net Wed Jan 9 08:21:50 2008 From: mike at sentex.net (Mike Tancsa) Date: Wed Jan 9 08:21:55 2008 Subject: cvs commit: src/sys/net route.c route.h In-Reply-To: <200801091538.m09Fcn0w050430@repoman.freebsd.org> References: <200801091538.m09Fcn0w050430@repoman.freebsd.org> Message-ID: <200801091554.m09FsnUC049542@lava.sentex.ca> At 10:38 AM 1/9/2008, Maxime Henrion wrote: >mux 2008-01-09 15:38:49 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/net route.c route.h > Log: > MFC route.c@1.125 and route.h@1.68: > Add a workaround for a deadlock between the rt_setgate() and rt_check() > functions. It is easily triggered by running routed, and, I expect, by > running any other daemon that uses routing sockets. Hi, I have a number of boxes running full bgp tables with Quagga. How does the deadlock manifest itself ? I havent seen the boxes lockup ? Or does the deadlock create other symptoms ? ---Mike From obrien at FreeBSD.org Wed Jan 9 08:46:20 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Wed Jan 9 08:46:23 2008 Subject: cvs commit: src/contrib/libiberty - Imported sources Message-ID: <200801091646.m09GkJ4v061856@repoman.freebsd.org> obrien 2008-01-09 16:46:18 UTC FreeBSD src repository src/contrib/libiberty - Imported sources Update of /home/ncvs/src/contrib/libiberty In directory repoman.freebsd.org:/tmp/cvs-serv53246 Log Message: Bring in fix for Binutils PR other/16240: Check for a failure return from cplus_demangle_type. This is the rev 1.50-1.51 change. Our addr2line, etc.. would crash if used on C++ code that contains certain symbol types. One example is _ZN13PatternDriver23StringScalarDeleteValueC1ERKNS_25ConflateStringScalarValueERKNS_25AbstractStringScalarValueERKNS_12TemplateEnumINS_12pdcomplementELZNS_16complement_namesEELZNS_14COMPLEMENTENUMEEEE Status: Vendor Tag: FSF Release Tags: binutils_2_15_cvsrev_1_51 N src/contrib/libiberty/cp-demangle.c No conflicts created by this import From obrien at freebsd.org Wed Jan 9 09:08:51 2008 From: obrien at freebsd.org (David O'Brien) Date: Wed Jan 9 09:08:55 2008 Subject: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c In-Reply-To: References: <200801081908.m08J8wIs094059@repoman.freebsd.org> <200801082039.18671.max@love2party.net> Message-ID: <20080109170850.GA27993@dragon.NUXI.org> On Tue, Jan 08, 2008 at 10:31:49PM -0800, Peter Wemm wrote: > 2) merge conflicts cause everybody pain. It is no fun getting 100 conflicts > because somebody just did a de-__P() sweep. > > Having said that, we have grown overly sensitive to both 1) and 2). I agree. We seem to have become overly sensitive (and grown some assumption of some "rules") I note I did not complain when sys/agp was gratitiously renamed to sys/dev/agp from sys/pci. I had local changes that I had to move to new files and fixup afterwards. I didn't complain.. maybe I should have? What feature did that rename give? Nothing - just a "style" change. > For what its worth, I'm glad it was cleaned up. Its funny the amount of concern being generated over something that everyone that has said something says they are happy with. :-) -- -- David (obrien@FreeBSD.org) From sam at errno.com Wed Jan 9 09:34:06 2008 From: sam at errno.com (Sam Leffler) Date: Wed Jan 9 09:34:13 2008 Subject: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c In-Reply-To: <20080109170850.GA27993@dragon.NUXI.org> References: <200801081908.m08J8wIs094059@repoman.freebsd.org> <200801082039.18671.max@love2party.net> <20080109170850.GA27993@dragon.NUXI.org> Message-ID: <4785058B.1050507@errno.com> David O'Brien wrote: > On Tue, Jan 08, 2008 at 10:31:49PM -0800, Peter Wemm wrote: > >> 2) merge conflicts cause everybody pain. It is no fun getting 100 conflicts >> because somebody just did a de-__P() sweep. >> >> Having said that, we have grown overly sensitive to both 1) and 2). >> > > I agree. We seem to have become overly sensitive (and grown some > assumption of some "rules") > > I note I did not complain when sys/agp was gratitiously renamed to > sys/dev/agp from sys/pci. I had local changes that I had to move to new > files and fixup afterwards. I didn't complain.. maybe I should have? > What feature did that rename give? Nothing - just a "style" change. > > > >> For what its worth, I'm glad it was cleaned up. >> > > Its funny the amount of concern being generated over something that > everyone that has said something says they are happy with. :-) > > The flip side of this is that I just tried to resolve some compile issues with netstat in the RELENG_7 branch and diff's against HEAD hit all the gratuitous "style changes" you recently made. I believe changes like this are fine when actively working in a particular area of code; but all this "knob polishing" is more likely to introduce bugs than improve the state of the code. If this is a precursor to you pitching in to improve the ipv6 code then great. I observe that netbsd does these sorts of changes in sweeps over the tree and w/ multiple people involved to review each other's work. I'd be more confident if I saw commits like this include a "Reviewed by:" line. Sam From jhb at FreeBSD.org Wed Jan 9 10:00:24 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Wed Jan 9 10:00:26 2008 Subject: cvs commit: src/etc/gss mech Message-ID: <200801091800.m09I0O9N082494@repoman.freebsd.org> jhb 2008-01-09 18:00:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) etc/gss mech Log: MFC: Update the shlib version for libgssapi_krb5. Approved by: re (kensmith) Revision Changes Path 1.1.2.1 +1 -1 src/etc/gss/mech From jhb at FreeBSD.org Wed Jan 9 10:00:52 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Wed Jan 9 10:00:55 2008 Subject: cvs commit: src/etc/gss mech Message-ID: <200801091800.m09I0pNn082619@repoman.freebsd.org> jhb 2008-01-09 18:00:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) etc/gss mech Log: MFC: Update the shlib version for libgssapi_krb5. Approved by: re (kensmith) Revision Changes Path 1.1.4.1 +1 -1 src/etc/gss/mech From jhb at FreeBSD.org Wed Jan 9 10:01:52 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Wed Jan 9 10:01:56 2008 Subject: cvs commit: src/sys/i386/pci pci_pir.c Message-ID: <200801091801.m09I1qF9082983@repoman.freebsd.org> jhb 2008-01-09 18:01:52 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/i386/pci pci_pir.c Log: MFC: More properly handle links who only have 1 valid IRQ in their bitmask. Approved by: re (kensmith) Revision Changes Path 1.120.2.1 +12 -13 src/sys/i386/pci/pci_pir.c From jhb at FreeBSD.org Wed Jan 9 10:02:27 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Wed Jan 9 10:02:30 2008 Subject: cvs commit: src/sys/i386/pci pci_pir.c Message-ID: <200801091802.m09I2Rm5083209@repoman.freebsd.org> jhb 2008-01-09 18:02:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/i386/pci pci_pir.c Log: MFC: More properly handle links who only have 1 valid IRQ in their bitmask. Revision Changes Path 1.117.2.3 +12 -13 src/sys/i386/pci/pci_pir.c From obrien at FreeBSD.org Wed Jan 9 10:06:25 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Wed Jan 9 10:06:30 2008 Subject: cvs commit: src/usr.bin/top machine.c src/contrib/top top.c Message-ID: <200801091806.m09I6Ot4084997@repoman.freebsd.org> obrien 2008-01-09 18:06:24 UTC FreeBSD src repository Modified files: usr.bin/top machine.c contrib/top top.c Log: Improve -u (limit uid lookups) behavior. Submitted by: David Frascone PR: 119490 Revision Changes Path 1.24 +1 -1 src/contrib/top/top.c 1.84 +8 -2 src/usr.bin/top/machine.c From obrien at FreeBSD.org Wed Jan 9 10:14:07 2008 From: obrien at FreeBSD.org (David O'Brien) Date: Wed Jan 9 10:14:11 2008 Subject: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c In-Reply-To: <4785058B.1050507@errno.com> References: <200801081908.m08J8wIs094059@repoman.freebsd.org> <200801082039.18671.max@love2party.net> <20080109170850.GA27993@dragon.NUXI.org> <4785058B.1050507@errno.com> Message-ID: <20080109181239.GA29471@dragon.NUXI.org> On Wed, Jan 09, 2008 at 09:34:03AM -0800, Sam Leffler wrote: > David O'Brien wrote: > The flip side of this is that I just tried to resolve some compile issues > with netstat in the RELENG_7 branch and diff's against HEAD hit all the > gratuitous "style changes" you recently made. One way to avoid seeing them is to use some extra options to 'cvs diff'. 'cvs diff -kk -Bbw' reduces them to very little. (if there's a good doc to add the "-kk -Bbw" suggestion to, please let me know) -- -- David (obrien@FreeBSD.org) From mav at FreeBSD.org Wed Jan 9 11:51:22 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Wed Jan 9 11:51:25 2008 Subject: cvs commit: src/sys/netgraph ng_l2tp.c Message-ID: <200801091951.m09JpM8I013229@repoman.freebsd.org> mav 2008-01-09 19:51:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/netgraph ng_l2tp.c Log: MFC rev. 1.22 Increase control channel xmit queue to 128 packets. Previous value 16 was too small for real LAC as temporal activity spike cound easily overflow queue demanding tunnel disconnection due to possible state inconsistency. Approved by: re (gnn) Revision Changes Path 1.17.2.2 +1 -1 src/sys/netgraph/ng_l2tp.c From mav at FreeBSD.org Wed Jan 9 11:55:52 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Wed Jan 9 11:55:55 2008 Subject: cvs commit: src/sys/netgraph ng_l2tp.c Message-ID: <200801091955.m09JtqLD017147@repoman.freebsd.org> mav 2008-01-09 19:55:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/netgraph ng_l2tp.c Log: MFC rev. 1.22 Increase control channel xmit queue to 128 packets. Previous value 16 was too small for real LAC as temporal activity spike cound easily overflow queue demanding tunnel disconnection due to possible state inconsistency. Approved by: re (gnn) Revision Changes Path 1.17.2.1.2.1 +1 -1 src/sys/netgraph/ng_l2tp.c From scottl at FreeBSD.org Wed Jan 9 12:02:57 2008 From: scottl at FreeBSD.org (Scott Long) Date: Wed Jan 9 12:03:01 2008 Subject: cvs commit: src/sys/dev/iir iir.c Message-ID: <200801092002.m09K2ufO018340@repoman.freebsd.org> scottl 2008-01-09 20:02:56 UTC FreeBSD src repository Modified files: sys/dev/iir iir.c Log: Fix a buffer overflow in the processing of various SCSI commands. This likely fixes a an great number of weird problems that have been reported with this driver. PR: 119114 Submitted by: Jens Rehsack Revision Changes Path 1.20 +42 -26 src/sys/dev/iir/iir.c From peterjeremy at optushome.com.au Wed Jan 9 12:15:56 2008 From: peterjeremy at optushome.com.au (Peter Jeremy) Date: Wed Jan 9 12:16:01 2008 Subject: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c In-Reply-To: <4785058B.1050507@errno.com> References: <200801081908.m08J8wIs094059@repoman.freebsd.org> <200801082039.18671.max@love2party.net> <20080109170850.GA27993@dragon.NUXI.org> <4785058B.1050507@errno.com> Message-ID: <20080109201424.GA4969@server.vk2pj.dyndns.org> On Wed, Jan 09, 2008 at 09:34:03AM -0800, Sam Leffler wrote: >I observe that netbsd does these sorts of changes in sweeps over the tree >and w/ multiple people involved to review each other's work. I'd be more >confident if I saw commits like this include a "Reviewed by:" line. For this sort of commit, it should also be possible to check that you haven't broken anything by cmp(1)ing the .o files or manually preprocessing and diffing the preprocessed files. -- Peter Jeremy Please excuse any delays as the result of my ISP's inability to implement an MTA that is either RFC2821-compliant or matches their claimed behaviour. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080109/b16111b0/attachment.pgp From sam at errno.com Wed Jan 9 12:42:21 2008 From: sam at errno.com (Sam Leffler) Date: Wed Jan 9 12:42:31 2008 Subject: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c In-Reply-To: <20080109201424.GA4969@server.vk2pj.dyndns.org> References: <200801081908.m08J8wIs094059@repoman.freebsd.org> <200801082039.18671.max@love2party.net> <20080109170850.GA27993@dragon.NUXI.org> <4785058B.1050507@errno.com> <20080109201424.GA4969@server.vk2pj.dyndns.org> Message-ID: <478531AC.5030303@errno.com> Peter Jeremy wrote: > On Wed, Jan 09, 2008 at 09:34:03AM -0800, Sam Leffler wrote: > >> I observe that netbsd does these sorts of changes in sweeps over the tree >> and w/ multiple people involved to review each other's work. I'd be more >> confident if I saw commits like this include a "Reviewed by:" line. >> > > For this sort of commit, it should also be possible to check that you > haven't broken anything by cmp(1)ing the .o files or manually preprocessing > and diffing the preprocessed files. > For this specific case md5 checksums of the resulting .o files should work. However some committers have a history of making changes like this that either break the build (w/o a quick followup to correct the problem) or introduce subtle issues that aren't found until much later. Hence my request (removed by obrien) that people do changes like this when they are actively working on a section of code. Drive-by commits like this frequently do more harm than good. Sam From marius at FreeBSD.org Wed Jan 9 13:44:11 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Wed Jan 9 13:44:15 2008 Subject: cvs commit: src/sys/dev/pci pci_user.c Message-ID: <200801092144.m09LiBRn047596@repoman.freebsd.org> marius 2008-01-09 21:44:10 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/pci pci_user.c Log: MFC: 1.25 Fix some bugs in the FreeBSD 4/5/6 pci(4) IOCTLs compatibility code: - Use the correct offsets when copying out the results of PCIOCGETCONF_OLD. This happened to not affect the 64-bit architectures because there the addition of pc_domain to struct pcisel didn't change the overall size of struct pci_conf. - Always copy the name and unit information to conf_old so it's also part of the output once this information is cached in dinfo. - Use the correct type for flags in struct pci_match_conf_old. This change is more or less cosmetic though. Approved by: re (gnn) Revision Changes Path 1.22.2.2 +9 -12 src/sys/dev/pci/pci_user.c From marius at FreeBSD.org Wed Jan 9 13:45:37 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Wed Jan 9 13:45:39 2008 Subject: cvs commit: src/sys/dev/pci pci_user.c Message-ID: <200801092145.m09LjbMh047725@repoman.freebsd.org> marius 2008-01-09 21:45:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/dev/pci pci_user.c Log: MFC: 1.25 Fix some bugs in the FreeBSD 4/5/6 pci(4) IOCTLs compatibility code: - Use the correct offsets when copying out the results of PCIOCGETCONF_OLD. This happened to not affect the 64-bit architectures because there the addition of pc_domain to struct pcisel didn't change the overall size of struct pci_conf. - Always copy the name and unit information to conf_old so it's also part of the output once this information is cached in dinfo. - Use the correct type for flags in struct pci_match_conf_old. This change is more or less cosmetic though. Approved by: re (gnn) Revision Changes Path 1.22.2.1.2.1 +9 -12 src/sys/dev/pci/pci_user.c From rwatson at FreeBSD.org Wed Jan 9 16:26:48 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Wed Jan 9 16:26:51 2008 Subject: cvs commit: src/sys/ddb db_textdump.c Message-ID: <200801100026.m0A0Ql6h082513@repoman.freebsd.org> rwatson 2008-01-10 00:26:47 UTC FreeBSD src repository Modified files: sys/ddb db_textdump.c Log: Refine textdump comments slightly. MFC after: 3 months Revision Changes Path 1.2 +12 -10 src/sys/ddb/db_textdump.c From kmacy at FreeBSD.org Wed Jan 9 16:55:43 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Wed Jan 9 16:55:45 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_main.c cxgb_sge.c src/sys/dev/cxgb/common cxgb_t3_cpl.h src/sys/dev/cxgb/sys cxgb_support.c Message-ID: <200801100055.m0A0th1G095667@repoman.freebsd.org> kmacy 2008-01-10 00:55:42 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_main.c cxgb_sge.c sys/dev/cxgb/common cxgb_t3_cpl.h sys/dev/cxgb/sys cxgb_support.c Log: - make 9k clusters the default unless a tunable is set - return the error from cxgb_tx_common so that when an error is hit we dont spin forever in the taskq thread - remove unused rxsd_ref - simplify header_offset calculation for embedded mbuf headers - fix memory leak by making sure that mbuf header initialization took place - disable printf's for stalled queue, don't do offload/ctrl queue restart when tunnel queue is restarted - add more diagnostic information about the txq state - add facility to dump the actual contents of the hardware queue using sysctl Revision Changes Path 1.6 +1 -0 src/sys/dev/cxgb/common/cxgb_t3_cpl.h 1.42 +10 -5 src/sys/dev/cxgb/cxgb_main.c 1.36 +206 -118 src/sys/dev/cxgb/cxgb_sge.c 1.3 +7 -2 src/sys/dev/cxgb/sys/cxgb_support.c From edwin at FreeBSD.org Wed Jan 9 17:10:32 2008 From: edwin at FreeBSD.org (Edwin Groothuis) Date: Wed Jan 9 17:10:35 2008 Subject: cvs commit: src/share/misc committers-src.dot Message-ID: <200801100110.m0A1AVY7098810@repoman.freebsd.org> edwin 2008-01-10 01:10:31 UTC FreeBSD src repository Modified files: share/misc committers-src.dot Log: http://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/conventions.html 4.1 point 6: Add an entry for yourself to src/share/misc/committers-repository.dot, where repository is either doc, ports or src, depending on the commit privileges you obtained. Approved by: grog@ Revision Changes Path 1.69 +1 -0 src/share/misc/committers-src.dot From attilio at FreeBSD.org Wed Jan 9 17:10:59 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Wed Jan 9 17:11:01 2008 Subject: cvs commit: src/sys/compat/linprocfs linprocfs.c src/sys/compat/linux linux_file.c linux_getcwd.c src/sys/compat/opensolaris/kern opensolaris_kobj.c opensolaris_vfs.c src/sys/compat/opensolaris/sys vnode.h src/sys/compat/pecoff imgact_pecoff.c src/sys/compat/svr4 ... Message-ID: <200801100110.m0A1AwBc099854@repoman.freebsd.org> attilio 2008-01-10 01:10:58 UTC FreeBSD src repository Modified files: sys/compat/linprocfs linprocfs.c sys/compat/linux linux_file.c linux_getcwd.c sys/compat/opensolaris/kern opensolaris_kobj.c opensolaris_vfs.c sys/compat/opensolaris/sys vnode.h sys/compat/pecoff imgact_pecoff.c sys/compat/svr4 imgact_svr4.c svr4_fcntl.c svr4_misc.c sys/contrib/opensolaris/uts/common/fs gfs.c sys/contrib/opensolaris/uts/common/fs/zfs zfs_ctldir.c zfs_replay.c zfs_vfsops.c zfs_vnops.c zfs_znode.c sys/dev/hwpmc hwpmc_mod.c sys/dev/md md.c sys/fs/cd9660 cd9660_lookup.c cd9660_vfsops.c sys/fs/coda coda_vfsops.c coda_vnops.c sys/fs/devfs devfs_devs.c devfs_vnops.c sys/fs/fdescfs fdesc_vfsops.c fdesc_vnops.c sys/fs/fifofs fifo_vnops.c sys/fs/hpfs hpfs_vnops.c sys/fs/msdosfs msdosfs_lookup.c msdosfs_vfsops.c msdosfs_vnops.c sys/fs/ntfs ntfs_vfsops.c ntfs_vnops.c sys/fs/nullfs null_subr.c null_vfsops.c sys/fs/nwfs nwfs_node.c nwfs_vnops.c sys/fs/portalfs portal_vfsops.c portal_vnops.c sys/fs/procfs procfs.c procfs_map.c sys/fs/pseudofs pseudofs_vncache.c pseudofs_vnops.c sys/fs/smbfs smbfs_io.c smbfs_node.c smbfs_vnops.c sys/fs/tmpfs tmpfs_subr.c tmpfs_vfsops.c tmpfs_vnops.c sys/fs/udf udf_vnops.c sys/fs/unionfs union_subr.c union_vfsops.c union_vnops.c sys/gnu/fs/ext2fs ext2_lookup.c ext2_vfsops.c ext2_vnops.c fs.h sys/gnu/fs/reiserfs reiserfs_namei.c sys/gnu/fs/xfs/FreeBSD xfs_freebsd_iget.c xfs_super.c xfs_vnode.c xfs_vnops.c sys/i386/ibcs2 ibcs2_misc.c imgact_coff.c sys/i386/linux imgact_linux.c sys/kern imgact_aout.c imgact_elf.c imgact_gzip.c kern_alq.c kern_descrip.c kern_exec.c kern_jail.c kern_ktrace.c kern_proc.c kern_sig.c uipc_mqueue.c uipc_syscalls.c vfs_acl.c vfs_aio.c vfs_bio.c vfs_cache.c vfs_extattr.c vfs_lookup.c vfs_mount.c vfs_subr.c vfs_syscalls.c vfs_vnops.c sys/nfs4client nfs4_vnops.c sys/nfsclient nfs_subs.c nfs_vnops.c sys/nfsserver nfs_serv.c nfs_srvsubs.c sys/security/audit audit_arg.c audit_bsm_klib.c audit_worker.c sys/security/mac mac_process.c mac_syscalls.c sys/sys vnode.h sys/ufs/ffs ffs_snapshot.c ffs_softdep.c ffs_vfsops.c sys/ufs/ufs ufs_extattr.c ufs_lookup.c ufs_quota.c ufs_vnops.c sys/vm swap_pager.c vm_contig.c vm_object.c vnode_pager.c Log: vn_lock() is currently only used with the 'curthread' passed as argument. Remove this argument and pass curthread directly to underlying VOP_LOCK1() VFS method. This modify makes the code cleaner and in particular remove an annoying dependence helping next lockmgr() cleanup. KPI results, obviously, changed. Manpage and FreeBSD_version will be updated through further commits. As a side note, would be valuable to say that next commits will address a similar cleanup about VFS methods, in particular vop_lock1 and vop_unlock. Tested by: Diego Sardina , Andrea Di Pasquale Revision Changes Path 1.118 +1 -1 src/sys/compat/linprocfs/linprocfs.c 1.108 +1 -1 src/sys/compat/linux/linux_file.c 1.29 +2 -2 src/sys/compat/linux/linux_getcwd.c 1.5 +3 -3 src/sys/compat/opensolaris/kern/opensolaris_kobj.c 1.8 +3 -3 src/sys/compat/opensolaris/kern/opensolaris_vfs.c 1.4 +2 -2 src/sys/compat/opensolaris/sys/vnode.h 1.42 +1 -1 src/sys/compat/pecoff/imgact_pecoff.c 1.27 +1 -1 src/sys/compat/svr4/imgact_svr4.c 1.42 +1 -1 src/sys/compat/svr4/svr4_fcntl.c 1.99 +3 -3 src/sys/compat/svr4/svr4_misc.c 1.4 +1 -1 src/sys/contrib/opensolaris/uts/common/fs/gfs.c 1.6 +3 -3 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c 1.4 +7 -7 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_replay.c 1.13 +4 -4 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c 1.25 +5 -5 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c 1.11 +1 -1 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_znode.c 1.31 +1 -1 src/sys/dev/hwpmc/hwpmc_mod.c 1.172 +6 -6 src/sys/dev/md/md.c 1.44 +1 -1 src/sys/fs/cd9660/cd9660_lookup.c 1.152 +2 -2 src/sys/fs/cd9660/cd9660_vfsops.c 1.69 +3 -3 src/sys/fs/coda/coda_vfsops.c 1.77 +2 -2 src/sys/fs/coda/coda_vnops.c 1.52 +1 -1 src/sys/fs/devfs/devfs_devs.c 1.154 +5 -5 src/sys/fs/devfs/devfs_vnops.c 1.58 +1 -1 src/sys/fs/fdescfs/fdesc_vfsops.c 1.105 +2 -2 src/sys/fs/fdescfs/fdesc_vnops.c 1.141 +2 -2 src/sys/fs/fifofs/fifo_vnops.c 1.71 +1 -1 src/sys/fs/hpfs/hpfs_vnops.c 1.53 +1 -1 src/sys/fs/msdosfs/msdosfs_lookup.c 1.184 +2 -2 src/sys/fs/msdosfs/msdosfs_vfsops.c 1.182 +2 -2 src/sys/fs/msdosfs/msdosfs_vnops.c 1.91 +1 -1 src/sys/fs/ntfs/ntfs_vfsops.c 1.61 +1 -1 src/sys/fs/ntfs/ntfs_vnops.c 1.53 +1 -1 src/sys/fs/nullfs/null_subr.c 1.85 +2 -2 src/sys/fs/nullfs/null_vfsops.c 1.40 +1 -1 src/sys/fs/nwfs/nwfs_node.c 1.43 +1 -1 src/sys/fs/nwfs/nwfs_vnops.c 1.62 +1 -1 src/sys/fs/portalfs/portal_vfsops.c 1.74 +1 -2 src/sys/fs/portalfs/portal_vnops.c 1.17 +1 -1 src/sys/fs/procfs/procfs.c 1.41 +1 -1 src/sys/fs/procfs/procfs_map.c 1.39 +1 -1 src/sys/fs/pseudofs/pseudofs_vncache.c 1.66 +2 -2 src/sys/fs/pseudofs/pseudofs_vnops.c 1.42 +2 -2 src/sys/fs/smbfs/smbfs_io.c 1.35 +1 -1 src/sys/fs/smbfs/smbfs_node.c 1.66 +1 -1 src/sys/fs/smbfs/smbfs_vnops.c 1.15 +1 -1 src/sys/fs/tmpfs/tmpfs_subr.c 1.16 +1 -1 src/sys/fs/tmpfs/tmpfs_vfsops.c 1.14 +2 -2 src/sys/fs/tmpfs/tmpfs_vnops.c 1.67 +1 -1 src/sys/fs/udf/udf_vnops.c 1.97 +3 -3 src/sys/fs/unionfs/union_subr.c 1.88 +3 -3 src/sys/fs/unionfs/union_vfsops.c 1.151 +23 -22 src/sys/fs/unionfs/union_vnops.c 1.53 +1 -1 src/sys/gnu/fs/ext2fs/ext2_lookup.c 1.168 +3 -3 src/sys/gnu/fs/ext2fs/ext2_vfsops.c 1.111 +3 -3 src/sys/gnu/fs/ext2fs/ext2_vnops.c 1.19 +1 -1 src/sys/gnu/fs/ext2fs/fs.h 1.5 +1 -1 src/sys/gnu/fs/reiserfs/reiserfs_namei.c 1.3 +1 -1 src/sys/gnu/fs/xfs/FreeBSD/xfs_freebsd_iget.c 1.6 +1 -1 src/sys/gnu/fs/xfs/FreeBSD/xfs_super.c 1.3 +1 -1 src/sys/gnu/fs/xfs/FreeBSD/xfs_vnode.c 1.7 +6 -6 src/sys/gnu/fs/xfs/FreeBSD/xfs_vnops.c 1.69 +2 -2 src/sys/i386/ibcs2/ibcs2_misc.c 1.69 +1 -1 src/sys/i386/ibcs2/imgact_coff.c 1.57 +1 -1 src/sys/i386/linux/imgact_linux.c 1.103 +2 -3 src/sys/kern/imgact_aout.c 1.184 +2 -2 src/sys/kern/imgact_elf.c 1.57 +1 -1 src/sys/kern/imgact_gzip.c 1.21 +1 -1 src/sys/kern/kern_alq.c 1.319 +2 -2 src/sys/kern/kern_descrip.c 1.314 +4 -4 src/sys/kern/kern_exec.c 1.73 +1 -1 src/sys/kern/kern_jail.c 1.124 +1 -1 src/sys/kern/kern_ktrace.c 1.260 +1 -2 src/sys/kern/kern_proc.c 1.354 +1 -1 src/sys/kern/kern_sig.c 1.28 +3 -4 src/sys/kern/uipc_mqueue.c 1.262 +2 -2 src/sys/kern/uipc_syscalls.c 1.55 +3 -3 src/sys/kern/vfs_acl.c 1.235 +1 -1 src/sys/kern/vfs_aio.c 1.533 +1 -1 src/sys/kern/vfs_bio.c 1.116 +2 -2 src/sys/kern/vfs_cache.c 1.433 +4 -4 src/sys/kern/vfs_extattr.c 1.104 +12 -7 src/sys/kern/vfs_lookup.c 1.271 +2 -2 src/sys/kern/vfs_mount.c 1.714 +6 -6 src/sys/kern/vfs_subr.c 1.447 +20 -20 src/sys/kern/vfs_syscalls.c 1.257 +17 -16 src/sys/kern/vfs_vnops.c 1.38 +2 -2 src/sys/nfs4client/nfs4_vnops.c 1.148 +3 -3 src/sys/nfsclient/nfs_subs.c 1.278 +2 -2 src/sys/nfsclient/nfs_vnops.c 1.176 +13 -13 src/sys/nfsserver/nfs_serv.c 1.151 +1 -1 src/sys/nfsserver/nfs_srvsubs.c 1.16 +2 -2 src/sys/security/audit/audit_arg.c 1.9 +1 -1 src/sys/security/audit/audit_bsm_klib.c 1.18 +1 -1 src/sys/security/audit/audit_worker.c 1.121 +2 -2 src/sys/security/mac/mac_process.c 1.134 +2 -2 src/sys/security/mac/mac_syscalls.c 1.328 +2 -2 src/sys/sys/vnode.h 1.138 +6 -6 src/sys/ufs/ffs/ffs_snapshot.c 1.215 +2 -2 src/sys/ufs/ffs/ffs_softdep.c 1.332 +4 -4 src/sys/ufs/ffs/ffs_vfsops.c 1.87 +5 -9 src/sys/ufs/ufs/ufs_extattr.c 1.85 +3 -3 src/sys/ufs/ufs/ufs_lookup.c 1.96 +4 -6 src/sys/ufs/ufs/ufs_quota.c 1.294 +3 -3 src/sys/ufs/ufs/ufs_vnops.c 1.299 +3 -3 src/sys/vm/swap_pager.c 1.66 +1 -1 src/sys/vm/vm_contig.c 1.389 +1 -1 src/sys/vm/vm_object.c 1.239 +1 -1 src/sys/vm/vnode_pager.c From attilio at FreeBSD.org Wed Jan 9 17:24:00 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Wed Jan 9 17:24:03 2008 Subject: cvs commit: src/share/man/man9 VOP_LOCK.9 Message-ID: <200801100124.m0A1O0Fg002821@repoman.freebsd.org> attilio 2008-01-10 01:24:00 UTC FreeBSD src repository Modified files: share/man/man9 VOP_LOCK.9 Log: Update vn_lock() prototype accordingly with the 'thread' argument removal. Revision Changes Path 1.20 +5 -2 src/share/man/man9/VOP_LOCK.9 From attilio at FreeBSD.org Wed Jan 9 17:25:24 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Wed Jan 9 17:25:27 2008 Subject: cvs commit: src/sys/sys param.h Message-ID: <200801100125.m0A1PNJU002921@repoman.freebsd.org> attilio 2008-01-10 01:25:23 UTC FreeBSD src repository Modified files: sys/sys param.h Log: Bump FreeBSD_version in order to reflect vn_lock() prototype changes. Revision Changes Path 1.324 +1 -1 src/sys/sys/param.h From scottl at samsco.org Wed Jan 9 17:25:35 2008 From: scottl at samsco.org (Scott Long) Date: Wed Jan 9 17:25:39 2008 Subject: cvs commit: src/sys/compat/linprocfs linprocfs.c src/sys/compat/linux linux_file.c linux_getcwd.c src/sys/compat/opensolaris/kern opensolaris_kobj.c opensolaris_vfs.c src/sys/compat/opensolaris/sys vnode.h src/sys/compat/pecoff imgact_pecoff.c src/sys/compat/svr4 ... In-Reply-To: <200801100110.m0A1AwBc099854@repoman.freebsd.org> References: <200801100110.m0A1AwBc099854@repoman.freebsd.org> Message-ID: <4598CC24-E3D2-496E-B1ED-D60117F4C9E2@samsco.org> Am I reading your description right in that there will be multiple API changes coming? If so, are you going to do a single __FreeBSD_version bump for all of them, or a bump for each of them? Scott On Jan 9, 2008, at 6:10 PM, Attilio Rao wrote: > attilio 2008-01-10 01:10:58 UTC > > FreeBSD src repository > > Modified files: > sys/compat/linprocfs linprocfs.c > sys/compat/linux linux_file.c linux_getcwd.c > sys/compat/opensolaris/kern opensolaris_kobj.c > opensolaris_vfs.c > sys/compat/opensolaris/sys vnode.h > sys/compat/pecoff imgact_pecoff.c > sys/compat/svr4 imgact_svr4.c svr4_fcntl.c svr4_misc.c > sys/contrib/opensolaris/uts/common/fs gfs.c > sys/contrib/opensolaris/uts/common/fs/zfs zfs_ctldir.c > zfs_replay.c > zfs_vfsops.c > zfs_vnops.c > zfs_znode.c > sys/dev/hwpmc hwpmc_mod.c > sys/dev/md md.c > sys/fs/cd9660 cd9660_lookup.c cd9660_vfsops.c > sys/fs/coda coda_vfsops.c coda_vnops.c > sys/fs/devfs devfs_devs.c devfs_vnops.c > sys/fs/fdescfs fdesc_vfsops.c fdesc_vnops.c > sys/fs/fifofs fifo_vnops.c > sys/fs/hpfs hpfs_vnops.c > sys/fs/msdosfs msdosfs_lookup.c msdosfs_vfsops.c > msdosfs_vnops.c > sys/fs/ntfs ntfs_vfsops.c ntfs_vnops.c > sys/fs/nullfs null_subr.c null_vfsops.c > sys/fs/nwfs nwfs_node.c nwfs_vnops.c > sys/fs/portalfs portal_vfsops.c portal_vnops.c > sys/fs/procfs procfs.c procfs_map.c > sys/fs/pseudofs pseudofs_vncache.c pseudofs_vnops.c > sys/fs/smbfs smbfs_io.c smbfs_node.c smbfs_vnops.c > sys/fs/tmpfs tmpfs_subr.c tmpfs_vfsops.c tmpfs_vnops.c > sys/fs/udf udf_vnops.c > sys/fs/unionfs union_subr.c union_vfsops.c union_vnops.c > sys/gnu/fs/ext2fs ext2_lookup.c ext2_vfsops.c ext2_vnops.c > fs.h > sys/gnu/fs/reiserfs reiserfs_namei.c > sys/gnu/fs/xfs/FreeBSD xfs_freebsd_iget.c xfs_super.c > xfs_vnode.c xfs_vnops.c > sys/i386/ibcs2 ibcs2_misc.c imgact_coff.c > sys/i386/linux imgact_linux.c > sys/kern imgact_aout.c imgact_elf.c imgact_gzip.c > kern_alq.c kern_descrip.c kern_exec.c > kern_jail.c kern_ktrace.c kern_proc.c > kern_sig.c uipc_mqueue.c uipc_syscalls.c > vfs_acl.c vfs_aio.c vfs_bio.c vfs_cache.c > vfs_extattr.c vfs_lookup.c vfs_mount.c > vfs_subr.c vfs_syscalls.c vfs_vnops.c > sys/nfs4client nfs4_vnops.c > sys/nfsclient nfs_subs.c nfs_vnops.c > sys/nfsserver nfs_serv.c nfs_srvsubs.c > sys/security/audit audit_arg.c audit_bsm_klib.c > audit_worker.c > sys/security/mac mac_process.c mac_syscalls.c > sys/sys vnode.h > sys/ufs/ffs ffs_snapshot.c ffs_softdep.c ffs_vfsops.c > sys/ufs/ufs ufs_extattr.c ufs_lookup.c ufs_quota.c > ufs_vnops.c > sys/vm swap_pager.c vm_contig.c vm_object.c > vnode_pager.c > Log: > vn_lock() is currently only used with the 'curthread' passed as > argument. > Remove this argument and pass curthread directly to underlying > VOP_LOCK1() VFS method. This modify makes the code cleaner and in > particular remove an annoying dependence helping next lockmgr() > cleanup. > KPI results, obviously, changed. > > Manpage and FreeBSD_version will be updated through further commits. > > As a side note, would be valuable to say that next commits will > address > a similar cleanup about VFS methods, in particular vop_lock1 and > vop_unlock. > > Tested by: Diego Sardina , > Andrea Di Pasquale > > Revision Changes Path > 1.118 +1 -1 src/sys/compat/linprocfs/linprocfs.c > 1.108 +1 -1 src/sys/compat/linux/linux_file.c > 1.29 +2 -2 src/sys/compat/linux/linux_getcwd.c > 1.5 +3 -3 src/sys/compat/opensolaris/kern/ > opensolaris_kobj.c > 1.8 +3 -3 src/sys/compat/opensolaris/kern/ > opensolaris_vfs.c > 1.4 +2 -2 src/sys/compat/opensolaris/sys/vnode.h > 1.42 +1 -1 src/sys/compat/pecoff/imgact_pecoff.c > 1.27 +1 -1 src/sys/compat/svr4/imgact_svr4.c > 1.42 +1 -1 src/sys/compat/svr4/svr4_fcntl.c > 1.99 +3 -3 src/sys/compat/svr4/svr4_misc.c > 1.4 +1 -1 src/sys/contrib/opensolaris/uts/common/fs/gfs.c > 1.6 +3 -3 src/sys/contrib/opensolaris/uts/common/fs/zfs/ > zfs_ctldir.c > 1.4 +7 -7 src/sys/contrib/opensolaris/uts/common/fs/zfs/ > zfs_replay.c > 1.13 +4 -4 src/sys/contrib/opensolaris/uts/common/fs/zfs/ > zfs_vfsops.c > 1.25 +5 -5 src/sys/contrib/opensolaris/uts/common/fs/zfs/ > zfs_vnops.c > 1.11 +1 -1 src/sys/contrib/opensolaris/uts/common/fs/zfs/ > zfs_znode.c > 1.31 +1 -1 src/sys/dev/hwpmc/hwpmc_mod.c > 1.172 +6 -6 src/sys/dev/md/md.c > 1.44 +1 -1 src/sys/fs/cd9660/cd9660_lookup.c > 1.152 +2 -2 src/sys/fs/cd9660/cd9660_vfsops.c > 1.69 +3 -3 src/sys/fs/coda/coda_vfsops.c > 1.77 +2 -2 src/sys/fs/coda/coda_vnops.c > 1.52 +1 -1 src/sys/fs/devfs/devfs_devs.c > 1.154 +5 -5 src/sys/fs/devfs/devfs_vnops.c > 1.58 +1 -1 src/sys/fs/fdescfs/fdesc_vfsops.c > 1.105 +2 -2 src/sys/fs/fdescfs/fdesc_vnops.c > 1.141 +2 -2 src/sys/fs/fifofs/fifo_vnops.c > 1.71 +1 -1 src/sys/fs/hpfs/hpfs_vnops.c > 1.53 +1 -1 src/sys/fs/msdosfs/msdosfs_lookup.c > 1.184 +2 -2 src/sys/fs/msdosfs/msdosfs_vfsops.c > 1.182 +2 -2 src/sys/fs/msdosfs/msdosfs_vnops.c > 1.91 +1 -1 src/sys/fs/ntfs/ntfs_vfsops.c > 1.61 +1 -1 src/sys/fs/ntfs/ntfs_vnops.c > 1.53 +1 -1 src/sys/fs/nullfs/null_subr.c > 1.85 +2 -2 src/sys/fs/nullfs/null_vfsops.c > 1.40 +1 -1 src/sys/fs/nwfs/nwfs_node.c > 1.43 +1 -1 src/sys/fs/nwfs/nwfs_vnops.c > 1.62 +1 -1 src/sys/fs/portalfs/portal_vfsops.c > 1.74 +1 -2 src/sys/fs/portalfs/portal_vnops.c > 1.17 +1 -1 src/sys/fs/procfs/procfs.c > 1.41 +1 -1 src/sys/fs/procfs/procfs_map.c > 1.39 +1 -1 src/sys/fs/pseudofs/pseudofs_vncache.c > 1.66 +2 -2 src/sys/fs/pseudofs/pseudofs_vnops.c > 1.42 +2 -2 src/sys/fs/smbfs/smbfs_io.c > 1.35 +1 -1 src/sys/fs/smbfs/smbfs_node.c > 1.66 +1 -1 src/sys/fs/smbfs/smbfs_vnops.c > 1.15 +1 -1 src/sys/fs/tmpfs/tmpfs_subr.c > 1.16 +1 -1 src/sys/fs/tmpfs/tmpfs_vfsops.c > 1.14 +2 -2 src/sys/fs/tmpfs/tmpfs_vnops.c > 1.67 +1 -1 src/sys/fs/udf/udf_vnops.c > 1.97 +3 -3 src/sys/fs/unionfs/union_subr.c > 1.88 +3 -3 src/sys/fs/unionfs/union_vfsops.c > 1.151 +23 -22 src/sys/fs/unionfs/union_vnops.c > 1.53 +1 -1 src/sys/gnu/fs/ext2fs/ext2_lookup.c > 1.168 +3 -3 src/sys/gnu/fs/ext2fs/ext2_vfsops.c > 1.111 +3 -3 src/sys/gnu/fs/ext2fs/ext2_vnops.c > 1.19 +1 -1 src/sys/gnu/fs/ext2fs/fs.h > 1.5 +1 -1 src/sys/gnu/fs/reiserfs/reiserfs_namei.c > 1.3 +1 -1 src/sys/gnu/fs/xfs/FreeBSD/xfs_freebsd_iget.c > 1.6 +1 -1 src/sys/gnu/fs/xfs/FreeBSD/xfs_super.c > 1.3 +1 -1 src/sys/gnu/fs/xfs/FreeBSD/xfs_vnode.c > 1.7 +6 -6 src/sys/gnu/fs/xfs/FreeBSD/xfs_vnops.c > 1.69 +2 -2 src/sys/i386/ibcs2/ibcs2_misc.c > 1.69 +1 -1 src/sys/i386/ibcs2/imgact_coff.c > 1.57 +1 -1 src/sys/i386/linux/imgact_linux.c > 1.103 +2 -3 src/sys/kern/imgact_aout.c > 1.184 +2 -2 src/sys/kern/imgact_elf.c > 1.57 +1 -1 src/sys/kern/imgact_gzip.c > 1.21 +1 -1 src/sys/kern/kern_alq.c > 1.319 +2 -2 src/sys/kern/kern_descrip.c > 1.314 +4 -4 src/sys/kern/kern_exec.c > 1.73 +1 -1 src/sys/kern/kern_jail.c > 1.124 +1 -1 src/sys/kern/kern_ktrace.c > 1.260 +1 -2 src/sys/kern/kern_proc.c > 1.354 +1 -1 src/sys/kern/kern_sig.c > 1.28 +3 -4 src/sys/kern/uipc_mqueue.c > 1.262 +2 -2 src/sys/kern/uipc_syscalls.c > 1.55 +3 -3 src/sys/kern/vfs_acl.c > 1.235 +1 -1 src/sys/kern/vfs_aio.c > 1.533 +1 -1 src/sys/kern/vfs_bio.c > 1.116 +2 -2 src/sys/kern/vfs_cache.c > 1.433 +4 -4 src/sys/kern/vfs_extattr.c > 1.104 +12 -7 src/sys/kern/vfs_lookup.c > 1.271 +2 -2 src/sys/kern/vfs_mount.c > 1.714 +6 -6 src/sys/kern/vfs_subr.c > 1.447 +20 -20 src/sys/kern/vfs_syscalls.c > 1.257 +17 -16 src/sys/kern/vfs_vnops.c > 1.38 +2 -2 src/sys/nfs4client/nfs4_vnops.c > 1.148 +3 -3 src/sys/nfsclient/nfs_subs.c > 1.278 +2 -2 src/sys/nfsclient/nfs_vnops.c > 1.176 +13 -13 src/sys/nfsserver/nfs_serv.c > 1.151 +1 -1 src/sys/nfsserver/nfs_srvsubs.c > 1.16 +2 -2 src/sys/security/audit/audit_arg.c > 1.9 +1 -1 src/sys/security/audit/audit_bsm_klib.c > 1.18 +1 -1 src/sys/security/audit/audit_worker.c > 1.121 +2 -2 src/sys/security/mac/mac_process.c > 1.134 +2 -2 src/sys/security/mac/mac_syscalls.c > 1.328 +2 -2 src/sys/sys/vnode.h > 1.138 +6 -6 src/sys/ufs/ffs/ffs_snapshot.c > 1.215 +2 -2 src/sys/ufs/ffs/ffs_softdep.c > 1.332 +4 -4 src/sys/ufs/ffs/ffs_vfsops.c > 1.87 +5 -9 src/sys/ufs/ufs/ufs_extattr.c > 1.85 +3 -3 src/sys/ufs/ufs/ufs_lookup.c > 1.96 +4 -6 src/sys/ufs/ufs/ufs_quota.c > 1.294 +3 -3 src/sys/ufs/ufs/ufs_vnops.c > 1.299 +3 -3 src/sys/vm/swap_pager.c > 1.66 +1 -1 src/sys/vm/vm_contig.c > 1.389 +1 -1 src/sys/vm/vm_object.c > 1.239 +1 -1 src/sys/vm/vnode_pager.c From edwin at FreeBSD.org Wed Jan 9 17:25:40 2008 From: edwin at FreeBSD.org (Edwin Groothuis) Date: Wed Jan 9 17:25:43 2008 Subject: cvs commit: src/share/misc committers-ports.dot committers-src.dot Message-ID: <200801100125.m0A1PepN002951@repoman.freebsd.org> edwin 2008-01-10 01:25:40 UTC FreeBSD src repository Modified files: share/misc committers-ports.dot committers-src.dot Log: Make sure that grog is linked to me, and that I (in *-ports*) am linked to the people I helped out, and add them to the overview too. Approved by: grog@ Revision Changes Path 1.65 +4 -0 src/share/misc/committers-ports.dot 1.70 +1 -0 src/share/misc/committers-src.dot From attilio at freebsd.org Wed Jan 9 17:27:09 2008 From: attilio at freebsd.org (Attilio Rao) Date: Wed Jan 9 17:27:15 2008 Subject: cvs commit: src/sys/compat/linprocfs linprocfs.c src/sys/compat/linux linux_file.c linux_getcwd.c src/sys/compat/opensolaris/kern opensolaris_kobj.c opensolaris_vfs.c src/sys/compat/opensolaris/sys vnode.h src/sys/compat/pecoff imgact_pecoff.c sr Message-ID: <3bbf2fe10801091727s6106682q8144dba82db0f502@mail.gmail.com> 2008/1/10, Scott Long : > Am I reading your description right in that there will be multiple API > changes coming? If so, are you going to do a single __FreeBSD_version > bump for all of them, or a bump for each of them? As I'm going to do them gradually (some days can pass between one and another) I was planning to bump FreeBSD_version for any KPI change. Do you think it is not the right thing to do? Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein From sam at FreeBSD.org Wed Jan 9 20:26:44 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Wed Jan 9 20:26:46 2008 Subject: cvs commit: src/usr.sbin/arp arp.c Message-ID: <200801100426.m0A4QimN033810@repoman.freebsd.org> sam 2008-01-10 04:26:44 UTC FreeBSD src repository Modified files: usr.sbin/arp arp.c Log: quiet compiler complaint about comparing &v against NULL Revision Changes Path 1.66 +2 -2 src/usr.sbin/arp/arp.c From sam at FreeBSD.org Wed Jan 9 20:28:26 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Wed Jan 9 20:28:29 2008 Subject: cvs commit: src/usr.bin/netstat route.c Message-ID: <200801100428.m0A4SQot033864@repoman.freebsd.org> sam 2008-01-10 04:28:26 UTC FreeBSD src repository Modified files: usr.bin/netstat route.c Log: quiet compiler complaint about unused parameters Revision Changes Path 1.84 +2 -2 src/usr.bin/netstat/route.c From yuri.pankov at gmail.com Wed Jan 9 21:52:12 2008 From: yuri.pankov at gmail.com (Yuri Pankov) Date: Wed Jan 9 21:52:17 2008 Subject: cvs commit: src/share/termcap termcap.src In-Reply-To: <200801081600.m08G0OWf032139@repoman.freebsd.org> References: <200801081600.m08G0OWf032139@repoman.freebsd.org> Message-ID: <20080110055049.GB55492@darklight.org.ru> On Tue, Jan 08, 2008 at 04:00:24PM +0000, Rong-En Fan wrote: > rafan 2008-01-08 16:00:24 UTC > > FreeBSD src repository > > Modified files: > share/termcap termcap.src > Log: > - Remove kH and *6 from xterm. They are defined to the same key as @7 (kp_end). > As ncurses has the limitation that it returns the first matched key symbol, > you can not use END in ncurses based program, like mutt, with xterm. > - Add @8 (kp_enter) definition for xterm so you can use ENTER in xterm with > ncurses based program. > > I also found that NetBSD's xterm does the same thing. > > PR: 100150 > Reported by: Arseny Nasokin > Discussed with: Thomas Dickey, Ulrich Spoerlein > Reviewed by: freebsd-arch@ > MFC after: 2 month > > Revision Changes Path > 1.150 +2 -2 src/share/termcap/termcap.src Thanks from all xterm/ncurses users! Yuri From kmacy at FreeBSD.org Wed Jan 9 22:52:48 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Wed Jan 9 22:52:51 2008 Subject: cvs commit: src/sys/dev/cxgb/sys uipc_mvec.c Message-ID: <200801100652.m0A6qm0E087414@repoman.freebsd.org> kmacy 2008-01-10 06:52:48 UTC FreeBSD src repository Modified files: sys/dev/cxgb/sys uipc_mvec.c Log: should always free when refcount is 1 Revision Changes Path 1.18 +3 -1 src/sys/dev/cxgb/sys/uipc_mvec.c From kmacy at FreeBSD.org Wed Jan 9 22:54:21 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Wed Jan 9 22:54:22 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_adapter.h cxgb_sge.c Message-ID: <200801100654.m0A6sK86087694@repoman.freebsd.org> kmacy 2008-01-10 06:54:20 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_adapter.h cxgb_sge.c Log: Add support for selectively dumping the state of the hardware response queue. Change ordering of a couple of types. Revision Changes Path 1.24 +6 -8 src/sys/dev/cxgb/cxgb_adapter.h 1.37 +124 -39 src/sys/dev/cxgb/cxgb_sge.c From pjd at FreeBSD.org Thu Jan 10 00:36:39 2008 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Thu Jan 10 00:36:40 2008 Subject: cvs commit: src/sys/vm vm_kern.c Message-ID: <200801100836.m0A8acwG005416@repoman.freebsd.org> pjd 2008-01-10 08:36:38 UTC FreeBSD src repository Modified files: sys/vm vm_kern.c Log: When one tries to allocate memory with the M_WAITOK flag and we are short in address space in kmem map call vm_lowmem event in a loop and wait a bit for subsystems to reclaim some memory which in turn will reclaim address space as well. Note, this is a work-around. Reviewed by: alc Approved by: alc MFC after: 3 days Revision Changes Path 1.131 +13 -6 src/sys/vm/vm_kern.c From rwatson at FreeBSD.org Thu Jan 10 01:00:00 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Jan 10 01:00:07 2008 Subject: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c In-Reply-To: <478531AC.5030303@errno.com> References: <200801081908.m08J8wIs094059@repoman.freebsd.org> <200801082039.18671.max@love2party.net> <20080109170850.GA27993@dragon.NUXI.org> <4785058B.1050507@errno.com> <20080109201424.GA4969@server.vk2pj.dyndns.org> <478531AC.5030303@errno.com> Message-ID: <20080110085803.H66908@fledge.watson.org> On Wed, 9 Jan 2008, Sam Leffler wrote: > Peter Jeremy wrote: >> On Wed, Jan 09, 2008 at 09:34:03AM -0800, Sam Leffler wrote: >> >>> I observe that netbsd does these sorts of changes in sweeps over the tree >>> and w/ multiple people involved to review each other's work. I'd be more >>> confident if I saw commits like this include a "Reviewed by:" line. >> >> For this sort of commit, it should also be possible to check that you >> haven't broken anything by cmp(1)ing the .o files or manually preprocessing >> and diffing the preprocessed files. > > For this specific case md5 checksums of the resulting .o files should work. > However some committers have a history of making changes like this that > either break the build (w/o a quick followup to correct the problem) or > introduce subtle issues that aren't found until much later. Hence my > request (removed by obrien) that people do changes like this when they are > actively working on a section of code. Drive-by commits like this > frequently do more harm than good. In the past, we've had several subtle bugs crop up as a result of changing to ANSI C function prototypes, which no longer automatically promote arguments to int from shorter types (I think it's that way around). This caused some very subtle semantic changes in the socket code a few years ago and was a nightmare to track down. Unfortunately, I don't remember the details or I'd dig up the commit that fixed it, it was really quite tricky, as what on face value was a style change actually changed the semantics significantly. Robert N M Watson Computer Laboratory University of Cambridge From nvass at teledomenet.gr Thu Jan 10 03:45:00 2008 From: nvass at teledomenet.gr (Nikos Vassiliadis) Date: Thu Jan 10 03:45:06 2008 Subject: cvs commit: src/sys/net route.c route.h In-Reply-To: <200801091554.m09FsnUC049542@lava.sentex.ca> References: <200801091538.m09Fcn0w050430@repoman.freebsd.org> <200801091554.m09FsnUC049542@lava.sentex.ca> Message-ID: <200801101323.53589.nvass@teledomenet.gr> On Wednesday 09 January 2008 17:54:48 Mike Tancsa wrote: > At 10:38 AM 1/9/2008, Maxime Henrion wrote: > >mux 2008-01-09 15:38:49 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_6) > > sys/net route.c route.h > > Log: > > MFC route.c@1.125 and route.h@1.68: > > Add a workaround for a deadlock between the rt_setgate() and > > rt_check() functions. It is easily triggered by running routed, and, > > I expect, by running any other daemon that uses routing sockets. > > Hi, > I have a number of boxes running full bgp tables with > Quagga. How does the deadlock manifest itself ? I havent seen the > boxes lockup ? I was using routed over a UDP tunnel (/usr/share/examples/netgraph/udp.tunnel) to distribute routing information over some DSL lines. This stopped working when I upgraded one of the routers to FreeBSD-6. I never reported it, feeling that the setup(PPPoE + netgraph UDP tunnel + routed) to reproduce it, is somehow complicated. It seems that after Maxime's changes, the deadlock I was seeing is gone. Testing a similar setup, seems to work, as it did in the pre-FBSD-6 days. Nikos From rwatson at FreeBSD.org Thu Jan 10 04:29:15 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Jan 10 04:29:16 2008 Subject: cvs commit: src/sys/kern uipc_usrreq.c Message-ID: <200801101229.m0ACTEGb063611@repoman.freebsd.org> rwatson 2008-01-10 12:29:13 UTC FreeBSD src repository Modified files: sys/kern uipc_usrreq.c Log: Correct typos in comments. MFC after: 3 weeks Revision Changes Path 1.211 +2 -2 src/sys/kern/uipc_usrreq.c From rwatson at FreeBSD.org Thu Jan 10 04:38:18 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Jan 10 04:38:21 2008 Subject: cvs commit: src/sys/kern uipc_usrreq.c Message-ID: <200801101238.m0ACcHx9065052@repoman.freebsd.org> rwatson 2008-01-10 12:38:17 UTC FreeBSD src repository Modified files: sys/kern uipc_usrreq.c Log: Remove "lock pushdown" todo item in comment -- I did that for 7.0. MFC after: 3 weeks Revision Changes Path 1.212 +0 -1 src/sys/kern/uipc_usrreq.c From des at FreeBSD.org Thu Jan 10 06:51:26 2008 From: des at FreeBSD.org (Dag-Erling Smorgrav) Date: Thu Jan 10 06:51:30 2008 Subject: cvs commit: src/games/fortune/datfiles fortunes Message-ID: <200801101451.m0AEpPUS013303@repoman.freebsd.org> des 2008-01-10 14:51:25 UTC FreeBSD src repository Modified files: games/fortune/datfiles fortunes Log: A real gem from freebsd-current@ Revision Changes Path 1.255 +3 -0 src/games/fortune/datfiles/fortunes From rpaulo at FreeBSD.org Thu Jan 10 08:09:22 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Thu Jan 10 08:09:26 2008 Subject: cvs commit: src/sys/dev/coretemp coretemp.c Message-ID: <200801101609.m0AG9M14026971@repoman.freebsd.org> rpaulo 2008-01-10 16:09:22 UTC FreeBSD src repository Modified files: sys/dev/coretemp coretemp.c Log: Disable the check for errata AE18. On MacBooks (1,1 version) there's no problem with coretemp and C3 state. Approved by: njl (mentor) Revision Changes Path 1.5 +6 -0 src/sys/dev/coretemp/coretemp.c From jkim at FreeBSD.org Thu Jan 10 08:31:15 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Thu Jan 10 08:31:19 2008 Subject: cvs commit: src/usr.sbin/pmcstat pmcstat.c Message-ID: <200801101631.m0AGVEoK030889@repoman.freebsd.org> jkim 2008-01-10 16:31:14 UTC FreeBSD src repository Modified files: usr.sbin/pmcstat pmcstat.c Log: Fix non-SMP kernel regression introduced in the previous commit. Reviewed by: jkoshy Revision Changes Path 1.19 +7 -4 src/usr.sbin/pmcstat/pmcstat.c From nate at root.org Thu Jan 10 09:14:44 2008 From: nate at root.org (Nate Lawson) Date: Thu Jan 10 09:14:49 2008 Subject: cvs commit: src/sys/dev/coretemp coretemp.c In-Reply-To: <20080110160925.E4EB116A47F@hub.freebsd.org> References: <20080110160925.E4EB116A47F@hub.freebsd.org> Message-ID: <47865280.2060503@root.org> Rui Paulo wrote: > rpaulo 2008-01-10 16:09:22 UTC > > FreeBSD src repository > > Modified files: > sys/dev/coretemp coretemp.c > Log: > Disable the check for errata AE18. On MacBooks (1,1 version) there's > no problem with coretemp and C3 state. > > Approved by: njl (mentor) > > Revision Changes Path > 1.5 +6 -0 src/sys/dev/coretemp/coretemp.c > Note that this should not be MFCd for a while, at least until after the current set of releases. It is safer to have the errata in case we don't fully understand why it was added in the first place. -- Nate From peterjeremy at optushome.com.au Thu Jan 10 10:32:00 2008 From: peterjeremy at optushome.com.au (Peter Jeremy) Date: Thu Jan 10 10:32:07 2008 Subject: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c In-Reply-To: <20080110085803.H66908@fledge.watson.org> References: <200801081908.m08J8wIs094059@repoman.freebsd.org> <200801082039.18671.max@love2party.net> <20080109170850.GA27993@dragon.NUXI.org> <4785058B.1050507@errno.com> <20080109201424.GA4969@server.vk2pj.dyndns.org> <478531AC.5030303@errno.com> <20080110085803.H66908@fledge.watson.org> Message-ID: <20080110183028.GT4442@server.vk2pj.dyndns.org> On Thu, Jan 10, 2008 at 08:59:59AM +0000, Robert Watson wrote: >In the past, we've had several subtle bugs crop up as a result of changing >to ANSI C function prototypes, which no longer automatically promote >arguments to int from shorter types I hadn't considered that but it _is_ the sort of thing that comparing object files would detect - if you make a supposedly stylistic change and the generated code changes then it's time to take a much more careful look into what you are doing. > (I think it's that way around). That would be correct - I know Sun Studio 11 (at least) warns about the situation where mixing ANSI and K&R prototypes/definitions causes type mismatches due to implicit promotion. I thought gcc did as well. -- Peter Jeremy Please excuse any delays as the result of my ISP's inability to implement an MTA that is either RFC2821-compliant or matches their claimed behaviour. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080110/08c2987d/attachment.pgp From brueffer at FreeBSD.org Thu Jan 10 11:11:38 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Thu Jan 10 11:11:42 2008 Subject: cvs commit: src/share/man/man9 VOP_LOCK.9 Message-ID: <200801101911.m0AJBb2t067307@repoman.freebsd.org> brueffer 2008-01-10 19:11:37 UTC FreeBSD src repository Modified files: share/man/man9 VOP_LOCK.9 Log: Removed a contraction. Revision Changes Path 1.21 +1 -1 src/share/man/man9/VOP_LOCK.9 From dougb at FreeBSD.org Thu Jan 10 12:07:34 2008 From: dougb at FreeBSD.org (Doug Barton) Date: Thu Jan 10 12:07:39 2008 Subject: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c In-Reply-To: <20080110085803.H66908@fledge.watson.org> References: <200801081908.m08J8wIs094059@repoman.freebsd.org> <200801082039.18671.max@love2party.net> <20080109170850.GA27993@dragon.NUXI.org> <4785058B.1050507@errno.com> <20080109201424.GA4969@server.vk2pj.dyndns.org> <478531AC.5030303@errno.com> <20080110085803.H66908@fledge.watson.org> Message-ID: <47867B03.9060205@FreeBSD.org> Robert Watson wrote: > In the past, we've had several subtle bugs crop up as a result of > changing to ANSI C function prototypes Ok, so isn't the conclusion we should reach here, "Don't do style changes unless you're willing to verify that the resulting binaries are the same before and after?" Do we really need to keep flogging this topic? Doug -- This .signature sanitized for your protection From thompsa at FreeBSD.org Thu Jan 10 12:53:14 2008 From: thompsa at FreeBSD.org (Andrew Thompson) Date: Thu Jan 10 12:53:17 2008 Subject: cvs commit: src/usr.bin/netstat route.c Message-ID: <200801102053.m0AKrD9X002573@repoman.freebsd.org> thompsa 2008-01-10 20:53:13 UTC FreeBSD src repository Modified files: usr.bin/netstat route.c Log: Add IFT_BRIDGE to the Ethernet section so l2 addresses are formatted correctly. PR: bin/119542 Submitted by: Niki Denev Revision Changes Path 1.85 +1 -0 src/usr.bin/netstat/route.c From jhb at FreeBSD.org Thu Jan 10 13:17:13 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 10 13:17:15 2008 Subject: cvs commit: src/sys/dev/pci pci.c Message-ID: <200801102117.m0ALHCDd007267@repoman.freebsd.org> jhb 2008-01-10 21:17:12 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/pci pci.c Log: Flip the switch to enable MSI by default on 6.x. This will not be MFC'd into 6.3. Revision Changes Path 1.292.2.23 +2 -2 src/sys/dev/pci/pci.c From rwatson at FreeBSD.org Thu Jan 10 14:11:21 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Jan 10 14:11:22 2008 Subject: cvs commit: src/sys/kern init_main.c kern_proc.c kern_resource.c kern_synch.c src/sys/sys proc.h Message-ID: <200801102211.m0AMBLTk018016@repoman.freebsd.org> rwatson 2008-01-10 22:11:21 UTC FreeBSD src repository Modified files: sys/kern init_main.c kern_proc.c kern_resource.c kern_synch.c sys/sys proc.h Log: Don't zero td_runtime when billing thread CPU usage to the process; maintain a separate td_incruntime to hold unbilled CPU usage for the thread that has the previous properties of td_runtime. When thread information is requested using the thread monitoring sysctls, export thread td_runtime instead of process rusage runtime in kinfo_proc. This restores the display of individual ithread and other kernel thread CPU usage since inception in ps -H and top -SH, as well for libthr user threads, valuable debugging information lost with the move to try kthreads since they are no longer independent processes. There is universal agreement that we should rewrite the process and thread export sysctls, but this commit gets things going a bit better in the mean time. Likewise, there are resevations about the continued validity of statclock given the speed of modern processors. Reviewed by: attilio, emaste, jhb, julian Revision Changes Path 1.290 +4 -0 src/sys/kern/init_main.c 1.261 +13 -7 src/sys/kern/kern_proc.c 1.182 +3 -3 src/sys/kern/kern_resource.c 1.305 +4 -2 src/sys/kern/kern_synch.c 1.499 +1 -0 src/sys/sys/proc.h From jhb at FreeBSD.org Thu Jan 10 14:11:21 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 10 14:11:31 2008 Subject: cvs commit: src/include unistd.h src/lib/libc/gen Makefile.inc feature_present.3 feature_present.c Message-ID: <200801102211.m0AMBLVQ018032@repoman.freebsd.org> jhb 2008-01-10 22:11:21 UTC FreeBSD src repository Modified files: include unistd.h lib/libc/gen Makefile.inc Added files: lib/libc/gen feature_present.3 feature_present.c Log: Add a feature_present(3) function which checks to see if a named kernel feature is present by checking the kern.features sysctl MIB. MFC after: 1 week Revision Changes Path 1.81 +1 -0 src/include/unistd.h 1.130 +3 -2 src/lib/libc/gen/Makefile.inc 1.1 +72 -0 src/lib/libc/gen/feature_present.3 (new) 1.1 +62 -0 src/lib/libc/gen/feature_present.c (new) From jhb at FreeBSD.org Thu Jan 10 15:36:00 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 10 15:36:02 2008 Subject: cvs commit: src/sys/nfsclient nfs_socket.c Message-ID: <200801102336.m0ANa0mP035046@repoman.freebsd.org> jhb 2008-01-10 23:36:00 UTC FreeBSD src repository Modified files: sys/nfsclient nfs_socket.c Log: Pass curthread to various socket routines (socreate(), sobind(), and soconnect()) instead of &thread0 when establishing a connection to the NFS server. Otherwise inconsistent credentials may be used when setting up the NFS socket. MFC after: 1 week Reviewed by: rwatson Revision Changes Path 1.156 +1 -1 src/sys/nfsclient/nfs_socket.c From jhb at FreeBSD.org Thu Jan 10 15:43:50 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 10 15:43:51 2008 Subject: cvs commit: src/sys/dev/ppbus ppbconf.c ppbconf.h Message-ID: <200801102343.m0ANhnCO038997@repoman.freebsd.org> jhb 2008-01-10 23:43:48 UTC FreeBSD src repository Modified files: sys/dev/ppbus ppbconf.c ppbconf.h Log: Work around problems with the ppbus(4)'s interesting way of managing interrupt handlers for child devices by adding a dummy handler that is always present so that the underlying interrupt thread is always around avoiding panics from stray interrupts. MFC after: 3 days Revision Changes Path 1.27 +37 -0 src/sys/dev/ppbus/ppbconf.c 1.20 +3 -0 src/sys/dev/ppbus/ppbconf.h From kmacy at FreeBSD.org Thu Jan 10 15:51:35 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Thu Jan 10 15:51:41 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_sge.c Message-ID: <200801102351.m0ANpYIJ040227@repoman.freebsd.org> kmacy 2008-01-10 23:51:34 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_sge.c Log: If we're not running with multiqueue enabled we need to wait to acquire the rspq lock. Not doing so was causing us to skip re-enabling the interrupt. - remove duplicate credits sysctl - add support for dumping hardware context of the txq - decrement budget_left when we break out of the process_responses loop Revision Changes Path 1.38 +41 -14 src/sys/dev/cxgb/cxgb_sge.c From julian at elischer.org Thu Jan 10 16:01:48 2008 From: julian at elischer.org (Julian Elischer) Date: Thu Jan 10 16:01:56 2008 Subject: cvs commit: src/sys/nfsclient nfs_socket.c In-Reply-To: <200801102336.m0ANa0mP035046@repoman.freebsd.org> References: <200801102336.m0ANa0mP035046@repoman.freebsd.org> Message-ID: <4786B202.4020708@elischer.org> John Baldwin wrote: > jhb 2008-01-10 23:36:00 UTC > > FreeBSD src repository > > Modified files: > sys/nfsclient nfs_socket.c > Log: > Pass curthread to various socket routines (socreate(), sobind(), and > soconnect()) instead of &thread0 when establishing a connection to the NFS > server. Otherwise inconsistent credentials may be used when setting up > the NFS socket. > > MFC after: 1 week > Reviewed by: rwatson > > Revision Changes Path > 1.156 +1 -1 src/sys/nfsclient/nfs_socket.c originally it was proc0 From alfred at freebsd.org Thu Jan 10 16:48:57 2008 From: alfred at freebsd.org (Alfred Perlstein) Date: Thu Jan 10 16:49:01 2008 Subject: cvs commit: src/games/fortune/datfiles fortunes In-Reply-To: <200801101451.m0AEpPUS013303@repoman.freebsd.org> References: <200801101451.m0AEpPUS013303@repoman.freebsd.org> Message-ID: <20080111004601.GB52842@elvis.mu.org> * Dag-Erling Smorgrav [080110 06:48] wrote: > des 2008-01-10 14:51:25 UTC > > FreeBSD src repository > > Modified files: > games/fortune/datfiles fortunes > Log: > A real gem from freebsd-current@ > > Revision Changes Path > 1.255 +3 -0 src/games/fortune/datfiles/fortunes Link? Wiki'ing that name is weird... -- - Alfred Perlstein From alfred at freebsd.org Thu Jan 10 17:03:30 2008 From: alfred at freebsd.org (Alfred Perlstein) Date: Thu Jan 10 17:03:34 2008 Subject: cvs commit: src/sys/nfsclient nfs_socket.c In-Reply-To: <200801102336.m0ANa0mP035046@repoman.freebsd.org> References: <200801102336.m0ANa0mP035046@repoman.freebsd.org> Message-ID: <20080111010033.GC52842@elvis.mu.org> * John Baldwin [080110 15:33] wrote: > jhb 2008-01-10 23:36:00 UTC > > FreeBSD src repository > > Modified files: > sys/nfsclient nfs_socket.c > Log: > Pass curthread to various socket routines (socreate(), sobind(), and > soconnect()) instead of &thread0 when establishing a connection to the NFS > server. Otherwise inconsistent credentials may be used when setting up > the NFS socket. I'm not sure, but I think this may be a regression, I seem to recall that a long time ago it was switched to &thread0 because otherwise certain operations can fail due to curthread not running as root. Rev 1.73 of this file might have some clues. I think something weird with ipfw+uid rules can happen with curthread rather than thread0, but I might be mistaking 1.73 for some other change. > > MFC after: 1 week > Reviewed by: rwatson > > Revision Changes Path > 1.156 +1 -1 src/sys/nfsclient/nfs_socket.c -- - Alfred Perlstein From peter at wemm.org Thu Jan 10 17:41:47 2008 From: peter at wemm.org (Peter Wemm) Date: Thu Jan 10 17:41:53 2008 Subject: cvs commit: src/sys/nfsclient nfs_socket.c In-Reply-To: <20080111010033.GC52842@elvis.mu.org> References: <200801102336.m0ANa0mP035046@repoman.freebsd.org> <20080111010033.GC52842@elvis.mu.org> Message-ID: On Jan 10, 2008 5:00 PM, Alfred Perlstein wrote: > > * John Baldwin [080110 15:33] wrote: > > jhb 2008-01-10 23:36:00 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/nfsclient nfs_socket.c > > Log: > > Pass curthread to various socket routines (socreate(), sobind(), and > > soconnect()) instead of &thread0 when establishing a connection to the NFS > > server. Otherwise inconsistent credentials may be used when setting up > > the NFS socket. > > I'm not sure, but I think this may be a regression, I seem to recall > that a long time ago it was switched to &thread0 because otherwise > certain operations can fail due to curthread not running as root. That's my recollection too. For example, when nfs is configured to bind to a priviliged local port for making queries or connections, it had to be done as root. With tcp mounts, the connection can be dropped and a reconnect required at any time. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From kmacy at FreeBSD.org Thu Jan 10 18:26:55 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Thu Jan 10 18:26:58 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_adapter.h cxgb_main.c cxgb_sge.c Message-ID: <200801110226.m0B2QssG082675@repoman.freebsd.org> kmacy 2008-01-11 02:26:54 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_adapter.h cxgb_main.c cxgb_sge.c Log: Be more aggressive about tx cleaning - when multiples streams were running the tx queue could fill up and stop getting cleaned. Revision Changes Path 1.25 +2 -1 src/sys/dev/cxgb/cxgb_adapter.h 1.43 +3 -2 src/sys/dev/cxgb/cxgb_main.c 1.39 +33 -12 src/sys/dev/cxgb/cxgb_sge.c From alfred at freebsd.org Thu Jan 10 18:39:25 2008 From: alfred at freebsd.org (Alfred Perlstein) Date: Thu Jan 10 18:39:30 2008 Subject: cvs commit: src/sys/nfsclient nfs_socket.c In-Reply-To: References: <200801102336.m0ANa0mP035046@repoman.freebsd.org> <20080111010033.GC52842@elvis.mu.org> Message-ID: <20080111023628.GB99258@elvis.mu.org> * Peter Wemm [080110 17:39] wrote: > On Jan 10, 2008 5:00 PM, Alfred Perlstein wrote: > > > > * John Baldwin [080110 15:33] wrote: > > > jhb 2008-01-10 23:36:00 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/nfsclient nfs_socket.c > > > Log: > > > Pass curthread to various socket routines (socreate(), sobind(), and > > > soconnect()) instead of &thread0 when establishing a connection to the NFS > > > server. Otherwise inconsistent credentials may be used when setting up > > > the NFS socket. > > > > I'm not sure, but I think this may be a regression, I seem to recall > > that a long time ago it was switched to &thread0 because otherwise > > certain operations can fail due to curthread not running as root. > > That's my recollection too. For example, when nfs is configured to > bind to a priviliged local port for making queries or connections, it > had to be done as root. With tcp mounts, the connection can be > dropped and a reconnect required at any time. This could be implemented by a handoff to a thread that does the appropriate setuid call beforehand, or perhaps the credential inconsistencies can be further expained or fixed. -Alfred From das at FreeBSD.org Thu Jan 10 20:18:26 2008 From: das at FreeBSD.org (David Schultz) Date: Thu Jan 10 20:18:29 2008 Subject: cvs commit: src/lib/msun/src s_csqrt.c s_csqrtf.c Message-ID: <200801110418.m0B4IQlv001237@repoman.freebsd.org> das 2008-01-11 04:18:26 UTC FreeBSD src repository Modified files: lib/msun/src s_csqrt.c s_csqrtf.c Log: - Correct the range check in the double version to catch negative values that would overflow. - Style fixes and improved handling of NaNs suggested by bde. Revision Changes Path 1.2 +19 -16 src/lib/msun/src/s_csqrt.c 1.2 +3 -3 src/lib/msun/src/s_csqrtf.c From jc at irbs.com Thu Jan 10 22:23:41 2008 From: jc at irbs.com (John Capo) Date: Thu Jan 10 22:23:47 2008 Subject: cvs commit: src/sys/net route.c route.h In-Reply-To: <200801091538.m09Fcn0w050430@repoman.freebsd.org> References: <200801091538.m09Fcn0w050430@repoman.freebsd.org> Message-ID: <20080111055442.GA76580@exuma.irbs.com> Quoting Maxime Henrion (mux@FreeBSD.org): > mux 2008-01-09 15:38:49 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > sys/net route.c route.h > Log: > MFC route.c@1.125 and route.h@1.68: > Add a workaround for a deadlock between the rt_setgate() and rt_check() > functions. It is easily triggered by running routed, and, I expect, by > running any other daemon that uses routing sockets. Would the symptom be a unresponsive machine? I just experienced a hung machine running quagga ospfd. Had to hit the BRS :-( > > Revision Changes Path > 1.109.2.5 +10 -1 src/sys/net/route.c > 1.63.2.2 +1 -0 src/sys/net/route.h > _______________________________________________ > cvs-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-all > To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" From nvass at teledomenet.gr Fri Jan 11 01:44:10 2008 From: nvass at teledomenet.gr (Nikos Vassiliadis) Date: Fri Jan 11 01:44:16 2008 Subject: cvs commit: src/sys/net route.c route.h In-Reply-To: <200801101323.53589.nvass@teledomenet.gr> References: <200801091538.m09Fcn0w050430@repoman.freebsd.org> <200801091554.m09FsnUC049542@lava.sentex.ca> <200801101323.53589.nvass@teledomenet.gr> Message-ID: <200801111144.07070.nvass@teledomenet.gr> On Thursday 10 January 2008 13:23:52 Nikos Vassiliadis wrote: > It seems that after Maxime's changes, the deadlock I was > seeing is gone. Testing a similar setup, seems to work, > as it did in the pre-FBSD-6 days. Unfortunately my report is false, it still ceases working i.e. the machine does not respond and can't break to the debugger. Nikos From kib at FreeBSD.org Fri Jan 11 03:53:05 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Fri Jan 11 03:53:07 2008 Subject: cvs commit: src/sys/dev/fdc fdc.c Message-ID: <200801111153.m0BBr4Ho032590@repoman.freebsd.org> kib 2008-01-11 11:53:04 UTC FreeBSD src repository Modified files: sys/dev/fdc fdc.c Log: Fix unload of the fdc.ko: Wakeup the thread doing the fdc_detach() when the fdc worker thread exits [1]. Write access to the write-protected floppy shall call device_unbusy() to pair the device_busy() in the fd_access() [2]. PR: 116537 [1], 116539 [2] MFC after: 1 week Revision Changes Path 1.319 +8 -1 src/sys/dev/fdc/fdc.c From rwatson at FreeBSD.org Fri Jan 11 03:59:05 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Fri Jan 11 03:59:12 2008 Subject: cvs commit: src/sys/nfsclient nfs_socket.c In-Reply-To: <20080111023628.GB99258@elvis.mu.org> References: <200801102336.m0ANa0mP035046@repoman.freebsd.org> <20080111010033.GC52842@elvis.mu.org> <20080111023628.GB99258@elvis.mu.org> Message-ID: <20080111115353.G63715@fledge.watson.org> On Thu, 10 Jan 2008, Alfred Perlstein wrote: >>>> Pass curthread to various socket routines (socreate(), sobind(), and >>>> soconnect()) instead of &thread0 when establishing a connection to the NFS >>>> server. Otherwise inconsistent credentials may be used when setting up >>>> the NFS socket. >>> >>> I'm not sure, but I think this may be a regression, I seem to recall that >>> a long time ago it was switched to &thread0 because otherwise certain >>> operations can fail due to curthread not running as root. >> >> That's my recollection too. For example, when nfs is configured to bind to >> a priviliged local port for making queries or connections, it had to be >> done as root. With tcp mounts, the connection can be dropped and a >> reconnect required at any time. > > This could be implemented by a handoff to a thread that does the appropriate > setuid call beforehand, or perhaps the credential inconsistencies can be > further expained or fixed. The real bug is that sobind() and soconnect() take threads as arguments, and should either take just credentials or credentials and threads depending on whether they really want a thread as well. I started fixing this a few years ago but it requires touching a lot of stuff (like protosw) so is pretty disruptive. Basically, because they accept a thread as an argument, you can't use the cached mount-time credential to authorize these further socket operations. You don't want to used the cached socket()-time credential, another obvious choice, as you want to be able to have the root user bind()/connect() a socket and then hand it off to unprivileged processes to use without being able to rebind/connect with privilege. Possibly the above change should be modified to use curthread for UDP and thread0 for TCP, as TCP can be reconnected but may not have the bind problem John is running into, whereas UDP won't be reconnected? Robert N M Watson Computer Laboratory University of Cambridge From jhb at FreeBSD.org Fri Jan 11 05:41:32 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Fri Jan 11 05:41:35 2008 Subject: cvs commit: src ObsoleteFiles.inc Message-ID: <200801111341.m0BDfV4A063978@repoman.freebsd.org> jhb 2008-01-11 13:41:31 UTC FreeBSD src repository Modified files: . ObsoleteFiles.inc Log: Add entries for manpages for pmc_x86_get_msr(3), kthread_create(9), shm_open(3), and shm_unlink(3). Revision Changes Path 1.125 +7 -0 src/ObsoleteFiles.inc From bde at FreeBSD.org Fri Jan 11 06:11:47 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Fri Jan 11 06:11:48 2008 Subject: cvs commit: src/sys/amd64/include ieeefp.h Message-ID: <200801111411.m0BEBkQb070424@repoman.freebsd.org> bde 2008-01-11 14:11:46 UTC FreeBSD src repository Modified files: sys/amd64/include ieeefp.h Log: Fix some style bugs: - fix a previous style fix: shifts should be in the correct direction even if they are null. - restore a comment about namespace pollution from floatingpoint.h 1.12 and update it. - remove unused namespace pollution FP_*REG. - improve some comments. - sort macro definitions for entry points. - don't use underscores for macro args. Revision Changes Path 1.18 +25 -24 src/sys/amd64/include/ieeefp.h From jhb at FreeBSD.org Fri Jan 11 06:26:09 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Fri Jan 11 06:26:15 2008 Subject: cvs commit: src/sys/dev/fdc fdc.c In-Reply-To: <200801111153.m0BBr4Ho032590@repoman.freebsd.org> References: <200801111153.m0BBr4Ho032590@repoman.freebsd.org> Message-ID: <59750.192.168.0.18.1200061563.squirrel@mail.baldwin.cx> On Fri, January 11, 2008 6:53 am, Konstantin Belousov wrote: > kib 2008-01-11 11:53:04 UTC > > FreeBSD src repository > > Modified files: > sys/dev/fdc fdc.c > Log: > Fix unload of the fdc.ko: > > Wakeup the thread doing the fdc_detach() when the fdc worker thread > exits [1]. > Write access to the write-protected floppy shall call device_unbusy() to > pair the device_busy() in the fd_access() [2]. > > PR: 116537 [1], 116539 [2] > MFC after: 1 week > > Revision Changes Path > 1.319 +8 -1 src/sys/dev/fdc/fdc.c [1] is wrong and reintroduces a panic race on module unload. The wakeup() is internal to kproc_exit/kthread_exit. The correct fix is to fix the msleep() in detach to sleep on fdc->fdc_thread instead of &fdc->fdc_thread. -- John Baldwin From attilio at FreeBSD.org Fri Jan 11 08:38:14 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Fri Jan 11 08:38:18 2008 Subject: cvs commit: src/sys/kern kern_lock.c Message-ID: <200801111638.m0BGcDTD096865@repoman.freebsd.org> attilio 2008-01-11 16:38:13 UTC FreeBSD src repository Modified files: sys/kern kern_lock.c Log: lockmgr() function will return successfully when trying to work under panic but it won't actually lock anything. This can lead some paths to reach lockmgr_disown() with inconsistent lock which will let trigger the relative assertions. Fix those in order to recognize panic situation and to not trigger. Reported by: pho Submitted by: kib Revision Changes Path 1.119 +6 -3 src/sys/kern/kern_lock.c From kib at FreeBSD.org Fri Jan 11 08:50:55 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Fri Jan 11 08:50:55 2008 Subject: cvs commit: src/sys/dev/fdc fdc.c Message-ID: <200801111650.m0BGorhh009597@repoman.freebsd.org> kib 2008-01-11 16:50:53 UTC FreeBSD src repository Modified files: sys/dev/fdc fdc.c Log: The wakeup() line from the rev. 1.319 is wrong and reintroduces a panic race on module unload. The wakeup() is internal to kproc_exit/kthread_exit. The correct fix is to fix the msleep() in detach to sleep on fdc->fdc_thread instead of &fdc->fdc_thread. Noted and reviewed by: jhb Pointy hat to: kib MFC after: 1 week Revision Changes Path 1.320 +1 -2 src/sys/dev/fdc/fdc.c From jhb at freebsd.org Fri Jan 11 08:55:09 2008 From: jhb at freebsd.org (John Baldwin) Date: Fri Jan 11 08:55:14 2008 Subject: cvs commit: src/sys/nfsclient nfs_socket.c In-Reply-To: <20080111023628.GB99258@elvis.mu.org> References: <200801102336.m0ANa0mP035046@repoman.freebsd.org> <20080111023628.GB99258@elvis.mu.org> Message-ID: <200801111154.45554.jhb@freebsd.org> On Thursday 10 January 2008 09:36:28 pm Alfred Perlstein wrote: > * Peter Wemm [080110 17:39] wrote: > > On Jan 10, 2008 5:00 PM, Alfred Perlstein wrote: > > > > > > * John Baldwin [080110 15:33] wrote: > > > > jhb 2008-01-10 23:36:00 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/nfsclient nfs_socket.c > > > > Log: > > > > Pass curthread to various socket routines (socreate(), sobind(), and > > > > soconnect()) instead of &thread0 when establishing a connection to the NFS > > > > server. Otherwise inconsistent credentials may be used when setting up > > > > the NFS socket. > > > > > > I'm not sure, but I think this may be a regression, I seem to recall > > > that a long time ago it was switched to &thread0 because otherwise > > > certain operations can fail due to curthread not running as root. > > > > That's my recollection too. For example, when nfs is configured to > > bind to a priviliged local port for making queries or connections, it > > had to be done as root. With tcp mounts, the connection can be > > dropped and a reconnect required at any time. > > This could be implemented by a handoff to a thread that does the > appropriate setuid call beforehand, or perhaps the credential > inconsistencies can be further expained or fixed. The problem case I have is doing a mount inside of a jail. The socket's credential is jailed but thread0's credential is not, and you end up with odd behavior where sobind() treats the socket as non-jailed (and thus only binds the local port and not the local IP address) but soconnect() treats the socket as jailed and fails with EINVAL when it sees a partially bound socket. (sobind() of a jailed socket sets both the port and IP.) What I can do as a workaround is to change curthread's ucred to be the NFS mount's credential during nfs_connect() by fiddling with td_ucred. It would be safe as it wouldn't affect other threads even in the same process and the current thread isn't going to be doing anything else until the function returns with the restored credentials, just hackish. -- John Baldwin From bde at FreeBSD.org Fri Jan 11 09:11:32 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Fri Jan 11 09:11:34 2008 Subject: cvs commit: src/sys/amd64/include ieeefp.h Message-ID: <200801111711.m0BHBWxv014282@repoman.freebsd.org> bde 2008-01-11 17:11:32 UTC FreeBSD src repository Modified files: sys/amd64/include ieeefp.h Log: Fix fpset*() to not trap if there is a currently unmasked exception. Unmasked exceptions (which can be fixed up using fpset*() before they trap) are very rare, especially on amd64 since SSE exceptions trap synchronously, but I want to merge the faster amd64 implementations of fpset*() back to i386 without introducing the bug on i386. The i386 implementation has always avoided the trap automatically by changing things using load/store of the FP environment, but this is very slow. Most changes only affect the control word, so they can usually be done much more efficiently, and amd64 has always done this, but loading the control word can trap. This version use the fast method only in the usual case where it will not trap. This only costs a couple of integer instructions (including one branch which I haven't optimized carefully yet) in the usual case, but bloats the inlines a lot. The inlines were already a bit too large to handle both the FPU and SSE. Revision Changes Path 1.19 +42 -12 src/sys/amd64/include/ieeefp.h From jhb at freebsd.org Fri Jan 11 09:13:09 2008 From: jhb at freebsd.org (John Baldwin) Date: Fri Jan 11 09:13:16 2008 Subject: cvs commit: src/sys/dev/fdc fdc.c In-Reply-To: <200801111650.m0BGorhh009597@repoman.freebsd.org> References: <200801111650.m0BGorhh009597@repoman.freebsd.org> Message-ID: <200801111212.40473.jhb@freebsd.org> On Friday 11 January 2008 11:50:53 am Konstantin Belousov wrote: > kib 2008-01-11 16:50:53 UTC > > FreeBSD src repository > > Modified files: > sys/dev/fdc fdc.c > Log: > The wakeup() line from the rev. 1.319 is wrong and reintroduces > a panic race on module unload. The wakeup() is internal to > kproc_exit/kthread_exit. The correct fix is to fix the msleep() in > detach to sleep on fdc->fdc_thread instead of &fdc->fdc_thread. > > Noted and reviewed by: jhb > Pointy hat to: kib > MFC after: 1 week Original pointy hat to: jhb As I missed updating the msleep() when I fixed the unload race the first time around which lead to the hang seen in the original PR. -- John Baldwin From bde at FreeBSD.org Fri Jan 11 09:54:20 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Fri Jan 11 09:54:24 2008 Subject: cvs commit: src/sys/i386/include ieeefp.h Message-ID: <200801111754.m0BHsKg3020550@repoman.freebsd.org> bde 2008-01-11 17:54:20 UTC FreeBSD src repository Modified files: sys/i386/include ieeefp.h Log: MFamd64 1.15-1.18 (cosmetic changes, mainly to comments). The inline functions haven't been cleaned up here because the amd64 cleanups don't apply directly and the functions here will be merged or rewritten later. Revision Changes Path 1.12 +25 -15 src/sys/i386/include/ieeefp.h From bde at FreeBSD.org Fri Jan 11 10:27:02 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Fri Jan 11 10:27:04 2008 Subject: cvs commit: src/sys/i386/include ieeefp.h Message-ID: <200801111827.m0BIR2bt026340@repoman.freebsd.org> bde 2008-01-11 18:27:01 UTC FreeBSD src repository Modified files: sys/i386/include ieeefp.h Log: Separate fpresetsticky() from the other fpset functions so that the others can be replaced cleanly by the amd64 versions. There is no current amd64 version to merge, but there is an old one which is similar. Fix the following bugs in fpresetsticky(): - garbage args clobbered non-sticky bits in the status register - the return value was usually garbage since it was masked with the arg instead of with the field selector. Optimize fpresetsticky() to avoid using the environment as in feclearexcept() (use only fnclex() if possible) and also to avoid using fnclex() for null changes. The second of these optimizations might not be so good since its branch might cost more than it saves. Revision Changes Path 1.13 +27 -4 src/sys/i386/include/ieeefp.h From bde at FreeBSD.org Fri Jan 11 10:59:35 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Fri Jan 11 10:59:39 2008 Subject: cvs commit: src/sys/i386/include ieeefp.h Message-ID: <200801111859.m0BIxZqu035686@repoman.freebsd.org> bde 2008-01-11 18:59:35 UTC FreeBSD src repository Modified files: sys/i386/include ieeefp.h Log: MFamd64 (everything possible up to 1.19; mainly the amd64 implementations of fpget*() and fpset*()). The i386 fpget*() were efficient but a bit obfuscated (using macros and a case statement to demultiplex them through a single inline). The demultiplexing mainly gave smaller source code. The i386 fpset*() were obfuscated in the same way and were very inefficient due to the case statement not having enough cases or complexity so all cases used the FP environment. This also fixes a harmless bug in rev.1.12. fpsetmask() extracted the old value from the bit-field twice, but the doubled shift was harmless since the shift count is 0. All fp*() interfaces are now inline functions on i386. They used to be macros that call (a different set of) inline functions. This is a small ABI change which shouldn't cause problems since cases where inlining fails (mainly -O0) only give (working) static functions. Revision Changes Path 1.14 +103 -61 src/sys/i386/include/ieeefp.h From attilio at FreeBSD.org Fri Jan 11 11:56:18 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Fri Jan 11 11:56:20 2008 Subject: cvs commit: src/sys/fs/hpfs hpfs_vfsops.c Message-ID: <200801111956.m0BJuHx7055524@repoman.freebsd.org> attilio 2008-01-11 19:56:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/fs/hpfs hpfs_vfsops.c Log: MFC rev. 1.62: g_vfs_close wants the sx topology lock held while executing, so add correct locking for mounting operation. Approved by: re Revision Changes Path 1.60.2.1 +8 -0 src/sys/fs/hpfs/hpfs_vfsops.c From dougb at FreeBSD.org Fri Jan 11 14:41:22 2008 From: dougb at FreeBSD.org (Doug Barton) Date: Fri Jan 11 14:41:24 2008 Subject: cvs commit: src/etc/namedb named.conf Message-ID: <200801112241.m0BMfMY8022312@repoman.freebsd.org> dougb 2008-01-11 22:41:21 UTC FreeBSD src repository Modified files: etc/namedb named.conf Log: Remove from the default empty zone list zones that, unlike the others, could theoretically be allocated one day. Revision Changes Path 1.27 +0 -8 src/etc/namedb/named.conf From jhb at freebsd.org Fri Jan 11 15:33:10 2008 From: jhb at freebsd.org (John Baldwin) Date: Fri Jan 11 15:33:14 2008 Subject: cvs commit: src/sys/nfsclient nfs_socket.c In-Reply-To: <200801111154.45554.jhb@freebsd.org> References: <200801102336.m0ANa0mP035046@repoman.freebsd.org> <20080111023628.GB99258@elvis.mu.org> <200801111154.45554.jhb@freebsd.org> Message-ID: <200801111832.58893.jhb@freebsd.org> On Friday 11 January 2008 11:54:44 am John Baldwin wrote: > On Thursday 10 January 2008 09:36:28 pm Alfred Perlstein wrote: > > * Peter Wemm [080110 17:39] wrote: > > > On Jan 10, 2008 5:00 PM, Alfred Perlstein wrote: > > > > > > > > * John Baldwin [080110 15:33] wrote: > > > > > jhb 2008-01-10 23:36:00 UTC > > > > > > > > > > FreeBSD src repository > > > > > > > > > > Modified files: > > > > > sys/nfsclient nfs_socket.c > > > > > Log: > > > > > Pass curthread to various socket routines (socreate(), sobind(), and > > > > > soconnect()) instead of &thread0 when establishing a connection to the NFS > > > > > server. Otherwise inconsistent credentials may be used when setting up > > > > > the NFS socket. > > > > > > > > I'm not sure, but I think this may be a regression, I seem to recall > > > > that a long time ago it was switched to &thread0 because otherwise > > > > certain operations can fail due to curthread not running as root. > > > > > > That's my recollection too. For example, when nfs is configured to > > > bind to a priviliged local port for making queries or connections, it > > > had to be done as root. With tcp mounts, the connection can be > > > dropped and a reconnect required at any time. > > > > This could be implemented by a handoff to a thread that does the > > appropriate setuid call beforehand, or perhaps the credential > > inconsistencies can be further expained or fixed. > > The problem case I have is doing a mount inside of a jail. The socket's > credential is jailed but thread0's credential is not, and you end up with > odd behavior where sobind() treats the socket as non-jailed (and thus only > binds the local port and not the local IP address) but soconnect() treats > the socket as jailed and fails with EINVAL when it sees a partially bound > socket. (sobind() of a jailed socket sets both the port and IP.) What I > can do as a workaround is to change curthread's ucred to be the NFS mount's > credential during nfs_connect() by fiddling with td_ucred. It would be > safe as it wouldn't affect other threads even in the same process and the > current thread isn't going to be doing anything else until the function > returns with the restored credentials, just hackish. I have a patch to do this and it works both inside and out of jails for both UDP and TCP mounts. I used tcpdrop on the server in each case to force the client to reconnect on a different socket and that worked ok while doing a ls -l as a mere mortal. I also verified that this test case (dropping the existing TCP connection) caused the ls process to hang in "nfscon" with the change I committed yesterday. This is relative to what is in HEAD now: Index: nfs_socket.c =================================================================== RCS file: /host/cvs/usr/cvs/src/sys/nfsclient/nfs_socket.c,v retrieving revision 1.156 diff -u -r1.156 nfs_socket.c --- nfs_socket.c 10 Jan 2008 23:36:00 -0000 1.156 +++ nfs_socket.c 11 Jan 2008 17:20:30 -0000 @@ -264,7 +264,19 @@ int error, rcvreserve, sndreserve; int pktscale; struct sockaddr *saddr; - struct thread *td = curthread; /* only used for socreate and sobind */ + struct ucred *origcred; + struct thread *td = curthread; + + /* + * We need to establish the socket using the credentials of + * the mountpoint. Some parts of this process (such as + * sobind() and soconnect()) will use the curent thread's + * credential instead of the socket credential. To work + * around this, temporarily change the current thread's + * credential to that of the mountpoint. + */ + origcred = td->td_ucred; + td->td_ucred = nmp->nm_mountp->mnt_cred; if (nmp->nm_sotype == SOCK_STREAM) { mtx_lock(&nmp->nm_mtx); @@ -453,6 +465,9 @@ so->so_snd.sb_flags |= SB_NOINTR; SOCKBUF_UNLOCK(&so->so_snd); + /* Restore current thread's credentials. */ + td->td_ucred = origcred; + mtx_lock(&nmp->nm_mtx); /* Initialize other non-zero congestion variables */ nfs_init_rtt(nmp); @@ -463,6 +478,9 @@ return (0); bad: + /* Restore current thread's credentials. */ + td->td_ucred = origcred; + nfs_disconnect(nmp); return (error); } -- John Baldwin From jhb at FreeBSD.org Fri Jan 11 15:57:40 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Fri Jan 11 15:57:42 2008 Subject: cvs commit: src/sys/nfsclient nfs_socket.c Message-ID: <200801112357.m0BNve3Z034649@repoman.freebsd.org> jhb 2008-01-11 23:57:40 UTC FreeBSD src repository Modified files: sys/nfsclient nfs_socket.c Log: The previous revision broke the case of reconnecting to a TCP NFS server via a new socket during an NFS operation as that reconnect takes place in the context of an arbitrary thread with an arbitrary credential. Ideally we would like to use the mount point's credential for the entire process of setting up the socket to connect to the NFS server. Since some of the APIs (sobind(), etc.) only take a thread pointer and infer the credential from that instead of a direct credential, work around the problem by temporarily changing the current thread's credential to that of the mount point while connecting the socket and then reverting back to the original credential when we are done. Reviewed by: rwatson Tested on: UDP, TCP, TCP with forced reconnect Revision Changes Path 1.157 +22 -1 src/sys/nfsclient/nfs_socket.c From jhb at FreeBSD.org Fri Jan 11 16:07:04 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Fri Jan 11 16:07:08 2008 Subject: cvs commit: src/usr.bin/kdump kdump.c Message-ID: <200801120007.m0C074qH037307@repoman.freebsd.org> jhb 2008-01-12 00:07:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.bin/kdump kdump.c Log: MFC: Only use sockoptname() to parse socket option names for SOL_SOCKET requests. Approved by: re (gnn) Revision Changes Path 1.37.2.2 +6 -4 src/usr.bin/kdump/kdump.c From jhb at FreeBSD.org Fri Jan 11 16:07:50 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Fri Jan 11 16:07:54 2008 Subject: cvs commit: src/usr.bin/kdump kdump.c Message-ID: <200801120007.m0C07ov6037407@repoman.freebsd.org> jhb 2008-01-12 00:07:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) usr.bin/kdump kdump.c Log: MFC: Only use sockoptname() to parse socket option names for SOL_SOCKET requests. Approved by: re (gnn) Revision Changes Path 1.37.2.1.2.1 +6 -4 src/usr.bin/kdump/kdump.c From delphij at FreeBSD.org Fri Jan 11 16:11:26 2008 From: delphij at FreeBSD.org (Xin LI) Date: Fri Jan 11 16:11:30 2008 Subject: cvs commit: src/usr.bin/systat ifstat.c Message-ID: <200801120011.m0C0BQht038237@repoman.freebsd.org> delphij 2008-01-12 00:11:26 UTC FreeBSD src repository Modified files: usr.bin/systat ifstat.c Log: - Handle the case where interface from "middle" is missing by more carefully inspecting the return value from sysctl(3). [1] - Use calloc instead of malloc+memset of zero. Submitted by: Alexander Chernikov [1] PR: bin/119581 MFC after: 2 weeks Revision Changes Path 1.7 +4 -4 src/usr.bin/systat/ifstat.c From jhb at FreeBSD.org Fri Jan 11 16:13:07 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Fri Jan 11 16:13:14 2008 Subject: cvs commit: src/sys/fs/devfs devfs_vnops.c Message-ID: <200801120013.m0C0D7CF038738@repoman.freebsd.org> jhb 2008-01-12 00:13:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/fs/devfs devfs_vnops.c Log: MFC: Lock the vnode interlock while reading v_usecount to update si_usecount in a cdev in devfs_reclaim(). Approved by: re (gnn) Revision Changes Path 1.149.2.1 +3 -0 src/sys/fs/devfs/devfs_vnops.c From jhb at FreeBSD.org Fri Jan 11 16:13:33 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Fri Jan 11 16:13:34 2008 Subject: cvs commit: src/sys/fs/devfs devfs_vnops.c Message-ID: <200801120013.m0C0DXa5038772@repoman.freebsd.org> jhb 2008-01-12 00:13:33 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/fs/devfs devfs_vnops.c Log: MFC: Lock the vnode interlock while reading v_usecount to update si_usecount in a cdev in devfs_reclaim(). Approved by: re (gnn) Revision Changes Path 1.149.4.1 +3 -0 src/sys/fs/devfs/devfs_vnops.c From jhb at FreeBSD.org Fri Jan 11 16:17:51 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Fri Jan 11 16:17:54 2008 Subject: cvs commit: src/sys/fs/devfs devfs_vnops.c Message-ID: <200801120017.m0C0HoQD039089@repoman.freebsd.org> jhb 2008-01-12 00:17:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/fs/devfs devfs_vnops.c Log: MFC: Lock the vnode interlock while reading v_usecount to update si_usecount in a cdev in devfs_reclaim(). Revision Changes Path 1.114.2.16 +3 -0 src/sys/fs/devfs/devfs_vnops.c From jhb at FreeBSD.org Fri Jan 11 16:19:33 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Fri Jan 11 16:19:36 2008 Subject: cvs commit: src/sys/kern tty.c Message-ID: <200801120019.m0C0JX2b039148@repoman.freebsd.org> jhb 2008-01-12 00:19:33 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern tty.c Log: MFC: Close a race in the kern.ttys sysctl handler that resulted in panics in dev2udev(). Approved by: re (gnn) Revision Changes Path 1.273.2.1 +20 -3 src/sys/kern/tty.c From jhb at FreeBSD.org Fri Jan 11 16:20:06 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Fri Jan 11 16:20:10 2008 Subject: cvs commit: src/sys/kern tty.c Message-ID: <200801120020.m0C0K6qN039248@repoman.freebsd.org> jhb 2008-01-12 00:20:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/kern tty.c Log: MFC: Close a race in the kern.ttys sysctl handler that resulted in panics in dev2udev(). Approved by: re (gnn) Revision Changes Path 1.273.4.1 +20 -3 src/sys/kern/tty.c From delphij at FreeBSD.org Fri Jan 11 16:54:48 2008 From: delphij at FreeBSD.org (Xin LI) Date: Fri Jan 11 16:54:51 2008 Subject: cvs commit: src/lib/libkvm kvm.c Message-ID: <200801120054.m0C0sl1l053849@repoman.freebsd.org> delphij 2008-01-12 00:54:47 UTC FreeBSD src repository Modified files: lib/libkvm kvm.c Log: Plug memory leaks that is observed when argbuf or argspc is used in the context. Submitted by: Michal Vranek PR: bin/118380 MFC after: 1 month Revision Changes Path 1.32 +4 -0 src/lib/libkvm/kvm.c From peter at wemm.org Fri Jan 11 16:59:32 2008 From: peter at wemm.org (Peter Wemm) Date: Fri Jan 11 16:59:37 2008 Subject: cvs commit: src/sys/kern tty.c In-Reply-To: <200801120020.m0C0K6qN039248@repoman.freebsd.org> References: <200801120020.m0C0K6qN039248@repoman.freebsd.org> Message-ID: On Jan 11, 2008 4:20 PM, John Baldwin wrote: > jhb 2008-01-12 00:20:06 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_7_0) > sys/kern tty.c > Log: > MFC: Close a race in the kern.ttys sysctl handler that resulted in panics > in dev2udev(). I think this fixes a (previously reported) panic caused by removing a usb tty device while a pending kqueue event is actively listening on it. At least, your change conflicted with my change to fix the kevent panic. I'll test and see if your version solves my problem as well. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From mux at FreeBSD.org Fri Jan 11 17:30:20 2008 From: mux at FreeBSD.org (Maxime Henrion) Date: Fri Jan 11 17:30:25 2008 Subject: cvs commit: src/sys/net route.c route.h In-Reply-To: <200801091554.m09FsnUC049542@lava.sentex.ca> References: <200801091538.m09Fcn0w050430@repoman.freebsd.org> <200801091554.m09FsnUC049542@lava.sentex.ca> Message-ID: <20080112011035.GA5752@elvis.mu.org> Mike Tancsa wrote: > At 10:38 AM 1/9/2008, Maxime Henrion wrote: > >mux 2008-01-09 15:38:49 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_6) > > sys/net route.c route.h > > Log: > > MFC route.c@1.125 and route.h@1.68: > > Add a workaround for a deadlock between the rt_setgate() and rt_check() > > functions. It is easily triggered by running routed, and, I expect, by > > running any other daemon that uses routing sockets. > > Hi, > I have a number of boxes running full bgp tables with > Quagga. How does the deadlock manifest itself ? I havent seen the > boxes lockup ? Or does the deadlock create other symptoms ? > > ---Mike > It resulted in a hard lockup for us, but it's possible there are other different outcomes in different scenarios. For details on the specific deadlock I have observed, see thread 'Deadlock in the routing code' on freebsd-net@. Cheers, Maxime From kostikbel at gmail.com Fri Jan 11 22:17:56 2008 From: kostikbel at gmail.com (Kostik Belousov) Date: Fri Jan 11 22:18:00 2008 Subject: cvs commit: src/sys/fs/hpfs hpfs_vfsops.c In-Reply-To: <200801111956.m0BJuHx7055524@repoman.freebsd.org> References: <200801111956.m0BJuHx7055524@repoman.freebsd.org> Message-ID: <20080112054828.GR57756@deviant.kiev.zoral.com.ua> On Fri, Jan 11, 2008 at 07:56:17PM +0000, Attilio Rao wrote: > attilio 2008-01-11 19:56:17 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_7) > sys/fs/hpfs hpfs_vfsops.c > Log: > MFC rev. 1.62: > g_vfs_close wants the sx topology lock held while executing, so add > correct locking for mounting operation. > > Approved by: re > > Revision Changes Path > 1.60.2.1 +8 -0 src/sys/fs/hpfs/hpfs_vfsops.c Would it make sense to remove the hpfs from the tree ? -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080112/8845ed58/attachment.pgp From maxim at FreeBSD.org Sat Jan 12 11:02:12 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 12 11:02:16 2008 Subject: cvs commit: src/etc rc.firewall rc.firewall6 Message-ID: <200801121902.m0CJ2Clp090710@repoman.freebsd.org> maxim 2008-01-12 19:02:11 UTC FreeBSD src repository Modified files: etc rc.firewall rc.firewall6 Log: o Correct an info about "Firewalls and Internet Security" book: name, authors list, ISBN, URLs. PR: conf/119590 MFC after: 1 week Revision Changes Path 1.53 +6 -7 src/etc/rc.firewall 1.18 +7 -8 src/etc/rc.firewall6 From maxim at FreeBSD.org Sat Jan 12 11:14:31 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 12 11:14:32 2008 Subject: cvs commit: src/sys/dev/puc pucdata.c Message-ID: <200801121914.m0CJEUiA093935@repoman.freebsd.org> maxim 2008-01-12 19:14:30 UTC FreeBSD src repository Modified files: sys/dev/puc pucdata.c Log: o Add Moxa Technologies CP-104EL PCI Express 4 port Serial card. PR: kern/119515 Submitted by: Gavin Stone-Tolcher MFC after: 1 month Revision Changes Path 1.60 +6 -0 src/sys/dev/puc/pucdata.c From maxim at FreeBSD.org Sat Jan 12 11:24:55 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 12 11:24:59 2008 Subject: cvs commit: src/sys/cam/scsi scsi_da.c Message-ID: <200801121924.m0CJOtmj095686@repoman.freebsd.org> maxim 2008-01-12 19:24:55 UTC FreeBSD src repository Modified files: sys/cam/scsi scsi_da.c Log: o Correct EasyMP3 EM732X usb 2.0 flash mp3 player revision: it's 1.00 not 1.0. PR: usb/96546 Submitted by: Eugene Grosbein MFC after: 1 month Revision Changes Path 1.226 +1 -1 src/sys/cam/scsi/scsi_da.c From maxim at FreeBSD.org Sat Jan 12 11:37:18 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 12 11:37:21 2008 Subject: cvs commit: src/share/man/man9 mbuf_tags.9 Message-ID: <200801121937.m0CJbIb3097695@repoman.freebsd.org> maxim 2008-01-12 19:37:18 UTC FreeBSD src repository Modified files: share/man/man9 mbuf_tags.9 Log: o Do not claim vlan(4) uses mbuf_tags(9). PR: docs/11959 Submitted by: Alexander Chernikov MFC after: 1 week Revision Changes Path 1.8 +3 -4 src/share/man/man9/mbuf_tags.9 From maxim at FreeBSD.org Sat Jan 12 12:00:26 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 12 12:00:30 2008 Subject: cvs commit: src/sbin/setkey parse.y Message-ID: <200801122000.m0CK0PlH002072@repoman.freebsd.org> maxim 2008-01-12 20:00:24 UTC FreeBSD src repository Modified files: sbin/setkey parse.y Log: o Allow setkey(8) to recognize esp as a protocoal name for spdadd. PR: bin/107392 Submitted by: Eugene Grosbein MFC after: 1 month Revision Changes Path 1.11 +1 -0 src/sbin/setkey/parse.y From kmacy at FreeBSD.org Sat Jan 12 12:34:57 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sat Jan 12 12:35:00 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_multiq.c Message-ID: <200801122034.m0CKYuSX009114@repoman.freebsd.org> kmacy 2008-01-12 20:34:56 UTC FreeBSD src repository Added files: sys/dev/cxgb cxgb_multiq.c Log: MFp4 multiple queue support Revision Changes Path 1.1 +698 -0 src/sys/dev/cxgb/cxgb_multiq.c (new) From maxim at FreeBSD.org Sat Jan 12 12:37:07 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 12 12:37:08 2008 Subject: cvs commit: src/usr.sbin/iostat iostat.c Message-ID: <200801122037.m0CKb6CS009262@repoman.freebsd.org> maxim 2008-01-12 20:37:06 UTC FreeBSD src repository Modified files: usr.sbin/iostat iostat.c Log: o Plug a memory leak: do not forget to free asprintf(3) allocated memory. PR: bin/119608 Submitted by: peter.schuller MFC after: 1 week Revision Changes Path 1.38 +4 -2 src/usr.sbin/iostat/iostat.c From maxim at FreeBSD.org Sat Jan 12 12:52:31 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 12 12:52:33 2008 Subject: cvs commit: src/etc/defaults rc.conf src/share/man/man5 rc.conf.5 Message-ID: <200801122052.m0CKqVrQ020802@repoman.freebsd.org> maxim 2008-01-12 20:52:30 UTC FreeBSD src repository Modified files: etc/defaults rc.conf share/man/man5 rc.conf.5 Log: o From the Problem Report: the TCP_DROP_SYNFIN kernel option is now included in the kernel by default. Remove reference to this option from defaults/rc.conf and rc.conf(5). PR: conf/119098 Submitted by: Beat Gaetzi MFC after: 1 week Revision Changes Path 1.322 +0 -2 src/etc/defaults/rc.conf 1.332 +1 -5 src/share/man/man5/rc.conf.5 From das at FreeBSD.ORG Sat Jan 12 12:52:57 2008 From: das at FreeBSD.ORG (David Schultz) Date: Sat Jan 12 12:53:03 2008 Subject: cvs commit: src/usr.sbin/iostat iostat.c In-Reply-To: <200801122037.m0CKb6CS009262@repoman.freebsd.org> References: <200801122037.m0CKb6CS009262@repoman.freebsd.org> Message-ID: <20080112205254.GB3090@VARK.MIT.EDU> On Sat, Jan 12, 2008, Maxim Konovalov wrote: > - asprintf(&devname, "%s%d", > + if (asprintf(&devname, "%s%d", > cur.dinfo->devices[di].device_name, > - cur.dinfo->devices[di].unit_number); > + cur.dinfo->devices[di].unit_number) == 1) > + errx(1, "asprintf() failed (out of memory?)"); err(1, "asprintf") will produce a more meaningful error message, by the way. Also, I think you wanted to compare the return value of asprintf to -1 instead of 1. From maxim at FreeBSD.org Sat Jan 12 12:57:20 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 12 12:57:24 2008 Subject: cvs commit: src/usr.sbin/iostat iostat.c Message-ID: <200801122057.m0CKvJv5021382@repoman.freebsd.org> maxim 2008-01-12 20:57:19 UTC FreeBSD src repository Modified files: usr.sbin/iostat iostat.c Log: o Fix a typo. errx() -> err(). Submitted by: das Revision Changes Path 1.39 +2 -2 src/usr.sbin/iostat/iostat.c From maxim at FreeBSD.org Sat Jan 12 13:07:05 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 12 13:07:07 2008 Subject: cvs commit: src/share/man/man9 mbuf_tags.9 Message-ID: <200801122107.m0CL73Bw024036@repoman.freebsd.org> maxim 2008-01-12 21:07:03 UTC FreeBSD src repository Modified files: share/man/man9 mbuf_tags.9 Log: o .Dd.year++. Revision Changes Path 1.9 +1 -1 src/share/man/man9/mbuf_tags.9 From maxim at FreeBSD.org Sat Jan 12 13:09:49 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 12 13:09:53 2008 Subject: cvs commit: src/usr.sbin/inetd inetd.8 Message-ID: <200801122109.m0CL9nV9024131@repoman.freebsd.org> maxim 2008-01-12 21:09:48 UTC FreeBSD src repository Modified files: usr.sbin/inetd inetd.8 Log: o inetd(8) requires wait/nowait column in inetd.conf for ONC services as well. PR: bin/119203 Submitted by: Peter Jeremy MFC atfer: 1 week Revision Changes Path 1.85 +2 -1 src/usr.sbin/inetd/inetd.8 From cognet at FreeBSD.org Sat Jan 12 13:11:44 2008 From: cognet at FreeBSD.org (Olivier Houchard) Date: Sat Jan 12 13:11:48 2008 Subject: cvs commit: src/sys/arm/arm support.S Message-ID: <200801122111.m0CLBhMu025001@repoman.freebsd.org> cognet 2008-01-12 21:11:43 UTC FreeBSD src repository Modified files: sys/arm/arm support.S Log: Back when I committed the arm port, I've been asked to move memcpy/memset/memcmp and friends from libkern/arm to arm/arm/support.S, and so I did, but in the process, I didn't add the appropriate copyrights. This is a major oversight from me, and I apology to the NetBSD people for it. MFC After: 1 day Revision Changes Path 1.14 +69 -0 src/sys/arm/arm/support.S From das at FreeBSD.ORG Sat Jan 12 13:19:23 2008 From: das at FreeBSD.ORG (David Schultz) Date: Sat Jan 12 13:19:29 2008 Subject: cvs commit: src/usr.sbin/iostat iostat.c In-Reply-To: <20080112235350.C10888@mp2.macomnet.net> References: <200801122037.m0CKb6CS009262@repoman.freebsd.org> <20080112205254.GB3090@VARK.MIT.EDU> <20080112235350.C10888@mp2.macomnet.net> Message-ID: <20080112211919.GA3408@VARK.MIT.EDU> On Sat, Jan 12, 2008, Maxim Konovalov wrote: > On Sat, 12 Jan 2008, 15:52-0500, David Schultz wrote: > > > On Sat, Jan 12, 2008, Maxim Konovalov wrote: > > > - asprintf(&devname, "%s%d", > > > + if (asprintf(&devname, "%s%d", > > > cur.dinfo->devices[di].device_name, > > > - cur.dinfo->devices[di].unit_number); > > > + cur.dinfo->devices[di].unit_number) == 1) > > > + errx(1, "asprintf() failed (out of memory?)"); > > > > err(1, "asprintf") will produce a more meaningful error message, > > by the way. Also, I think you wanted to compare the return value > > of asprintf to -1 instead of 1. > > > err(1, "asprintf") was my first version, yes. But I failed to find in > the man page it sets errno. Thanks for the review, I'll fix the typo > shortly. I don't think it always does set errno, but you can set errno to 0 before the call, and you'll get either the real error message from err() or "unknown error". From peterjeremy at optushome.com.au Sat Jan 12 13:22:19 2008 From: peterjeremy at optushome.com.au (Peter Jeremy) Date: Sat Jan 12 13:22:28 2008 Subject: cvs commit: src/usr.sbin/inetd inetd.8 In-Reply-To: <200801122109.m0CL9nV9024131@repoman.freebsd.org> References: <200801122109.m0CL9nV9024131@repoman.freebsd.org> Message-ID: <20080112212216.GU60060@server.vk2pj.dyndns.org> On Sat, Jan 12, 2008 at 09:09:49PM +0000, Maxim Konovalov wrote: > o inetd(8) requires wait/nowait column in inetd.conf for > ONC services as well. Thanks for that, and thanks for correcting the PR - I had been discussing the max-child-per-ip field on IRC but had neglected to correct the patch. -- Peter Jeremy Please excuse any delays as the result of my ISP's inability to implement an MTA that is either RFC2821-compliant or matches their claimed behaviour. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080112/6b690669/attachment.pgp From maxim at macomnet.ru Sat Jan 12 13:26:11 2008 From: maxim at macomnet.ru (Maxim Konovalov) Date: Sat Jan 12 13:26:13 2008 Subject: cvs commit: src/usr.sbin/iostat iostat.c In-Reply-To: <20080112205254.GB3090@VARK.MIT.EDU> References: <200801122037.m0CKb6CS009262@repoman.freebsd.org> <20080112205254.GB3090@VARK.MIT.EDU> Message-ID: <20080112235350.C10888@mp2.macomnet.net> On Sat, 12 Jan 2008, 15:52-0500, David Schultz wrote: > On Sat, Jan 12, 2008, Maxim Konovalov wrote: > > - asprintf(&devname, "%s%d", > > + if (asprintf(&devname, "%s%d", > > cur.dinfo->devices[di].device_name, > > - cur.dinfo->devices[di].unit_number); > > + cur.dinfo->devices[di].unit_number) == 1) > > + errx(1, "asprintf() failed (out of memory?)"); > > err(1, "asprintf") will produce a more meaningful error message, > by the way. Also, I think you wanted to compare the return value > of asprintf to -1 instead of 1. > err(1, "asprintf") was my first version, yes. But I failed to find in the man page it sets errno. Thanks for the review, I'll fix the typo shortly. -- Maxim Konovalov From njl at FreeBSD.org Sat Jan 12 14:13:13 2008 From: njl at FreeBSD.org (Nate Lawson) Date: Sat Jan 12 14:13:16 2008 Subject: cvs commit: src/sys/dev/acpica/Osd OsdSchedule.c src/sys/contrib/dev/acpica evgpe.c Message-ID: <200801122213.m0CMDDCS035485@repoman.freebsd.org> njl 2008-01-12 22:13:12 UTC FreeBSD src repository Modified files: sys/dev/acpica/Osd OsdSchedule.c Modified files: (Branch: INTEL) sys/contrib/dev/acpica evgpe.c Log: Fix GPE livelock that occurs on HP/Compaq laptops, mostly in the thermal zone code. The GPE handler method (i.e. _L00) generates various Notify events that need to be run to completion before the GPE is re-enabled. In ACPI-CA, we queue an asynch callback at the same priority as a Notify so that it will only run after all Notify handlers have completed. The callback re-enables the GPE afterwards. We also changed the priority of Notifies to be the same as GPEs, given the possibility that another GPE could arrive before the Notifies have completed and we don't want it to get queued ahead of the rest. The ACPI-CA change was submitted by Alexey Starikovskiy (SUSE) and will appear in a later release. Special thanks to him for helping track this bug down. MFC after: 1 week Tested by: jhb, Yousif Hassan Revision Changes Path 1.1.1.13 +19 -3 src/sys/contrib/dev/acpica/evgpe.c 1.40 +7 -3 src/sys/dev/acpica/Osd/OsdSchedule.c From rwatson at FreeBSD.org Sat Jan 12 14:26:12 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Jan 12 14:26:20 2008 Subject: cvs commit: src/sys/nfsclient nfs_vnops.c In-Reply-To: <20071229061730.GY68594@egr.msu.edu> References: <200711271220.lARCKxFm040533@repoman.freebsd.org> <20071229061730.GY68594@egr.msu.edu> Message-ID: <20080112222521.L36731@fledge.watson.org> On Sat, 29 Dec 2007, Adam McDougall wrote: > Can this be merged to 6 as well? I've been running the patch ported to > 6-stable for a while with no problems. Thanks. Adam, Sorry for the delay in responding -- I'll merge this to 6-STABLE after 6.3-RELEASE is over and done with. Robert N M Watson Computer Laboratory University of Cambridge > > On Tue, Nov 27, 2007 at 12:20:59PM +0000, Robert Watson wrote: > > rwatson 2007-11-27 12:20:59 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_7) > sys/nfsclient nfs_vnops.c > Log: > Merge nfs_vnops.c:1.277 from HEAD to RELENG_7: > > Remove hacks from the NFSv2/3 client intended to handle a lack of a > server-side RPC retranmission cache for non-idempotent operations: these > hacks substituted 0 (success) for the expected EEXIST in the event that > a target name already existed for LINK, SYMLINK, and MKDIR operations, > under the assumption that EEXIST represented a second application of the > original RPC rather than a true failure. > > Background: certain NFS operations (in this case, LINK, SYMLINK, and > MKDIR) are not idempotent, as they leave behind persisting state on the > server that prevents them from being replayed without an error;if an UDP > RPC reply is lost leading to a retransmission by theclient, the second > reply will return EEXIST rather than success, asthe new object has > already been created. The NFS client previouslysilently mapped the > EEXIST return into success to paper over thisproblem. > > However, in all modern NFS server implementations, a reply cache is kept > in order to retransmit the original reply to a retransmitted request, > rather than performing the operation a second time, allowing this hack > to be avoided. This allows link()-based filelocking over NFS to operate > correctly, as an application requestingthe creation of a new link for a > file to tell if it succeededatomically or not. > > Other NFS clients, including Solaris and Linux, generally follow this > behavior for the same reasons. Most clients also now default to TCP, > which also helps avoid the issue of retransmitted but non-idempotent > requests in most cases. > > Reported by: Adam McDougall , > Timo Sirainen > Reviewed by: mohans > > Approved by: re (kensmith) > > Revision Changes Path > 1.276.2.1 +4 -25 src/sys/nfsclient/nfs_vnops.c > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > > From simon at FreeBSD.org Sat Jan 12 14:58:07 2008 From: simon at FreeBSD.org (Simon L. Nielsen) Date: Sat Jan 12 14:58:09 2008 Subject: cvs commit: src/tools/tools/nanobsd nanobsd.sh Message-ID: <200801122258.m0CMw6nk042088@repoman.freebsd.org> simon 2008-01-12 22:58:06 UTC FreeBSD src repository Modified files: tools/tools/nanobsd nanobsd.sh Log: - Add support for using swap backed md(4) devices for building the disk image. In some cases this can be a significant speed-up, if most of the image can be kept in RAM while being populated. On the 2GB image I'm currently working with, the build time, excluding buildworld/buildkernel, goes from ~17 minutes to ~6 minutes. This is not enabled by default, as it might have the opposite effect on low-memory systems. - During the generation of the image file be a bit more verbose in the log file so it is possible to see what's being done. - Add a NANO_DISKIMGDIR variable which makes it possibly to place the final images somewhere other than ${MAKEOBJDIRPREFIX}. The default value for NANO_DISKIMGDIR is $MAKEOBJDIRPREFIX. Go for it: phk Revision Changes Path 1.30 +33 -6 src/tools/tools/nanobsd/nanobsd.sh From imp at bsdimp.com Sat Jan 12 16:38:04 2008 From: imp at bsdimp.com (M. Warner Losh) Date: Sat Jan 12 16:38:11 2008 Subject: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c In-Reply-To: <20080110085803.H66908@fledge.watson.org> References: <20080109201424.GA4969@server.vk2pj.dyndns.org> <478531AC.5030303@errno.com> <20080110085803.H66908@fledge.watson.org> Message-ID: <20080112.173645.420517174.imp@bsdimp.com> In message: <20080110085803.H66908@fledge.watson.org> Robert Watson writes: : In the past, we've had several subtle bugs crop up as a result of : changing to ANSI C function prototypes, which no longer : automatically promote arguments to int from shorter types (I think : it's that way around). This caused some very subtle semantic : changes in the socket code a few years ago and was a nightmare to : track down. Unfortunately, I don't remember the details or I'd dig : up the commit that fixed it, it was really quite tricky, as what on : face value was a style change actually changed the semantics : significantly. Yes. The changes there are when the prototype was introduced. In the absence of a prototype, all things are promoted to int or long or are a pointer. The usual cause for problems is where something was promoted without sign extension before the prototype, and with sign extension after (or vice versa). This is one reason why most kernel files have prototypes at the top of them for all static functions in the file. When the prototype is encountered, it doesn't matter if the definition later in the file is done in the old style or new style: all functions in the file are treated the same. However, that's not what happened here. Syntactic sugar was removed that lead to binaries of the same md5. We need to be careful to not make too big a deal out of that... My concern with doing style sweeps now is that it may delay 7.0 getting out, or make it harder than necessary to merge things. We should strive to keep them to a minimum unless active work is going on that isn't going to be merged back into 7.0 anyway (which should be most things today). I share the concern for unreviewed changes, and there's no need to beat on that drum further. So please read this as a 'now is a good time for a reminder' rather than a complaint about this specific commit. Warner From das at FreeBSD.org Sat Jan 12 18:11:11 2008 From: das at FreeBSD.org (David Schultz) Date: Sat Jan 12 18:11:16 2008 Subject: cvs commit: src/lib/libc/stdlib heapsort.c qsort.c Message-ID: <200801130211.m0D2BBeo084882@repoman.freebsd.org> das 2008-01-13 02:11:10 UTC FreeBSD src repository Modified files: lib/libc/stdlib heapsort.c qsort.c Log: Use size_t to avoid overflow when sorting arrays larger than 2 GB. PR: 111085 MFC after: 2 weeks Revision Changes Path 1.6 +1 -1 src/lib/libc/stdlib/heapsort.c 1.14 +2 -1 src/lib/libc/stdlib/qsort.c From mcdouga9 at egr.msu.edu Sat Jan 12 18:20:26 2008 From: mcdouga9 at egr.msu.edu (Adam McDougall) Date: Sat Jan 12 18:20:34 2008 Subject: cvs commit: src/sys/nfsclient nfs_vnops.c In-Reply-To: <20080112222521.L36731@fledge.watson.org> References: <200711271220.lARCKxFm040533@repoman.freebsd.org> <20071229061730.GY68594@egr.msu.edu> <20080112222521.L36731@fledge.watson.org> Message-ID: <20080113022025.GV38562@egr.msu.edu> On Sat, Jan 12, 2008 at 10:26:10PM +0000, Robert Watson wrote: On Sat, 29 Dec 2007, Adam McDougall wrote: >> Can this be merged to 6 as well? I've been running the patch ported to >> 6-stable for a while with no problems. Thanks. Adam, Sorry for the delay in responding -- I'll merge this to 6-STABLE after 6.3-RELEASE is over and done with. Robert N M Watson Computer Laboratory University of Cambridge No problem, Thanks! From obrien at FreeBSD.org Sat Jan 12 21:49:04 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 21:49:06 2008 Subject: cvs commit: src/gnu/usr.bin Makefile Message-ID: <200801130549.m0D5n3fv082524@repoman.freebsd.org> obrien 2008-01-13 05:49:03 UTC FreeBSD src repository Modified files: gnu/usr.bin Makefile Log: Disable CVS from the build. Revision Changes Path 1.93 +3 -3 src/gnu/usr.bin/Makefile From obrien at FreeBSD.org Sat Jan 12 21:49:41 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 21:49:43 2008 Subject: cvs commit: src/contrib/cvs - Imported sources Message-ID: <200801130549.m0D5ne4l082551@repoman.freebsd.org> obrien 2008-01-13 05:49:40 UTC FreeBSD src repository src/contrib/cvs - Imported sources Update of /home/ncvs/src/contrib/cvs In directory repoman.freebsd.org:/tmp/cvs-serv82539 Log Message: Import cvs-1.11.22 onto vendor branch. Status: Vendor Tag: CVSHOME Release Tags: v1_11_22 U src/contrib/cvs/README U src/contrib/cvs/acinclude.m4 U src/contrib/cvs/configure.in U src/contrib/cvs/aclocal.m4 U src/contrib/cvs/Makefile.am U src/contrib/cvs/Makefile.in U src/contrib/cvs/config.h.in U src/contrib/cvs/configure U src/contrib/cvs/AUTHORS U src/contrib/cvs/COPYING U src/contrib/cvs/COPYING.LIB U src/contrib/cvs/ChangeLog U src/contrib/cvs/INSTALL U src/contrib/cvs/NEWS U src/contrib/cvs/TODO U src/contrib/cvs/compile U src/contrib/cvs/depcomp U src/contrib/cvs/install-sh U src/contrib/cvs/mdate-sh U src/contrib/cvs/missing U src/contrib/cvs/mkinstalldirs U src/contrib/cvs/BUGS U src/contrib/cvs/ChangeLog.zoo U src/contrib/cvs/DEVEL-CVS U src/contrib/cvs/FAQ U src/contrib/cvs/HACKING U src/contrib/cvs/MINOR-BUGS U src/contrib/cvs/PROJECTS U src/contrib/cvs/TESTS U src/contrib/cvs/cvs-format.el U src/contrib/cvs/mktemp.sh U src/contrib/cvs/contrib/README U src/contrib/cvs/contrib/Makefile.am U src/contrib/cvs/contrib/Makefile.in U src/contrib/cvs/contrib/check_cvs.in U src/contrib/cvs/contrib/clmerge.in U src/contrib/cvs/contrib/cln_hist.in U src/contrib/cvs/contrib/commit_prep.in U src/contrib/cvs/contrib/cvs_acls.in U src/contrib/cvs/contrib/log.in U src/contrib/cvs/contrib/log_accum.in U src/contrib/cvs/contrib/mfpipe.in U src/contrib/cvs/contrib/pvcs2rcs.in U src/contrib/cvs/contrib/rcs2log.sh U src/contrib/cvs/contrib/rcslock.in C src/contrib/cvs/contrib/sccs2rcs.in U src/contrib/cvs/contrib/ChangeLog U src/contrib/cvs/contrib/intro.doc U src/contrib/cvs/contrib/cvscheck.man U src/contrib/cvs/contrib/cvs2vendor.sh U src/contrib/cvs/contrib/cvscheck.sh U src/contrib/cvs/contrib/cvshelp.man N src/contrib/cvs/contrib/cvs_acls.html U src/contrib/cvs/contrib/descend.sh U src/contrib/cvs/contrib/debug_check_log.sh U src/contrib/cvs/contrib/descend.man U src/contrib/cvs/contrib/dirfns.shar U src/contrib/cvs/contrib/rcs-to-cvs.sh U src/contrib/cvs/contrib/rcs2sccs.sh U src/contrib/cvs/doc/Makefile.am U src/contrib/cvs/doc/Makefile.in N src/contrib/cvs/doc/mkman.pl U src/contrib/cvs/doc/stamp-1 U src/contrib/cvs/doc/stamp-vti U src/contrib/cvs/doc/version-client.texi U src/contrib/cvs/doc/version.texi U src/contrib/cvs/doc/ChangeLog U src/contrib/cvs/doc/mdate-sh U src/contrib/cvs/doc/cvs.texinfo U src/contrib/cvs/doc/cvsclient.texi U src/contrib/cvs/doc/ChangeLog.fsf U src/contrib/cvs/doc/RCSFILES U src/contrib/cvs/doc/cvs.1 U src/contrib/cvs/doc/cvs-paper.ms U src/contrib/cvs/doc/cvs.man.header U src/contrib/cvs/doc/cvs.man.footer U src/contrib/cvs/lib/Makefile.am U src/contrib/cvs/lib/Makefile.in U src/contrib/cvs/lib/fnmatch.h.in U src/contrib/cvs/lib/ChangeLog U src/contrib/cvs/lib/dup2.c U src/contrib/cvs/lib/fncase.c U src/contrib/cvs/lib/fnmatch.c U src/contrib/cvs/lib/ftruncate.c U src/contrib/cvs/lib/gethostname.c U src/contrib/cvs/lib/memmove.c U src/contrib/cvs/lib/mkdir.c U src/contrib/cvs/lib/rename.c U src/contrib/cvs/lib/strerror.c U src/contrib/cvs/lib/strstr.c U src/contrib/cvs/lib/strtoul.c U src/contrib/cvs/lib/valloc.c U src/contrib/cvs/lib/waitpid.c U src/contrib/cvs/lib/argmatch.c U src/contrib/cvs/lib/getdate.y U src/contrib/cvs/lib/getline.c U src/contrib/cvs/lib/getopt.c U src/contrib/cvs/lib/getopt1.c U src/contrib/cvs/lib/getpass.c U src/contrib/cvs/lib/md5.c U src/contrib/cvs/lib/regex.c U src/contrib/cvs/lib/savecwd.c U src/contrib/cvs/lib/sighandle.c U src/contrib/cvs/lib/stripslash.c U src/contrib/cvs/lib/xgetwd.c U src/contrib/cvs/lib/yesno.c U src/contrib/cvs/lib/getline.h U src/contrib/cvs/lib/getopt.h U src/contrib/cvs/lib/getpagesize.h U src/contrib/cvs/lib/md5.h U src/contrib/cvs/lib/regex.h U src/contrib/cvs/lib/savecwd.h U src/contrib/cvs/lib/system.h U src/contrib/cvs/lib/wait.h U src/contrib/cvs/lib/xselect.h U src/contrib/cvs/lib/xtime.h U src/contrib/cvs/lib/xsize.h U src/contrib/cvs/lib/ChangeLog.fsf U src/contrib/cvs/lib/xgssapi.h N src/contrib/cvs/lib/test-getdate.sh N src/contrib/cvs/lib/getdate U src/contrib/cvs/src/Makefile.am U src/contrib/cvs/src/Makefile.in U src/contrib/cvs/src/cvsbug.in U src/contrib/cvs/src/ChangeLog U src/contrib/cvs/src/add.c U src/contrib/cvs/src/admin.c U src/contrib/cvs/src/annotate.c C src/contrib/cvs/src/buffer.c U src/contrib/cvs/src/checkin.c C src/contrib/cvs/src/checkout.c U src/contrib/cvs/src/classify.c C src/contrib/cvs/src/client.c C src/contrib/cvs/src/commit.c U src/contrib/cvs/src/create_adm.c U src/contrib/cvs/src/cvsrc.c C src/contrib/cvs/src/diff.c U src/contrib/cvs/src/edit.c C src/contrib/cvs/src/entries.c U src/contrib/cvs/src/error.c U src/contrib/cvs/src/expand_path.c U src/contrib/cvs/src/fileattr.c C src/contrib/cvs/src/filesubr.c U src/contrib/cvs/src/find_names.c U src/contrib/cvs/src/hardlink.c U src/contrib/cvs/src/hash.c U src/contrib/cvs/src/history.c U src/contrib/cvs/src/ignore.c C src/contrib/cvs/src/import.c C src/contrib/cvs/src/lock.c C src/contrib/cvs/src/log.c C src/contrib/cvs/src/login.c C src/contrib/cvs/src/logmsg.c C src/contrib/cvs/src/main.c C src/contrib/cvs/src/mkmodules.c U src/contrib/cvs/src/modules.c U src/contrib/cvs/src/myndbm.c U src/contrib/cvs/src/no_diff.c C src/contrib/cvs/src/parseinfo.c C src/contrib/cvs/src/patch.c C src/contrib/cvs/src/rcs.c C src/contrib/cvs/src/rcscmds.c C src/contrib/cvs/src/recurse.c U src/contrib/cvs/src/release.c U src/contrib/cvs/src/remove.c U src/contrib/cvs/src/repos.c U src/contrib/cvs/src/root.c U src/contrib/cvs/src/run.c U src/contrib/cvs/src/scramble.c C src/contrib/cvs/src/server.c U src/contrib/cvs/src/stack.c U src/contrib/cvs/src/status.c U src/contrib/cvs/src/subr.c C src/contrib/cvs/src/tag.c C src/contrib/cvs/src/update.c U src/contrib/cvs/src/version.c U src/contrib/cvs/src/vers_ts.c U src/contrib/cvs/src/watch.c U src/contrib/cvs/src/wrapper.c U src/contrib/cvs/src/zlib.c U src/contrib/cvs/src/buffer.h U src/contrib/cvs/src/client.h C src/contrib/cvs/src/cvs.h U src/contrib/cvs/src/edit.h U src/contrib/cvs/src/error.h U src/contrib/cvs/src/fileattr.h U src/contrib/cvs/src/hardlink.h U src/contrib/cvs/src/hash.h U src/contrib/cvs/src/history.h U src/contrib/cvs/src/myndbm.h C src/contrib/cvs/src/rcs.h U src/contrib/cvs/src/root.h U src/contrib/cvs/src/server.h U src/contrib/cvs/src/stack.h U src/contrib/cvs/src/update.h U src/contrib/cvs/src/watch.h U src/contrib/cvs/src/ChangeLog-9194 U src/contrib/cvs/src/ChangeLog-9395 U src/contrib/cvs/src/ChangeLog-96 U src/contrib/cvs/src/ChangeLog-97 U src/contrib/cvs/src/sanity.sh U src/contrib/cvs/diff/Makefile.am U src/contrib/cvs/diff/Makefile.in U src/contrib/cvs/diff/ChangeLog U src/contrib/cvs/diff/diff.c U src/contrib/cvs/diff/diff3.c U src/contrib/cvs/diff/analyze.c U src/contrib/cvs/diff/cmpbuf.c U src/contrib/cvs/diff/cmpbuf.h U src/contrib/cvs/diff/io.c U src/contrib/cvs/diff/context.c U src/contrib/cvs/diff/ed.c U src/contrib/cvs/diff/normal.c U src/contrib/cvs/diff/ifdef.c U src/contrib/cvs/diff/util.c U src/contrib/cvs/diff/dir.c U src/contrib/cvs/diff/version.c U src/contrib/cvs/diff/diff.h U src/contrib/cvs/diff/side.c U src/contrib/cvs/diff/system.h U src/contrib/cvs/diff/diffrun.h U src/contrib/cvs/diff/diagmeet.note U src/contrib/cvs/man/Makefile.am U src/contrib/cvs/man/Makefile.in U src/contrib/cvs/man/ChangeLog U src/contrib/cvs/man/cvs.5 U src/contrib/cvs/man/cvsbug.8 U src/contrib/cvs/tools/README U src/contrib/cvs/tools/Makefile.am U src/contrib/cvs/tools/Makefile.in U src/contrib/cvs/tools/ChangeLog 25 conflicts created by this import. Use the following command to help the merge: cvs checkout -jCVSHOME:yesterday -jCVSHOME src/contrib/cvs From obrien at FreeBSD.org Sat Jan 12 21:50:34 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 21:50:35 2008 Subject: cvs commit: src/contrib/cvs FREEBSD-Xlist Message-ID: <200801130550.m0D5oXA6082892@repoman.freebsd.org> obrien 2008-01-13 05:50:33 UTC FreeBSD src repository Modified files: contrib/cvs FREEBSD-Xlist Log: Update for the 1.11.22 import. Revision Changes Path 1.2 +2 -1 src/contrib/cvs/FREEBSD-Xlist From obrien at FreeBSD.org Sat Jan 12 22:00:43 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:00:47 2008 Subject: cvs commit: src/contrib/cvs/src checkout.c Message-ID: <200801130600.m0D60hb0084329@repoman.freebsd.org> obrien 2008-01-13 06:00:42 UTC FreeBSD src repository Modified files: contrib/cvs/src checkout.c Log: Merge our -T comprehensive CVS/Template support into cvs 1.11.22. Revision Changes Path 1.6 +12 -10 src/contrib/cvs/src/checkout.c From obrien at FreeBSD.org Sat Jan 12 22:02:28 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:02:32 2008 Subject: cvs commit: src/contrib/cvs/src client.c Message-ID: <200801130602.m0D62SH3084883@repoman.freebsd.org> obrien 2008-01-13 06:02:28 UTC FreeBSD src repository Modified files: contrib/cvs/src client.c Log: Merge rev 1.7: always upload new files, even if the timestamps match, rev 1.4: flip the default for CVS_RSH to "ssh", rev 1.2: fix a problem sometimes seen when doing checkouts from a local repo and committing via remote cvs (a cvs -d override of the mismatched CVS/Root files was missing) into cvs 1.11.22. Revision Changes Path 1.13 +103 -124 src/contrib/cvs/src/client.c From obrien at FreeBSD.org Sat Jan 12 22:04:43 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:04:45 2008 Subject: cvs commit: src/contrib/cvs/src cvs.h Message-ID: <200801130604.m0D64hwx086525@repoman.freebsd.org> obrien 2008-01-13 06:04:43 UTC FreeBSD src repository Modified files: contrib/cvs/src cvs.h Log: Change default from rsh to ssh. (moved from client.c). Merge rev 1.14: comprehensive -T CVS/Template support, rev 1.9: new long flag that causes cvs to ignore the CVSROOT/passwd file, rev 1.3: support for checking out from a read-only repository, rev. 1.2: support for local $Id$ keyword into cvs 1.11.22. Note that rev 1.4 (make verifymsg extra useful) is OBE. Revision Changes Path 1.21 +33 -18 src/contrib/cvs/src/cvs.h From obrien at FreeBSD.org Sat Jan 12 22:05:25 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:05:27 2008 Subject: cvs commit: src/contrib/cvs/src diff.c Message-ID: <200801130605.m0D65Plc086605@repoman.freebsd.org> obrien 2008-01-13 06:05:25 UTC FreeBSD src repository Modified files: contrib/cvs/src diff.c Log: Merge rev 1.16: implement -j for cvs diff, allowing tag:date based diffs into version 1.11.22. Revision Changes Path 1.22 +100 -66 src/contrib/cvs/src/diff.c From obrien at FreeBSD.org Sat Jan 12 22:06:16 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:06:20 2008 Subject: cvs commit: src/contrib/cvs/src filesubr.c Message-ID: <200801130606.m0D66G2p086656@repoman.freebsd.org> obrien 2008-01-13 06:06:16 UTC FreeBSD src repository Modified files: contrib/cvs/src filesubr.c Log: Toss all of our local changes - they are OBE. However, stay with version 1.9.26's buflen of BUFSIZ as we have in the past vs. going with the 1.10+ limited length of 128. Revision Changes Path 1.14 +61 -34 src/contrib/cvs/src/filesubr.c From obrien at FreeBSD.org Sat Jan 12 22:06:42 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:06:45 2008 Subject: cvs commit: src/contrib/cvs/src tag.c Message-ID: <200801130606.m0D66fQP086690@repoman.freebsd.org> obrien 2008-01-13 06:06:41 UTC FreeBSD src repository Modified files: contrib/cvs/src tag.c Log: Merge rev 1.2 (do not check val-tags if the repository is read-only) into version 1.11.22. Revision Changes Path 1.3 +180 -83 src/contrib/cvs/src/tag.c From obrien at FreeBSD.org Sat Jan 12 22:07:21 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:07:25 2008 Subject: cvs commit: src/contrib/cvs/src entries.c Message-ID: <200801130607.m0D67Kfx086732@repoman.freebsd.org> obrien 2008-01-13 06:07:20 UTC FreeBSD src repository Modified files: contrib/cvs/src entries.c Log: Merge revs 1.2 (comprehensive CVS/Template support) into version 1.11.22. Revision Changes Path 1.5 +8 -2 src/contrib/cvs/src/entries.c From obrien at FreeBSD.org Sat Jan 12 22:08:17 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:08:19 2008 Subject: cvs commit: src/contrib/cvs/src lock.c Message-ID: <200801130608.m0D68HhS086811@repoman.freebsd.org> obrien 2008-01-13 06:08:17 UTC FreeBSD src repository Modified files: contrib/cvs/src lock.c Log: Merge rev 1.3 (catch write-lock attempts immediately if running in read-only mode) & rev 1.2 (check out from read-only repository support) into version 1.11.22. Revision Changes Path 1.14 +182 -42 src/contrib/cvs/src/lock.c From obrien at FreeBSD.org Sat Jan 12 22:08:50 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:08:53 2008 Subject: cvs commit: src/contrib/cvs/src log.c Message-ID: <200801130608.m0D68oPe086845@repoman.freebsd.org> obrien 2008-01-13 06:08:50 UTC FreeBSD src repository Modified files: contrib/cvs/src log.c Log: Merge rev 1.3 ('-n' option) & rev. 1.2 ("iso8601" option keyword) into version 1.11.22. Revision Changes Path 1.4 +67 -27 src/contrib/cvs/src/log.c From obrien at FreeBSD.org Sat Jan 12 22:09:42 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:09:44 2008 Subject: cvs commit: src/contrib/cvs/src logmsg.c Message-ID: <200801130609.m0D69fLP086900@repoman.freebsd.org> obrien 2008-01-13 06:09:41 UTC FreeBSD src repository Modified files: contrib/cvs/src logmsg.c Log: Merge rev 1.9 (put the blank line back in the beginning of constructed log messages being passed to $EDITOR) into version 1.11.22. Revision Changes Path 1.13 +13 -16 src/contrib/cvs/src/logmsg.c From obrien at FreeBSD.org Sat Jan 12 22:10:19 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:10:23 2008 Subject: cvs commit: src/contrib/cvs/src main.c Message-ID: <200801130610.m0D6AJuJ087050@repoman.freebsd.org> obrien 2008-01-13 06:10:19 UTC FreeBSD src repository Modified files: contrib/cvs/src main.c Log: Merge rev 1.25 ("iso8601" option keyword), rev 1.23 (blame), rev 1.17 (environtmental var "CVS_OPTIONS"), rev 1.14 ('-g' option to support shared-group access), rev 1.7 ('-R' read-only repository mode), rev 1.6 (support for checking out from a read-only repository), revs 1.4 & 1.5 ("tagexpand=") into version 1.11.22. Revision Changes Path 1.26 +110 -136 src/contrib/cvs/src/main.c From obrien at FreeBSD.org Sat Jan 12 22:10:58 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:11:02 2008 Subject: cvs commit: src/contrib/cvs/src parseinfo.c Message-ID: <200801130610.m0D6Aw8x087315@repoman.freebsd.org> obrien 2008-01-13 06:10:58 UTC FreeBSD src repository Modified files: contrib/cvs/src parseinfo.c Log: Merge rev 1.2 (extensions to the $CVSROOT/config syntax) and rev 1.4 (1.12 CVSROOT/config keyword expansion forward compatability) into version 1.11.22. Revision Changes Path 1.5 +18 -6 src/contrib/cvs/src/parseinfo.c From obrien at FreeBSD.org Sat Jan 12 22:11:36 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:11:38 2008 Subject: cvs commit: src/contrib/cvs/src rcs.h Message-ID: <200801130611.m0D6BaAb087648@repoman.freebsd.org> obrien 2008-01-13 06:11:36 UTC FreeBSD src repository Modified files: contrib/cvs/src rcs.h Log: Merge rev 1.11 ("iso8601" option keyword) into version 1.11.22. (all our other local changes are OBE) Revision Changes Path 1.12 +9 -3 src/contrib/cvs/src/rcs.h From obrien at FreeBSD.org Sat Jan 12 22:12:27 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:12:28 2008 Subject: cvs commit: src/contrib/cvs/src rcs.c Message-ID: <200801130612.m0D6CRHK087974@repoman.freebsd.org> obrien 2008-01-13 06:12:27 UTC FreeBSD src repository Modified files: contrib/cvs/src rcs.c Log: Merge rev 1.28 (CAN-2005-0753 / FreeBSD-SA-05:05.cvs fixes), rev 1.27 ("iso8601" option keyword) revs 1.12/1.10/1.5/1.4 ($CVSHeader$ support) rev 1.2 ($CVS_LOCAL_BRANCH_NUM support for local commit feature of cvsup) into version 1.11.22. Note rev 1.21 ("-D date" checkout bug relating to 1.1.1.1 vs 1.1 revisions), rev 1.13 (allow -D'date' with -r'branch' on a checkout), rev 1.6 (use xstrdup rather than strdup) are fixed in the vendor sources Revision Changes Path 1.29 +296 -80 src/contrib/cvs/src/rcs.c From obrien at FreeBSD.org Sat Jan 12 22:12:54 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:12:59 2008 Subject: cvs commit: src/contrib/cvs/src server.c Message-ID: <200801130612.m0D6Cscf088158@repoman.freebsd.org> obrien 2008-01-13 06:12:54 UTC FreeBSD src repository Modified files: contrib/cvs/src server.c Log: Merge rev 1.9 (new long flag to ignore the CVSROOT/passwd file) rev 1.2 (local tag/$Id$ keyword support) into version 1.11.22. Revision Changes Path 1.25 +125 -47 src/contrib/cvs/src/server.c From obrien at FreeBSD.org Sat Jan 12 22:13:28 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:13:32 2008 Subject: cvs commit: src/contrib/cvs/src update.c Message-ID: <200801130613.m0D6DSvV088362@repoman.freebsd.org> obrien 2008-01-13 06:13:25 UTC FreeBSD src repository Modified files: contrib/cvs/src update.c Log: Merge rev 1.9 (update "-T" Template support) and rev 1.2 (-D'date' option with -r'branch' on update) into version 1.11.22. Revision Changes Path 1.15 +93 -112 src/contrib/cvs/src/update.c From obrien at FreeBSD.org Sat Jan 12 22:14:30 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:14:31 2008 Subject: cvs commit: src/contrib/cvs/man cvs.1 Message-ID: <200801130614.m0D6ETOs088541@repoman.freebsd.org> obrien 2008-01-13 06:14:29 UTC FreeBSD src repository Modified files: contrib/cvs/man cvs.1 Log: Merge what 1.11.17 -> 1.11.22 ../doc/cvs.1 changes I could. We never merged in the 1.11.15 -> 1.11.17 changes - due to the moving of cvs.1 from man/ to doc/ and being auto generated. Revision Changes Path 1.23 +22 -13 src/contrib/cvs/man/cvs.1 From obrien at FreeBSD.org Sat Jan 12 22:15:39 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:15:42 2008 Subject: cvs commit: CVSROOT exclude Message-ID: <200801130615.m0D6FdJh088726@repoman.freebsd.org> obrien 2008-01-13 06:15:39 UTC FreeBSD src repository Modified files: . exclude Log: Exclude CVS for vender import merge. Revision Changes Path 1.153 +1 -0 CVSROOT/exclude From obrien at FreeBSD.org Sat Jan 12 22:20:14 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:20:17 2008 Subject: cvs commit: src/contrib/cvs/contrib sccs2rcs.in src/contrib/cvs/src buffer.c commit.c import.c login.c mkmodules.c patch.c rcscmds.c recurse.c Message-ID: <200801130620.m0D6KDIM088948@repoman.freebsd.org> obrien 2008-01-13 06:20:12 UTC FreeBSD src repository Modified files: contrib/cvs/contrib sccs2rcs.in contrib/cvs/src buffer.c commit.c import.c login.c mkmodules.c patch.c rcscmds.c recurse.c Log: We use the stock versions of these files. Reviewed/begged-for by: peter Revision Changes Path 1.6 +12 -0 src/contrib/cvs/contrib/sccs2rcs.in 1.6 +50 -18 src/contrib/cvs/src/buffer.c 1.16 +129 -61 src/contrib/cvs/src/commit.c 1.13 +37 -34 src/contrib/cvs/src/import.c 1.10 +9 -3 src/contrib/cvs/src/login.c 1.14 +19 -4 src/contrib/cvs/src/mkmodules.c 1.3 +51 -21 src/contrib/cvs/src/patch.c 1.11 +80 -94 src/contrib/cvs/src/rcscmds.c 1.13 +94 -71 src/contrib/cvs/src/recurse.c From obrien at FreeBSD.org Sat Jan 12 22:24:49 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:24:52 2008 Subject: cvs commit: src/contrib/cvs/doc mkman.in Message-ID: <200801130624.m0D6OnGo090211@repoman.freebsd.org> obrien 2008-01-13 06:24:49 UTC FreeBSD src repository Removed files: (Branch: CVSHOME) contrib/cvs/doc mkman.in Log: 2004-09-25 Derek Price * mkman.in: Move to... * mkman.pl: ...here. Revision Changes Path 1.1.1.2 +0 -314 src/contrib/cvs/doc/mkman.in (dead) From obrien at FreeBSD.org Sat Jan 12 22:35:25 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:35:27 2008 Subject: cvs commit: src/contrib/cvs FREEBSD-upgrade Message-ID: <200801130635.m0D6ZOEc091800@repoman.freebsd.org> obrien 2008-01-13 06:35:22 UTC FreeBSD src repository Modified files: contrib/cvs FREEBSD-upgrade Log: Update for the 1.11.22 import. Reviewed/begged-for by: peter Revision Changes Path 1.12 +10 -3 src/contrib/cvs/FREEBSD-upgrade From obrien at FreeBSD.org Sat Jan 12 22:37:24 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:37:28 2008 Subject: cvs commit: CVSROOT exclude Message-ID: <200801130637.m0D6bNEW091872@repoman.freebsd.org> obrien 2008-01-13 06:37:23 UTC FreeBSD src repository Modified files: . exclude Log: Revert rev 1.153. Revision Changes Path 1.154 +0 -1 CVSROOT/exclude From obrien at FreeBSD.org Sat Jan 12 22:56:31 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 12 22:56:33 2008 Subject: cvs commit: src/gnu/usr.bin Makefile Message-ID: <200801130656.m0D6uVFR002209@repoman.freebsd.org> obrien 2008-01-13 06:56:31 UTC FreeBSD src repository Modified files: gnu/usr.bin Makefile Log: Reenable cvs with the build. Revision Changes Path 1.94 +3 -3 src/gnu/usr.bin/Makefile From yar at FreeBSD.org Sat Jan 12 23:56:36 2008 From: yar at FreeBSD.org (Yar Tikhiy) Date: Sat Jan 12 23:56:40 2008 Subject: cvs commit: src/sbin/fsck_msdosfs boot.c Message-ID: <200801130756.m0D7uaLu012188@repoman.freebsd.org> yar 2008-01-13 07:56:36 UTC FreeBSD src repository Modified files: sbin/fsck_msdosfs boot.c Log: Prevent the `fix?' question from running together with the problem description on the terminal: use conventional punctuation. Revision Changes Path 1.5 +1 -1 src/sbin/fsck_msdosfs/boot.c From keramida at FreeBSD.org Sun Jan 13 00:33:21 2008 From: keramida at FreeBSD.org (Giorgos Keramidas) Date: Sun Jan 13 00:33:47 2008 Subject: cvs commit: src/tools/regression/usr.bin/tr Makefile regress.00.out regress.01.out regress.02.out regress.03.out regress.04.out regress.05.out regress.06.out regress.07.out regress.08.out regress.09.out regress.0a.out regress.0b.out regress.in regress.sh ... Message-ID: <200801130833.m0D8XLDd019137@repoman.freebsd.org> keramida 2008-01-13 08:33:20 UTC FreeBSD src repository (doc committer) Added files: tools/regression/usr.bin/tr Makefile regress.00.out regress.01.out regress.02.out regress.03.out regress.04.out regress.05.out regress.06.out regress.07.out regress.08.out regress.09.out regress.0a.out regress.0b.out regress.in regress.sh regress.t regress2.in Log: Add a new set of regression tests, for the tr(1) utility. Approved by: das, dds Revision Changes Path 1.1 +4 -0 src/tools/regression/usr.bin/tr/Makefile (new) 1.1 +4 -0 src/tools/regression/usr.bin/tr/regress.00.out (new) 1.1 +4 -0 src/tools/regression/usr.bin/tr/regress.01.out (new) 1.1 +4 -0 src/tools/regression/usr.bin/tr/regress.02.out (new) 1.1 +4 -0 src/tools/regression/usr.bin/tr/regress.03.out (new) 1.1 +4 -0 src/tools/regression/usr.bin/tr/regress.04.out (new) 1.1 +4 -0 src/tools/regression/usr.bin/tr/regress.05.out (new) 1.1 +9 -0 src/tools/regression/usr.bin/tr/regress.06.out (new) 1.1 +9 -0 src/tools/regression/usr.bin/tr/regress.07.out (new) 1.1 +9 -0 src/tools/regression/usr.bin/tr/regress.08.out (new) 1.1 +1 -0 src/tools/regression/usr.bin/tr/regress.09.out (new) 1.1 +1 -0 src/tools/regression/usr.bin/tr/regress.0a.out (new) 1.1 +1 -0 src/tools/regression/usr.bin/tr/regress.0b.out (new) 1.1 +4 -0 src/tools/regression/usr.bin/tr/regress.in (new) 1.1 +20 -0 src/tools/regression/usr.bin/tr/regress.sh (new) 1.1 +6 -0 src/tools/regression/usr.bin/tr/regress.t (new) 1.1 +9 -0 src/tools/regression/usr.bin/tr/regress2.in (new) From keramida at FreeBSD.org Sun Jan 13 00:33:59 2008 From: keramida at FreeBSD.org (Giorgos Keramidas) Date: Sun Jan 13 00:34:16 2008 Subject: cvs commit: src/tools/regression/usr.bin Makefile Message-ID: <200801130833.m0D8Xw1n019178@repoman.freebsd.org> keramida 2008-01-13 08:33:58 UTC FreeBSD src repository (doc committer) Modified files: tools/regression/usr.bin Makefile Log: Attach the tr(1) regression tests to the build. Approved by: das, dds Revision Changes Path 1.13 +1 -1 src/tools/regression/usr.bin/Makefile From obrien at FreeBSD.org Sun Jan 13 00:58:26 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sun Jan 13 00:58:31 2008 Subject: cvs commit: src/gnu/usr.bin/cvs Makefile Message-ID: <200801130858.m0D8wQoZ031456@repoman.freebsd.org> obrien 2008-01-13 08:58:26 UTC FreeBSD src repository Modified files: gnu/usr.bin/cvs Makefile Log: Disable contrib - there is weirdness going on with it. Revision Changes Path 1.17 +1 -1 src/gnu/usr.bin/cvs/Makefile From obrien at FreeBSD.org Sun Jan 13 01:45:54 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sun Jan 13 01:45:59 2008 Subject: cvs commit: src/gnu/usr.bin/cvs/contrib Makefile Message-ID: <200801130945.m0D9jsgf040114@repoman.freebsd.org> obrien 2008-01-13 09:45:54 UTC FreeBSD src repository Modified files: gnu/usr.bin/cvs/contrib Makefile Log: Use our standard verbose spelling of rules variables. (as a nice side affect, this will make gnu/usr.bin/cvs/contrib/Makefile have a later date than contrib/cvs/contrib/Makefile.in - which will help the build break after the 1.11.22 CVS import...) Revision Changes Path 1.19 +3 -3 src/gnu/usr.bin/cvs/contrib/Makefile From peter at wemm.org Sun Jan 13 01:52:37 2008 From: peter at wemm.org (Peter Wemm) Date: Sun Jan 13 01:52:41 2008 Subject: cvs commit: src/gnu/usr.bin/cvs Makefile In-Reply-To: <200801130858.m0D8wQoZ031456@repoman.freebsd.org> References: <200801130858.m0D8wQoZ031456@repoman.freebsd.org> Message-ID: On Jan 13, 2008 12:58 AM, David E. O'Brien wrote: > obrien 2008-01-13 08:58:26 UTC > > Modified files: > gnu/usr.bin/cvs Makefile > Log: > Disable contrib - there is weirdness going on with it. To the observers.. this is NOT david's fault. If you touch /usr/src/contrib/cvs/contrib/Makefile.in on a stock 7.0 system, the same problem happens. The tree only built due to sheer luck that the timestamps on gnu/usr.bin/cvs/contrib/Makefile were usually newer than the unrelated Makefile.in that is in src/contrib. 7.0 and HEAD were broken for a long time before David's import. David was just unlucky enough to touch the timestamps and expose the existing problem. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From obrien at FreeBSD.org Sun Jan 13 02:14:23 2008 From: obrien at FreeBSD.org (David O'Brien) Date: Sun Jan 13 02:14:25 2008 Subject: cvs commit: src/usr.bin/make globals.h job.c job.h main.c make.1 make.h parse.c In-Reply-To: <200703080916.l289GB7N040141@repoman.freebsd.org> References: <200703080916.l289GB7N040141@repoman.freebsd.org> Message-ID: <20080113101421.GA45977@dragon.NUXI.org> On Thu, Mar 08, 2007 at 09:16:11AM +0000, Max Khon wrote: > fjoe 2007-03-08 09:16:11 UTC > Modified files: > usr.bin/make globals.h job.c job.h main.c make.1 > make.h parse.c > Log: > Implement "Remaking Makefiles" feature: > > After reading Makefile and all the files that are included using > .include or .sinclude directives (source Makefiles) make considers > each source Makefile as a target and tries to rebuild it. Both > explicit and implicit rules are checked and all source Makefiles are > updated if necessary. If any of the source Makefiles were rebuilt, > make restarts from clean state. How does one turn this off? It causes SuffFindDeps to be run over every .MAKEFILE_LIST member. This causes a problem if you try to build in src/gnu/usr.bin/cvs/contrib and ./Makefile has an older date than src/contrib/cvs/contrib/Makefile.in. I'm curious, is this functionality depended on to build world? Or it is a feature to do cool stuff outside of /usr/src? > When remaking a source Makefile options -t (touch target), -q (query > mode), and -n (no exec) do not take effect, unless source Makefile is > specified explicitly as a target in make command line. I'm not so sure this is good behavior. When trying to debug the issue with src/gnu/usr.bin/cvs/contrib/Makefile; I did: rm Makefile ; cvs up Makefile ; make -n and yet still had my Makefile damanged (do to the other issues with this commit). I really do think 'make -n' really does mean "DO NOT ACTUALLY EXECUTE THEM". At a minimum, make.1 needs updating to make it clear that 'make -n' can have side affects. -- David From simon at FreeBSD.org Sun Jan 13 03:44:48 2008 From: simon at FreeBSD.org (Simon L. Nielsen) Date: Sun Jan 13 03:44:50 2008 Subject: cvs commit: src/crypto/openssl/crypto/engine eng_cryptodev.c Message-ID: <200801131144.m0DBimYT077701@repoman.freebsd.org> simon 2008-01-13 11:44:47 UTC FreeBSD src repository Modified files: crypto/openssl/crypto/engine eng_cryptodev.c Log: Unbreak detection of cryptodev support for FreeBSD which was broken with OpenSSL 0.9.8 import. Note that this does not enable cryptodev by default, as it was the case with OpenSSL 0.9.7 in FreeBSD base, but this change makes it possible to enable cryptodev at all. This has been submitted upstream as: http://rt.openssl.org/Ticket/Display.html?id=1624 Submitted by: nork Revision Changes Path 1.2 +2 -1 src/crypto/openssl/crypto/engine/eng_cryptodev.c From simon at FreeBSD.org Sun Jan 13 04:19:39 2008 From: simon at FreeBSD.org (Simon L. Nielsen) Date: Sun Jan 13 04:19:42 2008 Subject: cvs commit: src/crypto/openssl/crypto/engine eng_cryptodev.c In-Reply-To: <200801131144.m0DBimYT077701@repoman.freebsd.org> References: <200801131144.m0DBimYT077701@repoman.freebsd.org> Message-ID: <20080113115947.GA1135@zaphod.nitro.dk> On 2008.01.13 11:44:47 +0000, Simon L. Nielsen wrote: > simon 2008-01-13 11:44:47 UTC > > FreeBSD src repository > > Modified files: > crypto/openssl/crypto/engine eng_cryptodev.c > Log: > Unbreak detection of cryptodev support for FreeBSD which was broken > with OpenSSL 0.9.8 import. > > Note that this does not enable cryptodev by default, as it was the > case with OpenSSL 0.9.7 in FreeBSD base, but this change makes it > possible to enable cryptodev at all. With this change it is possible to enable cryptodev by default for openssl(1) with lines like below in etc/ssl/openssl.cnf. Unfortunately openssh does not call the functions to read the config file so it's not possible to enable cryptodev in openssh in a similar fashion. I have yet figure out how to do support cryptodev by default cleanly... Oh, and I just remembered that I forgot to thank Mike Tancsa / Sentex for providing hardware used for testing this. So... thanks! :-) [openssl_init] engines = engine_section [engine_section] cryptodev = cryptodev_section [ cryptodev_section ] engine_id = cryptodev default_algorithms = ALL (Note that the above was copied from a config file I haven't touched in month so I'm 100% the exact section above is enough, but it's close...) -- Simon L. Nielsen From des at des.no Sun Jan 13 05:57:59 2008 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Sun Jan 13 05:58:04 2008 Subject: cvs commit: src/usr.sbin/iostat iostat.c In-Reply-To: <20080112211919.GA3408@VARK.MIT.EDU> (David Schultz's message of "Sat\, 12 Jan 2008 16\:19\:19 -0500") References: <200801122037.m0CKb6CS009262@repoman.freebsd.org> <20080112205254.GB3090@VARK.MIT.EDU> <20080112235350.C10888@mp2.macomnet.net> <20080112211919.GA3408@VARK.MIT.EDU> Message-ID: <86ve5xq142.fsf@ds4.des.no> David Schultz writes: > Maxim Konovalov writes: > > err(1, "asprintf") was my first version, yes. But I failed to find in > > the man page it sets errno. Thanks for the review, I'll fix the typo > > shortly. > I don't think it always does set errno, but you can set errno to 0 > before the call, and you'll get either the real error message from > err() or "unknown error". If asprintf() fails because malloc() failed, malloc() will have set errno to ENOMEM. I can't think of any other failure mode for asprintf() that won't either be silently ignored (error in format string) or result in a segmentation fault (bogus argument to %s). DES -- Dag-Erling Sm?rgrav - des@des.no From simon at FreeBSD.org Sun Jan 13 06:27:54 2008 From: simon at FreeBSD.org (Simon L. Nielsen) Date: Sun Jan 13 06:27:55 2008 Subject: cvs commit: src/etc/rc.d jail Message-ID: <200801131427.m0DERrmp017034@repoman.freebsd.org> simon 2008-01-13 14:27:53 UTC FreeBSD src repository Modified files: etc/rc.d jail Log: Add warning about this script dealing with untrusted data. MFC after: 1 week Revision Changes Path 1.38 +6 -0 src/etc/rc.d/jail From attilio at FreeBSD.org Sun Jan 13 06:44:16 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Sun Jan 13 06:44:21 2008 Subject: cvs commit: src/sys/compat/linux linux_file.c linux_misc.c src/sys/compat/ndis subr_ndis.c src/sys/compat/opensolaris/kern opensolaris_kobj.c opensolaris_vfs.c src/sys/compat/opensolaris/sys vnode.h src/sys/compat/pecoff imgact_pecoff.c src/sys/compat/svr4 ... Message-ID: <200801131444.m0DEiG65020895@repoman.freebsd.org> attilio 2008-01-13 14:44:15 UTC FreeBSD src repository Modified files: sys/compat/linux linux_file.c linux_misc.c sys/compat/ndis subr_ndis.c sys/compat/opensolaris/kern opensolaris_kobj.c opensolaris_vfs.c sys/compat/opensolaris/sys vnode.h sys/compat/pecoff imgact_pecoff.c sys/compat/svr4 imgact_svr4.c svr4_fcntl.c svr4_misc.c sys/contrib/opensolaris/uts/common/fs/zfs zfs_ctldir.c zfs_replay.c zfs_vnops.c zfs_znode.c sys/dev/hwpmc hwpmc_mod.c sys/dev/md md.c sys/fs/cd9660 cd9660_lookup.c cd9660_vfsops.c sys/fs/coda coda_vnops.c sys/fs/devfs devfs_devs.c devfs_vfsops.c devfs_vnops.c sys/fs/fdescfs fdesc_vnops.c sys/fs/fifofs fifo_vnops.c sys/fs/hpfs hpfs_vfsops.c hpfs_vnops.c sys/fs/msdosfs msdosfs_lookup.c msdosfs_vfsops.c msdosfs_vnops.c sys/fs/ntfs ntfs_vfsops.c ntfs_vnops.c sys/fs/nullfs null_vfsops.c null_vnops.c sys/fs/nwfs nwfs_vfsops.c nwfs_vnops.c sys/fs/procfs procfs.c sys/fs/pseudofs pseudofs_vncache.c pseudofs_vnops.c sys/fs/smbfs smbfs_vfsops.c smbfs_vnops.c sys/fs/tmpfs tmpfs_vfsops.c tmpfs_vnops.c sys/fs/udf udf_vfsops.c udf_vnops.c sys/fs/unionfs union_subr.c union_vfsops.c union_vnops.c sys/gnu/fs/ext2fs ext2_lookup.c ext2_vfsops.c ext2_vnops.c fs.h sys/gnu/fs/reiserfs reiserfs_inode.c reiserfs_namei.c reiserfs_vfsops.c sys/gnu/fs/xfs/FreeBSD xfs_mountops.c xfs_super.c xfs_vnode.c xfs_vnops.c sys/i386/ibcs2 ibcs2_misc.c imgact_coff.c sys/i386/linux imgact_linux.c sys/kern imgact_aout.c imgact_elf.c imgact_gzip.c kern_acct.c kern_alq.c kern_descrip.c kern_exec.c kern_exit.c kern_jail.c kern_ktrace.c kern_linker.c kern_sig.c link_elf.c link_elf_obj.c tty_cons.c uipc_mqueue.c uipc_syscalls.c uipc_usrreq.c vfs_acl.c vfs_aio.c vfs_bio.c vfs_cache.c vfs_default.c vfs_extattr.c vfs_lookup.c vfs_mount.c vfs_subr.c vfs_syscalls.c vfs_vnops.c vnode_if.src sys/nfs4client nfs4_vfsops.c nfs4_vnops.c sys/nfsclient nfs_subs.c nfs_vfsops.c nfs_vnops.c sys/nfsserver nfs_serv.c nfs_srvsubs.c sys/security/audit audit_arg.c audit_syscalls.c audit_worker.c sys/security/mac mac_process.c mac_syscalls.c sys/sys vnode.h sys/ufs/ffs ffs_rawread.c ffs_snapshot.c ffs_softdep.c ffs_vfsops.c ffs_vnops.c sys/ufs/ufs ufs_extattr.c ufs_lookup.c ufs_quota.c ufs_vnops.c sys/vm swap_pager.c vm_contig.c vm_object.c vnode_pager.c Log: VOP_LOCK1() (and so VOP_LOCK()) and VOP_UNLOCK() are only used in conjuction with 'thread' argument passing which is always curthread. Remove the unuseful extra-argument and pass explicitly curthread to lower layer functions, when necessary. KPI results broken by this change, which should affect several ports, so version bumping and manpage update will be further committed. Tested by: kris, pho, Diego Sardina Revision Changes Path 1.109 +1 -1 src/sys/compat/linux/linux_file.c 1.216 +2 -2 src/sys/compat/linux/linux_misc.c 1.111 +1 -1 src/sys/compat/ndis/subr_ndis.c 1.6 +5 -5 src/sys/compat/opensolaris/kern/opensolaris_kobj.c 1.9 +4 -4 src/sys/compat/opensolaris/kern/opensolaris_vfs.c 1.5 +4 -5 src/sys/compat/opensolaris/sys/vnode.h 1.43 +2 -3 src/sys/compat/pecoff/imgact_pecoff.c 1.28 +1 -2 src/sys/compat/svr4/imgact_svr4.c 1.43 +1 -1 src/sys/compat/svr4/svr4_fcntl.c 1.100 +3 -3 src/sys/compat/svr4/svr4_misc.c 1.7 +2 -2 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c 1.5 +10 -10 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_replay.c 1.26 +1 -1 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c 1.12 +1 -1 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_znode.c 1.32 +2 -4 src/sys/dev/hwpmc/hwpmc_mod.c 1.173 +8 -8 src/sys/dev/md/md.c 1.45 +1 -2 src/sys/fs/cd9660/cd9660_lookup.c 1.153 +2 -2 src/sys/fs/cd9660/cd9660_vfsops.c 1.78 +4 -4 src/sys/fs/coda/coda_vnops.c 1.53 +1 -3 src/sys/fs/devfs/devfs_devs.c 1.53 +1 -1 src/sys/fs/devfs/devfs_vfsops.c 1.155 +4 -4 src/sys/fs/devfs/devfs_vnops.c 1.106 +1 -1 src/sys/fs/fdescfs/fdesc_vnops.c 1.142 +2 -2 src/sys/fs/fifofs/fifo_vnops.c 1.63 +1 -1 src/sys/fs/hpfs/hpfs_vfsops.c 1.72 +1 -1 src/sys/fs/hpfs/hpfs_vnops.c 1.54 +1 -2 src/sys/fs/msdosfs/msdosfs_lookup.c 1.185 +5 -5 src/sys/fs/msdosfs/msdosfs_vfsops.c 1.183 +17 -18 src/sys/fs/msdosfs/msdosfs_vnops.c 1.92 +1 -1 src/sys/fs/ntfs/ntfs_vfsops.c 1.62 +1 -1 src/sys/fs/ntfs/ntfs_vnops.c 1.86 +3 -3 src/sys/fs/nullfs/null_vfsops.c 1.97 +4 -6 src/sys/fs/nullfs/null_vnops.c 1.46 +1 -1 src/sys/fs/nwfs/nwfs_vfsops.c 1.44 +1 -1 src/sys/fs/nwfs/nwfs_vnops.c 1.18 +1 -1 src/sys/fs/procfs/procfs.c 1.40 +2 -2 src/sys/fs/pseudofs/pseudofs_vncache.c 1.67 +1 -1 src/sys/fs/pseudofs/pseudofs_vnops.c 1.43 +1 -1 src/sys/fs/smbfs/smbfs_vfsops.c 1.67 +1 -1 src/sys/fs/smbfs/smbfs_vnops.c 1.17 +1 -1 src/sys/fs/tmpfs/tmpfs_vfsops.c 1.15 +2 -2 src/sys/fs/tmpfs/tmpfs_vnops.c 1.51 +1 -1 src/sys/fs/udf/udf_vfsops.c 1.68 +1 -1 src/sys/fs/udf/udf_vnops.c 1.98 +4 -4 src/sys/fs/unionfs/union_subr.c 1.89 +4 -4 src/sys/fs/unionfs/union_vfsops.c 1.152 +34 -40 src/sys/fs/unionfs/union_vnops.c 1.54 +1 -2 src/sys/gnu/fs/ext2fs/ext2_lookup.c 1.169 +8 -8 src/sys/gnu/fs/ext2fs/ext2_vfsops.c 1.112 +8 -9 src/sys/gnu/fs/ext2fs/ext2_vnops.c 1.20 +1 -1 src/sys/gnu/fs/ext2fs/fs.h 1.4 +1 -1 src/sys/gnu/fs/reiserfs/reiserfs_inode.c 1.6 +1 -1 src/sys/gnu/fs/reiserfs/reiserfs_namei.c 1.11 +3 -3 src/sys/gnu/fs/reiserfs/reiserfs_vfsops.c 1.11 +2 -2 src/sys/gnu/fs/xfs/FreeBSD/xfs_mountops.c 1.7 +2 -2 src/sys/gnu/fs/xfs/FreeBSD/xfs_super.c 1.4 +1 -1 src/sys/gnu/fs/xfs/FreeBSD/xfs_vnode.c 1.8 +6 -6 src/sys/gnu/fs/xfs/FreeBSD/xfs_vnops.c 1.70 +2 -2 src/sys/i386/ibcs2/ibcs2_misc.c 1.70 +3 -4 src/sys/i386/ibcs2/imgact_coff.c 1.58 +1 -2 src/sys/i386/linux/imgact_linux.c 1.104 +1 -1 src/sys/kern/imgact_aout.c 1.185 +2 -3 src/sys/kern/imgact_elf.c 1.58 +1 -2 src/sys/kern/imgact_gzip.c 1.98 +2 -2 src/sys/kern/kern_acct.c 1.22 +2 -2 src/sys/kern/kern_alq.c 1.320 +1 -1 src/sys/kern/kern_descrip.c 1.315 +3 -3 src/sys/kern/kern_exec.c 1.307 +1 -1 src/sys/kern/kern_exit.c 1.74 +3 -3 src/sys/kern/kern_jail.c 1.125 +2 -2 src/sys/kern/kern_ktrace.c 1.154 +3 -3 src/sys/kern/kern_linker.c 1.355 +3 -3 src/sys/kern/kern_sig.c 1.95 +1 -1 src/sys/kern/link_elf.c 1.97 +1 -1 src/sys/kern/link_elf_obj.c 1.141 +1 -1 src/sys/kern/tty_cons.c 1.29 +1 -1 src/sys/kern/uipc_mqueue.c 1.263 +2 -2 src/sys/kern/uipc_syscalls.c 1.213 +1 -1 src/sys/kern/uipc_usrreq.c 1.56 +3 -3 src/sys/kern/vfs_acl.c 1.236 +1 -1 src/sys/kern/vfs_aio.c 1.534 +1 -2 src/sys/kern/vfs_bio.c 1.117 +1 -1 src/sys/kern/vfs_cache.c 1.139 +5 -4 src/sys/kern/vfs_default.c 1.434 +4 -4 src/sys/kern/vfs_extattr.c 1.105 +11 -12 src/sys/kern/vfs_lookup.c 1.272 +10 -10 src/sys/kern/vfs_mount.c 1.715 +19 -20 src/sys/kern/vfs_subr.c 1.448 +27 -27 src/sys/kern/vfs_syscalls.c 1.258 +12 -13 src/sys/kern/vfs_vnops.c 1.88 +0 -2 src/sys/kern/vnode_if.src 1.30 +1 -1 src/sys/nfs4client/nfs4_vfsops.c 1.39 +2 -2 src/sys/nfs4client/nfs4_vnops.c 1.149 +1 -1 src/sys/nfsclient/nfs_subs.c 1.197 +2 -2 src/sys/nfsclient/nfs_vfsops.c 1.279 +2 -2 src/sys/nfsclient/nfs_vnops.c 1.177 +16 -16 src/sys/nfsserver/nfs_serv.c 1.152 +4 -5 src/sys/nfsserver/nfs_srvsubs.c 1.17 +2 -2 src/sys/security/audit/audit_arg.c 1.23 +2 -2 src/sys/security/audit/audit_syscalls.c 1.19 +7 -7 src/sys/security/audit/audit_worker.c 1.122 +2 -2 src/sys/security/mac/mac_process.c 1.135 +2 -2 src/sys/security/mac/mac_syscalls.c 1.329 +1 -1 src/sys/sys/vnode.h 1.30 +7 -7 src/sys/ufs/ffs/ffs_rawread.c 1.139 +14 -14 src/sys/ufs/ffs/ffs_snapshot.c 1.216 +2 -2 src/sys/ufs/ffs/ffs_softdep.c 1.333 +8 -8 src/sys/ufs/ffs/ffs_vfsops.c 1.176 +4 -2 src/sys/ufs/ffs/ffs_vnops.c 1.88 +16 -16 src/sys/ufs/ufs/ufs_extattr.c 1.86 +3 -4 src/sys/ufs/ufs/ufs_lookup.c 1.97 +6 -6 src/sys/ufs/ufs/ufs_quota.c 1.295 +6 -6 src/sys/ufs/ufs/ufs_vnops.c 1.300 +3 -3 src/sys/vm/swap_pager.c 1.67 +1 -1 src/sys/vm/vm_contig.c 1.390 +1 -1 src/sys/vm/vm_object.c 1.240 +1 -1 src/sys/vm/vnode_pager.c From attilio at FreeBSD.org Sun Jan 13 06:48:51 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Sun Jan 13 06:48:53 2008 Subject: cvs commit: src/sys/sys param.h Message-ID: <200801131448.m0DEmpZ3021320@repoman.freebsd.org> attilio 2008-01-13 14:48:51 UTC FreeBSD src repository Modified files: sys/sys param.h Log: Version bumping in order to reflect VOP_LOCK1(), VOP_UNLOCK() KPI changing. Revision Changes Path 1.325 +1 -1 src/sys/sys/param.h From brde at optusnet.com.au Sun Jan 13 09:44:22 2008 From: brde at optusnet.com.au (Bruce Evans) Date: Sun Jan 13 09:44:30 2008 Subject: cvs commit: src/usr.sbin/iostat iostat.c In-Reply-To: <86ve5xq142.fsf@ds4.des.no> References: <200801122037.m0CKb6CS009262@repoman.freebsd.org> <20080112205254.GB3090@VARK.MIT.EDU> <20080112235350.C10888@mp2.macomnet.net> <20080112211919.GA3408@VARK.MIT.EDU> <86ve5xq142.fsf@ds4.des.no> Message-ID: <20080114042508.X11683@besplex.bde.org> On Sun, 13 Jan 2008, [utf-8] Dag-Erling Smørgrav wrote: > David Schultz writes: >> I don't think it always does set errno, but you can set errno to 0 >> before the call, and you'll get either the real error message from >> err() or "unknown error". > > If asprintf() fails because malloc() failed, malloc() will have set > errno to ENOMEM. I can't think of any other failure mode for asprintf() > that won't either be silently ignored (error in format string) or result > in a segmentation fault (bogus argument to %s). FreeBSD vfprintf.c doesn't touch errno directly, but POSIX with XSI bugfeatures says that it sets errno to EILSEQ or EINVAL if it fails with certain errors. Also, when the printf variant is printf or fprintf, it may set errno to ENOMEM, and when it is snprintf it may set errno to EOVERFLOW for the non-error of passing a buffer size of > INT_MAX (with a buffer that large) or for the error of the the result wanting to be larger than INT_MAX. POSIX is standardizing the behaviour in the latter case and might require it to set errno (FreeBSD vfprintf.c just returns EOF). Bruce From sam at errno.com Sun Jan 13 11:01:47 2008 From: sam at errno.com (Sam Leffler) Date: Sun Jan 13 11:01:59 2008 Subject: cvs commit: src/crypto/openssl/crypto/engine eng_cryptodev.c In-Reply-To: <20080113115947.GA1135@zaphod.nitro.dk> References: <200801131144.m0DBimYT077701@repoman.freebsd.org> <20080113115947.GA1135@zaphod.nitro.dk> Message-ID: <478A601A.3060506@errno.com> Simon L. Nielsen wrote: > On 2008.01.13 11:44:47 +0000, Simon L. Nielsen wrote: > >> simon 2008-01-13 11:44:47 UTC >> >> FreeBSD src repository >> >> Modified files: >> crypto/openssl/crypto/engine eng_cryptodev.c >> Log: >> Unbreak detection of cryptodev support for FreeBSD which was broken >> with OpenSSL 0.9.8 import. >> >> Note that this does not enable cryptodev by default, as it was the >> case with OpenSSL 0.9.7 in FreeBSD base, but this change makes it >> possible to enable cryptodev at all. >> > > With this change it is possible to enable cryptodev by default for > openssl(1) with lines like below in etc/ssl/openssl.cnf. > Unfortunately openssh does not call the functions to read the config > file so it's not possible to enable cryptodev in openssh in a similar > fashion. I have yet figure out how to do support cryptodev by default > cleanly... > > Oh, and I just remembered that I forgot to thank Mike Tancsa / Sentex > for providing hardware used for testing this. So... thanks! :-) > > > > [openssl_init] > engines = engine_section > > [engine_section] > cryptodev = cryptodev_section > > [ cryptodev_section ] > engine_id = cryptodev > default_algorithms = ALL > > > (Note that the above was copied from a config file I haven't touched > in month so I'm 100% the exact section above is enough, but it's > close...) > > I gave you a patch to make cryptodev the default (if present) w/o modifying openssl.cnf. That is how things used to work in freebsd and how things work on systems like openbsd. Was there a problem w/ it? Sam From obrien at FreeBSD.org Sun Jan 13 12:35:19 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sun Jan 13 12:35:22 2008 Subject: cvs commit: src/contrib/file - Imported sources Message-ID: <200801132035.m0DKZJhV090555@repoman.freebsd.org> obrien 2008-01-13 20:35:18 UTC FreeBSD src repository src/contrib/file - Imported sources Update of /home/ncvs/src/contrib/file In directory repoman.freebsd.org:/tmp/cvs-serv90514 Log Message: Import file version 4.23 onto the vendor branch Status: Vendor Tag: ZOULAS Release Tags: file_4_23 U src/contrib/file/README U src/contrib/file/acinclude.m4 U src/contrib/file/configure.in U src/contrib/file/aclocal.m4 U src/contrib/file/Makefile.am U src/contrib/file/Makefile.in U src/contrib/file/config.h.in U src/contrib/file/configure U src/contrib/file/ChangeLog U src/contrib/file/install-sh U src/contrib/file/mkinstalldirs U src/contrib/file/LEGAL.NOTICE U src/contrib/file/MAINT U src/contrib/file/PORTING U src/contrib/file/file.c U src/contrib/file/Header U src/contrib/file/Localstuff U src/contrib/file/magic.mime U src/contrib/file/magic2mime U src/contrib/file/apprentice.c U src/contrib/file/apptype.c U src/contrib/file/ascmagic.c U src/contrib/file/compress.c U src/contrib/file/file.h N src/contrib/file/file_opts.h U src/contrib/file/fsmagic.c U src/contrib/file/funcs.c U src/contrib/file/is_tar.c U src/contrib/file/magic.c U src/contrib/file/magic.h U src/contrib/file/names.h U src/contrib/file/patchlevel.h U src/contrib/file/print.c U src/contrib/file/readelf.c U src/contrib/file/readelf.h U src/contrib/file/softmagic.c U src/contrib/file/tar.h U src/contrib/file/test.c U src/contrib/file/file.man U src/contrib/file/libmagic.man U src/contrib/file/magic.man U src/contrib/file/Magdir/acorn U src/contrib/file/Magdir/adi U src/contrib/file/Magdir/adventure U src/contrib/file/Magdir/allegro U src/contrib/file/Magdir/alliant U src/contrib/file/Magdir/alpha U src/contrib/file/Magdir/amanda U src/contrib/file/Magdir/amigaos U src/contrib/file/Magdir/animation U src/contrib/file/Magdir/apl U src/contrib/file/Magdir/apple U src/contrib/file/Magdir/applix U src/contrib/file/Magdir/archive U src/contrib/file/Magdir/asterix U src/contrib/file/Magdir/att3b U src/contrib/file/Magdir/audio U src/contrib/file/Magdir/basis U src/contrib/file/Magdir/bflt U src/contrib/file/Magdir/blender U src/contrib/file/Magdir/blit U src/contrib/file/Magdir/bout U src/contrib/file/Magdir/bsdi U src/contrib/file/Magdir/btsnoop U src/contrib/file/Magdir/cad U src/contrib/file/Magdir/cafebabe U src/contrib/file/Magdir/c-lang U src/contrib/file/Magdir/c64 U src/contrib/file/Magdir/cddb U src/contrib/file/Magdir/chord U src/contrib/file/Magdir/cisco N src/contrib/file/Magdir/efi U src/contrib/file/Magdir/citrus U src/contrib/file/Magdir/claris U src/contrib/file/Magdir/clipper U src/contrib/file/Magdir/cracklib U src/contrib/file/Magdir/spec U src/contrib/file/Magdir/commands U src/contrib/file/Magdir/communications U src/contrib/file/Magdir/compress U src/contrib/file/Magdir/console U src/contrib/file/Magdir/convex U src/contrib/file/Magdir/ctags U src/contrib/file/Magdir/dact U src/contrib/file/Magdir/database U src/contrib/file/Magdir/diamond U src/contrib/file/Magdir/diff U src/contrib/file/Magdir/digital U src/contrib/file/Magdir/dolby U src/contrib/file/Magdir/dump U src/contrib/file/Magdir/editors U src/contrib/file/Magdir/elf U src/contrib/file/Magdir/encore U src/contrib/file/Magdir/epoc U src/contrib/file/Magdir/esri U src/contrib/file/Magdir/fcs U src/contrib/file/Magdir/filesystems U src/contrib/file/Magdir/flash U src/contrib/file/Magdir/fonts N src/contrib/file/Magdir/fortran U src/contrib/file/Magdir/frame U src/contrib/file/Magdir/freebsd U src/contrib/file/Magdir/gcc U src/contrib/file/Magdir/fsav U src/contrib/file/Magdir/games U src/contrib/file/Magdir/geos U src/contrib/file/Magdir/gimp U src/contrib/file/Magdir/gnu U src/contrib/file/Magdir/grace U src/contrib/file/Magdir/gringotts U src/contrib/file/Magdir/hitachi-sh U src/contrib/file/Magdir/hp U src/contrib/file/Magdir/human68k U src/contrib/file/Magdir/ibm370 U src/contrib/file/Magdir/ibm6000 U src/contrib/file/Magdir/iff U src/contrib/file/Magdir/images U src/contrib/file/Magdir/intel U src/contrib/file/Magdir/interleaf U src/contrib/file/Magdir/island U src/contrib/file/Magdir/ispell U src/contrib/file/Magdir/java U src/contrib/file/Magdir/jpeg U src/contrib/file/Magdir/karma U src/contrib/file/Magdir/lecter U src/contrib/file/Magdir/lex U src/contrib/file/Magdir/lif U src/contrib/file/Magdir/linux U src/contrib/file/Magdir/lisp U src/contrib/file/Magdir/mach U src/contrib/file/Magdir/macintosh U src/contrib/file/Magdir/magic U src/contrib/file/Magdir/mail.news U src/contrib/file/Magdir/maple U src/contrib/file/Magdir/mup U src/contrib/file/Magdir/mathematica U src/contrib/file/Magdir/matroska U src/contrib/file/Magdir/mcrypt U src/contrib/file/Magdir/mime U src/contrib/file/Magdir/mips U src/contrib/file/Magdir/mirage U src/contrib/file/Magdir/misctools U src/contrib/file/Magdir/mkid U src/contrib/file/Magdir/mlssa U src/contrib/file/Magdir/mmdf U src/contrib/file/Magdir/modem U src/contrib/file/Magdir/motorola U src/contrib/file/Magdir/msdos U src/contrib/file/Magdir/msvc U src/contrib/file/Magdir/natinst U src/contrib/file/Magdir/ncr U src/contrib/file/Magdir/netbsd U src/contrib/file/Magdir/netscape U src/contrib/file/Magdir/news U src/contrib/file/Magdir/nitpicker U src/contrib/file/Magdir/ocaml U src/contrib/file/Magdir/octave U src/contrib/file/Magdir/olf U src/contrib/file/Magdir/os2 U src/contrib/file/Magdir/os400 U src/contrib/file/Magdir/os9 U src/contrib/file/Magdir/osf1 U src/contrib/file/Magdir/palm U src/contrib/file/Magdir/parix U src/contrib/file/Magdir/pbm U src/contrib/file/Magdir/pdf U src/contrib/file/Magdir/pdp U src/contrib/file/Magdir/perl U src/contrib/file/Magdir/pgp U src/contrib/file/Magdir/pkgadd U src/contrib/file/Magdir/plan9 U src/contrib/file/Magdir/plus5 U src/contrib/file/Magdir/printer U src/contrib/file/Magdir/project U src/contrib/file/Magdir/psdbms U src/contrib/file/Magdir/psion U src/contrib/file/Magdir/pulsar U src/contrib/file/Magdir/pyramid U src/contrib/file/Magdir/python U src/contrib/file/Magdir/revision U src/contrib/file/Magdir/riff U src/contrib/file/Magdir/rpm U src/contrib/file/Magdir/rtf U src/contrib/file/Magdir/sc U src/contrib/file/Magdir/sccs U src/contrib/file/Magdir/sendmail U src/contrib/file/Magdir/sequent U src/contrib/file/Magdir/sgi U src/contrib/file/Magdir/sgml U src/contrib/file/Magdir/sharc U src/contrib/file/Magdir/sinclair U src/contrib/file/Magdir/sketch U src/contrib/file/Magdir/smalltalk U src/contrib/file/Magdir/sniffer U src/contrib/file/Magdir/dyadic U src/contrib/file/Magdir/scientific U src/contrib/file/Magdir/softquad U src/contrib/file/Magdir/sql U src/contrib/file/Magdir/spectrum U src/contrib/file/Magdir/sun U src/contrib/file/Magdir/sysex U src/contrib/file/Magdir/teapot U src/contrib/file/Magdir/terminfo U src/contrib/file/Magdir/tex U src/contrib/file/Magdir/tgif U src/contrib/file/Magdir/ti-8x U src/contrib/file/Magdir/timezone U src/contrib/file/Magdir/troff U src/contrib/file/Magdir/tuxedo U src/contrib/file/Magdir/typeset U src/contrib/file/Magdir/unknown U src/contrib/file/Magdir/unicode U src/contrib/file/Magdir/uuencode U src/contrib/file/Magdir/varied.out U src/contrib/file/Magdir/varied.script U src/contrib/file/Magdir/vax U src/contrib/file/Magdir/vicar U src/contrib/file/Magdir/virtutech U src/contrib/file/Magdir/visx U src/contrib/file/Magdir/vms U src/contrib/file/Magdir/vmware U src/contrib/file/Magdir/vorbis U src/contrib/file/Magdir/vxl U src/contrib/file/Magdir/wordprocessors U src/contrib/file/Magdir/xdelta U src/contrib/file/Magdir/xenix U src/contrib/file/Magdir/xo65 U src/contrib/file/Magdir/xwindows U src/contrib/file/Magdir/zilog U src/contrib/file/Magdir/zyxel No conflicts created by this import From obrien at FreeBSD.org Sun Jan 13 12:37:19 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sun Jan 13 12:37:23 2008 Subject: cvs commit: src/usr.bin/file config.h src/lib/libmagic config.h Message-ID: <200801132037.m0DKbJ9R090655@repoman.freebsd.org> obrien 2008-01-13 20:37:19 UTC FreeBSD src repository Modified files: usr.bin/file config.h lib/libmagic config.h Log: Update for the 'file' 4.23 import. Revision Changes Path 1.7 +23 -4 src/lib/libmagic/config.h 1.14 +23 -4 src/usr.bin/file/config.h From dougb at FreeBSD.org Sun Jan 13 12:47:34 2008 From: dougb at FreeBSD.org (Doug Barton) Date: Sun Jan 13 12:47:39 2008 Subject: cvs commit: src/etc/namedb named.conf Message-ID: <200801132047.m0DKlYCM001301@repoman.freebsd.org> dougb 2008-01-13 20:47:34 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) etc/namedb named.conf Log: MFC the change from 1.27, removal of zones from the empty zone list that may theoretically be allocated some day. Approved by: re (kensmith) Revision Changes Path 1.26.2.1 +0 -8 src/etc/namedb/named.conf From dougb at FreeBSD.org Sun Jan 13 12:48:24 2008 From: dougb at FreeBSD.org (Doug Barton) Date: Sun Jan 13 12:48:25 2008 Subject: cvs commit: src/etc/namedb named.conf Message-ID: <200801132048.m0DKmNb2001353@repoman.freebsd.org> dougb 2008-01-13 20:48:23 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) etc/namedb named.conf Log: MFC the change from 1.27, removal of zones from the empty zone list that may theoretically be allocated some day. Approved by: re (kensmith) Revision Changes Path 1.26.4.1 +0 -8 src/etc/namedb/named.conf From dougb at FreeBSD.org Sun Jan 13 12:49:53 2008 From: dougb at FreeBSD.org (Doug Barton) Date: Sun Jan 13 12:49:56 2008 Subject: cvs commit: src/etc/namedb named.conf Message-ID: <200801132049.m0DKnqGN001409@repoman.freebsd.org> dougb 2008-01-13 20:49:52 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) etc/namedb named.conf Log: MFC the change from 1.27, removal of zones from the empty zone list that may theoretically be allocated some day. Approved by: re (kensmith) Revision Changes Path 1.21.2.7 +0 -8 src/etc/namedb/named.conf From dougb at FreeBSD.org Sun Jan 13 12:51:09 2008 From: dougb at FreeBSD.org (Doug Barton) Date: Sun Jan 13 12:51:13 2008 Subject: cvs commit: src/etc/namedb named.conf Message-ID: <200801132051.m0DKp9tF001773@repoman.freebsd.org> dougb 2008-01-13 20:51:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) etc/namedb named.conf Log: MFC the change from 1.27, removal of zones from the empty zone list that may theoretically be allocated some day. Approved by: re (kensmith) Revision Changes Path 1.21.2.6.2.1 +0 -8 src/etc/namedb/named.conf From kientzle at freebsd.org Sun Jan 13 14:26:07 2008 From: kientzle at freebsd.org (Tim Kientzle) Date: Sun Jan 13 14:26:15 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <200801080800.m08806jI012963@repoman.freebsd.org> References: <200801080800.m08806jI012963@repoman.freebsd.org> Message-ID: <478A8FFE.8080602@freebsd.org> Dag-Erling Smorgrav wrote: > Welcome unzip(1), ... can handle all but four of the 991 zip files (including > jar files) I was able to identify in the ports tree. The remaining four > are two self-extracting archives and two which have garbage preceding the > first local header. This limitation is a feature of libarchive(3) which > I am currently working to resolve. Impressive, indeed. Could you identify those four files? I want to take a look myself and see if one of the odd approaches I've been ruminating about might work. Of course, giving those four ports a build-time dependency on the Info-Zip version is arguably the right approach in any case. Tim Kientzle From kmacy at FreeBSD.org Sun Jan 13 14:32:03 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sun Jan 13 14:32:05 2008 Subject: cvs commit: src/sys/modules/cxgb/cxgb Makefile Message-ID: <200801132232.m0DMW20a026302@repoman.freebsd.org> kmacy 2008-01-13 22:32:00 UTC FreeBSD src repository Modified files: sys/modules/cxgb/cxgb Makefile Log: add cxgb_multiq.c to the build Revision Changes Path 1.4 +1 -1 src/sys/modules/cxgb/cxgb/Makefile From kmacy at FreeBSD.org Sun Jan 13 14:33:50 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sun Jan 13 14:33:54 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_sge.c Message-ID: <200801132233.m0DMXnwf026411@repoman.freebsd.org> kmacy 2008-01-13 22:33:49 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_sge.c Log: style nit Revision Changes Path 1.40 +2 -1 src/sys/dev/cxgb/cxgb_sge.c From kmacy at FreeBSD.org Sun Jan 13 14:35:13 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sun Jan 13 14:35:14 2008 Subject: cvs commit: src/sys/dev/cxgb/sys uipc_mvec.c Message-ID: <200801132235.m0DMZDqd026501@repoman.freebsd.org> kmacy 2008-01-13 22:35:13 UTC FreeBSD src repository Modified files: sys/dev/cxgb/sys uipc_mvec.c Log: remove unused code Revision Changes Path 1.19 +0 -1 src/sys/dev/cxgb/sys/uipc_mvec.c From kmacy at FreeBSD.org Sun Jan 13 14:37:10 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sun Jan 13 14:37:12 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_osdep.h Message-ID: <200801132237.m0DMb9fZ026628@repoman.freebsd.org> kmacy 2008-01-13 22:37:09 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_osdep.h Log: Add buf_ring_full utility function, make sure dequeue/enqueue see the latest indexes Revision Changes Path 1.18 +10 -2 src/sys/dev/cxgb/cxgb_osdep.h From kmacy at FreeBSD.org Sun Jan 13 14:38:18 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sun Jan 13 14:38:23 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_adapter.h cxgb_main.c cxgb_multiq.c Message-ID: <200801132238.m0DMcHEX026713@repoman.freebsd.org> kmacy 2008-01-13 22:38:17 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_adapter.h cxgb_main.c cxgb_multiq.c Log: Convert over to using the multiqueue infrastructure although all calls going through cxgb_start still end up using queue 0 Revision Changes Path 1.26 +0 -4 src/sys/dev/cxgb/cxgb_adapter.h 1.44 +1 -107 src/sys/dev/cxgb/cxgb_main.c 1.2 +92 -96 src/sys/dev/cxgb/cxgb_multiq.c From kris at FreeBSD.org Sun Jan 13 14:46:24 2008 From: kris at FreeBSD.org (Kris Kennaway) Date: Sun Jan 13 14:46:28 2008 Subject: cvs commit: src/tools/sched schedgraph.py Message-ID: <200801132246.m0DMkOl1028151@repoman.freebsd.org> kris 2008-01-13 22:46:24 UTC FreeBSD src repository Modified files: tools/sched schedgraph.py Log: * Remove KTR_CPUMASK, it is not correct to set this * Explain why 32768 entries is usually not enough * Increase the scaling ratio to 10 to deal with 32-bit overflows that can occur in calculating the canvas offsets Revision Changes Path 1.15 +3 -2 src/tools/sched/schedgraph.py From kris at FreeBSD.org Sun Jan 13 14:51:36 2008 From: kris at FreeBSD.org (Kris Kennaway) Date: Sun Jan 13 14:51:37 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <478A8FFE.8080602@freebsd.org> References: <200801080800.m08806jI012963@repoman.freebsd.org> <478A8FFE.8080602@freebsd.org> Message-ID: <478A95F2.1070709@FreeBSD.org> Tim Kientzle wrote: > Dag-Erling Smorgrav wrote: >> Welcome unzip(1), ... can handle all but four of the 991 zip files >> (including >> jar files) I was able to identify in the ports tree. The remaining >> four >> are two self-extracting archives and two which have garbage >> preceding the >> first local header. This limitation is a feature of libarchive(3) >> which >> I am currently working to resolve. > > Impressive, indeed. > > Could you identify those four files? I want to take a look > myself and see if one of the odd approaches I've been > ruminating about might work. > > Of course, giving those four ports a build-time dependency > on the Info-Zip version is arguably the right approach > in any case. That would probably be undesirable because it would mean having to special case things in the ports tree and/or duplicate code. Kris From simon at FreeBSD.org Sun Jan 13 15:37:15 2008 From: simon at FreeBSD.org (Simon L. Nielsen) Date: Sun Jan 13 15:37:20 2008 Subject: cvs commit: src/crypto/openssl/crypto/engine eng_cryptodev.c In-Reply-To: <478A601A.3060506@errno.com> References: <200801131144.m0DBimYT077701@repoman.freebsd.org> <20080113115947.GA1135@zaphod.nitro.dk> <478A601A.3060506@errno.com> Message-ID: <20080113233716.GB14893@zaphod.nitro.dk> On 2008.01.13 11:01:46 -0800, Sam Leffler wrote: > Simon L. Nielsen wrote: >> On 2008.01.13 11:44:47 +0000, Simon L. Nielsen wrote: >> >>> simon 2008-01-13 11:44:47 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> crypto/openssl/crypto/engine eng_cryptodev.c Log: >>> Unbreak detection of cryptodev support for FreeBSD which was broken >>> with OpenSSL 0.9.8 import. >>> Note that this does not enable cryptodev by default, as it was the >>> case with OpenSSL 0.9.7 in FreeBSD base, but this change makes it >>> possible to enable cryptodev at all. >>> >> >> With this change it is possible to enable cryptodev by default for >> openssl(1) with lines like below in etc/ssl/openssl.cnf. >> Unfortunately openssh does not call the functions to read the config >> file so it's not possible to enable cryptodev in openssh in a similar >> fashion. I have yet figure out how to do support cryptodev by default >> cleanly... [...] > > I gave you a patch to make cryptodev the default (if present) w/o modifying > openssl.cnf. That is how things used to work in freebsd and how things > work on systems like openbsd. Was there a problem w/ it? I'm not certain that is the correct way and that it won't have any other side-effects. I should have found some OpenSSL people to bug about this, but I haven't gotten around to doing that yet. Part of what worries me some, is that I can't find out why OpenSSL stopped just using cryptodev by default, neither in docs nor in the code. -- Simon L. Nielsen From kientzle at FreeBSD.org Sun Jan 13 15:50:30 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Sun Jan 13 15:50:32 2008 Subject: cvs commit: src/lib/libarchive archive_read_support_format_tar.c src/lib/libarchive/test test_read_format_tar.c Message-ID: <200801132350.m0DNoUL0046604@repoman.freebsd.org> kientzle 2008-01-13 23:50:30 UTC FreeBSD src repository Modified files: lib/libarchive archive_read_support_format_tar.c lib/libarchive/test test_read_format_tar.c Log: Since the tar bidder can never get called more than once, it doesn't need to compensate for this situation. While here, fix a minor longstanding bug that empty tar archives (which begin with at least 512 zero bytes) never properly reported their format. In particular, this fixes the output of: bsdtar tvvf /dev/zero And, of course, a new test to verify that libarchive correctly recognizes the format of such files. Revision Changes Path 1.64 +12 -23 src/lib/libarchive/archive_read_support_format_tar.c 1.3 +47 -0 src/lib/libarchive/test/test_read_format_tar.c From sam at errno.com Sun Jan 13 16:05:41 2008 From: sam at errno.com (Sam Leffler) Date: Sun Jan 13 16:05:44 2008 Subject: cvs commit: src/crypto/openssl/crypto/engine eng_cryptodev.c In-Reply-To: <20080113233716.GB14893@zaphod.nitro.dk> References: <200801131144.m0DBimYT077701@repoman.freebsd.org> <20080113115947.GA1135@zaphod.nitro.dk> <478A601A.3060506@errno.com> <20080113233716.GB14893@zaphod.nitro.dk> Message-ID: <478AA753.8090106@errno.com> Simon L. Nielsen wrote: > On 2008.01.13 11:01:46 -0800, Sam Leffler wrote: > >> Simon L. Nielsen wrote: >> >>> On 2008.01.13 11:44:47 +0000, Simon L. Nielsen wrote: >>> >>> >>>> simon 2008-01-13 11:44:47 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> crypto/openssl/crypto/engine eng_cryptodev.c Log: >>>> Unbreak detection of cryptodev support for FreeBSD which was broken >>>> with OpenSSL 0.9.8 import. >>>> Note that this does not enable cryptodev by default, as it was the >>>> case with OpenSSL 0.9.7 in FreeBSD base, but this change makes it >>>> possible to enable cryptodev at all. >>>> >>>> >>> With this change it is possible to enable cryptodev by default for >>> openssl(1) with lines like below in etc/ssl/openssl.cnf. >>> Unfortunately openssh does not call the functions to read the config >>> file so it's not possible to enable cryptodev in openssh in a similar >>> fashion. I have yet figure out how to do support cryptodev by default >>> cleanly... >>> > [...] > >> I gave you a patch to make cryptodev the default (if present) w/o modifying >> openssl.cnf. That is how things used to work in freebsd and how things >> work on systems like openbsd. Was there a problem w/ it? >> > > I'm not certain that is the correct way and that it won't have any > other side-effects. I should have found some OpenSSL people to bug > about this, but I haven't gotten around to doing that yet. > Ok, I thought you were going to do that before this commit; hence my question. > Part of what worries me some, is that I can't find out why OpenSSL > stopped just using cryptodev by default, neither in docs nor in the > code. > I would expect openssl folks had no clue they broke it because openbsd doesn't track their code (in this area at least). The only worry I have about my change is if it makes it impossible to override it's use (e.g. via openssl.cnf). If you can override the default then I can see nothing wrong w/ the change and it will "fix ssh". Sam From tim at kientzle.com Sun Jan 13 16:52:47 2008 From: tim at kientzle.com (Tim Kientzle) Date: Sun Jan 13 16:52:52 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <478A95F2.1070709@FreeBSD.org> References: <200801080800.m08806jI012963@repoman.freebsd.org> <478A8FFE.8080602@freebsd.org> <478A95F2.1070709@FreeBSD.org> Message-ID: <478AA9E4.2010807@kientzle.com> >> Of course, giving those four ports a build-time dependency >> on the Info-Zip version is arguably the right approach >> in any case. > > That would probably be undesirable because it would mean having to > special case things in the ports tree and/or duplicate code. I'm confused. How is it different from having a build-time dependency on GNU tar? I thought I remembered a few cases where ports installed GNU tar (as a build dependency) and then extracted with GNU tar. This case would seem no different. But I'm far less familiar with the details than you are, so I'll happily bow to your expertise in the matter. Tim Kientzle From kmacy at FreeBSD.org Sun Jan 13 16:59:34 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sun Jan 13 16:59:36 2008 Subject: cvs commit: src/sys/conf files Message-ID: <200801140059.m0E0xYkX066417@repoman.freebsd.org> kmacy 2008-01-14 00:59:33 UTC FreeBSD src repository Modified files: sys/conf files Log: Add cxgb_multiq.c to the cxgb build for static linking Revision Changes Path 1.1263 +1 -0 src/sys/conf/files From kris at FreeBSD.org Sun Jan 13 17:35:12 2008 From: kris at FreeBSD.org (Kris Kennaway) Date: Sun Jan 13 17:35:16 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <478AA9E4.2010807@kientzle.com> References: <200801080800.m08806jI012963@repoman.freebsd.org> <478A8FFE.8080602@freebsd.org> <478A95F2.1070709@FreeBSD.org> <478AA9E4.2010807@kientzle.com> Message-ID: <478ABC4B.8080601@FreeBSD.org> Tim Kientzle wrote: >>> Of course, giving those four ports a build-time dependency >>> on the Info-Zip version is arguably the right approach >>> in any case. >> >> That would probably be undesirable because it would mean having to >> special case things in the ports tree and/or duplicate code. > > I'm confused. How is it different from having > a build-time dependency on GNU tar? I thought > I remembered a few cases where ports installed > GNU tar (as a build dependency) and then extracted > with GNU tar. > > This case would seem no different. But I'm far > less familiar with the details than you are, so > I'll happily bow to your expertise in the matter. > > Tim Kientzle These ports currently obtain the unzip port dependency by setting USE_ZIP, and then everything just works, i.e. there is logic in bsd.port.mk to handle things like distfile extraction. If we have to special case ports to deal with variant zipfiles that cannot be processed by /usr/bin/unzip then it gets messier because we have to account for some ports being satisfied with USE_ZIP=yes meaning /usr/bin/unzip and some still requiring /usr/ports/archivers/unzip. I'd prefer not to have to add those workarounds. Kris From das at FreeBSD.org Sun Jan 13 18:12:08 2008 From: das at FreeBSD.org (David Schultz) Date: Sun Jan 13 18:12:10 2008 Subject: cvs commit: src/lib/msun/src math.h s_llrintl.c s_lrintl.c s_nearbyint.c s_rint.c s_rintl.c src/lib/msun Makefile Symbol.map src/lib/msun/man lrint.3 rint.3 src/lib/msun/amd64 Makefile.inc s_llrintl.S s_lrintl.S s_rintl.S src/lib/msun/i387 Makefile.inc ... Message-ID: <200801140212.m0E2C7WI087665@repoman.freebsd.org> das 2008-01-14 02:12:07 UTC FreeBSD src repository Modified files: lib/msun/src s_rint.c s_nearbyint.c math.h lib/msun Makefile Symbol.map lib/msun/man lrint.3 rint.3 lib/msun/amd64 Makefile.inc lib/msun/i387 Makefile.inc Added files: lib/msun/src s_rintl.c s_llrintl.c s_lrintl.c lib/msun/amd64 s_llrintl.S s_lrintl.S s_rintl.S lib/msun/i387 s_llrintl.S s_lrintl.S s_rintl.S Log: Implement rintl(), nearbyintl(), lrintl(), and llrintl(). Thanks to bde@ for feedback and testing of rintl(). Revision Changes Path 1.85 +6 -4 src/lib/msun/Makefile 1.11 +4 -0 src/lib/msun/Symbol.map 1.7 +3 -3 src/lib/msun/amd64/Makefile.inc 1.1 +35 -0 src/lib/msun/amd64/s_llrintl.S (new) 1.1 +35 -0 src/lib/msun/amd64/s_lrintl.S (new) 1.1 +43 -0 src/lib/msun/amd64/s_rintl.S (new) 1.11 +2 -1 src/lib/msun/i387/Makefile.inc 1.1 +36 -0 src/lib/msun/i387/s_llrintl.S (new) 1.1 +35 -0 src/lib/msun/i387/s_lrintl.S (new) 1.1 +43 -0 src/lib/msun/i387/s_rintl.S (new) 1.3 +17 -7 src/lib/msun/man/lrint.3 1.13 +19 -15 src/lib/msun/man/rint.3 1.66 +3 -5 src/lib/msun/src/math.h 1.1 +9 -0 src/lib/msun/src/s_llrintl.c (new) 1.1 +9 -0 src/lib/msun/src/s_lrintl.c (new) 1.2 +1 -0 src/lib/msun/src/s_nearbyint.c 1.14 +6 -0 src/lib/msun/src/s_rint.c 1.1 +77 -0 src/lib/msun/src/s_rintl.c (new) From das at FreeBSD.org Sun Jan 13 18:18:01 2008 From: das at FreeBSD.org (David Schultz) Date: Sun Jan 13 18:18:05 2008 Subject: cvs commit: src/tools/regression/lib/msun test-lrint.c Message-ID: <200801140218.m0E2I0Bk088479@repoman.freebsd.org> das 2008-01-14 02:18:00 UTC FreeBSD src repository Modified files: tools/regression/lib/msun test-lrint.c Log: Tests for lrintl() and llrintl(). I didn't add anything specially tailored for the long double format; instead, I just modified the existing tests to test lrintl() and llrintl() as well. Revision Changes Path 1.2 +22 -5 src/tools/regression/lib/msun/test-lrint.c From kmacy at FreeBSD.org Sun Jan 13 21:56:04 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sun Jan 13 21:56:06 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_osdep.h Message-ID: <200801140556.m0E5u4Jc046415@repoman.freebsd.org> kmacy 2008-01-14 05:56:03 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_osdep.h Log: Add extensive sanity checking to buf_ring Revision Changes Path 1.19 +50 -7 src/sys/dev/cxgb/cxgb_osdep.h From kmacy at FreeBSD.org Sun Jan 13 21:59:07 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sun Jan 13 21:59:10 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_main.c Message-ID: <200801140559.m0E5x65U046509@repoman.freebsd.org> kmacy 2008-01-14 05:59:06 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_main.c Log: Make back pressure visible more quickly, particularly now that we maintain a queue internally Revision Changes Path 1.45 +1 -1 src/sys/dev/cxgb/cxgb_main.c From kmacy at FreeBSD.org Sun Jan 13 22:00:42 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sun Jan 13 22:00:43 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_multiq.c Message-ID: <200801140600.m0E60gxY046847@repoman.freebsd.org> kmacy 2008-01-14 06:00:42 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_multiq.c Log: - Add more extensive sanity checks - remove initial dequeue from cxgb_start as it was causing an mbuf to be referenced twice Revision Changes Path 1.3 +22 -15 src/sys/dev/cxgb/cxgb_multiq.c From jkoshy at FreeBSD.org Sun Jan 13 22:33:42 2008 From: jkoshy at FreeBSD.org (Joseph Koshy) Date: Sun Jan 13 22:33:44 2008 Subject: cvs commit: src/sys/sys pmc.h Message-ID: <200801140633.m0E6XfS8053816@repoman.freebsd.org> jkoshy 2008-01-14 06:33:41 UTC FreeBSD src repository Modified files: sys/sys pmc.h Log: Increment major version to mark the ABI change between RELENG_7 and -HEAD. Revision Changes Path 1.14 +1 -1 src/sys/sys/pmc.h From yongari at FreeBSD.org Sun Jan 13 23:16:49 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Sun Jan 13 23:16:51 2008 Subject: cvs commit: src/sys/dev/stge if_stge.c if_stgereg.h Message-ID: <200801140716.m0E7GmTr060948@repoman.freebsd.org> yongari 2008-01-14 07:16:48 UTC FreeBSD src repository Modified files: sys/dev/stge if_stge.c if_stgereg.h Log: Implement WOL capability. - Turn on WOL bits in suspend/shutdown method. - WOL is disabled in resume routine as WOL can interfere normal Rx operation. - Move stge_reset() to stge_init_locked() as resetting hardware clears configured Rx information which in turn results in non-working Rx module after suspend/shutdown operation. Revision Changes Path 1.11 +46 -11 src/sys/dev/stge/if_stge.c 1.4 +8 -0 src/sys/dev/stge/if_stgereg.h From kmacy at FreeBSD.org Sun Jan 13 23:55:57 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sun Jan 13 23:55:58 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_multiq.c Message-ID: <200801140755.m0E7tuo0066833@repoman.freebsd.org> kmacy 2008-01-14 07:55:56 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_multiq.c Log: - Assert that immpkt is not set - convert %lx to 32-bit safe %jx Revision Changes Path 1.4 +4 -2 src/sys/dev/cxgb/cxgb_multiq.c From das at FreeBSD.org Mon Jan 14 01:21:34 2008 From: das at FreeBSD.org (David Schultz) Date: Mon Jan 14 01:21:36 2008 Subject: cvs commit: src/lib/libc/stdlib qsort.c Message-ID: <200801140921.m0E9LYak090695@repoman.freebsd.org> das 2008-01-14 09:21:34 UTC FreeBSD src repository Modified files: lib/libc/stdlib qsort.c Log: Changing 'r' to a size_t in the previous commit turned quicksort into slowsort for some sequences because different parts of the code used 'r' to store two different things, one of which was signed. Clean things up by splitting 'r' into two variables, and use a more meaningful name. Revision Changes Path 1.15 +5 -4 src/lib/libc/stdlib/qsort.c From hrs at FreeBSD.org Mon Jan 14 01:47:24 2008 From: hrs at FreeBSD.org (Hiroki Sato) Date: Mon Jan 14 01:47:29 2008 Subject: cvs commit: src/release/doc/share/sgml release.ent Message-ID: <200801140947.m0E9lOjS094599@repoman.freebsd.org> hrs 2008-01-14 09:47:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) release/doc/share/sgml release.ent Log: Bump &release.*; for 6.3R. Approved by: re (implicitly) Revision Changes Path 1.24.2.6.2.3 +4 -4 src/release/doc/share/sgml/release.ent From hrs at FreeBSD.org Mon Jan 14 01:58:56 2008 From: hrs at FreeBSD.org (Hiroki Sato) Date: Mon Jan 14 01:58:58 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/share/sgml release.dsl src/release/doc/share/sgml release.ent Message-ID: <200801140958.m0E9wtdo096943@repoman.freebsd.org> hrs 2008-01-14 09:58:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) release/doc/en_US.ISO8859-1/share/sgml release.dsl release/doc/share/sgml release.ent Log: Update page footer for release. Approved by: re (implicitly) Revision Changes Path 1.8.4.1.6.1 +0 -11 src/release/doc/en_US.ISO8859-1/share/sgml/release.dsl 1.24.2.6.2.4 +2 -2 src/release/doc/share/sgml/release.ent From kensmith at FreeBSD.org Mon Jan 14 09:28:37 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Mon Jan 14 09:28:41 2008 Subject: cvs commit: src/release/scripts package-split.py Message-ID: <200801141728.m0EHSaY6096391@repoman.freebsd.org> kensmith 2008-01-14 17:28:36 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) release/scripts package-split.py Log: Add the various packages we've ejected from the CD sets through recent years back on disc3. Approved by: re (hrs) Revision Changes Path 1.16.2.3 +12 -0 src/release/scripts/package-split.py From kensmith at FreeBSD.org Mon Jan 14 09:31:35 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Mon Jan 14 09:31:37 2008 Subject: cvs commit: src/release/scripts package-split.py Message-ID: <200801141731.m0EHVZMA098118@repoman.freebsd.org> kensmith 2008-01-14 17:31:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) release/scripts package-split.py Log: MFRELENG_7 v1.16.2.3 > Add the various packages we've ejected from the CD sets through > recent years back on disc3. Approved by: re (hrs) Revision Changes Path 1.16.2.2.2.1 +12 -0 src/release/scripts/package-split.py From kensmith at FreeBSD.org Mon Jan 14 09:41:10 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Mon Jan 14 09:41:12 2008 Subject: cvs commit: src/release/scripts package-split.py Message-ID: <200801141741.m0EHf9w3099540@repoman.freebsd.org> kensmith 2008-01-14 17:41:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/scripts package-split.py Log: Add the various packages we've ejected from the CD sets through recent years back on disc3. Revision Changes Path 1.6.2.11 +11 -0 src/release/scripts/package-split.py From kensmith at FreeBSD.org Mon Jan 14 09:42:15 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Mon Jan 14 09:42:16 2008 Subject: cvs commit: src/release/scripts package-split.py Message-ID: <200801141742.m0EHg9U8099946@repoman.freebsd.org> kensmith 2008-01-14 17:42:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) release/scripts package-split.py Log: MFRELENG_6 v1.6.2.11 > Add the various packages we've ejected from the CD sets through > recent years back on disc3. Approved by: re (hrs) Revision Changes Path 1.6.2.9.2.2 +11 -0 src/release/scripts/package-split.py From obrien at FreeBSD.org Mon Jan 14 10:11:55 2008 From: obrien at FreeBSD.org (David O'Brien) Date: Mon Jan 14 10:11:59 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <478ABC4B.8080601@FreeBSD.org> References: <200801080800.m08806jI012963@repoman.freebsd.org> <478A8FFE.8080602@freebsd.org> <478A95F2.1070709@FreeBSD.org> <478AA9E4.2010807@kientzle.com> <478ABC4B.8080601@FreeBSD.org> Message-ID: <20080114181154.GA2286@dragon.NUXI.org> On Mon, Jan 14, 2008 at 02:35:07AM +0100, Kris Kennaway wrote: > Tim Kientzle wrote: >>>> Of course, giving those four ports a build-time dependency >>>> on the Info-Zip version is arguably the right approach >>>> in any case. >>> >>> That would probably be undesirable because it would mean having to >>> special case things in the ports tree and/or duplicate code. >> I'm confused. How is it different from having >> a build-time dependency on GNU tar? I thought >> I remembered a few cases where ports installed >> GNU tar (as a build dependency) and then extracted >> with GNU tar. >> This case would seem no different. But I'm far >> less familiar with the details than you are, so >> I'll happily bow to your expertise in the matter. >> Tim Kientzle > > These ports currently obtain the unzip port dependency by setting USE_ZIP, > and then everything just works, i.e. there is logic in bsd.port.mk to > handle things like distfile extraction. > > If we have to special case ports to deal with variant zipfiles that cannot > be processed by /usr/bin/unzip then it gets messier because we have to > account for some ports being satisfied with USE_ZIP=yes meaning > /usr/bin/unzip and some still requiring /usr/ports/archivers/unzip. I'd > prefer not to have to add those workarounds. This seems quite easy... For those four-ish ports 's/USE_ZIP/USE_INFOZIP/' Index: bsd.commands.mk =================================================================== RCS file: /home/ncvs/ports/Mk/bsd.commands.mk,v retrieving revision 1.1 diff -u -p -r1.1 bsd.commands.mk --- bsd.commands.mk 4 Aug 2007 11:37:23 -0000 1.1 +++ bsd.commands.mk 14 Jan 2008 18:08:05 -0000 @@ -83,7 +83,11 @@ TR?= LANG=C /usr/bin/tr TRUE?= true # Shell builtin UMOUNT?= /sbin/umount UNAME?= /usr/bin/uname +.if defined(USE_INFOZIP) UNZIP_CMD?= ${LOCALBASE}/bin/unzip +.else +UNZIP_CMD?= /usr/bin/unzip +.endif WHICH?= /usr/bin/which XARGS?= /usr/bin/xargs YACC?= /usr/bin/yacc Index: bsd.port.mk =================================================================== RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v retrieving revision 1.589 diff -u -p -r1.589 bsd.port.mk --- bsd.port.mk 17 Oct 2007 10:12:24 -0000 1.589 +++ bsd.port.mk 14 Jan 2008 18:08:55 -0000 @@ -1339,6 +1345,10 @@ X_WINDOW_SYSTEM ?= xfree86-4 . endif .endif +.if defined(USE_INFOZIP) +USE_ZIP= yes +.endif + .if defined(USE_BZIP2) EXTRACT_SUFX?= .tar.bz2 .elif defined(USE_ZIP) @@ -1657,7 +1669,7 @@ LIB32DIR= lib .endif PLIST_SUB+= LIB32DIR=${LIB32DIR} -.if defined(USE_ZIP) +.if defined(USE_INFOZIP) EXTRACT_DEPENDS+= unzip:${PORTSDIR}/archivers/unzip .endif .if defined(USE_MAKESELF) From bmah at freebsd.org Mon Jan 14 10:34:35 2008 From: bmah at freebsd.org (Bruce A. Mah) Date: Mon Jan 14 10:35:39 2008 Subject: cvs commit: src/release/doc/share/sgml release.ent In-Reply-To: <200801140947.m0E9lOjS094599@repoman.freebsd.org> References: <200801140947.m0E9lOjS094599@repoman.freebsd.org> Message-ID: <478BAB39.3030400@freebsd.org> If memory serves me right, Hiroki Sato wrote: > hrs 2008-01-14 09:47:24 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6_3) > release/doc/share/sgml release.ent > Log: > Bump &release.*; for 6.3R. > > Approved by: re (implicitly) > > Revision Changes Path > 1.24.2.6.2.3 +4 -4 src/release/doc/share/sgml/release.ent @@ -36,9 +36,9 @@ - - - + + + Hrm. When I looked briefly on www.freebsd.org, we didn't have manpage sets for XFree86 4.6.0, X.org 7.3, or NetBSD 4.0 available via man.cgi. Did I miss something? Thanks, Bruce. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 249 bytes Desc: OpenPGP digital signature Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080114/1b21379d/signature.pgp From hrs at FreeBSD.org Mon Jan 14 10:47:46 2008 From: hrs at FreeBSD.org (Hiroki Sato) Date: Mon Jan 14 10:47:50 2008 Subject: cvs commit: src/release/doc/share/sgml release.ent In-Reply-To: <478BAB39.3030400@freebsd.org> References: <200801140947.m0E9lOjS094599@repoman.freebsd.org> <478BAB39.3030400@freebsd.org> Message-ID: <20080115.034621.44748251.hrs@allbsd.org> "Bruce A. Mah" wrote in <478BAB39.3030400@freebsd.org>: bm> If memory serves me right, Hiroki Sato wrote: bm> > hrs 2008-01-14 09:47:24 UTC bm> > bm> > FreeBSD src repository bm> > bm> > Modified files: (Branch: RELENG_6_3) bm> > release/doc/share/sgml release.ent bm> > Log: bm> > Bump &release.*; for 6.3R. bm> > bm> > Approved by: re (implicitly) bm> > bm> > Revision Changes Path bm> > 1.24.2.6.2.3 +4 -4 src/release/doc/share/sgml/release.ent bm> bm> @@ -36,9 +36,9 @@ bm> bm> bm> bm> - bm> - bm> - bm> + bm> + bm> + bm> bm> bm> bm> Hrm. When I looked briefly on www.freebsd.org, we didn't have manpage bm> sets for XFree86 4.6.0, X.org 7.3, or NetBSD 4.0 available via man.cgi. bm> Did I miss something? Right. I will upload them. -- | Hiroki SATO -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080114/20dc7d51/attachment.pgp From kensmith at FreeBSD.org Mon Jan 14 11:28:10 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Mon Jan 14 11:28:12 2008 Subject: cvs commit: src/usr.sbin/sysinstall dist.c dist.h menus.c sysinstall.h Message-ID: <200801141928.m0EJS9ct019941@repoman.freebsd.org> kensmith 2008-01-14 19:28:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.sbin/sysinstall dist.c dist.h menus.c sysinstall.h Log: MFC: dist.c v1.254, dist.h v1.72, menus.c v1.429, sysinstall.h v1.275 > Change sysinstall's handling of X11 stuff. Doing it in pieces was > probably the right thing to do a while ago but xorg has progressed > to the point that for novice users (who are the ones expected to think > installing X11 during an install...) it's best to just install the > whole x11/xorg metaport for them. This removes the X11 sub-menus > and sets it up so you just select whether or not you want X11. While > here garbage collect an X11 configuration menu I missed removing when > I removed support for attempting xorg configuration from inside sysinstall > a while ago. Approved by: re (hrs) Revision Changes Path 1.249.2.5 +3 -37 src/usr.sbin/sysinstall/dist.c 1.67.2.5 +1 -27 src/usr.sbin/sysinstall/dist.h 1.425.2.4 +1 -196 src/usr.sbin/sysinstall/menus.c 1.274.2.1 +0 -8 src/usr.sbin/sysinstall/sysinstall.h From kensmith at FreeBSD.org Mon Jan 14 11:28:43 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Mon Jan 14 11:28:45 2008 Subject: cvs commit: src/usr.sbin/sysinstall dist.c dist.h menus.c sysinstall.h Message-ID: <200801141928.m0EJSh1h019980@repoman.freebsd.org> kensmith 2008-01-14 19:28:43 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) usr.sbin/sysinstall dist.c dist.h menus.c sysinstall.h Log: MFC: dist.c v1.254, dist.h v1.72, menus.c v1.429, sysinstall.h v1.275 > Change sysinstall's handling of X11 stuff. Doing it in pieces was > probably the right thing to do a while ago but xorg has progressed > to the point that for novice users (who are the ones expected to think > installing X11 during an install...) it's best to just install the > whole x11/xorg metaport for them. This removes the X11 sub-menus > and sets it up so you just select whether or not you want X11. While > here garbage collect an X11 configuration menu I missed removing when > I removed support for attempting xorg configuration from inside sysinstall > a while ago. Approved by: re (hrs) Revision Changes Path 1.249.2.4.2.1 +3 -37 src/usr.sbin/sysinstall/dist.c 1.67.2.4.2.1 +1 -27 src/usr.sbin/sysinstall/dist.h 1.425.2.3.2.1 +1 -196 src/usr.sbin/sysinstall/menus.c 1.274.4.1 +0 -8 src/usr.sbin/sysinstall/sysinstall.h From kris at FreeBSD.org Mon Jan 14 12:26:07 2008 From: kris at FreeBSD.org (Kris Kennaway) Date: Mon Jan 14 12:26:08 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <20080114181154.GA2286@dragon.NUXI.org> References: <200801080800.m08806jI012963@repoman.freebsd.org> <478A8FFE.8080602@freebsd.org> <478A95F2.1070709@FreeBSD.org> <478AA9E4.2010807@kientzle.com> <478ABC4B.8080601@FreeBSD.org> <20080114181154.GA2286@dragon.NUXI.org> Message-ID: <478BC55B.2060202@FreeBSD.org> David O'Brien wrote: >> If we have to special case ports to deal with variant zipfiles that cannot >> be processed by /usr/bin/unzip then it gets messier because we have to >> account for some ports being satisfied with USE_ZIP=yes meaning >> /usr/bin/unzip and some still requiring /usr/ports/archivers/unzip. I'd >> prefer not to have to add those workarounds. > > This seems quite easy... > > For those four-ish ports 's/USE_ZIP/USE_INFOZIP/' That's what I meant by "special case". I don't like adding special case variables to bsd.*.mk for the benefit of a tiny number of ports; that file is already cluttered enough. Kris From alc at FreeBSD.org Mon Jan 14 13:25:07 2008 From: alc at FreeBSD.org (Alan Cox) Date: Mon Jan 14 13:25:09 2008 Subject: cvs commit: src/sys/amd64/amd64 pmap.c Message-ID: <200801142125.m0ELP6hX050969@repoman.freebsd.org> alc 2008-01-14 21:25:06 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c Log: Make pmap_is_prefaultable() more TLB friendly. Specifically, make it use the kernel's direct map instead of the pmap's recursive mapping to access the lowest level in the page table. The direct map is preferable for two reasons: (1) The TLB is more likely to hold the required direct mapping because pmap_enter() has already used the direct map to access a nearby PTE and (2) loading a direct mapping into the TLB involves walking only 2 or 3 levels of the page table instead of 4. Revision Changes Path 1.604 +1 -1 src/sys/amd64/amd64/pmap.c From brueffer at FreeBSD.org Mon Jan 14 13:45:03 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Mon Jan 14 13:45:05 2008 Subject: cvs commit: src/share/man/man4 wpi.4 Message-ID: <200801142145.m0ELj3a9053955@repoman.freebsd.org> brueffer 2008-01-14 21:45:02 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man4 wpi.4 Log: Remove a dublicate complete copy of the manpage. No MFC as the version in HEAD is ok. Submitted by: pluknet Approved by: re (hrs) Revision Changes Path 1.3.2.2 +0 -151 src/share/man/man4/wpi.4 From brueffer at FreeBSD.org Mon Jan 14 13:50:07 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Mon Jan 14 13:50:11 2008 Subject: cvs commit: src/share/man/man4 wpi.4 Message-ID: <200801142150.m0ELo6w1054215@repoman.freebsd.org> brueffer 2008-01-14 21:50:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) share/man/man4 wpi.4 Log: Remove a dublicate complete copy of the manpage. No MFC as the version in HEAD is ok. Submitted by: pluknet Approved by: re (hrs) Revision Changes Path 1.3.2.1.2.1 +0 -151 src/share/man/man4/wpi.4 From jhb at freebsd.org Mon Jan 14 13:58:28 2008 From: jhb at freebsd.org (John Baldwin) Date: Mon Jan 14 13:58:37 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <478BC55B.2060202@FreeBSD.org> References: <200801080800.m08806jI012963@repoman.freebsd.org> <20080114181154.GA2286@dragon.NUXI.org> <478BC55B.2060202@FreeBSD.org> Message-ID: <200801141554.52748.jhb@freebsd.org> On Monday 14 January 2008 03:26:03 pm Kris Kennaway wrote: > David O'Brien wrote: > > >> If we have to special case ports to deal with variant zipfiles that cannot > >> be processed by /usr/bin/unzip then it gets messier because we have to > >> account for some ports being satisfied with USE_ZIP=yes meaning > >> /usr/bin/unzip and some still requiring /usr/ports/archivers/unzip. I'd > >> prefer not to have to add those workarounds. > > > > This seems quite easy... > > > > For those four-ish ports 's/USE_ZIP/USE_INFOZIP/' > > That's what I meant by "special case". I don't like adding special case > variables to bsd.*.mk for the benefit of a tiny number of ports; that > file is already cluttered enough. Also, if there are ports distfiles that unzip doesn't handle then there are likely other zip files in the wild that users may run into that it won't handle either. In that case, I think the ports distfiles are a good canary for seeing if unzip is suitable for widespread use. -- John Baldwin From das at FreeBSD.ORG Mon Jan 14 14:32:55 2008 From: das at FreeBSD.ORG (David Schultz) Date: Mon Jan 14 14:33:03 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <478BC55B.2060202@FreeBSD.org> References: <200801080800.m08806jI012963@repoman.freebsd.org> <478A8FFE.8080602@freebsd.org> <478A95F2.1070709@FreeBSD.org> <478AA9E4.2010807@kientzle.com> <478ABC4B.8080601@FreeBSD.org> <20080114181154.GA2286@dragon.NUXI.org> <478BC55B.2060202@FreeBSD.org> Message-ID: <20080114223239.GC56062@VARK.MIT.EDU> On Mon, Jan 14, 2008, Kris Kennaway wrote: > David O'Brien wrote: > > >>If we have to special case ports to deal with variant zipfiles that > >>cannot be processed by /usr/bin/unzip then it gets messier because we > >>have to account for some ports being satisfied with USE_ZIP=yes meaning > >>/usr/bin/unzip and some still requiring /usr/ports/archivers/unzip. I'd > >>prefer not to have to add those workarounds. > > > >This seems quite easy... > > > >For those four-ish ports 's/USE_ZIP/USE_INFOZIP/' > > That's what I meant by "special case". I don't like adding special case > variables to bsd.*.mk for the benefit of a tiny number of ports; that > file is already cluttered enough. Given how little time it took Tim to get libarchive from a simple prototype that supported tar files to a 23k line library that supports dozens of variant archive formats, I suspect that the limitation and the corresponding hack will be temporary. :) And if it is just a small number of ports, it could be set up as an extract dependency in the individual port makefiles, right? It's not as though InfoZIP is going to change a lot in the near future. From kris at FreeBSD.org Mon Jan 14 14:46:45 2008 From: kris at FreeBSD.org (Kris Kennaway) Date: Mon Jan 14 14:46:50 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <20080114223239.GC56062@VARK.MIT.EDU> References: <200801080800.m08806jI012963@repoman.freebsd.org> <478A8FFE.8080602@freebsd.org> <478A95F2.1070709@FreeBSD.org> <478AA9E4.2010807@kientzle.com> <478ABC4B.8080601@FreeBSD.org> <20080114181154.GA2286@dragon.NUXI.org> <478BC55B.2060202@FreeBSD.org> <20080114223239.GC56062@VARK.MIT.EDU> Message-ID: <478BE651.1020901@FreeBSD.org> David Schultz wrote: > On Mon, Jan 14, 2008, Kris Kennaway wrote: >> David O'Brien wrote: >> >>>> If we have to special case ports to deal with variant zipfiles that >>>> cannot be processed by /usr/bin/unzip then it gets messier because we >>>> have to account for some ports being satisfied with USE_ZIP=yes meaning >>>> /usr/bin/unzip and some still requiring /usr/ports/archivers/unzip. I'd >>>> prefer not to have to add those workarounds. >>> This seems quite easy... >>> >>> For those four-ish ports 's/USE_ZIP/USE_INFOZIP/' >> That's what I meant by "special case". I don't like adding special case >> variables to bsd.*.mk for the benefit of a tiny number of ports; that >> file is already cluttered enough. > > Given how little time it took Tim to get libarchive from a simple > prototype that supported tar files to a 23k line library that > supports dozens of variant archive formats, I suspect that the > limitation and the corresponding hack will be temporary. :) And if > it is just a small number of ports, it could be set up as an > extract dependency in the individual port makefiles, right? It's > not as though InfoZIP is going to change a lot in the near future. > > No, you'd have to duplicate the do-extract code (or add a special variable for those 4 ports). I'd much rather wait to see what Tim and Dag-Erling can come up with. Kris From peter at FreeBSD.org Mon Jan 14 14:51:45 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Mon Jan 14 14:51:46 2008 Subject: cvs commit: src/sys/i386/i386 pmap.c Message-ID: <200801142251.m0EMpi8h065602@repoman.freebsd.org> peter 2008-01-14 22:51:44 UTC FreeBSD src repository Modified files: sys/i386/i386 pmap.c Log: Add a CTASSERT that KERNBASE is valid. This is usually messed up by an invalid KVA_PAGES, so add a pointer to there. Revision Changes Path 1.607 +7 -0 src/sys/i386/i386/pmap.c From peter at FreeBSD.org Mon Jan 14 14:53:02 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Mon Jan 14 14:53:03 2008 Subject: cvs commit: src/sys/i386/include pmap.h Message-ID: <200801142253.m0EMr195065962@repoman.freebsd.org> peter 2008-01-14 22:53:01 UTC FreeBSD src repository Modified files: sys/i386/include pmap.h Log: Update the KVA_PAGES comments for the effect that PAE has on it. It becomes a unit size of 2MB instead of 4MB and must be a multiple of 8 to get a valid KERNBASE. Revision Changes Path 1.131 +2 -0 src/sys/i386/include/pmap.h From cperciva at FreeBSD.org Mon Jan 14 14:55:21 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Mon Jan 14 14:55:27 2008 Subject: cvs commit: src/lib/libc/inet inet_network.c src/lib/libc/stdlib grantpt.c src/lib/libutil pty.c Message-ID: <200801142255.m0EMtK7x066176@repoman.freebsd.org> cperciva 2008-01-14 22:55:20 UTC FreeBSD src repository Modified files: lib/libc/inet inet_network.c lib/libc/stdlib grantpt.c lib/libutil pty.c Log: Fix issues which allow snooping on ptys. [08:01] Fix an off-by-one error in inet_network(3). [08:02] Security: FreeBSD-SA-08:01.pty Security: FreeBSD-SA-08:02.libc Revision Changes Path 1.5 +2 -2 src/lib/libc/inet/inet_network.c 1.10 +35 -46 src/lib/libc/stdlib/grantpt.c 1.20 +3 -55 src/lib/libutil/pty.c From cperciva at FreeBSD.org Mon Jan 14 14:55:54 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Mon Jan 14 14:55:59 2008 Subject: cvs commit: src UPDATING src/lib/libc/inet inet_network.c src/lib/libc/stdlib grantpt.c src/lib/libutil pty.c Message-ID: <200801142255.m0EMtsqp066338@repoman.freebsd.org> cperciva 2008-01-14 22:55:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) . UPDATING lib/libc/inet inet_network.c lib/libc/stdlib grantpt.c lib/libutil pty.c Log: Fix issues which allow snooping on ptys. [08:01] Fix an off-by-one error in inet_network(3). [08:02] Security: FreeBSD-SA-08:01.pty Security: FreeBSD-SA-08:02.libc Approved by: re (kensmith) Revision Changes Path 1.507.2.3.2.1 +4 -0 src/UPDATING 1.4.4.1 +2 -2 src/lib/libc/inet/inet_network.c 1.7.2.2.2.2 +35 -37 src/lib/libc/stdlib/grantpt.c 1.17.2.2.2.1 +1 -2 src/lib/libutil/pty.c From cperciva at FreeBSD.org Mon Jan 14 14:56:05 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Mon Jan 14 14:56:09 2008 Subject: cvs commit: src/lib/libc/inet inet_network.c src/lib/libc/stdlib grantpt.c src/lib/libutil pty.c Message-ID: <200801142256.m0EMu5tX066414@repoman.freebsd.org> cperciva 2008-01-14 22:56:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libc/inet inet_network.c lib/libc/stdlib grantpt.c lib/libutil pty.c Log: Fix issues which allow snooping on ptys. [08:01] Fix an off-by-one error in inet_network(3). [08:02] Security: FreeBSD-SA-08:01.pty Security: FreeBSD-SA-08:02.libc Revision Changes Path 1.2.2.2 +2 -2 src/lib/libc/inet/inet_network.c 1.4.2.2 +25 -23 src/lib/libc/stdlib/grantpt.c 1.15.10.2 +47 -42 src/lib/libutil/pty.c From cperciva at FreeBSD.org Mon Jan 14 14:56:19 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Mon Jan 14 14:56:23 2008 Subject: cvs commit: src UPDATING src/lib/libc/inet inet_network.c src/lib/libc/stdlib grantpt.c src/lib/libutil pty.c Message-ID: <200801142256.m0EMuIhZ066504@repoman.freebsd.org> cperciva 2008-01-14 22:56:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) . UPDATING lib/libc/inet inet_network.c lib/libc/stdlib grantpt.c lib/libutil pty.c Log: Fix issues which allow snooping on ptys. [08:01] Fix an off-by-one error in inet_network(3). [08:02] Security: FreeBSD-SA-08:01.pty Security: FreeBSD-SA-08:02.libc Approved by: re (kensmith) Thanks to: re@ for being so patient with us holding up the release Revision Changes Path 1.416.2.37.2.3 +4 -0 src/UPDATING 1.2.2.1.4.1 +2 -2 src/lib/libc/inet/inet_network.c 1.4.10.2 +25 -23 src/lib/libc/stdlib/grantpt.c 1.15.20.2 +1 -2 src/lib/libutil/pty.c From cperciva at FreeBSD.org Mon Jan 14 14:56:44 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Mon Jan 14 14:56:45 2008 Subject: cvs commit: src UPDATING src/lib/libc/inet inet_network.c src/lib/libc/stdlib grantpt.c src/lib/libutil pty.c src/sys/conf newvers.sh Message-ID: <200801142256.m0EMuiQg066627@repoman.freebsd.org> cperciva 2008-01-14 22:56:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_2) . UPDATING lib/libc/inet inet_network.c lib/libc/stdlib grantpt.c lib/libutil pty.c sys/conf newvers.sh Log: Fix issues which allow snooping on ptys. [08:01] Fix an off-by-one error in inet_network(3). [08:02] Security: FreeBSD-SA-08:01.pty Security: FreeBSD-SA-08:02.libc Approved by: so (cperciva) Revision Changes Path 1.416.2.29.2.13 +4 -0 src/UPDATING 1.2.2.1.2.1 +2 -2 src/lib/libc/inet/inet_network.c 1.4.8.1 +25 -23 src/lib/libc/stdlib/grantpt.c 1.15.18.1 +1 -2 src/lib/libutil/pty.c 1.69.2.13.2.13 +1 -1 src/sys/conf/newvers.sh From cperciva at FreeBSD.org Mon Jan 14 14:56:57 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Mon Jan 14 14:57:01 2008 Subject: cvs commit: src UPDATING src/lib/libc/stdlib grantpt.c src/lib/libutil pty.c src/sys/conf newvers.sh Message-ID: <200801142256.m0EMuumm066717@repoman.freebsd.org> cperciva 2008-01-14 22:56:56 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_1) . UPDATING lib/libc/stdlib grantpt.c lib/libutil pty.c sys/conf newvers.sh Log: Fix issues which allow snooping on ptys. Security: FreeBSD-SA-08:01.pty Approved by: so (cperciva) Revision Changes Path 1.416.2.22.2.24 +3 -0 src/UPDATING 1.4.6.1 +25 -23 src/lib/libc/stdlib/grantpt.c 1.15.14.1 +1 -2 src/lib/libutil/pty.c 1.69.2.11.2.24 +1 -1 src/sys/conf/newvers.sh From cperciva at FreeBSD.org Mon Jan 14 14:57:06 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Mon Jan 14 14:57:11 2008 Subject: cvs commit: src/lib/libutil pty.c Message-ID: <200801142257.m0EMv6aE066752@repoman.freebsd.org> cperciva 2008-01-14 22:57:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) lib/libutil pty.c Log: Fix issues which allow snooping on ptys. Security: FreeBSD-SA-08:01.pty Revision Changes Path 1.15.4.1 +47 -42 src/lib/libutil/pty.c From cperciva at FreeBSD.org Mon Jan 14 14:57:20 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Mon Jan 14 14:57:24 2008 Subject: cvs commit: src UPDATING src/lib/libutil pty.c src/sys/conf newvers.sh Message-ID: <200801142257.m0EMvJm8066822@repoman.freebsd.org> cperciva 2008-01-14 22:57:19 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_5) . UPDATING lib/libutil pty.c sys/conf newvers.sh Log: Fix issues which allow snooping on ptys. Security: FreeBSD-SA-08:01.pty Approved by: so (cperciva) Revision Changes Path 1.342.2.35.2.18 +3 -0 src/UPDATING 1.15.16.1 +1 -2 src/lib/libutil/pty.c 1.62.2.21.2.20 +1 -1 src/sys/conf/newvers.sh From cperciva at FreeBSD.org Mon Jan 14 14:57:45 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Mon Jan 14 14:57:48 2008 Subject: cvs commit: src/lib/libc/inet inet_network.c src/lib/libc/stdlib grantpt.c src/lib/libutil pty.c Message-ID: <200801142257.m0EMvjH6066919@repoman.freebsd.org> cperciva 2008-01-14 22:57:45 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libc/inet inet_network.c lib/libc/stdlib grantpt.c lib/libutil pty.c Log: Fix issues which allow snooping on ptys. [08:01] Fix an off-by-one error in inet_network(3). [08:02] Security: FreeBSD-SA-08:01.pty Security: FreeBSD-SA-08:02.libc Approved by: re (kensmith) Revision Changes Path 1.4.2.1 +2 -2 src/lib/libc/inet/inet_network.c 1.7.2.4 +35 -37 src/lib/libc/stdlib/grantpt.c 1.17.2.3 +16 -60 src/lib/libutil/pty.c From jhb at freebsd.org Mon Jan 14 15:36:31 2008 From: jhb at freebsd.org (John Baldwin) Date: Mon Jan 14 15:36:35 2008 Subject: cvs commit: src/lib/libc/inet inet_network.c src/lib/libc/stdlib grantpt.c src/lib/libutil pty.c In-Reply-To: <200801142255.m0EMtK7x066176@repoman.freebsd.org> References: <200801142255.m0EMtK7x066176@repoman.freebsd.org> Message-ID: <200801141836.19291.jhb@freebsd.org> On Monday 14 January 2008 05:55:20 pm Colin Percival wrote: > cperciva 2008-01-14 22:55:20 UTC > > FreeBSD src repository > > Modified files: > lib/libc/inet inet_network.c > lib/libc/stdlib grantpt.c > lib/libutil pty.c > Log: > Fix issues which allow snooping on ptys. [08:01] > > Fix an off-by-one error in inet_network(3). [08:02] > > Security: FreeBSD-SA-08:01.pty > Security: FreeBSD-SA-08:02.libc Did you mean to disable support for pts(4) in ptsname(3) in HEAD? Note that pts(4) isn't disabled in any of the other pty-related functions in HEAD (e.g. posix_openpt(3)). -- John Baldwin From jhb at FreeBSD.org Mon Jan 14 15:49:56 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Jan 14 15:50:02 2008 Subject: cvs commit: src/lib/libutil pty.3 Message-ID: <200801142349.m0ENnuVQ075703@repoman.freebsd.org> jhb 2008-01-14 23:49:56 UTC FreeBSD src repository Modified files: lib/libutil pty.3 Log: Update the manpage for openpty(3) to account for the recent fixes. Specifically, remove the BUGS section and note that openpty(3) now always does the various security-related steps. Also, update the error return value section. The PR below is for the original bug rather than the doc updates. MFC after: 1 week PR: bin/9770 Revision Changes Path 1.14 +14 -18 src/lib/libutil/pty.3 From yongari at FreeBSD.org Mon Jan 14 17:10:32 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Mon Jan 14 17:10:35 2008 Subject: cvs commit: src/sys/pci if_rlreg.h src/sys/dev/re if_re.c Message-ID: <200801150110.m0F1AVlA001255@repoman.freebsd.org> yongari 2008-01-15 01:10:31 UTC FreeBSD src repository Modified files: sys/pci if_rlreg.h sys/dev/re if_re.c Log: Overhaul re(4). o Increased number of Rx/Tx descriptors to 256 for 8169 GigEs because it's hard to push the hardware to the limit with default 64 descriptors. TSO requires large number of Tx descriptors to pass a full sized TCP segment(65535 bytes IP packet) to hardware. Previously it consumed 32 Tx descriptors, assuming MCLBYTES DMA segment size, to send the TCP segment which means re(4) couldn't queue more than two full sized IP packets. For 8139C+ it still uses 64 Rx/Tx descriptors due to its hardware limitations. With this changes there are (very) small waste of memory for 8139C+ users but I don't think it would affect 8139C+ users for most cases. o Various bus_dma(9) fixes. - The hardware supports DAC so allow 64bit DMA operations. - Removed BUS_DMA_ALLOC_NOW flag. - Increased DMA segment size to 4096 from MCLBYTES because TSO consumes too many descriptors with MCLBYTES DMA segment size. - Tx/Rx side bus_dmamap_load_mbuf_sg(9) support. With these changes the code is more readable than previous one and got a (slightly) better performance as it doesn't need to pass/ decode arguments to/from callback function. - Removed unnecessary callback function re_dmamap_desc() and nuked rl_dmaload_arg structure which was used in the callback. - Additional protection for DMA map load failure. In case of failure reuse current map instead of returning a bogus DMA map. - Deferred DMA map unloading/sync operation for maximum performance until we really need to load new DMA map. If we happen to reuse current map(e.g. input error) there is no need to sync/unload/load again. - The number of allowable Tx DMA segments for a mbuf chains are now 32 instead of magic nseg value. If the number of available Tx descriptors are short enough to send highly fragmented mbuf chains an optimized re_defrag() is called to collapse mbuf chains which is supposed to be much faster than m_defrag(9). re_defrag() was borrowed from ath(4). - Separated Rx/Tx DMA tag from a common DMA tag such that Rx DMA tag correctly uses DMA maps that were created with DMA alignment restriction(8bytes alignments). Tx DMA tag does not have such alignment limitation. - Added additional sanity checks for DMA ring map load failure. - Added additional spare Rx DMA map for graceful handling of Rx DMA map load failure. - Fixed misused bus_dmamap_sync(9) and added missing bus_dmamap_sync(9) in re_encap()/re_txeof()/re_rxeof(). o Enabled TSO again as re(4) have reasonable number of Tx descriptors. o Don't touch DMA address of a Tx descriptor in re_txeof(). It's not needed. o Fix incorrect update of if_ierrors counter. For Rx buffer shortage it should update if_qdrops as the buffer is reused. o Added checks for unsupported H/W revisions and return ENXIO for these hardwares. This is required to remove resource allocation code in re_probe as other drivers do in device probe routine. o Modified descriptor index manipulation macros as it's now possible to have different number of descriptors for Rx/Tx. o In re_start, to save a lock operation, use IFQ_DRV_IS_EMPTY before trying to invoke IFQ_DRV_DEQUEUE. Also don't blindly call re_encap since we already know the number of available Tx descriptors in advance. o Removed RL_TX_DESC_THLD which was used to reserve RL_TX_DESC_THLD descriptors in Tx path. There is no such a limitation mentioned in 8139C+/8169/8110/8168/8101/8111 datasheet and it seems to work ok without reserving RL_TX_DESC_THLD descriptors. o Fix a comment for RL_GTXSTART. The register is 8bits register. o Added comments for 8169/8139C+ hardware restrictions on descriptors. o Removed forward declaration for "struct rl_softc", it's not needed. o Added a new structure rl_txdesc for Tx descriptor managements and a structure rl_rxdesc for Rx descriptor managements. o Removed unused member variable rl_intlock in driver softc. There are still several unused member variables which are supposed to be used to access hardware statistics counters. But it seems that accessing hardware counters were not implemented yet. Revision Changes Path 1.101 +483 -359 src/sys/dev/re/if_re.c 1.70 +37 -23 src/sys/pci/if_rlreg.h From aryeh.friedman at gmail.com Mon Jan 14 17:37:12 2008 From: aryeh.friedman at gmail.com (Aryeh M. Friedman) Date: Mon Jan 14 17:37:24 2008 Subject: cvs commit: src/sys/pci if_rlreg.h src/sys/dev/re if_re.c In-Reply-To: <200801150110.m0F1AVlA001255@repoman.freebsd.org> References: <200801150110.m0F1AVlA001255@repoman.freebsd.org> Message-ID: <478C0E45.4030300@gmail.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Is this equiv to the cumulative patch on your site? Pyun YongHyeon wrote: > yongari 2008-01-15 01:10:31 UTC > > FreeBSD src repository > > Modified files: sys/pci if_rlreg.h sys/dev/re > if_re.c Log: Overhaul re(4). o Increased number of Rx/Tx > descriptors to 256 for 8169 GigEs because it's hard to push the > hardware to the limit with default 64 descriptors. TSO requires > large number of Tx descriptors to pass a full sized TCP > segment(65535 bytes IP packet) to hardware. Previously it consumed > 32 Tx descriptors, assuming MCLBYTES DMA segment size, to send the > TCP segment which means re(4) couldn't queue more than two full > sized IP packets. For 8139C+ it still uses 64 Rx/Tx descriptors due > to its hardware limitations. With this changes there are (very) > small waste of memory for 8139C+ users but I don't think it would > affect 8139C+ users for most cases. o Various bus_dma(9) fixes. - > The hardware supports DAC so allow 64bit DMA operations. - Removed > BUS_DMA_ALLOC_NOW flag. - Increased DMA segment size to 4096 from > MCLBYTES because TSO consumes too many descriptors with MCLBYTES > DMA segment size. - Tx/Rx side bus_dmamap_load_mbuf_sg(9) support. > With these changes the code is more readable than previous one and > got a (slightly) better performance as it doesn't need to pass/ > decode arguments to/from callback function. - Removed unnecessary > callback function re_dmamap_desc() and nuked rl_dmaload_arg > structure which was used in the callback. - Additional protection > for DMA map load failure. In case of failure reuse current map > instead of returning a bogus DMA map. - Deferred DMA map > unloading/sync operation for maximum performance until we really > need to load new DMA map. If we happen to reuse current map(e.g. > input error) there is no need to sync/unload/load again. - The > number of allowable Tx DMA segments for a mbuf chains are now 32 > instead of magic nseg value. If the number of available Tx > descriptors are short enough to send highly fragmented mbuf chains > an optimized re_defrag() is called to collapse mbuf chains which is > supposed to be much faster than m_defrag(9). re_defrag() was > borrowed from ath(4). - Separated Rx/Tx DMA tag from a common DMA > tag such that Rx DMA tag correctly uses DMA maps that were created > with DMA alignment restriction(8bytes alignments). Tx DMA tag does > not have such alignment limitation. - Added additional sanity > checks for DMA ring map load failure. - Added additional spare Rx > DMA map for graceful handling of Rx DMA map load failure. - Fixed > misused bus_dmamap_sync(9) and added missing bus_dmamap_sync(9) in > re_encap()/re_txeof()/re_rxeof(). o Enabled TSO again as re(4) have > reasonable number of Tx descriptors. o Don't touch DMA address of a > Tx descriptor in re_txeof(). It's not needed. o Fix incorrect > update of if_ierrors counter. For Rx buffer shortage it should > update if_qdrops as the buffer is reused. o Added checks for > unsupported H/W revisions and return ENXIO for these hardwares. > This is required to remove resource allocation code in re_probe as > other drivers do in device probe routine. o Modified descriptor > index manipulation macros as it's now possible to have different > number of descriptors for Rx/Tx. o In re_start, to save a lock > operation, use IFQ_DRV_IS_EMPTY before trying to invoke > IFQ_DRV_DEQUEUE. Also don't blindly call re_encap since we already > know the number of available Tx descriptors in advance. o Removed > RL_TX_DESC_THLD which was used to reserve RL_TX_DESC_THLD > descriptors in Tx path. There is no such a limitation mentioned in > 8139C+/8169/8110/8168/8101/8111 datasheet and it seems to work ok > without reserving RL_TX_DESC_THLD descriptors. o Fix a comment for > RL_GTXSTART. The register is 8bits register. o Added comments for > 8169/8139C+ hardware restrictions on descriptors. o Removed forward > declaration for "struct rl_softc", it's not needed. o Added a new > structure rl_txdesc for Tx descriptor managements and a structure > rl_rxdesc for Rx descriptor managements. o Removed unused member > variable rl_intlock in driver softc. There are still several unused > member variables which are supposed to be used to access hardware > statistics counters. But it seems that accessing hardware counters > were not implemented yet. > > Revision Changes Path 1.101 +483 -359 > src/sys/dev/re/if_re.c 1.70 +37 -23 src/sys/pci/if_rlreg.h > _______________________________________________ cvs-src@freebsd.org > mailing list http://lists.freebsd.org/mailman/listinfo/cvs-src To > unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > - -- Aryeh M. Friedman FloSoft Systems, Java Developer Tools. http://www.flosoft-systems.com Developer, not business, friendly. "Free software != Free beer" Blog: http://www.flosoft-systems.com/flosoft_systems_community/blogs/aryeh/index.php -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHjA5FjRvRjGmHRgQRAm2fAJ9ws2xyHRh7gnAoNJh2nwKzhU3LhQCgod/G lfdLHycwMHg3dknfOun+cqs= =PkUT -----END PGP SIGNATURE----- From hrs at FreeBSD.org Mon Jan 14 18:34:12 2008 From: hrs at FreeBSD.org (Hiroki Sato) Date: Mon Jan 14 18:34:13 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml Message-ID: <200801150234.m0F2YBeh015683@repoman.freebsd.org> hrs 2008-01-15 02:34:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: Document FreeBSD-SA-08:01.pty and FreeBSD-SA-08:02.libc. Approved by: re (implicitly) Revision Changes Path 1.883.2.87.2.7 +15 -0 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From cperciva at freebsd.org Mon Jan 14 18:36:41 2008 From: cperciva at freebsd.org (Colin Percival) Date: Mon Jan 14 18:36:44 2008 Subject: cvs commit: src/lib/libc/inet inet_network.c src/lib/libc/stdlib grantpt.c src/lib/libutil pty.c In-Reply-To: <200801141836.19291.jhb@freebsd.org> References: <200801142255.m0EMtK7x066176@repoman.freebsd.org> <200801141836.19291.jhb@freebsd.org> Message-ID: <478C1C03.7020802@freebsd.org> John Baldwin wrote: > On Monday 14 January 2008 05:55:20 pm Colin Percival wrote: >> Fix issues which allow snooping on ptys. [08:01] >> >> Fix an off-by-one error in inet_network(3). [08:02] >> >> Security: FreeBSD-SA-08:01.pty >> Security: FreeBSD-SA-08:02.libc > > Did you mean to disable support for pts(4) in ptsname(3) in HEAD? Note that > pts(4) isn't disabled in any of the other pty-related functions in HEAD (e.g. > posix_openpt(3)). Oops -- I was putting together the patch for HEAD based on what I had for RELENG_7 and that must have slipped in accidentally. Please feel free to make HEAD do whatever you think it should do. Colin Percival From pyunyh at gmail.com Mon Jan 14 19:06:34 2008 From: pyunyh at gmail.com (Pyun YongHyeon) Date: Mon Jan 14 19:06:39 2008 Subject: cvs commit: src/sys/pci if_rlreg.h src/sys/dev/re if_re.c In-Reply-To: <478C0E45.4030300@gmail.com> References: <200801150110.m0F1AVlA001255@repoman.freebsd.org> <478C0E45.4030300@gmail.com> Message-ID: <20080115023602.GB80745@cdnetworks.co.kr> On Mon, Jan 14, 2008 at 08:37:09PM -0500, Aryeh M. Friedman wrote: [...] > > Is this equiv to the cumulative patch on your site? > Yes. I still have more re(4) patches but they have nothing to do with stability/performance of re(4). -- Regards, Pyun YongHyeon From kmacy at FreeBSD.org Mon Jan 14 19:21:03 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Mon Jan 14 19:21:06 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_osdep.h Message-ID: <200801150321.m0F3L2Js023962@repoman.freebsd.org> kmacy 2008-01-15 03:21:02 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_osdep.h Log: remove superfluous locking from dequeue Revision Changes Path 1.20 +0 -2 src/sys/dev/cxgb/cxgb_osdep.h From kmacy at FreeBSD.org Mon Jan 14 19:27:43 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Mon Jan 14 19:27:50 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_adapter.h cxgb_main.c cxgb_multiq.c cxgb_sge.c src/sys/dev/cxgb/sys mvec.h uipc_mvec.c Message-ID: <200801150327.m0F3RhBo025147@repoman.freebsd.org> kmacy 2008-01-15 03:27:42 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_adapter.h cxgb_main.c cxgb_multiq.c cxgb_sge.c sys/dev/cxgb/sys mvec.h uipc_mvec.c Log: - move WR_LEN in to cxgb_adapter.h add PIO_LEN to make intent clearer - move cxgb_tx_common in to cxgb_multiq.c and rename to cxgb_tx - move cxgb_tx_common dependencies - further simplify cxgb_dequeue_packet for the non-multiqueue case - only launch one service thread per port in the non-multiq case - remove dead cleaning code from cxgb_sge.c - simplify PIO case substantially in by returning directly from mbuf collapse and just using m_copydata - remove gratuitous m_gethdr in the rx path - clarify freeing of mbufs in collapse Revision Changes Path 1.27 +11 -4 src/sys/dev/cxgb/cxgb_adapter.h 1.46 +0 -73 src/sys/dev/cxgb/cxgb_main.c 1.5 +124 -40 src/sys/dev/cxgb/cxgb_multiq.c 1.41 +40 -85 src/sys/dev/cxgb/cxgb_sge.c 1.11 +3 -1 src/sys/dev/cxgb/sys/mvec.h 1.20 +13 -46 src/sys/dev/cxgb/sys/uipc_mvec.c From yongari at FreeBSD.org Mon Jan 14 19:47:25 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Mon Jan 14 19:47:29 2008 Subject: cvs commit: src/sys/dev/re if_re.c Message-ID: <200801150347.m0F3lODn028026@repoman.freebsd.org> yongari 2008-01-15 03:47:24 UTC FreeBSD src repository Modified files: sys/dev/re if_re.c Log: Fix build. Revision Changes Path 1.102 +1 -1 src/sys/dev/re/if_re.c From yongari at FreeBSD.org Mon Jan 14 20:00:13 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Mon Jan 14 20:00:15 2008 Subject: cvs commit: src/sys/sys mbuf.h Message-ID: <200801150400.m0F40CwT029948@repoman.freebsd.org> yongari 2008-01-15 04:00:12 UTC FreeBSD src repository Modified files: sys/sys mbuf.h Log: Protect arg in macro M_ASSERTPKTHDR. Revision Changes Path 1.220 +1 -1 src/sys/sys/mbuf.h From kientzle at FreeBSD.org Mon Jan 14 20:56:49 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Mon Jan 14 20:56:54 2008 Subject: cvs commit: src/lib/libarchive archive_read_support_format_cpio.c Message-ID: <200801150456.m0F4un25048467@repoman.freebsd.org> kientzle 2008-01-15 04:56:49 UTC FreeBSD src repository Modified files: lib/libarchive archive_read_support_format_cpio.c Log: Support uppercase hex digits in cpio archives. Thanks to: Joshua Kwan MFC after: 7 days Revision Changes Path 1.26 +5 -3 src/lib/libarchive/archive_read_support_format_cpio.c From mpp at FreeBSD.org Mon Jan 14 22:33:22 2008 From: mpp at FreeBSD.org (Mike Pritchard) Date: Mon Jan 14 22:33:27 2008 Subject: cvs commit: src/sbin/quotacheck quotacheck.c Message-ID: <200801150633.m0F6XLaw052896@repoman.freebsd.org> mpp 2008-01-15 06:33:21 UTC FreeBSD src repository Modified files: sbin/quotacheck quotacheck.c Log: Quotacheck may possibly skip quota accounting for up to 2 files on a filesystem if the quota data files reside on a different filesystem (e.g. the userquota=/somepath,groupquota=/somepath2 options are specified in /etc/fstab to place the quota files somewhere other than the default location). Fix quotacheck to only skip accounting if the quota data file actually resides on the filesystem being checked. Revision Changes Path 1.34 +14 -3 src/sbin/quotacheck/quotacheck.c From das at FreeBSD.org Mon Jan 14 22:50:50 2008 From: das at FreeBSD.org (David Schultz) Date: Mon Jan 14 22:51:00 2008 Subject: cvs commit: src/lib/libc/gen getttyent.c Message-ID: <200801150650.m0F6oo1m092812@repoman.freebsd.org> das 2008-01-15 06:50:50 UTC FreeBSD src repository Modified files: lib/libc/gen getttyent.c Log: In getttyent(3), if /etc/ttys doesn't end in a newline, don't freak out and keep trying to expand the buffer until realloc() fails. PR: 114398 Revision Changes Path 1.17 +1 -1 src/lib/libc/gen/getttyent.c From das at FreeBSD.org Mon Jan 14 23:40:31 2008 From: das at FreeBSD.org (David Schultz) Date: Mon Jan 14 23:40:33 2008 Subject: cvs commit: src/usr.bin/wall wall.c Message-ID: <200801150740.m0F7eUhh001207@repoman.freebsd.org> das 2008-01-15 07:40:30 UTC FreeBSD src repository Modified files: usr.bin/wall wall.c Log: Fix some bugs in wall(1): - Handle wrapping correctly when \r appears in the input, and don't remove the \r from the output. - For lines longer than 79 characters, don't drop every 80th character. - Style: Braces around compound while statement. PR: 114498 Submitted by: Niclas Zeising (earlier version) Revision Changes Path 1.25 +13 -6 src/usr.bin/wall/wall.c From kmacy at FreeBSD.org Tue Jan 15 00:08:09 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Tue Jan 15 00:08:13 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_adapter.h cxgb_multiq.c cxgb_sge.c src/sys/dev/cxgb/sys mvec.h uipc_mvec.c Message-ID: <200801150808.m0F889mx007702@repoman.freebsd.org> kmacy 2008-01-15 08:08:09 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_adapter.h cxgb_multiq.c cxgb_sge.c sys/dev/cxgb/sys mvec.h uipc_mvec.c Log: - Simplify mb_free_ext_fast - increase asserts for mbuf accounting - track outstanding mbufs (maps very closely to leaked) - actually only create one thread per port if !multiq Oddly enough this fixes the use after free - move txq_segs to stack in t3_encap - add checks that pidx doesn't move pass cidx - simplify mbuf free logic in collapse mbufs routine Revision Changes Path 1.28 +1 -2 src/sys/dev/cxgb/cxgb_adapter.h 1.6 +12 -3 src/sys/dev/cxgb/cxgb_multiq.c 1.42 +28 -7 src/sys/dev/cxgb/cxgb_sge.c 1.12 +10 -3 src/sys/dev/cxgb/sys/mvec.h 1.21 +40 -25 src/sys/dev/cxgb/sys/uipc_mvec.c From jeff at FreeBSD.org Tue Jan 15 01:03:09 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Tue Jan 15 01:03:14 2008 Subject: cvs commit: src/sys/kern sched_ule.c Message-ID: <200801150903.m0F939eP079036@repoman.freebsd.org> jeff 2008-01-15 09:03:09 UTC FreeBSD src repository Modified files: sys/kern sched_ule.c Log: - When executing the 'tryself' branch in sched_pickcpu() look at the lowest priority on the queue for the current cpu vs curthread's priority. In the case that curthread is waking up many threads of a lower priority as would happen with a turnstile_broadcast() or wakeup() of many threads this prevents them from all ending up on the current cpu. - In sched_add() make the relationship between a scheduled ithread and the current cpu advisory rather than strict. Only give the ithread affinity for the current cpu if it's actually being scheduled from a hardware interrupt. This prevents it from migrating when it simply blocks on a lock. Sponsored by: Nokia Revision Changes Path 1.222 +5 -4 src/sys/kern/sched_ule.c From rdivacky at FreeBSD.org Tue Jan 15 01:55:56 2008 From: rdivacky at FreeBSD.org (Roman Divacky) Date: Tue Jan 15 01:56:00 2008 Subject: cvs commit: src/sys/pci if_rlreg.h src/sys/dev/re if_re.c In-Reply-To: <200801150110.m0F1AVlA001255@repoman.freebsd.org> References: <200801150110.m0F1AVlA001255@repoman.freebsd.org> Message-ID: <20080115095542.GA34226@freebsd.org> > - The number of allowable Tx DMA segments for a mbuf chains are > now 32 instead of magic nseg value. If the number of available > Tx descriptors are short enough to send highly fragmented mbuf > chains an optimized re_defrag() is called to collapse mbuf > chains which is supposed to be much faster than m_defrag(9). > re_defrag() was borrowed from ath(4). would it make sense to introduce a new foo_defrag() to not duplicate the ath|re_defrag() all over the place? From gallatin at FreeBSD.org Tue Jan 15 05:29:35 2008 From: gallatin at FreeBSD.org (Andrew Gallatin) Date: Tue Jan 15 05:29:37 2008 Subject: cvs commit: src/sys/dev/mxge eth_z8e.h ethp_z8e.h Message-ID: <200801151329.m0FDTZmg043950@repoman.freebsd.org> gallatin 2008-01-15 13:29:33 UTC FreeBSD src repository Modified files: sys/dev/mxge eth_z8e.h ethp_z8e.h Log: Update to firmware version 1.4.29 from 1.4.25. Relevant changes include: - Fix a bug introduced in 1.4.20 where speculative read by the processor in the write-only doorbell region would cause a target-abort (as opposed to simply returning random data). This could manifest itself as NMI or machine freeze depending on how the BIOS/OS/chipset configuration handles target-abort. - Add support for new revisions of -R cards (with AEL1002/AEL1010 xaui->xfi) - Increase an internal timing (dispatch engine): fix possible spurious reset (seen on very few cards). Revision Changes Path 1.3 +13144 -12745 src/sys/dev/mxge/eth_z8e.h 1.3 +13225 -12825 src/sys/dev/mxge/ethp_z8e.h From andre at freebsd.org Tue Jan 15 05:58:32 2008 From: andre at freebsd.org (Andre Oppermann) Date: Tue Jan 15 05:58:35 2008 Subject: cvs commit: src/sys/pci if_rlreg.h src/sys/dev/re if_re.c In-Reply-To: <200801150110.m0F1AVlA001255@repoman.freebsd.org> References: <200801150110.m0F1AVlA001255@repoman.freebsd.org> Message-ID: <478CB5C8.80308@freebsd.org> Pyun YongHyeon wrote: > yongari 2008-01-15 01:10:31 UTC > > FreeBSD src repository > > Modified files: > sys/pci if_rlreg.h > sys/dev/re if_re.c > Log: > Overhaul re(4). > - The number of allowable Tx DMA segments for a mbuf chains are > now 32 instead of magic nseg value. If the number of available > Tx descriptors are short enough to send highly fragmented mbuf > chains an optimized re_defrag() is called to collapse mbuf > chains which is supposed to be much faster than m_defrag(9). > re_defrag() was borrowed from ath(4). If this function is used more often we should make it a public function within the mbuf framework. Copying this stuff around is evil(TM). -- Andre From cperciva at FreeBSD.org Tue Jan 15 05:59:13 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Tue Jan 15 05:59:18 2008 Subject: cvs commit: src/lib/libc/stdlib grantpt.c src/lib/libutil pty.c Message-ID: <200801151359.m0FDxDJO048412@repoman.freebsd.org> cperciva 2008-01-15 13:59:13 UTC FreeBSD src repository Modified files: lib/libc/stdlib grantpt.c lib/libutil pty.c Log: Back out last commit, since it accidentally broke pts. The security fix will be re-committed soon, hopefully without breaking anything. Revision Changes Path 1.11 +46 -35 src/lib/libc/stdlib/grantpt.c 1.21 +55 -3 src/lib/libutil/pty.c From rwatson at FreeBSD.org Tue Jan 15 06:02:10 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Tue Jan 15 06:02:14 2008 Subject: cvs commit: src/lib/libc/stdlib grantpt.c src/lib/libutil pty.c In-Reply-To: <200801151359.m0FDxDJO048412@repoman.freebsd.org> References: <200801151359.m0FDxDJO048412@repoman.freebsd.org> Message-ID: <20080115140113.D22539@fledge.watson.org> On Tue, 15 Jan 2008, Colin Percival wrote: > cperciva 2008-01-15 13:59:13 UTC > > FreeBSD src repository > > Modified files: > lib/libc/stdlib grantpt.c > lib/libutil pty.c > Log: > Back out last commit, since it accidentally broke pts. > > The security fix will be re-committed soon, hopefully without breaking > anything. I can do this later today (4-6 hours) if all goes well, but if someone else gets to it first I'm fine with them committing it. I believe all that's needed is removing the #if 0's from the patch you originally committed, but can't test it for a few hours. Thanks, Robert N M Watson Computer Laboratory University of Cambridge From gallatin at FreeBSD.org Tue Jan 15 07:04:41 2008 From: gallatin at FreeBSD.org (Andrew Gallatin) Date: Tue Jan 15 07:04:42 2008 Subject: cvs commit: src/sys/dev/mxge eth_z8e.h ethp_z8e.h Message-ID: <200801151504.m0FF4eO6075476@repoman.freebsd.org> gallatin 2008-01-15 15:04:40 UTC FreeBSD src repository Modified files: sys/dev/mxge eth_z8e.h ethp_z8e.h Log: Fix accidental swap of "const" for "static" in mxge firmware byte arrays caused by running my import script with the wrong args. Revision Changes Path 1.4 +3 -3 src/sys/dev/mxge/eth_z8e.h 1.4 +3 -3 src/sys/dev/mxge/ethp_z8e.h From obrien at freebsd.org Tue Jan 15 07:16:34 2008 From: obrien at freebsd.org (David O'Brien) Date: Tue Jan 15 07:16:44 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <200801141554.52748.jhb@freebsd.org> References: <200801080800.m08806jI012963@repoman.freebsd.org> <20080114181154.GA2286@dragon.NUXI.org> <478BC55B.2060202@FreeBSD.org> <200801141554.52748.jhb@freebsd.org> Message-ID: <20080115151602.GA27461@dragon.NUXI.org> On Mon, Jan 14, 2008 at 03:54:52PM -0500, John Baldwin wrote: > Also, if there are ports distfiles that unzip doesn't handle then there are > likely other zip files in the wild that users may run into that it won't > handle either. In that case, I think the ports distfiles are a good canary > for seeing if unzip is suitable for widespread use. There are zip files in the wild that InfoZip won't work on also. (needed to use a PeeCee and pkunzip). -- -- David (obrien@FreeBSD.org) From jhb at freebsd.org Tue Jan 15 07:27:30 2008 From: jhb at freebsd.org (John Baldwin) Date: Tue Jan 15 07:27:40 2008 Subject: cvs commit: src/lib/libc/stdlib grantpt.c src/lib/libutil pty.c In-Reply-To: <200801151359.m0FDxDJO048412@repoman.freebsd.org> References: <200801151359.m0FDxDJO048412@repoman.freebsd.org> Message-ID: <200801151027.21703.jhb@freebsd.org> On Tuesday 15 January 2008 08:59:13 am Colin Percival wrote: > cperciva 2008-01-15 13:59:13 UTC > > FreeBSD src repository > > Modified files: > lib/libc/stdlib grantpt.c > lib/libutil pty.c > Log: > Back out last commit, since it accidentally broke pts. > > The security fix will be re-committed soon, hopefully without breaking > anything. You didn't need to do this, you just needed to not add the #if 0 in grantpt.c that wasn't in the original patch for HEAD. -- John Baldwin From jhb at FreeBSD.org Tue Jan 15 07:36:23 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Tue Jan 15 07:36:25 2008 Subject: cvs commit: src/lib/libc/stdlib grantpt.c src/lib/libutil pty.c Message-ID: <200801151536.m0FFaNHm080385@repoman.freebsd.org> jhb 2008-01-15 15:36:23 UTC FreeBSD src repository Modified files: lib/libc/stdlib grantpt.c lib/libutil pty.c Log: Put back the openpty(3) and ptsname(3) fixes but don't disable ptsname(3) on pts(4) devices this time. This fixes the issues while leaving pts(4) enabled on HEAD. Revision Changes Path 1.12 +31 -46 src/lib/libc/stdlib/grantpt.c 1.22 +3 -55 src/lib/libutil/pty.c From gallatin at FreeBSD.org Tue Jan 15 07:39:37 2008 From: gallatin at FreeBSD.org (Andrew Gallatin) Date: Tue Jan 15 07:39:41 2008 Subject: cvs commit: src/sys/dev/mxge eth_z8e.h ethp_z8e.h Message-ID: <200801151539.m0FFdbTX080461@repoman.freebsd.org> gallatin 2008-01-15 15:39:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/mxge eth_z8e.h ethp_z8e.h Log: MFC: Update to firmware version 1.4.29 from 1.4.25 Revision Changes Path 1.2.2.2 +13144 -12745 src/sys/dev/mxge/eth_z8e.h 1.2.2.2 +13225 -12825 src/sys/dev/mxge/ethp_z8e.h From gallatin at FreeBSD.org Tue Jan 15 07:41:30 2008 From: gallatin at FreeBSD.org (Andrew Gallatin) Date: Tue Jan 15 07:41:35 2008 Subject: cvs commit: src/sys/dev/mxge eth_z8e.h ethp_z8e.h Message-ID: <200801151541.m0FFfU2m081025@repoman.freebsd.org> gallatin 2008-01-15 15:41:30 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) sys/dev/mxge eth_z8e.h ethp_z8e.h Log: MFC: Update to firmware version 1.4.29 from 1.4.25 Approved by: re (kensmith) Revision Changes Path 1.2.2.1.2.1 +13144 -12745 src/sys/dev/mxge/eth_z8e.h 1.2.2.1.2.1 +13225 -12825 src/sys/dev/mxge/ethp_z8e.h From kensmith at FreeBSD.org Tue Jan 15 07:45:08 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Tue Jan 15 07:45:10 2008 Subject: cvs commit: src UPDATING Message-ID: <200801151545.m0FFj70j081872@repoman.freebsd.org> kensmith 2008-01-15 15:45:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) . UPDATING Log: Add theoretical date of 6.3-RELEASE. Approved by: re (implicit) Revision Changes Path 1.416.2.37.2.4 +3 -0 src/UPDATING From kensmith at FreeBSD.org Tue Jan 15 07:46:22 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Tue Jan 15 07:46:23 2008 Subject: cvs commit: src/sys/conf newvers.sh Message-ID: <200801151546.m0FFkL8B081929@repoman.freebsd.org> kensmith 2008-01-15 15:46:21 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) sys/conf newvers.sh Log: Get ready for the 6.3-RELEASE builds. Approved by: re (implicit) Revision Changes Path 1.69.2.15.2.3 +1 -1 src/sys/conf/newvers.sh From kientzle at FreeBSD.org Tue Jan 15 08:27:15 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Tue Jan 15 08:27:17 2008 Subject: cvs commit: src/lib/libarchive archive_read_support_format_zip.c Message-ID: <200801151627.m0FGRFlW089102@repoman.freebsd.org> kientzle 2008-01-15 16:27:15 UTC FreeBSD src repository Modified files: lib/libarchive archive_read_support_format_zip.c Log: Handle Zip archives that are "multi-part archives with only one part" by simply ignoring the marker at the beginning of the file. (Zip archivers reserve four bytes at the beginning of each part of a multi-part archive, if it happens to only require one part, those four bytes get filled with a placeholder that can be ignored.) Thanks to: Marius Nuennerich, for pointing me to a Zip archive that libarchive couldn't handle MFC after: 7 days Revision Changes Path 1.20 +19 -1 src/lib/libarchive/archive_read_support_format_zip.c From gallatin at FreeBSD.org Tue Jan 15 09:57:52 2008 From: gallatin at FreeBSD.org (Andrew Gallatin) Date: Tue Jan 15 09:57:54 2008 Subject: cvs commit: src/sys/dev/mxge eth_z8e.h ethp_z8e.h Message-ID: <200801151757.m0FHvpob037726@repoman.freebsd.org> gallatin 2008-01-15 17:57:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/mxge eth_z8e.h ethp_z8e.h Log: MFC: Update to firmware version 1.4.29 from 1.4.25 Approved by: re (kensmith) Revision Changes Path 1.2.4.1 +13144 -12745 src/sys/dev/mxge/eth_z8e.h 1.2.4.1 +13225 -12825 src/sys/dev/mxge/ethp_z8e.h From gallatin at FreeBSD.org Tue Jan 15 09:59:16 2008 From: gallatin at FreeBSD.org (Andrew Gallatin) Date: Tue Jan 15 09:59:20 2008 Subject: cvs commit: src/sys/dev/mxge eth_z8e.h ethp_z8e.h Message-ID: <200801151759.m0FHxFBI038056@repoman.freebsd.org> gallatin 2008-01-15 17:59:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/dev/mxge eth_z8e.h ethp_z8e.h Log: MFC: Update to firmware version 1.4.29 from 1.4.25 Approved by: re (kensmith) Revision Changes Path 1.2.6.1 +13144 -12745 src/sys/dev/mxge/eth_z8e.h 1.2.6.1 +13225 -12825 src/sys/dev/mxge/ethp_z8e.h From sobomax at FreeBSD.org Tue Jan 15 10:34:47 2008 From: sobomax at FreeBSD.org (Maxim Sobolev) Date: Tue Jan 15 10:34:54 2008 Subject: cvs commit: src/sys/crypto/rijndael rijndael-api.c test00.c Message-ID: <200801151834.m0FIYlKL048849@repoman.freebsd.org> sobomax 2008-01-15 18:34:47 UTC FreeBSD src repository Modified files: sys/crypto/rijndael rijndael-api.c test00.c Log: Make test00 compilable again. Revision Changes Path 1.2 +2 -0 src/sys/crypto/rijndael/rijndael-api.c 1.2 +1 -1 src/sys/crypto/rijndael/test00.c From jhb at FreeBSD.org Tue Jan 15 10:50:49 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Tue Jan 15 10:50:53 2008 Subject: cvs commit: src/sys/dev/acpica acpi_hpet.c Message-ID: <200801151850.m0FIomfA050782@repoman.freebsd.org> jhb 2008-01-15 18:50:48 UTC FreeBSD src repository Modified files: sys/dev/acpica acpi_hpet.c Log: Fix a few minor issues based on a bug report and reading over the HPET spec: - Use read/modify/write cycles to enable and disable the HPET instead of writing 0 to reserved bits. - Shutdown the HPET during suspend as encouraged by the spec. - Fail to attach to an HPET with a period of zero. MFC after: 1 week PR: kern/119675 [3] Reported by: Leo Bicknell | bicknell ufp.org Revision Changes Path 1.13 +45 -3 src/sys/dev/acpica/acpi_hpet.c From jhb at FreeBSD.org Tue Jan 15 10:55:53 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Tue Jan 15 10:55:58 2008 Subject: cvs commit: src/lib/libc/stdlib grantpt.c Message-ID: <200801151855.m0FItr4B051915@repoman.freebsd.org> jhb 2008-01-15 18:55:52 UTC FreeBSD src repository Modified files: lib/libc/stdlib grantpt.c Log: Remove some now-unused macros. MFC after: 1 week Revision Changes Path 1.13 +1 -3 src/lib/libc/stdlib/grantpt.c From sobomax at FreeBSD.org Tue Jan 15 11:21:09 2008 From: sobomax at FreeBSD.org (Maxim Sobolev) Date: Tue Jan 15 11:21:12 2008 Subject: cvs commit: src/sys/dev/hptrr hptrr_osm_bsd.c Message-ID: <200801151921.m0FJL9X0078919@repoman.freebsd.org> sobomax 2008-01-15 19:21:09 UTC FreeBSD src repository Modified files: sys/dev/hptrr hptrr_osm_bsd.c Log: Hide common prints under bootverbose. Obtained from: src/sys/dev/rr232x/osm_bsd.c, rev.1.2-1.3 MFC after: 2 weeks Revision Changes Path 1.2 +4 -2 src/sys/dev/hptrr/hptrr_osm_bsd.c From brueffer at FreeBSD.org Tue Jan 15 11:54:18 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Tue Jan 15 11:54:20 2008 Subject: cvs commit: src/share/man/man5 src.conf.5 src/tools/build/options WITHOUT_FORTRAN Message-ID: <200801151954.m0FJsHEU097021@repoman.freebsd.org> brueffer 2008-01-15 19:54:17 UTC FreeBSD src repository Modified files: share/man/man5 src.conf.5 Removed files: tools/build/options WITHOUT_FORTRAN Log: WITHOUT_FORTRAN was removed some time ago. Regen src.conf.5. PR: 119562 Submitted by: Daniel Rucci MFC after: 3 days Revision Changes Path 1.24 +1 -6 src/share/man/man5/src.conf.5 1.2 +0 -4 src/tools/build/options/WITHOUT_FORTRAN (dead) From gallatin at FreeBSD.org Tue Jan 15 12:34:50 2008 From: gallatin at FreeBSD.org (Andrew Gallatin) Date: Tue Jan 15 12:35:00 2008 Subject: cvs commit: src/sys/conf files src/sys/dev/mxge if_mxge.c if_mxge_var.h mxge_lro.c mxge_mcp.h mxge_rss_eth_z8e.c mxge_rss_ethp_z8e.c rss_eth_z8e.h rss_ethp_z8e.h src/sys/modules/mxge Makefile src/sys/modules/mxge/mxge_rss_eth_z8e ... Message-ID: <200801152034.m0FKYn0i025292@repoman.freebsd.org> gallatin 2008-01-15 20:34:49 UTC FreeBSD src repository Modified files: sys/conf files sys/dev/mxge if_mxge.c if_mxge_var.h mxge_lro.c mxge_mcp.h sys/modules/mxge Makefile Added files: sys/dev/mxge mxge_rss_eth_z8e.c mxge_rss_ethp_z8e.c rss_eth_z8e.h rss_ethp_z8e.h sys/modules/mxge/mxge_rss_eth_z8e Makefile sys/modules/mxge/mxge_rss_ethp_z8e Makefile Log: Add optional support to mxge for MSI-X interrupts and multiple receive queues (which we call slices). The NIC will steer traffic into up to hw.mxge.max_slices different receive rings based on a configurable hash type (hw.mxge.rss_hash_type). Currently the driver defaults to using a single slice, so the default behavior is unchanged. Also, transmit from non-zero slices is disabled currently. Revision Changes Path 1.1264 +2 -0 src/sys/conf/files 1.43 +1104 -470 src/sys/dev/mxge/if_mxge.c 1.17 +41 -20 src/sys/dev/mxge/if_mxge_var.h 1.6 +19 -17 src/sys/dev/mxge/mxge_lro.c 1.9 +61 -12 src/sys/dev/mxge/mxge_mcp.h 1.1 +47 -0 src/sys/dev/mxge/mxge_rss_eth_z8e.c (new) 1.1 +47 -0 src/sys/dev/mxge/mxge_rss_ethp_z8e.c (new) 1.1 +15126 -0 src/sys/dev/mxge/rss_eth_z8e.h (new) 1.1 +15207 -0 src/sys/dev/mxge/rss_ethp_z8e.h (new) 1.3 +2 -0 src/sys/modules/mxge/Makefile 1.1 +7 -0 src/sys/modules/mxge/mxge_rss_eth_z8e/Makefile (new) 1.1 +7 -0 src/sys/modules/mxge/mxge_rss_ethp_z8e/Makefile (new) From jhb at FreeBSD.org Tue Jan 15 12:38:17 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Tue Jan 15 12:38:22 2008 Subject: cvs commit: src/share/man/man9 Makefile sleep.9 Message-ID: <200801152038.m0FKcHuP027553@repoman.freebsd.org> jhb 2008-01-15 20:38:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man9 Makefile sleep.9 Log: MFC: Sync up to rev 1.49 of sleep.9. Revision Changes Path 1.260.2.11 +1 -0 src/share/man/man9/Makefile 1.45.2.2 +96 -43 src/share/man/man9/sleep.9 From jhb at FreeBSD.org Tue Jan 15 12:39:40 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Tue Jan 15 12:39:41 2008 Subject: cvs commit: src/share/man/man9 sleep.9 Message-ID: <200801152039.m0FKdddI027625@repoman.freebsd.org> jhb 2008-01-15 20:39:39 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man9 sleep.9 Log: MFC: Correct first release for msleep_spin(). Revision Changes Path 1.45.2.3 +1 -1 src/share/man/man9/sleep.9 From jhb at FreeBSD.org Tue Jan 15 13:40:49 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Tue Jan 15 13:40:50 2008 Subject: cvs commit: src/sys/dev/pci pci_user.c Message-ID: <200801152140.m0FLemWu047390@repoman.freebsd.org> jhb 2008-01-15 21:40:47 UTC FreeBSD src repository Modified files: sys/dev/pci pci_user.c Log: Don't cache the new-bus name of a PCI device in the PCI conf structure, but reread it from the device_t every time the device list is fetched. Previously the device name in pciconf -l would not be updated when a driver was unloaded or if a device was detached and attached to a different driver. MFC after: 1 week PR: kern/104777 Submitted by: "Iasen Kostoff" tbyte | otel net Revision Changes Path 1.26 +4 -1 src/sys/dev/pci/pci_user.c From jhb at FreeBSD.org Tue Jan 15 14:01:26 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Tue Jan 15 14:01:30 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_sge.c src/sys/dev/cxgb/sys uipc_mvec.c Message-ID: <200801152201.m0FM1QJi053615@repoman.freebsd.org> jhb 2008-01-15 22:01:26 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_sge.c sys/dev/cxgb/sys uipc_mvec.c Log: Use '%zd' to print PIO_LEN since it involves a size_t (via sizeof()) to appease the tinderbox on 32-bit platforms. Tested on: amd64, i386 Revision Changes Path 1.43 +1 -1 src/sys/dev/cxgb/cxgb_sge.c 1.22 +1 -1 src/sys/dev/cxgb/sys/uipc_mvec.c From des at des.no Tue Jan 15 14:13:40 2008 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Tue Jan 15 14:13:51 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <478BE651.1020901@FreeBSD.org> (Kris Kennaway's message of "Mon\, 14 Jan 2008 23\:46\:41 +0100") References: <200801080800.m08806jI012963@repoman.freebsd.org> <478A8FFE.8080602@freebsd.org> <478A95F2.1070709@FreeBSD.org> <478AA9E4.2010807@kientzle.com> <478ABC4B.8080601@FreeBSD.org> <20080114181154.GA2286@dragon.NUXI.org> <478BC55B.2060202@FreeBSD.org> <20080114223239.GC56062@VARK.MIT.EDU> <478BE651.1020901@FreeBSD.org> Message-ID: <86y7aqbuuw.fsf@ds4.des.no> Kris Kennaway writes: > No, you'd have to duplicate the do-extract code (or add a special > variable for those 4 ports). I'd much rather wait to see what Tim and > Dag-Erling can come up with. Take it easy everyone, no special-casing will be necessary as I fully intend to add support for them to libarchive. The four files I've identified are: /usr/ports/distfiles/XMMS-AfterStep.zip /usr/ports/distfiles/mathfonts-4.1/MathFonts_TrueType_41.exe /usr/ports/distfiles/q2-3.20-x86-full.exe /usr/ports/distfiles/wordsall.zip Two of them are self-extracting. There is no easy way to figure out how much to skip. I wrote a PE decoder which located the correct section, but the zip file is preceded by decoder-specific data which I couldn't decode. The correct starting position can be obtained from the central directory, which is at the end of the file, which means libarchive needs full seek support. I am working on that, but it requires a few changes in the API between the libarchive core and the support modules, which is a published API, so I need to discuss this with Tim (who until recently was away on vacation). AFAICT, the other two files simply have a dummy local header ("PK00") at the beginning, which requires a trivial modification to the existing zip support code to handle. DES -- Dag-Erling Sm?rgrav - des@des.no From jhb at FreeBSD.org Tue Jan 15 14:26:38 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Tue Jan 15 14:26:43 2008 Subject: cvs commit: src/sys/dev/ppbus ppbconf.c ppbconf.h Message-ID: <200801152226.m0FMQcn2065712@repoman.freebsd.org> jhb 2008-01-15 22:26:38 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/ppbus ppbconf.c ppbconf.h Log: MFC: Use a dummy interrupt handler to work around lpt(4) interrupt problems. Approved by: re (gnn) Revision Changes Path 1.26.2.1 +37 -0 src/sys/dev/ppbus/ppbconf.c 1.19.20.1 +3 -0 src/sys/dev/ppbus/ppbconf.h From jhb at FreeBSD.org Tue Jan 15 14:28:15 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Tue Jan 15 14:28:20 2008 Subject: cvs commit: src/sys/dev/ppbus ppbconf.c ppbconf.h Message-ID: <200801152228.m0FMSFax065987@repoman.freebsd.org> jhb 2008-01-15 22:28:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/dev/ppbus ppbconf.c ppbconf.h Log: MFC: Use a dummy interrupt handler to work around lpt(4) interrupt problems. Approved by: re (gnn) Revision Changes Path 1.26.4.1 +37 -0 src/sys/dev/ppbus/ppbconf.c 1.19.24.1 +3 -0 src/sys/dev/ppbus/ppbconf.h From kip.macy at gmail.com Tue Jan 15 15:13:27 2008 From: kip.macy at gmail.com (Kip Macy) Date: Tue Jan 15 15:13:30 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_sge.c src/sys/dev/cxgb/sys uipc_mvec.c In-Reply-To: <200801152201.m0FM1QJi053615@repoman.freebsd.org> References: <200801152201.m0FM1QJi053615@repoman.freebsd.org> Message-ID: Thanks. Sorry about that. -Kip On Jan 15, 2008 2:01 PM, John Baldwin wrote: > jhb 2008-01-15 22:01:26 UTC > > FreeBSD src repository > > Modified files: > sys/dev/cxgb cxgb_sge.c > sys/dev/cxgb/sys uipc_mvec.c > Log: > Use '%zd' to print PIO_LEN since it involves a size_t (via sizeof()) to > appease the tinderbox on 32-bit platforms. > > Tested on: amd64, i386 > > Revision Changes Path > 1.43 +1 -1 src/sys/dev/cxgb/cxgb_sge.c > 1.22 +1 -1 src/sys/dev/cxgb/sys/uipc_mvec.c > From das at FreeBSD.org Tue Jan 15 15:31:24 2008 From: das at FreeBSD.org (David Schultz) Date: Tue Jan 15 15:31:29 2008 Subject: cvs commit: src/lib/msun/src s_rintl.c Message-ID: <200801152331.m0FNVOGl099079@repoman.freebsd.org> das 2008-01-15 23:31:24 UTC FreeBSD src repository Modified files: lib/msun/src s_rintl.c Log: Optimize this a bit better. Submitted by: bde (although these aren't all of his changes) Revision Changes Path 1.2 +18 -13 src/lib/msun/src/s_rintl.c From cperciva at FreeBSD.org Tue Jan 15 15:35:46 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Tue Jan 15 15:35:48 2008 Subject: cvs commit: src UPDATING Message-ID: <200801152335.m0FNZkMV001001@repoman.freebsd.org> cperciva 2008-01-15 23:35:46 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_5) . UPDATING Log: Fix date of last advisory -- January 14th, not January 18th. Approved by: so (cperciva) Revision Changes Path 1.342.2.35.2.19 +1 -1 src/UPDATING From cperciva at FreeBSD.org Tue Jan 15 15:36:10 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Tue Jan 15 15:36:11 2008 Subject: cvs commit: src UPDATING Message-ID: <200801152336.m0FNa9TE001107@repoman.freebsd.org> cperciva 2008-01-15 23:36:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_1) . UPDATING Log: Fix date of last advisory -- January 14th, not January 18th. Approved by: so (cperciva) Revision Changes Path 1.416.2.22.2.25 +1 -1 src/UPDATING From cperciva at FreeBSD.org Tue Jan 15 15:36:53 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Tue Jan 15 15:36:58 2008 Subject: cvs commit: src UPDATING Message-ID: <200801152336.m0FNarCQ001341@repoman.freebsd.org> cperciva 2008-01-15 23:36:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_2) . UPDATING Log: Fix date of last advisory -- January 14th, not January 18th. Approved by: so (cperciva) Revision Changes Path 1.416.2.29.2.14 +1 -1 src/UPDATING From cperciva at FreeBSD.org Tue Jan 15 15:37:07 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Tue Jan 15 15:37:11 2008 Subject: cvs commit: src UPDATING Message-ID: <200801152337.m0FNb7kD001441@repoman.freebsd.org> cperciva 2008-01-15 23:37:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) . UPDATING Log: Fix date of last advisory -- January 14th, not January 18th. Approved by: re (kensmith) Revision Changes Path 1.507.2.3.2.2 +1 -1 src/UPDATING From kmacy at FreeBSD.org Tue Jan 15 16:26:05 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Tue Jan 15 16:26:10 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_adapter.h Message-ID: <200801160026.m0G0Q4NY024146@repoman.freebsd.org> kmacy 2008-01-16 00:26:04 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_adapter.h Log: put tx queue size back to 1024 Revision Changes Path 1.29 +0 -4 src/sys/dev/cxgb/cxgb_adapter.h From kmacy at FreeBSD.org Tue Jan 15 16:28:30 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Tue Jan 15 16:28:32 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_sge.c src/sys/dev/cxgb/sys mvec.h uipc_mvec.c Message-ID: <200801160028.m0G0SUQe025047@repoman.freebsd.org> kmacy 2008-01-16 00:28:30 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_sge.c sys/dev/cxgb/sys mvec.h uipc_mvec.c Log: Fix mbuf leak caused by freeing packet zone clusters but not their associated mbufs - Track packet zone mbufs separately from other mbufs - free packet zone buffers via m_free rather than trying to manage the refcount as with clusters - its refcount and management seems to be "special" Revision Changes Path 1.44 +7 -3 src/sys/dev/cxgb/cxgb_sge.c 1.13 +11 -3 src/sys/dev/cxgb/sys/mvec.h 1.23 +27 -23 src/sys/dev/cxgb/sys/uipc_mvec.c From njl at FreeBSD.org Tue Jan 15 17:05:22 2008 From: njl at FreeBSD.org (Nate Lawson) Date: Tue Jan 15 17:05:24 2008 Subject: cvs commit: src/sys/kern kern_cpu.c Message-ID: <200801160105.m0G15MUC054327@repoman.freebsd.org> njl 2008-01-16 01:05:22 UTC FreeBSD src repository Modified files: sys/kern kern_cpu.c Log: Remove duplicate cpufreq levels, i.e. ones that are within 25 Mhz of each other. The first one survives, the rest are removed. So far, it appears only some acpi_perf(4) BIOS tables have these invalid states, but address this in the core to be sure to handle other potential driver data. PR: kern/114722 Tested by: stefan.lambrev / moneybookers.com MFC after: 3 days Revision Changes Path 1.29 +11 -0 src/sys/kern/kern_cpu.c From njl at FreeBSD.org Tue Jan 15 17:18:37 2008 From: njl at FreeBSD.org (Nate Lawson) Date: Tue Jan 15 17:18:39 2008 Subject: cvs commit: src/sys/contrib/dev/acpica evgpe.c src/sys/dev/acpica/Osd OsdSchedule.c Message-ID: <200801160118.m0G1Ibqx059867@repoman.freebsd.org> njl 2008-01-16 01:18:36 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/contrib/dev/acpica evgpe.c sys/dev/acpica/Osd OsdSchedule.c Log: MFC: queue an asynch handler to re-enable a level-triggered GPE Approved by: re Revision Changes Path 1.1.1.12.2.1 +19 -3 src/sys/contrib/dev/acpica/evgpe.c 1.39.2.1 +7 -3 src/sys/dev/acpica/Osd/OsdSchedule.c From njl at FreeBSD.org Tue Jan 15 17:22:15 2008 From: njl at FreeBSD.org (Nate Lawson) Date: Tue Jan 15 17:22:28 2008 Subject: cvs commit: src/sys/contrib/dev/acpica evgpe.c src/sys/dev/acpica/Osd OsdSchedule.c Message-ID: <200801160122.m0G1MF0w062207@repoman.freebsd.org> njl 2008-01-16 01:22:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/contrib/dev/acpica evgpe.c sys/dev/acpica/Osd OsdSchedule.c Log: MFC: queue an asynch handler to re-enable a level-triggered GPE Approved by: re Revision Changes Path 1.1.1.12.4.1 +19 -3 src/sys/contrib/dev/acpica/evgpe.c 1.39.4.1 +7 -3 src/sys/dev/acpica/Osd/OsdSchedule.c From kmacy at FreeBSD.org Tue Jan 15 18:39:34 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Tue Jan 15 18:39:36 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_sge.c src/sys/dev/cxgb/sys uipc_mvec.c Message-ID: <200801160239.m0G2dYf5006447@repoman.freebsd.org> kmacy 2008-01-16 02:39:33 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_sge.c sys/dev/cxgb/sys uipc_mvec.c Log: remove superfluous debug printfs Revision Changes Path 1.45 +1 -5 src/sys/dev/cxgb/cxgb_sge.c 1.24 +0 -3 src/sys/dev/cxgb/sys/uipc_mvec.c From kientzle at freebsd.org Tue Jan 15 19:48:59 2008 From: kientzle at freebsd.org (Tim Kientzle) Date: Tue Jan 15 19:49:10 2008 Subject: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c In-Reply-To: <86y7aqbuuw.fsf@ds4.des.no> References: <200801080800.m08806jI012963@repoman.freebsd.org> <478A8FFE.8080602@freebsd.org> <478A95F2.1070709@FreeBSD.org> <478AA9E4.2010807@kientzle.com> <478ABC4B.8080601@FreeBSD.org> <20080114181154.GA2286@dragon.NUXI.org> <478BC55B.2060202@FreeBSD.org> <20080114223239.GC56062@VARK.MIT.EDU> <478BE651.1020901@FreeBSD.org> <86y7aqbuuw.fsf@ds4.des.no> Message-ID: <478D7EA7.8080003@freebsd.org> > The four files I've identified are: Ah! Thanks for the list. Now that I'm back from vacation, I've been meaning to ask you for that. > Two of them are self-extracting. ... requires a few changes > in the API between the libarchive core and the support modules, which is > a published API ... I still have a faint hope that we can support this without the changes DES is proposing, but he's probably right. (In particular, I would like to be able to extract SFX archives from stdin, which requires that we avoid seeking.) I hope to do some experiments in the next few days to see if I can come up with anything. Though by then, DES may well have demonstrated that his approach isn't as complicated as I thought. > AFAICT, the other two files simply have a dummy local header ("PK00") at > the beginning, which requires a trivial modification to the existing zip > support code to handle. I just committed a fix for this. PK00 is documented as a marker that indicates a multi-part Zip archive which has only one part. libarchive in -CURRENT now recognizes and ignores this marker. 993 down, two to go. ;-) Tim Kientzle From keramida at FreeBSD.org Tue Jan 15 22:59:22 2008 From: keramida at FreeBSD.org (Giorgos Keramidas) Date: Tue Jan 15 22:59:24 2008 Subject: cvs commit: src/sys/boot/forth loader.conf.5 Message-ID: <200801160659.m0G6xMIx056935@repoman.freebsd.org> keramida 2008-01-16 06:59:22 UTC FreeBSD src repository (doc committer) Modified files: sys/boot/forth loader.conf.5 Log: Document that loader(8) stops reading `loader.conf' when it encounters a syntax error, and add a tip about adding first the `vital' options and then experimental ones. PR: docs/119658 Submitted by: Julian Stacey, jhs at berklix.org Revision Changes Path 1.27 +10 -0 src/sys/boot/forth/loader.conf.5 From keramida at FreeBSD.org Tue Jan 15 23:00:56 2008 From: keramida at FreeBSD.org (Giorgos Keramidas) Date: Tue Jan 15 23:00:59 2008 Subject: cvs commit: src/sys/boot/forth loader.conf.5 Message-ID: <200801160700.m0G70t0n057319@repoman.freebsd.org> keramida 2008-01-16 07:00:55 UTC FreeBSD src repository (doc committer) Modified files: sys/boot/forth loader.conf.5 Log: Bump manpage date for rev 1.27 MFC after: 3 days Revision Changes Path 1.28 +1 -1 src/sys/boot/forth/loader.conf.5 From wearabnet at yahoo.ca Wed Jan 16 00:23:54 2008 From: wearabnet at yahoo.ca (Abdullah Ibn Hamad Al-Marri) Date: Wed Jan 16 00:23:58 2008 Subject: cvs commit: src/sys/dev/re if_re.c Message-ID: <418844.85458.qm@web33701.mail.mud.yahoo.com> ----- Original Message ---- > From: Pyun YongHyeon > To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; cvs-all@FreeBSD.org > Sent: Tuesday, January 15, 2008 6:47:24 AM > Subject: cvs commit: src/sys/dev/re if_re.c > > yongari 2008-01-15 03:47:24 UTC > > FreeBSD src repository > > Modified files: > sys/dev/re if_re.c > Log: > Fix build. > > Revision Changes Path > 1.102 +1 -1 src/sys/dev/re/if_re.c Hello Pyun, Thank you for the hard work to make re works better. Could you please make a patch that I could apply against RELENG_7? Regards, -Abdullah Ibn Hamad Al-Marri Arab Portal http://www.WeArab.Net/ ____________________________________________________________________________________ Looking for last minute shopping deals? Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsearch/category.php?category=shopping From joel at FreeBSD.org Wed Jan 16 05:41:56 2008 From: joel at FreeBSD.org (Joel Dahl) Date: Wed Jan 16 05:42:00 2008 Subject: cvs commit: CVSROOT access.unclassified Message-ID: <200801161341.m0GDftMP029442@repoman.freebsd.org> joel 2008-01-16 13:41:55 UTC FreeBSD src repository (doc committer) Removed files: . access.unclassified Log: Kill this file. It's empty and we have no use for it. Reviewed by: peter, dhw Approved by: core Revision Changes Path 1.651 +0 -8 CVSROOT/access.unclassified (dead) From remko at FreeBSD.org Wed Jan 16 05:54:40 2008 From: remko at FreeBSD.org (Remko Lodder) Date: Wed Jan 16 05:54:42 2008 Subject: cvs commit: src/sys/dev/drm drm_drv.c Message-ID: <200801161354.m0GDse5d036623@repoman.freebsd.org> remko 2008-01-16 13:54:40 UTC FreeBSD src repository Modified files: sys/dev/drm drm_drv.c Log: Dont accidentally remove a filesocket which is still in use. This gives problems when the DRM driver is loaded and the AIXGL extension is loaded , the AIXGL driver requests a drm_close and this will cause the radeon driver to fail while starting X windows. PR: kern/114688 Submitted by: vehemens Prodded by: Robert Noland Approved by: imp (mentor, a while ago already), anholt MFC After: 1 week Revision Changes Path 1.7 +9 -6 src/sys/dev/drm/drm_drv.c From brueffer at FreeBSD.org Wed Jan 16 07:05:51 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Wed Jan 16 07:05:55 2008 Subject: cvs commit: src Makefile.inc1 Message-ID: <200801161505.m0GF5okm052693@repoman.freebsd.org> brueffer 2008-01-16 15:05:49 UTC FreeBSD src repository Modified files: . Makefile.inc1 Log: Remove WITHOUT_FORTRAN from the XMAKE target, it doesn't exist anymore. Reviewed by: imp, kan Approved by: rwatson (mentor) MFC after: 3 days Revision Changes Path 1.592 +1 -1 src/Makefile.inc1 From jhb at FreeBSD.org Wed Jan 16 07:51:24 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Wed Jan 16 07:51:30 2008 Subject: cvs commit: src/sys/kern uipc_shm.c src/tools/regression/posixshm Makefile posixshm.c posixshm.t test.c test.h Message-ID: <200801161551.m0GFpO9f059439@repoman.freebsd.org> jhb 2008-01-16 15:51:24 UTC FreeBSD src repository Modified files: sys/kern uipc_shm.c Added files: tools/regression/posixshm Makefile posixshm.c posixshm.t test.c test.h Log: Add a set of regression tests for the POSIX shm API (shm_open(2) and shm_unlink(2)). Revision Changes Path 1.2 +0 -3 src/sys/kern/uipc_shm.c 1.1 +9 -0 src/tools/regression/posixshm/Makefile (new) 1.1 +627 -0 src/tools/regression/posixshm/posixshm.c (new) 1.1 +5 -0 src/tools/regression/posixshm/posixshm.t (new) 1.1 +128 -0 src/tools/regression/posixshm/test.c (new) 1.1 +59 -0 src/tools/regression/posixshm/test.h (new) From obrien at FreeBSD.org Wed Jan 16 09:15:59 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Wed Jan 16 09:16:06 2008 Subject: cvs commit: src/gnu/usr.bin/cvs/contrib Makefile Message-ID: <200801161715.m0GHFxfJ083200@repoman.freebsd.org> obrien 2008-01-16 17:15:59 UTC FreeBSD src repository Modified files: gnu/usr.bin/cvs/contrib Makefile Log: Use a phony .POSIX target. This seems to be the way to turn off the stuff in src/usr.bin/make/main.c rev 1.161. Revision Changes Path 1.20 +2 -0 src/gnu/usr.bin/cvs/contrib/Makefile From obrien at FreeBSD.org Wed Jan 16 09:16:37 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Wed Jan 16 09:16:39 2008 Subject: cvs commit: src/gnu/usr.bin/cvs Makefile Message-ID: <200801161716.m0GHGaRi083253@repoman.freebsd.org> obrien 2008-01-16 17:16:36 UTC FreeBSD src repository Modified files: gnu/usr.bin/cvs Makefile Log: Use a phony .POSIX target. This seems to be the way to turn off the stuff in src/usr.bin/make/main.c rev 1.161. Revision Changes Path 1.18 +1 -1 src/gnu/usr.bin/cvs/Makefile From sgk at troutmask.apl.washington.edu Wed Jan 16 10:03:38 2008 From: sgk at troutmask.apl.washington.edu (Steve Kargl) Date: Wed Jan 16 10:03:42 2008 Subject: cvs commit: src Makefile.inc1 In-Reply-To: <200801161505.m0GF5okm052693@repoman.freebsd.org> References: <200801161505.m0GF5okm052693@repoman.freebsd.org> Message-ID: <20080116180341.GA93583@troutmask.apl.washington.edu> On Wed, Jan 16, 2008 at 03:05:49PM +0000, Christian Brueffer wrote: > brueffer 2008-01-16 15:05:49 UTC > > FreeBSD src repository > > Modified files: > . Makefile.inc1 > Log: > Remove WITHOUT_FORTRAN from the XMAKE target, it doesn't exist anymore. > This may be an incomplete commit. Try 'find /usr/src -name Makefile | xargs grep -i fortran' You should also remove libg2c and cc/f77. -- Steve From jhb at FreeBSD.org Wed Jan 16 10:47:08 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Wed Jan 16 10:47:13 2008 Subject: cvs commit: src/sys/dev/acpica acpi_hpet.c acpi_hpet.h Message-ID: <200801161847.m0GIl7Bb097855@repoman.freebsd.org> jhb 2008-01-16 18:47:07 UTC FreeBSD src repository Modified files: sys/dev/acpica acpi_hpet.c Added files: sys/dev/acpica acpi_hpet.h Log: Add a header containing constants for the various HPET registers and their fields and update the code to match. The PR served more as an inspiration than providing the actual diffs. MFC after: 1 week PR: kern/112544 Revision Changes Path 1.14 +19 -23 src/sys/dev/acpica/acpi_hpet.c 1.1 +65 -0 src/sys/dev/acpica/acpi_hpet.h (new) From delphij at FreeBSD.org Wed Jan 16 11:27:44 2008 From: delphij at FreeBSD.org (Xin LI) Date: Wed Jan 16 11:27:47 2008 Subject: cvs commit: src/usr.bin/systat cmds.c convtbl.c devs.c fetch.c icmp.c icmp6.c iostat.c ip.c ip6.c keyboard.c main.c mbufs.c netcmds.c netstat.c pigs.c swap.c tcp.c vmstat.c Message-ID: <200801161927.m0GJRhRU005134@repoman.freebsd.org> delphij 2008-01-16 19:27:43 UTC FreeBSD src repository Modified files: usr.bin/systat cmds.c convtbl.c devs.c fetch.c icmp.c icmp6.c iostat.c ip.c ip6.c keyboard.c main.c mbufs.c netcmds.c netstat.c pigs.c swap.c tcp.c vmstat.c Log: ANSIfy and remove register. Resulting binary verified with strip(1)+md5(1). Revision Changes Path 1.6 +4 -7 src/usr.bin/systat/cmds.c 1.13 +1 -1 src/usr.bin/systat/convtbl.c 1.10 +1 -1 src/usr.bin/systat/devs.c 1.6 +3 -10 src/usr.bin/systat/fetch.c 1.6 +1 -2 src/usr.bin/systat/icmp.c 1.4 +1 -2 src/usr.bin/systat/icmp6.c 1.25 +12 -21 src/usr.bin/systat/iostat.c 1.8 +1 -2 src/usr.bin/systat/ip.c 1.4 +1 -2 src/usr.bin/systat/ip6.c 1.3 +1 -1 src/usr.bin/systat/keyboard.c 1.21 +5 -8 src/usr.bin/systat/main.c 1.21 +6 -7 src/usr.bin/systat/mbufs.c 1.13 +16 -26 src/usr.bin/systat/netcmds.c 1.29 +14 -30 src/usr.bin/systat/netstat.c 1.25 +8 -10 src/usr.bin/systat/pigs.c 1.36 +7 -8 src/usr.bin/systat/swap.c 1.15 +1 -2 src/usr.bin/systat/tcp.c 1.84 +16 -29 src/usr.bin/systat/vmstat.c From remko at FreeBSD.org Wed Jan 16 11:36:22 2008 From: remko at FreeBSD.org (Remko Lodder) Date: Wed Jan 16 11:36:24 2008 Subject: cvs commit: src/lib/libc/sys access.2 Message-ID: <200801161936.m0GJaMkO006565@repoman.freebsd.org> remko 2008-01-16 19:36:22 UTC FreeBSD src repository Modified files: lib/libc/sys access.2 Log: Fix some style nits. Prodded by: brueffer MFC After: 3 days Revision Changes Path 1.21 +4 -4 src/lib/libc/sys/access.2 From kmacy at FreeBSD.org Wed Jan 16 13:33:35 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Wed Jan 16 13:33:37 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_main.c Message-ID: <200801162133.m0GLXYsG035204@repoman.freebsd.org> kmacy 2008-01-16 21:33:34 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_main.c Log: Fix lock ordering panic by not calling ether_ioctl with port lock held Reported by: rrs Revision Changes Path 1.47 +2 -2 src/sys/dev/cxgb/cxgb_main.c From rwatson at FreeBSD.org Wed Jan 16 13:40:06 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Wed Jan 16 13:40:11 2008 Subject: cvs commit: src/sys/kern uipc_sem.c Message-ID: <200801162140.m0GLe63U035464@repoman.freebsd.org> rwatson 2008-01-16 21:40:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern uipc_sem.c Log: Merge uipc_sem.c:1.30 from HEAD to RELENG_7: Free MAC label on a POSIX semaphore when the semaphore is freed. Submitted by: jhb Approved by: re (kensmith) Revision Changes Path 1.28.2.1 +3 -0 src/sys/kern/uipc_sem.c From peter at wemm.org Wed Jan 16 14:29:08 2008 From: peter at wemm.org (Peter Wemm) Date: Wed Jan 16 14:29:19 2008 Subject: cvs commit: CVSROOT access.unclassified In-Reply-To: <200801161341.m0GDftMP029442@repoman.freebsd.org> References: <200801161341.m0GDftMP029442@repoman.freebsd.org> Message-ID: On Jan 16, 2008 5:41 AM, Joel Dahl wrote: > joel 2008-01-16 13:41:55 UTC > > FreeBSD src repository (doc committer) > > Removed files: > . access.unclassified > Log: > Kill this file. It's empty and we have no use for it. > > Reviewed by: peter, dhw > Approved by: core > > Revision Changes Path > 1.651 +0 -8 CVSROOT/access.unclassified (dead) > Ironically, I just found something that used it. My scripts that do the activity dates etc referenced it. Oh well, they needed to be fixed. :) -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From cognet at FreeBSD.org Wed Jan 16 14:43:51 2008 From: cognet at FreeBSD.org (Olivier Houchard) Date: Wed Jan 16 14:43:55 2008 Subject: cvs commit: src/sys/arm/arm support.S Message-ID: <200801162243.m0GMhoqV046648@repoman.freebsd.org> cognet 2008-01-16 22:43:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/arm/arm support.S Log: MFC rev 1.14: Back when I committed the arm port, I've been asked to move memcpy/memset/memcmp and friends from libkern/arm to arm/arm/support.S, and so I did, but in the process, I didn't add the appropriate copyrights. This is a major oversight from me, and I apology to the NetBSD people for it. Approved by: re (mux) Revision Changes Path 1.12.2.1 +69 -0 src/sys/arm/arm/support.S From cognet at FreeBSD.org Wed Jan 16 14:44:24 2008 From: cognet at FreeBSD.org (Olivier Houchard) Date: Wed Jan 16 14:44:28 2008 Subject: cvs commit: src/sys/arm/arm support.S Message-ID: <200801162244.m0GMiNRW046696@repoman.freebsd.org> cognet 2008-01-16 22:44:23 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/arm/arm support.S Log: MFC rev 1.14: Back when I committed the arm port, I've been asked to move memcpy/memset/memcmp and friends from libkern/arm to arm/arm/support.S, and so I did, but in the process, I didn't add the appropriate copyrights. This is a major oversight from me, and I apology to the NetBSD people for it. Approved by: re (mux) Revision Changes Path 1.12.4.1 +69 -0 src/sys/arm/arm/support.S From cognet at FreeBSD.org Wed Jan 16 14:45:04 2008 From: cognet at FreeBSD.org (Olivier Houchard) Date: Wed Jan 16 14:45:05 2008 Subject: cvs commit: src/sys/arm/arm support.S Message-ID: <200801162245.m0GMj3Tm046776@repoman.freebsd.org> cognet 2008-01-16 22:45:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/arm/arm support.S Log: MFC rev 1.14: Back when I committed the arm port, I've been asked to move memcpy/memset/memcmp and friends from libkern/arm to arm/arm/support.S, and so I did, but in the process, I didn't add the appropriate copyrights. This is a major oversight from me, and I apology to the NetBSD people for it. Approved by: re (mux) Revision Changes Path 1.9.2.1 +69 -0 src/sys/arm/arm/support.S From kensmith at FreeBSD.org Wed Jan 16 15:33:22 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Wed Jan 16 15:33:28 2008 Subject: cvs commit: CVSROOT approvers Message-ID: <200801162333.m0GNXLCR055221@repoman.freebsd.org> kensmith 2008-01-16 23:33:21 UTC FreeBSD src repository Modified files: . approvers Log: Release the code freeze on RELENG_7 but re@ requests it be considered a "code slush". No large sweeping changes until 7.0 is out please. We want to minimize headaches people have merging in things that are meant to be in 7.0-RELEASE. Approved by: core (implicit) Revision Changes Path 1.46 +1 -1 CVSROOT/approvers From rodrigc at FreeBSD.org Wed Jan 16 20:24:54 2008 From: rodrigc at FreeBSD.org (Craig Rodrigues) Date: Wed Jan 16 20:24:57 2008 Subject: cvs commit: src/sys/kern vfs_mount.c Message-ID: <200801170424.m0H4OreH012480@repoman.freebsd.org> rodrigc 2008-01-17 04:24:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern vfs_mount.c Log: MFC: 1.270 - In vfs_scanopt(), make sure that the mount option value is not NULL before calling vsscanf(). PR: 118531 MFC: 1.268 - Internally convert "rdonly" mount option to "ro". Approved by: re (kensmith) Revision Changes Path 1.265.2.2 +8 -3 src/sys/kern/vfs_mount.c From pjd at FreeBSD.org Wed Jan 16 23:47:04 2008 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Wed Jan 16 23:47:05 2008 Subject: cvs commit: src/sys/vm vm_kern.c Message-ID: <200801170747.m0H7l4Lg073106@repoman.freebsd.org> pjd 2008-01-17 07:47:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/vm vm_kern.c Log: MFC: sys/vm/vm_kern.c 1.131 When one tries to allocate memory with the M_WAITOK flag and we are short in address space in kmem map call vm_lowmem event in a loop and wait a bit for subsystems to reclaim some memory which in turn will reclaim address space as well. Note, this is a work-around. Reviewed by: alc Approved by: alc, re (gnn) Revision Changes Path 1.128.2.1 +13 -6 src/sys/vm/vm_kern.c From pjd at FreeBSD.org Wed Jan 16 23:49:17 2008 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Wed Jan 16 23:49:18 2008 Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs vdev.c Message-ID: <200801170749.m0H7nHtt073180@repoman.freebsd.org> pjd 2008-01-17 07:49:16 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/contrib/opensolaris/uts/common/fs/zfs vdev.c Log: Close access to vdev when setting state to anything but open state. This fixes replacing drive in place, eg. zpool replace tank da1 da1. Before the fix, it complained that device is already open. Obtained from: OpenSolaris Approved by: re (gnn) Revision Changes Path 1.3.2.1 +11 -0 src/sys/contrib/opensolaris/uts/common/fs/zfs/vdev.c From pjd at FreeBSD.org Wed Jan 16 23:50:35 2008 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Wed Jan 16 23:50:39 2008 Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zvol.c Message-ID: <200801170750.m0H7oYdl073539@repoman.freebsd.org> pjd 2008-01-17 07:50:34 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/contrib/opensolaris/uts/common/fs/zfs zvol.c Log: MFC: sys/contrib/opensolaris/uts/common/fs/zfs/zvol.c 1.4 Call zil_commit() (if ZIL is not disabled) after every non-read request (BIO_WRITE and BIO_FLUSH) as it is done is Solaris. The difference is that Solaris calls it only for sync requests, but we can't say in GEOM if the request is sync or async, so we do it for every request. Approved by: re (gnn) Revision Changes Path 1.2.2.1 +11 -11 src/sys/contrib/opensolaris/uts/common/fs/zfs/zvol.c From thompsa at FreeBSD.org Thu Jan 17 01:46:19 2008 From: thompsa at FreeBSD.org (Andrew Thompson) Date: Thu Jan 17 01:46:22 2008 Subject: cvs commit: src/sys/net if_bridge.c Message-ID: <200801170946.m0H9kHIp001777@repoman.freebsd.org> thompsa 2008-01-17 09:46:17 UTC FreeBSD src repository Modified files: sys/net if_bridge.c Log: Sync from OpenBSD r1.118, nuke clause 3 & 4. Revision Changes Path 1.110 +0 -5 src/sys/net/if_bridge.c From cognet at FreeBSD.org Thu Jan 17 04:41:59 2008 From: cognet at FreeBSD.org (Olivier Houchard) Date: Thu Jan 17 04:42:03 2008 Subject: cvs commit: src/sys/arm/arm pmap.c Message-ID: <200801171241.m0HCfxOx038150@repoman.freebsd.org> cognet 2008-01-17 12:41:59 UTC FreeBSD src repository Modified files: sys/arm/arm pmap.c Log: Unbreak build by adding the missing parameter to pmap_enter(). Revision Changes Path 1.97 +2 -1 src/sys/arm/arm/pmap.c From bde at FreeBSD.org Thu Jan 17 05:12:47 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Thu Jan 17 05:12:49 2008 Subject: cvs commit: src/sys/amd64/include _types.h float.h Message-ID: <200801171312.m0HDCllo053622@repoman.freebsd.org> bde 2008-01-17 13:12:47 UTC FreeBSD src repository Modified files: sys/amd64/include _types.h float.h Log: Translate from the i386. All FP constants and operations are evaluated in the range and precision of their type(s) on amd64, but FLT_EVAL_METHOD said that they were evalated in the "interesting" (buggy) i387 methods. float_t was broken compatibly with FLT_EVAL_METHOD. These definitions seem to be broken on powerpc and possibly on arm. float_t is float on powerpc with gcc [-notraditional] according to glibc, and FLT_EVAL_METHOD is marked with XXX on arm. Revision Changes Path 1.12 +1 -1 src/sys/amd64/include/_types.h 1.16 +1 -1 src/sys/amd64/include/float.h From pjd at FreeBSD.org Thu Jan 17 06:57:51 2008 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Thu Jan 17 06:57:55 2008 Subject: cvs commit: src/sys/vm vm_kern.c Message-ID: <200801171457.m0HEvowd069821@repoman.freebsd.org> pjd 2008-01-17 14:57:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/vm vm_kern.c Log: MFC: sys/vm/vm_kern.c 1.131 When one tries to allocate memory with the M_WAITOK flag and we are short in address space in kmem map call vm_lowmem event in a loop and wait a bit for subsystems to reclaim some memory which in turn will reclaim address space as well. Note, this is a work-around. Reviewed by: alc Approved by: alc Approved by: re (gnn) Revision Changes Path 1.128.4.1 +13 -6 src/sys/vm/vm_kern.c From pjd at FreeBSD.org Thu Jan 17 06:58:49 2008 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Thu Jan 17 06:58:51 2008 Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs vdev.c Message-ID: <200801171458.m0HEwnjb069885@repoman.freebsd.org> pjd 2008-01-17 14:58:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/contrib/opensolaris/uts/common/fs/zfs vdev.c Log: MFC: sys/contrib/opensolaris/uts/common/fs/zfs/vdev.c 1.4 Close access to vdev when setting state to anything but open state. This fixes replacing drive in place, eg. zpool replace tank da1 da1. Before the fix, it complained that device is already open. Obtained from: OpenSolaris Approved by: re (gnn) Revision Changes Path 1.3.4.1 +11 -0 src/sys/contrib/opensolaris/uts/common/fs/zfs/vdev.c From pjd at FreeBSD.org Thu Jan 17 06:59:27 2008 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Thu Jan 17 06:59:45 2008 Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs zvol.c Message-ID: <200801171459.m0HExQsJ069931@repoman.freebsd.org> pjd 2008-01-17 14:59:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/contrib/opensolaris/uts/common/fs/zfs zvol.c Log: MFC: sys/contrib/opensolaris/uts/common/fs/zfs/zvol.c 1.4 Call zil_commit() (if ZIL is not disabled) after every non-read request (BIO_WRITE and BIO_FLUSH) as it is done is Solaris. The difference is that Solaris calls it only for sync requests, but we can't say in GEOM if the request is sync or async, so we do it for every request. Approved by: re (gnn) Revision Changes Path 1.2.4.1 +11 -11 src/sys/contrib/opensolaris/uts/common/fs/zfs/zvol.c From bde at FreeBSD.org Thu Jan 17 08:39:07 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Thu Jan 17 08:39:09 2008 Subject: cvs commit: src/lib/libc/amd64 _fpmath.h src/lib/libc/i386 _fpmath.h src/lib/libc/ia64 _fpmath.h Message-ID: <200801171639.m0HGd7pn089315@repoman.freebsd.org> bde 2008-01-17 16:39:07 UTC FreeBSD src repository Modified files: lib/libc/amd64 _fpmath.h lib/libc/i386 _fpmath.h lib/libc/ia64 _fpmath.h Log: Add an alternative view of the bits in an 80-bit long double (64+16 instead of 32+32+15+1) on all arches that have such long doubles (amd64, ia64 and i386). Large objects should be be accessed in large units, and the 32+32+15+1[+padding] decomposition asks for almost the opposite of that, sometimes resulting in very slow accesses depending on how well the compiler ignores what we ask for and converts to the best units for the given machine. E.g., on Athlons, there is a 10-20 cycle penalty for accessing the middle 32-bit word immediately after an 80-bit store. Whether actually using the alternative view is better is very machine- dependent. A 32+32+16 view is probably best with old 32-bit systems and gcc through 4.2.1. The compiler should mostly avoid the view and generate best accesses, but gcc-4.2.1 is far from doing that. I think 64+16 is best for now. Similarly for doubles -- they should be using 64+0 especially on 64-bit machines, but fdlibm uses 32+32 extensively for them. Fortunately, in 64-bit mode for doubles, gcc already ignores the 32+32-bit view and generates best accesses in many cases. Revision Changes Path 1.7 +6 -1 src/lib/libc/amd64/_fpmath.h 1.6 +6 -1 src/lib/libc/i386/_fpmath.h 1.7 +12 -1 src/lib/libc/ia64/_fpmath.h From bde at FreeBSD.org Thu Jan 17 09:02:16 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Thu Jan 17 09:02:18 2008 Subject: cvs commit: src/lib/msun/src math_private.h Message-ID: <200801171702.m0HH2BVf002173@repoman.freebsd.org> bde 2008-01-17 17:02:11 UTC FreeBSD src repository Modified files: lib/msun/src math_private.h Log: Add a macro STRICT_ASSIGN() to help avoid the compiler bug that assignments and casts don't clip extra precision, if any. The implementation is to assign to a temporary volatile variable and read the result back to assign to the original lvalue. lib/msun currently 2 different hard-coded hacks to avoid the problem in just a few places and needs it in a few more places. One variant uses volatile for the original lvalue. This works but is slower than necessary. Another temporarily casts the lvalue to volatile. This broke with gcc-4.2.1 or earlier (gcc now stores to the lvalue but doesn't load from it). Revision Changes Path 1.22 +16 -0 src/lib/msun/src/math_private.h From alc at FreeBSD.org Thu Jan 17 10:25:53 2008 From: alc at FreeBSD.org (Alan Cox) Date: Thu Jan 17 10:25:57 2008 Subject: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c Message-ID: <200801171825.m0HIPqkm016559@repoman.freebsd.org> alc 2008-01-17 18:25:52 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c sys/i386/i386 pmap.c Log: Retire PMAP_DIAGNOSTIC. Any useful diagnostics that were conditionally compiled under PMAP_DIAGNOSTIC are now KASSERT()s. (Note: The kernel option DIAGNOSTIC still disables inlining of certain pmap functions.) Eliminate dead code from pmap_enter(). This code implemented an assertion. On i386, an equivalent check is already implemented. However, on amd64, a small change is required to implement an equivalent check. Eliminate \n from a nearby panic string. Use KASSERT() to reimplement pmap_copy()'s two assertions. Revision Changes Path 1.605 +10 -27 src/sys/amd64/amd64/pmap.c 1.608 +9 -26 src/sys/i386/i386/pmap.c From jhb at FreeBSD.org Thu Jan 17 10:59:39 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 17 10:59:46 2008 Subject: cvs commit: src/sys/amd64/isa clock.c src/sys/i386/isa clock.c Message-ID: <200801171859.m0HIxc4b021341@repoman.freebsd.org> jhb 2008-01-17 18:59:38 UTC FreeBSD src repository Modified files: sys/amd64/isa clock.c sys/i386/isa clock.c Log: Use cpu_spinwait() (i.e., "pause") when spinning on rdtsc during DELAY(). MFC after: 1 week Revision Changes Path 1.236 +1 -0 src/sys/amd64/isa/clock.c 1.241 +1 -0 src/sys/i386/isa/clock.c From emaste at FreeBSD.org Thu Jan 17 11:00:00 2008 From: emaste at FreeBSD.org (Ed Maste) Date: Thu Jan 17 11:00:04 2008 Subject: cvs commit: src/tools/tools/aac aac_checkq.c Message-ID: <200801171859.m0HIxxwj021368@repoman.freebsd.org> emaste 2008-01-17 18:59:59 UTC FreeBSD src repository Modified files: tools/tools/aac aac_checkq.c Log: Eliminate warnings by adding headers. Revision Changes Path 1.4 +2 -0 src/tools/tools/aac/aac_checkq.c From ambrisko at FreeBSD.org Thu Jan 17 11:29:02 2008 From: ambrisko at FreeBSD.org (Doug Ambrisko) Date: Thu Jan 17 11:29:04 2008 Subject: cvs commit: src/share/misc pci_vendors Message-ID: <200801171929.m0HJT2kV027229@repoman.freebsd.org> ambrisko 2008-01-17 19:29:02 UTC FreeBSD src repository Modified files: share/misc pci_vendors Log: Correct that LSI 0060 is a mfi device and not mpt. Revision Changes Path 1.37 +1 -1 src/share/misc/pci_vendors From ambrisko at FreeBSD.org Thu Jan 17 11:36:15 2008 From: ambrisko at FreeBSD.org (Doug Ambrisko) Date: Thu Jan 17 11:36:17 2008 Subject: cvs commit: src/share/man/man4 mfi.4 Message-ID: <200801171936.m0HJaE46028800@repoman.freebsd.org> ambrisko 2008-01-17 19:36:14 UTC FreeBSD src repository Modified files: share/man/man4 mfi.4 Log: Note the driver support PERC and LSI1078 based controllers. Prompted by: Vlad GALU Revision Changes Path 1.7 +6 -2 src/share/man/man4/mfi.4 From rwatson at FreeBSD.org Thu Jan 17 11:52:02 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Jan 17 11:52:07 2008 Subject: cvs commit: src/sys/kern uipc_sem.c Message-ID: <200801171952.m0HJq2Mk044524@repoman.freebsd.org> rwatson 2008-01-17 19:52:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/kern uipc_sem.c Log: Merge uipc_sem.c:1.30 from RELENG_7 to RELENG_7_0: Free MAC label on a POSIX semaphore when the semaphore is freed. Submitted by: jhb Approved by: re (kensmith) Revision Changes Path 1.28.4.1 +3 -0 src/sys/kern/uipc_sem.c From jhb at FreeBSD.org Thu Jan 17 12:11:59 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 17 12:12:04 2008 Subject: cvs commit: src/sys/dev/if_ndis if_ndis.c Message-ID: <200801172011.m0HKBxbB017229@repoman.freebsd.org> jhb 2008-01-17 20:11:59 UTC FreeBSD src repository Modified files: sys/dev/if_ndis if_ndis.c Log: Use pause(9) instead of a tsleep() on a stack variable. MFC after: 1 week Revision Changes Path 1.131 +1 -1 src/sys/dev/if_ndis/if_ndis.c From jhb at FreeBSD.org Thu Jan 17 12:15:18 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 17 12:15:20 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c Message-ID: <200801172015.m0HKFFFS029669@repoman.freebsd.org> jhb 2008-01-17 20:15:15 UTC FreeBSD src repository Modified files: sys/kern kern_rwlock.c Log: Remove a conditional that is always true. MFC after: 2 weeks Revision Changes Path 1.34 +1 -1 src/sys/kern/kern_rwlock.c From brueffer at FreeBSD.org Thu Jan 17 12:51:58 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Thu Jan 17 12:52:01 2008 Subject: cvs commit: src/share/mk bsd.own.mk Message-ID: <200801172051.m0HKpw9D028673@repoman.freebsd.org> brueffer 2008-01-17 20:51:58 UTC FreeBSD src repository Modified files: share/mk bsd.own.mk Log: Remove remnants of old *_FORTRAN build flags. Approved by: rwatson (mentor) MFC after: 3 days Revision Changes Path 1.72 +0 -2 src/share/mk/bsd.own.mk From jhb at FreeBSD.org Thu Jan 17 13:02:45 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 17 13:02:49 2008 Subject: cvs commit: src/sys/nfsclient nfs_socket.c Message-ID: <200801172102.m0HL2i8U030268@repoman.freebsd.org> jhb 2008-01-17 21:02:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/nfsclient nfs_socket.c Log: MFC: Force consistent use of the mountpoint's credentials when connecting to the NFS server by temporarily changing the current thread's credentials to that of the mountpoint while establishing the connection. Revision Changes Path 1.154.2.2 +22 -1 src/sys/nfsclient/nfs_socket.c From jhb at FreeBSD.org Thu Jan 17 13:04:52 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 17 13:04:58 2008 Subject: cvs commit: src/sys/nfsclient nfs_socket.c Message-ID: <200801172104.m0HL4q1l031828@repoman.freebsd.org> jhb 2008-01-17 21:04:52 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/nfsclient nfs_socket.c Log: MFC: Force consistent use of the mountpoint's credentials when connecting to the NFS server by temporarily changing the current thread's credentials to that of the mountpoint while establishing the connection. Revision Changes Path 1.125.2.18 +22 -1 src/sys/nfsclient/nfs_socket.c From chris at unixpages.org Thu Jan 17 13:22:53 2008 From: chris at unixpages.org (Christian Brueffer) Date: Thu Jan 17 13:23:01 2008 Subject: cvs commit: src Makefile.inc1 In-Reply-To: <20080116180341.GA93583@troutmask.apl.washington.edu> References: <200801161505.m0GF5okm052693@repoman.freebsd.org> <20080116180341.GA93583@troutmask.apl.washington.edu> Message-ID: <20080117205250.GD1230@haakonia.hitnet.RWTH-Aachen.DE> On Wed, Jan 16, 2008 at 10:03:41AM -0800, Steve Kargl wrote: > On Wed, Jan 16, 2008 at 03:05:49PM +0000, Christian Brueffer wrote: > > brueffer 2008-01-16 15:05:49 UTC > > > > FreeBSD src repository > > > > Modified files: > > . Makefile.inc1 > > Log: > > Remove WITHOUT_FORTRAN from the XMAKE target, it doesn't exist anymore. > > > > This may be an incomplete commit. Try 'find /usr/src -name Makefile > | xargs grep -i fortran' > > You should also remove libg2c and cc/f77. > I'll look into it, thanks. - Christian -- Christian Brueffer chris@unixpages.org brueffer@FreeBSD.org GPG Key: http://people.freebsd.org/~brueffer/brueffer.key.asc GPG Fingerprint: A5C8 2099 19FF AACA F41B B29B 6C76 178C A0ED 982D -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080117/07988b5a/attachment.pgp From sam at FreeBSD.org Thu Jan 17 13:25:09 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Thu Jan 17 13:25:10 2008 Subject: cvs commit: src/sys/kern uipc_mbuf.c src/sys/sys mbuf.h src/sys/dev/ath if_ath.c src/sys/dev/cxgb/sys mvec.h Message-ID: <200801172125.m0HLP9Sj097205@repoman.freebsd.org> sam 2008-01-17 21:25:09 UTC FreeBSD src repository Modified files: sys/kern uipc_mbuf.c sys/sys mbuf.h sys/dev/ath if_ath.c sys/dev/cxgb/sys mvec.h Log: promote ath_defrag to m_collapse (and retire private+unused m_collapse from cxgb) Reviewed by: pyun, jhb, kmacy MFC after: 2 weeks Revision Changes Path 1.178 +1 -85 src/sys/dev/ath/if_ath.c 1.14 +0 -14 src/sys/dev/cxgb/sys/mvec.h 1.175 +86 -0 src/sys/kern/uipc_mbuf.c 1.221 +1 -0 src/sys/sys/mbuf.h From kmacy at FreeBSD.org Thu Jan 17 13:25:58 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Thu Jan 17 13:26:04 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_sge.c src/sys/dev/cxgb/sys cxgb_support.c Message-ID: <200801172125.m0HLPwFd097619@repoman.freebsd.org> kmacy 2008-01-17 21:25:58 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_sge.c sys/dev/cxgb/sys cxgb_support.c Log: - remove bogus_imm counter - disable pcpu cluster cache by default until reference counting is handled correctly for held clusters - can be re-enable by sysctl Revision Changes Path 1.46 +4 -4 src/sys/dev/cxgb/cxgb_sge.c 1.4 +22 -18 src/sys/dev/cxgb/sys/cxgb_support.c From jhb at FreeBSD.org Thu Jan 17 13:43:13 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 17 13:43:14 2008 Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb kgdb.h main.c trgt.c Message-ID: <200801172143.m0HLhCm8016953@repoman.freebsd.org> jhb 2008-01-17 21:43:12 UTC FreeBSD src repository Modified files: gnu/usr.bin/gdb/kgdb kgdb.h main.c trgt.c Log: Add a new 'add-kld ' command to kgdb to make it easier to analyze crash dumps with kernel modules. The command is basically a wrapper around add-symbol-file except that it uses the kernel linker data structures and the ELF section headers of the kld to calculate the section addresses add-symbol-file needs. The 'kld' parameter may either be an absolute path or a relative path. kgdb looks for the kld in several locations checking for variants with ".symbols" or ".debug" suffixes in each location. The first location it tries is just opening the specified path (this handles absolute paths and looks for the kld relative to the current directory otherwise). Next it tries to find the module in the same directory of the kernel image being used. If that fails it extracts the kern.module_path from the kernel being debugged and looks in each of those paths. The upshot is that for the common cases of debugging /boot/kernel/kernel where the module is in either /boot/kernel or /boot/modules one can merely do 'add-kld foo.ko'. MFC after: 1 week Revision Changes Path 1.7 +2 -0 src/gnu/usr.bin/gdb/kgdb/kgdb.h 1.12 +2 -2 src/gnu/usr.bin/gdb/kgdb/main.c 1.6 +271 -0 src/gnu/usr.bin/gdb/kgdb/trgt.c From jhb at freebsd.org Thu Jan 17 13:52:43 2008 From: jhb at freebsd.org (John Baldwin) Date: Thu Jan 17 13:52:51 2008 Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb kgdb.h main.c trgt.c In-Reply-To: <200801172143.m0HLhCm8016953@repoman.freebsd.org> References: <200801172143.m0HLhCm8016953@repoman.freebsd.org> Message-ID: <200801171652.31546.jhb@freebsd.org> On Thursday 17 January 2008 04:43:12 pm John Baldwin wrote: > jhb 2008-01-17 21:43:12 UTC > > FreeBSD src repository > > Modified files: > gnu/usr.bin/gdb/kgdb kgdb.h main.c trgt.c > Log: > Add a new 'add-kld ' command to kgdb to make it easier to analyze > crash dumps with kernel modules. The command is basically a wrapper > around add-symbol-file except that it uses the kernel linker data > structures and the ELF section headers of the kld to calculate the > section addresses add-symbol-file needs. Forgot to say: Tested on: i386, amd64 A sample run on i386: > sudo ./kgdb -c /usr/crash/vmcore.10 /boot/kernel/kernel ... crash: blow the kernel stack on purpose Fatal double fault: eip = 0xc05c6220 esp = 0xe61b0000 ebp = 0xe61b0018 panic: double fault KDB: enter: panic ... (kgdb) where #0 doadump () at pcpu.h:195 #1 0xc05d399c in boot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:417 #2 0xc05d3c0a in panic (fmt=Variable "fmt" is not available. ) at /usr/src/sys/kern/kern_shutdown.c:571 #3 0xc08115d9 in dblfault_handler () at /usr/src/sys/i386/i386/trap.c:927 #4 0xc05c6220 in mtx_pool_setup_dynamic () #5 0xc065e125 in arc4rand (ptr=0xe61b0168, len=4, reseed=0) at /usr/src/sys/libkern/arc4random.c:142 #6 0xc065e171 in arc4random () at /usr/src/sys/libkern/arc4random.c:150 #7 0xc3d43402 in ?? () #8 0xb15ac28c in ?? () #9 0x793b5626 in ?? () #10 0xe61b018c in ?? () #11 0xc3d43410 in ?? () #12 0xbc8e58bf in ?? () ... (kgdb) add-kld crash.ko add symbol table from file "/boot/modules/crash.ko.symbols" at .text_addr = 0xc3d416f0 .data_addr = 0xc3d44000 .bss_addr = 0xc3d44254 .rodata_addr = 0xc3d4364e Reading symbols from /boot/modules/crash.ko.symbols...done. (kgdb) where #0 doadump () at pcpu.h:195 #1 0xc05d399c in boot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:417 #2 0xc05d3c0a in panic (fmt=Variable "fmt" is not available. ) at /usr/src/sys/kern/kern_shutdown.c:571 #3 0xc08115d9 in dblfault_handler () at /usr/src/sys/i386/i386/trap.c:927 #4 0xc05c6220 in mtx_pool_setup_dynamic () #5 0xc065e125 in arc4rand (ptr=0xe61b0168, len=4, reseed=0) at /usr/src/sys/libkern/arc4random.c:142 #6 0xc065e171 in arc4random () at /usr/src/sys/libkern/arc4random.c:150 #7 0xc3d43402 in blow_stack () at crash.c:773 #8 0xc3d43410 in blow_stack () at crash.c:764 #9 0xc3d43410 in blow_stack () at crash.c:764 #10 0xc3d43410 in blow_stack () at crash.c:764 #11 0xc3d43410 in blow_stack () at crash.c:764 #12 0xc3d43410 in blow_stack () at crash.c:764 #13 0xc3d43410 in blow_stack () at crash.c:764 #14 0xc3d43410 in blow_stack () at crash.c:764 #15 0xc3d43410 in blow_stack () at crash.c:764 #16 0xc3d43410 in blow_stack () at crash.c:764 #17 0xc3d43410 in blow_stack () at crash.c:764 #18 0xc3d43410 in blow_stack () at crash.c:764 #19 0xc3d43410 in blow_stack () at crash.c:764 -- John Baldwin From jhb at FreeBSD.org Thu Jan 17 14:46:34 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 17 14:46:37 2008 Subject: cvs commit: src/sys/kern kern_mib.c Message-ID: <200801172246.m0HMkXqk077731@repoman.freebsd.org> jhb 2008-01-17 22:46:32 UTC FreeBSD src repository Modified files: sys/kern kern_mib.c Log: Add 'compat_freebsd[4567]' features corresponding to the kernel options COMPAT_FREEBSD[4567]. MFC after: 1 week Requested by: kris Revision Changes Path 1.87 +17 -0 src/sys/kern/kern_mib.c From jhb at FreeBSD.org Thu Jan 17 15:37:48 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 17 15:37:50 2008 Subject: cvs commit: src/sys/arm/xscale/ixp425 if_npe.c src/sys/dev/gem if_gem.c src/sys/dev/msk if_msk.c src/sys/dev/nfe if_nfe.c src/sys/dev/re if_re.c src/sys/dev/wpi if_wpi.c Message-ID: <200801172337.m0HNbllJ067624@repoman.freebsd.org> jhb 2008-01-17 23:37:47 UTC FreeBSD src repository Modified files: sys/arm/xscale/ixp425 if_npe.c sys/dev/gem if_gem.c sys/dev/msk if_msk.c sys/dev/nfe if_nfe.c sys/dev/re if_re.c sys/dev/wpi if_wpi.c Log: - Retire npe_defrag(), gem_defrag(), msk_defrag(), nfe_defrag(), and re_defrag() and use m_collapse() instead. - Replace a reference to ath_defrag() in a comment in if_wpi.c with m_collapse(). Revision Changes Path 1.8 +1 -85 src/sys/arm/xscale/ixp425/if_npe.c 1.47 +1 -88 src/sys/dev/gem/if_gem.c 1.27 +1 -88 src/sys/dev/msk/if_msk.c 1.25 +1 -89 src/sys/dev/nfe/if_nfe.c 1.103 +1 -91 src/sys/dev/re/if_re.c 1.6 +1 -1 src/sys/dev/wpi/if_wpi.c From thompsa at FreeBSD.org Thu Jan 17 16:19:10 2008 From: thompsa at FreeBSD.org (Andrew Thompson) Date: Thu Jan 17 16:19:12 2008 Subject: cvs commit: src/sys/net if_bridge.c Message-ID: <200801180019.m0I0JAwr076152@repoman.freebsd.org> thompsa 2008-01-18 00:19:10 UTC FreeBSD src repository Modified files: sys/net if_bridge.c Log: IEEE 802.1D-2004 states, frames containing any of the group MAC Addresses specified in Table 7-10 in their destination address field shall not be relayed by the Bridge. Add a check in bridge_forward() to adhere to this. PR: kern/119744 Revision Changes Path 1.111 +14 -1 src/sys/net/if_bridge.c From peter at FreeBSD.org Thu Jan 17 17:43:15 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Thu Jan 17 17:43:16 2008 Subject: cvs commit: src/contrib/top display.c layout.h machine.h top.c top.h src/usr.bin/top machine.c Message-ID: <200801180143.m0I1hEkp099077@repoman.freebsd.org> peter 2008-01-18 01:43:14 UTC FreeBSD src repository Modified files: contrib/top display.c layout.h machine.h top.c top.h usr.bin/top machine.c Log: Add a -P flag to display per-cpu cpu usage stats. Revision Changes Path 1.10 +69 -17 src/contrib/top/display.c 1.3 +22 -20 src/contrib/top/layout.h 1.10 +3 -0 src/contrib/top/machine.h 1.25 +10 -1 src/contrib/top/top.c 1.5 +3 -1 src/contrib/top/top.h 1.85 +95 -5 src/usr.bin/top/machine.c From davidxu at FreeBSD.org Thu Jan 17 20:29:37 2008 From: davidxu at FreeBSD.org (David Xu) Date: Thu Jan 17 20:29:41 2008 Subject: cvs commit: src/lib/libthr Makefile Message-ID: <200801180429.m0I4TbLm027137@repoman.freebsd.org> davidxu 2008-01-18 04:29:37 UTC FreeBSD src repository Modified files: lib/libthr Makefile Log: SYSTEM_SCOPE_ONLY flag is no longer needed, it is the only mode libthr supports. Revision Changes Path 1.31 +0 -2 src/lib/libthr/Makefile From kientzle at FreeBSD.org Thu Jan 17 20:53:46 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Thu Jan 17 20:53:48 2008 Subject: cvs commit: src/lib/libarchive archive_read_extract.c Message-ID: <200801180453.m0I4rjPw040112@repoman.freebsd.org> kientzle 2008-01-18 04:53:45 UTC FreeBSD src repository Modified files: lib/libarchive archive_read_extract.c Log: Reconnect the progress callback. It may not get called as often as you might expect, but at least it will get called now. Thanks to: David Topham for asking how this got disconnected. Revision Changes Path 1.60 +8 -2 src/lib/libarchive/archive_read_extract.c From kientzle at FreeBSD.org Thu Jan 17 21:05:58 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Thu Jan 17 21:06:00 2008 Subject: cvs commit: src/lib/libarchive archive_write_disk.c src/lib/libarchive/test Makefile test_write_disk_hardlink.c Message-ID: <200801180505.m0I55woO042844@repoman.freebsd.org> kientzle 2008-01-18 05:05:58 UTC FreeBSD src repository Modified files: lib/libarchive archive_write_disk.c lib/libarchive/test Makefile Added files: lib/libarchive/test test_write_disk_hardlink.c Log: Issues with hardlinks in newc-format files prompted me to write a new test to exercise the hardlink strategies used by different archive formats (tar, old cpio, new cpio). This uncovered two problems, both fixed by this commit: 1) Enforce file size when writing files to disk. 2) When restoring hardlink entries, if they have data associated, go ahead and open the file so we can write the data. In particular, this fixes bsdtar/bsdcpio extraction of new cpio formats where the "original" is empty and the subsequent "hardlink" entry actually carries the data. It also provides correct behavior for old cpio archives where hardlinked entries have their bodies stored multiple times in the archive; the last body should always be the one that ends up in the final file. The new pax format also permits (but does not require) hardlinks to carry file data; again, the last contents should always win. Note that with any of these, a size of zero on a hardlink simply means that the hardlink carries no data; it does not mean that the file has zero size. A non-zero size on a hardlink does provide the file size. Thanks to: John Baldwin, for reminding me about this long-standing bug and sending me a simple example archive that prompted this test case Revision Changes Path 1.19 +32 -6 src/lib/libarchive/archive_write_disk.c 1.13 +1 -0 src/lib/libarchive/test/Makefile 1.1 +165 -0 src/lib/libarchive/test/test_write_disk_hardlink.c (new) From kientzle at FreeBSD.org Thu Jan 17 21:48:51 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Thu Jan 17 21:48:55 2008 Subject: cvs commit: src/lib/libarchive/test test_write_disk.c Message-ID: <200801180548.m0I5moP9049499@repoman.freebsd.org> kientzle 2008-01-18 05:48:50 UTC FreeBSD src repository Modified files: lib/libarchive/test test_write_disk.c Log: The previous commit caused the archive_write_disk interface to start obeying filesize limits; this test wasn't properly setting file sizes before trying to write file data. Revision Changes Path 1.7 +2 -0 src/lib/libarchive/test/test_write_disk.c From kientzle at FreeBSD.org Thu Jan 17 22:08:40 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Thu Jan 17 22:08:44 2008 Subject: cvs commit: src/lib/libarchive archive_write_disk.c Message-ID: <200801180608.m0I68dIs053550@repoman.freebsd.org> kientzle 2008-01-18 06:08:39 UTC FreeBSD src repository Modified files: lib/libarchive archive_write_disk.c Log: Fix 64-bit build after my last commit. Revision Changes Path 1.20 +1 -1 src/lib/libarchive/archive_write_disk.c From kientzle at FreeBSD.org Thu Jan 17 22:16:08 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Thu Jan 17 22:16:14 2008 Subject: cvs commit: src/lib/libarchive archive_write_disk.c Message-ID: <200801180616.m0I6G8NO055101@repoman.freebsd.org> kientzle 2008-01-18 06:16:08 UTC FreeBSD src repository Modified files: lib/libarchive archive_write_disk.c Log: I misread the Tinderbox error; this should really unbreak 64-bit builds. Pointy hats, yep, keep 'em coming. ;-/ Revision Changes Path 1.21 +1 -1 src/lib/libarchive/archive_write_disk.c From davidxu at FreeBSD.org Thu Jan 17 23:04:43 2008 From: davidxu at FreeBSD.org (David Xu) Date: Thu Jan 17 23:04:45 2008 Subject: cvs commit: src/sys/sys time.h src/sys/kern kern_time.c Message-ID: <200801180704.m0I74go6064311@repoman.freebsd.org> davidxu 2008-01-18 07:04:42 UTC FreeBSD src repository Modified files: sys/sys time.h sys/kern kern_time.c Log: Add POSIX clock id CLOCK_THREAD_CPUTIME_ID, this can be used to measure per-thread runtime in user code. Revision Changes Path 1.143 +16 -0 src/sys/kern/kern_time.c 1.75 +1 -0 src/sys/sys/time.h From yongari at FreeBSD.org Fri Jan 18 00:32:10 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Fri Jan 18 00:32:12 2008 Subject: cvs commit: src/sys/dev/stge if_stge.c Message-ID: <200801180832.m0I8W9sf077964@repoman.freebsd.org> yongari 2008-01-18 08:32:09 UTC FreeBSD src repository Modified files: sys/dev/stge if_stge.c Log: Use m_collapse(9) to collapse mbuf chains instead of relying on shortest possible chain of mbufs of m_defrag(9). What we want is chains of mbufs that can be safely stored to a Tx descriptor which can have up to STGE_MAXTXSEGS mbufs. The ethernet controller does not need to align Tx buffers on 32bit boundary. So the use of m_defrag(9) was waste of time. Revision Changes Path 1.12 +1 -1 src/sys/dev/stge/if_stge.c From davidxu at FreeBSD.org Fri Jan 18 00:48:32 2008 From: davidxu at FreeBSD.org (David Xu) Date: Fri Jan 18 00:48:36 2008 Subject: cvs commit: src/include unistd.h Message-ID: <200801180848.m0I8mWIC089155@repoman.freebsd.org> davidxu 2008-01-18 08:48:32 UTC FreeBSD src repository Modified files: include unistd.h Log: _POSIX_THREAD_CPUTIME is now supported. Revision Changes Path 1.82 +1 -1 src/include/unistd.h From thompsa at FreeBSD.org Fri Jan 18 01:34:10 2008 From: thompsa at FreeBSD.org (Andrew Thompson) Date: Fri Jan 18 01:34:11 2008 Subject: cvs commit: src/sys/net if_bridge.c Message-ID: <200801180934.m0I9YA7f097456@repoman.freebsd.org> thompsa 2008-01-18 09:34:10 UTC FreeBSD src repository Modified files: sys/net if_bridge.c Log: Remove a chunk of duplicated code, test the destination address against the bridge the same way we check member interfaces. Revision Changes Path 1.112 +27 -56 src/sys/net/if_bridge.c From phk at FreeBSD.org Fri Jan 18 01:34:40 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Fri Jan 18 01:34:45 2008 Subject: cvs commit: src/share/zoneinfo leapseconds Message-ID: <200801180934.m0I9Yd8b097489@repoman.freebsd.org> phk 2008-01-18 09:34:39 UTC FreeBSD src repository Modified files: share/zoneinfo leapseconds Log: Still no new leapseconds: Bulletin C-35 Revision Changes Path 1.20 +3 -3 src/share/zoneinfo/leapseconds From kib at FreeBSD.org Fri Jan 18 01:39:36 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Fri Jan 18 01:39:38 2008 Subject: cvs commit: src/sys/dev/fdc fdc.c Message-ID: <200801180939.m0I9daRd097698@repoman.freebsd.org> kib 2008-01-18 09:39:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/fdc fdc.c Log: MFC rev. 1.319, 1.320: Fix unload of the fdc.ko: Wakeup the thread doing the fdc_detach() when the fdc worker thread exits. Write access to the write-protected floppy shall call device_unbusy() to pair the device_busy() in the fd_access(). Revision Changes Path 1.317.2.1 +8 -2 src/sys/dev/fdc/fdc.c From kib at FreeBSD.org Fri Jan 18 02:02:54 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Fri Jan 18 02:02:59 2008 Subject: cvs commit: src/sys/amd64/amd64 machdep.c pmap.c src/sys/arm/arm pmap.c src/sys/arm/at91 kb920x_machdep.c src/sys/arm/sa11x0 assabet_machdep.c src/sys/arm/xscale/i80321 ep80219_machdep.c iq31244_machdep.c src/sys/arm/xscale/i8134x crb_machdep.c ... Message-ID: <200801181002.m0IA2s4b002247@repoman.freebsd.org> kib 2008-01-18 10:02:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/amd64/amd64 machdep.c pmap.c sys/arm/arm pmap.c sys/arm/at91 kb920x_machdep.c sys/arm/sa11x0 assabet_machdep.c sys/arm/xscale/i80321 ep80219_machdep.c iq31244_machdep.c sys/arm/xscale/i8134x crb_machdep.c sys/arm/xscale/ixp425 avila_machdep.c sys/compat/pecoff imgact_pecoff.c sys/compat/svr4 imgact_svr4.c sys/i386/i386 machdep.c pmap.c sys/i386/ibcs2 imgact_coff.c sys/i386/linux imgact_linux.c sys/ia64/ia64 machdep.c pmap.c sys/kern imgact_aout.c imgact_elf.c imgact_gzip.c kern_exec.c kern_fork.c kern_kse.c kern_proc.c kern_sig.c kern_thr.c kern_thread.c sys/pc98/pc98 machdep.c sys/powerpc/powerpc machdep.c pmap_dispatch.c sys/sparc64/sparc64 machdep.c pmap.c sys/sun4v/sun4v machdep.c pmap.c sys/sys proc.h signalvar.h sys/vm pmap.h vm_extern.h vm_glue.c vm_map.c Log: MFC fix for the panic("vm_thread_new: kstack allocation failed") and silent NULL pointer dereference in the i386 and sparc64 pmap_pinit() when the kmem_alloc_nofault() failed to allocate address space. Both functions now return error instead of panicing or dereferencing NULL. The reason for MFCing this so late in release cycle is, according to marius@, because > it fixes the crashing (though no panic) of the test suite > of the graphic/OpenEXR port on sparc64. This test suite is run > (and required to succeed) during the package build and that's > why portmgr@ bitch about at it as OpenEXR is a dependency of KDE > which in turn is supposed to end up on the release CD images. Revisions MFCed: 1.677 of src/sys/amd64/amd64/machdep.c 1.592 of src/sys/amd64/amd64/pmap.c 1.88 of src/sys/arm/arm/pmap.c 1.27 of src/sys/arm/at91/kb920x_machdep.c 1.22 of src/sys/arm/sa11x0/assabet_machdep.c 1.8 of src/sys/arm/xscale/i80321/ep80219_machdep.c 1.29 of src/sys/arm/xscale/i80321/iq31244_machdep.c 1.3 of src/sys/arm/xscale/i8134x/crb_machdep.c 1.6 of src/sys/arm/xscale/ixp425/avila_machdep.c 1.41 of src/sys/compat/pecoff/imgact_pecoff.c 1.26 of src/sys/compat/svr4/imgact_svr4.c 1.660 of src/sys/i386/i386/machdep.c 1.596 of src/sys/i386/i386/pmap.c 1.68 of src/sys/i386/ibcs2/imgact_coff.c 1.56 of src/sys/i386/linux/imgact_linux.c 1.226 of src/sys/ia64/ia64/machdep.c 1.192 of src/sys/ia64/ia64/pmap.c 1.102 of src/sys/kern/imgact_aout.c 1.179 of src/sys/kern/imgact_elf.c 1.56 of src/sys/kern/imgact_gzip.c 1.310 of src/sys/kern/kern_exec.c 1.287 of src/sys/kern/kern_fork.c 1.236 of src/sys/kern/kern_kse.c 1.253 of src/sys/kern/kern_proc.c 1.352 of src/sys/kern/kern_sig.c 1.63 of src/sys/kern/kern_thr.c 1.257 of src/sys/kern/kern_thread.c 1.397 of src/sys/pc98/pc98/machdep.c 1.104 of src/sys/powerpc/powerpc/machdep.c 1.10 of src/sys/powerpc/powerpc/pmap_dispatch.c 1.139 of src/sys/sparc64/sparc64/machdep.c 1.167 of src/sys/sparc64/sparc64/pmap.c 1.16 of src/sys/sun4v/sun4v/machdep.c 1.40 of src/sys/sun4v/sun4v/pmap.c 1.493 of src/sys/sys/proc.h 1.78 of src/sys/sys/signalvar.h 1.80 of src/sys/vm/pmap.h 1.79 of src/sys/vm/vm_extern.h 1.226 of src/sys/vm/vm_glue.c 1.390 of src/sys/vm/vm_map.c Requested by: marius Tested by: Peter Holm, marius (make universe and sparc64 runs) Approved by: re (kensmith) Revision Changes Path 1.675.2.3 +1 -1 src/sys/amd64/amd64/machdep.c 1.590.2.4 +3 -1 src/sys/amd64/amd64/pmap.c 1.86.2.2 +2 -1 src/sys/arm/arm/pmap.c 1.23.2.2 +1 -1 src/sys/arm/at91/kb920x_machdep.c 1.21.2.1 +1 -1 src/sys/arm/sa11x0/assabet_machdep.c 1.7.2.1 +1 -1 src/sys/arm/xscale/i80321/ep80219_machdep.c 1.28.2.1 +1 -1 src/sys/arm/xscale/i80321/iq31244_machdep.c 1.2.2.1 +1 -1 src/sys/arm/xscale/i8134x/crb_machdep.c 1.5.2.1 +1 -1 src/sys/arm/xscale/ixp425/avila_machdep.c 1.40.2.1 +5 -1 src/sys/compat/pecoff/imgact_pecoff.c 1.25.10.1 +3 -1 src/sys/compat/svr4/imgact_svr4.c 1.658.2.2 +1 -1 src/sys/i386/i386/machdep.c 1.594.2.5 +8 -1 src/sys/i386/i386/pmap.c 1.67.2.1 +3 -1 src/sys/i386/ibcs2/imgact_coff.c 1.55.2.1 +3 -1 src/sys/i386/linux/imgact_linux.c 1.225.2.1 +1 -1 src/sys/ia64/ia64/machdep.c 1.191.2.1 +2 -1 src/sys/ia64/ia64/pmap.c 1.101.2.1 +3 -1 src/sys/kern/imgact_aout.c 1.178.2.3 +3 -1 src/sys/kern/imgact_elf.c 1.55.2.1 +5 -1 src/sys/kern/imgact_gzip.c 1.308.2.2 +3 -1 src/sys/kern/kern_exec.c 1.282.2.2 +34 -7 src/sys/kern/kern_fork.c 1.235.2.1 +30 -13 src/sys/kern/kern_kse.c 1.252.2.3 +13 -15 src/sys/kern/kern_proc.c 1.349.2.2 +1 -1 src/sys/kern/kern_sig.c 1.62.2.1 +2 -0 src/sys/kern/kern_thr.c 1.255.2.2 +22 -5 src/sys/kern/kern_thread.c 1.396.2.1 +1 -1 src/sys/pc98/pc98/machdep.c 1.103.2.2 +2 -2 src/sys/powerpc/powerpc/machdep.c 1.9.2.1 +2 -1 src/sys/powerpc/powerpc/pmap_dispatch.c 1.138.2.1 +1 -1 src/sys/sparc64/sparc64/machdep.c 1.166.2.1 +6 -1 src/sys/sparc64/sparc64/pmap.c 1.15.2.1 +1 -1 src/sys/sun4v/sun4v/machdep.c 1.39.2.1 +2 -1 src/sys/sun4v/sun4v/pmap.c 1.491.2.2 +1 -0 src/sys/sys/proc.h 1.77.2.1 +1 -0 src/sys/sys/signalvar.h 1.79.2.1 +1 -1 src/sys/vm/pmap.h 1.78.2.1 +5 -5 src/sys/vm/vm_extern.h 1.225.2.1 +22 -11 src/sys/vm/vm_glue.c 1.388.2.3 +23 -6 src/sys/vm/vm_map.c From kib at FreeBSD.org Fri Jan 18 04:09:55 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Fri Jan 18 04:10:00 2008 Subject: cvs commit: src/sys/fs/udf udf_vfsops.c Message-ID: <200801181209.m0IC9tIp024538@repoman.freebsd.org> kib 2008-01-18 12:09:54 UTC FreeBSD src repository Modified files: sys/fs/udf udf_vfsops.c Log: udf_vget() shall vgone() the vnode when the file_entry cannot be allocated or read from the volume. Otherwise, half-constructed vnode could be found later and cause panic when accessed. PR: 118322 MFC after: 1 week Revision Changes Path 1.52 +3 -0 src/sys/fs/udf/udf_vfsops.c From ru at FreeBSD.org Fri Jan 18 04:13:06 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Fri Jan 18 04:13:08 2008 Subject: cvs commit: src/share/man/man7 clocks.7 Message-ID: <200801181213.m0ICD5FH025849@repoman.freebsd.org> ru 2008-01-18 12:13:05 UTC FreeBSD src repository Modified files: share/man/man7 clocks.7 Log: Correct the sysconf variable name, _SC_CLK_TCK. Revision Changes Path 1.25 +2 -2 src/share/man/man7/clocks.7 From rwatson at FreeBSD.org Fri Jan 18 04:19:51 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Fri Jan 18 04:19:55 2008 Subject: cvs commit: src/sys/netinet tcp_usrreq.c Message-ID: <200801181219.m0ICJp8L026279@repoman.freebsd.org> rwatson 2008-01-18 12:19:51 UTC FreeBSD src repository Modified files: sys/netinet tcp_usrreq.c Log: In tcp_ctloutput(), don't hold the inpcb lock over sooptcopyin(), rather, drop the lock and then re-acquire it, revalidating TCP connection state assumptions when we do so. This avoids a potential lock order reversal (and potential deadlock, although none have been reported) due to the inpcb lock being held over a page fault. MFC after: 1 week PR: 102752 Reviewed by: bz Reported by: Václav Haisman Revision Changes Path 1.166 +55 -25 src/sys/netinet/tcp_usrreq.c From davidxu at FreeBSD.org Fri Jan 18 05:00:29 2008 From: davidxu at FreeBSD.org (David Xu) Date: Fri Jan 18 05:00:34 2008 Subject: cvs commit: src/sys/kern kern_time.c Message-ID: <200801181300.m0ID0SMi041767@repoman.freebsd.org> davidxu 2008-01-18 13:00:28 UTC FreeBSD src repository Modified files: sys/kern kern_time.c Log: Make sure reading td_runtime in critical section since thread may be preempted and td_runtime will be modified. Revision Changes Path 1.144 +2 -1 src/sys/kern/kern_time.c From des at FreeBSD.org Fri Jan 18 05:13:02 2008 From: des at FreeBSD.org (Dag-Erling Smorgrav) Date: Fri Jan 18 05:13:04 2008 Subject: cvs commit: src/usr.sbin/mtree verify.c Message-ID: <200801181313.m0IDD1rL045820@repoman.freebsd.org> des 2008-01-18 13:13:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.sbin/mtree verify.c Log: MFC: (1.26) traverse the tree in lexical order Revision Changes Path 1.25.2.1 +7 -1 src/usr.sbin/mtree/verify.c From des at FreeBSD.org Fri Jan 18 05:23:57 2008 From: des at FreeBSD.org (Dag-Erling Smorgrav) Date: Fri Jan 18 05:23:59 2008 Subject: cvs commit: src/lib/libfetch Makefile common.c common.h fetch.3 fetch.c file.c ftp.c http.c Message-ID: <200801181323.m0IDNvIJ047694@repoman.freebsd.org> des 2008-01-18 13:23:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libfetch Makefile common.c common.h fetch.3 fetch.c file.c ftp.c http.c Log: MFC: clean up namespace violations; correct is*() usage; NO_PROXY support Revision Changes Path 1.49.2.1 +6 -6 src/lib/libfetch/Makefile 1.50.10.1 +100 -50 src/lib/libfetch/common.c 1.28.10.1 +27 -26 src/lib/libfetch/common.h 1.63.2.1 +17 -1 src/lib/libfetch/fetch.3 1.38.10.1 +15 -15 src/lib/libfetch/fetch.c 1.17.10.1 +10 -10 src/lib/libfetch/file.c 1.96.2.1 +136 -128 src/lib/libfetch/ftp.c 1.78.2.1 +114 -109 src/lib/libfetch/http.c From des at FreeBSD.org Fri Jan 18 05:28:24 2008 From: des at FreeBSD.org (Dag-Erling Smorgrav) Date: Fri Jan 18 05:28:29 2008 Subject: cvs commit: src/lib/libpam/modules/pam_opieaccess pam_opieaccess.8 Message-ID: <200801181328.m0IDSO8a047880@repoman.freebsd.org> des 2008-01-18 13:28:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libpam/modules/pam_opieaccess pam_opieaccess.8 Log: MFC: (1.10) correct documentation of ~/.opiealways PR: 117512 Revision Changes Path 1.9.18.1 +5 -3 src/lib/libpam/modules/pam_opieaccess/pam_opieaccess.8 From des at FreeBSD.org Fri Jan 18 05:29:05 2008 From: des at FreeBSD.org (Dag-Erling Smorgrav) Date: Fri Jan 18 05:29:07 2008 Subject: cvs commit: src/contrib/openpam CREDITS HISTORY INSTALL LICENSE Makefile.am Makefile.in README RELNOTES aclocal.m4 autogen.sh config.h.in configure configure.ac depcomp install-sh ltmain.sh missing src/contrib/openpam/bin Makefile.am Makefile.in ... Message-ID: <200801181329.m0IDT5Kh048537@repoman.freebsd.org> des 2008-01-18 13:29:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) contrib/openpam CREDITS HISTORY INSTALL LICENSE Makefile.am Makefile.in README RELNOTES aclocal.m4 autogen.sh config.h.in configure configure.ac depcomp install-sh ltmain.sh missing contrib/openpam/bin Makefile.am Makefile.in contrib/openpam/bin/su Makefile.am Makefile.in su.c contrib/openpam/doc Makefile.am Makefile.in contrib/openpam/doc/man Makefile.am Makefile.in openpam.3 openpam.man openpam_borrow_cred.3 openpam_free_data.3 openpam_free_envlist.3 openpam_get_option.3 openpam_log.3 openpam_nullconv.3 openpam_readline.3 openpam_restore_cred.3 openpam_set_option.3 openpam_ttyconv.3 pam.3 pam.conf.5 pam.man pam_acct_mgmt.3 pam_authenticate.3 pam_chauthtok.3 pam_close_session.3 pam_conv.3 pam_end.3 pam_error.3 pam_get_authtok.3 pam_get_data.3 pam_get_item.3 pam_get_user.3 pam_getenv.3 pam_getenvlist.3 pam_info.3 pam_open_session.3 pam_prompt.3 pam_putenv.3 pam_set_data.3 pam_set_item.3 pam_setcred.3 pam_setenv.3 pam_sm_acct_mgmt.3 pam_sm_authenticate.3 pam_sm_chauthtok.3 pam_sm_close_session.3 pam_sm_open_session.3 pam_sm_setcred.3 pam_start.3 pam_strerror.3 pam_verror.3 pam_vinfo.3 pam_vprompt.3 contrib/openpam/include Makefile.am Makefile.in contrib/openpam/include/security Makefile.am Makefile.in openpam.h openpam_version.h pam_appl.h pam_constants.h pam_modules.h pam_types.h contrib/openpam/lib Makefile.am Makefile.in openpam_borrow_cred.c openpam_configure.c openpam_dispatch.c openpam_dynamic.c openpam_findenv.c openpam_free_data.c openpam_free_envlist.c openpam_get_option.c openpam_impl.h openpam_load.c openpam_log.c openpam_nullconv.c openpam_readline.c openpam_restore_cred.c openpam_set_option.c openpam_static.c openpam_ttyconv.c pam_acct_mgmt.c pam_authenticate.c pam_authenticate_secondary.c pam_chauthtok.c pam_close_session.c pam_end.c pam_error.c pam_get_authtok.c pam_get_data.c pam_get_item.c pam_get_mapped_authtok.c pam_get_mapped_username.c pam_get_user.c pam_getenv.c pam_getenvlist.c pam_info.c pam_open_session.c pam_prompt.c pam_putenv.c pam_set_data.c pam_set_item.c pam_set_mapped_authtok.c pam_set_mapped_username.c pam_setcred.c pam_setenv.c pam_sm_acct_mgmt.c pam_sm_authenticate.c pam_sm_authenticate_secondary.c pam_sm_chauthtok.c pam_sm_close_session.c pam_sm_get_mapped_authtok.c pam_sm_get_mapped_username.c pam_sm_open_session.c pam_sm_set_mapped_authtok.c pam_sm_set_mapped_username.c pam_sm_setcred.c pam_start.c pam_strerror.c pam_verror.c pam_vinfo.c pam_vprompt.c contrib/openpam/misc gendoc.pl contrib/openpam/modules Makefile.am Makefile.in contrib/openpam/modules/pam_deny Makefile.am Makefile.in pam_deny.c contrib/openpam/modules/pam_permit Makefile.am Makefile.in pam_permit.c contrib/openpam/modules/pam_unix Makefile.am Makefile.in pam_unix.c lib/libpam/libpam Makefile lib/libpam/modules/pam_krb5 pam_krb5.c lib/libpam/modules/pam_ssh pam_ssh.c lib/libpam/modules/pam_unix pam_unix.c usr.sbin/ppp auth.c Log: MFC: OpenPAM Hydrangea Revision Changes Path 1.1.1.8.10.1 +4 -1 src/contrib/openpam/CREDITS 1.1.1.18.10.1 +25 -2 src/contrib/openpam/HISTORY 1.1.1.3.20.1 +10 -4 src/contrib/openpam/INSTALL 1.1.1.5.20.1 +2 -1 src/contrib/openpam/LICENSE 1.1.1.3.10.1 +15 -3 src/contrib/openpam/Makefile.am 1.1.1.4.10.1 +63 -28 src/contrib/openpam/Makefile.in 1.1.1.5.22.1 +1 -1 src/contrib/openpam/README 1.1.1.18.10.1 +3 -3 src/contrib/openpam/RELNOTES 1.1.1.3.10.1 +1319 -855 src/contrib/openpam/aclocal.m4 1.1.1.2.10.1 +3 -3 src/contrib/openpam/autogen.sh 1.1.1.2.10.1 +6 -2 src/contrib/openpam/bin/Makefile.am 1.1.1.3.10.1 +45 -20 src/contrib/openpam/bin/Makefile.in 1.1.1.2.10.1 +1 -3 src/contrib/openpam/bin/su/Makefile.am 1.1.1.3.10.1 +31 -28 src/contrib/openpam/bin/su/Makefile.in 1.1.1.6.20.1 +5 -3 src/contrib/openpam/bin/su/su.c 1.1.1.2.10.1 +3 -0 src/contrib/openpam/config.h.in 1.1.1.4.10.1 +6585 -6505 src/contrib/openpam/configure 1.1.1.1.10.1 +55 -28 src/contrib/openpam/configure.ac 1.1.1.2.10.1 +38 -34 src/contrib/openpam/depcomp 1.1.1.2.10.1 +1 -1 src/contrib/openpam/doc/Makefile.am 1.1.1.3.10.1 +42 -18 src/contrib/openpam/doc/Makefile.in 1.1.1.3.10.1 +10 -7 src/contrib/openpam/doc/man/Makefile.am 1.1.1.3.10.1 +30 -18 src/contrib/openpam/doc/man/Makefile.in 1.1.1.10.10.1 +9 -8 src/contrib/openpam/doc/man/openpam.3 1.1.1.2.10.1 +1 -1 src/contrib/openpam/doc/man/openpam.man 1.1.1.14.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_borrow_cred.3 1.1.1.14.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_free_data.3 1.1.1.3.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_free_envlist.3 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_get_option.3 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_log.3 1.1.1.11.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_nullconv.3 1.1.1.6.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_readline.3 1.1.1.14.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_restore_cred.3 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_set_option.3 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_ttyconv.3 1.1.1.18.10.1 +6 -5 src/contrib/openpam/doc/man/pam.3 1.1.1.2.10.1 +1 -1 src/contrib/openpam/doc/man/pam.conf.5 1.1.1.3.10.1 +1 -1 src/contrib/openpam/doc/man/pam.man 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_acct_mgmt.3 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_authenticate.3 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_chauthtok.3 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_close_session.3 1.1.1.4.10.1 +2 -1 src/contrib/openpam/doc/man/pam_conv.3 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_end.3 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_error.3 1.1.1.19.10.1 +2 -1 src/contrib/openpam/doc/man/pam_get_authtok.3 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_get_data.3 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_get_item.3 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_get_user.3 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_getenv.3 1.1.1.19.10.1 +2 -1 src/contrib/openpam/doc/man/pam_getenvlist.3 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_info.3 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_open_session.3 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_prompt.3 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_putenv.3 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_set_data.3 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_set_item.3 1.1.1.19.10.1 +2 -1 src/contrib/openpam/doc/man/pam_setcred.3 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_setenv.3 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/pam_sm_acct_mgmt.3 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/pam_sm_authenticate.3 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/pam_sm_chauthtok.3 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/pam_sm_close_session.3 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/pam_sm_open_session.3 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/pam_sm_setcred.3 1.1.1.19.10.1 +2 -1 src/contrib/openpam/doc/man/pam_start.3 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_strerror.3 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_verror.3 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_vinfo.3 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_vprompt.3 1.1.1.2.10.1 +1 -1 src/contrib/openpam/include/Makefile.am 1.1.1.3.10.1 +42 -18 src/contrib/openpam/include/Makefile.in 1.1.1.2.10.1 +2 -1 src/contrib/openpam/include/security/Makefile.am 1.1.1.3.10.1 +29 -12 src/contrib/openpam/include/security/Makefile.in 1.1.1.16.10.1 +100 -67 src/contrib/openpam/include/security/openpam.h 1.1.1.9.10.1 +8 -7 src/contrib/openpam/include/security/openpam_version.h 1.1.1.8.18.1 +41 -23 src/contrib/openpam/include/security/pam_appl.h 1.1.1.12.20.1 +5 -4 src/contrib/openpam/include/security/pam_constants.h 1.1.1.6.20.1 +5 -4 src/contrib/openpam/include/security/pam_modules.h 1.1.1.9.20.1 +6 -5 src/contrib/openpam/include/security/pam_types.h 1.1.1.2.10.1 +50 -52 src/contrib/openpam/install-sh 1.1.1.3.10.1 +21 -7 src/contrib/openpam/lib/Makefile.am 1.1.1.3.10.1 +181 -892 src/contrib/openpam/lib/Makefile.in 1.1.1.8.10.1 +3 -2 src/contrib/openpam/lib/openpam_borrow_cred.c 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/openpam_configure.c 1.1.1.9.20.1 +2 -1 src/contrib/openpam/lib/openpam_dispatch.c 1.1.1.8.10.1 +3 -1 src/contrib/openpam/lib/openpam_dynamic.c 1.1.1.8.20.1 +2 -1 src/contrib/openpam/lib/openpam_findenv.c 1.1.1.5.10.1 +2 -1 src/contrib/openpam/lib/openpam_free_data.c 1.1.1.1.10.1 +1 -1 src/contrib/openpam/lib/openpam_free_envlist.c 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/openpam_get_option.c 1.1.1.16.18.1 +2 -1 src/contrib/openpam/lib/openpam_impl.h 1.1.1.11.10.1 +3 -34 src/contrib/openpam/lib/openpam_load.c 1.1.1.14.10.1 +6 -1 src/contrib/openpam/lib/openpam_log.c 1.1.1.6.10.1 +2 -1 src/contrib/openpam/lib/openpam_nullconv.c 1.1.1.3.2.1 +2 -1 src/contrib/openpam/lib/openpam_readline.c 1.1.1.8.10.1 +4 -3 src/contrib/openpam/lib/openpam_restore_cred.c 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/openpam_set_option.c 1.1.1.5.20.1 +2 -1 src/contrib/openpam/lib/openpam_static.c 1.1.1.16.10.1 +4 -2 src/contrib/openpam/lib/openpam_ttyconv.c 1.1.1.9.20.1 +2 -1 src/contrib/openpam/lib/pam_acct_mgmt.c 1.1.1.10.20.1 +2 -1 src/contrib/openpam/lib/pam_authenticate.c 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/pam_authenticate_secondary.c 1.1.1.10.20.1 +2 -1 src/contrib/openpam/lib/pam_chauthtok.c 1.1.1.9.20.1 +2 -1 src/contrib/openpam/lib/pam_close_session.c 1.1.1.9.20.1 +2 -1 src/contrib/openpam/lib/pam_end.c 1.1.1.6.20.1 +3 -2 src/contrib/openpam/lib/pam_error.c 1.1.1.17.10.1 +2 -1 src/contrib/openpam/lib/pam_get_authtok.c 1.1.1.11.10.1 +4 -3 src/contrib/openpam/lib/pam_get_data.c 1.1.1.9.20.1 +3 -2 src/contrib/openpam/lib/pam_get_item.c 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/pam_get_mapped_authtok.c 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/pam_get_mapped_username.c 1.1.1.12.10.1 +2 -1 src/contrib/openpam/lib/pam_get_user.c 1.1.1.10.20.1 +2 -1 src/contrib/openpam/lib/pam_getenv.c 1.1.1.8.20.1 +2 -1 src/contrib/openpam/lib/pam_getenvlist.c 1.1.1.6.20.1 +3 -2 src/contrib/openpam/lib/pam_info.c 1.1.1.10.10.1 +2 -1 src/contrib/openpam/lib/pam_open_session.c 1.1.1.6.20.1 +3 -2 src/contrib/openpam/lib/pam_prompt.c 1.1.1.8.20.1 +2 -1 src/contrib/openpam/lib/pam_putenv.c 1.1.1.9.20.1 +2 -1 src/contrib/openpam/lib/pam_set_data.c 1.1.1.11.20.1 +2 -1 src/contrib/openpam/lib/pam_set_item.c 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/pam_set_mapped_authtok.c 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/pam_set_mapped_username.c 1.1.1.10.20.1 +2 -1 src/contrib/openpam/lib/pam_setcred.c 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/pam_setenv.c 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_acct_mgmt.c 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_authenticate.c 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_authenticate_secondary.c 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_chauthtok.c 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_close_session.c 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_get_mapped_authtok.c 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_get_mapped_username.c 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_open_session.c 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_set_mapped_authtok.c 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_set_mapped_username.c 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_setcred.c 1.1.1.10.20.1 +2 -1 src/contrib/openpam/lib/pam_start.c 1.1.1.8.10.1 +3 -2 src/contrib/openpam/lib/pam_strerror.c 1.1.1.6.20.1 +3 -2 src/contrib/openpam/lib/pam_verror.c 1.1.1.6.20.1 +3 -2 src/contrib/openpam/lib/pam_vinfo.c 1.1.1.11.18.1 +3 -2 src/contrib/openpam/lib/pam_vprompt.c 1.1.1.4.10.1 +838 -312 src/contrib/openpam/ltmain.sh 1.1.1.12.10.1 +3 -1 src/contrib/openpam/misc/gendoc.pl 1.1.1.2.10.1 +47 -47 src/contrib/openpam/missing 1.1.1.2.10.1 +1 -1 src/contrib/openpam/modules/Makefile.am 1.1.1.3.10.1 +42 -18 src/contrib/openpam/modules/Makefile.in 1.1.1.2.10.1 +1 -1 src/contrib/openpam/modules/pam_deny/Makefile.am 1.1.1.3.10.1 +34 -24 src/contrib/openpam/modules/pam_deny/Makefile.in 1.1.1.7.10.1 +26 -1 src/contrib/openpam/modules/pam_deny/pam_deny.c 1.1.1.2.10.1 +1 -1 src/contrib/openpam/modules/pam_permit/Makefile.am 1.1.1.3.10.1 +34 -24 src/contrib/openpam/modules/pam_permit/Makefile.in 1.1.1.6.20.1 +26 -1 src/contrib/openpam/modules/pam_permit/pam_permit.c 1.1.1.2.10.1 +1 -1 src/contrib/openpam/modules/pam_unix/Makefile.am 1.1.1.3.10.1 +36 -25 src/contrib/openpam/modules/pam_unix/Makefile.in 1.1.1.4.20.1 +30 -6 src/contrib/openpam/modules/pam_unix/pam_unix.c 1.54.10.1 +1 -0 src/lib/libpam/libpam/Makefile 1.23.10.1 +3 -3 src/lib/libpam/modules/pam_krb5/pam_krb5.c 1.44.2.1 +3 -3 src/lib/libpam/modules/pam_ssh/pam_ssh.c 1.52.2.1 +1 -1 src/lib/libpam/modules/pam_unix/pam_unix.c 1.58.10.1 +5 -5 src/usr.sbin/ppp/auth.c From attilio at freebsd.org Fri Jan 18 05:34:59 2008 From: attilio at freebsd.org (Attilio Rao) Date: Fri Jan 18 05:35:02 2008 Subject: cvs commit: src/sys/kern kern_time.c In-Reply-To: <200801181300.m0ID0SMi041767@repoman.freebsd.org> References: <200801181300.m0ID0SMi041767@repoman.freebsd.org> Message-ID: <3bbf2fe10801180534y7f97f39meb0b12624e0b919a@mail.gmail.com> 2008/1/18, David Xu : > davidxu 2008-01-18 13:00:28 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_time.c > Log: > Make sure reading td_runtime in critical section since thread may be > preempted and td_runtime will be modified. If you don't need the operation to be atomical with other operations inside the critical path (and I don't expect so) this change is pointless as our reading are always atomic. Attilio -- Peace can only be achieved by understanding - A. Einstein From des at FreeBSD.org Fri Jan 18 05:35:10 2008 From: des at FreeBSD.org (Dag-Erling Smorgrav) Date: Fri Jan 18 05:35:15 2008 Subject: cvs commit: src/usr.bin/fetch fetch.1 Message-ID: <200801181335.m0IDZAWQ049875@repoman.freebsd.org> des 2008-01-18 13:35:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.bin/fetch fetch.1 Log: MFC: (1.68) document environment variables. Revision Changes Path 1.67.2.1 +19 -9 src/usr.bin/fetch/fetch.1 From jhb at freebsd.org Fri Jan 18 06:29:51 2008 From: jhb at freebsd.org (John Baldwin) Date: Fri Jan 18 06:29:59 2008 Subject: cvs commit: src/lib/libarchive archive_write_disk.c src/lib/libarchive/test Makefile test_write_disk_hardlink.c In-Reply-To: <200801180505.m0I55woO042844@repoman.freebsd.org> References: <200801180505.m0I55woO042844@repoman.freebsd.org> Message-ID: <200801180829.03092.jhb@freebsd.org> On Friday 18 January 2008 12:05:58 am Tim Kientzle wrote: > kientzle 2008-01-18 05:05:58 UTC > > FreeBSD src repository > > Modified files: > lib/libarchive archive_write_disk.c > lib/libarchive/test Makefile > Added files: > lib/libarchive/test test_write_disk_hardlink.c > Log: > Issues with hardlinks in newc-format files prompted me to > write a new test to exercise the hardlink strategies used > by different archive formats (tar, old cpio, new cpio). > This uncovered two problems, both fixed by this commit: > > 1) Enforce file size when writing files to disk. > > 2) When restoring hardlink entries, if they have data associated, go > ahead and open the file so we can write the data. > > In particular, this fixes bsdtar/bsdcpio extraction of new cpio > formats where the "original" is empty and the subsequent "hardlink" > entry actually carries the data. It also provides correct behavior > for old cpio archives where hardlinked entries have their bodies > stored multiple times in the archive; the last body should always be > the one that ends up in the final file. The new pax format also > permits (but does not require) hardlinks to carry file data; again, > the last contents should always win. > > Note that with any of these, a size of zero on a hardlink simply means > that the hardlink carries no data; it does not mean that the file has > zero size. A non-zero size on a hardlink does provide the file size. > > Thanks to: John Baldwin, for reminding me about this long-standing bug > and sending me a simple example archive that prompted this test case Woo, thanks! -- John Baldwin From jhb at freebsd.org Fri Jan 18 06:30:01 2008 From: jhb at freebsd.org (John Baldwin) Date: Fri Jan 18 06:30:22 2008 Subject: cvs commit: src/sys/kern kern_time.c In-Reply-To: <3bbf2fe10801180534y7f97f39meb0b12624e0b919a@mail.gmail.com> References: <200801181300.m0ID0SMi041767@repoman.freebsd.org> <3bbf2fe10801180534y7f97f39meb0b12624e0b919a@mail.gmail.com> Message-ID: <200801180929.45123.jhb@freebsd.org> On Friday 18 January 2008 08:34:57 am Attilio Rao wrote: > 2008/1/18, David Xu : > > davidxu 2008-01-18 13:00:28 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_time.c > > Log: > > Make sure reading td_runtime in critical section since thread may be > > preempted and td_runtime will be modified. > > If you don't need the operation to be atomical with other operations > inside the critical path (and I don't expect so) this change is > pointless as our reading are always atomic. Not on 32-bit archs like i386. They may do two 32-bit reads and you could have problems if the lower 32 wraps in between the reads. -- John Baldwin From attilio at freebsd.org Fri Jan 18 06:36:18 2008 From: attilio at freebsd.org (Attilio Rao) Date: Fri Jan 18 06:36:21 2008 Subject: cvs commit: src/sys/kern kern_time.c In-Reply-To: <200801180929.45123.jhb@freebsd.org> References: <200801181300.m0ID0SMi041767@repoman.freebsd.org> <3bbf2fe10801180534y7f97f39meb0b12624e0b919a@mail.gmail.com> <200801180929.45123.jhb@freebsd.org> Message-ID: <3bbf2fe10801180636q3e286316w9ca685f92cf53828@mail.gmail.com> 2008/1/18, John Baldwin : > On Friday 18 January 2008 08:34:57 am Attilio Rao wrote: > > 2008/1/18, David Xu : > > > davidxu 2008-01-18 13:00:28 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/kern kern_time.c > > > Log: > > > Make sure reading td_runtime in critical section since thread may be > > > preempted and td_runtime will be modified. > > > > If you don't need the operation to be atomical with other operations > > inside the critical path (and I don't expect so) this change is > > pointless as our reading are always atomic. > > Not on 32-bit archs like i386. They may do two 32-bit reads and you could > have problems if the lower 32 wraps in between the reads. Ah, right, td_runtime is uint64_t, sorry. Attilio -- Peace can only be achieved by understanding - A. Einstein From rwatson at FreeBSD.org Fri Jan 18 06:38:13 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Fri Jan 18 06:38:16 2008 Subject: cvs commit: src/sys/kern kern_time.c In-Reply-To: <200801181300.m0ID0SMi041767@repoman.freebsd.org> References: <200801181300.m0ID0SMi041767@repoman.freebsd.org> Message-ID: <20080118143759.P28136@fledge.watson.org> On Fri, 18 Jan 2008, David Xu wrote: > davidxu 2008-01-18 13:00:28 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_time.c > Log: > Make sure reading td_runtime in critical section since thread may be > preempted and td_runtime will be modified. Thanks! Robert N M Watson Computer Laboratory University of Cambridge From kostikbel at gmail.com Fri Jan 18 07:32:02 2008 From: kostikbel at gmail.com (Kostik Belousov) Date: Fri Jan 18 07:32:05 2008 Subject: cvs commit: src/contrib/openpam CREDITS HISTORY INSTALL LICENSE Makefile.am Makefile.in README RELNOTES aclocal.m4 autogen.sh config.h.in configure configure.ac depcomp install-sh ltmain.sh missing src/contrib/openpam/bin Makefile.am Makefile.in ... In-Reply-To: <200801181329.m0IDT5Kh048537@repoman.freebsd.org> References: <200801181329.m0IDT5Kh048537@repoman.freebsd.org> Message-ID: <20080118153156.GJ57756@deviant.kiev.zoral.com.ua> On Fri, Jan 18, 2008 at 01:29:05PM +0000, Dag-Erling Smorgrav wrote: > des 2008-01-18 13:29:05 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_7) > contrib/openpam CREDITS HISTORY INSTALL LICENSE > Makefile.am Makefile.in README RELNOTES > aclocal.m4 autogen.sh config.h.in > configure configure.ac depcomp install-sh > ltmain.sh missing > contrib/openpam/bin Makefile.am Makefile.in > contrib/openpam/bin/su Makefile.am Makefile.in su.c > contrib/openpam/doc Makefile.am Makefile.in > contrib/openpam/doc/man Makefile.am Makefile.in openpam.3 > openpam.man openpam_borrow_cred.3 > openpam_free_data.3 > openpam_free_envlist.3 > openpam_get_option.3 openpam_log.3 > openpam_nullconv.3 openpam_readline.3 > openpam_restore_cred.3 > openpam_set_option.3 openpam_ttyconv.3 > pam.3 pam.conf.5 pam.man > pam_acct_mgmt.3 pam_authenticate.3 > pam_chauthtok.3 pam_close_session.3 > pam_conv.3 pam_end.3 pam_error.3 > pam_get_authtok.3 pam_get_data.3 > pam_get_item.3 pam_get_user.3 > pam_getenv.3 pam_getenvlist.3 > pam_info.3 pam_open_session.3 > pam_prompt.3 pam_putenv.3 > pam_set_data.3 pam_set_item.3 > pam_setcred.3 pam_setenv.3 > pam_sm_acct_mgmt.3 > pam_sm_authenticate.3 > pam_sm_chauthtok.3 > pam_sm_close_session.3 > pam_sm_open_session.3 pam_sm_setcred.3 > pam_start.3 pam_strerror.3 > pam_verror.3 pam_vinfo.3 pam_vprompt.3 > contrib/openpam/include Makefile.am Makefile.in > contrib/openpam/include/security Makefile.am Makefile.in > openpam.h openpam_version.h > pam_appl.h pam_constants.h > pam_modules.h pam_types.h > contrib/openpam/lib Makefile.am Makefile.in > openpam_borrow_cred.c openpam_configure.c > openpam_dispatch.c openpam_dynamic.c > openpam_findenv.c openpam_free_data.c > openpam_free_envlist.c > openpam_get_option.c openpam_impl.h > openpam_load.c openpam_log.c > openpam_nullconv.c openpam_readline.c > openpam_restore_cred.c > openpam_set_option.c openpam_static.c > openpam_ttyconv.c pam_acct_mgmt.c > pam_authenticate.c > pam_authenticate_secondary.c > pam_chauthtok.c pam_close_session.c > pam_end.c pam_error.c pam_get_authtok.c > pam_get_data.c pam_get_item.c > pam_get_mapped_authtok.c > pam_get_mapped_username.c pam_get_user.c > pam_getenv.c pam_getenvlist.c pam_info.c > pam_open_session.c pam_prompt.c > pam_putenv.c pam_set_data.c > pam_set_item.c pam_set_mapped_authtok.c > pam_set_mapped_username.c pam_setcred.c > pam_setenv.c pam_sm_acct_mgmt.c > pam_sm_authenticate.c > pam_sm_authenticate_secondary.c > pam_sm_chauthtok.c pam_sm_close_session.c > pam_sm_get_mapped_authtok.c > pam_sm_get_mapped_username.c > pam_sm_open_session.c > pam_sm_set_mapped_authtok.c > pam_sm_set_mapped_username.c > pam_sm_setcred.c pam_start.c > pam_strerror.c pam_verror.c pam_vinfo.c > pam_vprompt.c > contrib/openpam/misc gendoc.pl > contrib/openpam/modules Makefile.am Makefile.in > contrib/openpam/modules/pam_deny Makefile.am Makefile.in > pam_deny.c > contrib/openpam/modules/pam_permit Makefile.am Makefile.in > pam_permit.c > contrib/openpam/modules/pam_unix Makefile.am Makefile.in > pam_unix.c > lib/libpam/libpam Makefile > lib/libpam/modules/pam_krb5 pam_krb5.c > lib/libpam/modules/pam_ssh pam_ssh.c > lib/libpam/modules/pam_unix pam_unix.c > usr.sbin/ppp auth.c > Log: > MFC: OpenPAM Hydrangea > > Revision Changes Path > 1.1.1.8.10.1 +4 -1 src/contrib/openpam/CREDITS > 1.1.1.18.10.1 +25 -2 src/contrib/openpam/HISTORY > 1.1.1.3.20.1 +10 -4 src/contrib/openpam/INSTALL > 1.1.1.5.20.1 +2 -1 src/contrib/openpam/LICENSE > 1.1.1.3.10.1 +15 -3 src/contrib/openpam/Makefile.am > 1.1.1.4.10.1 +63 -28 src/contrib/openpam/Makefile.in > 1.1.1.5.22.1 +1 -1 src/contrib/openpam/README > 1.1.1.18.10.1 +3 -3 src/contrib/openpam/RELNOTES > 1.1.1.3.10.1 +1319 -855 src/contrib/openpam/aclocal.m4 > 1.1.1.2.10.1 +3 -3 src/contrib/openpam/autogen.sh > 1.1.1.2.10.1 +6 -2 src/contrib/openpam/bin/Makefile.am > 1.1.1.3.10.1 +45 -20 src/contrib/openpam/bin/Makefile.in > 1.1.1.2.10.1 +1 -3 src/contrib/openpam/bin/su/Makefile.am > 1.1.1.3.10.1 +31 -28 src/contrib/openpam/bin/su/Makefile.in > 1.1.1.6.20.1 +5 -3 src/contrib/openpam/bin/su/su.c > 1.1.1.2.10.1 +3 -0 src/contrib/openpam/config.h.in > 1.1.1.4.10.1 +6585 -6505 src/contrib/openpam/configure > 1.1.1.1.10.1 +55 -28 src/contrib/openpam/configure.ac > 1.1.1.2.10.1 +38 -34 src/contrib/openpam/depcomp > 1.1.1.2.10.1 +1 -1 src/contrib/openpam/doc/Makefile.am > 1.1.1.3.10.1 +42 -18 src/contrib/openpam/doc/Makefile.in > 1.1.1.3.10.1 +10 -7 src/contrib/openpam/doc/man/Makefile.am > 1.1.1.3.10.1 +30 -18 src/contrib/openpam/doc/man/Makefile.in > 1.1.1.10.10.1 +9 -8 src/contrib/openpam/doc/man/openpam.3 > 1.1.1.2.10.1 +1 -1 src/contrib/openpam/doc/man/openpam.man > 1.1.1.14.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_borrow_cred.3 > 1.1.1.14.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_free_data.3 > 1.1.1.3.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_free_envlist.3 > 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_get_option.3 > 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_log.3 > 1.1.1.11.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_nullconv.3 > 1.1.1.6.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_readline.3 > 1.1.1.14.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_restore_cred.3 > 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_set_option.3 > 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/openpam_ttyconv.3 > 1.1.1.18.10.1 +6 -5 src/contrib/openpam/doc/man/pam.3 > 1.1.1.2.10.1 +1 -1 src/contrib/openpam/doc/man/pam.conf.5 > 1.1.1.3.10.1 +1 -1 src/contrib/openpam/doc/man/pam.man > 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_acct_mgmt.3 > 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_authenticate.3 > 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_chauthtok.3 > 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_close_session.3 > 1.1.1.4.10.1 +2 -1 src/contrib/openpam/doc/man/pam_conv.3 > 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_end.3 > 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_error.3 > 1.1.1.19.10.1 +2 -1 src/contrib/openpam/doc/man/pam_get_authtok.3 > 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_get_data.3 > 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_get_item.3 > 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_get_user.3 > 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_getenv.3 > 1.1.1.19.10.1 +2 -1 src/contrib/openpam/doc/man/pam_getenvlist.3 > 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_info.3 > 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_open_session.3 > 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_prompt.3 > 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_putenv.3 > 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_set_data.3 > 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_set_item.3 > 1.1.1.19.10.1 +2 -1 src/contrib/openpam/doc/man/pam_setcred.3 > 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_setenv.3 > 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/pam_sm_acct_mgmt.3 > 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/pam_sm_authenticate.3 > 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/pam_sm_chauthtok.3 > 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/pam_sm_close_session.3 > 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/pam_sm_open_session.3 > 1.1.1.17.10.1 +2 -1 src/contrib/openpam/doc/man/pam_sm_setcred.3 > 1.1.1.19.10.1 +2 -1 src/contrib/openpam/doc/man/pam_start.3 > 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_strerror.3 > 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_verror.3 > 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_vinfo.3 > 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_vprompt.3 > 1.1.1.2.10.1 +1 -1 src/contrib/openpam/include/Makefile.am > 1.1.1.3.10.1 +42 -18 src/contrib/openpam/include/Makefile.in > 1.1.1.2.10.1 +2 -1 src/contrib/openpam/include/security/Makefile.am > 1.1.1.3.10.1 +29 -12 src/contrib/openpam/include/security/Makefile.in > 1.1.1.16.10.1 +100 -67 src/contrib/openpam/include/security/openpam.h > 1.1.1.9.10.1 +8 -7 src/contrib/openpam/include/security/openpam_version.h > 1.1.1.8.18.1 +41 -23 src/contrib/openpam/include/security/pam_appl.h > 1.1.1.12.20.1 +5 -4 src/contrib/openpam/include/security/pam_constants.h > 1.1.1.6.20.1 +5 -4 src/contrib/openpam/include/security/pam_modules.h > 1.1.1.9.20.1 +6 -5 src/contrib/openpam/include/security/pam_types.h > 1.1.1.2.10.1 +50 -52 src/contrib/openpam/install-sh > 1.1.1.3.10.1 +21 -7 src/contrib/openpam/lib/Makefile.am > 1.1.1.3.10.1 +181 -892 src/contrib/openpam/lib/Makefile.in > 1.1.1.8.10.1 +3 -2 src/contrib/openpam/lib/openpam_borrow_cred.c > 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/openpam_configure.c > 1.1.1.9.20.1 +2 -1 src/contrib/openpam/lib/openpam_dispatch.c > 1.1.1.8.10.1 +3 -1 src/contrib/openpam/lib/openpam_dynamic.c > 1.1.1.8.20.1 +2 -1 src/contrib/openpam/lib/openpam_findenv.c > 1.1.1.5.10.1 +2 -1 src/contrib/openpam/lib/openpam_free_data.c > 1.1.1.1.10.1 +1 -1 src/contrib/openpam/lib/openpam_free_envlist.c > 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/openpam_get_option.c > 1.1.1.16.18.1 +2 -1 src/contrib/openpam/lib/openpam_impl.h > 1.1.1.11.10.1 +3 -34 src/contrib/openpam/lib/openpam_load.c > 1.1.1.14.10.1 +6 -1 src/contrib/openpam/lib/openpam_log.c > 1.1.1.6.10.1 +2 -1 src/contrib/openpam/lib/openpam_nullconv.c > 1.1.1.3.2.1 +2 -1 src/contrib/openpam/lib/openpam_readline.c > 1.1.1.8.10.1 +4 -3 src/contrib/openpam/lib/openpam_restore_cred.c > 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/openpam_set_option.c > 1.1.1.5.20.1 +2 -1 src/contrib/openpam/lib/openpam_static.c > 1.1.1.16.10.1 +4 -2 src/contrib/openpam/lib/openpam_ttyconv.c > 1.1.1.9.20.1 +2 -1 src/contrib/openpam/lib/pam_acct_mgmt.c > 1.1.1.10.20.1 +2 -1 src/contrib/openpam/lib/pam_authenticate.c > 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/pam_authenticate_secondary.c > 1.1.1.10.20.1 +2 -1 src/contrib/openpam/lib/pam_chauthtok.c > 1.1.1.9.20.1 +2 -1 src/contrib/openpam/lib/pam_close_session.c > 1.1.1.9.20.1 +2 -1 src/contrib/openpam/lib/pam_end.c > 1.1.1.6.20.1 +3 -2 src/contrib/openpam/lib/pam_error.c > 1.1.1.17.10.1 +2 -1 src/contrib/openpam/lib/pam_get_authtok.c > 1.1.1.11.10.1 +4 -3 src/contrib/openpam/lib/pam_get_data.c > 1.1.1.9.20.1 +3 -2 src/contrib/openpam/lib/pam_get_item.c > 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/pam_get_mapped_authtok.c > 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/pam_get_mapped_username.c > 1.1.1.12.10.1 +2 -1 src/contrib/openpam/lib/pam_get_user.c > 1.1.1.10.20.1 +2 -1 src/contrib/openpam/lib/pam_getenv.c > 1.1.1.8.20.1 +2 -1 src/contrib/openpam/lib/pam_getenvlist.c > 1.1.1.6.20.1 +3 -2 src/contrib/openpam/lib/pam_info.c > 1.1.1.10.10.1 +2 -1 src/contrib/openpam/lib/pam_open_session.c > 1.1.1.6.20.1 +3 -2 src/contrib/openpam/lib/pam_prompt.c > 1.1.1.8.20.1 +2 -1 src/contrib/openpam/lib/pam_putenv.c > 1.1.1.9.20.1 +2 -1 src/contrib/openpam/lib/pam_set_data.c > 1.1.1.11.20.1 +2 -1 src/contrib/openpam/lib/pam_set_item.c > 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/pam_set_mapped_authtok.c > 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/pam_set_mapped_username.c > 1.1.1.10.20.1 +2 -1 src/contrib/openpam/lib/pam_setcred.c > 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/pam_setenv.c > 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_acct_mgmt.c > 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_authenticate.c > 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_authenticate_secondary.c > 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_chauthtok.c > 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_close_session.c > 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_get_mapped_authtok.c > 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_get_mapped_username.c > 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_open_session.c > 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_set_mapped_authtok.c > 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_set_mapped_username.c > 1.1.1.6.20.1 +2 -1 src/contrib/openpam/lib/pam_sm_setcred.c > 1.1.1.10.20.1 +2 -1 src/contrib/openpam/lib/pam_start.c > 1.1.1.8.10.1 +3 -2 src/contrib/openpam/lib/pam_strerror.c > 1.1.1.6.20.1 +3 -2 src/contrib/openpam/lib/pam_verror.c > 1.1.1.6.20.1 +3 -2 src/contrib/openpam/lib/pam_vinfo.c > 1.1.1.11.18.1 +3 -2 src/contrib/openpam/lib/pam_vprompt.c > 1.1.1.4.10.1 +838 -312 src/contrib/openpam/ltmain.sh > 1.1.1.12.10.1 +3 -1 src/contrib/openpam/misc/gendoc.pl > 1.1.1.2.10.1 +47 -47 src/contrib/openpam/missing > 1.1.1.2.10.1 +1 -1 src/contrib/openpam/modules/Makefile.am > 1.1.1.3.10.1 +42 -18 src/contrib/openpam/modules/Makefile.in > 1.1.1.2.10.1 +1 -1 src/contrib/openpam/modules/pam_deny/Makefile.am > 1.1.1.3.10.1 +34 -24 src/contrib/openpam/modules/pam_deny/Makefile.in > 1.1.1.7.10.1 +26 -1 src/contrib/openpam/modules/pam_deny/pam_deny.c > 1.1.1.2.10.1 +1 -1 src/contrib/openpam/modules/pam_permit/Makefile.am > 1.1.1.3.10.1 +34 -24 src/contrib/openpam/modules/pam_permit/Makefile.in > 1.1.1.6.20.1 +26 -1 src/contrib/openpam/modules/pam_permit/pam_permit.c > 1.1.1.2.10.1 +1 -1 src/contrib/openpam/modules/pam_unix/Makefile.am > 1.1.1.3.10.1 +36 -25 src/contrib/openpam/modules/pam_unix/Makefile.in > 1.1.1.4.20.1 +30 -6 src/contrib/openpam/modules/pam_unix/pam_unix.c > 1.54.10.1 +1 -0 src/lib/libpam/libpam/Makefile > 1.23.10.1 +3 -3 src/lib/libpam/modules/pam_krb5/pam_krb5.c > 1.44.2.1 +3 -3 src/lib/libpam/modules/pam_ssh/pam_ssh.c > 1.52.2.1 +1 -1 src/lib/libpam/modules/pam_unix/pam_unix.c > 1.58.10.1 +5 -5 src/usr.sbin/ppp/auth.c Was security/openpam_attr.h forgotten from being added to the MFC ? Trying to rebuild world, I get ===> lib/libpam/modules/pam_ssh (buildincludes) ===> lib/libpam/modules/pam_tacplus (buildincludes) ===> lib/libpam/modules/pam_unix (buildincludes) ===> lib/libpam/libpam (buildincludes) make: don't know how to make security/openpam_attr.h. Stop *** Error code 2 Stop in /usr/bsd/src/lib/libpam. *** Error code 1 -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 195 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080118/23e07a39/attachment.pgp From ambrisko at FreeBSD.org Fri Jan 18 08:31:25 2008 From: ambrisko at FreeBSD.org (Doug Ambrisko) Date: Fri Jan 18 08:31:28 2008 Subject: cvs commit: src/sys/dev/an if_an.c if_an_pci.c if_anreg.h Message-ID: <200801181631.m0IGVPeP080939@repoman.freebsd.org> ambrisko 2008-01-18 16:31:24 UTC FreeBSD src repository Modified files: sys/dev/an if_an.c if_an_pci.c if_anreg.h Log: First real attempt at proper locking. The locking is a little complicated since the the command and data that is being built to be sent to or read from the HW lives in the softc. Commands are later run via an_setdef etc. In the ioctl path various references are kept to the data stored in the softc so it needs to be protected. Almost think of the command in the softc a global variable since it essentially is. Since locking wasn't done in this type of context the commands would get corrupted. Thanks to avatar@ for catching some lock issues and dhw@ for testing. Things are a lot more stable except for the MPI-350 cards. My an(4) remote laptop stays on the network now. The driver should be changed so that it uses private memory that is passed to the functions that talk to the card. Then only those functions would really need to grab locks. Reviewed by: avatar@ Revision Changes Path 1.87 +248 -121 src/sys/dev/an/if_an.c 1.29 +4 -1 src/sys/dev/an/if_an_pci.c 1.25 +1 -0 src/sys/dev/an/if_anreg.h From ambrisko at FreeBSD.org Fri Jan 18 08:34:20 2008 From: ambrisko at FreeBSD.org (Doug Ambrisko) Date: Fri Jan 18 08:34:22 2008 Subject: cvs commit: src/sys/dev/an if_an.c if_an_pci.c Message-ID: <200801181634.m0IGYIcb081702@repoman.freebsd.org> ambrisko 2008-01-18 16:34:18 UTC FreeBSD src repository Modified files: sys/dev/an if_an.c if_an_pci.c Log: Style changes from avatar. Submitted by: avatar Revision Changes Path 1.88 +39 -39 src/sys/dev/an/if_an.c 1.30 +9 -9 src/sys/dev/an/if_an_pci.c From brueffer at FreeBSD.org Fri Jan 18 08:45:43 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Fri Jan 18 08:45:48 2008 Subject: cvs commit: src/share/man/man5 src.conf.5 src/tools/build/options WITHOUT_FORTRAN Message-ID: <200801181645.m0IGjh9g083341@repoman.freebsd.org> brueffer 2008-01-18 16:45:43 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man5 src.conf.5 Removed files: (Branch: RELENG_7) tools/build/options WITHOUT_FORTRAN Log: MFC: WITHOUT_FORTRAN was removed some time ago. Regen src.conf.5. Revision Changes Path 1.18.2.3 +3 -8 src/share/man/man5/src.conf.5 1.1.2.1 +0 -4 src/tools/build/options/WITHOUT_FORTRAN (dead) From brueffer at FreeBSD.org Fri Jan 18 09:00:45 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Fri Jan 18 09:00:50 2008 Subject: cvs commit: src/share/man/man4 pcib.4 Message-ID: <200801181700.m0IH0iX5094174@repoman.freebsd.org> brueffer 2008-01-18 17:00:44 UTC FreeBSD src repository Modified files: share/man/man4 pcib.4 Log: pcib is compiled in when "device pci" is specified. Submitted by: marius Reviewed by: imp Revision Changes Path 1.3 +2 -2 src/share/man/man4/pcib.4 From julian at FreeBSD.org Fri Jan 18 09:02:14 2008 From: julian at FreeBSD.org (Julian Elischer) Date: Fri Jan 18 09:02:21 2008 Subject: cvs commit: src/sys/kern genassym.sh Message-ID: <200801181702.m0IH2EX9094763@repoman.freebsd.org> julian 2008-01-18 17:02:14 UTC FreeBSD src repository Modified files: sys/kern genassym.sh Log: refactor code so it can run in a chroot without having to have /dev/mounted MFC After: 1 week Revision Changes Path 1.5 +48 -33 src/sys/kern/genassym.sh From remko at FreeBSD.org Fri Jan 18 09:03:37 2008 From: remko at FreeBSD.org (Remko Lodder) Date: Fri Jan 18 09:03:38 2008 Subject: cvs commit: src/sys/nfsserver nfs_srvsubs.c Message-ID: <200801181703.m0IH3aav096307@repoman.freebsd.org> remko 2008-01-18 17:03:36 UTC FreeBSD src repository Modified files: sys/nfsserver nfs_srvsubs.c Log: Use nfsrv_destroycache() only once, else it crashes the server. PR: kern/118152 Submitted by: Bjoern Groenvall Approved by: imp (mentor, a while ago already), jhb MFC After: 3 days Revision Changes Path 1.153 +0 -1 src/sys/nfsserver/nfs_srvsubs.c From kib at FreeBSD.org Fri Jan 18 10:07:05 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Fri Jan 18 10:07:10 2008 Subject: cvs commit: src/sys/kern tty_pty.c Message-ID: <200801181807.m0II741E008940@repoman.freebsd.org> kib 2008-01-18 18:07:04 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: In the rev. 1.153, the one place for converting minor number to unit was missed. As result, pty_create_slave() may index out of the names[] bounds, creating wrong slave tty names. Tested by: kensmith Reviewed by: jhb MFC after: 3 days Revision Changes Path 1.156 +3 -1 src/sys/kern/tty_pty.c From wearabnet at yahoo.ca Fri Jan 18 10:22:47 2008 From: wearabnet at yahoo.ca (Abdullah Ibn Hamad Al-Marri) Date: Fri Jan 18 10:23:04 2008 Subject: cvs commit: src/contrib/openpam CREDITS HISTORY INSTALL LICENSE Makefile.am Makefile.in README RELNOTES aclocal.m4 autogen.sh config.h.in configure configure.ac depcomp install-sh ltmain.sh missing src/contrib/openpam/bin Makefile.am Makefile.in ... Message-ID: <144021.43327.qm@web33706.mail.mud.yahoo.com> ----- Original Message ---- > From: Kostik Belousov > To: Dag-Erling Smorgrav > Cc: cvs-src@freebsd.org; src-committers@freebsd.org; cvs-all@freebsd.org > Sent: Friday, January 18, 2008 6:31:56 PM > Subject: Re: cvs commit: src/contrib/openpam CREDITS HISTORY INSTALL LICENSE Makefile.am Makefile.in README RELNOTES aclocal.m4 autogen.sh config.h.in configure configure.ac depcomp install-sh ltmain.sh missing src/contrib/openpam/bin Makefile.am Makefile.in ... > > On Fri, Jan 18, 2008 at 01:29:05PM +0000, Dag-Erling Smorgrav wrote: > > des 2008-01-18 13:29:05 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_7) > > contrib/openpam CREDITS HISTORY INSTALL LICENSE > > Makefile.am Makefile.in README RELNOTES > > aclocal.m4 autogen.sh config.h.in > > configure configure.ac depcomp install-sh > > ltmain.sh missing > > contrib/openpam/bin Makefile.am Makefile.in > > contrib/openpam/bin/su Makefile.am Makefile.in su.c > > contrib/openpam/doc Makefile.am Makefile.in > > contrib/openpam/doc/man Makefile.am Makefile.in openpam.3 > > openpam.man openpam_borrow_cred.3 > > openpam_free_data.3 > > openpam_free_envlist.3 > > openpam_get_option.3 openpam_log.3 > > openpam_nullconv.3 openpam_readline.3 > > openpam_restore_cred.3 > > openpam_set_option.3 openpam_ttyconv.3 > > pam.3 pam.conf.5 pam.man > > pam_acct_mgmt.3 pam_authenticate.3 > > pam_chauthtok.3 pam_close_session.3 > > pam_conv.3 pam_end.3 pam_error.3 > > pam_get_authtok.3 pam_get_data.3 > > pam_get_item.3 pam_get_user.3 > > pam_getenv.3 pam_getenvlist.3 > > pam_info.3 pam_open_session.3 > > pam_prompt.3 pam_putenv.3 > > pam_set_data.3 pam_set_item.3 > > pam_setcred.3 pam_setenv.3 > > pam_sm_acct_mgmt.3 > > pam_sm_authenticate.3 > > pam_sm_chauthtok.3 > > pam_sm_close_session.3 > > pam_sm_open_session.3 pam_sm_setcred.3 > > pam_start.3 pam_strerror.3 > > pam_verror.3 pam_vinfo.3 pam_vprompt.3 > > contrib/openpam/include Makefile.am Makefile.in > > contrib/openpam/include/security Makefile.am Makefile.in > > openpam.h openpam_version.h > > pam_appl.h pam_constants.h > > pam_modules.h pam_types.h > > contrib/openpam/lib Makefile.am Makefile.in > > openpam_borrow_cred.c openpam_configure.c > > openpam_dispatch.c openpam_dynamic.c > > openpam_findenv.c openpam_free_data.c > > openpam_free_envlist.c > > openpam_get_option.c openpam_impl.h > > openpam_load.c openpam_log.c > > openpam_nullconv.c openpam_readline.c > > openpam_restore_cred.c > > openpam_set_option.c openpam_static.c > > openpam_ttyconv.c pam_acct_mgmt.c > > pam_authenticate.c > > pam_authenticate_secondary.c > > pam_chauthtok.c pam_close_session.c > > pam_end.c pam_error.c pam_get_authtok.c > > pam_get_data.c pam_get_item.c > > pam_get_mapped_authtok.c > > pam_get_mapped_username.c pam_get_user.c > > pam_getenv.c pam_getenvlist.c pam_info.c > > pam_open_session.c pam_prompt.c > > pam_putenv.c pam_set_data.c > > pam_set_item.c pam_set_mapped_authtok.c > > pam_set_mapped_username.c pam_setcred.c > > pam_setenv.c pam_sm_acct_mgmt.c > > pam_sm_authenticate.c > > pam_sm_authenticate_secondary.c > > pam_sm_chauthtok.c pam_sm_close_session.c > > pam_sm_get_mapped_authtok.c > > pam_sm_get_mapped_username.c > > pam_sm_open_session.c > > pam_sm_set_mapped_authtok.c > > pam_sm_set_mapped_username.c > > pam_sm_setcred.c pam_start.c > > pam_strerror.c pam_verror.c pam_vinfo.c > > pam_vprompt.c > > contrib/openpam/misc gendoc.pl > > contrib/openpam/modules Makefile.am Makefile.in > > contrib/openpam/modules/pam_deny Makefile.am Makefile.in > > pam_deny.c > > contrib/openpam/modules/pam_permit Makefile.am Makefile.in > > pam_permit.c > > contrib/openpam/modules/pam_unix Makefile.am Makefile.in > > pam_unix.c > > lib/libpam/libpam Makefile > > lib/libpam/modules/pam_krb5 pam_krb5.c > > lib/libpam/modules/pam_ssh pam_ssh.c > > lib/libpam/modules/pam_unix pam_unix.c > > usr.sbin/ppp auth.c > > Log: > > MFC: OpenPAM Hydrangea > > > > Revision Changes Path > > 1.1.1.8.10.1 +4 -1 src/contrib/openpam/CREDITS > > 1.1.1.18.10.1 +25 -2 src/contrib/openpam/HISTORY > > 1.1.1.3.20.1 +10 -4 src/contrib/openpam/INSTALL > > 1.1.1.5.20.1 +2 -1 src/contrib/openpam/LICENSE > > 1.1.1.3.10.1 +15 -3 src/contrib/openpam/Makefile.am > > 1.1.1.4.10.1 +63 -28 src/contrib/openpam/Makefile.in > > 1.1.1.5.22.1 +1 -1 src/contrib/openpam/README > > 1.1.1.18.10.1 +3 -3 src/contrib/openpam/RELNOTES > > 1.1.1.3.10.1 +1319 -855 src/contrib/openpam/aclocal.m4 > > 1.1.1.2.10.1 +3 -3 src/contrib/openpam/autogen.sh > > 1.1.1.2.10.1 +6 -2 src/contrib/openpam/bin/Makefile.am > > 1.1.1.3.10.1 +45 -20 src/contrib/openpam/bin/Makefile.in > > 1.1.1.2.10.1 +1 -3 src/contrib/openpam/bin/su/Makefile.am > > 1.1.1.3.10.1 +31 -28 src/contrib/openpam/bin/su/Makefile.in > > 1.1.1.6.20.1 +5 -3 src/contrib/openpam/bin/su/su.c > > 1.1.1.2.10.1 +3 -0 src/contrib/openpam/config.h.in > > 1.1.1.4.10.1 +6585 -6505 src/contrib/openpam/configure > > 1.1.1.1.10.1 +55 -28 src/contrib/openpam/configure.ac > > 1.1.1.2.10.1 +38 -34 src/contrib/openpam/depcomp > > 1.1.1.2.10.1 +1 -1 src/contrib/openpam/doc/Makefile.am > > 1.1.1.3.10.1 +42 -18 src/contrib/openpam/doc/Makefile.in > > 1.1.1.3.10.1 +10 -7 src/contrib/openpam/doc/man/Makefile.am > > 1.1.1.3.10.1 +30 -18 src/contrib/openpam/doc/man/Makefile.in > > 1.1.1.10.10.1 +9 -8 src/contrib/openpam/doc/man/openpam.3 > > 1.1.1.2.10.1 +1 -1 src/contrib/openpam/doc/man/openpam.man > > 1.1.1.14.10.1 +2 -1 > src/contrib/openpam/doc/man/openpam_borrow_cred.3 > > 1.1.1.14.10.1 +2 -1 > src/contrib/openpam/doc/man/openpam_free_data.3 > > 1.1.1.3.10.1 +2 -1 > src/contrib/openpam/doc/man/openpam_free_envlist.3 > > 1.1.1.17.10.1 +2 -1 > src/contrib/openpam/doc/man/openpam_get_option.3 > > 1.1.1.17.10.1 +2 -1 > src/contrib/openpam/doc/man/openpam_log.3 > > 1.1.1.11.10.1 +2 -1 > src/contrib/openpam/doc/man/openpam_nullconv.3 > > 1.1.1.6.10.1 +2 -1 > src/contrib/openpam/doc/man/openpam_readline.3 > > 1.1.1.14.10.1 +2 -1 > src/contrib/openpam/doc/man/openpam_restore_cred.3 > > 1.1.1.17.10.1 +2 -1 > src/contrib/openpam/doc/man/openpam_set_option.3 > > 1.1.1.17.10.1 +2 -1 > src/contrib/openpam/doc/man/openpam_ttyconv.3 > > 1.1.1.18.10.1 +6 -5 src/contrib/openpam/doc/man/pam.3 > > 1.1.1.2.10.1 +1 -1 src/contrib/openpam/doc/man/pam.conf.5 > > 1.1.1.3.10.1 +1 -1 src/contrib/openpam/doc/man/pam.man > > 1.1.1.18.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_acct_mgmt.3 > > 1.1.1.18.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_authenticate.3 > > 1.1.1.18.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_chauthtok.3 > > 1.1.1.18.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_close_session.3 > > 1.1.1.4.10.1 +2 -1 src/contrib/openpam/doc/man/pam_conv.3 > > 1.1.1.18.10.1 +2 -1 src/contrib/openpam/doc/man/pam_end.3 > > 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_error.3 > > 1.1.1.19.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_get_authtok.3 > > 1.1.1.18.10.1 +3 -2 > src/contrib/openpam/doc/man/pam_get_data.3 > > 1.1.1.18.10.1 +3 -2 > src/contrib/openpam/doc/man/pam_get_item.3 > > 1.1.1.18.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_get_user.3 > > 1.1.1.18.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_getenv.3 > > 1.1.1.19.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_getenvlist.3 > > 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_info.3 > > 1.1.1.18.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_open_session.3 > > 1.1.1.18.10.1 +3 -2 > src/contrib/openpam/doc/man/pam_prompt.3 > > 1.1.1.18.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_putenv.3 > > 1.1.1.18.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_set_data.3 > > 1.1.1.18.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_set_item.3 > > 1.1.1.19.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_setcred.3 > > 1.1.1.18.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_setenv.3 > > 1.1.1.17.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_sm_acct_mgmt.3 > > 1.1.1.17.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_sm_authenticate.3 > > 1.1.1.17.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_sm_chauthtok.3 > > 1.1.1.17.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_sm_close_session.3 > > 1.1.1.17.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_sm_open_session.3 > > 1.1.1.17.10.1 +2 -1 > src/contrib/openpam/doc/man/pam_sm_setcred.3 > > 1.1.1.19.10.1 +2 -1 src/contrib/openpam/doc/man/pam_start.3 > > 1.1.1.18.10.1 +3 -2 > src/contrib/openpam/doc/man/pam_strerror.3 > > 1.1.1.18.10.1 +3 -2 > src/contrib/openpam/doc/man/pam_verror.3 > > 1.1.1.18.10.1 +3 -2 src/contrib/openpam/doc/man/pam_vinfo.3 > > 1.1.1.18.10.1 +3 -2 > src/contrib/openpam/doc/man/pam_vprompt.3 > > 1.1.1.2.10.1 +1 -1 src/contrib/openpam/include/Makefile.am > > 1.1.1.3.10.1 +42 -18 src/contrib/openpam/include/Makefile.in > > 1.1.1.2.10.1 +2 -1 > src/contrib/openpam/include/security/Makefile.am > > 1.1.1.3.10.1 +29 -12 > src/contrib/openpam/include/security/Makefile.in > > 1.1.1.16.10.1 +100 -67 > src/contrib/openpam/include/security/openpam.h > > 1.1.1.9.10.1 +8 -7 > src/contrib/openpam/include/security/openpam_version.h > > 1.1.1.8.18.1 +41 -23 > src/contrib/openpam/include/security/pam_appl.h > > 1.1.1.12.20.1 +5 -4 > src/contrib/openpam/include/security/pam_constants.h > > 1.1.1.6.20.1 +5 -4 > src/contrib/openpam/include/security/pam_modules.h > > 1.1.1.9.20.1 +6 -5 > src/contrib/openpam/include/security/pam_types.h > > 1.1.1.2.10.1 +50 -52 src/contrib/openpam/install-sh > > 1.1.1.3.10.1 +21 -7 src/contrib/openpam/lib/Makefile.am > > 1.1.1.3.10.1 +181 -892 src/contrib/openpam/lib/Makefile.in > > 1.1.1.8.10.1 +3 -2 > src/contrib/openpam/lib/openpam_borrow_cred.c > > 1.1.1.7.20.1 +2 -1 > src/contrib/openpam/lib/openpam_configure.c > > 1.1.1.9.20.1 +2 -1 > src/contrib/openpam/lib/openpam_dispatch.c > > 1.1.1.8.10.1 +3 -1 > src/contrib/openpam/lib/openpam_dynamic.c > > 1.1.1.8.20.1 +2 -1 > src/contrib/openpam/lib/openpam_findenv.c > > 1.1.1.5.10.1 +2 -1 > src/contrib/openpam/lib/openpam_free_data.c > > 1.1.1.1.10.1 +1 -1 > src/contrib/openpam/lib/openpam_free_envlist.c > > 1.1.1.7.20.1 +2 -1 > src/contrib/openpam/lib/openpam_get_option.c > > 1.1.1.16.18.1 +2 -1 src/contrib/openpam/lib/openpam_impl.h > > 1.1.1.11.10.1 +3 -34 src/contrib/openpam/lib/openpam_load.c > > 1.1.1.14.10.1 +6 -1 src/contrib/openpam/lib/openpam_log.c > > 1.1.1.6.10.1 +2 -1 > src/contrib/openpam/lib/openpam_nullconv.c > > 1.1.1.3.2.1 +2 -1 > src/contrib/openpam/lib/openpam_readline.c > > 1.1.1.8.10.1 +4 -3 > src/contrib/openpam/lib/openpam_restore_cred.c > > 1.1.1.7.20.1 +2 -1 > src/contrib/openpam/lib/openpam_set_option.c > > 1.1.1.5.20.1 +2 -1 > src/contrib/openpam/lib/openpam_static.c > > 1.1.1.16.10.1 +4 -2 > src/contrib/openpam/lib/openpam_ttyconv.c > > 1.1.1.9.20.1 +2 -1 src/contrib/openpam/lib/pam_acct_mgmt.c > > 1.1.1.10.20.1 +2 -1 > src/contrib/openpam/lib/pam_authenticate.c > > 1.1.1.7.20.1 +2 -1 > src/contrib/openpam/lib/pam_authenticate_secondary.c > > 1.1.1.10.20.1 +2 -1 src/contrib/openpam/lib/pam_chauthtok.c > > 1.1.1.9.20.1 +2 -1 > src/contrib/openpam/lib/pam_close_session.c > > 1.1.1.9.20.1 +2 -1 src/contrib/openpam/lib/pam_end.c > > 1.1.1.6.20.1 +3 -2 src/contrib/openpam/lib/pam_error.c > > 1.1.1.17.10.1 +2 -1 > src/contrib/openpam/lib/pam_get_authtok.c > > 1.1.1.11.10.1 +4 -3 src/contrib/openpam/lib/pam_get_data.c > > 1.1.1.9.20.1 +3 -2 src/contrib/openpam/lib/pam_get_item.c > > 1.1.1.7.20.1 +2 -1 > src/contrib/openpam/lib/pam_get_mapped_authtok.c > > 1.1.1.7.20.1 +2 -1 > src/contrib/openpam/lib/pam_get_mapped_username.c > > 1.1.1.12.10.1 +2 -1 src/contrib/openpam/lib/pam_get_user.c > > 1.1.1.10.20.1 +2 -1 src/contrib/openpam/lib/pam_getenv.c > > 1.1.1.8.20.1 +2 -1 > src/contrib/openpam/lib/pam_getenvlist.c > > 1.1.1.6.20.1 +3 -2 src/contrib/openpam/lib/pam_info.c > > 1.1.1.10.10.1 +2 -1 > src/contrib/openpam/lib/pam_open_session.c > > 1.1.1.6.20.1 +3 -2 src/contrib/openpam/lib/pam_prompt.c > > 1.1.1.8.20.1 +2 -1 src/contrib/openpam/lib/pam_putenv.c > > 1.1.1.9.20.1 +2 -1 src/contrib/openpam/lib/pam_set_data.c > > 1.1.1.11.20.1 +2 -1 src/contrib/openpam/lib/pam_set_item.c > > 1.1.1.7.20.1 +2 -1 > src/contrib/openpam/lib/pam_set_mapped_authtok.c > > 1.1.1.7.20.1 +2 -1 > src/contrib/openpam/lib/pam_set_mapped_username.c > > 1.1.1.10.20.1 +2 -1 src/contrib/openpam/lib/pam_setcred.c > > 1.1.1.7.20.1 +2 -1 src/contrib/openpam/lib/pam_setenv.c > > 1.1.1.6.20.1 +2 -1 > src/contrib/openpam/lib/pam_sm_acct_mgmt.c > > 1.1.1.6.20.1 +2 -1 > src/contrib/openpam/lib/pam_sm_authenticate.c > > 1.1.1.6.20.1 +2 -1 > src/contrib/openpam/lib/pam_sm_authenticate_secondary.c > > 1.1.1.6.20.1 +2 -1 > src/contrib/openpam/lib/pam_sm_chauthtok.c > > 1.1.1.6.20.1 +2 -1 > src/contrib/openpam/lib/pam_sm_close_session.c > > 1.1.1.6.20.1 +2 -1 > src/contrib/openpam/lib/pam_sm_get_mapped_authtok.c > > 1.1.1.6.20.1 +2 -1 > src/contrib/openpam/lib/pam_sm_get_mapped_username.c > > 1.1.1.6.20.1 +2 -1 > src/contrib/openpam/lib/pam_sm_open_session.c > > 1.1.1.6.20.1 +2 -1 > src/contrib/openpam/lib/pam_sm_set_mapped_authtok.c > > 1.1.1.6.20.1 +2 -1 > src/contrib/openpam/lib/pam_sm_set_mapped_username.c > > 1.1.1.6.20.1 +2 -1 > src/contrib/openpam/lib/pam_sm_setcred.c > > 1.1.1.10.20.1 +2 -1 src/contrib/openpam/lib/pam_start.c > > 1.1.1.8.10.1 +3 -2 src/contrib/openpam/lib/pam_strerror.c > > 1.1.1.6.20.1 +3 -2 src/contrib/openpam/lib/pam_verror.c > > 1.1.1.6.20.1 +3 -2 src/contrib/openpam/lib/pam_vinfo.c > > 1.1.1.11.18.1 +3 -2 src/contrib/openpam/lib/pam_vprompt.c > > 1.1.1.4.10.1 +838 -312 src/contrib/openpam/ltmain.sh > > 1.1.1.12.10.1 +3 -1 src/contrib/openpam/misc/gendoc.pl > > 1.1.1.2.10.1 +47 -47 src/contrib/openpam/missing > > 1.1.1.2.10.1 +1 -1 src/contrib/openpam/modules/Makefile.am > > 1.1.1.3.10.1 +42 -18 src/contrib/openpam/modules/Makefile.in > > 1.1.1.2.10.1 +1 -1 > src/contrib/openpam/modules/pam_deny/Makefile.am > > 1.1.1.3.10.1 +34 -24 > src/contrib/openpam/modules/pam_deny/Makefile.in > > 1.1.1.7.10.1 +26 -1 > src/contrib/openpam/modules/pam_deny/pam_deny.c > > 1.1.1.2.10.1 +1 -1 > src/contrib/openpam/modules/pam_permit/Makefile.am > > 1.1.1.3.10.1 +34 -24 > src/contrib/openpam/modules/pam_permit/Makefile.in > > 1.1.1.6.20.1 +26 -1 > src/contrib/openpam/modules/pam_permit/pam_permit.c > > 1.1.1.2.10.1 +1 -1 > src/contrib/openpam/modules/pam_unix/Makefile.am > > 1.1.1.3.10.1 +36 -25 > src/contrib/openpam/modules/pam_unix/Makefile.in > > 1.1.1.4.20.1 +30 -6 > src/contrib/openpam/modules/pam_unix/pam_unix.c > > 1.54.10.1 +1 -0 src/lib/libpam/libpam/Makefile > > 1.23.10.1 +3 -3 > src/lib/libpam/modules/pam_krb5/pam_krb5.c > > 1.44.2.1 +3 -3 > src/lib/libpam/modules/pam_ssh/pam_ssh.c > > 1.52.2.1 +1 -1 > src/lib/libpam/modules/pam_unix/pam_unix.c > > 1.58.10.1 +5 -5 src/usr.sbin/ppp/auth.c > > Was security/openpam_attr.h forgotten from being added to the MFC ? > > Trying to rebuild world, I get > ===> lib/libpam/modules/pam_ssh (buildincludes) > ===> lib/libpam/modules/pam_tacplus (buildincludes) > ===> lib/libpam/modules/pam_unix (buildincludes) > ===> lib/libpam/libpam (buildincludes) > make: don't know how to make security/openpam_attr.h. Stop > *** Error code 2 > > Stop in /usr/bsd/src/lib/libpam. > *** Error code 1 > > Same here. i386 ===> lib/libpam/modules/pam_opieaccess (buildincludes) ===> lib/libpam/modules/pam_passwdqc (buildincludes) ===> lib/libpam/modules/pam_permit (buildincludes) ===> lib/libpam/modules/pam_radius (buildincludes) ===> lib/libpam/modules/pam_rhosts (buildincludes) ===> lib/libpam/modules/pam_rootok (buildincludes) ===> lib/libpam/modules/pam_securetty (buildincludes) ===> lib/libpam/modules/pam_self (buildincludes) ===> lib/libpam/modules/pam_ssh (buildincludes) ===> lib/libpam/modules/pam_tacplus (buildincludes) ===> lib/libpam/modules/pam_unix (buildincludes) ===> lib/libpam/libpam (buildincludes) make: don't know how to make security/openpam_attr.h. Stop *** Error code 2 Stop in /usr/src/lib/libpam. *** Error code 1 Stop in /usr/src/lib. *** Error code 1 Stop in /usr/src/lib. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. Regards, -Abdullah Ibn Hamad Al-Marri Arab Portal http://www.WeArab.Net/ ____________________________________________________________________________________ Be a better friend, newshound, and know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ From emaste at FreeBSD.org Fri Jan 18 10:57:27 2008 From: emaste at FreeBSD.org (Ed Maste) Date: Fri Jan 18 10:57:29 2008 Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb kthr.c Message-ID: <200801181857.m0IIvRdp043885@repoman.freebsd.org> emaste 2008-01-18 18:57:27 UTC FreeBSD src repository Modified files: gnu/usr.bin/gdb/kgdb kthr.c Log: Include the thread name (in addition to the proc name) in "info threads." Revision Changes Path 1.9 +13 -3 src/gnu/usr.bin/gdb/kgdb/kthr.c From rwatson at FreeBSD.org Fri Jan 18 11:16:04 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Fri Jan 18 11:16:07 2008 Subject: cvs commit: src/sys/kern uipc_usrreq.c Message-ID: <200801181916.m0IJG34T048171@repoman.freebsd.org> rwatson 2008-01-18 19:16:03 UTC FreeBSD src repository Modified files: sys/kern uipc_usrreq.c Log: Move unlock of global UNIX domain socket lock slightly lower in unp_connect(): it is expected to return with the lock held, and two possible error paths otherwise returned with it unlocked. The fix committed here is slightly different from the patch in the PR, but along an alternative line suggested in the PR. PR: 119778 MFC after: 3 days Submitted by: James Juran Revision Changes Path 1.214 +1 -1 src/sys/kern/uipc_usrreq.c From maxim at FreeBSD.org Fri Jan 18 11:25:16 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Fri Jan 18 11:25:22 2008 Subject: cvs commit: src/share/misc bsd-family-tree Message-ID: <200801181925.m0IJPF3C049786@repoman.freebsd.org> maxim 2008-01-18 19:25:15 UTC FreeBSD src repository Modified files: share/misc bsd-family-tree Log: o FreeBSD 6.3-RELEASE added. Revision Changes Path 1.118 +4 -1 src/share/misc/bsd-family-tree From csjp at FreeBSD.org Fri Jan 18 11:50:35 2008 From: csjp at FreeBSD.org (Christian S.J. Peron) Date: Fri Jan 18 11:50:37 2008 Subject: cvs commit: src/sys/security/audit audit_bsm.c Message-ID: <200801181950.m0IJoZGE053956@repoman.freebsd.org> csjp 2008-01-18 19:50:34 UTC FreeBSD src repository Modified files: sys/security/audit audit_bsm.c Log: Add a case for AUE_LISTEN. This removes the following console error message: "BSM conversion requested for unknown event 43140" It should be noted that we need to audit the fd argument for this system call. Obtained from: TrustedBSD Project MFC after: 1 week Revision Changes Path 1.23 +1 -0 src/sys/security/audit/audit_bsm.c From csjp at FreeBSD.org Fri Jan 18 11:57:22 2008 From: csjp at FreeBSD.org (Christian S.J. Peron) Date: Fri Jan 18 11:57:26 2008 Subject: cvs commit: src/sys/security/audit audit_bsm.c Message-ID: <200801181957.m0IJvLNH055200@repoman.freebsd.org> csjp 2008-01-18 19:57:21 UTC FreeBSD src repository Modified files: sys/security/audit audit_bsm.c Log: Fix gratuitous whitespace bug MFC after: 1 week Obtained from: TrustedBSD Project Revision Changes Path 1.24 +2 -1 src/sys/security/audit/audit_bsm.c From kensmith at FreeBSD.org Fri Jan 18 12:27:24 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Fri Jan 18 12:27:29 2008 Subject: cvs commit: src/sys/conf newvers.sh Message-ID: <200801182027.m0IKROvu062048@repoman.freebsd.org> kensmith 2008-01-18 20:27:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/conf newvers.sh Log: 6.3-RELEASE is announced to time to have RELENG_6 say it's 6.3-STABLE. Revision Changes Path 1.69.2.16 +1 -1 src/sys/conf/newvers.sh From jkim at FreeBSD.org Fri Jan 18 12:33:22 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Fri Jan 18 12:33:27 2008 Subject: cvs commit: src/sys/dev/bge if_bge.c Message-ID: <200801182033.m0IKXMkZ063356@repoman.freebsd.org> jkim 2008-01-18 20:33:21 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c Log: Fix mbuf pool watermark configuration (mismerged from OpenBSD in 1.132). Submitted by: sephe MFC after: 3 days Revision Changes Path 1.201 +1 -1 src/sys/dev/bge/if_bge.c From pieter at degoeje.nl Fri Jan 18 12:42:43 2008 From: pieter at degoeje.nl (Pieter de Goeje) Date: Fri Jan 18 12:42:46 2008 Subject: cvs commit: src/usr.bin/vmstat Makefile vmstat.8 vmstat.c In-Reply-To: <200712130236.lBD2aCWP029948@repoman.freebsd.org> References: <200712130236.lBD2aCWP029948@repoman.freebsd.org> Message-ID: <200801182142.35019.pieter@degoeje.nl> On Thursday 13 December 2007, Peter Wemm wrote: > peter 2007-12-13 02:36:11 UTC > > FreeBSD src repository > > Modified files: > usr.bin/vmstat Makefile vmstat.8 vmstat.c > Log: > Add the -H, -h and -P flags to vmstat. -P causes per-cpu output of > user/system/idle stats. -h feeds the memory column through > humanize_number() to reduce the amount of column overflowing. -H turns > this off. -h is turned on by default if stdout is a tty. > > Revision Changes Path > 1.13 +2 -2 src/usr.bin/vmstat/Makefile > 1.37 +9 -1 src/usr.bin/vmstat/vmstat.8 > 1.99 +196 -17 src/usr.bin/vmstat/vmstat.c I noticed vmstat dumps stats from all kern.smp.maxcpus CPUs on screen when using -P. Attached patch fixes the problem. Cheers, Pieter de Goeje -------------- next part -------------- A non-text attachment was scrubbed... Name: vmstat.patch Type: text/x-diff Size: 830 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080118/6109e4ef/vmstat.bin From das at FreeBSD.org Fri Jan 18 13:25:52 2008 From: das at FreeBSD.org (David Schultz) Date: Fri Jan 18 13:25:57 2008 Subject: cvs commit: src/lib/libc/sparc64 _fpmath.h Message-ID: <200801182125.m0ILPqWI081616@repoman.freebsd.org> das 2008-01-18 21:25:52 UTC FreeBSD src repository Modified files: lib/libc/sparc64 _fpmath.h Log: Add a new union member to access the exponent and sign of a long double in a single op. Idea from bde. Revision Changes Path 1.6 +5 -0 src/lib/libc/sparc64/_fpmath.h From das at FreeBSD.org Fri Jan 18 13:42:46 2008 From: das at FreeBSD.org (David Schultz) Date: Fri Jan 18 13:42:51 2008 Subject: cvs commit: src/lib/msun/ld80 s_exp2l.c src/lib/msun/ld128 s_exp2l.c src/lib/msun/src math.h s_exp2.c Message-ID: <200801182142.m0ILgkH1087331@repoman.freebsd.org> das 2008-01-18 21:42:46 UTC FreeBSD src repository Modified files: lib/msun/src math.h s_exp2.c Added files: lib/msun/ld80 s_exp2l.c lib/msun/ld128 s_exp2l.c Log: Implement exp2l(). There is one version for machines with 80-bit long doubles (i386, amd64, ia64) and one for machines with 128-bit long doubles (sparc64). Other platforms use the double version. I've only done runtime testing on i386. Thanks to bde@ for helpful discussions and bugfixes. Revision Changes Path 1.1 +426 -0 src/lib/msun/ld128/s_exp2l.c (new) 1.1 +291 -0 src/lib/msun/ld80/s_exp2l.c (new) 1.67 +2 -0 src/lib/msun/src/math.h 1.2 +6 -0 src/lib/msun/src/s_exp2.c From das at FreeBSD.org Fri Jan 18 13:43:00 2008 From: das at FreeBSD.org (David Schultz) Date: Fri Jan 18 13:43:02 2008 Subject: cvs commit: src/lib/msun/man exp.3 log.3 Message-ID: <200801182143.m0ILh09p087413@repoman.freebsd.org> das 2008-01-18 21:43:00 UTC FreeBSD src repository Modified files: lib/msun/man exp.3 Added files: lib/msun/man log.3 Log: Introduce a new log(3) manpage and move the relevant functions there. Document exp2l() in exp(3), and remove the quaint discussion of topics such as what these functions were called on the HP-71B's variant of BASIC. Revision Changes Path 1.24 +14 -69 src/lib/msun/man/exp.3 1.1 +104 -0 src/lib/msun/man/log.3 (new) From das at FreeBSD.org Fri Jan 18 13:43:10 2008 From: das at FreeBSD.org (David Schultz) Date: Fri Jan 18 13:43:22 2008 Subject: cvs commit: src/lib/msun Makefile Symbol.map Message-ID: <200801182143.m0ILhAUn087457@repoman.freebsd.org> das 2008-01-18 21:43:10 UTC FreeBSD src repository Modified files: lib/msun Makefile Symbol.map Log: Hook up exp2l() and related docs to the build. Revision Changes Path 1.86 +6 -6 src/lib/msun/Makefile 1.12 +1 -0 src/lib/msun/Symbol.map From das at FreeBSD.org Fri Jan 18 13:46:55 2008 From: das at FreeBSD.org (David Schultz) Date: Fri Jan 18 13:47:03 2008 Subject: cvs commit: src/tools/regression/lib/msun Makefile test-exponential.c test-exponential.t Message-ID: <200801182146.m0ILksW2089628@repoman.freebsd.org> das 2008-01-18 21:46:54 UTC FreeBSD src repository Modified files: tools/regression/lib/msun Makefile Added files: tools/regression/lib/msun test-exponential.c test-exponential.t Log: Add some regression tests for libm's exponential functions. These mostly just test corner cases rather than accuracy. Some of the tests don't pass right now if you compile libm at -O2 due to gcc constant-folding some things that it shouldn't. I'll fix that shortly. Revision Changes Path 1.10 +1 -1 src/tools/regression/lib/msun/Makefile 1.1 +170 -0 src/tools/regression/lib/msun/test-exponential.c (new) 1.1 +10 -0 src/tools/regression/lib/msun/test-exponential.t (new) From attilio at FreeBSD.org Fri Jan 18 14:09:30 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Fri Jan 18 14:09:32 2008 Subject: cvs commit: src/share/man/man9 VOP_LOCK.9 Message-ID: <200801182209.m0IM9ToB093883@repoman.freebsd.org> attilio 2008-01-18 22:09:29 UTC FreeBSD src repository Modified files: share/man/man9 VOP_LOCK.9 Log: Update VOP_LOCK() and VOP_UNLOCK() prototypes. Leave 'td' argument description as it is used by VOP_ISLOCKED(). It will be axed in further commit. Revision Changes Path 1.22 +3 -3 src/share/man/man9/VOP_LOCK.9 From peter at FreeBSD.org Fri Jan 18 14:09:45 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Fri Jan 18 14:09:47 2008 Subject: cvs commit: src/usr.bin/vmstat vmstat.c Message-ID: <200801182209.m0IM9iv3093911@repoman.freebsd.org> peter 2008-01-18 22:09:44 UTC FreeBSD src repository Modified files: usr.bin/vmstat vmstat.c Log: Fix some boolean logic errors. && vs & and other sillyness. *blush* This would prevent it from skipping non-present cpus in -P output. Submitted by: Pieter de Goeje Revision Changes Path 1.100 +3 -3 src/usr.bin/vmstat/vmstat.c From jkim at FreeBSD.org Fri Jan 18 14:09:50 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Fri Jan 18 14:09:54 2008 Subject: cvs commit: src/sys/dev/bge if_bge.c if_bgereg.h src/sys/dev/mii brgphy.c Message-ID: <200801182209.m0IM9oxk093969@repoman.freebsd.org> jkim 2008-01-18 22:09:50 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c if_bgereg.h sys/dev/mii brgphy.c Log: Add a flag for Ethernet@WireSpeed capability and correct chip revisions. The idea was taken from OpenBSD and cross-referenced with Linux driver. Revision Changes Path 1.202 +9 -0 src/sys/dev/bge/if_bge.c 1.75 +2 -1 src/sys/dev/bge/if_bgereg.h 1.71 +1 -7 src/sys/dev/mii/brgphy.c From peter at wemm.org Fri Jan 18 14:10:35 2008 From: peter at wemm.org (Peter Wemm) Date: Fri Jan 18 14:10:42 2008 Subject: cvs commit: src/usr.bin/vmstat Makefile vmstat.8 vmstat.c In-Reply-To: <200801182142.35019.pieter@degoeje.nl> References: <200712130236.lBD2aCWP029948@repoman.freebsd.org> <200801182142.35019.pieter@degoeje.nl> Message-ID: On Jan 18, 2008 12:42 PM, Pieter de Goeje wrote: > > On Thursday 13 December 2007, Peter Wemm wrote: > > peter 2007-12-13 02:36:11 UTC > > > > FreeBSD src repository > > > > Modified files: > > usr.bin/vmstat Makefile vmstat.8 vmstat.c > > Log: > > Add the -H, -h and -P flags to vmstat. -P causes per-cpu output of > > user/system/idle stats. -h feeds the memory column through > > humanize_number() to reduce the amount of column overflowing. -H turns > > this off. -h is turned on by default if stdout is a tty. > > > > Revision Changes Path > > 1.13 +2 -2 src/usr.bin/vmstat/Makefile > > 1.37 +9 -1 src/usr.bin/vmstat/vmstat.8 > > 1.99 +196 -17 src/usr.bin/vmstat/vmstat.c > > I noticed vmstat dumps stats from all kern.smp.maxcpus CPUs on screen when > using -P. Attached patch fixes the problem. > > Cheers, > Pieter de Goeje > Committed as rev 1.100 of vmstat.c.. Thanks! -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 From das at FreeBSD.org Fri Jan 18 14:10:57 2008 From: das at FreeBSD.org (David Schultz) Date: Fri Jan 18 14:10:59 2008 Subject: cvs commit: src/tools/regression/lib/msun test-exponential.c Message-ID: <200801182210.m0IMAvrS094330@repoman.freebsd.org> das 2008-01-18 22:10:57 UTC FreeBSD src repository Modified files: tools/regression/lib/msun test-exponential.c Log: expm1(-big) generates an inexact exception but not underflow. Revision Changes Path 1.2 +1 -1 src/tools/regression/lib/msun/test-exponential.c From das at FreeBSD.org Fri Jan 18 14:19:04 2008 From: das at FreeBSD.org (David Schultz) Date: Fri Jan 18 14:20:03 2008 Subject: cvs commit: src/lib/msun/src e_expf.c s_exp2.c s_exp2f.c Message-ID: <200801182219.m0IMJ4r0095779@repoman.freebsd.org> das 2008-01-18 22:19:04 UTC FreeBSD src repository Modified files: lib/msun/src e_expf.c s_exp2.c s_exp2f.c Log: Use volatile hacks to make sure these functions generate an underflow exception when they're supposed to. Previously, gcc -O2 was optimizing away the statement that generated it. Revision Changes Path 1.11 +2 -1 src/lib/msun/src/e_expf.c 1.3 +2 -1 src/lib/msun/src/s_exp2.c 1.2 +2 -1 src/lib/msun/src/s_exp2f.c From brueffer at FreeBSD.org Fri Jan 18 15:24:11 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Fri Jan 18 15:24:16 2008 Subject: cvs commit: src/tools/build/mk OptionalObsoleteFiles.inc Message-ID: <200801182324.m0INOA7L007715@repoman.freebsd.org> brueffer 2008-01-18 23:24:10 UTC FreeBSD src repository Modified files: tools/build/mk OptionalObsoleteFiles.inc Log: Remove files conditional on the obsolete MK_FORTRAN knob. They are already listed in ObsoleteFiles.inc anyway. Reported by: David Wolfskill Approved by: rwatson (mentor) MFC after: 3 days Revision Changes Path 1.12 +0 -12 src/tools/build/mk/OptionalObsoleteFiles.inc From mike at sentex.net Fri Jan 18 17:57:01 2008 From: mike at sentex.net (Mike Tancsa) Date: Fri Jan 18 17:57:05 2008 Subject: cvs commit: src/contrib/openpam CREDITS HISTORY INSTALL LICENSE Makefile.am Makefile.in README RELNOTES aclocal.m4 autogen.sh config.h.in configure configure.ac depcomp install-sh ltmain.sh missing src/contrib/openpam/bin Makefile.am Makefile.in ... In-Reply-To: <20080118153156.GJ57756@deviant.kiev.zoral.com.ua> References: <200801181329.m0IDT5Kh048537@repoman.freebsd.org> <20080118153156.GJ57756@deviant.kiev.zoral.com.ua> Message-ID: <200801190156.m0J1uvU1009719@lava.sentex.ca> At 10:31 AM 1/18/2008, Kostik Belousov wrote: >On Fri, Jan 18, 2008 at 01:29:05PM +0000, Dag-Erling Smorgrav wrote: > > des 2008-01-18 13:29:05 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_7) > > contrib/openpam CREDITS HISTORY INSTALL LICENSE > > Makefile.am Makefile.in README RELNOTES > >Was security/openpam_attr.h forgotten from being added to the MFC ? I had the same error and adding that file fixed it for me as well. ---Mike >Trying to rebuild world, I get >===> lib/libpam/modules/pam_ssh (buildincludes) >===> lib/libpam/modules/pam_tacplus (buildincludes) >===> lib/libpam/modules/pam_unix (buildincludes) >===> lib/libpam/libpam (buildincludes) >make: don't know how to make security/openpam_attr.h. Stop >*** Error code 2 > >Stop in /usr/bsd/src/lib/libpam. >*** Error code 1 > > From csjp at FreeBSD.org Fri Jan 18 21:47:32 2008 From: csjp at FreeBSD.org (Christian S.J. Peron) Date: Fri Jan 18 21:47:39 2008 Subject: cvs commit: src/contrib/openpam CREDITS HISTORY INSTALL LICENSE Makefile.am Makefile.in README RELNOTES aclocal.m4 autogen.sh config.h.in configure configure.ac depcomp install-sh ltmain.sh missing src/contrib/openpam/bin Makefile.am Makefile.in ... In-Reply-To: <20080118153156.GJ57756@deviant.kiev.zoral.com.ua> References: <200801181329.m0IDT5Kh048537@repoman.freebsd.org> <20080118153156.GJ57756@deviant.kiev.zoral.com.ua> Message-ID: <20080119052918.GA2336@sub.vaned.net> On Fri, Jan 18, 2008 at 05:31:56PM +0200, Kostik Belousov wrote: [..] > > Was security/openpam_attr.h forgotten from being added to the MFC ? > > Trying to rebuild world, I get > ===> lib/libpam/modules/pam_ssh (buildincludes) > ===> lib/libpam/modules/pam_tacplus (buildincludes) > ===> lib/libpam/modules/pam_unix (buildincludes) > ===> lib/libpam/libpam (buildincludes) > make: don't know how to make security/openpam_attr.h. Stop > *** Error code 2 I am experiencing the same problem. Is there an ETA on when this might be fixed? From kib at FreeBSD.org Fri Jan 18 21:48:30 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Fri Jan 18 21:48:33 2008 Subject: cvs commit: src/sys/ufs/ffs ffs_balloc.c Message-ID: <200801190548.m0J5mU7q082793@repoman.freebsd.org> kib 2008-01-19 05:48:30 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/ufs/ffs ffs_balloc.c Log: MFC rev. 1.52: The ffs_balloc() routines, whan allocating the indirect blocks for the inode, do the rollback in case the allocation failed (due to insufficient free space or quota limits). But, the code does leaves the buffers corresponding to the inoirect blocks on the vnode bufobj list. This causes several assertion failures (for instance, "ffs_truncate3" in ffs_truncate()) to fail, and could result in the indirect block aliasing problem, like writing the context of such blocks to random disk location. Remove the buffers from the bufobj properly. Revision Changes Path 1.50.10.1 +42 -2 src/sys/ufs/ffs/ffs_balloc.c From kib at FreeBSD.org Fri Jan 18 21:57:48 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Fri Jan 18 21:57:50 2008 Subject: cvs commit: src/sys/ufs/ffs ffs_balloc.c Message-ID: <200801190557.m0J5vm9a083142@repoman.freebsd.org> kib 2008-01-19 05:57:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/ufs/ffs ffs_balloc.c Log: MFC rev. 1.53: ffs_balloc_ufsX() routines, in the case of recovering from the failed allocation, free the indirect blocks before clearing the disk pointers, that could lead to the softupdate inconsistencies in the case of the machine or disk crash at the wrong time. Rearrange the recover code to do the ffs_blkfree() after the second ffs_syncvnode(), that clears the pointers chain. Revision Changes Path 1.50.10.2 +16 -12 src/sys/ufs/ffs/ffs_balloc.c From rafan at FreeBSD.org Sat Jan 19 03:47:38 2008 From: rafan at FreeBSD.org (Rong-En Fan) Date: Sat Jan 19 03:47:43 2008 Subject: cvs commit: src/contrib/openpam/include/security openpam_attr.h Message-ID: <200801191147.m0JBlbeI019947@repoman.freebsd.org> rafan 2008-01-19 11:47:37 UTC FreeBSD src repository Added files: (Branch: RELENG_7) contrib/openpam/include/security openpam_attr.h Log: - Add missing file for OpenPAM Hydrangea MFC Revision Changes Path 1.1.1.1.2.1 +28 -0 src/contrib/openpam/include/security/openpam_attr.h (new) From rwatson at FreeBSD.org Sat Jan 19 04:34:41 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Jan 19 04:34:55 2008 Subject: cvs commit: src/lib/libc/gen Makefile.inc posixshm.c shm_open.3 src/lib/libc/sys Makefile.inc shm_open.2 src/sys/compat/freebsd32 syscalls.master src/sys/conf files src/sys/kern kern_descrip.c syscalls.master uipc_shm.c src/sys/security/mac mac_framework.h ... In-Reply-To: <200801082158.m08LwGXh035451@repoman.freebsd.org> References: <200801082158.m08LwGXh035451@repoman.freebsd.org> Message-ID: <20080119123352.O91115@fledge.watson.org> On Tue, 8 Jan 2008, John Baldwin wrote: > jhb 2008-01-08 21:58:16 UTC > > FreeBSD src repository > > Modified files: > lib/libc/gen Makefile.inc > lib/libc/sys Makefile.inc shm_open.2 Do you also need to add the new system calls to src/lib/libc/sys/Symbol.map? Robert N M Watson Computer Laboratory University of Cambridge From rwatson at FreeBSD.org Sat Jan 19 05:27:18 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Jan 19 05:27:20 2008 Subject: cvs commit: src/sys/fs/coda coda_vnops.c Message-ID: <200801191327.m0JDRFhU037252@repoman.freebsd.org> rwatson 2008-01-19 13:27:14 UTC FreeBSD src repository Modified files: sys/fs/coda coda_vnops.c Log: Borrow the VM object associated with an underlying cache vnode with the Coda vnode derived from it, in the style of nullfs. This allows files in the Coda file system to be memory-mapped, such as with execve(2) or mmap(2). MFC after: 3 days Reported by: Rune Revision Changes Path 1.79 +5 -1 src/sys/fs/coda/coda_vnops.c From rwatson at FreeBSD.org Sat Jan 19 05:29:14 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Jan 19 05:29:20 2008 Subject: cvs commit: src/sys/fs/coda coda_vnops.c Message-ID: <200801191329.m0JDTEEH037325@repoman.freebsd.org> rwatson 2008-01-19 13:29:14 UTC FreeBSD src repository Modified files: sys/fs/coda coda_vnops.c Log: Lock the new directory vnode returned by coda_mkdir(), as this is required by FreeBSD's vnode locking protocol. MFC after: 3 days Revision Changes Path 1.80 +5 -1 src/sys/fs/coda/coda_vnops.c From rwatson at FreeBSD.org Sat Jan 19 05:41:57 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Jan 19 05:42:03 2008 Subject: cvs commit: src/sys/fs/coda coda_vnops.c Message-ID: <200801191341.m0JDfvT2037876@repoman.freebsd.org> rwatson 2008-01-19 13:41:56 UTC FreeBSD src repository Modified files: sys/fs/coda coda_vnops.c Log: Use VOP_NULL rather than VOP_PANIC for Coda's vop_print routine, so as to avoid panicking in DDB show lockedvnods. MFC after: 3 days Revision Changes Path 1.81 +1 -1 src/sys/fs/coda/coda_vnops.c From rwatson at FreeBSD.org Sat Jan 19 06:32:45 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Jan 19 06:32:49 2008 Subject: cvs commit: src/sys/fs/coda cnode.h coda_namecache.h coda_psdev.c coda_vfsops.c Message-ID: <200801191432.m0JEWit6043425@repoman.freebsd.org> rwatson 2008-01-19 14:32:44 UTC FreeBSD src repository Modified files: sys/fs/coda cnode.h coda_namecache.h coda_psdev.c coda_vfsops.c Log: Don't declare functions as extern. Move all extern variable definitions to associated .h files, move some extern variable definitions between include files to place them more appropriately. MFC after: 3 days Revision Changes Path 1.22 +0 -6 src/sys/fs/coda/cnode.h 1.12 +22 -15 src/sys/fs/coda/coda_namecache.h 1.40 +0 -3 src/sys/fs/coda/coda_psdev.c 1.70 +0 -3 src/sys/fs/coda/coda_vfsops.c From jhb at FreeBSD.org Sat Jan 19 07:38:14 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Sat Jan 19 07:38:19 2008 Subject: cvs commit: src/sys/amd64/amd64 intr_machdep.c src/sys/i386/i386 intr_machdep.c Message-ID: <200801191538.m0JFcDOA048401@repoman.freebsd.org> jhb 2008-01-19 15:38:13 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/amd64/amd64 intr_machdep.c sys/i386/i386 intr_machdep.c Log: MFC: Split the intr_table_lock into an sx lock used for most things, and a spin lock to protect intrcnt_index. Originally I had this as a spin lock so interrupt code could use it to lookup sources. However, we don't actually do that because it would add a lot of overhead to interrupts, and if we ever do support removing interrupt sources, we can use other means to safely do so w/o locking in the interrupt handling code. This fixes a LOR in the most recent MSI MFC and was a part of the original commit to HEAD that included the changes in the most recent MSI MFC. Revision Changes Path 1.15.2.6 +24 -21 src/sys/amd64/amd64/intr_machdep.c 1.14.2.6 +24 -21 src/sys/i386/i386/intr_machdep.c From rwatson at FreeBSD.org Sat Jan 19 07:39:11 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Jan 19 07:39:16 2008 Subject: cvs commit: src/sys/fs/coda coda_vnops.c Message-ID: <200801191539.m0JFdAJx048451@repoman.freebsd.org> rwatson 2008-01-19 15:39:10 UTC FreeBSD src repository Modified files: sys/fs/coda coda_vnops.c Log: Don't acquire an additional vnode reference to a vnode when it is opened and then release it when it is closed: we rely on the caller to keep the vnode around with a valid reference. This avoids vrele() destroying the vnode vop_close() is being called from during a call to vop_close(), and a crash due to lockmgr recursing the vnode lock when a Coda unmount occurs. MFC after: 3 days Revision Changes Path 1.82 +0 -5 src/sys/fs/coda/coda_vnops.c From rwatson at FreeBSD.org Sat Jan 19 07:40:46 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Jan 19 07:40:51 2008 Subject: cvs commit: src/sys/fs/coda coda_vfsops.c Message-ID: <200801191540.m0JFek44048569@repoman.freebsd.org> rwatson 2008-01-19 15:40:46 UTC FreeBSD src repository Modified files: sys/fs/coda coda_vfsops.c Log: Zero mi_rotovp and coda_ctlvp immediately after calling vrele() on the vnodes during coda_unmount() in order to detect errant use of them after the vnode references may no longer be valid. No need to clear the VV_ROOT flag on mi_rootvp flag (especially after the vnode reference is no longer valid) as this isn't done on other file systems. MFC after: 3 days Revision Changes Path 1.71 +2 -3 src/sys/fs/coda/coda_vfsops.c From bde at FreeBSD.org Sat Jan 19 08:37:57 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Sat Jan 19 08:37:59 2008 Subject: cvs commit: src/lib/msun/src s_rint.c s_rintf.c Message-ID: <200801191637.m0JGbvJg053050@repoman.freebsd.org> bde 2008-01-19 16:37:57 UTC FreeBSD src repository Modified files: lib/msun/src s_rint.c s_rintf.c Log: Use STRICT_ASSIGN() instead of assorted direct volatile hacks to work around assignments not working for gcc on i386. Now volatile hacks for rint() and rintf() don't needlessly pessimize so many arches and the remaining pessimizations (for arm and powerpc) can be avoided centrally. This cleans up after s_rint.c 1.3 and 1.13 and s_rintf.c 1.3 and 1.9: - s_rint.c 1.13 broke 1.3 by only using a volatile cast hack in 1 place when it was needed in 2 places, and the volatile cast hack stopped working with gcc-4. These bugs only affected correctness tests on i386 since i386 normally uses asm rint() and doesn't support the extra precision mode that would break assignments of doubles. - s_rintf.c 1.9 improved(?) on 1.3 by using a volatile variable hack instead of an extra-precision variable hack, but it declared 2 variables as volatile when only 1 variable needed to be volatile. This only affected speed tests on i386 since i386 uses asm rintf(). Revision Changes Path 1.15 +2 -2 src/lib/msun/src/s_rint.c 1.11 +6 -4 src/lib/msun/src/s_rintf.c From rwatson at FreeBSD.org Sat Jan 19 08:39:14 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Jan 19 08:39:17 2008 Subject: cvs commit: src/sys/fs/coda coda_vfsops.c Message-ID: <200801191639.m0JGdEwx053111@repoman.freebsd.org> rwatson 2008-01-19 16:39:14 UTC FreeBSD src repository Modified files: sys/fs/coda coda_vfsops.c Log: Rework coda_statfs(): no longer need to zero the statfs structure or fill out all fields, just fill out the ones the file system knows about. Among other things, this causes the outpuf of "mount" and "df" to make quite a bit more sense as /dev/cfs0 is specified as the mountfrom name. MFC after: 3 days Revision Changes Path 1.72 +1 -6 src/sys/fs/coda/coda_vfsops.c From deischen at freebsd.org Sat Jan 19 09:10:28 2008 From: deischen at freebsd.org (Daniel Eischen) Date: Sat Jan 19 09:10:32 2008 Subject: cvs commit: src/lib/libc/gen Makefile.inc posixshm.c shm_open.3 src/lib/libc/sys Makefile.inc shm_open.2 src/sys/compat/freebsd32 syscalls.master src/sys/conf files src/sys/kern kern_descrip.c syscalls.master uipc_shm.c src/sys/security/mac mac_framework.h ... In-Reply-To: <20080119123352.O91115@fledge.watson.org> References: <200801082158.m08LwGXh035451@repoman.freebsd.org> <20080119123352.O91115@fledge.watson.org> Message-ID: On Sat, 19 Jan 2008, Robert Watson wrote: > On Tue, 8 Jan 2008, John Baldwin wrote: > >> jhb 2008-01-08 21:58:16 UTC >> >> FreeBSD src repository >> >> Modified files: >> lib/libc/gen Makefile.inc >> lib/libc/sys Makefile.inc shm_open.2 > > Do you also need to add the new system calls to src/lib/libc/sys/Symbol.map? You don't need to add them if they are not going to be used outside of libc, or if they are already in the symbol map. -- DE From rwatson at FreeBSD.org Sat Jan 19 09:12:45 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Jan 19 09:12:50 2008 Subject: cvs commit: src/sys/fs/coda coda_vnops.c Message-ID: <200801191712.m0JHCjob064568@repoman.freebsd.org> rwatson 2008-01-19 17:12:45 UTC FreeBSD src repository Modified files: sys/fs/coda coda_vnops.c Log: Improve default vnode operation handling for Coda: - Don't specify vnode operations for mknod, lease, and advlock--let them fall through to vop_default. - Implement vop_default with &default_vnodeops, rather than with VOP_PANIC, so that unimplemented vnode operations are handled in more sensible ways than panicking, such as EOPNOTSUPP on ACL queries generated by bsdtar, or mknod. MFC after: 3 days Revision Changes Path 1.83 +1 -4 src/sys/fs/coda/coda_vnops.c From maxim at FreeBSD.org Sat Jan 19 09:18:18 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 19 09:18:21 2008 Subject: cvs commit: src/etc/defaults rc.conf src/share/man/man5 rc.conf.5 Message-ID: <200801191718.m0JHIH5w065674@repoman.freebsd.org> maxim 2008-01-19 17:18:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) etc/defaults rc.conf share/man/man5 rc.conf.5 Log: MFC rev. 1.322 rc.conf, rev. 1.332 rc.conf.5: TCP_DROP_SYNFIN has gone. Revision Changes Path 1.318.2.2 +0 -2 src/etc/defaults/rc.conf 1.327.2.1 +1 -5 src/share/man/man5/rc.conf.5 From maxim at FreeBSD.org Sat Jan 19 09:18:57 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 19 09:18:59 2008 Subject: cvs commit: src/etc/defaults rc.conf src/share/man/man5 rc.conf.5 Message-ID: <200801191718.m0JHIvs8065755@repoman.freebsd.org> maxim 2008-01-19 17:18:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) etc/defaults rc.conf share/man/man5 rc.conf.5 Log: MFC rev. 1.322 rc.conf, rev. 1.332 rc.conf.5: TCP_DROP_SYNFIN has gone. Revision Changes Path 1.252.2.39 +0 -2 src/etc/defaults/rc.conf 1.256.2.35 +1 -5 src/share/man/man5/rc.conf.5 From maxim at FreeBSD.org Sat Jan 19 09:27:07 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 19 09:27:08 2008 Subject: cvs commit: src/usr.sbin/iostat iostat.c Message-ID: <200801191727.m0JHR59E066140@repoman.freebsd.org> maxim 2008-01-19 17:27:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.sbin/iostat iostat.c Log: MFC rev 1.37: fix an output. MFC revs. 1.38, 1.39: plug a memory leak. Revision Changes Path 1.36.2.1 +6 -4 src/usr.sbin/iostat/iostat.c From maxim at FreeBSD.org Sat Jan 19 09:27:43 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 19 09:27:45 2008 Subject: cvs commit: src/usr.sbin/iostat iostat.c Message-ID: <200801191727.m0JHRhvf066183@repoman.freebsd.org> maxim 2008-01-19 17:27:43 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/iostat iostat.c Log: MFC rev 1.37: fix an output. MFC revs. 1.38, 1.39: plug a memory leak. Revision Changes Path 1.28.12.5 +6 -4 src/usr.sbin/iostat/iostat.c From maxim at FreeBSD.org Sat Jan 19 09:32:18 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 19 09:32:20 2008 Subject: cvs commit: src/share/man/man9 mbuf_tags.9 Message-ID: <200801191732.m0JHWH0Z066388@repoman.freebsd.org> maxim 2008-01-19 17:32:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man9 mbuf_tags.9 Log: MFC revs. 1.8, 1.9: do not claim vlan(4) uses mbuf_tags(9). Revision Changes Path 1.7.10.1 +3 -4 src/share/man/man9/mbuf_tags.9 From maxim at FreeBSD.org Sat Jan 19 09:33:03 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 19 09:33:08 2008 Subject: cvs commit: src/share/man/man9 mbuf_tags.9 Message-ID: <200801191733.m0JHX326066454@repoman.freebsd.org> maxim 2008-01-19 17:33:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man9 mbuf_tags.9 Log: MFC revs. 1.8, 1.9: do not claim vlan(4) uses mbuf_tags(9). Revision Changes Path 1.7.2.1 +3 -4 src/share/man/man9/mbuf_tags.9 From attilio at FreeBSD.org Sat Jan 19 09:36:24 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Sat Jan 19 09:36:26 2008 Subject: cvs commit: src/sys/gnu/fs/xfs/FreeBSD xfs_buf.c xfs_buf.h src/sys/kern kern_shutdown.c vfs_bio.c vfs_subr.c src/sys/nfs4client nfs4_vnops.c src/sys/nfsclient nfs_subs.c nfs_vnops.c src/sys/sys buf.h lockmgr.h src/sys/ufs/ffs ... Message-ID: <200801191736.m0JHaOQ5066747@repoman.freebsd.org> attilio 2008-01-19 17:36:24 UTC FreeBSD src repository Modified files: sys/gnu/fs/xfs/FreeBSD xfs_buf.c xfs_buf.h sys/kern kern_shutdown.c vfs_bio.c vfs_subr.c sys/nfs4client nfs4_vnops.c sys/nfsclient nfs_subs.c nfs_vnops.c sys/sys buf.h lockmgr.h sys/ufs/ffs ffs_vfsops.c Log: - Introduce the function lockmgr_recursed() which returns true if the lockmgr lkp, when held in exclusive mode, is recursed - Introduce the function BUF_RECURSED() which does the same for bufobj locks based on the top of lockmgr_recursed() - Introduce the function BUF_ISLOCKED() which works like the counterpart VOP_ISLOCKED(9), showing the state of lockmgr linked with the bufobj BUF_RECURSED() and BUF_ISLOCKED() entirely replace the usage of bogus BUF_REFCNT() in a more explicative and SMP-compliant way. This allows us to axe out BUF_REFCNT() and leaving the function lockcount() totally unused in our stock kernel. Further commits will axe lockcount() as well as part of lockmgr() cleanup. KPI results, obviously, broken so further commits will update manpages and freebsd version. Tested by: kris (on UFS and NFS) Revision Changes Path 1.3 +4 -4 src/sys/gnu/fs/xfs/FreeBSD/xfs_buf.c 1.3 +1 -2 src/sys/gnu/fs/xfs/FreeBSD/xfs_buf.h 1.188 +1 -1 src/sys/kern/kern_shutdown.c 1.535 +14 -16 src/sys/kern/vfs_bio.c 1.716 +1 -1 src/sys/kern/vfs_subr.c 1.40 +5 -4 src/sys/nfs4client/nfs4_vnops.c 1.150 +1 -1 src/sys/nfsclient/nfs_subs.c 1.280 +5 -4 src/sys/nfsclient/nfs_vnops.c 1.198 +12 -24 src/sys/sys/buf.h 1.57 +2 -0 src/sys/sys/lockmgr.h 1.334 +1 -1 src/sys/ufs/ffs/ffs_vfsops.c From attilio at FreeBSD.org Sat Jan 19 09:39:25 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Sat Jan 19 09:39:28 2008 Subject: cvs commit: src/sys/sys param.h Message-ID: <200801191739.m0JHdPcQ066874@repoman.freebsd.org> attilio 2008-01-19 17:39:25 UTC FreeBSD src repository Modified files: sys/sys param.h Log: Bump FreeBSD_version in order to reflect introduction of lockmgr_recursed(), BUF_RECURSED(), BUF_ISLOCKED() and trimming out of BUF_REFCNT(). Revision Changes Path 1.326 +1 -1 src/sys/sys/param.h From maxim at FreeBSD.org Sat Jan 19 09:40:09 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 19 09:40:14 2008 Subject: cvs commit: src/etc rc.firewall rc.firewall6 Message-ID: <200801191740.m0JHe8kn067027@repoman.freebsd.org> maxim 2008-01-19 17:40:08 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) etc rc.firewall rc.firewall6 Log: MFC rev. 1.53 rc.firewall and rev. 1.18 rc.firewall6: fix bibliography. Revision Changes Path 1.52.2.1 +6 -7 src/etc/rc.firewall 1.17.2.1 +7 -8 src/etc/rc.firewall6 From maxim at FreeBSD.org Sat Jan 19 09:40:28 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 19 09:40:33 2008 Subject: cvs commit: src/etc rc.firewall rc.firewall6 Message-ID: <200801191740.m0JHeSp7067116@repoman.freebsd.org> maxim 2008-01-19 17:40:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) etc rc.firewall rc.firewall6 Log: MFC rev. 1.53 rc.firewall and rev. 1.18 rc.firewall6: fix bibliography. Revision Changes Path 1.47.10.3 +7 -8 src/etc/rc.firewall 1.15.8.2 +7 -8 src/etc/rc.firewall6 From maxim at FreeBSD.org Sat Jan 19 09:53:10 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 19 09:53:12 2008 Subject: cvs commit: src/sbin/mount_ntfs mount_ntfs.8 src/sys/fs/ntfs ntfs_vfsops.c Message-ID: <200801191753.m0JHr95B067747@repoman.freebsd.org> maxim 2008-01-19 17:53:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sbin/mount_ntfs mount_ntfs.8 sys/fs/ntfs ntfs_vfsops.c Log: MFC rev. 1.90 ntfs_vfsops.c and revs. 1.22, 1.23 mount_ntfs.8: mask maximum file permissions with ACCESSPERMS. Revision Changes Path 1.21.10.1 +4 -1 src/sbin/mount_ntfs/mount_ntfs.8 1.88.2.1 +2 -1 src/sys/fs/ntfs/ntfs_vfsops.c From maxim at FreeBSD.org Sat Jan 19 09:54:11 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 19 09:54:14 2008 Subject: cvs commit: src/sbin/mount_ntfs mount_ntfs.8 src/sys/fs/ntfs ntfs_vfsops.c Message-ID: <200801191754.m0JHsBg4067819@repoman.freebsd.org> maxim 2008-01-19 17:54:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sbin/mount_ntfs mount_ntfs.8 sys/fs/ntfs ntfs_vfsops.c Log: MFC rev. 1.90 ntfs_vfsops.c and revs. 1.22, 1.23 mount_ntfs.8: mask maximum file permissions with ACCESSPERMS. Revision Changes Path 1.21.2.1 +4 -1 src/sbin/mount_ntfs/mount_ntfs.8 1.78.2.5 +2 -1 src/sys/fs/ntfs/ntfs_vfsops.c From kib at FreeBSD.org Sat Jan 19 09:57:06 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Sat Jan 19 09:57:08 2008 Subject: cvs commit: src/sys/kern tty_pty.c Message-ID: <200801191757.m0JHv6dH067963@repoman.freebsd.org> kib 2008-01-19 17:57:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern tty_pty.c Log: MFC rev. 1.156: In the rev. 1.153, the one place for converting minor number to unit was missed. As result, pty_create_slave() may index out of the names[] bounds, creating wrong slave tty names. Revision Changes Path 1.152.2.3 +3 -1 src/sys/kern/tty_pty.c From maxim at FreeBSD.org Sat Jan 19 10:01:50 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 19 10:01:53 2008 Subject: cvs commit: src/usr.sbin/inetd inetd.8 Message-ID: <200801191801.m0JI1obv068245@repoman.freebsd.org> maxim 2008-01-19 18:01:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.sbin/inetd inetd.8 Log: MFC rev. 1.85: wait/nowait column for ONC services. Revision Changes Path 1.84.2.1 +2 -1 src/usr.sbin/inetd/inetd.8 From maxim at FreeBSD.org Sat Jan 19 10:02:12 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 19 10:02:17 2008 Subject: cvs commit: src/usr.sbin/inetd inetd.8 Message-ID: <200801191802.m0JI2Bes068296@repoman.freebsd.org> maxim 2008-01-19 18:02:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/inetd inetd.8 Log: MFC rev. 1.85: wait/nowait column for ONC services. Revision Changes Path 1.81.2.3 +2 -1 src/usr.sbin/inetd/inetd.8 From maxim at FreeBSD.org Sat Jan 19 10:06:07 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 19 10:06:08 2008 Subject: cvs commit: src/share/misc bsd-family-tree Message-ID: <200801191806.m0JI66U6069657@repoman.freebsd.org> maxim 2008-01-19 18:06:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/misc bsd-family-tree Log: MFC revs. 1.116-1.118: OpenBSD 4.2, NetBSD 4.0, FreeBSD 6.3. Revision Changes Path 1.95.2.10 +8 -1 src/share/misc/bsd-family-tree From maxim at FreeBSD.org Sat Jan 19 10:07:08 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sat Jan 19 10:07:10 2008 Subject: cvs commit: src/share/misc bsd-family-tree Message-ID: <200801191807.m0JI77Z0069731@repoman.freebsd.org> maxim 2008-01-19 18:07:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/misc bsd-family-tree Log: MFC revs. 1.116-1.118: OpenBSD 4.2, NetBSD 4.0, FreeBSD 6.3. Revision Changes Path 1.115.2.1 +8 -1 src/share/misc/bsd-family-tree From kib at FreeBSD.org Sat Jan 19 10:12:26 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Sat Jan 19 10:12:31 2008 Subject: cvs commit: src/sys/ufs/ffs ffs_balloc.c Message-ID: <200801191812.m0JICPCB070094@repoman.freebsd.org> kib 2008-01-19 18:12:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/ufs/ffs ffs_balloc.c Log: MFC rev. 1.52: The ffs_balloc() routines, whan allocating the indirect blocks for the inode, do the rollback in case the allocation failed (due to insufficient free space or quota limits). But, the code does leaves the buffers corresponding to the inoirect blocks on the vnode bufobj list. This causes several assertion failures (for instance, "ffs_truncate3" in ffs_truncate()) to fail, and could result in the indirect block aliasing problem, like writing the context of such blocks to random disk location. Remove the buffers from the bufobj properly. MFC rev. 1.53: ffs_balloc_ufsX() routines, in the case of recovering from the failed allocation, free the indirect blocks before clearing the disk pointers, that could lead to the softupdate inconsistencies in the case of the machine or disk crash at the wrong time. Rearrange the recover code to do the ffs_blkfree() after the second ffs_syncvnode(), that clears the pointers chain. Approved by: re (kensmith) Revision Changes Path 1.50.14.1 +50 -6 src/sys/ufs/ffs/ffs_balloc.c From bde at FreeBSD.org Sat Jan 19 10:13:21 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Sat Jan 19 10:13:23 2008 Subject: cvs commit: src/lib/msun/src s_log1p.c s_log1pf.c Message-ID: <200801191813.m0JIDLjF070709@repoman.freebsd.org> bde 2008-01-19 18:13:21 UTC FreeBSD src repository Modified files: lib/msun/src s_log1p.c s_log1pf.c Log: Use STRICT_ASSIGN() for log1pf() and log1p() instead of a volatile cast hack for log1pf() only. The cast hack broke with gcc-4, resulting in ~1 million errors of more than 1 ulp, with a maximum error of ~1.5 ulps. Now the maximum error for log1pf() on i386 is 0.5034 ulps again (this depends on extra precision), and log1p() has a chance of working with extra precision. See s_log1pf.c 1.8 for the original hack. (It claims only 62343 large errors). Convert to _FBSDID(). Another thing broken with gcc-4 is the static const hack used for rcsids. Revision Changes Path 1.9 +5 -4 src/lib/msun/src/s_log1p.c 1.10 +5 -4 src/lib/msun/src/s_log1pf.c From kib at FreeBSD.org Sat Jan 19 10:15:07 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Sat Jan 19 10:15:12 2008 Subject: cvs commit: src/sys/amd64/amd64 machdep.c pmap.c src/sys/arm/arm pmap.c src/sys/arm/at91 kb920x_machdep.c src/sys/arm/sa11x0 assabet_machdep.c src/sys/arm/xscale/i80321 ep80219_machdep.c iq31244_machdep.c src/sys/arm/xscale/i8134x crb_machdep.c ... Message-ID: <200801191815.m0JIF7UJ071569@repoman.freebsd.org> kib 2008-01-19 18:15:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/amd64/amd64 machdep.c pmap.c sys/arm/arm pmap.c sys/arm/at91 kb920x_machdep.c sys/arm/sa11x0 assabet_machdep.c sys/arm/xscale/i80321 ep80219_machdep.c iq31244_machdep.c sys/arm/xscale/i8134x crb_machdep.c sys/arm/xscale/ixp425 avila_machdep.c sys/compat/pecoff imgact_pecoff.c sys/compat/svr4 imgact_svr4.c sys/i386/i386 machdep.c pmap.c sys/i386/ibcs2 imgact_coff.c sys/i386/linux imgact_linux.c sys/ia64/ia64 machdep.c pmap.c sys/kern imgact_aout.c imgact_elf.c imgact_gzip.c kern_exec.c kern_fork.c kern_kse.c kern_proc.c kern_sig.c kern_thr.c kern_thread.c sys/pc98/pc98 machdep.c sys/powerpc/powerpc machdep.c pmap_dispatch.c sys/sparc64/sparc64 machdep.c pmap.c sys/sun4v/sun4v machdep.c pmap.c sys/sys proc.h signalvar.h sys/vm pmap.h vm_extern.h vm_glue.c vm_map.c Log: MFC fix for the panic("vm_thread_new: kstack allocation failed") and silent NULL pointer dereference in the i386 and sparc64 pmap_pinit() when the kmem_alloc_nofault() failed to allocate address space. Both functions now return error instead of panicing or dereferencing NULL. The reason for MFCing this so late in release cycle is, according to marius@, because > it fixes the crashing (though no panic) of the test suite > of the graphic/OpenEXR port on sparc64. This test suite is run > (and required to succeed) during the package build and that's > why portmgr@ bitch about at it as OpenEXR is a dependency of KDE > which in turn is supposed to end up on the release CD images. Revisions MFCed: 1.677 of src/sys/amd64/amd64/machdep.c 1.592 of src/sys/amd64/amd64/pmap.c 1.88 of src/sys/arm/arm/pmap.c 1.27 of src/sys/arm/at91/kb920x_machdep.c 1.22 of src/sys/arm/sa11x0/assabet_machdep.c 1.8 of src/sys/arm/xscale/i80321/ep80219_machdep.c 1.29 of src/sys/arm/xscale/i80321/iq31244_machdep.c 1.3 of src/sys/arm/xscale/i8134x/crb_machdep.c 1.6 of src/sys/arm/xscale/ixp425/avila_machdep.c 1.41 of src/sys/compat/pecoff/imgact_pecoff.c 1.26 of src/sys/compat/svr4/imgact_svr4.c 1.660 of src/sys/i386/i386/machdep.c 1.596 of src/sys/i386/i386/pmap.c 1.68 of src/sys/i386/ibcs2/imgact_coff.c 1.56 of src/sys/i386/linux/imgact_linux.c 1.226 of src/sys/ia64/ia64/machdep.c 1.192 of src/sys/ia64/ia64/pmap.c 1.102 of src/sys/kern/imgact_aout.c 1.179 of src/sys/kern/imgact_elf.c 1.56 of src/sys/kern/imgact_gzip.c 1.310 of src/sys/kern/kern_exec.c 1.287 of src/sys/kern/kern_fork.c 1.236 of src/sys/kern/kern_kse.c 1.253 of src/sys/kern/kern_proc.c 1.352 of src/sys/kern/kern_sig.c 1.63 of src/sys/kern/kern_thr.c 1.257 of src/sys/kern/kern_thread.c 1.397 of src/sys/pc98/pc98/machdep.c 1.104 of src/sys/powerpc/powerpc/machdep.c 1.10 of src/sys/powerpc/powerpc/pmap_dispatch.c 1.139 of src/sys/sparc64/sparc64/machdep.c 1.167 of src/sys/sparc64/sparc64/pmap.c 1.16 of src/sys/sun4v/sun4v/machdep.c 1.40 of src/sys/sun4v/sun4v/pmap.c 1.493 of src/sys/sys/proc.h 1.78 of src/sys/sys/signalvar.h 1.80 of src/sys/vm/pmap.h 1.79 of src/sys/vm/vm_extern.h 1.226 of src/sys/vm/vm_glue.c 1.390 of src/sys/vm/vm_map.c Requested by: marius Tested by: Peter Holm, marius (make universe and sparc64 runs) Approved by: re (kensmith) Revision Changes Path 1.675.2.2.2.1 +1 -1 src/sys/amd64/amd64/machdep.c 1.590.2.3.2.1 +3 -1 src/sys/amd64/amd64/pmap.c 1.86.2.1.2.1 +2 -1 src/sys/arm/arm/pmap.c 1.23.2.1.2.1 +1 -1 src/sys/arm/at91/kb920x_machdep.c 1.21.4.1 +1 -1 src/sys/arm/sa11x0/assabet_machdep.c 1.7.4.1 +1 -1 src/sys/arm/xscale/i80321/ep80219_machdep.c 1.28.4.1 +1 -1 src/sys/arm/xscale/i80321/iq31244_machdep.c 1.2.4.1 +1 -1 src/sys/arm/xscale/i8134x/crb_machdep.c 1.5.4.1 +1 -1 src/sys/arm/xscale/ixp425/avila_machdep.c 1.40.4.1 +5 -1 src/sys/compat/pecoff/imgact_pecoff.c 1.25.14.1 +3 -1 src/sys/compat/svr4/imgact_svr4.c 1.658.2.1.2.1 +1 -1 src/sys/i386/i386/machdep.c 1.594.2.4.2.1 +8 -1 src/sys/i386/i386/pmap.c 1.67.4.1 +3 -1 src/sys/i386/ibcs2/imgact_coff.c 1.55.4.1 +3 -1 src/sys/i386/linux/imgact_linux.c 1.225.4.1 +1 -1 src/sys/ia64/ia64/machdep.c 1.191.4.1 +2 -1 src/sys/ia64/ia64/pmap.c 1.101.4.1 +3 -1 src/sys/kern/imgact_aout.c 1.178.2.2.2.1 +3 -1 src/sys/kern/imgact_elf.c 1.55.4.1 +5 -1 src/sys/kern/imgact_gzip.c 1.308.2.1.2.1 +3 -1 src/sys/kern/kern_exec.c 1.282.2.1.2.1 +34 -7 src/sys/kern/kern_fork.c 1.235.4.1 +30 -13 src/sys/kern/kern_kse.c 1.252.2.2.2.1 +13 -15 src/sys/kern/kern_proc.c 1.349.2.1.2.1 +1 -1 src/sys/kern/kern_sig.c 1.62.4.1 +2 -0 src/sys/kern/kern_thr.c 1.255.2.1.2.1 +22 -5 src/sys/kern/kern_thread.c 1.396.4.1 +1 -1 src/sys/pc98/pc98/machdep.c 1.103.2.1.2.1 +2 -2 src/sys/powerpc/powerpc/machdep.c 1.9.4.1 +2 -1 src/sys/powerpc/powerpc/pmap_dispatch.c 1.138.4.1 +1 -1 src/sys/sparc64/sparc64/machdep.c 1.166.4.1 +6 -1 src/sys/sparc64/sparc64/pmap.c 1.15.4.1 +1 -1 src/sys/sun4v/sun4v/machdep.c 1.39.4.1 +2 -1 src/sys/sun4v/sun4v/pmap.c 1.491.2.1.2.1 +1 -0 src/sys/sys/proc.h 1.77.4.1 +1 -0 src/sys/sys/signalvar.h 1.79.4.1 +1 -1 src/sys/vm/pmap.h 1.78.4.1 +5 -5 src/sys/vm/vm_extern.h 1.225.4.1 +22 -11 src/sys/vm/vm_glue.c 1.388.2.1.2.2 +23 -6 src/sys/vm/vm_map.c From bmah at FreeBSD.org Sat Jan 19 10:24:30 2008 From: bmah at FreeBSD.org (Bruce A. Mah) Date: Sat Jan 19 10:24:33 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml Message-ID: <200801191824.m0JIOUTg072005@repoman.freebsd.org> bmah 2008-01-19 18:24:30 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) release/doc/en_US.ISO8859-1/relnotes article.sgml Log: Now that RELENG_7 is in a slush state, trim release notes for a post-7.0 world. Revision Changes Path 1.1068.2.21 +15 -1436 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml From bmah at FreeBSD.org Sat Jan 19 10:25:18 2008 From: bmah at FreeBSD.org (Bruce A. Mah) Date: Sat Jan 19 10:25:23 2008 Subject: cvs commit: src/release/doc/share/sgml release.ent Message-ID: <200801191825.m0JIPIM6072103@repoman.freebsd.org> bmah 2008-01-19 18:25:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) release/doc/share/sgml release.ent Log: Update release documentation entities for a post 7.0 world. Revision Changes Path 1.28.2.3 +5 -5 src/release/doc/share/sgml/release.ent From rwatson at FreeBSD.org Sat Jan 19 11:21:07 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Jan 19 11:21:10 2008 Subject: cvs commit: src/sys/fs/coda coda_namecache.h Message-ID: <200801191921.m0JJL7Tk077005@repoman.freebsd.org> rwatson 2008-01-19 19:21:07 UTC FreeBSD src repository Modified files: sys/fs/coda coda_namecache.h Log: Remove unused oldhash definition from Coda namecache. MFC after: 3 days Revision Changes Path 1.13 +0 -5 src/sys/fs/coda/coda_namecache.h From bde at FreeBSD.org Sat Jan 19 12:02:56 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Sat Jan 19 12:02:58 2008 Subject: cvs commit: src/lib/msun/src k_rem_pio2.c k_rem_pio2f.c Message-ID: <200801192002.m0JK2tK2078812@repoman.freebsd.org> bde 2008-01-19 20:02:55 UTC FreeBSD src repository Modified files: lib/msun/src k_rem_pio2.c k_rem_pio2f.c Log: Use STRICT_ASSIGN() for _kernel_rem_pio2f() and _kernel_rem_pio2f() instead of a volatile cast hack for the float version only. The cast hack broke with gcc-4, but this was harmless since the float version hasn't been used for a few years. Merge from the float version so that the double version has a chance of working on i386 with extra precision. See k_rem_pio2f.c rev.1.8 for the original hack. Convert to _FBSDID(). Revision Changes Path 1.8 +5 -3 src/lib/msun/src/k_rem_pio2.c 1.9 +5 -4 src/lib/msun/src/k_rem_pio2f.c From njl at FreeBSD.org Sat Jan 19 12:31:00 2008 From: njl at FreeBSD.org (Nate Lawson) Date: Sat Jan 19 12:31:06 2008 Subject: cvs commit: src/sys/kern kern_cpu.c Message-ID: <200801192030.m0JKUxkZ081949@repoman.freebsd.org> njl 2008-01-19 20:30:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/kern kern_cpu.c Log: MFC 1.28,1.29: reject cpufreq changes before sched_bind() is usable and remove duplicated levels. Approved by: re Revision Changes Path 1.27.4.1 +28 -1 src/sys/kern/kern_cpu.c From njl at FreeBSD.org Sat Jan 19 12:31:00 2008 From: njl at FreeBSD.org (Nate Lawson) Date: Sat Jan 19 12:31:10 2008 Subject: cvs commit: src/sys/kern kern_cpu.c Message-ID: <200801192031.m0JKV0da081972@repoman.freebsd.org> njl 2008-01-19 20:31:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern kern_cpu.c Log: MFC 1.28,1.29: reject cpufreq changes before sched_bind() is usable and remove duplicated levels. Approved by: re Revision Changes Path 1.27.2.1 +28 -1 src/sys/kern/kern_cpu.c From bde at FreeBSD.org Sat Jan 19 13:37:15 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Sat Jan 19 13:37:19 2008 Subject: cvs commit: src/lib/msun/src s_exp2.c s_exp2f.c Message-ID: <200801192137.m0JLbFIa095771@repoman.freebsd.org> bde 2008-01-19 21:37:14 UTC FreeBSD src repository Modified files: lib/msun/src s_exp2.c s_exp2f.c Log: Use STRICT_ASSIGN() for exp2f() and exp2() instead of a volatile variable hack for exp2f() only. The volatile variable had a surprisingly large cost for exp2f() -- 19 cycles or 15% on i386 in the worst case observed. This is only partly explained by there being several references to the variable, only one of which benefited from it being volatile. Arches that have working assignment are likely to benefit even more from not having any volatile variable. exp2() now has a chance of working with extra precision on i386. exp2() has even more references to the variable, so it would have been pessimized more by simply declaring the variable as volatile. Even the temporary volatile variable for STRICT_ASSIGN costs 5-10% on i386, (A64) so I will change STRICT_ASSIGN() to do an ordinary assignment until i386 defaults to extra precision. Revision Changes Path 1.4 +1 -1 src/lib/msun/src/s_exp2.c 1.3 +4 -3 src/lib/msun/src/s_exp2f.c From das at FreeBSD.org Sat Jan 19 13:41:32 2008 From: das at FreeBSD.org (David Schultz) Date: Sat Jan 19 13:41:36 2008 Subject: cvs commit: src/sys/sys signal.h Message-ID: <200801192141.m0JLfWek095960@repoman.freebsd.org> das 2008-01-19 21:41:31 UTC FreeBSD src repository Modified files: sys/sys signal.h Log: Correct the visibility macro surrounding SIGSYS. Submitted by: Andriy Gapon Revision Changes Path 1.58 +1 -1 src/sys/sys/signal.h From bde at FreeBSD.org Sat Jan 19 14:05:14 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Sat Jan 19 14:05:16 2008 Subject: cvs commit: src/lib/msun/src math_private.h Message-ID: <200801192205.m0JM5EF2098067@repoman.freebsd.org> bde 2008-01-19 22:05:14 UTC FreeBSD src repository Modified files: lib/msun/src math_private.h Log: Do an ordinary assignment in STRICT_ASSIGN() except for floats until there is a problem with non-floats (when i386 defaults to extra precision). This essentially restores yesterday's behaviour for doubles on i386 (since generic rint() isn't used and everywhere else assumed working assignment), but for arches that use the generic rint() it finishes restoring some of 1995's behaviour (don't waste time doing unnecessary store/load). Revision Changes Path 1.23 +6 -2 src/lib/msun/src/math_private.h From kmacy at FreeBSD.org Sat Jan 19 14:47:44 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sat Jan 19 14:47:48 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_sge.c src/sys/dev/cxgb/sys cxgb_support.c Message-ID: <200801192247.m0JMlhCu001186@repoman.freebsd.org> kmacy 2008-01-19 22:47:43 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_sge.c sys/dev/cxgb/sys cxgb_support.c Log: Re-enable pcpu caching by default make sysctl R/W Revision Changes Path 1.47 +1 -1 src/sys/dev/cxgb/cxgb_sge.c 1.5 +1 -1 src/sys/dev/cxgb/sys/cxgb_support.c From bde at FreeBSD.org Sat Jan 19 14:50:51 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Sat Jan 19 14:50:53 2008 Subject: cvs commit: src/lib/msun/src k_rem_pio2f.c Message-ID: <200801192250.m0JMooNr001418@repoman.freebsd.org> bde 2008-01-19 22:50:50 UTC FreeBSD src repository Removed files: lib/msun/src k_rem_pio2f.c Log: Remove the float version of the kernel of arg reduction for pi/2, since it should never have existed and it has not been used for many years (floats are reduced faster using doubles). All relevant changes (just the workaround for broken assignment) have been merged to the double version. Revision Changes Path 1.10 +0 -198 src/lib/msun/src/k_rem_pio2f.c (dead) From rodrigc at FreeBSD.org Sat Jan 19 18:38:43 2008 From: rodrigc at FreeBSD.org (Craig Rodrigues) Date: Sat Jan 19 18:38:48 2008 Subject: cvs commit: src/sys/kern vfs_mount.c Message-ID: <200801200238.m0K2cgiT029752@repoman.freebsd.org> rodrigc 2008-01-20 02:38:42 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/kern vfs_mount.c Log: MFC: 1.270 - In vfs_scanopt(), make sure that the mount option value is not NULL before calling vsscanf(). PR: 118531 MFC: 1.268 - Internally convert "rdonly" mount option to "ro". Approved by: re (kensmith) Revision Changes Path 1.265.2.1.2.1 +8 -3 src/sys/kern/vfs_mount.c From bde at FreeBSD.org Sat Jan 19 20:09:50 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Sat Jan 19 20:10:02 2008 Subject: cvs commit: src/lib/msun/src k_rem_pio2.c Message-ID: <200801200409.m0K49k7B036386@repoman.freebsd.org> bde 2008-01-20 04:09:44 UTC FreeBSD src repository Modified files: lib/msun/src k_rem_pio2.c Log: Oops, when merging from the float version to the double versions, don't forget to translate "float" to "double". ucbtest didn't detect the bug, but exhaustive testing of the float case relative to the double case eventually did. The bug only affects args x with |x| ~> 2**19*(pi/2) on non-i386 (i386 is broken in a different way for large args). Revision Changes Path 1.9 +1 -1 src/lib/msun/src/k_rem_pio2.c From bmah at FreeBSD.org Sat Jan 19 21:57:41 2008 From: bmah at FreeBSD.org (Bruce A. Mah) Date: Sat Jan 19 21:57:45 2008 Subject: cvs commit: src/release/doc/share/sgml release.ent Message-ID: <200801200557.m0K5vefW067162@repoman.freebsd.org> bmah 2008-01-20 05:57:39 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/share/sgml release.ent Log: Update entities for a post-6.2 world. Revision Changes Path 1.24.2.8 +4 -4 src/release/doc/share/sgml/release.ent From bmah at FreeBSD.org Sat Jan 19 21:58:18 2008 From: bmah at FreeBSD.org (Bruce A. Mah) Date: Sat Jan 19 21:58:22 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml Message-ID: <200801200558.m0K5wI11067209@repoman.freebsd.org> bmah 2008-01-20 05:58:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: Trim release notes for a post 6.3 world. Revision Changes Path 1.883.2.89 +13 -223 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From bmah at FreeBSD.org Sat Jan 19 22:00:03 2008 From: bmah at FreeBSD.org (Bruce A. Mah) Date: Sat Jan 19 22:00:05 2008 Subject: cvs commit: src/release/doc/share/sgml release.ent Message-ID: <200801200600.m0K603aY067335@repoman.freebsd.org> bmah 2008-01-20 06:00:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/share/sgml release.ent Log: Forced commit to note that revision 1.24.2.8 was appropriate for a post-6.3 world. Revision Changes Path 1.24.2.9 +0 -0 src/release/doc/share/sgml/release.ent From maxim at FreeBSD.org Sun Jan 20 00:31:35 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sun Jan 20 00:31:37 2008 Subject: cvs commit: src/sbin/ipfw ipfw2.c Message-ID: <200801200831.m0K8VZ0E081130@repoman.freebsd.org> maxim 2008-01-20 08:31:35 UTC FreeBSD src repository Modified files: sbin/ipfw ipfw2.c Log: o Fix ipfw(8) command line parser bug: "ipfw nat 1 config if" requires an argument. PR: bin/119815 Submitted by: Dierk Sacher MFC after: 1 week Revision Changes Path 1.112 +2 -0 src/sbin/ipfw/ipfw2.c From bz at FreeBSD.org Sun Jan 20 02:08:16 2008 From: bz at FreeBSD.org (Bjoern A. Zeeb) Date: Sun Jan 20 02:08:21 2008 Subject: cvs commit: src/sys/netinet6 in6_src.c Message-ID: <200801201008.m0KA8FYi096810@repoman.freebsd.org> bz 2008-01-20 10:08:15 UTC FreeBSD src repository Modified files: sys/netinet6 in6_src.c Log: Correct the commented out debugging printf()s in REPLACE and NEXT macros. ip6_sprintf() needs a buffer as first argument these days. MFC after: 2 weeks Revision Changes Path 1.49 +8 -2 src/sys/netinet6/in6_src.c From admin at su29.net Sun Jan 20 08:18:11 2008 From: admin at su29.net (Alexander V. Chernikov) Date: Sun Jan 20 08:18:17 2008 Subject: cvs commit: src/share/man/man9 mbuf_tags.9 In-Reply-To: <200801191733.m0JHX326066454@repoman.freebsd.org> References: <200801191733.m0JHX326066454@repoman.freebsd.org> Message-ID: <47936D1C.6030805@su29.net> Maxim Konovalov wrote: > maxim 2008-01-19 17:33:03 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_6) > share/man/man9 mbuf_tags.9 > Log: > MFC revs. 1.8, 1.9: do not claim vlan(4) uses mbuf_tags(9). > > Revision Changes Path > 1.7.2.1 +3 -4 src/share/man/man9/mbuf_tags.9 > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > > Hi Maxim, mbuf_tags(9) are still used in vlan processing code on RELENG_6 From maxim at FreeBSD.org Sun Jan 20 08:31:40 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Sun Jan 20 08:31:42 2008 Subject: cvs commit: src/share/man/man9 mbuf_tags.9 Message-ID: <200801201631.m0KGVdm6037550@repoman.freebsd.org> maxim 2008-01-20 16:31:39 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man9 mbuf_tags.9 Log: Revert 1.7.2.1: vlan(4) does use mbuf_tags(9) in RELENG_6. Noticed by: Alexander V. Chernikov Revision Changes Path 1.7.2.2 +4 -3 src/share/man/man9/mbuf_tags.9 From rwatson at FreeBSD.org Sun Jan 20 11:55:53 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sun Jan 20 11:55:58 2008 Subject: cvs commit: src/sys/sys user.h src/sys/kern kern_descrip.c Message-ID: <200801201955.m0KJtr2m094245@repoman.freebsd.org> rwatson 2008-01-20 19:55:52 UTC FreeBSD src repository Modified files: sys/sys user.h sys/kern kern_descrip.c Log: Export a type for POSIX SHM file descriptors via kern.proc.filedesc as used by procstat, or SHM descriptors will show up as type unknown in userspace. Revision Changes Path 1.321 +4 -0 src/sys/kern/kern_descrip.c 1.73 +1 -0 src/sys/sys/user.h From rwatson at FreeBSD.org Sun Jan 20 11:57:34 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sun Jan 20 11:57:39 2008 Subject: cvs commit: src/usr.bin/procstat procstat_files.c Message-ID: <200801201957.m0KJvXA2094698@repoman.freebsd.org> rwatson 2008-01-20 19:57:33 UTC FreeBSD src repository Modified files: usr.bin/procstat procstat_files.c Log: When printing process file descriptor lists, show a type of 'h' for POSIX shared memory descriptors. Revision Changes Path 1.3 +4 -0 src/usr.bin/procstat/procstat_files.c From brueffer at FreeBSD.org Sun Jan 20 13:55:29 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Sun Jan 20 13:55:30 2008 Subject: cvs commit: src/share/man/man4 Makefile coretemp.4 Message-ID: <200801202155.m0KLtS3b013984@repoman.freebsd.org> brueffer 2008-01-20 21:55:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man4 Makefile Added files: (Branch: RELENG_6) share/man/man4 coretemp.4 Log: MFC: Manpage for the coretemp(4) driver. PR: 119837 Submitted by: Dylan Cochran Revision Changes Path 1.320.2.33 +2 -0 src/share/man/man4/Makefile 1.4.2.1 +74 -0 src/share/man/man4/coretemp.4 (new) From rwatson at FreeBSD.org Sun Jan 20 15:43:07 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sun Jan 20 15:43:08 2008 Subject: cvs commit: src/sys/kern syscalls.master src/sys/compat/freebsd32 syscalls.master Message-ID: <200801202343.m0KNh7St028007@repoman.freebsd.org> rwatson 2008-01-20 23:43:06 UTC FreeBSD src repository Modified files: sys/kern syscalls.master sys/compat/freebsd32 syscalls.master Log: Use audit events AUE_SHMOPEN and AUE_SHMUNLINK with new system calls shm_open() and shm_unlink(). More auditing will need to be done for these calls to capture arguments properly. Revision Changes Path 1.95 +2 -2 src/sys/compat/freebsd32/syscalls.master 1.236 +2 -2 src/sys/kern/syscalls.master From rwatson at FreeBSD.org Sun Jan 20 15:44:25 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sun Jan 20 15:44:27 2008 Subject: cvs commit: src/sys/kern init_sysent.c syscalls.c systrace_args.c src/sys/sys syscall.h syscall.mk sysproto.h src/sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c Message-ID: <200801202344.m0KNiPTA028141@repoman.freebsd.org> rwatson 2008-01-20 23:44:25 UTC FreeBSD src repository Modified files: sys/kern init_sysent.c syscalls.c systrace_args.c sys/sys syscall.h syscall.mk sysproto.h sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c Log: Regenerate. Revision Changes Path 1.81 +1 -1 src/sys/compat/freebsd32/freebsd32_proto.h 1.79 +1 -1 src/sys/compat/freebsd32/freebsd32_syscall.h 1.70 +1 -1 src/sys/compat/freebsd32/freebsd32_syscalls.c 1.80 +3 -3 src/sys/compat/freebsd32/freebsd32_sysent.c 1.232 +3 -3 src/sys/kern/init_sysent.c 1.216 +1 -1 src/sys/kern/syscalls.c 1.16 +0 -0 src/sys/kern/systrace_args.c 1.213 +1 -1 src/sys/sys/syscall.h 1.168 +1 -1 src/sys/sys/syscall.mk 1.217 +3 -3 src/sys/sys/sysproto.h From Benjamin.Close at clearchain.com Sun Jan 20 16:47:24 2008 From: Benjamin.Close at clearchain.com (Benjamin Close) Date: Sun Jan 20 16:47:32 2008 Subject: cvs commit: src/share/misc pci_vendors In-Reply-To: <200801171929.m0HJT2kV027229@repoman.freebsd.org> References: <200801171929.m0HJT2kV027229@repoman.freebsd.org> Message-ID: <4793E7FF.5060009@clearchain.com> Doug Ambrisko wrote: > ambrisko 2008-01-17 19:29:02 UTC > > FreeBSD src repository > > Modified files: > share/misc pci_vendors > Log: > Correct that LSI 0060 is a mfi device and not mpt. > > Revision Changes Path > 1.37 +1 -1 src/share/misc/pci_vendors > You might want to inform one of the two sources that the vendors file is generated from, else next update this change will probably get clobbered. (See top of file) Cheers, Benjamin From sam at FreeBSD.org Sun Jan 20 20:13:01 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Sun Jan 20 20:13:05 2008 Subject: cvs commit: src/share/man/man4 axe.4 Message-ID: <200801210413.m0L4D1Hl064704@repoman.freebsd.org> sam 2008-01-21 04:13:01 UTC FreeBSD src repository Modified files: share/man/man4 axe.4 Log: updates for additional chip support Submitted by: "J.R. Oldroyd" MFC after: 2 weeks Revision Changes Path 1.15 +47 -10 src/share/man/man4/axe.4 From yongari at FreeBSD.org Sun Jan 20 20:23:51 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Sun Jan 20 20:23:55 2008 Subject: cvs commit: src/sys/dev/sf if_sf.c if_sfreg.h Message-ID: <200801210423.m0L4NorL066126@repoman.freebsd.org> yongari 2008-01-21 04:23:48 UTC FreeBSD src repository Modified files: sys/dev/sf if_sf.c if_sfreg.h Log: Forced commit to note that sf(4) was repocopied from sys/pci and modified for its new location. Revision Changes Path 1.97 +1 -1 src/sys/dev/sf/if_sf.c 1.20 +0 -0 src/sys/dev/sf/if_sfreg.h From yongari at FreeBSD.org Sun Jan 20 20:27:34 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Sun Jan 20 20:27:36 2008 Subject: cvs commit: src/sys/conf files src/sys/modules/sf Makefile Message-ID: <200801210427.m0L4RXbe066321@repoman.freebsd.org> yongari 2008-01-21 04:27:32 UTC FreeBSD src repository Modified files: sys/conf files sys/modules/sf Makefile Log: Update file list and Makefile after repocopying sf(4) from src/sys/pci to src/sys/dev. Revision Changes Path 1.1265 +1 -1 src/sys/conf/files 1.15 +1 -1 src/sys/modules/sf/Makefile From rafan at FreeBSD.org Sun Jan 20 20:41:20 2008 From: rafan at FreeBSD.org (Rong-En Fan) Date: Sun Jan 20 20:41:23 2008 Subject: cvs commit: src/etc rc.firewall src/etc/defaults rc.conf Message-ID: <200801210441.m0L4fJrK066916@repoman.freebsd.org> rafan 2008-01-21 04:41:18 UTC FreeBSD src repository Modified files: etc rc.firewall etc/defaults rc.conf Log: Improve kernel NAT support in rc.firewall - Allow IP in firewall_nat_interface, just like natd_interface - Allow additional configuration parameters passed to ipfw via firewall_nat_flags - Document firewall_nat_* in defaults/rc.conf Tested by: Albert B. Wang MFC after: 1 month Revision Changes Path 1.323 +3 -0 src/etc/defaults/rc.conf 1.54 +7 -1 src/etc/rc.firewall From yongari at FreeBSD.org Sun Jan 20 20:46:03 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Sun Jan 20 20:46:05 2008 Subject: cvs commit: src/sys/pci if_sf.c if_sfreg.h Message-ID: <200801210446.m0L4k2HZ067097@repoman.freebsd.org> yongari 2008-01-21 04:45:59 UTC FreeBSD src repository Removed files: sys/pci if_sf.c if_sfreg.h Log: sf(4) was repocopied to src/sys/dev/sf. Revision Changes Path 1.97 +0 -1604 src/sys/pci/if_sf.c (dead) 1.20 +0 -1059 src/sys/pci/if_sfreg.h (dead) From yongari at FreeBSD.org Sun Jan 20 21:02:56 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Sun Jan 20 21:02:58 2008 Subject: cvs commit: src/sys/dev/sf starfire_rx.h starfire_tx.h Message-ID: <200801210502.m0L52rR4076589@repoman.freebsd.org> yongari 2008-01-21 05:02:46 UTC FreeBSD src repository Added files: sys/dev/sf starfire_rx.h starfire_tx.h Log: Import AIC-6915 firmware for GFP from Adaptec. Special thanks to bruffer to send the firmware image to me. Submitted by: gibbs via bruffer Revision Changes Path 1.1 +118 -0 src/sys/dev/sf/starfire_rx.h (new) 1.1 +117 -0 src/sys/dev/sf/starfire_tx.h (new) From yongari at FreeBSD.org Sun Jan 20 21:09:09 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Sun Jan 20 21:09:14 2008 Subject: cvs commit: src/sys/dev/sf starfire_tx.h Message-ID: <200801210509.m0L598Xm077894@repoman.freebsd.org> yongari 2008-01-21 05:09:07 UTC FreeBSD src repository Modified files: sys/dev/sf starfire_tx.h Log: It seems that the firmware for TxGFP does not work at all. I could be wrong but I couldn't find a way to make it work. In addition, the number of TxGFP instruction does not match the firmware image size, so I guess something was wrong when Adaptec generated the TxGFP firmware from their DDK. According to datasheet, normally, the first GFP instruction would be opcode C, WaitForStartOfFrame, to synchronize checksumming with incoming frame. But the first instruction in TxGFP firmware was opcode 1, BrToImmIfTrue, so it could not process checksum correctly, I guess. Checking for RxGFP firmware also indicates the first instruction should be opcode C. Since the number of instructions in TxGFP firmware lacks exactly one instruction, I prepended the opcode C to TxGFP firmware image. With this change, the resulting image size perfectly matches with the nummber of instructions and Tx checksum offload seems to work without problems. Revision Changes Path 1.2 +1 -0 src/sys/dev/sf/starfire_tx.h From yongari at FreeBSD.org Sun Jan 20 22:38:24 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Sun Jan 20 22:38:26 2008 Subject: cvs commit: src/sys/dev/sf if_sf.c if_sfreg.h Message-ID: <200801210638.m0L6cOOZ080986@repoman.freebsd.org> yongari 2008-01-21 06:38:23 UTC FreeBSD src repository Modified files: sys/dev/sf if_sf.c if_sfreg.h Log: Overhaul sf(4) to make it run on all architectures and implement checksum offoload by downloading AIC-6915 firmware. Changes are o Header file cleanup. o Simplified probe logic. o s/u_int{8,16,32}_t/uint{8,16,32}_t/g o K&R -> ANSI C. o In register access function, added support both memory mapped and IO space register acccess. The function will dynamically detect which method would be choosed. o sf_setperf() was modified to support strict-alignment architectures. o Use SF_MII_DATAPORT instead of hardcoded value 0xffff. o Added link state/speed, duplex changes handling task q. The task q is also responsible for flow control settings. o Always hornor link up/down state reported by mii layers. The link state information is used in sf_start() to determine whether we got a valid link. o Added experimental flow-control setup. It was commented out but will be activated once we have flow-cotrol infrastructure in mii layer. o Simplify IFF_UP/IFCAP_POLLING and IFF_PROMISC handling logic. Rx filter always honors promiscuous mode. o Implemented suspend/resume methods. o Reorganized Rx filter routine so promiscuous mode changes doesn't require interface re-initialization. o Reimplemnted driver probe routine such that it looks for matching device from supported hardware list table. This change will help to add newer hardware revision to the driver. o Use ETHER_ADDR_LEN instead of hardcoded value. o Prefer memory space register mapping over I/O space as the hardware requires lots of register access to get various consumer/producer index. Failing to get memory space mapping, sf(4) falls back to I/O space mapping. Use of memory space register mapping requires somewhat large memory space(512K), though. o Switch to simpler bus_{read,write}_{1,2,4}. o Use PCIR_BAR macro to get BARs. o Program PCI cache line size if the cache line size was set to 0 and enable PCI MWI. o Add a new sysctl node 'dev.sf.N.stats' that shows various MAC counters for Rx/Tx statistics. o Add a sysctl node to configure interrupt moderation timer. The timer defers interrupts generation until time specified in timer control register is expired. The value in the timer register is in units of 102.4us. The allowable range for the timer is 0 - 31 (0 ~ 3.276ms). The default value is 1(102.4us). Users can change the timer value with dev.sf.N.int_mod sysctl(8) variable/loader(8) tunable. o bus_dma(9) conversion - Enable 64bit DMA addressing. - Enable 64bit descriptor format support. - Apply descriptor ring alignment requirements(256 bytes alignment). - Apply Rx buffer address alignment requirements(4 bytes alignment). - Apply 4GB boundary restrictions(Tx/Rx ring and its completion ring should live in the same 4GB address space.) - Set number of allowable number of DMA segments to 16. In fact, AIC-6915 doesn't have a limit for number of DMA segments but it would be waste of Tx descriptor resource if we allow more than 16. - Rx/Tx side bus_dmamap_load_mbuf_sg(9) support. - Added alignment fixup code for strict-alignment architectures. - Added endianness support code in Tx/Rx descriptor access. With these changes sf(4) should work on all platforms. o Don't set if_mtu in device attach, it's handled in ether_ifattach. o Use our own callout to drive watchdog timer. o Enable VLAN oversized frames and announce sf(4)'s VLAN capability to upper layer. o In sf_detach(), remove mtx_initialized KASSERT as it's not possible to get there without initialzing the mutex. Also mark that we're about to detaching so active bpf listeners do not panic the system. o To reduce PCI register access cycles, Rx completion ring is directly scanned instead of reading consumer/producer index registers. In theory, Tx completion ring also can be directly scanned. However the completion ring is composed of two types completion(1 for Tx done and 1 and DMA done). So reading producer index via register access would be more safer way to detect the ring wrap-around. o In sf_rxeof(), don't use m_devget(9) to align recevied frames. The alignment is required only for strict-alignment architectures and now the alignment is handled by sf_fixup_rx() if required. The removal of the copy operation in fast path should increase Rx performance a lot on non-strict-alignemnt architectures such as i386 and amd64. o In sf_newbuf(), don't set descriptor valid bit as sf(4) is programmed to run with normal mode. In normal mode, the valid bit have no meaning. The valid bit should be used only when the hardware uses polling(prefetch) mode. The end of descriptor queue bit could be used if needed, but sf(4) relys on auto-wrapping of hardware on 256 descriptor queue entries so both valid and descriptor end bit are not used anymore. o Don't disable generation of Tx DMA completion as said in datasheet and use the Tx DMA completion entry instead of relying on Tx done completion entry. Also added additional Tx completion entry type check in Tx completion handler. o Don't blindly reset watchdog timer in sf_txeof(). sf(4) now unarm the the watchdog only if there are no active Tx descriptors in Tx queue. o Don't manually update various counters in driver, instead, use built-in MAC statistic registers to update them. The statistic registers are updated in every second. o Modified Tx underrun handlers to increase the threshold value in units of 256 bytes. Previously it used to increase 16 bytes at a time which seems to take too long to stabalize whenever Tx underrun occurrs. o In interrupt handler, additional check for the interrupt is performed such that interrupts only for this device is allowed to process descriptor rings. Because reading SF_ISR register clears all interrtups, nuke writing to a SF_ISR register. o Tx underrun is abonormal condition and SF_ISR_ABNORMALINTR includes the interrupt. So there is no need to inspect the Tx underrun again in main interrupt loop. o Don't blindly reinitialize hardware for abnormal interrupt condition. sf(4) reintializes the hardware only when it encounters DMA error which requires an explicit hardware reinitialization. o Fix a long standing bug that incorrectly clears MAC statistic registers in sf_init_locked. o Added strict-alignment safe way of ethernet address reprogramming as IF_LLADDR may return unaligned address. o Move sf_reset() to sf_init_locked in order to always reset the hardware to a known state prior to configuring hardware. o Set default Rx DMA, Tx DMA paramters as shown in datasheet. o Enable PCI busmaster logic and autopadding for VLAN frames. o Rework sf_encap. - Previously sf(4) used to type 0 of Tx descriptor with padding enabled to store driver private data. Emebedding private data structures into descriptors is bad idea as the structure size would be different between 64bit and 32bit architectures. The type 0 descriptor allows fixed number of DMA segments in a descriptor format and provides relatively simple interface to manage multi-fragmented frames. However, it wastes lots of Tx descriptors as not all frames are fragmented as the number of allowable segments in a descriptor. - To overcome the limitation of type 0 descriptor, switch to type 2 descriptor which allows 64bit DMA addressing and can handle unliumited number of fragmented DMA segments. The drawback of type 2 descriptor is in its complexity in managing descriptors as driver should handle the end of Tx ring manually. - Manually set Tx desciptor queue end mark and record number of used descriptors to reclaim used descriptors in sf_txeof(). o Rework sf_start. - Honor link up/down state before attempting transmission. - Because sf(4) uses only one of two Tx queues, use low priority queue instead of high one. This will remove one shift operation in each Tx kick command. - Cache last produder index into softc such that subsequenet Tx operation doesn't need to access producer index register. o Rewrote sf_stats_update to include all available MAC statistic counters. o Employ AIC-6915 firmware from Adaptec and implement firmware download routine and TCP/UDP checksum offload. Partial checksum offload support was commented out due to the possibility of firmware bug in RxGFP. The firmware can strip VLAN tag in Rx path but the lack of firmware assistance of VLAN tag insertion in transmit side made it useless on FreeBSD. Unlike checksum offload, FreeBSD requires both Tx/Rx hardware VLAN assistance capability. The firmware may also detect wakeup frame and can wake system up from states other than D0. However, the lack of wakeup support form D3cold state keep me from adding WOL capability. Also detecting WOL frame requires firmware support but it's not yet known to me whether the firmware can process the WOL frame. o Changed *_ADDR_HIADDR to *_ADDR_HI to match other definitions of registers. o Added definitioan to interrupt moderation related constants. o Redefined SF_INTRS to include Tx DMA done and DMA errors. Removed Tx done as it's not needed anymore. o Added definition for Rx/Tx DMA high priority threshold. o Nuked unused marco SF_IDX_LO, SF_IDX_HI. o Added complete MAC statistic register definition. o Modified sf_stats structure to hold all MAC statistic regiters. o Nuke various driver private padding data in Tx/Rx descriptor definition. sf(4) no longer requires private padding. Also remove unused padding related definitions. This greatly simplifies descriptor manipulation on 64bit architectures. o Becase we no longer pad driver private data into descriptor, remove deprecated/not-applicable comments for padding. o Redefine Rx/Tx desciptor status. sf(4) doesn't use bit fileds anymore to support endianness. Tested by: bruffer (initial version) Revision Changes Path 1.98 +1814 -702 src/sys/dev/sf/if_sf.c 1.21 +312 -267 src/sys/dev/sf/if_sfreg.h From yongari at FreeBSD.org Sun Jan 20 22:47:23 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Sun Jan 20 22:47:24 2008 Subject: cvs commit: src/share/man/man4 vlan.4 Message-ID: <200801210647.m0L6lLhe081194@repoman.freebsd.org> yongari 2008-01-21 06:47:21 UTC FreeBSD src repository Modified files: share/man/man4 vlan.4 Log: sf(4) gained VLAN_MTU support. Touch Dd. Revision Changes Path 1.45 +2 -1 src/share/man/man4/vlan.4 From yongari at FreeBSD.org Sun Jan 20 22:51:26 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Sun Jan 20 22:51:28 2008 Subject: cvs commit: src/sys/sparc64/conf GENERIC Message-ID: <200801210651.m0L6pPIx081318@repoman.freebsd.org> yongari 2008-01-21 06:51:25 UTC FreeBSD src repository Modified files: sys/sparc64/conf GENERIC Log: Uncomment sf(4), sf(4) should work on all architectures. Revision Changes Path 1.131 +1 -1 src/sys/sparc64/conf/GENERIC From yongari at FreeBSD.org Sun Jan 20 23:35:15 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Sun Jan 20 23:35:20 2008 Subject: cvs commit: src/share/man/man4 sf.4 Message-ID: <200801210735.m0L7ZFWx086585@repoman.freebsd.org> yongari 2008-01-21 07:35:15 UTC FreeBSD src repository Modified files: share/man/man4 sf.4 Log: Document two new sysctl variables, dev.sf.%d.int_mod and dev.sf.%d.stats. Xref vlan(4). Touchd Dd. Reviewed by: brueffer Revision Changes Path 1.25 +19 -1 src/share/man/man4/sf.4 From brueffer at FreeBSD.org Mon Jan 21 01:00:11 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Mon Jan 21 01:00:16 2008 Subject: cvs commit: src/release/doc/share/misc dev.archlist.txt Message-ID: <200801210900.m0L90Aaq000667@repoman.freebsd.org> brueffer 2008-01-21 09:00:09 UTC FreeBSD src repository Modified files: release/doc/share/misc dev.archlist.txt Log: sf(4) should work on all archs now, remove it from here. Revision Changes Path 1.102 +0 -1 src/release/doc/share/misc/dev.archlist.txt From yongari at FreeBSD.org Mon Jan 21 01:51:29 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Mon Jan 21 01:51:34 2008 Subject: cvs commit: src/sys/dev/sf if_sf.c Message-ID: <200801210951.m0L9pSF6004821@repoman.freebsd.org> yongari 2008-01-21 09:51:28 UTC FreeBSD src repository Modified files: sys/dev/sf if_sf.c Log: Fix build. Revision Changes Path 1.99 +2 -2 src/sys/dev/sf/if_sf.c From des at des.no Mon Jan 21 04:44:56 2008 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Mon Jan 21 04:45:18 2008 Subject: cvs commit: src/contrib/openpam/include/security openpam_attr.h In-Reply-To: <200801191147.m0JBlbeI019947@repoman.freebsd.org> (Rong-En Fan's message of "Sat\, 19 Jan 2008 11\:47\:37 +0000 \(UTC\)") References: <200801191147.m0JBlbeI019947@repoman.freebsd.org> Message-ID: <86prvvxs8w.fsf@ds4.des.no> Rong-En Fan writes: > Added files: (Branch: RELENG_7) > contrib/openpam/include/security openpam_attr.h > Log: > - Add missing file for OpenPAM Hydrangea MFC Bugger. Of course, 'make world' worked fine before I committed, and I didn't notice that the new file wasn't included in the commit. Thank you for taking care of it. DES -- Dag-Erling Sm?rgrav - des@des.no From des at des.no Mon Jan 21 04:57:01 2008 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Mon Jan 21 04:57:10 2008 Subject: cvs commit: src/contrib/openpam/include/security openpam_attr.h In-Reply-To: <86prvvxs8w.fsf@ds4.des.no> ("Dag-Erling =?utf-8?Q?Sm=C3=B8rg?= =?utf-8?Q?rav=22's?= message of "Mon\, 21 Jan 2008 13\:44\:47 +0100") References: <200801191147.m0JBlbeI019947@repoman.freebsd.org> <86prvvxs8w.fsf@ds4.des.no> Message-ID: <86lk6jxroq.fsf@ds4.des.no> Dag-Erling Sm?rgrav writes: > Rong-En Fan writes: > > Added files: (Branch: RELENG_7) > > contrib/openpam/include/security openpam_attr.h > > Log: > > - Add missing file for OpenPAM Hydrangea MFC > Bugger. Of course, 'make world' worked fine before I committed, and I > didn't notice that the new file wasn't included in the commit. Thank > you for taking care of it. OK, this is very weird. I did a cvs up on the tree I committed from, and discovered that not only had openpam_attr.h been correctly 'cvs add'ed, but several other removed or added files were not committed: R contrib/openpam/MANIFEST A contrib/openpam/compile R contrib/openpam/configure.in R contrib/openpam/ltconfig R contrib/openpam/mkinstalldirs R contrib/openpam/stamp-h.in cvs update: conflict: contrib/openpam/include/security/openpam_attr.h created independently by second party C contrib/openpam/include/security/openpam_attr.h Fortunately, none of these (except opempam_attr.h) were important. There is something rotten in the state of CVS. I believe the command I used to commit was % fncvs commit -m contrib/openpam/commit-message contrib/openpam lib/libpam usr.sbin/ppp (where fncvs is an alias for 'cvs -z3 -d ncvs.freebsd.org:/home/ncvs') Apparently, it only committed modified files, not added or removed files. DES -- Dag-Erling Sm?rgrav - des@des.no From kib at FreeBSD.org Mon Jan 21 04:57:19 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Mon Jan 21 04:57:31 2008 Subject: cvs commit: src/sys/kern tty_pty.c Message-ID: <200801211257.m0LCvJNj030032@repoman.freebsd.org> kib 2008-01-21 12:57:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/kern tty_pty.c Log: MFC rev. 1.156: In the rev. 1.153, the one place for converting minor number to unit was missed. As result, pty_create_slave() may index out of the names[] bounds, creating wrong slave tty names. Approved by: re (kensmith) Revision Changes Path 1.152.2.2.2.1 +3 -1 src/sys/kern/tty_pty.c From ru at FreeBSD.org Mon Jan 21 05:26:33 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Mon Jan 21 05:26:44 2008 Subject: cvs commit: src/sys/pci amdsmb.c nfsmb.c Message-ID: <200801211326.m0LDQWgX033618@repoman.freebsd.org> ru 2008-01-21 13:26:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/pci amdsmb.c nfsmb.c Log: Add copyrights. PR: 119136 Revision Changes Path 1.4.2.1 +26 -0 src/sys/pci/amdsmb.c 1.6.2.2 +26 -0 src/sys/pci/nfsmb.c From ru at FreeBSD.org Mon Jan 21 05:26:34 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Mon Jan 21 05:26:49 2008 Subject: cvs commit: src/sys/pci amdsmb.c nfsmb.c Message-ID: <200801211326.m0LDQYRP033637@repoman.freebsd.org> ru 2008-01-21 13:26:34 UTC FreeBSD src repository Modified files: sys/pci amdsmb.c nfsmb.c Log: Add copyrights. PR: 119136 Revision Changes Path 1.5 +26 -0 src/sys/pci/amdsmb.c 1.8 +26 -0 src/sys/pci/nfsmb.c From bde at FreeBSD.org Mon Jan 21 05:46:21 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Mon Jan 21 05:46:28 2008 Subject: cvs commit: src/lib/msun/src s_log1pf.c Message-ID: <200801211346.m0LDkLmZ034746@repoman.freebsd.org> bde 2008-01-21 13:46:21 UTC FreeBSD src repository Modified files: lib/msun/src s_log1pf.c Log: Fix cutoffs. This is just a cleanup and an optimization for unusual cases which are used mainly by regression tests. As usual, the cutoff for tiny args was not correctly translated to float precision. It was 2**-54 but 2**-24 works. It must be about 2**-precision, since the error from approximating log(1+x) by x is about the same as |x|. Exhaustive testing shows that 2**-24 gives perfect rounding in round-to-nearest mode. Similarly for the cutoff for being small, except this is not used by so many other functions. It was 2**-29 but 2**-15 works. It must be a bit smaller than sqrt(2**-precision), since the error from approximating log(1+x) by x-x*x/2 is about the same as x*x. Exhaustive testing shows that 2**-15 gives a maximum error of 0.5052 ulps in round-to-nearest-mode. The algorithm for the general case is only good for 0.8388 ulps, so this is sufficient (but it loses slightly on i386 -- then extra precision gives 0.5032 ulps for the general case). While investigating this, I noticed that optimizing the usual case by falling into a middle case involving a simple polynomial evaluation (return x-x*x/2 instead of x here) is not such a good idea since it gives an enormous pessimization of tinier args on machines for which denormals are slow. Float x*x/2 is denormal when |x| ~< 2**-64 and x*x/2 is evaluated in float precision, so it can easily be denormal for normal x. This is even more interesting for general polynomial evaluations. Multiplying out large powers of x is normally a good optimization since it reduces dependencies, but it creates denormals starting with quite large x. Revision Changes Path 1.11 +2 -2 src/lib/msun/src/s_log1pf.c From jhb at freebsd.org Mon Jan 21 07:07:54 2008 From: jhb at freebsd.org (John Baldwin) Date: Mon Jan 21 07:08:06 2008 Subject: cvs commit: src/sys/sys user.h src/sys/kern kern_descrip.c In-Reply-To: <200801201955.m0KJtr2m094245@repoman.freebsd.org> References: <200801201955.m0KJtr2m094245@repoman.freebsd.org> Message-ID: <200801210930.56939.jhb@freebsd.org> On Sunday 20 January 2008 02:55:52 pm Robert Watson wrote: > rwatson 2008-01-20 19:55:52 UTC > > FreeBSD src repository > > Modified files: > sys/sys user.h > sys/kern kern_descrip.c > Log: > Export a type for POSIX SHM file descriptors via kern.proc.filedesc as > used by procstat, or SHM descriptors will show up as type unknown in > userspace. Oops, thanks for fixing. -- John Baldwin From jhb at freebsd.org Mon Jan 21 07:07:56 2008 From: jhb at freebsd.org (John Baldwin) Date: Mon Jan 21 07:08:07 2008 Subject: cvs commit: src/contrib/openpam/include/security openpam_attr.h In-Reply-To: <86lk6jxroq.fsf@ds4.des.no> References: <200801191147.m0JBlbeI019947@repoman.freebsd.org> <86prvvxs8w.fsf@ds4.des.no> <86lk6jxroq.fsf@ds4.des.no> Message-ID: <200801210935.45997.jhb@freebsd.org> On Monday 21 January 2008 07:56:53 am Dag-Erling Sm?rgrav wrote: > Dag-Erling Sm?rgrav writes: > > Rong-En Fan writes: > > > Added files: (Branch: RELENG_7) > > > contrib/openpam/include/security openpam_attr.h > > > Log: > > > - Add missing file for OpenPAM Hydrangea MFC > > Bugger. Of course, 'make world' worked fine before I committed, and I > > didn't notice that the new file wasn't included in the commit. Thank > > you for taking care of it. > > OK, this is very weird. > > I did a cvs up on the tree I committed from, and discovered that not > only had openpam_attr.h been correctly 'cvs add'ed, but several other > removed or added files were not committed: > > R contrib/openpam/MANIFEST > A contrib/openpam/compile > R contrib/openpam/configure.in > R contrib/openpam/ltconfig > R contrib/openpam/mkinstalldirs > R contrib/openpam/stamp-h.in > cvs update: conflict: contrib/openpam/include/security/openpam_attr.h created independently by second party > C contrib/openpam/include/security/openpam_attr.h > > Fortunately, none of these (except opempam_attr.h) were important. > > There is something rotten in the state of CVS. > > I believe the command I used to commit was > > % fncvs commit -m contrib/openpam/commit-message contrib/openpam lib/libpam usr.sbin/ppp > > (where fncvs is an alias for 'cvs -z3 -d ncvs.freebsd.org:/home/ncvs') > > Apparently, it only committed modified files, not added or removed > files. Are you running HEAD with the recent CVS import? It appears to have introduced at least one other bug as well (a duplicate free() bug was reported on the lists as a regression). -- John Baldwin From des at des.no Mon Jan 21 07:51:35 2008 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Mon Jan 21 07:51:43 2008 Subject: cvs commit: src/contrib/openpam/include/security openpam_attr.h In-Reply-To: <200801210935.45997.jhb@freebsd.org> (John Baldwin's message of "Mon\, 21 Jan 2008 09\:35\:45 -0500") References: <200801191147.m0JBlbeI019947@repoman.freebsd.org> <86prvvxs8w.fsf@ds4.des.no> <86lk6jxroq.fsf@ds4.des.no> <200801210935.45997.jhb@freebsd.org> Message-ID: <86myqzmb2a.fsf@ds4.des.no> John Baldwin writes: > Dag-Erling Sm?rgrav writes: > > [CVS did not commit added / removed files] > Are you running HEAD with the recent CVS import? HEAD from December 6. DES -- Dag-Erling Sm?rgrav - des@des.no From des at FreeBSD.org Mon Jan 21 08:12:08 2008 From: des at FreeBSD.org (Dag-Erling Smorgrav) Date: Mon Jan 21 08:12:10 2008 Subject: cvs commit: src/contrib/openpam MANIFEST compile configure.in ltconfig mkinstalldirs stamp-h.in Message-ID: <200801211612.m0LGC60o047403@repoman.freebsd.org> des 2008-01-21 16:12:05 UTC FreeBSD src repository Added files: (Branch: RELENG_7) contrib/openpam compile Removed files: (Branch: RELENG_7) contrib/openpam MANIFEST configure.in ltconfig mkinstalldirs stamp-h.in Log: Final part of the OpenPAM MFC which CVS botched. Revision Changes Path 1.1.1.15.10.1 +0 -173 src/contrib/openpam/MANIFEST (dead) 1.1.1.1.2.1 +142 -0 src/contrib/openpam/compile (new) 1.1.1.2.18.1 +0 -99 src/contrib/openpam/configure.in (dead) 1.1.1.1.20.1 +0 -3132 src/contrib/openpam/ltconfig (dead) 1.1.1.1.20.1 +0 -40 src/contrib/openpam/mkinstalldirs (dead) 1.1.1.2.18.1 +0 -1 src/contrib/openpam/stamp-h.in (dead) From jkim at FreeBSD.org Mon Jan 21 09:17:01 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Mon Jan 21 09:17:07 2008 Subject: cvs commit: src/sys/dev/bge if_bge.c Message-ID: <200801211717.m0LHH1AZ067646@repoman.freebsd.org> jkim 2008-01-21 17:17:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/bge if_bge.c Log: MFC: 1.201 Fix mbuf pool watermark configuration. Revision Changes Path 1.198.2.3 +1 -1 src/sys/dev/bge/if_bge.c From kensmith at FreeBSD.org Mon Jan 21 09:25:50 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Mon Jan 21 09:26:14 2008 Subject: cvs commit: src/release fixit.profile Message-ID: <200801211725.m0LHPnTF067991@repoman.freebsd.org> kensmith 2008-01-21 17:25:49 UTC FreeBSD src repository Modified files: release fixit.profile Log: Adjust paths for EDITOR and PAGER environment variables in the fixit shell. This would break them for floppy based fixit mode which still seems to use /stand except that vi(1) and more(1) don't exist in /stand on the fixit floppy so it really doesn't matter what these settings are there. These paths work for CD-based fixit mode. This is just "temporary" and on its way to 7.0-REL. I'm too chicken to make what is probably the correct adjustment this close to release. It seems /mnt2 is just a symbolic link, and stuff really gets mounted as /dist. Adjusting paths to that for 8.X is probably the right thing to do and I'll try that after 7.0 is done. Noticed by: gallatin MFC after: 1 day Revision Changes Path 1.12 +2 -2 src/release/fixit.profile From jkim at FreeBSD.org Mon Jan 21 10:04:42 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Mon Jan 21 10:04:46 2008 Subject: cvs commit: src/sys/dev/bge if_bge.c Message-ID: <200801211804.m0LI4fKP079117@repoman.freebsd.org> jkim 2008-01-21 18:04:41 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/bge if_bge.c Log: MFC: 1.201 Fix mbuf pool watermark configuration. Revision Changes Path 1.91.2.24 +1 -1 src/sys/dev/bge/if_bge.c From obrien at FreeBSD.org Mon Jan 21 10:44:56 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Mon Jan 21 10:45:02 2008 Subject: cvs commit: src Makefile.inc1 src/tools/build Makefile Message-ID: <200801211844.m0LIiufY081896@repoman.freebsd.org> obrien 2008-01-21 18:44:55 UTC FreeBSD src repository Modified files: . Makefile.inc1 tools/build Makefile Log: Remove 5.x and 6.x cruft - source upgrades to RELENG_8 from versions prior to RELENG_7 are not supported. Revision Changes Path 1.593 +0 -28 src/Makefile.inc1 1.13 +0 -5 src/tools/build/Makefile From brueffer at FreeBSD.org Mon Jan 21 10:47:38 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Mon Jan 21 10:47:41 2008 Subject: cvs commit: src/tools/build/mk OptionalObsoleteFiles.inc Message-ID: <200801211847.m0LIlc50082034@repoman.freebsd.org> brueffer 2008-01-21 18:47:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) tools/build/mk OptionalObsoleteFiles.inc Log: MFC: rev. 1.12 Remove files conditional on the obsolete MK_FORTRAN knob. They are already listed in ObsoleteFiles.inc anyway. Approved by: rwatson (mentor) Revision Changes Path 1.11.2.1 +0 -12 src/tools/build/mk/OptionalObsoleteFiles.inc From brueffer at FreeBSD.org Mon Jan 21 10:49:06 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Mon Jan 21 10:49:11 2008 Subject: cvs commit: src Makefile.inc1 Message-ID: <200801211849.m0LIn5UR082095@repoman.freebsd.org> brueffer 2008-01-21 18:49:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) . Makefile.inc1 Log: MFC: rev. 1.592 Remove WITHOUT_FORTRAN from the XMAKE target, it doesn't exist anymore. Approved by: rwatson (mentor) Revision Changes Path 1.588.2.3 +1 -1 src/Makefile.inc1 From brueffer at FreeBSD.org Mon Jan 21 10:50:21 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Mon Jan 21 10:50:27 2008 Subject: cvs commit: src/share/mk bsd.own.mk Message-ID: <200801211850.m0LIoKkm082210@repoman.freebsd.org> brueffer 2008-01-21 18:50:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/mk bsd.own.mk Log: MFC: rev. 1.72 Remove remnants of old *_FORTRAN build flags. Approved by: rwatson (mentor) Revision Changes Path 1.67.2.3 +0 -2 src/share/mk/bsd.own.mk From brueffer at FreeBSD.org Mon Jan 21 11:52:17 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Mon Jan 21 11:52:24 2008 Subject: cvs commit: src/share/man/man7 ports.7 Message-ID: <200801211952.m0LJqHgR087689@repoman.freebsd.org> brueffer 2008-01-21 19:52:16 UTC FreeBSD src repository Modified files: share/man/man7 ports.7 Log: Document the 'maintainer' target. PR: 119699 Submitted by: Warren Block MFC after: 3 days Revision Changes Path 1.65 +3 -1 src/share/man/man7/ports.7 From rwatson at FreeBSD.org Mon Jan 21 13:19:10 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Mon Jan 21 13:19:17 2008 Subject: cvs commit: src/sys/fs/coda coda_vnops.c Message-ID: <200801212119.m0LLJ9wd004882@repoman.freebsd.org> rwatson 2008-01-21 21:19:08 UTC FreeBSD src repository Modified files: sys/fs/coda coda_vnops.c Log: Replace references to VOP_LOCK() w/o LK_RETRY to vn_lock() with LK_RETRY, avoiding extra error handling, or in some cases, missing error handling. MFC after: 3 days Discussed with: kib Revision Changes Path 1.84 +4 -14 src/sys/fs/coda/coda_vnops.c From des at des.no Mon Jan 21 13:23:20 2008 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Mon Jan 21 13:23:24 2008 Subject: cvs commit: src/contrib/cvs/src log.c In-Reply-To: <200801130608.m0D68oPe086845@repoman.freebsd.org> (David E. O'Brien's message of "Sun\, 13 Jan 2008 06\:08\:50 +0000 \(UTC\)") References: <200801130608.m0D68oPe086845@repoman.freebsd.org> Message-ID: <86prvu7u0w.fsf@ds4.des.no> "David E. O'Brien" writes: > Log: > Merge rev 1.3 ('-n' option) & rev. 1.2 ("iso8601" option keyword) > into version 1.11.22. Speaking of which, it's about time we flipped the iso8601 switch for ncvs... DES -- Dag-Erling Sm?rgrav - des@des.no From rwatson at FreeBSD.org Mon Jan 21 13:39:10 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Mon Jan 21 13:39:11 2008 Subject: cvs commit: src/sys/fs/coda coda_vnops.c Message-ID: <200801212139.m0LLd9qR005913@repoman.freebsd.org> rwatson 2008-01-21 21:39:09 UTC FreeBSD src repository Modified files: sys/fs/coda coda_vnops.c Log: Put "coda_rdwr: Internally Opening" printf generated by in-kernel writes to files, such as ktrace output, under CODA_VERBOSE. Otherwise, each such call to VOP_WRITE() results in a kernel printf. MFC after: 3 days Obtained from: NetBSD Revision Changes Path 1.85 +2 -0 src/sys/fs/coda/coda_vnops.c From brueffer at FreeBSD.org Mon Jan 21 13:56:03 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Mon Jan 21 13:56:15 2008 Subject: cvs commit: src/share/man/man5 src.conf.5 src/tools/build/options WITHOUT_FORTRAN Message-ID: <200801212156.m0LLu3N6006744@repoman.freebsd.org> brueffer 2008-01-21 21:56:02 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) share/man/man5 src.conf.5 Removed files: (Branch: RELENG_7_0) tools/build/options WITHOUT_FORTRAN Log: MFC: WITHOUT_FORTRAN was removed some time ago. Regen src.conf.5. Approved by: re (kensmith), rwatson (mentor) Revision Changes Path 1.18.2.2.2.1 +3 -8 src/share/man/man5/src.conf.5 1.1.4.1 +0 -4 src/tools/build/options/WITHOUT_FORTRAN (dead) From brueffer at FreeBSD.org Mon Jan 21 13:58:56 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Mon Jan 21 13:59:02 2008 Subject: cvs commit: src Makefile.inc1 Message-ID: <200801212158.m0LLwugG007161@repoman.freebsd.org> brueffer 2008-01-21 21:58:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) . Makefile.inc1 Log: MFC: rev. 1.592 Remove WITHOUT_FORTRAN from the XMAKE target, it doesn't exist anymore. Approved by: re (kensmith), rwatson (mentor) Revision Changes Path 1.588.2.2.2.2 +1 -1 src/Makefile.inc1 From brueffer at FreeBSD.org Mon Jan 21 14:00:26 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Mon Jan 21 14:00:34 2008 Subject: cvs commit: src/share/mk bsd.own.mk Message-ID: <200801212200.m0LM0QTH007405@repoman.freebsd.org> brueffer 2008-01-21 22:00:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) share/mk bsd.own.mk Log: MFC: rev. 1.72 Remove remnants of old *_FORTRAN build flags. Approved by: re (kensmith), rwatson (mentor) Revision Changes Path 1.67.2.2.2.1 +0 -2 src/share/mk/bsd.own.mk From brueffer at FreeBSD.org Mon Jan 21 14:02:22 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Mon Jan 21 14:02:27 2008 Subject: cvs commit: src/tools/build/mk OptionalObsoleteFiles.inc Message-ID: <200801212202.m0LM2LeP007522@repoman.freebsd.org> brueffer 2008-01-21 22:02:21 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) tools/build/mk OptionalObsoleteFiles.inc Log: MFC: rev. 1.12 Remove files conditional on the obsolete MK_FORTRAN knob. They are already listed in ObsoleteFiles.inc anyway. Approved by: re (kensmith), rwatson (mentor) Revision Changes Path 1.11.4.1 +0 -12 src/tools/build/mk/OptionalObsoleteFiles.inc From imp at FreeBSD.org Mon Jan 21 14:04:38 2008 From: imp at FreeBSD.org (Warner Losh) Date: Mon Jan 21 14:04:40 2008 Subject: cvs commit: src UPDATING Message-ID: <200801212204.m0LM4brH008746@repoman.freebsd.org> imp 2008-01-21 22:04:37 UTC FreeBSD src repository Modified files: . UPDATING Log: Note change in the supported upgrade path. Prior to this 5.3-release and newer were supported upgrade paths to -current. After today's commits, 6.0-RELEASE and newer is supported for jumping to current. Make that clear in the UPDATING entry. For the pedants out there, upgrading from FreeBSD_version 600029 and newer should still work. This represents a point from May 29, 2005 forward. The prior date was October 16th 2004. Revision Changes Path 1.514 +8 -0 src/UPDATING From trhodes at FreeBSD.org Mon Jan 21 14:08:06 2008 From: trhodes at FreeBSD.org (Tom Rhodes) Date: Mon Jan 21 14:08:08 2008 Subject: cvs commit: src/usr.bin/mt mt.1 Message-ID: <200801212208.m0LM86Z4008940@repoman.freebsd.org> trhodes 2008-01-21 22:08:06 UTC FreeBSD src repository Modified files: usr.bin/mt mt.1 Log: Note what options are only for DDS drives. PR: 35608 Revision Changes Path 1.45 +4 -4 src/usr.bin/mt/mt.1 From imp at bsdimp.com Mon Jan 21 14:16:30 2008 From: imp at bsdimp.com (M. Warner Losh) Date: Mon Jan 21 14:16:34 2008 Subject: cvs commit: src Makefile.inc1 src/tools/build Makefile In-Reply-To: <200801211844.m0LIiufY081896@repoman.freebsd.org> References: <200801211844.m0LIiufY081896@repoman.freebsd.org> Message-ID: <20080121.151417.1106074095.imp@bsdimp.com> In message: <200801211844.m0LIiufY081896@repoman.freebsd.org> "David E. O'Brien" writes: : Remove 5.x and 6.x cruft - source upgrades to RELENG_8 from versions prior : to RELENG_7 are not supported. I've just committed an updating entry for this change. The commit message has a typo in it. It should read "versions prior to RELENG_6" rather than RELENG_7. This means we support people back just under 3 years (May 2005: 2 years 8 months) rather than the little over 3 years we did before (Oct 2004 3 years 3 months). FreeBSD_vesrion 600029 and newer will work. So this delta pushes back things forward only about 8 months. Warner From trhodes at FreeBSD.org Mon Jan 21 15:09:20 2008 From: trhodes at FreeBSD.org (Tom Rhodes) Date: Mon Jan 21 15:09:21 2008 Subject: cvs commit: src/sbin/natd natd.8 Message-ID: <200801212309.m0LN9IjR022254@repoman.freebsd.org> trhodes 2008-01-21 23:09:18 UTC FreeBSD src repository Modified files: sbin/natd natd.8 Log: Note that the punch_fw option does not work in securelevel 3 and Xref init.8. Bump .Dd. PR: 41807 Revision Changes Path 1.66 +6 -1 src/sbin/natd/natd.8 From ache at FreeBSD.org Mon Jan 21 15:48:14 2008 From: ache at FreeBSD.org (Andrey A. Chernov) Date: Mon Jan 21 15:48:20 2008 Subject: cvs commit: src/lib/libc/locale Makefile.inc ascii.c mblocal.h setrunelocale.c Message-ID: <200801212348.m0LNmDCD026644@repoman.freebsd.org> ache 2008-01-21 23:48:13 UTC FreeBSD src repository Modified files: lib/libc/locale Makefile.inc mblocal.h setrunelocale.c Added files: lib/libc/locale ascii.c Log: Introduce new encoding: "ASCII" It differs from default C/POSIX "NONE" mainly by stricter 8bit check for mb*towc*/wc*tomb* family, returning EILSEQ Revision Changes Path 1.62 +1 -1 src/lib/libc/locale/Makefile.inc 1.1 +187 -0 src/lib/libc/locale/ascii.c (new) 1.7 +1 -0 src/lib/libc/locale/mblocal.h 1.48 +2 -0 src/lib/libc/locale/setrunelocale.c From brooks at FreeBSD.org Mon Jan 21 15:54:58 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Mon Jan 21 15:55:00 2008 Subject: cvs commit: src/sbin/dhclient dhclient-script Message-ID: <200801212354.m0LNsv3N026933@repoman.freebsd.org> brooks 2008-01-21 23:54:57 UTC FreeBSD src repository Modified files: sbin/dhclient dhclient-script Log: During PREINIT, when giving the interface the address 0.0.0.0, do it as an alias to avoid distrubing other addresses. PR: bin/119255 Submitted by: Jaakko Heinonen Revision Changes Path 1.18 +1 -1 src/sbin/dhclient/dhclient-script From rwatson at FreeBSD.org Mon Jan 21 15:59:24 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Mon Jan 21 15:59:30 2008 Subject: cvs commit: src/share/man/man4 Makefile coda.4 Message-ID: <200801212359.m0LNxNvN027130@repoman.freebsd.org> rwatson 2008-01-21 23:59:23 UTC FreeBSD src repository Modified files: share/man/man4 Makefile Added files: share/man/man4 coda.4 Log: Add a rather basic man page for the coda kernel module. MFC after: 3 days Revision Changes Path 1.403 +1 -0 src/share/man/man4/Makefile 1.1 +82 -0 src/share/man/man4/coda.4 (new) From ache at FreeBSD.org Mon Jan 21 16:05:07 2008 From: ache at FreeBSD.org (Andrey A. Chernov) Date: Mon Jan 21 16:05:13 2008 Subject: cvs commit: src/usr.bin/mklocale mklocale.1 yacc.y Message-ID: <200801220005.m0M056LN028605@repoman.freebsd.org> ache 2008-01-22 00:04:52 UTC FreeBSD src repository Modified files: usr.bin/mklocale mklocale.1 yacc.y Log: Understand newly introduced "ASCII" encoding Revision Changes Path 1.28 +2 -0 src/usr.bin/mklocale/mklocale.1 1.28 +1 -0 src/usr.bin/mklocale/yacc.y From rwatson at FreeBSD.org Mon Jan 21 16:32:55 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Mon Jan 21 16:33:01 2008 Subject: cvs commit: src/sys/fs/coda cnode.h coda_namecache.h coda_psdev.c coda_vfsops.c coda_vnops.c Message-ID: <200801220032.m0M0Wt3x031184@repoman.freebsd.org> rwatson 2008-01-22 00:32:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/fs/coda cnode.h coda_namecache.h coda_psdev.c coda_vfsops.c coda_vnops.c Log: Merge a variety of Coda fixes from HEAD to RELENG_7: coda_vnops.c:1.79: Borrow the VM object associated with an underlying cache vnode with the Coda vnode derived from it, in the style of nullfs. This allows files in the Coda file system to be memory-mapped, such as with execve(2) or mmap(2). Reported by: Rune coda_vnops.c:1.80: Lock the new directory vnode returned by coda_mkdir(), as this is required by FreeBSD's vnode locking protocol. coda_vnops.c:1.81: Use VOP_NULL rather than VOP_PANIC for Coda's vop_print routine, so as to avoid panicking in DDB show lockedvnods. cnode.h:1.22, coda_namecache.h:1.12, coda_psdev.c:1.40, coda_vfsops.c:1.70: Don't declare functions as extern. Move all extern variable definitions to associated .h files, move some extern variable definitions between include files to place them more appropriately. coda_vnops.c:1.82: Don't acquire an additional vnode reference to a vnode when it is opened and then release it when it is closed: we rely on the caller to keep the vnode around with a valid reference. This avoids vrele() destroying the vnode vop_close() is being called from during a call to vop_close(), and a crash due to lockmgr recursing the vnode lock when a Coda unmount occurs. coda_vfsops.c:1.71: Zero mi_rotovp and coda_ctlvp immediately after calling vrele() on the vnodes during coda_unmount() in order to detect errant use of them after the vnode references may no longer be valid. No need to clear the VV_ROOT flag on mi_rootvp flag (especially after the vnode reference is no longer valid) as this isn't done on other file systems. coda_vfsops.c: Rework coda_statfs(): no longer need to zero the statfs structure or fill out all fields, just fill out the ones the file system knows about. Among other things, this causes the outpuf of "mount" and "df" to make quite a bit more sense as /dev/cfs0 is specified as the mountfrom name. coda_vnops.c:1.83: Improve default vnode operation handling for Coda: - Don't specify vnode operations for mknod, lease, and advlock--let them fall through to vop_default. - Implement vop_default with &default_vnodeops, rather than with VOP_PANIC, so that unimplemented vnode operations are handled in more sensible ways than panicking, such as EOPNOTSUPP on ACL queries generated by bsdtar, or mknod. coda_namecache.h:1.13: Remove unused oldhash definition from Coda namecache. coda_vnops.c:1.84: Replace references to VOP_LOCK() w/o LK_RETRY to vn_lock() with LK_RETRY, avoiding extra error handling, or in some cases, missing error handling. Discussed with: kib coda_vnops.c:1.85: Put "coda_rdwr: Internally Opening" printf generated by in-kernel writes to files, such as ktrace output, under CODA_VERBOSE. Otherwise, each such call to VOP_WRITE() results in a kernel printf. Obtained from: NetBSD Revision Changes Path 1.21.2.1 +0 -6 src/sys/fs/coda/cnode.h 1.11.2.1 +22 -20 src/sys/fs/coda/coda_namecache.h 1.39.2.1 +0 -3 src/sys/fs/coda/coda_psdev.c 1.67.2.1 +4 -13 src/sys/fs/coda/coda_vfsops.c 1.76.2.1 +15 -23 src/sys/fs/coda/coda_vnops.c From kientzle at FreeBSD.org Mon Jan 21 23:23:44 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Mon Jan 21 23:23:46 2008 Subject: cvs commit: src/usr.bin/tar bsdtar.1 bsdtar.c Message-ID: <200801220723.m0M7NiVW081471@repoman.freebsd.org> kientzle 2008-01-22 07:23:44 UTC FreeBSD src repository Modified files: usr.bin/tar bsdtar.1 bsdtar.c Log: Make -l always have the SUSv2 meaning of "check links." GNU tar changed -l to match SUSv2 a couple of years ago, so bsdtar no longer needs to pander to this particular GNUism. Thanks to: Debian maintainers MFC after: 7 days Revision Changes Path 1.37 +8 -17 src/usr.bin/tar/bsdtar.1 1.79 +3 -13 src/usr.bin/tar/bsdtar.c From brueffer at FreeBSD.org Mon Jan 21 23:40:22 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Mon Jan 21 23:40:29 2008 Subject: cvs commit: src/share/man/man4 coda.4 Message-ID: <200801220740.m0M7eLhX082164@repoman.freebsd.org> brueffer 2008-01-22 07:40:21 UTC FreeBSD src repository Modified files: share/man/man4 coda.4 Log: Small fixes. Revision Changes Path 1.2 +2 -2 src/share/man/man4/coda.4 From jeremie at le-hen.org Tue Jan 22 01:00:31 2008 From: jeremie at le-hen.org (Jeremie Le Hen) Date: Tue Jan 22 01:00:48 2008 Subject: cvs commit: src/contrib/cvs/src log.c In-Reply-To: <86prvu7u0w.fsf@ds4.des.no> References: <200801130608.m0D68oPe086845@repoman.freebsd.org> <86prvu7u0w.fsf@ds4.des.no> Message-ID: <20080122083944.GB73672@obiwan.tataz.chchile.org> Hi, On Mon, Jan 21, 2008 at 10:23:11PM +0100, Dag-Erling Sm?rgrav wrote: > "David E. O'Brien" writes: > > Log: > > Merge rev 1.3 ('-n' option) & rev. 1.2 ("iso8601" option keyword) > > into version 1.11.22. > > Speaking of which, it's about time we flipped the iso8601 switch for > ncvs... Do you have some pointers about this point of history? Thank you. Regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org > From des at des.no Tue Jan 22 02:42:05 2008 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Tue Jan 22 02:42:15 2008 Subject: cvs commit: src/contrib/cvs/src log.c In-Reply-To: <20080122083944.GB73672@obiwan.tataz.chchile.org> (Jeremie Le Hen's message of "Tue\, 22 Jan 2008 09\:39\:44 +0100") References: <200801130608.m0D68oPe086845@repoman.freebsd.org> <86prvu7u0w.fsf@ds4.des.no> <20080122083944.GB73672@obiwan.tataz.chchile.org> Message-ID: <864pd65eh6.fsf@ds4.des.no> Jeremie Le Hen writes: > Dag-Erling Sm?rgrav writes: > > Speaking of which, it's about time we flipped the iso8601 switch for > > ncvs... > Do you have some pointers about this point of history? Huh? CVS uses a non-standard time format (which IIRC has changed over time) in "cvs log" output and Id tags. In 2004, I patched our version to optionally use an ISO 8601 format instead, but didn't make it the default, and enabled it only in projcvs as an experiment. There hasn't been any trouble with it for years, so it should be safe to enable it on [dnp]cvs as well. At the same time, I patched log_accum.pl to output dates in ISO 8601 format, as you can see from the commit emails. DES -- Dag-Erling Sm?rgrav - des@des.no From keramida at FreeBSD.org Tue Jan 22 03:18:52 2008 From: keramida at FreeBSD.org (Giorgos Keramidas) Date: Tue Jan 22 03:18:54 2008 Subject: cvs commit: src/usr.sbin/iostat iostat.c Message-ID: <200801221118.m0MBIpN4020184@repoman.freebsd.org> keramida 2008-01-22 11:18:51 UTC FreeBSD src repository (doc committer) Modified files: usr.sbin/iostat iostat.c Log: Repeat iostat header after rows-3 instead of a hardcoded 20. Use ioctl() to get the window size in iostat(8), and force a new header to be prepended to the output every time the current window size changes. Change the number of lines before each header to `rows - 3' when the terminal is resized, so that the full terminal length can be used for output lines. PR: bin/119705 Submitted by: keramida Approved by: maxim MFC after: 2 weeks Revision Changes Path 1.40 +71 -3 src/usr.sbin/iostat/iostat.c From rwatson at FreeBSD.org Tue Jan 22 04:10:27 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Tue Jan 22 04:10:34 2008 Subject: cvs commit: src/share/man/man4 coda.4 In-Reply-To: <200801220740.m0M7eLhX082164@repoman.freebsd.org> References: <200801220740.m0M7eLhX082164@repoman.freebsd.org> Message-ID: <20080122121007.S65035@fledge.watson.org> On Tue, 22 Jan 2008, Christian Brueffer wrote: > brueffer 2008-01-22 07:40:21 UTC > > FreeBSD src repository > > Modified files: > share/man/man4 coda.4 > Log: > Small fixes. Thanks! I'll be sure to MFC them with the man page when I do the MFC. Robert N M Watson Computer Laboratory University of Cambridge From trhodes at FreeBSD.org Tue Jan 22 04:23:31 2008 From: trhodes at FreeBSD.org (Tom Rhodes) Date: Tue Jan 22 04:23:37 2008 Subject: cvs commit: src/share/man/man7 ports.7 Message-ID: <200801221223.m0MCNVEN025468@repoman.freebsd.org> trhodes 2008-01-22 12:23:30 UTC FreeBSD src repository Modified files: share/man/man7 ports.7 Log: The config-recursive target is not run during the normal install process, move it down to where it belongs. Document 'all-depends-list' target and bump doc date. PR: 119519 Submitted by: Yuri Pankov Reviewed by: flz Revision Changes Path 1.66 +8 -6 src/share/man/man7/ports.7 From trhodes at FreeBSD.org Tue Jan 22 07:05:28 2008 From: trhodes at FreeBSD.org (Tom Rhodes) Date: Tue Jan 22 07:05:32 2008 Subject: cvs commit: src UPDATING Message-ID: <200801221505.m0MF5OGD047996@repoman.freebsd.org> trhodes 2008-01-22 15:05:22 UTC FreeBSD src repository Modified files: . UPDATING Log: Quick note on how to disable malloc debugging in the top entry in this file. PR: 83621 Submitted by: Scott Robbins (original version) Reviewed by: imp Revision Changes Path 1.515 +2 -1 src/UPDATING From ru at FreeBSD.ORG Tue Jan 22 07:54:34 2008 From: ru at FreeBSD.ORG (Ruslan Ermilov) Date: Tue Jan 22 07:54:39 2008 Subject: cvs commit: src Makefile.inc1 src/tools/build Makefile In-Reply-To: <20080121.151417.1106074095.imp@bsdimp.com> References: <200801211844.m0LIiufY081896@repoman.freebsd.org> <20080121.151417.1106074095.imp@bsdimp.com> Message-ID: <20080122155427.GB16573@team.vega.ru> Hi, On Mon, Jan 21, 2008 at 03:14:17PM -0700, M. Warner Losh wrote: > In message: <200801211844.m0LIiufY081896@repoman.freebsd.org> > "David E. O'Brien" writes: > : Remove 5.x and 6.x cruft - source upgrades to RELENG_8 from versions prior > : to RELENG_7 are not supported. > > I've just committed an updating entry for this change. The commit > message has a typo in it. It should read "versions prior to RELENG_6" > rather than RELENG_7. Both messages are bad, because RELENG_[67] are floating targets. > This means we support people back just under 3 > years (May 2005: 2 years 8 months) rather than the little over 3 years > we did before (Oct 2004 3 years 3 months). FreeBSD_vesrion 600029 and > newer will work. So this delta pushes back things forward only about > 8 months. I only wonder how was the value of 600029 choosen? Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer From trhodes at FreeBSD.org Tue Jan 22 07:56:49 2008 From: trhodes at FreeBSD.org (Tom Rhodes) Date: Tue Jan 22 07:56:52 2008 Subject: cvs commit: src/lib/libc/sys flock.2 Message-ID: <200801221556.m0MFunv3052168@repoman.freebsd.org> trhodes 2008-01-22 15:56:49 UTC FreeBSD src repository Modified files: lib/libc/sys flock.2 Log: Xref flopen.3 which references this manual page. PR: 112650 Revision Changes Path 1.26 +2 -1 src/lib/libc/sys/flock.2 From ru at FreeBSD.org Tue Jan 22 07:57:58 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Tue Jan 22 07:58:03 2008 Subject: cvs commit: src Makefile.inc1 Message-ID: <200801221557.m0MFvvZu052232@repoman.freebsd.org> ru 2008-01-22 15:57:57 UTC FreeBSD src repository Modified files: . Makefile.inc1 Log: Cleanup after last commit (remove undefined variables). Revision Changes Path 1.594 +1 -7 src/Makefile.inc1 From kensmith at FreeBSD.org Tue Jan 22 08:35:10 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Tue Jan 22 08:35:17 2008 Subject: cvs commit: src/release/amd64 boot_crunch.conf src/release/i386 boot_crunch.conf src/release/ia64 boot_crunch.conf src/release/pc98 boot_crunch.conf src/release/powerpc boot_crunch.conf src/release/sparc64 boot_crunch.conf ... Message-ID: <200801221635.m0MGZA9a056058@repoman.freebsd.org> kensmith 2008-01-22 16:35:10 UTC FreeBSD src repository Modified files: release/amd64 boot_crunch.conf release/i386 boot_crunch.conf release/ia64 boot_crunch.conf release/pc98 boot_crunch.conf release/powerpc boot_crunch.conf release/sparc64 boot_crunch.conf release/sun4v boot_crunch.conf Log: In 'fixit mode' running "fsck /dev/ad0s1a" typically complains that it can't find fsck_4.2bsd because there was no fstab file saying what filesystem type it is looking at so it got the filesystem type from the disk's label. When that fails admins who haven't been in this situation before are most likely to try "fsck -t ufs /dev/ad0s1a" because ufs is the type used in fstab files on working systems but that also fails complaining it can't find fsck_ufs. This just sets it up so /stand in the MFS image (/sbin is a symlink to /stand) includes hard links pointing fsck_4.2bsd and fsck_ufs to fsck_ffs which is what is present in /sbin on installed systems. Prodded by: obrien MFC after: 1 day Revision Changes Path 1.62 +2 -0 src/release/amd64/boot_crunch.conf 1.62 +2 -0 src/release/i386/boot_crunch.conf 1.12 +2 -0 src/release/ia64/boot_crunch.conf 1.63 +2 -0 src/release/pc98/boot_crunch.conf 1.5 +2 -0 src/release/powerpc/boot_crunch.conf 1.9 +2 -0 src/release/sparc64/boot_crunch.conf 1.2 +2 -0 src/release/sun4v/boot_crunch.conf From imp at bsdimp.com Tue Jan 22 08:58:57 2008 From: imp at bsdimp.com (M. Warner Losh) Date: Tue Jan 22 08:59:03 2008 Subject: cvs commit: src Makefile.inc1 src/tools/build Makefile In-Reply-To: <20080122155427.GB16573@team.vega.ru> References: <200801211844.m0LIiufY081896@repoman.freebsd.org> <20080121.151417.1106074095.imp@bsdimp.com> <20080122155427.GB16573@team.vega.ru> Message-ID: <20080122.095757.1159151185.imp@bsdimp.com> In message: <20080122155427.GB16573@team.vega.ru> Ruslan Ermilov writes: : Hi, : : On Mon, Jan 21, 2008 at 03:14:17PM -0700, M. Warner Losh wrote: : > In message: <200801211844.m0LIiufY081896@repoman.freebsd.org> : > "David E. O'Brien" writes: : > : Remove 5.x and 6.x cruft - source upgrades to RELENG_8 from versions prior : > : to RELENG_7 are not supported. : > : > I've just committed an updating entry for this change. The commit : > message has a typo in it. It should read "versions prior to RELENG_6" : > rather than RELENG_7. : : Both messages are bad, because RELENG_[67] are floating targets. They are imprecise. But are a good mnemonic for how to remember what's supported. : > This means we support people back just under 3 : > years (May 2005: 2 years 8 months) rather than the little over 3 years : > we did before (Oct 2004 3 years 3 months). FreeBSD_vesrion 600029 and : > newer will work. So this delta pushes back things forward only about : > 8 months. : : I only wonder how was the value of 600029 choosen? It was two revisions before the branch point for RELENG_6, which happened at 600031. It also is one greater than the largest if that was removed. Warner From ru at FreeBSD.org Tue Jan 22 09:10:57 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Tue Jan 22 09:11:01 2008 Subject: cvs commit: src Makefile.inc1 src/tools/build Makefile In-Reply-To: <20080122.095757.1159151185.imp@bsdimp.com> References: <200801211844.m0LIiufY081896@repoman.freebsd.org> <20080121.151417.1106074095.imp@bsdimp.com> <20080122155427.GB16573@team.vega.ru> <20080122.095757.1159151185.imp@bsdimp.com> Message-ID: <20080122171051.GB19248@team.vega.ru> On Tue, Jan 22, 2008 at 09:57:57AM -0700, M. Warner Losh wrote: > In message: <20080122155427.GB16573@team.vega.ru> > Ruslan Ermilov writes: > : Hi, > : > : On Mon, Jan 21, 2008 at 03:14:17PM -0700, M. Warner Losh wrote: > : > In message: <200801211844.m0LIiufY081896@repoman.freebsd.org> > : > "David E. O'Brien" writes: > : > : Remove 5.x and 6.x cruft - source upgrades to RELENG_8 from versions prior > : > : to RELENG_7 are not supported. > : > > : > I've just committed an updating entry for this change. The commit > : > message has a typo in it. It should read "versions prior to RELENG_6" > : > rather than RELENG_7. > : > : Both messages are bad, because RELENG_[67] are floating targets. > > They are imprecise. But are a good mnemonic for how to remember > what's supported. > OK, agreed. > : > This means we support people back just under 3 > : > years (May 2005: 2 years 8 months) rather than the little over 3 years > : > we did before (Oct 2004 3 years 3 months). FreeBSD_vesrion 600029 and > : > newer will work. So this delta pushes back things forward only about > : > 8 months. > : > : I only wonder how was the value of 600029 choosen? > > It was two revisions before the branch point for RELENG_6, which > happened at 600031. I think you're twice off-by-one here, : $ cvs -R ann -rRELENG_6_BP param.h | grep '#define.*__FreeBSD_version' : : Annotations for param.h : *************** : 1.244 (sam 11-Jul-05): #define __FreeBSD_version 600032 /* Master, propagated to newvers */ but it still doesn't answer my question. Why you've choosen this __FreeBSD_version and not RELENG_6_BP (i.e., 600032). I don't mind it, just want to understand the formulae. :-) > It also is one greater than the largest if that > was removed. Can you elaborate on what you mean here? I don't understand. Thanks. Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer From sam at errno.com Tue Jan 22 09:11:34 2008 From: sam at errno.com (Sam Leffler) Date: Tue Jan 22 09:11:37 2008 Subject: cvs commit: src/release/amd64 boot_crunch.conf src/release/i386 boot_crunch.conf src/release/ia64 boot_crunch.conf src/release/pc98 boot_crunch.conf src/release/powerpc boot_crunch.conf src/release/sparc64 boot_crunch.conf ... In-Reply-To: <200801221635.m0MGZA9a056058@repoman.freebsd.org> References: <200801221635.m0MGZA9a056058@repoman.freebsd.org> Message-ID: <479623C5.9030804@errno.com> Ken Smith wrote: > kensmith 2008-01-22 16:35:10 UTC > > FreeBSD src repository > > Modified files: > release/amd64 boot_crunch.conf > release/i386 boot_crunch.conf > release/ia64 boot_crunch.conf > release/pc98 boot_crunch.conf > release/powerpc boot_crunch.conf > release/sparc64 boot_crunch.conf > release/sun4v boot_crunch.conf > Log: > In 'fixit mode' running "fsck /dev/ad0s1a" typically complains that it > can't find fsck_4.2bsd because there was no fstab file saying what > filesystem type it is looking at so it got the filesystem type from > the disk's label. When that fails admins who haven't been in this > situation before are most likely to try "fsck -t ufs /dev/ad0s1a" because > ufs is the type used in fstab files on working systems but that also fails > complaining it can't find fsck_ufs. > > This just sets it up so /stand in the MFS image (/sbin is a symlink > to /stand) includes hard links pointing fsck_4.2bsd and fsck_ufs to > fsck_ffs which is what is present in /sbin on installed systems. > Thank you, this has been item #1 on my TODO list for several years! Want to go for #2? :-) (loading a module via loader w/ undefined symbols causes the system to panic at boot). Sam From jkim at FreeBSD.org Tue Jan 22 09:13:41 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Tue Jan 22 09:13:47 2008 Subject: cvs commit: src/sys/dev/bge if_bge.c Message-ID: <200801221713.m0MHDeFZ068782@repoman.freebsd.org> jkim 2008-01-22 17:13:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/bge if_bge.c Log: MFC: 1.194 Remove BCM5704S specific tunable (hw.bge.fake_autoneg) and auto-detect the condition. PR: kern/118308 Revision Changes Path 1.91.2.25 +13 -15 src/sys/dev/bge/if_bge.c From jkim at FreeBSD.org Tue Jan 22 09:30:14 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Tue Jan 22 09:30:20 2008 Subject: cvs commit: src/sys/dev/bge if_bge.c Message-ID: <200801221730.m0MHUDmR069747@repoman.freebsd.org> jkim 2008-01-22 17:30:13 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/dev/bge if_bge.c Log: MFC: 1.201 Fix mbuf pool watermark configuration. Approved by: re (kensmith) Revision Changes Path 1.198.2.2.2.1 +1 -1 src/sys/dev/bge/if_bge.c From imp at bsdimp.com Tue Jan 22 09:31:31 2008 From: imp at bsdimp.com (M. Warner Losh) Date: Tue Jan 22 09:31:39 2008 Subject: cvs commit: src Makefile.inc1 src/tools/build Makefile In-Reply-To: <20080122171051.GB19248@team.vega.ru> References: <20080122155427.GB16573@team.vega.ru> <20080122.095757.1159151185.imp@bsdimp.com> <20080122171051.GB19248@team.vega.ru> Message-ID: <20080122.102940.1586015611.imp@bsdimp.com> In message: <20080122171051.GB19248@team.vega.ru> Ruslan Ermilov writes: : > : I only wonder how was the value of 600029 choosen? : > : > It was two revisions before the branch point for RELENG_6, which : > happened at 600031. : : I think you're twice off-by-one here, : : : $ cvs -R ann -rRELENG_6_BP param.h | grep '#define.*__FreeBSD_version' : : : : Annotations for param.h : : *************** : : 1.244 (sam 11-Jul-05): #define __FreeBSD_version 600032 /* Master, propagated to newvers */ : : but it still doesn't answer my question. Why you've choosen : this __FreeBSD_version and not RELENG_6_BP (i.e., 600032). : I don't mind it, just want to understand the formulae. :-) Maybe I should have selected this. I wanted to select the version that would work rather than the branch point. Maybe this was silly of me. : > It also is one greater than the largest if that : > was removed. : : Can you elaborate on what you mean here? I don't understand. : Thanks. The following line: .if ${BOOTSTRAPPING} < 600029 was the line with the biggest number on the right hand side of the < that was removed. Meaning that anything 600029 and newer will still work. Warner From jkim at FreeBSD.org Tue Jan 22 09:53:41 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Tue Jan 22 09:53:48 2008 Subject: cvs commit: src/sys/dev/acpica acpi_battery.c Message-ID: <200801221753.m0MHree2070873@repoman.freebsd.org> jkim 2008-01-22 17:53:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/acpica acpi_battery.c Log: MFC: 1.26 Check battery presence first before trying to get battery information. Revision Changes Path 1.25.2.1 +4 -3 src/sys/dev/acpica/acpi_battery.c From delphij at delphij.net Tue Jan 22 10:06:24 2008 From: delphij at delphij.net (Xin LI) Date: Tue Jan 22 10:06:32 2008 Subject: cvs commit: src/sys/dev/bge if_bge.c In-Reply-To: <200801221730.m0MHUDmR069747@repoman.freebsd.org> References: <200801221730.m0MHUDmR069747@repoman.freebsd.org> Message-ID: <47963094.6070702@delphij.net> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jung-uk Kim wrote: > jkim 2008-01-22 17:30:13 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_7_0) > sys/dev/bge if_bge.c > Log: > MFC: 1.201 > > Fix mbuf pool watermark configuration. > > Approved by: re (kensmith) Thanks! - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHljCUi+vbBBjt66ARAgfOAKCiDyoRpfhqztQ+n9daR9yAWuChWACfUawK afglaCriwsz2mT2QE5Sh0ik= =IEr4 -----END PGP SIGNATURE----- From trhodes at FreeBSD.org Tue Jan 22 10:35:24 2008 From: trhodes at FreeBSD.org (Tom Rhodes) Date: Tue Jan 22 10:35:27 2008 Subject: cvs commit: src/share/man/man4 syncache.4 Message-ID: <200801221835.m0MIZO7C074634@repoman.freebsd.org> trhodes 2008-01-22 18:35:24 UTC FreeBSD src repository Modified files: share/man/man4 syncache.4 Log: Document net.inet.tcp.syncookies_only using a description taken from tcp_syncache.c revision 1.99 of andre's commit log. PR: 107611 Revision Changes Path 1.5 +11 -1 src/share/man/man4/syncache.4 From mnag at FreeBSD.org Tue Jan 22 10:58:51 2008 From: mnag at FreeBSD.org (Marcus Alves Grando) Date: Tue Jan 22 10:58:57 2008 Subject: cvs commit: src/usr.sbin/sysinstall menus.c Message-ID: <200801221858.m0MIworN080583@repoman.freebsd.org> mnag 2008-01-22 18:58:50 UTC FreeBSD src repository (ports committer) Modified files: usr.sbin/sysinstall menus.c Log: - Add new NTP servers provided by NIC.br (http://www.ntp.br) - Remove nonfunctional servers PR: 119884 Approved by: simon MFC after: 3 days Revision Changes Path 1.430 +10 -7 src/usr.sbin/sysinstall/menus.c From ru at FreeBSD.org Tue Jan 22 11:00:58 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Tue Jan 22 11:01:02 2008 Subject: cvs commit: src Makefile.inc1 src/tools/build Makefile In-Reply-To: <20080122.102940.1586015611.imp@bsdimp.com> References: <20080122155427.GB16573@team.vega.ru> <20080122.095757.1159151185.imp@bsdimp.com> <20080122171051.GB19248@team.vega.ru> <20080122.102940.1586015611.imp@bsdimp.com> Message-ID: <20080122190040.GA47055@team.vega.ru> On Tue, Jan 22, 2008 at 10:29:40AM -0700, M. Warner Losh wrote: > In message: <20080122171051.GB19248@team.vega.ru> > Ruslan Ermilov writes: > : > : I only wonder how was the value of 600029 choosen? > : > > : > It was two revisions before the branch point for RELENG_6, which > : > happened at 600031. > : > : I think you're twice off-by-one here, > : > : : $ cvs -R ann -rRELENG_6_BP param.h | grep '#define.*__FreeBSD_version' > : : > : : Annotations for param.h > : : *************** > : : 1.244 (sam 11-Jul-05): #define __FreeBSD_version 600032 /* Master, propagated to newvers */ > : > : but it still doesn't answer my question. Why you've choosen > : this __FreeBSD_version and not RELENG_6_BP (i.e., 600032). > : I don't mind it, just want to understand the formulae. :-) > > Maybe I should have selected this. I wanted to select the version > that would work rather than the branch point. Maybe this was silly of > me. > > : > It also is one greater than the largest if that > : > was removed. > : > : Can you elaborate on what you mean here? I don't understand. > : Thanks. > > The following line: > > .if ${BOOTSTRAPPING} < 600029 > > was the line with the biggest number on the right hand side of the < > that was removed. Meaning that anything 600029 and newer will still > work. > Got it now, thanks. How about if we restore the check whose aim was to avoid cluttering mailing lists with questions about upsupported source upgrades, but make it correspond to 6.0-RELEASE: %%% Index: Makefile.inc1 =================================================================== RCS file: /home/ncvs/src/Makefile.inc1,v retrieving revision 1.594 diff -u -p -r1.594 Makefile.inc1 --- Makefile.inc1 22 Jan 2008 15:57:57 -0000 1.594 +++ Makefile.inc1 22 Jan 2008 18:58:35 -0000 @@ -841,6 +841,10 @@ update: # legacy: Build compatibility shims for the next three targets # legacy: +.if ${BOOTSTRAPPING} < 600034 + @echo "ERROR: Source upgrades from versions prior to 6.0 not supported."; \ + false +.endif .for _tool in tools/build ${_+_}@${ECHODIR} "===> ${_tool} (obj,includes,depend,all,install)"; \ cd ${.CURDIR}/${_tool}; \ %%% Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer From ru at freebsd.org Tue Jan 22 11:08:40 2008 From: ru at freebsd.org (Ruslan Ermilov) Date: Tue Jan 22 11:08:44 2008 Subject: cvs commit: src/usr.bin/mklocale mklocale.1 yacc.y In-Reply-To: <200801220005.m0M056LN028605@repoman.freebsd.org> References: <200801220005.m0M056LN028605@repoman.freebsd.org> Message-ID: <20080122190825.GD47055@team.vega.ru> On Tue, Jan 22, 2008 at 12:04:53AM +0000, Andrey A. Chernov wrote: > ache 2008-01-22 00:04:52 UTC > > FreeBSD src repository > > Modified files: > usr.bin/mklocale mklocale.1 yacc.y > Log: > Understand newly introduced "ASCII" encoding > > Revision Changes Path > 1.28 +2 -0 src/usr.bin/mklocale/mklocale.1 > 1.28 +1 -0 src/usr.bin/mklocale/yacc.y > mklocale(1) is a tool used during buildworld. Am I right that after this commit it should be bootstrapped (i.e., a new version should be built and used instead of the currently installed one)? Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer From trhodes at FreeBSD.org Tue Jan 22 11:16:09 2008 From: trhodes at FreeBSD.org (Tom Rhodes) Date: Tue Jan 22 11:16:12 2008 Subject: cvs commit: src/share/man/man4 syncache.4 Message-ID: <200801221916.m0MJG98S087789@repoman.freebsd.org> trhodes 2008-01-22 19:16:09 UTC FreeBSD src repository Modified files: share/man/man4 syncache.4 Log: Correct a typo. Noticed by: ru Revision Changes Path 1.6 +1 -1 src/share/man/man4/syncache.4 From obrien at FreeBSD.org Tue Jan 22 11:17:28 2008 From: obrien at FreeBSD.org (David O'Brien) Date: Tue Jan 22 11:17:35 2008 Subject: cvs commit: src Makefile.inc1 src/tools/build Makefile In-Reply-To: <20080122190040.GA47055@team.vega.ru> References: <20080122155427.GB16573@team.vega.ru> <20080122.095757.1159151185.imp@bsdimp.com> <20080122171051.GB19248@team.vega.ru> <20080122.102940.1586015611.imp@bsdimp.com> <20080122190040.GA47055@team.vega.ru> Message-ID: <20080122191705.GA9070@dragon.NUXI.org> On Tue, Jan 22, 2008 at 10:00:40PM +0300, Ruslan Ermilov wrote: > How about if we restore the check whose aim was to avoid cluttering > mailing lists with questions about upsupported source upgrades, but > make it correspond to 6.0-RELEASE: > > %%% > Index: Makefile.inc1 > =================================================================== > RCS file: /home/ncvs/src/Makefile.inc1,v > retrieving revision 1.594 > diff -u -p -r1.594 Makefile.inc1 > --- Makefile.inc1 22 Jan 2008 15:57:57 -0000 1.594 > +++ Makefile.inc1 22 Jan 2008 18:58:35 -0000 > @@ -841,6 +841,10 @@ update: > # legacy: Build compatibility shims for the next three targets > # > legacy: > +.if ${BOOTSTRAPPING} < 600034 > + @echo "ERROR: Source upgrades from versions prior to 6.0 not supported."; \ > + false > +.endif I see your point here. Should I add this back? From imp at bsdimp.com Tue Jan 22 11:22:23 2008 From: imp at bsdimp.com (M. Warner Losh) Date: Tue Jan 22 11:22:30 2008 Subject: cvs commit: src Makefile.inc1 src/tools/build Makefile In-Reply-To: <20080122191705.GA9070@dragon.NUXI.org> References: <20080122.102940.1586015611.imp@bsdimp.com> <20080122190040.GA47055@team.vega.ru> <20080122191705.GA9070@dragon.NUXI.org> Message-ID: <20080122.122059.270770161.imp@bsdimp.com> In message: <20080122191705.GA9070@dragon.NUXI.org> "David O'Brien" writes: : On Tue, Jan 22, 2008 at 10:00:40PM +0300, Ruslan Ermilov wrote: : > How about if we restore the check whose aim was to avoid cluttering : > mailing lists with questions about upsupported source upgrades, but : > make it correspond to 6.0-RELEASE: : > : > %%% : > Index: Makefile.inc1 : > =================================================================== : > RCS file: /home/ncvs/src/Makefile.inc1,v : > retrieving revision 1.594 : > diff -u -p -r1.594 Makefile.inc1 : > --- Makefile.inc1 22 Jan 2008 15:57:57 -0000 1.594 : > +++ Makefile.inc1 22 Jan 2008 18:58:35 -0000 : > @@ -841,6 +841,10 @@ update: : > # legacy: Build compatibility shims for the next three targets : > # : > legacy: : > +.if ${BOOTSTRAPPING} < 600034 : > + @echo "ERROR: Source upgrades from versions prior to 6.0 not supported."; \ : > + false : > +.endif : : I see your point here. Should I add this back? It does break BOOTSTRAPPING=0 case, which would be nice to keep working. Err, fix, since the last set of changes also broke it. Warner From attilio at FreeBSD.org Tue Jan 22 11:58:33 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Tue Jan 22 11:58:39 2008 Subject: cvs commit: src/share/man/man9 Makefile Message-ID: <200801221958.m0MJwU3l008393@repoman.freebsd.org> attilio 2008-01-22 19:58:30 UTC FreeBSD src repository Modified files: share/man/man9 Makefile Log: Fix lock.9 manpage in order to recall lockmgr_disown() with 'man' command. Revision Changes Path 1.321 +1 -0 src/share/man/man9/Makefile From attilio at FreeBSD.org Tue Jan 22 12:02:24 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Tue Jan 22 12:02:31 2008 Subject: cvs commit: src/share/man/man9 BUF_REFCNT.9 Makefile Message-ID: <200801222002.m0MK2OLb008629@repoman.freebsd.org> attilio 2008-01-22 20:02:24 UTC FreeBSD src repository Modified files: share/man/man9 Makefile Removed files: share/man/man9 BUF_REFCNT.9 Log: BUF_REFCNT(9) function no more exists, so just axe out the manpage. Revision Changes Path 1.8 +0 -61 src/share/man/man9/BUF_REFCNT.9 (dead) 1.322 +0 -1 src/share/man/man9/Makefile From attilio at FreeBSD.org Tue Jan 22 12:08:10 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Tue Jan 22 12:08:16 2008 Subject: cvs commit: src ObsoleteFiles.inc Message-ID: <200801222008.m0MK89BI010056@repoman.freebsd.org> attilio 2008-01-22 20:08:09 UTC FreeBSD src repository Modified files: . ObsoleteFiles.inc Log: Reflect BUF_REFCNT(9) removal. Pointed out by: brueffer Revision Changes Path 1.126 +2 -0 src/ObsoleteFiles.inc From attilio at FreeBSD.org Tue Jan 22 12:16:10 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Tue Jan 22 12:16:12 2008 Subject: cvs commit: src/share/man/man9 Makefile lock.9 Message-ID: <200801222016.m0MKGAKY011230@repoman.freebsd.org> attilio 2008-01-22 20:16:10 UTC FreeBSD src repository Modified files: share/man/man9 Makefile lock.9 Log: Add the newly added function lockmgr_recursed() to the manpages. Revision Changes Path 1.323 +1 -0 src/share/man/man9/Makefile 1.21 +9 -1 src/share/man/man9/lock.9 From attilio at FreeBSD.org Tue Jan 22 13:26:36 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Tue Jan 22 13:26:42 2008 Subject: cvs commit: src/share/man/man9 BUF_ISLOCKED.9 BUF_RECURSED.9 Makefile Message-ID: <200801222126.m0MLQZid060884@repoman.freebsd.org> attilio 2008-01-22 21:26:35 UTC FreeBSD src repository Modified files: share/man/man9 Makefile Added files: share/man/man9 BUF_ISLOCKED.9 BUF_RECURSED.9 Log: Add manpages for BUF_RECURSED(9) and BUF_ISLOCKED(9) and connect them to the build. Reviewed by: brueffer Revision Changes Path 1.1 +68 -0 src/share/man/man9/BUF_ISLOCKED.9 (new) 1.1 +64 -0 src/share/man/man9/BUF_RECURSED.9 (new) 1.324 +2 -0 src/share/man/man9/Makefile From gallatin at FreeBSD.org Tue Jan 22 14:04:31 2008 From: gallatin at FreeBSD.org (Andrew Gallatin) Date: Tue Jan 22 14:04:33 2008 Subject: cvs commit: src/sys/dev/mxge if_mxge.c if_mxge_var.h Message-ID: <200801222204.m0MM4V6N064251@repoman.freebsd.org> gallatin 2008-01-22 22:04:31 UTC FreeBSD src repository Modified files: sys/dev/mxge if_mxge.c if_mxge_var.h Log: Take advantage of the new physically contiguous 9K jumbos in 8. Revision Changes Path 1.44 +23 -3 src/sys/dev/mxge/if_mxge.c 1.18 +6 -0 src/sys/dev/mxge/if_mxge_var.h From bmah at FreeBSD.org Tue Jan 22 15:05:28 2008 From: bmah at FreeBSD.org (Bruce A. Mah) Date: Tue Jan 22 15:05:33 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml Message-ID: <200801222305.m0MN5RFV070651@repoman.freebsd.org> bmah 2008-01-22 23:05:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) release/doc/en_US.ISO8859-1/relnotes article.sgml Log: New release notes: SA-08:01, SA-08:02. Bump copyright date. Approved by: re (implicitly) Revision Changes Path 1.1068.2.20.2.2 +14 -0 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml From ache at nagual.pp.ru Tue Jan 22 15:31:15 2008 From: ache at nagual.pp.ru (Andrey Chernov) Date: Tue Jan 22 15:31:22 2008 Subject: cvs commit: src/usr.bin/mklocale mklocale.1 yacc.y In-Reply-To: <20080122190825.GD47055@team.vega.ru> References: <200801220005.m0M056LN028605@repoman.freebsd.org> <20080122190825.GD47055@team.vega.ru> Message-ID: <20080122231830.GA15131@nagual.pp.ru> On Tue, Jan 22, 2008 at 10:08:25PM +0300, Ruslan Ermilov wrote: > On Tue, Jan 22, 2008 at 12:04:53AM +0000, Andrey A. Chernov wrote: > > ache 2008-01-22 00:04:52 UTC > > > > FreeBSD src repository > > > > Modified files: > > usr.bin/mklocale mklocale.1 yacc.y > > Log: > > Understand newly introduced "ASCII" encoding > > > > Revision Changes Path > > 1.28 +2 -0 src/usr.bin/mklocale/mklocale.1 > > 1.28 +1 -0 src/usr.bin/mklocale/yacc.y > > > mklocale(1) is a tool used during buildworld. Am I right > that after this commit it should be bootstrapped (i.e., > a new version should be built and used instead of the > currently installed one)? As I can see in Makefile.inc1, it is bootstrapped already. May I miss something? -- http://ache.pp.ru/ From ache at nagual.pp.ru Tue Jan 22 15:57:34 2008 From: ache at nagual.pp.ru (Andrey Chernov) Date: Tue Jan 22 15:57:38 2008 Subject: cvs commit: src/usr.bin/mklocale mklocale.1 yacc.y In-Reply-To: <20080122231830.GA15131@nagual.pp.ru> References: <200801220005.m0M056LN028605@repoman.freebsd.org> <20080122190825.GD47055@team.vega.ru> <20080122231830.GA15131@nagual.pp.ru> Message-ID: <20080122235732.GA16024@nagual.pp.ru> On Wed, Jan 23, 2008 at 02:18:31AM +0300, Andrey Chernov wrote: > > mklocale(1) is a tool used during buildworld. Am I right > > that after this commit it should be bootstrapped (i.e., > > a new version should be built and used instead of the > > currently installed one)? > > As I can see in Makefile.inc1, it is bootstrapped already. > May I miss something? Oops, not there anymore after your latest commit. I realize that macro was empty in anycase, so I'll add it. -- http://ache.pp.ru/ From ache at FreeBSD.org Tue Jan 22 16:04:18 2008 From: ache at FreeBSD.org (Andrey A. Chernov) Date: Tue Jan 22 16:04:21 2008 Subject: cvs commit: src/sys/sys param.h Message-ID: <200801230004.m0N04IvK075210@repoman.freebsd.org> ache 2008-01-23 00:04:18 UTC FreeBSD src repository Modified files: sys/sys param.h Log: Bump FreeBSD_version after adding "ASCII" encoding to libc Revision Changes Path 1.327 +1 -1 src/sys/sys/param.h From jkim at FreeBSD.org Tue Jan 22 16:15:23 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Tue Jan 22 16:15:28 2008 Subject: cvs commit: src/sys/dev/acpica acpi_battery.c Message-ID: <200801230015.m0N0FMVw076669@repoman.freebsd.org> jkim 2008-01-23 00:15:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/dev/acpica acpi_battery.c Log: MFC: 1.26 Check battery presence first before trying to get battery information. Approved by: re (kensmith) Revision Changes Path 1.25.4.1 +4 -3 src/sys/dev/acpica/acpi_battery.c From ache at FreeBSD.org Tue Jan 22 16:16:37 2008 From: ache at FreeBSD.org (Andrey A. Chernov) Date: Tue Jan 22 16:16:42 2008 Subject: cvs commit: src Makefile.inc1 Message-ID: <200801230016.m0N0GbNW076716@repoman.freebsd.org> ache 2008-01-23 00:16:37 UTC FreeBSD src repository Modified files: . Makefile.inc1 Log: Conditionally add mklocale to bootstrap-tools Revision Changes Path 1.595 +5 -0 src/Makefile.inc1 From ache at FreeBSD.org Tue Jan 22 17:57:27 2008 From: ache at FreeBSD.org (Andrey A. Chernov) Date: Tue Jan 22 17:57:30 2008 Subject: cvs commit: src/lib/libc/locale setrunelocale.c Message-ID: <200801230157.m0N1vQ62092192@repoman.freebsd.org> ache 2008-01-23 01:57:26 UTC FreeBSD src repository Modified files: lib/libc/locale setrunelocale.c Log: 1) Add (void) cast to _none_init() (while I am here) 2) Fix longstanding segfault in mb/wc code when unknown encoding is specified in the locale file (mb/wc functions becomes NULL in that case). Revision Changes Path 1.49 +4 -2 src/lib/libc/locale/setrunelocale.c From ache at FreeBSD.org Tue Jan 22 18:17:27 2008 From: ache at FreeBSD.org (Andrey A. Chernov) Date: Tue Jan 22 18:17:30 2008 Subject: cvs commit: src/lib/libc/locale setrunelocale.c Message-ID: <200801230217.m0N2HRrY094952@repoman.freebsd.org> ache 2008-01-23 02:17:27 UTC FreeBSD src repository Modified files: lib/libc/locale setrunelocale.c Log: Better fix for longstanding segfault. Don't touch current locale at all on unknown encoding. Previous fix resets it to POSIX. Revision Changes Path 1.50 +29 -17 src/lib/libc/locale/setrunelocale.c From ache at FreeBSD.org Tue Jan 22 19:05:36 2008 From: ache at FreeBSD.org (Andrey A. Chernov) Date: Tue Jan 22 19:05:42 2008 Subject: cvs commit: src/lib/libc/locale setrunelocale.c Message-ID: <200801230305.m0N35awJ099622@repoman.freebsd.org> ache 2008-01-23 03:05:35 UTC FreeBSD src repository Modified files: lib/libc/locale setrunelocale.c Log: Fix longstanding mb/wc functions segfault if error occurse inside __init(). Currently _EUC_init() only was affected. Revision Changes Path 1.51 +39 -29 src/lib/libc/locale/setrunelocale.c From jeff at FreeBSD.org Tue Jan 22 19:10:19 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Tue Jan 22 19:10:20 2008 Subject: cvs commit: src/sys/kern sched_ule.c Message-ID: <200801230310.m0N3AI20099835@repoman.freebsd.org> jeff 2008-01-23 03:10:18 UTC FreeBSD src repository Modified files: sys/kern sched_ule.c Log: - sched_prio() should only adjust tdq_lowpri if the thread is running or on a run-queue. If the priority is numerically raised only change lowpri if we're certain it will be correct. Some slop is allowed however previously we could erroneously raise lowpri for an idle cpu that a thread had recently run on which lead to errors in load balancing decisions. Revision Changes Path 1.223 +9 -7 src/sys/kern/sched_ule.c From ache at FreeBSD.org Tue Jan 22 20:25:11 2008 From: ache at FreeBSD.org (Andrey A. Chernov) Date: Tue Jan 22 20:25:17 2008 Subject: cvs commit: src/share/mklocale la_LN.US-ASCII.src Message-ID: <200801230425.m0N4PAsj009954@repoman.freebsd.org> ache 2008-01-23 04:25:10 UTC FreeBSD src repository Modified files: share/mklocale la_LN.US-ASCII.src Log: "NONE" -> "ASCII" encoding Revision Changes Path 1.3 +1 -1 src/share/mklocale/la_LN.US-ASCII.src From kientzle at FreeBSD.org Tue Jan 22 21:43:26 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Tue Jan 22 21:43:29 2008 Subject: cvs commit: src/lib/libarchive archive_write_set_format_cpio_newc.c src/lib/libarchive/test test_write_format_cpio_newc.c Message-ID: <200801230543.m0N5hQKf023930@repoman.freebsd.org> kientzle 2008-01-23 05:43:26 UTC FreeBSD src repository Modified files: lib/libarchive archive_write_set_format_cpio_newc.c lib/libarchive/test test_write_format_cpio_newc.c Log: Properly pad symlinks when writing cpio "newc" format. Thanks to: Jesse Barker for reporting this. MFC after: 7 days Revision Changes Path 1.3 +7 -1 src/lib/libarchive/archive_write_set_format_cpio_newc.c 1.2 +42 -3 src/lib/libarchive/test/test_write_format_cpio_newc.c From kientzle at FreeBSD.org Tue Jan 22 21:47:09 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Tue Jan 22 21:47:15 2008 Subject: cvs commit: src/lib/libarchive/test test_write_disk.c Message-ID: <200801230547.m0N5l8i3024127@repoman.freebsd.org> kientzle 2008-01-23 05:47:08 UTC FreeBSD src repository Modified files: lib/libarchive/test test_write_disk.c Log: Explain a subtle API change that was made recently. Even though I believe this is a good change, it does have the potential to break certain clients, so it's good to document the reasoning behind the change. Revision Changes Path 1.8 +21 -0 src/lib/libarchive/test/test_write_disk.c From kientzle at FreeBSD.org Tue Jan 22 21:48:08 2008 From: kientzle at FreeBSD.org (Tim Kientzle) Date: Tue Jan 22 21:48:13 2008 Subject: cvs commit: src/lib/libarchive Makefile Message-ID: <200801230548.m0N5m7kp024202@repoman.freebsd.org> kientzle 2008-01-23 05:48:07 UTC FreeBSD src repository Modified files: lib/libarchive Makefile Log: Track version # from the portable release. Revision Changes Path 1.80 +1 -1 src/lib/libarchive/Makefile From maxim at FreeBSD.org Wed Jan 23 00:50:35 2008 From: maxim at FreeBSD.org (Maxim Konovalov) Date: Wed Jan 23 00:50:41 2008 Subject: cvs commit: src/sys Makefile Message-ID: <200801230850.m0N8oZ7S057408@repoman.freebsd.org> maxim 2008-01-23 08:50:35 UTC FreeBSD src repository Modified files: sys Makefile Log: o Add boot, gdb, nfsserver and opencrypto dirs to CSCOPEDIRS; sort. Revision Changes Path 1.46 +3 -3 src/sys/Makefile From mav at FreeBSD.org Wed Jan 23 03:47:10 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Wed Jan 23 03:47:12 2008 Subject: cvs commit: src/sys/netgraph ng_ppp.c Message-ID: <200801231147.m0NBl9lN007588@repoman.freebsd.org> mav 2008-01-23 11:47:09 UTC FreeBSD src repository Modified files: sys/netgraph ng_ppp.c Log: Fix bundle xmit octets stats for packet-split operation mode. Revision Changes Path 1.71 +4 -4 src/sys/netgraph/ng_ppp.c From mav at FreeBSD.org Wed Jan 23 03:50:36 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Wed Jan 23 03:50:42 2008 Subject: cvs commit: src/sys/netgraph ng_ppp.c Message-ID: <200801231150.m0NBoadJ009100@repoman.freebsd.org> mav 2008-01-23 11:50:36 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/netgraph ng_ppp.c Log: MFC rev 1.71 Fix bundle xmit octets stats for packet-split operation mode. Revision Changes Path 1.70.2.1 +4 -4 src/sys/netgraph/ng_ppp.c From rwatson at FreeBSD.org Wed Jan 23 04:07:18 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Wed Jan 23 04:07:23 2008 Subject: cvs commit: src/sys/kern uipc_usrreq.c Message-ID: <200801231207.m0NC7Hgv011123@repoman.freebsd.org> rwatson 2008-01-23 12:07:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern uipc_usrreq.c Log: Merge uipc_usrreq.c:1.214 from HEAD to RELENG_7: Move unlock of global UNIX domain socket lock slightly lower in unp_connect(): it is expected to return with the lock held, and two possible error paths otherwise returned with it unlocked. The fix committed here is slightly different from the patch in the PR, but along an alternative line suggested in the PR. PR: 119778 Submitted by: James Juran Approved by: re (gnn) Revision Changes Path 1.206.2.1 +1 -1 src/sys/kern/uipc_usrreq.c From rwatson at FreeBSD.org Wed Jan 23 04:08:12 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Wed Jan 23 04:08:14 2008 Subject: cvs commit: src/sys/kern uipc_usrreq.c Message-ID: <200801231208.m0NC8CWS011201@repoman.freebsd.org> rwatson 2008-01-23 12:08:12 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/kern uipc_usrreq.c Log: Merge uipc_usrreq.c:1.214 from HEAD to RELENG_7_0: Move unlock of global UNIX domain socket lock slightly lower in unp_connect(): it is expected to return with the lock held, and two possible error paths otherwise returned with it unlocked. The fix committed here is slightly different from the patch in the PR, but along an alternative line suggested in the PR. PR: 119778 Submitted by: James Juran Approved by: re (gnn) Revision Changes Path 1.206.4.1 +1 -1 src/sys/kern/uipc_usrreq.c From rwatson at FreeBSD.org Wed Jan 23 04:09:43 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Wed Jan 23 04:09:49 2008 Subject: cvs commit: src/sys/fs/coda cnode.h coda_namecache.h coda_psdev.c coda_vfsops.c coda_vnops.c Message-ID: <200801231209.m0NC9hqu011272@repoman.freebsd.org> rwatson 2008-01-23 12:09:43 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/fs/coda cnode.h coda_namecache.h coda_psdev.c coda_vfsops.c coda_vnops.c Log: Merge a variety of Coda fixes from HEAD to RELENG_7_0: coda_vnops.c:1.79: Borrow the VM object associated with an underlying cache vnode with the Coda vnode derived from it, in the style of nullfs. This allows files in the Coda file system to be memory-mapped, such as with execve(2) or mmap(2). Reported by: Rune coda_vnops.c:1.80: Lock the new directory vnode returned by coda_mkdir(), as this is required by FreeBSD's vnode locking protocol. coda_vnops.c:1.81: Use VOP_NULL rather than VOP_PANIC for Coda's vop_print routine, so as to avoid panicking in DDB show lockedvnods. cnode.h:1.22, coda_namecache.h:1.12, coda_psdev.c:1.40, coda_vfsops.c:1.70: Don't declare functions as extern. Move all extern variable definitions to associated .h files, move some extern variable definitions between include files to place them more appropriately. coda_vnops.c:1.82: Don't acquire an additional vnode reference to a vnode when it is opened and then release it when it is closed: we rely on the caller to keep the vnode around with a valid reference. This avoids vrele() destroying the vnode vop_close() is being called from during a call to vop_close(), and a crash due to lockmgr recursing the vnode lock when a Coda unmount occurs. coda_vfsops.c:1.71: Zero mi_rotovp and coda_ctlvp immediately after calling vrele() on the vnodes during coda_unmount() in order to detect errant use of them after the vnode references may no longer be valid. No need to clear the VV_ROOT flag on mi_rootvp flag (especially after the vnode reference is no longer valid) as this isn't done on other file systems. coda_vfsops.c: Rework coda_statfs(): no longer need to zero the statfs structure or fill out all fields, just fill out the ones the file system knows about. Among other things, this causes the outpuf of "mount" and "df" to make quite a bit more sense as /dev/cfs0 is specified as the mountfrom name. coda_vnops.c:1.83: Improve default vnode operation handling for Coda: - Don't specify vnode operations for mknod, lease, and advlock--let them fall through to vop_default. - Implement vop_default with &default_vnodeops, rather than with VOP_PANIC, so that unimplemented vnode operations are handled in more sensible ways than panicking, such as EOPNOTSUPP on ACL queries generated by bsdtar, or mknod. coda_namecache.h:1.13: Remove unused oldhash definition from Coda namecache. coda_vnops.c:1.84: Replace references to VOP_LOCK() w/o LK_RETRY to vn_lock() with LK_RETRY, avoiding extra error handling, or in some cases, missing error handling. Discussed with: kib coda_vnops.c:1.85: Put "coda_rdwr: Internally Opening" printf generated by in-kernel writes to files, such as ktrace output, under CODA_VERBOSE. Otherwise, each such call to VOP_WRITE() results in a kernel printf. Obtained from: NetBSD Approved by: re (kensmith) Revision Changes Path 1.21.4.1 +0 -6 src/sys/fs/coda/cnode.h 1.11.4.1 +22 -20 src/sys/fs/coda/coda_namecache.h 1.39.4.1 +0 -3 src/sys/fs/coda/coda_psdev.c 1.67.4.1 +4 -13 src/sys/fs/coda/coda_vfsops.c 1.76.4.1 +15 -23 src/sys/fs/coda/coda_vnops.c From rwatson at FreeBSD.org Wed Jan 23 04:12:25 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Wed Jan 23 04:12:37 2008 Subject: cvs commit: src/share/man/man4 Makefile Message-ID: <200801231212.m0NCCO8W011505@repoman.freebsd.org> rwatson 2008-01-23 12:12:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man4 Makefile Log: Merge revisions 1.1 and 1.2 of the coda.4 man page from HEAD to RELENG_7: Add a rather basic man page for the coda kernel module. Small fixes. Approved by: re (kensmith) Revision Changes Path 1.393.2.3 +1 -0 src/share/man/man4/Makefile From rwatson at FreeBSD.org Wed Jan 23 04:16:00 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Wed Jan 23 04:16:02 2008 Subject: cvs commit: src/share/man/man4 coda.4 Message-ID: <200801231216.m0NCG0Za012555@repoman.freebsd.org> rwatson 2008-01-23 12:16:00 UTC FreeBSD src repository Added files: (Branch: RELENG_7) share/man/man4 coda.4 Log: Merge revisions 1.1 and 1.2 of the coda.4 man page from HEAD to RELENG_7: Add a rather basic man page for the coda kernel module. Small fixes. Approved by: re (kensmith) Revision Changes Path 1.2.2.1 +82 -0 src/share/man/man4/coda.4 (new) From mav at FreeBSD.org Wed Jan 23 04:17:34 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Wed Jan 23 04:17:43 2008 Subject: cvs commit: src/sys/netgraph ng_ppp.c Message-ID: <200801231217.m0NCHYnJ012675@repoman.freebsd.org> mav 2008-01-23 12:17:34 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netgraph ng_ppp.c Log: MFC rev 1.71 Fix bundle xmit octets stats for packet-split operation mode. Revision Changes Path 1.57.2.5 +4 -4 src/sys/netgraph/ng_ppp.c From rwatson at FreeBSD.org Wed Jan 23 04:22:12 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Wed Jan 23 04:22:14 2008 Subject: cvs commit: src/share/man/man4 Makefile coda.4 Message-ID: <200801231222.m0NCMBgt012929@repoman.freebsd.org> rwatson 2008-01-23 12:22:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) share/man/man4 Makefile Added files: (Branch: RELENG_7_0) share/man/man4 coda.4 Log: Merge revisions 1.1 and 1.2 of the coda.4 man page from HEAD to RELENG_7_0: Add a rather basic man page for the coda kernel module. Small fixes. Approved by: re (kensmith) Revision Changes Path 1.393.2.2.2.1 +1 -0 src/share/man/man4/Makefile 1.2.4.1 +82 -0 src/share/man/man4/coda.4 (new) From chinsan at FreeBSD.org Wed Jan 23 08:08:36 2008 From: chinsan at FreeBSD.org (Chin-San Huang) Date: Wed Jan 23 08:08:42 2008 Subject: cvs commit: src/share/man/man5 rc.conf.5 Message-ID: <200801231608.m0NG8Z5N049625@repoman.freebsd.org> chinsan 2008-01-23 16:08:35 UTC FreeBSD src repository (doc,ports committer) Modified files: share/man/man5 rc.conf.5 Log: - Document firewall_nat_enable related settings. Tested by: AB MFC after: 1 month Revision Changes Path 1.333 +26 -1 src/share/man/man5/rc.conf.5 From yar at FreeBSD.org Wed Jan 23 09:33:08 2008 From: yar at FreeBSD.org (Yar Tikhiy) Date: Wed Jan 23 09:33:17 2008 Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb kgdb.h main.c trgt.c In-Reply-To: <200801171652.31546.jhb@freebsd.org> References: <200801172143.m0HLhCm8016953@repoman.freebsd.org> <200801171652.31546.jhb@freebsd.org> Message-ID: <20080123173307.GA27907@freefall.freebsd.org> On Thu, Jan 17, 2008 at 04:52:30PM -0500, John Baldwin wrote: > On Thursday 17 January 2008 04:43:12 pm John Baldwin wrote: > > jhb 2008-01-17 21:43:12 UTC > > > > FreeBSD src repository > > > > Modified files: > > gnu/usr.bin/gdb/kgdb kgdb.h main.c trgt.c > > Log: > > Add a new 'add-kld ' command to kgdb to make it easier to analyze > > crash dumps with kernel modules. The command is basically a wrapper > > around add-symbol-file except that it uses the kernel linker data > > structures and the ELF section headers of the kld to calculate the > > section addresses add-symbol-file needs. > > Forgot to say: > > Tested on: i386, amd64 > > A sample run on i386: > > > sudo ./kgdb -c /usr/crash/vmcore.10 /boot/kernel/kernel > ... > crash: blow the kernel stack on purpose > > Fatal double fault: > eip = 0xc05c6220 > esp = 0xe61b0000 > ebp = 0xe61b0018 > panic: double fault > KDB: enter: panic > ... > (kgdb) where > #0 doadump () at pcpu.h:195 > #1 0xc05d399c in boot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:417 > #2 0xc05d3c0a in panic (fmt=Variable "fmt" is not available. > ) at /usr/src/sys/kern/kern_shutdown.c:571 > #3 0xc08115d9 in dblfault_handler () at /usr/src/sys/i386/i386/trap.c:927 > #4 0xc05c6220 in mtx_pool_setup_dynamic () > #5 0xc065e125 in arc4rand (ptr=0xe61b0168, len=4, reseed=0) > at /usr/src/sys/libkern/arc4random.c:142 > #6 0xc065e171 in arc4random () at /usr/src/sys/libkern/arc4random.c:150 > #7 0xc3d43402 in ?? () > #8 0xb15ac28c in ?? () > #9 0x793b5626 in ?? () > #10 0xe61b018c in ?? () > #11 0xc3d43410 in ?? () > #12 0xbc8e58bf in ?? () > ... > (kgdb) add-kld crash.ko > add symbol table from file "/boot/modules/crash.ko.symbols" at > .text_addr = 0xc3d416f0 > .data_addr = 0xc3d44000 > .bss_addr = 0xc3d44254 > .rodata_addr = 0xc3d4364e > Reading symbols from /boot/modules/crash.ko.symbols...done. Thank you! By the way, if there are a lot of modules to load, using asf(8) might be a little easier: one needs to run asf once and then he can source its output (written to .asf by default) into the kgdb session. Just a little advertisment so that my work on asf(8) doesn't fall into oblivion. :-) OTOH, I can imagine `add-all-klds' command for kgdb implemented in a similar vein since there is a full list of loaded modules in the core image. Yar From jhb at FreeBSD.org Wed Jan 23 09:58:47 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Wed Jan 23 09:58:51 2008 Subject: cvs commit: src/lib/libc/stdlib grantpt.c src/lib/libutil pty.3 Message-ID: <200801231758.m0NHwk2F066293@repoman.freebsd.org> jhb 2008-01-23 17:58:46 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libc/stdlib grantpt.c lib/libutil pty.3 Log: MFC: Update openpty(3) manpage for the recent pty fixes and remove some now-unused macros from grantpt.c. Revision Changes Path 1.7.2.5 +1 -12 src/lib/libc/stdlib/grantpt.c 1.13.18.1 +14 -18 src/lib/libutil/pty.3 From jhb at FreeBSD.org Wed Jan 23 09:59:28 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Wed Jan 23 09:59:34 2008 Subject: cvs commit: src/lib/libc/stdlib grantpt.c src/lib/libutil pty.3 Message-ID: <200801231759.m0NHxRqG066373@repoman.freebsd.org> jhb 2008-01-23 17:59:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libc/stdlib grantpt.c lib/libutil pty.3 Log: MFC: Update openpty(3) manpage for the recent pty fixes and remove some now-unused macros from grantpt.c. Revision Changes Path 1.4.2.3 +1 -10 src/lib/libc/stdlib/grantpt.c 1.13.8.1 +14 -18 src/lib/libutil/pty.3 From jhb at FreeBSD.org Wed Jan 23 10:02:58 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Wed Jan 23 10:03:01 2008 Subject: cvs commit: src/sys/dev/acpica acpi_hpet.c acpi_hpet.h Message-ID: <200801231802.m0NI2we1066676@repoman.freebsd.org> jhb 2008-01-23 18:02:58 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/acpica acpi_hpet.c Added files: (Branch: RELENG_7) sys/dev/acpica acpi_hpet.h Log: MFC: Fix some minor issues such as using read/modify/write for updating the configuration register and add a header file to hold HPET register constants. Revision Changes Path 1.12.2.1 +58 -20 src/sys/dev/acpica/acpi_hpet.c 1.1.2.1 +65 -0 src/sys/dev/acpica/acpi_hpet.h (new) From jhb at FreeBSD.org Wed Jan 23 10:03:16 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Wed Jan 23 10:03:18 2008 Subject: cvs commit: src/sys/dev/acpica acpi_hpet.c acpi_hpet.h Message-ID: <200801231803.m0NI3FDu067892@repoman.freebsd.org> jhb 2008-01-23 18:03:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/acpica acpi_hpet.c Added files: (Branch: RELENG_6) sys/dev/acpica acpi_hpet.h Log: MFC: Fix some minor issues such as using read/modify/write for updating the configuration register and add a header file to hold HPET register constants. Revision Changes Path 1.5.2.7 +58 -20 src/sys/dev/acpica/acpi_hpet.c 1.1.4.1 +65 -0 src/sys/dev/acpica/acpi_hpet.h (new) From jhb at FreeBSD.org Wed Jan 23 10:04:28 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Wed Jan 23 10:04:37 2008 Subject: cvs commit: src/sys/dev/pci pci_user.c Message-ID: <200801231804.m0NI4S4p067988@repoman.freebsd.org> jhb 2008-01-23 18:04:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/pci pci_user.c Log: MFC: Don't cache the new-bus name of a PCI device in the PCI conf structure. Revision Changes Path 1.22.2.3 +4 -1 src/sys/dev/pci/pci_user.c From jhb at FreeBSD.org Wed Jan 23 10:05:34 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Wed Jan 23 10:05:40 2008 Subject: cvs commit: src/sys/dev/pci pci_user.c Message-ID: <200801231805.m0NI5YDn068106@repoman.freebsd.org> jhb 2008-01-23 18:05:34 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/pci pci_user.c Log: MFC: Don't cache the new-bus name of a PCI device in the PCI conf structure. Revision Changes Path 1.19.2.3 +4 -1 src/sys/dev/pci/pci_user.c From kensmith at FreeBSD.org Wed Jan 23 12:04:12 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Wed Jan 23 12:04:13 2008 Subject: cvs commit: src/release fixit.profile Message-ID: <200801232004.m0NK4BH8081995@repoman.freebsd.org> kensmith 2008-01-23 20:04:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) release fixit.profile Log: MFC v1.12: Update EDITOR and PAGER environment variables so they are correct for the CDROM fixit environment. Noticed by: gallatin Revision Changes Path 1.10.10.2 +2 -2 src/release/fixit.profile From kensmith at FreeBSD.org Wed Jan 23 12:05:23 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Wed Jan 23 12:05:25 2008 Subject: cvs commit: src/release fixit.profile Message-ID: <200801232005.m0NK5Mwq082076@repoman.freebsd.org> kensmith 2008-01-23 20:05:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release fixit.profile Log: MFC v1.12: Update EDITOR and PAGER environment variables so they are correct for the CDROM fixit environment. Noticed by: gallatin Revision Changes Path 1.10.2.2 +2 -2 src/release/fixit.profile From kensmith at FreeBSD.org Wed Jan 23 12:06:27 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Wed Jan 23 12:06:35 2008 Subject: cvs commit: src/release fixit.profile Message-ID: <200801232006.m0NK6RtG082135@repoman.freebsd.org> kensmith 2008-01-23 20:06:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) release fixit.profile Log: MFC v1.12: Update EDITOR and PAGER environment variables so they are correct for the CDROM fixit environment. Noticed by: gallatin Approved by: re (bmah) Revision Changes Path 1.10.10.1.2.1 +2 -2 src/release/fixit.profile From kensmith at FreeBSD.org Wed Jan 23 12:16:49 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Wed Jan 23 12:16:55 2008 Subject: cvs commit: src/release/amd64 boot_crunch.conf src/release/i386 boot_crunch.conf src/release/ia64 boot_crunch.conf src/release/pc98 boot_crunch.conf src/release/powerpc boot_crunch.conf src/release/sparc64 boot_crunch.conf ... Message-ID: <200801232016.m0NKGmbe083559@repoman.freebsd.org> kensmith 2008-01-23 20:16:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) release/amd64 boot_crunch.conf release/i386 boot_crunch.conf release/ia64 boot_crunch.conf release/pc98 boot_crunch.conf release/powerpc boot_crunch.conf release/sparc64 boot_crunch.conf release/sun4v boot_crunch.conf Log: MFC: Add fsck_4.2bsd and fsck_ufs as hard links to fsck_ffs in /stand on the MFS image so that (for example) "fsck /dev/ad0s1a" will work. Without this you needed (for example) "fsck -t ffs /dev/ad0s1a" (or needed to run fsck_ffs instead of fsck). Versions being MFCed: 1.62 src/release/amd64/boot_crunch.conf 1.62 src/release/i386/boot_crunch.conf 1.12 src/release/ia64/boot_crunch.conf 1.63 src/release/pc98/boot_crunch.conf 1.5 src/release/powerpc/boot_crunch.conf 1.9 src/release/sparc64/boot_crunch.conf 1.2 src/release/sun4v/boot_crunch.conf Revision Changes Path 1.61.2.1 +2 -0 src/release/amd64/boot_crunch.conf 1.61.2.1 +2 -0 src/release/i386/boot_crunch.conf 1.11.2.1 +2 -0 src/release/ia64/boot_crunch.conf 1.62.2.1 +2 -0 src/release/pc98/boot_crunch.conf 1.4.2.1 +2 -0 src/release/powerpc/boot_crunch.conf 1.8.2.1 +2 -0 src/release/sparc64/boot_crunch.conf 1.1.2.1 +2 -0 src/release/sun4v/boot_crunch.conf From kensmith at FreeBSD.org Wed Jan 23 12:19:18 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Wed Jan 23 12:19:20 2008 Subject: cvs commit: src/release/amd64 boot_crunch.conf src/release/i386 boot_crunch.conf src/release/ia64 boot_crunch.conf src/release/pc98 boot_crunch.conf src/release/powerpc boot_crunch.conf src/release/sparc64 boot_crunch.conf Message-ID: <200801232019.m0NKJInp083766@repoman.freebsd.org> kensmith 2008-01-23 20:19:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/amd64 boot_crunch.conf release/i386 boot_crunch.conf release/ia64 boot_crunch.conf release/pc98 boot_crunch.conf release/powerpc boot_crunch.conf release/sparc64 boot_crunch.conf Log: MFC: Add fsck_4.2bsd and fsck_ufs as hard links to fsck_ffs in /stand on the MFS image so that (for example) "fsck /dev/ad0s1a" will work. Without this you needed (for example) "fsck -t ffs /dev/ad0s1a" (or needed to run fsck_ffs instead of fsck). Versions being MFCed: 1.62 src/release/amd64/boot_crunch.conf 1.62 src/release/i386/boot_crunch.conf 1.12 src/release/ia64/boot_crunch.conf 1.63 src/release/pc98/boot_crunch.conf 1.5 src/release/powerpc/boot_crunch.conf 1.9 src/release/sparc64/boot_crunch.conf 1.2 src/release/sun4v/boot_crunch.conf Revision Changes Path 1.59.2.2 +2 -0 src/release/amd64/boot_crunch.conf 1.59.2.2 +2 -0 src/release/i386/boot_crunch.conf 1.9.2.2 +2 -0 src/release/ia64/boot_crunch.conf 1.59.2.2 +2 -0 src/release/pc98/boot_crunch.conf 1.3.2.1 +2 -0 src/release/powerpc/boot_crunch.conf 1.7.2.1 +2 -0 src/release/sparc64/boot_crunch.conf From kensmith at FreeBSD.org Wed Jan 23 12:22:49 2008 From: kensmith at FreeBSD.org (Ken Smith) Date: Wed Jan 23 12:22:50 2008 Subject: cvs commit: src/release/amd64 boot_crunch.conf src/release/i386 boot_crunch.conf src/release/ia64 boot_crunch.conf src/release/pc98 boot_crunch.conf src/release/powerpc boot_crunch.conf src/release/sparc64 boot_crunch.conf ... Message-ID: <200801232022.m0NKMmHv084187@repoman.freebsd.org> kensmith 2008-01-23 20:22:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) release/amd64 boot_crunch.conf release/i386 boot_crunch.conf release/ia64 boot_crunch.conf release/pc98 boot_crunch.conf release/powerpc boot_crunch.conf release/sparc64 boot_crunch.conf release/sun4v boot_crunch.conf Log: MFC: Add fsck_4.2bsd and fsck_ufs as hard links to fsck_ffs in /stand on the MFS image so that (for example) "fsck /dev/ad0s1a" will work. Without this you needed (for example) "fsck -t ffs /dev/ad0s1a" (or needed to run fsck_ffs instead of fsck). Versions being MFCed: 1.62 src/release/amd64/boot_crunch.conf 1.62 src/release/i386/boot_crunch.conf 1.12 src/release/ia64/boot_crunch.conf 1.63 src/release/pc98/boot_crunch.conf 1.5 src/release/powerpc/boot_crunch.conf 1.9 src/release/sparc64/boot_crunch.conf 1.2 src/release/sun4v/boot_crunch.conf Approved by: re (bmah) Revision Changes Path 1.61.4.1 +2 -0 src/release/amd64/boot_crunch.conf 1.61.4.1 +2 -0 src/release/i386/boot_crunch.conf 1.11.4.1 +2 -0 src/release/ia64/boot_crunch.conf 1.62.4.1 +2 -0 src/release/pc98/boot_crunch.conf 1.4.4.1 +2 -0 src/release/powerpc/boot_crunch.conf 1.8.4.1 +2 -0 src/release/sparc64/boot_crunch.conf 1.1.4.1 +2 -0 src/release/sun4v/boot_crunch.conf From delphij at FreeBSD.org Wed Jan 23 12:37:44 2008 From: delphij at FreeBSD.org (Xin LI) Date: Wed Jan 23 12:37:46 2008 Subject: cvs commit: src/release/doc/zh_CN.GB2312/relnotes article.sgml Message-ID: <200801232037.m0NKbiUT084760@repoman.freebsd.org> delphij 2008-01-23 20:37:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) release/doc/zh_CN.GB2312/relnotes article.sgml Log: MFen 1.1068.2.20.2.2 Approved by: re (kensmith) Revision Changes Path 1.1.2.2.2.2 +12 -1 src/release/doc/zh_CN.GB2312/relnotes/article.sgml From des at FreeBSD.org Wed Jan 23 12:58:00 2008 From: des at FreeBSD.org (Dag-Erling Smorgrav) Date: Wed Jan 23 12:58:07 2008 Subject: cvs commit: src/lib/libfetch ftp.c Message-ID: <200801232057.m0NKvxq5002602@repoman.freebsd.org> des 2008-01-23 20:57:59 UTC FreeBSD src repository Modified files: lib/libfetch ftp.c Log: Fix a regression introduced in rev 1.99: replace fclose(f) with a comment explaining why f cannot possibly be a valid FILE * at this point. MFC after: 1 day Revision Changes Path 1.101 +5 -1 src/lib/libfetch/ftp.c From rwatson at FreeBSD.org Wed Jan 23 13:15:51 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Wed Jan 23 13:15:54 2008 Subject: cvs commit: src/sys/netinet tcp_usrreq.c Message-ID: <200801232115.m0NLFpFB005393@repoman.freebsd.org> rwatson 2008-01-23 21:15:51 UTC FreeBSD src repository Modified files: sys/netinet tcp_usrreq.c Log: tcp_usrreq.c:1.313 removed tcbinfo locking from tcp_usr_accept(), which while in principle a good idea, opened us up to a race inherrent to the syncache's direct insertion of incoming TCP connections into the "completed connection" listen queue, as it transpires that the socket is inserted before the inpcb is fully filled in by syncache_expand(). The bug manifested with the occasional returning of 0.0.0.0:0 in the address returned by the accept() system call, which occurred if accept managed to execute tcp_usr_accept() before syncache_expand() had copied the endpoint addresses into inpcb connection state. Re-add tcbinfo locking around the address copyout, which has the effect of delaying the copy until syncache_expand() has finished running, as it is run while the tcbinfo lock is held. This is undesirable in that it increases contention on tcbinfo further, but a more significant change will be required to how the syncache inserts new sockets in order to fix this and keep more granular locking here. In particular, either more state needs to be passed into sonewconn() so that pru_attach() can fill in the fields *before* the socket is inserted, or the socket needs to be inserted in the incomplete connection queue until it is actually ready to be used. Reported by: glebius (and kris) Tested by: glebius Revision Changes Path 1.167 +2 -0 src/sys/netinet/tcp_usrreq.c From andre at freebsd.org Wed Jan 23 13:54:06 2008 From: andre at freebsd.org (Andre Oppermann) Date: Wed Jan 23 13:54:08 2008 Subject: cvs commit: src/sys/netinet tcp_syncache.c In-Reply-To: <200711200656.lAK6u4bc021279@repoman.freebsd.org> References: <200711200656.lAK6u4bc021279@repoman.freebsd.org> Message-ID: <4797B77E.2090605@freebsd.org> Mike Silbersack wrote: > silby 2007-11-20 06:56:04 UTC > > FreeBSD src repository > > Modified files: > sys/netinet tcp_syncache.c > Log: > Comment out the syncache's test which ensures that hosts which negotiate TCP > timestamps in the initial SYN packet actually use them in the rest of the > connection. Unfortunately, during the 7.0 testing cycle users have already > found network devices that violate this constraint. > > RFC 1323 states 'and may send a TSopt in other segments' rather than > 'and MUST send', so we must allow it. > > Discovered by: Rob Zietlow > Tracked down by: Kip Macy > PR: bin/118005 > > Revision Changes Path > 1.134 +6 -0 src/sys/netinet/tcp_syncache.c > > kmacy 2007-12-12 06:11:50 UTC > > FreeBSD src repository > > Modified files: > sys/netinet tcp_syncache.c > Log: > Remove spurious timestamp check. RFC 1323 explicitly states that timestamps MAY > be transmitted if negotiated. > > Revision Changes Path > 1.138 +1 -17 src/sys/netinet/tcp_syncache.c These changes and their rationale are not really correct. The citation from RFC1323 is grossly misrepresented. The partly cited sentence says that timestamps may only be transmitted if they were negotiated. It doesn't say that timestamps may or may not be sent after they were negotiated. In fact RFC1323 Section 3.2 explicitly states: "For simplicity and symmetry, we specify that timestamps always be sent and echoed in both directions." It is also the unchallenged consensus view of the IETF TCPM is that timestamps must be sent when negotiated [1]. It is not allowed to not include them when agreed so at SYN time. Any deviation of this is a violation of the RFC. Thus the test was correct and valid. OTOH the enforcement of this rule wasn't really there before and it may be argued that we've got a POLA violation here. A careful reading of the referenced PR bin/118005 and its audit trail do not support the conclusion that the enforcement is the root cause of the symptoms described. The submitter makes a clear distinction between inside and outside of his LAN. Inside everything continues to work just fine. It's outside of his LAN that certain machines can't establish connections to the upgraded machine. The cited outside machines are FreeBSD 6.2, OpenBSD 4.1 and Linux RHEL 4U4. All these operating systems correctly implement RFC1323 timestamps and do not omit them once negotiated. Hence it is very likely that the root cause is in some device along the path munging the packets in a non-RFC conform way. Perhaps a reverse-NAT gateway on his Internet gateway. Or some other packet rewriting system. The PR needs to reopened and the root cause properly inspected. Based on the rationale above I'd like to re-instate the test in HEAD because a) it is correct and b) even if disabled to serve as education for future readers of the SYN/SYN-ACK/ACK path. If the test has to remain disabled we should include a clear description including which systems and their revisions fail the test. Alternatively the test should be modified to disable sending of timestamps if this situation occurs as they are a pointless waste of bits anyway as they won't ever be returned back to us to measure anything. [1] http://www1.ietf.org/mail-archive/web/tcpm/current/msg02507.html and (many) following messages in that thread -- Andre Index: tcp_syncache.c =================================================================== RCS file: /home/ncvs/src/sys/netinet/tcp_syncache.c,v retrieving revision 1.141 diff -u -p -r1.141 tcp_syncache.c --- tcp_syncache.c 19 Dec 2007 16:56:28 -0000 1.141 +++ tcp_syncache.c 23 Jan 2008 21:33:49 -0000 @@ -914,12 +914,41 @@ syncache_expand(struct in_conninfo *inc, goto failed; } + /* + * If timestamps were present in the SYN and we accepted + * them in our SYN|ACK RFC1323 Section 3.2 requires them + * to be present from now on. And vice versa. + */ + if ((sc->sc_flags & SCF_TIMESTAMP) && !(to->to_flags & TOF_TS)) { + if ((s = tcp_log_addrs(inc, th, NULL, NULL))) + log(LOG_DEBUG, "%s; %s: Timestamp missing, " + "segment rejected\n", s, __func__); +#ifdef TCP_BROKEN_TS + /* + * There appear to be non-conformant devices that + * negotiate timestamps but then fail to include + * them in every segment from then on. + * + * Evidence of this really happening is inconclusive + * and specific operating systems or firmware and their + * revisions are not known. + * + * For a work-around disable sending of timestamps + * as they become a pointless waste of bandwidth + * if we won't get them reflected back anyway. + */ + sc->sc_flags &= ~SCF_TIMESTAMP; +#else + goto failed; +#endif + } if (!(sc->sc_flags & SCF_TIMESTAMP) && (to->to_flags & TOF_TS)) { if ((s = tcp_log_addrs(inc, th, NULL, NULL))) log(LOG_DEBUG, "%s; %s: Timestamp not expected, " "segment rejected\n", s, __func__); goto failed; } + /* * If timestamps were negotiated the reflected timestamp * must be equal to what we actually sent in the SYN|ACK. From jhb at freebsd.org Wed Jan 23 14:10:04 2008 From: jhb at freebsd.org (John Baldwin) Date: Wed Jan 23 14:10:18 2008 Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb kgdb.h main.c trgt.c In-Reply-To: <20080123173307.GA27907@freefall.freebsd.org> References: <200801172143.m0HLhCm8016953@repoman.freebsd.org> <200801171652.31546.jhb@freebsd.org> <20080123173307.GA27907@freefall.freebsd.org> Message-ID: <200801231546.59937.jhb@freebsd.org> On Wednesday 23 January 2008 12:33:07 pm Yar Tikhiy wrote: > On Thu, Jan 17, 2008 at 04:52:30PM -0500, John Baldwin wrote: > > On Thursday 17 January 2008 04:43:12 pm John Baldwin wrote: > > > jhb 2008-01-17 21:43:12 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > gnu/usr.bin/gdb/kgdb kgdb.h main.c trgt.c > > > Log: > > > Add a new 'add-kld ' command to kgdb to make it easier to analyze > > > crash dumps with kernel modules. The command is basically a wrapper > > > around add-symbol-file except that it uses the kernel linker data > > > structures and the ELF section headers of the kld to calculate the > > > section addresses add-symbol-file needs. > > > > Forgot to say: > > > > Tested on: i386, amd64 > > > > A sample run on i386: > > > > > sudo ./kgdb -c /usr/crash/vmcore.10 /boot/kernel/kernel > > ... > > crash: blow the kernel stack on purpose > > > > Fatal double fault: > > eip = 0xc05c6220 > > esp = 0xe61b0000 > > ebp = 0xe61b0018 > > panic: double fault > > KDB: enter: panic > > ... > > (kgdb) where > > #0 doadump () at pcpu.h:195 > > #1 0xc05d399c in boot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:417 > > #2 0xc05d3c0a in panic (fmt=Variable "fmt" is not available. > > ) at /usr/src/sys/kern/kern_shutdown.c:571 > > #3 0xc08115d9 in dblfault_handler () at /usr/src/sys/i386/i386/trap.c:927 > > #4 0xc05c6220 in mtx_pool_setup_dynamic () > > #5 0xc065e125 in arc4rand (ptr=0xe61b0168, len=4, reseed=0) > > at /usr/src/sys/libkern/arc4random.c:142 > > #6 0xc065e171 in arc4random () at /usr/src/sys/libkern/arc4random.c:150 > > #7 0xc3d43402 in ?? () > > #8 0xb15ac28c in ?? () > > #9 0x793b5626 in ?? () > > #10 0xe61b018c in ?? () > > #11 0xc3d43410 in ?? () > > #12 0xbc8e58bf in ?? () > > ... > > (kgdb) add-kld crash.ko > > add symbol table from file "/boot/modules/crash.ko.symbols" at > > .text_addr = 0xc3d416f0 > > .data_addr = 0xc3d44000 > > .bss_addr = 0xc3d44254 > > .rodata_addr = 0xc3d4364e > > Reading symbols from /boot/modules/crash.ko.symbols...done. > > Thank you! > > By the way, if there are a lot of modules to load, using asf(8) > might be a little easier: one needs to run asf once and then he > can source its output (written to .asf by default) into the kgdb > session. Just a little advertisment so that my work on asf(8) > doesn't fall into oblivion. :-) > > OTOH, I can imagine `add-all-klds' command for kgdb implemented in > a similar vein since there is a full list of loaded modules in the > core image. Actually, that is my next step is to make the kgdb auto-load all klds it can find on startup. asf(8) does work, but I find it a bit more work to have to use an external utility to do it, and potentially more confusing for users. -- John Baldwin From ru at FreeBSD.org Wed Jan 23 14:21:36 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Wed Jan 23 14:21:42 2008 Subject: cvs commit: src Makefile.inc1 UPDATING Message-ID: <200801232221.m0NMLa0Y020183@repoman.freebsd.org> ru 2008-01-23 22:21:36 UTC FreeBSD src repository Modified files: . Makefile.inc1 UPDATING Log: Support source upgrades from at least 6.0-RELEASE. Reviewed by: imp, obrien Revision Changes Path 1.596 +4 -0 src/Makefile.inc1 1.516 +2 -5 src/UPDATING From aryeh.friedman at gmail.com Wed Jan 23 14:54:17 2008 From: aryeh.friedman at gmail.com (Aryeh M. Friedman) Date: Wed Jan 23 14:54:22 2008 Subject: cvs commit: src/lib/libfetch ftp.c In-Reply-To: <200801232057.m0NKvxq5002602@repoman.freebsd.org> References: <200801232057.m0NKvxq5002602@repoman.freebsd.org> Message-ID: <4797C269.7070507@gmail.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Just writting to confirm the fix works on the orginial reported issue.... a stupid question what does MFC stand for? Dag-Erling Smorgrav wrote: > des 2008-01-23 20:57:59 UTC > > FreeBSD src repository > > Modified files: lib/libfetch ftp.c Log: Fix a regression > introduced in rev 1.99: replace fclose(f) with a comment explaining > why f cannot possibly be a valid FILE * at this point. > > MFC after: 1 day > > Revision Changes Path 1.101 +5 -1 > src/lib/libfetch/ftp.c > _______________________________________________ cvs-src@freebsd.org > mailing list http://lists.freebsd.org/mailman/listinfo/cvs-src To > unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > - -- Aryeh M. Friedman FloSoft Systems, Java Tool Developers Developer, not business, friendly http://www.flosoft-systems.com "Free software != Free beer" Blog: http://www.flosoft-systems.com/flosoft_systems_community/blogs/aryeh/index.php -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHl8JoQi2hk2LEXBARAs6NAJ98dfUDffsoNl1b69uMehsCIu4l0QCg3kMJ NdRS3FcnLanF1uuwj3uxtKk= =4fXR -----END PGP SIGNATURE----- From brooks at FreeBSD.org Wed Jan 23 15:04:27 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Wed Jan 23 15:04:33 2008 Subject: cvs commit: src/lib/libfetch ftp.c In-Reply-To: <4797C269.7070507@gmail.com> References: <200801232057.m0NKvxq5002602@repoman.freebsd.org> <4797C269.7070507@gmail.com> Message-ID: <20080123230425.GB14264@lor.one-eyed-alien.net> On Wed, Jan 23, 2008 at 05:40:41PM -0500, Aryeh M. Friedman wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Just writting to confirm the fix works on the orginial reported > issue.... a stupid question what does MFC stand for? Merge From Current as googling for "what does MFC stand for freebsd" would tell you. -- Brooks > Dag-Erling Smorgrav wrote: > > des 2008-01-23 20:57:59 UTC > > > > FreeBSD src repository > > > > Modified files: lib/libfetch ftp.c Log: Fix a regression > > introduced in rev 1.99: replace fclose(f) with a comment explaining > > why f cannot possibly be a valid FILE * at this point. > > > > MFC after: 1 day > > > > Revision Changes Path 1.101 +5 -1 > > src/lib/libfetch/ftp.c > > _______________________________________________ cvs-src@freebsd.org > > mailing list http://lists.freebsd.org/mailman/listinfo/cvs-src To > > unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > > > > > - -- > Aryeh M. Friedman > FloSoft Systems, Java Tool Developers > Developer, not business, friendly > http://www.flosoft-systems.com > > "Free software != Free beer" > > Blog: > > http://www.flosoft-systems.com/flosoft_systems_community/blogs/aryeh/index.php > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.4 (FreeBSD) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iD8DBQFHl8JoQi2hk2LEXBARAs6NAJ98dfUDffsoNl1b69uMehsCIu4l0QCg3kMJ > NdRS3FcnLanF1uuwj3uxtKk= > =4fXR > -----END PGP SIGNATURE----- > -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080123/4beaed11/attachment.pgp From rwatson at FreeBSD.org Wed Jan 23 15:40:23 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Wed Jan 23 15:40:29 2008 Subject: cvs commit: src/sys/netinet tcp_usrreq.c Message-ID: <200801232340.m0NNeM5H029037@repoman.freebsd.org> rwatson 2008-01-23 23:40:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/netinet tcp_usrreq.c Log: Merge tcp_usrreq.c:1.167 from HEAD to RELENG_7: tcp_usrreq.c:1.313 removed tcbinfo locking from tcp_usr_accept(), which while in principle a good idea, opened us up to a race inherrent to the syncache's direct insertion of incoming TCP connections into the "completed connection" listen queue, as it transpires that the socket is inserted before the inpcb is fully filled in by syncache_expand(). The bug manifested with the occasional returning of 0.0.0.0:0 in the address returned by the accept() system call, which occurred if accept managed to execute tcp_usr_accept() before syncache_expand() had copied the endpoint addresses into inpcb connection state. Re-add tcbinfo locking around the address copyout, which has the effect of delaying the copy until syncache_expand() has finished running, as it is run while the tcbinfo lock is held. This is undesirable in that it increases contention on tcbinfo further, but a more significant change will be required to how the syncache inserts new sockets in order to fix this and keep more granular locking here. In particular, either more state needs to be passed into sonewconn() so that pru_attach() can fill in the fields *before* the socket is inserted, or the socket needs to be inserted in the incomplete connection queue until it is actually ready to be used. Reported by: glebius (and kris) Tested by: glebius Approved: re (kensmith) Revision Changes Path 1.163.2.2 +2 -0 src/sys/netinet/tcp_usrreq.c From eischen at vigrid.com Wed Jan 23 15:40:50 2008 From: eischen at vigrid.com (Daniel Eischen) Date: Wed Jan 23 15:40:55 2008 Subject: cvs commit: src/lib/libfetch ftp.c In-Reply-To: <20080123230425.GB14264@lor.one-eyed-alien.net> References: <200801232057.m0NKvxq5002602@repoman.freebsd.org> <4797C269.7070507@gmail.com> <20080123230425.GB14264@lor.one-eyed-alien.net> Message-ID: On Wed, 23 Jan 2008, Brooks Davis wrote: > On Wed, Jan 23, 2008 at 05:40:41PM -0500, Aryeh M. Friedman wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Just writting to confirm the fix works on the orginial reported >> issue.... a stupid question what does MFC stand for? > > Merge From Current as googling for "what does MFC stand for freebsd" > would tell you. It's funny to think back years ago when I first started watching the commits. At first I thought MFC meant "minor f***ing change", as in WTF or RTFM. -- DE From edwin at mavetju.org Wed Jan 23 16:02:57 2008 From: edwin at mavetju.org (Edwin Groothuis) Date: Wed Jan 23 16:03:01 2008 Subject: cvs commit: src/share/zoneinfo leapseconds In-Reply-To: <200801180934.m0I9Yd8b097489@repoman.freebsd.org> References: <200801180934.m0I9Yd8b097489@repoman.freebsd.org> Message-ID: <20080124000254.GA67469@k7.mavetju> On Fri, Jan 18, 2008 at 09:34:39AM +0000, Poul-Henning Kamp wrote: > phk 2008-01-18 09:34:39 UTC > > FreeBSD src repository > > Modified files: > share/zoneinfo leapseconds > Log: > Still no new leapseconds: Bulletin C-35 This would have been (and still will be) updated in the next tzdata release. Edwin -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://www.mavetju.org/weblog/ From phk at phk.freebsd.dk Wed Jan 23 16:25:56 2008 From: phk at phk.freebsd.dk (Poul-Henning Kamp) Date: Wed Jan 23 16:25:59 2008 Subject: cvs commit: src/share/zoneinfo leapseconds In-Reply-To: Your message of "Thu, 24 Jan 2008 11:02:54 +1100." <20080124000254.GA67469@k7.mavetju> Message-ID: <40949.1201134360@critter.freebsd.dk> In message <20080124000254.GA67469@k7.mavetju>, Edwin Groothuis writes: >On Fri, Jan 18, 2008 at 09:34:39AM +0000, Poul-Henning Kamp wrote: >> phk 2008-01-18 09:34:39 UTC >> >> FreeBSD src repository >> >> Modified files: >> share/zoneinfo leapseconds >> Log: >> Still no new leapseconds: Bulletin C-35 > >This would have been (and still will be) updated in the next tzdata >release. Please understand that the information that _no_ leapsecond is going to happen is just as important as if we were told that a leapsecond was going to happen. Unless tzdata is going to updated at every bulletin C arrival, we need to handle this on ourselves. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From trhodes at FreeBSD.org Wed Jan 23 16:39:39 2008 From: trhodes at FreeBSD.org (Tom Rhodes) Date: Wed Jan 23 16:39:45 2008 Subject: cvs commit: src/share/man/man4 xl.4 Message-ID: <200801240039.m0O0ddH4035275@repoman.freebsd.org> trhodes 2008-01-24 00:39:39 UTC FreeBSD src repository Modified files: share/man/man4 xl.4 Log: Add a diagnostic note about "transmission error ... tx underrun, increasing tx start threshold ..." Looking around on the mailing lists, and even having one of these cards I agree the messages should be documented. Bump doc date. PR: 88477 Revision Changes Path 1.39 +6 -1 src/share/man/man4/xl.4 From edwin at mavetju.org Wed Jan 23 17:06:56 2008 From: edwin at mavetju.org (Edwin Groothuis) Date: Wed Jan 23 17:07:04 2008 Subject: cvs commit: src/share/zoneinfo leapseconds In-Reply-To: <40949.1201134360@critter.freebsd.dk> References: <20080124000254.GA67469@k7.mavetju> <40949.1201134360@critter.freebsd.dk> Message-ID: <20080124010652.GA68022@k7.mavetju> On Thu, Jan 24, 2008 at 12:26:00AM +0000, Poul-Henning Kamp wrote: > In message <20080124000254.GA67469@k7.mavetju>, Edwin Groothuis writes: > >On Fri, Jan 18, 2008 at 09:34:39AM +0000, Poul-Henning Kamp wrote: > >> phk 2008-01-18 09:34:39 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> share/zoneinfo leapseconds > >> Log: > >> Still no new leapseconds: Bulletin C-35 > > > >This would have been (and still will be) updated in the next tzdata > >release. > > Please understand that the information that _no_ leapsecond is going > to happen is just as important as if we were told that a leapsecond > was going to happen. > > Unless tzdata is going to updated at every bulletin C arrival, we need > to handle this on ourselves. With the historical tracking of the tzdata files, I know that now and then the FreeBSD repository got out of sync with the vendor data. But if you look at the last six - nine months, you will see that it's much more in sync with the vendor branch within a shorter time. Leapseconds is one of the files from them, but due to the lack of a SCM repository for them I can't browse through it, but then the FreeBSD repository seems to have a lot of updates on it in it. Honestly, not that I worry that you updated it: it will give me a nice headsup to check for it at the next import. Edwin -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://www.mavetju.org/weblog/ From kip.macy at gmail.com Wed Jan 23 20:58:38 2008 From: kip.macy at gmail.com (Kip Macy) Date: Wed Jan 23 20:58:45 2008 Subject: cvs commit: src/sys/netinet tcp_syncache.c In-Reply-To: <4797B77E.2090605@freebsd.org> References: <200711200656.lAK6u4bc021279@repoman.freebsd.org> <4797B77E.2090605@freebsd.org> Message-ID: Did you talk to the original submitter? Note that FreeBSD's TCP stack is for use in servers and is not intending as a validating TCP stack. If you would like it to serve as such you would better served by tracking down the ANVL tests that FreeBSD fails. Also note that there is no MUST in the following sentence: "For simplicity and symmetry, we specify that timestamps always be sent and echoed in both directions." So it is clearly open to interpretation. -Kip On Jan 23, 2008 1:54 PM, Andre Oppermann wrote: > > Mike Silbersack wrote: > > silby 2007-11-20 06:56:04 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/netinet tcp_syncache.c > > Log: > > Comment out the syncache's test which ensures that hosts which negotiate TCP > > timestamps in the initial SYN packet actually use them in the rest of the > > connection. Unfortunately, during the 7.0 testing cycle users have already > > found network devices that violate this constraint. > > > > RFC 1323 states 'and may send a TSopt in other segments' rather than > > 'and MUST send', so we must allow it. > > > > Discovered by: Rob Zietlow > > Tracked down by: Kip Macy > > PR: bin/118005 > > > > Revision Changes Path > > 1.134 +6 -0 src/sys/netinet/tcp_syncache.c > > > > kmacy 2007-12-12 06:11:50 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/netinet tcp_syncache.c > > Log: > > Remove spurious timestamp check. RFC 1323 explicitly states that timestamps MAY > > be transmitted if negotiated. > > > > Revision Changes Path > > 1.138 +1 -17 src/sys/netinet/tcp_syncache.c > > These changes and their rationale are not really correct. The citation > from RFC1323 is grossly misrepresented. The partly cited sentence says > that timestamps may only be transmitted if they were negotiated. It > doesn't say that timestamps may or may not be sent after they were > negotiated. In fact RFC1323 Section 3.2 explicitly states: "For > simplicity and symmetry, we specify that timestamps always be sent > and echoed in both directions." It is also the unchallenged consensus > view of the IETF TCPM is that timestamps must be sent when negotiated > [1]. It is not allowed to not include them when agreed so at SYN time. > Any deviation of this is a violation of the RFC. Thus the test was > correct and valid. > > OTOH the enforcement of this rule wasn't really there before and it > may be argued that we've got a POLA violation here. A careful reading > of the referenced PR bin/118005 and its audit trail do not support the > conclusion that the enforcement is the root cause of the symptoms > described. The submitter makes a clear distinction between inside and > outside of his LAN. Inside everything continues to work just fine. > It's outside of his LAN that certain machines can't establish > connections to the upgraded machine. The cited outside machines are > FreeBSD 6.2, OpenBSD 4.1 and Linux RHEL 4U4. All these operating > systems correctly implement RFC1323 timestamps and do not omit them > once negotiated. Hence it is very likely that the root cause is in > some device along the path munging the packets in a non-RFC conform > way. Perhaps a reverse-NAT gateway on his Internet gateway. Or some > other packet rewriting system. The PR needs to reopened and the root > cause properly inspected. > > Based on the rationale above I'd like to re-instate the test in HEAD > because a) it is correct and b) even if disabled to serve as education > for future readers of the SYN/SYN-ACK/ACK path. If the test has to > remain disabled we should include a clear description including which > systems and their revisions fail the test. Alternatively the test > should be modified to disable sending of timestamps if this situation > occurs as they are a pointless waste of bits anyway as they won't ever > be returned back to us to measure anything. > > > [1] http://www1.ietf.org/mail-archive/web/tcpm/current/msg02507.html > and (many) following messages in that thread > > -- > Andre > > Index: tcp_syncache.c > =================================================================== > RCS file: /home/ncvs/src/sys/netinet/tcp_syncache.c,v > retrieving revision 1.141 > diff -u -p -r1.141 tcp_syncache.c > --- tcp_syncache.c 19 Dec 2007 16:56:28 -0000 1.141 > +++ tcp_syncache.c 23 Jan 2008 21:33:49 -0000 > @@ -914,12 +914,41 @@ syncache_expand(struct in_conninfo *inc, > goto failed; > } > > + /* > + * If timestamps were present in the SYN and we accepted > + * them in our SYN|ACK RFC1323 Section 3.2 requires them > + * to be present from now on. And vice versa. > + */ > + if ((sc->sc_flags & SCF_TIMESTAMP) && !(to->to_flags & TOF_TS)) { > + if ((s = tcp_log_addrs(inc, th, NULL, NULL))) > + log(LOG_DEBUG, "%s; %s: Timestamp missing, " > + "segment rejected\n", s, __func__); > +#ifdef TCP_BROKEN_TS > + /* > + * There appear to be non-conformant devices that > + * negotiate timestamps but then fail to include > + * them in every segment from then on. > + * > + * Evidence of this really happening is inconclusive > + * and specific operating systems or firmware and their > + * revisions are not known. > + * > + * For a work-around disable sending of timestamps > + * as they become a pointless waste of bandwidth > + * if we won't get them reflected back anyway. > + */ > + sc->sc_flags &= ~SCF_TIMESTAMP; > +#else > + goto failed; > +#endif > + } > if (!(sc->sc_flags & SCF_TIMESTAMP) && (to->to_flags & TOF_TS)) { > if ((s = tcp_log_addrs(inc, th, NULL, NULL))) > log(LOG_DEBUG, "%s; %s: Timestamp not expected, " > "segment rejected\n", s, __func__); > goto failed; > } > + > /* > * If timestamps were negotiated the reflected timestamp > * must be equal to what we actually sent in the SYN|ACK. > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > From brueffer at FreeBSD.org Wed Jan 23 21:48:00 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Wed Jan 23 21:48:01 2008 Subject: cvs commit: src/share/man/man7 ports.7 Message-ID: <200801240547.m0O5lxN9078829@repoman.freebsd.org> brueffer 2008-01-24 05:47:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man7 ports.7 Log: MFC: rev. 1.65 Document the 'maintainer' target. Revision Changes Path 1.61.2.2 +3 -1 src/share/man/man7/ports.7 From brueffer at FreeBSD.org Wed Jan 23 21:48:56 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Wed Jan 23 21:48:58 2008 Subject: cvs commit: src/share/man/man7 ports.7 Message-ID: <200801240548.m0O5mtOh078879@repoman.freebsd.org> brueffer 2008-01-24 05:48:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man7 ports.7 Log: MFC: rev. 1.65 Document the 'maintainer' target. Revision Changes Path 1.50.2.8 +3 -1 src/share/man/man7/ports.7 From yar at comp.chem.msu.su Wed Jan 23 21:55:27 2008 From: yar at comp.chem.msu.su (Yar Tikhiy) Date: Wed Jan 23 21:55:30 2008 Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb kgdb.h main.c trgt.c In-Reply-To: <200801231546.59937.jhb@freebsd.org> References: <200801172143.m0HLhCm8016953@repoman.freebsd.org> <200801171652.31546.jhb@freebsd.org> <20080123173307.GA27907@freefall.freebsd.org> <200801231546.59937.jhb@freebsd.org> Message-ID: <20080124053533.GA59743@comp.chem.msu.su> On Wed, Jan 23, 2008 at 03:46:59PM -0500, John Baldwin wrote: > On Wednesday 23 January 2008 12:33:07 pm Yar Tikhiy wrote: > > On Thu, Jan 17, 2008 at 04:52:30PM -0500, John Baldwin wrote: > > > On Thursday 17 January 2008 04:43:12 pm John Baldwin wrote: > > > > jhb 2008-01-17 21:43:12 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > gnu/usr.bin/gdb/kgdb kgdb.h main.c trgt.c > > > > Log: > > > > Add a new 'add-kld ' command to kgdb to make it easier to analyze > > > > crash dumps with kernel modules. The command is basically a wrapper > > > > around add-symbol-file except that it uses the kernel linker data > > > > structures and the ELF section headers of the kld to calculate the > > > > section addresses add-symbol-file needs. > > > > > > Forgot to say: > > > > > > Tested on: i386, amd64 > > > > > > A sample run on i386: > > > > > > > sudo ./kgdb -c /usr/crash/vmcore.10 /boot/kernel/kernel > > > ... > > > crash: blow the kernel stack on purpose > > > > > > Fatal double fault: > > > eip = 0xc05c6220 > > > esp = 0xe61b0000 > > > ebp = 0xe61b0018 > > > panic: double fault > > > KDB: enter: panic > > > ... > > > (kgdb) where > > > #0 doadump () at pcpu.h:195 > > > #1 0xc05d399c in boot (howto=260) > at /usr/src/sys/kern/kern_shutdown.c:417 > > > #2 0xc05d3c0a in panic (fmt=Variable "fmt" is not available. > > > ) at /usr/src/sys/kern/kern_shutdown.c:571 > > > #3 0xc08115d9 in dblfault_handler () at /usr/src/sys/i386/i386/trap.c:927 > > > #4 0xc05c6220 in mtx_pool_setup_dynamic () > > > #5 0xc065e125 in arc4rand (ptr=0xe61b0168, len=4, reseed=0) > > > at /usr/src/sys/libkern/arc4random.c:142 > > > #6 0xc065e171 in arc4random () at /usr/src/sys/libkern/arc4random.c:150 > > > #7 0xc3d43402 in ?? () > > > #8 0xb15ac28c in ?? () > > > #9 0x793b5626 in ?? () > > > #10 0xe61b018c in ?? () > > > #11 0xc3d43410 in ?? () > > > #12 0xbc8e58bf in ?? () > > > ... > > > (kgdb) add-kld crash.ko > > > add symbol table from file "/boot/modules/crash.ko.symbols" at > > > .text_addr = 0xc3d416f0 > > > .data_addr = 0xc3d44000 > > > .bss_addr = 0xc3d44254 > > > .rodata_addr = 0xc3d4364e > > > Reading symbols from /boot/modules/crash.ko.symbols...done. > > > > Thank you! > > > > By the way, if there are a lot of modules to load, using asf(8) > > might be a little easier: one needs to run asf once and then he > > can source its output (written to .asf by default) into the kgdb > > session. Just a little advertisment so that my work on asf(8) > > doesn't fall into oblivion. :-) > > > > OTOH, I can imagine `add-all-klds' command for kgdb implemented in > > a similar vein since there is a full list of loaded modules in the > > core image. > > Actually, that is my next step is to make the kgdb auto-load all klds it can > find on startup. asf(8) does work, but I find it a bit more work to have to > use an external utility to do it, and potentially more confusing for users. Of course, asf(8) is inferior to auto-loading by kgdb. asf(8) did its job for me already, so I won't mind if it is retired now and replaced by the better solution. It's just what is called progress. Many thanks for your work in this area! If it were assigned to a lazy person like me, people would have to use asf(8) forever. :-) -- Yar From ru at FreeBSD.org Wed Jan 23 23:03:22 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Wed Jan 23 23:03:28 2008 Subject: cvs commit: src/share/mk bsd.own.mk Message-ID: <200801240703.m0O73Ldn085488@repoman.freebsd.org> ru 2008-01-24 07:03:21 UTC FreeBSD src repository Modified files: share/mk bsd.own.mk Log: Cosmetique: sort the list. Revision Changes Path 1.73 +2 -2 src/share/mk/bsd.own.mk From ru at FreeBSD.org Wed Jan 23 23:04:13 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Wed Jan 23 23:04:14 2008 Subject: cvs commit: src/etc/rc.d hostid Message-ID: <200801240704.m0O74Cep085541@repoman.freebsd.org> ru 2008-01-24 07:04:12 UTC FreeBSD src repository Modified files: etc/rc.d hostid Log: Shorter equivalent of the command. Revision Changes Path 1.8 +1 -1 src/etc/rc.d/hostid From brueffer at FreeBSD.org Wed Jan 23 23:11:30 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Wed Jan 23 23:11:32 2008 Subject: cvs commit: src/share/man/man7 ports.7 Message-ID: <200801240711.m0O7BTsP085899@repoman.freebsd.org> brueffer 2008-01-24 07:11:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) share/man/man7 ports.7 Log: MFC: rev. 1.65 Document the 'maintainer' target. Approved by: re (kensmith) Revision Changes Path 1.61.4.2 +3 -1 src/share/man/man7/ports.7 From ru at FreeBSD.org Wed Jan 23 23:24:31 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Wed Jan 23 23:24:36 2008 Subject: cvs commit: src/usr.bin/fstat/zfs Makefile Message-ID: <200801240724.m0O7OUdq089499@repoman.freebsd.org> ru 2008-01-24 07:24:30 UTC FreeBSD src repository Modified files: usr.bin/fstat/zfs Makefile Log: Style. Revision Changes Path 1.3 +2 -2 src/usr.bin/fstat/zfs/Makefile From ru at FreeBSD.org Wed Jan 23 23:25:13 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Wed Jan 23 23:25:15 2008 Subject: cvs commit: src/usr.bin/fstat Makefile Message-ID: <200801240725.m0O7PDRT089631@repoman.freebsd.org> ru 2008-01-24 07:25:13 UTC FreeBSD src repository Modified files: usr.bin/fstat Makefile Log: Flag a hack. Revision Changes Path 1.11 +2 -1 src/usr.bin/fstat/Makefile From scottl at FreeBSD.org Wed Jan 23 23:26:53 2008 From: scottl at FreeBSD.org (Scott Long) Date: Wed Jan 23 23:26:55 2008 Subject: cvs commit: src/sys/dev/amr amr.c amrreg.h amrvar.h Message-ID: <200801240726.m0O7QrQn089834@repoman.freebsd.org> scottl 2008-01-24 07:26:53 UTC FreeBSD src repository Modified files: sys/dev/amr amr.c amrreg.h amrvar.h Log: Many improvements that have been collected over time: - Improve error handling for load operations. - Fix a memory corruption bug when using certain linux management apps. - Allocate all commands up front to avoid OOM deadlocks later on. Revision Changes Path 1.85 +111 -27 src/sys/dev/amr/amr.c 1.11 +9 -0 src/sys/dev/amr/amrreg.h 1.35 +26 -16 src/sys/dev/amr/amrvar.h From silby at silby.com Wed Jan 23 23:34:27 2008 From: silby at silby.com (Mike Silbersack) Date: Wed Jan 23 23:34:31 2008 Subject: cvs commit: src/sys/netinet tcp_syncache.c In-Reply-To: <4797B77E.2090605@freebsd.org> References: <200711200656.lAK6u4bc021279@repoman.freebsd.org> <4797B77E.2090605@freebsd.org> Message-ID: <20080124005006.D93697@odysseus.silby.com> On Wed, 23 Jan 2008, Andre Oppermann wrote: > OTOH the enforcement of this rule wasn't really there before and it > may be argued that we've got a POLA violation here. A careful reading That's exactly the point. We were not enforcing timestamps since... whenever the RFC1323 code went in. Then we start enforcing them, and start getting bug reports while we're still in the beta phase. That indicates to me that we would've been likely to see many reports as time went on. If you want to put the check back in, but hide it behind a sysctl that is disabled by default, that would be ok with me. I'm not generally opposed to security improvements that only affect edge cases... but being unable to connect is not an edge case! -Mike From ru at FreeBSD.org Wed Jan 23 23:43:10 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Wed Jan 23 23:43:12 2008 Subject: cvs commit: src/gnu/lib/csu Makefile Message-ID: <200801240743.m0O7h9uu093782@repoman.freebsd.org> ru 2008-01-24 07:43:09 UTC FreeBSD src repository Modified files: gnu/lib/csu Makefile Log: Remove one more alpha leftover. Revision Changes Path 1.28 +1 -1 src/gnu/lib/csu/Makefile From ru at FreeBSD.org Wed Jan 23 23:50:12 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Wed Jan 23 23:50:18 2008 Subject: cvs commit: src/usr.bin/netstat inet.c Message-ID: <200801240750.m0O7oCEx095539@repoman.freebsd.org> ru 2008-01-24 07:50:12 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.bin/netstat inet.c Log: MFC: 1.79: Fix printing of the number of syncache entries added. Revision Changes Path 1.78.2.1 +2 -2 src/usr.bin/netstat/inet.c From des at FreeBSD.org Thu Jan 24 00:07:52 2008 From: des at FreeBSD.org (Dag-Erling Smorgrav) Date: Thu Jan 24 00:07:54 2008 Subject: cvs commit: src/lib/libfetch ftp.c Message-ID: <200801240807.m0O87qPg099038@repoman.freebsd.org> des 2008-01-24 08:07:52 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libfetch ftp.c Log: MFC: (1.101) replace fclose() with comment explaining why it's incorrect. Approved by: re (kensmith) Revision Changes Path 1.96.2.2 +5 -1 src/lib/libfetch/ftp.c From bz at FreeBSD.org Thu Jan 24 00:14:39 2008 From: bz at FreeBSD.org (Bjoern A. Zeeb) Date: Thu Jan 24 00:14:40 2008 Subject: cvs commit: src/sys/netinet in.c Message-ID: <200801240814.m0O8EdnQ000236@repoman.freebsd.org> bz 2008-01-24 08:14:39 UTC FreeBSD src repository Modified files: sys/netinet in.c Log: Differentiate between addifaddr and delifaddr for the privilege check. Reviewed by: rwatson MFC after: 2 weeks Revision Changes Path 1.103 +2 -1 src/sys/netinet/in.c From des at FreeBSD.org Thu Jan 24 00:17:18 2008 From: des at FreeBSD.org (Dag-Erling Smorgrav) Date: Thu Jan 24 00:17:24 2008 Subject: cvs commit: src/lib/libfetch Makefile common.c common.h fetch.3 fetch.c file.c ftp.c http.c Message-ID: <200801240817.m0O8HIDe000410@repoman.freebsd.org> des 2008-01-24 08:17:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libfetch Makefile common.c common.h fetch.3 fetch.c file.c ftp.c http.c Log: MFC: namespace pollution cleanup, NO_PROXY support Revision Changes Path 1.44.2.2 +16 -9 src/lib/libfetch/Makefile 1.50.2.1 +100 -50 src/lib/libfetch/common.c 1.28.2.1 +27 -26 src/lib/libfetch/common.h 1.60.2.3 +17 -11 src/lib/libfetch/fetch.3 1.38.2.1 +15 -15 src/lib/libfetch/fetch.c 1.17.2.1 +10 -10 src/lib/libfetch/file.c 1.91.2.3 +140 -128 src/lib/libfetch/ftp.c 1.76.2.3 +114 -109 src/lib/libfetch/http.c From des at FreeBSD.org Thu Jan 24 00:17:50 2008 From: des at FreeBSD.org (Dag-Erling Smorgrav) Date: Thu Jan 24 00:17:52 2008 Subject: cvs commit: src/usr.bin/fetch fetch.1 Message-ID: <200801240817.m0O8HoKY000444@repoman.freebsd.org> des 2008-01-24 08:17:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/fetch fetch.1 Log: MFC: document environment variables. Revision Changes Path 1.66.2.2 +19 -9 src/usr.bin/fetch/fetch.1 From des at FreeBSD.org Thu Jan 24 00:20:26 2008 From: des at FreeBSD.org (Dag-Erling Smorgrav) Date: Thu Jan 24 00:20:35 2008 Subject: cvs commit: src/lib/libfetch Makefile Message-ID: <200801240820.m0O8KPD5000723@repoman.freebsd.org> des 2008-01-24 08:20:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libfetch Makefile Log: Previous commit included changes which are invalid for RELENG_6. Revision Changes Path 1.44.2.3 +3 -10 src/lib/libfetch/Makefile From bz at FreeBSD.org Thu Jan 24 00:26:00 2008 From: bz at FreeBSD.org (Bjoern A. Zeeb) Date: Thu Jan 24 00:26:01 2008 Subject: cvs commit: src/sys/kern kern_jail.c src/sys/netinet ip_options.c src/sys/netinet6 in6.c ip6_output.c ip6_var.h raw_ip6.c udp6_usrreq.c src/sys/sys priv.h Message-ID: <200801240825.m0O8PxG4001023@repoman.freebsd.org> bz 2008-01-24 08:25:59 UTC FreeBSD src repository Modified files: sys/kern kern_jail.c sys/netinet ip_options.c sys/netinet6 in6.c ip6_output.c ip6_var.h raw_ip6.c udp6_usrreq.c sys/sys priv.h Log: Replace the last susers calls in netinet6/ with privilege checks. Introduce a new privilege allowing to set certain IP header options (hop-by-hop, routing headers). Leave a few comments to be addressed later. Reviewed by: rwatson (older version, before addressing his comments) Revision Changes Path 1.75 +6 -0 src/sys/kern/kern_jail.c 1.8 +1 -0 src/sys/netinet/ip_options.c 1.78 +10 -10 src/sys/netinet6/in6.c 1.113 +75 -44 src/sys/netinet6/ip6_output.c 1.41 +1 -1 src/sys/netinet6/ip6_var.h 1.76 +4 -7 src/sys/netinet6/raw_ip6.c 1.85 +1 -6 src/sys/netinet6/udp6_usrreq.c 1.18 +1 -0 src/sys/sys/priv.h From trhodes at FreeBSD.org Thu Jan 24 01:46:05 2008 From: trhodes at FreeBSD.org (Tom Rhodes) Date: Thu Jan 24 01:46:09 2008 Subject: cvs commit: src/usr.sbin/ntp Makefile src/usr.sbin/ntp/doc Makefile Message-ID: <200801240946.m0O9k5OF017270@repoman.freebsd.org> trhodes 2008-01-24 09:46:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/ntp Makefile usr.sbin/ntp/doc Makefile Log: MFC: : ru 2006-03-15 11:17:31 UTC : : FreeBSD src repository : : Modified files: : usr.sbin/ntp Makefile : usr.sbin/ntp/doc Makefile : Log: : If we don't want HTML docs, we might still want manpages. : If we don't want manpages, we might still want HTML docs. : : Revision Changes Path : 1.12 +0 -3 src/usr.sbin/ntp/Makefile : 1.12 +2 -0 src/usr.sbin/ntp/doc/Makefile PR: 118261 Revision Changes Path 1.11.2.1 +0 -3 src/usr.sbin/ntp/Makefile 1.11.2.2 +2 -0 src/usr.sbin/ntp/doc/Makefile From andre at freebsd.org Thu Jan 24 02:57:41 2008 From: andre at freebsd.org (Andre Oppermann) Date: Thu Jan 24 02:57:47 2008 Subject: cvs commit: src/sys/netinet tcp_syncache.c In-Reply-To: <20080124005006.D93697@odysseus.silby.com> References: <200711200656.lAK6u4bc021279@repoman.freebsd.org> <4797B77E.2090605@freebsd.org> <20080124005006.D93697@odysseus.silby.com> Message-ID: <47986F27.10401@freebsd.org> Mike Silbersack wrote: > > On Wed, 23 Jan 2008, Andre Oppermann wrote: > >> OTOH the enforcement of this rule wasn't really there before and it >> may be argued that we've got a POLA violation here. A careful reading > > That's exactly the point. We were not enforcing timestamps since... > whenever the RFC1323 code went in. Then we start enforcing them, and > start getting bug reports while we're still in the beta phase. That > indicates to me that we would've been likely to see many reports as time > went on. I'm complaining about not fixing or modifying the test. The rationale and comments to the change are not correct and a different fix would be more appropriate. > If you want to put the check back in, but hide it behind a sysctl that > is disabled by default, that would be ok with me. The check is fine. However in the edge case it should not cause the connection to be aborted but it should disable timestamps locally. There is no point in sending them if they do not get returned. > I'm not generally opposed to security improvements that only affect edge > cases... but being unable to connect is not an edge case! Fully agreed. I'll reopen the PR and follow up with the originator to do some further analysis. All operating system he cites that were unable to connect correctly send timestamps and do not stop after the SYN phase. So there must be something else at play here. Have you received or heart of any *other* reports that may be related to the timestamp check? -- Andre From andre at freebsd.org Thu Jan 24 02:58:18 2008 From: andre at freebsd.org (Andre Oppermann) Date: Thu Jan 24 02:58:21 2008 Subject: cvs commit: src/sys/netinet tcp_syncache.c In-Reply-To: References: <200711200656.lAK6u4bc021279@repoman.freebsd.org> <4797B77E.2090605@freebsd.org> Message-ID: <47986F4D.6070208@freebsd.org> Kip Macy wrote: > Did you talk to the original submitter? Note that FreeBSD's TCP stack > is for use in servers and is not intending as a validating TCP stack. > If you would like it to serve as such you would better served by > tracking down the ANVL tests that FreeBSD fails. Also note that there > is no MUST in the following sentence: > > > "For simplicity and symmetry, we specify that > timestamps always be sent and echoed in both directions." > > So it is clearly open to interpretation. No, it is not. RFC1323 was written in 1992 before RFCs contained the boiler plate definition of MUST, SHOULD, MAY and so on. I, at least as a non-native English speaker, find the sentence perfectly clear and without any doubt. The IETF TCPM working group comes to the same conclusion. And I suppose many native English speakers too. Despite that arguing over whether "always" lacks a "MUST" to make it really always always and never not you cited the wrong part of RFC1323 as reason to completely remove the check. That's what I'm complaining about. Everyone in FreeBSD, including you and me, should at least provide the correct citation and rationale for any code change irrespective of the eventual merit of the change itself which is a separate issue. -- Andre From pjd at FreeBSD.org Thu Jan 24 03:21:55 2008 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Thu Jan 24 03:22:03 2008 Subject: cvs commit: src/sys/compat/opensolaris/kern opensolaris_kmem.c src/sys/compat/opensolaris/sys kmem.h Message-ID: <200801241121.m0OBLtRw030186@repoman.freebsd.org> pjd 2008-01-24 11:21:54 UTC FreeBSD src repository Modified files: sys/compat/opensolaris/kern opensolaris_kmem.c sys/compat/opensolaris/sys kmem.h Log: Change type of kmem_used() and kmem_size() functions to uint64_t, so it doesn't overflow in arc.c in this check: if (kmem_used() > (kmem_size() * 4) / 5) return (1); With this bug ZFS almost doesn't cache. Only 32bit machines are affected that have vm.kmem_size set to values >=1GB. Reported by: David Taylor Revision Changes Path 1.3 +5 -5 src/sys/compat/opensolaris/kern/opensolaris_kmem.c 1.4 +3 -3 src/sys/compat/opensolaris/sys/kmem.h From pjd at FreeBSD.org Thu Jan 24 03:24:16 2008 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Thu Jan 24 03:24:21 2008 Subject: cvs commit: src/sys/contrib/opensolaris/uts/common/fs/zfs arc.c Message-ID: <200801241124.m0OBOGjr030293@repoman.freebsd.org> pjd 2008-01-24 11:24:16 UTC FreeBSD src repository Modified files: sys/contrib/opensolaris/uts/common/fs/zfs arc.c Log: - Reduce how much ZFS caches by default. This is another change to mitigate 'kmem_map too small panics'. - Print two warnings if there is not enough memory and not enough address space. - Improve comment. Revision Changes Path 1.14 +5 -4 src/sys/contrib/opensolaris/uts/common/fs/zfs/arc.c From maxim at macomnet.ru Thu Jan 24 03:58:57 2008 From: maxim at macomnet.ru (Maxim Konovalov) Date: Thu Jan 24 03:59:06 2008 Subject: cvs commit: src/sys/netinet tcp_syncache.c In-Reply-To: <47986F27.10401@freebsd.org> References: <200711200656.lAK6u4bc021279@repoman.freebsd.org> <4797B77E.2090605@freebsd.org> <20080124005006.D93697@odysseus.silby.com> <47986F27.10401@freebsd.org> Message-ID: <20080124145713.K15031@mp2.macomnet.net> [...] > > I'm not generally opposed to security improvements that only affect edge > > cases... but being unable to connect is not an edge case! > > Fully agreed. I'll reopen the PR and follow up with the originator > to do some further analysis. All operating system he cites that were > unable to connect correctly send timestamps and do not stop after > the SYN phase. So there must be something else at play here. Have > you received or heart of any *other* reports that may be related to > the timestamp check? > I saw this with my adsl router. Happy to test patches. -- Maxim Konovalov From marck at FreeBSD.org Thu Jan 24 04:10:00 2008 From: marck at FreeBSD.org (Dmitry Morozovsky) Date: Thu Jan 24 04:10:03 2008 Subject: cvs commit: src/share/man/man4 puc.4 Message-ID: <200801241209.m0OC9xAi034366@repoman.freebsd.org> marck 2008-01-24 12:09:59 UTC FreeBSD src repository (doc committer) Modified files: share/man/man4 puc.4 Log: There is no PUC_FASTINTR option anymore. MFC after: 2 weeks Revision Changes Path 1.5 +1 -12 src/share/man/man4/puc.4 From attilio at FreeBSD.org Thu Jan 24 04:34:30 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Thu Jan 24 04:34:36 2008 Subject: cvs commit: src/sys/dev/usb ehci.c if_udav.c src/sys/fs/cd9660 cd9660_vfsops.c src/sys/fs/hpfs hpfs_subr.h hpfs_vfsops.c src/sys/fs/msdosfs msdosfs_denode.c src/sys/fs/ntfs ntfs_subr.c src/sys/fs/nullfs null_vnops.c src/sys/fs/nwfs nwfs_node.c ... Message-ID: <200801241234.m0OCYU8N036792@repoman.freebsd.org> attilio 2008-01-24 12:34:30 UTC FreeBSD src repository Modified files: sys/dev/usb ehci.c if_udav.c sys/fs/cd9660 cd9660_vfsops.c sys/fs/hpfs hpfs_subr.h hpfs_vfsops.c sys/fs/msdosfs msdosfs_denode.c sys/fs/ntfs ntfs_subr.c sys/fs/nullfs null_vnops.c sys/fs/nwfs nwfs_node.c sys/fs/smbfs smbfs_node.c sys/fs/udf udf_vfsops.c sys/fs/unionfs union_subr.c sys/gnu/fs/ext2fs ext2_vfsops.c sys/gnu/fs/reiserfs reiserfs_inode.c sys/kern kern_lock.c vfs_default.c vfs_mount.c vfs_subr.c sys/netncp ncp_conn.c sys/netsmb smb_conn.c sys/nfs4client nfs4_idmap.c sys/nfsclient nfs_node.c sys/sys buf.h lockmgr.h sys/ufs/ffs ffs_snapshot.c ffs_vfsops.c ffs_vnops.c sys/ufs/ufs ufs_extattr.c Log: Cleanup lockmgr interface and exported KPI: - Remove the "thread" argument from the lockmgr() function as it is always curthread now - Axe lockcount() function as it is no longer used - Axe LOCKMGR_ASSERT() as it is bogus really and no currently used. Hopefully this will be soonly replaced by something suitable for it. - Remove the prototype for dumplockinfo() as the function is no longer present Addictionally: - Introduce a KASSERT() in lockstatus() in order to let it accept only curthread or NULL as they should only be passed - Do a little bit of style(9) cleanup on lockmgr.h KPI results heavilly broken by this change, so manpages and FreeBSD_version will be modified accordingly by further commits. Tested by: matteo Revision Changes Path 1.58 +2 -2 src/sys/dev/usb/ehci.c 1.35 +0 -8 src/sys/dev/usb/if_udav.c 1.154 +1 -1 src/sys/fs/cd9660/cd9660_vfsops.c 1.5 +2 -2 src/sys/fs/hpfs/hpfs_subr.h 1.64 +2 -4 src/sys/fs/hpfs/hpfs_vfsops.c 1.99 +2 -4 src/sys/fs/msdosfs/msdosfs_denode.c 1.44 +8 -11 src/sys/fs/ntfs/ntfs_subr.c 1.98 +1 -2 src/sys/fs/nullfs/null_vnops.c 1.41 +10 -11 src/sys/fs/nwfs/nwfs_node.c 1.36 +4 -3 src/sys/fs/smbfs/smbfs_node.c 1.53 +1 -1 src/sys/fs/udf/udf_vfsops.c 1.99 +1 -1 src/sys/fs/unionfs/union_subr.c 1.170 +1 -1 src/sys/gnu/fs/ext2fs/ext2_vfsops.c 1.5 +2 -2 src/sys/gnu/fs/reiserfs/reiserfs_inode.c 1.120 +7 -24 src/sys/kern/kern_lock.c 1.140 +3 -4 src/sys/kern/vfs_default.c 1.273 +3 -3 src/sys/kern/vfs_mount.c 1.717 +2 -2 src/sys/kern/vfs_subr.c 1.31 +16 -16 src/sys/netncp/ncp_conn.c 1.19 +7 -9 src/sys/netsmb/smb_conn.c 1.6 +3 -3 src/sys/nfs4client/nfs4_idmap.c 1.87 +1 -1 src/sys/nfsclient/nfs_node.c 1.199 +3 -3 src/sys/sys/buf.h 1.58 +4 -27 src/sys/sys/lockmgr.h 1.140 +20 -26 src/sys/ufs/ffs/ffs_snapshot.c 1.335 +1 -1 src/sys/ufs/ffs/ffs_vfsops.c 1.177 +3 -3 src/sys/ufs/ffs/ffs_vnops.c 1.89 +2 -2 src/sys/ufs/ufs/ufs_extattr.c From attilio at FreeBSD.org Thu Jan 24 04:37:55 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Thu Jan 24 04:37:58 2008 Subject: cvs commit: src/sys/sys param.h Message-ID: <200801241237.m0OCbtcn037346@repoman.freebsd.org> attilio 2008-01-24 12:37:54 UTC FreeBSD src repository Modified files: sys/sys param.h Log: Bump __FreeBSD_version in order to signal: - lockmgr() prototype changing - lockcount() axing - LOCKMGR_ASSERT() axing Revision Changes Path 1.328 +1 -1 src/sys/sys/param.h From ru at FreeBSD.org Thu Jan 24 05:33:01 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Thu Jan 24 05:33:09 2008 Subject: cvs commit: src/share/mk sys.mk Message-ID: <200801241333.m0ODX0bg056404@repoman.freebsd.org> ru 2008-01-24 13:33:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/mk sys.mk Log: MFC: 1.95: Weed out a warning argument that isn't applicable to C++ code. Revision Changes Path 1.92.2.2 +1 -1 src/share/mk/sys.mk From ru at FreeBSD.org Thu Jan 24 05:48:22 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Thu Jan 24 05:48:28 2008 Subject: cvs commit: src/share/man/man4 sched_4bsd.4 sched_ule.4 Message-ID: <200801241348.m0ODmKZu057100@repoman.freebsd.org> ru 2008-01-24 13:48:20 UTC FreeBSD src repository Modified files: share/man/man4 sched_4bsd.4 sched_ule.4 Log: - sched_4bsd is no longer a default system scheduler on some architectures, so call it "traditional" instead. - sched_ule is no longer buggy or experimental (according to rev. 1.7 of sched_ule(4)), so don't call it experimental (reported by a user on stable@). Reviewed by: rwatson Revision Changes Path 1.6 +2 -2 src/share/man/man4/sched_4bsd.4 1.8 +3 -11 src/share/man/man4/sched_ule.4 From attilio at FreeBSD.org Thu Jan 24 06:17:54 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Thu Jan 24 06:18:00 2008 Subject: cvs commit: src/share/man/man9 lock.9 Message-ID: <200801241417.m0OEHqc5060268@repoman.freebsd.org> attilio 2008-01-24 14:17:52 UTC FreeBSD src repository Modified files: share/man/man9 lock.9 Log: Reflect lockcount() axing and lockmgr() prototype changing. Revision Changes Path 1.22 +2 -20 src/share/man/man9/lock.9 From karels at karels.net Thu Jan 24 06:40:28 2008 From: karels at karels.net (Mike Karels) Date: Thu Jan 24 06:40:43 2008 Subject: cvs commit: src/sys/netinet tcp_syncache.c In-Reply-To: Your message of Thu, 24 Jan 2008 11:58:21 +0100. <47986F4D.6070208@freebsd.org> Message-ID: <200801241414.m0OEECWt097838@redrock.karels.net> Return-Path: owner-freebsd-net@freebsd.org Delivery-Date: Thu Jan 24 05:00:27 2008 Received: from staring.karels.net (root@staring.karels.net [206.196.45.1]) by redrock.karels.net (8.13.8/8.13.6) with ESMTP id m0OB0Rb6097199 for ; Thu, 24 Jan 2008 05:00:27 -0600 (CST) (envelope-from owner-freebsd-net@freebsd.org) Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53]) by staring.karels.net (8.11.6/8.11.2) with ESMTP id m0OB0QA08500 for ; Thu, 24 Jan 2008 05:00:26 -0600 (CST) Received: from hub.freebsd.org (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 398C833428; Thu, 24 Jan 2008 10:58:25 +0000 (UTC) (envelope-from owner-freebsd-net@freebsd.org) Received: from hub.freebsd.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 10EE016A419; Thu, 24 Jan 2008 10:58:25 +0000 (UTC) (envelope-from owner-freebsd-net@freebsd.org) Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CE46B16A478 for ; Thu, 24 Jan 2008 10:58:18 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 2909C13C4DD for ; Thu, 24 Jan 2008 10:58:17 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 98697 invoked from network); 24 Jan 2008 10:19:32 -0000 Received: from localhost (HELO [127.0.0.1]) ([127.0.0.1]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 24 Jan 2008 10:19:32 -0000 Message-ID: <47986F4D.6070208@freebsd.org> Date: Thu, 24 Jan 2008 11:58:21 +0100 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.14 (Windows/20071210) MIME-Version: 1.0 To: Kip Macy References: <200711200656.lAK6u4bc021279@repoman.freebsd.org> <4797B77E.2090605@freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Mike Silbersack , kmacy@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, src-committers@freebsd.org, freebsd-net@freebsd.org Subject: Re: cvs commit: src/sys/netinet tcp_syncache.c X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: owner-freebsd-net@freebsd.org Errors-To: owner-freebsd-net@freebsd.org > Kip Macy wrote: > > So it is clearly open to interpretation. > No, it is not. RFC1323 was written in 1992 before RFCs contained the > boiler plate definition of MUST, SHOULD, MAY and so on. The use of MUST, etc, originated in RFC1122 in 1989. That RFC also contains this: 1.2.2 Robustness Principle At every layer of the protocols, there is a general rule whose application can lead to enormous benefits in robustness and interoperability [IP:1]: "Be liberal in what you accept, and conservative in what you send" This quote is also on the RFC1122 working group coffee cup on my shelf. It seems to apply here. Mike From kib at FreeBSD.org Thu Jan 24 07:37:49 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Thu Jan 24 07:37:52 2008 Subject: cvs commit: src/sys/dev/syscons syscons.c Message-ID: <200801241537.m0OFbmhU066967@repoman.freebsd.org> kib 2008-01-24 15:37:48 UTC FreeBSD src repository Modified files: sys/dev/syscons syscons.c Log: Do not dereference NULL scp in the case the screen is not opened. Instead, return ENXIO to the ioctl caller. Reported and tested by: Pawel Worach Discussed with: markus MFC after: 3 days Revision Changes Path 1.457 +2 -0 src/sys/dev/syscons/syscons.c From kostikbel at gmail.com Thu Jan 24 07:41:00 2008 From: kostikbel at gmail.com (Kostik Belousov) Date: Thu Jan 24 07:41:03 2008 Subject: cvs commit: src/sys/dev/syscons syscons.c In-Reply-To: <200801241537.m0OFbmhU066967@repoman.freebsd.org> References: <200801241537.m0OFbmhU066967@repoman.freebsd.org> Message-ID: <20080124154057.GE57756@deviant.kiev.zoral.com.ua> On Thu, Jan 24, 2008 at 03:37:48PM +0000, Konstantin Belousov wrote: > kib 2008-01-24 15:37:48 UTC > > FreeBSD src repository > > Modified files: > sys/dev/syscons syscons.c > Log: > Do not dereference NULL scp in the case the screen is not opened. > Instead, return ENXIO to the ioctl caller. > > Reported and tested by: Pawel Worach > Discussed with: markus With marcus, really. My apology. > MFC after: 3 days > > Revision Changes Path > 1.457 +2 -0 src/sys/dev/syscons/syscons.c -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 195 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080124/56d4d543/attachment.pgp From rafan at FreeBSD.org Thu Jan 24 07:47:33 2008 From: rafan at FreeBSD.org (Rong-En Fan) Date: Thu Jan 24 07:47:36 2008 Subject: cvs commit: src/usr.bin/file config.h file.1 magic.5 src/lib/libmagic Makefile config.h src/contrib/file ChangeLog FREEBSD-upgrade LEGAL.NOTICE Localstuff MAINT Makefile.am Makefile.in README aclocal.m4 apprentice.c apptype.c ascmagic.c ... Message-ID: <200801241547.m0OFlXDJ067622@repoman.freebsd.org> rafan 2008-01-24 15:47:33 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/file config.h file.1 magic.5 lib/libmagic Makefile config.h contrib/file ChangeLog FREEBSD-upgrade LEGAL.NOTICE Localstuff MAINT Makefile.am Makefile.in README aclocal.m4 apprentice.c apptype.c ascmagic.c compress.c config.h.in configure configure.in file.c file.h file.man fsmagic.c funcs.c install-sh is_tar.c libmagic.man magic.c magic.h magic.man magic.mime magic2mime mkinstalldirs names.h patchlevel.h print.c readelf.c readelf.h softmagic.c tar.h test.c contrib/file/Magdir adventure amigaos animation apple archive audio bout c-lang c64 cad commands compress console ctags database diff digital dump editors elf filesystems flash fonts fsav gnu iff images java linux lisp mach macintosh mail.news maple mathematica mime mips misctools msdos ncr os2 perl printer psion python revision riff sgi sgml sharc sql sun sysex tex tgif varied.out varied.script vmware wordprocessors xwindows Added files: (Branch: RELENG_6) contrib/file/Magdir basis bflt btsnoop cafebabe cracklib mup os400 scientific unicode Log: MFC file 4.21 Revision Changes Path 1.1.1.2.2.1 +290 -0 src/contrib/file/ChangeLog 1.4.14.1 +14 -3 src/contrib/file/FREEBSD-upgrade 1.1.1.3.2.1 +2 -2 src/contrib/file/LEGAL.NOTICE 1.1.1.2.8.1 +1 -1 src/contrib/file/Localstuff 1.1.1.2.8.1 +31 -19 src/contrib/file/MAINT 1.1.1.3.8.1 +33 -21 src/contrib/file/Magdir/adventure 1.1.1.4.8.1 +7 -0 src/contrib/file/Magdir/amigaos 1.1.1.6.2.1 +157 -133 src/contrib/file/Magdir/animation 1.1.1.3.8.1 +41 -0 src/contrib/file/Magdir/apple 1.1.1.8.2.1 +434 -23 src/contrib/file/Magdir/archive 1.1.1.7.2.1 +160 -13 src/contrib/file/Magdir/audio 1.1.1.1.6.1 +16 -0 src/contrib/file/Magdir/basis (new) 1.1.1.1.6.1 +12 -0 src/contrib/file/Magdir/bflt (new) 1.1.1.1.8.1 +1 -1 src/contrib/file/Magdir/bout 1.1.1.1.6.1 +11 -0 src/contrib/file/Magdir/btsnoop (new) 1.1.1.2.8.1 +2 -2 src/contrib/file/Magdir/c-lang 1.1.1.1.8.1 +17 -2 src/contrib/file/Magdir/c64 1.1.1.1.8.1 +40 -7 src/contrib/file/Magdir/cad 1.1.1.1.6.1 +21 -0 src/contrib/file/Magdir/cafebabe (new) 1.1.1.4.8.1 +4 -1 src/contrib/file/Magdir/commands 1.1.1.4.8.1 +25 -8 src/contrib/file/Magdir/compress 1.1.1.3.2.1 +26 -30 src/contrib/file/Magdir/console 1.1.1.1.6.1 +13 -0 src/contrib/file/Magdir/cracklib (new) 1.1.1.2.12.1 +1 -1 src/contrib/file/Magdir/ctags 1.1.1.4.8.1 +9 -0 src/contrib/file/Magdir/database 1.1.1.2.8.1 +2 -0 src/contrib/file/Magdir/diff 1.1.1.1.16.1 +2 -2 src/contrib/file/Magdir/digital 1.1.1.1.16.1 +12 -0 src/contrib/file/Magdir/dump 1.1.1.2.14.1 +4 -0 src/contrib/file/Magdir/editors 1.1.1.10.2.1 +72 -68 src/contrib/file/Magdir/elf 1.1.1.8.2.1 +901 -29 src/contrib/file/Magdir/filesystems 1.1.1.3.8.1 +3 -0 src/contrib/file/Magdir/flash 1.1.1.2.8.1 +3 -0 src/contrib/file/Magdir/fonts 1.1.1.1.16.1 +52 -19 src/contrib/file/Magdir/fsav 1.1.1.2.8.1 +11 -1 src/contrib/file/Magdir/gnu 1.1.1.2.8.1 +30 -2 src/contrib/file/Magdir/iff 1.1.1.8.8.1 +19 -9 src/contrib/file/Magdir/images 1.1.1.1.16.1 +3 -5 src/contrib/file/Magdir/java 1.1.1.4.2.1 +69 -1 src/contrib/file/Magdir/linux 1.1.1.4.12.1 +14 -2 src/contrib/file/Magdir/lisp 1.1.1.2.8.1 +50 -12 src/contrib/file/Magdir/mach 1.1.1.5.8.1 +1 -1 src/contrib/file/Magdir/macintosh 1.1.1.3.8.1 +3 -2 src/contrib/file/Magdir/mail.news 1.1.1.2.8.1 +0 -1 src/contrib/file/Magdir/maple 1.1.1.2.8.1 +1 -1 src/contrib/file/Magdir/mathematica 1.1.1.1.16.1 +1 -1 src/contrib/file/Magdir/mime 1.1.1.1.16.1 +2 -2 src/contrib/file/Magdir/mips 1.1.1.1.8.1 +10 -2 src/contrib/file/Magdir/misctools 1.1.1.7.2.1 +359 -137 src/contrib/file/Magdir/msdos 1.1.1.1.6.1 +22 -0 src/contrib/file/Magdir/mup (new) 1.1.1.1.16.1 +2 -2 src/contrib/file/Magdir/ncr 1.1.1.2.8.1 +1 -1 src/contrib/file/Magdir/os2 1.1.1.2.6.1 +37 -0 src/contrib/file/Magdir/os400 (new) 1.1.1.3.2.1 +21 -4 src/contrib/file/Magdir/perl 1.1.1.3.8.1 +4 -0 src/contrib/file/Magdir/printer 1.1.1.1.8.1 +3 -3 src/contrib/file/Magdir/psion 1.1.1.3.8.1 +5 -0 src/contrib/file/Magdir/python 1.1.1.1.8.1 +5 -1 src/contrib/file/Magdir/revision 1.1.1.4.8.1 +8 -0 src/contrib/file/Magdir/riff 1.1.1.1.6.1 +60 -0 src/contrib/file/Magdir/scientific (new) 1.1.1.3.8.1 +6 -6 src/contrib/file/Magdir/sgi 1.1.1.3.8.1 +2 -1 src/contrib/file/Magdir/sgml 1.1.1.1.16.1 +1 -1 src/contrib/file/Magdir/sharc 1.1.1.1.14.1 +27 -0 src/contrib/file/Magdir/sql 1.1.1.2.8.1 +8 -0 src/contrib/file/Magdir/sun 1.1.1.2.8.1 +125 -2 src/contrib/file/Magdir/sysex 1.1.1.3.2.1 +14 -14 src/contrib/file/Magdir/tex 1.1.1.1.16.1 +1 -1 src/contrib/file/Magdir/tgif 1.1.1.1.6.1 +15 -0 src/contrib/file/Magdir/unicode (new) 1.1.1.4.8.1 +9 -2 src/contrib/file/Magdir/varied.out 1.1.1.1.8.1 +1 -1 src/contrib/file/Magdir/varied.script 1.1.1.2.8.1 +0 -7 src/contrib/file/Magdir/vmware 1.1.1.1.8.1 +28 -3 src/contrib/file/Magdir/wordprocessors 1.1.1.1.8.1 +1 -1 src/contrib/file/Magdir/xwindows 1.1.1.9.2.1 +17 -5 src/contrib/file/Makefile.am 1.1.1.11.2.1 +197 -84 src/contrib/file/Makefile.in 1.1.1.7.8.1 +3 -2 src/contrib/file/README 1.1.1.8.2.1 +6409 -3982 src/contrib/file/aclocal.m4 1.1.1.9.2.1 +900 -278 src/contrib/file/apprentice.c 1.1.1.1.8.1 +1 -1 src/contrib/file/apptype.c 1.1.1.7.2.1 +85 -57 src/contrib/file/ascmagic.c 1.1.1.6.2.1 +133 -49 src/contrib/file/compress.c 1.1.1.8.2.1 +21 -0 src/contrib/file/config.h.in 1.1.1.10.2.1 +17013 -4883 src/contrib/file/configure 1.1.1.10.2.1 +10 -13 src/contrib/file/configure.in 1.1.1.10.2.1 +89 -25 src/contrib/file/file.c 1.1.1.8.2.2 +168 -94 src/contrib/file/file.h 1.1.1.8.8.1 +37 -8 src/contrib/file/file.man 1.1.1.4.2.1 +3 -1 src/contrib/file/fsmagic.c 1.1.1.2.2.2 +200 -27 src/contrib/file/funcs.c 1.1.1.2.2.1 +281 -209 src/contrib/file/install-sh 1.1.1.4.2.1 +10 -2 src/contrib/file/is_tar.c 1.1.1.1.8.1 +0 -2 src/contrib/file/libmagic.man 1.1.1.2.2.2 +114 -69 src/contrib/file/magic.c 1.1.1.2.2.1 +20 -11 src/contrib/file/magic.h 1.1.1.6.8.1 +197 -40 src/contrib/file/magic.man 1.1.1.7.2.1 +96 -47 src/contrib/file/magic.mime 1.1.1.2.8.1 +3 -2 src/contrib/file/magic2mime 1.1.1.3.2.1 +118 -59 src/contrib/file/mkinstalldirs 1.1.1.4.2.1 +3 -1 src/contrib/file/names.h 1.1.1.11.2.1 +32 -2 src/contrib/file/patchlevel.h 1.1.1.8.2.1 +72 -34 src/contrib/file/print.c 1.1.1.7.2.1 +327 -172 src/contrib/file/readelf.c 1.1.1.4.2.1 +2 -0 src/contrib/file/readelf.h 1.1.1.10.2.1 +927 -551 src/contrib/file/softmagic.c 1.1.1.3.2.1 +3 -72 src/contrib/file/tar.h 1.1.1.2.2.1 +4 -4 src/contrib/file/test.c 1.6.2.2 +3 -1 src/lib/libmagic/Makefile 1.2.2.1 +60 -54 src/lib/libmagic/config.h 1.9.2.1 +60 -54 src/usr.bin/file/config.h 1.36.2.1 +40 -7 src/usr.bin/file/file.1 1.23.2.1 +202 -30 src/usr.bin/file/magic.5 From dumbbell at FreeBSD.org Thu Jan 24 09:10:19 2008 From: dumbbell at FreeBSD.org (Jean-Sebastien Pedron) Date: Thu Jan 24 09:10:25 2008 Subject: cvs commit: src/sys/sys event.h src/sys/kern vfs_aio.c Message-ID: <200801241710.m0OHAJCG083388@repoman.freebsd.org> dumbbell 2008-01-24 17:10:19 UTC FreeBSD src repository Modified files: sys/sys event.h sys/kern vfs_aio.c Log: When asked to use kqueue, AIO stores its internal state in the `kn_sdata' member of the newly registered knote. The problem is that this member is overwritten by a call to kevent(2) with the EV_ADD flag, targetted at the same kevent/knote. For instance, a userland application may set the pointer to NULL, leading to a panic. A testcase was provided by the submitter. PR: kern/118911 Submitted by: MOROHOSHI Akihiko MFC after: 1 day Revision Changes Path 1.237 +6 -4 src/sys/kern/vfs_aio.c 1.38 +2 -0 src/sys/sys/event.h From jhb at FreeBSD.org Thu Jan 24 10:52:27 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 24 10:52:29 2008 Subject: cvs commit: src/sys/dev/acpica acpi_hpet.c acpi_hpet.h Message-ID: <200801241852.m0OIqQPq095806@repoman.freebsd.org> jhb 2008-01-24 18:52:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/dev/acpica acpi_hpet.c Added files: (Branch: RELENG_7_0) sys/dev/acpica acpi_hpet.h Log: MFC: Fix some minor issues such as using read/modify/write for updating the configuration register and add a header file to hold HPET register constants. Approved by: re (kensmith) Revision Changes Path 1.12.4.1 +58 -20 src/sys/dev/acpica/acpi_hpet.c 1.1.6.1 +65 -0 src/sys/dev/acpica/acpi_hpet.h (new) From jhb at FreeBSD.org Thu Jan 24 10:53:29 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 24 10:53:31 2008 Subject: cvs commit: src/sys/dev/pci pci_user.c Message-ID: <200801241853.m0OIrTaN095858@repoman.freebsd.org> jhb 2008-01-24 18:53:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/dev/pci pci_user.c Log: MFC: Don't cache the new-bus name of a PCI device in the PCI conf structure. Approved by: re (kensmith) Revision Changes Path 1.22.2.1.2.2 +4 -1 src/sys/dev/pci/pci_user.c From jhb at FreeBSD.org Thu Jan 24 11:11:14 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 24 11:11:20 2008 Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb Makefile kgdb.h kld.c trgt.c Message-ID: <200801241911.m0OJBDLd097854@repoman.freebsd.org> jhb 2008-01-24 19:11:13 UTC FreeBSD src repository Modified files: gnu/usr.bin/gdb/kgdb Makefile kgdb.h trgt.c Added files: gnu/usr.bin/gdb/kgdb kld.c Log: Move the code for working with kld's out into its own file. Revision Changes Path 1.7 +1 -1 src/gnu/usr.bin/gdb/kgdb/Makefile 1.8 +1 -0 src/gnu/usr.bin/gdb/kgdb/kgdb.h 1.1 +304 -0 src/gnu/usr.bin/gdb/kgdb/kld.c (new) 1.7 +0 -268 src/gnu/usr.bin/gdb/kgdb/trgt.c From jhb at FreeBSD.org Thu Jan 24 11:42:18 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 24 11:42:24 2008 Subject: cvs commit: src/lib/libstand Makefile src/sbin/gpt Makefile add.c boot.c gpt.8 gpt.c gpt.h show.c src/sys/boot/i386 Makefile src/sys/boot/i386/gptboot Makefile gptboot.c gptldr.S src/sys/boot/i386/libi386 biosdisk.c devicename.c ... Message-ID: <200801241942.m0OJgH5J000300@repoman.freebsd.org> jhb 2008-01-24 19:42:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libstand Makefile sbin/gpt Makefile add.c gpt.8 gpt.c gpt.h show.c sys/boot/i386 Makefile sys/boot/i386/libi386 biosdisk.c devicename.c sys/boot/pc98/libpc98 biosdisk.c sys/geom/part g_part.c g_part.h g_part_gpt.c sys/sys gpt.h Added files: (Branch: RELENG_7) sbin/gpt boot.c sys/boot/i386/gptboot Makefile gptboot.c gptldr.S sys/boot/i386/pmbr Makefile pmbr.s Log: MFC: Add support for booting from GPT-labeled disks from the BIOS. This includes /boot/pmbr, /boot/gptboot, and 'gpt boot'. Revision Changes Path 1.57.2.2 +4 -0 src/lib/libstand/Makefile 1.7.2.1 +2 -2 src/sbin/gpt/Makefile 1.15.2.1 +44 -32 src/sbin/gpt/add.c 1.2.2.1 +271 -0 src/sbin/gpt/boot.c (new) 1.17.2.1 +43 -2 src/sbin/gpt/gpt.8 1.16.2.2 +1 -0 src/sbin/gpt/gpt.c 1.11.2.1 +2 -0 src/sbin/gpt/gpt.h 1.14.2.1 +3 -0 src/sbin/gpt/show.c 1.21.2.1 +2 -2 src/sys/boot/i386/Makefile 1.62.2.1 +77 -0 src/sys/boot/i386/gptboot/Makefile (new) 1.86.2.1 +727 -0 src/sys/boot/i386/gptboot/gptboot.c (new) 1.2.2.1 +125 -0 src/sys/boot/i386/gptboot/gptldr.S (new) 1.48.2.4 +307 -35 src/sys/boot/i386/libi386/biosdisk.c 1.8.2.1 +29 -12 src/sys/boot/i386/libi386/devicename.c 1.1.2.1 +14 -0 src/sys/boot/i386/pmbr/Makefile (new) 1.2.2.1 +223 -0 src/sys/boot/i386/pmbr/pmbr.s (new) 1.34.2.4 +33 -32 src/sys/boot/pc98/libpc98/biosdisk.c 1.9.2.2 +1 -0 src/sys/geom/part/g_part.c 1.3.2.2 +1 -0 src/sys/geom/part/g_part.h 1.3.2.2 +8 -0 src/sys/geom/part/g_part_gpt.c 1.10.2.2 +3 -1 src/sys/sys/gpt.h From lulf at FreeBSD.org Thu Jan 24 12:23:11 2008 From: lulf at FreeBSD.org (Ulf Lilleengen) Date: Thu Jan 24 12:23:18 2008 Subject: cvs commit: src/sys/modules/geom Makefile Message-ID: <200801242023.m0OKN9hD003896@repoman.freebsd.org> lulf 2008-01-24 20:23:08 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/modules/geom Makefile Log: - Add geom_virstor to the module build. PR: kern/119902 Submitted by: Yoshihiro Ota Approved by: re (kensmith), pjd (mentor) Revision Changes Path 1.19.2.1 +1 -0 src/sys/modules/geom/Makefile From lulf at FreeBSD.org Thu Jan 24 12:28:28 2008 From: lulf at FreeBSD.org (Ulf Lilleengen) Date: Thu Jan 24 12:28:36 2008 Subject: cvs commit: src/sys/modules/geom Makefile Message-ID: <200801242028.m0OKSSDk004104@repoman.freebsd.org> lulf 2008-01-24 20:28:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/modules/geom Makefile Log: - Add geom_virstor to the module build. PR: kern/119902 Submitted by: Yoshihiro Ota Approved by: re (kensmith), pjd (mentor) Revision Changes Path 1.19.4.1 +1 -0 src/sys/modules/geom/Makefile From kip.macy at gmail.com Thu Jan 24 13:11:17 2008 From: kip.macy at gmail.com (Kip Macy) Date: Thu Jan 24 13:11:20 2008 Subject: cvs commit: src/sys/netinet tcp_syncache.c In-Reply-To: <47986F4D.6070208@freebsd.org> References: <200711200656.lAK6u4bc021279@repoman.freebsd.org> <4797B77E.2090605@freebsd.org> <47986F4D.6070208@freebsd.org> Message-ID: Whatever, just run all future changes by silby. On Jan 24, 2008 2:58 AM, Andre Oppermann wrote: > Kip Macy wrote: > > Did you talk to the original submitter? Note that FreeBSD's TCP stack > > is for use in servers and is not intending as a validating TCP stack. > > If you would like it to serve as such you would better served by > > tracking down the ANVL tests that FreeBSD fails. Also note that there > > is no MUST in the following sentence: > > > > > > "For simplicity and symmetry, we specify that > > timestamps always be sent and echoed in both directions." > > > > So it is clearly open to interpretation. > > No, it is not. RFC1323 was written in 1992 before RFCs contained the > boiler plate definition of MUST, SHOULD, MAY and so on. I, at least > as a non-native English speaker, find the sentence perfectly clear > and without any doubt. The IETF TCPM working group comes to the > same conclusion. And I suppose many native English speakers too. > Despite that arguing over whether "always" lacks a "MUST" to make > it really always always and never not you cited the wrong part of > RFC1323 as reason to completely remove the check. That's what I'm > complaining about. Everyone in FreeBSD, including you and me, should > at least provide the correct citation and rationale for any code > change irrespective of the eventual merit of the change itself which > is a separate issue. > > -- > Andre > From jhb at FreeBSD.org Thu Jan 24 13:37:24 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 24 13:37:26 2008 Subject: cvs commit: src/sys/netinet tcp.h tcp_usrreq.c Message-ID: <200801242137.m0OLbIIj018482@repoman.freebsd.org> jhb 2008-01-24 21:37:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netinet tcp.h tcp_usrreq.c Log: MFC: Expose smoothed RTT and RTT variance measurements to userland via socket option TCP_INFO. Revision Changes Path 1.31.2.3 +2 -2 src/sys/netinet/tcp.h 1.124.2.7 +4 -0 src/sys/netinet/tcp_usrreq.c From cperciva at FreeBSD.org Thu Jan 24 14:07:03 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Thu Jan 24 14:07:14 2008 Subject: cvs commit: src LOCKS Message-ID: <200801242207.m0OM7357020923@repoman.freebsd.org> cperciva 2008-01-24 22:07:03 UTC FreeBSD src repository Modified files: . LOCKS Log: Once the release goes out, RELENG_7_* will need approval from so@. Approved by: core (two months ago) Revision Changes Path 1.4 +1 -0 src/LOCKS From jhb at FreeBSD.org Thu Jan 24 14:23:23 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 24 14:23:29 2008 Subject: cvs commit: src/lib/libstand Makefile src/sbin/gpt Makefile add.c boot.c gpt.8 gpt.c gpt.h show.c src/sys/boot/i386 Makefile src/sys/boot/i386/gptboot Makefile gptboot.c gptldr.S src/sys/boot/i386/libi386 biosdisk.c devicename.c ... Message-ID: <200801242223.m0OMNN1L022891@repoman.freebsd.org> jhb 2008-01-24 22:23:22 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libstand Makefile sbin/gpt Makefile add.c gpt.8 gpt.c gpt.h show.c sys/boot/i386 Makefile sys/boot/i386/libi386 biosdisk.c devicename.c sys/boot/pc98/libpc98 biosdisk.c sys/sys gpt.h Added files: (Branch: RELENG_6) sbin/gpt boot.c sys/boot/i386/gptboot Makefile gptboot.c gptldr.S sys/boot/i386/pmbr Makefile pmbr.s Log: MFC: Add support for booting from GPT-labeled disks from the BIOS. This includes /boot/pmbr, /boot/gptboot, and 'gpt boot'. Revision Changes Path 1.54.2.2 +4 -0 src/lib/libstand/Makefile 1.6.8.2 +2 -2 src/sbin/gpt/Makefile 1.11.2.4 +44 -32 src/sbin/gpt/add.c 1.2.4.1 +271 -0 src/sbin/gpt/boot.c (new) 1.13.2.3 +43 -2 src/sbin/gpt/gpt.8 1.10.2.4 +1 -0 src/sbin/gpt/gpt.c 1.7.2.3 +2 -0 src/sbin/gpt/gpt.h 1.11.2.3 +3 -0 src/sbin/gpt/show.c 1.20.8.1 +2 -1 src/sys/boot/i386/Makefile 1.62.4.1 +77 -0 src/sys/boot/i386/gptboot/Makefile (new) 1.86.4.1 +727 -0 src/sys/boot/i386/gptboot/gptboot.c (new) 1.2.4.1 +125 -0 src/sys/boot/i386/gptboot/gptldr.S (new) 1.45.2.6 +303 -35 src/sys/boot/i386/libi386/biosdisk.c 1.7.2.1 +29 -12 src/sys/boot/i386/libi386/devicename.c 1.1.4.1 +14 -0 src/sys/boot/i386/pmbr/Makefile (new) 1.2.4.1 +223 -0 src/sys/boot/i386/pmbr/pmbr.s (new) 1.32.2.5 +33 -32 src/sys/boot/pc98/libpc98/biosdisk.c 1.8.2.2 +3 -1 src/sys/sys/gpt.h From mnag at FreeBSD.org Thu Jan 24 17:53:09 2008 From: mnag at FreeBSD.org (Marcus Alves Grando) Date: Thu Jan 24 17:53:17 2008 Subject: cvs commit: src/usr.sbin/sysinstall menus.c Message-ID: <200801250153.m0P1r9fq048971@repoman.freebsd.org> mnag 2008-01-25 01:53:09 UTC FreeBSD src repository (ports committer) Modified files: (Branch: RELENG_6) usr.sbin/sysinstall menus.c Log: MFC: 1.430 - Add new NTP servers provided by NIC.br (http://www.ntp.br) - Remove nonfunctional servers PR: 119884 Approved by: simon Revision Changes Path 1.410.2.13 +10 -7 src/usr.sbin/sysinstall/menus.c From mnag at FreeBSD.org Thu Jan 24 18:00:26 2008 From: mnag at FreeBSD.org (Marcus Alves Grando) Date: Thu Jan 24 18:00:31 2008 Subject: cvs commit: src/usr.sbin/sysinstall menus.c Message-ID: <200801250200.m0P20PRR049325@repoman.freebsd.org> mnag 2008-01-25 02:00:24 UTC FreeBSD src repository (ports committer) Modified files: (Branch: RELENG_7) usr.sbin/sysinstall menus.c Log: MFC: 1.430 - Add new NTP servers provided by NIC.br (http://www.ntp.br) - Remove nonfunctional servers PR: 119884 Approved by: simon Revision Changes Path 1.425.2.5 +10 -7 src/usr.sbin/sysinstall/menus.c From jhb at FreeBSD.org Thu Jan 24 18:09:39 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Jan 24 18:09:44 2008 Subject: cvs commit: src/sys/kern subr_sleepqueue.c Message-ID: <200801250209.m0P29cjL050767@repoman.freebsd.org> jhb 2008-01-25 02:09:38 UTC FreeBSD src repository Modified files: sys/kern subr_sleepqueue.c Log: Fix a race in the sleepqueue timeout code that resulted in sleeps not being properly cancelled by a timeout. In general there is a race between a the sleepq timeout handler firing while the thread is still in the process of going to sleep. In 6.x with sched_lock, the race was largely protected by sched_lock. The only place it was "exposed" and had to be handled was while checking for any pending signals in sleepq_catch_signals(). With the thread lock changes, the thread lock is dropped in between sleepq_add() and sleepq_*wait*() opening up a new window for this race. Thus, if the timeout fired while the sleeping thread was in between sleepq_add() and sleepq_*wait*(), the thread would be marked as timed out, but the thread would not be dequeued and sleepq_switch() would still block the thread until it was awakened via some other means. In the case of pause(9) where there is no other wakeup, the thread would never be awakened. Fix this by teaching sleepq_switch() to check if the thread has had its sleep canceled before blocking by checking the TDF_TIMEOUT flag and aborting the sleep and dequeueing the thread if it is set. MFC after: 3 days Reported by: dwhite, peter Revision Changes Path 1.42 +25 -4 src/sys/kern/subr_sleepqueue.c From emaste at FreeBSD.org Thu Jan 24 18:41:45 2008 From: emaste at FreeBSD.org (Ed Maste) Date: Thu Jan 24 18:41:51 2008 Subject: cvs commit: src/sys/dev/usb uftdi.c uftdireg.h Message-ID: <200801250241.m0P2fiHC053006@repoman.freebsd.org> emaste 2008-01-25 02:41:44 UTC FreeBSD src repository Modified files: sys/dev/usb uftdi.c uftdireg.h Log: Calculate baud rate divisor instead of allowing only a fixed set of standard rates. Obtained from OpenBSD src/sys/dev/usb/uftdi.c 1.29 src/sys/dev/usb/uftdireg.h 1.11 OpenBSD revisions noted by: ticso, on hackers Revision Changes Path 1.38 +66 -18 src/sys/dev/usb/uftdi.c 1.3 +5 -17 src/sys/dev/usb/uftdireg.h From mtm at FreeBSD.org Thu Jan 24 21:23:02 2008 From: mtm at FreeBSD.org (Mike Makonnen) Date: Thu Jan 24 21:23:04 2008 Subject: cvs commit: src/etc/defaults rc.conf src/etc/rc.d kerberos Message-ID: <200801250523.m0P5N2UQ075732@repoman.freebsd.org> mtm 2008-01-25 05:23:02 UTC FreeBSD src repository Modified files: etc/defaults rc.conf etc/rc.d kerberos Log: Rev. 1.6 made it impossible to use rc.d/kerberos with the krb5 port. Re-implement the change so that the script once again works with the krb5 port. Submitted by: kensmith (slightly modified) MFC after: 3 days Revision Changes Path 1.324 +1 -1 src/etc/defaults/rc.conf 1.8 +0 -1 src/etc/rc.d/kerberos From danfe at FreeBSD.org Fri Jan 25 01:34:32 2008 From: danfe at FreeBSD.org (Alexey Dokuchaev) Date: Fri Jan 25 01:34:38 2008 Subject: cvs commit: src/sys/sys event.h src/sys/kern vfs_aio.c In-Reply-To: <200801241710.m0OHAJCG083388@repoman.freebsd.org> References: <200801241710.m0OHAJCG083388@repoman.freebsd.org> Message-ID: <20080125093431.GA26126@FreeBSD.org> On Thu, Jan 24, 2008 at 05:10:19PM +0000, Jean-Sebastien Pedron wrote: > dumbbell 2008-01-24 17:10:19 UTC > > FreeBSD src repository > > Modified files: > sys/sys event.h > sys/kern vfs_aio.c > Log: > When asked to use kqueue, AIO stores its internal state in the > `kn_sdata' member of the newly registered knote. The problem is that > this member is overwritten by a call to kevent(2) with the EV_ADD flag, > targetted at the same kevent/knote. For instance, a userland application > may set the pointer to NULL, leading to a panic. > > A testcase was provided by the submitter. Given we have a test case, should it be put in our regression suit? ./danfe From kib at FreeBSD.org Fri Jan 25 02:12:34 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Fri Jan 25 02:12:36 2008 Subject: cvs commit: src/sys/fs/udf udf_vfsops.c Message-ID: <200801251012.m0PACYSm007632@repoman.freebsd.org> kib 2008-01-25 10:12:33 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/fs/udf udf_vfsops.c Log: MFC rev. 1.52: udf_vget() shall vgone() the vnode when the file_entry cannot be allocated or read from the volume. Otherwise, half-constructed vnode could be found later and cause panic when accessed. PR: 118322 Revision Changes Path 1.48.2.1 +3 -0 src/sys/fs/udf/udf_vfsops.c From dumbbell at freebsd.org Fri Jan 25 02:34:56 2008 From: dumbbell at freebsd.org (=?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?=) Date: Fri Jan 25 02:35:04 2008 Subject: cvs commit: src/sys/sys event.h src/sys/kern vfs_aio.c In-Reply-To: <20080125093431.GA26126@FreeBSD.org> References: <200801241710.m0OHAJCG083388@repoman.freebsd.org> <20080125093431.GA26126@FreeBSD.org> Message-ID: <4799B5EF.4020201@freebsd.org> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 25.01.2008 10:34, Alexey Dokuchaev wrote: > On Thu, Jan 24, 2008 at 05:10:19PM +0000, Jean-Sebastien Pedron wrote: >> A testcase was provided by the submitter. > > Given we have a test case, should it be put in our regression suit? I don't know our regression suit very well but you're right. I'll take a look at it. Thanks for pointing me to this. - -- Jean-S?bastien P?dron http://www.dumbbell.fr/ PGP Key: http://www.dumbbell.fr/pgp/pubkey.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkeZte8ACgkQa+xGJsFYOlP5tgCePx9UFBEVqaDcKVpFdmF7dpkV /Z0AoJaewq5/dxAe+p4ZEyCe+l+faR+U =7hhx -----END PGP SIGNATURE----- From cognet at FreeBSD.org Fri Jan 25 02:50:32 2008 From: cognet at FreeBSD.org (Olivier Houchard) Date: Fri Jan 25 02:50:38 2008 Subject: cvs commit: CVSROOT access Message-ID: <200801251050.m0PAoVjQ009982@repoman.freebsd.org> cognet 2008-01-25 10:50:31 UTC FreeBSD src repository Modified files: . access Log: Here comes a new challenger. Please welcome Oleksandr Tymoshenko (gonzo@FreeBSD.org) as a new src committer. Oleksandr has been the main developer on our mips port for quite some time, and his commit bit is long overdue. I'll try hard to mentor him. Welcome, Oleksandr ! Approved by: core Revision Changes Path 1.854 +1 -0 CVSROOT/access From mnag at FreeBSD.org Fri Jan 25 02:54:40 2008 From: mnag at FreeBSD.org (Marcus Alves Grando) Date: Fri Jan 25 02:54:42 2008 Subject: cvs commit: src/usr.sbin/sysinstall menus.c Message-ID: <200801251054.m0PAseKr012111@repoman.freebsd.org> mnag 2008-01-25 10:54:40 UTC FreeBSD src repository (ports committer) Modified files: (Branch: RELENG_7_0) usr.sbin/sysinstall menus.c Log: MFC: 1.430 - Add new NTP servers provided by NIC.br (http://www.ntp.br) - Remove nonfunctional servers PR: 119884 Approved by: simon Approved by: re (bmah) Revision Changes Path 1.425.2.3.2.2 +10 -7 src/usr.sbin/sysinstall/menus.c From rnsanchez at wait4.org Fri Jan 25 04:12:50 2008 From: rnsanchez at wait4.org (Ricardo Nabinger Sanchez) Date: Fri Jan 25 04:12:54 2008 Subject: cvs commit: CVSROOT access In-Reply-To: <200801251050.m0PAoVjQ009982@repoman.freebsd.org> References: <200801251050.m0PAoVjQ009982@repoman.freebsd.org> Message-ID: <20080125095205.3e0d8b1e.rnsanchez@wait4.org> On Fri, 25 Jan 2008 10:50:31 +0000 (UTC) Olivier Houchard wrote: > Here comes a new challenger. > Please welcome Oleksandr Tymoshenko (gonzo@FreeBSD.org) as a new src > committer. > Oleksandr has been the main developer on our mips port for quite > some time, and his commit bit is long overdue. > I'll try hard to mentor him. > > Welcome, Oleksandr ! Whoa, great news! Congratulations! :) -- Ricardo Nabinger Sanchez rnsanchez@wait4.org Powered by FreeBSD http://rnsanchez.wait4.org "Left to themselves, things tend to go from bad to worse." From rwatson at FreeBSD.org Fri Jan 25 06:38:27 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Fri Jan 25 06:38:30 2008 Subject: cvs commit: src/sbin/ipfw ipfw2.c src/sys/netinet ip_fw.h ip_fw2.c Message-ID: <200801251438.m0PEcRRW041152@repoman.freebsd.org> rwatson 2008-01-25 14:38:27 UTC FreeBSD src repository Modified files: sbin/ipfw ipfw2.c sys/netinet ip_fw.h ip_fw2.c Log: Hide ipfw internal data structures behind IPFW_INTERNAL rather than exposing them to all consumers of ip_fw.h. These structures are used in both ipfw(8) and ipfw(4), but not part of the user<->kernel interface for other applications to use, rather, shared implementation. MFC after: 3 days Reported by: Paul Vixie Revision Changes Path 1.113 +2 -0 src/sbin/ipfw/ipfw2.c 1.111 +11 -0 src/sys/netinet/ip_fw.h 1.180 +3 -0 src/sys/netinet/ip_fw2.c From jhb at freebsd.org Fri Jan 25 06:39:27 2008 From: jhb at freebsd.org (John Baldwin) Date: Fri Jan 25 06:39:32 2008 Subject: cvs commit: src/sys/kern subr_sleepqueue.c In-Reply-To: <200801250209.m0P29cjL050767@repoman.freebsd.org> References: <200801250209.m0P29cjL050767@repoman.freebsd.org> Message-ID: <200801250739.41413.jhb@freebsd.org> On Thursday 24 January 2008 09:09:38 pm John Baldwin wrote: > jhb 2008-01-25 02:09:38 UTC > > FreeBSD src repository > > Modified files: > sys/kern subr_sleepqueue.c > Log: > Fix a race in the sleepqueue timeout code that resulted in sleeps not > being properly cancelled by a timeout. In general there is a race > between a the sleepq timeout handler firing while the thread is still > in the process of going to sleep. In 6.x with sched_lock, the race was > largely protected by sched_lock. The only place it was "exposed" and had > to be handled was while checking for any pending signals in > sleepq_catch_signals(). > > With the thread lock changes, the thread lock is dropped in between > sleepq_add() and sleepq_*wait*() opening up a new window for this race. > Thus, if the timeout fired while the sleeping thread was in between > sleepq_add() and sleepq_*wait*(), the thread would be marked as timed > out, but the thread would not be dequeued and sleepq_switch() would > still block the thread until it was awakened via some other means. In > the case of pause(9) where there is no other wakeup, the thread would > never be awakened. > > Fix this by teaching sleepq_switch() to check if the thread has had its > sleep canceled before blocking by checking the TDF_TIMEOUT flag and > aborting the sleep and dequeueing the thread if it is set. > > MFC after: 3 days > Reported by: dwhite, peter This should fix the "vmo_de" hangs some people have reported on 7.x+. -- John Baldwin From mtm at FreeBSD.org Fri Jan 25 07:06:27 2008 From: mtm at FreeBSD.org (Mike Makonnen) Date: Fri Jan 25 07:06:35 2008 Subject: cvs commit: src/etc rc.subr Message-ID: <200801251506.m0PF6Qwf043571@repoman.freebsd.org> mtm 2008-01-25 15:06:26 UTC FreeBSD src repository Modified files: etc rc.subr Log: If the rc.conf(5) variable for a script is not enabled do not fail silently. Display a message that the command wasn't run and make possible suggestions for what to do. PR: conf/118770 MFC after: 1 week Revision Changes Path 1.78 +3 -0 src/etc/rc.subr From mtm at FreeBSD.org Fri Jan 25 07:54:15 2008 From: mtm at FreeBSD.org (Mike Makonnen) Date: Fri Jan 25 07:54:17 2008 Subject: cvs commit: src/usr.sbin/pw pw.8 Message-ID: <200801251554.m0PFsEge047061@repoman.freebsd.org> mtm 2008-01-25 15:54:14 UTC FreeBSD src repository Modified files: usr.sbin/pw pw.8 Log: Clarify in what formats the grouplist for the '-G' switch may be accepted. Submitted by: Eygene Ryabinkin Revision Changes Path 1.42 +1 -1 src/usr.sbin/pw/pw.8 From ceri at submonkey.net Fri Jan 25 07:58:10 2008 From: ceri at submonkey.net (Ceri Davies) Date: Fri Jan 25 07:58:20 2008 Subject: cvs commit: src/etc rc.subr In-Reply-To: <200801251506.m0PF6Qwf043571@repoman.freebsd.org> References: <200801251506.m0PF6Qwf043571@repoman.freebsd.org> Message-ID: <20080125152102.GD6064@submonkey.net> On Fri, Jan 25, 2008 at 03:06:26PM +0000, Mike Makonnen wrote: > mtm 2008-01-25 15:06:26 UTC > > FreeBSD src repository > > Modified files: > etc rc.subr > Log: > If the rc.conf(5) variable for a script is not enabled do not fail > silently. Display a message that the command wasn't run and make > possible suggestions for what to do. Any chance that we could make this behaviour dependent on some other variable (or not do it)? It's going to make booting look pretty nasty. Ceri > | @@ -606,6 +606,9 @@ run_rc_command() > | # > | if [ -n "${rcvar}" -a "$rc_arg" != "rcvar" ]; then > | if ! checkyesno ${rcvar}; then > | + echo -n "Cannot '${rc_arg}' $name. Set ${rcvar} to " > | + echo -n "YES in /etc/rc.conf or use 'one${rc_arg}' " > | + echo "instead of '${rc_arg}'." > | return 0 > | fi > | fi -- That must be wonderful! I don't understand it at all. -- Moliere -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080125/f07b7aa9/attachment.pgp From brooks at freebsd.org Fri Jan 25 08:23:12 2008 From: brooks at freebsd.org (Brooks Davis) Date: Fri Jan 25 08:23:19 2008 Subject: cvs commit: src/etc rc.subr In-Reply-To: <20080125152102.GD6064@submonkey.net> References: <200801251506.m0PF6Qwf043571@repoman.freebsd.org> <20080125152102.GD6064@submonkey.net> Message-ID: <20080125160412.GA36311@lor.one-eyed-alien.net> On Fri, Jan 25, 2008 at 03:21:02PM +0000, Ceri Davies wrote: > On Fri, Jan 25, 2008 at 03:06:26PM +0000, Mike Makonnen wrote: > > mtm 2008-01-25 15:06:26 UTC > > > > FreeBSD src repository > > > > Modified files: > > etc rc.subr > > Log: > > If the rc.conf(5) variable for a script is not enabled do not fail > > silently. Display a message that the command wasn't run and make > > possible suggestions for what to do. > > Any chance that we could make this behaviour dependent on some other > variable (or not do it)? It's going to make booting look pretty nasty. The other option I'd considered was to create a quiet precmd that works like force and use quietstart/quitestop for boot. I've become convinced this is the right interactive behavior. -- Brooks > Ceri > > > | @@ -606,6 +606,9 @@ run_rc_command() > > | # > > | if [ -n "${rcvar}" -a "$rc_arg" != "rcvar" ]; then > > | if ! checkyesno ${rcvar}; then > > | + echo -n "Cannot '${rc_arg}' $name. Set ${rcvar} to " > > | + echo -n "YES in /etc/rc.conf or use 'one${rc_arg}' " > > | + echo "instead of '${rc_arg}'." > > | return 0 > > | fi > > | fi > > -- > That must be wonderful! I don't understand it at all. > -- Moliere -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080125/e89d60a3/attachment.pgp From mtm at FreeBSD.org Fri Jan 25 08:44:35 2008 From: mtm at FreeBSD.org (Mike Makonnen) Date: Fri Jan 25 08:44:37 2008 Subject: cvs commit: src/etc rc.subr Message-ID: <200801251644.m0PGiYJg051286@repoman.freebsd.org> mtm 2008-01-25 16:44:34 UTC FreeBSD src repository Modified files: etc rc.subr Log: Backout previous commit. It's going to clutter the console during boot and shutdown. I think I'll hide it behind autoboot or maybe take brooks@ suggestion and implement a different command prefix for booting/shutdown purposes, but in any case it needs more thought and attention. Noticed by: ceri Pointyhat to: mtm Revision Changes Path 1.79 +0 -3 src/etc/rc.subr From mtm at FreeBSD.Org Fri Jan 25 08:45:54 2008 From: mtm at FreeBSD.Org (Mike Makonnen) Date: Fri Jan 25 08:46:01 2008 Subject: cvs commit: src/etc rc.subr In-Reply-To: <20080125160412.GA36311@lor.one-eyed-alien.net> References: <200801251506.m0PF6Qwf043571@repoman.freebsd.org> <20080125152102.GD6064@submonkey.net> <20080125160412.GA36311@lor.one-eyed-alien.net> Message-ID: <1201279820.1547.5.camel@mercury> On Fri, 2008-01-25 at 10:04 -0600, Brooks Davis wrote: > The other option I'd considered was to create a quiet precmd that works like > force and use quietstart/quitestop for boot. I've become convinced this is the > right interactive behavior. Yes, I think I agree. Initialy, I had thought about putting it behind a global variable like "autoboot" or something but I like your suggestion better. Cheers. -- Mike Makonnen | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc mmakonnen @ gmail.com | AC7B 5672 2D11 F4D0 EBF8 5279 5359 2B82 7CD4 1F55 mtm @ FreeBSD.Org | FreeBSD - http://www.freebsd.org From scottl at samsco.org Fri Jan 25 08:47:50 2008 From: scottl at samsco.org (Scott Long) Date: Fri Jan 25 08:47:58 2008 Subject: cvs commit: src/etc rc.subr In-Reply-To: <200801251644.m0PGiYJg051286@repoman.freebsd.org> References: <200801251644.m0PGiYJg051286@repoman.freebsd.org> Message-ID: <479A12AF.2050003@samsco.org> Mike Makonnen wrote: > mtm 2008-01-25 16:44:34 UTC > > FreeBSD src repository > > Modified files: > etc rc.subr > Log: > Backout previous commit. It's going to clutter the console > during boot and shutdown. I think I'll hide it behind autoboot or > maybe take brooks@ suggestion and implement a different command > prefix for booting/shutdown purposes, but in any case it needs more > thought and attention. > > Noticed by: ceri > Pointyhat to: mtm > > Revision Changes Path > 1.79 +0 -3 src/etc/rc.subr In any case, I think you're on a good track. I can't tell you how many times I've pulled my hair out from typing "/etc/rc.d/foo start" at the command line and having nothing at all happen as a response. Scott From brooks at FreeBSD.org Fri Jan 25 09:06:01 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Fri Jan 25 09:06:05 2008 Subject: cvs commit: src/etc rc.subr In-Reply-To: <479A12AF.2050003@samsco.org> References: <200801251644.m0PGiYJg051286@repoman.freebsd.org> <479A12AF.2050003@samsco.org> Message-ID: <20080125170546.GC36311@lor.one-eyed-alien.net> On Fri, Jan 25, 2008 at 09:47:43AM -0700, Scott Long wrote: > Mike Makonnen wrote: >> mtm 2008-01-25 16:44:34 UTC >> FreeBSD src repository >> Modified files: >> etc rc.subr Log: >> Backout previous commit. It's going to clutter the console >> during boot and shutdown. I think I'll hide it behind autoboot or >> maybe take brooks@ suggestion and implement a different command >> prefix for booting/shutdown purposes, but in any case it needs more >> thought and attention. >> Noticed by: ceri >> Pointyhat to: mtm >> Revision Changes Path >> 1.79 +0 -3 src/etc/rc.subr > > In any case, I think you're on a good track. I can't tell you how many > times I've pulled my hair out from typing "/etc/rc.d/foo start" at the > command line and having nothing at all happen as a response. The one that continually messes me up is disabling nagios in /etc/rc.conf during maintance and then doing "/usr/local/etc/rc.d/nagios stop" and forgetting that it doen't do anything so I get individual notices about all 352 cluster nodes going down. :( -- Brooks -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080125/c9672804/attachment.pgp From rdivacky at FreeBSD.org Fri Jan 25 09:11:24 2008 From: rdivacky at FreeBSD.org (Roman Divacky) Date: Fri Jan 25 09:11:33 2008 Subject: cvs commit: src/etc rc.subr In-Reply-To: <20080125170546.GC36311@lor.one-eyed-alien.net> References: <200801251644.m0PGiYJg051286@repoman.freebsd.org> <479A12AF.2050003@samsco.org> <20080125170546.GC36311@lor.one-eyed-alien.net> Message-ID: <20080125170945.GA31476@freebsd.org> On Fri, Jan 25, 2008 at 11:05:46AM -0600, Brooks Davis wrote: > On Fri, Jan 25, 2008 at 09:47:43AM -0700, Scott Long wrote: > > Mike Makonnen wrote: > >> mtm 2008-01-25 16:44:34 UTC > >> FreeBSD src repository > >> Modified files: > >> etc rc.subr Log: > >> Backout previous commit. It's going to clutter the console > >> during boot and shutdown. I think I'll hide it behind autoboot or > >> maybe take brooks@ suggestion and implement a different command > >> prefix for booting/shutdown purposes, but in any case it needs more > >> thought and attention. > >> Noticed by: ceri > >> Pointyhat to: mtm > >> Revision Changes Path > >> 1.79 +0 -3 src/etc/rc.subr > > > > In any case, I think you're on a good track. I can't tell you how many > > times I've pulled my hair out from typing "/etc/rc.d/foo start" at the > > command line and having nothing at all happen as a response. > > The one that continually messes me up is disabling nagios in > /etc/rc.conf during maintance and then doing "/usr/local/etc/rc.d/nagios > stop" and forgetting that it doen't do anything so I get individual > notices about all 352 cluster nodes going down. :( semantically foo_enable="YES" could permit "stop" action because I don't see any logical contradiction in stopping a service that is not enabled... just my 2 cents :) roman From scottl at samsco.org Fri Jan 25 09:30:42 2008 From: scottl at samsco.org (Scott Long) Date: Fri Jan 25 09:30:50 2008 Subject: cvs commit: src/etc rc.subr In-Reply-To: <20080125170945.GA31476@freebsd.org> References: <200801251644.m0PGiYJg051286@repoman.freebsd.org> <479A12AF.2050003@samsco.org> <20080125170546.GC36311@lor.one-eyed-alien.net> <20080125170945.GA31476@freebsd.org> Message-ID: <479A1CBF.808@samsco.org> Roman Divacky wrote: > On Fri, Jan 25, 2008 at 11:05:46AM -0600, Brooks Davis wrote: >> On Fri, Jan 25, 2008 at 09:47:43AM -0700, Scott Long wrote: >>> Mike Makonnen wrote: >>>> mtm 2008-01-25 16:44:34 UTC >>>> FreeBSD src repository >>>> Modified files: >>>> etc rc.subr Log: >>>> Backout previous commit. It's going to clutter the console >>>> during boot and shutdown. I think I'll hide it behind autoboot or >>>> maybe take brooks@ suggestion and implement a different command >>>> prefix for booting/shutdown purposes, but in any case it needs more >>>> thought and attention. >>>> Noticed by: ceri >>>> Pointyhat to: mtm >>>> Revision Changes Path >>>> 1.79 +0 -3 src/etc/rc.subr >>> In any case, I think you're on a good track. I can't tell you how many >>> times I've pulled my hair out from typing "/etc/rc.d/foo start" at the >>> command line and having nothing at all happen as a response. >> The one that continually messes me up is disabling nagios in >> /etc/rc.conf during maintance and then doing "/usr/local/etc/rc.d/nagios >> stop" and forgetting that it doen't do anything so I get individual >> notices about all 352 cluster nodes going down. :( > > semantically foo_enable="YES" could permit "stop" action because I don't > see any logical contradiction in stopping a service that is not enabled... > > just my 2 cents :) > > roman Be that as it may, fixing the system to provide feedback to interactive users is a good thing. Scott From rdivacky at FreeBSD.org Fri Jan 25 10:03:39 2008 From: rdivacky at FreeBSD.org (Roman Divacky) Date: Fri Jan 25 10:03:44 2008 Subject: cvs commit: src/etc rc.subr In-Reply-To: <479A1CBF.808@samsco.org> References: <200801251644.m0PGiYJg051286@repoman.freebsd.org> <479A12AF.2050003@samsco.org> <20080125170546.GC36311@lor.one-eyed-alien.net> <20080125170945.GA31476@freebsd.org> <479A1CBF.808@samsco.org> Message-ID: <20080125180326.GA33885@freebsd.org> On Fri, Jan 25, 2008 at 10:30:39AM -0700, Scott Long wrote: > Roman Divacky wrote: > >On Fri, Jan 25, 2008 at 11:05:46AM -0600, Brooks Davis wrote: > >>On Fri, Jan 25, 2008 at 09:47:43AM -0700, Scott Long wrote: > >>>Mike Makonnen wrote: > >>>>mtm 2008-01-25 16:44:34 UTC > >>>> FreeBSD src repository > >>>> Modified files: > >>>> etc rc.subr Log: > >>>> Backout previous commit. It's going to clutter the console > >>>> during boot and shutdown. I think I'll hide it behind autoboot or > >>>> maybe take brooks@ suggestion and implement a different command > >>>> prefix for booting/shutdown purposes, but in any case it needs more > >>>> thought and attention. > >>>> Noticed by: ceri > >>>> Pointyhat to: mtm > >>>> Revision Changes Path > >>>> 1.79 +0 -3 src/etc/rc.subr > >>>In any case, I think you're on a good track. I can't tell you how many > >>>times I've pulled my hair out from typing "/etc/rc.d/foo start" at the > >>>command line and having nothing at all happen as a response. > >>The one that continually messes me up is disabling nagios in > >>/etc/rc.conf during maintance and then doing "/usr/local/etc/rc.d/nagios > >>stop" and forgetting that it doen't do anything so I get individual > >>notices about all 352 cluster nodes going down. :( > > > >semantically foo_enable="YES" could permit "stop" action because I don't > >see any logical contradiction in stopping a service that is not enabled... > > > >just my 2 cents :) > > > >roman > > Be that as it may, fixing the system to provide feedback to interactive > users is a good thing. > > Scott sure.. my suggestion is orthogonal to this, it just happens to be from the same bucket From jhb at FreeBSD.org Fri Jan 25 11:24:12 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Fri Jan 25 11:24:19 2008 Subject: cvs commit: src/tools/sched schedgraph.py Message-ID: <200801251924.m0PJOCEO050785@repoman.freebsd.org> jhb 2008-01-25 19:24:12 UTC FreeBSD src repository Modified files: tools/sched schedgraph.py Log: Update the timestamp regexps in syncstamp() and monostamp() for > 99999 traces where there isn't any leading whitespace before the record number in the ktrdump output. Revision Changes Path 1.16 +2 -2 src/tools/sched/schedgraph.py From jhb at FreeBSD.org Fri Jan 25 11:44:51 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Fri Jan 25 11:44:57 2008 Subject: cvs commit: src/sys/kern subr_sleepqueue.c Message-ID: <200801251944.m0PJiofM061498@repoman.freebsd.org> jhb 2008-01-25 19:44:46 UTC FreeBSD src repository Modified files: sys/kern subr_sleepqueue.c Log: Fix a bug where a thread that hit the race where the sleep timeout fires while the thread does not hold the thread lock would stop blocking for subsequent interruptible sleeps and would always immediately fail the sleep with EWOULDBLOCK instead (even sleeps that didn't have a timeout). Some background: - KSE has a facility for allowing one thread to interrupt another thread. During this process, the target thread aborts any interruptible sleeps much as if the target thread had a pending signal. Once the target thread acknowledges the interrupt, normal sleep handling resumes. KSE manages this via the TDF_INTERRUPTED flag. Specifically, it sets the flag when it sends an interrupt to another thread and clears it when the interrupt is acknowledged. (Note that this is purely a software interrupt sort of thing and has no relation to hardware interrupts or kernel interrupt threads.) - The old code for handling the sleep timeout race handled the race by setting the TDF_INTERRUPT flag and faking a KSE-style thread interrupt to the thread in the process of going to sleep. It probably should have just checked the TDF_TIMEOUT flag in sleepq_catch_signals() instead. - The bug was that the sleepq code would set TDF_INTERRUPT but it was never cleared. The sleepq code couldn't safely clear it in case there actually was a real KSE thread interrupt pending for the target thread (in fact, the sleepq timeout actually stomped on said pending interrupt). Thus, any future interruptible sleeps (*sleep(.. PCATCH ..) or cv_*wait_sig()) would see the TDF_INTERRUPT flag set and immediately fail with EWOULDBLOCK. The flag could be cleared if the thread belonged to a KSE process and another thread posted an interrupt to the original thread. However, in the more common case of a non-KSE process, the thread would pretty much stop sleeping. - Fix the bug by just setting TDF_TIMEOUT in the sleepq timeout code and not messing with TDF_INTERRUPT and td_intrval. With yesterday's fix to fix sleepq_switch() to check TDF_TIMEOUT, this is now sufficient. MFC after: 3 days Revision Changes Path 1.43 +1 -2 src/sys/kern/subr_sleepqueue.c From bde at FreeBSD.org Fri Jan 25 13:09:22 2008 From: bde at FreeBSD.org (Bruce Evans) Date: Fri Jan 25 13:09:28 2008 Subject: cvs commit: src/lib/msun/src k_cos.c Message-ID: <200801252109.m0PL9LC8077059@repoman.freebsd.org> bde 2008-01-25 21:09:21 UTC FreeBSD src repository Modified files: lib/msun/src k_cos.c Log: Fix a harmless type error in 1.9. Revision Changes Path 1.11 +1 -1 src/lib/msun/src/k_cos.c From kmacy at FreeBSD.org Fri Jan 25 17:00:57 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Fri Jan 25 17:01:00 2008 Subject: cvs commit: src/sys/modules/cxgb/cxgb Makefile Message-ID: <200801260100.m0Q10uqe004892@repoman.freebsd.org> kmacy 2008-01-26 01:00:56 UTC FreeBSD src repository Modified files: sys/modules/cxgb/cxgb Makefile Log: add opt_global.h dependency Revision Changes Path 1.5 +1 -1 src/sys/modules/cxgb/cxgb/Makefile From emaste at FreeBSD.org Fri Jan 25 20:30:49 2008 From: emaste at FreeBSD.org (Ed Maste) Date: Fri Jan 25 20:30:50 2008 Subject: cvs commit: src/sys/dev/usb uark.c Message-ID: <200801260430.m0Q4UmIj021581@repoman.freebsd.org> emaste 2008-01-26 04:30:48 UTC FreeBSD src repository Modified files: sys/dev/usb uark.c Log: Allow arbitrary baud rates, not just the standard ones. Revision Changes Path 1.8 +13 -21 src/sys/dev/usb/uark.c From julian at FreeBSD.org Fri Jan 25 21:11:10 2008 From: julian at FreeBSD.org (Julian Elischer) Date: Fri Jan 25 21:11:15 2008 Subject: cvs commit: src/sys/powerpc/powermac ata_kauai.c Message-ID: <200801260511.m0Q5B9BF033570@repoman.freebsd.org> julian 2008-01-26 05:11:09 UTC FreeBSD src repository Modified files: sys/powerpc/powermac ata_kauai.c Log: One of my powerbooks has this chip in it.. Confirmed by looking at netbsd.. they have also added this. checked by grehen MFC After: 3 days Revision Changes Path 1.14 +1 -0 src/sys/powerpc/powermac/ata_kauai.c From kib at FreeBSD.org Fri Jan 25 22:09:23 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Fri Jan 25 22:09:25 2008 Subject: cvs commit: src/sys/kern tty_pty.c Message-ID: <200801260609.m0Q69NhJ038157@repoman.freebsd.org> kib 2008-01-26 06:09:23 UTC FreeBSD src repository Modified files: sys/kern tty_pty.c Log: In rev. 1.156, the convertion of the minor number to the unit number resulted in the argument to the make_dev() to be a unit number. Correct this by supplying a minor number to make_dev(), and using the unit number for the calculation of the slave tty name. Reported and tested by: Peter Holm Reviewed by: jhb Yet another pointy hat to: kib MFC after: 1 day Revision Changes Path 1.157 +5 -3 src/sys/kern/tty_pty.c From mtm at FreeBSD.org Fri Jan 25 22:49:32 2008 From: mtm at FreeBSD.org (Mike Makonnen) Date: Fri Jan 25 22:49:34 2008 Subject: cvs commit: src/sys/netinet6 ip6_output.c Message-ID: <200801260649.m0Q6nVCA043347@repoman.freebsd.org> mtm 2008-01-26 06:49:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/netinet6 ip6_output.c Log: MFC: rev. 1.110 ---------------------------------------------------------------------------- Instead of manually freeing the packet options structure (and not even doing a good job of it) in the copypktopts() function, just call ip6_clearpktopts() directly. Otherwise, the callers of this function would end up freeing the memory twice. Reviewed by: jinmei PR: kern/116360 ---------------------------------------------------------------------------- Revision Changes Path 1.109.2.1 +1 -6 src/sys/netinet6/ip6_output.c From trhodes at FreeBSD.org Fri Jan 25 22:50:15 2008 From: trhodes at FreeBSD.org (Tom Rhodes) Date: Fri Jan 25 22:50:21 2008 Subject: cvs commit: src/share/man/man4 dcons.4 Message-ID: <200801260650.m0Q6oEs2043463@repoman.freebsd.org> trhodes 2008-01-26 06:50:14 UTC FreeBSD src repository Modified files: share/man/man4 dcons.4 Log: Catch up with revision 1.18 of dcons_os.c and add an example of how to use dcons(4) as a valid gdb port. PR: 118490 Submitted by: Alexandre Kovalenko Revision Changes Path 1.12 +12 -1 src/share/man/man4/dcons.4 From mtm at FreeBSD.org Fri Jan 25 23:08:49 2008 From: mtm at FreeBSD.org (Mike Makonnen) Date: Fri Jan 25 23:08:50 2008 Subject: cvs commit: src/sys/netinet6 ip6_output.c Message-ID: <200801260708.m0Q78mMO045286@repoman.freebsd.org> mtm 2008-01-26 07:08:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netinet6 ip6_output.c Log: MFC: rev. 1.110 ---------------------------------------------------------------------------- Instead of manually freeing the packet options structure (and not even doing a good job of it) in the copypktopts() function, just call ip6_clearpktopts() directly. Otherwise, the callers of this function would end up freeing the memory twice. Reviewed by: jinmei PR: kern/116360 ---------------------------------------------------------------------------- Revision Changes Path 1.90.2.11 +1 -6 src/sys/netinet6/ip6_output.c From das at FreeBSD.org Sat Jan 26 00:21:13 2008 From: das at FreeBSD.org (David Schultz) Date: Sat Jan 26 00:21:19 2008 Subject: cvs commit: src/sbin/growfs growfs.c Message-ID: <200801260821.m0Q8LCp6051252@repoman.freebsd.org> das 2008-01-26 08:21:12 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sbin/growfs growfs.c Log: MFC growfs.c,v 1.26 Fix an int overflow on very large file systems. PR: bin/113399 Submitted by: Staffan Ulfberg Revision Changes Path 1.25.2.1 +2 -2 src/sbin/growfs/growfs.c From das at FreeBSD.org Sat Jan 26 00:21:14 2008 From: das at FreeBSD.org (David Schultz) Date: Sat Jan 26 00:21:21 2008 Subject: cvs commit: src/lib/libc/stdlib heapsort.c qsort.c Message-ID: <200801260821.m0Q8LEm7051284@repoman.freebsd.org> das 2008-01-26 08:21:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libc/stdlib heapsort.c qsort.c Log: MFC qsort.c,v 1.14-1.15, heapsort.c,v 1.6 Use size_t to avoid overflow when sorting arrays larger than 2 GB. PR: 111085 Revision Changes Path 1.5.2.1 +1 -1 src/lib/libc/stdlib/heapsort.c 1.13.2.1 +7 -5 src/lib/libc/stdlib/qsort.c From das at FreeBSD.org Sat Jan 26 00:21:33 2008 From: das at FreeBSD.org (David Schultz) Date: Sat Jan 26 00:21:36 2008 Subject: cvs commit: src/lib/libc/gdtoa _ldtoa.c Message-ID: <200801260821.m0Q8LWwE051330@repoman.freebsd.org> das 2008-01-26 08:21:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libc/gdtoa _ldtoa.c Log: MFC _ldtoa.c,v 1.5 Fix handling of subnormals on i386/ia64/amd64. PR: 85080 Revision Changes Path 1.2.18.1 +0 -2 src/lib/libc/gdtoa/_ldtoa.c From mtm at FreeBSD.org Sat Jan 26 03:22:12 2008 From: mtm at FreeBSD.org (Mike Makonnen) Date: Sat Jan 26 03:22:18 2008 Subject: cvs commit: src/etc rc rc.subr src/etc/rc.d netif Message-ID: <200801261122.m0QBMClS074435@repoman.freebsd.org> mtm 2008-01-26 11:22:12 UTC FreeBSD src repository Modified files: etc rc rc.subr etc/rc.d netif Log: Re-implement: do not silently fail when a command is not carried out because the rc.conf(5) variable was not enabled. Display a message that the command wasn't run and offer suggestions on what the user can do. Implement a quiet prefix, which will disable some diagnostics. The fast prefix also implies quiet. During boot we use either fast or quiet. For shutdown we already use 'faststop'. So, this informational message should only appear during interactive use. An additional benefit of having a quiet prefix is that we can start putting some of our diagnostic messages behind this knob and start "de-cluttering" the console during boot and shutdown. Revision Changes Path 1.341 +1 -1 src/etc/rc 1.25 +1 -1 src/etc/rc.d/netif 1.80 +16 -1 src/etc/rc.subr From keramida at FreeBSD.org Sat Jan 26 03:37:55 2008 From: keramida at FreeBSD.org (Giorgos Keramidas) Date: Sat Jan 26 03:38:01 2008 Subject: cvs commit: src/usr.bin/split split.1 Message-ID: <200801261137.m0QBbsru075011@repoman.freebsd.org> keramida 2008-01-26 11:37:54 UTC FreeBSD src repository (doc committer) Modified files: (Branch: RELENG_6) usr.bin/split split.1 Log: MFC: 1.19 Update usage & SYNOPSIS and clarify that input files are not removed. Sort getopt option handling of -p too, while here. The changes are adapted from a patch by Ruslan Ermilov, posted as followup to docs/33852. PR: docs/33852 Submitted by: Gary W. Swearingen Revision Changes Path 1.15.2.1 +22 -10 src/usr.bin/split/split.1 From mpp at FreeBSD.org Sat Jan 26 04:03:27 2008 From: mpp at FreeBSD.org (Mike Pritchard) Date: Sat Jan 26 04:03:30 2008 Subject: cvs commit: src/sbin/quotacheck Makefile preen.c quotacheck.8 quotacheck.c quotacheck.h Message-ID: <200801261203.m0QC3RTS078486@repoman.freebsd.org> mpp 2008-01-26 12:03:27 UTC FreeBSD src repository Modified files: sbin/quotacheck Makefile preen.c quotacheck.8 quotacheck.c Added files: sbin/quotacheck quotacheck.h Log: Sync up quotacheck's preen.c with fsck's. This makes quotacheck process parallel checks in the same way as fsck, since fsck supports pass numbers other than 0, 1 or 2. Without this, quotacheck would ignore file systems with pass numbers > 2. The -l (maxrun) option is now deprecated and can be tuned with pass numbers in /etc/fstab if needed. Revision Changes Path 1.9 +2 -2 src/sbin/quotacheck/Makefile 1.27 +180 -183 src/sbin/quotacheck/preen.c 1.20 +3 -0 src/sbin/quotacheck/quotacheck.8 1.35 +13 -18 src/sbin/quotacheck/quotacheck.c 1.1 +43 -0 src/sbin/quotacheck/quotacheck.h (new) From rwatson at FreeBSD.org Sat Jan 26 04:34:24 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Jan 26 04:34:30 2008 Subject: cvs commit: src/sys/fs/fifofs fifo_vnops.c Message-ID: <200801261234.m0QCYNhg082499@repoman.freebsd.org> rwatson 2008-01-26 12:34:23 UTC FreeBSD src repository Modified files: sys/fs/fifofs fifo_vnops.c Log: Remove Giant acquisition around soreceive() and sosend() in fifofs. The bug that caused us to reintroduce it is believed to be fixed, and Kris says he no longer sees problems with fifofs in highly parallel builds. If this works out, we'll MFC it for 7.1. MFC after: 3 months Pointed out by: kris Revision Changes Path 1.143 +4 -10 src/sys/fs/fifofs/fifo_vnops.c From keramida at FreeBSD.org Sat Jan 26 04:38:20 2008 From: keramida at FreeBSD.org (Giorgos Keramidas) Date: Sat Jan 26 04:38:28 2008 Subject: cvs commit: src/usr.bin/xargs xargs.1 Message-ID: <200801261238.m0QCcKgS082698@repoman.freebsd.org> keramida 2008-01-26 12:38:19 UTC FreeBSD src repository (doc committer) Modified files: usr.bin/xargs xargs.1 Log: Document the no-op -r option of BSD xargs(1). PR: docs/106416 Submitted by: Pete Slagle, freebsd-stable at voidcaptain.com MFC after: 3 days Revision Changes Path 1.38 +30 -2 src/usr.bin/xargs/xargs.1 From mpp at FreeBSD.org Sat Jan 26 05:03:36 2008 From: mpp at FreeBSD.org (Mike Pritchard) Date: Sat Jan 26 05:03:42 2008 Subject: cvs commit: src/share/man/man5 fstab.5 Message-ID: <200801261303.m0QD3af2093786@repoman.freebsd.org> mpp 2008-01-26 13:03:35 UTC FreeBSD src repository Modified files: share/man/man5 fstab.5 Log: Explain how the passno field in /etc/fstab works with fsck and quotacheck in some more detail. Revision Changes Path 1.28 +24 -3 src/share/man/man5/fstab.5 From mtm at FreeBSD.org Sat Jan 26 05:37:49 2008 From: mtm at FreeBSD.org (Mike Makonnen) Date: Sat Jan 26 05:37:58 2008 Subject: cvs commit: src/etc netstart Message-ID: <200801261337.m0QDbmYt096024@repoman.freebsd.org> mtm 2008-01-26 13:37:48 UTC FreeBSD src repository Modified files: etc netstart Log: Use 'quietstart' so as not to get spammed with informational diagnostics. Revision Changes Path 1.68 +26 -24 src/etc/netstart From mtm at FreeBSD.org Sat Jan 26 05:50:39 2008 From: mtm at FreeBSD.org (Mike Makonnen) Date: Sat Jan 26 05:50:46 2008 Subject: cvs commit: src/etc devd.conf Message-ID: <200801261350.m0QDocnL096946@repoman.freebsd.org> mtm 2008-01-26 13:50:38 UTC FreeBSD src repository Modified files: etc devd.conf Log: Generally, anything that runs rc.d scripts internally should start using the quiet prefix (i.e. quietstart, quietstop, etc...). Revision Changes Path 1.39 +5 -5 src/etc/devd.conf From rwatson at FreeBSD.org Sat Jan 26 05:55:53 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Jan 26 05:56:01 2008 Subject: cvs commit: src/sys/ddb db_capture.c Message-ID: <200801261355.m0QDtqdc097184@repoman.freebsd.org> rwatson 2008-01-26 13:55:52 UTC FreeBSD src repository Modified files: sys/ddb db_capture.c Log: Rename DB_ constants in db_capture.c to DDB_ so that when they are exposed as kernel compile options, they have more meaningful names. PR: 119993 MFC after: 2 months Suggested by: Scot Hetzel Revision Changes Path 1.3 +16 -16 src/sys/ddb/db_capture.c From rwatson at FreeBSD.org Sat Jan 26 05:57:34 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Jan 26 05:57:36 2008 Subject: cvs commit: src/sys/netinet tcp_usrreq.c Message-ID: <200801261357.m0QDvXmE097293@repoman.freebsd.org> rwatson 2008-01-26 13:57:33 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/netinet tcp_usrreq.c Log: Merge tcp_usrreq.c:1.167 from HEAD to RELENG_7_0: tcp_usrreq.c:1.130 removed tcbinfo locking from tcp_usr_accept(), which while in principle a good idea, opened us up to a race inherrent to the syncache's direct insertion of incoming TCP connections into the "completed connection" listen queue, as it transpires that the socket is inserted before the inpcb is fully filled in by syncache_expand(). The bug manifested with the occasional returning of 0.0.0.0:0 in the address returned by the accept() system call, which occurred if accept managed to execute tcp_usr_accept() before syncache_expand() had copied the endpoint addresses into inpcb connection state. Re-add tcbinfo locking around the address copyout, which has the effect of delaying the copy until syncache_expand() has finished running, as it is run while the tcbinfo lock is held. This is undesirable in that it increases contention on tcbinfo further, but a more significant change will be required to how the syncache inserts new sockets in order to fix this and keep more granular locking here. In particular, either more state needs to be passed into sonewconn() so that pru_attach() can fill in the fields *before* the socket is inserted, or the socket needs to be inserted in the incomplete connection queue until it is actually ready to be used. Reported by: glebius (and kris) Tested by: glebius Approved by: re (kensmith) Revision Changes Path 1.163.2.1.2.1 +2 -0 src/sys/netinet/tcp_usrreq.c From mtm at FreeBSD.org Sat Jan 26 06:02:20 2008 From: mtm at FreeBSD.org (Mike Makonnen) Date: Sat Jan 26 06:02:26 2008 Subject: cvs commit: src/etc/rc.d ipfw mountcritremote ppp Message-ID: <200801261402.m0QE2KAs097553@repoman.freebsd.org> mtm 2008-01-26 14:02:20 UTC FreeBSD src repository Modified files: etc/rc.d ipfw mountcritremote ppp Log: Generally, anything that runs rc.d scripts internally should start using the quiet prefix (i.e. quietstart, quietstop, etc...). Revision Changes Path 1.16 +2 -2 src/etc/rc.d/ipfw 1.18 +1 -1 src/etc/rc.d/mountcritremote 1.16 +2 -2 src/etc/rc.d/ppp From mav at FreeBSD.org Sat Jan 26 06:14:11 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Sat Jan 26 06:14:16 2008 Subject: cvs commit: src/sys/netgraph ng_ppp.c Message-ID: <200801261414.m0QEEBch000160@repoman.freebsd.org> mav 2008-01-26 14:14:10 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/netgraph ng_ppp.c Log: MFC rev 1.71 Fix bundle xmit octets stats for packet-split operation mode. Approved by: re (kensmith) Revision Changes Path 1.70.4.1 +4 -4 src/sys/netgraph/ng_ppp.c From yar at FreeBSD.org Sat Jan 26 09:09:41 2008 From: yar at FreeBSD.org (Yar Tikhiy) Date: Sat Jan 26 09:09:48 2008 Subject: cvs commit: src UPDATING src/include fts.h src/lib/libc/gen Makefile.inc Symbol.map fts-compat.c fts-compat.h fts.3 fts.c src/sys/sys param.h Message-ID: <200801261709.m0QH9f2D024309@repoman.freebsd.org> yar 2008-01-26 17:09:41 UTC FreeBSD src repository Modified files: . UPDATING include fts.h lib/libc/gen Makefile.inc Symbol.map fts-compat.c fts-compat.h fts.3 fts.c sys/sys param.h Log: Our fts(3) API, as inherited from 4.4BSD, suffers from integer fields in FTS and FTSENT structs being too narrow. In addition, the narrow types creep from there into fts.c. As a result, fts(3) consumers, e.g., find(1) or rm(1), can't handle file trees an ordinary user can create, which can have security implications. To fix the historic implementation of fts(3), OpenBSD and NetBSD have already changed in somewhat incompatible ways, so we are free to do so, too. This change is a superset of changes from the other BSDs with a few more improvements. It doesn't touch fts(3) functionality; it just extends integer types used by it to match modern reality and the C standard. Here are its points: o For C object sizes, use size_t unless it's 100% certain that the object will be really small. (Note that fts(3) can construct pathnames _much_ longer than PATH_MAX for its consumers.) o Avoid the short types because on modern platforms using them results in larger and slower code. Change shorts to ints as follows: - For variables than count simple, limited things like states, use plain vanilla `int' as it's the type of choice in C. - For a limited number of bit flags use `unsigned' because signed bit-wise operations are implementation-defined, i.e., unportable, in C. o For things that should be at least 64 bits wide, use long long and not int64_t, as the latter is an optional type. See FTSENT.fts_number aka FTS.fts_bignum. Extending fts_number `to satisfy future needs' is pointless because there is fts_pointer, which can be used to link to arbitrary data from an FTSENT. However, there already are fts(3) consumers that require fts_number, or fts_bignum, have at least 64 bits in it, so we must allow for them. o For the tree depth, use `long'. This is a trade-off between making this field too wide and allowing for 64-bit inode numbers and/or chain-mounted filesystems. On the one hand, `long' is almost enough for 32-bit filesystems on a 32-bit platform (our ino_t is uint32_t now). On the other hand, platforms with a 64-bit (or wider) `long' will be ready for 64-bit inode numbers, as well as for several 32-bit filesystems mounted one under another. Note that fts_level has to be signed because -1 is a magic value for it, FTS_ROOTPARENTLEVEL. o For the `nlinks' local var in fts_build(), use `long'. The logic in fts_build() requires that `nlinks' be signed, but our nlink_t currently is uint16_t. Therefore let's make the signed var wide enough to be able to represent 2^16-1 in pure C99, and even 2^32-1 on a 64-bit platform. Perhaps the logic should be changed just to use nlink_t, but it can be done later w/o breaking fts(3) ABI any more because `nlinks' is just a local var. This commit also inludes supporting stuff for the fts change: o Preserve the old versions of fts(3) functions through libc symbol versioning because the old versions appeared in all our former releases. o Bump __FreeBSD_version just in case. There is a small chance that some ill-written 3-rd party apps may fail to build or work correctly if compiled after this change. o Update the fts(3) manpage accordingly. In particular, remove references to fts_bignum, which was a FreeBSD-specific hack to work around the too narrow types of FTSENT members. Now fts_number is at least 64 bits wide (long long) and fts_bignum is an undocumented alias for fts_number kept around for compatibility reasons. According to Google Code Search, the only big consumers of fts_bignum are in our own source tree, so they can be fixed easily to use fts_number. o Mention the change in src/UPDATING. PR: bin/104458 Approved by: re (quite a while ago) Discussed with: deischen (the symbol versioning part) Reviewed by: -arch (mostly silence); das (generally OK, but we didn't agree on some types used; assuming that no objections on -arch let me to stick to my opinion) Revision Changes Path 1.517 +14 -0 src/UPDATING 1.12 +11 -18 src/include/fts.h 1.131 +1 -1 src/lib/libc/gen/Makefile.inc 1.8 +11 -8 src/lib/libc/gen/Symbol.map 1.30 +28 -9 src/lib/libc/gen/fts-compat.c 1.13 +0 -13 src/lib/libc/gen/fts-compat.h 1.24 +6 -21 src/lib/libc/gen/fts.3 1.29 +13 -41 src/lib/libc/gen/fts.c 1.329 +1 -1 src/sys/sys/param.h From jhb at FreeBSD.org Sat Jan 26 09:09:46 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Sat Jan 26 09:09:54 2008 Subject: cvs commit: src/sys/dev/pci pci.c Message-ID: <200801261709.m0QH9kmV024336@repoman.freebsd.org> jhb 2008-01-26 17:09:46 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/pci pci.c Log: MFC 1.343: Add support for ATA chipsets that have NULL'd BAR's for legacy ports. Revision Changes Path 1.292.2.24 +3 -1 src/sys/dev/pci/pci.c From brueffer at FreeBSD.org Sat Jan 26 12:23:26 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Sat Jan 26 12:23:32 2008 Subject: cvs commit: src ObsoleteFiles.inc src/share/man/man4 Makefile oldcard.4 Message-ID: <200801262023.m0QKNPF2042520@repoman.freebsd.org> brueffer 2008-01-26 20:23:25 UTC FreeBSD src repository Modified files: . ObsoleteFiles.inc share/man/man4 Makefile Removed files: share/man/man4 oldcard.4 Log: OLDCARD is long gone, so finally remove the oldcard.4 manpage. Confirmed by: imp Revision Changes Path 1.127 +3 -0 src/ObsoleteFiles.inc 1.404 +0 -2 src/share/man/man4/Makefile 1.11 +0 -244 src/share/man/man4/oldcard.4 (dead) From delphij at FreeBSD.org Sat Jan 26 13:58:29 2008 From: delphij at FreeBSD.org (Xin LI) Date: Sat Jan 26 13:58:31 2008 Subject: cvs commit: src/usr.bin/systat ifstat.c Message-ID: <200801262158.m0QLwTlr065901@repoman.freebsd.org> delphij 2008-01-26 21:58:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.bin/systat ifstat.c Log: MFC revision 1.7 date: 2008/01/12 00:11:26; author: delphij; state: Exp; lines: +4 -4 - Handle the case where interface from "middle" is missing by more carefully inspecting the return value from sysctl(3). [1] - Use calloc instead of malloc+memset of zero. Submitted by: Alexander Chernikov [1] PR: bin/119581 MFC after: 2 weeks Revision Changes Path 1.6.2.1 +4 -4 src/usr.bin/systat/ifstat.c From delphij at FreeBSD.org Sat Jan 26 13:58:45 2008 From: delphij at FreeBSD.org (Xin LI) Date: Sat Jan 26 13:58:51 2008 Subject: cvs commit: src/usr.bin/systat ifstat.c Message-ID: <200801262158.m0QLwi1t065935@repoman.freebsd.org> delphij 2008-01-26 21:58:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/systat ifstat.c Log: MFC revision 1.7 date: 2008/01/12 00:11:26; author: delphij; state: Exp; lines: +4 -4 - Handle the case where interface from "middle" is missing by more carefully inspecting the return value from sysctl(3). [1] - Use calloc instead of malloc+memset of zero. Submitted by: Alexander Chernikov [1] PR: bin/119581 MFC after: 2 weeks Revision Changes Path 1.2.8.2 +4 -4 src/usr.bin/systat/ifstat.c From brueffer at FreeBSD.org Sat Jan 26 13:58:53 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Sat Jan 26 13:58:56 2008 Subject: cvs commit: src MAINTAINERS Message-ID: <200801262158.m0QLwqOq065962@repoman.freebsd.org> brueffer 2008-01-26 21:58:52 UTC FreeBSD src repository Modified files: . MAINTAINERS Log: OLDCARD is gone, release imp's lock. Approved by: imp Revision Changes Path 1.146 +0 -1 src/MAINTAINERS From delphij at FreeBSD.org Sat Jan 26 13:59:10 2008 From: delphij at FreeBSD.org (Xin LI) Date: Sat Jan 26 13:59:13 2008 Subject: cvs commit: src/usr.bin/systat ifstat.c Message-ID: <200801262159.m0QLxA1n066009@repoman.freebsd.org> delphij 2008-01-26 21:59:10 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) usr.bin/systat ifstat.c Log: MFC revision 1.7 date: 2008/01/12 00:11:26; author: delphij; state: Exp; lines: +4 -4 - Handle the case where interface from "middle" is missing by more carefully inspecting the return value from sysctl(3). [1] - Use calloc instead of malloc+memset of zero. Submitted by: Alexander Chernikov [1] PR: bin/119581 MFC after: 2 weeks Revision Changes Path 1.2.2.1 +4 -4 src/usr.bin/systat/ifstat.c From delphij at FreeBSD.org Sat Jan 26 14:13:31 2008 From: delphij at FreeBSD.org (Xin LI) Date: Sat Jan 26 14:13:37 2008 Subject: cvs commit: src/usr.bin/systat ifstat.c Message-ID: <200801262213.m0QMDU7I068476@repoman.freebsd.org> delphij 2008-01-26 22:13:30 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) usr.bin/systat ifstat.c Log: MFC revision 1.7 date: 2008/01/12 00:11:26; author: delphij; state: Exp; lines: +4 -4 - Handle the case where interface from "middle" is missing by more carefully inspecting the return value from sysctl(3). [1] - Use calloc instead of malloc+memset of zero. Submitted by: Alexander Chernikov [1] PR: bin/119581 Approved by: re (kensmith) Revision Changes Path 1.6.4.1 +4 -4 src/usr.bin/systat/ifstat.c From aryeh.friedman at gmail.com Sat Jan 26 14:28:44 2008 From: aryeh.friedman at gmail.com (Aryeh M. Friedman) Date: Sat Jan 26 14:28:53 2008 Subject: cvs commit: src UPDATING src/include fts.h src/lib/libc/gen Makefile.inc Symbol.map fts-compat.c fts-compat.h fts.3 fts.c src/sys/sys param.h In-Reply-To: <200801261709.m0QH9f2D024309@repoman.freebsd.org> References: <200801261709.m0QH9f2D024309@repoman.freebsd.org> Message-ID: <479BB418.2030808@gmail.com> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Yar Tikhiy wrote: > yar 2008-01-26 17:09:41 UTC > > FreeBSD src repository > > Modified files: . UPDATING include > fts.h lib/libc/gen Makefile.inc Symbol.map fts-compat.c > fts-compat.h fts.3 fts.c sys/sys param.h Log: Our > fts(3) API, as inherited from 4.4BSD, suffers from integer fields > in FTS and FTSENT structs being too narrow. In addition, the > narrow types creep from there into fts.c. As a result, fts(3) > consumers, e.g., find(1) or rm(1), can't handle file trees an > ordinary user can create, which can have security implications. > > To fix the historic implementation of fts(3), OpenBSD and NetBSD > have already changed in somewhat incompatible ways, so we > are free to do so, too. This change is a superset of changes from > the other BSDs with a few more improvements. It doesn't touch > fts(3) functionality; it just extends integer types used by it to > match modern reality and the C standard. > > Here are its points: > > o For C object sizes, use size_t unless it's 100% certain that the > object will be really small. (Note that fts(3) can construct > pathnames _much_ longer than PATH_MAX for its consumers.) > > o Avoid the short types because on modern platforms using them > results in larger and slower code. Change shorts to ints as > follows: > > - For variables than count simple, limited things like states, use > plain vanilla `int' as it's the type of choice in C. > > - For a limited number of bit flags use `unsigned' because signed > bit-wise operations are implementation-defined, i.e., unportable, > in C. > > o For things that should be at least 64 bits wide, use long long > and not int64_t, as the latter is an optional type. See > FTSENT.fts_number aka FTS.fts_bignum. Extending fts_number `to > satisfy future needs' is pointless because there is fts_pointer, > which can be used to link to arbitrary data from an FTSENT. > However, there already are fts(3) consumers that require > fts_number, or fts_bignum, have at least 64 bits in it, so we must > allow for them. > > o For the tree depth, use `long'. This is a trade-off between > making this field too wide and allowing for 64-bit inode numbers > and/or chain-mounted filesystems. On the one hand, `long' is > almost enough for 32-bit filesystems on a 32-bit platform (our > ino_t is uint32_t now). On the other hand, platforms with a 64-bit > (or wider) `long' will be ready for 64-bit inode numbers, as well > as for several 32-bit filesystems mounted one under another. Note > that fts_level has to be signed because -1 is a magic value for it, > FTS_ROOTPARENTLEVEL. > > o For the `nlinks' local var in fts_build(), use `long'. The logic > in fts_build() requires that `nlinks' be signed, but our nlink_t > currently is uint16_t. Therefore let's make the signed var wide > enough to be able to represent 2^16-1 in pure C99, and even 2^32-1 > on a 64-bit platform. Perhaps the logic should be changed just to > use nlink_t, but it can be done later w/o breaking fts(3) ABI any > more because `nlinks' is just a local var. > > This commit also inludes supporting stuff for the fts change: > > o Preserve the old versions of fts(3) functions through libc symbol > versioning because the old versions appeared in all our former > releases. > > o Bump __FreeBSD_version just in case. There is a small chance > that some ill-written 3-rd party apps may fail to build or work > correctly if compiled after this change. > > o Update the fts(3) manpage accordingly. In particular, remove > references to fts_bignum, which was a FreeBSD-specific hack to work > around the too narrow types of FTSENT members. Now fts_number is > at least 64 bits wide (long long) and fts_bignum is an undocumented > alias for fts_number kept around for compatibility reasons. > According to Google Code Search, the only big consumers of > fts_bignum are in our own source tree, so they can be fixed easily > to use fts_number. > > o Mention the change in src/UPDATING. > > PR: bin/104458 Approved by: re (quite a while ago) > Discussed with: deischen (the symbol versioning part) Reviewed by: > -arch (mostly silence); das (generally OK, but we didn't agree on > some types used; assuming that no objections on -arch let me to > stick to my opinion) > > Revision Changes Path 1.517 +14 -0 src/UPDATING 1.12 > +11 -18 src/include/fts.h 1.131 +1 -1 > src/lib/libc/gen/Makefile.inc 1.8 +11 -8 > src/lib/libc/gen/Symbol.map 1.30 +28 -9 > src/lib/libc/gen/fts-compat.c 1.13 +0 -13 > src/lib/libc/gen/fts-compat.h 1.24 +6 -21 > src/lib/libc/gen/fts.3 1.29 +13 -41 src/lib/libc/gen/fts.c > 1.329 +1 -1 src/sys/sys/param.h > _______________________________________________ cvs-src@freebsd.org > mailing list http://lists.freebsd.org/mailman/listinfo/cvs-src To > unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > This breaks the build for usr.sbin/setfmac/setfmac.c on -CURRENT (AMD64). Here is a very temp fix: cvs diff: Diffing . Index: setfmac.c =================================================================== RCS file: /home/ncvs/src/usr.sbin/setfmac/setfmac.c,v retrieving revision 1.9 diff -r1.9 setfmac.c 158a159 > /* 161a163 > */ 163a166 > /* 166a170 > */ 172a177,178 > ; /* 174a181 > */ 175a183,184 > ; /* 178a188 > */ 440a451 > /* 443a455 > */ 485a498 > /* 487a501 > */ - -- Aryeh M. Friedman FloSoft Systems, Java Tool Developers Developer, not business, friendly http://www.flosoft-systems.com "Free software != Free beer" Blog: http://www.flosoft-systems.com/flosoft_systems_community/blogs/aryeh/index.php -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHm7QXQi2hk2LEXBARAgyKAJ4tzYrtAhUlYW84RopGL2Fu3Pm9iwCfYs+T bkzQ3M8fdqxHuFciiftb/uE= =30/Q -----END PGP SIGNATURE----- From rwatson at FreeBSD.org Sat Jan 26 14:32:24 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Jan 26 14:32:26 2008 Subject: cvs commit: src/sys/conf options src/sys/ddb db_capture.c Message-ID: <200801262232.m0QMWOWM069975@repoman.freebsd.org> rwatson 2008-01-26 22:32:24 UTC FreeBSD src repository Modified files: sys/conf options sys/ddb db_capture.c Log: Allow DDB_CAPTURE_DEFAULTBUFSIZE and DDB_CAPTURE_MAXBUFSIZE to be overridden at compile-time using kernel options of the same names. Rather than doing a compile-time CTASSERT of buffer sizes being even multiples of block sizes, just adjust them at boottime, as the failure mode is more user-friendly. MFC after: 2 months PR: 119993 Suggested by: Scot Hetzel Revision Changes Path 1.616 +2 -0 src/sys/conf/options 1.4 +18 -13 src/sys/ddb/db_capture.c From sam at FreeBSD.org Sat Jan 26 14:35:58 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Sat Jan 26 14:36:12 2008 Subject: cvs commit: src/sys/dev/wpi if_wpi.c Message-ID: <200801262235.m0QMZv7b070196@repoman.freebsd.org> sam 2008-01-26 22:35:57 UTC FreeBSD src repository Modified files: sys/dev/wpi if_wpi.c Log: rx mbufs must have a pkthdr; use m_gethdr to populate the rx ring (and while here correct the mbuf type) Submitted by: Sam Banks MFC after: 1 week Revision Changes Path 1.7 +1 -1 src/sys/dev/wpi/if_wpi.c From mav at FreeBSD.org Sat Jan 26 14:39:06 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Sat Jan 26 14:39:08 2008 Subject: cvs commit: src/sys/netgraph ng_ppp.c Message-ID: <200801262239.m0QMd6Hn070479@repoman.freebsd.org> mav 2008-01-26 22:39:05 UTC FreeBSD src repository Modified files: sys/netgraph ng_ppp.c Log: Improve multilink receive performance with fragment headers preallocation. Revision Changes Path 1.72 +23 -22 src/sys/netgraph/ng_ppp.c From mav at FreeBSD.org Sat Jan 26 14:41:15 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Sat Jan 26 14:41:25 2008 Subject: cvs commit: src/sys/netgraph ng_ppp.c Message-ID: <200801262241.m0QMfEFn070645@repoman.freebsd.org> mav 2008-01-26 22:41:14 UTC FreeBSD src repository Modified files: sys/netgraph ng_ppp.c Log: Improve multilink xmit performance by netgraph item reuse. Revision Changes Path 1.73 +13 -3 src/sys/netgraph/ng_ppp.c From mav at FreeBSD.org Sat Jan 26 14:42:48 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Sat Jan 26 14:42:55 2008 Subject: cvs commit: src/sys/netgraph ng_ppp.c Message-ID: <200801262242.m0QMglc1070749@repoman.freebsd.org> mav 2008-01-26 22:42:47 UTC FreeBSD src repository Modified files: sys/netgraph ng_ppp.c Log: Improve multilink receive performance by netgraph item reuse. Revision Changes Path 1.74 +17 -5 src/sys/netgraph/ng_ppp.c From rwatson at FreeBSD.org Sat Jan 26 15:02:15 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Jan 26 15:02:22 2008 Subject: cvs commit: src/sys/ddb db_capture.c Message-ID: <200801262302.m0QN2ESf071722@repoman.freebsd.org> rwatson 2008-01-26 23:02:14 UTC FreeBSD src repository Modified files: sys/ddb db_capture.c Log: Increase maximum DDB capture buffer size to 5MB. PR: 119993 MFC after: 2 months Suggested by: Scot Hetzel Revision Changes Path 1.5 +1 -1 src/sys/ddb/db_capture.c From marius at FreeBSD.org Sat Jan 26 17:00:25 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Sat Jan 26 17:00:26 2008 Subject: cvs commit: src/sys/dev/mii gentbi.c Message-ID: <200801270100.m0R10Oi0093343@repoman.freebsd.org> marius 2008-01-27 01:00:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/mii gentbi.c Log: MFC: 1.4 - Remove MIIF_NOISOLATE. - Fix spelling in a comment. Revision Changes Path 1.3.2.1 +1 -2 src/sys/dev/mii/gentbi.c From marius at FreeBSD.org Sat Jan 26 17:00:29 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Sat Jan 26 17:00:32 2008 Subject: cvs commit: src/sys/dev/mii gentbi.c Message-ID: <200801270100.m0R10Su1093370@repoman.freebsd.org> marius 2008-01-27 01:00:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/mii gentbi.c Log: MFC: 1.4 - Remove MIIF_NOISOLATE. - Fix spelling in a comment. Revision Changes Path 1.1.2.4 +1 -2 src/sys/dev/mii/gentbi.c From marius at FreeBSD.org Sat Jan 26 17:02:29 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Sat Jan 26 17:02:31 2008 Subject: cvs commit: src/sys/modules/mii Makefile Message-ID: <200801270102.m0R12ThJ093454@repoman.freebsd.org> marius 2008-01-27 01:02:29 UTC FreeBSD src repository Modified files: sys/modules/mii Makefile Log: Sort values according to style.Makefile(5). Revision Changes Path 1.31 +9 -8 src/sys/modules/mii/Makefile From marius at FreeBSD.org Sat Jan 26 17:10:42 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Sat Jan 26 17:10:50 2008 Subject: cvs commit: src/sys/conf files src/sys/dev/mii miidevs nsphyter.c nsphyterreg.h src/sys/modules/mii Makefile Message-ID: <200801270110.m0R1AgKi095012@repoman.freebsd.org> marius 2008-01-27 01:10:41 UTC FreeBSD src repository Modified files: sys/conf files sys/dev/mii miidevs sys/modules/mii Makefile Added files: sys/dev/mii nsphyter.c nsphyterreg.h Log: Add a driver for the National Semiconductor DP83815, DP83843 and DP83847 PHYs. The main reason for using a specific driver for these PHYs are reset quirks similar to the nsphy(4) driven DP83840A. PR: 112654 Obtained from: NetBSD MFC after: 2 weeks Thanks to: mlaier for testing w/ DP83815 Revision Changes Path 1.1266 +1 -0 src/sys/conf/files 1.48 +2 -0 src/sys/dev/mii/miidevs 1.1 +341 -0 src/sys/dev/mii/nsphyter.c (new) 1.1 +186 -0 src/sys/dev/mii/nsphyterreg.h (new) 1.32 +1 -1 src/sys/modules/mii/Makefile From marius at FreeBSD.org Sat Jan 26 17:11:58 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Sat Jan 26 17:12:01 2008 Subject: cvs commit: src/sys/dev/mii amphy.c Message-ID: <200801270111.m0R1BwPK095124@repoman.freebsd.org> marius 2008-01-27 01:11:58 UTC FreeBSD src repository Modified files: sys/dev/mii amphy.c Log: Fix a typo in a comment. Revision Changes Path 1.24 +1 -1 src/sys/dev/mii/amphy.c From jb at FreeBSD.org Sat Jan 26 17:19:48 2008 From: jb at FreeBSD.org (John Birrell) Date: Sat Jan 26 17:19:54 2008 Subject: cvs commit: src/usr.sbin/setfmac setfmac.c Message-ID: <200801270119.m0R1JlKn096256@repoman.freebsd.org> jb 2008-01-27 01:19:47 UTC FreeBSD src repository Modified files: usr.sbin/setfmac setfmac.c Log: fts_pathlen is now a size_t rather than an int so a cast is needed. I'm not sure why warn() and err() string formatted variables need to be right-justified. Revision Changes Path 1.10 +6 -6 src/usr.sbin/setfmac/setfmac.c From marius at FreeBSD.org Sat Jan 26 17:30:03 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Sat Jan 26 17:30:05 2008 Subject: cvs commit: src/sys/dev/mii nsphy.c Message-ID: <200801270130.m0R1U2Mo096710@repoman.freebsd.org> marius 2008-01-27 01:30:02 UTC FreeBSD src repository Modified files: sys/dev/mii nsphy.c Log: - Fix a typo in a comment. - Fix whitespace according to style(9). - Sync the comment describing why we have to wait in nsphy_reset() with nsphyter_reset(). It's true that the manual tells to not do a reset within 500us of applying power but that's unlikely the cause of problems seen here. Generally having to wait 500us after a reset however is. Revision Changes Path 1.30 +10 -8 src/sys/dev/mii/nsphy.c From mav at FreeBSD.org Sat Jan 26 18:04:13 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Sat Jan 26 18:04:22 2008 Subject: cvs commit: src/sys/netgraph ng_pred1.c Message-ID: <200801270204.m0R24C9V099174@repoman.freebsd.org> mav 2008-01-27 02:04:12 UTC FreeBSD src repository Modified files: sys/netgraph ng_pred1.c Log: Slightly simplify code. Revision Changes Path 1.3 +6 -6 src/sys/netgraph/ng_pred1.c From mav at FreeBSD.org Sat Jan 26 18:36:09 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Sat Jan 26 18:36:11 2008 Subject: cvs commit: src/sys/netgraph ng_pppoe.h Message-ID: <200801270236.m0R2a9fY001532@repoman.freebsd.org> mav 2008-01-27 02:36:08 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/netgraph ng_pppoe.h Log: MFC rev. 1.25 Remove some prehistoric never used defines. Revision Changes Path 1.24.2.1 +0 -5 src/sys/netgraph/ng_pppoe.h From mav at FreeBSD.org Sat Jan 26 18:45:42 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Sat Jan 26 18:45:48 2008 Subject: cvs commit: src/sys/netgraph ng_pppoe.c Message-ID: <200801270245.m0R2jfeJ001920@repoman.freebsd.org> mav 2008-01-27 02:45:41 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/netgraph ng_pppoe.c Log: MFC rev 1.85-1.86 Remove ng_pppoe_sendpacket() function to simplify code as it is called as much times as it has cases inside of it. Split ng_pppoe_rcvdata() function into three hook-specific ones to simplify code and reduce stack usage. Revision Changes Path 1.84.2.1 +486 -525 src/sys/netgraph/ng_pppoe.c From mav at FreeBSD.org Sat Jan 26 18:47:34 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Sat Jan 26 18:47:40 2008 Subject: cvs commit: src/sys/netgraph ng_pppoe.c Message-ID: <200801270247.m0R2lWYC001997@repoman.freebsd.org> mav 2008-01-27 02:47:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/netgraph ng_pppoe.c Log: MFC rev. 1.88 Add support for optional "AC-Name\Service-Name" syntax at NGM_PPPOE_CONNECT argument. It allows ppp, mpd or any other node consumer to request connection to specified access concentrator. Proposed by: Alexander A. Burylov Revision Changes Path 1.84.2.2 +37 -6 src/sys/netgraph/ng_pppoe.c From obrien at FreeBSD.org Sat Jan 26 19:58:23 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Sat Jan 26 19:58:26 2008 Subject: cvs commit: src/share/man/man9 style.9 Message-ID: <200801270358.m0R3wNwm007266@repoman.freebsd.org> obrien 2008-01-27 03:58:23 UTC FreeBSD src repository Modified files: share/man/man9 style.9 Log: Add to the history section. Revision Changes Path 1.125 +4 -0 src/share/man/man9/style.9 From obrien at FreeBSD.org Sat Jan 26 20:33:35 2008 From: obrien at FreeBSD.org (David O'Brien) Date: Sat Jan 26 20:33:38 2008 Subject: cvs commit: src UPDATING src/include fts.h src/lib/libc/gen Makefile.inc Symbol.map fts-compat.c fts-compat.h fts.3 fts.c src/sys/sys param.h In-Reply-To: <200801261709.m0QH9f2D024309@repoman.freebsd.org> References: <200801261709.m0QH9f2D024309@repoman.freebsd.org> Message-ID: <20080127043334.GA75235@dragon.NUXI.org> On Sat, Jan 26, 2008 at 05:09:41PM +0000, Yar Tikhiy wrote: > o For things that should be at least 64 bits wide, use long long > and not int64_t, as the latter is an optional type. I don't follow - int64_t is an ISO-C99 type, and we have it in FreeBSD. Is this code expected to be taken from FreeBSD and used in some pre-C99 system? -- -- David (obrien@FreeBSD.org) From kmacy at FreeBSD.org Sat Jan 26 20:37:04 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sat Jan 26 20:37:15 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_sge.c Message-ID: <200801270437.m0R4b3pf010982@repoman.freebsd.org> kmacy 2008-01-27 04:37:02 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_sge.c Log: fix DISABLE_MBUF_IOVEC case by initializing mbuf header completely Revision Changes Path 1.48 +11 -39 src/sys/dev/cxgb/cxgb_sge.c From kmacy at FreeBSD.org Sat Jan 26 20:39:38 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sat Jan 26 20:39:40 2008 Subject: cvs commit: src/sys/dev/cxgb/ulp/tom cxgb_tcp.h Message-ID: <200801270439.m0R4dcGE011051@repoman.freebsd.org> kmacy 2008-01-27 04:39:38 UTC FreeBSD src repository Modified files: sys/dev/cxgb/ulp/tom cxgb_tcp.h Log: Fix loading for case where we don't overload tcp_usrreqs by calling tcp_drop directly Revision Changes Path 1.2 +4 -1 src/sys/dev/cxgb/ulp/tom/cxgb_tcp.h From yar at comp.chem.msu.su Sat Jan 26 21:38:17 2008 From: yar at comp.chem.msu.su (Yar Tikhiy) Date: Sat Jan 26 21:38:25 2008 Subject: cvs commit: src UPDATING src/include fts.h src/lib/libc/gen Makefile.inc Symbol.map fts-compat.c fts-compat.h fts.3 fts.c src/sys/sys param.h In-Reply-To: <20080127043334.GA75235@dragon.NUXI.org> References: <200801261709.m0QH9f2D024309@repoman.freebsd.org> <20080127043334.GA75235@dragon.NUXI.org> Message-ID: <20080127053813.GH49535@comp.chem.msu.su> On Sat, Jan 26, 2008 at 08:33:34PM -0800, David O'Brien wrote: > On Sat, Jan 26, 2008 at 05:09:41PM +0000, Yar Tikhiy wrote: > > o For things that should be at least 64 bits wide, use long long > > and not int64_t, as the latter is an optional type. > > I don't follow - int64_t is an ISO-C99 type, and we have it in FreeBSD. > Is this code expected to be taken from FreeBSD and used in some pre-C99 > system? C99 explicitly says that any intN_t is an optional type[0]. E.g., a 96-bit system may choose not to provide int64_t if none of its basic C types is 64 bits wide. fts(3) is a purely userland library which need not depend on a particular platform[1], so I did my best to avoid any assumptions like, `There will never be a 96-bit system around.' [0] In my copy of N869 Draft it's in section 7.18.1.1, paragraph 3. [1] Unfortunately, a lot of nonportability has crept into our implementation of it. -- Yar From yar at FreeBSD.org Sat Jan 26 22:35:33 2008 From: yar at FreeBSD.org (Yar Tikhiy) Date: Sat Jan 26 22:35:36 2008 Subject: cvs commit: src/usr.sbin/setfmac setfmac.c In-Reply-To: <200801270119.m0R1JlKn096256@repoman.freebsd.org> References: <200801270119.m0R1JlKn096256@repoman.freebsd.org> Message-ID: <20080127063533.GA62684@freefall.freebsd.org> On Sun, Jan 27, 2008 at 01:19:47AM +0000, John Birrell wrote: > jb 2008-01-27 01:19:47 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/setfmac setfmac.c > Log: > fts_pathlen is now a size_t rather than an int so a cast is needed. > I'm not sure why warn() and err() string formatted variables need > to be right-justified. > > Revision Changes Path > 1.10 +6 -6 src/usr.sbin/setfmac/setfmac.c Thank you for fixing this! The format strings in question might just have a bug in them. My guess is that the author of the format strings feared that fts_path might not be NUL-terminated, so he explicitly specified variable precision of fts_pathlen; but he forgot to left-justify the field as well. In fact, fts_path in a fresh FTSENT just returned by fts_read() is always NUL-terminated. (See fts(3).) Tricks with fts_pathlen are necessary only if referring to old, saved FTSENTs, but this is dangerous and unportable anyway. setfmac seems to refer to fresh FTSENTs only, so the format can be changed safely from "%.*s" to just "%s". It will eliminate the fts_pathlen arguments to the printf-like functions completely. It was Robert Watson who committed the lines to setfmac.c, according to cvs annotate, so I added him to Cc:. Robert, do you think it's OK to simplify the format strings by changing "%.*s" to "%s" along with removing the fts_pathlen arguments? E.g.: case FTS_NS: - err(1, "traversing %.*s", ftsent->fts_pathlen, - ftsent->fts_path); + err(1, "traversing %s", ftsent->fts_path); default: Thanks! Yar From dds at FreeBSD.org Sat Jan 26 23:37:01 2008 From: dds at FreeBSD.org (Diomidis Spinellis) Date: Sat Jan 26 23:37:07 2008 Subject: cvs commit: src/bin/mv mv.c Message-ID: <200801270737.m0R7b1f1032699@repoman.freebsd.org> dds 2008-01-27 07:37:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) bin/mv mv.c Log: MFC revisions 1.47-1.50. - Follow POSIX specification when moving a directory to an existing directory across devices. - Improve consistency and remove some style bugs of earlier versions. This version passes all tests of tools/regression/bin/mv/regress.sh 1.6 PR: bin/118367 Revision Changes Path 1.45.2.2 +59 -18 src/bin/mv/mv.c From dds at FreeBSD.org Sat Jan 26 23:38:39 2008 From: dds at FreeBSD.org (Diomidis Spinellis) Date: Sat Jan 26 23:38:45 2008 Subject: cvs commit: src/bin/mv mv.c Message-ID: <200801270738.m0R7cdG9032754@repoman.freebsd.org> dds 2008-01-27 07:38:39 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) bin/mv mv.c Log: MFC revisions 1.47-1.50. - Follow POSIX specification when moving a directory to an existing directory across devices. - Improve consistency and remove some style bugs of earlier versions. This version passes all tests of tools/regression/bin/mv/regress.sh 1.6 PR: bin/118367 Revision Changes Path 1.46.2.1 +59 -18 src/bin/mv/mv.c From kib at FreeBSD.org Sat Jan 26 23:51:43 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Sat Jan 26 23:51:51 2008 Subject: cvs commit: src/sys/kern tty_pty.c Message-ID: <200801270751.m0R7phb0033317@repoman.freebsd.org> kib 2008-01-27 07:51:43 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern tty_pty.c Log: MFC rev. 1.157: In rev. 1.156, the convertion of the minor number to the unit number resulted in the argument to the make_dev() to be a unit number. Correct this by supplying a minor number to make_dev(), and using the unit number for the calculation of the slave tty name. Revision Changes Path 1.152.2.4 +5 -3 src/sys/kern/tty_pty.c From kib at FreeBSD.org Sat Jan 26 23:52:23 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Sat Jan 26 23:52:25 2008 Subject: cvs commit: src/sys/dev/syscons syscons.c Message-ID: <200801270752.m0R7qNgb033357@repoman.freebsd.org> kib 2008-01-27 07:52:23 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/syscons syscons.c Log: MFC rev. 1.457: Do not dereference NULL scp in the case the screen is not opened. Instead, return ENXIO to the ioctl caller. Revision Changes Path 1.453.2.1 +2 -0 src/sys/dev/syscons/syscons.c From kientzle at freebsd.org Sat Jan 26 23:55:02 2008 From: kientzle at freebsd.org (Tim Kientzle) Date: Sat Jan 26 23:55:07 2008 Subject: cvs commit: src UPDATING src/include fts.h src/lib/libc/gen Makefile.inc Symbol.map fts-compat.c fts-compat.h fts.3 fts.c src/sys/sys param.h In-Reply-To: <200801261709.m0QH9f2D024309@repoman.freebsd.org> References: <200801261709.m0QH9f2D024309@repoman.freebsd.org> Message-ID: <479C38D5.3050901@freebsd.org> Yar Tikhiy wrote: > Our fts(3) API, as inherited from 4.4BSD, suffers from integer > fields in FTS and FTSENT structs being too narrow. In addition, > the narrow types creep from there into fts.c. As a result, fts(3) > consumers, e.g., find(1) or rm(1), can't handle file trees an ordinary > user can create, which can have security implications. Kudos! It's about time we fixed this. The inability of 'rm' to clean up my test trees for libarchive has become a bit tiresome. ;-) Tim Kientzle From dds at FreeBSD.org Sun Jan 27 00:06:41 2008 From: dds at FreeBSD.org (Diomidis Spinellis) Date: Sun Jan 27 00:06:43 2008 Subject: cvs commit: src/etc/defaults periodic.conf src/etc/periodic/daily 460.status-mail-rejects Message-ID: <200801270806.m0R86euN035192@repoman.freebsd.org> dds 2008-01-27 08:06:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) etc/defaults periodic.conf etc/periodic/daily 460.status-mail-rejects Log: MFC: A new configuration variable, daily_status_mail_rejects_shorten, allows the rejected mail reports to tally the rejects per blacklist without providing details about individual sender hosts. The default configuration keeps the reports in their original form. Revision Changes Path 1.33.2.5 +1 -0 src/etc/defaults/periodic.conf 1.20.2.1 +8 -1 src/etc/periodic/daily/460.status-mail-rejects From dds at FreeBSD.org Sun Jan 27 00:07:15 2008 From: dds at FreeBSD.org (Diomidis Spinellis) Date: Sun Jan 27 00:07:16 2008 Subject: cvs commit: src/etc/defaults periodic.conf src/etc/periodic/daily 460.status-mail-rejects Message-ID: <200801270807.m0R87FpQ035254@repoman.freebsd.org> dds 2008-01-27 08:07:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) etc/defaults periodic.conf etc/periodic/daily 460.status-mail-rejects Log: MFC: A new configuration variable, daily_status_mail_rejects_shorten, allows the rejected mail reports to tally the rejects per blacklist without providing details about individual sender hosts. The default configuration keeps the reports in their original form. Revision Changes Path 1.44.2.2 +1 -0 src/etc/defaults/periodic.conf 1.20.10.1 +8 -1 src/etc/periodic/daily/460.status-mail-rejects From simon at FreeBSD.org Sun Jan 27 00:50:12 2008 From: simon at FreeBSD.org (Simon L. Nielsen) Date: Sun Jan 27 00:50:21 2008 Subject: cvs commit: src/usr.bin/xargs xargs.1 In-Reply-To: <200801261238.m0QCcKgS082698@repoman.freebsd.org> References: <200801261238.m0QCcKgS082698@repoman.freebsd.org> Message-ID: <20080127085017.GA966@zaphod.nitro.dk> On 2008.01.26 12:38:19 +0000, Giorgos Keramidas wrote: > keramida 2008-01-26 12:38:19 UTC > > FreeBSD src repository (doc committer) > > Modified files: > usr.bin/xargs xargs.1 > Log: > Document the no-op -r option of BSD xargs(1). [...] > | @@ -45,7 +45,7 @@ > | .Nd "construct argument list(s) and execute utility" > | .Sh SYNOPSIS > | .Nm > | -.Op Fl 0opt > | +.Op Fl 0r > | .Op Fl E Ar eofstr You removed "opt" - that seems like it wasn't intended? -- Simon L. Nielsen From mav at FreeBSD.org Sun Jan 27 00:52:42 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Sun Jan 27 00:52:49 2008 Subject: cvs commit: src/sys/netgraph/netflow netflow.c Message-ID: <200801270852.m0R8qfT1046957@repoman.freebsd.org> mav 2008-01-27 08:52:41 UTC FreeBSD src repository Modified files: sys/netgraph/netflow netflow.c Log: Remove one very strange unneded if. Revision Changes Path 1.26 +2 -7 src/sys/netgraph/netflow/netflow.c From mav at FreeBSD.org Sun Jan 27 01:22:10 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Sun Jan 27 01:22:18 2008 Subject: cvs commit: src/sys/netgraph/netflow netflow.c Message-ID: <200801270922.m0R9MAbJ050289@repoman.freebsd.org> mav 2008-01-27 09:22:10 UTC FreeBSD src repository Modified files: sys/netgraph/netflow netflow.c Log: Fix memory leak when export hook is not connected. Revision Changes Path 1.27 +2 -0 src/sys/netgraph/netflow/netflow.c From obrien at FreeBSD.org Sun Jan 27 01:47:11 2008 From: obrien at FreeBSD.org (David O'Brien) Date: Sun Jan 27 01:47:19 2008 Subject: cvs commit: src UPDATING src/include fts.h src/lib/libc/gen Makefile.inc Symbol.map fts-compat.c fts-compat.h fts.3 fts.c src/sys/sys param.h In-Reply-To: <20080127053813.GH49535@comp.chem.msu.su> References: <200801261709.m0QH9f2D024309@repoman.freebsd.org> <20080127043334.GA75235@dragon.NUXI.org> <20080127053813.GH49535@comp.chem.msu.su> Message-ID: <20080127094653.GA74753@dragon.NUXI.org> On Sun, Jan 27, 2008 at 08:38:13AM +0300, Yar Tikhiy wrote: > On Sat, Jan 26, 2008 at 08:33:34PM -0800, David O'Brien wrote: > > On Sat, Jan 26, 2008 at 05:09:41PM +0000, Yar Tikhiy wrote: > > > o For things that should be at least 64 bits wide, use long long > > > and not int64_t, as the latter is an optional type. > > > > I don't follow - int64_t is an ISO-C99 type, and we have it in FreeBSD. > > Is this code expected to be taken from FreeBSD and used in some pre-C99 > > system? > > C99 explicitly says that any intN_t is an optional type[0]. E.g., > a 96-bit system may choose not to provide int64_t if none of its > basic C types is 64 bits wide. I think this is a quite silly argument. $ find /usr/src/sys -name \*.[ch] -a -type f \ | xargs grep int[0-9][0-9]_t | wc -l 37026 I think that shows we can depend on int64_t existing and usable. > fts(3) is a purely userland library which need not depend on a > particular platform[1], so I did my best to avoid any assumptions like, > `There will never be a 96-bit system around.' This is FreeBSD - not a magazine on C programming, in which examples should be usable on all platforms. Given the use of intN_t in the kernel, we already cannot boot on this future platform Please don't un-C99 the system that folks have worked to update us to. -- -- David (obrien@FreeBSD.org) From mtm at FreeBSD.org Sun Jan 27 02:15:37 2008 From: mtm at FreeBSD.org (Mike Makonnen) Date: Sun Jan 27 02:15:43 2008 Subject: cvs commit: src/usr.sbin/adduser adduser.8 adduser.sh Message-ID: <200801271015.m0RAFaRF054251@repoman.freebsd.org> mtm 2008-01-27 10:15:36 UTC FreeBSD src repository Modified files: usr.sbin/adduser adduser.8 adduser.sh Log: Add the -M command-line option, which will set home directory permissions. Works both in interactive or batch mode. This is a heavily modified version of the patch submitted in the PR. PR: bin/105060 MFC after: 1 week Revision Changes Path 1.61 +4 -0 src/usr.sbin/adduser/adduser.8 1.32 +40 -1 src/usr.sbin/adduser/adduser.sh From rwatson at FreeBSD.org Sun Jan 27 02:51:18 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sun Jan 27 02:51:26 2008 Subject: cvs commit: src/usr.sbin/setfmac setfmac.c In-Reply-To: <20080127063533.GA62684@freefall.freebsd.org> References: <200801270119.m0R1JlKn096256@repoman.freebsd.org> <20080127063533.GA62684@freefall.freebsd.org> Message-ID: <20080127104856.P30050@fledge.watson.org> On Sun, 27 Jan 2008, Yar Tikhiy wrote: > The format strings in question might just have a bug in them. My guess is > that the author of the format strings feared that fts_path might not be > NUL-terminated, so he explicitly specified variable precision of > fts_pathlen; but he forgot to left-justify the field as well. > > In fact, fts_path in a fresh FTSENT just returned by fts_read() is always > NUL-terminated. (See fts(3).) Tricks with fts_pathlen are necessary only > if referring to old, saved FTSENTs, but this is dangerous and unportable > anyway. setfmac seems to refer to fresh FTSENTs only, so the format can be > changed safely from "%.*s" to just "%s". It will eliminate the fts_pathlen > arguments to the printf-like functions completely. > > It was Robert Watson who committed the lines to setfmac.c, according to cvs > annotate, so I added him to Cc:. > > Robert, do you think it's OK to simplify the format strings by changing > "%.*s" to "%s" along with removing the fts_pathlen arguments? E.g.: I think Brian Feldman may have originally submitted this part of the code code, and likely it was a concern about nul-termination. I'm fine with the change, especially if the concern about nul-termination was unfounded :-). Robert N M Watson Computer Laboratory University of Cambridge > > case FTS_NS: > - err(1, "traversing %.*s", ftsent->fts_pathlen, > - ftsent->fts_path); > + err(1, "traversing %s", ftsent->fts_path); > default: > > Thanks! > > Yar > From mtm at FreeBSD.org Sun Jan 27 05:45:23 2008 From: mtm at FreeBSD.org (Mike Makonnen) Date: Sun Jan 27 05:45:30 2008 Subject: cvs commit: src/etc/defaults rc.conf Message-ID: <200801271345.m0RDjMul082920@repoman.freebsd.org> mtm 2008-01-27 13:45:21 UTC FreeBSD src repository Modified files: etc/defaults rc.conf Log: Clarify that devfs_system_ruleset should contain a name, not a number. Prompted by PR conf/85363 MFC after: 3 days Revision Changes Path 1.325 +1 -1 src/etc/defaults/rc.conf From mav at FreeBSD.org Sun Jan 27 07:01:17 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Sun Jan 27 07:01:20 2008 Subject: cvs commit: src/sys/netgraph/netflow ng_netflow.c Message-ID: <200801271501.m0RF1Hki089075@repoman.freebsd.org> mav 2008-01-27 15:01:16 UTC FreeBSD src repository Modified files: sys/netgraph/netflow ng_netflow.c Log: Run expire even without export hook connected. PR: kern/119839 Revision Changes Path 1.15 +4 -8 src/sys/netgraph/netflow/ng_netflow.c From mtm at FreeBSD.org Sun Jan 27 07:15:13 2008 From: mtm at FreeBSD.org (Mike Makonnen) Date: Sun Jan 27 07:15:14 2008 Subject: cvs commit: src/etc/defaults rc.conf src/etc/rc.d ipfw src/share/man/man5 rc.conf.5 Message-ID: <200801271515.m0RFFCQW098139@repoman.freebsd.org> mtm 2008-01-27 15:15:12 UTC FreeBSD src repository Modified files: etc/defaults rc.conf etc/rc.d ipfw share/man/man5 rc.conf.5 Log: Add a dummynet_enable knob to go with firewall_enable. If this knob is enabled dummynet(4) is added to the list of required modules. Discussed on: #freebsd-bugbusters (rwatson, trhodes) PR: conf/79196 MFC after: 1 week Revision Changes Path 1.326 +1 -0 src/etc/defaults/rc.conf 1.17 +8 -0 src/etc/rc.d/ipfw 1.334 +12 -1 src/share/man/man5/rc.conf.5 From trhodes at FreeBSD.org Sun Jan 27 07:37:50 2008 From: trhodes at FreeBSD.org (Tom Rhodes) Date: Sun Jan 27 07:37:59 2008 Subject: cvs commit: src/share/man/man4 ed.4 Message-ID: <200801271537.m0RFbnaN099806@repoman.freebsd.org> trhodes 2008-01-27 15:37:49 UTC FreeBSD src repository Modified files: share/man/man4 ed.4 Log: Bring the DIAGNOSTICS section in ed.4 closer to reality by removing missing diagnostic messages and adding a few found in the code. PR: 51891 Revision Changes Path 1.56 +16 -8 src/share/man/man4/ed.4 From marius at FreeBSD.org Sun Jan 27 07:42:07 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Sun Jan 27 07:42:16 2008 Subject: cvs commit: src/sys/dev/isp isp_sbus.c Message-ID: <200801271542.m0RFg7WU000159@repoman.freebsd.org> marius 2008-01-27 15:42:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/isp isp_sbus.c Log: MFC: 1.36 Add missing locking for SBus controllers. Revision Changes Path 1.35.2.1 +5 -0 src/sys/dev/isp/isp_sbus.c From marius at FreeBSD.org Sun Jan 27 07:44:38 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Sun Jan 27 07:44:42 2008 Subject: cvs commit: src/sys/dev/isp isp_sbus.c Message-ID: <200801271544.m0RFibSD000268@repoman.freebsd.org> marius 2008-01-27 15:44:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) sys/dev/isp isp_sbus.c Log: MFC: 1.36 Add missing locking for SBus controllers. Approved by: re (kensmith) Revision Changes Path 1.35.4.1 +5 -0 src/sys/dev/isp/isp_sbus.c From iwasaki at FreeBSD.org Sun Jan 27 08:06:38 2008 From: iwasaki at FreeBSD.org (Mitsuru IWASAKI) Date: Sun Jan 27 08:06:44 2008 Subject: cvs commit: src/sys/kern subr_bus.c src/sys/sys bus.h Message-ID: <200801271606.m0RG6c42002712@repoman.freebsd.org> iwasaki 2008-01-27 16:06:38 UTC FreeBSD src repository Modified files: sys/kern subr_bus.c sys/sys bus.h Log: Add devctl_process_running() so that power management system driver can check whether devd(8) is running. MFC after: 1 week Revision Changes Path 1.204 +9 -0 src/sys/kern/subr_bus.c 1.79 +1 -0 src/sys/sys/bus.h From iwasaki at FreeBSD.org Sun Jan 27 08:11:05 2008 From: iwasaki at FreeBSD.org (Mitsuru IWASAKI) Date: Sun Jan 27 08:11:11 2008 Subject: cvs commit: src/sys/dev/acpica acpi.c Message-ID: <200801271611.m0RGB5VV002933@repoman.freebsd.org> iwasaki 2008-01-27 16:11:05 UTC FreeBSD src repository Modified files: sys/dev/acpica acpi.c Log: Enter the sleep state immediately without waiting for timeout if devd(8) is not running such as the system in single user mode. MFC after: 1 week Revision Changes Path 1.244 +6 -0 src/sys/dev/acpica/acpi.c From keramida at FreeBSD.org Sun Jan 27 08:20:37 2008 From: keramida at FreeBSD.org (Giorgos Keramidas) Date: Sun Jan 27 08:20:38 2008 Subject: cvs commit: src/usr.bin/xargs xargs.1 Message-ID: <200801271620.m0RGKabZ004243@repoman.freebsd.org> keramida 2008-01-27 16:20:36 UTC FreeBSD src repository (doc committer) Modified files: usr.bin/xargs xargs.1 Log: Revive '-opt' flags which I accidentally removed. Noticed by: simon Revision Changes Path 1.39 +1 -1 src/usr.bin/xargs/xargs.1 From keramida at ceid.upatras.gr Sun Jan 27 08:39:26 2008 From: keramida at ceid.upatras.gr (Giorgos Keramidas) Date: Sun Jan 27 08:39:34 2008 Subject: cvs commit: src/usr.bin/xargs xargs.1 In-Reply-To: <20080127085017.GA966@zaphod.nitro.dk> References: <200801261238.m0QCcKgS082698@repoman.freebsd.org> <20080127085017.GA966@zaphod.nitro.dk> Message-ID: <20080127162128.GA1878@kobe.laptop> On 2008-01-27 09:50, "Simon L. Nielsen" wrote: > On 2008.01.26 12:38:19 +0000, Giorgos Keramidas wrote: > > keramida 2008-01-26 12:38:19 UTC > > > > FreeBSD src repository (doc committer) > > > > Modified files: > > usr.bin/xargs xargs.1 > > Log: > > Document the no-op -r option of BSD xargs(1). > [...] > > | @@ -45,7 +45,7 @@ > > | .Nd "construct argument list(s) and execute utility" > > | .Sh SYNOPSIS > > | .Nm > > | -.Op Fl 0opt > > | +.Op Fl 0r > > | .Op Fl E Ar eofstr > > You removed "opt" - that seems like it wasn't intended? No that wasn't intended. I should have kept that part. It should be back now, after revision 1.39, thanks :) From marius at FreeBSD.org Sun Jan 27 09:43:20 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Sun Jan 27 09:43:30 2008 Subject: cvs commit: src/sys/dev/isp isp_sbus.c Message-ID: <200801271743.m0RHhK3E024686@repoman.freebsd.org> marius 2008-01-27 17:43:19 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/isp isp_sbus.c Log: MFC: 1.36 Add missing locking for SBus controllers. Revision Changes Path 1.15.8.10 +5 -0 src/sys/dev/isp/isp_sbus.c From marius at FreeBSD.org Sun Jan 27 09:43:31 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Sun Jan 27 09:43:35 2008 Subject: cvs commit: src/sys/dev/isp isp_sbus.c Message-ID: <200801271743.m0RHhVMi024713@repoman.freebsd.org> marius 2008-01-27 17:43:31 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/dev/isp isp_sbus.c Log: MFC: 1.36 Add missing locking for SBus controllers. Revision Changes Path 1.15.2.9 +5 -0 src/sys/dev/isp/isp_sbus.c From mtm at FreeBSD.org Sun Jan 27 14:14:57 2008 From: mtm at FreeBSD.org (Mike Makonnen) Date: Sun Jan 27 14:15:00 2008 Subject: cvs commit: src/usr.sbin/pw pw.8 Message-ID: <200801272214.m0RMEvu3057734@repoman.freebsd.org> mtm 2008-01-27 22:14:56 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/pw pw.8 Log: MFC: rev. 1.42 Clarify in what formats the grouplist for the '-G' switch may be accepted. Submitted by: Eygene Ryabinkin Revision Changes Path 1.37.2.3 +1 -1 src/usr.sbin/pw/pw.8 From mtm at FreeBSD.org Sun Jan 27 14:16:03 2008 From: mtm at FreeBSD.org (Mike Makonnen) Date: Sun Jan 27 14:16:05 2008 Subject: cvs commit: src/usr.sbin/pw pw.8 Message-ID: <200801272216.m0RMG3li057853@repoman.freebsd.org> mtm 2008-01-27 22:16:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.sbin/pw pw.8 Log: MFC: r