cvs commit: src/sys/kern kern_descrip.c

Kris Kennaway kris at FreeBSD.org
Sat Apr 26 12:55:33 UTC 2008


On Fri, Apr 25, 2008 at 03:04:59PM +0200, Roman Divacky wrote:
> On Thu, Apr 24, 2008 at 10:08:36PM +0000, Kris Kennaway wrote:
> > kris        2008-04-24 22:08:36 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/kern             kern_descrip.c 
> >   Log:
> >   fdhold can return NULL, so add the one remaining missing check for this
> >   condition.
> 
>         fdp = fdhold(p);
> +       if (fdp == NULL)
> +               return (0);
>         PROC_UNLOCK(p);
> 
> I think you leak the PROC lock here...

You're right, I mis-merged :/

Kris

--
In God we Trust -- all others must submit an X.509 certificate.
    -- Charles Forsythe <forsythe at alum.mit.edu>


More information about the cvs-src mailing list