cvs commit: src/sys/dev/ata ata-all.c

[John-Mark Gurney]

Bjoern A. Zeeb wrote this message on Sun, Apr 20, 2008 at 17:45 +0000:
> bz          2008-04-20 17:45:32 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/ata          ata-all.c 
>   Log:
>   devclass_get_maxunit() returns n+1 with n starting at 0.
>   So if we have channel 0..3  devclass_get_maxunit is 4.
>   
>   It's never been a problem as devclass_get_device() has
>   catched a possibly bad input.

Any one object to changing:
.Nm devclass_get_maxunit
.Nd find the maximum unit number in the class

to:
.Nm devclass_get_maxunit
.Nd find the next free unit number in the class

It looks like we may also want to change the description, as it doesn't:
Returns the next unit number to be allocated to device instances in the
devclass.

That's what devclass_find_free_unit does, though devclass_alloc_unit
doesn't use it.  devclass_find_free_unit is also missing a man page.

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."