From weongyo at FreeBSD.org Tue Apr 1 00:20:05 2008 From: weongyo at FreeBSD.org (Weongyo Jeong) Date: Tue Apr 1 00:20:07 2008 Subject: cvs commit: src/share/man/man4 Makefile Message-ID: <200804010720.m317K4Am026901@repoman.freebsd.org> weongyo 2008-04-01 07:20:04 UTC FreeBSD src repository Modified files: share/man/man4 Makefile Log: Connect malo.4 to the build. Approved by: thompsa (mentor) Revision Changes Path 1.413 +1 -0 src/share/man/man4/Makefile From rink at FreeBSD.org Tue Apr 1 00:36:30 2008 From: rink at FreeBSD.org (Rink Springer) Date: Tue Apr 1 00:36:34 2008 Subject: cvs commit: src/share/man/man4 Makefile src/sys/conf NOTES files src/sys/dev/cmx cmx.c cmx_pccard.c cmxreg.h cmxvar.h src/sys/dev/pccard pccarddevs src/sys/modules Makefile src/sys/modules/cmx Makefile Message-ID: <200804010736.m317aULg027540@repoman.freebsd.org> rink 2008-04-01 07:36:30 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man4 Makefile sys/conf NOTES files sys/dev/pccard pccarddevs sys/modules Makefile Added files: (Branch: RELENG_7) sys/dev/cmx cmx.c cmx_pccard.c cmxreg.h cmxvar.h sys/modules/cmx Makefile Log: MFC: Commit cmx(4), a driver for Omnikey CardMan 4040 PCMCIA smartcard readers. PR: kern/114582 Submitted by: Daniel Roethlisberger Reviewed by: imp, myself Tested by: johans, myself Revision Changes Path 1.393.2.8 +1 -0 src/share/man/man4/Makefile 1.1454.2.4 +2 -0 src/sys/conf/NOTES 1.1243.2.11 +2 -0 src/sys/conf/files 1.1.2.1 +701 -0 src/sys/dev/cmx/cmx.c (new) 1.1.2.1 +115 -0 src/sys/dev/cmx/cmx_pccard.c (new) 1.1.2.1 +66 -0 src/sys/dev/cmx/cmxreg.h (new) 1.1.2.1 +99 -0 src/sys/dev/cmx/cmxvar.h (new) 1.129.2.2 +4 -0 src/sys/dev/pccard/pccarddevs 1.540.2.8 +4 -0 src/sys/modules/Makefile 1.1.2.1 +12 -0 src/sys/modules/cmx/Makefile (new) From rink at FreeBSD.org Tue Apr 1 00:57:50 2008 From: rink at FreeBSD.org (Rink Springer) Date: Tue Apr 1 00:57:52 2008 Subject: cvs commit: src/share/man/man4 Makefile uslcom.4 src/sys/conf NOTES files src/sys/dev/usb usbdevs uslcom.c src/sys/modules Makefile src/sys/modules/uslcom Makefile Message-ID: <200804010757.m317vmPR028299@repoman.freebsd.org> rink 2008-04-01 07:57:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man4 Makefile sys/conf NOTES files sys/dev/usb usbdevs sys/modules Makefile Added files: (Branch: RELENG_7) share/man/man4 uslcom.4 sys/dev/usb uslcom.c sys/modules/uslcom Makefile Log: MFC: Import uslcom(4) from OpenBSD - this is a driver for Silicon Laboratories CP2101/CP2102 based USB serial adapters. Reviewed by: imp, emaste Obtained from: OpenBSD Revision Changes Path 1.393.2.9 +1 -0 src/share/man/man4/Makefile 1.3.2.1 +97 -0 src/share/man/man4/uslcom.4 (new) 1.1454.2.5 +2 -0 src/sys/conf/NOTES 1.1243.2.12 +1 -0 src/sys/conf/files 1.328.2.6 +26 -0 src/sys/dev/usb/usbdevs 1.2.2.1 +419 -0 src/sys/dev/usb/uslcom.c (new) 1.540.2.9 +1 -0 src/sys/modules/Makefile 1.2.2.1 +10 -0 src/sys/modules/uslcom/Makefile (new) From rink at FreeBSD.org Tue Apr 1 00:59:40 2008 From: rink at FreeBSD.org (Rink Springer) Date: Tue Apr 1 00:59:42 2008 Subject: cvs commit: src/share/man/man4 cmx.4 Message-ID: <200804010759.m317xd04028413@repoman.freebsd.org> rink 2008-04-01 07:59:39 UTC FreeBSD src repository Added files: (Branch: RELENG_7) share/man/man4 cmx.4 Log: Add cmx.4 file forgotten in previous cmx(4) MFC. Noticed by: brueffer Revision Changes Path 1.2.2.1 +120 -0 src/share/man/man4/cmx.4 (new) From rink at FreeBSD.org Tue Apr 1 01:05:31 2008 From: rink at FreeBSD.org (Rink Springer) Date: Tue Apr 1 01:05:33 2008 Subject: cvs commit: src/sys/dev/atkbdc psm.c Message-ID: <200804010805.m3185VYx029779@repoman.freebsd.org> rink 2008-04-01 08:05:31 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/atkbdc psm.c Log: MFC: Some PS/2 mice (at least the A4Tech X-7xx) need to be set to Intelli mode first before they can be set to Explorer mode. PR: kern/118578 Submitted by: Andriy Gapon (I added some comments) Reviewed by: philip Revision Changes Path 1.93.2.1 +7 -0 src/sys/dev/atkbdc/psm.c From flz at FreeBSD.org Tue Apr 1 01:43:08 2008 From: flz at FreeBSD.org (Florent Thoumie) Date: Tue Apr 1 01:43:14 2008 Subject: cvs commit: src/usr.sbin/pkg_install Makefile src/usr.sbin/pkg_install/sign Makefile README check.c common.c extern.h gzip.c gzip.h main.c pgp.h pgp_check.c pgp_sign.c pkg_sign.1 sha1.c sign.c stand.c stand.h x509.c In-Reply-To: <20080401045140.GB40865@team.vega.ru> References: <200803311245.m2VCjICB008584@repoman.freebsd.org> <20080331125802.M816@FreeBSD.org> <20080401045140.GB40865@team.vega.ru> Message-ID: On Tue, Apr 1, 2008 at 5:51 AM, Ruslan Ermilov wrote: > > On Mon, Mar 31, 2008 at 02:44:35PM +0100, Florent Thoumie wrote: > > On Mon, Mar 31, 2008 at 1:58 PM, Pav Lucistnik wrote: > > > On Mon, 31 Mar 2008 12:45:18 +0000 (UTC), Florent Thoumie wrote > > > > > > > flz 2008-03-31 12:45:18 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > usr.sbin/pkg_install Makefile > > > > Removed files: > > > > usr.sbin/pkg_install/sign Makefile README check.c common.c > > > > extern.h gzip.c gzip.h main.c pgp.h > > > > pgp_check.c pgp_sign.c pkg_sign.1 > > > > sha1.c sign.c stand.c stand.h x509.c > > > > Log: > > > > Retire pkg_sign. It was used to embed signatures in gzip'ed packages. > > > > It's not relevant since we've changed to bzip2 compression. > > > > > > Yay! > > > > > > Is the -lssl -lcrypto needed for anything else? If not, could you yank it out > > > from pkg_install/Makefile.inc ? > > > > If it links against libfetch and MK_OPENSSL!=no, it will link against > > libssl and libcrypto. > > > > Now I guess it's just a matter of explicit linking (if you remove > > those references, it still builds fine). > > > We support static linking for which they're still necessary. Right. Thanks Ruslan for the clarification. -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer From ceri at submonkey.net Tue Apr 1 01:49:47 2008 From: ceri at submonkey.net (Ceri Davies) Date: Tue Apr 1 01:49:50 2008 Subject: cvs commit: src/games/fortune/datfiles fortunes In-Reply-To: <87hcema76s.fsf@kobe.laptop> References: <200803311028.m2VASAxD097068@repoman.freebsd.org> <47F13951.2080907@FreeBSD.org> <87hcema76s.fsf@kobe.laptop> Message-ID: <20080401084946.GI44028@submonkey.net> On Tue, Apr 01, 2008 at 12:56:43AM +0300, Giorgos Keramidas wrote: > On Mon, 31 Mar 2008 12:19:45 -0700, Doug Barton wrote: > > Ganbold Tsagaankhuu wrote: > >> ganbold 2008-03-31 10:28:09 UTC > >> > >> FreeBSD src repository (doc committer) > >> > >> Modified files: > >> games/fortune/datfiles fortunes Log: > >> Improve some quotes of Chinggis Khan. > >> Remove militant and moralized quotes of Chinggis Khan. > >> Add one more quote of Chinggis Khan. > >> Reviewed by: yar > >> Approved by: keramida(mentor) > >> Revision Changes Path > >> 1.259 +37 -56 src/games/fortune/datfiles/fortunes > >> > >> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/games/fortune/datfiles/fortunes.diff?&r1=1.258&r2=1.259&f=h > > > > We do not remove fortunes without a very good reason. Can you please > > replace the ones you deleted? > > This is the age old "these fortune cookies may be offensive to some > people" bikeshed. Do we really want to go there again? Other than perhaps the grammar, I find it impossible to imagine how anyone could be offended by, for example, this one: Strive to the pass of high mountain Cross in the shallow side of the wide ocean Do not give up because of distance Will certainly reach if walks Do not discourage of human Shall overcome if you try You may as well be offended by Rocky. ceri -- That must be wonderful! I don't understand it at all. -- Moliere -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080401/2904c8cc/attachment.pgp From ganbold at micom.mng.net Tue Apr 1 03:41:25 2008 From: ganbold at micom.mng.net (Ganbold) Date: Tue Apr 1 03:41:30 2008 Subject: cvs commit: src/games/fortune/datfiles fortunes In-Reply-To: <20080401084946.GI44028@submonkey.net> References: <200803311028.m2VASAxD097068@repoman.freebsd.org> <47F13951.2080907@FreeBSD.org> <87hcema76s.fsf@kobe.laptop> <20080401084946.GI44028@submonkey.net> Message-ID: <47F1FF48.1090009@micom.mng.net> Ceri Davies wrote: > On Tue, Apr 01, 2008 at 12:56:43AM +0300, Giorgos Keramidas wrote: > >> On Mon, 31 Mar 2008 12:19:45 -0700, Doug Barton wrote: >> >>> Ganbold Tsagaankhuu wrote: >>> >>>> ganbold 2008-03-31 10:28:09 UTC >>>> >>>> FreeBSD src repository (doc committer) >>>> >>>> Modified files: >>>> games/fortune/datfiles fortunes Log: >>>> Improve some quotes of Chinggis Khan. >>>> Remove militant and moralized quotes of Chinggis Khan. >>>> Add one more quote of Chinggis Khan. >>>> Reviewed by: yar >>>> Approved by: keramida(mentor) >>>> Revision Changes Path >>>> 1.259 +37 -56 src/games/fortune/datfiles/fortunes >>>> >>>> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/games/fortune/datfiles/fortunes.diff?&r1=1.258&r2=1.259&f=h >>>> >>> We do not remove fortunes without a very good reason. Can you please >>> replace the ones you deleted? >>> >> This is the age old "these fortune cookies may be offensive to some >> people" bikeshed. Do we really want to go there again? >> > > Other than perhaps the grammar, I find it impossible to imagine how > anyone could be offended by, for example, this one: > > Strive to the pass of high mountain > Cross in the shallow side of the wide ocean > Do not give up because of distance > Will certainly reach if walks > Do not discourage of human > Shall overcome if you try > Above quote was changed to: Ascend to the high mountain pass, Cross the shallow side of the wide ocean. Do not give up to the great distance: It's by going that you will reach your aim. Be not discouraged by human frailty: You will overcome it if you try to. Ganbold > You may as well be offended by Rocky. > > ceri > -- You have a message from the operator. From kib at FreeBSD.org Tue Apr 1 03:49:06 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Tue Apr 1 03:49:09 2008 Subject: cvs commit: src/include unistd.h Message-ID: <200804011049.m31An6Xa046402@repoman.freebsd.org> kib 2008-04-01 10:49:06 UTC FreeBSD src repository Modified files: include unistd.h Log: Correct the prototype for the faccessat(). Reported by: ru Revision Changes Path 1.86 +1 -1 src/include/unistd.h From flz at FreeBSD.org Tue Apr 1 04:05:26 2008 From: flz at FreeBSD.org (Florent Thoumie) Date: Tue Apr 1 04:05:31 2008 Subject: cvs commit: src ObsoleteFiles.inc Message-ID: <200804011105.m31B5QU2048100@repoman.freebsd.org> flz 2008-04-01 11:05:26 UTC FreeBSD src repository Modified files: . ObsoleteFiles.inc Log: Add pkg_check and pkg_sign to ObsoleteFiles.inc Reminded by: Pawel Worach MFC after: 1 week Revision Changes Path 1.136 +5 -0 src/ObsoleteFiles.inc From remko at elvandar.org Tue Apr 1 04:17:39 2008 From: remko at elvandar.org (Remko Lodder) Date: Tue Apr 1 04:17:43 2008 Subject: cvs commit: src/games/fortune/datfiles fortunes In-Reply-To: <47F1FF48.1090009@micom.mng.net> References: <200803311028.m2VASAxD097068@repoman.freebsd.org> <47F13951.2080907@FreeBSD.org> <87hcema76s.fsf@kobe.laptop> <20080401084946.GI44028@submonkey.net> <47F1FF48.1090009@micom.mng.net> Message-ID: <32266.194.74.82.3.1207048683.squirrel@galain.elvandar.org> On Tue, April 1, 2008 11:24 am, Ganbold wrote: > Ceri Davies wrote: >> On Tue, Apr 01, 2008 at 12:56:43AM +0300, Giorgos Keramidas wrote: >> >>> On Mon, 31 Mar 2008 12:19:45 -0700, Doug Barton >>> wrote: >>> >>>> Ganbold Tsagaankhuu wrote: >>>> >>>>> ganbold 2008-03-31 10:28:09 UTC >>>>> >>>>> FreeBSD src repository (doc committer) >>>>> >>>>> Modified files: >>>>> games/fortune/datfiles fortunes Log: >>>>> Improve some quotes of Chinggis Khan. >>>>> Remove militant and moralized quotes of Chinggis Khan. >>>>> Add one more quote of Chinggis Khan. >>>>> Reviewed by: yar >>>>> Approved by: keramida(mentor) >>>>> Revision Changes Path >>>>> 1.259 +37 -56 src/games/fortune/datfiles/fortunes >>>>> >>>>> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/games/fortune/datfiles/fortunes.diff?&r1=1.258&r2=1.259&f=h >>>>> >>>> We do not remove fortunes without a very good reason. Can you please >>>> replace the ones you deleted? >>>> >>> This is the age old "these fortune cookies may be offensive to some >>> people" bikeshed. Do we really want to go there again? >>> >> >> Other than perhaps the grammar, I find it impossible to imagine how >> anyone could be offended by, for example, this one: >> >> Strive to the pass of high mountain >> Cross in the shallow side of the wide ocean >> Do not give up because of distance >> Will certainly reach if walks >> Do not discourage of human >> Shall overcome if you try >> > > Above quote was changed to: > > Ascend to the high mountain pass, > Cross the shallow side of the wide ocean. > Do not give up to the great distance: > It's by going that you will reach your aim. > Be not discouraged by human frailty: > You will overcome it if you try to. > > > > Ganbold > I dont understand the change this is not offending at all in my believing. Please do not change quotes of people, perhaps they weren't the best people around, but they are quotes, and quotes are not to be changed by anyone. if they are too "hard" or something, they should either be removed, or let them stay, but not changed. (unless it's an obvious typo, that isn't in the original quote ofcourse). thanks, Remko -- /"\ Best regards, | remko@FreeBSD.org \ / Remko Lodder | remko@EFnet X http://www.evilcoder.org/ | / \ ASCII Ribbon Campaign | Against HTML Mail and News From rwatson at FreeBSD.org Tue Apr 1 04:23:32 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Tue Apr 1 04:23:36 2008 Subject: cvs commit: src/sys/conf options src/sys/ddb db_capture.c Message-ID: <200804011123.m31BNWRm048774@repoman.freebsd.org> rwatson 2008-04-01 11:23:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/conf options sys/ddb db_capture.c Log: Merge options:1.616, db_capture.c:1.4 from HEAD to RELNEG_7: Allow DDB_CAPTURE_DEFAULTBUFSIZE and DDB_CAPTURE_MAXBUFSIZE to be overridden at compile-time using kernel options of the same names. Rather than doing a compile-time CTASSERT of buffer sizes being even multiples of block sizes, just adjust them at boottime, as the failure mode is more user-friendly. MFC after: 2 months PR: 119993 Suggested by: Scot Hetzel Revision Changes Path 1.608.2.2 +2 -0 src/sys/conf/options 1.5.2.4 +18 -13 src/sys/ddb/db_capture.c From rwatson at FreeBSD.org Tue Apr 1 04:31:19 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Tue Apr 1 04:31:21 2008 Subject: cvs commit: src/sys/ddb db_capture.c Message-ID: <200804011131.m31BVJVd049084@repoman.freebsd.org> rwatson 2008-04-01 11:31:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/ddb db_capture.c Log: Merge db_capture.c:1.5 from HEAD to RELENG_7: Increase maximum DDB capture buffer size to 5MB. PR: 119993 Suggested by: Scot Hetzel Revision Changes Path 1.5.2.5 +1 -1 src/sys/ddb/db_capture.c From jroberson at chesapeake.net Tue Apr 1 04:38:52 2008 From: jroberson at chesapeake.net (Jeff Roberson) Date: Tue Apr 1 04:39:02 2008 Subject: cvs commit: src/lib/libthr/thread thr_cond.c thr_private.h thr_rwlock.c In-Reply-To: <47F19B89.20601@freebsd.org> References: <200803310255.m2V2toJl053104@repoman.freebsd.org> <20080331150346.R72156@desktop> <47F19B89.20601@freebsd.org> Message-ID: <20080401013919.M72156@desktop> On Tue, 1 Apr 2008, David Xu wrote: > Jeff Roberson wrote: >> On Mon, 31 Mar 2008, David Xu wrote: >> >>> davidxu 2008-03-31 02:55:50 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> lib/libthr/thread thr_cond.c thr_private.h thr_rwlock.c >>> Log: >>> Rewrite rwlock to user atomic operations to change rwlock state, this >>> eliminates internal mutex lock contention when most rwlock operations >>> are read. >>> >>> Orignal patch provided by: jeff >> >> Thanks David! >> >> Do you still plan to do kernel side support so we can totally eliminate the >> pthread mutex and condvars from rwlock? I have evidence that this would >> produce further improvements. >> >> Jeff > > I have pure kernel version working, sometimes locking kernel sleep > chain is more expensive than a pure userland mutex locking, since > kernel sleep chain lock is global. I am hestiate adding more code > to kernel since I have tested mysql super-smack and sysbench > read-only and seen no visible performance differences. > all patches are here: > > http://people.freebsd.org/~davidxu/patch/libthr_umtx_rwlock.diff > http://people.freebsd.org/~davidxu/patch/umtx_rwlock.diff > > Te main bottleneck is in mysql itself, there are lots of lock > contention, the following is a list of the main contention points when > testing super-smack read benchmark. > > http://people.freebsd.org/~davidxu/mysql/mysql_lock.txt > > I don't think it scales beyond 4 cores ( I have tested it on a 4-core > machine). On linux it scales to 8 cores. On FreeBSD CVS is limited by poor locking in the buffer cache. I have a local hack so I can test changes to this. I will try my hack with your umtx changes and get back to you. Thanks, Jeff > > Regards, > David Xu > From rwatson at FreeBSD.org Tue Apr 1 04:39:05 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Tue Apr 1 04:39:06 2008 Subject: cvs commit: src/sys/ddb db_textdump.c Message-ID: <200804011139.m31Bd4EA049362@repoman.freebsd.org> rwatson 2008-04-01 11:39:04 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/ddb db_textdump.c Log: Merge db_textdump.c:1.3 from HEAD to RELENG_7: Use dump_write() instead of direct calls to di->dumper() in textdumps. Textdumps already do pretty much the same sanity checking, but abstractions and seatbelts are both useful. Revision Changes Path 1.3.2.3 +3 -3 src/sys/ddb/db_textdump.c From rwatson at FreeBSD.org Tue Apr 1 04:48:26 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Tue Apr 1 04:48:28 2008 Subject: cvs commit: src/sys/ddb db_examine.c Message-ID: <200804011148.m31BmPQu049691@repoman.freebsd.org> rwatson 2008-04-01 11:48:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/ddb db_examine.c Log: Merge db_examine.c:1.35 from HEAD to RELENG_7: Add a /S mode to DDB "ex" command, which interprets and prints the value at the requested address as a symbol. For example, "ex /S aio_swake" prints the name of the function currently registered in via aio_swake hook. The change as committed differs slightly from the patch in the PR, as I force the size of the retrieved value (and the automatic address increment) to be sizeof(void *). This seems to provide the most useful auto-increment behavior, and defaults using the default size (4), which is not sizeof(void *) on 64-bit platforms. PR: 57976 Submitted by: Dan Strick Revision Changes Path 1.33.2.2 +6 -0 src/sys/ddb/db_examine.c From rwatson at FreeBSD.org Tue Apr 1 04:50:04 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Tue Apr 1 04:50:07 2008 Subject: cvs commit: src/share/man/man4 ddb.4 Message-ID: <200804011150.m31Bo4Rv049788@repoman.freebsd.org> rwatson 2008-04-01 11:50:04 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man4 ddb.4 Log: Merge ddb.4:1.48 from HEAD to RELENG_7: Update ddb.4 to reflect addition of /S (symbol name) printing mode for examine. PR: 57976 Revision Changes Path 1.42.2.6 +2 -0 src/share/man/man4/ddb.4 From ganbold at micom.mng.net Tue Apr 1 04:51:43 2008 From: ganbold at micom.mng.net (Ganbold) Date: Tue Apr 1 04:51:49 2008 Subject: cvs commit: src/games/fortune/datfiles fortunes In-Reply-To: <47F13951.2080907@FreeBSD.org> References: <200803311028.m2VASAxD097068@repoman.freebsd.org> <47F13951.2080907@FreeBSD.org> Message-ID: <47F221CC.8010209@micom.mng.net> Doug Barton wrote: > Ganbold Tsagaankhuu wrote: >> ganbold 2008-03-31 10:28:09 UTC >> >> FreeBSD src repository (doc committer) >> >> Modified files: >> games/fortune/datfiles fortunes Log: >> Improve some quotes of Chinggis Khan. >> Remove militant and moralized quotes of Chinggis Khan. >> Add one more quote of Chinggis Khan. >> Reviewed by: yar >> Approved by: keramida(mentor) >> Revision Changes Path >> 1.259 +37 -56 src/games/fortune/datfiles/fortunes >> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/games/fortune/datfiles/fortunes.diff?&r1=1.258&r2=1.259&f=h >> > > We do not remove fortunes without a very good reason. Can you please > replace the ones you deleted? Sorry, Doug. I have patch that adds missing quotes here: Index: ../src/games/fortune/datfiles/fortunes =================================================================== RCS file: /home/ncvs/src/games/fortune/datfiles/fortunes,v retrieving revision 1.259 diff -u -r1.259 fortunes --- ../src/games/fortune/datfiles/fortunes 31 Mar 2008 10:28:09 -0000 1.259 +++ ../src/games/fortune/datfiles/fortunes 1 Apr 2008 02:21:21 -0000 @@ -46075,6 +46075,12 @@ The greatest griefs are those we cause ourselves. -- Sophocles % +The greatest joy a man can know is to conquer his enemies and drive them +before him. To ride their horses and take away their possessions. To see +the faces of those who were dear to them bedewed with tears, and to clasp +their wives and daughters to his arms. + -- Chinggis (Genghis) Khan +% The greatest love is a mother's, then a dog's, then a sweetheart's. -- Polish proverb % @@ -55303,6 +55309,14 @@ When a man marries again, it is because he adored his first wife. -- Wilde % +When alcohol touches the tongue, +It is as small as a gnat, +But after leaving the tongue +It becomes as big as an elephant. +It ruins the mind +And exhausts the wealth. + -- Boorchi (first of 9 knights of Genghis khan) +% When alerted to an intrusion by tinkling glass or otherwise, 1) Calm yourself 2) Identify the intruder 3) If hostile, kill him. But if you want me back out my last commit please let me know. thanks and my apologies, Ganbold > > Thanks, > > Doug > -- McEwan's Rule of Relative Importance: When traveling with a herd of elephants, don't be the first to lie down and rest. From bms at FreeBSD.org Tue Apr 1 06:54:25 2008 From: bms at FreeBSD.org (Bruce M Simpson) Date: Tue Apr 1 06:54:37 2008 Subject: cvs commit: src/contrib/netcat nc.1 netcat.c Message-ID: <200804011354.m31DsO18067704@repoman.freebsd.org> bms 2008-04-01 13:54:24 UTC FreeBSD src repository Modified files: contrib/netcat nc.1 netcat.c Log: Add an -O option to disable TCP options, for protocol testing purposes. Do this for active and passive (-l switch) TCP sessions. MFC after: 1 week Revision Changes Path 1.8 +9 -3 src/contrib/netcat/nc.1 1.7 +18 -3 src/contrib/netcat/netcat.c From yar at comp.chem.msu.su Tue Apr 1 06:55:01 2008 From: yar at comp.chem.msu.su (Yar Tikhiy) Date: Tue Apr 1 06:55:08 2008 Subject: cvs commit: src/games/fortune/datfiles fortunes In-Reply-To: <47F13951.2080907@FreeBSD.org> References: <200803311028.m2VASAxD097068@repoman.freebsd.org> <47F13951.2080907@FreeBSD.org> Message-ID: On Mon, Mar 31, 2008 at 11:19 PM, Doug Barton wrote: > > Ganbold Tsagaankhuu wrote: > > ganbold 2008-03-31 10:28:09 UTC > > > > FreeBSD src repository (doc committer) > > > > Modified files: > > games/fortune/datfiles fortunes > > Log: > > Improve some quotes of Chinggis Khan. > > Remove militant and moralized quotes of Chinggis Khan. > > Add one more quote of Chinggis Khan. > > > > Reviewed by: yar > > Approved by: keramida(mentor) > > > > Revision Changes Path > > 1.259 +37 -56 src/games/fortune/datfiles/fortunes > > > > http://www.FreeBSD.org/cgi/cvsweb.cgi/src/games/fortune/datfiles/fortunes.diff?&r1=1.258&r2=1.259&f=h > > We do not remove fortunes without a very good reason. Can you please > replace the ones you deleted? Please note that the fortunes removed were submitted by Ganbold some time ago. The things went as follows: - Ganbold posted a PR on adding quotes from Chinggis Khan; - the original version of the quotes was in rather poor English; - grog@ committed the patch as is without any corrections and left it to rot; - now Ganbold has got his commit bit and wants to finish the task he initially suggested. So I think Ganbold in a way owns the quotes and it's up to him to decide what final cut of Chinggis Khan's wisdom to present to the English-speaking world. Due to poor quality of grog@'s initial commit (which raised no objections BTW), the quotes had been WIP before this commit. IMHO this commit isn't covered by the "don't remove fortunes" rule. -- Yar From mav at FreeBSD.org Tue Apr 1 06:58:11 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Tue Apr 1 06:58:13 2008 Subject: cvs commit: src/sys/netgraph ng_car.c Message-ID: <200804011358.m31DwBUh067902@repoman.freebsd.org> mav 2008-04-01 13:58:10 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/netgraph ng_car.c Log: MFC rev. 1.6-1.7 - Switch from timeval to bintime, to use 1/(2^20) of seconds instead of microseconds. It allows to use bit shifts instead of some heavy 64bit mul/div math operations. - Account all node stats at the shape mode. - Do not check destination hook presence, it will be done by netgraph. - Use u_int instead of int in some places to simplify type conversions. - Use NG_SEND_DATA_ONLY() macro instead of selfmade equivalent. Revision Changes Path 1.4.2.2 +51 -58 src/sys/netgraph/ng_car.c From yar at comp.chem.msu.su Tue Apr 1 07:20:02 2008 From: yar at comp.chem.msu.su (Yar Tikhiy) Date: Tue Apr 1 07:20:09 2008 Subject: cvs commit: src/games/fortune/datfiles fortunes In-Reply-To: <20080401084946.GI44028@submonkey.net> References: <200803311028.m2VASAxD097068@repoman.freebsd.org> <47F13951.2080907@FreeBSD.org> <87hcema76s.fsf@kobe.laptop> <20080401084946.GI44028@submonkey.net> Message-ID: On Tue, Apr 1, 2008 at 12:49 PM, Ceri Davies wrote: > On Tue, Apr 01, 2008 at 12:56:43AM +0300, Giorgos Keramidas wrote: > > On Mon, 31 Mar 2008 12:19:45 -0700, Doug Barton wrote: > > > Ganbold Tsagaankhuu wrote: > > >> ganbold 2008-03-31 10:28:09 UTC > > >> > > >> FreeBSD src repository (doc committer) > > >> > > >> Modified files: > > >> games/fortune/datfiles fortunes Log: > > >> Improve some quotes of Chinggis Khan. > > >> Remove militant and moralized quotes of Chinggis Khan. > > >> Add one more quote of Chinggis Khan. > > >> Reviewed by: yar > > >> Approved by: keramida(mentor) > > >> Revision Changes Path > > >> 1.259 +37 -56 src/games/fortune/datfiles/fortunes > > >> > > >> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/games/fortune/datfiles/fortunes.diff?&r1=1.258&r2=1.259&f=h > > > > > > We do not remove fortunes without a very good reason. Can you please > > > replace the ones you deleted? > > > > This is the age old "these fortune cookies may be offensive to some > > people" bikeshed. Do we really want to go there again? > > Other than perhaps the grammar, I find it impossible to imagine how > anyone could be offended by, for example, this one: > > > Strive to the pass of high mountain > Cross in the shallow side of the wide ocean > Do not give up because of distance > Will certainly reach if walks > Do not discourage of human > Shall overcome if you try > > You may as well be offended by Rocky. That one wasn't a matter of offense. Perhaps Ganbold should have mentioned in his commit message how the quotes from Chinggis Khan had made their way to the fortunes file. The quotes were originally in Mongolian. More than a year ago (before becoming a committer) Ganbold posted a PR (or maybe wrote a mail to several committers) suggesting to add his English translations of the quotes. Unfortunately, their language wasn't quite ideal; but they were committed anyway by grog@. I had been feeling uneasy about the fortune file pollution since then, but I had failed to persuade grog@ to make the quotes comprehensible. When Ganbold got his commit bit, he and yours truly co-edited the translations of the quotes to bring them up to the language standards. We also wanted to make them as poetic as their originals, so we had to omit certain parts we couldn't express well enough in English. Perhaps it was a job for a committer speaking English as a native language, but none had stepped in to fix the quotes in a year. So please stop criticizing Ganbold's commit. He has just fulfilled a task he initiated, which is a Right Thing many of us don't usually do. But, of course, feel free to offer your effort and poetic talent to make the quotes from Chinggis Khan even better. ;-) -- Yar From thompsa at FreeBSD.org Tue Apr 1 08:05:12 2008 From: thompsa at FreeBSD.org (Andrew Thompson) Date: Tue Apr 1 08:05:19 2008 Subject: cvs commit: src/usr.bin/netstat route.c Message-ID: <200804011505.m31F5Bco072376@repoman.freebsd.org> thompsa 2008-04-01 15:05:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.bin/netstat route.c Log: MFC r1.85 Add IFT_BRIDGE to the Ethernet section so l2 addresses are formatted correctly Revision Changes Path 1.82.2.5 +1 -0 src/usr.bin/netstat/route.c From remko at FreeBSD.org Tue Apr 1 08:20:50 2008 From: remko at FreeBSD.org (Remko Lodder) Date: Tue Apr 1 08:20:55 2008 Subject: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.h Message-ID: <200804011520.m31FKndX072924@repoman.freebsd.org> remko 2008-04-01 15:20:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/ata ata-chipset.c ata-pci.h Log: MFC rev 1.212 ata-chipset.c MFC rev 1.83 ata-pci.h Add proper support for the SATA/AHCI part of IXP[67]00 Approved by: imp (mentor, implicit), sos Revision Changes Path 1.202.2.7 +22 -12 src/sys/dev/ata/ata-chipset.c 1.81.2.2 +6 -0 src/sys/dev/ata/ata-pci.h From keramida at freebsd.org Tue Apr 1 08:36:13 2008 From: keramida at freebsd.org (Giorgos Keramidas) Date: Tue Apr 1 08:36:22 2008 Subject: cvs commit: src/games/fortune/datfiles fortunes In-Reply-To: <32266.194.74.82.3.1207048683.squirrel@galain.elvandar.org> (Remko Lodder's message of "Tue, 1 Apr 2008 13:18:03 +0200 (CEST)") References: <200803311028.m2VASAxD097068@repoman.freebsd.org> <47F13951.2080907@FreeBSD.org> <87hcema76s.fsf@kobe.laptop> <20080401084946.GI44028@submonkey.net> <47F1FF48.1090009@micom.mng.net> <32266.194.74.82.3.1207048683.squirrel@galain.elvandar.org> Message-ID: <874paly52l.fsf@kobe.laptop> On Tue, 1 Apr 2008 13:18:03 +0200 (CEST), "Remko Lodder" wrote: >>> Other than perhaps the grammar, I find it impossible to imagine how >>> anyone could be offended by, for example, this one: >>> >>> Strive to the pass of high mountain >>> Cross in the shallow side of the wide ocean >>> Do not give up because of distance >>> Will certainly reach if walks >>> Do not discourage of human >>> Shall overcome if you try >> >> Above quote was changed to: >> >> Ascend to the high mountain pass, >> Cross the shallow side of the wide ocean. >> Do not give up to the great distance: >> It's by going that you will reach your aim. >> Be not discouraged by human frailty: >> You will overcome it if you try to. > > I dont understand the change this is not offending at all in my > believing. Please do not change quotes of people, perhaps they > weren't the best people around, but they are quotes, and quotes are > not to be changed by anyone. > > if they are too "hard" or something, they should either be removed, or > let them stay, but not changed. (unless it's an obvious typo, that > isn't in the original quote ofcourse). There are two sorts of changes in that commit. Grammar and translation fixes by Ganbold (who is a native speaker of the language) and the removal of some militant quotes. He's preparing a backout patch, so please let's not waste anymore time on this :-/ From dfr at FreeBSD.org Tue Apr 1 09:07:02 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Tue Apr 1 09:07:07 2008 Subject: cvs commit: src/sys/kern kern_lockf.c Message-ID: <200804011607.m31G71DG075301@repoman.freebsd.org> dfr 2008-04-01 16:07:01 UTC FreeBSD src repository Modified files: sys/kern kern_lockf.c Log: Don't try to use an SX lock while holding the vnode interlock. Sponsored by: Isilon Systems Revision Changes Path 1.61 +10 -5 src/sys/kern/kern_lockf.c From yar at comp.chem.msu.su Tue Apr 1 10:47:31 2008 From: yar at comp.chem.msu.su (Yar Tikhiy) Date: Tue Apr 1 10:47:38 2008 Subject: cvs commit: src/games/fortune/datfiles fortunes In-Reply-To: <874paly52l.fsf@kobe.laptop> References: <200803311028.m2VASAxD097068@repoman.freebsd.org> <47F13951.2080907@FreeBSD.org> <87hcema76s.fsf@kobe.laptop> <20080401084946.GI44028@submonkey.net> <47F1FF48.1090009@micom.mng.net> <32266.194.74.82.3.1207048683.squirrel@galain.elvandar.org> <874paly52l.fsf@kobe.laptop> Message-ID: On Tue, Apr 1, 2008 at 7:20 PM, Giorgos Keramidas wrote: > On Tue, 1 Apr 2008 13:18:03 +0200 (CEST), "Remko Lodder" wrote: > >>> Other than perhaps the grammar, I find it impossible to imagine how > >>> anyone could be offended by, for example, this one: > >>> > >>> Strive to the pass of high mountain > >>> Cross in the shallow side of the wide ocean > >>> Do not give up because of distance > >>> Will certainly reach if walks > >>> Do not discourage of human > >>> Shall overcome if you try > >> > >> Above quote was changed to: > >> > >> Ascend to the high mountain pass, > >> Cross the shallow side of the wide ocean. > >> Do not give up to the great distance: > >> It's by going that you will reach your aim. > >> Be not discouraged by human frailty: > >> You will overcome it if you try to. > > > > > I dont understand the change this is not offending at all in my > > believing. Please do not change quotes of people, perhaps they > > weren't the best people around, but they are quotes, and quotes are > > not to be changed by anyone. > > > > if they are too "hard" or something, they should either be removed, or > > let them stay, but not changed. (unless it's an obvious typo, that > > isn't in the original quote ofcourse). > > There are two sorts of changes in that commit. Grammar and translation > fixes by Ganbold (who is a native speaker of the language) and the > removal of some militant quotes. He's preparing a backout patch, so > please let's not waste anymore time on this :-/ All objections to this commit stemmed from people's not knowing that it was from Ganbold that the quotes came into the fortunes file. I don't think Ganbold should be bothered with any back-outs here, but the final decision is up to you as his mentor. I'd rather we forget the half-baked quotes committed a year ago and consider this commit by Ganbold as introducing new quotes from Chinghis Khan we all are happy to learn. Nobody but Ganbold knows Mongolian here, so he is the ultimate judge in this case anyway. -- Yar From remko at FreeBSD.org Tue Apr 1 11:22:37 2008 From: remko at FreeBSD.org (Remko Lodder) Date: Tue Apr 1 11:22:51 2008 Subject: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.h Message-ID: <200804011822.m31IMbML093035@repoman.freebsd.org> remko 2008-04-01 18:22:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/ata ata-chipset.c ata-pci.h Log: MFC rev 1.212 ata-chipset.c MFC rev 1.83 ata-pci.h Add proper support for the SATA/AHCI part of IXP[67]00 Approved by: imp (mentor, implicit), sos Revision Changes Path 1.126.2.27 +22 -12 src/sys/dev/ata/ata-chipset.c 1.49.2.16 +6 -0 src/sys/dev/ata/ata-pci.h From ceri at submonkey.net Tue Apr 1 11:48:09 2008 From: ceri at submonkey.net (Ceri Davies) Date: Tue Apr 1 11:48:14 2008 Subject: cvs commit: src/games/fortune/datfiles fortunes In-Reply-To: References: <200803311028.m2VASAxD097068@repoman.freebsd.org> <47F13951.2080907@FreeBSD.org> <87hcema76s.fsf@kobe.laptop> <20080401084946.GI44028@submonkey.net> <47F1FF48.1090009@micom.mng.net> <32266.194.74.82.3.1207048683.squirrel@galain.elvandar.org> <874paly52l.fsf@kobe.laptop> Message-ID: <20080401184805.GN44028@submonkey.net> On Tue, Apr 01, 2008 at 09:47:28PM +0400, Yar Tikhiy wrote: > On Tue, Apr 1, 2008 at 7:20 PM, Giorgos Keramidas wrote: > > On Tue, 1 Apr 2008 13:18:03 +0200 (CEST), "Remko Lodder" wrote: > > >>> Other than perhaps the grammar, I find it impossible to imagine how > > >>> anyone could be offended by, for example, this one: > > >>> > > >>> Strive to the pass of high mountain > > >>> Cross in the shallow side of the wide ocean > > >>> Do not give up because of distance > > >>> Will certainly reach if walks > > >>> Do not discourage of human > > >>> Shall overcome if you try > > >> > > >> Above quote was changed to: > > >> > > >> Ascend to the high mountain pass, > > >> Cross the shallow side of the wide ocean. > > >> Do not give up to the great distance: > > >> It's by going that you will reach your aim. > > >> Be not discouraged by human frailty: > > >> You will overcome it if you try to. > > > > > > > > I dont understand the change this is not offending at all in my > > > believing. Please do not change quotes of people, perhaps they > > > weren't the best people around, but they are quotes, and quotes are > > > not to be changed by anyone. > > > > > > if they are too "hard" or something, they should either be removed, or > > > let them stay, but not changed. (unless it's an obvious typo, that > > > isn't in the original quote ofcourse). > > > > There are two sorts of changes in that commit. Grammar and translation > > fixes by Ganbold (who is a native speaker of the language) and the > > removal of some militant quotes. He's preparing a backout patch, so > > please let's not waste anymore time on this :-/ > > All objections to this commit stemmed from people's not knowing that > it was from Ganbold that the quotes came into the fortunes file. I > don't think Ganbold should be bothered with any back-outs here, but > the final decision is up to you as his mentor. Hmm, I'm not sure that's an accurate summary. I'm perfectly happy with new translations, but I'm not happy about this being removed, for example: The greatest joy a man can know is to conquer his enemies and drive them before him. To ride their horses and take away their possessions. To see the faces of those who were dear to them bedewed with tears, and to clasp their wives and daughters to his arms. -- Chinggis (Genghis) Khan It's not very nice, but I don't believe it deserves to be removed. Ceri -- That must be wonderful! I don't understand it at all. -- Moliere -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080401/7f51c8df/attachment.pgp From kris at FreeBSD.org Tue Apr 1 12:38:23 2008 From: kris at FreeBSD.org (Kris Kennaway) Date: Tue Apr 1 12:38:26 2008 Subject: cvs commit: src/lib/libthr/thread thr_cond.c thr_private.h thr_rwlock.c In-Reply-To: <47F19B89.20601@freebsd.org> References: <200803310255.m2V2toJl053104@repoman.freebsd.org> <20080331150346.R72156@desktop> <47F19B89.20601@freebsd.org> Message-ID: <47F28F34.7060007@FreeBSD.org> David Xu wrote: > Jeff Roberson wrote: >> On Mon, 31 Mar 2008, David Xu wrote: >> >>> davidxu 2008-03-31 02:55:50 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> lib/libthr/thread thr_cond.c thr_private.h thr_rwlock.c >>> Log: >>> Rewrite rwlock to user atomic operations to change rwlock state, this >>> eliminates internal mutex lock contention when most rwlock operations >>> are read. >>> >>> Orignal patch provided by: jeff >> >> Thanks David! >> >> Do you still plan to do kernel side support so we can totally >> eliminate the pthread mutex and condvars from rwlock? I have evidence >> that this would produce further improvements. >> >> Jeff > > I have pure kernel version working, sometimes locking kernel sleep > chain is more expensive than a pure userland mutex locking, since > kernel sleep chain lock is global. I am hestiate adding more code > to kernel since I have tested mysql super-smack and sysbench > read-only and seen no visible performance differences. > all patches are here: > > http://people.freebsd.org/~davidxu/patch/libthr_umtx_rwlock.diff This patch appears to be incomplete (it also doesn't apply cleanly). /zoo/kris/src8/lib/libthr/thread/thr_rwlock.c: In function 'rwlock_rdlock_common': /zoo/kris/src8/lib/libthr/thread/thr_rwlock.c:133: warning: implicit declaration of function '_thr_rwlock_tryrdlock' /zoo/kris/src8/lib/libthr/thread/thr_rwlock.c:173: warning: implicit declaration of function '__thr_rwlock_rdlock' /zoo/kris/src8/lib/libthr/thread/thr_rwlock.c: In function '_pthread_rwlock_trywrlock': /zoo/kris/src8/lib/libthr/thread/thr_rwlock.c:246: warning: implicit declaration of function '_thr_rwlock_trywrlock' /zoo/kris/src8/lib/libthr/thread/thr_rwlock.c: In function '_pthread_rwlock_unlock': /zoo/kris/src8/lib/libthr/thread/thr_rwlock.c:275: warning: implicit declaration of function '_thr_rwlock_unlock' /zoo/kris/src8/lib/libthr/thread/thr_rwlock.c: In function 'rwlock_wrlock_common': /zoo/kris/src8/lib/libthr/thread/thr_rwlock.c:331: warning: implicit declaration of function '__thr_rwlock_wrlock' *** Error code 1 Kris From dougb at FreeBSD.org Tue Apr 1 13:00:59 2008 From: dougb at FreeBSD.org (Doug Barton) Date: Tue Apr 1 13:01:03 2008 Subject: cvs commit: src/games/fortune/datfiles fortunes In-Reply-To: <47F221CC.8010209@micom.mng.net> References: <200803311028.m2VASAxD097068@repoman.freebsd.org> <47F13951.2080907@FreeBSD.org> <47F221CC.8010209@micom.mng.net> Message-ID: <47F29475.9080609@FreeBSD.org> Ganbold wrote: > Doug Barton wrote: >> Ganbold Tsagaankhuu wrote: >>> ganbold 2008-03-31 10:28:09 UTC >>> >>> FreeBSD src repository (doc committer) >>> >>> Modified files: >>> games/fortune/datfiles fortunes Log: >>> Improve some quotes of Chinggis Khan. >>> Remove militant and moralized quotes of Chinggis Khan. >>> Add one more quote of Chinggis Khan. >>> Reviewed by: yar >>> Approved by: keramida(mentor) >>> Revision Changes Path >>> 1.259 +37 -56 src/games/fortune/datfiles/fortunes >>> >>> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/games/fortune/datfiles/fortunes.diff?&r1=1.258&r2=1.259&f=h >>> >> >> We do not remove fortunes without a very good reason. Can you please >> replace the ones you deleted? > > Sorry, Doug. I have patch that adds missing quotes here: That looks good, thanks! And since I didn't do it last time, thank you for doing this translation work. Improvements such as bringing things closer to original versions are (IMO) always welcome. Doug -- This .signature sanitized for your protection From jkh at brierdr.com Tue Apr 1 12:56:32 2008 From: jkh at brierdr.com (Jordan K. Hubbard) Date: Tue Apr 1 13:29:39 2008 Subject: cvs commit: src/games/fortune/datfiles fortunes In-Reply-To: <20080401184805.GN44028@submonkey.net> References: <200803311028.m2VASAxD097068@repoman.freebsd.org> <47F13951.2080907@FreeBSD.org> <87hcema76s.fsf@kobe.laptop> <20080401084946.GI44028@submonkey.net> <47F1FF48.1090009@micom.mng.net> <32266.194.74.82.3.1207048683.squirrel@galain.elvandar.org> <874paly52l.fsf@kobe.laptop> <20080401184805.GN44028@submonkey.net> Message-ID: On Apr 1, 2008, at 11:48 AM, Ceri Davies wrote: > The greatest joy a man can know is to conquer his enemies and drive > them > before him. To ride their horses and take away their possessions. > To see > the faces of those who were dear to them bedewed with tears, and to > clasp > their wives and daughters to his arms. > -- Chinggis (Genghis) Khan > > It's not very nice, but I don't believe it deserves to be removed. I believe the quote has also been updated (ref: http://en.wikiquote.org/wiki/Conan_the_Barbarian) : Khitan General: We have won again. This is good! But what is best in life? Khitan Warrior: The open steppe, a fleet horse, falcons at your wrist, and the wind in your hair. Khitan General: Wrong! Conan, what is best in life? Conan: To crush your enemies, see them driven before you, and to hear the lamentations of their women! Khitan General: That is good. In honor of the great Arnold Schwarzenegger (who delivered these lines as pure poetry in the first Conan movie), I believe it would only be right to replace Genghis' quote with the above! - Jordan From attilio at FreeBSD.org Tue Apr 1 13:31:55 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Tue Apr 1 13:31:57 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c src/sys/sys rwlock.h Message-ID: <200804012031.m31KVtKs000176@repoman.freebsd.org> attilio 2008-04-01 20:31:55 UTC FreeBSD src repository Modified files: sys/kern kern_rwlock.c sys/sys rwlock.h Log: Add rw_try_rlock() and rw_try_wlock() to rwlocks. These functions try the specified operation (rlocking and wlocking) and true is returned if the operation completes, false otherwise. The KPI is enriched by this commit, so __FreeBSD_version bumping and manpage updating will happen soon. Requested by: jeff, kris Revision Changes Path 1.37 +49 -0 src/sys/kern/kern_rwlock.c 1.17 +4 -0 src/sys/sys/rwlock.h From attilio at FreeBSD.org Tue Apr 1 13:33:07 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Tue Apr 1 13:33:09 2008 Subject: cvs commit: src/sys/sys param.h Message-ID: <200804012033.m31KX6Gs000233@repoman.freebsd.org> attilio 2008-04-01 20:33:06 UTC FreeBSD src repository Modified files: sys/sys param.h Log: Bump __FreeBSD_version in order to reflect rw_try_rlock() and rw_try_wlock() functions introduction. Revision Changes Path 1.346 +1 -1 src/sys/sys/param.h From emaste at FreeBSD.org Tue Apr 1 13:53:32 2008 From: emaste at FreeBSD.org (Ed Maste) Date: Tue Apr 1 13:53:44 2008 Subject: cvs commit: src/sys/dev/aac aac.c Message-ID: <200804012053.m31KrWAl010090@repoman.freebsd.org> emaste 2008-04-01 20:53:32 UTC FreeBSD src repository Modified files: sys/dev/aac aac.c Log: Calling RequestSupplementAdapterInfo before RequestAdapterInfo appears to trip a bug causing the latter to return a zeroed struct aac_adapter_info. This causes two issues. One is cosmetic only -- a verbose boot prints information about the controller, and shows all zero: aac0: Unknown processor 0MHz, 0MB memory (0MB cache, 0MB execution), unknown battery platform The second problem is that the firmware version information is stored away for aac_rev_check, for userland tools (like aaccli) to query via the FSACTL_MINIPORT_REV_CHECK and FSACTL_LNX_MINIPORT_REV_CHECK ioctls. When aaccli encounters this issue it prints Command Error: Move the RequestSupplementAdapterInfo call after RequestAdapterInfo, which seems to fix both problems. Revision Changes Path 1.137 +17 -17 src/sys/dev/aac/aac.c From attilio at FreeBSD.org Tue Apr 1 13:56:46 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Tue Apr 1 13:56:48 2008 Subject: cvs commit: src/share/man/man9 Makefile rwlock.9 Message-ID: <200804012056.m31KujVi010270@repoman.freebsd.org> attilio 2008-04-01 20:56:45 UTC FreeBSD src repository Modified files: share/man/man9 Makefile rwlock.9 Log: Add manpages for rw_try_rlock() and rw_try_wlock() functions. Revision Changes Path 1.334 +2 -0 src/share/man/man9/Makefile 1.15 +19 -1 src/share/man/man9/rwlock.9 From max at love2party.net Tue Apr 1 15:28:06 2008 From: max at love2party.net (Max Laier) Date: Tue Apr 1 15:28:10 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c src/sys/sys rwlock.h In-Reply-To: <200804012031.m31KVtKs000176@repoman.freebsd.org> References: <200804012031.m31KVtKs000176@repoman.freebsd.org> Message-ID: <200804020025.57684.max@love2party.net> On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote: > attilio 2008-04-01 20:31:55 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_rwlock.c > sys/sys rwlock.h > Log: > Add rw_try_rlock() and rw_try_wlock() to rwlocks. > These functions try the specified operation (rlocking and wlocking) > and true is returned if the operation completes, false otherwise. hmmm ... I'm certainly missing something here, but what's a possible usecase for these? It seems there is not much you can do if you can't obtain a rw_lock. I can understand the need for sx_try_* where you want to avoid sleeping, but I can't figure out the need for it on a locking primitive that will only spin or wait (not 100% sure about the terminology here). This is especially strange for rw_try_wlock, unless you plan to sleep manually on fail. But then again you'd have a good chance that you have to do it over and over again if timing is unfortunate. > The KPI is enriched by this commit, so __FreeBSD_version bumping and > manpage updating will happen soon. > > Requested by: jeff, kris > > Revision Changes Path > 1.37 +49 -0 src/sys/kern/kern_rwlock.c > 1.17 +4 -0 src/sys/sys/rwlock.h -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News From jroberson at chesapeake.net Tue Apr 1 15:51:38 2008 From: jroberson at chesapeake.net (Jeff Roberson) Date: Tue Apr 1 15:51:42 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c src/sys/sys rwlock.h In-Reply-To: <200804020025.57684.max@love2party.net> References: <200804012031.m31KVtKs000176@repoman.freebsd.org> <200804020025.57684.max@love2party.net> Message-ID: <20080401123951.J72156@desktop> On Wed, 2 Apr 2008, Max Laier wrote: > On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote: >> attilio 2008-04-01 20:31:55 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/kern kern_rwlock.c >> sys/sys rwlock.h >> Log: >> Add rw_try_rlock() and rw_try_wlock() to rwlocks. >> These functions try the specified operation (rlocking and wlocking) >> and true is returned if the operation completes, false otherwise. > > hmmm ... I'm certainly missing something here, but what's a possible > usecase for these? It seems there is not much you can do if you can't > obtain a rw_lock. I can understand the need for sx_try_* where you want > to avoid sleeping, but I can't figure out the need for it on a locking > primitive that will only spin or wait (not 100% sure about the > terminology here). This is especially strange for rw_try_wlock, unless > you plan to sleep manually on fail. But then again you'd have a good > chance that you have to do it over and over again if timing is > unfortunate. I asked for it. We have a try operation for mtx already. I was experimenting with converting some code to use rwlocks from mtx and it required it. The specific case is in the softdep code where it uses trylock to avoid deadlocking. With trylock you can violate the lockorder. Thanks, Jeff > >> The KPI is enriched by this commit, so __FreeBSD_version bumping and >> manpage updating will happen soon. >> >> Requested by: jeff, kris >> >> Revision Changes Path >> 1.37 +49 -0 src/sys/kern/kern_rwlock.c >> 1.17 +4 -0 src/sys/sys/rwlock.h > > > > -- > /"\ Best regards, | mlaier@freebsd.org > \ / Max Laier | ICQ #67774661 > X http://pf4freebsd.love2party.net/ | mlaier@EFnet > / \ ASCII Ribbon Campaign | Against HTML Mail and News > From kris at FreeBSD.org Tue Apr 1 16:15:42 2008 From: kris at FreeBSD.org (Kris Kennaway) Date: Tue Apr 1 16:15:44 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c src/sys/sys rwlock.h In-Reply-To: <200804020025.57684.max@love2party.net> References: <200804012031.m31KVtKs000176@repoman.freebsd.org> <200804020025.57684.max@love2party.net> Message-ID: <47F2C223.6010705@FreeBSD.org> Max Laier wrote: > On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote: >> attilio 2008-04-01 20:31:55 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/kern kern_rwlock.c >> sys/sys rwlock.h >> Log: >> Add rw_try_rlock() and rw_try_wlock() to rwlocks. >> These functions try the specified operation (rlocking and wlocking) >> and true is returned if the operation completes, false otherwise. > > hmmm ... I'm certainly missing something here, but what's a possible > usecase for these? It seems there is not much you can do if you can't > obtain a rw_lock. I can understand the need for sx_try_* where you want > to avoid sleeping, but I can't figure out the need for it on a locking > primitive that will only spin or wait (not 100% sure about the > terminology here). This is especially strange for rw_try_wlock, unless > you plan to sleep manually on fail. But then again you'd have a good > chance that you have to do it over and over again if timing is > unfortunate. One situation is that try_[rw]lock can be used to bail out completely if you are doing something optional. e.g. you might have code that is doing some optimization like prefetching of data that can be just skipped if the lock (read or write) cannot be immediately obtained. Kris From iedowse at FreeBSD.org Tue Apr 1 16:40:33 2008 From: iedowse at FreeBSD.org (Ian Dowse) Date: Tue Apr 1 16:40:35 2008 Subject: cvs commit: src/sys/net if.h Message-ID: <200804012340.m31NeXb8020569@repoman.freebsd.org> iedowse 2008-04-01 23:40:33 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/net if.h Log: MFC 1.113: Add IFF_NEEDSGIANT to IFF_CANTCHANGE to prevent userland code from clearing IFF_NEEDSGIANT. Revision Changes Path 1.108.2.1 +2 -1 src/sys/net/if.h From obrien at FreeBSD.org Tue Apr 1 17:02:48 2008 From: obrien at FreeBSD.org (David O'Brien) Date: Tue Apr 1 17:02:55 2008 Subject: cvs commit: CVSROOT exclude In-Reply-To: <20080401040349.GA74837@what-creek.com> References: <200803282147.m2SLlC0R038334@repoman.freebsd.org> <20080330235811.GA23907@dragon.NUXI.org> <20080331002108.GC61720@what-creek.com> <20080401024255.GC66987@dragon.NUXI.org> <20080401040349.GA74837@what-creek.com> Message-ID: <20080402000247.GA12975@dragon.NUXI.org> On Tue, Apr 01, 2008 at 04:03:49AM +0000, John Birrell wrote: > The remaining two lines: > ^src/cddl/contrib/opensolaris > ^src/sys/cddl/contrib/opensolaris > need to stay. Why do they need to stay, if we've made changes to every one of the files in these trees (the claim I've heard). -- -- David (obrien@FreeBSD.org) From max at love2party.net Tue Apr 1 17:03:07 2008 From: max at love2party.net (Max Laier) Date: Tue Apr 1 17:03:14 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c src/sys/sys rwlock.h In-Reply-To: <20080401123951.J72156@desktop> References: <200804012031.m31KVtKs000176@repoman.freebsd.org> <200804020025.57684.max@love2party.net> <20080401123951.J72156@desktop> Message-ID: <200804020200.58006.max@love2party.net> On Wednesday 02 April 2008 00:52:45 Jeff Roberson wrote: > On Wed, 2 Apr 2008, Max Laier wrote: > > On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote: > >> attilio 2008-04-01 20:31:55 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/kern kern_rwlock.c > >> sys/sys rwlock.h > >> Log: > >> Add rw_try_rlock() and rw_try_wlock() to rwlocks. > >> These functions try the specified operation (rlocking and > >> wlocking) and true is returned if the operation completes, false > >> otherwise. > > > > hmmm ... I'm certainly missing something here, but what's a possible > > usecase for these? It seems there is not much you can do if you > > can't obtain a rw_lock. I can understand the need for sx_try_* where > > you want to avoid sleeping, but I can't figure out the need for it on > > a locking primitive that will only spin or wait (not 100% sure about > > the terminology here). This is especially strange for rw_try_wlock, > > unless you plan to sleep manually on fail. But then again you'd have > > a good chance that you have to do it over and over again if timing is > > unfortunate. > > I asked for it. We have a try operation for mtx already. I was > experimenting with converting some code to use rwlocks from mtx and it > required it. The specific case is in the softdep code where it uses > trylock to avoid deadlocking. With trylock you can violate the > lockorder. Makes sense, thanks! A little follow-up, though about something I'm wondering about for quite some time now. Take the following scenario: Thread A: rw_rlock(RW) ... mtx_lock(MTX) ... UNLOCK Thread B: mtx_lock(MTX) ... rw_rlock(RW) ... UNLOCK Thread C: rw_wlock(RW) ... UNLOCK Can this deadlock? How? If thread C did: rw_wlock(RW) ... mtx_lock(MTX) ... UNLOCK or the other way around, I can see that it will[1] deadlock, but with the wlock without a lock order wrt the MTX, I can't see it. Plus, can we teach WITNESS to keep quite about thread A and B unless we also see a lock order with the wlock and the mutex? [1] In fact, thinking about it right now ... if thread C did: mtx_lock(MTX) ... rw_slock(RW) ... UNLOCK it might still be okay. IIRC we allow rlocks to succeed as long as there are other rlocks held. Though this might be historical behavior to support recursion. I see that we wouldn't want to rely on this to avoid live locks. -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News From attilio at freebsd.org Tue Apr 1 17:23:25 2008 From: attilio at freebsd.org (Attilio Rao) Date: Tue Apr 1 17:23:48 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c src/sys/sys rwlock.h In-Reply-To: <200804020200.58006.max@love2party.net> References: <200804012031.m31KVtKs000176@repoman.freebsd.org> <200804020025.57684.max@love2party.net> <20080401123951.J72156@desktop> <200804020200.58006.max@love2party.net> Message-ID: <3bbf2fe10804011723w69e38ed7sc5760ea269600654@mail.gmail.com> 2008/4/2, Max Laier : > On Wednesday 02 April 2008 00:52:45 Jeff Roberson wrote: > > On Wed, 2 Apr 2008, Max Laier wrote: > > > On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote: > > >> attilio 2008-04-01 20:31:55 UTC > > >> > > >> FreeBSD src repository > > >> > > >> Modified files: > > >> sys/kern kern_rwlock.c > > >> sys/sys rwlock.h > > >> Log: > > >> Add rw_try_rlock() and rw_try_wlock() to rwlocks. > > >> These functions try the specified operation (rlocking and > > >> wlocking) and true is returned if the operation completes, false > > >> otherwise. > > > > > > hmmm ... I'm certainly missing something here, but what's a possible > > > usecase for these? It seems there is not much you can do if you > > > can't obtain a rw_lock. I can understand the need for sx_try_* where > > > you want to avoid sleeping, but I can't figure out the need for it on > > > a locking primitive that will only spin or wait (not 100% sure about > > > the terminology here). This is especially strange for rw_try_wlock, > > > unless you plan to sleep manually on fail. But then again you'd have > > > a good chance that you have to do it over and over again if timing is > > > unfortunate. > > > > I asked for it. We have a try operation for mtx already. I was > > experimenting with converting some code to use rwlocks from mtx and it > > required it. The specific case is in the softdep code where it uses > > trylock to avoid deadlocking. With trylock you can violate the > > lockorder. > > > Makes sense, thanks! A little follow-up, though about something I'm > wondering about for quite some time now. Take the following scenario: > > Thread A: rw_rlock(RW) ... mtx_lock(MTX) ... UNLOCK > Thread B: mtx_lock(MTX) ... rw_rlock(RW) ... UNLOCK > Thread C: rw_wlock(RW) ... UNLOCK This can't deadlock simply because rw_rlock() is not mutually exclusive. > Can this deadlock? How? > > If thread C did: rw_wlock(RW) ... mtx_lock(MTX) ... UNLOCK or the other > way around, I can see that it will[1] deadlock, but with the wlock > without a lock order wrt the MTX, I can't see it. Plus, can we teach > WITNESS to keep quite about thread A and B unless we also see a lock > order with the wlock and the mutex? You mean skipping possible LORs for shared instances of double-sided primitives? Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein From jb at what-creek.com Tue Apr 1 17:48:39 2008 From: jb at what-creek.com (John Birrell) Date: Tue Apr 1 17:48:47 2008 Subject: cvs commit: CVSROOT exclude In-Reply-To: <20080402000247.GA12975@dragon.NUXI.org> References: <200803282147.m2SLlC0R038334@repoman.freebsd.org> <20080330235811.GA23907@dragon.NUXI.org> <20080331002108.GC61720@what-creek.com> <20080401024255.GC66987@dragon.NUXI.org> <20080401040349.GA74837@what-creek.com> <20080402000247.GA12975@dragon.NUXI.org> Message-ID: <20080402004838.GA84296@what-creek.com> On Tue, Apr 01, 2008 at 05:02:47PM -0700, David O'Brien wrote: > On Tue, Apr 01, 2008 at 04:03:49AM +0000, John Birrell wrote: > > The remaining two lines: > > ^src/cddl/contrib/opensolaris > > ^src/sys/cddl/contrib/opensolaris > > need to stay. > > Why do they need to stay, if we've made changes to every one of the files > in these trees (the claim I've heard). Most files. Not all. -- John Birrell From jroberson at chesapeake.net Tue Apr 1 18:10:01 2008 From: jroberson at chesapeake.net (Jeff Roberson) Date: Tue Apr 1 18:10:08 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c src/sys/sys rwlock.h In-Reply-To: <3bbf2fe10804011723w69e38ed7sc5760ea269600654@mail.gmail.com> References: <200804012031.m31KVtKs000176@repoman.freebsd.org> <200804020025.57684.max@love2party.net> <20080401123951.J72156@desktop> <200804020200.58006.max@love2party.net> <3bbf2fe10804011723w69e38ed7sc5760ea269600654@mail.gmail.com> Message-ID: <20080401150918.F72156@desktop> On Wed, 2 Apr 2008, Attilio Rao wrote: > 2008/4/2, Max Laier : >> On Wednesday 02 April 2008 00:52:45 Jeff Roberson wrote: >> > On Wed, 2 Apr 2008, Max Laier wrote: >> >> On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote: >> >>> attilio 2008-04-01 20:31:55 UTC >> >>> >> >>> FreeBSD src repository >> >>> >> >>> Modified files: >> >>> sys/kern kern_rwlock.c >> >>> sys/sys rwlock.h >> >>> Log: >> >>> Add rw_try_rlock() and rw_try_wlock() to rwlocks. >> >>> These functions try the specified operation (rlocking and >> >>> wlocking) and true is returned if the operation completes, false >> >>> otherwise. >> >> >> >> hmmm ... I'm certainly missing something here, but what's a possible >> >> usecase for these? It seems there is not much you can do if you >> >> can't obtain a rw_lock. I can understand the need for sx_try_* where >> >> you want to avoid sleeping, but I can't figure out the need for it on >> >> a locking primitive that will only spin or wait (not 100% sure about >> >> the terminology here). This is especially strange for rw_try_wlock, >> >> unless you plan to sleep manually on fail. But then again you'd have >> >> a good chance that you have to do it over and over again if timing is >> >> unfortunate. >> > >> > I asked for it. We have a try operation for mtx already. I was >> > experimenting with converting some code to use rwlocks from mtx and it >> > required it. The specific case is in the softdep code where it uses >> > trylock to avoid deadlocking. With trylock you can violate the >> > lockorder. >> >> >> Makes sense, thanks! A little follow-up, though about something I'm >> wondering about for quite some time now. Take the following scenario: >> >> Thread A: rw_rlock(RW) ... mtx_lock(MTX) ... UNLOCK >> Thread B: mtx_lock(MTX) ... rw_rlock(RW) ... UNLOCK >> Thread C: rw_wlock(RW) ... UNLOCK > > This can't deadlock simply because rw_rlock() is not mutually exclusive. It can deadlock if there is a writer waiting in queue depending on whether we prefer readers or writers. I think we should consider the reader/writer perference an implementation detail to prevent code like this from cropping up. Readers are only allowed to proceed with a read lock if they already own a read lock, not just if the lock is already read locked. This changed in current recently. So a single recursive read acqusition can't deadlock but get multiple threads and a writer involved with writer preference and you can. Jeff > >> Can this deadlock? How? >> >> If thread C did: rw_wlock(RW) ... mtx_lock(MTX) ... UNLOCK or the other >> way around, I can see that it will[1] deadlock, but with the wlock >> without a lock order wrt the MTX, I can't see it. Plus, can we teach >> WITNESS to keep quite about thread A and B unless we also see a lock >> order with the wlock and the mutex? > > You mean skipping possible LORs for shared instances of double-sided primitives? > > Thanks, > Attilio > > > -- > Peace can only be achieved by understanding - A. Einstein > From yar at comp.chem.msu.su Tue Apr 1 18:15:00 2008 From: yar at comp.chem.msu.su (Yar Tikhiy) Date: Tue Apr 1 18:15:02 2008 Subject: cvs commit: src/games/fortune/datfiles fortunes In-Reply-To: <20080401184805.GN44028@submonkey.net> References: <200803311028.m2VASAxD097068@repoman.freebsd.org> <47F13951.2080907@FreeBSD.org> <87hcema76s.fsf@kobe.laptop> <20080401084946.GI44028@submonkey.net> <47F1FF48.1090009@micom.mng.net> <32266.194.74.82.3.1207048683.squirrel@galain.elvandar.org> <874paly52l.fsf@kobe.laptop> <20080401184805.GN44028@submonkey.net> Message-ID: On Tue, Apr 1, 2008 at 10:48 PM, Ceri Davies wrote: > > On Tue, Apr 01, 2008 at 09:47:28PM +0400, Yar Tikhiy wrote: > > On Tue, Apr 1, 2008 at 7:20 PM, Giorgos Keramidas wrote: > > > On Tue, 1 Apr 2008 13:18:03 +0200 (CEST), "Remko Lodder" wrote: > > > >>> Other than perhaps the grammar, I find it impossible to imagine how > > > >>> anyone could be offended by, for example, this one: > > > >>> > > > >>> Strive to the pass of high mountain > > > >>> Cross in the shallow side of the wide ocean > > > >>> Do not give up because of distance > > > >>> Will certainly reach if walks > > > >>> Do not discourage of human > > > >>> Shall overcome if you try > > > >> > > > >> Above quote was changed to: > > > >> > > > >> Ascend to the high mountain pass, > > > >> Cross the shallow side of the wide ocean. > > > >> Do not give up to the great distance: > > > >> It's by going that you will reach your aim. > > > >> Be not discouraged by human frailty: > > > >> You will overcome it if you try to. > > > > > > > > > > > I dont understand the change this is not offending at all in my > > > > believing. Please do not change quotes of people, perhaps they > > > > weren't the best people around, but they are quotes, and quotes are > > > > not to be changed by anyone. > > > > > > > > if they are too "hard" or something, they should either be removed, or > > > > let them stay, but not changed. (unless it's an obvious typo, that > > > > isn't in the original quote ofcourse). > > > > > > There are two sorts of changes in that commit. Grammar and translation > > > fixes by Ganbold (who is a native speaker of the language) and the > > > removal of some militant quotes. He's preparing a backout patch, so > > > please let's not waste anymore time on this :-/ > > > > All objections to this commit stemmed from people's not knowing that > > it was from Ganbold that the quotes came into the fortunes file. I > > don't think Ganbold should be bothered with any back-outs here, but > > the final decision is up to you as his mentor. > > Hmm, I'm not sure that's an accurate summary. I'm perfectly happy with > new translations, but I'm not happy about this being removed, for > example: > > > The greatest joy a man can know is to conquer his enemies and drive them > before him. To ride their horses and take away their possessions. To see > the faces of those who were dear to them bedewed with tears, and to clasp > their wives and daughters to his arms. > -- Chinggis (Genghis) Khan > > It's not very nice, but I don't believe it deserves to be removed. You have a point here! It appears that this quote had been in the fortunes file before the collection translated by Ganbold was initially committed. According to the CVS history, it used to be the only quote from Genghis Khan in our fortunes file, so let's restore it and thus conclude this thread. Sorry, it was my idea to axe it. -- Yar From max at love2party.net Tue Apr 1 19:14:40 2008 From: max at love2party.net (Max Laier) Date: Tue Apr 1 19:14:48 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c src/sys/sys rwlock.h In-Reply-To: <20080401150918.F72156@desktop> References: <200804012031.m31KVtKs000176@repoman.freebsd.org> <3bbf2fe10804011723w69e38ed7sc5760ea269600654@mail.gmail.com> <20080401150918.F72156@desktop> Message-ID: <200804020412.30624.max@love2party.net> On Wednesday 02 April 2008 03:11:11 Jeff Roberson wrote: > On Wed, 2 Apr 2008, Attilio Rao wrote: > > 2008/4/2, Max Laier : > >> On Wednesday 02 April 2008 00:52:45 Jeff Roberson wrote: > >> > On Wed, 2 Apr 2008, Max Laier wrote: > >> >> On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote: > >> >>> attilio 2008-04-01 20:31:55 UTC > >> >>> > >> >>> FreeBSD src repository > >> >>> > >> >>> Modified files: > >> >>> sys/kern kern_rwlock.c > >> >>> sys/sys rwlock.h > >> >>> Log: > >> >>> Add rw_try_rlock() and rw_try_wlock() to rwlocks. > >> >>> These functions try the specified operation (rlocking and > >> >>> wlocking) and true is returned if the operation completes, false > >> >>> otherwise. > >> >> > >> >> hmmm ... I'm certainly missing something here, but what's a > >> >> possible usecase for these? It seems there is not much you can > >> >> do if you can't obtain a rw_lock. I can understand the need for > >> >> sx_try_* where you want to avoid sleeping, but I can't figure out > >> >> the need for it on a locking primitive that will only spin or > >> >> wait (not 100% sure about the terminology here). This is > >> >> especially strange for rw_try_wlock, unless you plan to sleep > >> >> manually on fail. But then again you'd have a good chance that > >> >> you have to do it over and over again if timing is unfortunate. > >> > > >> > I asked for it. We have a try operation for mtx already. I was > >> > experimenting with converting some code to use rwlocks from mtx > >> > and it required it. The specific case is in the softdep code > >> > where it uses trylock to avoid deadlocking. With trylock you can > >> > violate the lockorder. > >> > >> Makes sense, thanks! A little follow-up, though about something I'm > >> wondering about for quite some time now. Take the following > >> scenario: > >> > >> Thread A: rw_rlock(RW) ... mtx_lock(MTX) ... UNLOCK > >> Thread B: mtx_lock(MTX) ... rw_rlock(RW) ... UNLOCK > >> Thread C: rw_wlock(RW) ... UNLOCK > > > > This can't deadlock simply because rw_rlock() is not mutually > > exclusive. > > It can deadlock if there is a writer waiting in queue depending on > whether we prefer readers or writers. I think we should consider the > reader/writer perference an implementation detail to prevent code like > this from cropping up. Sorry, I still don't understand this. Even if there is a writer (thread C) waiting and we prefer writers, the reader (A or B) has to wait, but eventually the writer will give up the lock (as it can make progress independently of whether the mutex is held or not) and the readers can progress. What am I missing? I don't think this is a good thing either, but I also think that there are some cases where there just are different access orders. I'd rather want a clean way out of this than a lot of difficult per-instance hacks. This does not mean that these can't be fixed cleanly, but I think it's really hard sometimes especially for code we import from elsewhere (hence the personal interest). > Readers are only allowed to proceed with a read lock if they already > own a read lock, not just if the lock is already read locked. This > changed in current recently. So a single recursive read acqusition > can't deadlock but get multiple threads and a writer involved with > writer preference and you can. -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News From delphij at delphij.net Tue Apr 1 19:28:45 2008 From: delphij at delphij.net (Xin LI) Date: Tue Apr 1 19:28:49 2008 Subject: cvs commit: src/contrib/netcat nc.1 netcat.c In-Reply-To: <200804011354.m31DsO18067704@repoman.freebsd.org> References: <200804011354.m31DsO18067704@repoman.freebsd.org> Message-ID: <47F2EF52.4090104@delphij.net> Bruce M Simpson wrote: > bms 2008-04-01 13:54:24 UTC > > FreeBSD src repository > > Modified files: > contrib/netcat nc.1 netcat.c > Log: > Add an -O option to disable TCP options, for protocol testing purposes. > Do this for active and passive (-l switch) TCP sessions. > > MFC after: 1 week Could you please consider submitting this to OpenBSD as well? Cheers, -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! From davidxu at FreeBSD.org Tue Apr 1 21:08:38 2008 From: davidxu at FreeBSD.org (David Xu) Date: Tue Apr 1 21:08:39 2008 Subject: cvs commit: src/sys/sys umtx.h src/sys/kern kern_umtx.c Message-ID: <200804020408.m3248bnW044860@repoman.freebsd.org> davidxu 2008-04-02 04:08:37 UTC FreeBSD src repository Modified files: sys/sys umtx.h sys/kern kern_umtx.c Log: Introduce kernel based userland rwlock. Each umtx chain now has two lists, one for readers and one for writers, other types of synchronization object just use first list. Asked by: jeff Revision Changes Path 1.65 +487 -45 src/sys/kern/kern_umtx.c 1.31 +21 -1 src/sys/sys/umtx.h From davidxu at FreeBSD.org Tue Apr 1 21:27:00 2008 From: davidxu at FreeBSD.org (David Xu) Date: Tue Apr 1 21:27:03 2008 Subject: cvs commit: src/sys/kern kern_umtx.c Message-ID: <200804020426.m324Qxav045424@repoman.freebsd.org> davidxu 2008-04-02 04:26:59 UTC FreeBSD src repository Modified files: sys/kern kern_umtx.c Log: Er, don't restart a timeout version. Revision Changes Path 1.66 +4 -2 src/sys/kern/kern_umtx.c From davidxu at FreeBSD.org Tue Apr 1 21:32:31 2008 From: davidxu at FreeBSD.org (David Xu) Date: Tue Apr 1 21:32:34 2008 Subject: cvs commit: src/lib/libthr/thread thr_private.h thr_rwlock.c thr_umtx.c thr_umtx.h Message-ID: <200804020432.m324WVwe045630@repoman.freebsd.org> davidxu 2008-04-02 04:32:31 UTC FreeBSD src repository Modified files: lib/libthr/thread thr_private.h thr_rwlock.c thr_umtx.c thr_umtx.h Log: Replace userland rwlock with a pure kernel based rwlock, the new implementation does not switch pointers when it resumes waiters. Asked by: jeff Revision Changes Path 1.87 +1 -6 src/lib/libthr/thread/thr_private.h 1.14 +93 -217 src/lib/libthr/thread/thr_rwlock.c 1.14 +24 -0 src/lib/libthr/thread/thr_umtx.c 1.12 +81 -0 src/lib/libthr/thread/thr_umtx.h From alc at FreeBSD.org Tue Apr 1 21:39:48 2008 From: alc at FreeBSD.org (Alan Cox) Date: Tue Apr 1 21:39:50 2008 Subject: cvs commit: src/sys/amd64/amd64 pmap.c Message-ID: <200804020439.m324dlU9045880@repoman.freebsd.org> alc 2008-04-02 04:39:47 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c Log: Optimize pmap_pml4e() and pmap_pdpe() based upon two observations: The given pmap is never NULL, and therefore pmap_pml4e() can never return NULL. The pervasive use of these inline functions throughout the pmap makes these simple changes worthwhile. Revision Changes Path 1.611 +1 -3 src/sys/amd64/amd64/pmap.c From davidxu at FreeBSD.org Tue Apr 1 22:54:42 2008 From: davidxu at FreeBSD.org (David Xu) Date: Tue Apr 1 22:54:44 2008 Subject: cvs commit: src/sys/kern kern_umtx.c Message-ID: <200804020554.m325sfx4059349@repoman.freebsd.org> davidxu 2008-04-02 05:54:41 UTC FreeBSD src repository Modified files: sys/kern kern_umtx.c Log: Fix compiling problem for amd64. Revision Changes Path 1.67 +2 -2 src/sys/kern/kern_umtx.c From jroberson at chesapeake.net Wed Apr 2 00:04:50 2008 From: jroberson at chesapeake.net (Jeff Roberson) Date: Wed Apr 2 00:04:54 2008 Subject: cvs commit: src/sys/sys umtx.h src/sys/kern kern_umtx.c In-Reply-To: <200804020408.m3248bnW044860@repoman.freebsd.org> References: <200804020408.m3248bnW044860@repoman.freebsd.org> Message-ID: <20080401210132.V72156@desktop> On Wed, 2 Apr 2008, David Xu wrote: > davidxu 2008-04-02 04:08:37 UTC > > FreeBSD src repository > > Modified files: > sys/sys umtx.h > sys/kern kern_umtx.c > Log: > Introduce kernel based userland rwlock. Each umtx chain now has two lists, > one for readers and one for writers, other types of synchronization > object just use first list. Hey great David! This made an even bigger difference than I originally measured. Once we get a little more concurrency in the io layer with myisam it'll really shine. Thanks, Jeff > > Asked by: jeff > > Revision Changes Path > 1.65 +487 -45 src/sys/kern/kern_umtx.c > 1.31 +21 -1 src/sys/sys/umtx.h > From jroberson at chesapeake.net Wed Apr 2 00:14:13 2008 From: jroberson at chesapeake.net (Jeff Roberson) Date: Wed Apr 2 00:14:21 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c src/sys/sys rwlock.h In-Reply-To: <200804020412.30624.max@love2party.net> References: <200804012031.m31KVtKs000176@repoman.freebsd.org> <3bbf2fe10804011723w69e38ed7sc5760ea269600654@mail.gmail.com> <20080401150918.F72156@desktop> <200804020412.30624.max@love2party.net> Message-ID: <20080401210738.E72156@desktop> On Wed, 2 Apr 2008, Max Laier wrote: > On Wednesday 02 April 2008 03:11:11 Jeff Roberson wrote: >> On Wed, 2 Apr 2008, Attilio Rao wrote: >>> 2008/4/2, Max Laier : >>>> On Wednesday 02 April 2008 00:52:45 Jeff Roberson wrote: >>>>> On Wed, 2 Apr 2008, Max Laier wrote: >>>>>> On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote: >>>>>>> attilio 2008-04-01 20:31:55 UTC >>>>>>> >>>>>>> FreeBSD src repository >>>>>>> >>>>>>> Modified files: >>>>>>> sys/kern kern_rwlock.c >>>>>>> sys/sys rwlock.h >>>>>>> Log: >>>>>>> Add rw_try_rlock() and rw_try_wlock() to rwlocks. >>>>>>> These functions try the specified operation (rlocking and >>>>>>> wlocking) and true is returned if the operation completes, false >>>>>>> otherwise. >>>>>> >>>>>> hmmm ... I'm certainly missing something here, but what's a >>>>>> possible usecase for these? It seems there is not much you can >>>>>> do if you can't obtain a rw_lock. I can understand the need for >>>>>> sx_try_* where you want to avoid sleeping, but I can't figure out >>>>>> the need for it on a locking primitive that will only spin or >>>>>> wait (not 100% sure about the terminology here). This is >>>>>> especially strange for rw_try_wlock, unless you plan to sleep >>>>>> manually on fail. But then again you'd have a good chance that >>>>>> you have to do it over and over again if timing is unfortunate. >>>>> >>>>> I asked for it. We have a try operation for mtx already. I was >>>>> experimenting with converting some code to use rwlocks from mtx >>>>> and it required it. The specific case is in the softdep code >>>>> where it uses trylock to avoid deadlocking. With trylock you can >>>>> violate the lockorder. >>>> >>>> Makes sense, thanks! A little follow-up, though about something I'm >>>> wondering about for quite some time now. Take the following >>>> scenario: >>>> >>>> Thread A: rw_rlock(RW) ... mtx_lock(MTX) ... UNLOCK >>>> Thread B: mtx_lock(MTX) ... rw_rlock(RW) ... UNLOCK >>>> Thread C: rw_wlock(RW) ... UNLOCK >>> >>> This can't deadlock simply because rw_rlock() is not mutually >>> exclusive. >> >> It can deadlock if there is a writer waiting in queue depending on >> whether we prefer readers or writers. I think we should consider the >> reader/writer perference an implementation detail to prevent code like >> this from cropping up. > > Sorry, I still don't understand this. Even if there is a writer (thread > C) waiting and we prefer writers, the reader (A or B) has to wait, but > eventually the writer will give up the lock (as it can make progress > independently of whether the mutex is held or not) and the readers can > progress. What am I missing? Thread A: rw_rlock(RW) ... mtx_lock(MTX) ... UNLOCK Thread B: mtx_lock(MTX) ... rw_rlock(RW) ... UNLOCK Thread C: rw_wlock(RW) ... UNLOCK Thread A: Thread B: Thread C: rw_rlock(rw) mtx_lock(mtx) rw_wlock(rw) <- Blocked waiting for a rw_rlock(rw) <- Blocked waiting for c due to write fairness mtx_lock(mtx) <- Blocked waiting for B Does that help? > > I don't think this is a good thing either, but I also think that there are > some cases where there just are different access orders. I'd rather want > a clean way out of this than a lot of difficult per-instance hacks. This > does not mean that these can't be fixed cleanly, but I think it's really > hard sometimes especially for code we import from elsewhere (hence the > personal interest). I think the best solution is to treat rlocks as wlocks in terms of access orders. > >> Readers are only allowed to proceed with a read lock if they already >> own a read lock, not just if the lock is already read locked. This >> changed in current recently. So a single recursive read acqusition >> can't deadlock but get multiple threads and a writer involved with >> writer preference and you can. Thanks, Jeff > > -- > /"\ Best regards, | mlaier@freebsd.org > \ / Max Laier | ICQ #67774661 > X http://pf4freebsd.love2party.net/ | mlaier@EFnet > / \ ASCII Ribbon Campaign | Against HTML Mail and News > From davidxu at FreeBSD.org Wed Apr 2 00:41:25 2008 From: davidxu at FreeBSD.org (David Xu) Date: Wed Apr 2 00:41:28 2008 Subject: cvs commit: src/lib/libthr/arch/amd64 Makefile.inc src/lib/libthr/arch/amd64/include pthread_md.h src/lib/libthr/arch/i386 Makefile.inc src/lib/libthr/arch/i386/include pthread_md.h src/lib/libthr/thread thr_private.h thr_rtld.c thr_umtx.c ... Message-ID: <200804020741.m327fP1W065205@repoman.freebsd.org> davidxu 2008-04-02 07:41:25 UTC FreeBSD src repository Modified files: lib/libthr/arch/amd64 Makefile.inc lib/libthr/arch/amd64/include pthread_md.h lib/libthr/arch/i386 Makefile.inc lib/libthr/arch/i386/include pthread_md.h lib/libthr/thread thr_private.h thr_rtld.c thr_umtx.c Added files: lib/libthr/arch/amd64/amd64 _umtx_op_err.S lib/libthr/arch/i386/i386 _umtx_op_err.S Log: Replace function _umtx_op with _umtx_op_err, the later function directly returns errno, because errno can be mucked by user's signal handler and most of pthread api heavily depends on errno to be correct, this change should improve stability of the thread library. Revision Changes Path 1.4 +1 -1 src/lib/libthr/arch/amd64/Makefile.inc 1.1 +37 -0 src/lib/libthr/arch/amd64/amd64/_umtx_op_err.S (new) 1.5 +3 -0 src/lib/libthr/arch/amd64/include/pthread_md.h 1.4 +1 -1 src/lib/libthr/arch/i386/Makefile.inc 1.1 +36 -0 src/lib/libthr/arch/i386/i386/_umtx_op_err.S (new) 1.9 +3 -0 src/lib/libthr/arch/i386/include/pthread_md.h 1.88 +2 -0 src/lib/libthr/thread/thr_private.h 1.7 +1 -1 src/lib/libthr/thread/thr_rtld.c 1.15 +28 -48 src/lib/libthr/thread/thr_umtx.c From rwatson at FreeBSD.org Wed Apr 2 01:06:35 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Wed Apr 2 01:06:40 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c src/sys/sys rwlock.h In-Reply-To: <20080401210738.E72156@desktop> References: <200804012031.m31KVtKs000176@repoman.freebsd.org> <3bbf2fe10804011723w69e38ed7sc5760ea269600654@mail.gmail.com> <20080401150918.F72156@desktop> <200804020412.30624.max@love2party.net> <20080401210738.E72156@desktop> Message-ID: <20080402090327.D14932@fledge.watson.org> On Tue, 1 Apr 2008, Jeff Roberson wrote: >> I don't think this is a good thing either, but I also think that there are >> some cases where there just are different access orders. I'd rather want a >> clean way out of this than a lot of difficult per-instance hacks. This >> does not mean that these can't be fixed cleanly, but I think it's really >> hard sometimes especially for code we import from elsewhere (hence the >> personal interest). > > I think the best solution is to treat rlocks as wlocks in terms of access > orders. The 'problem' is that there are certain usage cases for rwlocks where 99% of paths use only recursive read locks, with rather incestuous lock orders with respect to other locks, and 1% of paths use write locks and are very conservative about the calling path. I'm sure the example that Max has in mind is pfil, where you may get pfil invocation as you enter the stack or as you exit it, but whose lock should not ever lead to deadlock as it's only acquired readable in those paths. The key missing bit of the picture is that the write path must be constructed very, very carefully so that it is never called holding any locks that interact with the read locks. What would be very nice is if witness fired if the write path got it wrong in those cases, since using rwlocks effectively as a reference count to prevent subsystem reconfiguration while in use is a structure likely to be used elsewhere. Robert N M Watson Computer Laboratory University of Cambridge From davidxu at FreeBSD.org Wed Apr 2 01:33:43 2008 From: davidxu at FreeBSD.org (David Xu) Date: Wed Apr 2 01:33:45 2008 Subject: cvs commit: src/lib/libthr/thread thr_cond.c thr_private.h Message-ID: <200804020833.m328XgED070353@repoman.freebsd.org> davidxu 2008-04-02 08:33:42 UTC FreeBSD src repository Modified files: lib/libthr/thread thr_cond.c thr_private.h Log: Remove unused functions. Revision Changes Path 1.25 +0 -53 src/lib/libthr/thread/thr_cond.c 1.89 +0 -2 src/lib/libthr/thread/thr_private.h From davidxu at FreeBSD.org Wed Apr 2 01:53:19 2008 From: davidxu at FreeBSD.org (David Xu) Date: Wed Apr 2 01:53:21 2008 Subject: cvs commit: src/lib/libc/include namespace.h un-namespace.h src/lib/libthr/thread thr_private.h Message-ID: <200804020853.m328rIeB080067@repoman.freebsd.org> davidxu 2008-04-02 08:53:18 UTC FreeBSD src repository Modified files: lib/libc/include namespace.h un-namespace.h lib/libthr/thread thr_private.h Log: Add pthread_setaffinity_np and pthread_getaffinity_np to libc namespace. Revision Changes Path 1.23 +2 -0 src/lib/libc/include/namespace.h 1.20 +2 -0 src/lib/libc/include/un-namespace.h 1.90 +0 -2 src/lib/libthr/thread/thr_private.h From jroberson at chesapeake.net Wed Apr 2 02:29:40 2008 From: jroberson at chesapeake.net (Jeff Roberson) Date: Wed Apr 2 02:29:44 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c src/sys/sys rwlock.h In-Reply-To: <20080401210738.E72156@desktop> References: <200804012031.m31KVtKs000176@repoman.freebsd.org> <3bbf2fe10804011723w69e38ed7sc5760ea269600654@mail.gmail.com> <20080401150918.F72156@desktop> <200804020412.30624.max@love2party.net> <20080401210738.E72156@desktop> Message-ID: <20080401232749.C72156@desktop> On Tue, 1 Apr 2008, Jeff Roberson wrote: > On Wed, 2 Apr 2008, Max Laier wrote: > >> On Wednesday 02 April 2008 03:11:11 Jeff Roberson wrote: >>> On Wed, 2 Apr 2008, Attilio Rao wrote: >>>> 2008/4/2, Max Laier : >>>>> On Wednesday 02 April 2008 00:52:45 Jeff Roberson wrote: >>>>>> On Wed, 2 Apr 2008, Max Laier wrote: >>>>>>> On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote: >>>>>>>> attilio 2008-04-01 20:31:55 UTC >>>>>>>> >>>>>>>> FreeBSD src repository >>>>>>>> >>>>>>>> Modified files: >>>>>>>> sys/kern kern_rwlock.c >>>>>>>> sys/sys rwlock.h >>>>>>>> Log: >>>>>>>> Add rw_try_rlock() and rw_try_wlock() to rwlocks. >>>>>>>> These functions try the specified operation (rlocking and >>>>>>>> wlocking) and true is returned if the operation completes, false >>>>>>>> otherwise. >>>>>>> >>>>>>> hmmm ... I'm certainly missing something here, but what's a >>>>>>> possible usecase for these? It seems there is not much you can >>>>>>> do if you can't obtain a rw_lock. I can understand the need for >>>>>>> sx_try_* where you want to avoid sleeping, but I can't figure out >>>>>>> the need for it on a locking primitive that will only spin or >>>>>>> wait (not 100% sure about the terminology here). This is >>>>>>> especially strange for rw_try_wlock, unless you plan to sleep >>>>>>> manually on fail. But then again you'd have a good chance that >>>>>>> you have to do it over and over again if timing is unfortunate. >>>>>> >>>>>> I asked for it. We have a try operation for mtx already. I was >>>>>> experimenting with converting some code to use rwlocks from mtx >>>>>> and it required it. The specific case is in the softdep code >>>>>> where it uses trylock to avoid deadlocking. With trylock you can >>>>>> violate the lockorder. >>>>> >>>>> Makes sense, thanks! A little follow-up, though about something I'm >>>>> wondering about for quite some time now. Take the following >>>>> scenario: >>>>> >>>>> Thread A: rw_rlock(RW) ... mtx_lock(MTX) ... UNLOCK >>>>> Thread B: mtx_lock(MTX) ... rw_rlock(RW) ... UNLOCK >>>>> Thread C: rw_wlock(RW) ... UNLOCK >>>> >>>> This can't deadlock simply because rw_rlock() is not mutually >>>> exclusive. >>> >>> It can deadlock if there is a writer waiting in queue depending on >>> whether we prefer readers or writers. I think we should consider the >>> reader/writer perference an implementation detail to prevent code like >>> this from cropping up. >> >> Sorry, I still don't understand this. Even if there is a writer (thread >> C) waiting and we prefer writers, the reader (A or B) has to wait, but >> eventually the writer will give up the lock (as it can make progress >> independently of whether the mutex is held or not) and the readers can >> progress. What am I missing? > > Thread A: rw_rlock(RW) ... mtx_lock(MTX) ... UNLOCK > Thread B: mtx_lock(MTX) ... rw_rlock(RW) ... UNLOCK > Thread C: rw_wlock(RW) ... UNLOCK > I should mention one more variation on this. If the following preceeded the diagram below there would be no deadlock: rw_rlock(rw); ^^^^^^^^^^^^^ > Thread A: Thread B: Thread C: > rw_rlock(rw) > mtx_lock(mtx) > rw_wlock(rw) <- Blocked waiting for a > rw_rlock(rw) <- Blocked waiting for c due to write fairness > mtx_lock(mtx) <- Blocked waiting for B The recursive acquisition is not blocked by a write waiter because that could certainly lead to deadlock. Note that this reverts us to a strict order which can be verified by witness regardless of the reader/write type of the lock. Jeff > > Does that help? > >> >> I don't think this is a good thing either, but I also think that there are >> some cases where there just are different access orders. I'd rather want >> a clean way out of this than a lot of difficult per-instance hacks. This >> does not mean that these can't be fixed cleanly, but I think it's really >> hard sometimes especially for code we import from elsewhere (hence the >> personal interest). > > I think the best solution is to treat rlocks as wlocks in terms of access > orders. > >> >>> Readers are only allowed to proceed with a read lock if they already >>> own a read lock, not just if the lock is already read locked. This >>> changed in current recently. So a single recursive read acqusition >>> can't deadlock but get multiple threads and a writer involved with >>> writer preference and you can. > > Thanks, > Jeff > >> >> -- >> /"\ Best regards, | mlaier@freebsd.org >> \ / Max Laier | ICQ #67774661 >> X http://pf4freebsd.love2party.net/ | mlaier@EFnet >> / \ ASCII Ribbon Campaign | Against HTML Mail and News >> > From ru at FreeBSD.org Wed Apr 2 02:41:30 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Wed Apr 2 02:41:34 2008 Subject: cvs commit: src/usr.bin/ktrace ktrace.1 ktrace.c src/usr.bin/kdump kdump.1 kdump.c Message-ID: <200804020941.m329fUvO083420@repoman.freebsd.org> ru 2008-04-02 09:41:30 UTC FreeBSD src repository Modified files: usr.bin/ktrace ktrace.1 ktrace.c usr.bin/kdump kdump.1 kdump.c Log: Spell -t option's argument by name. Revision Changes Path 1.17 +2 -2 src/usr.bin/kdump/kdump.1 1.42 +1 -1 src/usr.bin/kdump/kdump.c 1.20 +3 -3 src/usr.bin/ktrace/ktrace.1 1.24 +2 -2 src/usr.bin/ktrace/ktrace.c From attilio at freebsd.org Wed Apr 2 03:05:36 2008 From: attilio at freebsd.org (Attilio Rao) Date: Wed Apr 2 03:05:40 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c src/sys/sys rwlock.h In-Reply-To: <20080401150918.F72156@desktop> References: <200804012031.m31KVtKs000176@repoman.freebsd.org> <200804020025.57684.max@love2party.net> <20080401123951.J72156@desktop> <200804020200.58006.max@love2party.net> <3bbf2fe10804011723w69e38ed7sc5760ea269600654@mail.gmail.com> <20080401150918.F72156@desktop> Message-ID: <3bbf2fe10804020305r624ab142j18f00b84f2ae240f@mail.gmail.com> 2008/4/2, Jeff Roberson : > > On Wed, 2 Apr 2008, Attilio Rao wrote: > > > > 2008/4/2, Max Laier : > > > > > On Wednesday 02 April 2008 00:52:45 Jeff Roberson wrote: > > > > On Wed, 2 Apr 2008, Max Laier wrote: > > > >> On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote: > > > >>> attilio 2008-04-01 20:31:55 UTC > > > >>> > > > >>> FreeBSD src repository > > > >>> > > > >>> Modified files: > > > >>> sys/kern kern_rwlock.c > > > >>> sys/sys rwlock.h > > > >>> Log: > > > >>> Add rw_try_rlock() and rw_try_wlock() to rwlocks. > > > >>> These functions try the specified operation (rlocking and > > > >>> wlocking) and true is returned if the operation completes, false > > > >>> otherwise. > > > >> > > > >> hmmm ... I'm certainly missing something here, but what's a possible > > > >> usecase for these? It seems there is not much you can do if you > > > >> can't obtain a rw_lock. I can understand the need for sx_try_* where > > > >> you want to avoid sleeping, but I can't figure out the need for it on > > > >> a locking primitive that will only spin or wait (not 100% sure about > > > >> the terminology here). This is especially strange for rw_try_wlock, > > > >> unless you plan to sleep manually on fail. But then again you'd have > > > >> a good chance that you have to do it over and over again if timing is > > > >> unfortunate. > > > > > > > > I asked for it. We have a try operation for mtx already. I was > > > > experimenting with converting some code to use rwlocks from mtx and it > > > > required it. The specific case is in the softdep code where it uses > > > > trylock to avoid deadlocking. With trylock you can violate the > > > > lockorder. > > > > > > > > > Makes sense, thanks! A little follow-up, though about something I'm > > > wondering about for quite some time now. Take the following scenario: > > > > > > Thread A: rw_rlock(RW) ... mtx_lock(MTX) ... UNLOCK > > > Thread B: mtx_lock(MTX) ... rw_rlock(RW) ... UNLOCK > > > Thread C: rw_wlock(RW) ... UNLOCK > > > > > > > This can't deadlock simply because rw_rlock() is not mutually exclusive. > > > > It can deadlock if there is a writer waiting in queue depending on whether > we prefer readers or writers. I think we should consider the reader/writer > perference an implementation detail to prevent code like this from cropping > up. Ah, right, the writer starvation avoidance will lead to a deadlock here. Thanks, I didn't consider it, so it is still valid / better to treact read locks as all the other locks for WITNESS. Attilio -- Peace can only be achieved by understanding - A. Einstein From jeff at FreeBSD.org Wed Apr 2 03:40:04 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Wed Apr 2 03:40:06 2008 Subject: cvs commit: src/sys/kern vfs_subr.c Message-ID: <200804021040.m32Ae4Lh087614@repoman.freebsd.org> jeff 2008-04-02 10:40:03 UTC FreeBSD src repository Modified files: sys/kern vfs_subr.c Log: - Destroy the bo mtx when the vnode is destroyed. Revision Changes Path 1.727 +1 -0 src/sys/kern/vfs_subr.c From kib at FreeBSD.org Wed Apr 2 04:11:59 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Wed Apr 2 04:12:02 2008 Subject: cvs commit: src/sys/kern kern_conf.c Message-ID: <200804021111.m32BBwdL089685@repoman.freebsd.org> kib 2008-04-02 11:11:58 UTC FreeBSD src repository Modified files: sys/kern kern_conf.c Log: Add two missed chunks from the rev. 1.210, for the giant_read() and giant_ioctl(). PR: kern/122287 MFC after: 3 days Revision Changes Path 1.211 +2 -4 src/sys/kern/kern_conf.c From jeff at FreeBSD.org Wed Apr 2 04:20:30 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Wed Apr 2 04:20:32 2008 Subject: cvs commit: src/sys/sys callout.h src/sys/kern kern_clock.c kern_intr.c kern_timeout.c Message-ID: <200804021120.m32BKUYX089976@repoman.freebsd.org> jeff 2008-04-02 11:20:30 UTC FreeBSD src repository Modified files: sys/sys callout.h sys/kern kern_clock.c kern_intr.c kern_timeout.c Log: Implement per-cpu callout threads, wheels, and locks. - Move callout thread creation from kern_intr.c to kern_timeout.c - Call callout_tick() on every processor via hardclock_cpu() rather than inspecting callout internal details in kern_clock.c. - Remove callout implementation details from callout.h - Package up all of the global variables into a per-cpu callout structure. - Start one thread per-cpu. Threads are not strictly bound. They prefer to execute on the native cpu but may migrate temporarily if interrupts are starving callout processing. - Run all callouts by default in the thread for cpu0 to maintain current ordering and concurrency guarantees. Many consumers may not properly handle concurrent execution. - The new callout_reset_on() api allows specifying a particular cpu to execute the callout on. This may migrate a callout to a new cpu. callout_reset() schedules on the last assigned cpu while callout_reset_curcpu() schedules on the current cpu. Reviewed by: phk Sponsored by: Nokia Revision Changes Path 1.209 +2 -23 src/sys/kern/kern_clock.c 1.158 +14 -11 src/sys/kern/kern_intr.c 1.112 +246 -124 src/sys/kern/kern_timeout.c 1.33 +9 -7 src/sys/sys/callout.h From jeff at FreeBSD.org Wed Apr 2 04:21:43 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Wed Apr 2 04:21:45 2008 Subject: cvs commit: src/sys/kern kern_event.c subr_sleepqueue.c Message-ID: <200804021121.m32BLgYP090074@repoman.freebsd.org> jeff 2008-04-02 11:21:42 UTC FreeBSD src repository Modified files: sys/kern kern_event.c subr_sleepqueue.c Log: - Convert two timeout users to the new callout_reset_curcpu() api. Sponsored by: Nokia Revision Changes Path 1.118 +3 -3 src/sys/kern/kern_event.c 1.52 +1 -1 src/sys/kern/subr_sleepqueue.c From davidxu at FreeBSD.org Wed Apr 2 04:41:13 2008 From: davidxu at FreeBSD.org (David Xu) Date: Wed Apr 2 04:41:15 2008 Subject: cvs commit: src/lib/libthr/thread thr_affinity.c Message-ID: <200804021141.m32BfCrA091002@repoman.freebsd.org> davidxu 2008-04-02 11:41:12 UTC FreeBSD src repository Modified files: lib/libthr/thread thr_affinity.c Log: Non-portable functions are in pthread_np.h, fix compiling problem. Revision Changes Path 1.3 +1 -1 src/lib/libthr/thread/thr_affinity.c From gallatin at FreeBSD.org Wed Apr 2 06:59:44 2008 From: gallatin at FreeBSD.org (Andrew Gallatin) Date: Wed Apr 2 06:59:45 2008 Subject: cvs commit: src/sys/dev/mxge if_mxge.c Message-ID: <200804021359.m32DxhH8007047@repoman.freebsd.org> gallatin 2008-04-02 13:59:43 UTC FreeBSD src repository Modified files: sys/dev/mxge if_mxge.c Log: Initialize if_baudrate using IF_Gbps() macro. Note that if_baudrate is a long, and 32-bits isn't enough to properly represent 10Gb/s. Pointed out by: dwhite Revision Changes Path 1.49 +1 -1 src/sys/dev/mxge/if_mxge.c From max at love2party.net Wed Apr 2 07:47:37 2008 From: max at love2party.net (Max Laier) Date: Wed Apr 2 07:47:41 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c src/sys/sys rwlock.h In-Reply-To: <20080401210738.E72156@desktop> References: <200804012031.m31KVtKs000176@repoman.freebsd.org> <200804020412.30624.max@love2party.net> <20080401210738.E72156@desktop> Message-ID: <200804021645.19331.max@love2party.net> On Wednesday 02 April 2008 09:15:25 Jeff Roberson wrote: > On Wed, 2 Apr 2008, Max Laier wrote: > > On Wednesday 02 April 2008 03:11:11 Jeff Roberson wrote: > >> On Wed, 2 Apr 2008, Attilio Rao wrote: > >>> 2008/4/2, Max Laier : > >>>> On Wednesday 02 April 2008 00:52:45 Jeff Roberson wrote: > >>>>> On Wed, 2 Apr 2008, Max Laier wrote: > >>>>>> On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote: > >>>>>>> attilio 2008-04-01 20:31:55 UTC > >>>>>>> > >>>>>>> FreeBSD src repository > >>>>>>> > >>>>>>> Modified files: > >>>>>>> sys/kern kern_rwlock.c > >>>>>>> sys/sys rwlock.h > >>>>>>> Log: > >>>>>>> Add rw_try_rlock() and rw_try_wlock() to rwlocks. > >>>>>>> These functions try the specified operation (rlocking and > >>>>>>> wlocking) and true is returned if the operation completes, > >>>>>>> false otherwise. > >>>>>> > >>>>>> hmmm ... I'm certainly missing something here, but what's a > >>>>>> possible usecase for these? It seems there is not much you can > >>>>>> do if you can't obtain a rw_lock. I can understand the need for > >>>>>> sx_try_* where you want to avoid sleeping, but I can't figure > >>>>>> out the need for it on a locking primitive that will only spin > >>>>>> or wait (not 100% sure about the terminology here). This is > >>>>>> especially strange for rw_try_wlock, unless you plan to sleep > >>>>>> manually on fail. But then again you'd have a good chance that > >>>>>> you have to do it over and over again if timing is unfortunate. > >>>>> > >>>>> I asked for it. We have a try operation for mtx already. I was > >>>>> experimenting with converting some code to use rwlocks from mtx > >>>>> and it required it. The specific case is in the softdep code > >>>>> where it uses trylock to avoid deadlocking. With trylock you can > >>>>> violate the lockorder. > >>>> > >>>> Makes sense, thanks! A little follow-up, though about something > >>>> I'm wondering about for quite some time now. Take the following > >>>> scenario: > >>>> > >>>> Thread A: rw_rlock(RW) ... mtx_lock(MTX) ... UNLOCK > >>>> Thread B: mtx_lock(MTX) ... rw_rlock(RW) ... UNLOCK > >>>> Thread C: rw_wlock(RW) ... UNLOCK > >>> > >>> This can't deadlock simply because rw_rlock() is not mutually > >>> exclusive. > >> > >> It can deadlock if there is a writer waiting in queue depending on > >> whether we prefer readers or writers. I think we should consider > >> the reader/writer perference an implementation detail to prevent > >> code like this from cropping up. > > > > Sorry, I still don't understand this. Even if there is a writer > > (thread C) waiting and we prefer writers, the reader (A or B) has to > > wait, but eventually the writer will give up the lock (as it can make > > progress independently of whether the mutex is held or not) and the > > readers can progress. What am I missing? > > Thread A: rw_rlock(RW) ... mtx_lock(MTX) ... UNLOCK > Thread B: mtx_lock(MTX) ... rw_rlock(RW) ... UNLOCK > Thread C: rw_wlock(RW) ... UNLOCK > > Thread A: Thread B: Thread C: > rw_rlock(rw) > mtx_lock(mtx) > rw_wlock(rw) <- Blocked waiting for a > rw_rlock(rw) <- Blocked waiting for c due to write > fairness mtx_lock(mtx) <- Blocked waiting for B > > Does that help? Yes it does, thanks. Do you know what the situation for rm_locks is? If I understand correctly they implement full priority propagation. In this scenario C would boost A via the RM and A would boost B via MTX so B could run and avoid the deadlock. Or am I missing something again? In any case doing "while (!rw_try_wlock(rw));" instead of a plain "rw_wlock(rw);" would now be a possible workaround - if we don't care about starvation of thread C, right? > > I don't think this is a good thing either, but I also think that > > there are some cases where there just are different access orders. > > I'd rather want a clean way out of this than a lot of difficult > > per-instance hacks. This does not mean that these can't be fixed > > cleanly, but I think it's really hard sometimes especially for code > > we import from elsewhere (hence the personal interest). > > I think the best solution is to treat rlocks as wlocks in terms of > access orders. > > >> Readers are only allowed to proceed with a read lock if they already > >> own a read lock, not just if the lock is already read locked. This > >> changed in current recently. So a single recursive read acqusition > >> can't deadlock but get multiple threads and a writer involved with > >> writer preference and you can. > > Thanks, > Jeff > > > -- > > /"\ Best regards, | mlaier@freebsd.org > > \ / Max Laier | ICQ #67774661 > > X http://pf4freebsd.love2party.net/ | mlaier@EFnet > > / \ ASCII Ribbon Campaign | Against HTML Mail and News -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News From das at FreeBSD.ORG Wed Apr 2 07:53:20 2008 From: das at FreeBSD.ORG (David Schultz) Date: Wed Apr 2 07:53:30 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c src/sys/sys rwlock.h In-Reply-To: <20080401123951.J72156@desktop> References: <200804012031.m31KVtKs000176@repoman.freebsd.org> <200804020025.57684.max@love2party.net> <20080401123951.J72156@desktop> Message-ID: <20080402145520.GA21462@zim.MIT.EDU> On Tue, Apr 01, 2008, Jeff Roberson wrote: > On Wed, 2 Apr 2008, Max Laier wrote: > > >On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote: > >>attilio 2008-04-01 20:31:55 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/kern kern_rwlock.c > >> sys/sys rwlock.h > >> Log: > >> Add rw_try_rlock() and rw_try_wlock() to rwlocks. > >> These functions try the specified operation (rlocking and wlocking) > >>and true is returned if the operation completes, false otherwise. > > > >hmmm ... I'm certainly missing something here, but what's a possible > >usecase for these? It seems there is not much you can do if you can't > >obtain a rw_lock. I can understand the need for sx_try_* where you want > >to avoid sleeping, but I can't figure out the need for it on a locking > >primitive that will only spin or wait (not 100% sure about the > >terminology here). This is especially strange for rw_try_wlock, unless > >you plan to sleep manually on fail. But then again you'd have a good > >chance that you have to do it over and over again if timing is > >unfortunate. > > I asked for it. We have a try operation for mtx already. I was > experimenting with converting some code to use rwlocks from mtx and it > required it. The specific case is in the softdep code where it uses > trylock to avoid deadlocking. With trylock you can violate the lockorder. One reason that many systems don't provide a rw_try_wlock() primitive is that a constant stream of readers can easily starve threads attempting to acquire the write lock without waiting. There are probably situations where this isn't a problem, though, e.g., if readers rarely hold the lock for a long time... From wb at freebie.xs4all.nl Wed Apr 2 07:56:16 2008 From: wb at freebie.xs4all.nl (Wilko Bulte) Date: Wed Apr 2 07:56:24 2008 Subject: cvs commit: src/games/fortune/datfiles fortunes In-Reply-To: <47F1BEB4.1060104@FreeBSD.org> References: <200803311028.m2VASAxD097068@repoman.freebsd.org> <47F13951.2080907@FreeBSD.org> <87hcema76s.fsf@kobe.laptop> <47F1BEB4.1060104@FreeBSD.org> Message-ID: <20080402145611.GB82144@freebie.xs4all.nl> Quoting Doug Barton, who wrote on Mon, Mar 31, 2008 at 09:48:52PM -0700 .. > Jordan K. Hubbard wrote: > > > >On Mar 31, 2008, at 2:56 PM, Giorgos Keramidas wrote: > > > >>This is the age old "these fortune cookies may be offensive to some > >>people" bikeshed. Do we really want to go there again? > >> > >>If removing the ones deleted by Ganbold is considered such a big loss to > >>the consumers of the fortune cookies, then sure, we'll have to backout > >>the removal. I'd prefer if we didn't, but oh well :/ > > > > > >from fortune(6): > > > >"I think the world would be a more peaceful place if people > >could just keep their fingers out of the fortune files. > > > > -- Jordan K. Hubbard" > > > >:-) > > My point exactly. We have always erred on the side of NOT removing > something since what people find offensive (or humorous) varies hugely > across cultures, languages, political persuasions, etc. > > If you want to make an argument that those fortunes should be moved to > the -o file, that might be worth talking about. But flat out removing > them is not keeping in the spirit of how things have traditionally > been done. If all the soft-skinned creatures who cannot handle fortunes just rm -rf fortune? Then we could just go on with life. Political correctness has never served any useful purpose in this world. Wilko -- Wilko Bulte wilko@FreeBSD.org From imp at FreeBSD.org Wed Apr 2 09:17:20 2008 From: imp at FreeBSD.org (Warner Losh) Date: Wed Apr 2 09:17:22 2008 Subject: cvs commit: src/sys/conf NOTES Message-ID: <200804021617.m32GHJxr030361@repoman.freebsd.org> imp 2008-04-02 16:17:19 UTC FreeBSD src repository Modified files: sys/conf NOTES Log: Add zyd, ural, and rum. They were missing. Revision Changes Path 1.1479 +10 -0 src/sys/conf/NOTES From xcllnt at mac.com Wed Apr 2 09:40:05 2008 From: xcllnt at mac.com (Marcel Moolenaar) Date: Wed Apr 2 09:40:13 2008 Subject: cvs commit: src/lib/libthr/arch/amd64 Makefile.inc src/lib/libthr/arch/amd64/include pthread_md.h src/lib/libthr/arch/i386 Makefile.inc src/lib/libthr/arch/i386/include pthread_md.h src/lib/libthr/thread thr_private.h thr_rtld.c thr_umtx.c ... In-Reply-To: <200804020741.m327fP1W065205@repoman.freebsd.org> References: <200804020741.m327fP1W065205@repoman.freebsd.org> Message-ID: <77FDA3DB-B81A-42D1-871E-AB04CD86C150@mac.com> On Apr 2, 2008, at 12:41 AM, David Xu wrote: > davidxu 2008-04-02 07:41:25 UTC > > FreeBSD src repository > > Modified files: > lib/libthr/arch/amd64 Makefile.inc > lib/libthr/arch/amd64/include pthread_md.h > lib/libthr/arch/i386 Makefile.inc > lib/libthr/arch/i386/include pthread_md.h > lib/libthr/thread thr_private.h thr_rtld.c thr_umtx.c > Added files: > lib/libthr/arch/amd64/amd64 _umtx_op_err.S > lib/libthr/arch/i386/i386 _umtx_op_err.S > Log: > Replace function _umtx_op with _umtx_op_err, the later function > directly > returns errno, because errno can be mucked by user's signal handler > and > most of pthread api heavily depends on errno to be correct, this > change > should improve stability of the thread library. Doesn't this also apply to !i386 & !amd64? -- Marcel Moolenaar xcllnt@mac.com From brueffer at FreeBSD.org Wed Apr 2 09:52:28 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Wed Apr 2 09:52:35 2008 Subject: cvs commit: src/share/man/man4 arcmsr.4 Message-ID: <200804021652.m32GqSoj040958@repoman.freebsd.org> brueffer 2008-04-02 16:52:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man4 arcmsr.4 Log: MFC: rev. 1.6 ARC-1680 is supported. Revision Changes Path 1.5.2.1 +3 -1 src/share/man/man4/arcmsr.4 From brueffer at FreeBSD.org Wed Apr 2 09:53:05 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Wed Apr 2 09:53:07 2008 Subject: cvs commit: src/share/man/man4 arcmsr.4 Message-ID: <200804021653.m32Gr4Bb041018@repoman.freebsd.org> brueffer 2008-04-02 16:53:04 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man4 arcmsr.4 Log: MFC: rev. 1.6 ARC-1680 is supported. Revision Changes Path 1.3.4.3 +3 -1 src/share/man/man4/arcmsr.4 From obrien at FreeBSD.org Wed Apr 2 10:24:23 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Wed Apr 2 10:24:30 2008 Subject: cvs commit: src/share/mk sys.mk Message-ID: <200804021724.m32HOMFe044398@repoman.freebsd.org> obrien 2008-04-02 17:24:22 UTC FreeBSD src repository Modified files: share/mk sys.mk Log: PR ports/121363 (& ports/73797) has been committed, so we can now go back to JB's revision 1.96 change to remove -fno-strict-aliasing from CFLAGS. This makes the default CFLAGS to match the simple defaults that the tinderboxes use. By using -fno-strict-aliasing by default we are choosing to ignore problems in code which had the potential to shoot ourselves in the foot. Revision Changes Path 1.100 +2 -2 src/share/mk/sys.mk From jhb at freebsd.org Wed Apr 2 11:17:47 2008 From: jhb at freebsd.org (John Baldwin) Date: Wed Apr 2 11:17:55 2008 Subject: cvs commit: src/sys/sys callout.h src/sys/kern kern_clock.c kern_intr.c kern_timeout.c In-Reply-To: <200804021120.m32BKUYX089976@repoman.freebsd.org> References: <200804021120.m32BKUYX089976@repoman.freebsd.org> Message-ID: <200804021417.20141.jhb@freebsd.org> On Wednesday 02 April 2008 07:20:30 am Jeff Roberson wrote: > jeff 2008-04-02 11:20:30 UTC > > FreeBSD src repository > > Modified files: > sys/sys callout.h > sys/kern kern_clock.c kern_intr.c kern_timeout.c > Log: > Implement per-cpu callout threads, wheels, and locks. > > - Move callout thread creation from kern_intr.c to kern_timeout.c > - Call callout_tick() on every processor via hardclock_cpu() rather than > inspecting callout internal details in kern_clock.c. > - Remove callout implementation details from callout.h > - Package up all of the global variables into a per-cpu callout > structure. - Start one thread per-cpu. Threads are not strictly bound. > They prefer to execute on the native cpu but may migrate temporarily if > interrupts are starving callout processing. > - Run all callouts by default in the thread for cpu0 to maintain current > ordering and concurrency guarantees. Many consumers may not properly > handle concurrent execution. > - The new callout_reset_on() api allows specifying a particular cpu to > execute the callout on. This may migrate a callout to a new cpu. > callout_reset() schedules on the last assigned cpu while > callout_reset_curcpu() schedules on the current cpu. > > Reviewed by: phk > Sponsored by: Nokia This still has the bug in kern_intr.c:swi_add() as per previous e-mail. Surprised gcc didn't warn about it. -- John Baldwin From dougb at FreeBSD.org Wed Apr 2 12:29:17 2008 From: dougb at FreeBSD.org (Doug Barton) Date: Wed Apr 2 12:29:19 2008 Subject: cvs commit: src/etc/rc.d zfs Message-ID: <200804021929.m32JTGCo051671@repoman.freebsd.org> dougb 2008-04-02 19:29:16 UTC FreeBSD src repository Modified files: etc/rc.d zfs Log: Back out revision 1.6, the addition of "BEFORE: mountcritremote". mountcritremote REQUIREs FILESYSTEMS, and that script REQUIREs zfs, so this change is a noop. By removing it we make life a little easier both for rcorder(8) and for debugging down the road. Approved by: 2 weeks of silence from pjd Revision Changes Path 1.7 +0 -1 src/etc/rc.d/zfs From jfv at FreeBSD.org Wed Apr 2 15:00:37 2008 From: jfv at FreeBSD.org (Jack F Vogel) Date: Wed Apr 2 15:00:39 2008 Subject: cvs commit: src/sys/conf files src/sys/dev/em e1000_80003es2lan.c e1000_82540.c e1000_82541.c e1000_82542.c e1000_82543.c e1000_82571.c e1000_82571.h e1000_api.c e1000_api.h e1000_defines.h e1000_hw.h e1000_ich8lan.c e1000_ich8lan.h ... Message-ID: <200804022200.m32M0aNY070654@repoman.freebsd.org> jfv 2008-04-02 22:00:36 UTC FreeBSD src repository Modified files: sys/conf files sys/dev/em e1000_80003es2lan.c e1000_82540.c e1000_82541.c e1000_82542.c e1000_82543.c e1000_82571.c e1000_82571.h e1000_api.c e1000_api.h e1000_defines.h e1000_hw.h e1000_ich8lan.c e1000_ich8lan.h e1000_mac.c e1000_mac.h e1000_manage.c e1000_nvm.c e1000_nvm.h e1000_osdep.h e1000_phy.c e1000_phy.h if_em.c if_em.h sys/dev/igb e1000_mac.c if_igb.c sys/modules/em Makefile sys/modules/igb Makefile Added files: sys/dev/em e1000_osdep.c sys/dev/igb e1000_osdep.c Log: This update primarily addresses the ability to have both the em and the igb driver static in the kernel. But it also reflects some other bug fixes in my development stream at Intel. PR 122373 is also fixed in this code. Revision Changes Path 1.1287 +8 -16 src/sys/conf/files 1.6 +131 -128 src/sys/dev/em/e1000_80003es2lan.c 1.6 +81 -85 src/sys/dev/em/e1000_82540.c 1.6 +146 -150 src/sys/dev/em/e1000_82541.c 1.6 +87 -53 src/sys/dev/em/e1000_82542.c 1.6 +106 -102 src/sys/dev/em/e1000_82543.c 1.6 +147 -182 src/sys/dev/em/e1000_82571.c 1.6 +3 -12 src/sys/dev/em/e1000_82571.h 1.6 +140 -119 src/sys/dev/em/e1000_api.c 1.6 +6 -4 src/sys/dev/em/e1000_api.h 1.6 +3 -25 src/sys/dev/em/e1000_defines.h 1.6 +38 -35 src/sys/dev/em/e1000_hw.h 1.6 +186 -259 src/sys/dev/em/e1000_ich8lan.c 1.6 +3 -9 src/sys/dev/em/e1000_ich8lan.h 1.6 +152 -27 src/sys/dev/em/e1000_mac.c 1.6 +12 -4 src/sys/dev/em/e1000_mac.h 1.6 +10 -11 src/sys/dev/em/e1000_manage.c 1.6 +80 -47 src/sys/dev/em/e1000_nvm.c 1.6 +8 -8 src/sys/dev/em/e1000_nvm.h 1.1 +101 -0 src/sys/dev/em/e1000_osdep.c (new) 1.6 +38 -40 src/sys/dev/em/e1000_osdep.h 1.6 +268 -333 src/sys/dev/em/e1000_phy.c 1.6 +13 -8 src/sys/dev/em/e1000_phy.h 1.191 +123 -179 src/sys/dev/em/if_em.c 1.68 +0 -3 src/sys/dev/em/if_em.h 1.2 +3 -3 src/sys/dev/igb/e1000_mac.c 1.1 +101 -0 src/sys/dev/igb/e1000_osdep.c (new) 1.6 +97 -141 src/sys/dev/igb/if_igb.c 1.12 +1 -1 src/sys/modules/em/Makefile 1.3 +1 -1 src/sys/modules/igb/Makefile From jfv at FreeBSD.org Wed Apr 2 17:25:09 2008 From: jfv at FreeBSD.org (Jack F Vogel) Date: Wed Apr 2 17:25:11 2008 Subject: cvs commit: src/sys/dev/igb if_igb.c Message-ID: <200804030025.m330P9KW086626@repoman.freebsd.org> jfv 2008-04-03 00:25:09 UTC FreeBSD src repository Modified files: sys/dev/igb if_igb.c Log: Fix minor bug in last checkin, NO_STRICT_ALIGNMENT code. Revision Changes Path 1.7 +1 -1 src/sys/dev/igb/if_igb.c From davidxu at FreeBSD.org Wed Apr 2 18:48:11 2008 From: davidxu at FreeBSD.org (David Xu) Date: Wed Apr 2 18:48:14 2008 Subject: cvs commit: src/lib/libthr/arch/amd64 Makefile.inc src/lib/libthr/arch/amd64/include pthread_md.h src/lib/libthr/arch/i386 Makefile.inc src/lib/libthr/arch/i386/include pthread_md.h src/lib/libthr/thread thr_private.h thr_rtld.c thr_umtx.c ... In-Reply-To: <77FDA3DB-B81A-42D1-871E-AB04CD86C150@mac.com> References: <200804020741.m327fP1W065205@repoman.freebsd.org> <77FDA3DB-B81A-42D1-871E-AB04CD86C150@mac.com> Message-ID: <47F437AD.2070304@freebsd.org> Marcel Moolenaar wrote: > > On Apr 2, 2008, at 12:41 AM, David Xu wrote: >> davidxu 2008-04-02 07:41:25 UTC >> >> FreeBSD src repository >> >> Modified files: >> lib/libthr/arch/amd64 Makefile.inc >> lib/libthr/arch/amd64/include pthread_md.h >> lib/libthr/arch/i386 Makefile.inc >> lib/libthr/arch/i386/include pthread_md.h >> lib/libthr/thread thr_private.h thr_rtld.c thr_umtx.c >> Added files: >> lib/libthr/arch/amd64/amd64 _umtx_op_err.S >> lib/libthr/arch/i386/i386 _umtx_op_err.S >> Log: >> Replace function _umtx_op with _umtx_op_err, the later function directly >> returns errno, because errno can be mucked by user's signal handler and >> most of pthread api heavily depends on errno to be correct, this change >> should improve stability of the thread library. > > Doesn't this also apply to !i386 & !amd64? > Marcel, you are welcomed to improve it since I only know x86. Regards, From davidxu at FreeBSD.org Wed Apr 2 19:13:52 2008 From: davidxu at FreeBSD.org (David Xu) Date: Wed Apr 2 19:13:54 2008 Subject: cvs commit: src/lib/libthr/thread thr_private.h Message-ID: <200804030213.m332DpI8005822@repoman.freebsd.org> davidxu 2008-04-03 02:13:51 UTC FreeBSD src repository Modified files: lib/libthr/thread thr_private.h Log: add __hidden suffix to _umtx_op_err, this eliminates PLT. Revision Changes Path 1.91 +1 -1 src/lib/libthr/thread/thr_private.h From kevlo at FreeBSD.org Wed Apr 2 19:41:55 2008 From: kevlo at FreeBSD.org (Kevin Lo) Date: Wed Apr 2 19:41:56 2008 Subject: cvs commit: src/lib/libc/sys aio_cancel.2 aio_suspend.2 Message-ID: <200804030241.m332fsCs006870@repoman.freebsd.org> kevlo 2008-04-03 02:41:54 UTC FreeBSD src repository Modified files: lib/libc/sys aio_cancel.2 aio_suspend.2 Log: style(9) cleanup Revision Changes Path 1.23 +1 -1 src/lib/libc/sys/aio_cancel.2 1.23 +1 -1 src/lib/libc/sys/aio_suspend.2 From davidxu at FreeBSD.org Wed Apr 2 19:47:36 2008 From: davidxu at FreeBSD.org (David Xu) Date: Wed Apr 2 19:47:37 2008 Subject: cvs commit: src/lib/libthr/thread thr_private.h Message-ID: <200804030247.m332ladb007082@repoman.freebsd.org> davidxu 2008-04-03 02:47:35 UTC FreeBSD src repository Modified files: lib/libthr/thread thr_private.h Log: put THR_CRITICAL_LEAVE into do .. while statement. Revision Changes Path 1.92 +4 -2 src/lib/libthr/thread/thr_private.h From gnn at FreeBSD.org Wed Apr 2 22:26:55 2008 From: gnn at FreeBSD.org (George V. Neville-Neil) Date: Wed Apr 2 22:26:57 2008 Subject: cvs commit: src/tools/tools/mctest Makefile mctest.1 mctest.cc mctest.h Message-ID: <200804030526.m335QsKw024854@repoman.freebsd.org> gnn 2008-04-03 05:26:54 UTC FreeBSD src repository Modified files: tools/tools/mctest mctest.cc mctest.h Added files: tools/tools/mctest Makefile mctest.1 Log: Add a manual page and a Makefile. Add code to reflect packets back from the sink so that we can measure round trip at the source. Revision Changes Path 1.1 +9 -0 src/tools/tools/mctest/Makefile (new) 1.1 +100 -0 src/tools/tools/mctest/mctest.1 (new) 1.3 +110 -5 src/tools/tools/mctest/mctest.cc 1.2 +1 -0 src/tools/tools/mctest/mctest.h From imp at FreeBSD.org Wed Apr 2 23:07:46 2008 From: imp at FreeBSD.org (Warner Losh) Date: Wed Apr 2 23:07:49 2008 Subject: cvs commit: src/sys/arm/at91 kb920x_machdep.c Message-ID: <200804030607.m3367ke1027205@repoman.freebsd.org> imp 2008-04-03 06:07:45 UTC FreeBSD src repository Modified files: sys/arm/at91 kb920x_machdep.c Log: Remove unnecessary #define. Revision Changes Path 1.29 +0 -1 src/sys/arm/at91/kb920x_machdep.c From imp at FreeBSD.org Wed Apr 2 23:14:25 2008 From: imp at FreeBSD.org (Warner Losh) Date: Wed Apr 2 23:14:27 2008 Subject: cvs commit: src/sys/arm/xscale/ixp425 avila_machdep.c Message-ID: <200804030614.m336EOfN027443@repoman.freebsd.org> imp 2008-04-03 06:14:23 UTC FreeBSD src repository Modified files: sys/arm/xscale/ixp425 avila_machdep.c Log: KERNBASE + 0x00200000 is the same thing as KERNVIRTADDR on this platform, so use the latter in preference to the former. This makes the fake_preload setup be the same between kb920x_machdep.c and avila_machdep.c.... Revision Changes Path 1.7 +2 -3 src/sys/arm/xscale/ixp425/avila_machdep.c From das at FreeBSD.org Wed Apr 2 23:14:52 2008 From: das at FreeBSD.org (David Schultz) Date: Wed Apr 2 23:14:55 2008 Subject: cvs commit: src/lib/msun/src s_fma.c s_fmal.c Message-ID: <200804030614.m336EpMS027505@repoman.freebsd.org> das 2008-04-03 06:14:51 UTC FreeBSD src repository Modified files: lib/msun/src s_fma.c s_fmal.c Log: Fix some corner cases: - fma(x, y, z) returns z, not NaN, if z is infinite, x and y are finite, x*y overflows, and x*y and z have opposite signs. - fma(x, y, z) doesn't generate an overflow, underflow, or inexact exception if z is NaN or infinite, as per IEEE 754R. - If the rounding mode is set to FE_DOWNWARD, fma(1.0, 0.0, -0.0) is -0.0, not +0.0. Revision Changes Path 1.5 +10 -5 src/lib/msun/src/s_fma.c 1.4 +10 -5 src/lib/msun/src/s_fmal.c From das at FreeBSD.org Wed Apr 2 23:15:59 2008 From: das at FreeBSD.org (David Schultz) Date: Wed Apr 2 23:16:01 2008 Subject: cvs commit: src/tools/regression/lib/msun Makefile test-fma.c test-fma.t Message-ID: <200804030615.m336Fwcv027593@repoman.freebsd.org> das 2008-04-03 06:15:58 UTC FreeBSD src repository Modified files: tools/regression/lib/msun Makefile Added files: tools/regression/lib/msun test-fma.c test-fma.t Log: Add some tests for fma(), fmaf(), and fmal(). Revision Changes Path 1.12 +1 -1 src/tools/regression/lib/msun/Makefile 1.1 +413 -0 src/tools/regression/lib/msun/test-fma.c (new) 1.1 +10 -0 src/tools/regression/lib/msun/test-fma.t (new) From jfv at FreeBSD.org Wed Apr 2 23:17:17 2008 From: jfv at FreeBSD.org (Jack F Vogel) Date: Wed Apr 2 23:17:19 2008 Subject: cvs commit: src/sys/dev/igb if_igb.c Message-ID: <200804030617.m336HGav027675@repoman.freebsd.org> jfv 2008-04-03 06:17:16 UTC FreeBSD src repository Modified files: sys/dev/igb if_igb.c Log: Fix a lint issue in the build. Revision Changes Path 1.8 +12 -12 src/sys/dev/igb/if_igb.c From jfv at FreeBSD.org Thu Apr 3 06:45:38 2008 From: jfv at FreeBSD.org (Jack F Vogel) Date: Thu Apr 3 06:45:39 2008 Subject: cvs commit: src/sys/dev/igb if_igb.c Message-ID: <200804030645.m336jcMX028662@repoman.freebsd.org> jfv 2008-04-03 06:45:38 UTC FreeBSD src repository Modified files: sys/dev/igb if_igb.c Log: Another build fix Revision Changes Path 1.9 +1 -1 src/sys/dev/igb/if_igb.c From jeremie at le-hen.org Thu Apr 3 06:50:48 2008 From: jeremie at le-hen.org (Jeremie Le Hen) Date: Thu Apr 3 06:51:16 2008 Subject: cvs commit: src/sys/fs/ntfs ntfs_subr.c In-Reply-To: <20080329.221050.1649770238.imp@bsdimp.com> References: <200803300219.m2U2JSjv016162@repoman.freebsd.org> <47EEF9CA.9080008@gmail.com> <20080329.221050.1649770238.imp@bsdimp.com> Message-ID: <20080403064908.GA77598@obiwan.tataz.chchile.org> Hi, On Sat, Mar 29, 2008 at 10:10:50PM -0600, M. Warner Losh wrote: > Because the kernel based ntfs works and is BSD. FUSE is GPL, and new > GPL components are to be avoided. For the records, Ithink NetBSD has developped a BSDish solution API-compatible with FUSE, ironically named refuse :-). This is just a compatibility layer on top of a kernel based component named puffs. http://www.netbsd.org/docs/puffs/ Maybe this should end up in the project idea page. Regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org > From aryeh.friedman at gmail.com Thu Apr 3 09:06:29 2008 From: aryeh.friedman at gmail.com (Aryeh M. Friedman) Date: Thu Apr 3 09:06:32 2008 Subject: cvs commit: src/sys/fs/ntfs ntfs_subr.c In-Reply-To: <20080403064908.GA77598@obiwan.tataz.chchile.org> References: <200803300219.m2U2JSjv016162@repoman.freebsd.org> <47EEF9CA.9080008@gmail.com> <20080329.221050.1649770238.imp@bsdimp.com> <20080403064908.GA77598@obiwan.tataz.chchile.org> Message-ID: <47F49E0C.7010202@gmail.com> Jeremie Le Hen wrote: > Hi, > > On Sat, Mar 29, 2008 at 10:10:50PM -0600, M. Warner Losh wrote: > >> Because the kernel based ntfs works and is BSD. FUSE is GPL, and new >> GPL components are to be avoided. >> > > For the records, Ithink NetBSD has developped a BSDish solution > API-compatible with FUSE, ironically named refuse :-). This is just a > compatibility layer on top of a kernel based component named puffs. > > http://www.netbsd.org/docs/puffs/ > > Maybe this should end up in the project idea page. Any guess on the time commitment.... if long enough I can add it to my list of applied for SoC projects, From jroberson at chesapeake.net Thu Apr 3 09:29:44 2008 From: jroberson at chesapeake.net (Jeff Roberson) Date: Thu Apr 3 09:29:54 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c src/sys/sys rwlock.h In-Reply-To: <20080402145520.GA21462@zim.MIT.EDU> References: <200804012031.m31KVtKs000176@repoman.freebsd.org> <200804020025.57684.max@love2party.net> <20080401123951.J72156@desktop> <20080402145520.GA21462@zim.MIT.EDU> Message-ID: <20080402232758.L949@desktop> On Wed, 2 Apr 2008, David Schultz wrote: > On Tue, Apr 01, 2008, Jeff Roberson wrote: >> On Wed, 2 Apr 2008, Max Laier wrote: >> >>> On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote: >>>> attilio 2008-04-01 20:31:55 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/kern kern_rwlock.c >>>> sys/sys rwlock.h >>>> Log: >>>> Add rw_try_rlock() and rw_try_wlock() to rwlocks. >>>> These functions try the specified operation (rlocking and wlocking) >>>> and true is returned if the operation completes, false otherwise. >>> >>> hmmm ... I'm certainly missing something here, but what's a possible >>> usecase for these? It seems there is not much you can do if you can't >>> obtain a rw_lock. I can understand the need for sx_try_* where you want >>> to avoid sleeping, but I can't figure out the need for it on a locking >>> primitive that will only spin or wait (not 100% sure about the >>> terminology here). This is especially strange for rw_try_wlock, unless >>> you plan to sleep manually on fail. But then again you'd have a good >>> chance that you have to do it over and over again if timing is >>> unfortunate. >> >> I asked for it. We have a try operation for mtx already. I was >> experimenting with converting some code to use rwlocks from mtx and it >> required it. The specific case is in the softdep code where it uses >> trylock to avoid deadlocking. With trylock you can violate the lockorder. > > One reason that many systems don't provide a rw_try_wlock() > primitive is that a constant stream of readers can easily starve > threads attempting to acquire the write lock without waiting. > There are probably situations where this isn't a problem, though, > e.g., if readers rarely hold the lock for a long time... > The same applies to constant streams of lockers with a normal mutex. We have found a few cases now where trylock was used that basically never succeeded and caused pessimal behavior. I'm not really a fan of it myself but it is (ab)used in some scenarios and having it in rw will make changing from mtx easier. I think it would be a good task for someone to attempt to remove uses of trylock by restructuring the locking. Thanks, Jeff From rwatson at FreeBSD.org Thu Apr 3 09:48:04 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Apr 3 09:48:08 2008 Subject: cvs commit: src/sys/fs/ntfs ntfs_subr.c In-Reply-To: <20080403064908.GA77598@obiwan.tataz.chchile.org> References: <200803300219.m2U2JSjv016162@repoman.freebsd.org> <47EEF9CA.9080008@gmail.com> <20080329.221050.1649770238.imp@bsdimp.com> <20080403064908.GA77598@obiwan.tataz.chchile.org> Message-ID: <20080403104327.B42859@fledge.watson.org> On Thu, 3 Apr 2008, Jeremie Le Hen wrote: > On Sat, Mar 29, 2008 at 10:10:50PM -0600, M. Warner Losh wrote: > >> Because the kernel based ntfs works and is BSD. FUSE is GPL, and new GPL >> components are to be avoided. > > For the records, Ithink NetBSD has developped a BSDish solution > API-compatible with FUSE, ironically named refuse :-). This is just a > compatibility layer on top of a kernel based component named puffs. > > http://www.netbsd.org/docs/puffs/ > > Maybe this should end up in the project idea page. We currently have two user file system frameworks in ports (fuse, Arla nnpfs) and one in the kernel already (Coda). And no doubt more I don't know about. We're actively discussing importing nnpfs to make access to AFS easier out of the box. I'd be careful to recommend a determination of whether it makes a useful further contribution or not, rather than just recommending a port of the code. I have a loose recollection from the AsiaBSDCon puffs talk last year that fast path access to local cache (container) files wasn't implemented in puffs, which would put it at a significant disadvantage performance-wise to nnpfs. However, a year is a long time, so it may well be that puffs has now picked up that support in the mean time. Robert N M Watson Computer Laboratory University of Cambridge From yar at FreeBSD.org Thu Apr 3 10:22:57 2008 From: yar at FreeBSD.org (Yar Tikhiy) Date: Thu Apr 3 10:23:08 2008 Subject: cvs commit: src/games/fortune/datfiles fortunes Message-ID: <200804031022.m33AMuum050137@repoman.freebsd.org> yar 2008-04-03 10:22:56 UTC FreeBSD src repository Modified files: games/fortune/datfiles fortunes Log: Put back the quote from Chinggis Khan removed in rev. 1.259. The quote predated rev. 1.232, which rev. 1.259 was to correct; therefore it was protected by the "Don't remove fortunes" rule. Noticed by: ceri Pointy hat to: yar Revision Changes Path 1.260 +6 -0 src/games/fortune/datfiles/fortunes From jroberson at chesapeake.net Thu Apr 3 10:36:04 2008 From: jroberson at chesapeake.net (Jeff Roberson) Date: Thu Apr 3 10:36:08 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c src/sys/sys rwlock.h In-Reply-To: <200804021645.19331.max@love2party.net> References: <200804012031.m31KVtKs000176@repoman.freebsd.org> <200804020412.30624.max@love2party.net> <20080401210738.E72156@desktop> <200804021645.19331.max@love2party.net> Message-ID: <20080403003059.D949@desktop> On Wed, 2 Apr 2008, Max Laier wrote: > On Wednesday 02 April 2008 09:15:25 Jeff Roberson wrote: >> On Wed, 2 Apr 2008, Max Laier wrote: >>> On Wednesday 02 April 2008 03:11:11 Jeff Roberson wrote: >>>> On Wed, 2 Apr 2008, Attilio Rao wrote: >>>>> 2008/4/2, Max Laier : >>>>>> On Wednesday 02 April 2008 00:52:45 Jeff Roberson wrote: >>>>>>> On Wed, 2 Apr 2008, Max Laier wrote: >>>>>>>> On Tuesday 01 April 2008 22:31:55 Attilio Rao wrote: >>>>>>>>> attilio 2008-04-01 20:31:55 UTC >>>>>>>>> >>>>>>>>> FreeBSD src repository >>>>>>>>> >>>>>>>>> Modified files: >>>>>>>>> sys/kern kern_rwlock.c >>>>>>>>> sys/sys rwlock.h >>>>>>>>> Log: >>>>>>>>> Add rw_try_rlock() and rw_try_wlock() to rwlocks. >>>>>>>>> These functions try the specified operation (rlocking and >>>>>>>>> wlocking) and true is returned if the operation completes, >>>>>>>>> false otherwise. >>>>>>>> >>>>>>>> hmmm ... I'm certainly missing something here, but what's a >>>>>>>> possible usecase for these? It seems there is not much you can >>>>>>>> do if you can't obtain a rw_lock. I can understand the need for >>>>>>>> sx_try_* where you want to avoid sleeping, but I can't figure >>>>>>>> out the need for it on a locking primitive that will only spin >>>>>>>> or wait (not 100% sure about the terminology here). This is >>>>>>>> especially strange for rw_try_wlock, unless you plan to sleep >>>>>>>> manually on fail. But then again you'd have a good chance that >>>>>>>> you have to do it over and over again if timing is unfortunate. >>>>>>> >>>>>>> I asked for it. We have a try operation for mtx already. I was >>>>>>> experimenting with converting some code to use rwlocks from mtx >>>>>>> and it required it. The specific case is in the softdep code >>>>>>> where it uses trylock to avoid deadlocking. With trylock you can >>>>>>> violate the lockorder. >>>>>> >>>>>> Makes sense, thanks! A little follow-up, though about something >>>>>> I'm wondering about for quite some time now. Take the following >>>>>> scenario: >>>>>> >>>>>> Thread A: rw_rlock(RW) ... mtx_lock(MTX) ... UNLOCK >>>>>> Thread B: mtx_lock(MTX) ... rw_rlock(RW) ... UNLOCK >>>>>> Thread C: rw_wlock(RW) ... UNLOCK >>>>> >>>>> This can't deadlock simply because rw_rlock() is not mutually >>>>> exclusive. >>>> >>>> It can deadlock if there is a writer waiting in queue depending on >>>> whether we prefer readers or writers. I think we should consider >>>> the reader/writer perference an implementation detail to prevent >>>> code like this from cropping up. >>> >>> Sorry, I still don't understand this. Even if there is a writer >>> (thread C) waiting and we prefer writers, the reader (A or B) has to >>> wait, but eventually the writer will give up the lock (as it can make >>> progress independently of whether the mutex is held or not) and the >>> readers can progress. What am I missing? >> >> Thread A: rw_rlock(RW) ... mtx_lock(MTX) ... UNLOCK >> Thread B: mtx_lock(MTX) ... rw_rlock(RW) ... UNLOCK >> Thread C: rw_wlock(RW) ... UNLOCK >> >> Thread A: Thread B: Thread C: >> rw_rlock(rw) >> mtx_lock(mtx) >> rw_wlock(rw) <- Blocked waiting for a >> rw_rlock(rw) <- Blocked waiting for c due to write >> fairness mtx_lock(mtx) <- Blocked waiting for B >> >> Does that help? > > Yes it does, thanks. Do you know what the situation for rm_locks is? If > I understand correctly they implement full priority propagation. In this > scenario C would boost A via the RM and A would boost B via MTX so B > could run and avoid the deadlock. Or am I missing something again? I know that in rm ups tracks individual owners and has the ability to do pp when a reader blocks a writer. I don't know if that is hooked up or not. However, the issue blocking B, which really is the problem, isn't one of priority. You would have to detect this loop, which would be possible, but then you'd have to force thread b's acquire to succeed despite the lock fairness. I don't think that's a very clean design. turnstiles and rwlocks would have to be much more integrated for it to work. > > In any case doing "while (!rw_try_wlock(rw));" instead of a > plain "rw_wlock(rw);" would now be a possible workaround - if we don't > care about starvation of thread C, right? I hope you aren't considering doing this in practice. There is no guarantee how long the lock will be held even if the owners hold it over very brief snippits of code. They may be preempted by something of a higher priority which runs for a very long time causing the spinning code above to consume excessive amounts of cpu. Thanks, Jeff > >>> I don't think this is a good thing either, but I also think that >>> there are some cases where there just are different access orders. >>> I'd rather want a clean way out of this than a lot of difficult >>> per-instance hacks. This does not mean that these can't be fixed >>> cleanly, but I think it's really hard sometimes especially for code >>> we import from elsewhere (hence the personal interest). >> >> I think the best solution is to treat rlocks as wlocks in terms of >> access orders. >> >>>> Readers are only allowed to proceed with a read lock if they already >>>> own a read lock, not just if the lock is already read locked. This >>>> changed in current recently. So a single recursive read acqusition >>>> can't deadlock but get multiple threads and a writer involved with >>>> writer preference and you can. >> >> Thanks, >> Jeff >> >>> -- >>> /"\ Best regards, | mlaier@freebsd.org >>> \ / Max Laier | ICQ #67774661 >>> X http://pf4freebsd.love2party.net/ | mlaier@EFnet >>> / \ ASCII Ribbon Campaign | Against HTML Mail and News > > > > -- > /"\ Best regards, | mlaier@freebsd.org > \ / Max Laier | ICQ #67774661 > X http://pf4freebsd.love2party.net/ | mlaier@EFnet > / \ ASCII Ribbon Campaign | Against HTML Mail and News > From davidxu at FreeBSD.org Thu Apr 3 11:49:21 2008 From: davidxu at FreeBSD.org (David Xu) Date: Thu Apr 3 11:49:24 2008 Subject: cvs commit: src/sys/kern kern_umtx.c Message-ID: <200804031149.m33BnK56057211@repoman.freebsd.org> davidxu 2008-04-03 11:49:20 UTC FreeBSD src repository Modified files: sys/kern kern_umtx.c Log: let umtxq_busy() only spin on mp machine. make function name do_rwlock_unlock to be consistent with others. Revision Changes Path 1.68 +13 -9 src/sys/kern/kern_umtx.c From ivoras at freebsd.org Thu Apr 3 11:50:43 2008 From: ivoras at freebsd.org (Ivan Voras) Date: Thu Apr 3 11:50:52 2008 Subject: cvs commit: src/sys/fs/ntfs ntfs_subr.c In-Reply-To: <47F49E0C.7010202@gmail.com> References: <200803300219.m2U2JSjv016162@repoman.freebsd.org> <47EEF9CA.9080008@gmail.com> <20080329.221050.1649770238.imp@bsdimp.com> <20080403064908.GA77598@obiwan.tataz.chchile.org> <47F49E0C.7010202@gmail.com> Message-ID: <47F4C22E.8030208@freebsd.org> Aryeh M. Friedman wrote: > Jeremie Le Hen wrote: >> Hi, >> >> On Sat, Mar 29, 2008 at 10:10:50PM -0600, M. Warner Losh wrote: >> >>> Because the kernel based ntfs works and is BSD. FUSE is GPL, and new >>> GPL components are to be avoided. >>> >> >> For the records, Ithink NetBSD has developped a BSDish solution >> API-compatible with FUSE, ironically named refuse :-). This is just a >> compatibility layer on top of a kernel based component named puffs. >> >> http://www.netbsd.org/docs/puffs/ >> >> Maybe this should end up in the project idea page. > > Any guess on the time commitment.... if long enough I can add it to my > list of applied for SoC projects, See this: http://blogs.freebsdish.org/anderson/2007/11/27/puffs-for-freebsd/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: OpenPGP digital signature Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080403/06fb461c/signature.pgp From peter at wemm.org Thu Apr 3 12:21:06 2008 From: peter at wemm.org (Peter Wemm) Date: Thu Apr 3 12:21:12 2008 Subject: cvs commit: src/sys/dev/bce if_bce.c if_bcefw.h if_bcereg.h In-Reply-To: References: <200802220046.m1M0kMPM008814@repoman.freebsd.org> <5D267A3F22FD854F8F48B3D2B523819324EF633FCC@IRVEXCHCCR01.corp.ad.broadcom.com> Message-ID: On Mon, Mar 31, 2008 at 12:34 PM, Peter Wemm wrote: > > On Mon, Mar 31, 2008 at 12:13 PM, David Christensen > wrote: > > > On Thu, Feb 21, 2008 at 5:46 PM, David Christensen > > > wrote: > > > > Modified files: > > > > sys/dev/bce if_bce.c if_bcefw.h if_bcereg.h > > > > Log: > > > > MFC after: 4 weeks > > > > > > > > - Added loose RX MTU functionality to allow frames larger > > > than 1500 bytes > > > > to be accepted even though the interface MTU is set to 1500. > > > > - Implemented new TCP header splitting/jumbo frame > > > support which uses > > > > two chains for receive traffic rather than the original > > > single recevie > > > > chain. > > > > - Added additional debug support code. > > > > > > > > Revision Changes Path > > > > 1.36 +1559 -675 src/sys/dev/bce/if_bce.c > > > > 1.5 +6179 -4850 src/sys/dev/bce/if_bcefw.h > > > > 1.17 +264 -55 src/sys/dev/bce/if_bcereg.h > > > > > > This has been devastating on the freebsd.org cluster. > > > > > > Attached are three test runs. I've done a cold reboot, then 'cd > > > /usr/src/sys' and doing a 'cvs -Rq update' where the CVSROOT is over > > > nfs. > > > > > > First, the old driver: > > > svn# time cvs -Rq up > > > 0.890u 4.577s 1:14.48 7.3% 669+2315k 7379+0io 10094pf+0w > > > > > > Now, the same test again, but with this change included in the kernel: > > > svn# time cvs -Rq up > > > 0.940u 359.906s 7:01.04 85.7% 648+2242k 7365+0io 10082pf+0w > > > > > > Note the massive increase (nearly 100 times increase) in system time, > > > and the almost 7-fold increase in wall clock time. > > > > > > Turning on promisc mode helps a lot, but doesn't solve it. (This was > > > found when ps@ was using tcpdump to try and figure out what the > > > problem was) > > > > The change is needed to update the FreeBSD driver so that it can > > continue using production firmware for the controllers. The previous > > firmware was specific to FreeBSD and was not being maintained. > > > > I didn't see any performance issues running with netperf. Is the NFS > > traffic UDP or TCP? What's the MTU in use? How much system memory is > > available? > > NFS over UDP. We're also seeing problems with NIS/YP (also UDP) on > the box with the driver active. The MTU is the standard 1500. Both > machines have 8GB of ram. Both are 64 bit kernels. Client is a Dell > 2950 (2 x quad core2), the server is a HP DL385 (quad opteron with > bge). > > > > If this is a performance problem then the first place I would look is > > in the definitions for rx_bd_mbuf_alloc_size and pg_bd_mbuf_alloc_size. > > The older version of the driver would use multiple 2KB buffers > > (MCLBYTES in size) from a single chain when building a packet so you > > would typically have a single mbuf cluster passed to the stack. The > > new firmware uses two chains, each of which may be a different size. > > The current implementation will use MHLEN bytes for the rx chain and > > MCLBYTES for the pg chain. When a packet is received the hardware will > > place as much data as possible into a single mbuf in the rx chain, > > then place any remaining data into one or more mbufs in the pg chain. > > The driver will then stitch together the mbufs before passing them up > > the stack. This process is supposed to improve performance for TCP > > because the TCP payload will be split from the TCP header and should > > be quicker to access. > > > > A quick test would be to set rx_bd_mbuf_alloc_size to MCLBYTES, which > > should for the most part duplicate the older behavior. The driver > > will still allocate more mbufs which might be a problem if system > > memory is already low. Is anyone else aware of a driver that does > > TCP header splitting? It's typically on the TX side to see a packet > > with two or three mbufs in a chain but I suspect it's less typical > > on the RX side which could be part of the problem. > > The one thing that I'm very sure of is that system memory isn't low, > on either machine. The extraordinary increase in accumulated system > time of the process makes me wonder if something odd is going on with > the TX path. When sending packets, the network stack and driver code > path execution times are charged to the user process doing the writes. > On the receive side, the cpu time will be accumulated in either the > driver ithread or taskqueue, or the netisr kthread. To be honest, I > hadn't been looking to see if excessive cpu time was accumulating > there, but I did notice that the system's load average was over 2.0 > for the duration of the 'cvs update' on an otherwise idle machine. > This suggests to me that both send and receive were bogging down > somehow. > > Perhaps it is something silly like a spin lock being triggered? > > > > > > > > Here's the same test, with the new driver, and promisc mode on: > > > svn# ifconfig bce0 promisc > > > svn# time cvs -Rq up > > > 0.967u 50.919s 2:13.97 38.7% 650+2250k 7379+0io 10094pf+0w > > > > > > It is better.. Only double the wall clock time, but still over 10 > > > times as much system time. > > > > > > > It's not clear to me why promiscuous mode would make a difference > > here as that should only affect which packets are accepted by the > > MAC. Is there any teaming or VLANs used in your configuration? > > The RX MTU settings shouldn't be affected by promiscuous mode. > > There is nothing special going on. Just a plain gige cable to a cisco > gige switch. I have no explanation for the promisc thing - one of the > freebsd.org admins thought the problem was with YP/NIS. He started up > a tcpdump to observe the NIS interactions during ssh login, and the > problem mostly went away. > > BTW; I did the test twice. I ran the machine with cvs HEAD, and > backed the driver out to before the commit. I also tried a RELENG_7 > kernel, and then put the HEAD bce driver on 7.x - the problem goes > with the bce driver change in both 7.x and 8.x/HEAD. > > There will be 4 more of these machines online sometime today (7.x and > 8,x, both 32 and 64 bit). We can experiment with those at will. > > > > > > > > > > > > So please, don't MFC until this is solved.. > > > > > > > I haven't yet as I've received reports from a few other people that > > they're having problems, though they're functional problems and not > > performance issues. On 8.0/i386, with PAE enabled, I get messages on the console and the system hangs when trying to do a nfs mount. Backing out the driver fixes it. The same driver doesn't cause quite as spectacular a failure on 8.0/amd64, but it isn't exactly happy.. Additional IP options:.^M Mounting NFS file systebcms:e1: link state changed to UP^M bce1: discard frame w/o leading ethernet header (len 0 pkt len 0)^M bce1: discard frame w/o leading ethernet header (len 0 pkt len 0)^M bce1: discard frame w/o leading ethernet header (len 0 pkt len 0)^M bce1: discard frame w/o leading ethernet header (len 0 pkt len 0)^M [..forever..] NFS over UDP, fwiw. Server is a netapp. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 "If Java had true garbage collection, most programs would delete themselves upon execution." -- Robert Sewell **WANTED TO BUY: Garmin Streetpilot 2650 or 2660. Not later model! ** From jeremie at le-hen.org Thu Apr 3 13:27:31 2008 From: jeremie at le-hen.org (Jeremie Le Hen) Date: Thu Apr 3 13:27:36 2008 Subject: cvs commit: src/sys/fs/ntfs ntfs_subr.c In-Reply-To: <20080403104327.B42859@fledge.watson.org> References: <200803300219.m2U2JSjv016162@repoman.freebsd.org> <47EEF9CA.9080008@gmail.com> <20080329.221050.1649770238.imp@bsdimp.com> <20080403064908.GA77598@obiwan.tataz.chchile.org> <20080403104327.B42859@fledge.watson.org> Message-ID: <20080403132551.GB77598@obiwan.tataz.chchile.org> Hi Robert, On Thu, Apr 03, 2008 at 10:48:03AM +0100, Robert Watson wrote: > On Thu, 3 Apr 2008, Jeremie Le Hen wrote: > > For the records, Ithink NetBSD has developped a BSDish solution > > API-compatible with FUSE, ironically named refuse :-). This is just a > > compatibility layer on top of a kernel based component named puffs. > > > > http://www.netbsd.org/docs/puffs/ > > > > Maybe this should end up in the project idea page. > > We currently have two user file system frameworks in ports (fuse, Arla > nnpfs) and one in the kernel already (Coda). And no doubt more I don't know > about. We're actively discussing importing nnpfs to make access to AFS > easier out of the box. I'd be careful to recommend a determination of > whether it makes a useful further contribution or not, rather than just > recommending a port of the code. I have a loose recollection from the > AsiaBSDCon puffs talk last year that fast path access to local cache > (container) files wasn't implemented in puffs, which would put it at a > significant disadvantage performance-wise to nnpfs. However, a year is a > long time, so it may well be that puffs has now picked up that support in > the mean time. I don't know anything about Arla or Coda, so I won't make any performance-wise comments about those filesystem. However, there seem to be quite a community around FUSE. I think this is mostly because people are more confident with userland coding. There are really plenty of filesystems using FUSE, albeit most of them seem to be very silly IMHO. See http://fuse.sf.net/wiki/index.php/FileSystems . Yet some of them could be useful for people needing compatibility before performance. NTFS is a good example, FUSEPod, SshFS are good ones too. Once we'd have gathered FreeBSD fellows around puffs/refuse, some of them may tackle the performance problem. Regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org > From scottl at FreeBSD.org Thu Apr 3 14:39:49 2008 From: scottl at FreeBSD.org (Scott Long) Date: Thu Apr 3 14:39:55 2008 Subject: cvs commit: src/sys/dev/mpt mpt.c Message-ID: <200804031439.m33EdnX8079444@repoman.freebsd.org> scottl 2008-04-03 14:39:48 UTC FreeBSD src repository Modified files: sys/dev/mpt mpt.c Log: Don't force a reset at driver attach time. It doesn't work on some adapters, apparently. Revision Changes Path 1.48 +1 -1 src/sys/dev/mpt/mpt.c From xcllnt at mac.com Thu Apr 3 14:46:05 2008 From: xcllnt at mac.com (Marcel Moolenaar) Date: Thu Apr 3 14:46:15 2008 Subject: cvs commit: src/sys/dev/mpt mpt.c In-Reply-To: <200804031439.m33EdnX8079444@repoman.freebsd.org> References: <200804031439.m33EdnX8079444@repoman.freebsd.org> Message-ID: On Apr 3, 2008, at 7:39 AM, Scott Long wrote: > scottl 2008-04-03 14:39:48 UTC > > FreeBSD src repository > > Modified files: > sys/dev/mpt mpt.c > Log: > Don't force a reset at driver attach time. It doesn't work on some > adapters, apparently. Thanks! -- Marcel Moolenaar xcllnt@mac.com From ru at FreeBSD.org Thu Apr 3 16:21:43 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Thu Apr 3 16:21:50 2008 Subject: cvs commit: src/lib/libc/gen msgctl.3 Message-ID: <200804031621.m33GLhMI084993@repoman.freebsd.org> ru 2008-04-03 16:21:43 UTC FreeBSD src repository Modified files: lib/libc/gen msgctl.3 Log: Fix descriptions of "struct msqid_ds and "struct ipc_perm" to match harsh reality. Revision Changes Path 1.21 +11 -11 src/lib/libc/gen/msgctl.3 From imp at FreeBSD.org Thu Apr 3 16:44:52 2008 From: imp at FreeBSD.org (Warner Losh) Date: Thu Apr 3 16:45:06 2008 Subject: cvs commit: src/sys/arm/arm machdep.c src/sys/arm/at91 kb920x_machdep.c src/sys/arm/include machdep.h src/sys/arm/sa11x0 assabet_machdep.c src/sys/arm/xscale/i80321 ep80219_machdep.c iq31244_machdep.c src/sys/arm/xscale/i8134x crb_machdep.c ... Message-ID: <200804031644.m33Gip5R085902@repoman.freebsd.org> imp 2008-04-03 16:44:50 UTC FreeBSD src repository Modified files: sys/arm/arm machdep.c sys/arm/at91 kb920x_machdep.c sys/arm/include machdep.h sys/arm/sa11x0 assabet_machdep.c sys/arm/xscale/i80321 ep80219_machdep.c iq31244_machdep.c sys/arm/xscale/i8134x crb_machdep.c sys/arm/xscale/ixp425 avila_machdep.c Log: Take the first baby step towards unifying and cleaning up arminit(): - Pull all the code to deal with the trampoline stuff into one centeralized place and use it from everywhere. - Some minor style tidiness Reviewed by: tinguely Revision Changes Path 1.30 +57 -0 src/sys/arm/arm/machdep.c 1.30 +3 -53 src/sys/arm/at91/kb920x_machdep.c 1.3 +5 -5 src/sys/arm/include/machdep.h 1.23 +7 -43 src/sys/arm/sa11x0/assabet_machdep.c 1.9 +2 -53 src/sys/arm/xscale/i80321/ep80219_machdep.c 1.30 +2 -50 src/sys/arm/xscale/i80321/iq31244_machdep.c 1.5 +2 -54 src/sys/arm/xscale/i8134x/crb_machdep.c 1.8 +1 -48 src/sys/arm/xscale/ixp425/avila_machdep.c From marcel at FreeBSD.org Thu Apr 3 17:38:27 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Thu Apr 3 17:38:35 2008 Subject: cvs commit: src/sys/powerpc/psim openpic_iobus.c Message-ID: <200804031738.m33HcRpf097717@repoman.freebsd.org> marcel 2008-04-03 17:38:27 UTC FreeBSD src repository Modified files: sys/powerpc/psim openpic_iobus.c Log: Set sc_psim so that the openpic core can correct the off-by-one error in the number of IRQs that PSIM gives us. Revision Changes Path 1.10 +5 -0 src/sys/powerpc/psim/openpic_iobus.c From marcel at FreeBSD.org Thu Apr 3 17:40:23 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Thu Apr 3 17:40:28 2008 Subject: cvs commit: src/sys/powerpc/include asm.h Message-ID: <200804031740.m33HeMP0097816@repoman.freebsd.org> marcel 2008-04-03 17:40:20 UTC FreeBSD src repository Modified files: sys/powerpc/include asm.h Log: Align functions to 16-byte boundaries due to profiling granularity. Revision Changes Path 1.11 +1 -1 src/sys/powerpc/include/asm.h From raj at FreeBSD.org Thu Apr 3 18:20:42 2008 From: raj at FreeBSD.org (Rafal Jaworowski) Date: Thu Apr 3 18:20:44 2008 Subject: cvs commit: src/sys/arm/xscale/ixp425 avila_machdep.c Message-ID: <200804031820.m33IKd0b000399@repoman.freebsd.org> raj 2008-04-03 18:20:39 UTC FreeBSD src repository Modified files: sys/arm/xscale/ixp425 avila_machdep.c Log: Fix AVILA build. Reviewed by: sam Approved by: cognet(mentor) Revision Changes Path 1.9 +2 -2 src/sys/arm/xscale/ixp425/avila_machdep.c From raj at FreeBSD.org Thu Apr 3 18:22:08 2008 From: raj at FreeBSD.org (Rafal Jaworowski) Date: Thu Apr 3 18:22:14 2008 Subject: cvs commit: src/sys/arm/sa11x0 files.sa11x0 sa11x0_io.c src/sys/arm/xscale/i80321 files.ep80219 files.i80219 files.i80321 files.iq31244 obio_space.c src/sys/arm/xscale/i8134x obio_space.c src/sys/arm/xscale/ixp425 files.avila files.ixp425 ... Message-ID: <200804031822.m33IM8nV000863@repoman.freebsd.org> raj 2008-04-03 18:22:08 UTC FreeBSD src repository Modified files: sys/arm/sa11x0 files.sa11x0 sa11x0_io.c sys/arm/xscale/i80321 files.ep80219 files.i80219 files.i80321 files.iq31244 obio_space.c sys/arm/xscale/i8134x obio_space.c sys/arm/xscale/ixp425 files.avila files.ixp425 ixp425_a4x_space.c ixp425_space.c Log: Refactor certain ARM bus space methods: instead of having multiple copies of the same code introduce sys/arm/arm/bus_space_generic.c for a shared set of routines. Reviewed by: sam Approved by: cognet (mentor) Revision Changes Path 1.4 +1 -0 src/sys/arm/sa11x0/files.sa11x0 1.11 +7 -120 src/sys/arm/sa11x0/sa11x0_io.c 1.2 +1 -0 src/sys/arm/xscale/i80321/files.ep80219 1.2 +1 -0 src/sys/arm/xscale/i80321/files.i80219 1.4 +1 -0 src/sys/arm/xscale/i80321/files.i80321 1.3 +1 -0 src/sys/arm/xscale/i80321/files.iq31244 1.5 +6 -103 src/sys/arm/xscale/i80321/obio_space.c 1.2 +6 -103 src/sys/arm/xscale/i8134x/obio_space.c 1.3 +1 -0 src/sys/arm/xscale/ixp425/files.avila 1.5 +1 -0 src/sys/arm/xscale/ixp425/files.ixp425 1.2 +6 -7 src/sys/arm/xscale/ixp425/ixp425_a4x_space.c 1.2 +6 -91 src/sys/arm/xscale/ixp425/ixp425_space.c From raj at FreeBSD.org Thu Apr 3 18:28:35 2008 From: raj at FreeBSD.org (Rafal Jaworowski) Date: Thu Apr 3 18:28:45 2008 Subject: cvs commit: src/sys/arm/arm bus_space_generic.c Message-ID: <200804031828.m33ISY8A001077@repoman.freebsd.org> raj 2008-04-03 18:28:34 UTC FreeBSD src repository Added files: sys/arm/arm bus_space_generic.c Log: Now really add the bus_space_generic.c file... Reviewed by: sam Approved by: cognet (mentor) Revision Changes Path 1.1 +146 -0 src/sys/arm/arm/bus_space_generic.c (new) From jhb at FreeBSD.org Thu Apr 3 18:46:56 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Apr 3 18:47:00 2008 Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb kld.c main.c Message-ID: <200804031846.m33Ikq4d001711@repoman.freebsd.org> jhb 2008-04-03 18:46:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) gnu/usr.bin/gdb/kgdb kld.c main.c Log: MFC: Initialize list of kld's correctly when there are no kld's and catch errors in kgdb_parse() so it returns 0 for invalid expressions. This fixes the kld loading for 6.x and 7.x. Revision Changes Path 1.6.2.2 +1 -0 src/gnu/usr.bin/gdb/kgdb/kld.c 1.11.2.2 +9 -6 src/gnu/usr.bin/gdb/kgdb/main.c From jhb at FreeBSD.org Thu Apr 3 18:47:05 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Apr 3 18:47:11 2008 Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb kld.c main.c Message-ID: <200804031847.m33Il5pv001767@repoman.freebsd.org> jhb 2008-04-03 18:47:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) gnu/usr.bin/gdb/kgdb kld.c main.c Log: MFC: Initialize list of kld's correctly when there are no kld's and catch errors in kgdb_parse() so it returns 0 for invalid expressions. This fixes the kld loading for 6.x and 7.x. Revision Changes Path 1.6.4.2 +1 -0 src/gnu/usr.bin/gdb/kgdb/kld.c 1.7.2.6 +9 -6 src/gnu/usr.bin/gdb/kgdb/main.c From jhb at FreeBSD.org Thu Apr 3 18:49:06 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Apr 3 18:49:10 2008 Subject: cvs commit: src/gnu/usr.bin/gdb/kgdb trgt.c Message-ID: <200804031849.m33In55P001842@repoman.freebsd.org> jhb 2008-04-03 18:49:05 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) gnu/usr.bin/gdb/kgdb trgt.c Log: MFC: Add the 'tid' command to select a thread using a kernel thread ID. Revision Changes Path 1.2.2.5 +28 -0 src/gnu/usr.bin/gdb/kgdb/trgt.c From jhb at FreeBSD.org Thu Apr 3 18:51:14 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Apr 3 18:51:17 2008 Subject: cvs commit: src/sys/gnu/fs/ext2fs ext2_vfsops.c src/sys/ufs/ffs ffs_vfsops.c Message-ID: <200804031851.m33IpDQR001994@repoman.freebsd.org> jhb 2008-04-03 18:51:13 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/gnu/fs/ext2fs ext2_vfsops.c sys/ufs/ffs ffs_vfsops.c Log: MFC: Fix a nit with the 'nofoo' options where 'foo' is mapped to 'nonofoo' so that filesystems will consider 'nonofoo' a valid option. Revision Changes Path 1.165.2.1 +1 -1 src/sys/gnu/fs/ext2fs/ext2_vfsops.c 1.329.2.3 +3 -3 src/sys/ufs/ffs/ffs_vfsops.c From jhb at FreeBSD.org Thu Apr 3 19:39:49 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Apr 3 19:39:59 2008 Subject: cvs commit: src/sys/kern kern_shutdown.c Message-ID: <200804031939.m33Jdm4b005933@repoman.freebsd.org> jhb 2008-04-03 19:39:47 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern kern_shutdown.c Log: MFC: Make it possible to continue working after calling doadump() manually. Revision Changes Path 1.182.2.4 +1 -0 src/sys/kern/kern_shutdown.c From jhb at FreeBSD.org Thu Apr 3 19:40:59 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Apr 3 19:41:10 2008 Subject: cvs commit: src/sys/kern kern_shutdown.c Message-ID: <200804031940.m33Jewtq006022@repoman.freebsd.org> jhb 2008-04-03 19:40:58 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern kern_shutdown.c Log: MFC: Make it possible to continue working after calling doadump() manually. Revision Changes Path 1.174.2.5 +1 -0 src/sys/kern/kern_shutdown.c From imp at FreeBSD.org Thu Apr 3 20:36:45 2008 From: imp at FreeBSD.org (Warner Losh) Date: Thu Apr 3 20:36:56 2008 Subject: cvs commit: src/lib/libc/gen err.c Message-ID: <200804032036.m33KaiJi013468@repoman.freebsd.org> imp 2008-04-03 20:36:44 UTC FreeBSD src repository Modified files: lib/libc/gen err.c Log: Minor style(9) nit: move to using ANSI definition of functions. Revision Changes Path 1.15 +5 -19 src/lib/libc/gen/err.c From imp at FreeBSD.org Thu Apr 3 20:37:38 2008 From: imp at FreeBSD.org (Warner Losh) Date: Thu Apr 3 20:37:45 2008 Subject: cvs commit: src/sbin/restore dirs.c interactive.c Message-ID: <200804032037.m33Kbc1r016497@repoman.freebsd.org> imp 2008-04-03 20:37:38 UTC FreeBSD src repository Modified files: sbin/restore dirs.c interactive.c Log: Use safer string handling. Reviewed by: security-team Revision Changes Path 1.32 +4 -5 src/sbin/restore/dirs.c 1.19 +4 -6 src/sbin/restore/interactive.c From imp at FreeBSD.org Thu Apr 3 20:42:37 2008 From: imp at FreeBSD.org (Warner Losh) Date: Thu Apr 3 20:42:43 2008 Subject: cvs commit: src/sys/conf Makefile.arm Message-ID: <200804032042.m33KgaBh017248@repoman.freebsd.org> imp 2008-04-03 20:42:36 UTC FreeBSD src repository Modified files: sys/conf Makefile.arm Log: Always build kernel.tramp. This should be helpful for a lot of people, as well making sure it doesn't break. Revision Changes Path 1.36 +2 -0 src/sys/conf/Makefile.arm From jfv at FreeBSD.org Thu Apr 3 20:58:19 2008 From: jfv at FreeBSD.org (Jack F Vogel) Date: Thu Apr 3 20:58:21 2008 Subject: cvs commit: src/sys/conf files Message-ID: <200804032058.m33KwI2g027013@repoman.freebsd.org> jfv 2008-04-03 20:58:18 UTC FreeBSD src repository Modified files: sys/conf files Log: Fix the build breakage, need the | between dependencies, I didn't realize that :( Revision Changes Path 1.1288 +8 -8 src/sys/conf/files From brooks at FreeBSD.org Thu Apr 3 21:33:15 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Thu Apr 3 21:33:21 2008 Subject: cvs commit: src/sbin/ddb ddb.8 ddb.c Message-ID: <200804032133.m33LXF0G031338@repoman.freebsd.org> brooks 2008-04-03 21:33:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sbin/ddb ddb.8 ddb.c Log: NFC the ability to read a file of commands to ddb(8) modeled after the feature in ipfw(8). Revision Changes Path 1.3.2.3 +14 -0 src/sbin/ddb/ddb.8 1.2.2.2 +67 -5 src/sbin/ddb/ddb.c From brooks at FreeBSD.org Thu Apr 3 21:36:12 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Thu Apr 3 21:36:24 2008 Subject: cvs commit: src/etc Makefile ddb.conf src/etc/defaults rc.conf src/etc/rc.d Makefile ddb src/share/man/man5 rc.conf.5 Message-ID: <200804032136.m33LaC6X031718@repoman.freebsd.org> brooks 2008-04-03 21:36:12 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) etc Makefile etc/defaults rc.conf etc/rc.d Makefile share/man/man5 rc.conf.5 Added files: (Branch: RELENG_7) etc ddb.conf etc/rc.d ddb Log: MFC: Use the new command file feature of ddb(8) to support setting ddb(4) scripts at boot. This is currently disabled by default. /etc/ddb.conf contains some potentially reasonable default scripts. PR: conf/119995 Submitted by: Scot Hetzel (Earlier version) Revision Changes Path 1.360.2.4 +1 -1 src/etc/Makefile 1.1.2.1 +15 -0 src/etc/ddb.conf (new) 1.318.2.6 +2 -0 src/etc/defaults/rc.conf 1.84.2.3 +1 -1 src/etc/rc.d/Makefile 1.1.2.1 +32 -0 src/etc/rc.d/ddb (new) 1.327.2.3 +13 -0 src/share/man/man5/rc.conf.5 From emaste at FreeBSD.org Thu Apr 3 23:29:32 2008 From: emaste at FreeBSD.org (Ed Maste) Date: Thu Apr 3 23:29:37 2008 Subject: cvs commit: src/sys/dev/aac aac_disk.c Message-ID: <200804032329.m33NTV6r048733@repoman.freebsd.org> emaste 2008-04-03 23:29:31 UTC FreeBSD src repository Modified files: sys/dev/aac aac_disk.c Log: Allow crashdumps on machines with >4GB of RAM as long as the adapter can do 64-bit S/G. Submitted by: Alex Bencz Reviewed by: scottl Revision Changes Path 1.46 +54 -13 src/sys/dev/aac/aac_disk.c From sam at FreeBSD.org Thu Apr 3 23:43:28 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Thu Apr 3 23:43:35 2008 Subject: cvs commit: src/sys/net if.h src/sbin/ifconfig ifconfig.8 ifconfig.c Message-ID: <200804032343.m33NhRMM051642@repoman.freebsd.org> sam 2008-04-03 23:43:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/net if.h sbin/ifconfig ifconfig.8 ifconfig.c Log: MFC: WOL infrastructure support Revision Changes Path 1.142.2.2 +16 -1 src/sbin/ifconfig/ifconfig.8 1.134.2.1 +9 -1 src/sbin/ifconfig/ifconfig.c 1.108.2.2 +7 -3 src/sys/net/if.h From julian at elischer.org Fri Apr 4 00:16:51 2008 From: julian at elischer.org (Julian Elischer) Date: Fri Apr 4 00:17:01 2008 Subject: cvs commit: src/sbin/ddb ddb.8 ddb.c In-Reply-To: <200804032133.m33LXF0G031338@repoman.freebsd.org> References: <200804032133.m33LXF0G031338@repoman.freebsd.org> Message-ID: <47F57371.4000904@elischer.org> Brooks Davis wrote: > brooks 2008-04-03 21:33:15 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_7) > sbin/ddb ddb.8 ddb.c > Log: > NFC the ability to read a file of commands to ddb(8) modeled after the > feature in ipfw(8). > > Revision Changes Path > 1.3.2.3 +14 -0 src/sbin/ddb/ddb.8 > 1.2.2.2 +67 -5 src/sbin/ddb/ddb.c NFC? "Nuke from current"? From jeff at FreeBSD.org Fri Apr 4 01:03:24 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Fri Apr 4 01:03:37 2008 Subject: cvs commit: src/sys/kern kern_intr.c Message-ID: <200804040103.m3413ODX074116@repoman.freebsd.org> jeff 2008-04-04 01:03:23 UTC FreeBSD src repository Modified files: sys/kern kern_intr.c Log: - Fix a mis-merge that crept in during the softclock changes. Spotted by: jhb Revision Changes Path 1.159 +0 -2 src/sys/kern/kern_intr.c From jeff at FreeBSD.org Fri Apr 4 01:04:44 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Fri Apr 4 01:04:50 2008 Subject: cvs commit: src/sys/kern sched_ule.c Message-ID: <200804040104.m3414hJj074163@repoman.freebsd.org> jeff 2008-04-04 01:04:43 UTC FreeBSD src repository Modified files: sys/kern sched_ule.c Log: - Don't check for the ITHD pri class in tdq_load_add and rem. 4BSD doesn't do this either. Simply check P_NOLOAD. It'd be nice if this was in a thread flag so we didn't have an extra cache miss every time we add and remove a thread from the run-queue. Revision Changes Path 1.239 +6 -12 src/sys/kern/sched_ule.c From jeff at FreeBSD.org Fri Apr 4 01:16:19 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Fri Apr 4 01:16:25 2008 Subject: cvs commit: src/sys/kern sched_ule.c Message-ID: <200804040116.m341GJsD074573@repoman.freebsd.org> jeff 2008-04-04 01:16:18 UTC FreeBSD src repository Modified files: sys/kern sched_ule.c Log: - Allow static_boost to specify no boost with '0', traditional kernel fixed pri boost with '1' or any priority less than the current thread's priority with a value greater than two. Default the boost to PRI_MIN_TIMESHARE to prevent regular user-space threads from starving threads in the kernel. This prevents these user-threads from also being scheduled as if they are high fixed-priority kernel threads. - Restore the setting of lowpri in tdq_choose(). It has to be either here or in sched_switch(). I accidentally removed it from both places. Tested by: kris Revision Changes Path 1.240 +6 -2 src/sys/kern/sched_ule.c From jeff at FreeBSD.org Fri Apr 4 01:22:05 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Fri Apr 4 01:22:07 2008 Subject: cvs commit: src/sys/sys cpuset.h src/sys/kern kern_cpuset.c Message-ID: <200804040122.m341M554074847@repoman.freebsd.org> jeff 2008-04-04 01:22:04 UTC FreeBSD src repository Modified files: sys/sys cpuset.h sys/kern kern_cpuset.c Log: - Add a Nokia copyright to cpuset to reflect their generous contribution to this work. Revision Changes Path 1.8 +3 -0 src/sys/kern/kern_cpuset.c 1.6 +3 -0 src/sys/sys/cpuset.h From jroberson at chesapeake.net Fri Apr 4 01:23:40 2008 From: jroberson at chesapeake.net (Jeff Roberson) Date: Fri Apr 4 01:23:44 2008 Subject: cvs commit: src/sys/kern sched_ule.c In-Reply-To: <200804040116.m341GJsD074573@repoman.freebsd.org> References: <200804040116.m341GJsD074573@repoman.freebsd.org> Message-ID: <20080403152038.W949@desktop> On Fri, 4 Apr 2008, Jeff Roberson wrote: > jeff 2008-04-04 01:16:18 UTC > > FreeBSD src repository > > Modified files: > sys/kern sched_ule.c > Log: > - Allow static_boost to specify no boost with '0', traditional kernel > fixed pri boost with '1' or any priority less than the current thread's > priority with a value greater than two. Default the boost to > PRI_MIN_TIMESHARE to prevent regular user-space threads from starving > threads in the kernel. This prevents these user-threads from also > being scheduled as if they are high fixed-priority kernel threads. This is one of those unfortunate cases where one setting doesn't work for everything and I just had to pick a value in the middle somewhere that makes sense. I am likely to remove this tunable before 8.0 is complete but if you notice any serious regressions please try setting kern.sched.static_boost = 1. Thanks, Jeff > - Restore the setting of lowpri in tdq_choose(). It has to be either here > or in sched_switch(). I accidentally removed it from both places. > > Tested by: kris > > Revision Changes Path > 1.240 +6 -2 src/sys/kern/sched_ule.c > From rodrigc at FreeBSD.org Fri Apr 4 01:50:59 2008 From: rodrigc at FreeBSD.org (Craig Rodrigues) Date: Fri Apr 4 01:51:05 2008 Subject: cvs commit: src/sbin/fsck_ffs main.c Message-ID: <200804040150.m341owGT075760@repoman.freebsd.org> rodrigc 2008-04-04 01:50:58 UTC FreeBSD src repository Modified files: sbin/fsck_ffs main.c Log: Add comment about specifying "ro" mount option when doing an update mount on a read-only file system. Requested by: yar Revision Changes Path 1.50 +4 -0 src/sbin/fsck_ffs/main.c From rodrigc at FreeBSD.org Fri Apr 4 02:20:17 2008 From: rodrigc at FreeBSD.org (Craig Rodrigues) Date: Fri Apr 4 02:20:19 2008 Subject: cvs commit: src/sbin/fsck_ffs main.c Message-ID: <200804040220.m342KGSh077761@repoman.freebsd.org> rodrigc 2008-04-04 02:20:16 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sbin/fsck_ffs main.c Log: MFC 1.49-1.50: - do not upgrade a read-only mount to read-write when we fsck it PR: 120319 Revision Changes Path 1.47.2.1 +7 -1 src/sbin/fsck_ffs/main.c From grog at FreeBSD.org Fri Apr 4 03:57:47 2008 From: grog at FreeBSD.org (Greg Lehey) Date: Fri Apr 4 03:57:53 2008 Subject: cvs commit: src/bin/ls ls.1 ls.c ls.h print.c Message-ID: <200804040357.m343vlQ8083007@repoman.freebsd.org> grog 2008-04-04 03:57:47 UTC FreeBSD src repository Modified files: bin/ls ls.1 ls.c ls.h print.c Log: Add -D option to specify exact format of date and time output with ls -l. Revision Changes Path 1.101 +28 -6 src/bin/ls/ls.1 1.86 +6 -2 src/bin/ls/ls.c 1.23 +2 -1 src/bin/ls/ls.h 1.77 +10 -7 src/bin/ls/print.c From ru at FreeBSD.org Fri Apr 4 05:55:43 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Fri Apr 4 05:55:47 2008 Subject: cvs commit: src/bin/ls ls.1 util.c Message-ID: <200804040555.m345tgVE098535@repoman.freebsd.org> ru 2008-04-04 05:55:42 UTC FreeBSD src repository Modified files: bin/ls ls.1 util.c Log: - Add -D to usage(). - Bump document date for the addition of the -D option. - Reformat a sentence to look like a real sentence. Revision Changes Path 1.102 +3 -2 src/bin/ls/ls.1 1.41 +2 -2 src/bin/ls/util.c From ru at FreeBSD.org Fri Apr 4 07:31:45 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Fri Apr 4 07:31:52 2008 Subject: cvs commit: src/sbin/ddb ddb.8 ddb.c Message-ID: <200804040731.m347Vijq004688@repoman.freebsd.org> ru 2008-04-04 07:31:43 UTC FreeBSD src repository Modified files: sbin/ddb ddb.8 ddb.c Log: - Normalize usage(), add "ddb pathname" syntax. - Revise the manpage. Revision Changes Path 1.4 +23 -20 src/sbin/ddb/ddb.8 1.3 +5 -5 src/sbin/ddb/ddb.c From yar at comp.chem.msu.su Fri Apr 4 08:57:42 2008 From: yar at comp.chem.msu.su (Yar Tikhiy) Date: Fri Apr 4 08:57:53 2008 Subject: cvs commit: src/sbin/fsck_ffs main.c In-Reply-To: <200804040150.m341owGT075760@repoman.freebsd.org> References: <200804040150.m341owGT075760@repoman.freebsd.org> Message-ID: <20080404085746.GB19086@dg.local> On Fri, Apr 04, 2008 at 01:50:58AM +0000, Craig Rodrigues wrote: > rodrigc 2008-04-04 01:50:58 UTC > > FreeBSD src repository > > Modified files: > sbin/fsck_ffs main.c > Log: > Add comment about specifying "ro" mount option when > doing an update mount on a read-only file system. > > Requested by: yar > > Revision Changes Path > 1.50 +4 -0 src/sbin/fsck_ffs/main.c Thanks! (But see below.) > Index: src/sbin/fsck_ffs/main.c > diff -u src/sbin/fsck_ffs/main.c:1.49 src/sbin/fsck_ffs/main.c:1.50 > --- src/sbin/fsck_ffs/main.c:1.49 Wed Mar 5 08:25:49 2008 > +++ src/sbin/fsck_ffs/main.c Fri Apr 4 01:50:58 2008 > @@ -541,6 +541,10 @@ > build_iovec(&iov, &iovlen, "errmsg", errmsg, > sizeof(errmsg)); > build_iovec(&iov, &iovlen, "update", NULL, 0); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ As I've already pointed out, this line you also added is dangerous because it installs the string "update" to among the root mount point options, which may blow up later with more changes to the mount framework. The option still needs to be spelled MNT_UPDATE and passed as a flag for now. > + /* > + * XX: We need the following line until we clean up > + * nmount parsing of root mounts and NFS root mounts. > + */ > build_iovec(&iov, &iovlen, "ro", NULL, 0); > if (nmount(iov, iovlen, fflags) == 0) { > return (0); -- Yar From kib at FreeBSD.org Fri Apr 4 09:37:57 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Fri Apr 4 09:38:05 2008 Subject: cvs commit: src/sys/fs/fdescfs fdesc_vnops.c Message-ID: <200804040937.m349bvJR019843@repoman.freebsd.org> kib 2008-04-04 09:37:57 UTC FreeBSD src repository Modified files: sys/fs/fdescfs fdesc_vnops.c Log: The temporary workaround for the call to the vget() without lock type in the fdesc_allocvp(). The caller of the fdesc_allocvp() expects that the returned vnode is not reclaimed. Do lock the vnode exclusive and drop the lock after. Reported by: pho Reviewed by: jeff Revision Changes Path 1.108 +3 -1 src/sys/fs/fdescfs/fdesc_vnops.c From dfr at FreeBSD.org Fri Apr 4 09:43:04 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Fri Apr 4 09:43:07 2008 Subject: cvs commit: src/lib/libc/include libc_private.h src/lib/libc/sys Makefile.inc fcntl.c Message-ID: <200804040943.m349h3U3020079@repoman.freebsd.org> dfr 2008-04-04 09:43:03 UTC FreeBSD src repository Modified files: lib/libc/include libc_private.h lib/libc/sys Makefile.inc Added files: lib/libc/sys fcntl.c Log: Add some compatibility code so that software which is built to use the new struct flock with l_sysid member can work properly on an an old kernel which doesn't support l_sysid. Sponsored by: Isilon Systems Revision Changes Path 1.18 +3 -0 src/lib/libc/include/libc_private.h 1.133 +2 -1 src/lib/libc/sys/Makefile.inc 1.1 +87 -0 src/lib/libc/sys/fcntl.c (new) From jeff at FreeBSD.org Fri Apr 4 10:00:47 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Fri Apr 4 10:00:53 2008 Subject: cvs commit: src/sys/kern kern_rwlock.c Message-ID: <200804041000.m34A0kSL020625@repoman.freebsd.org> jeff 2008-04-04 10:00:46 UTC FreeBSD src repository Modified files: sys/kern kern_rwlock.c Log: - Add sysctls at debug.rwlock to control the behavior of the speculative spinning when readers hold a lock. This spinning is speculative because, unlike the write case, we can not test whether the owners are running. - Add speculative read spinning for readers who are blocked by pending writers while a read lock is still held. This allows the thread to spin until the write lock succeeds after which it may spin until the writer has released the lock. This prevents excessive context switches when readers and writers both hold the lock for brief periods. Sponsored by: Nokia Revision Changes Path 1.38 +26 -3 src/sys/kern/kern_rwlock.c From kensmith at cse.Buffalo.EDU Fri Apr 4 12:44:21 2008 From: kensmith at cse.Buffalo.EDU (Ken Smith) Date: Fri Apr 4 12:44:32 2008 Subject: cvs commit: src/sbin/ddb ddb.8 ddb.c In-Reply-To: <47F57371.4000904@elischer.org> References: <200804032133.m33LXF0G031338@repoman.freebsd.org> <47F57371.4000904@elischer.org> Message-ID: <1207313051.38068.5.camel@bauer.cse.buffalo.edu> On Thu, 2008-04-03 at 17:16 -0700, Julian Elischer wrote: > Brooks Davis wrote: > > brooks 2008-04-03 21:33:15 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_7) > > sbin/ddb ddb.8 ddb.c > > Log: > > NFC the ability to read a file of commands to ddb(8) modeled after the > > feature in ipfw(8). > > > > Revision Changes Path > > 1.3.2.3 +14 -0 src/sbin/ddb/ddb.8 > > 1.2.2.2 +67 -5 src/sbin/ddb/ddb.c > > > NFC? > > "Nuke from current"? > Julian criticizing someone for a typo. Isn't that sorta like me criticizing someone for being late? Sorry, couldn't resist. I tried. Honest. :-) -- Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel | -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: This is a digitally signed message part Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080404/d1959318/attachment.pgp From cokane at FreeBSD.org Fri Apr 4 13:03:57 2008 From: cokane at FreeBSD.org (Coleman Kane) Date: Fri Apr 4 13:04:07 2008 Subject: cvs commit: src/sbin/ddb ddb.8 ddb.c In-Reply-To: <1207313051.38068.5.camel@bauer.cse.buffalo.edu> References: <200804032133.m33LXF0G031338@repoman.freebsd.org> <47F57371.4000904@elischer.org> <1207313051.38068.5.camel@bauer.cse.buffalo.edu> Message-ID: <47F6272D.4050400@FreeBSD.org> Ken Smith wrote: > On Thu, 2008-04-03 at 17:16 -0700, Julian Elischer wrote: > >> Brooks Davis wrote: >> >>> brooks 2008-04-03 21:33:15 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: (Branch: RELENG_7) >>> sbin/ddb ddb.8 ddb.c >>> Log: >>> NFC the ability to read a file of commands to ddb(8) modeled after the >>> feature in ipfw(8). >>> >>> Revision Changes Path >>> 1.3.2.3 +14 -0 src/sbin/ddb/ddb.8 >>> 1.2.2.2 +67 -5 src/sbin/ddb/ddb.c >>> >> NFC? >> >> "Nuke from current"? >> >> > > Julian criticizing someone for a typo. Isn't that sorta like me > criticizing someone for being late? > > Sorry, couldn't resist. I tried. Honest. :-) > I think we've just stumbled upon a new term for feature removal. I like it. -- Coleman Kane From jhb at freebsd.org Fri Apr 4 13:29:48 2008 From: jhb at freebsd.org (John Baldwin) Date: Fri Apr 4 13:29:54 2008 Subject: cvs commit: src/sys/kern sched_ule.c In-Reply-To: <200804040104.m3414hJj074163@repoman.freebsd.org> References: <200804040104.m3414hJj074163@repoman.freebsd.org> Message-ID: <200804040904.37819.jhb@freebsd.org> On Thursday 03 April 2008 09:04:43 pm Jeff Roberson wrote: > jeff 2008-04-04 01:04:43 UTC > > FreeBSD src repository > > Modified files: > sys/kern sched_ule.c > Log: > - Don't check for the ITHD pri class in tdq_load_add and rem. 4BSD > doesn't do this either. Simply check P_NOLOAD. It'd be nice if this was > in a thread flag so we didn't have an extra cache miss every time we add > and remove a thread from the run-queue. Actually, now that all interrupt threads are in a single process, it should be a per-thread flag. It was only ever intended to mask softclock since that is what did the load calculation on 4BSD so that 4BSD wouldn't always return a load of 1 even on an idle box (since softclock was always running when the load was checked). -- John Baldwin From julian at elischer.org Fri Apr 4 15:07:06 2008 From: julian at elischer.org (Julian Elischer) Date: Fri Apr 4 15:07:16 2008 Subject: cvs commit: src/sbin/ddb ddb.8 ddb.c In-Reply-To: <1207313051.38068.5.camel@bauer.cse.buffalo.edu> References: <200804032133.m33LXF0G031338@repoman.freebsd.org> <47F57371.4000904@elischer.org> <1207313051.38068.5.camel@bauer.cse.buffalo.edu> Message-ID: <47F64418.7020003@elischer.org> Ken Smith wrote: > On Thu, 2008-04-03 at 17:16 -0700, Julian Elischer wrote: >> Brooks Davis wrote: >>> brooks 2008-04-03 21:33:15 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: (Branch: RELENG_7) >>> sbin/ddb ddb.8 ddb.c >>> Log: >>> NFC the ability to read a file of commands to ddb(8) modeled after the >>> feature in ipfw(8). >>> >>> Revision Changes Path >>> 1.3.2.3 +14 -0 src/sbin/ddb/ddb.8 >>> 1.2.2.2 +67 -5 src/sbin/ddb/ddb.c >> >> NFC? >> >> "Nuke from current"? >> > > Julian criticizing someone for a typo. Isn't that sorta like me > criticizing someone for being late? > > Sorry, couldn't resist. I tried. Honest. :-) > it wsa a joke you know.. (as was yours I know..) From scottl at FreeBSD.org Fri Apr 4 16:32:06 2008 From: scottl at FreeBSD.org (Scott Long) Date: Fri Apr 4 16:32:12 2008 Subject: cvs commit: src/sys/dev/iir iir.c Message-ID: <200804041632.m34GW6w4070361@repoman.freebsd.org> scottl 2008-04-04 16:32:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/iir iir.c Log: Merge rev 1.20: Fix a buffer overflow in the processing of various SCSI commands. This likely fixes a great number of weird problems that have been reported with this driver. Revision Changes Path 1.19.2.1 +42 -26 src/sys/dev/iir/iir.c From scottl at FreeBSD.org Fri Apr 4 16:42:18 2008 From: scottl at FreeBSD.org (Scott Long) Date: Fri Apr 4 16:42:25 2008 Subject: cvs commit: src/sys/dev/iir iir.c Message-ID: <200804041642.m34GgHUu071169@repoman.freebsd.org> scottl 2008-04-04 16:42:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/iir iir.c Log: Merge rev 1.20: Fix a buffer overflow in the processing of various SCSI commands. This likely fixes a great number of weird problems that have been reported with this driver. Revision Changes Path 1.13.2.2 +42 -26 src/sys/dev/iir/iir.c From imp at FreeBSD.org Fri Apr 4 16:59:58 2008 From: imp at FreeBSD.org (Warner Losh) Date: Fri Apr 4 17:00:08 2008 Subject: cvs commit: src/share/man/man9 sleep.9 Message-ID: <200804041659.m34Gxwat081401@repoman.freebsd.org> imp 2008-04-04 16:59:58 UTC FreeBSD src repository Modified files: share/man/man9 sleep.9 Log: Add note about PZERO being obsolete, because so much code uses it. Feel free to improve the verbage, since this was a compromise between conflicting feedback I got on my original version. Revision Changes Path 1.62 +5 -1 src/share/man/man9/sleep.9 From raj at FreeBSD.org Fri Apr 4 17:35:25 2008 From: raj at FreeBSD.org (Rafal Jaworowski) Date: Fri Apr 4 17:35:33 2008 Subject: cvs commit: src/sys/arm/arm elf_trampoline.c src/sys/conf Makefile.arm Message-ID: <200804041735.m34HZOe7084609@repoman.freebsd.org> raj 2008-04-04 17:35:24 UTC FreeBSD src repository Modified files: sys/arm/arm elf_trampoline.c sys/conf Makefile.arm Log: Make kernel.tramp build properly on ARM9E. Reviewed by: imp Approved by: cognet (mentor) Revision Changes Path 1.20 +2 -0 src/sys/arm/arm/elf_trampoline.c 1.37 +1 -1 src/sys/conf/Makefile.arm From alc at FreeBSD.org Fri Apr 4 18:00:22 2008 From: alc at FreeBSD.org (Alan Cox) Date: Fri Apr 4 18:00:29 2008 Subject: cvs commit: src/sys/amd64/amd64 pmap.c Message-ID: <200804041800.m34I0MP6085733@repoman.freebsd.org> alc 2008-04-04 18:00:22 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c Log: Eliminate an unnecessary test and its misleading comment from pmap_enter(). Revision Changes Path 1.612 +0 -6 src/sys/amd64/amd64/pmap.c From julian at FreeBSD.org Fri Apr 4 18:08:52 2008 From: julian at FreeBSD.org (Julian Elischer) Date: Fri Apr 4 18:08:58 2008 Subject: cvs commit: src/sbin/ipfw ipfw.8 ipfw2.c Message-ID: <200804041808.m34I8p9x089272@repoman.freebsd.org> julian 2008-04-04 18:08:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sbin/ipfw ipfw.8 ipfw2.c Log: MFC: ipfw2.c 1.114 ipfw.8 1.209 Use an explicit argument to display table args a IP addresses. Revision Changes Path 1.203.2.3 +5 -0 src/sbin/ipfw/ipfw.8 1.108.2.5 +9 -6 src/sbin/ipfw/ipfw2.c From julian at FreeBSD.org Fri Apr 4 18:10:51 2008 From: julian at FreeBSD.org (Julian Elischer) Date: Fri Apr 4 18:10:56 2008 Subject: cvs commit: src/sbin/ipfw ipfw.8 ipfw2.c Message-ID: <200804041810.m34IAobh089404@repoman.freebsd.org> julian 2008-04-04 18:10:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sbin/ipfw ipfw.8 ipfw2.c Log: MFC: ipfw2.c 1.114 ipfw.8 1.209 Use an explicit argument to format table args as IP addresses. Revision Changes Path 1.175.2.14 +5 -0 src/sbin/ipfw/ipfw.8 1.76.2.21 +9 -6 src/sbin/ipfw/ipfw2.c From imp at FreeBSD.org Fri Apr 4 18:22:16 2008 From: imp at FreeBSD.org (Warner Losh) Date: Fri Apr 4 18:22:22 2008 Subject: cvs commit: src/sys/arm/sa11x0 assabet_machdep.c Message-ID: <200804041822.m34IMGoL089859@repoman.freebsd.org> imp 2008-04-04 18:22:16 UTC FreeBSD src repository Modified files: sys/arm/sa11x0 assabet_machdep.c Log: Fix stupid typo Revision Changes Path 1.24 +1 -1 src/sys/arm/sa11x0/assabet_machdep.c From alc at FreeBSD.org Fri Apr 4 18:41:13 2008 From: alc at FreeBSD.org (Alan Cox) Date: Fri Apr 4 18:41:23 2008 Subject: cvs commit: src/sys/i386/i386 pmap.c src/sys/kern kern_mbuf.c src/sys/vm uma.h uma_core.c Message-ID: <200804041841.m34IfCmE094819@repoman.freebsd.org> alc 2008-04-04 18:41:12 UTC FreeBSD src repository Modified files: sys/i386/i386 pmap.c sys/kern kern_mbuf.c sys/vm uma.h uma_core.c Log: Reintroduce UMA_SLAB_KMAP; however, change its spelling to UMA_SLAB_KERNEL for consistency with its sibling UMA_SLAB_KMEM. (UMA_SLAB_KMAP met its original demise in revision 1.30 of vm/uma_core.c.) UMA_SLAB_KERNEL is now required by the jumbo frame allocators. Without it, UMA cannot correctly return pages from the jumbo frame zones to the VM system because it resets the pages' object field to NULL instead of the kernel object. In more detail, the jumbo frame zones are created with the option UMA_ZONE_REFCNT. This causes UMA to overwrite the pages' object field with the address of the slab. However, when UMA wants to release these pages, it doesn't know how to restore the object field, so it sets it to NULL. This change teaches UMA how to reset the object field to the kernel object. Crashes reported by: kris Fix tested by: kris Fix discussed with: jeff MFC after: 6 weeks Revision Changes Path 1.614 +3 -1 src/sys/i386/i386/pmap.c 1.40 +2 -1 src/sys/kern/kern_mbuf.c 1.32 +1 -0 src/sys/vm/uma.h 1.149 +4 -0 src/sys/vm/uma_core.c From alc at FreeBSD.org Fri Apr 4 19:14:59 2008 From: alc at FreeBSD.org (Alan Cox) Date: Fri Apr 4 19:15:01 2008 Subject: cvs commit: src/sys/vm vm_map.c Message-ID: <200804041914.m34JEwX1097097@repoman.freebsd.org> alc 2008-04-04 19:14:58 UTC FreeBSD src repository Modified files: sys/vm vm_map.c Log: Update a comment to vm_map_pmap_enter(). Revision Changes Path 1.394 +2 -2 src/sys/vm/vm_map.c From imp at FreeBSD.org Fri Apr 4 19:33:10 2008 From: imp at FreeBSD.org (Warner Losh) Date: Fri Apr 4 19:33:15 2008 Subject: cvs commit: src/sys/conf Makefile.arm Message-ID: <200804041933.m34JXABh097825@repoman.freebsd.org> imp 2008-04-04 19:33:10 UTC FreeBSD src repository Modified files: sys/conf Makefile.arm Log: If you build a compiler with TARGET_BIG_ENDIAN, and then try to build a little endian kernel, things break. Be explicit about the endian choice by setting it in the little endian case as well. Revision Changes Path 1.38 +4 -0 src/sys/conf/Makefile.arm From imp at FreeBSD.org Fri Apr 4 20:59:27 2008 From: imp at FreeBSD.org (Warner Losh) Date: Fri Apr 4 20:59:29 2008 Subject: cvs commit: src/libexec/rtld-elf rtld.c rtld.h src/libexec/rtld-elf/mips reloc.c rtld_machdep.h rtld_start.S Message-ID: <200804042059.m34KxRAT022573@repoman.freebsd.org> imp 2008-04-04 20:59:26 UTC FreeBSD src repository Modified files: libexec/rtld-elf rtld.c rtld.h Added files: libexec/rtld-elf/mips reloc.c rtld_machdep.h rtld_start.S Log: MFp4: Add mips support for dynamic linking. This code came from the merged mips2 and Juniper mips repositories. Warner Losh, Randall Seager, Oleksandr Tymoshenko and Olivier Houchard worked to merge, debug and integrate this code. This code may also contain code derived from NetBSD. Revision Changes Path 1.1 +357 -0 src/libexec/rtld-elf/mips/reloc.c (new) 1.1 +74 -0 src/libexec/rtld-elf/mips/rtld_machdep.h (new) 1.1 +127 -0 src/libexec/rtld-elf/mips/rtld_start.S (new) 1.125 +39 -5 src/libexec/rtld-elf/rtld.c 1.39 +5 -0 src/libexec/rtld-elf/rtld.h From imp at FreeBSD.org Fri Apr 4 21:12:40 2008 From: imp at FreeBSD.org (Warner Losh) Date: Fri Apr 4 21:12:47 2008 Subject: cvs commit: src/share/mk sys.mk Message-ID: <200804042112.m34LCebO024355@repoman.freebsd.org> imp 2008-04-04 21:12:40 UTC FreeBSD src repository Modified files: share/mk sys.mk Log: MFp4 (mips2-jnpr): o Default to -O on mips as well as arm. -O2 has been strongly implicated in many problems in the past, so we're taking a conservative approach until the problems are well understood. Revision Changes Path 1.101 +1 -1 src/share/mk/sys.mk From imp at FreeBSD.org Fri Apr 4 21:33:42 2008 From: imp at FreeBSD.org (Warner Losh) Date: Fri Apr 4 21:33:52 2008 Subject: cvs commit: src/usr.bin/gprof gprof.h Message-ID: <200804042133.m34LXgMt025008@repoman.freebsd.org> imp 2008-04-04 21:33:42 UTC FreeBSD src repository Modified files: usr.bin/gprof gprof.h Log: Add mips support. Revision Changes Path 1.26 +3 -0 src/usr.bin/gprof/gprof.h From imp at FreeBSD.org Fri Apr 4 21:35:13 2008 From: imp at FreeBSD.org (Warner Losh) Date: Fri Apr 4 21:35:20 2008 Subject: cvs commit: src/usr.bin/xlint/lint1 param.h Message-ID: <200804042135.m34LZD9l025230@repoman.freebsd.org> imp 2008-04-04 21:35:13 UTC FreeBSD src repository Modified files: usr.bin/xlint/lint1 param.h Log: MFp4(mips2-jnpr): Add mips support. Revision Changes Path 1.10 +3 -0 src/usr.bin/xlint/lint1/param.h From cperciva at FreeBSD.org Fri Apr 4 23:22:02 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Fri Apr 4 23:22:43 2008 Subject: cvs commit: src/usr.sbin/freebsd-update freebsd-update.sh Message-ID: <200804042322.m34NM1SF032197@repoman.freebsd.org> cperciva 2008-04-04 23:22:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.sbin/freebsd-update freebsd-update.sh Log: MFC revisions 1.13, 1.14: Don't try to compute the SHA256 hashes of files which don't exist; and fix the handling of symlinks to dynamically linked libraries. Revision Changes Path 1.8.2.3 +16 -16 src/usr.sbin/freebsd-update/freebsd-update.sh From cperciva at FreeBSD.org Fri Apr 4 23:22:50 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Fri Apr 4 23:22:56 2008 Subject: cvs commit: src/usr.sbin/freebsd-update freebsd-update.sh Message-ID: <200804042322.m34NMnj9032242@repoman.freebsd.org> cperciva 2008-04-04 23:22:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/freebsd-update freebsd-update.sh Log: MFC revisions 1.13, 1.14: Don't try to compute the SHA256 hashes of files which don't exist; and fix the handling of symlinks to dynamically linked libraries. Revision Changes Path 1.2.2.9 +16 -16 src/usr.sbin/freebsd-update/freebsd-update.sh From cperciva at FreeBSD.org Fri Apr 4 23:24:45 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Fri Apr 4 23:24:52 2008 Subject: cvs commit: src/etc freebsd-update.conf Message-ID: <200804042324.m34NOiOI032312@repoman.freebsd.org> cperciva 2008-04-04 23:24:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) etc freebsd-update.conf Log: MFC revision 1.4: Add /boot/devices.hints to the default list of files which have local modifications merged during upgrading. Revision Changes Path 1.1.4.3 +1 -1 src/etc/freebsd-update.conf From cperciva at FreeBSD.org Fri Apr 4 23:25:08 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Fri Apr 4 23:25:11 2008 Subject: cvs commit: src/etc freebsd-update.conf Message-ID: <200804042325.m34NP8C4032402@repoman.freebsd.org> cperciva 2008-04-04 23:25:08 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) etc freebsd-update.conf Log: MFC revision 1.4: Add /boot/devices.hints to the default list of files which have local modifications merged during upgrading. Revision Changes Path 1.1.2.4 +1 -1 src/etc/freebsd-update.conf From yongari at FreeBSD.org Sat Apr 5 00:52:11 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Sat Apr 5 00:52:17 2008 Subject: cvs commit: src/sys/dev/mii ip1000phy.c ip1000phyreg.h miidevs Message-ID: <200804050052.m350q7jg045431@repoman.freebsd.org> yongari 2008-04-05 00:52:07 UTC FreeBSD src repository Modified files: sys/dev/mii ip1000phy.c ip1000phyreg.h miidevs Log: Add support for IC Plus IP1001 PHY. Tested by: Stuart Fraser < stuart AT stuartfraser DOT net > Revision Changes Path 1.3 +58 -21 src/sys/dev/mii/ip1000phy.c 1.2 +45 -0 src/sys/dev/mii/ip1000phyreg.h 1.52 +1 -0 src/sys/dev/mii/miidevs From kib at FreeBSD.org Sat Apr 5 04:18:30 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Sat Apr 5 04:18:37 2008 Subject: cvs commit: src/sys/kern kern_conf.c Message-ID: <200804050418.m354ITDJ063308@repoman.freebsd.org> kib 2008-04-05 04:18:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern kern_conf.c Log: MFC rev. 1.211: Add two missed chunks from the rev. 1.210, for the giant_read() and giant_ioctl(). Revision Changes Path 1.208.2.3 +2 -4 src/sys/kern/kern_conf.c From alc at FreeBSD.org Sat Apr 5 05:02:53 2008 From: alc at FreeBSD.org (Alan Cox) Date: Sat Apr 5 05:03:04 2008 Subject: cvs commit: src/sys/vm vm_phys.c Message-ID: <200804050502.m3552rLi074148@repoman.freebsd.org> alc 2008-04-05 05:02:53 UTC FreeBSD src repository Modified files: sys/vm vm_phys.c Log: Eliminate an unnecessary test from vm_phys_unfree_page(). Revision Changes Path 1.8 +1 -1 src/sys/vm/vm_phys.c From nyan at jp.FreeBSD.org Sat Apr 5 05:17:44 2008 From: nyan at jp.FreeBSD.org (Takahashi Yoshihiro) Date: Sat Apr 5 05:17:55 2008 Subject: cvs commit: src/sys/amd64/include clock.h timerreg.h src/sys/amd64/isa clock.c src/sys/dev/speaker spkr.c src/sys/dev/syscons syscons.c src/sys/i386/i386 trap.c src/sys/i386/include clock.h timerreg.h src/sys/i386/isa clock.c ... In-Reply-To: <200803262009.m2QK9MAo082269@repoman.freebsd.org> References: <200803262009.m2QK9MAo082269@repoman.freebsd.org> Message-ID: <20080405.135051.193733780.nyan@jp.FreeBSD.org> In article <200803262009.m2QK9MAo082269@repoman.freebsd.org> Poul-Henning Kamp writes: > In the other function, sc_bell() it seems to get the period from > the KDMKTONE ioctl in terms if 1/1193182th second, so we hardcode > the 1193182 and leave it at that. It's probably not important. PC98 uses the different frequency. It's 1996800 or 2457600. Please see i8254_init(). --- TAKAHASHI Yoshihiro From brde at optusnet.com.au Sat Apr 5 07:53:53 2008 From: brde at optusnet.com.au (Bruce Evans) Date: Sat Apr 5 07:54:02 2008 Subject: cvs commit: src/sys/amd64/include clock.h timerreg.h src/sys/amd64/isa clock.c src/sys/dev/speaker spkr.c src/sys/dev/syscons syscons.c src/sys/i386/i386 trap.c src/sys/i386/include clock.h timerreg.h src/sys/i386/isa clock.c ... In-Reply-To: <20080405.135051.193733780.nyan@jp.FreeBSD.org> References: <200803262009.m2QK9MAo082269@repoman.freebsd.org> <20080405.135051.193733780.nyan@jp.FreeBSD.org> Message-ID: <20080405171736.T4685@besplex.bde.org> On Sat, 5 Apr 2008, Takahashi Yoshihiro wrote: > In article <200803262009.m2QK9MAo082269@repoman.freebsd.org> > Poul-Henning Kamp writes: > >> In the other function, sc_bell() it seems to get the period from >> the KDMKTONE ioctl in terms if 1/1193182th second, so we hardcode >> the 1193182 and leave it at that. It's probably not important. > > PC98 uses the different frequency. It's 1996800 or 2457600. > Please see i8254_init(). The period of 1/1193182th seconds is part of the (broken as designed or implemented) KDMKTONE ioctl and/or the syscons bell escape sequence. Conversion to these units is broken almost everywhere. I use the following fix for this in kbdcontrol (except I actually use visual bell since I can't hear either bell without hearing aids. With hearing aids, I can hear the non-broken bell at 800 Hz but not the broken bell at 1193182/800 = 1491 Hz). IIRC, the default is a broken bell, with sc->bell_pitch = BELL_PITCH = 800. 800 is correct for the pitch, but it is passed without conversion to sysbeep(pitch, period), and sysbeep()'s pitch arg is actually the period in IBM-PC-i8254 cycles, while sysbeep()'s period arg actually is a period, but it is the period of the beep and is named better elsewhere as the duration of the beep. This for the i386 sysbeep(). IIRC, alpha and ia64 sysbeep()'s actually expected the pitch arg to be a pitch -- they inverted it and used to panic for division by 0 when the pitch was 0. The pcvt passed a "pitch" of 1493 IBM-PC-i8254 cycles to sysbeep(), so its default was correct. Magic numbers near 800 and 1491 (but rarely ones that actually give exactly 800 Hz) appeared in a few other places. E.g., i386/machdep.c had the the slightly different pitch 880 and scaled it with the slightly wrong scale TIMER_FREQ. The follow change converts to the syscons ABI in kbdcontrol, so that kbdcontrol actually sets the pitch in hertz as documented if the pitch is specified explicitly, but it preserves the broken default of a period of 800 cycles otherwise. (The units for these cycles are supposed to be 1/1193182th seconds, but they are in fact very machine-dependent, with alpha and ia64 inverting them and PC98 having a different timer frequency. 2457600/800 = 3072 Hz would be an even more unusual and harder to hear default beep frequency than 1491 Hz.) % Index: kbdcontrol.c % =================================================================== % RCS file: /home/ncvs/src/usr.sbin/kbdcontrol/kbdcontrol.c,v % retrieving revision 1.47 % diff -u -2 -r1.47 kbdcontrol.c % --- kbdcontrol.c 3 May 2003 21:06:37 -0000 1.47 % +++ kbdcontrol.c 4 May 2003 03:14:51 -0000 % @@ -903,5 +903,5 @@ % set_bell_values(char *opt) % { % - int bell, duration, pitch; % + int bell, duration, period, pitch; % % bell = 0; % @@ -910,10 +910,15 @@ % opt += 6; % } % - if (!strcmp(opt, "visual")) % + if (!strcmp(opt, "visual")) { % bell |= 1; % - else if (!strcmp(opt, "normal")) % - duration = 5, pitch = 800; % + duration = 0, period = 0; /* XXX */ % + } else if (!strcmp(opt, "normal")) % + /* % + * XXX the historical normal "pitch" of 800 Hz is actually % + * a period of 800 IBM-PC-i8254 cycles or 670 usec. % + */ % + duration = 5, period = 800; % else if (!strcmp(opt, "off")) % - duration = 0, pitch = 0; % + duration = 0, period = 0; /* XXX */ % else { % char *v1; % @@ -931,5 +936,17 @@ % } % if (pitch != 0) % - pitch = 1193182 / pitch; /* in Hz */ % + /* % + * XXX the boundary cases are broken. The kernel % + * silently truncates large periods modulo 0x10000 % + * (18.2 msec). I'm not sure what a period of 0 % + * does. % + */ % + period = 1193182 / pitch; /* in i8254 cycles */ % + else % + /* % + * A pitch of 0 should give a period of "infinity" % + * (actually 65535). But be bug for bug compatible. % + */ % + period = 0; % duration /= 10; /* in 10 m sec */ % } % @@ -937,5 +954,5 @@ % ioctl(0, CONS_BELLTYPE, &bell); % if ((bell & ~2) == 0) % - fprintf(stderr, "[=%d;%dB", pitch, duration); % + fprintf(stderr, "[=%d;%dB", period, duration); % } % Bruce From dfr at FreeBSD.org Sat Apr 5 10:26:20 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Sat Apr 5 10:26:26 2008 Subject: cvs commit: src/usr.sbin/btxld btxld.c Message-ID: <200804051026.m35AQKoW099931@repoman.freebsd.org> dfr 2008-04-05 10:26:20 UTC FreeBSD src repository Modified files: usr.sbin/btxld btxld.c Log: Allow for a zero length 'loader'. Revision Changes Path 1.11 +2 -0 src/usr.sbin/btxld/btxld.c From takawata at FreeBSD.org Sat Apr 5 14:21:02 2008 From: takawata at FreeBSD.org (Takanori Watanabe) Date: Sat Apr 5 14:21:05 2008 Subject: cvs commit: src/sys/dev/acpica/Osd OsdSynch.c Message-ID: <200804051421.m35EL2nW026104@repoman.freebsd.org> takawata 2008-04-05 14:21:01 UTC FreeBSD src repository Modified files: sys/dev/acpica/Osd OsdSynch.c Log: GPE lock may recurse on resume path. Revision Changes Path 1.33 +1 -1 src/sys/dev/acpica/Osd/OsdSynch.c From dfr at FreeBSD.org Sat Apr 5 15:03:29 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Sat Apr 5 15:03:34 2008 Subject: cvs commit: src/lib/libstand nfs.c Message-ID: <200804051503.m35F3T9e029253@repoman.freebsd.org> dfr 2008-04-05 15:03:29 UTC FreeBSD src repository Modified files: lib/libstand nfs.c Log: On i386, don't try to do network-type stuff if the device name is'nt pxeN. Revision Changes Path 1.13 +7 -0 src/lib/libstand/nfs.c From ceri at FreeBSD.org Sat Apr 5 15:51:15 2008 From: ceri at FreeBSD.org (Ceri Davies) Date: Sat Apr 5 15:51:26 2008 Subject: cvs commit: src/tools/tools README Message-ID: <200804051551.m35FpFNq031035@repoman.freebsd.org> ceri 2008-04-05 15:51:14 UTC FreeBSD src repository Modified files: tools/tools README Log: Correct typo. Revision Changes Path 1.52 +1 -1 src/tools/tools/README From jhb at FreeBSD.org Sat Apr 5 17:24:45 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Sat Apr 5 17:24:55 2008 Subject: cvs commit: src/sys/dev/de if_de.c Message-ID: <200804051724.m35HOiM3046350@repoman.freebsd.org> jhb 2008-04-05 17:24:44 UTC FreeBSD src repository Modified files: sys/dev/de if_de.c Log: During attach on some de(4) adapters the driver sends out a test packet as part of detecting the media. Explicitly ensure that we don't send it to bpf(4) as bpf(4) isn't setup yet. This worked by accident before the bpf interface stuff was reworked to avoid other races (bpf_peers_present, etc.) but now it needs an explicit check to avoid a panic. MFC after: 3 days PR: kern/120915 Revision Changes Path 1.184 +6 -2 src/sys/dev/de/if_de.c From jhb at freebsd.org Sat Apr 5 18:07:06 2008 From: jhb at freebsd.org (John Baldwin) Date: Sat Apr 5 18:07:16 2008 Subject: cvs commit: src/sys/dev/acpica/Osd OsdSynch.c In-Reply-To: <200804051421.m35EL2nW026104@repoman.freebsd.org> References: <200804051421.m35EL2nW026104@repoman.freebsd.org> Message-ID: <200804051350.20354.jhb@freebsd.org> On Saturday 05 April 2008 10:21:01 am Takanori Watanabe wrote: > takawata 2008-04-05 14:21:01 UTC > > FreeBSD src repository > > Modified files: > sys/dev/acpica/Osd OsdSynch.c > Log: > GPE lock may recurse on resume path. I think there were two PR's for this? I think it was the Global lock that got recursed on in at least one instance rather than the GPE lock too. It would be nice if we could only tag certain ACPI locks with recursion rather than all of them. :( -- John Baldwin From bmah at FreeBSD.org Sat Apr 5 18:11:40 2008 From: bmah at FreeBSD.org (Bruce A. Mah) Date: Sat Apr 5 18:11:46 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml Message-ID: <200804051811.m35IBeOi049251@repoman.freebsd.org> bmah 2008-04-05 18:11:39 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes article.sgml Log: New release notes: ULE default (+MFC), aac(4) >2TB volume support (+MFC), kernel-mode NLM, adduser(8) -M (+MFC), ls(1) -D, nc(1) -O, pkg_sign/pkg_check gone. MFCs noted: textdump(4), cmx(4), uslcom(4), Revision Changes Path 1.1084 +31 -4 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml From bmah at FreeBSD.org Sat Apr 5 18:19:07 2008 From: bmah at FreeBSD.org (Bruce A. Mah) Date: Sat Apr 5 18:19:18 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml Message-ID: <200804051819.m35IJ61U049593@repoman.freebsd.org> bmah 2008-04-05 18:19:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_4) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: MFC: BTX real mode, tzdata2008b. Revision Changes Path 1.22.2.448 +6 -1 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From bz at FreeBSD.org Sat Apr 5 19:40:07 2008 From: bz at FreeBSD.org (Bjoern A. Zeeb) Date: Sat Apr 5 19:40:18 2008 Subject: cvs commit: src/bin/ls ls.1 ls.c ls.h print.c In-Reply-To: <200804040357.m343vlQ8083007@repoman.freebsd.org> References: <200804040357.m343vlQ8083007@repoman.freebsd.org> Message-ID: <20080405193851.J66744@maildrop.int.zabbadoz.net> On Fri, 4 Apr 2008, Greg Lehey wrote: > grog 2008-04-04 03:57:47 UTC > > FreeBSD src repository > > Modified files: > bin/ls ls.1 ls.c ls.h print.c > Log: > Add -D option to specify exact format of date and time output with ls -l. > > Revision Changes Path > 1.101 +28 -6 src/bin/ls/ls.1 > 1.86 +6 -2 src/bin/ls/ls.c > 1.23 +2 -1 src/bin/ls/ls.h > 1.77 +10 -7 src/bin/ls/print.c I think something went wrong here. Could you please fix this. Thanks. bz@dopt:/local/building/freebsd/HEAD/bin/ls> ll total 80 drwxr-xr-x 2 bz wheel 512 Apr 5 15:18 CVS/ -rw-r--r-- 1 bz wheel 300 May 25 2004 Makefile -rw-r--r-- 1 bz wheel 4803 Mar 24 2006 cmp.c -rw-r--r-- 1 bz wheel 2852 Mar 24 2006 extern.h ^^^^ -rw-r--r-- 1 bz wheel 16646 Apr 5 15:18 ls.1 -rw-r--r-- 1 bz wheel 22427 Apr 5 15:18 ls.c -rw-r--r-- 1 bz wheel 3335 Apr 5 15:18 ls.h -rw-r--r-- 1 bz wheel 15078 Apr 5 15:18 print.c -rw-r--r-- 1 bz wheel 5647 Apr 5 15:18 util.c -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT Software is harder than hardware so better get it right the first time. From jhb at FreeBSD.org Sat Apr 5 19:58:30 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Sat Apr 5 19:58:32 2008 Subject: cvs commit: src/sys/amd64/amd64 intr_machdep.c src/sys/arm/arm intr.c src/sys/i386/i386 intr_machdep.c src/sys/ia64/ia64 interrupt.c src/sys/kern kern_intr.c src/sys/powerpc/powerpc intr_machdep.c src/sys/sparc64/sparc64 intr_machdep.c ... Message-ID: <200804051958.m35JwUhb054031@repoman.freebsd.org> jhb 2008-04-05 19:58:30 UTC FreeBSD src repository Modified files: sys/amd64/amd64 intr_machdep.c sys/arm/arm intr.c sys/i386/i386 intr_machdep.c sys/ia64/ia64 interrupt.c sys/kern kern_intr.c sys/powerpc/powerpc intr_machdep.c sys/sparc64/sparc64 intr_machdep.c sys/sun4v/sun4v intr_machdep.c sys/sys interrupt.h Log: Add a MI intr_event_handle() routine for the non-INTR_FILTER case. This allows all the INTR_FILTER #ifdef's to be removed from the MD interrupt code. - Rename the intr_event 'eoi', 'disable', and 'enable' hooks to 'post_filter', 'pre_ithread', and 'post_ithread' to be less x86-centric. Also, add a comment describe what the MI code expects them to do. - On amd64, i386, and powerpc this is effectively a NOP. - On arm, don't bother masking the interrupt unless the ithread is scheduled in the non-INTR_FILTER case to match what INTR_FILTER did. Also, don't bother unmasking the interrupt in the post_filter case if we never masked it. The INTR_FILTER case had been doing this by having arm_unmask_irq for the post_filter (formerly 'eoi') hook. - On ia64, stray interrupts are now masked for the non-INTR_FILTER case. They were already masked in the INTR_FILTER case. - On sparc64, use the a NULL pre_ithread hook and use intr_enable_eoi() for both the 'post_filter' and 'post_ithread' hooks to match what the non-INTR_FILTER code did. - On sun4v, retire the ithread wrapper hack by using an appropriate 'post_ithread' hook instead (it's what 'post_ithread'/'enable' was designed to do even in 5.x). Glanced at by: piso Reviewed by: marius Requested by: marius [1], [5] Tested on: amd64, i386, arm, sparc64 Revision Changes Path 1.40 +2 -111 src/sys/amd64/amd64/intr_machdep.c 1.20 +3 -43 src/sys/arm/arm/intr.c 1.35 +2 -121 src/sys/i386/i386/intr_machdep.c 1.65 +4 -46 src/sys/ia64/ia64/interrupt.c 1.160 +105 -21 src/sys/kern/kern_intr.c 1.20 +1 -45 src/sys/powerpc/powerpc/intr_machdep.c 1.31 +3 -51 src/sys/sparc64/sparc64/intr_machdep.c 1.10 +14 -79 src/sys/sun4v/sun4v/intr_machdep.c 1.40 +34 -17 src/sys/sys/interrupt.h From jhb at FreeBSD.org Sat Apr 5 20:13:17 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Sat Apr 5 20:13:27 2008 Subject: cvs commit: src/sys/conf options src/sys/dev/asmc asmc.c src/sys/kern kern_intr.c Message-ID: <200804052013.m35KDGJ0055725@repoman.freebsd.org> jhb 2008-04-05 20:13:15 UTC FreeBSD src repository Modified files: sys/conf options sys/dev/asmc asmc.c sys/kern kern_intr.c Log: Move INTR_FILTER from opt_global.h to its own header. Revision Changes Path 1.624 +1 -1 src/sys/conf/options 1.3 +2 -0 src/sys/dev/asmc/asmc.c 1.161 +1 -0 src/sys/kern/kern_intr.c From antoine at FreeBSD.org Sat Apr 5 20:36:21 2008 From: antoine at FreeBSD.org (Antoine Brodin) Date: Sat Apr 5 20:36:24 2008 Subject: cvs commit: src/bin/ls ls.1 ls.c ls.h print.c In-Reply-To: <20080405193851.J66744@maildrop.int.zabbadoz.net> References: <200804040357.m343vlQ8083007@repoman.freebsd.org> <20080405193851.J66744@maildrop.int.zabbadoz.net> Message-ID: On Sat, Apr 5, 2008 at 9:40 PM, Bjoern A. Zeeb wrote: > On Fri, 4 Apr 2008, Greg Lehey wrote: > > grog 2008-04-04 03:57:47 UTC > > > > FreeBSD src repository > > > > Modified files: > > bin/ls ls.1 ls.c ls.h print.c > > Log: > > Add -D option to specify exact format of date and time output with ls -l. > > > > Revision Changes Path > > 1.101 +28 -6 src/bin/ls/ls.1 > > 1.86 +6 -2 src/bin/ls/ls.c > > 1.23 +2 -1 src/bin/ls/ls.h > > 1.77 +10 -7 src/bin/ls/print.c > > > > I think something went wrong here. Could you please fix this. Thanks. > > bz@dopt:/local/building/freebsd/HEAD/bin/ls> ll > total 80 > drwxr-xr-x 2 bz wheel 512 Apr 5 15:18 CVS/ > -rw-r--r-- 1 bz wheel 300 May 25 2004 Makefile > -rw-r--r-- 1 bz wheel 4803 Mar 24 2006 cmp.c > -rw-r--r-- 1 bz wheel 2852 Mar 24 2006 extern.h > ^^^^ > -rw-r--r-- 1 bz wheel 16646 Apr 5 15:18 ls.1 > -rw-r--r-- 1 bz wheel 22427 Apr 5 15:18 ls.c > -rw-r--r-- 1 bz wheel 3335 Apr 5 15:18 ls.h > -rw-r--r-- 1 bz wheel 15078 Apr 5 15:18 print.c > -rw-r--r-- 1 bz wheel 5647 Apr 5 15:18 util.c The problem is that there is a tab instead of a space lines 171 and 391 of print.c Cheers, Antoine From emaste at freebsd.org Sat Apr 5 20:46:02 2008 From: emaste at freebsd.org (Ed Maste) Date: Sat Apr 5 20:46:07 2008 Subject: cvs commit: src/sys/dev/acpica/Osd OsdSynch.c In-Reply-To: <200804051350.20354.jhb@freebsd.org> References: <200804051421.m35EL2nW026104@repoman.freebsd.org> <200804051350.20354.jhb@freebsd.org> Message-ID: <20080405203400.GA89620@sandvine.com> On Sat, Apr 05, 2008 at 01:50:20PM -0400, John Baldwin wrote: > On Saturday 05 April 2008 10:21:01 am Takanori Watanabe wrote: > > takawata 2008-04-05 14:21:01 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/acpica/Osd OsdSynch.c > > Log: > > GPE lock may recurse on resume path. > > I think there were two PR's for this? I think it was the Global lock that got > recursed on in at least one instance rather than the GPE lock too. It would > be nice if we could only tag certain ACPI locks with recursion rather than > all of them. :( The PRs I'm aware of are kern/114649 and kern/114113. -Ed From imp at FreeBSD.org Sat Apr 5 21:26:28 2008 From: imp at FreeBSD.org (Warner Losh) Date: Sat Apr 5 21:26:40 2008 Subject: cvs commit: src/bin/ls print.c Message-ID: <200804052126.m35LQR4Z068588@repoman.freebsd.org> imp 2008-04-05 21:26:25 UTC FreeBSD src repository Modified files: bin/ls print.c Log: Turn a tab into a space. This fixes a misalignment for ls -l. Tabs Noticed by: Antoine Brodin Revision Changes Path 1.78 +2 -2 src/bin/ls/print.c From cognet at FreeBSD.org Sat Apr 5 21:51:12 2008 From: cognet at FreeBSD.org (Olivier Houchard) Date: Sat Apr 5 21:51:22 2008 Subject: cvs commit: src/sys/arm/xscale/i8134x files.i81342 Message-ID: <200804052151.m35LpBE2069539@repoman.freebsd.org> cognet 2008-04-05 21:51:11 UTC FreeBSD src repository Modified files: sys/arm/xscale/i8134x files.i81342 Log: Add bus_space_generic.c for the i81342 as well. Revision Changes Path 1.2 +1 -0 src/sys/arm/xscale/i8134x/files.i81342 From cognet at FreeBSD.org Sat Apr 5 21:57:12 2008 From: cognet at FreeBSD.org (Olivier Houchard) Date: Sat Apr 5 21:57:19 2008 Subject: cvs commit: src/sys/arm/xscale/i80321 files.ep80219 files.iq31244 src/sys/arm/xscale/ixp425 files.avila Message-ID: <200804052157.m35LvBpt069761@repoman.freebsd.org> cognet 2008-04-05 21:57:11 UTC FreeBSD src repository Modified files: sys/arm/xscale/i80321 files.ep80219 files.iq31244 sys/arm/xscale/ixp425 files.avila Log: Remove bus_space_generic.c from the per-plarform files. Having it in the per-cpu files should be enough. Revision Changes Path 1.3 +0 -1 src/sys/arm/xscale/i80321/files.ep80219 1.4 +0 -1 src/sys/arm/xscale/i80321/files.iq31244 1.4 +0 -1 src/sys/arm/xscale/ixp425/files.avila From grog at FreeBSD.org Sun Apr 6 00:07:01 2008 From: grog at FreeBSD.org (Greg 'groggy' Lehey) Date: Sun Apr 6 00:07:06 2008 Subject: cvs commit: src/bin/ls ls.1 ls.c ls.h print.c In-Reply-To: <20080405193851.J66744@maildrop.int.zabbadoz.net> References: <200804040357.m343vlQ8083007@repoman.freebsd.org> <20080405193851.J66744@maildrop.int.zabbadoz.net> Message-ID: <20080405234758.GB27705@dereel.lemis.com> On Saturday, 5 April 2008 at 19:40:02 +0000, Bjoern A. Zeeb wrote: > On Fri, 4 Apr 2008, Greg Lehey wrote: > >> grog 2008-04-04 03:57:47 UTC >> >> FreeBSD src repository >> >> Modified files: >> bin/ls ls.1 ls.c ls.h print.c >> Log: >> Add -D option to specify exact format of date and time output with ls -l. > > I think something went wrong here. Could you please fix this. Thanks. > > bz@dopt:/local/building/freebsd/HEAD/bin/ls> ll > total 80 > drwxr-xr-x 2 bz wheel 512 Apr 5 15:18 CVS/ > -rw-r--r-- 1 bz wheel 300 May 25 2004 Makefile > -rw-r--r-- 1 bz wheel 4803 Mar 24 2006 cmp.c > -rw-r--r-- 1 bz wheel 2852 Mar 24 2006 extern.h Ugh. My editor was a little too zealous in replacing spaces with tabs :-( Done. Greg -- See complete headers for address and phone numbers. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080406/e92dda59/attachment.pgp From cokane at FreeBSD.org Sun Apr 6 00:58:00 2008 From: cokane at FreeBSD.org (Coleman Kane) Date: Sun Apr 6 00:58:03 2008 Subject: cvs commit: src/bin/ls ls.1 ls.c ls.h print.c In-Reply-To: <20080405234758.GB27705@dereel.lemis.com> References: <200804040357.m343vlQ8083007@repoman.freebsd.org> <20080405193851.J66744@maildrop.int.zabbadoz.net> <20080405234758.GB27705@dereel.lemis.com> Message-ID: <47F81C48.1040103@FreeBSD.org> Greg 'groggy' Lehey wrote: > On Saturday, 5 April 2008 at 19:40:02 +0000, Bjoern A. Zeeb wrote: > >> On Fri, 4 Apr 2008, Greg Lehey wrote: >> >> >>> grog 2008-04-04 03:57:47 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> bin/ls ls.1 ls.c ls.h print.c >>> Log: >>> Add -D option to specify exact format of date and time output with ls -l. >>> >> I think something went wrong here. Could you please fix this. Thanks. >> >> bz@dopt:/local/building/freebsd/HEAD/bin/ls> ll >> total 80 >> drwxr-xr-x 2 bz wheel 512 Apr 5 15:18 CVS/ >> -rw-r--r-- 1 bz wheel 300 May 25 2004 Makefile >> -rw-r--r-- 1 bz wheel 4803 Mar 24 2006 cmp.c >> -rw-r--r-- 1 bz wheel 2852 Mar 24 2006 extern.h >> > > Ugh. My editor was a little too zealous in replacing spaces with tabs :-( > > Done. > > Greg > -- > See complete headers for address and phone numbers. > Uhm.... shouldn't this be "\t" instead of the actualy tab character (0x08)? -- Coleman From bmah at FreeBSD.org Sun Apr 6 05:19:23 2008 From: bmah at FreeBSD.org (Bruce A. Mah) Date: Sun Apr 6 05:19:29 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml Message-ID: <200804060519.m365JM1s014103@repoman.freebsd.org> bmah 2008-04-06 05:19:21 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) release/doc/en_US.ISO8859-1/relnotes article.sgml Log: MFC: textdumps, ULE default scheduler, cmx(4), uslcom(4), aac(4) >2TB volume support, adduser(8) -M, ypserv(8) -P. Revision Changes Path 1.1068.2.24 +29 -1 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml From bmah at FreeBSD.org Sun Apr 6 05:34:17 2008 From: bmah at FreeBSD.org (Bruce A. Mah) Date: Sun Apr 6 05:34:26 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml Message-ID: <200804060534.m365YH7P014601@repoman.freebsd.org> bmah 2008-04-06 05:34:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: MFC: BTX real mode, tzdata2008b, GNOME 2.22. Revision Changes Path 1.883.2.91 +13 -4 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From grog at FreeBSD.org Sun Apr 6 05:36:57 2008 From: grog at FreeBSD.org (Greg 'groggy' Lehey) Date: Sun Apr 6 05:37:03 2008 Subject: cvs commit: src/bin/ls ls.1 ls.c ls.h print.c In-Reply-To: <47F81C48.1040103@FreeBSD.org> References: <200804040357.m343vlQ8083007@repoman.freebsd.org> <20080405193851.J66744@maildrop.int.zabbadoz.net> <20080405234758.GB27705@dereel.lemis.com> <47F81C48.1040103@FreeBSD.org> Message-ID: <20080406053648.GC27705@dereel.lemis.com> On Saturday, 5 April 2008 at 20:41:44 -0400, Coleman Kane wrote: > Greg 'groggy' Lehey wrote: >> On Saturday, 5 April 2008 at 19:40:02 +0000, Bjoern A. Zeeb wrote: >> >>> On Fri, 4 Apr 2008, Greg Lehey wrote: >>> >>> >>>> grog 2008-04-04 03:57:47 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> bin/ls ls.1 ls.c ls.h print.c >>>> Log: >>>> Add -D option to specify exact format of date and time output with ls -l. >>>> >>> I think something went wrong here. Could you please fix this. Thanks. >>> >>> bz@dopt:/local/building/freebsd/HEAD/bin/ls> ll >>> total 80 >>> drwxr-xr-x 2 bz wheel 512 Apr 5 15:18 CVS/ >>> -rw-r--r-- 1 bz wheel 300 May 25 2004 Makefile >>> -rw-r--r-- 1 bz wheel 4803 Mar 24 2006 cmp.c >>> -rw-r--r-- 1 bz wheel 2852 Mar 24 2006 extern.h >>> >> >> Ugh. My editor was a little too zealous in replacing spaces with tabs :-( > > Uhm.... shouldn't this be "\t" instead of the actualy tab character > (0x08)? No. It should be two spaces. Here's the diff :-) --- print.c 4 Apr 2008 03:57:46 -0000 1.77 +++ print.c 5 Apr 2008 23:44:24 -0000 @@ -388,7 +388,7 @@ format = d_first ? "%e %b %R" : "%b %e %R"; else /* mmm dd yyyy || dd mmm yyyy */ - format = d_first ? "%e %b %Y" : "%b %e %Y"; + format = d_first ? "%e %b %Y" : "%b %e %Y"; strftime(longstring, sizeof(longstring), format, localtime(&ftime)); For reasons lost in the mists of time, there are two spaces before the %Y in this format, but my editor accidentally replaced them with a tab character. As you can see, that's not immediately obvious. Greg -- See complete headers for address and phone numbers. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080406/a5f97d8b/attachment.pgp From bmah at FreeBSD.org Sun Apr 6 05:44:12 2008 From: bmah at FreeBSD.org (Bruce A. Mah) Date: Sun Apr 6 05:44:19 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml Message-ID: <200804060544.m365iBXU014901@repoman.freebsd.org> bmah 2008-04-06 05:44:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: MFC: BTX real mode, GNOME 2.22. Bump copyright date while here. Revision Changes Path 1.761.2.87 +7 -2 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From kib at FreeBSD.org Sun Apr 6 10:02:21 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Sun Apr 6 10:02:27 2008 Subject: cvs commit: src/sys/sys vnode.h src/sys/kern vfs_mount.c src/sys/ufs/ffs ffs_softdep.c Message-ID: <200804061002.m36A2Kj7040855@repoman.freebsd.org> kib 2008-04-06 10:02:20 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/sys vnode.h sys/kern vfs_mount.c sys/ufs/ffs ffs_softdep.c Log: MFC rev. 1.277 of sys/kern/vfs_mount.c rev. 1.332 of sys/sys/vnode.h rev. 1.222 of sys/ufs/ffs/ffs_softdep.c Yield the cpu in the kernel while iterating the list of the vnodes belonging to the mountpoint. Also, yield when in the softdep_process_worklist() even when we are not going to sleep due to buffer drain. Revision Changes Path 1.265.2.3 +6 -0 src/sys/kern/vfs_mount.c 1.326.2.1 +2 -0 src/sys/sys/vnode.h 1.211.2.2 +1 -0 src/sys/ufs/ffs/ffs_softdep.c From jeff at FreeBSD.org Sun Apr 6 11:08:49 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Sun Apr 6 11:08:56 2008 Subject: cvs commit: src/sys/kern kern_timeout.c Message-ID: <200804061108.m36B8nuB045282@repoman.freebsd.org> jeff 2008-04-06 11:08:49 UTC FreeBSD src repository Modified files: sys/kern kern_timeout.c Log: - Correct a major error introduced in the per-cpu timeout commit. Sleep and wakeup require the same wait channel to function properly. Found by: kris Pointy hat: me Revision Changes Path 1.113 +5 -5 src/sys/kern/kern_timeout.c From cokane at FreeBSD.org Sun Apr 6 13:48:58 2008 From: cokane at FreeBSD.org (Coleman Kane) Date: Sun Apr 6 13:49:04 2008 Subject: cvs commit: src/bin/ls ls.1 ls.c ls.h print.c In-Reply-To: <20080406053648.GC27705@dereel.lemis.com> References: <200804040357.m343vlQ8083007@repoman.freebsd.org> <20080405193851.J66744@maildrop.int.zabbadoz.net> <20080405234758.GB27705@dereel.lemis.com> <47F81C48.1040103@FreeBSD.org> <20080406053648.GC27705@dereel.lemis.com> Message-ID: <47F8D4BD.1020901@FreeBSD.org> Greg 'groggy' Lehey wrote: > On Saturday, 5 April 2008 at 20:41:44 -0400, Coleman Kane wrote: > >> Greg 'groggy' Lehey wrote: >> >>> On Saturday, 5 April 2008 at 19:40:02 +0000, Bjoern A. Zeeb wrote: >>> >>> >>>> On Fri, 4 Apr 2008, Greg Lehey wrote: >>>> >>>> >>>> >>>>> grog 2008-04-04 03:57:47 UTC >>>>> >>>>> FreeBSD src repository >>>>> >>>>> Modified files: >>>>> bin/ls ls.1 ls.c ls.h print.c >>>>> Log: >>>>> Add -D option to specify exact format of date and time output with ls -l. >>>>> >>>>> >>>> I think something went wrong here. Could you please fix this. Thanks. >>>> >>>> bz@dopt:/local/building/freebsd/HEAD/bin/ls> ll >>>> total 80 >>>> drwxr-xr-x 2 bz wheel 512 Apr 5 15:18 CVS/ >>>> -rw-r--r-- 1 bz wheel 300 May 25 2004 Makefile >>>> -rw-r--r-- 1 bz wheel 4803 Mar 24 2006 cmp.c >>>> -rw-r--r-- 1 bz wheel 2852 Mar 24 2006 extern.h >>>> >>>> >>> Ugh. My editor was a little too zealous in replacing spaces with tabs :-( >>> >> Uhm.... shouldn't this be "\t" instead of the actualy tab character >> (0x08)? >> > > No. It should be two spaces. > > Here's the diff :-) > > --- print.c 4 Apr 2008 03:57:46 -0000 1.77 > +++ print.c 5 Apr 2008 23:44:24 -0000 > @@ -388,7 +388,7 @@ > format = d_first ? "%e %b %R" : "%b %e %R"; > else > /* mmm dd yyyy || dd mmm yyyy */ > - format = d_first ? "%e %b %Y" : "%b %e %Y"; > + format = d_first ? "%e %b %Y" : "%b %e %Y"; > strftime(longstring, sizeof(longstring), format, localtime(&ftime)); > > For reasons lost in the mists of time, there are two spaces before the > %Y in this format, but my editor accidentally replaced them with a tab > character. As you can see, that's not immediately obvious. > > Greg > -- > See complete headers for address and phone numbers. > Oh heh. I had a dyslexic moment there (I read "tabs with spaces"). Nevermind. -- Coleman From dfr at FreeBSD.org Sun Apr 6 13:52:18 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Sun Apr 6 13:52:25 2008 Subject: cvs commit: src/usr.sbin/rpc.statd statd.c src/usr.sbin/rpc.lockd lockd.c Message-ID: <200804061352.m36DqHS0063772@repoman.freebsd.org> dfr 2008-04-06 13:52:17 UTC FreeBSD src repository Modified files: usr.sbin/rpc.statd statd.c usr.sbin/rpc.lockd lockd.c Log: Call listen(2) on bound tcp sockets before passing them to svc_tli_create. Revision Changes Path 1.26 +3 -0 src/usr.sbin/rpc.lockd/lockd.c 1.18 +3 -0 src/usr.sbin/rpc.statd/statd.c From rwatson at FreeBSD.org Sun Apr 6 14:03:58 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sun Apr 6 14:04:05 2008 Subject: cvs commit: src/sys/security/audit audit_worker.c Message-ID: <200804061403.m36E3v37065348@repoman.freebsd.org> rwatson 2008-04-06 14:03:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/security/audit audit_worker.c Log: Merge audit_worker.c:1.20 from HEAD to RELENG_7: Replace somewhat awkward audit trail rotation scheme, which involved the global audit mutex and condition variables, with an sx lock which protects the trail vnode and credential while in use, and is acquired by the system call code when rotating the trail. Previously, a "message" would be sent to the kernel audit worker, which did the rotation, but the new code is simpler and (hopefully) less error-prone. Obtained from: TrustedBSD Project Revision Changes Path 1.16.2.2 +106 -171 src/sys/security/audit/audit_worker.c From rwatson at FreeBSD.org Sun Apr 6 15:01:42 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sun Apr 6 15:01:53 2008 Subject: cvs commit: src/sys/security/audit audit_trigger.c Message-ID: <200804061501.m36F1f85080192@repoman.freebsd.org> rwatson 2008-04-06 15:01:41 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/security/audit audit_trigger.c Log: Merge audit_trigger.c:1.7 from HEAD to RELENG_7: Rather than copying out the full audit trigger record, which includes a queue entry field, just copy out the unsigned int that is the trigger message. In practice, auditd always requested sizeof(unsigned int), so the extra bytes were ignored, but copying them out was not the intent. Revision Changes Path 1.5.2.1 +1 -1 src/sys/security/audit/audit_trigger.c From mav at FreeBSD.org Sun Apr 6 15:26:33 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Sun Apr 6 15:26:39 2008 Subject: cvs commit: src/sys/netgraph ng_base.c Message-ID: <200804061526.m36FQWid082581@repoman.freebsd.org> mav 2008-04-06 15:26:32 UTC FreeBSD src repository Modified files: sys/netgraph ng_base.c Log: Rewrite node's r/w/q-lock semantics using only atomics instead of mutex and atomics combination. Mutex is now used only for queue protection. Also avoid unneded extra swi scheduling calls. Revision Changes Path 1.155 +76 -247 src/sys/netgraph/ng_base.c From rwatson at FreeBSD.org Sun Apr 6 15:57:19 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sun Apr 6 15:57:26 2008 Subject: cvs commit: src/sys/security/audit audit_private.h audit_syscalls.c audit_trigger.c audit_worker.c Message-ID: <200804061557.m36FvIN4083613@repoman.freebsd.org> rwatson 2008-04-06 15:57:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/security/audit audit_private.h audit_syscalls.c audit_trigger.c audit_worker.c Log: Merge audit_private.h:1.18, audit_syscalls.c:1.24, audit_trigger.c:1.6, audit_worker.c:1.21 from HEAD to RELENG_7: Rename globally exposed symbol send_trigger() to audit_send_trigger(). Revision Changes Path 1.16.2.1 +1 -1 src/sys/security/audit/audit_private.h 1.21.2.2 +1 -1 src/sys/security/audit/audit_syscalls.c 1.5.2.2 +1 -1 src/sys/security/audit/audit_trigger.c 1.16.2.3 +4 -3 src/sys/security/audit/audit_worker.c From bz at FreeBSD.org Sun Apr 6 17:00:08 2008 From: bz at FreeBSD.org (Bjoern A. Zeeb) Date: Sun Apr 6 17:00:17 2008 Subject: cvs commit: src/etc/rc.d ppp src/share/man/man5 rc.conf.5 In-Reply-To: <200803280757.m2S7vqvN037009@repoman.freebsd.org> References: <200803280757.m2S7vqvN037009@repoman.freebsd.org> Message-ID: <20080406165513.N66744@maildrop.int.zabbadoz.net> On Fri, 28 Mar 2008, Brooks Davis wrote: > brooks 2008-03-28 07:57:52 UTC > > FreeBSD src repository > > Modified files: > etc/rc.d ppp > share/man/man5 rc.conf.5 > Log: > Add support for hardwiring ppp sessions to particular devices with new > per-profile variables of the form ppp__unit. No ppp_unit > variable is supported since tying the same unit to more than one profile > won't work. > > PR: conf/122127 > MFC after: 1 week There is a bug in there: + # Check for hard wired unit + eval _ppp_unit=\$ppp_${_ppp_profile_cleaned}_unit + if [ -n "_ppp_unit" ]; then ^^^^^^^^^^^ should ${_ppp_unit} + _ppp_unit="-unit${_ppp_unit}" + fi + rc_flags="$rc_flags $_ppp_unit" > Revision Changes Path > 1.18 +8 -1 src/etc/rc.d/ppp > 1.337 +9 -1 src/share/man/man5/rc.conf.5 -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT Software is harder than hardware so better get it right the first time. From syrinx at FreeBSD.org Sun Apr 6 17:49:37 2008 From: syrinx at FreeBSD.org (Shteryana Shopova) Date: Sun Apr 6 17:49:45 2008 Subject: cvs commit: src/contrib/bsnmp/snmpd main.c Message-ID: <200804061749.m36HnbpZ099330@repoman.freebsd.org> syrinx 2008-04-06 17:49:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) contrib/bsnmp/snmpd main.c Log: MFC: src/contrib/bsnmp/snmpd/main.c: Revision 1.1.1.14 Vendor patch: Prevent bsnmpd from dumping core when a module's init hook returns an error. Approved by: bz (mentor) Revision Changes Path 1.1.1.8.2.3 +2 -0 src/contrib/bsnmp/snmpd/main.c From alc at FreeBSD.org Sun Apr 6 18:09:29 2008 From: alc at FreeBSD.org (Alan Cox) Date: Sun Apr 6 18:09:35 2008 Subject: cvs commit: src/sys/vm vm_page.c vm_phys.c vm_reserv.c vm_reserv.h Message-ID: <200804061809.m36I9SWA001722@repoman.freebsd.org> alc 2008-04-06 18:09:28 UTC FreeBSD src repository Modified files: sys/vm vm_page.c vm_phys.c vm_reserv.c vm_reserv.h Log: Introduce vm_reserv_reclaim_contig(). This function is used by contigmalloc(9) as a last resort to steal pages from an inactive, partially-used superpage reservation. Rename vm_reserv_reclaim() to vm_reserv_reclaim_inactive() and refactor it so that a separate subroutine is responsible for breaking the selected reservation. This subroutine is also used by vm_reserv_reclaim_contig(). Revision Changes Path 1.369 +1 -1 src/sys/vm/vm_page.c 1.9 +8 -0 src/sys/vm/vm_phys.c 1.2 +85 -22 src/sys/vm/vm_reserv.c 1.2 +5 -2 src/sys/vm/vm_reserv.h From bz at FreeBSD.org Sun Apr 6 19:20:16 2008 From: bz at FreeBSD.org (Bjoern A. Zeeb) Date: Sun Apr 6 19:20:26 2008 Subject: cvs commit: CVSROOT access Message-ID: <200804061920.m36JKFdV007928@repoman.freebsd.org> bz 2008-04-06 19:20:15 UTC FreeBSD src repository Modified files: . access Log: Forced commit to note that syrinx is no longer under mentorship. Approved by: core (implicit) Revision Changes Path 1.868 +0 -0 CVSROOT/access From attilio at FreeBSD.org Sun Apr 6 20:08:51 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Sun Apr 6 20:08:57 2008 Subject: cvs commit: src/sys/fs/unionfs union_subr.c src/sys/kern kern_lock.c src/sys/sys _lockmgr.h _stack.h lockmgr.h proc.h sleepqueue.h stack.h vnode.h src/sys/ufs/ffs ffs_softdep.c Message-ID: <200804062008.m36K8prN014344@repoman.freebsd.org> attilio 2008-04-06 20:08:51 UTC FreeBSD src repository Modified files: sys/fs/unionfs union_subr.c sys/kern kern_lock.c sys/sys lockmgr.h proc.h sleepqueue.h stack.h vnode.h sys/ufs/ffs ffs_softdep.c Added files: sys/sys _lockmgr.h _stack.h Log: Optimize lockmgr in order to get rid of the pool mutex interlock, of the state transitioning flags and of msleep(9) callings. Use, instead, an algorithm very similar to what sx(9) and rwlock(9) alredy do and direct accesses to the sleepqueue(9) primitive. In order to avoid writer starvation a mechanism very similar to what rwlock(9) uses now is implemented, with the correspective per-thread shared lockmgrs counter. This patch also adds 2 new functions to lockmgr KPI: lockmgr_rw() and lockmgr_args_rw(). These two are like the 2 "normal" versions, but they both accept a rwlock as interlock. In order to realize this, the general lockmgr manager function "__lockmgr_args()" has been implemented through the generic lock layer. It supports all the blocking primitives, but currently only these 2 mappers live. The patch drops the support for WITNESS atm, but it will be probabilly added soon. Also, there is a little race in the draining code which is also present in the current CVS stock implementation: if some sharers, once they wakeup, are in the runqueue they can contend the lock with the exclusive drainer. This is hard to be fixed but the now committed code mitigate this issue a lot better than the (past) CVS version. In addition assertive KA_HELD and KA_UNHELD have been made mute assertions because they are dangerous and they will be nomore supported soon. In order to avoid namespace pollution, stack.h is splitted into two parts: one which includes only the "struct stack" definition (_stack.h) and one defining the KPI. In this way, newly added _lockmgr.h can just include _stack.h. Kernel ABI results heavilly changed by this commit (the now committed version of "struct lock" is a lot smaller than the previous one) and KPI results broken by lockmgr_rw() / lockmgr_args_rw() introduction, so manpages and __FreeBSD_version will be updated accordingly. Tested by: kris, pho, jeff, danger Reviewed by: jeff Sponsored by: Google, Summer of Code program 2007 Revision Changes Path 1.100 +4 -5 src/sys/fs/unionfs/union_subr.c 1.128 +809 -627 src/sys/kern/kern_lock.c 1.1 +49 -0 src/sys/sys/_lockmgr.h (new) 1.1 +39 -0 src/sys/sys/_stack.h (new) 1.68 +137 -188 src/sys/sys/lockmgr.h 1.510 +2 -1 src/sys/sys/proc.h 1.14 +1 -0 src/sys/sys/sleepqueue.h 1.5 +1 -6 src/sys/sys/stack.h 1.335 +4 -2 src/sys/sys/vnode.h 1.223 +2 -2 src/sys/ufs/ffs/ffs_softdep.c From attilio at FreeBSD.org Sun Apr 6 20:27:56 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Sun Apr 6 20:28:02 2008 Subject: cvs commit: src/sys/sys param.h Message-ID: <200804062027.m36KRtuL015089@repoman.freebsd.org> attilio 2008-04-06 20:27:55 UTC FreeBSD src repository Modified files: sys/sys param.h Log: Bump __FreeBSD_version in order to reflect lockmgr_rw() and lockmgr_args_rw() introduction. Revision Changes Path 1.347 +1 -1 src/sys/sys/param.h From brooks at FreeBSD.org Sun Apr 6 20:39:33 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Sun Apr 6 20:39:44 2008 Subject: cvs commit: src/etc/rc.d ppp Message-ID: <200804062039.m36KdX6R015520@repoman.freebsd.org> brooks 2008-04-06 20:39:33 UTC FreeBSD src repository Modified files: etc/rc.d ppp Log: Fix a stupid typo. Reviewed by: bz Revision Changes Path 1.19 +1 -1 src/etc/rc.d/ppp From brooks at FreeBSD.org Sun Apr 6 20:40:25 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Sun Apr 6 20:40:52 2008 Subject: cvs commit: src/etc/rc.d ppp Message-ID: <200804062040.m36KeOT7015613@repoman.freebsd.org> brooks 2008-04-06 20:40:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) etc/rc.d ppp Log: Fix a stupid typo. Reported by: bz Revision Changes Path 1.13.2.2 +14 -3 src/etc/rc.d/ppp From rwatson at FreeBSD.org Sun Apr 6 21:20:56 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sun Apr 6 21:21:07 2008 Subject: cvs commit: src/sys/netinet in_pcb.c src/sys/netinet6 in6_pcb.c Message-ID: <200804062120.m36LKutT027033@repoman.freebsd.org> rwatson 2008-04-06 21:20:56 UTC FreeBSD src repository Modified files: sys/netinet in_pcb.c sys/netinet6 in6_pcb.c Log: In in_pcbnotifyall() and in6_pcbnotify(), use LIST_FOREACH_SAFE() and eliminate unnecessary local variable caching of the list head pointer, making the code a bit easier to read. MFC after: 3 weeks Revision Changes Path 1.203 +2 -5 src/sys/netinet/in_pcb.c 1.88 +2 -6 src/sys/netinet6/in6_pcb.c From attilio at FreeBSD.org Sun Apr 6 21:22:12 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Sun Apr 6 21:22:15 2008 Subject: cvs commit: src/share/man/man9 Makefile lock.9 Message-ID: <200804062122.m36LMCmk027166@repoman.freebsd.org> attilio 2008-04-06 21:22:12 UTC FreeBSD src repository Modified files: share/man/man9 Makefile lock.9 Log: Commit manpages for lockmgr_args_rw(9) and lockmgr_rw(9). Revision Changes Path 1.335 +2 -0 src/share/man/man9/Makefile 1.32 +42 -16 src/share/man/man9/lock.9 From kan at FreeBSD.org Sun Apr 6 22:08:17 2008 From: kan at FreeBSD.org (Alexander Kabaev) Date: Sun Apr 6 22:08:23 2008 Subject: cvs commit: src/usr.sbin/rpc.statd statd.c Message-ID: <200804062208.m36M8H6H029732@repoman.freebsd.org> kan 2008-04-06 22:08:17 UTC FreeBSD src repository Modified files: usr.sbin/rpc.statd statd.c Log: Fix apparent mis-paste in previous check-in by author. Revision Changes Path 1.19 +1 -1 src/usr.sbin/rpc.statd/statd.c From truckman at FreeBSD.org Mon Apr 7 00:29:32 2008 From: truckman at FreeBSD.org (Don Lewis) Date: Mon Apr 7 00:29:39 2008 Subject: cvs commit: src/sys/kern vfs_syscalls.c Message-ID: <200804070029.m370TWDH037150@repoman.freebsd.org> truckman 2008-04-07 00:29:32 UTC FreeBSD src repository Modified files: sys/kern vfs_syscalls.c Log: vfs_syscalls.c 1.452 mistakenly swapped the behavior of chown() and lchown(). Revision Changes Path 1.453 +1 -1 src/sys/kern/vfs_syscalls.c From rwatson at FreeBSD.org Mon Apr 7 01:43:31 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Mon Apr 7 01:43:36 2008 Subject: cvs commit: src/sys/net if_loop.c Message-ID: <200804070143.m371hUX0051481@repoman.freebsd.org> rwatson 2008-04-07 01:43:30 UTC FreeBSD src repository Modified files: sys/net if_loop.c Log: Coerce if_loop.c in the general direction of style(9): - Use ANSI function declarations - Remove use of 'register' keyword - Prefer style(9) return parens, white space MFC after: 1 month Revision Changes Path 1.115 +18 -33 src/sys/net/if_loop.c From rwatson at FreeBSD.org Mon Apr 7 02:51:01 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Mon Apr 7 02:51:07 2008 Subject: cvs commit: src/sys/net bpf.c bpf_zerocopy.c bpf_zerocopy.h src/share/man/man4 bpf.4 Message-ID: <200804070251.m372p02x055613@repoman.freebsd.org> rwatson 2008-04-07 02:51:00 UTC FreeBSD src repository Modified files: sys/net bpf.c bpf_zerocopy.c bpf_zerocopy.h share/man/man4 bpf.4 Log: Maintain and observe a ZBUF_FLAG_IMMUTABLE flag on zero-copy BPF buffer kernel descriptors, which is used to allow the buffer currently in the BPF "store" position to be assigned to userspace when it fills, even if userspace hasn't acknowledged the buffer in the "hold" position yet. To implement this, notify the buffer model when a buffer becomes full, and check that the store buffer is writable, not just for it being full, before trying to append new packet data. Shared memory buffers will be assigned to userspace at most once per fill, be it in the store or in the hold position. This removes the restriction that at most one shared memory can by owned by userspace, reducing the chances that userspace will need to call select() after acknowledging one buffer in order to wait for the next buffer when under high load. This more fully realizes the goal of zero system calls in order to process a high-speed packet stream from BPF. Update bpf.4 to reflect that both buffers may be owned by userspace at once; caution against assuming this. Revision Changes Path 1.50 +8 -8 src/share/man/man4/bpf.4 1.191 +50 -10 src/sys/net/bpf.c 1.4 +73 -4 src/sys/net/bpf_zerocopy.c 1.2 +2 -0 src/sys/net/bpf_zerocopy.h From alc at FreeBSD.org Mon Apr 7 07:38:03 2008 From: alc at FreeBSD.org (Alan Cox) Date: Mon Apr 7 07:38:10 2008 Subject: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c Message-ID: <200804070738.m377c3ol081506@repoman.freebsd.org> alc 2008-04-07 07:38:03 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c sys/i386/i386 pmap.c Log: Update pmap_page_wired_mappings() so that it counts 2/4MB page mappings. Revision Changes Path 1.613 +18 -4 src/sys/amd64/amd64/pmap.c 1.615 +18 -4 src/sys/i386/i386/pmap.c From dfr at rabson.org Mon Apr 7 07:59:40 2008 From: dfr at rabson.org (Doug Rabson) Date: Mon Apr 7 07:59:46 2008 Subject: cvs commit: src/usr.sbin/rpc.statd statd.c In-Reply-To: <200804062208.m36M8H6H029732@repoman.freebsd.org> References: <200804062208.m36M8H6H029732@repoman.freebsd.org> Message-ID: <95DD70E3-CC9E-40D3-B1B4-1B5038E76888@rabson.org> On 6 Apr 2008, at 23:08, Alexander Kabaev wrote: > kan 2008-04-06 22:08:17 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/rpc.statd statd.c > Log: > Fix apparent mis-paste in previous check-in by author. Sorry about that - I was porting a patch for RELENG_7 back to HEAD and I clearly forgot to compile the HEAD version :( From rink at FreeBSD.org Mon Apr 7 08:35:32 2008 From: rink at FreeBSD.org (Rink Springer) Date: Mon Apr 7 08:35:35 2008 Subject: cvs commit: src/sys/amd64/conf GENERIC src/sys/i386/conf GENERIC Message-ID: <200804070835.m378ZW1c086972@repoman.freebsd.org> rink 2008-04-07 08:35:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/amd64/conf GENERIC sys/i386/conf GENERIC Log: Add USB->RS232 devices to the GENERIC kernel. imp@ has already done this in HEAD, refer to revision 1.476 of i386/conf/GENERIC and revision 1.486 of amd64/conf/GENERIC. It seems only fair to do the same in RELENG_7. Discussed with: imp Approved by: re (bmah, kensmith) Revision Changes Path 1.484.2.5 +11 -0 src/sys/amd64/conf/GENERIC 1.474.2.5 +11 -0 src/sys/i386/conf/GENERIC From flz at FreeBSD.org Mon Apr 7 10:27:21 2008 From: flz at FreeBSD.org (Florent Thoumie) Date: Mon Apr 7 10:27:34 2008 Subject: cvs commit: src/usr.sbin/pkg_install Makefile src/usr.sbin/pkg_install/add add.h main.c perform.c pkg_add.1 src/usr.sbin/pkg_install/create main.c pkg_create.1 src/usr.sbin/pkg_install/delete main.c perform.c pkg_delete.1 src/usr.sbin/pkg_install/info main.c ... Message-ID: <200804071027.m37ARLxX017587@repoman.freebsd.org> flz 2008-04-07 10:27:21 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.sbin/pkg_install Makefile usr.sbin/pkg_install/add add.h main.c perform.c pkg_add.1 usr.sbin/pkg_install/create main.c pkg_create.1 usr.sbin/pkg_install/delete main.c perform.c pkg_delete.1 usr.sbin/pkg_install/info main.c pkg_info.1 usr.sbin/pkg_install/lib lib.h match.c usr.sbin/pkg_install/version main.c perform.c pkg_version.1 version.h Added files: (Branch: RELENG_7) usr.sbin/pkg_install/updating Makefile main.c pathnames.h pkg_updating.1 Removed files: (Branch: RELENG_7) usr.sbin/pkg_install/sign Makefile README check.c common.c extern.h gzip.c gzip.h main.c pgp.h pgp_check.c pgp_sign.c pkg_sign.1 sha1.c sign.c stand.c stand.h x509.c Log: Synchronize pkg_install with HEAD: - Add pkg_updating, - Remove pkg_sign, - Support for 8-CURRENT, - Style cleanup (__P use), - ... and much more. Revision Changes Path 1.17.2.1 +1 -5 src/usr.sbin/pkg_install/Makefile 1.14.2.1 +1 -0 src/usr.sbin/pkg_install/add/add.h 1.72.2.2 +9 -4 src/usr.sbin/pkg_install/add/main.c 1.80.2.1 +4 -0 src/usr.sbin/pkg_install/add/perform.c 1.71.2.2 +4 -1 src/usr.sbin/pkg_install/add/pkg_add.1 1.40.2.1 +1 -1 src/usr.sbin/pkg_install/create/main.c 1.70.2.1 +0 -0 src/usr.sbin/pkg_install/create/pkg_create.1 1.28.2.1 +1 -1 src/usr.sbin/pkg_install/delete/main.c 1.41.18.1 +1 -1 src/usr.sbin/pkg_install/delete/perform.c 1.31.10.1 +0 -0 src/usr.sbin/pkg_install/delete/pkg_delete.1 1.50.2.1 +1 -1 src/usr.sbin/pkg_install/info/main.c 1.60.2.1 +0 -0 src/usr.sbin/pkg_install/info/pkg_info.1 1.60.2.1 +10 -1 src/usr.sbin/pkg_install/lib/lib.h 1.20.2.1 +57 -11 src/usr.sbin/pkg_install/lib/match.c 1.10.18.1 +0 -16 src/usr.sbin/pkg_install/sign/Makefile (dead) 1.1.26.1 +0 -55 src/usr.sbin/pkg_install/sign/README (dead) 1.2.24.1 +0 -119 src/usr.sbin/pkg_install/sign/check.c (dead) 1.2.24.1 +0 -90 src/usr.sbin/pkg_install/sign/common.c (dead) 1.2.24.1 +0 -100 src/usr.sbin/pkg_install/sign/extern.h (dead) 1.3.24.1 +0 -319 src/usr.sbin/pkg_install/sign/gzip.c (dead) 1.2.24.1 +0 -95 src/usr.sbin/pkg_install/sign/gzip.h (dead) 1.3.2.1 +0 -185 src/usr.sbin/pkg_install/sign/main.c (dead) 1.1.26.1 +0 -25 src/usr.sbin/pkg_install/sign/pgp.h (dead) 1.2.24.1 +0 -196 src/usr.sbin/pkg_install/sign/pgp_check.c (dead) 1.5.18.1 +0 -281 src/usr.sbin/pkg_install/sign/pgp_sign.c (dead) 1.10.10.1 +0 -211 src/usr.sbin/pkg_install/sign/pkg_sign.1 (dead) 1.5.18.1 +0 -230 src/usr.sbin/pkg_install/sign/sha1.c (dead) 1.5.2.1 +0 -150 src/usr.sbin/pkg_install/sign/sign.c (dead) 1.3.2.1 +0 -57 src/usr.sbin/pkg_install/sign/stand.c (dead) 1.2.18.1 +0 -28 src/usr.sbin/pkg_install/sign/stand.h (dead) 1.5.2.1 +0 -428 src/usr.sbin/pkg_install/sign/x509.c (dead) 1.2.2.1 +14 -0 src/usr.sbin/pkg_install/updating/Makefile (new) 1.2.2.1 +259 -0 src/usr.sbin/pkg_install/updating/main.c (new) 1.2.2.1 +17 -0 src/usr.sbin/pkg_install/updating/pathnames.h (new) 1.3.2.1 +88 -0 src/usr.sbin/pkg_install/updating/pkg_updating.1 (new) 1.7.2.1 +1 -1 src/usr.sbin/pkg_install/version/main.c 1.16.2.2 +0 -0 src/usr.sbin/pkg_install/version/perform.c 1.36.2.2 +5 -5 src/usr.sbin/pkg_install/version/pkg_version.1 1.5.2.1 +0 -7 src/usr.sbin/pkg_install/version/version.h From mav at FreeBSD.org Mon Apr 7 10:33:29 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Mon Apr 7 10:33:35 2008 Subject: cvs commit: src/share/man/man4 ng_pptpgre.4 src/sys/netgraph ng_pptpgre.c ng_pptpgre.h Message-ID: <200804071033.m37AXScc017977@repoman.freebsd.org> mav 2008-04-07 10:33:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man4 ng_pptpgre.4 sys/netgraph ng_pptpgre.c ng_pptpgre.h Log: MFC ng_pptpgre.c rev. 1.41-1.42 Rewrite node to support multiple hooks, alike to ng_l2tp, to use one pair of pptpgre and ksocket nodes for all calls between two peers. This patch modifies node's API by adding new "session_%04x" hook names support, while keeping backward compatibility. Revision Changes Path 1.21.2.1 +8 -5 src/share/man/man4/ng_pptpgre.4 1.37.2.3 +281 -261 src/sys/netgraph/ng_pptpgre.c 1.9.2.1 +4 -0 src/sys/netgraph/ng_pptpgre.h From rpaulo at FreeBSD.org Mon Apr 7 11:08:46 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Mon Apr 7 11:10:12 2008 Subject: cvs commit: src/sys/modules/asmc Makefile Message-ID: <200804071108.m37B8jec020284@repoman.freebsd.org> rpaulo 2008-04-07 11:08:45 UTC FreeBSD src repository Modified files: sys/modules/asmc Makefile Log: Add opt_intr_filter.h. Revision Changes Path 1.2 +1 -1 src/sys/modules/asmc/Makefile From rpaulo at FreeBSD.org Mon Apr 7 11:22:13 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Mon Apr 7 11:22:24 2008 Subject: cvs commit: src/sys/dev/asmc asmc.c asmcvar.h Message-ID: <200804071122.m37BMCmW021255@repoman.freebsd.org> rpaulo 2008-04-07 11:22:12 UTC FreeBSD src repository Modified files: sys/dev/asmc asmc.c asmcvar.h Log: The SMC is represented on the acpi tables, so we can completely remove dependency on isa. We are now an acpi child. Also: * Add compile time debugging activation * Increase the delay for the SMS init flag. Revision Changes Path 1.4 +72 -42 src/sys/dev/asmc/asmc.c 1.2 +12 -14 src/sys/dev/asmc/asmcvar.h From rpaulo at FreeBSD.org Mon Apr 7 11:26:13 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Mon Apr 7 11:26:25 2008 Subject: cvs commit: src/sys/modules/asmc Makefile Message-ID: <200804071126.m37BQDPf021550@repoman.freebsd.org> rpaulo 2008-04-07 11:26:13 UTC FreeBSD src repository Modified files: sys/modules/asmc Makefile Log: Remove isa_if.h. Revision Changes Path 1.3 +1 -1 src/sys/modules/asmc/Makefile From rpaulo at FreeBSD.org Mon Apr 7 11:27:17 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Mon Apr 7 11:27:35 2008 Subject: cvs commit: src/share/man/man4 asmc.4 Message-ID: <200804071127.m37BRG0W021601@repoman.freebsd.org> rpaulo 2008-04-07 11:27:16 UTC FreeBSD src repository Modified files: share/man/man4 asmc.4 Log: Change the EXAMPLE section to reflect reality (ISA -> ACPI). Revision Changes Path 1.4 +3 -3 src/share/man/man4/asmc.4 From flz at FreeBSD.org Mon Apr 7 11:32:02 2008 From: flz at FreeBSD.org (Florent Thoumie) Date: Mon Apr 7 11:32:14 2008 Subject: cvs commit: src/usr.sbin/pkg_install Makefile src/usr.sbin/pkg_install/add add.h extract.c main.c perform.c pkg_add.1 src/usr.sbin/pkg_install/create create.h main.c perform.c pkg_create.1 pl.c src/usr.sbin/pkg_install/delete main.c perform.c ... Message-ID: <200804071132.m37BW1te022080@repoman.freebsd.org> flz 2008-04-07 11:32:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/pkg_install Makefile usr.sbin/pkg_install/add add.h extract.c main.c perform.c pkg_add.1 usr.sbin/pkg_install/create create.h main.c perform.c pkg_create.1 pl.c usr.sbin/pkg_install/delete main.c perform.c pkg_delete.1 usr.sbin/pkg_install/info info.h main.c perform.c pkg_info.1 show.c usr.sbin/pkg_install/lib deps.c exec.c global.c lib.h match.c plist.c url.c usr.sbin/pkg_install/version main.c perform.c pkg_version.1 test-pkg_version.sh version.h Added files: (Branch: RELENG_6) usr.sbin/pkg_install/updating Makefile main.c pathnames.h pkg_updating.1 Removed files: (Branch: RELENG_6) usr.sbin/pkg_install/sign Makefile README check.c common.c extern.h gzip.c gzip.h main.c pgp.h pgp_check.c pgp_sign.c pkg_sign.1 sha1.c sign.c stand.c stand.h x509.c Log: Synchronize pkg_install with HEAD: - Add pkg_updating, - Remove pkg_sign, - Support for 8-CURRENT, - Style cleanup (__P use), - ... and much more. Revision Changes Path 1.16.2.1 +2 -4 src/usr.sbin/pkg_install/Makefile 1.11.8.4 +1 -0 src/usr.sbin/pkg_install/add/add.h 1.43.2.3 +0 -0 src/usr.sbin/pkg_install/add/extract.c 1.61.2.11 +12 -5 src/usr.sbin/pkg_install/add/main.c 1.77.8.4 +4 -0 src/usr.sbin/pkg_install/add/perform.c 1.66.2.5 +97 -73 src/usr.sbin/pkg_install/add/pkg_add.1 1.25.2.2 +0 -0 src/usr.sbin/pkg_install/create/create.h 1.36.2.3 +10 -10 src/usr.sbin/pkg_install/create/main.c 1.80.2.3 +0 -0 src/usr.sbin/pkg_install/create/perform.c 1.68.2.3 +0 -0 src/usr.sbin/pkg_install/create/pkg_create.1 1.27.8.2 +0 -0 src/usr.sbin/pkg_install/create/pl.c 1.26.8.2 +2 -2 src/usr.sbin/pkg_install/delete/main.c 1.41.8.1 +1 -1 src/usr.sbin/pkg_install/delete/perform.c 1.31.2.1 +0 -0 src/usr.sbin/pkg_install/delete/pkg_delete.1 1.28.2.2 +0 -0 src/usr.sbin/pkg_install/info/info.h 1.47.2.3 +2 -2 src/usr.sbin/pkg_install/info/main.c 1.53.8.2 +0 -0 src/usr.sbin/pkg_install/info/perform.c 1.54.2.3 +38 -30 src/usr.sbin/pkg_install/info/pkg_info.1 1.38.2.4 +0 -0 src/usr.sbin/pkg_install/info/show.c 1.11.8.2 +0 -0 src/usr.sbin/pkg_install/lib/deps.c 1.10.14.1 +2 -2 src/usr.sbin/pkg_install/lib/exec.c 1.10.2.1 +1 -1 src/usr.sbin/pkg_install/lib/global.c 1.56.2.3 +12 -3 src/usr.sbin/pkg_install/lib/lib.h 1.19.8.3 +0 -0 src/usr.sbin/pkg_install/lib/match.c 1.50.2.2 +1 -1 src/usr.sbin/pkg_install/lib/plist.c 1.4.10.3 +8 -8 src/usr.sbin/pkg_install/lib/url.c 1.10.8.1 +0 -16 src/usr.sbin/pkg_install/sign/Makefile (dead) 1.1.16.1 +0 -55 src/usr.sbin/pkg_install/sign/README (dead) 1.2.14.1 +0 -119 src/usr.sbin/pkg_install/sign/check.c (dead) 1.2.14.1 +0 -90 src/usr.sbin/pkg_install/sign/common.c (dead) 1.2.14.1 +0 -100 src/usr.sbin/pkg_install/sign/extern.h (dead) 1.3.14.1 +0 -319 src/usr.sbin/pkg_install/sign/gzip.c (dead) 1.2.14.1 +0 -95 src/usr.sbin/pkg_install/sign/gzip.h (dead) 1.2.14.2 +0 -185 src/usr.sbin/pkg_install/sign/main.c (dead) 1.1.16.1 +0 -25 src/usr.sbin/pkg_install/sign/pgp.h (dead) 1.2.14.1 +0 -196 src/usr.sbin/pkg_install/sign/pgp_check.c (dead) 1.5.8.1 +0 -281 src/usr.sbin/pkg_install/sign/pgp_sign.c (dead) 1.10.2.1 +0 -211 src/usr.sbin/pkg_install/sign/pkg_sign.1 (dead) 1.5.8.1 +0 -230 src/usr.sbin/pkg_install/sign/sha1.c (dead) 1.4.8.2 +0 -150 src/usr.sbin/pkg_install/sign/sign.c (dead) 1.2.14.2 +0 -57 src/usr.sbin/pkg_install/sign/stand.c (dead) 1.2.8.1 +0 -28 src/usr.sbin/pkg_install/sign/stand.h (dead) 1.4.8.2 +0 -428 src/usr.sbin/pkg_install/sign/x509.c (dead) 1.2.4.1 +14 -0 src/usr.sbin/pkg_install/updating/Makefile (new) 1.2.4.1 +259 -0 src/usr.sbin/pkg_install/updating/main.c (new) 1.2.4.1 +17 -0 src/usr.sbin/pkg_install/updating/pathnames.h (new) 1.3.4.1 +88 -0 src/usr.sbin/pkg_install/updating/pkg_updating.1 (new) 1.5.2.2 +5 -5 src/usr.sbin/pkg_install/version/main.c 1.12.2.6 +2 -2 src/usr.sbin/pkg_install/version/perform.c 1.34.2.2 +6 -6 src/usr.sbin/pkg_install/version/pkg_version.1 1.5.8.2 +0 -0 src/usr.sbin/pkg_install/version/test-pkg_version.sh 1.4.2.2 +0 -7 src/usr.sbin/pkg_install/version/version.h From rpaulo at FreeBSD.org Mon Apr 7 11:38:43 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Mon Apr 7 11:38:49 2008 Subject: cvs commit: src/sys/dev/asmc asmcvar.h Message-ID: <200804071138.m37BchNM022366@repoman.freebsd.org> rpaulo 2008-04-07 11:38:43 UTC FreeBSD src repository Modified files: sys/dev/asmc asmcvar.h Log: "Prettyfy" numbers in hexadecimal. No functional change. Revision Changes Path 1.3 +2 -2 src/sys/dev/asmc/asmcvar.h From rpaulo at FreeBSD.org Mon Apr 7 12:10:04 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Mon Apr 7 12:10:08 2008 Subject: cvs commit: src/sys/dev/asmc asmc.c asmcvar.h Message-ID: <200804071209.m37C9xc3025009@repoman.freebsd.org> rpaulo 2008-04-07 12:09:59 UTC FreeBSD src repository Modified files: sys/dev/asmc asmc.c asmcvar.h Log: * Add missing #else in the #ifdef DEBUG section. * Fix the login in asmc_init(). * Change the INIT2 constant to reflect the same change in the Linux driver. Revision Changes Path 1.5 +5 -4 src/sys/dev/asmc/asmc.c 1.4 +1 -1 src/sys/dev/asmc/asmcvar.h From mav at FreeBSD.org Mon Apr 7 12:23:52 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Mon Apr 7 12:23:59 2008 Subject: cvs commit: src/sys/netgraph ng_base.c In-Reply-To: <200804061526.m36FQWid082581@repoman.freebsd.org> References: <200804061526.m36FQWid082581@repoman.freebsd.org> Message-ID: <47FA1255.60002@FreeBSD.org> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi. Alexander Motin wrote: > mav 2008-04-06 15:26:32 UTC > > FreeBSD src repository > > Modified files: > sys/netgraph ng_base.c > Log: > Rewrite node's r/w/q-lock semantics using only atomics instead of mutex > and atomics combination. Mutex is now used only for queue protection. > Also avoid unneded extra swi scheduling calls. > > Revision Changes Path > 1.155 +76 -247 src/sys/netgraph/ng_base.c This patch broke tinderbox build on powerpc. But as soon as I have only replaced _add_ with _set_ and _subtract_ with _clear_ IMHO problem is powerpc atomic.h related. That atomic.h looks something strange: #define atomic_set_long atomic_set_32 #define atomic_clear_long atomic_clear_32 #define atomic_add_long(p, v) atomic_add_32((uint32_t *)p, (uint32_t)v) #define atomic_subtract_long(p, v) atomic_subtract_32((uint32_t *)p, (uint32_t)v) #define atomic_readandclear_long atomic_readandclear_32 Can somebody with powerpc experience check this? - -- Alexander Motin -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFH+hJV0kCgngV3usoRAjtBAJ9+f7dzmXv8xVcmLG3h3x22eg8B9gCfVuvE 5aDm6E5iX1r7tfsQ/kmR0GU= =14ws -----END PGP SIGNATURE----- From rwatson at FreeBSD.org Mon Apr 7 12:41:46 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Mon Apr 7 12:41:51 2008 Subject: cvs commit: src/sys/netinet tcp_input.c Message-ID: <200804071241.m37Cfjl0026426@repoman.freebsd.org> rwatson 2008-04-07 12:41:45 UTC FreeBSD src repository Modified files: sys/netinet tcp_input.c Log: Add further TCP inpcb locking assertions to some TCP input code paths. MFC after: 1 month Revision Changes Path 1.374 +11 -0 src/sys/netinet/tcp_input.c From rpaulo at FreeBSD.org Mon Apr 7 12:58:43 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Mon Apr 7 12:58:49 2008 Subject: cvs commit: src/sys/dev/asmc asmc.c asmcvar.h Message-ID: <200804071258.m37Cwh7q036065@repoman.freebsd.org> rpaulo 2008-04-07 12:58:43 UTC FreeBSD src repository Modified files: sys/dev/asmc asmc.c asmcvar.h Log: Actually, I was looking at the wrong Linux .c file. Set INIT2 to its previous value. While there, lower the delay for the misterious key. Revision Changes Path 1.6 +1 -1 src/sys/dev/asmc/asmc.c 1.5 +1 -1 src/sys/dev/asmc/asmcvar.h From grehan at freebsd.org Mon Apr 7 13:18:01 2008 From: grehan at freebsd.org (Peter Grehan) Date: Mon Apr 7 13:18:07 2008 Subject: cvs commit: src/sys/netgraph ng_base.c Message-ID: <20080407231735.DUL49107@dommail.onthenet.com.au> >Can somebody with powerpc experience check this? I'll get to it later this morning PDT if Marcel doesn't beat me to it. later, Peter. From jkoshy at FreeBSD.org Mon Apr 7 13:34:20 2008 From: jkoshy at FreeBSD.org (Joseph Koshy) Date: Mon Apr 7 13:34:32 2008 Subject: cvs commit: CVSROOT access Message-ID: <200804071334.m37DYKTL038391@repoman.freebsd.org> jkoshy 2008-04-07 13:34:20 UTC FreeBSD src repository Modified files: . access Log: Kai Wang is henceforth free to fly solo. Approved by: core (implicit) Revision Changes Path 1.869 +0 -0 CVSROOT/access From deischen at FreeBSD.org Mon Apr 7 13:53:51 2008 From: deischen at FreeBSD.org (Daniel Eischen) Date: Mon Apr 7 13:53:58 2008 Subject: cvs commit: src/lib/libc/sys Symbol.map Message-ID: <200804071353.m37Drpks039024@repoman.freebsd.org> deischen 2008-04-07 13:53:51 UTC FreeBSD src repository Modified files: lib/libc/sys Symbol.map Log: Move the cpuset functions from FBSD_1.0 to FBSD_1.1. All symbols added to 8.0 belong in the FBSD_1.1 symbol namespace. Revision Changes Path 1.14 +5 -5 src/lib/libc/sys/Symbol.map From emaste at FreeBSD.org Mon Apr 7 14:16:35 2008 From: emaste at FreeBSD.org (Ed Maste) Date: Mon Apr 7 14:16:46 2008 Subject: cvs commit: src/sys/dev/aac aac.c Message-ID: <200804071416.m37EGZII041810@repoman.freebsd.org> emaste 2008-04-07 14:16:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/aac aac.c Log: MFC aac.c 1.137: Calling RequestSupplementAdapterInfo before RequestAdapterInfo appears to trip a bug causing the latter to return a zeroed struct aac_adapter_info. This causes two issues. One is cosmetic only -- a verbose boot prints information about the controller, and shows all zero: aac0: Unknown processor 0MHz, 0MB memory (0MB cache, 0MB execution), unknown battery platform The second problem is that the firmware version information is stored away for aac_rev_check, for userland tools (like aaccli) to query via the FSACTL_MINIPORT_REV_CHECK and FSACTL_LNX_MINIPORT_REV_CHECK ioctls. When aaccli encounters this issue it prints Command Error: Move the RequestSupplementAdapterInfo call after RequestAdapterInfo, which seems to fix both problems. Revision Changes Path 1.109.2.17 +17 -17 src/sys/dev/aac/aac.c From cognet at FreeBSD.org Mon Apr 7 14:17:27 2008 From: cognet at FreeBSD.org (Olivier Houchard) Date: Mon Apr 7 14:17:41 2008 Subject: cvs commit: CVSROOT access Message-ID: <200804071417.m37EHRfT041859@repoman.freebsd.org> cognet 2008-04-07 14:17:27 UTC FreeBSD src repository Modified files: . access Log: Forced commit to note raj@ is now free of mentorship. Approved by: core (sort of) Revision Changes Path 1.870 +0 -0 CVSROOT/access From emaste at FreeBSD.org Mon Apr 7 14:19:57 2008 From: emaste at FreeBSD.org (Ed Maste) Date: Mon Apr 7 14:20:08 2008 Subject: cvs commit: src/sys/dev/aac aac.c Message-ID: <200804071419.m37EJv65041928@repoman.freebsd.org> emaste 2008-04-07 14:19:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/aac aac.c Log: MFC aac.c 1.137: Calling RequestSupplementAdapterInfo before RequestAdapterInfo appears to trip a bug causing the latter to return a zeroed struct aac_adapter_info. This causes two issues. One is cosmetic only -- a verbose boot prints information about the controller, and shows all zero: aac0: Unknown processor 0MHz, 0MB memory (0MB cache, 0MB execution), unknown battery platform The second problem is that the firmware version information is stored away for aac_rev_check, for userland tools (like aaccli) to query via the FSACTL_MINIPORT_REV_CHECK and FSACTL_LNX_MINIPORT_REV_CHECK ioctls. When aaccli encounters this issue it prints Command Error: Move the RequestSupplementAdapterInfo call after RequestAdapterInfo, which seems to fix both problems. Revision Changes Path 1.120.2.11 +17 -17 src/sys/dev/aac/aac.c From attilio at FreeBSD.org Mon Apr 7 14:46:39 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Mon Apr 7 14:46:45 2008 Subject: cvs commit: src/sys/kern kern_lock.c src/sys/sys lockmgr.h Message-ID: <200804071446.m37EkdhZ047067@repoman.freebsd.org> attilio 2008-04-07 14:46:38 UTC FreeBSD src repository Modified files: sys/kern kern_lock.c sys/sys lockmgr.h Log: - Use a different encoding for lockmgr options: make them encoded by bit in order to allow per-bit checks on the options flag, in particular in the consumers code [1] - Re-enable the check against TDP_DEADLKTREAT as the anti-waiters starvation patch allows exclusive waiters to override new shared requests. [1] Requested by: pjd, jeff Revision Changes Path 1.129 +1 -1 src/sys/kern/kern_lock.c 1.69 +21 -21 src/sys/sys/lockmgr.h From xcllnt at mac.com Mon Apr 7 17:04:55 2008 From: xcllnt at mac.com (Marcel Moolenaar) Date: Mon Apr 7 17:05:07 2008 Subject: cvs commit: src/sys/netgraph ng_base.c In-Reply-To: <20080407231735.DUL49107@dommail.onthenet.com.au> References: <20080407231735.DUL49107@dommail.onthenet.com.au> Message-ID: <5C5302E1-3207-415F-95F0-9ADCA5670576@mac.com> On Apr 7, 2008, at 6:17 AM, Peter Grehan wrote: >> Can somebody with powerpc experience check this? > > I'll get to it later this morning PDT if Marcel doesn't beat > me to it. You may be faster than I then. Compile libthr when you make changes. It's been having aliasing related compile failures after -fno-string-aliases was removed. It's for the same set of atomic functions... FYI, -- Marcel Moolenaar xcllnt@mac.com From pjd at FreeBSD.org Mon Apr 7 18:12:38 2008 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Mon Apr 7 18:12:45 2008 Subject: cvs commit: src/sys/ufs/ufs ufs_gjournal.c Message-ID: <200804071812.m37ICbNV074282@repoman.freebsd.org> pjd 2008-04-07 18:12:37 UTC FreeBSD src repository Modified files: sys/ufs/ufs ufs_gjournal.c Log: Correct function name in panic(). Reported by: kensmith Revision Changes Path 1.3 +1 -1 src/sys/ufs/ufs/ufs_gjournal.c From jhb at FreeBSD.org Mon Apr 7 18:23:29 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Apr 7 18:23:35 2008 Subject: cvs commit: src/sbin/gpt gpt.c Message-ID: <200804071823.m37INSrD074687@repoman.freebsd.org> jhb 2008-04-07 18:23:28 UTC FreeBSD src repository Modified files: sbin/gpt gpt.c Log: Add 'zfs' as an alias for the FreeBSD ZFS UUID. MFC after: 3 days PR: bin/119976 Submitted by: Cian Hughes Ci of nhugh.es Revision Changes Path 1.20 +7 -0 src/sbin/gpt/gpt.c From jhb at FreeBSD.org Mon Apr 7 18:35:11 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Apr 7 18:35:18 2008 Subject: cvs commit: src/sys/dev/acpica acpi.c Message-ID: <200804071835.m37IZBMK075084@repoman.freebsd.org> jhb 2008-04-07 18:35:11 UTC FreeBSD src repository Modified files: sys/dev/acpica acpi.c Log: Revert back to probing Host-PCI bridges in the order we encounter them in the tree rather than sorting them by their address on PCI bus 0. Reported by: kan Revision Changes Path 1.248 +11 -18 src/sys/dev/acpica/acpi.c From andre at FreeBSD.org Mon Apr 7 18:44:00 2008 From: andre at FreeBSD.org (Andre Oppermann) Date: Mon Apr 7 18:44:05 2008 Subject: cvs commit: src/sys/netinet tcp.h tcp_output.c Message-ID: <200804071843.m37Ihxr2075491@repoman.freebsd.org> andre 2008-04-07 18:43:59 UTC FreeBSD src repository Modified files: sys/netinet tcp.h tcp_output.c Log: Use #defines for TCP options padding after EOL to be consistent. Reviewed by: bz Revision Changes Path 1.42 +2 -0 src/sys/netinet/tcp.h 1.147 +2 -2 src/sys/netinet/tcp_output.c From andre at FreeBSD.org Mon Apr 7 18:50:16 2008 From: andre at FreeBSD.org (Andre Oppermann) Date: Mon Apr 7 18:50:29 2008 Subject: cvs commit: src/sys/netinet tcp_output.c Message-ID: <200804071850.m37IoGDY075780@repoman.freebsd.org> andre 2008-04-07 18:50:05 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Remove now unnecessary comment. Revision Changes Path 1.148 +0 -2 src/sys/netinet/tcp_output.c From andre at FreeBSD.org Mon Apr 7 19:09:24 2008 From: andre at FreeBSD.org (Andre Oppermann) Date: Mon Apr 7 19:09:30 2008 Subject: cvs commit: src/sys/netinet tcp_output.c Message-ID: <200804071909.m37J9Nal077550@repoman.freebsd.org> andre 2008-04-07 19:09:23 UTC FreeBSD src repository Modified files: sys/netinet tcp_output.c Log: Remove TCP options ordering assumptions in tcp_addoptions(). Ordering was changed in rev. 1.161 of tcp_var.h. All option now test for sufficient space in TCP header before getting added. Reported by: Mark Atkinson Tested by: Mark Atkinson MFC after: 1 week Revision Changes Path 1.149 +11 -1 src/sys/netinet/tcp_output.c From jhb at FreeBSD.org Mon Apr 7 19:12:23 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Mon Apr 7 19:12:34 2008 Subject: cvs commit: src/sys/dev/usb ehci_pci.c uhci_pci.c Message-ID: <200804071912.m37JCMHp077761@repoman.freebsd.org> jhb 2008-04-07 19:12:22 UTC FreeBSD src repository Modified files: sys/dev/usb ehci_pci.c uhci_pci.c Log: Add PCI ID's for ICH8 USB controllers. MFC after: 1 week PR: usb/116574 Submitted by: Dave Grochowski malus.x of gmail Revision Changes Path 1.31 +8 -0 src/sys/dev/usb/ehci_pci.c 1.63 +25 -0 src/sys/dev/usb/uhci_pci.c From clbuisson at orange.fr Tue Apr 8 00:24:16 2008 From: clbuisson at orange.fr (Claude Buisson) Date: Tue Apr 8 00:24:23 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml Message-ID: <47FAB23A.6070302@orange.fr> On Sun Apr 6 05:44:12 UTC 2008: > bmah 2008-04-06 05:44:11 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_5) ^^^^^^^^^ > release/doc/en_US.ISO8859-1/relnotes/common new.sgml > Log: > MFC: BTX real mode, GNOME 2.22. ^^^^^^^^^^^^^ > > Bump copyright date while here. > > Revision Changes Path > 1.761.2.87 +7 -2 src/release/doc/en_US.ISO8859-1/relnotes/... AFAIK, BTX realmode has been MFCed to RELENG_7, RELENG_6, RELENG_4, but NOT to RELENG_5 Claude Buisson From weongyo at FreeBSD.org Tue Apr 8 01:47:33 2008 From: weongyo at FreeBSD.org (Weongyo Jeong) Date: Tue Apr 8 01:47:36 2008 Subject: cvs commit: src/usr.sbin/sysinstall devices.c src/sys/boot/forth loader.conf Message-ID: <200804080147.m381lXh6020763@repoman.freebsd.org> weongyo 2008-04-08 01:47:33 UTC FreeBSD src repository Modified files: usr.sbin/sysinstall devices.c sys/boot/forth loader.conf Log: Add a couple of missing wireless NIC driver modules. Approved by: thompsa (mentor) Revision Changes Path 1.124 +5 -0 src/sys/boot/forth/loader.conf 1.174 +8 -0 src/usr.sbin/sysinstall/devices.c From marcel at FreeBSD.org Tue Apr 8 02:57:59 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Tue Apr 8 02:58:11 2008 Subject: cvs commit: src/release/ia64 mkisoimages.sh Message-ID: <200804080257.m382vxuR024394@repoman.freebsd.org> marcel 2008-04-08 02:57:59 UTC FreeBSD src repository Modified files: release/ia64 mkisoimages.sh Log: Increase the size of the EFI system partition from 16M to 20M. We just ran out of space... Revision Changes Path 1.12 +1 -1 src/release/ia64/mkisoimages.sh From thompsa at FreeBSD.org Tue Apr 8 06:33:48 2008 From: thompsa at FreeBSD.org (Andrew Thompson) Date: Tue Apr 8 06:33:59 2008 Subject: cvs commit: src/sys/contrib/dev/wpi LICENSE iwlwifi-3945-2.14.4.fw.uu Message-ID: <200804080633.m386Xlkp045751@repoman.freebsd.org> thompsa 2008-04-08 06:33:47 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/contrib/dev/wpi LICENSE iwlwifi-3945-2.14.4.fw.uu Log: Fix MFC, the contents were duplicated. Revision Changes Path 1.1.2.2 +0 -39 src/sys/contrib/dev/wpi/LICENSE 1.1.2.2 +0 -2628 src/sys/contrib/dev/wpi/iwlwifi-3945-2.14.4.fw.uu From thompsa at FreeBSD.org Tue Apr 8 06:55:10 2008 From: thompsa at FreeBSD.org (Andrew Thompson) Date: Tue Apr 8 06:55:16 2008 Subject: cvs commit: src/sys/net bridgestp.c bridgestp.h Message-ID: <200804080655.m386t9VS059911@repoman.freebsd.org> thompsa 2008-04-08 06:55:09 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/net bridgestp.c bridgestp.h Log: MFC bridgestp.c r1.40, bridgestp.h r1.15 Fix spelling, retaining old define. Revision Changes Path 1.39.2.1 +7 -7 src/sys/net/bridgestp.c 1.14.2.1 +2 -1 src/sys/net/bridgestp.h From flz at FreeBSD.org Tue Apr 8 09:07:43 2008 From: flz at FreeBSD.org (Florent Thoumie) Date: Tue Apr 8 09:07:53 2008 Subject: cvs commit: src ObsoleteFiles.inc Message-ID: <200804080907.m3897huq076670@repoman.freebsd.org> flz 2008-04-08 09:07:43 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) . ObsoleteFiles.inc Log: Add pkg_check and pkg_sign to ObsoleteFiles.inc. Revision Changes Path 1.112.2.12 +5 -0 src/ObsoleteFiles.inc From flz at FreeBSD.org Tue Apr 8 09:08:17 2008 From: flz at FreeBSD.org (Florent Thoumie) Date: Tue Apr 8 09:08:19 2008 Subject: cvs commit: src ObsoleteFiles.inc Message-ID: <200804080908.m3898H5F076709@repoman.freebsd.org> flz 2008-04-08 09:08:17 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) . ObsoleteFiles.inc Log: Add pkg_check and pkg_sign to ObsoleteFiles.inc. Revision Changes Path 1.25.2.22 +5 -0 src/ObsoleteFiles.inc From phk at FreeBSD.org Tue Apr 8 09:38:16 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Tue Apr 8 09:38:24 2008 Subject: cvs commit: src/sys/i386/cpufreq est.c p4tcc.c Message-ID: <200804080938.m389cGQY077882@repoman.freebsd.org> phk 2008-04-08 09:38:16 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/i386/cpufreq est.c p4tcc.c Log: MFC: 1.13: Use correct bitmask for checking CPU identities. 1.16: Add XXX comment about the table in general. Revision Changes Path 1.11.2.4 +16 -2 src/sys/i386/cpufreq/est.c 1.12.2.1 +9 -1 src/sys/i386/cpufreq/p4tcc.c From phk at FreeBSD.org Tue Apr 8 09:45:07 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Tue Apr 8 09:45:14 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h Message-ID: <200804080945.m389j7cP078363@repoman.freebsd.org> phk 2008-04-08 09:45:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/ata ata-all.h Log: MFC: 1.127 Use bus_{read|write_*() instead of bus_space_{read|write}_*() for purely stylistic reasons. Revision Changes Path 1.124.2.3 +14 -36 src/sys/dev/ata/ata-all.h From kib at FreeBSD.org Tue Apr 8 09:45:49 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Tue Apr 8 09:45:57 2008 Subject: cvs commit: src/sys/amd64/linux32 linux.h linux32_dummy.c linux32_sysvec.c syscalls.master src/sys/compat/linux linux_file.c linux_file.h linux_misc.c linux_stats.c linux_util.c linux_util.h src/sys/compat/svr4 svr4_sysvec.c src/sys/i386/ibcs2 ibcs2_util.c ... Message-ID: <200804080945.m389jnat078564@repoman.freebsd.org> kib 2008-04-08 09:45:49 UTC FreeBSD src repository Modified files: sys/amd64/linux32 linux.h linux32_dummy.c linux32_sysvec.c syscalls.master sys/compat/linux linux_file.c linux_misc.c linux_stats.c linux_util.c linux_util.h sys/compat/svr4 svr4_sysvec.c sys/i386/ibcs2 ibcs2_util.c sys/i386/linux linux.h linux_dummy.c linux_sysvec.c syscalls.master sys/kern vfs_lookup.c sys/sys syscallsubr.h Added files: sys/compat/linux linux_file.h Log: Implement the linux syscalls openat, mkdirat, mknodat, fchownat, futimesat, fstatat, unlinkat, renameat, linkat, symlinkat, readlinkat, fchmodat, faccessat. Submitted by: rdivacky Sponsored by: Google Summer of Code 2007 Tested by: pho Revision Changes Path 1.17 +0 -2 src/sys/amd64/linux32/linux.h 1.10 +0 -12 src/sys/amd64/linux32/linux32_dummy.c 1.34 +2 -1 src/sys/amd64/linux32/linux32_sysvec.c 1.32 +24 -13 src/sys/amd64/linux32/syscalls.master 1.111 +246 -112 src/sys/compat/linux/linux_file.c 1.1 +36 -0 src/sys/compat/linux/linux_file.h (new) 1.220 +84 -0 src/sys/compat/linux/linux_misc.c 1.91 +40 -3 src/sys/compat/linux/linux_stats.c 1.34 +4 -3 src/sys/compat/linux/linux_util.c 1.30 +7 -5 src/sys/compat/linux/linux_util.h 1.45 +1 -1 src/sys/compat/svr4/svr4_sysvec.c 1.21 +1 -1 src/sys/i386/ibcs2/ibcs2_util.c 1.79 +0 -2 src/sys/i386/linux/linux.h 1.47 +0 -12 src/sys/i386/linux/linux_dummy.c 1.154 +1 -1 src/sys/i386/linux/linux_sysvec.c 1.91 +24 -13 src/sys/i386/linux/syscalls.master 1.110 +11 -2 src/sys/kern/vfs_lookup.c 1.50 +2 -2 src/sys/sys/syscallsubr.h From kib at FreeBSD.org Tue Apr 8 09:48:26 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Tue Apr 8 09:48:33 2008 Subject: cvs commit: src/sys/i386/linux linux_proto.h linux_syscall.h linux_sysent.c Message-ID: <200804080948.m389mQ1U078859@repoman.freebsd.org> kib 2008-04-08 09:48:26 UTC FreeBSD src repository Modified files: sys/i386/linux linux_proto.h linux_syscall.h linux_sysent.c Log: Regenerate Revision Changes Path 1.97 +59 -26 src/sys/i386/linux/linux_proto.h 1.89 +1 -1 src/sys/i386/linux/linux_syscall.h 1.96 +13 -14 src/sys/i386/linux/linux_sysent.c From phk at FreeBSD.org Tue Apr 8 09:49:43 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Tue Apr 8 09:49:48 2008 Subject: cvs commit: src/sys/sys ata.h src/sys/dev/ata ata-disk.c Message-ID: <200804080949.m389ng1Y078976@repoman.freebsd.org> phk 2008-04-08 09:49:42 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/sys ata.h sys/dev/ata ata-disk.c Log: MFC 1.206: If the disk reports that it support the Compact Flash Association command set, announce BIO_DELETE capability and issue ATA_CFA_ERASE when we get one. Revision Changes Path 1.204.2.2 +9 -0 src/sys/dev/ata/ata-disk.c 1.36.2.2 +1 -0 src/sys/sys/ata.h From kib at FreeBSD.org Tue Apr 8 09:51:20 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Tue Apr 8 09:51:23 2008 Subject: cvs commit: src/sys/amd64/linux32 linux32_proto.h linux32_syscall.h linux32_sysent.c Message-ID: <200804080951.m389pJRk079192@repoman.freebsd.org> kib 2008-04-08 09:51:19 UTC FreeBSD src repository Modified files: sys/amd64/linux32 linux32_proto.h linux32_syscall.h linux32_sysent.c Log: Regenerate Revision Changes Path 1.35 +59 -26 src/sys/amd64/linux32/linux32_proto.h 1.35 +1 -1 src/sys/amd64/linux32/linux32_syscall.h 1.35 +13 -14 src/sys/amd64/linux32/linux32_sysent.c From phk at FreeBSD.org Tue Apr 8 09:54:37 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Tue Apr 8 09:54:43 2008 Subject: cvs commit: src/sbin/atacontrol atacontrol.c Message-ID: <200804080954.m389sb2V079250@repoman.freebsd.org> phk 2008-04-08 09:54:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sbin/atacontrol atacontrol.c Log: MFC 1.44,1.45: Report CFA capability. 1.46: Un-cut&paste argument processing, fix things lint found. Revision Changes Path 1.43.2.1 +71 -104 src/sbin/atacontrol/atacontrol.c From kevlo at FreeBSD.org Tue Apr 8 10:24:42 2008 From: kevlo at FreeBSD.org (Kevin Lo) Date: Tue Apr 8 10:24:51 2008 Subject: cvs commit: src/sys/arm/arm exception.S locore.S src/sys/arm/sa11x0 assabet_machdep.c src/sys/arm/xscale/i80321 ep80219_machdep.c iq31244_machdep.c src/sys/arm/xscale/i8134x crb_machdep.c src/sys/arm/xscale/ixp425 avila_machdep.c Message-ID: <200804081024.m38AOgvm081501@repoman.freebsd.org> kevlo 2008-04-08 10:24:42 UTC FreeBSD src repository Modified files: sys/arm/arm exception.S locore.S sys/arm/sa11x0 assabet_machdep.c sys/arm/xscale/i80321 ep80219_machdep.c iq31244_machdep.c sys/arm/xscale/i8134x crb_machdep.c sys/arm/xscale/ixp425 avila_machdep.c Log: Remove some long-dead code Reviewed by: cognet Revision Changes Path 1.6 +0 -5 src/sys/arm/arm/exception.S 1.19 +0 -37 src/sys/arm/arm/locore.S 1.25 +1 -4 src/sys/arm/sa11x0/assabet_machdep.c 1.10 +0 -4 src/sys/arm/xscale/i80321/ep80219_machdep.c 1.31 +0 -4 src/sys/arm/xscale/i80321/iq31244_machdep.c 1.6 +0 -4 src/sys/arm/xscale/i8134x/crb_machdep.c 1.10 +0 -4 src/sys/arm/xscale/ixp425/avila_machdep.c From phk at FreeBSD.org Tue Apr 8 10:48:22 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Tue Apr 8 10:48:30 2008 Subject: cvs commit: src/sbin/atacontrol atacontrol.8 atacontrol.c src/sys/sys ata.h src/sys/dev/ata ata-all.c ata-all.h ata-disk.c Message-ID: <200804081048.m38AmMKL082533@repoman.freebsd.org> phk 2008-04-08 10:48:21 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sbin/atacontrol atacontrol.8 atacontrol.c sys/sys ata.h sys/dev/ata ata-all.c ata-all.h ata-disk.c Log: MFC: Add support for "atacontrol spindown" Revision Changes Path 1.28.2.2 +8 -0 src/sbin/atacontrol/atacontrol.8 1.43.2.2 +27 -0 src/sbin/atacontrol/atacontrol.c 1.280.2.1 +6 -0 src/sys/dev/ata/ata-all.c 1.124.2.4 +3 -0 src/sys/dev/ata/ata-all.h 1.204.2.3 +49 -1 src/sys/dev/ata/ata-disk.c 1.36.2.3 +3 -0 src/sys/sys/ata.h From phk at FreeBSD.org Tue Apr 8 11:04:06 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Tue Apr 8 11:04:08 2008 Subject: cvs commit: src/sys/kern kern_exit.c Message-ID: <200804081104.m38B46dX084227@repoman.freebsd.org> phk 2008-04-08 11:04:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern kern_exit.c Log: MFC 1.310: In abort2(2): Accept a NULL arg pointer if nargs == 0 Revision Changes Path 1.304.2.1 +8 -6 src/sys/kern/kern_exit.c From bz at FreeBSD.org Tue Apr 8 11:51:18 2008 From: bz at FreeBSD.org (Bjoern A. Zeeb) Date: Tue Apr 8 11:51:24 2008 Subject: cvs commit: src/sys/dev/bge if_bge.c Message-ID: <200804081151.m38BpHuL085890@repoman.freebsd.org> bz 2008-04-08 11:51:17 UTC FreeBSD src repository Modified files: sys/dev/bge if_bge.c Log: In some situations we were not clearing pending link state attentions. Because of this we were not getting further interrupts for link state changes, thus never went into iface UP state and thus could not transmit. The only way out of this was an incoming packet generating an rx interrupt and making us call into bge_link_upd. Up to rev. 1.101, in bge_start_locked, we only returned instantly if there was 'no link AND nothing queued for tx'. So with a packet queued for tx, we hit the register scrubbing at the end of bge_start_locked and were out fine. We simply lost a packet or two but got the interrupts need to get into UP state. With rev. 1.102 this was turned into 'if there is no link OR there is nothing to send' (correct behaviour) and as long as there is no link we never hit the register scrubbing and consequently never got the link UP. What we do now is force an interrupt at the end of bge_ifmedia_upd_locked so we will call bge_link_upd, clear the link state attention and get further interrupts. This helps to get the iface UP on an idle network or at least to get it UP faster not depending on an rx intr anymore. In case you could not get a DHCP lease or it took very long, it was because of this. It is unknown which chips are affected by this. ASIC rev. 0x2003 was the most popular trouble candidate. At least the fiber cards should have been working fine. Which register to scrub is currently under discussion. The comitted solution was tested and found to work for a lot of setups. It might not help with MSI. The reason why we end up in such a situation is entirely unknown. PR: kern/111804 Tested by: phk, scottl at Y! MFC after: 14 days Revision Changes Path 1.205 +17 -0 src/sys/dev/bge/if_bge.c From rpaulo at FreeBSD.org Tue Apr 8 12:35:56 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Tue Apr 8 12:36:08 2008 Subject: cvs commit: src/sys/dev/usb ums.c Message-ID: <200804081235.m38CZuUK088545@repoman.freebsd.org> rpaulo 2008-04-08 12:35:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/usb ums.c Log: MFC r1.97: Sync with rev 1.63 of NetBSD's ums.c: If a mouse has both a wheel and a Z direction we report both. XXX Due to tradition the wheel is reported as the Z direction (and the Z direction as W). Now Apple's Mighty Mouse is fully supported, except the X11 mouse driver doesn't know what to do with the new coordinate. Revision Changes Path 1.77.2.6 +49 -14 src/sys/dev/usb/ums.c From rpaulo at FreeBSD.org Tue Apr 8 12:35:56 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Tue Apr 8 12:36:09 2008 Subject: cvs commit: src/sys/dev/usb ums.c Message-ID: <200804081235.m38CZupi088562@repoman.freebsd.org> rpaulo 2008-04-08 12:35:56 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/usb ums.c Log: MFC r1.97: Sync with rev 1.63 of NetBSD's ums.c: If a mouse has both a wheel and a Z direction we report both. XXX Due to tradition the wheel is reported as the Z direction (and the Z direction as W). Now Apple's Mighty Mouse is fully supported, except the X11 mouse driver doesn't know what to do with the new coordinate. Revision Changes Path 1.96.2.2 +49 -14 src/sys/dev/usb/ums.c From kib at FreeBSD.org Tue Apr 8 12:57:27 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Tue Apr 8 12:57:39 2008 Subject: cvs commit: src/sys/sys param.h Message-ID: <200804081257.m38CvRhr098723@repoman.freebsd.org> kib 2008-04-08 12:57:26 UTC FreeBSD src repository Modified files: sys/sys param.h Log: Bump __FreeBSD_version after the implementation of the openat() and related syscalls both for the native FreeBSD ABI and linuxolator. Revision Changes Path 1.348 +1 -1 src/sys/sys/param.h From nyan at FreeBSD.org Tue Apr 8 13:10:58 2008 From: nyan at FreeBSD.org (Takahashi Yoshihiro) Date: Tue Apr 8 13:11:10 2008 Subject: cvs commit: src/sys/pc98/cbus sc_machdep.h syscons_cbus.c Message-ID: <200804081310.m38DAvlJ000452@repoman.freebsd.org> nyan 2008-04-08 13:10:57 UTC FreeBSD src repository Modified files: sys/pc98/cbus sc_machdep.h syscons_cbus.c Log: Always set the bell_pitch to 800. This catch up with the sysbeep() argument changing. Revision Changes Path 1.6 +1 -5 src/sys/pc98/cbus/sc_machdep.h 1.28 +1 -4 src/sys/pc98/cbus/syscons_cbus.c From nyan at FreeBSD.org Tue Apr 8 13:15:57 2008 From: nyan at FreeBSD.org (Takahashi Yoshihiro) Date: Tue Apr 8 13:16:04 2008 Subject: cvs commit: src/sys/pc98/conf GENERIC Message-ID: <200804081315.m38DFuSb001513@repoman.freebsd.org> nyan 2008-04-08 13:15:56 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/pc98/conf GENERIC Log: MFi386: revision 1.474.2.5 Add USB->RS232 devices to the GENERIC kernel. Revision Changes Path 1.297.2.2 +11 -0 src/sys/pc98/conf/GENERIC From jhb at FreeBSD.org Tue Apr 8 14:19:58 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Tue Apr 8 14:20:11 2008 Subject: cvs commit: src/sys/dev/de if_de.c Message-ID: <200804081419.m38EJwVR018617@repoman.freebsd.org> jhb 2008-04-08 14:19:58 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/de if_de.c Log: MFC: Explicitly bypass bpf(4) for media test packets during attach. Revision Changes Path 1.183.2.1 +6 -2 src/sys/dev/de/if_de.c From jhb at FreeBSD.org Tue Apr 8 14:23:24 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Tue Apr 8 14:23:34 2008 Subject: cvs commit: src/sys/pci if_de.c Message-ID: <200804081423.m38ENNxu020363@repoman.freebsd.org> jhb 2008-04-08 14:23:23 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/pci if_de.c Log: MFC: Explicitly bypass bpf(4) for media test packets during attach. Revision Changes Path 1.162.2.7 +6 -2 src/sys/pci/if_de.c From jhb at freebsd.org Tue Apr 8 14:26:52 2008 From: jhb at freebsd.org (John Baldwin) Date: Tue Apr 8 14:27:02 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml In-Reply-To: <47FAB23A.6070302@orange.fr> References: <47FAB23A.6070302@orange.fr> Message-ID: <200804080948.57953.jhb@freebsd.org> On Monday 07 April 2008 07:46:02 pm Claude Buisson wrote: > On Sun Apr 6 05:44:12 UTC 2008: > > bmah 2008-04-06 05:44:11 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_5) > > ^^^^^^^^^ > > > release/doc/en_US.ISO8859-1/relnotes/common new.sgml > > Log: > > MFC: BTX real mode, GNOME 2.22. > > ^^^^^^^^^^^^^ > > > Bump copyright date while here. > > > > Revision Changes Path > > 1.761.2.87 +7 -2 src/release/doc/en_US.ISO8859-1/relnotes/... > > AFAIK, BTX realmode has been MFCed to RELENG_7, RELENG_6, RELENG_4, > but NOT to RELENG_5 Correct. -- John Baldwin From marcel at FreeBSD.org Tue Apr 8 16:34:51 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Tue Apr 8 16:34:57 2008 Subject: cvs commit: src/sys/powerpc/include atomic.h Message-ID: <200804081634.m38GYp5V044577@repoman.freebsd.org> marcel 2008-04-08 16:34:51 UTC FreeBSD src repository Modified files: sys/powerpc/include atomic.h Log: Quick fix for the kernel build breakage in netgraph and the aliasing warning in libthr. A more elaborate fix is in the works that makes sure that all variants have proper inline functions with proper types. Revision Changes Path 1.20 +4 -2 src/sys/powerpc/include/atomic.h From rpaulo at FreeBSD.org Tue Apr 8 16:36:49 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Tue Apr 8 16:37:00 2008 Subject: cvs commit: src/sys/dev/usb ubsa.c usbdevs Message-ID: <200804081636.m38Ganw2044731@repoman.freebsd.org> rpaulo 2008-04-08 16:36:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/usb ubsa.c usbdevs Log: MFC: Add Qualcomm ZTE CMDMA MSM modem to the list of supported modems. Revision Changes Path 1.17.2.6 +2 -0 src/sys/dev/usb/ubsa.c 1.232.2.28 +2 -0 src/sys/dev/usb/usbdevs From rpaulo at FreeBSD.org Tue Apr 8 16:36:50 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Tue Apr 8 16:37:10 2008 Subject: cvs commit: src/sys/dev/usb ubsa.c usbdevs Message-ID: <200804081636.m38Ganhc044750@repoman.freebsd.org> rpaulo 2008-04-08 16:36:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/usb ubsa.c usbdevs Log: MFC: Add Qualcomm ZTE CMDMA MSM modem to the list of supported modems. Revision Changes Path 1.32.2.1 +2 -0 src/sys/dev/usb/ubsa.c 1.328.2.7 +2 -0 src/sys/dev/usb/usbdevs From grehan at freebsd.org Tue Apr 8 16:37:20 2008 From: grehan at freebsd.org (Peter Grehan) Date: Tue Apr 8 16:37:29 2008 Subject: cvs commit: src/sys/powerpc/include atomic.h In-Reply-To: <200804081634.m38GYp5V044577@repoman.freebsd.org> References: <200804081634.m38GYp5V044577@repoman.freebsd.org> Message-ID: <47FB9F3A.7070509@freebsd.org> > Modified files: > sys/powerpc/include atomic.h > Log: > Quick fix for the kernel build breakage in netgraph and the > aliasing warning in libthr. A more elaborate fix is in the > works that makes sure that all variants have proper inline > functions with proper types. Thankyou Marcel ! later, Peter. From rpaulo at FreeBSD.org Tue Apr 8 16:39:00 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Tue Apr 8 16:39:20 2008 Subject: cvs commit: src/share/man/man4 ubsa.4 Message-ID: <200804081639.m38Gd0Di044810@repoman.freebsd.org> rpaulo 2008-04-08 16:39:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man4 ubsa.4 Log: MFC r1.11: Add Qualcomm, Inc. ZTE CDMA Technologies MSM to the list of supported devices. Revision Changes Path 1.5.2.6 +3 -1 src/share/man/man4/ubsa.4 From rpaulo at FreeBSD.org Tue Apr 8 16:39:01 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Tue Apr 8 16:39:28 2008 Subject: cvs commit: src/share/man/man4 ubsa.4 Message-ID: <200804081639.m38Gd0JE044829@repoman.freebsd.org> rpaulo 2008-04-08 16:39:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man4 ubsa.4 Log: MFC r1.11: Add Qualcomm, Inc. ZTE CDMA Technologies MSM to the list of supported devices. Revision Changes Path 1.10.2.1 +3 -1 src/share/man/man4/ubsa.4 From trhodes at FreeBSD.org Tue Apr 8 17:33:58 2008 From: trhodes at FreeBSD.org (Tom Rhodes) Date: Tue Apr 8 17:34:04 2008 Subject: cvs commit: src/share/man/man4 ed.4 Message-ID: <200804081733.m38HXvvF057355@repoman.freebsd.org> trhodes 2008-04-08 17:33:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man4 ed.4 Log: MFC revisions 1.56 and 1.57: Bring the DIAGNOSTICS section in ed.4 closer to reality by removing missing diagnostic messages and adding a few found in the code. PR: 51891 Properly Xref device.hints(5). Revision Changes Path 1.53.2.1 +16 -8 src/share/man/man4/ed.4 From trhodes at FreeBSD.org Tue Apr 8 17:40:43 2008 From: trhodes at FreeBSD.org (Tom Rhodes) Date: Tue Apr 8 17:40:54 2008 Subject: cvs commit: src/share/man/man4 ed.4 Message-ID: <200804081740.m38Heh68057844@repoman.freebsd.org> trhodes 2008-04-08 17:40:43 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) share/man/man4 ed.4 Log: MFC revisions 1.56 and 1.57: Bring the DIAGNOSTICS section in ed.4 closer to reality by removing missing diagnostic messages and adding a few found in the code. PR: 51891 Properly Xref device.hints(5). Revision Changes Path 1.45.2.4 +16 -8 src/share/man/man4/ed.4 From sam at FreeBSD.org Tue Apr 8 17:48:03 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Tue Apr 8 17:48:09 2008 Subject: cvs commit: src/sys/kern subr_taskqueue.c Message-ID: <200804081748.m38Hm2Qm058103@repoman.freebsd.org> sam 2008-04-08 17:48:02 UTC FreeBSD src repository Modified files: sys/kern subr_taskqueue.c Log: change taskqueue_start_threads to create threads instead of proc's Reviewed by: jhb Revision Changes Path 1.42 +24 -22 src/sys/kern/subr_taskqueue.c From sam at FreeBSD.org Tue Apr 8 17:53:34 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Tue Apr 8 17:53:39 2008 Subject: cvs commit: src/sys/sys eventhandler.h kernel.h src/sys/kern vfs_mount.c Message-ID: <200804081753.m38HrYPx058333@repoman.freebsd.org> sam 2008-04-08 17:53:33 UTC FreeBSD src repository Modified files: sys/sys eventhandler.h kernel.h sys/kern vfs_mount.c Log: o add a mountroot event handler that fires when / is mounted; this information was lost when root started being mounted by init o remove SI_SUB_MOUNT_ROOT since it's no longer meaningful MFC after: 2 weeks Revision Changes Path 1.279 +2 -0 src/sys/kern/vfs_mount.c 1.42 +4 -0 src/sys/sys/eventhandler.h 1.140 +0 -1 src/sys/sys/kernel.h From jkim at FreeBSD.org Tue Apr 8 17:55:26 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Tue Apr 8 17:55:37 2008 Subject: cvs commit: src UPDATING src/share/man/man4 psm.4 src/sys/dev/atkbdc psm.c src/sys/sys param.h Message-ID: <200804081755.m38HtQrf058500@repoman.freebsd.org> jkim 2008-04-08 17:55:26 UTC FreeBSD src repository Modified files: . UPDATING share/man/man4 psm.4 sys/dev/atkbdc psm.c sys/sys param.h Log: - Add write(2) support for psm(4) in native operation level. Now arbitrary commands can be written to /dev/psm%d and status can be read back from it. - Reflect the change in psm(4) and bump version for ports. MFC after: 1 week Revision Changes Path 1.524 +7 -0 src/UPDATING 1.49 +4 -2 src/share/man/man4/psm.4 1.95 +53 -7 src/sys/dev/atkbdc/psm.c 1.349 +1 -1 src/sys/sys/param.h From sam at FreeBSD.org Tue Apr 8 18:54:42 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Tue Apr 8 18:54:48 2008 Subject: cvs commit: src/etc/rc.d wpa_supplicant Message-ID: <200804081854.m38IsgJG071281@repoman.freebsd.org> sam 2008-04-08 18:54:42 UTC FreeBSD src repository Modified files: etc/rc.d wpa_supplicant Log: spell pidfile correctly so multiple wpa_supplicant processes can be run MFC after: 1 week Revision Changes Path 1.3 +2 -2 src/etc/rc.d/wpa_supplicant From jkim at FreeBSD.org Tue Apr 8 19:09:46 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Tue Apr 8 19:09:50 2008 Subject: cvs commit: src/sys/dev/atkbdc psm.c Message-ID: <200804081909.m38J9jgx075565@repoman.freebsd.org> jkim 2008-04-08 19:09:45 UTC FreeBSD src repository Modified files: sys/dev/atkbdc psm.c Log: Clean up and fix style(9) nits. Revision Changes Path 1.96 +2903 -2817 src/sys/dev/atkbdc/psm.c From remko at FreeBSD.org Tue Apr 8 19:43:01 2008 From: remko at FreeBSD.org (Remko Lodder) Date: Tue Apr 8 19:43:11 2008 Subject: cvs commit: src/usr.sbin/sysinstall menus.c Message-ID: <200804081943.m38Jh0jW076891@repoman.freebsd.org> remko 2008-04-08 19:43:00 UTC FreeBSD src repository Modified files: usr.sbin/sysinstall menus.c Log: Remove ftp.hk.super.net, the DNS isn't pointing to anything at the moment. I tested this as well as the submitter and couldn't resolve this either, since I dont want to "announce" dead mirrors, I'll remove it from the list. PR: 122567 Submitted by: vs Approved by: imp (mentor, implicit for trivial changes) MFC after: 1 week Revision Changes Path 1.431 +0 -3 src/usr.sbin/sysinstall/menus.c From sam at FreeBSD.org Tue Apr 8 23:00:04 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Tue Apr 8 23:00:12 2008 Subject: cvs commit: src/etc/rc.d wpa_supplicant Message-ID: <200804082300.m38N046t002949@repoman.freebsd.org> sam 2008-04-08 23:00:04 UTC FreeBSD src repository Modified files: etc/rc.d wpa_supplicant Log: add support wired interfaces MFC after: 2 weeks Revision Changes Path 1.4 +17 -1 src/etc/rc.d/wpa_supplicant From sam at FreeBSD.org Tue Apr 8 23:12:16 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Tue Apr 8 23:12:24 2008 Subject: cvs commit: src/etc/rc.d wpa_supplicant src/etc/defaults rc.conf Message-ID: <200804082312.m38NCFmh004516@repoman.freebsd.org> sam 2008-04-08 23:12:15 UTC FreeBSD src repository Modified files: etc/rc.d wpa_supplicant etc/defaults rc.conf Log: o add rc.conf knobs to set the wpa_supplicant program, logging flags, and config file o change default logging options from -q to -s (log to syslog); this is currently broken for boot-time startup as syslogd is started too late but that'll be dealt with separately MFC after: 2 weeks Revision Changes Path 1.329 +4 -0 src/etc/defaults/rc.conf 1.5 +3 -3 src/etc/rc.d/wpa_supplicant From sam at freebsd.org Tue Apr 8 23:12:49 2008 From: sam at freebsd.org (Sam Leffler) Date: Tue Apr 8 23:12:59 2008 Subject: cvs commit: src/etc/rc.d wpa_supplicant src/etc/defaults rc.conf In-Reply-To: <200804082312.m38NCFmh004516@repoman.freebsd.org> References: <200804082312.m38NCFmh004516@repoman.freebsd.org> Message-ID: <47FBFBF0.10702@freebsd.org> Sam Leffler wrote: > sam 2008-04-08 23:12:15 UTC > > FreeBSD src repository > > Modified files: > etc/rc.d wpa_supplicant > etc/defaults rc.conf > Log: > o add rc.conf knobs to set the wpa_supplicant program, logging flags, > and config file > o change default logging options from -q to -s (log to syslog); this > is currently broken for boot-time startup as syslogd is started too > late but that'll be dealt with separately > > Reviewed by: brooks From emax at FreeBSD.org Tue Apr 8 23:34:13 2008 From: emax at FreeBSD.org (Maksim Yevmenkin) Date: Tue Apr 8 23:34:16 2008 Subject: cvs commit: src/etc/rc.d Makefile rfcomm_pppd_server src/share/man/man5 rc.conf.5 Message-ID: <200804082334.m38NYDrM005172@repoman.freebsd.org> emax 2008-04-08 23:34:12 UTC FreeBSD src repository Modified files: etc/rc.d Makefile share/man/man5 rc.conf.5 Added files: etc/rc.d rfcomm_pppd_server Log: Add rfcomm_pppd_server rc script to allow start rfcomm_pppd(8) in server mode at boot time. Multiple profiles can be started at the same time. The whole idea is very similar to the ppp rc script. Document Bluetooth knobs in rc.conf(5) MFC after: 1 week Revision Changes Path 1.90 +1 -1 src/etc/rc.d/Makefile 1.1 +122 -0 src/etc/rc.d/rfcomm_pppd_server (new) 1.338 +106 -0 src/share/man/man5/rc.conf.5 From emax at FreeBSD.org Tue Apr 8 23:50:04 2008 From: emax at FreeBSD.org (Maksim Yevmenkin) Date: Tue Apr 8 23:50:09 2008 Subject: cvs commit: src/etc/defaults rc.conf Message-ID: <200804082350.m38No3SV009479@repoman.freebsd.org> emax 2008-04-08 23:50:03 UTC FreeBSD src repository Modified files: etc/defaults rc.conf Log: Set defaults for the rfcomm_pppd_server rc script MFC after: 1 week Revision Changes Path 1.330 +13 -0 src/etc/defaults/rc.conf From thompsa at FreeBSD.org Wed Apr 9 00:38:33 2008 From: thompsa at FreeBSD.org (Andrew Thompson) Date: Wed Apr 9 00:38:35 2008 Subject: cvs commit: src/sys/net if_gif.c Message-ID: <200804090038.m390cXSS012122@repoman.freebsd.org> thompsa 2008-04-09 00:38:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/net if_gif.c Log: MFC r1.68 Improve EtherIP interaction with the bridge Submitted by: Eugene Grosbein Revision Changes Path 1.66.2.1 +30 -2 src/sys/net/if_gif.c From thompsa at FreeBSD.org Wed Apr 9 00:47:42 2008 From: thompsa at FreeBSD.org (Andrew Thompson) Date: Wed Apr 9 00:47:49 2008 Subject: cvs commit: src/sys/net ieee8023ad_lacp.c ieee8023ad_lacp.h if_lagg.c Message-ID: <200804090047.m390lfAG021515@repoman.freebsd.org> thompsa 2008-04-09 00:47:41 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/net ieee8023ad_lacp.c ieee8023ad_lacp.h if_lagg.c Log: MFC if_lagg.c r1.26-27, ieee8023ad_lacp.c r1.13-15, ieee8023ad_lacp.h r1.9-11 - Pass any unmatched slowprotocols frames up the stack - Switch the LACP state machine over to its own mutex Revision Changes Path 1.12.2.1 +105 -129 src/sys/net/ieee8023ad_lacp.c 1.8.2.1 +48 -4 src/sys/net/ieee8023ad_lacp.h 1.19.2.6 +9 -5 src/sys/net/if_lagg.c From marcel at FreeBSD.org Wed Apr 9 01:00:39 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Wed Apr 9 01:00:45 2008 Subject: cvs commit: src/sys/powerpc/include atomic.h Message-ID: <200804090100.m3910dlQ022039@repoman.freebsd.org> marcel 2008-04-09 01:00:36 UTC FreeBSD src repository Modified files: sys/powerpc/include atomic.h Log: Reimplement atomic_add, atomic_clear, atomic_set and atomic_subtract so that all implemented variants have proper prototypes. The 8-bit, 16-bit and 64-bit variants are not implemented. This really fixes the current build breakages caused by type casting and struct aliasing rules. Revision Changes Path 1.21 +294 -272 src/sys/powerpc/include/atomic.h From marcel at FreeBSD.org Wed Apr 9 03:32:49 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Wed Apr 9 03:32:55 2008 Subject: cvs commit: src/sys/ia64/ia64 sscdisk.c Message-ID: <200804090332.m393WncO031308@repoman.freebsd.org> marcel 2008-04-09 03:32:49 UTC FreeBSD src repository Modified files: sys/ia64/ia64 sscdisk.c Log: Unbreak after removal of SI_SUB_MOUNT_ROOT. Revision Changes Path 1.35 +1 -12 src/sys/ia64/ia64/sscdisk.c From bz at FreeBSD.org Wed Apr 9 05:17:19 2008 From: bz at FreeBSD.org (Bjoern A. Zeeb) Date: Wed Apr 9 05:17:22 2008 Subject: cvs commit: src/sys/netinet ip_input.c ip_ipsec.c ip_ipsec.h Message-ID: <200804090517.m395HI7r046147@repoman.freebsd.org> bz 2008-04-09 05:17:18 UTC FreeBSD src repository Modified files: sys/netinet ip_input.c ip_ipsec.c ip_ipsec.h Log: Take the route mtu into account, if available, when sending an ICMP unreach, frag needed. Up to now we only looked at the interface MTU. Make sure to only use the minimum of the two. In case IPSEC is compiled in, loop the mtu through ip_ipsec_mtu() to avoid any further conditional maths. Without this, PMTU was broken in those cases when there was a route with a lower MTU than the MTU of the outgoing interface. PR: kern/122338 Tested by: Mark Cammidge mark peralex.com Reviewed by: silence on net@ MFC after: 2 weeks Revision Changes Path 1.335 +26 -4 src/sys/netinet/ip_input.c 1.10 +1 -2 src/sys/netinet/ip_ipsec.c 1.3 +1 -1 src/sys/netinet/ip_ipsec.h From grehan at FreeBSD.org Wed Apr 9 08:50:38 2008 From: grehan at FreeBSD.org (Peter Grehan) Date: Wed Apr 9 08:50:44 2008 Subject: cvs commit: src/sys/powerpc/fpu fpu_add.c fpu_compare.c fpu_div.c fpu_explode.c fpu_implode.c fpu_mul.c fpu_sqrt.c fpu_subr.c Message-ID: <200804090850.m398oceM069691@repoman.freebsd.org> grehan 2008-04-09 08:50:37 UTC FreeBSD src repository Modified files: sys/powerpc/fpu fpu_add.c fpu_compare.c fpu_div.c fpu_explode.c fpu_implode.c fpu_mul.c fpu_sqrt.c fpu_subr.c Log: Include before to get typedefs required by new atomic.h. Fixes tinderbox LINT build. Revision Changes Path 1.3 +1 -1 src/sys/powerpc/fpu/fpu_add.c 1.2 +1 -1 src/sys/powerpc/fpu/fpu_compare.c 1.2 +1 -1 src/sys/powerpc/fpu/fpu_div.c 1.2 +1 -1 src/sys/powerpc/fpu/fpu_explode.c 1.2 +1 -1 src/sys/powerpc/fpu/fpu_implode.c 1.2 +1 -1 src/sys/powerpc/fpu/fpu_mul.c 1.2 +1 -1 src/sys/powerpc/fpu/fpu_sqrt.c 1.3 +1 -1 src/sys/powerpc/fpu/fpu_subr.c From phk at FreeBSD.org Wed Apr 9 10:01:08 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Wed Apr 9 10:01:15 2008 Subject: cvs commit: src/usr.sbin/fifolog Makefile Makefile.inc flint.lnt src/usr.sbin/fifolog/fifolog_create Makefile fifolog.1 fifolog_create.c src/usr.sbin/fifolog/fifolog_reader Makefile fifolog_reader.c src/usr.sbin/fifolog/fifolog_writer Makefile ... Message-ID: <200804091001.m39A18AM073924@repoman.freebsd.org> phk 2008-04-09 10:01:08 UTC FreeBSD src repository Added files: (Branch: RELENG_7) usr.sbin/fifolog Makefile Makefile.inc flint.lnt usr.sbin/fifolog/fifolog_create Makefile fifolog.1 fifolog_create.c usr.sbin/fifolog/fifolog_reader Makefile fifolog_reader.c usr.sbin/fifolog/fifolog_writer Makefile fifolog_writer.c usr.sbin/fifolog/lib Makefile fifolog.h fifolog_create.c fifolog_int.c fifolog_reader.c fifolog_write.h fifolog_write_poll.c getdate.y libfifolog.h libfifolog_int.h miniobj.h Log: MFC: the fifolog tools. (Will be connected to build after a make universe check) Revision Changes Path 1.1.2.1 +10 -0 src/usr.sbin/fifolog/Makefile (new) 1.1.2.1 +13 -0 src/usr.sbin/fifolog/Makefile.inc (new) 1.1.2.1 +22 -0 src/usr.sbin/fifolog/fifolog_create/Makefile (new) 1.1.2.1 +210 -0 src/usr.sbin/fifolog/fifolog_create/fifolog.1 (new) 1.1.2.1 +105 -0 src/usr.sbin/fifolog/fifolog_create/fifolog_create.c (new) 1.2.2.1 +21 -0 src/usr.sbin/fifolog/fifolog_reader/Makefile (new) 1.2.2.1 +170 -0 src/usr.sbin/fifolog/fifolog_reader/fifolog_reader.c (new) 1.1.2.1 +16 -0 src/usr.sbin/fifolog/fifolog_writer/Makefile (new) 1.1.2.1 +105 -0 src/usr.sbin/fifolog/fifolog_writer/fifolog_writer.c (new) 1.1.2.1 +49 -0 src/usr.sbin/fifolog/flint.lnt (new) 1.1.2.1 +17 -0 src/usr.sbin/fifolog/lib/Makefile (new) 1.1.2.1 +138 -0 src/usr.sbin/fifolog/lib/fifolog.h (new) 1.1.2.1 +122 -0 src/usr.sbin/fifolog/lib/fifolog_create.c (new) 1.2.2.1 +275 -0 src/usr.sbin/fifolog/lib/fifolog_int.c (new) 1.1.2.1 +315 -0 src/usr.sbin/fifolog/lib/fifolog_reader.c (new) 1.1.2.1 +65 -0 src/usr.sbin/fifolog/lib/fifolog_write.h (new) 1.2.2.1 +416 -0 src/usr.sbin/fifolog/lib/fifolog_write_poll.c (new) 1.1.2.1 +889 -0 src/usr.sbin/fifolog/lib/getdate.y (new) 1.1.2.1 +62 -0 src/usr.sbin/fifolog/lib/libfifolog.h (new) 1.1.2.1 +45 -0 src/usr.sbin/fifolog/lib/libfifolog_int.h (new) 1.2.2.1 +66 -0 src/usr.sbin/fifolog/lib/miniobj.h (new) From flz at FreeBSD.org Wed Apr 9 15:08:31 2008 From: flz at FreeBSD.org (Florent Thoumie) Date: Wed Apr 9 15:08:37 2008 Subject: cvs commit: src/usr.sbin/pkg_install Makefile Message-ID: <200804091508.m39F8VwV040427@repoman.freebsd.org> flz 2008-04-09 15:08:31 UTC FreeBSD src repository Modified files: usr.sbin/pkg_install Makefile Log: Add a distfile target to generate a distfile to be used by the ports-mgmt/pkg_install port. Revision Changes Path 1.22 +16 -0 src/usr.sbin/pkg_install/Makefile From dfr at FreeBSD.org Wed Apr 9 15:43:20 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Wed Apr 9 15:43:27 2008 Subject: cvs commit: src/sys/nlm nlm_prot_impl.c Message-ID: <200804091543.m39FhKjs042448@repoman.freebsd.org> dfr 2008-04-09 15:43:20 UTC FreeBSD src repository Modified files: sys/nlm nlm_prot_impl.c Log: Fix a problem which stopped this from starting up on a kernel compiled without the INET6 option. Revision Changes Path 1.4 +4 -3 src/sys/nlm/nlm_prot_impl.c From xcllnt at mac.com Wed Apr 9 15:56:02 2008 From: xcllnt at mac.com (Marcel Moolenaar) Date: Wed Apr 9 15:56:19 2008 Subject: cvs commit: src/sys/powerpc/fpu fpu_add.c fpu_compare.c fpu_div.c fpu_explode.c fpu_implode.c fpu_mul.c fpu_sqrt.c fpu_subr.c In-Reply-To: <200804090850.m398oceM069691@repoman.freebsd.org> References: <200804090850.m398oceM069691@repoman.freebsd.org> Message-ID: <64C7F213-5512-4EE6-A9AB-08669B905554@mac.com> On Apr 9, 2008, at 1:50 AM, Peter Grehan wrote: > grehan 2008-04-09 08:50:37 UTC > > FreeBSD src repository > > Modified files: > sys/powerpc/fpu fpu_add.c fpu_compare.c fpu_div.c > fpu_explode.c fpu_implode.c fpu_mul.c > fpu_sqrt.c fpu_subr.c > Log: > Include before to get typedefs required > by new atomic.h. Fixes tinderbox LINT build. Thanks! -- Marcel Moolenaar xcllnt@mac.com From phk at FreeBSD.org Wed Apr 9 16:01:08 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Wed Apr 9 16:01:20 2008 Subject: cvs commit: src/usr.sbin Makefile Message-ID: <200804091601.m39G17u6044333@repoman.freebsd.org> phk 2008-04-09 16:01:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.sbin Makefile Log: MFC: Hitch fifolog tools into build Revision Changes Path 1.375.2.1 +1 -0 src/usr.sbin/Makefile From jhb at FreeBSD.org Wed Apr 9 16:17:50 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Wed Apr 9 16:17:56 2008 Subject: cvs commit: src/bin/cp cp.1 cp.c utils.c Message-ID: <200804091617.m39GHol3048697@repoman.freebsd.org> jhb 2008-04-09 16:17:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) bin/cp cp.1 cp.c utils.c Log: MFC: Add an '-a' option which maps to '-RpP'. Revision Changes Path 1.39.2.1 +6 -2 src/bin/cp/cp.1 1.57.2.1 +7 -1 src/bin/cp/cp.c 1.52.2.1 +2 -2 src/bin/cp/utils.c From rdivacky at FreeBSD.org Wed Apr 9 16:42:51 2008 From: rdivacky at FreeBSD.org (Roman Divacky) Date: Wed Apr 9 16:43:02 2008 Subject: cvs commit: src/sys/compat/linux linux_file.c Message-ID: <200804091642.m39GgohM052944@repoman.freebsd.org> rdivacky 2008-04-09 16:42:50 UTC FreeBSD src repository Modified files: sys/compat/linux linux_file.c Log: Remove using magic value of -1 to distinguish between linux_open() and linux_openat(). Instead just pass AT_FDCWD into linux_common_open() for the linux_open() case. This prevents passing -1 as a dirfd to openat() from succeeding which is wrong. Suggested by: rwatson, kib Approved by: kib (mentor) Revision Changes Path 1.112 +3 -5 src/sys/compat/linux/linux_file.c From jhb at FreeBSD.org Wed Apr 9 17:59:18 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Wed Apr 9 17:59:24 2008 Subject: cvs commit: src/sys/boot/i386/pxeldr pxeldr.S Message-ID: <200804091759.m39HxHFN074235@repoman.freebsd.org> jhb 2008-04-09 17:59:17 UTC FreeBSD src repository Modified files: sys/boot/i386/pxeldr pxeldr.S Log: Revert the previous change and let PROBE_KEYBOARD function identical to -P in boot2/gptboot. Revision Changes Path 1.17 +2 -4 src/sys/boot/i386/pxeldr/pxeldr.S From niclas.zeising at gmail.com Wed Apr 9 18:31:46 2008 From: niclas.zeising at gmail.com (Niclas Zeising) Date: Wed Apr 9 18:32:17 2008 Subject: cvs commit: src/etc/rc.d Makefile rfcomm_pppd_server src/share/man/man5 rc.conf.5 In-Reply-To: <200804082334.m38NYDrM005172@repoman.freebsd.org> References: <200804082334.m38NYDrM005172@repoman.freebsd.org> Message-ID: <47FD0603.10307@gmail.com> Maksim Yevmenkin wrote: > emax 2008-04-08 23:34:12 UTC > > FreeBSD src repository > > Modified files: > etc/rc.d Makefile > share/man/man5 rc.conf.5 > Added files: > etc/rc.d rfcomm_pppd_server > Log: > Add rfcomm_pppd_server rc script to allow start rfcomm_pppd(8) in server > mode at boot time. Multiple profiles can be started at the same time. > The whole idea is very similar to the ppp rc script. > > Document Bluetooth knobs in rc.conf(5) > > MFC after: 1 week > > Revision Changes Path > 1.90 +1 -1 src/etc/rc.d/Makefile > 1.1 +122 -0 src/etc/rc.d/rfcomm_pppd_server (new) > 1.338 +106 -0 src/share/man/man5/rc.conf.5 > _______________________________________________ > cvs-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-all > To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" > You should bumb .Dd as well. Regards! Niclas From sam at FreeBSD.org Wed Apr 9 18:40:11 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Wed Apr 9 18:40:13 2008 Subject: cvs commit: src/sys/dev/ral rt2661.c Message-ID: <200804091840.m39IeAFm081052@repoman.freebsd.org> sam 2008-04-09 18:40:10 UTC FreeBSD src repository Modified files: sys/dev/ral rt2661.c Log: fix locking botch MFC after: 1 week Revision Changes Path 1.19 +3 -1 src/sys/dev/ral/rt2661.c From mav at FreeBSD.org Wed Apr 9 19:03:19 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Wed Apr 9 19:03:21 2008 Subject: cvs commit: src/sys/netgraph ng_base.c Message-ID: <200804091903.m39J3Jhq086696@repoman.freebsd.org> mav 2008-04-09 19:03:19 UTC FreeBSD src repository Modified files: sys/netgraph ng_base.c Log: Add memory barriers to the node locking operations. Add some comments. Revision Changes Path 1.156 +32 -18 src/sys/netgraph/ng_base.c From peter at FreeBSD.org Wed Apr 9 19:05:59 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Wed Apr 9 19:06:06 2008 Subject: cvs commit: src/sys/compat/linprocfs linprocfs.c src/sys/kern kern_clock.c src/sys/sys pcpu.h resource.h Message-ID: <200804091905.m39J5xfx087212@repoman.freebsd.org> peter 2008-04-09 19:05:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/compat/linprocfs linprocfs.c sys/kern kern_clock.c sys/sys pcpu.h resource.h Log: MFC: collect per-cpu stats for %user, %system, %idle etc. Counters are stored in pcpu area and merged at collection time rather than a common set being manipulated with atomic ops. Revision Changes Path 1.115.2.1 +16 -5 src/sys/compat/linprocfs/linprocfs.c 1.202.2.2 +72 -9 src/sys/kern/kern_clock.c 1.22.2.1 +2 -0 src/sys/sys/pcpu.h 1.31.2.1 +1 -1 src/sys/sys/resource.h From peter at FreeBSD.org Wed Apr 9 19:07:34 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Wed Apr 9 19:07:45 2008 Subject: cvs commit: src/usr.bin/vmstat Makefile vmstat.8 vmstat.c Message-ID: <200804091907.m39J7YSZ087461@repoman.freebsd.org> peter 2008-04-09 19:07:34 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.bin/vmstat Makefile vmstat.8 vmstat.c Log: MFC: add -P flag etc for displaying per-cpu stats. Revision Changes Path 1.12.2.1 +2 -2 src/usr.bin/vmstat/Makefile 1.36.2.1 +9 -1 src/usr.bin/vmstat/vmstat.8 1.98.2.1 +196 -17 src/usr.bin/vmstat/vmstat.c From sam at FreeBSD.org Wed Apr 9 19:07:49 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Wed Apr 9 19:07:59 2008 Subject: cvs commit: src/sys/kern subr_firmware.c Message-ID: <200804091907.m39J7nQb087521@repoman.freebsd.org> sam 2008-04-09 19:07:49 UTC FreeBSD src repository Modified files: sys/kern subr_firmware.c Log: Do image loading in a context known to have a root directory: o create a private task queue thread that sets up root and current directories (hooking mountroot event as needed); this is necessary because task queue threads are parented from proc0 and it does not have a reference to rootvnode (lost when / mounting moved to init) o bounce image load + unload requests through the private task q so we can load images even when the request is made from a thread that does not have sufficient context (e.g. task q thread) o add a check in the task q thread to fail requests before root is mounted (just in case) Reviewed by: jhb, mlaier, luigi (glance) MFC after: 1 month Revision Changes Path 1.10 +121 -23 src/sys/kern/subr_firmware.c From peter at FreeBSD.org Wed Apr 9 19:08:44 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Wed Apr 9 19:08:52 2008 Subject: cvs commit: src/contrib/top display.c layout.h machine.h top.c top.h src/usr.bin/top machine.c Message-ID: <200804091908.m39J8hmF087684@repoman.freebsd.org> peter 2008-04-09 19:08:43 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) contrib/top display.c layout.h machine.h top.c top.h usr.bin/top machine.c Log: MFC: merge -P flag for displaying per-cpu %user/%system/%idle states. Revision Changes Path 1.9.10.1 +70 -18 src/contrib/top/display.c 1.2.50.1 +22 -20 src/contrib/top/layout.h 1.9.2.1 +4 -1 src/contrib/top/machine.h 1.23.2.2 +11 -2 src/contrib/top/top.c 1.4.2.1 +4 -2 src/contrib/top/top.h 1.82.2.2 +95 -5 src/usr.bin/top/machine.c From wearabnet at yahoo.ca Wed Apr 9 19:34:03 2008 From: wearabnet at yahoo.ca (Abdullah Ibn Hamad Al-Marri) Date: Wed Apr 9 19:34:19 2008 Subject: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h Message-ID: <968902.70296.qm@web33708.mail.mud.yahoo.com> ----- Original Message ---- > From: Pyun YongHyeon > To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; cvs-all@FreeBSD.org > Sent: Monday, March 31, 2008 7:03:14 AM > Subject: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h > > yongari 2008-03-31 04:03:14 UTC > > FreeBSD src repository > > Modified files: > sys/dev/re if_re.c > sys/pci if_rlreg.h > Log: > Padding more bytes than necessary one broke another variants of > PCIe RealTek chips. Only pad IP packets if the payload is less than > 28 bytes. > > Obtained from: NetBSD > PR: kern/122221 > > Revision Changes Path > 1.113 +1 -1 src/sys/dev/re/if_re.c > 1.74 +6 -0 src/sys/pci/if_rlreg.h Hello Pyun, I hope you are doing well. This is a friendly reminder... It has been more than a week since you said you'll MFC the re changes to RELENG_7 I still suffer of the current patch and the re poor performance. Thank you in advance, --- Regards, -Abdullah Ibn Hamad Al-Marri Arab Portal http://www.WeArab.Net/ __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com From peter at FreeBSD.org Wed Apr 9 19:47:21 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Wed Apr 9 19:47:31 2008 Subject: cvs commit: src/sys/compat/linprocfs linprocfs.c src/sys/kern kern_clock.c src/sys/sys pcpu.h resource.h Message-ID: <200804091947.m39JlKHW093641@repoman.freebsd.org> peter 2008-04-09 19:47:20 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/compat/linprocfs linprocfs.c sys/kern kern_clock.c sys/sys pcpu.h resource.h Log: MFC: record per-cpu stats for %user/%nice/%system/%idle Revision Changes Path 1.89.2.8 +16 -5 src/sys/compat/linprocfs/linprocfs.c 1.178.2.5 +68 -5 src/sys/kern/kern_clock.c 1.16.2.1 +2 -0 src/sys/sys/pcpu.h 1.29.2.1 +1 -1 src/sys/sys/resource.h From peter at FreeBSD.org Wed Apr 9 19:48:07 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Wed Apr 9 19:48:19 2008 Subject: cvs commit: src/contrib/top display.c layout.h machine.h top.c top.h src/usr.bin/top machine.c src/usr.bin/vmstat Makefile vmstat.8 vmstat.c Message-ID: <200804091948.m39Jm6Ao093803@repoman.freebsd.org> peter 2008-04-09 19:48:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) contrib/top display.c layout.h machine.h top.c top.h usr.bin/top machine.c usr.bin/vmstat Makefile vmstat.8 vmstat.c Log: MFC: backport -P (per-cpu) stats for %user/%system/%idle etc. Revision Changes Path 1.9.2.1 +70 -18 src/contrib/top/display.c 1.2.40.1 +22 -20 src/contrib/top/layout.h 1.7.2.3 +4 -1 src/contrib/top/machine.h 1.17.2.4 +14 -2 src/contrib/top/top.c 1.3.8.1 +4 -2 src/contrib/top/top.h 1.74.2.3 +95 -5 src/usr.bin/top/machine.c 1.11.8.2 +2 -2 src/usr.bin/vmstat/Makefile 1.32.2.2 +9 -1 src/usr.bin/vmstat/vmstat.8 1.86.2.7 +196 -17 src/usr.bin/vmstat/vmstat.c From davidch at broadcom.com Wed Apr 9 20:17:02 2008 From: davidch at broadcom.com (David Christensen) Date: Wed Apr 9 20:17:14 2008 Subject: cvs commit: src/sys/dev/bce if_bce.c if_bcefw.h if_bcereg.h In-Reply-To: References: <200802220046.m1M0kMPM008814@repoman.freebsd.org> <5D267A3F22FD854F8F48B3D2B523819324EF633FCC@IRVEXCHCCR01.corp.ad.broadcom.com> Message-ID: <5D267A3F22FD854F8F48B3D2B523819324EF6DEE3B@IRVEXCHCCR01.corp.ad.broadcom.com> > On 8.0/i386, with PAE enabled, I get messages on the console and the > system hangs when trying to do a nfs mount. Backing out the driver > fixes it. The same driver doesn't cause quite as spectacular a > failure on 8.0/amd64, but it isn't exactly happy.. > > Additional IP options:.^M > Mounting NFS file systebcms:e1: link state changed to UP^M > bce1: discard frame w/o leading ethernet header (len 0 pkt len 0)^M > bce1: discard frame w/o leading ethernet header (len 0 pkt len 0)^M > bce1: discard frame w/o leading ethernet header (len 0 pkt len 0)^M > bce1: discard frame w/o leading ethernet header (len 0 pkt len 0)^M > [..forever..] > > NFS over UDP, fwiw. Server is a netapp. I may have found the performance problem. It looks like an issue with handling the producer/consumer indices for the send ring that would cause outgoing frames to just sit there until a received frame came in and kickstarted the interrupt handler. This is consistent with your observation that enabling promiscuous mode seemed to make things better, there's more received traffic. I found that pinging the SUT from another system has the same effect. Can you try the attached patch to head and let me know? I tested on RELENG_7 and I haven't seen the discard errors yet. Dave -------------- next part -------------- A non-text attachment was scrubbed... Name: if_bcereg.patch Type: application/octet-stream Size: 890 bytes Desc: if_bcereg.patch Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080409/5ed4d565/if_bcereg.obj -------------- next part -------------- A non-text attachment was scrubbed... Name: if_bce.patch Type: application/octet-stream Size: 13993 bytes Desc: if_bce.patch Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080409/5ed4d565/if_bce.obj From pjd at FreeBSD.org Wed Apr 9 20:19:56 2008 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Wed Apr 9 20:20:07 2008 Subject: cvs commit: src/sys/kern vfs_cache.c Message-ID: <200804092019.m39KJthN000768@repoman.freebsd.org> pjd 2008-04-09 20:19:55 UTC FreeBSD src repository Modified files: sys/kern vfs_cache.c Log: - Use LK_TYPE_MASK where needed. Actually after sys/sys/lockmgr.h:1.69 it is no longer needed, but for now we still want to be consistent with other similar checks in the tree. - Call ASSERT_VOP_ELOCKED() only when vget() returns 0. Reviewed by: jeff Revision Changes Path 1.121 +5 -3 src/sys/kern/vfs_cache.c From kan at FreeBSD.org Wed Apr 9 20:27:53 2008 From: kan at FreeBSD.org (Alexander Kabaev) Date: Wed Apr 9 20:28:04 2008 Subject: cvs commit: src/share/mk bsd.lib.mk Message-ID: <200804092027.m39KRrxN002033@repoman.freebsd.org> kan 2008-04-09 20:27:53 UTC FreeBSD src repository Modified files: share/mk bsd.lib.mk Log: Fix spelling mistake in comment. Revision Changes Path 1.184 +1 -1 src/share/mk/bsd.lib.mk From marius at FreeBSD.org Wed Apr 9 21:14:02 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Wed Apr 9 21:14:08 2008 Subject: cvs commit: src/sys/sparc64/include intr_machdep.h smp.h src/sys/sparc64/sparc64 intr_machdep.c mp_machdep.c Message-ID: <200804092114.m39LE18A019634@repoman.freebsd.org> marius 2008-04-09 21:14:01 UTC FreeBSD src repository Modified files: sys/sparc64/include intr_machdep.h smp.h sys/sparc64/sparc64 intr_machdep.c mp_machdep.c Log: - Add support for IPI_PREEMPT. [1] - Add my copyright to mp_machdep.c for having implemented support for USIII and up and some fixes. Obtained from: sun4v (modulo style(9) bugs) [1] Revision Changes Path 1.18 +2 -1 src/sys/sparc64/include/intr_machdep.h 1.23 +1 -0 src/sys/sparc64/include/smp.h 1.32 +2 -1 src/sys/sparc64/sparc64/intr_machdep.c 1.39 +10 -0 src/sys/sparc64/sparc64/mp_machdep.c From emax at FreeBSD.org Wed Apr 9 21:24:12 2008 From: emax at FreeBSD.org (Maksim Yevmenkin) Date: Wed Apr 9 21:24:26 2008 Subject: cvs commit: src/share/man/man5 rc.conf.5 Message-ID: <200804092124.m39LOBfO021368@repoman.freebsd.org> emax 2008-04-09 21:24:11 UTC FreeBSD src repository Modified files: share/man/man5 rc.conf.5 Log: Update .Dd Pointed out by: Niclas Zeising MFC after: 1 week Revision Changes Path 1.339 +1 -1 src/share/man/man5/rc.conf.5 From flz at FreeBSD.org Wed Apr 9 22:20:28 2008 From: flz at FreeBSD.org (Florent Thoumie) Date: Wed Apr 9 22:20:35 2008 Subject: cvs commit: src/sys/dev/usb ubsa.c usbdevs Message-ID: <200804092220.m39MKS55031576@repoman.freebsd.org> flz 2008-04-09 22:20:28 UTC FreeBSD src repository Modified files: sys/dev/usb ubsa.c usbdevs Log: Add support for Verizon v740 to ubsa(4). PR: usb/122610 Submitted by: Randi Harper MFC after: 3 days Revision Changes Path 1.35 +2 -0 src/sys/dev/usb/ubsa.c 1.346 +1 -0 src/sys/dev/usb/usbdevs From delphij at FreeBSD.org Thu Apr 10 00:12:48 2008 From: delphij at FreeBSD.org (Xin LI) Date: Thu Apr 10 00:12:50 2008 Subject: cvs commit: src/include string.h src/sys/sys param.h src/lib/libc/string Makefile.inc Symbol.map memchr.3 memrchr.c Message-ID: <200804100012.m3A0CjvM058340@repoman.freebsd.org> delphij 2008-04-10 00:12:44 UTC FreeBSD src repository Modified files: include string.h sys/sys param.h lib/libc/string Makefile.inc Symbol.map memchr.3 Added files: lib/libc/string memrchr.c Log: Add memrchr(3). Obtained from: OpenBSD Revision Changes Path 1.26 +1 -0 src/include/string.h 1.38 +2 -1 src/lib/libc/string/Makefile.inc 1.3 +4 -0 src/lib/libc/string/Symbol.map 1.10 +28 -3 src/lib/libc/string/memchr.3 1.1 +40 -0 src/lib/libc/string/memrchr.c (new) 1.350 +1 -1 src/sys/sys/param.h From delphij at FreeBSD.org Thu Apr 10 00:25:54 2008 From: delphij at FreeBSD.org (Xin LI) Date: Thu Apr 10 00:26:01 2008 Subject: cvs commit: src/etc/rc.d mountlate root Message-ID: <200804100025.m3A0Prh7060398@repoman.freebsd.org> delphij 2008-04-10 00:25:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) etc/rc.d mountlate root Log: MFC: Do nextboot -D twice during boot. The first time in rc.d/root which ensures that we can remove the file as early as possible, but shut up nextboot at this moment if the operation is failed, because /boot is not necessarily a part of /; the newly added second run is placed in rc.d/mountlate after all filesystems were mounted. Revision Changes Path 1.2.2.2 +6 -0 src/etc/rc.d/mountlate 1.15.2.2 +1 -1 src/etc/rc.d/root From yongari at FreeBSD.org Thu Apr 10 01:06:06 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Thu Apr 10 01:06:10 2008 Subject: cvs commit: src/sys/pci if_rl.c Message-ID: <200804100106.m3A165vl076373@repoman.freebsd.org> yongari 2008-04-10 01:06:05 UTC FreeBSD src repository Modified files: sys/pci if_rl.c Log: It seems that RealTek 8129/8139 chip reports invalid length of received frame under certain conditions. wpaul said the length 0xfff0 is special meaning that indicates hardware is in the process of copying a packet into host memory. But it seems there are other cases that hardware is busy or stuck in bad situation even if the received frame length is not 0xfff0. To work-around this condition, add a check that verifys that recevied frame length is in valid range. If received length is out of range reinitialize hardware to recover from stuck condition. Reported by: Mike Tancsa ( mike AT sentex DOT net ) Tested by: Mike Tancsa Obtained from: OpenBSD MFC after: 1 week Revision Changes Path 1.174 +5 -3 src/sys/pci/if_rl.c From yongari at FreeBSD.org Thu Apr 10 01:25:10 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Thu Apr 10 01:25:16 2008 Subject: cvs commit: src/sys/dev/nfe if_nfe.c if_nfereg.h Message-ID: <200804100125.m3A1P9RE076990@repoman.freebsd.org> yongari 2008-04-10 01:25:09 UTC FreeBSD src repository Modified files: sys/dev/nfe if_nfe.c if_nfereg.h Log: Add support for MCP73 chips. Tested by: "Daan Vreeken [PA4DAN]" ( Danovitsch AT vitsch DOT net ) MFC after: 1 week Revision Changes Path 1.28 +12 -0 src/sys/dev/nfe/if_nfe.c 1.12 +4 -0 src/sys/dev/nfe/if_nfereg.h From brooks at FreeBSD.org Thu Apr 10 01:32:55 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Thu Apr 10 01:33:06 2008 Subject: cvs commit: src/etc/rc.d ppp Message-ID: <200804100132.m3A1WnQx077222@repoman.freebsd.org> brooks 2008-04-10 01:32:49 UTC FreeBSD src repository Modified files: etc/rc.d ppp Log: Declare _ppp_profile_cleaned, _punct, and _punct_c local in ppp_start_profile(). Reported by: yar MFC after: 1 week Revision Changes Path 1.20 +1 -0 src/etc/rc.d/ppp From marcel at FreeBSD.org Thu Apr 10 02:37:26 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Thu Apr 10 02:37:33 2008 Subject: cvs commit: src/sys/powerpc/include atomic.h Message-ID: <200804100237.m3A2bQEb080376@repoman.freebsd.org> marcel 2008-04-10 02:37:26 UTC FreeBSD src repository Modified files: sys/powerpc/include atomic.h Log: Fix copy-n-paste typos in free text. Revision Changes Path 1.22 +3 -3 src/sys/powerpc/include/atomic.h From peter at FreeBSD.org Thu Apr 10 02:44:45 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Thu Apr 10 02:44:51 2008 Subject: cvs commit: src/sys/kern kern_clock.c Message-ID: <200804100244.m3A2iilr080603@repoman.freebsd.org> peter 2008-04-10 02:44:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern kern_clock.c Log: MFC: rev 1.205: compile on systems without SCTL_MASK32 Revision Changes Path 1.202.2.3 +2 -1 src/sys/kern/kern_clock.c From peter at FreeBSD.org Thu Apr 10 02:45:40 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Thu Apr 10 02:45:50 2008 Subject: cvs commit: src/sys/kern kern_clock.c Message-ID: <200804100245.m3A2jdCO080694@repoman.freebsd.org> peter 2008-04-10 02:45:39 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern kern_clock.c Log: MFC: rev 1.205: compile on systems without SCTL_MASK32 Revision Changes Path 1.178.2.6 +2 -1 src/sys/kern/kern_clock.c From thompsa at FreeBSD.org Thu Apr 10 04:01:27 2008 From: thompsa at FreeBSD.org (Andrew Thompson) Date: Thu Apr 10 04:01:30 2008 Subject: cvs commit: src/sys/net if_bridge.c if_bridgevar.h src/sbin/ifconfig ifbridge.c ifconfig.8 Message-ID: <200804100401.m3A41R9x084387@repoman.freebsd.org> thompsa 2008-04-10 04:01:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/net if_bridge.c if_bridgevar.h sbin/ifconfig ifbridge.c ifconfig.8 Log: MFC if_bridge.c r1.106, if_bridgevar.h r1.24 ifbridge.c r1.12, ifconfig.8 r1.144 Add an option to limit the number of source MACs that can be behind a bridge interface. Revision Changes Path 1.11.2.1 +28 -6 src/sbin/ifconfig/ifbridge.c 1.142.2.3 +5 -0 src/sbin/ifconfig/ifconfig.8 1.103.2.4 +86 -23 src/sys/net/if_bridge.c 1.23.2.2 +5 -1 src/sys/net/if_bridgevar.h From thompsa at FreeBSD.org Thu Apr 10 05:03:56 2008 From: thompsa at FreeBSD.org (Andrew Thompson) Date: Thu Apr 10 05:04:04 2008 Subject: cvs commit: src/sys/net if_bridge.c Message-ID: <200804100503.m3A53txM097914@repoman.freebsd.org> thompsa 2008-04-10 05:03:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/net if_bridge.c Log: Sync to HEAD. - Simplify the error handling - Nuke licence clause 3 & 4 - Drop frames to any of the reserved multicast addresses - Remove duplicated code for testing local packets. Revision Changes Path 1.103.2.5 +67 -106 src/sys/net/if_bridge.c From tevans.uk at googlemail.com Thu Apr 10 09:20:53 2008 From: tevans.uk at googlemail.com (Tom Evans) Date: Thu Apr 10 09:20:58 2008 Subject: cvs commit: src/sys/fs/ntfs ntfs_subr.c In-Reply-To: <20080330104855.N7523@fledge.watson.org> References: <200803300219.m2U2JSjv016162@repoman.freebsd.org> <47EEF9CA.9080008@gmail.com> <20080330104855.N7523@fledge.watson.org> Message-ID: <1207817640.77243.5.camel@localhost> On Sun, 2008-03-30 at 10:51 +0100, Robert Watson wrote: > On Sat, 29 Mar 2008, Aryeh M. Friedman wrote: > > > Christian S.J. Peron wrote: > >> csjp 2008-03-30 02:19:27 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: (Branch: RELENG_7) > >> sys/fs/ntfs ntfs_subr.c Log: > >> Un-break the build by adding a thread argument. This was removed > in > >> -CURRENT but this change has not been MFCed yet. > >> Submitted by: attilo > >> Revision Changes Path > >> 1.42.2.2 +1 -1 src/sys/fs/ntfs/ntfs_subr.c > > > > I know this question should be else where but since the kernel ntfs > doesn't > > allow for writting and fusefs-ntfs is stable why is ntfs still in > the kernel > > and if it should be there why not replace it with fuse? > > That question was asked on arch@ recently, and you might want to go > read its > conclusions. They seem quite contrary to the observations you > make :-). > > Robert N M Watson > Computer Laboratory > University of Cambridge Perhaps as well as arch@ it was also discussed at length on fs@ http://lists.freebsd.org/pipermail/freebsd-fs/2008-February/004310.html Regards -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: This is a digitally signed message part Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080410/d85cd432/attachment.pgp From dfr at FreeBSD.org Thu Apr 10 09:39:30 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Thu Apr 10 09:39:38 2008 Subject: cvs commit: src/lib/libc/gen lockf.c src/lib/libc/include libc_private.h src/lib/libc/rpc svc_vc.c src/lib/libc/sys Makefile.inc Symbol.map fcntl.2 fcntl.c src/lib/libc/xdr xdr_rec.c src/sys/amd64/conf GENERIC src/sys/arm/conf AVILA BWCT CRB EP80219 ... Message-ID: <200804100939.m3A9dUFu028748@repoman.freebsd.org> dfr 2008-04-10 09:39:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libc/gen lockf.c lib/libc/include libc_private.h lib/libc/rpc svc_vc.c lib/libc/sys Makefile.inc Symbol.map fcntl.2 lib/libc/xdr xdr_rec.c sys/amd64/conf GENERIC sys/arm/conf AVILA BWCT CRB EP80219 HL200 IQ31244 KB920X SIMICS SKYEYE sys/compat/freebsd32 syscalls.master sys/compat/linux linux_file.c sys/compat/svr4 svr4_fcntl.c sys/conf NOTES files options sys/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c sys/fs/msdosfs msdosfs_vnops.c sys/fs/tmpfs tmpfs_vnops.c sys/i386/conf GENERIC XBOX sys/i386/ibcs2 ibcs2_fcntl.c sys/ia64/conf GENERIC sys/kern kern_descrip.c kern_lockf.c syscalls.master vnode_if.src sys/modules Makefile sys/nfs4client nfs4_vnops.c sys/nfsclient nfs_lock.c nfs_vnops.c sys/pc98/conf GENERIC sys/powerpc/conf GENERIC sys/rpc types.h sys/sparc64/conf GENERIC sys/sun4v/conf GENERIC sys/sys fcntl.h lockf.h param.h sys/ufs/ufs ufs_vnops.c usr.sbin Makefile usr.sbin/rpc.lockd lockd.c usr.sbin/rpc.statd statd.c Added files: (Branch: RELENG_7) lib/libc/sys fcntl.c sys/modules/krpc Makefile sys/modules/nfslockd Makefile sys/nlm nlm.h nlm_prot.h nlm_prot_clnt.c nlm_prot_impl.c nlm_prot_server.c nlm_prot_svc.c nlm_prot_xdr.c sm_inter.h sm_inter_xdr.c sys/rpc auth.h auth_none.c auth_unix.c authunix_prot.c clnt.h clnt_dg.c clnt_rc.c clnt_stat.h clnt_vc.c getnetconfig.c inet_ntop.c inet_pton.c netconfig.h nettype.h pmap_prot.h rpc.h rpc_callmsg.c rpc_com.h rpc_generic.c rpc_msg.h rpc_prot.c rpcb_clnt.c rpcb_clnt.h rpcb_prot.c rpcb_prot.h svc.c svc.h svc_auth.c svc_auth.h svc_auth_unix.c svc_dg.c svc_generic.c svc_vc.c xdr.h sys/xdr xdr.c xdr_array.c xdr_mbuf.c xdr_mem.c xdr_reference.c xdr_sizeof.c tools/regression/file/flock Makefile flock.c usr.sbin/clear_locks Makefile clear_locks.8 clear_locks.c Log: MFC: Kernel mode Network Lock Manager. Revision Changes Path 1.8.24.1 +1 -1 src/lib/libc/gen/lockf.c 1.17.2.1 +3 -0 src/lib/libc/include/libc_private.h 1.26.2.1 +2 -1 src/lib/libc/rpc/svc_vc.c 1.127.2.2 +2 -1 src/lib/libc/sys/Makefile.inc 1.9.2.1 +1 -0 src/lib/libc/sys/Symbol.map 1.45.2.1 +7 -2 src/lib/libc/sys/fcntl.2 1.1.2.1 +87 -0 src/lib/libc/sys/fcntl.c (new) 1.21.10.1 +6 -0 src/lib/libc/xdr/xdr_rec.c 1.484.2.6 +1 -0 src/sys/amd64/conf/GENERIC 1.6.2.1 +1 -0 src/sys/arm/conf/AVILA 1.2.2.1 +1 -0 src/sys/arm/conf/BWCT 1.2.2.1 +1 -0 src/sys/arm/conf/CRB 1.5.2.1 +1 -0 src/sys/arm/conf/EP80219 1.2.2.2 +1 -0 src/sys/arm/conf/HL200 1.19.2.1 +1 -0 src/sys/arm/conf/IQ31244 1.13.2.1 +1 -0 src/sys/arm/conf/KB920X 1.13.2.1 +1 -0 src/sys/arm/conf/SIMICS 1.7.2.1 +1 -0 src/sys/arm/conf/SKYEYE 1.91.2.3 +2 -1 src/sys/compat/freebsd32/syscalls.master 1.105.2.2 +2 -0 src/sys/compat/linux/linux_file.c 1.40.2.1 +2 -2 src/sys/compat/svr4/svr4_fcntl.c 1.1454.2.6 +1 -0 src/sys/conf/NOTES 1.1243.2.13 +32 -0 src/sys/conf/files 1.608.2.3 +2 -0 src/sys/conf/options 1.24.2.1 +20 -0 src/sys/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c 1.179.2.1 +18 -0 src/sys/fs/msdosfs/msdosfs_vnops.c 1.11.2.2 +15 -0 src/sys/fs/tmpfs/tmpfs_vnops.c 1.474.2.6 +1 -0 src/sys/i386/conf/GENERIC 1.7.4.1 +1 -0 src/sys/i386/conf/XBOX 1.28.10.1 +2 -1 src/sys/i386/ibcs2/ibcs2_fcntl.c 1.92.2.1 +1 -0 src/sys/ia64/conf/GENERIC 1.313.2.2 +66 -7 src/sys/kern/kern_descrip.c 1.57.2.1 +1905 -471 src/sys/kern/kern_lockf.c 1.233.2.1 +2 -1 src/sys/kern/syscalls.master 1.87.2.1 +13 -0 src/sys/kern/vnode_if.src 1.540.2.10 +2 -0 src/sys/modules/Makefile 1.1.2.1 +44 -0 src/sys/modules/krpc/Makefile (new) 1.1.2.1 +23 -0 src/sys/modules/nfslockd/Makefile (new) 1.37.2.1 +18 -0 src/sys/nfs4client/nfs4_vnops.c 1.45.2.1 +1 -0 src/sys/nfsclient/nfs_lock.c 1.276.2.2 +23 -0 src/sys/nfsclient/nfs_vnops.c 1.1.2.1 +119 -0 src/sys/nlm/nlm.h (new) 1.1.2.1 +448 -0 src/sys/nlm/nlm_prot.h (new) 1.2.2.1 +372 -0 src/sys/nlm/nlm_prot_clnt.c (new) 1.4.2.1 +1817 -0 src/sys/nlm/nlm_prot_impl.c (new) 1.2.2.1 +762 -0 src/sys/nlm/nlm_prot_server.c (new) 1.2.2.1 +509 -0 src/sys/nlm/nlm_prot_svc.c (new) 1.2.2.1 +454 -0 src/sys/nlm/nlm_prot_xdr.c (new) 1.1.2.1 +112 -0 src/sys/nlm/sm_inter.h (new) 1.2.2.1 +107 -0 src/sys/nlm/sm_inter_xdr.c (new) 1.297.2.3 +1 -0 src/sys/pc98/conf/GENERIC 1.71.2.5 +1 -0 src/sys/powerpc/conf/GENERIC 1.1.2.1 +361 -0 src/sys/rpc/auth.h (new) 1.1.2.1 +148 -0 src/sys/rpc/auth_none.c (new) 1.2.2.1 +299 -0 src/sys/rpc/auth_unix.c (new) 1.2.2.1 +122 -0 src/sys/rpc/authunix_prot.c (new) 1.1.2.1 +620 -0 src/sys/rpc/clnt.h (new) 1.2.2.1 +865 -0 src/sys/rpc/clnt_dg.c (new) 1.2.2.1 +307 -0 src/sys/rpc/clnt_rc.c (new) 1.1.2.1 +83 -0 src/sys/rpc/clnt_stat.h (new) 1.2.2.1 +827 -0 src/sys/rpc/clnt_vc.c (new) 1.1.2.1 +138 -0 src/sys/rpc/getnetconfig.c (new) 1.2.2.1 +187 -0 src/sys/rpc/inet_ntop.c (new) 1.2.2.1 +228 -0 src/sys/rpc/inet_pton.c (new) 1.1.2.1 +99 -0 src/sys/rpc/netconfig.h (new) 1.1.2.1 +68 -0 src/sys/rpc/nettype.h (new) 1.1.2.1 +107 -0 src/sys/rpc/pmap_prot.h (new) 1.1.2.1 +125 -0 src/sys/rpc/rpc.h (new) 1.1.2.1 +200 -0 src/sys/rpc/rpc_callmsg.c (new) 1.1.2.1 +126 -0 src/sys/rpc/rpc_com.h (new) 1.3.2.1 +741 -0 src/sys/rpc/rpc_generic.c (new) 1.1.2.1 +214 -0 src/sys/rpc/rpc_msg.h (new) 1.1.2.1 +348 -0 src/sys/rpc/rpc_prot.c (new) 1.2.2.1 +1382 -0 src/sys/rpc/rpcb_clnt.c (new) 1.1.2.1 +89 -0 src/sys/rpc/rpcb_clnt.h (new) 1.1.2.1 +244 -0 src/sys/rpc/rpcb_prot.c (new) 1.1.2.1 +579 -0 src/sys/rpc/rpcb_prot.h (new) 1.2.2.1 +574 -0 src/sys/rpc/svc.c (new) 1.1.2.1 +614 -0 src/sys/rpc/svc.h (new) 1.1.2.1 +133 -0 src/sys/rpc/svc_auth.c (new) 1.1.2.1 +67 -0 src/sys/rpc/svc_auth.h (new) 1.2.2.1 +144 -0 src/sys/rpc/svc_auth_unix.c (new) 1.2.2.1 +334 -0 src/sys/rpc/svc_dg.c (new) 1.2.2.1 +407 -0 src/sys/rpc/svc_generic.c (new) 1.2.2.1 +746 -0 src/sys/rpc/svc_vc.c (new) 1.12.2.1 +17 -7 src/sys/rpc/types.h 1.1.2.1 +368 -0 src/sys/rpc/xdr.h (new) 1.127.2.2 +1 -0 src/sys/sparc64/conf/GENERIC 1.14.2.2 +1 -0 src/sys/sun4v/conf/GENERIC 1.16.18.1 +24 -3 src/sys/sys/fcntl.h 1.20.2.1 +70 -18 src/sys/sys/lockf.h 1.308.2.7 +1 -1 src/sys/sys/param.h 1.291.2.2 +21 -0 src/sys/ufs/ufs/ufs_vnops.c 1.1.2.1 +816 -0 src/sys/xdr/xdr.c (new) 1.1.2.1 +155 -0 src/sys/xdr/xdr_array.c (new) 1.1.2.1 +238 -0 src/sys/xdr/xdr_mbuf.c (new) 1.1.2.1 +232 -0 src/sys/xdr/xdr_mem.c (new) 1.1.2.1 +135 -0 src/sys/xdr/xdr_reference.c (new) 1.1.2.1 +162 -0 src/sys/xdr/xdr_sizeof.c (new) 1.1.2.1 +7 -0 src/tools/regression/file/flock/Makefile (new) 1.2.2.1 +1356 -0 src/tools/regression/file/flock/flock.c (new) 1.375.2.2 +1 -0 src/usr.sbin/Makefile 1.2.2.1 +9 -0 src/usr.sbin/clear_locks/Makefile (new) 1.1.2.1 +51 -0 src/usr.sbin/clear_locks/clear_locks.8 (new) 1.1.2.1 +70 -0 src/usr.sbin/clear_locks/clear_locks.c (new) 1.20.2.2 +262 -16 src/usr.sbin/rpc.lockd/lockd.c 1.15.2.1 +3 -0 src/usr.sbin/rpc.statd/statd.c From dfr at FreeBSD.org Thu Apr 10 09:40:12 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Thu Apr 10 09:40:18 2008 Subject: cvs commit: src/sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c src/sys/kern init_sysent.c syscalls.c systrace_args.c src/sys/sys syscall.h syscall.mk sysproto.h Message-ID: <200804100940.m3A9e6uN028919@repoman.freebsd.org> dfr 2008-04-10 09:40:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/compat/freebsd32 freebsd32_proto.h freebsd32_syscall.h freebsd32_syscalls.c freebsd32_sysent.c sys/kern init_sysent.c syscalls.c systrace_args.c sys/sys syscall.h syscall.mk sysproto.h Log: Regen. Revision Changes Path 1.78.2.2 +1 -1 src/sys/compat/freebsd32/freebsd32_proto.h 1.76.2.2 +1 -1 src/sys/compat/freebsd32/freebsd32_syscall.h 1.67.2.2 +2 -2 src/sys/compat/freebsd32/freebsd32_syscalls.c 1.77.2.2 +2 -2 src/sys/compat/freebsd32/freebsd32_sysent.c 1.230.2.1 +2 -2 src/sys/kern/init_sysent.c 1.214.2.1 +2 -2 src/sys/kern/syscalls.c 1.14.2.1 +10 -0 src/sys/kern/systrace_args.c 1.211.2.1 +2 -1 src/sys/sys/syscall.h 1.166.2.1 +2 -1 src/sys/sys/syscall.mk 1.215.2.1 +9 -1 src/sys/sys/sysproto.h From kris at FreeBSD.org Thu Apr 10 09:55:44 2008 From: kris at FreeBSD.org (Kris Kennaway) Date: Thu Apr 10 09:55:50 2008 Subject: cvs commit: src/lib/libc/gen lockf.c src/lib/libc/include libc_private.h src/lib/libc/rpc svc_vc.c src/lib/libc/sys Makefile.inc Symbol.map fcntl.2 fcntl.c src/lib/libc/xdr xdr_rec.c src/sys/amd64/conf GENERIC src/sys/arm/conf AVILA BWCT CRB EP80219 ... In-Reply-To: <200804100939.m3A9dUFu028748@repoman.freebsd.org> References: <200804100939.m3A9dUFu028748@repoman.freebsd.org> Message-ID: <47FDE41D.5090601@FreeBSD.org> Doug Rabson wrote: > dfr 2008-04-10 09:39:29 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_7) > lib/libc/gen lockf.c Hmm, I am concerned by this quick merge because rpc.lockd is still not usable for me on HEAD. I had to disable it entirely on all of my client machines because it will usually hang and become unkillable when locking files over NFS (when interoperating with a 7.0 server). I haven't had time to get the tcpdump trace you requested because of focusing on other problems. Because of the client problems I haven't tested it at all on the server side yet. I really don't think this has received sufficient testing yet. Kris From ru at FreeBSD.org Thu Apr 10 09:56:58 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Thu Apr 10 09:57:04 2008 Subject: cvs commit: src/usr.bin/vmstat vmstat.c Message-ID: <200804100956.m3A9uw1k029975@repoman.freebsd.org> ru 2008-04-10 09:56:57 UTC FreeBSD src repository Modified files: usr.bin/vmstat vmstat.c Log: Add forgotten -H, -h, and -P to usage(). Revision Changes Path 1.101 +1 -1 src/usr.bin/vmstat/vmstat.c From dfr at rabson.org Thu Apr 10 10:22:44 2008 From: dfr at rabson.org (Doug Rabson) Date: Thu Apr 10 10:23:12 2008 Subject: cvs commit: src/lib/libc/gen lockf.c src/lib/libc/include libc_private.h src/lib/libc/rpc svc_vc.c src/lib/libc/sys Makefile.inc Symbol.map fcntl.2 fcntl.c src/lib/libc/xdr xdr_rec.c src/sys/amd64/conf GENERIC src/sys/arm/conf AVILA BWCT CRB EP80219 ... In-Reply-To: <47FDE41D.5090601@FreeBSD.org> References: <200804100939.m3A9dUFu028748@repoman.freebsd.org> <47FDE41D.5090601@FreeBSD.org> Message-ID: <9E913B4A-C81E-4AB8-AFF8-F51FC9B25721@rabson.org> On 10 Apr 2008, at 10:55, Kris Kennaway wrote: > Doug Rabson wrote: >> dfr 2008-04-10 09:39:29 UTC >> FreeBSD src repository >> Modified files: (Branch: RELENG_7) >> lib/libc/gen lockf.c > > Hmm, I am concerned by this quick merge because rpc.lockd is still > not usable for me on HEAD. I had to disable it entirely on all of > my client machines because it will usually hang and become > unkillable when locking files over NFS (when interoperating with a > 7.0 server). I haven't had time to get the tcpdump trace you > requested because of focusing on other problems. Because of the > client problems I haven't tested it at all on the server side yet. > > I really don't think this has received sufficient testing yet. I'm pretty sure I fixed that problem with my change to src/lib/libc/ rpc/svc_vc.c revision 1.27. From kris at FreeBSD.org Thu Apr 10 10:27:46 2008 From: kris at FreeBSD.org (Kris Kennaway) Date: Thu Apr 10 10:27:52 2008 Subject: cvs commit: src/lib/libc/gen lockf.c src/lib/libc/include libc_private.h src/lib/libc/rpc svc_vc.c src/lib/libc/sys Makefile.inc Symbol.map fcntl.2 fcntl.c src/lib/libc/xdr xdr_rec.c src/sys/amd64/conf GENERIC src/sys/arm/conf AVILA BWCT CRB EP80219 ... In-Reply-To: <9E913B4A-C81E-4AB8-AFF8-F51FC9B25721@rabson.org> References: <200804100939.m3A9dUFu028748@repoman.freebsd.org> <47FDE41D.5090601@FreeBSD.org> <9E913B4A-C81E-4AB8-AFF8-F51FC9B25721@rabson.org> Message-ID: <47FDEBA0.3050908@FreeBSD.org> Doug Rabson wrote: > > On 10 Apr 2008, at 10:55, Kris Kennaway wrote: > >> Doug Rabson wrote: >>> dfr 2008-04-10 09:39:29 UTC >>> FreeBSD src repository >>> Modified files: (Branch: RELENG_7) >>> lib/libc/gen lockf.c >> >> Hmm, I am concerned by this quick merge because rpc.lockd is still not >> usable for me on HEAD. I had to disable it entirely on all of my >> client machines because it will usually hang and become unkillable >> when locking files over NFS (when interoperating with a 7.0 server). >> I haven't had time to get the tcpdump trace you requested because of >> focusing on other problems. Because of the client problems I haven't >> tested it at all on the server side yet. >> >> I really don't think this has received sufficient testing yet. > > I'm pretty sure I fixed that problem with my change to > src/lib/libc/rpc/svc_vc.c revision 1.27. > > OK, I will retry, but that would just mean I can start testing. Let's hope the rest of the code is bug-free :) Kris From dfr at rabson.org Thu Apr 10 10:40:51 2008 From: dfr at rabson.org (Doug Rabson) Date: Thu Apr 10 10:40:59 2008 Subject: cvs commit: src/lib/libc/gen lockf.c src/lib/libc/include libc_private.h src/lib/libc/rpc svc_vc.c src/lib/libc/sys Makefile.inc Symbol.map fcntl.2 fcntl.c src/lib/libc/xdr xdr_rec.c src/sys/amd64/conf GENERIC src/sys/arm/conf AVILA BWCT CRB EP80219 ... In-Reply-To: <47FDEBA0.3050908@FreeBSD.org> References: <200804100939.m3A9dUFu028748@repoman.freebsd.org> <47FDE41D.5090601@FreeBSD.org> <9E913B4A-C81E-4AB8-AFF8-F51FC9B25721@rabson.org> <47FDEBA0.3050908@FreeBSD.org> Message-ID: <7E968817-C2EF-4A0C-BBC4-ACF3010EF83E@rabson.org> On 10 Apr 2008, at 11:27, Kris Kennaway wrote: > Doug Rabson wrote: >> On 10 Apr 2008, at 10:55, Kris Kennaway wrote: >>> Doug Rabson wrote: >>>> dfr 2008-04-10 09:39:29 UTC >>>> FreeBSD src repository >>>> Modified files: (Branch: RELENG_7) >>>> lib/libc/gen lockf.c >>> >>> Hmm, I am concerned by this quick merge because rpc.lockd is still >>> not usable for me on HEAD. I had to disable it entirely on all of >>> my client machines because it will usually hang and become >>> unkillable when locking files over NFS (when interoperating with a >>> 7.0 server). I haven't had time to get the tcpdump trace you >>> requested because of focusing on other problems. Because of the >>> client problems I haven't tested it at all on the server side yet. >>> >>> I really don't think this has received sufficient testing yet. >> I'm pretty sure I fixed that problem with my change to src/lib/libc/ >> rpc/svc_vc.c revision 1.27. > > OK, I will retry, but that would just mean I can start testing. > Let's hope the rest of the code is bug-free :) Thanks. If problems show up with RELENG_7 users, I can disable use of the kernel NLM without necessarily having to back out the whole thing. Lets see what shows up - I'll hold off committing to RELENG_6 for now. From kib at FreeBSD.org Thu Apr 10 12:13:57 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Thu Apr 10 12:13:59 2008 Subject: cvs commit: src/include unistd.h Message-ID: <200804101213.m3ACDuLZ046095@repoman.freebsd.org> kib 2008-04-10 12:13:56 UTC FreeBSD src repository Modified files: include unistd.h Log: Add the restrict qualifiers to the pointer arguments of the readlinkat. Revision Changes Path 1.87 +1 -1 src/include/unistd.h From ru at FreeBSD.org Thu Apr 10 12:16:21 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Thu Apr 10 12:16:24 2008 Subject: cvs commit: src/sbin/route route.c Message-ID: <200804101216.m3ACGK4l046465@repoman.freebsd.org> ru 2008-04-10 12:16:20 UTC FreeBSD src repository Modified files: sbin/route route.c Log: Fix printing of sockaddr prefixes in verbose mode. PR: bin/122403 Submitted by: az MFC after: 3 days Revision Changes Path 1.85 +1 -1 src/sbin/route/route.c From kris at FreeBSD.org Thu Apr 10 12:23:31 2008 From: kris at FreeBSD.org (Kris Kennaway) Date: Thu Apr 10 12:23:43 2008 Subject: cvs commit: src/lib/libc/gen lockf.c src/lib/libc/include libc_private.h src/lib/libc/rpc svc_vc.c src/lib/libc/sys Makefile.inc Symbol.map fcntl.2 fcntl.c src/lib/libc/xdr xdr_rec.c src/sys/amd64/conf GENERIC src/sys/arm/conf AVILA BWCT CRB EP80219 ... In-Reply-To: <7E968817-C2EF-4A0C-BBC4-ACF3010EF83E@rabson.org> References: <200804100939.m3A9dUFu028748@repoman.freebsd.org> <47FDE41D.5090601@FreeBSD.org> <9E913B4A-C81E-4AB8-AFF8-F51FC9B25721@rabson.org> <47FDEBA0.3050908@FreeBSD.org> <7E968817-C2EF-4A0C-BBC4-ACF3010EF83E@rabson.org> Message-ID: <47FE06C0.20309@FreeBSD.org> Doug Rabson wrote: > > On 10 Apr 2008, at 11:27, Kris Kennaway wrote: > >> Doug Rabson wrote: >>> On 10 Apr 2008, at 10:55, Kris Kennaway wrote: >>>> Doug Rabson wrote: >>>>> dfr 2008-04-10 09:39:29 UTC >>>>> FreeBSD src repository >>>>> Modified files: (Branch: RELENG_7) >>>>> lib/libc/gen lockf.c >>>> >>>> Hmm, I am concerned by this quick merge because rpc.lockd is still >>>> not usable for me on HEAD. I had to disable it entirely on all of >>>> my client machines because it will usually hang and become >>>> unkillable when locking files over NFS (when interoperating with a >>>> 7.0 server). I haven't had time to get the tcpdump trace you >>>> requested because of focusing on other problems. Because of the >>>> client problems I haven't tested it at all on the server side yet. >>>> >>>> I really don't think this has received sufficient testing yet. >>> I'm pretty sure I fixed that problem with my change to >>> src/lib/libc/rpc/svc_vc.c revision 1.27. >> >> OK, I will retry, but that would just mean I can start testing. Let's >> hope the rest of the code is bug-free :) > > Thanks. If problems show up with RELENG_7 users, I can disable use of > the kernel NLM without necessarily having to back out the whole thing. > Lets see what shows up - I'll hold off committing to RELENG_6 for now. > > > After cvs update and rebuilding kernel, includes, libc and rpc.lockd, I still get: hydra2# rpc.lockd Can't find or load kernel support for rpc.lockd - using non-kernel implementation hydra2# ps aux | grep lockd root 1217 0.0 0.0 3212 1188 ?? Ss 12:21PM 0:00.00 rpc.lockd: server (rpc.lockd) daemon 1218 0.0 0.0 3212 1360 ?? S 12:21PM 0:00.00 rpc.lockd: client (rpc.lockd) root 1219 0.0 0.0 3212 1188 ?? D 12:21PM 0:00.00 rpc.lockd: server (rpc.lockd) root 1221 0.0 0.0 552 352 p0 D+ 12:21PM 0:00.00 grep lockd hydra2# vi /etc/rc.conf load: 0.95 cmd: vi 1222 [lockd] 0.00u 0.00s 0% 1420k /etc is on a NFS-mounted / Kris From ken at mthelicon.com Thu Apr 10 12:51:34 2008 From: ken at mthelicon.com (Pegasus Mc cleaft) Date: Thu Apr 10 12:51:41 2008 Subject: cvs commit: src/etc/rc.d zfs Message-ID: <200804101318.25581.ken@mthelicon.com> Hello everyone, is it possible the change to the above script is causing this problem: I use zfs on a amd64 platform to hold my /usr /var and /usr/home directories. Using todays cvs, after I compiled, mergemastered and rebooted the machine it will no longer automount my zfs pool and fs' and reports an error that the pool was used previously on another machine. If I boot in single user mode, force the pool to import and then continue booting to multi-user mode, it all works fine after that. However, on shutdown and reboot, the same problem reoccures. When I had this problem before (different reason for the problem, I was actually moving drives to another machine) I found that forcing the pool to import and doing a proper shutdown cleared the problem; not so in this case. Peg From dfr at FreeBSD.org Thu Apr 10 12:54:53 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Thu Apr 10 12:55:05 2008 Subject: cvs commit: src/usr.sbin/rpc.lockd lockd.c Message-ID: <200804101254.m3ACsrYw063055@repoman.freebsd.org> dfr 2008-04-10 12:54:53 UTC FreeBSD src repository Modified files: usr.sbin/rpc.lockd lockd.c Log: If we can't find or load the kernel NLM support, don't just go ahead and try to use it anyway. Revision Changes Path 1.27 +2 -1 src/usr.sbin/rpc.lockd/lockd.c From sos at FreeBSD.org Thu Apr 10 13:01:18 2008 From: sos at FreeBSD.org (Søren Schmidt) Date: Thu Apr 10 13:01:31 2008 Subject: cvs commit: src/sys/sys ata.h Message-ID: <200804101301.m3AD1Hbh064088@repoman.freebsd.org> sos 2008-04-10 13:01:17 UTC FreeBSD src repository Modified files: sys/sys ata.h Log: Add experimental support for SATA Port Multipliers Support is working on the Silicon Image SiI3124/3132. Support is working on some AHCI chips but far from all. Remember this is WIP, so test reports and (constructive) suggestions are welcome! Revision Changes Path 1.40 +5 -3 src/sys/sys/ata.h From sos at FreeBSD.org Thu Apr 10 13:05:06 2008 From: sos at FreeBSD.org (Søren Schmidt) Date: Thu Apr 10 13:05:18 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-card.c ata-cbus.c ata-chipset.c ata-disk.c ata-disk.h ata-dma.c ata-isa.c ata-lowlevel.c ata-pci.c ata-pci.h ata-queue.c ata-raid.c ata-raid.h ata-usb.c ata_if.m atapi-cd.c atapi-cd.h atapi-fd.c ... Message-ID: <200804101305.m3AD55DK066187@repoman.freebsd.org> sos 2008-04-10 13:05:05 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.c ata-all.h ata-card.c ata-cbus.c ata-chipset.c ata-disk.c ata-disk.h ata-dma.c ata-isa.c ata-lowlevel.c ata-pci.c ata-pci.h ata-queue.c ata-raid.c ata-raid.h ata-usb.c ata_if.m atapi-cd.c atapi-cd.h atapi-fd.c atapi-fd.h atapi-tape.c atapi-tape.h Log: Add experimental support for SATA Port Multipliers Support is working on the Silicon Image SiI3124/3132. Support is working on some AHCI chips but far from all. Remember this is WIP, so test reports and (constructive) suggestions are welcome! Revision Changes Path 1.282 +73 -57 src/sys/dev/ata/ata-all.c 1.129 +42 -25 src/sys/dev/ata/ata-all.h 1.41 +1 -1 src/sys/dev/ata/ata-card.c 1.26 +1 -1 src/sys/dev/ata/ata-cbus.c 1.213 +797 -266 src/sys/dev/ata/ata-chipset.c 1.208 +117 -48 src/sys/dev/ata/ata-disk.c 1.54 +1 -1 src/sys/dev/ata/ata-disk.h 1.151 +160 -132 src/sys/dev/ata/ata-dma.c 1.32 +1 -1 src/sys/dev/ata/ata-isa.c 1.81 +31 -33 src/sys/dev/ata/ata-lowlevel.c 1.124 +41 -40 src/sys/dev/ata/ata-pci.c 1.84 +1 -2 src/sys/dev/ata/ata-pci.h 1.70 +8 -3 src/sys/dev/ata/ata-queue.c 1.127 +1 -1 src/sys/dev/ata/ata-raid.c 1.47 +1 -1 src/sys/dev/ata/ata-raid.h 1.8 +1 -2 src/sys/dev/ata/ata-usb.c 1.8 +1 -1 src/sys/dev/ata/ata_if.m 1.197 +4 -9 src/sys/dev/ata/atapi-cd.c 1.48 +1 -1 src/sys/dev/ata/atapi-cd.h 1.112 +3 -7 src/sys/dev/ata/atapi-fd.c 1.28 +1 -1 src/sys/dev/ata/atapi-fd.h 1.105 +5 -13 src/sys/dev/ata/atapi-tape.c 1.26 +1 -1 src/sys/dev/ata/atapi-tape.h From ru at FreeBSD.org Thu Apr 10 14:02:00 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Thu Apr 10 14:02:09 2008 Subject: cvs commit: src/usr.sbin/fifolog Makefile Makefile.inc src/usr.sbin/fifolog/fifolog_create Makefile fifolog.1 src/usr.sbin/fifolog/fifolog_reader Makefile src/usr.sbin/fifolog/fifolog_writer Makefile src/usr.sbin/fifolog/lib Makefile Message-ID: <200804101402.m3AE20nT074896@repoman.freebsd.org> ru 2008-04-10 14:02:00 UTC FreeBSD src repository Modified files: usr.sbin/fifolog Makefile Makefile.inc usr.sbin/fifolog/fifolog_create Makefile fifolog.1 usr.sbin/fifolog/fifolog_reader Makefile usr.sbin/fifolog/fifolog_writer Makefile usr.sbin/fifolog/lib Makefile Log: Clean up makefiles and a manpage. OK'ed by: phk Revision Changes Path 1.2 +1 -6 src/usr.sbin/fifolog/Makefile 1.2 +4 -7 src/usr.sbin/fifolog/Makefile.inc 1.2 +11 -11 src/usr.sbin/fifolog/fifolog_create/Makefile 1.2 +70 -62 src/usr.sbin/fifolog/fifolog_create/fifolog.1 1.3 +7 -10 src/usr.sbin/fifolog/fifolog_reader/Makefile 1.2 +8 -8 src/usr.sbin/fifolog/fifolog_writer/Makefile 1.2 +5 -11 src/usr.sbin/fifolog/lib/Makefile From Daan at vehosting.nl Thu Apr 10 14:14:14 2008 From: Daan at vehosting.nl (Daan Vreeken) Date: Thu Apr 10 14:14:20 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-card.c ata-cbus.c ata-chipset.c ata-disk.c ata-disk.h ata-dma.c ata-isa.c ata-lowlevel.c ata-pci.c ata-pci.h ata-queue.c ata-raid.c ata-raid.h ata-usb.c ata_if.m atapi-cd.c atapi-cd.h atapi-fd.c ... In-Reply-To: <200804101305.m3AD55DK066187@repoman.freebsd.org> References: <200804101305.m3AD55DK066187@repoman.freebsd.org> Message-ID: <200804101534.28928.Daan@vehosting.nl> Hi S?ren, On Thursday 10 April 2008 15:05:05 S?ren Schmidt wrote: > sos 2008-04-10 13:05:05 UTC > > FreeBSD src repository > > Modified files: > sys/dev/ata ata-all.c ata-all.h ata-card.c ata-cbus.c > ata-chipset.c ata-disk.c ata-disk.h > ata-dma.c ata-isa.c ata-lowlevel.c > ata-pci.c ata-pci.h ata-queue.c > ata-raid.c ata-raid.h ata-usb.c ata_if.m > atapi-cd.c atapi-cd.h atapi-fd.c > atapi-fd.h atapi-tape.c atapi-tape.h > Log: > Add experimental support for SATA Port Multipliers > > Support is working on the Silicon Image SiI3124/3132. > Support is working on some AHCI chips but far from all. > > Remember this is WIP, so test reports and (constructive) suggestions are > welcome! Wow, that's quick :) I'll try to test the code on the experimental storage server we're building here. I'll let you know how far I get. Thanks for the effort! -- Daan Vreeken VEHosting http://VEHosting.nl tel: +31-(0)40-7113050 / +31-(0)6-46210825 KvK nr: 17174380 From jkim at FreeBSD.org Thu Apr 10 15:17:42 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Thu Apr 10 15:17:52 2008 Subject: cvs commit: src/sys/dev/acpi_support acpi_asus.c Message-ID: <200804101517.m3AFHfrZ089400@repoman.freebsd.org> jkim 2008-04-10 15:17:41 UTC FreeBSD src repository Modified files: sys/dev/acpi_support acpi_asus.c Log: - Add ASUS G2K laptop support. - Add DLED and GLED found on newer ASUS laptops. - Turn on BLED, TLED, and WLED by default as other OSes. Reviewed by: philip MFC after: 3 days Revision Changes Path 1.31 +104 -33 src/sys/dev/acpi_support/acpi_asus.c From alc at FreeBSD.org Thu Apr 10 16:04:51 2008 From: alc at FreeBSD.org (Alan Cox) Date: Thu Apr 10 16:04:56 2008 Subject: cvs commit: src/sys/amd64/amd64 pmap.c src/sys/i386/i386 pmap.c Message-ID: <200804101604.m3AG4ouG093787@repoman.freebsd.org> alc 2008-04-10 16:04:50 UTC FreeBSD src repository Modified files: sys/amd64/amd64 pmap.c sys/i386/i386 pmap.c Log: Correct pmap_copy()'s method for extracting the physical address of a 2/4MB page from a PDE. Specifically, change it to use PG_PS_FRAME, not PG_FRAME, to extract the physical address of a 2/4MB page from a PDE. Change the last argument passed to pmap_pv_insert_pde() from a vm_page_t representing the first 4KB page of a 2/4MB page to the vm_paddr_t of the 2/4MB page. This avoids an otherwise unnecessary conversion from a vm_paddr_t to a vm_page_t in pmap_copy(). Revision Changes Path 1.614 +6 -6 src/sys/amd64/amd64/pmap.c 1.616 +6 -6 src/sys/i386/i386/pmap.c From xcllnt at mac.com Thu Apr 10 16:14:22 2008 From: xcllnt at mac.com (Marcel Moolenaar) Date: Thu Apr 10 16:14:31 2008 Subject: cvs commit: src/lib/libc/gen lockf.c src/lib/libc/include libc_private.h src/lib/libc/rpc svc_vc.c src/lib/libc/sys Makefile.inc Symbol.map fcntl.2 fcntl.c src/lib/libc/xdr xdr_rec.c src/sys/amd64/conf GENERIC src/sys/arm/conf AVILA BWCT CRB EP80219 ... In-Reply-To: <47FDE41D.5090601@FreeBSD.org> References: <200804100939.m3A9dUFu028748@repoman.freebsd.org> <47FDE41D.5090601@FreeBSD.org> Message-ID: On Apr 10, 2008, at 2:55 AM, Kris Kennaway wrote: > Doug Rabson wrote: >> dfr 2008-04-10 09:39:29 UTC >> FreeBSD src repository >> Modified files: (Branch: RELENG_7) >> lib/libc/gen lockf.c > > Hmm, I am concerned by this quick merge because rpc.lockd is still > not usable for me on HEAD. I had to disable it entirely on all of > my client machines because it will usually hang and become > unkillable when locking files over NFS (when interoperating with a > 7.0 server). I haven't had time to get the tcpdump trace you > requested because of focusing on other problems. Because of the > client problems I haven't tested it at all on the server side yet. I saw this too, but after adding "options NFSLOCKD" to my kernel configuration that problem went away. FYI, -- Marcel Moolenaar xcllnt@mac.com From ru at FreeBSD.org Thu Apr 10 16:17:56 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Thu Apr 10 16:18:07 2008 Subject: cvs commit: src/usr.bin/top machine.c Message-ID: <200804101617.m3AGHshI094894@repoman.freebsd.org> ru 2008-04-10 16:17:54 UTC FreeBSD src repository Modified files: usr.bin/top machine.c Log: Fix "top -P" (`&' mistyped as `&&' and a botched logic). The bug was unnoticed on non-i386 because mp_maxid is initialized differently, kern.cp_times doesn't print zeroes for non-existing CPUs, so no "writing outside of array bounds" happens. MFC after: 3 days Revision Changes Path 1.87 +3 -2 src/usr.bin/top/machine.c From takawata at FreeBSD.org Thu Apr 10 18:38:32 2008 From: takawata at FreeBSD.org (Takanori Watanabe) Date: Thu Apr 10 18:38:39 2008 Subject: cvs commit: src/sys/i386/i386 mp_machdep.c Message-ID: <200804101838.m3AIcV3M013203@repoman.freebsd.org> takawata 2008-04-10 18:38:31 UTC FreeBSD src repository Modified files: sys/i386/i386 mp_machdep.c Log: Don't break identity mapping set up for ACPI resume path. With this change, BSP processor context seems to be recovered. Revision Changes Path 1.286 +5 -2 src/sys/i386/i386/mp_machdep.c From rwatson at FreeBSD.org Thu Apr 10 19:54:55 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Apr 10 19:55:07 2008 Subject: cvs commit: src/sys/security/audit audit_arg.c audit_bsm.c audit_bsm_klib.c audit_private.h Message-ID: <200804101954.m3AJstb5016714@repoman.freebsd.org> rwatson 2008-04-10 19:54:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/security/audit audit_arg.c audit_bsm.c audit_bsm_klib.c audit_private.h Log: Merge audit_arg.c:1.18, audit_bsm.c:1.25, audit_bsm_klib.c:1.10, audit_private.h:1.17 from HEAD to RELENG_7: Rename several audit functions in the global kernel symbol namespace to have audit_ on the front: - canon_path -> audit_canon_path - msgctl_to_event -> audit_msgctl_to_event - semctl_to_event -> audit_semctl_to_event Note that audit.c:1.38 is not merged as changes it depends on have also not yet been merged. Revision Changes Path 1.15.2.1 +1 -1 src/sys/security/audit/audit_arg.c 1.20.2.4 +2 -2 src/sys/security/audit/audit_bsm.c 1.7.2.2 +4 -4 src/sys/security/audit/audit_bsm_klib.c 1.16.2.2 +3 -3 src/sys/security/audit/audit_private.h From rwatson at FreeBSD.org Thu Apr 10 20:00:19 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Apr 10 20:01:06 2008 Subject: cvs commit: src/sys/security/audit audit.c audit_bsm_klib.c audit_private.h Message-ID: <200804102000.m3AK0I6O017132@repoman.freebsd.org> rwatson 2008-04-10 20:00:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/security/audit audit.c audit_bsm_klib.c audit_private.h Log: MFC audit.c:1.39, audit_bsm_klib.c:1.11, audit_private.h:1.19 from HEAD to RELENG_7: Add audit_prefixes to two more globally visible functions in the Audit implementation. Revision Changes Path 1.33.2.2 +2 -2 src/sys/security/audit/audit.c 1.7.2.3 +2 -2 src/sys/security/audit/audit_bsm_klib.c 1.16.2.3 +3 -3 src/sys/security/audit/audit_private.h From rwatson at FreeBSD.org Thu Apr 10 20:15:37 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Apr 10 20:15:43 2008 Subject: cvs commit: src/sys/kern kern_linker.c src/sys/sys linker.h Message-ID: <200804102015.m3AKFa9D019667@repoman.freebsd.org> rwatson 2008-04-10 20:15:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern kern_linker.c sys/sys linker.h Log: Merge kern_linker.c:1.153, linker.h:1.50 from HEAD to RELENG_7: The kernel linker includes a number of utility functions to look up symbol information in support of DDB(4); these functions bypass normal linker locking as they may run in contexts where locking is unsafe (such as the kernel debugger). Add a new interface linker_ddb_search_symbol_name(), which looks up a symbol name and offset given an address, and also linker_search_symbol_name() which does the same but *does* follow the locking conventions of the linker. Unlike existing functions, these functions place the name in a caller-provided buffer, which is stable even after linker locks have been released. These functions will be used in upcoming revisions to stack(9) to support kernel stack trace generation in contexts as part of a live, rather than suspended, kernel. Revision Changes Path 1.149.2.1 +87 -13 src/sys/kern/kern_linker.c 1.46.2.1 +8 -0 src/sys/sys/linker.h From rwatson at FreeBSD.org Thu Apr 10 20:28:03 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Apr 10 20:28:09 2008 Subject: cvs commit: src/share/man/man9 Makefile stack.9 src/sys/kern kern_lock.c subr_stack.c src/sys/sys stack.h src/sys/vm redzone.c Message-ID: <200804102028.m3AKS32j020447@repoman.freebsd.org> rwatson 2008-04-10 20:28:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man9 Makefile stack.9 sys/kern kern_lock.c subr_stack.c sys/sys stack.h sys/vm redzone.c Log: Merge Makefile:1.320, stack.9:1.4, kern_lock.c:1.114, subr_stack.c:1.4, stack.h:1.3, redzone.c:1.2 from HEAD to RELENG_7: Modify stack(9) stack_print() and stack_sbuf_print() routines to use new linker interfaces for looking up function names and offsets from instruction pointers. Create two variants of each call: one that is "DDB-safe" and avoids locking in the linker, and one that is safe for use in live kernels, by virtue of observing locking, and in particular safe when kernel modules are being loaded and unloaded simultaneous to their use. This will allow them to be used outside of debugging contexts. Modify two of three current stack(9) consumers to use the DDB-safe interfaces, as they run in low-level debugging contexts, such as inside lockmgr(9) and the kernel memory allocator. Update man page. Revision Changes Path 1.310.2.3 +1 -0 src/share/man/man9/Makefile 1.5.2.2 +15 -2 src/share/man/man9/stack.9 1.110.2.1 +1 -1 src/sys/kern/kern_lock.c 1.3.2.1 +79 -24 src/sys/kern/subr_stack.c 1.2.4.1 +2 -0 src/sys/sys/stack.h 1.1.2.1 +4 -4 src/sys/vm/redzone.c From sos at FreeBSD.org Thu Apr 10 20:40:25 2008 From: sos at FreeBSD.org (Søren Schmidt) Date: Thu Apr 10 20:40:36 2008 Subject: cvs commit: src/sys/dev/ata ata-chipset.c Message-ID: <200804102040.m3AKePtF027994@repoman.freebsd.org> sos 2008-04-10 20:40:25 UTC FreeBSD src repository Modified files: sys/dev/ata ata-chipset.c Log: Fix clearing of nVidia interrupts. Revision Changes Path 1.214 +11 -3 src/sys/dev/ata/ata-chipset.c From rwatson at FreeBSD.org Thu Apr 10 20:54:02 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Apr 10 20:54:08 2008 Subject: cvs commit: src/sys/kern kern_descrip.c kern_proc.c src/sys/sys sysctl.h user.h Message-ID: <200804102054.m3AKs2fk038385@repoman.freebsd.org> rwatson 2008-04-10 20:54:02 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern kern_descrip.c kern_proc.c sys/sys sysctl.h user.h Log: Merge kern_descrip.c:1.314, kern_proc.c:1.256, sysctl.h:1.153, user.h:1.71 from HEAD to RELENG_7: Add two new sysctls in support of the forthcoming procstat(1) to support its -f and -v arguments: kern.proc.filedesc - dump file descriptor information for a process, if debugging is permitted, including socket addresses, open flags, file offsets, file paths, etc. kern.proc.vmmap - dump virtual memory mapping information for a process, if debugging is permitted, including layout and information on underlying objects, such as the type of object and path. These provide a superset of the information historically available through the now-deprecated procfs(4), and are intended to be exported in an ABI-robust form. Revision Changes Path 1.313.2.3 +180 -1 src/sys/kern/kern_descrip.c 1.252.2.4 +159 -1 src/sys/kern/kern_proc.c 1.148.2.1 +3 -0 src/sys/sys/sysctl.h 1.70.2.1 +92 -1 src/sys/sys/user.h From rwatson at FreeBSD.org Thu Apr 10 22:09:26 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Apr 10 22:09:31 2008 Subject: cvs commit: src/share/man/man9 stack.9 src/sys/amd64/amd64 db_trace.c stack_machdep.c src/sys/amd64/conf GENERIC src/sys/amd64/include stack.h src/sys/arm/arm db_trace.c stack_machdep.c src/sys/arm/include stack.h src/sys/conf NOTES ... Message-ID: <200804102209.m3AM9QNh046083@repoman.freebsd.org> rwatson 2008-04-10 22:09:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man9 stack.9 sys/amd64/amd64 db_trace.c sys/amd64/conf GENERIC sys/arm/arm db_trace.c sys/conf NOTES files files.amd64 files.arm files.i386 files.ia64 files.pc98 files.powerpc files.sparc64 files.sun4v options sys/i386/conf GENERIC sys/i386/i386 db_trace.c sys/ia64/conf GENERIC sys/ia64/ia64 db_machdep.c sys/kern subr_stack.c sys/pc98/conf GENERIC sys/powerpc/conf GENERIC sys/powerpc/powerpc db_trace.c sys/sparc64/conf GENERIC sys/sparc64/sparc64 db_trace.c sys/sun4v/conf GENERIC sys/sun4v/sun4v db_trace.c sys/sys stack.h Added files: (Branch: RELENG_7) sys/amd64/amd64 stack_machdep.c sys/amd64/include stack.h sys/arm/arm stack_machdep.c sys/arm/include stack.h sys/i386/i386 stack_machdep.c sys/i386/include stack.h sys/ia64/ia64 stack_machdep.c sys/pc98/include stack.h sys/powerpc/include stack.h sys/powerpc/powerpc stack_machdep.c sys/sparc64/include stack.h sys/sparc64/sparc64 stack_machdep.c sys/sun4v/include stack.h sys/sun4v/sun4v stack_machdep.c Log: Merge stack.9:1.5, amd64/db_trace.c:1.82, amd64/stack_machdep.c:1.1, amd64/conf/GENERIC:1.489, amd64/include/stack.h:1.1, arm/db_trace.c:1.14, arm/stack_machdep.c:1.1, arm/include/stack.h:1.1, NOTES:1.1457, files:1.1254, files.amd64:1.115, files.arm:1.19, files.i386:1.588, files.ia64:1.94, files.powerpc:1.67, files.sparc64:1.93, files.sun4v:1.13, options:1.610, i386/conf/GENERIC:1.478, i386/db_trace.c:1.80, i386/stack_machdep.c:1.1, i386/include/stack.h:1.1, ia64/conf/GENERIC:1.93, ia64/db_machdep.c:1.6, ia64/stack_machdep.c:1.1, kern/subr_stack.c:1.5, pc98/conf/GENERIC:1.299, powerpc/conf/GENERIC:1.73, powerpc/include/stack.h:1.1, powerpc/db_trace.c:1.14, powerpc/stack_machdep.c:1.1, sparc64/conf/GENERIC:1.129, sparc64/include/stack.h:1.1, sparc64/db_trace.c:1.27, sparc64/stack_machdep.c:1.1, sun4v/conf/GENERIC:1.16, sun4v/include/stack.h:1.1, sun4v/db_trace.c:1.2, sun4v/stack_machdep.c:1.1, sys/stack.h:1.4 from HEAD to RELENG_7: Break out stack(9) from ddb(4): - Introduce per-architecture stack_machdep.c to hold stack_save(9). - Introduce per-architecture machine/stack.h to capture any common definitions required between db_trace.c and stack_machdep.c. - Add new kernel option "options STACK"; we will build in stack(9) if it is defined, or also if "options DDB" is defined to provide compatibility with existing users of stack(9). Add new stack_save_td(9) function, which allows the capture of a stacktrace of another thread rather than the current thread, which the existing stack_save(9) was limited to. It requires that the thread be neither swapped out nor running, which is the responsibility of the consumer to enforce. Update stack(9) man page. Build tested: amd64, arm, i386, ia64, powerpc, sparc64, sun4v Runtime tested: amd64 (rwatson), arm (cognet), i386 (rwatson) Merge i386/stack_machdep.c:1.2 from HEAD to RELENG_7: Remove duplicate $FreeBSD$ tag. Merge files.pc98:1.359, pc98/include/stack.h:1.1 from HEAD to RELENG_7: Catch up pc98 for i386 stack(9) changes: Add stub stack.h for pc98 that includes i386 pc98. Add i386 stack_machdep.c to files.pc98. Spotted by: tinderbox Revision Changes Path 1.5.2.3 +28 -22 src/share/man/man9/stack.9 1.80.2.2 +1 -38 src/sys/amd64/amd64/db_trace.c 1.1.2.1 +87 -0 src/sys/amd64/amd64/stack_machdep.c (new) 1.484.2.7 +1 -0 src/sys/amd64/conf/GENERIC 1.1.2.1 +44 -0 src/sys/amd64/include/stack.h (new) 1.13.2.1 +1 -25 src/sys/arm/arm/db_trace.c 1.1.2.1 +76 -0 src/sys/arm/arm/stack_machdep.c (new) 1.1.2.1 +42 -0 src/sys/arm/include/stack.h (new) 1.1454.2.7 +7 -0 src/sys/conf/NOTES 1.1243.2.14 +1 -1 src/sys/conf/files 1.107.2.6 +1 -0 src/sys/conf/files.amd64 1.15.2.1 +1 -0 src/sys/conf/files.arm 1.580.2.6 +1 -0 src/sys/conf/files.i386 1.92.2.1 +1 -0 src/sys/conf/files.ia64 1.356.2.1 +1 -0 src/sys/conf/files.pc98 1.65.2.1 +1 -0 src/sys/conf/files.powerpc 1.92.2.2 +1 -0 src/sys/conf/files.sparc64 1.11.2.1 +1 -0 src/sys/conf/files.sun4v 1.608.2.4 +1 -0 src/sys/conf/options 1.474.2.7 +1 -0 src/sys/i386/conf/GENERIC 1.79.2.1 +1 -39 src/sys/i386/i386/db_trace.c 1.2.2.1 +87 -0 src/sys/i386/i386/stack_machdep.c (new) 1.1.2.1 +44 -0 src/sys/i386/include/stack.h (new) 1.92.2.2 +1 -0 src/sys/ia64/conf/GENERIC 1.4.2.1 +0 -12 src/sys/ia64/ia64/db_machdep.c 1.1.2.1 +57 -0 src/sys/ia64/ia64/stack_machdep.c (new) 1.3.2.2 +2 -0 src/sys/kern/subr_stack.c 1.297.2.4 +1 -0 src/sys/pc98/conf/GENERIC 1.1.2.1 +6 -0 src/sys/pc98/include/stack.h (new) 1.71.2.6 +1 -0 src/sys/powerpc/conf/GENERIC 1.1.2.1 +36 -0 src/sys/powerpc/include/stack.h (new) 1.13.2.1 +1 -38 src/sys/powerpc/powerpc/db_trace.c 1.1.2.1 +97 -0 src/sys/powerpc/powerpc/stack_machdep.c (new) 1.127.2.3 +1 -0 src/sys/sparc64/conf/GENERIC 1.1.2.1 +40 -0 src/sys/sparc64/include/stack.h (new) 1.26.2.1 +1 -34 src/sys/sparc64/sparc64/db_trace.c 1.1.2.1 +90 -0 src/sys/sparc64/sparc64/stack_machdep.c (new) 1.14.2.3 +1 -0 src/sys/sun4v/conf/GENERIC 1.1.2.1 +35 -0 src/sys/sun4v/include/stack.h (new) 1.1.2.1 +1 -23 src/sys/sun4v/sun4v/db_trace.c 1.1.2.1 +85 -0 src/sys/sun4v/sun4v/stack_machdep.c (new) 1.2.4.2 +2 -0 src/sys/sys/stack.h From delphij at FreeBSD.org Thu Apr 10 22:43:26 2008 From: delphij at FreeBSD.org (Xin LI) Date: Thu Apr 10 22:43:37 2008 Subject: cvs commit: src/usr.bin/chat chat.c Message-ID: <200804102243.m3AMhPMn047925@repoman.freebsd.org> delphij 2008-04-10 22:43:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.bin/chat chat.c Log: MFC revision 1.22 date: 2008/03/07 00:01:19; author: delphij; state: Exp; lines: +61 -68 Merge revisions 1.10 and 1.11 from DragonFly: - Use real getopt() handling instead of the hand-rolled and IOCCC-worthy "Micro getopt()" macros, plus clean up to the option handling code: * Sort the options in the switch statement; * Plug piddling memory leaks when processing repeated options by freeing strings before allocating them for a second time; * Die with a fatal error if the requested report file cannot be opened for appending; * Don't call init() before usage() (to prevent the usage message being mangled by changes to the terminal settings;) - Clean up the usage message, both in usage() and in the main program comment, both stylistically (sort and combine options) and for accuracy (following the manual page, make note of the -s and -S flags, and use the term 'send' instead of 'say' to reduce confusion (SAY is the name of a command for output to the user, not the connection.)) Obtained from: DragonFly Revision Changes Path 1.21.20.1 +61 -68 src/usr.bin/chat/chat.c From delphij at FreeBSD.org Thu Apr 10 22:43:46 2008 From: delphij at FreeBSD.org (Xin LI) Date: Thu Apr 10 22:44:03 2008 Subject: cvs commit: src/usr.bin/chat chat.c Message-ID: <200804102243.m3AMhkh5047958@repoman.freebsd.org> delphij 2008-04-10 22:43:46 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.bin/chat chat.c Log: MFC revision 1.22 date: 2008/03/07 00:01:19; author: delphij; state: Exp; lines: +61 -68 Merge revisions 1.10 and 1.11 from DragonFly: - Use real getopt() handling instead of the hand-rolled and IOCCC-worthy "Micro getopt()" macros, plus clean up to the option handling code: * Sort the options in the switch statement; * Plug piddling memory leaks when processing repeated options by freeing strings before allocating them for a second time; * Die with a fatal error if the requested report file cannot be opened for appending; * Don't call init() before usage() (to prevent the usage message being mangled by changes to the terminal settings;) - Clean up the usage message, both in usage() and in the main program comment, both stylistically (sort and combine options) and for accuracy (following the manual page, make note of the -s and -S flags, and use the term 'send' instead of 'say' to reduce confusion (SAY is the name of a command for output to the user, not the connection.)) Obtained from: DragonFly Revision Changes Path 1.21.10.1 +61 -68 src/usr.bin/chat/chat.c From rwatson at FreeBSD.org Thu Apr 10 22:45:27 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Apr 10 22:45:36 2008 Subject: cvs commit: src/sys/kern kern_proc.c src/sys/sys sysctl.h user.h Message-ID: <200804102245.m3AMjRZM048161@repoman.freebsd.org> rwatson 2008-04-10 22:45:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern kern_proc.c sys/sys sysctl.h user.h Log: Merge kern_proc.c:1.257, sysctl.h:1.154, and user.h:1.72 from HEAD to RELENG_7: Add another new sysctl in support of the forthcoming procstat(1) to support its -k argument: kern.proc.kstack - dump the kernel stack of a process, if debugging is permitted. This sysctl is present if either "options DDB" or "options STACK" is compiled into the kernel. Having support for tracing the kernel stacks of processes from user space makes it much easier to debug (or understand) specific wmesg's while avoiding the need to enter DDB in order to determine the path by which a process came to be blocked on a particular wait channel or lock. Revision Changes Path 1.252.2.5 +106 -0 src/sys/kern/kern_proc.c 1.148.2.2 +1 -0 src/sys/sys/sysctl.h 1.70.2.2 +19 -0 src/sys/sys/user.h From rwatson at FreeBSD.org Thu Apr 10 22:49:39 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Apr 10 22:49:50 2008 Subject: cvs commit: src/usr.bin/procstat Makefile procstat.1 procstat.c procstat.h procstat_args.c procstat_basic.c procstat_bin.c procstat_cred.c procstat_files.c procstat_kstack.c procstat_threads.c procstat_vm.c Message-ID: <200804102249.m3AMndtA048517@repoman.freebsd.org> rwatson 2008-04-10 22:49:39 UTC FreeBSD src repository Added files: (Branch: RELENG_7) usr.bin/procstat Makefile procstat.1 procstat.c procstat.h procstat_args.c procstat_basic.c procstat_bin.c procstat_cred.c procstat_files.c procstat_kstack.c procstat_threads.c procstat_vm.c Log: Merge Makefile:1.1, procstat.1:1.1, procstat.c:1.1, procstat.h:1.1, procstat_args.c:1.1, procstat_basic.c:1.1, procstat_bin.c:1.1, procstat_cred.c:1.1, procstat_files.c:1.1, procstat_kstack.c:1.1, procstat_threads.c:1.1, and procstat_vm.c:1.1 from HEAD to RELENG_7: Add procstat(1), a process inspection utility. This provides both some of the missing functionality from procfs(4) and new functionality for monitoring and debugging specific processes. procstat(1) operates in the following modes: -b Display binary information for the process. -c Display command line arguments for the process. -f Display file descriptor information for the process. -k Display the stacks of kernel threads in the process. -s Display security credential information for the process. -t Display thread information for the process. -v Display virtual memory mappings for the process. Further revision and modes are expected. Testing, ideas, etc: cognet, sam, Skip Ford Wesley Shields Revision Changes Path 1.1.2.1 +15 -0 src/usr.bin/procstat/Makefile (new) 1.1.2.1 +114 -0 src/usr.bin/procstat/procstat.1 (new) 1.2.2.1 +252 -0 src/usr.bin/procstat/procstat.c (new) 1.1.2.1 +46 -0 src/usr.bin/procstat/procstat.h (new) 1.2.2.1 +74 -0 src/usr.bin/procstat/procstat_args.c (new) 1.2.2.1 +64 -0 src/usr.bin/procstat/procstat_basic.c (new) 1.2.2.1 +68 -0 src/usr.bin/procstat/procstat_bin.c (new) 1.2.2.1 +57 -0 src/usr.bin/procstat/procstat_cred.c (new) 1.5.2.1 +303 -0 src/usr.bin/procstat/procstat_files.c (new) 1.3.2.1 +198 -0 src/usr.bin/procstat/procstat_kstack.c (new) 1.3.2.1 +138 -0 src/usr.bin/procstat/procstat_threads.c (new) 1.2.2.1 +130 -0 src/usr.bin/procstat/procstat_vm.c (new) From rwatson at FreeBSD.org Thu Apr 10 22:50:44 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Apr 10 22:50:46 2008 Subject: cvs commit: src/usr.bin Makefile Message-ID: <200804102250.m3AMoiri048703@repoman.freebsd.org> rwatson 2008-04-10 22:50:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.bin Makefile Log: Merge Makefile:1.304 from HEAD to RELENG_7: Connect procstat(1) to the build. Revision Changes Path 1.303.2.2 +1 -0 src/usr.bin/Makefile From rwatson at FreeBSD.org Thu Apr 10 22:57:19 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Apr 10 22:57:29 2008 Subject: cvs commit: src/sys/kern subr_stack.c Message-ID: <200804102257.m3AMvIg8049398@repoman.freebsd.org> rwatson 2008-04-10 22:57:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern subr_stack.c Log: Merge subr_stack.c:1.6 from HEAD to RELENG_7: When a symbol name can't be resolved, return "??" as the name, rather than "Unknown func", in order to avoid putting spaces in what ideally is a string separated by white space. Revision Changes Path 1.3.2.3 +2 -2 src/sys/kern/subr_stack.c From imp at FreeBSD.org Thu Apr 10 22:57:55 2008 From: imp at FreeBSD.org (Warner Losh) Date: Thu Apr 10 22:58:01 2008 Subject: cvs commit: src/usr.sbin/config main.c Message-ID: <200804102257.m3AMvsOn049477@repoman.freebsd.org> imp 2008-04-10 22:57:54 UTC FreeBSD src repository Modified files: usr.sbin/config main.c Log: Fix a bug introduced by DEFAULTS feature. When the config file doesn't exist, we make a directory and then say "oops, that file isn't there" leaving the directory behind. Add a stat for the config file so that we detect this before making the directory. This is semi-lame, but less lame than having this bug. Revision Changes Path 1.78 +2 -0 src/usr.sbin/config/main.c From rwatson at FreeBSD.org Thu Apr 10 22:58:11 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Apr 10 22:58:17 2008 Subject: cvs commit: src/usr.bin/procstat procstat_kstack.c procstat_threads.c Message-ID: <200804102258.m3AMwBuC049517@repoman.freebsd.org> rwatson 2008-04-10 22:58:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.bin/procstat procstat_kstack.c procstat_threads.c Log: Merge procstaT_kstack.c:1.2, procstat_threads.c:1.2 from HEAD to RELENG_7: Display per-thread command line in TDNAME field for -k and -t; if no per-thread name is available or the name is identical to the process name, display "-" instead. Very slightly shrink the COMM entry to make a bit more room, although this doesn't help with stack traces much. Suggested by: thompsa Revision Changes Path 1.3.2.2 +65 -18 src/usr.bin/procstat/procstat_kstack.c 1.3.2.2 +6 -3 src/usr.bin/procstat/procstat_threads.c From rwatson at FreeBSD.org Thu Apr 10 22:58:59 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Apr 10 22:59:07 2008 Subject: cvs commit: src/sys/kern kern_proc.c Message-ID: <200804102258.m3AMwxbE049626@repoman.freebsd.org> rwatson 2008-04-10 22:58:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern kern_proc.c Log: Merge kern_proc.c:1.258 from HEAD to RELENG_7: Check for P_WEXIT before PHOLD() on a process in kstack and vm query sysctls, as PHOLD() asserts !P_WEXIT. Reported by: Michael Plass Revision Changes Path 1.252.2.6 +8 -0 src/sys/kern/kern_proc.c From delphij at FreeBSD.org Thu Apr 10 23:49:23 2008 From: delphij at FreeBSD.org (Xin LI) Date: Thu Apr 10 23:49:35 2008 Subject: cvs commit: src/sbin/fsck_ffs fsck.h fsck_ffs.8 fsutil.c inode.c main.c Message-ID: <200804102349.m3ANnNaN053949@repoman.freebsd.org> delphij 2008-04-10 23:49:23 UTC FreeBSD src repository Modified files: sbin/fsck_ffs fsck.h fsck_ffs.8 fsutil.c inode.c main.c Log: Add a new flag, '-C' which enables a special mode that is intended for catastrophic recovery. Currently, this mode only validates whether a cylindergroup has good signature data, and prompts the user to decide whether to clear it as a whole. This mode is useful when there is data damage on a disk and you are working on copy of the original disk, as fsck_ffs(8) tends to abnormally exit in such case, as a last resort to recover data from the disk. Revision Changes Path 1.38 +2 -0 src/sbin/fsck_ffs/fsck.h 1.35 +22 -2 src/sbin/fsck_ffs/fsck_ffs.8 1.27 +30 -2 src/sbin/fsck_ffs/fsutil.c 1.39 +1 -2 src/sbin/fsck_ffs/inode.c 1.51 +6 -1 src/sbin/fsck_ffs/main.c From brooks at FreeBSD.org Fri Apr 11 00:18:00 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Fri Apr 11 00:18:10 2008 Subject: cvs commit: src/sbin/dhclient dhclient-script Message-ID: <200804110018.m3B0I0Q7056842@repoman.freebsd.org> brooks 2008-04-11 00:17:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sbin/dhclient dhclient-script Log: MFC rev 1.19 Add a new function is_default_interface() which determines if this interface is one with the default route (or there isn't one). Use it to decide if we should adjust the default route and /etc/resolv.conf. Fix the delete of the default route. The if statement was totally bogus and the delete only worked due to a typo. [1] Reported by: Jordan Coleman [1] Revision Changes Path 1.17.2.2 +48 -20 src/sbin/dhclient/dhclient-script From brooks at FreeBSD.org Fri Apr 11 00:18:37 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Fri Apr 11 00:18:40 2008 Subject: cvs commit: src/sbin/dhclient dhclient-script Message-ID: <200804110018.m3B0Ib7U056933@repoman.freebsd.org> brooks 2008-04-11 00:18:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sbin/dhclient dhclient-script Log: MFC rev 1.19 Add a new function is_default_interface() which determines if this interface is one with the default route (or there isn't one). Use it to decide if we should adjust the default route and /etc/resolv.conf. Fix the delete of the default route. The if statement was totally bogus and the delete only worked due to a typo. [1] Reported by: Jordan Coleman [1] Revision Changes Path 1.4.2.8 +48 -20 src/sbin/dhclient/dhclient-script From davidxu at FreeBSD.org Fri Apr 11 01:42:21 2008 From: davidxu at FreeBSD.org (David Xu) Date: Fri Apr 11 01:42:28 2008 Subject: cvs commit: src/lib/libthr/thread thr_create.c thr_private.h thr_sig.c Message-ID: <200804110142.m3B1gKQQ075519@repoman.freebsd.org> davidxu 2008-04-11 01:42:20 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libthr/thread thr_create.c thr_private.h thr_sig.c Log: MFC: Unblock SIGCANCEL for thread created by cleanup handler. Revision Changes Path 1.36.2.1 +30 -11 src/lib/libthr/thread/thr_create.c 1.78.2.2 +6 -0 src/lib/libthr/thread/thr_private.h 1.23.2.1 +2 -0 src/lib/libthr/thread/thr_sig.c From davidxu at FreeBSD.org Fri Apr 11 02:38:29 2008 From: davidxu at FreeBSD.org (David Xu) Date: Fri Apr 11 02:38:40 2008 Subject: cvs commit: src/sys/kern kern_umtx.c Message-ID: <200804110238.m3B2cTtr086093@repoman.freebsd.org> davidxu 2008-04-11 02:38:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern kern_umtx.c Log: MFC: Modifying td_flags with thread lock held. Revision Changes Path 1.61.2.2 +2 -0 src/sys/kern/kern_umtx.c From jeff at FreeBSD.org Fri Apr 11 03:26:41 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Fri Apr 11 03:26:44 2008 Subject: cvs commit: src/sys/amd64/amd64 intr_machdep.c src/sys/arm/arm intr.c src/sys/i386/i386 intr_machdep.c src/sys/ia64/ia64 interrupt.c src/sys/kern kern_cpuset.c kern_intr.c src/sys/powerpc/powerpc intr_machdep.c src/sys/sparc64/sparc64 ... Message-ID: <200804110326.m3B3QfjL095474@repoman.freebsd.org> jeff 2008-04-11 03:26:41 UTC FreeBSD src repository Modified files: sys/amd64/amd64 intr_machdep.c sys/arm/arm intr.c sys/i386/i386 intr_machdep.c sys/ia64/ia64 interrupt.c sys/kern kern_cpuset.c kern_intr.c sys/powerpc/powerpc intr_machdep.c sys/sparc64/sparc64 intr_machdep.c sys/sun4v/sun4v intr_machdep.c sys/sys cpuset.h interrupt.h Log: - Add the interrupt vector number to intr_event_create so MI code can lookup hard interrupt events by number. Ignore the irq# for soft intrs. - Add support to cpuset for binding hardware interrupts. This has the side effect of binding any ithread associated with the hard interrupt. As per restrictions imposed by MD code we can only bind interrupts to a single cpu presently. Interrupts can be 'unbound' by binding them to all cpus. Reviewed by: jhb Sponsored by: Nokia Revision Changes Path 1.41 +1 -1 src/sys/amd64/amd64/intr_machdep.c 1.21 +1 -1 src/sys/arm/arm/intr.c 1.36 +1 -1 src/sys/i386/i386/intr_machdep.c 1.66 +1 -1 src/sys/ia64/ia64/interrupt.c 1.9 +16 -0 src/sys/kern/kern_cpuset.c 1.162 +97 -59 src/sys/kern/kern_intr.c 1.21 +1 -1 src/sys/powerpc/powerpc/intr_machdep.c 1.33 +1 -1 src/sys/sparc64/sparc64/intr_machdep.c 1.11 +2 -2 src/sys/sun4v/sun4v/intr_machdep.c 1.7 +1 -0 src/sys/sys/cpuset.h 1.41 +5 -2 src/sys/sys/interrupt.h From jeff at FreeBSD.org Fri Apr 11 03:27:43 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Fri Apr 11 03:27:47 2008 Subject: cvs commit: src/usr.bin/cpuset cpuset.c Message-ID: <200804110327.m3B3RggJ095716@repoman.freebsd.org> jeff 2008-04-11 03:27:42 UTC FreeBSD src repository Modified files: usr.bin/cpuset cpuset.c Log: - Add support for interrupt bindig to cpuset(1). Interrupts are bound by specifying the interrupt with -x . The irq number matches those displayed by vmstat -i. Sponsored by: Nokia Revision Changes Path 1.5 +19 -7 src/usr.bin/cpuset/cpuset.c From jroberson at jroberson.net Fri Apr 11 03:34:56 2008 From: jroberson at jroberson.net (Jeff Roberson) Date: Fri Apr 11 03:35:02 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-card.c ata-cbus.c ata-chipset.c ata-disk.c ata-disk.h ata-dma.c ata-isa.c ata-lowlevel.c ata-pci.c ata-pci.h ata-queue.c ata-raid.c ata-raid.h ata-usb.c ata_if.m atapi-cd.c atapi-cd.h atapi-fd.c ... In-Reply-To: <200804101305.m3AD55DK066187@repoman.freebsd.org> References: <200804101305.m3AD55DK066187@repoman.freebsd.org> Message-ID: <20080410170530.V43186@desktop> I have two problems with this patch. First, it seems to break my amr device which is no longer able to probe disks. Backing out this commit fixes the problem. Secondly, with WITNESS enabled my console is full of the following errors on boot: uma_zalloc_arg: zone "16" with the following non-sleepable locks held:^M exclusive sleep mutex ATA state lock r = 0 (0xffffff0004117678) locked @ dev/ata /ata-queue.c:194^M exclusive sleep mutex ATA queue lock r = 0 (0xffffff00041176b0) locked @ dev/ata /ata-queue.c:177^M KDB: stack backtrace:^M db_trace_self_wrapper() at db_trace_self_wrapper+0x27^M kdb_backtrace() at kdb_backtrace+0x3e^M witness_warn() at witness_warn+0x374^M uma_zalloc_arg() at uma_zalloc_arg+0x3f^M uma_zalloc() at uma_zalloc+0x20^M malloc() at malloc+0x122^M sysctl_add_oid() at sysctl_add_oid+0x11d^M alloc_bounce_zone() at alloc_bounce_zone+0x204^M bus_dma_tag_create() at bus_dma_tag_create+0x2d1^M ata_dmaload() at ata_dmaload+0x341^M ata_begin_transaction() at ata_begin_transaction+0x22f^M ata_start() at ata_start+0x24c^M ata_queue_request() at ata_queue_request+0x3da^M ata_raid_rw() at ata_raid_rw+0x14b^M ata_raid_adaptec_read_meta() at ata_raid_adaptec_read_meta+0x8a^M ata_raid_read_metadata() at ata_raid_read_metadata+0x297^M ata_raid_subdisk_attach() at ata_raid_subdisk_attach+0x57^M DEVICE_ATTACH() at DEVICE_ATTACH+0x84^M device_attach() at device_attach+0x3c^M device_probe_and_attach() at device_probe_and_attach+0x10d^M bus_generic_attach() at bus_generic_attach+0x23^M ad_attach() at ad_attach+0x25f^M DEVICE_ATTACH() at DEVICE_ATTACH+0x84^M device_attach() at device_attach+0x3c^M device_probe_and_attach() at device_probe_and_attach+0x10d^M bus_generic_attach() at bus_generic_attach+0x23^M ata_identify() at ata_identify+0x225^M ata_boot_attach() at ata_boot_attach+0x54^M run_interrupt_driven_config_hooks() at run_interrupt_driven_config_hooks+0x79^M mi_startup() at mi_startup+0x11b^M It's not legal to call bus_dma_tag_create with locks held. Thanks, Jeff On Thu, 10 Apr 2008, Søren Schmidt wrote: > sos 2008-04-10 13:05:05 UTC > > FreeBSD src repository > > Modified files: > sys/dev/ata ata-all.c ata-all.h ata-card.c ata-cbus.c > ata-chipset.c ata-disk.c ata-disk.h > ata-dma.c ata-isa.c ata-lowlevel.c > ata-pci.c ata-pci.h ata-queue.c > ata-raid.c ata-raid.h ata-usb.c ata_if.m > atapi-cd.c atapi-cd.h atapi-fd.c > atapi-fd.h atapi-tape.c atapi-tape.h > Log: > Add experimental support for SATA Port Multipliers > > Support is working on the Silicon Image SiI3124/3132. > Support is working on some AHCI chips but far from all. > > Remember this is WIP, so test reports and (constructive) suggestions are welcome! > > Revision Changes Path > 1.282 +73 -57 src/sys/dev/ata/ata-all.c > 1.129 +42 -25 src/sys/dev/ata/ata-all.h > 1.41 +1 -1 src/sys/dev/ata/ata-card.c > 1.26 +1 -1 src/sys/dev/ata/ata-cbus.c > 1.213 +797 -266 src/sys/dev/ata/ata-chipset.c > 1.208 +117 -48 src/sys/dev/ata/ata-disk.c > 1.54 +1 -1 src/sys/dev/ata/ata-disk.h > 1.151 +160 -132 src/sys/dev/ata/ata-dma.c > 1.32 +1 -1 src/sys/dev/ata/ata-isa.c > 1.81 +31 -33 src/sys/dev/ata/ata-lowlevel.c > 1.124 +41 -40 src/sys/dev/ata/ata-pci.c > 1.84 +1 -2 src/sys/dev/ata/ata-pci.h > 1.70 +8 -3 src/sys/dev/ata/ata-queue.c > 1.127 +1 -1 src/sys/dev/ata/ata-raid.c > 1.47 +1 -1 src/sys/dev/ata/ata-raid.h > 1.8 +1 -2 src/sys/dev/ata/ata-usb.c > 1.8 +1 -1 src/sys/dev/ata/ata_if.m > 1.197 +4 -9 src/sys/dev/ata/atapi-cd.c > 1.48 +1 -1 src/sys/dev/ata/atapi-cd.h > 1.112 +3 -7 src/sys/dev/ata/atapi-fd.c > 1.28 +1 -1 src/sys/dev/ata/atapi-fd.h > 1.105 +5 -13 src/sys/dev/ata/atapi-tape.c > 1.26 +1 -1 src/sys/dev/ata/atapi-tape.h > From yongari at FreeBSD.org Fri Apr 11 03:42:02 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Fri Apr 11 03:42:09 2008 Subject: cvs commit: src/sys/conf files src/sys/dev/vr if_vr.c if_vrreg.h src/sys/modules/vr Makefile src/sys/pci if_vr.c if_vrreg.h Message-ID: <200804110341.m3B3fx10098296@repoman.freebsd.org> yongari 2008-04-11 03:41:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/conf files sys/modules/vr Makefile Added files: (Branch: RELENG_7) sys/dev/vr if_vr.c if_vrreg.h Removed files: (Branch: RELENG_7) sys/pci if_vr.c if_vrreg.h Log: MFC vr(4) to latest HEAD. o vr(4) repocopied from sys/pci to sys/dev/vr. Teach vr(4) to use bus_dma(9) and major overhauling to handle link state change and reliable error recovery. o Moved vr_softc structure and relevant macros to header file. o Use PCIR_BAR macro to get BARs. o Implemented suspend/resume methods. o Implemented automatic Tx threshold configuration which will be activated when it suffers from Tx underrun. Also Tx underrun will try to restart only Tx path and resort to previous full-reset(both Rx/Tx) operation if restarting Tx path have failed. o Removed old bit-banging MII interface. Rhine provides simple and efficient MII interface. While I'm here show PHY address and PHY register number when its read/write operation was failed. o Define VR_MII_TIMEOUT constant and use it in MII access routines. o Always honor link up/down state reported by mii layers. The link state information is used in vr_start() to determine whether we got a valid link. o Removed vr_setcfg() which is now handled in vr_link_task(), link state taskqueue handler. When mii layer reports link state changes the taskqueue handler reprograms MAC to reflect negotiated duplex settings. Flow-control changes are not handled yet and it should be revisited when mii layer knows the notion of flow-control. o Added a new sysctl interface to get statistics of an instance of the driver.(sysctl dev.vr.0.stats=1) o Chip name was renamed to reflect the official name of the chips described in VIA Rhine I/II/III datasheet. REV_ID_3065_A -> REV_ID_VT6102_A REV_ID_3065_B -> REV_ID_VT6102_B REV_ID_3065_C -> REV_ID_VT6102_C REV_ID_3106_J -> REV_ID_VT6105_A0 REV_ID_3106_S -> REV_ID_VT6105M_A0 The following chip revisions were added. #define REV_ID_VT6105_B0 0x83 #define REV_ID_VT6105_LOM 0x8A #define REV_ID_VT6107_A0 0x8C #define REV_ID_VT6107_A1 0x8D #define REV_ID_VT6105M_B1 0x94 o Always show chip revision number in device attach. This shall help identifying revision specific issues. o Check whether EEPROM reloading is complete by inspecting the state of VR_EECSR_LOAD bit. This bit is self-cleared after the EEPROM reloading. Previously vr(4) blindly spins for 200us which may/may not enough to complete the EEPROM reload. o Removed if_mtu setup. It's done in ether_ifattach(). o Use our own callout to drive watchdog timer. o In vr_attach disable further interrupts after reset. For VT6102 or newer hardwares, diable MII state change interrupt as well because mii state handling is done by mii layer. o Add more sane register initialization for VT6102 or newer chips. - Have NIC report error instead of retrying forever. - Let hardware detect MII coding error. - Enable MODE10T mode. - Enable memory-read-multiple for VT6107. o PHY address for VT6105 or newer chips is located at fixed address 1. For older chips the PHY address is stored in VR_PHYADDR register. Armed with these information, there is no need to re-read VR_PHYADDR register in miibus handler to get PHY address. This saves one register access cycle for each MII access. o Don't reprogram VR_PHYADDR register whenever access to a register located at a PHY address is made. Rhine fmaily allows reprogramming PHY address location via VR_PHYADDR register depending on VR_MIISTAT_PHYOPT bit of VR_MIISTAT register. This used to lead numerous phantom PHYs attached to miibus during phy probe phase and driver used to limit allowable PHY address in mii register accessors for certain chip revisions. This removes one more register access cycle for each MII access. o Correctly set VLAN header length. o bus_dma(9) conversion. - Limit DMA access to be in range of 32bit address space. Hardware doesn't support DAC. - Apply descriptor ring alignment requirements(16 bytes alignment) - Apply Rx buffer address alignment requirements(4 bytes alignment) - Apply Tx buffer address alignment requirements(4 bytes alignment) for Rhine I chip. Rhine II or III has no Tx buffer address alignment restrictions, though. - Reduce number of allowable number of DMA segments to 8. - Removed the atomic(9) used in descriptor ownership managements as it's job of bus_dmamap_sync(9). With these change vr(4) should work on all platforms. o Rhine uses two separated 8bits command registers to control Tx/Rx MAC. So don't access it as a single 16bit register. o For non-strict alignment architectures vr(4) no longer require time-consuming copy operation for received frames to align IP header. This greatly improves Rx performance on i386/amd64 platforms. However the alignment is still necessary for strict-alignment platforms(e.g. sparc64). The alignment is handled in new fuction vr_fixup_rx(). o vr_rxeof() now rejects multiple-segmented(fragmented) frames as vr(4) is not ready to handle this situation. Datasheet said nothing about the reason when/why it happens. o In vr_newbuf() don't set VR_RXSTAT_FIRSTFRAG/VR_RXSTAT_LASTFRAG bits as it's set by hardware. o Don't pass checksum offload information to upper layer for fragmented frames. The hardware assisted checksum is valid only when the frame is non-fragmented IP frames. Also mark the checksum is valid for corrupted frames such that upper layers doesn't need to recompute the checksum with software routine. o Removed vr_rxeoc(). RxDMA doesn't seem to need to be idle before sending VR_CMD_RX_GO command. Previously it used to stop RxDMA first which in turn resulted in long delays in Rx error recovery. o Rewrote Tx completion handler. - Always check VR_TXSTAT_OWN bit in status word prior to inspecting other status bits in the status word. - Collision counter updates were corrected as VT3071 or newer ones use different bits to notify collisions. - Unlike other chip revisions, VT86C100A uses different bit to indicate Tx underrun. For VT3071 or newer ones, check both VR_TXSTAT_TBUFF and VR_TXSTAT_UDF bits to see whether Tx underrun was happend. In case of Tx underrun requeue the failed frame and restart stalled Tx SM. Also double Tx DMA threshold size on each failure to mitigate future Tx underruns. - Disarm watchdog timer only if we have no queued packets, otherwise don't touch watchdog timer. o Rewrote interrupt handler. - status word in Tx/Rx descriptors indicates more detailed error state required to recover from the specific error. There is no need to rely on interrupt status word to recover from Tx/Rx error except PCI bus error. Other event notifications like statistics counter overflows or link state events will be handled in main interrupt handler. - Don't touch VR_IMR register if we are in suspend mode. Touching the register may hang the hardware if we are in suspended state. Previously it seems that touching VR_IMR register in interrupt handler was to work-around panic occurred in system shutdown stage on SMP systems. I think that work-around would hide root-cause of the panic and I couldn't reproduce the panic with multiple attempts on my box. o While padding space to meet minimum frame size, zero the pad data in order to avoid possibly leaking sensitive data. o Rewrote vr_start_locked(). - Don't try to queue packets if number of available Tx descriptors are short than that of required one. o Don't reinitialize hardware whenever media configuration is changed. Media/link state changes are reported from mii layer if this happens and vr_link_task() will perform necessary changes. o Don't reinitialize hardware if only PROMISC bit was changed. Just toggle the PROMISC bit in hardware is sufficient to reflect the request. o Rearrganed the IFCAP_POLLING/IFCAP_HWCSUM handling in vr_ioctl(). o Generate Tx completion interrupts for every VR_TX_INTR_THRESH-th frames. This reduces Tx completion interrupts under heavy network loads. o Since vr(4) doesn't request Tx interrupts for every queued frames, reclaim any pending descriptors not handled in Tx completion handler before actually firing up watchdog timeouts. o Added vr_tx_stop()/vr_rx_stop() to wait for the end of active TxDMA/RxDMA cycles(draining). These routines are used in vr_stop() to ensure sane state of MAC before releasing allocated Tx/Rx buffers. vr_link_task() also takes advantage of these functions to get to idle state prior to restarting Tx/Rx. o Added vr_tx_start()/vr_rx_start() to restart Rx/Tx. By separating Rx operation from Tx operation vr(4) no longer need to full-reset the hardware in case of Tx/Rx error recovery. o Implemented WOL. o Added VT6105M specific register definitions. VT6105M has the following hardware capabilities. - Tx/Rx IP/TCP/UDP checksum offload. - VLAN hardware tag insertion/extraction. Due to lack of information for getting extracted VLAN tag in Rx path, VLAN hardware support was not implemented yet. - CAM(Content Addressable Memory) based 32 entry perfect multicast/ VLAN filtering. - 8 priority queues. o Implemented CAM based 32 entry perfect multicast filtering for VT6105M. If number of multicast entry is greater than 32, vr(4) uses traditional hash based filtering. o Reflect real Tx/Rx descriptor structure. Previously vr(4) used to embed other driver (private) data into these structure. This type of embedding make it hard to work on LP64 systems. o Removed unused vr_mii_frame structure and MII bit-baning definitions. o Added new PCI configuration registers that controls mii operation and mode selection. o Reduced number of Tx/Rx descriptors to 128 from 256. From my testing, increasing number of descriptors above than 64 didn't help increasing performance at all. Experimentations show 128 Rx descriptors seems to help a lot reducing Rx FIFO overruns under high system loads. It seems the poor Tx performance of Rhine hardwares comes from the limitation of hardware. You wouldn't satuarte the link with vr(4) no matter how fast CPU/large number of descriptors are used. o Added vr_statistics structure to hold various counter values. Revision Changes Path 1.1243.2.15 +1 -1 src/sys/conf/files 1.130.2.1 +2590 -0 src/sys/dev/vr/if_vr.c (new) 1.36.2.1 +752 -0 src/sys/dev/vr/if_vrreg.h (new) 1.13.2.1 +1 -1 src/sys/modules/vr/Makefile 1.126.2.3 +0 -1605 src/sys/pci/if_vr.c (dead) 1.34.2.1 +0 -520 src/sys/pci/if_vrreg.h (dead) From yongari at FreeBSD.org Fri Apr 11 03:49:48 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Fri Apr 11 03:49:49 2008 Subject: cvs commit: src/share/man/man4 vr.4 Message-ID: <200804110349.m3B3nlBh099540@repoman.freebsd.org> yongari 2008-04-11 03:49:47 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man4 vr.4 Log: MFC vr.4 rev 1.31 to RELENG_7. Document a new sysctl variable, dev.vr.%d.stats. Revision Changes Path 1.30.2.1 +9 -1 src/share/man/man4/vr.4 From yongari at FreeBSD.org Fri Apr 11 03:52:24 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Fri Apr 11 03:52:33 2008 Subject: cvs commit: src/sys/sparc64/conf GENERIC Message-ID: <200804110352.m3B3qO7A000141@repoman.freebsd.org> yongari 2008-04-11 03:52:23 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/sparc64/conf GENERIC Log: MFC GENERIC rev 1.132 to RELENG_7. Uncomment vr(4), vr(4) should work on all architectures. Revision Changes Path 1.127.2.4 +1 -1 src/sys/sparc64/conf/GENERIC From yongari at FreeBSD.org Fri Apr 11 04:01:25 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Fri Apr 11 04:01:30 2008 Subject: cvs commit: src/sys/dev/stge if_stge.c if_stgereg.h Message-ID: <200804110401.m3B41PIN001796@repoman.freebsd.org> yongari 2008-04-11 04:01:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/stge if_stge.c if_stgereg.h Log: MFC if_stge.c rev 1.11, if_stgereg.h rev 1.4 to RELENG_7. Implement WOL capability. - Turn on WOL bits in suspend/shutdown method. - WOL is disabled in resume routine as WOL can interfere normal Rx operation. - Move stge_reset() to stge_init_locked() as resetting hardware clears configured Rx information which in turn results in non-working Rx module after suspend/shutdown operation. Revision Changes Path 1.9.2.2 +46 -11 src/sys/dev/stge/if_stge.c 1.3.2.1 +8 -0 src/sys/dev/stge/if_stgereg.h From yongari at FreeBSD.org Fri Apr 11 04:03:37 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Fri Apr 11 04:03:42 2008 Subject: cvs commit: src/sys/dev/stge if_stge.c Message-ID: <200804110403.m3B43bDh003302@repoman.freebsd.org> yongari 2008-04-11 04:03:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/stge if_stge.c Log: MFC if_stge.c rev 1.12 to RELENG_7. Use m_collapse(9) to collapse mbuf chains instead of relying on shortest possible chain of mbufs of m_defrag(9). What we want is chains of mbufs that can be safely stored to a Tx descriptor which can have up to STGE_MAXTXSEGS mbufs. The ethernet controller does not need to align Tx buffers on 32bit boundary. So the use of m_defrag(9) was waste of time. Revision Changes Path 1.9.2.3 +1 -1 src/sys/dev/stge/if_stge.c From niclas.zeising at gmail.com Fri Apr 11 04:05:03 2008 From: niclas.zeising at gmail.com (Niclas Zeising) Date: Fri Apr 11 04:05:14 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-card.c ata-cbus.c ata-chipset.c ata-disk.c ata-disk.h ata-dma.c ata-isa.c ata-lowlevel.c ata-pci.c ata-pci.h ata-queue.c ata-raid.c ata-raid.h ata-usb.c ata_if.m atapi-cd.c atapi-cd.h atapi-fd.c ... In-Reply-To: <20080410170530.V43186@desktop> References: <200804101305.m3AD55DK066187@repoman.freebsd.org> <20080410170530.V43186@desktop> Message-ID: <47FEE343.9000705@gmail.com> Jeff Roberson wrote: > I have two problems with this patch. First, it seems to break my amr > device which is no longer able to probe disks. Backing out this commit > fixes the problem. > > Secondly, with WITNESS enabled my console is full of the following > errors on boot: > > uma_zalloc_arg: zone "16" with the following non-sleepable locks held:^M > exclusive sleep mutex ATA state lock r = 0 (0xffffff0004117678) locked @ > dev/ata > /ata-queue.c:194^M > exclusive sleep mutex ATA queue lock r = 0 (0xffffff00041176b0) locked @ > dev/ata > /ata-queue.c:177^M > KDB: stack backtrace:^M > db_trace_self_wrapper() at db_trace_self_wrapper+0x27^M > kdb_backtrace() at kdb_backtrace+0x3e^M > witness_warn() at witness_warn+0x374^M > uma_zalloc_arg() at uma_zalloc_arg+0x3f^M > uma_zalloc() at uma_zalloc+0x20^M > malloc() at malloc+0x122^M > sysctl_add_oid() at sysctl_add_oid+0x11d^M > alloc_bounce_zone() at alloc_bounce_zone+0x204^M > bus_dma_tag_create() at bus_dma_tag_create+0x2d1^M > ata_dmaload() at ata_dmaload+0x341^M > ata_begin_transaction() at ata_begin_transaction+0x22f^M > ata_start() at ata_start+0x24c^M > ata_queue_request() at ata_queue_request+0x3da^M > ata_raid_rw() at ata_raid_rw+0x14b^M > ata_raid_adaptec_read_meta() at ata_raid_adaptec_read_meta+0x8a^M > ata_raid_read_metadata() at ata_raid_read_metadata+0x297^M > ata_raid_subdisk_attach() at ata_raid_subdisk_attach+0x57^M > DEVICE_ATTACH() at DEVICE_ATTACH+0x84^M > device_attach() at device_attach+0x3c^M > device_probe_and_attach() at device_probe_and_attach+0x10d^M > bus_generic_attach() at bus_generic_attach+0x23^M > ad_attach() at ad_attach+0x25f^M > DEVICE_ATTACH() at DEVICE_ATTACH+0x84^M > device_attach() at device_attach+0x3c^M > device_probe_and_attach() at device_probe_and_attach+0x10d^M > bus_generic_attach() at bus_generic_attach+0x23^M > ata_identify() at ata_identify+0x225^M > ata_boot_attach() at ata_boot_attach+0x54^M > run_interrupt_driven_config_hooks() at > run_interrupt_driven_config_hooks+0x79^M > mi_startup() at mi_startup+0x11b^M > > It's not legal to call bus_dma_tag_create with locks held. > > Thanks, > Jeff Also, it seems to panic my machine. Can't confirm though, and since it was during a installworld my machine is too botched to do anything but reinstall. The panic string is: Too many DMA segment entries and the top of the backtrace, before the call to panic() is a call to ata_setup_interrupt(). Can't get further though as the system is totaly botched. The controller is a intel AHCI one. I also got the same LORs as Jeff. Regards! Niclas > > On Thu, 10 Apr 2008, S?ren Schmidt wrote: > >> sos 2008-04-10 13:05:05 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/ata ata-all.c ata-all.h ata-card.c ata-cbus.c >> ata-chipset.c ata-disk.c ata-disk.h >> ata-dma.c ata-isa.c ata-lowlevel.c >> ata-pci.c ata-pci.h ata-queue.c >> ata-raid.c ata-raid.h ata-usb.c ata_if.m >> atapi-cd.c atapi-cd.h atapi-fd.c >> atapi-fd.h atapi-tape.c atapi-tape.h >> Log: >> Add experimental support for SATA Port Multipliers >> >> Support is working on the Silicon Image SiI3124/3132. >> Support is working on some AHCI chips but far from all. >> >> Remember this is WIP, so test reports and (constructive) suggestions >> are welcome! >> >> Revision Changes Path >> 1.282 +73 -57 src/sys/dev/ata/ata-all.c >> 1.129 +42 -25 src/sys/dev/ata/ata-all.h >> 1.41 +1 -1 src/sys/dev/ata/ata-card.c >> 1.26 +1 -1 src/sys/dev/ata/ata-cbus.c >> 1.213 +797 -266 src/sys/dev/ata/ata-chipset.c >> 1.208 +117 -48 src/sys/dev/ata/ata-disk.c >> 1.54 +1 -1 src/sys/dev/ata/ata-disk.h >> 1.151 +160 -132 src/sys/dev/ata/ata-dma.c >> 1.32 +1 -1 src/sys/dev/ata/ata-isa.c >> 1.81 +31 -33 src/sys/dev/ata/ata-lowlevel.c >> 1.124 +41 -40 src/sys/dev/ata/ata-pci.c >> 1.84 +1 -2 src/sys/dev/ata/ata-pci.h >> 1.70 +8 -3 src/sys/dev/ata/ata-queue.c >> 1.127 +1 -1 src/sys/dev/ata/ata-raid.c >> 1.47 +1 -1 src/sys/dev/ata/ata-raid.h >> 1.8 +1 -2 src/sys/dev/ata/ata-usb.c >> 1.8 +1 -1 src/sys/dev/ata/ata_if.m >> 1.197 +4 -9 src/sys/dev/ata/atapi-cd.c >> 1.48 +1 -1 src/sys/dev/ata/atapi-cd.h >> 1.112 +3 -7 src/sys/dev/ata/atapi-fd.c >> 1.28 +1 -1 src/sys/dev/ata/atapi-fd.h >> 1.105 +5 -13 src/sys/dev/ata/atapi-tape.c >> 1.26 +1 -1 src/sys/dev/ata/atapi-tape.h >> > > ------------------------------------------------------------------------ > > _______________________________________________ > cvs-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-all > To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" From xcllnt at mac.com Fri Apr 11 04:40:16 2008 From: xcllnt at mac.com (Marcel Moolenaar) Date: Fri Apr 11 04:40:22 2008 Subject: cvs commit: src/sys/amd64/amd64 intr_machdep.c src/sys/arm/arm intr.c src/sys/i386/i386 intr_machdep.c src/sys/ia64/ia64 interrupt.c src/sys/kern kern_cpuset.c kern_intr.c src/sys/powerpc/powerpc intr_machdep.c src/sys/sparc64/sparc64 ... In-Reply-To: <200804110326.m3B3QfjL095474@repoman.freebsd.org> References: <200804110326.m3B3QfjL095474@repoman.freebsd.org> Message-ID: On Apr 10, 2008, at 8:26 PM, Jeff Roberson wrote: > jeff 2008-04-11 03:26:41 UTC > > FreeBSD src repository > > Modified files: > sys/amd64/amd64 intr_machdep.c > sys/arm/arm intr.c > sys/i386/i386 intr_machdep.c > sys/ia64/ia64 interrupt.c > sys/kern kern_cpuset.c kern_intr.c > sys/powerpc/powerpc intr_machdep.c > sys/sparc64/sparc64 intr_machdep.c > sys/sun4v/sun4v intr_machdep.c > sys/sys cpuset.h interrupt.h > Log: > - Add the interrupt vector number to intr_event_create so MI code > can > lookup hard interrupt events by number. Ignore the irq# for > soft intrs. JFYI: vectors are not the same as hard interrupt numbers. On ia64 they imply priority, which means that vector numbers should be selected for their priority and not have a 1-to-1 mapping with IRQ number. On powerpc they mean absolutely nothing other than being an index into an array. It's better to use IRQs and not vectors to lookup int. events by number. FYI, -- Marcel Moolenaar xcllnt@mac.com From jroberson at jroberson.net Fri Apr 11 05:00:32 2008 From: jroberson at jroberson.net (Jeff Roberson) Date: Fri Apr 11 05:00:46 2008 Subject: cvs commit: src/sys/amd64/amd64 intr_machdep.c src/sys/arm/arm intr.c src/sys/i386/i386 intr_machdep.c src/sys/ia64/ia64 interrupt.c src/sys/kern kern_cpuset.c kern_intr.c src/sys/powerpc/powerpc intr_machdep.c src/sys/sparc64/sparc64 ... In-Reply-To: References: <200804110326.m3B3QfjL095474@repoman.freebsd.org> Message-ID: <20080410190028.U43186@desktop> On Thu, 10 Apr 2008, Marcel Moolenaar wrote: > > On Apr 10, 2008, at 8:26 PM, Jeff Roberson wrote: >> jeff 2008-04-11 03:26:41 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/amd64/amd64 intr_machdep.c >> sys/arm/arm intr.c >> sys/i386/i386 intr_machdep.c >> sys/ia64/ia64 interrupt.c >> sys/kern kern_cpuset.c kern_intr.c >> sys/powerpc/powerpc intr_machdep.c >> sys/sparc64/sparc64 intr_machdep.c >> sys/sun4v/sun4v intr_machdep.c >> sys/sys cpuset.h interrupt.h >> Log: >> - Add the interrupt vector number to intr_event_create so MI code can >> lookup hard interrupt events by number. Ignore the irq# for soft intrs. > > JFYI: vectors are not the same as hard interrupt numbers. > On ia64 they imply priority, which means that vector > numbers should be selected for their priority and not > have a 1-to-1 mapping with IRQ number. > On powerpc they mean absolutely nothing other than being > an index into an array. > > It's better to use IRQs and not vectors to lookup int. > events by number. I think I mixed my terminology in the commit. I meant for all architectures to pass in the number that would appear in vmstat -i. Can you verify that this is what I did for powerpc and ia64? Thanks, Jeff > > FYI, > > -- > Marcel Moolenaar > xcllnt@mac.com > From benno at FreeBSD.org Fri Apr 11 05:50:54 2008 From: benno at FreeBSD.org (Benno Rice) Date: Fri Apr 11 05:51:02 2008 Subject: cvs commit: src/sys/dev/usb ehci_pci.c uhci_pci.c Message-ID: <200804110550.m3B5orIY029492@repoman.freebsd.org> benno 2008-04-11 05:50:53 UTC FreeBSD src repository Modified files: sys/dev/usb ehci_pci.c uhci_pci.c Log: Identify ICH9 USB controllers. I've taken a slightly different approach than is used with the ICH8 controllers in that each controller is not identified individually (eg USB A, USB B, etc). Instead I've given then same description to each one even though the device ID differs. This can easily be changed if desired, or ICH8 (and any others using that approach) can be made to work as this does. Revision Changes Path 1.32 +6 -0 src/sys/dev/usb/ehci_pci.c 1.64 +20 -0 src/sys/dev/usb/uhci_pci.c From xcllnt at mac.com Fri Apr 11 06:15:34 2008 From: xcllnt at mac.com (Marcel Moolenaar) Date: Fri Apr 11 06:15:43 2008 Subject: cvs commit: src/sys/amd64/amd64 intr_machdep.c src/sys/arm/arm intr.c src/sys/i386/i386 intr_machdep.c src/sys/ia64/ia64 interrupt.c src/sys/kern kern_cpuset.c kern_intr.c src/sys/powerpc/powerpc intr_machdep.c src/sys/sparc64/sparc64 ... In-Reply-To: <20080410190028.U43186@desktop> References: <200804110326.m3B3QfjL095474@repoman.freebsd.org> <20080410190028.U43186@desktop> Message-ID: <9B8DD956-E197-4540-A7F3-367B1E277456@mac.com> On Apr 10, 2008, at 10:01 PM, Jeff Roberson wrote: > On Thu, 10 Apr 2008, Marcel Moolenaar wrote: > >> >> On Apr 10, 2008, at 8:26 PM, Jeff Roberson wrote: >>> jeff 2008-04-11 03:26:41 UTC >>> FreeBSD src repository >>> Modified files: >>> sys/amd64/amd64 intr_machdep.c >>> sys/arm/arm intr.c >>> sys/i386/i386 intr_machdep.c >>> sys/ia64/ia64 interrupt.c >>> sys/kern kern_cpuset.c kern_intr.c >>> sys/powerpc/powerpc intr_machdep.c >>> sys/sparc64/sparc64 intr_machdep.c >>> sys/sun4v/sun4v intr_machdep.c >>> sys/sys cpuset.h interrupt.h >>> Log: >>> - Add the interrupt vector number to intr_event_create so MI code >>> can >>> lookup hard interrupt events by number. Ignore the irq# for >>> soft intrs. >> >> JFYI: vectors are not the same as hard interrupt numbers. >> On ia64 they imply priority, which means that vector >> numbers should be selected for their priority and not >> have a 1-to-1 mapping with IRQ number. >> On powerpc they mean absolutely nothing other than being >> an index into an array. >> >> It's better to use IRQs and not vectors to lookup int. >> events by number. > > I think I mixed my terminology in the commit. I meant for all > architectures to pass in the number that would appear in vmstat -i. > Can you verify that this is what I did for powerpc and ia64? powerpc correctly uses irq. ia64 incorrectly uses vector. Would you mind changing ia64 to use irq as well? Thanks, -- Marcel Moolenaar xcllnt@mac.com From rwatson at FreeBSD.org Fri Apr 11 08:07:11 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Fri Apr 11 08:07:17 2008 Subject: cvs commit: src/usr.bin/procstat procstat_args.c procstat_bin.c procstat_cred.c procstat_files.c Message-ID: <200804110807.m3B87BBL063159@repoman.freebsd.org> rwatson 2008-04-11 08:07:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.bin/procstat procstat_args.c procstat_bin.c procstat_cred.c procstat_files.c Log: Merge procstat_args.c:1.2, procstat_bin.c:1.2, procstat_cred.c:1.2, and procstat_files.c:1.2 from HEAD to RELENG_7: Add 'COMM' column to a few more output modes of procstat(1). The only one it's missing from is the VM display, where there's really not room, and the file output display is looking quite cramped. Revision Changes Path 1.2.2.2 +3 -1 src/usr.bin/procstat/procstat_args.c 1.2.2.2 +3 -1 src/usr.bin/procstat/procstat_bin.c 1.2.2.2 +4 -2 src/usr.bin/procstat/procstat_cred.c 1.5.2.2 +19 -16 src/usr.bin/procstat/procstat_files.c From rwatson at FreeBSD.org Fri Apr 11 08:12:37 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Fri Apr 11 08:12:43 2008 Subject: cvs commit: src/sys/kern kern_proc.c Message-ID: <200804110812.m3B8CaXQ064025@repoman.freebsd.org> rwatson 2008-04-11 08:12:36 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern kern_proc.c Log: Merge kern_proc.c:1.259 from HEAD to RELENG_7: Return ESRCH when a kernel stack is queried on a process in execve() -- p_candebug() will return EAGAIN which, if the other process never leaves execve(), will result in the sysctl spinning and never returning to userspace. Processes should always eventually leave execve(), but spinning in kernel while we wait is bad for countless reasons, and particularly harmful if execve() itself is deadlocked. Possibly we should return another error, or return a marker indicating the thread is in execve() so it can be reported that way in userspace. Reported by: kris Revision Changes Path 1.252.2.7 +2 -1 src/sys/kern/kern_proc.c From rwatson at FreeBSD.org Fri Apr 11 08:13:37 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Fri Apr 11 08:13:39 2008 Subject: cvs commit: src/sys/kern vfs_subr.c Message-ID: <200804110813.m3B8Dbm8064198@repoman.freebsd.org> rwatson 2008-04-11 08:13:37 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern vfs_subr.c Log: Merge vfs_subr.c:1.713 from HEAD to RELENG_7: In "show lockedvnods" DDB command, use db_printf() rather than printf() so that the results end up in the DDB output stream rather than the console output stream. This should likely also be done for the vprint() function it calls. Revision Changes Path 1.707.2.3 +1 -1 src/sys/kern/vfs_subr.c From pav at FreeBSD.org Fri Apr 11 08:26:07 2008 From: pav at FreeBSD.org (Pav Lucistnik) Date: Fri Apr 11 08:26:14 2008 Subject: cvs commit: src/usr.sbin/pkg_install/add perform.c src/usr.sbin/pkg_install/delete perform.c src/usr.sbin/pkg_install/lib lib.h match.c Message-ID: <200804110826.m3B8Q6fI065948@repoman.freebsd.org> pav 2008-04-11 08:26:06 UTC FreeBSD src repository (doc,ports committer) Modified files: usr.sbin/pkg_install/add perform.c usr.sbin/pkg_install/delete perform.c usr.sbin/pkg_install/lib lib.h match.c Log: Optimize package registration/deregistration. Previously, when looking up the package name for the origin of a dependency, all entries in /var/db/pkg were traversed for each dependency of added/removed package. Now, gather all the origins first, then do the lookup in a single pass over /var/db/pkg. This should provide a major speedup for packages with hundreds of dependencies. Submitted by: rdivacky (earlier version) MFC after: 1 month Revision Changes Path 1.83 +62 -24 src/usr.sbin/pkg_install/add/perform.c 1.43 +26 -10 src/usr.sbin/pkg_install/delete/perform.c 1.64 +1 -0 src/usr.sbin/pkg_install/lib/lib.h 1.22 +55 -17 src/usr.sbin/pkg_install/lib/match.c From rwatson at FreeBSD.org Fri Apr 11 08:47:37 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Fri Apr 11 08:47:43 2008 Subject: cvs commit: src/sys/sys proc.h src/sys/kern init_main.c kern_proc.c kern_resource.c kern_synch.c kern_thread.c Message-ID: <200804110847.m3B8laAo078519@repoman.freebsd.org> rwatson 2008-04-11 08:47:36 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/sys proc.h sys/kern init_main.c kern_proc.c kern_resource.c kern_synch.c kern_thread.c Log: Merge init_main.c:1.290, kern_proc.c:1.261, kern_resource.c:1.182, kern_sync.c:1.305, proc.h:1.499 from HEAD to RELENG_7: Don't zero td_runtime when billing thread CPU usage to the process; maintain a separate td_incruntime to hold unbilled CPU usage for the thread that has the previous properties of td_runtime. When thread information is requested using the thread monitoring sysctls, export thread td_runtime instead of process rusage runtime in kinfo_proc. This restores the display of individual ithread and other kernel thread CPU usage since inception in ps -H and top -SH, as well for libthr user threads, valuable debugging information lost with the move to try kthreads since they are no longer independent processes. There is universal agreement that we should rewrite the process and thread export sysctls, but this commit gets things going a bit better in the mean time. Likewise, there are resevations about the continued validity of statclock given the speed of modern processors. Reviewed by: attilio, emaste, jhb, julian Note: in MFC, td_incruntime is added to the end of struc thread, rather than the pre-zero'd section, and manually zero'd on thread creation, in order to avoid a negative ABI impact for third-party kernel modules. Revision Changes Path 1.283.2.3 +4 -0 src/sys/kern/init_main.c 1.252.2.8 +13 -7 src/sys/kern/kern_proc.c 1.180.2.2 +3 -3 src/sys/kern/kern_resource.c 1.302.2.1 +4 -2 src/sys/kern/kern_synch.c 1.255.2.3 +1 -0 src/sys/kern/kern_thread.c 1.491.2.3 +1 -0 src/sys/sys/proc.h From rwatson at FreeBSD.org Fri Apr 11 08:56:25 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Fri Apr 11 08:56:41 2008 Subject: cvs commit: src/usr.bin/procstat procstat.c procstat_basic.c procstat_files.c procstat_kstack.c procstat_threads.c procstat_vm.c Message-ID: <200804110856.m3B8uPQL079879@repoman.freebsd.org> rwatson 2008-04-11 08:56:25 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.bin/procstat procstat.c procstat_basic.c procstat_files.c procstat_kstack.c procstat_threads.c procstat_vm.c Log: Merge procstat.c:1.2, procstat_basic.c:1.2, procstat_files.c:1.4, procstat_kstack.c:1.3, procstat_threads.c:1.3, procstat_vm.c:1.2 from HEAD to RELENG_7: WARNS fixes: mainly constness and avoid comparing signed with unsigned by making array indicies unsigned. Also note one or two unused parameters. Revision Changes Path 1.2.2.2 +7 -6 src/usr.bin/procstat/procstat.c 1.2.2.2 +1 -1 src/usr.bin/procstat/procstat_basic.c 1.5.2.3 +2 -1 src/usr.bin/procstat/procstat_files.c 1.3.2.3 +4 -3 src/usr.bin/procstat/procstat_kstack.c 1.3.2.3 +2 -1 src/usr.bin/procstat/procstat_threads.c 1.2.2.2 +3 -2 src/usr.bin/procstat/procstat_vm.c From dfr at FreeBSD.org Fri Apr 11 09:01:32 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Fri Apr 11 09:01:36 2008 Subject: cvs commit: src/usr.sbin/rpc.lockd lockd.c Message-ID: <200804110901.m3B91WJZ081661@repoman.freebsd.org> dfr 2008-04-11 09:01:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.sbin/rpc.lockd lockd.c Log: MFC: lockd.c r1.27 - don't call the kernel NLM if its not loaded. Revision Changes Path 1.20.2.3 +2 -1 src/usr.sbin/rpc.lockd/lockd.c From rwatson at FreeBSD.org Fri Apr 11 09:09:28 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Fri Apr 11 09:09:41 2008 Subject: cvs commit: src/sys/kern kern_descrip.c src/sys/sys user.h src/usr.bin/procstat procstat_files.c Message-ID: <200804110909.m3B99StS084018@repoman.freebsd.org> rwatson 2008-04-11 09:09:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern kern_descrip.c sys/sys user.h usr.bin/procstat procstat_files.c Log: Merge kern_descrip.c:1.322, user.h:1.74, procstat_files.c:1.5: Add support for displaying a process' current working directory, root directory, and jail directory within procstat. While this functionality is available already in fstat, encapsulating it in the kern.proc.filedesc sysctl makes it accessible without using kvm and thus without needing elevated permissions. The new procstat output looks like: PID COMM FD T V FLAGS REF OFFSET PRO NAME 76792 tcsh cwd v d -------- - - - /usr/src 76792 tcsh root v d -------- - - - / 76792 tcsh 15 v c rw------ 16 9130 - - 76792 tcsh 16 v c rw------ 16 9130 - - 76792 tcsh 17 v c rw------ 16 9130 - - 76792 tcsh 18 v c rw------ 16 9130 - - 76792 tcsh 19 v c rw------ 16 9130 - - I am also bumping __FreeBSD_version for this as this new feature will be used in at least one port. Reviewed by: rwatson Approved by: rwatson Note that in the MFC, __FreeBSD_version is not bumped as we will bump it once (shortly) for all procstat(1) MFC changes together. Revision Changes Path 1.313.2.4 +50 -0 src/sys/kern/kern_descrip.c 1.70.2.3 +5 -1 src/sys/sys/user.h 1.5.2.4 +26 -4 src/usr.bin/procstat/procstat_files.c From rwatson at FreeBSD.org Fri Apr 11 09:13:12 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Fri Apr 11 09:13:21 2008 Subject: cvs commit: src/sys/sys param.h Message-ID: <200804110913.m3B9DB41084739@repoman.freebsd.org> rwatson 2008-04-11 09:13:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/sys param.h Log: Bump __FreeBSD_version in RELENG_7 to reflect addition of procstat(1) and its associated kernel sysctl additions. Revision Changes Path 1.308.2.8 +1 -1 src/sys/sys/param.h From jeff at FreeBSD.org Fri Apr 11 09:44:27 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Fri Apr 11 09:44:35 2008 Subject: cvs commit: src/sys/ufs/ufs ufs_lookup.c Message-ID: <200804110944.m3B9iPrX090735@repoman.freebsd.org> jeff 2008-04-11 09:44:25 UTC FreeBSD src repository Modified files: sys/ufs/ufs ufs_lookup.c Log: - cache dp->i_offset in the local 'i_offset' variable for use in loop indexes so directory lookup becomes shared lock safe. In the modifying cases an exclusive lock is held here so the commit routine may rely on the state of i_offset. - Similarly handle i_diroff by fetching at the start and setting only once the operation is complete. Without the exclusive lock these are only considered hints. - Assert that an exclusive lock is held when we're preparing for a commit routine. - Honor the lock type request from lookup instead of always using exclusive locking. Tested by: pho, kris Revision Changes Path 1.87 +48 -29 src/sys/ufs/ufs/ufs_lookup.c From jeff at FreeBSD.org Fri Apr 11 09:48:13 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Fri Apr 11 09:48:19 2008 Subject: cvs commit: src/sys/ufs/ufs dirhash.h ufs_dirhash.c Message-ID: <200804110948.m3B9mCjB091438@repoman.freebsd.org> jeff 2008-04-11 09:48:12 UTC FreeBSD src repository Modified files: sys/ufs/ufs dirhash.h ufs_dirhash.c Log: - Use a lockmgr lock rather than a mtx to protect dirhash. This lock may be held for the duration of the various dirhash operations which avoids many complex unlock/lock/revalidate sequences. - Permit shared locks on lookup. To protect the ip->i_dirhash pointer we use the vnode interlock in the shared case. Callers holding the exclusive vnode lock can run without fear of concurrent modification to i_dirhash. - Hold an exclusive dirhash lock when creating the dirhash structure for the first time or when re-creating a dirhash structure which has been recycled. Tested by: kris, pho Revision Changes Path 1.6 +2 -1 src/sys/ufs/ufs/dirhash.h 1.24 +289 -227 src/sys/ufs/ufs/ufs_dirhash.c From jroberson at jroberson.net Fri Apr 11 09:50:24 2008 From: jroberson at jroberson.net (Jeff Roberson) Date: Fri Apr 11 09:50:35 2008 Subject: cvs commit: src/sys/amd64/amd64 intr_machdep.c src/sys/arm/arm intr.c src/sys/i386/i386 intr_machdep.c src/sys/ia64/ia64 interrupt.c src/sys/kern kern_cpuset.c kern_intr.c src/sys/powerpc/powerpc intr_machdep.c src/sys/sparc64/sparc64 ... In-Reply-To: <9B8DD956-E197-4540-A7F3-367B1E277456@mac.com> References: <200804110326.m3B3QfjL095474@repoman.freebsd.org> <20080410190028.U43186@desktop> <9B8DD956-E197-4540-A7F3-367B1E277456@mac.com> Message-ID: <20080410235123.K43186@desktop> On Thu, 10 Apr 2008, Marcel Moolenaar wrote: > > On Apr 10, 2008, at 10:01 PM, Jeff Roberson wrote: >> On Thu, 10 Apr 2008, Marcel Moolenaar wrote: >> >>> >>> On Apr 10, 2008, at 8:26 PM, Jeff Roberson wrote: >>>> jeff 2008-04-11 03:26:41 UTC >>>> FreeBSD src repository >>>> Modified files: >>>> sys/amd64/amd64 intr_machdep.c >>>> sys/arm/arm intr.c >>>> sys/i386/i386 intr_machdep.c >>>> sys/ia64/ia64 interrupt.c >>>> sys/kern kern_cpuset.c kern_intr.c >>>> sys/powerpc/powerpc intr_machdep.c >>>> sys/sparc64/sparc64 intr_machdep.c >>>> sys/sun4v/sun4v intr_machdep.c >>>> sys/sys cpuset.h interrupt.h >>>> Log: >>>> - Add the interrupt vector number to intr_event_create so MI code can >>>> lookup hard interrupt events by number. Ignore the irq# for soft intrs. >>> >>> JFYI: vectors are not the same as hard interrupt numbers. >>> On ia64 they imply priority, which means that vector >>> numbers should be selected for their priority and not >>> have a 1-to-1 mapping with IRQ number. >>> On powerpc they mean absolutely nothing other than being >>> an index into an array. >>> >>> It's better to use IRQs and not vectors to lookup int. >>> events by number. >> >> I think I mixed my terminology in the commit. I meant for all >> architectures to pass in the number that would appear in vmstat -i. Can >> you verify that this is what I did for powerpc and ia64? > > powerpc correctly uses irq. > ia64 incorrectly uses vector. > > Would you mind changing ia64 to use irq as well? Index: ia64/ia64/interrupt.c =================================================================== RCS file: /home/ncvs/src/sys/ia64/ia64/interrupt.c,v retrieving revision 1.66 diff -r1.66 interrupt.c 343c343 < 0, vector, ia64_intr_mask, ia64_intr_unmask, ia64_intr_eoi, --- > 0, irq, ia64_intr_mask, ia64_intr_unmask, ia64_intr_eoi, Does that look right? > > Thanks, > > -- > Marcel Moolenaar > xcllnt@mac.com > From remko at FreeBSD.org Fri Apr 11 10:14:20 2008 From: remko at FreeBSD.org (Remko Lodder) Date: Fri Apr 11 10:14:31 2008 Subject: cvs commit: src ObsoleteFiles.inc Message-ID: <200804111014.m3BAEJoU097438@repoman.freebsd.org> remko 2008-04-11 10:14:19 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) . ObsoleteFiles.inc Log: MFC rev 1.134 ObsoleteFiles.inc Document the removal data for usbdevs.h and usbdevs_data.h, sort the entry into it's correct place (behind 200407XX before 200406XX because we have an explicit date here). PR: misc/122098 Submitted by: "John Hein" MFC after: 3 days Approved by: imp (mentor, implicit) PR: misc/122099 (should have been this PR). Revision Changes Path 1.25.2.23 +3 -0 src/ObsoleteFiles.inc From dfr at FreeBSD.org Fri Apr 11 10:34:59 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Fri Apr 11 10:35:06 2008 Subject: cvs commit: src/sys/nlm nlm_prot_impl.c src/sys/rpc clnt_rc.c Message-ID: <200804111034.m3BAYx3s001148@repoman.freebsd.org> dfr 2008-04-11 10:34:59 UTC FreeBSD src repository Modified files: sys/nlm nlm_prot_impl.c sys/rpc clnt_rc.c Log: Fix some issues that showed up during Kris' testing. Reported by: kris MFC after: 3 days Revision Changes Path 1.5 +28 -14 src/sys/nlm/nlm_prot_impl.c 1.3 +8 -2 src/sys/rpc/clnt_rc.c From bz at FreeBSD.org Fri Apr 11 11:23:58 2008 From: bz at FreeBSD.org (Bjoern A. Zeeb) Date: Fri Apr 11 11:24:00 2008 Subject: cvs commit: src/sys/nlm nlm_prot_impl.c src/sys/rpc clnt_rc.c In-Reply-To: <200804111034.m3BAYx3s001148@repoman.freebsd.org> References: <200804111034.m3BAYx3s001148@repoman.freebsd.org> Message-ID: <20080411112322.A66744@maildrop.int.zabbadoz.net> On Fri, 11 Apr 2008, Doug Rabson wrote: > dfr 2008-04-11 10:34:59 UTC > > FreeBSD src repository > > Modified files: > sys/nlm nlm_prot_impl.c > sys/rpc clnt_rc.c > Log: > Fix some issues that showed up during Kris' testing. what issues were that? > Reported by: kris > MFC after: 3 days > > Revision Changes Path > 1.5 +28 -14 src/sys/nlm/nlm_prot_impl.c > 1.3 +8 -2 src/sys/rpc/clnt_rc.c > -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT Software is harder than hardware so better get it right the first time. From dfr at rabson.org Fri Apr 11 11:26:44 2008 From: dfr at rabson.org (Doug Rabson) Date: Fri Apr 11 11:26:51 2008 Subject: cvs commit: src/sys/nlm nlm_prot_impl.c src/sys/rpc clnt_rc.c In-Reply-To: <6eb82e0804110419l12ceda38ncac4e3f6bb6051ce@mail.gmail.com> References: <200804111034.m3BAYx3s001148@repoman.freebsd.org> <6eb82e0804110419l12ceda38ncac4e3f6bb6051ce@mail.gmail.com> Message-ID: On 11 Apr 2008, at 12:19, Rong-en Fan wrote: > On Fri, Apr 11, 2008 at 6:34 PM, Doug Rabson wrote: >> dfr 2008-04-11 10:34:59 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/nlm nlm_prot_impl.c >> sys/rpc clnt_rc.c >> Log: >> Fix some issues that showed up during Kris' testing. > > Could you please tell us more about what these issues are? One was avoiding a cascade of error messages when lock requests were made by a a client with a host name that doesn't resolve in DNS (this is arguably a bug in rpc.statd as well but I'm not touching that). The other was avoiding a panic which appeared to be caused by the userland part of rpc.lockd dying under extreme load. From sos at FreeBSD.org Fri Apr 11 11:30:28 2008 From: sos at FreeBSD.org (Søren Schmidt) Date: Fri Apr 11 11:30:42 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-disk.c ata-dma.c ata-queue.c ata-raid.c atapi-cam.c atapi-cd.c atapi-fd.c atapi-tape.c Message-ID: <200804111130.m3BBUS7f012125@repoman.freebsd.org> sos 2008-04-11 11:30:28 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.c ata-all.h ata-disk.c ata-dma.c ata-queue.c ata-raid.c atapi-cam.c atapi-cd.c atapi-fd.c atapi-tape.c Log: Fix the brokenness in the former commit, sorry for the mess. The problem is that the PM support is part of a much larger WIP here, but due to popular demand I decided to get some of it imported. Also I forgot the mention: HW sponsored by: Vitsch Electronics / VEHosting Revision Changes Path 1.283 +54 -5 src/sys/dev/ata/ata-all.c 1.130 +3 -6 src/sys/dev/ata/ata-all.h 1.209 +3 -6 src/sys/dev/ata/ata-disk.c 1.152 +3 -32 src/sys/dev/ata/ata-dma.c 1.71 +3 -5 src/sys/dev/ata/ata-queue.c 1.128 +19 -16 src/sys/dev/ata/ata-raid.c 1.56 +1 -2 src/sys/dev/ata/atapi-cam.c 1.198 +3 -7 src/sys/dev/ata/atapi-cd.c 1.113 +1 -2 src/sys/dev/ata/atapi-fd.c 1.106 +1 -2 src/sys/dev/ata/atapi-tape.c From ru at FreeBSD.org Fri Apr 11 11:34:09 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Fri Apr 11 11:34:28 2008 Subject: cvs commit: src/usr.bin/top machine.c Message-ID: <200804111134.m3BBY9XN012966@repoman.freebsd.org> ru 2008-04-11 11:34:09 UTC FreeBSD src repository Modified files: usr.bin/top machine.c Log: Allocate enough memory for pcpu_cp_time[] to stop sysctl() from writing outside of array bounds. This fully fixes -P display on i386, where kern.cp_times prints zeroes for non-existing CPUs. Revision Changes Path 1.88 +1 -1 src/usr.bin/top/machine.c From ru at FreeBSD.org Fri Apr 11 11:39:27 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Fri Apr 11 11:39:33 2008 Subject: cvs commit: src/contrib/top machine.h src/usr.bin/top machine.c Message-ID: <200804111139.m3BBdQ7g014022@repoman.freebsd.org> ru 2008-04-11 11:39:26 UTC FreeBSD src repository Modified files: contrib/top machine.h usr.bin/top machine.c Log: system_info.cpustates isn't sparse, so a bitmask of available CPU states is redundant (I think it's a leftover from an older implementation). Revision Changes Path 1.11 +0 -1 src/contrib/top/machine.h 1.89 +0 -2 src/usr.bin/top/machine.c From rdivacky at FreeBSD.org Fri Apr 11 11:43:40 2008 From: rdivacky at FreeBSD.org (Roman Divacky) Date: Fri Apr 11 11:43:55 2008 Subject: cvs commit: src/usr.sbin/pkg_install/add perform.c src/usr.sbin/pkg_install/delete perform.c src/usr.sbin/pkg_install/lib lib.h match.c In-Reply-To: <200804110826.m3B8Q6fI065948@repoman.freebsd.org> References: <200804110826.m3B8Q6fI065948@repoman.freebsd.org> Message-ID: <20080411114305.GA37560@freebsd.org> On Fri, Apr 11, 2008 at 08:26:06AM +0000, Pav Lucistnik wrote: > pav 2008-04-11 08:26:06 UTC > > FreeBSD src repository (doc,ports committer) > > Modified files: > usr.sbin/pkg_install/add perform.c > usr.sbin/pkg_install/delete perform.c > usr.sbin/pkg_install/lib lib.h match.c > Log: > Optimize package registration/deregistration. Previously, when looking up the > package name for the origin of a dependency, all entries in /var/db/pkg were > traversed for each dependency of added/removed package. Now, gather all the > origins first, then do the lookup in a single pass over /var/db/pkg. > > This should provide a major speedup for packages with hundreds of dependencies. the speedup is in fact quite a dramatic one... see: http://djdomics.free.fr/FreeBSD/pkg_install/ roman From dwmalone at maths.tcd.ie Fri Apr 11 11:45:09 2008 From: dwmalone at maths.tcd.ie (David Malone) Date: Fri Apr 11 11:45:15 2008 Subject: cvs commit: src/sys/ufs/ufs dirhash.h ufs_dirhash.c In-Reply-To: <200804110948.m3B9mCjB091438@repoman.freebsd.org> References: <200804110948.m3B9mCjB091438@repoman.freebsd.org> Message-ID: <20080411114500.GA79162@walton.maths.tcd.ie> On Fri, Apr 11, 2008 at 09:48:12AM +0000, Jeff Roberson wrote: > - Use a lockmgr lock rather than a mtx to protect dirhash. This lock > may be held for the duration of the various dirhash operations which > avoids many complex unlock/lock/revalidate sequences. > - Permit shared locks on lookup. To protect the ip->i_dirhash pointer we > use the vnode interlock in the shared case. Callers holding the > exclusive vnode lock can run without fear of concurrent modification to > i_dirhash. > - Hold an exclusive dirhash lock when creating the dirhash structure for > the first time or when re-creating a dirhash structure which has been > recycled. Hi Jeff, I've been reading through this patch to understand it. I've a few questions: 1) You initialise a chunk of the dir hash struct earlier now, though it was previously left until we knew memory allocation was successful. Is there a reason for that? 2) Is ufsdirhash_create() trying harder than before to allocate a dirhash? It looks like it might be, but maybe that's just a feature of the new locking. 3) You've added a dh_memreq member to the structure to remember a value that's cheap to calculate from other structure members and only required at allocation and free time. I can understand why you'd want to avoid repeating the code, but it would seem better to make it a macro rather than storing it for the lifetime of the object? 4) You replaced an unlocked read with a locked read in ufsdirhash_lookup. I think this is because you are now locking the dh_score with the list mutex and are taking advantage of the fact that the score is changed just below? Won't this mean that for a sequence of operations on one directory, we'll now need to lock the list mutex for each lookup and get the lockmanager lock on the dirhash. At face value, this would seems to be worse than the old situation of only getting the dh mutex for each opteation? In the case of multiple directories, I guess we'll have two mutex locks replaced by one mutex and one lockmanager (shared) lock? This is probably the usual case, which isn't too bad. 5) It looks like the recycle policy (and locking thereof) is now slightly different and I think it might do something funny in some cases now. If we get the list lock in ufsdirhash_recycle, but someone holds an exclusive lock on some of the dirhashes, then we will walk over the locked ones until we find an unlocked one and free it. We then jump back to the start of the list and have to walk over the locked ones again. I wonder if in a low memory situation the locked nodes could be actually waiting for the list lock in ufsdirhash_list_locked() and there could be some sort of cascade where you end up freeing dirhashes that should actually be kept. Actually, this probably isn't possible because the list lock is dropped while we're doing the free? David. From ru at FreeBSD.org Fri Apr 11 11:45:28 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Fri Apr 11 11:45:29 2008 Subject: cvs commit: src/contrib/top machine.h src/usr.bin/top machine.c Message-ID: <200804111145.m3BBjR53015035@repoman.freebsd.org> ru 2008-04-11 11:45:27 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) contrib/top machine.h usr.bin/top machine.c Log: MFC: Fix "top -P". Revision Changes Path 1.9.2.2 +1 -2 src/contrib/top/machine.h 1.82.2.3 +7 -12 src/usr.bin/top/machine.c From grafan at gmail.com Fri Apr 11 11:47:05 2008 From: grafan at gmail.com (Rong-en Fan) Date: Fri Apr 11 11:47:10 2008 Subject: cvs commit: src/sys/nlm nlm_prot_impl.c src/sys/rpc clnt_rc.c In-Reply-To: <200804111034.m3BAYx3s001148@repoman.freebsd.org> References: <200804111034.m3BAYx3s001148@repoman.freebsd.org> Message-ID: <6eb82e0804110419l12ceda38ncac4e3f6bb6051ce@mail.gmail.com> On Fri, Apr 11, 2008 at 6:34 PM, Doug Rabson wrote: > dfr 2008-04-11 10:34:59 UTC > > FreeBSD src repository > > Modified files: > sys/nlm nlm_prot_impl.c > sys/rpc clnt_rc.c > Log: > Fix some issues that showed up during Kris' testing. Could you please tell us more about what these issues are? Thanks, Rong-En Fan > > Reported by: kris > MFC after: 3 days > > Revision Changes Path > 1.5 +28 -14 src/sys/nlm/nlm_prot_impl.c > 1.3 +8 -2 src/sys/rpc/clnt_rc.c > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > From rpaulo at FreeBSD.org Fri Apr 11 12:10:13 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Fri Apr 11 12:10:20 2008 Subject: cvs commit: src/usr.bin/cpuset cpuset.c In-Reply-To: <200804110327.m3B3RggJ095716@repoman.freebsd.org> References: <200804110327.m3B3RggJ095716@repoman.freebsd.org> Message-ID: <20080411120947.GA896@fnop.net> On Fri, Apr 11, 2008 at 03:27:42AM +0000, Jeff Roberson wrote: > jeff 2008-04-11 03:27:42 UTC > > FreeBSD src repository > > Modified files: > usr.bin/cpuset cpuset.c > Log: > - Add support for interrupt bindig to cpuset(1). Interrupts are bound > by specifying the interrupt with -x . The irq number matches > those displayed by vmstat -i. > > Sponsored by: Nokia > > Revision Changes Path > 1.5 +19 -7 src/usr.bin/cpuset/cpuset.c Thanks! This is great work! -- Rui Paulo From rpaulo at FreeBSD.org Fri Apr 11 12:12:26 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Fri Apr 11 12:12:33 2008 Subject: cvs commit: src/sys/dev/asmc asmc.c Message-ID: <200804111212.m3BCCPBU019587@repoman.freebsd.org> rpaulo 2008-04-11 12:12:25 UTC FreeBSD src repository Modified files: sys/dev/asmc asmc.c Log: Style nit. No functional change. Revision Changes Path 1.7 +3 -2 src/sys/dev/asmc/asmc.c From rpaulo at FreeBSD.org Fri Apr 11 12:14:22 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Fri Apr 11 12:14:34 2008 Subject: cvs commit: src/usr.sbin/pkg_install/add perform.c src/usr.sbin/pkg_install/delete perform.c src/usr.sbin/pkg_install/lib lib.h match.c In-Reply-To: <20080411114305.GA37560@freebsd.org> References: <200804110826.m3B8Q6fI065948@repoman.freebsd.org> <20080411114305.GA37560@freebsd.org> Message-ID: <20080411121404.GB896@fnop.net> On Fri, Apr 11, 2008 at 01:43:05PM +0200, Roman Divacky wrote: > On Fri, Apr 11, 2008 at 08:26:06AM +0000, Pav Lucistnik wrote: > > pav 2008-04-11 08:26:06 UTC > > > > FreeBSD src repository (doc,ports committer) > > > > Modified files: > > usr.sbin/pkg_install/add perform.c > > usr.sbin/pkg_install/delete perform.c > > usr.sbin/pkg_install/lib lib.h match.c > > Log: > > Optimize package registration/deregistration. Previously, when looking up the > > package name for the origin of a dependency, all entries in /var/db/pkg were > > traversed for each dependency of added/removed package. Now, gather all the > > origins first, then do the lookup in a single pass over /var/db/pkg. > > > > This should provide a major speedup for packages with hundreds of dependencies. > > the speedup is in fact quite a dramatic one... see: > > http://djdomics.free.fr/FreeBSD/pkg_install/ > > roman Indeed, thanks to you both! :-) -- Rui Paulo From jroberson at jroberson.net Fri Apr 11 12:31:45 2008 From: jroberson at jroberson.net (Jeff Roberson) Date: Fri Apr 11 12:32:00 2008 Subject: cvs commit: src/sys/ufs/ufs dirhash.h ufs_dirhash.c In-Reply-To: <20080411114500.GA79162@walton.maths.tcd.ie> References: <200804110948.m3B9mCjB091438@repoman.freebsd.org> <20080411114500.GA79162@walton.maths.tcd.ie> Message-ID: <20080411021519.E43186@desktop> On Fri, 11 Apr 2008, David Malone wrote: > On Fri, Apr 11, 2008 at 09:48:12AM +0000, Jeff Roberson wrote: >> - Use a lockmgr lock rather than a mtx to protect dirhash. This lock >> may be held for the duration of the various dirhash operations which >> avoids many complex unlock/lock/revalidate sequences. >> - Permit shared locks on lookup. To protect the ip->i_dirhash pointer we >> use the vnode interlock in the shared case. Callers holding the >> exclusive vnode lock can run without fear of concurrent modification to >> i_dirhash. >> - Hold an exclusive dirhash lock when creating the dirhash structure for >> the first time or when re-creating a dirhash structure which has been >> recycled. > > Hi Jeff, > > I've been reading through this patch to understand it. I've a few > questions: > > 1) You initialise a chunk of the dir hash struct earlier > now, though it was previously left until we knew memory > allocation was successful. Is there a reason for that? Now instead of freeing a recycled dirhash pointer in ip->i_dirhash I lock it and re-create it. This makes various races simpler. The dirhash has to be minimally constructed for dirhash_free_locked to function correctly if we bail out early. > > 2) Is ufsdirhash_create() trying harder than before to > allocate a dirhash? It looks like it might be, but maybe > that's just a feature of the new locking. The conditions in ufsdirhash_build() which result in creating a new directory hash remain the same except we are more agressive about reclaiming when the sysctl is lowered to ease testing. ufsdirhash_create() is a new function which tries to lock or allocate a dirhash. This is complex because i_dirhash must be protected with the vnode interlock if the directory lock is held shared. This code has to deal with concurrent creation as well as concurrent destruction by ufsdirhash_recycle(). > > 3) You've added a dh_memreq member to the structure to > remember a value that's cheap to calculate from other > structure members and only required at allocation and free > time. I can understand why you'd want to avoid repeating > the code, but it would seem better to make it a macro rather > than storing it for the lifetime of the object? Earlier versions of this patch suffered various accounting errors with the space used by the i_dirhash structure. Since I may call ufsdirhash_free_locked() before space is accounted for keeping the integer was much simpler. > > 4) You replaced an unlocked read with a locked read in > ufsdirhash_lookup. I think this is because you are now > locking the dh_score with the list mutex and are taking > advantage of the fact that the score is changed just below? > Won't this mean that for a sequence of operations on one > directory, we'll now need to lock the list mutex for each > lookup and get the lockmanager lock on the dirhash. At face > value, this would seems to be worse than the old situation > of only getting the dh mutex for each opteation? In the normal ufs_lookup() path we enter 3 dirhash functions which can now assume the lock is held rather than locking/unlocking. And in lookup in particular we are no longer required to drop and reacquire the lock, potentially multiple times. I'm sure it's a net reduction in lock operations. That really wasn't the primary motivation however. I mostly wanted to enable shared locking of directories. I doubt the number of mtx operations is dominating the performance of directory operations in any event. > > In the case of multiple directories, I guess we'll have two > mutex locks replaced by one mutex and one lockmanager > (shared) lock? This is probably the usual case, which isn't > too bad. I'm not sure I understand this. > > 5) It looks like the recycle policy (and locking thereof) > is now slightly different and I think it might do something > funny in some cases now. If we get the list lock in > ufsdirhash_recycle, but someone holds an exclusive lock on > some of the dirhashes, then we will walk over the locked > ones until we find an unlocked one and free it. We then > jump back to the start of the list and have to walk over > the locked ones again. I wonder if in a low memory situation > the locked nodes could be actually waiting for the list > lock in ufsdirhash_list_locked() and there could be some > sort of cascade where you end up freeing dirhashes that > should actually be kept. Actually, this probably isn't > possible because the list lock is dropped while we're doing > the free? Because we drop the list lock we have to restart the processing from the beginning. I guess it is a risk that we could have many locked dirhashes that we'll have to skip causing the recycle loop to potentially take a long time. However, the old code was strange here as well. It'd only examine the head of the list and only recycled if the score reached 0. Really we could just make this a simple LRU and be done with it. The score seems redundant. Jeff > > David. > From dwmalone at maths.tcd.ie Fri Apr 11 12:59:57 2008 From: dwmalone at maths.tcd.ie (David Malone) Date: Fri Apr 11 13:00:00 2008 Subject: cvs commit: src/sys/ufs/ufs dirhash.h ufs_dirhash.c In-Reply-To: Your message of "Fri, 11 Apr 2008 02:32:49 -1000." <20080411021519.E43186@desktop> Message-ID: <200804111359.aa80973@walton.maths.tcd.ie> > Now instead of freeing a recycled dirhash pointer in ip->i_dirhash I lock > it and re-create it. This makes various races simpler. The dirhash has > to be minimally constructed for dirhash_free_locked to function correctly > if we bail out early. Ah - OK - I think that probably partially explains your accounting problems, mentioned below, but it may not be worth fixing. It is probably worth looking over to make sure that it isn't just hiding some other problem. Dirhash has been quite good at finding bugs in other bits of code. > The conditions in ufsdirhash_build() which result in creating a new > directory hash remain the same except we are more agressive about > reclaiming when the sysctl is lowered to ease testing. I suspected that, but was having trouble seeing it. > In the normal ufs_lookup() path we enter 3 dirhash functions which can now > assume the lock is held rather than locking/unlocking. And in lookup in > particular we are no longer required to drop and reacquire the lock, > potentially multiple times. I'm sure it's a net reduction in lock > operations. That really wasn't the primary motivation however. I mostly > wanted to enable shared locking of directories. I doubt the number of mtx > operations is dominating the performance of directory operations in any > event. Agreed. > > > > In the case of multiple directories, I guess we'll have two > > mutex locks replaced by one mutex and one lockmanager > > (shared) lock? This is probably the usual case, which isn't > > too bad. > I'm not sure I understand this. I was probably thinking out aloud - please feel free to ignore it ;-) > > should actually be kept. Actually, this probably isn't > > possible because the list lock is dropped while we're doing > > the free? > Because we drop the list lock we have to restart the processing from the > beginning. OK - understood. > I guess it is a risk that we could have many locked dirhashes > that we'll have to skip causing the recycle loop to potentially take a > long time. However, the old code was strange here as well. It'd only > examine the head of the list and only recycled if the score reached 0. That was the thing it had been designed to do. It only checked the head of the list because the objects that are candidates for recycling are at the head of the list. The idea was to keep plucking thing from the head until we got far enough down that the object looked like it was still active. > Really we could just make this a simple LRU and be done with it. The > score seems redundant. If I remember correctly, that isn't a good idea. I think Ian found that pure LRU didn't work that well for recycling, which is why the hybrid LRU/LOU scheme is in place. LRU resulted in thrashing when a large number of directories were being accessed at the same time. Roughly what happened was you would access the directory, build the whole hash, use it once and then discard it before another access. Since building the whole hash is a little more costly than a single linear access, this resulted in a net loss. By ensuring that an established hashes are used for slightly longer, you could avoid this hit. David. From davidxu at FreeBSD.org Fri Apr 11 14:39:11 2008 From: davidxu at FreeBSD.org (David Xu) Date: Fri Apr 11 14:39:22 2008 Subject: cvs commit: src/sys/sys umtx.h src/sys/kern kern_umtx.c Message-ID: <200804111439.m3BEdBBd036591@repoman.freebsd.org> davidxu 2008-04-11 14:39:11 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/sys umtx.h sys/kern kern_umtx.c Log: MFC: Add umtx operation UMTX_OP_WAIT_UINT and userland rwlock. Revision Changes Path 1.61.2.3 +511 -49 src/sys/kern/kern_umtx.c 1.29.2.1 +22 -1 src/sys/sys/umtx.h From davidxu at FreeBSD.org Fri Apr 11 14:41:19 2008 From: davidxu at FreeBSD.org (David Xu) Date: Fri Apr 11 14:41:35 2008 Subject: cvs commit: src/sys/sys param.h Message-ID: <200804111441.m3BEfIa1036717@repoman.freebsd.org> davidxu 2008-04-11 14:41:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/sys param.h Log: Bump version for added umtx functions. Revision Changes Path 1.308.2.9 +1 -1 src/sys/sys/param.h From ariff at FreeBSD.org Fri Apr 11 15:26:26 2008 From: ariff at FreeBSD.org (Ariff Abdullah) Date: Fri Apr 11 15:26:32 2008 Subject: cvs commit: src/sys/dev/sound/pcm dsp.c Message-ID: <200804111526.m3BFQPuo039784@repoman.freebsd.org> ariff 2008-04-11 15:26:25 UTC FreeBSD src repository Modified files: sys/dev/sound/pcm dsp.c Log: Don't mess up with CHN_F_TRIGGERED, since it should exclusively be handled by chn_abort() and chn_start() alone. This should fix few issues with single duplex hardware (mostly) or pre virtual record (RELENG 6) under WINE emulation and possibly others that using SNDCTL_DSP_SETTRIGGER. MFC after: 3 days Revision Changes Path 1.108 +10 -4 src/sys/dev/sound/pcm/dsp.c From xcllnt at mac.com Fri Apr 11 16:35:52 2008 From: xcllnt at mac.com (Marcel Moolenaar) Date: Fri Apr 11 16:35:57 2008 Subject: cvs commit: src/sys/amd64/amd64 intr_machdep.c src/sys/arm/arm intr.c src/sys/i386/i386 intr_machdep.c src/sys/ia64/ia64 interrupt.c src/sys/kern kern_cpuset.c kern_intr.c src/sys/powerpc/powerpc intr_machdep.c src/sys/sparc64/sparc64 ... In-Reply-To: <20080410235123.K43186@desktop> References: <200804110326.m3B3QfjL095474@repoman.freebsd.org> <20080410190028.U43186@desktop> <9B8DD956-E197-4540-A7F3-367B1E277456@mac.com> <20080410235123.K43186@desktop> Message-ID: <6A40DB30-85A5-4A79-B744-729AA7F656D9@mac.com> On Apr 11, 2008, at 2:51 AM, Jeff Roberson wrote: > > On Thu, 10 Apr 2008, Marcel Moolenaar wrote: > >> >> On Apr 10, 2008, at 10:01 PM, Jeff Roberson wrote: >>> On Thu, 10 Apr 2008, Marcel Moolenaar wrote: >>>> On Apr 10, 2008, at 8:26 PM, Jeff Roberson wrote: >>>>> jeff 2008-04-11 03:26:41 UTC >>>>> FreeBSD src repository >>>>> Modified files: >>>>> sys/amd64/amd64 intr_machdep.c >>>>> sys/arm/arm intr.c >>>>> sys/i386/i386 intr_machdep.c >>>>> sys/ia64/ia64 interrupt.c >>>>> sys/kern kern_cpuset.c kern_intr.c >>>>> sys/powerpc/powerpc intr_machdep.c >>>>> sys/sparc64/sparc64 intr_machdep.c >>>>> sys/sun4v/sun4v intr_machdep.c >>>>> sys/sys cpuset.h interrupt.h >>>>> Log: >>>>> - Add the interrupt vector number to intr_event_create so MI >>>>> code can >>>>> lookup hard interrupt events by number. Ignore the irq# for >>>>> soft intrs. >>>> JFYI: vectors are not the same as hard interrupt numbers. >>>> On ia64 they imply priority, which means that vector >>>> numbers should be selected for their priority and not >>>> have a 1-to-1 mapping with IRQ number. >>>> On powerpc they mean absolutely nothing other than being >>>> an index into an array. >>>> It's better to use IRQs and not vectors to lookup int. >>>> events by number. >>> I think I mixed my terminology in the commit. I meant for all >>> architectures to pass in the number that would appear in vmstat - >>> i. Can you verify that this is what I did for powerpc and ia64? >> >> powerpc correctly uses irq. >> ia64 incorrectly uses vector. >> >> Would you mind changing ia64 to use irq as well? > > Index: ia64/ia64/interrupt.c > =================================================================== > RCS file: /home/ncvs/src/sys/ia64/ia64/interrupt.c,v > retrieving revision 1.66 > diff -r1.66 interrupt.c > 343c343 > < 0, vector, ia64_intr_mask, ia64_intr_unmask, > ia64_intr_eoi, > --- >> 0, irq, ia64_intr_mask, ia64_intr_unmask, > ia64_intr_eoi, > > Does that look right? Yup. It does. Everything matches that way: ohci0: mem 0x80023000-0x80023fff irq 16 at device 1.0 on pci0 ohci0 pnpinfo vendor=0x1033 device=0x0035 subvendor=0x1033 subdevice=0x0035 class=0x0c0310 at slot=1 function=0 Interrupt request lines: 16 #015 0 0 ohci0 0 0 ohci1 0 0 ehci0 0 0 #019 0 0 Looking up interrupt events for ohci0 would then also use 16 and not 48 (i.e. the vector number). FYI, -- Marcel Moolenaar xcllnt@mac.com From rpaulo at FreeBSD.org Fri Apr 11 17:16:20 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Fri Apr 11 17:16:24 2008 Subject: cvs commit: src/sys/dev/asmc asmc.c Message-ID: <200804111716.m3BHGJno055017@repoman.freebsd.org> rpaulo 2008-04-11 17:16:19 UTC FreeBSD src repository Modified files: sys/dev/asmc asmc.c Log: Don't call acpi_disabled() because we are not part of the acpi.ko module. Instead, use resource_disabled() that doesn't depend on any module. Noticed by: Ian FREISLICH Revision Changes Path 1.8 +1 -1 src/sys/dev/asmc/asmc.c From jhb at FreeBSD.org Fri Apr 11 17:35:54 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Fri Apr 11 17:36:04 2008 Subject: cvs commit: src/sys/kern subr_taskqueue.c Message-ID: <200804111735.m3BHZsRr055632@repoman.freebsd.org> jhb 2008-04-11 17:35:54 UTC FreeBSD src repository Modified files: sys/kern subr_taskqueue.c Log: Use kthread_exit() to terminate a taskqueue thread rather than kproc_exit() now that the taskqueue threads are kthreads rather than kprocs. Reported by: kris Revision Changes Path 1.43 +1 -1 src/sys/kern/subr_taskqueue.c From brooks at FreeBSD.org Fri Apr 11 19:57:57 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Fri Apr 11 19:58:02 2008 Subject: cvs commit: CVSROOT access Message-ID: <200804111957.m3BJvum1063036@repoman.freebsd.org> brooks 2008-04-11 19:57:55 UTC FreeBSD src repository Modified files: . access Log: Take will's commit bit into safe keeping at his request. Approved by: core Revision Changes Path 1.871 +0 -1 CVSROOT/access From delphij at FreeBSD.org Fri Apr 11 21:31:16 2008 From: delphij at FreeBSD.org (Xin LI) Date: Fri Apr 11 21:31:21 2008 Subject: cvs commit: src/sys/kern kern_jail.c src/sys/sys jail.h Message-ID: <200804112131.m3BLVFMl077459@repoman.freebsd.org> delphij 2008-04-11 21:31:15 UTC FreeBSD src repository Modified files: sys/kern kern_jail.c sys/sys jail.h Log: Instead of rolling our own jail number allocation procedure, use alloc_unr() to do it. Submitted by: Ed Schouten PR: kern/122270 MFC after: 1 month Revision Changes Path 1.77 +18 -24 src/sys/kern/kern_jail.c 1.30 +0 -2 src/sys/sys/jail.h From peterjeremy at optushome.com.au Fri Apr 11 21:46:55 2008 From: peterjeremy at optushome.com.au (Peter Jeremy) Date: Fri Apr 11 21:47:00 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-card.c ata-cbus.c ata-chipset.c ata-disk.c ata-disk.h ata-dma.c ata-isa.c ata-lowlevel.c ata-pci.c ata-pci.h ata-queue.c ata-raid.c ata-raid.h ata-usb.c ata_if.m atapi-cd.c atapi-cd.h atapi-fd.c ... In-Reply-To: <200804101305.m3AD55DK066187@repoman.freebsd.org> References: <200804101305.m3AD55DK066187@repoman.freebsd.org> Message-ID: <20080411214651.GA66822@server.vk2pj.dyndns.org> On Thu, Apr 10, 2008 at 01:05:05PM +0000, S?ren Schmidt wrote: >sos 2008-04-10 13:05:05 UTC > > FreeBSD src repository > > Modified files: > sys/dev/ata ata-all.c ata-all.h ata-card.c ata-cbus.c > ata-chipset.c ata-disk.c ata-disk.h > ata-dma.c ata-isa.c ata-lowlevel.c > ata-pci.c ata-pci.h ata-queue.c > ata-raid.c ata-raid.h ata-usb.c ata_if.m > atapi-cd.c atapi-cd.h atapi-fd.c > atapi-fd.h atapi-tape.c atapi-tape.h > Log: > Add experimental support for SATA Port Multipliers > > Support is working on the Silicon Image SiI3124/3132. > Support is working on some AHCI chips but far from all. > > Remember this is WIP, so test reports and (constructive) suggestions are welcome! This seems to also include code to re-size ATA disks (PR kern/78758). Was that intended? -- Peter Jeremy Please excuse any delays as the result of my ISP's inability to implement an MTA that is either RFC2821-compliant or matches their claimed behaviour. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 195 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080411/d96852e4/attachment.pgp From mckusick at FreeBSD.org Fri Apr 11 21:48:14 2008 From: mckusick at FreeBSD.org (Kirk McKusick) Date: Fri Apr 11 21:48:27 2008 Subject: cvs commit: src/sbin/restore dirs.c tape.c Message-ID: <200804112148.m3BLmEor078674@repoman.freebsd.org> mckusick 2008-04-11 21:48:14 UTC FreeBSD src repository Modified files: sbin/restore dirs.c tape.c Log: Correctly set file group when restore is run by a user other than root. Revision Changes Path 1.33 +6 -1 src/sbin/restore/dirs.c 1.50 +3 -1 src/sbin/restore/tape.c From mckusick at FreeBSD.org Fri Apr 11 21:51:53 2008 From: mckusick at FreeBSD.org (Kirk McKusick) Date: Fri Apr 11 21:51:57 2008 Subject: cvs commit: src/sbin/restore tape.c Message-ID: <200804112151.m3BLprbl078891@repoman.freebsd.org> mckusick 2008-04-11 21:51:53 UTC FreeBSD src repository Modified files: sbin/restore tape.c Log: Avoid printing spurious ``Header with wrong dumpdate.'' message. Revision Changes Path 1.51 +1 -1 src/sbin/restore/tape.c From marius at FreeBSD.org Fri Apr 11 22:53:06 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Fri Apr 11 22:53:14 2008 Subject: cvs commit: src/sys/cddl/contrib/opensolaris/uts/common/sys asm_linkage.h Message-ID: <200804112253.m3BMr6Al086794@repoman.freebsd.org> marius 2008-04-11 22:53:06 UTC FreeBSD src repository Modified files: sys/cddl/contrib/opensolaris/uts/common/sys asm_linkage.h Log: - Fix the path encoded in the multiple inclusion protection. - GCC uses 32-byte function alignment for UltraSPARC CPUs. - Remove code duplication. Approved by: core, pjd MFC after: 2 weeks Revision Changes Path 1.4 +13 -36 src/sys/cddl/contrib/opensolaris/uts/common/sys/asm_linkage.h From sos at FreeBSD.org Fri Apr 11 22:56:30 2008 From: sos at FreeBSD.org (Søren Schmidt) Date: Fri Apr 11 22:56:39 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c Message-ID: <200804112256.m3BMuT3T087118@repoman.freebsd.org> sos 2008-04-11 22:56:27 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.c Log: Fix badly placed '{' Dont leak requests on busdma failure (not that we'd get anywhere anyhow). Reported by: antoine@ Revision Changes Path 1.284 +5 -2 src/sys/dev/ata/ata-all.c From marius at FreeBSD.org Fri Apr 11 22:59:33 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Fri Apr 11 22:59:40 2008 Subject: cvs commit: src/sys/cddl/contrib/opensolaris/common/atomic/sparc64 atomic.S src/sys/modules/zfs Makefile Message-ID: <200804112259.m3BMxXD5087296@repoman.freebsd.org> marius 2008-04-11 22:59:33 UTC FreeBSD src repository Modified files: sys/modules/zfs Makefile Added files: sys/cddl/contrib/opensolaris/common/atomic/sparc64 atomic.S Log: Add atomic operations for ZFS/sparc64. Approved by: core, pjd Obtained from: OpenSolaris (w/ adaptations) MFC after: 2 weeks Revision Changes Path 1.1 +115 -0 src/sys/cddl/contrib/opensolaris/common/atomic/sparc64/atomic.S (new) 1.11 +1 -1 src/sys/modules/zfs/Makefile From sos at FreeBSD.org Fri Apr 11 23:02:05 2008 From: sos at FreeBSD.org (=?ISO-8859-1?Q?S=F8ren_Schmidt?=) Date: Fri Apr 11 23:02:14 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-card.c ata-cbus.c ata-chipset.c ata-disk.c ata-disk.h ata-dma.c ata-isa.c ata-lowlevel.c ata-pci.c ata-pci.h ata-queue.c ata-raid.c ata-raid.h ata-usb.c ata_if.m atapi-cd.c atapi-cd.h atapi-fd.c ... In-Reply-To: <20080411214651.GA66822@server.vk2pj.dyndns.org> References: <200804101305.m3AD55DK066187@repoman.freebsd.org> <20080411214651.GA66822@server.vk2pj.dyndns.org> Message-ID: Hi Well, sortof, I've floated that patch around for quite some time. However, since it can cause havoc to systems that keep proprietary info hidden for you behind the forged end of disk , I didn't want to make too much fuzz about it. But now its there and can be used if you know what you are doing :) -S?ren On 11Apr, 2008, at 23:46 , Peter Jeremy wrote: > On Thu, Apr 10, 2008 at 01:05:05PM +0000, S?ren Schmidt wrote: >> sos 2008-04-10 13:05:05 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/ata ata-all.c ata-all.h ata-card.c ata-cbus.c >> ata-chipset.c ata-disk.c ata-disk.h >> ata-dma.c ata-isa.c ata-lowlevel.c >> ata-pci.c ata-pci.h ata-queue.c >> ata-raid.c ata-raid.h ata-usb.c ata_if.m >> atapi-cd.c atapi-cd.h atapi-fd.c >> atapi-fd.h atapi-tape.c atapi-tape.h >> Log: >> Add experimental support for SATA Port Multipliers >> >> Support is working on the Silicon Image SiI3124/3132. >> Support is working on some AHCI chips but far from all. >> >> Remember this is WIP, so test reports and (constructive) >> suggestions are welcome! > > This seems to also include code to re-size ATA disks (PR kern/78758). > Was that intended? > > -- > Peter Jeremy > Please excuse any delays as the result of my ISP's inability to > implement > an MTA that is either RFC2821-compliant or matches their claimed > behaviour. From marius at FreeBSD.org Fri Apr 11 23:04:37 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Fri Apr 11 23:04:39 2008 Subject: cvs commit: src/sys/modules Makefile Message-ID: <200804112304.m3BN4aWp088630@repoman.freebsd.org> marius 2008-04-11 23:04:36 UTC FreeBSD src repository Modified files: sys/modules Makefile Log: Hook up ZFS to the sparc64 build. Approved by: pjd MFC after: 2 weeks Revision Changes Path 1.561 +3 -0 src/sys/modules/Makefile From jeff at FreeBSD.org Fri Apr 11 23:10:40 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Fri Apr 11 23:10:57 2008 Subject: cvs commit: src/sys/ia64/ia64 interrupt.c Message-ID: <200804112310.m3BNAdWt088921@repoman.freebsd.org> jeff 2008-04-11 23:10:39 UTC FreeBSD src repository Modified files: sys/ia64/ia64 interrupt.c Log: - Pass the irq and not the vector to intr_event_create(). Reviewed by: marcel Revision Changes Path 1.67 +1 -1 src/sys/ia64/ia64/interrupt.c From davidch at FreeBSD.org Fri Apr 11 23:10:40 2008 From: davidch at FreeBSD.org (David Christensen) Date: Fri Apr 11 23:10:57 2008 Subject: cvs commit: src/sys/dev/bce if_bce.c if_bcefw.h if_bcereg.h Message-ID: <200804112310.m3BNAeMx088941@repoman.freebsd.org> davidch 2008-04-11 23:10:40 UTC FreeBSD src repository Modified files: sys/dev/bce if_bce.c if_bcefw.h if_bcereg.h Log: - Fixed a problem with the send chain consumer index which would cause TX traffic to sit in the send chain until a received packet kick started the interrupt handler. This would cause extremely slow performance when used with NFS over UDP. - Removed untested polling code. - Updated copyright year in the file header. - Removed inadvertent ^M's created by DOS text editor. MFC after: 2 weeks Revision Changes Path 1.37 +389 -487 src/sys/dev/bce/if_bce.c 1.6 +983 -983 src/sys/dev/bce/if_bcefw.h 1.18 +241 -188 src/sys/dev/bce/if_bcereg.h From xcllnt at mac.com Fri Apr 11 23:16:03 2008 From: xcllnt at mac.com (Marcel Moolenaar) Date: Fri Apr 11 23:16:09 2008 Subject: cvs commit: src/sys/ia64/ia64 interrupt.c In-Reply-To: <200804112310.m3BNAdWt088921@repoman.freebsd.org> References: <200804112310.m3BNAdWt088921@repoman.freebsd.org> Message-ID: <52831F72-B27B-4BDA-88C1-71EDE4E0E7AF@mac.com> On Apr 11, 2008, at 4:10 PM, Jeff Roberson wrote: > jeff 2008-04-11 23:10:39 UTC > > FreeBSD src repository > > Modified files: > sys/ia64/ia64 interrupt.c > Log: > - Pass the irq and not the vector to intr_event_create(). Thanks! -- Marcel Moolenaar xcllnt@mac.com From marius at FreeBSD.org Fri Apr 11 23:38:07 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Fri Apr 11 23:38:14 2008 Subject: cvs commit: src/sys/dev/dc if_dc.c if_dcreg.h Message-ID: <200804112338.m3BNc7us089807@repoman.freebsd.org> marius 2008-04-11 23:38:07 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/dc if_dc.c if_dcreg.h Log: MFC: if_dc.c 1.194; if_dcreg.h 1.55 - Const'ify the dc_devs array. - Correct the maxsize parameter when creating the mbufs busdma tag to reflect the actual requirement of dc(4). - Move the KASSERT in dc_newbuf() to the right spot. - Also convert the TX side to take advantage of bus_dmamap_load_mbuf_sg(9). - Move the comment regarding dc_start_locked() to the right spot. Revision Changes Path 1.192.2.2 +83 -82 src/sys/dev/dc/if_dc.c 1.54.2.1 +1 -3 src/sys/dev/dc/if_dcreg.h From marius at FreeBSD.org Fri Apr 11 23:41:45 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Fri Apr 11 23:42:11 2008 Subject: cvs commit: src/sys/pci if_dc.c if_dcreg.h Message-ID: <200804112341.m3BNfhng089965@repoman.freebsd.org> marius 2008-04-11 23:41:43 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/pci if_dc.c if_dcreg.h Log: MFC: if_dc.c 1.195, 1.194; if_dcreg.h 1.55 - Fix function prototype for device_shutdown method. - Const'ify the dc_devs array. - Correct the maxsize parameter when creating the mbufs busdma tag to reflect the actual requirement of dc(4). - Move the KASSERT in dc_newbuf() to the right spot. - Also convert the TX side to take advantage of bus_dmamap_load_mbuf_sg(9). - Move the comment regarding dc_start_locked() to the right spot. Revision Changes Path 1.160.2.14 +87 -84 src/sys/pci/if_dc.c 1.44.2.7 +1 -3 src/sys/pci/if_dcreg.h From davidxu at FreeBSD.org Fri Apr 11 23:52:55 2008 From: davidxu at FreeBSD.org (David Xu) Date: Fri Apr 11 23:53:02 2008 Subject: cvs commit: src/lib/libthr/arch/amd64 Makefile.inc src/lib/libthr/arch/amd64/include pthread_md.h src/lib/libthr/arch/amd64/amd64 _umtx_op_err.S src/lib/libthr/arch/i386 Makefile.inc src/lib/libthr/arch/i386/include pthread_md.h src/lib/libthr/arch/i386/i386 _umtx_op_err.S ... Message-ID: <200804112352.m3BNqrfv090453@repoman.freebsd.org> davidxu 2008-04-11 23:52:53 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libthr/arch/amd64 Makefile.inc lib/libthr/arch/amd64/include pthread_md.h lib/libthr/arch/i386 Makefile.inc lib/libthr/arch/i386/include pthread_md.h lib/libthr/thread thr_private.h thr_rwlock.c thr_umtx.c thr_umtx.h Added files: (Branch: RELENG_7) lib/libthr/arch/amd64/amd64 _umtx_op_err.S lib/libthr/arch/i386/i386 _umtx_op_err.S Log: MFC: - add _umtx_op_err function to improve stability because of errno changed by application signal handler code. - use kernel based userland rwlock to implement pthread_rwlock, improve performance in most cases. Revision Changes Path 1.2.10.2 +1 -1 src/lib/libthr/arch/amd64/Makefile.inc 1.1.2.1 +37 -0 src/lib/libthr/arch/amd64/amd64/_umtx_op_err.S (new) 1.4.2.1 +3 -0 src/lib/libthr/arch/amd64/include/pthread_md.h 1.2.10.2 +1 -1 src/lib/libthr/arch/i386/Makefile.inc 1.1.2.1 +36 -0 src/lib/libthr/arch/i386/i386/_umtx_op_err.S (new) 1.8.2.1 +3 -0 src/lib/libthr/arch/i386/include/pthread_md.h 1.78.2.3 +4 -5 src/lib/libthr/thread/thr_private.h 1.10.2.1 +142 -181 src/lib/libthr/thread/thr_rwlock.c 1.12.2.1 +52 -35 src/lib/libthr/thread/thr_umtx.c 1.10.2.1 +81 -0 src/lib/libthr/thread/thr_umtx.h From davidxu at FreeBSD.org Sat Apr 12 02:42:55 2008 From: davidxu at FreeBSD.org (David Xu) Date: Sat Apr 12 02:43:01 2008 Subject: cvs commit: src/lib/libthr/thread thr_private.h thr_rtld.c thr_sem.c thr_sig.c thr_suspend_np.c thr_umtx.c thr_umtx.h Message-ID: <200804120242.m3C2gtWm008894@repoman.freebsd.org> davidxu 2008-04-12 02:42:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libthr/thread thr_private.h thr_rtld.c thr_sem.c thr_sig.c thr_suspend_np.c thr_umtx.c thr_umtx.h Log: MFC: retire type umtx_t. Revision Changes Path 1.78.2.4 +1 -1 src/lib/libthr/thread/thr_private.h 1.3.4.1 +5 -5 src/lib/libthr/thread/thr_rtld.c 1.9.2.1 +3 -3 src/lib/libthr/thread/thr_sem.c 1.23.2.2 +1 -1 src/lib/libthr/thread/thr_sig.c 1.8.2.1 +1 -1 src/lib/libthr/thread/thr_suspend_np.c 1.12.2.2 +2 -2 src/lib/libthr/thread/thr_umtx.c 1.10.2.2 +2 -3 src/lib/libthr/thread/thr_umtx.h From davidxu at FreeBSD.org Sat Apr 12 02:55:00 2008 From: davidxu at FreeBSD.org (David Xu) Date: Sat Apr 12 02:55:06 2008 Subject: cvs commit: src/lib/libthr/thread thr_rtld.c Message-ID: <200804120255.m3C2t0NG009240@repoman.freebsd.org> davidxu 2008-04-12 02:54:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libthr/thread thr_rtld.c Log: MFC: Preserve and restore errno. Revision Changes Path 1.3.4.2 +35 -3 src/lib/libthr/thread/thr_rtld.c From das at FreeBSD.org Sat Apr 12 03:09:53 2008 From: das at FreeBSD.org (David Schultz) Date: Sat Apr 12 03:09:59 2008 Subject: cvs commit: src/lib/libc/sparc64/fpu fpu_qp.c Message-ID: <200804120309.m3C39qx0010947@repoman.freebsd.org> das 2008-04-12 03:09:52 UTC FreeBSD src repository Modified files: lib/libc/sparc64/fpu fpu_qp.c Log: Make the software emulator for long doubles set the FPU exception flags appropriately. The next step is to make it raise a SIGFPE if any exceptions are unmasked. Thanks to remko for access to a sparc64 box for testing. Revision Changes Path 1.9 +15 -0 src/lib/libc/sparc64/fpu/fpu_qp.c From das at FreeBSD.org Sat Apr 12 03:10:13 2008 From: das at FreeBSD.org (David Schultz) Date: Sat Apr 12 03:10:15 2008 Subject: cvs commit: src/lib/libc/sparc64/fpu fpu_sqrt.c Message-ID: <200804120310.m3C3ADGb011023@repoman.freebsd.org> das 2008-04-12 03:10:13 UTC FreeBSD src repository Modified files: lib/libc/sparc64/fpu fpu_sqrt.c Log: Fix some bugs that caused sparc64's quad precision sqrt to get the wrong answer for virtually all inputs. Thanks to remko for access to a sparc64 box for testing. Revision Changes Path 1.5 +5 -5 src/lib/libc/sparc64/fpu/fpu_sqrt.c From das at FreeBSD.org Sat Apr 12 03:11:36 2008 From: das at FreeBSD.org (David Schultz) Date: Sat Apr 12 03:11:47 2008 Subject: cvs commit: src/lib/libc/gdtoa Makefile.inc _hdtoa.c _hldtoa.c Message-ID: <200804120311.m3C3BaFB011106@repoman.freebsd.org> das 2008-04-12 03:11:36 UTC FreeBSD src repository Modified files: lib/libc/gdtoa Makefile.inc _hdtoa.c Added files: lib/libc/gdtoa _hldtoa.c Log: Make several changes to the way printf handles hex floating point (%a): 1. Previously, printing the number 1.0 could produce 0x1p+0, 0x2p-1, 0x4p-2, or 0x8p-3, depending on what happened to be convenient. This meant that printing a value as a double and printing the same value as a long double could produce different (but equivalent) results. The change is to always make the leading digit a 1, unless the number is 0. This solves the aforementioned problem and has several other advantages. 2. Use the FPU to do rounding. This is far simpler and more portable than manipulating the bits, and it fixes an obsure round-to-even bug. It also raises the exceptions now required by IEEE 754R. The drawbacks are that it is usually slightly slower, and it makes printf less effective as a debugging tool when the FPU is hosed (e.g., due to a buggy softfloat implementation). 3. On i386, twiddle the rounding precision so that (2) works properly for long doubles. 4. Make several simplifications that are now possible due to (2). 5. Split __hldtoa() into a separate file. Thanks to remko for access to a sparc64 box for testing. Revision Changes Path 1.10 +1 -1 src/lib/libc/gdtoa/Makefile.inc 1.6 +31 -208 src/lib/libc/gdtoa/_hdtoa.c 1.1 +176 -0 src/lib/libc/gdtoa/_hldtoa.c (new) From das at FreeBSD.org Sat Apr 12 03:11:56 2008 From: das at FreeBSD.org (David Schultz) Date: Sat Apr 12 03:12:02 2008 Subject: cvs commit: src/lib/libc/stdio printf.3 src/tools/regression/lib/libc/stdio test-printfloat.c Message-ID: <200804120311.m3C3BudY011156@repoman.freebsd.org> das 2008-04-12 03:11:56 UTC FreeBSD src repository Modified files: lib/libc/stdio printf.3 tools/regression/lib/libc/stdio test-printfloat.c Log: Updates for changes in the way printf() handles hex floating point numbers. Revision Changes Path 1.61 +5 -4 src/lib/libc/stdio/printf.3 1.12 +5 -5 src/tools/regression/lib/libc/stdio/test-printfloat.c From davidxu at FreeBSD.org Sat Apr 12 04:07:21 2008 From: davidxu at FreeBSD.org (David Xu) Date: Sat Apr 12 04:07:23 2008 Subject: cvs commit: src/lib/libc/stdtime localtime.c Message-ID: <200804120407.m3C47KXR014163@repoman.freebsd.org> davidxu 2008-04-12 04:07:20 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libc/stdtime localtime.c Log: MFC revision 1.43: Reduce lock contention by replacing mutex with rwlock. Revision Changes Path 1.41.2.1 +63 -22 src/lib/libc/stdtime/localtime.c From pjd at FreeBSD.org Sat Apr 12 05:49:06 2008 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Sat Apr 12 05:49:15 2008 Subject: cvs commit: src/share/man/man4 ddb.4 Message-ID: <200804120549.m3C5n6fa029263@repoman.freebsd.org> pjd 2008-04-12 05:49:05 UTC FreeBSD src repository Modified files: share/man/man4 ddb.4 Log: Correct an obvious typo. Revision Changes Path 1.49 +1 -1 src/share/man/man4/ddb.4 From bu7cher at yandex.ru Sat Apr 12 06:25:23 2008 From: bu7cher at yandex.ru (Andrey V. Elsukov) Date: Sat Apr 12 06:25:30 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-card.c ata-cbus.c ata-chipset.c ata-disk.c ata-disk.h ata-dma.c ata-isa.c ata-lowlevel.c ata-pci.c ata-pci.h ata-queue.c ata-raid.c ata-raid.h ata-usb.c ata_if.m atapi-cd.c In-Reply-To: 9060000000207768514 References: <200804101305.m3AD55DK066187@repoman.freebsd.org> <20080411214651.GA66822@server.vk2pj.dyndns.org> 9060000000207768514 Message-ID: <8211207979782@webmail17.yandex.ru> 12.04.08, 03:02, "S?ren Schmidt" : > Well, sortof, I've floated that patch around for quite some time. > However, since it can cause havoc to systems that keep proprietary > info hidden for you behind the forged end of disk , I didn't want to > make too much fuzz about it. > But now its there and can be used if you know what you are doing :) It is related to PR kern/121703. I think you can close this PR. Dmitry reported to me that patch helped him. -- WBR, Andrey V. Elsukov From flz at FreeBSD.org Sat Apr 12 11:23:22 2008 From: flz at FreeBSD.org (Florent Thoumie) Date: Sat Apr 12 11:23:24 2008 Subject: cvs commit: src/sys/dev/usb ubsa.c usbdevs Message-ID: <200804121123.m3CBNLmD056321@repoman.freebsd.org> flz 2008-04-12 11:23:21 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/usb ubsa.c usbdevs Log: MFC: Add support for Verizon v740 to ubsa(4). src/sys/dev/usb/usbdevs: rev 1.345 -> 1.346 src/sys/dev/usb/ubsa.c: rev 1.34 -> 1.35 PR: usb/122610 Submitted by: Randi Harper Revision Changes Path 1.32.2.2 +2 -0 src/sys/dev/usb/ubsa.c 1.328.2.8 +1 -0 src/sys/dev/usb/usbdevs From simon at FreeBSD.org Sat Apr 12 11:53:08 2008 From: simon at FreeBSD.org (Simon L. Nielsen) Date: Sat Apr 12 11:53:17 2008 Subject: cvs commit: src/sys/kern subr_sleepqueue.c In-Reply-To: <200803130046.m2D0kDbx036689@repoman.freebsd.org> References: <200803130046.m2D0kDbx036689@repoman.freebsd.org> Message-ID: <20080412113636.GB1141@zaphod.nitro.dk> On 2008.03.13 00:46:13 +0000, Jeff Roberson wrote: > jeff 2008-03-13 00:46:12 UTC > > FreeBSD src repository > > Modified files: > sys/kern subr_sleepqueue.c > Log: > PR 117603 > - Close a sleepqueue signal race by interlocking with the per-process > spinlock. This was mistakenly omitted from the thread_lock patch and > has been a race since. > > MFC After: 1 week > PR: bin/117603 > Reported by: Danny Braniss Is there a reason this has not been MFC'ed to RELENG_7 or was it just forgotten? It would be really nice to have it MFC'ed so I don't have to manually patch as many systems so I can run dump :-). -- Simon L. Nielsen From rpaulo at FreeBSD.org Sat Apr 12 12:04:10 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Sat Apr 12 12:04:16 2008 Subject: cvs commit: src/sys/dev/asmc asmc.c asmcvar.h Message-ID: <200804121204.m3CC49ja058684@repoman.freebsd.org> rpaulo 2008-04-12 12:04:09 UTC FreeBSD src repository Modified files: sys/dev/asmc asmc.c asmcvar.h Log: Match the Mac Pro with 8 cores. This machine reports 35 temperature sensors and some fans. As I don't own this machine, I could not test this patch. Obtained from: applesmc Linux driver. Revision Changes Path 1.9 +12 -3 src/sys/dev/asmc/asmc.c 1.6 +32 -2 src/sys/dev/asmc/asmcvar.h From rpaulo at FreeBSD.org Sat Apr 12 12:06:00 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Sat Apr 12 12:06:08 2008 Subject: cvs commit: src/sys/dev/acpica acpi_cpu.c Message-ID: <200804121206.m3CC60hw058780@repoman.freebsd.org> rpaulo 2008-04-12 12:06:00 UTC FreeBSD src repository Modified files: sys/dev/acpica acpi_cpu.c Log: Update the list of Cx states when ACPICA notifies us. Usually, this notification is sent when the AC plug is plugged in/out. This is required on some laptops, namely the MacBooks. Silence on: freebsd-acpi Revision Changes Path 1.72 +24 -4 src/sys/dev/acpica/acpi_cpu.c From kris at FreeBSD.org Sat Apr 12 12:17:50 2008 From: kris at FreeBSD.org (Kris Kennaway) Date: Sat Apr 12 12:17:55 2008 Subject: cvs commit: src/sys/sys rwlock.h Message-ID: <200804121217.m3CCHn7Z059172@repoman.freebsd.org> kris 2008-04-12 12:17:49 UTC FreeBSD src repository Modified files: sys/sys rwlock.h Log: Trylocks were implemented, remove stale comment Revision Changes Path 1.18 +0 -2 src/sys/sys/rwlock.h From marius at FreeBSD.org Sat Apr 12 13:41:00 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Sat Apr 12 13:41:05 2008 Subject: cvs commit: src/sys/sparc64/include tlb.h src/sys/sparc64/sparc64 cache.c cheetah.c mp_machdep.c pmap.c spitfire.c tlb.c Message-ID: <200804121341.m3CDf0hX072473@repoman.freebsd.org> marius 2008-04-12 13:40:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/sparc64/include tlb.h sys/sparc64/sparc64 cache.c cheetah.c mp_machdep.c pmap.c spitfire.c tlb.c Log: MFC: tlb.h 1.27; cache.c 1.21; cheetah.c 1.6; mp_machdep.c 1.38; pmap.c 1.171; spitfire.c 1.6; tlb.c 1.9 - Do as the comment in pmap_bootstrap() suggests and flush all non-locked TLB entries possibly left over by the firmware and also do so while bootstrapping APs. - Use __FBSDID. Revision Changes Path 1.26.22.1 +8 -0 src/sys/sparc64/include/tlb.h 1.20.10.1 +5 -2 src/sys/sparc64/sparc64/cache.c 1.5.20.1 +20 -2 src/sys/sparc64/sparc64/cheetah.c 1.36.2.1 +5 -0 src/sys/sparc64/sparc64/mp_machdep.c 1.166.2.2 +12 -5 src/sys/sparc64/sparc64/pmap.c 1.5.20.1 +28 -5 src/sys/sparc64/sparc64/spitfire.c 1.8.20.1 +6 -4 src/sys/sparc64/sparc64/tlb.c From marius at FreeBSD.org Sat Apr 12 13:41:33 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Sat Apr 12 13:41:39 2008 Subject: cvs commit: src/sys/sparc64/include tlb.h src/sys/sparc64/sparc64 cache.c cheetah.c mp_machdep.c pmap.c spitfire.c tlb.c Message-ID: <200804121341.m3CDfWpw072549@repoman.freebsd.org> marius 2008-04-12 13:41:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/sparc64/include tlb.h sys/sparc64/sparc64 cache.c cheetah.c mp_machdep.c pmap.c spitfire.c tlb.c Log: MFC: tlb.h 1.27; cache.c 1.21; cheetah.c 1.6; mp_machdep.c 1.38; pmap.c 1.171; spitfire.c 1.6; tlb.c 1.9 - Do as the comment in pmap_bootstrap() suggests and flush all non-locked TLB entries possibly left over by the firmware and also do so while bootstrapping APs. - Use __FBSDID. Revision Changes Path 1.26.12.1 +8 -0 src/sys/sparc64/include/tlb.h 1.20.2.1 +5 -2 src/sys/sparc64/sparc64/cache.c 1.5.10.1 +20 -2 src/sys/sparc64/sparc64/cheetah.c 1.29.2.3 +5 -0 src/sys/sparc64/sparc64/mp_machdep.c 1.148.2.6 +12 -5 src/sys/sparc64/sparc64/pmap.c 1.5.10.1 +28 -5 src/sys/sparc64/sparc64/spitfire.c 1.8.10.1 +6 -4 src/sys/sparc64/sparc64/tlb.c From attilio at FreeBSD.org Sat Apr 12 13:51:19 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Sat Apr 12 13:51:25 2008 Subject: cvs commit: src/sys/kern subr_witness.c Message-ID: <200804121351.m3CDpJwl072869@repoman.freebsd.org> attilio 2008-04-12 13:51:19 UTC FreeBSD src repository Modified files: sys/kern subr_witness.c Log: Add missing stubs for spinlocks cpuset and intrcnt. Submitted by: kris Revision Changes Path 1.244 +2 -0 src/sys/kern/subr_witness.c From attilio at FreeBSD.org Sat Apr 12 13:56:19 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Sat Apr 12 13:56:21 2008 Subject: cvs commit: src/sys/kern kern_lock.c Message-ID: <200804121356.m3CDuHnU073067@repoman.freebsd.org> attilio 2008-04-12 13:56:17 UTC FreeBSD src repository Modified files: sys/kern kern_lock.c Log: - Remove a stale comment. - Add an extra assertion in order to catch malformed requested operations. Revision Changes Path 1.130 +2 -4 src/sys/kern/kern_lock.c From rpaulo at FreeBSD.org Sat Apr 12 14:04:09 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Sat Apr 12 14:04:17 2008 Subject: cvs commit: src/sys/dev/k8temp k8temp.c Message-ID: <200804121404.m3CE483l074461@repoman.freebsd.org> rpaulo 2008-04-12 14:04:08 UTC FreeBSD src repository Added files: sys/dev/k8temp k8temp.c Log: MFp4: k8temp, a driver to monitor AMD K8 CPU temperature via builtin sensors. Based on the Linux driver by the same name. Tested by: many (see freebsd-amd64) Revision Changes Path 1.1 +317 -0 src/sys/dev/k8temp/k8temp.c (new) From rpaulo at FreeBSD.org Sat Apr 12 14:08:25 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Sat Apr 12 14:08:32 2008 Subject: cvs commit: src/share/man/man4 Makefile k8temp.4 Message-ID: <200804121408.m3CE8OI8074665@repoman.freebsd.org> rpaulo 2008-04-12 14:08:24 UTC FreeBSD src repository Modified files: share/man/man4 Makefile Added files: share/man/man4 k8temp.4 Log: MFp4: k8temp(4) man page. Revision Changes Path 1.414 +1 -0 src/share/man/man4/Makefile 1.1 +71 -0 src/share/man/man4/k8temp.4 (new) From rpaulo at FreeBSD.org Sat Apr 12 14:20:25 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Sat Apr 12 14:20:32 2008 Subject: cvs commit: src/sys/amd64/conf NOTES src/sys/conf files.amd64 src/sys/modules Makefile src/sys/modules/k8temp Makefile Message-ID: <200804121420.m3CEKPgl075162@repoman.freebsd.org> rpaulo 2008-04-12 14:20:22 UTC FreeBSD src repository Modified files: sys/amd64/conf NOTES sys/conf files.amd64 sys/modules Makefile Added files: sys/modules/k8temp Makefile Log: Connect k8temp(4) to the build. Revision Changes Path 1.78 +2 -0 src/sys/amd64/conf/NOTES 1.119 +1 -0 src/sys/conf/files.amd64 1.562 +2 -0 src/sys/modules/Makefile 1.1 +8 -0 src/sys/modules/k8temp/Makefile (new) From das at FreeBSD.org Sat Apr 12 14:53:52 2008 From: das at FreeBSD.org (David Schultz) Date: Sat Apr 12 14:53:54 2008 Subject: cvs commit: src/lib/libc/gdtoa _hdtoa.c _hldtoa.c Message-ID: <200804121453.m3CErqbU076196@repoman.freebsd.org> das 2008-04-12 14:53:52 UTC FreeBSD src repository Modified files: lib/libc/gdtoa _hdtoa.c _hldtoa.c Log: Unbreak the build for arm and powerpc. Pointy hat to yours truly. Revision Changes Path 1.7 +2 -0 src/lib/libc/gdtoa/_hdtoa.c 1.2 +1 -0 src/lib/libc/gdtoa/_hldtoa.c From ariff at FreeBSD.org Sat Apr 12 15:07:34 2008 From: ariff at FreeBSD.org (Ariff Abdullah) Date: Sat Apr 12 15:07:40 2008 Subject: cvs commit: src/sys/dev/sound/pci/hda hdac.c Message-ID: <200804121507.m3CF7XAW077870@repoman.freebsd.org> ariff 2008-04-12 15:07:33 UTC FreeBSD src repository Modified files: sys/dev/sound/pci/hda hdac.c Log: - Add codec id for Sigmatel STAC9205 - Fix speaker issues with Dell Vostro 1500 (GPIO0) Tested by: John Wright - Apply ridiculous quirk on Asus A8X series (A8JC, A8M, A8xx, etc). These different laptop series share simmilar pci id, hardware codecs, etc. but works differently. A slight difference in connection type for widget #26 is used to differentiate it. Tested by: eric baumbach - Apply GPIO0 quirk for ASUS G2K laptop - Sort ASUS ids accordingly. Submitted by: jkim MFC after: 3 days Revision Changes Path 1.52 +52 -12 src/sys/dev/sound/pci/hda/hdac.c From philip at FreeBSD.org Sat Apr 12 16:02:04 2008 From: philip at FreeBSD.org (Philip Paeps) Date: Sat Apr 12 16:02:10 2008 Subject: cvs commit: CVSROOT access Message-ID: <200804121602.m3CG23an079739@repoman.freebsd.org> philip 2008-04-12 16:02:03 UTC FreeBSD src repository Modified files: . access Log: Welcome Dan Langille (dvl@) and Peter Losher (plosher@) to the access file as trusted non-committing contributors pending the adaptation of our email scripts to cater for this category of people. Approved by: core Revision Changes Path 1.872 +11 -0 CVSROOT/access From sos at FreeBSD.org Sat Apr 12 17:21:24 2008 From: sos at FreeBSD.org (Søren Schmidt) Date: Sat Apr 12 17:21:28 2008 Subject: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h Message-ID: <200804121721.m3CHLNqu095189@repoman.freebsd.org> sos 2008-04-12 17:21:23 UTC FreeBSD src repository Modified files: sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h Log: Dont call hw.status recursively. Spotted by: Marcel Moolenaar Revision Changes Path 1.215 +5 -7 src/sys/dev/ata/ata-chipset.c 1.125 +1 -1 src/sys/dev/ata/ata-pci.c 1.85 +1 -0 src/sys/dev/ata/ata-pci.h From mlaier at FreeBSD.org Sat Apr 12 18:26:49 2008 From: mlaier at FreeBSD.org (Max Laier) Date: Sat Apr 12 18:27:01 2008 Subject: cvs commit: src/contrib/pf/pfctl pfctl_altq.c pfctl_qstats.c src/sys/contrib/pf/net pf_if.c pf_ioctl.c pfvar.h Message-ID: <200804121826.m3CIQmav098543@repoman.freebsd.org> mlaier 2008-04-12 18:26:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) contrib/pf/pfctl pfctl_altq.c pfctl_qstats.c sys/contrib/pf/net pf_if.c pf_ioctl.c pfvar.h Log: MFC: Make ALTQ cope with disappearing interfaces (particularly common with mpd and netgraph in gernal). This also allows to add queues for an interface that is not yet existing (you have to provide the bandwidth for the interface, however). PR: kern/106400, kern/117827 Tested by: Florian Smeets, Boris S. Revision Changes Path 1.9.2.1 +13 -1 src/contrib/pf/pfctl/pfctl_altq.c 1.6.10.1 +27 -1 src/contrib/pf/pfctl/pfctl_qstats.c 1.11.2.3 +7 -1 src/sys/contrib/pf/net/pf_if.c 1.28.2.2 +117 -3 src/sys/contrib/pf/net/pf_ioctl.c 1.16.2.1 +8 -1 src/sys/contrib/pf/net/pfvar.h From marius at alchemy.franken.de Sat Apr 12 19:34:00 2008 From: marius at alchemy.franken.de (Marius Strobl) Date: Sat Apr 12 19:34:05 2008 Subject: cvs commit: src/sys/dev/usb ehci.c ohci.c In-Reply-To: <200803201619.m2KGJQr7033985@repoman.freebsd.org> References: <200803201619.m2KGJQr7033985@repoman.freebsd.org> Message-ID: <20080412193358.GA44768@alchemy.franken.de> On Thu, Mar 20, 2008 at 04:19:26PM +0000, Sam Leffler wrote: > sam 2008-03-20 16:19:25 UTC > > FreeBSD src repository > > Modified files: > sys/dev/usb ehci.c ohci.c > Log: > Workaround design botch in usb: blindly mixing bus_dma with PIO does not > work on architectures with a write-back cache as the PIO writes end up > in the cache which the sync(BUS_DMASYNC_POSTREAD) in usb_transfer_complete > then discards; compensate in the xfer methods that do PIO by pushing the > writes out of the cache before usb_transfer_complete is called. > > This fixes USB on xscale and likely other places. > > Sponsored by: hobnob > Reviewed by: cognet, imp > MFC after: 1 month > > Revision Changes Path > 1.62 +16 -0 src/sys/dev/usb/ehci.c > 1.171 +16 -0 src/sys/dev/usb/ohci.c This causes a crash during boot on sparc64. Looks like map is still NULL at that point. Marius ohci0: mem 0x1000000-0x1000fff at d0 ohci0: Reserved 0x1000 bytes for rid 0x10 type 3 at 0x1000000 ohci0: [GIANT-LOCKED] ohci0: [ITHREAD] usb0: OHCI version 1.0, legacy support usb0: on ohci0 usb0: USB revision 1.0 panic: trap: fast data access mmu miss cpuid = 0 KDB: enter: panic [thread pid 0 tid 100000 ] Stopped at kdb_enter+0x80: ta %xcc, 1 db> bt Tracing pid 0 tid 100000 td 0xc076d8e0 panic() at panic+0x208 trap() at trap+0x4d0 -- fast data access mmu miss tar=0 %o7=0xc0226f1c -- iommu_dvmamap_sync() at iommu_dvmamap_sync+0x4 ohci_root_ctrl_start() at ohci_root_ctrl_start+0xe4c ohci_root_ctrl_transfer() at ohci_root_ctrl_transfer+0x1c usbd_start_transfer() at usbd_start_transfer+0x188 usbd_transfer() at usbd_transfer+0x128 usbd_sync_transfer() at usbd_sync_transfer+0x10 usbd_do_request_flags_pipe() at usbd_do_request_flags_pipe+0x5c usbd_do_request_flags() at usbd_do_request_flags+0x1c usbd_do_request() at usbd_do_request+0x1c usbd_set_address() at usbd_set_address+0x34 usbd_new_device() at usbd_new_device+0x3a4 usb_attach() at usb_attach+0x16c device_attach() at device_attach+0x4a4 device_probe_and_attach() at device_probe_and_attach+0x14c ohci_pci_attach() at ohci_pci_attach+0x8bc device_attach() at device_attach+0x4a4 device_probe_and_attach() at device_probe_and_attach+0x14c bus_generic_attach() at bus_generic_attach+0x10 ofw_pcibus_attach() at ofw_pcibus_attach+0x680 device_attach() at device_attach+0x4a4 device_probe_and_attach() at device_probe_and_attach+0x14c bus_generic_attach() at bus_generic_attach+0x10 psycho_attach() at psycho_attach+0x1124 device_attach() at device_attach+0x4a4 device_probe_and_attach() at device_probe_and_attach+0x14c bus_generic_attach() at bus_generic_attach+0x10 nexus_attach() at nexus_attach+0x4fc device_attach() at device_attach+0x4a4 device_probe_and_attach() at device_probe_and_attach+0x14c root_bus_configure() at root_bus_configure+0x28 configure() at configure+0x4 mi_startup() at mi_startup+0x18c btext() at btext+0x34 > addr2line -fe kernel.debug 0xc057e9e4 iommu_dvmamap_sync /usr/home/marius/co/ts/src/sys/sparc64/sparc64/iommu.c:1137 From mlaier at FreeBSD.org Sat Apr 12 19:52:14 2008 From: mlaier at FreeBSD.org (Max Laier) Date: Sat Apr 12 19:52:20 2008 Subject: cvs commit: src/contrib/pf/pfctl pfctl_altq.c pfctl_qstats.c src/sys/contrib/pf/net pf_if.c pf_ioctl.c pfvar.h Message-ID: <200804121952.m3CJqDKf003382@repoman.freebsd.org> mlaier 2008-04-12 19:52:13 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) contrib/pf/pfctl pfctl_altq.c pfctl_qstats.c sys/contrib/pf/net pf_if.c pf_ioctl.c pfvar.h Log: MFC: Make ALTQ cope with disappearing interfaces (particularly common with mpd and netgraph in gernal). This also allows to add queues for an interface that is not yet existing (you have to provide the bandwidth for the interface, however). PR: kern/106400, kern/117827 Tested by: Florian Smeets, Boris S. Revision Changes Path 1.7.2.2 +13 -1 src/contrib/pf/pfctl/pfctl_altq.c 1.6.2.1 +27 -1 src/contrib/pf/pfctl/pfctl_qstats.c 1.10.2.1 +7 -1 src/sys/contrib/pf/net/pf_if.c 1.20.2.6 +117 -3 src/sys/contrib/pf/net/pf_ioctl.c 1.11.2.3 +8 -1 src/sys/contrib/pf/net/pfvar.h From attilio at FreeBSD.org Sat Apr 12 19:57:31 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Sat Apr 12 19:57:40 2008 Subject: cvs commit: src/sys/kern kern_lock.c subr_witness.c Message-ID: <200804121957.m3CJvUJ1003661@repoman.freebsd.org> attilio 2008-04-12 19:57:30 UTC FreeBSD src repository Modified files: sys/kern kern_lock.c subr_witness.c Log: - Re-introduce WITNESS support for lockmgr. About the old implementation the only one difference is that lockmgr*() functions now accept LK_NOWITNESS flag which skips ordering for the instanced calling. - Remove an unuseful stub in witness_checkorder() (because the above check doesn't allow ever happening) and allow witness_upgrade() to accept non-try operation too. Revision Changes Path 1.131 +78 -17 src/sys/kern/kern_lock.c 1.245 +0 -11 src/sys/kern/subr_witness.c From attilio at FreeBSD.org Sat Apr 12 20:18:03 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Sat Apr 12 20:18:09 2008 Subject: cvs commit: src/share/man/man9 lock.9 Message-ID: <200804122018.m3CKI3M8005617@repoman.freebsd.org> attilio 2008-04-12 20:18:03 UTC FreeBSD src repository Modified files: share/man/man9 lock.9 Log: LK_NOWITNESS can be used now in lockmgr*() functions in order to skip witness(4) checks on a per-instance basis. Revision Changes Path 1.33 +5 -1 src/share/man/man9/lock.9 From phk at FreeBSD.org Sat Apr 12 20:26:08 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Sat Apr 12 20:26:15 2008 Subject: cvs commit: src/sys/dev/pci pcivar.h Message-ID: <200804122026.m3CKQ7wh005956@repoman.freebsd.org> phk 2008-04-12 20:26:07 UTC FreeBSD src repository Modified files: sys/dev/pci pcivar.h Log: Remove a trailing comma which FlexeLint whines about. Revision Changes Path 1.81 +1 -1 src/sys/dev/pci/pcivar.h From phk at FreeBSD.org Sat Apr 12 20:35:57 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Sat Apr 12 20:36:04 2008 Subject: cvs commit: src/sys/kern subr_clock.c Message-ID: <200804122035.m3CKZuvL006359@repoman.freebsd.org> phk 2008-04-12 20:35:56 UTC FreeBSD src repository Modified files: sys/kern subr_clock.c Log: Emit summaries of struct c(alender)t(ime) <-> struct timespec conversions under bootverbose. Struct ct is used for setting/reading real time clocks and I'm about to Do Things to some of those, so a bit of preemptive debugging is in order. Remove a pointless __inline. Revision Changes Path 1.13 +27 -2 src/sys/kern/subr_clock.c From phk at FreeBSD.org Sat Apr 12 20:46:07 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Sat Apr 12 20:46:20 2008 Subject: cvs commit: src/sys/conf files.i386 src/sys/i386/conf GENERIC.hints src/sys/i386/isa clock.c Message-ID: <200804122046.m3CKk7VE006841@repoman.freebsd.org> phk 2008-04-12 20:46:07 UTC FreeBSD src repository Modified files: sys/conf files.i386 sys/i386/conf GENERIC.hints sys/i386/isa clock.c Log: Move i386 to generic RTC handling code. Make clock_if.m and subr_rtc.c standard on i386 Add hints for "atrtc" driver, for non-PnP, non-ACPI systems. NB: Make sure to install GENERIC.hints into /boot/device.hints in these! Nuke MD inittodr(), resettodr() functions. Don't attach to PHP0B00 in the "attimer" dummy driver any more, and remove comments that no longer apply for that reason. Add new "atrtc" device driver, which handles IBM PC AT Real Time Clock compatible devices using subr_rtc and clock_if. This driver is not entirely clean: other code still fondles the hardware to get a statclock interrupt on non-ACPI timer systems. Wrap some overly long lines. After it has settled in -current, this will be ported to amd64. Technically this is MFC'able, but I fail to see a good reason. Revision Changes Path 1.593 +2 -0 src/sys/conf/files.i386 1.20 +3 -0 src/sys/i386/conf/GENERIC.hints 1.246 +168 -103 src/sys/i386/isa/clock.c From phk at FreeBSD.org Sat Apr 12 21:51:54 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Sat Apr 12 21:52:04 2008 Subject: cvs commit: src/sys/kern subr_clock.c Message-ID: <200804122151.m3CLpsom019254@repoman.freebsd.org> phk 2008-04-12 21:51:54 UTC FreeBSD src repository Modified files: sys/kern subr_clock.c Log: fix printf type confusion on amd64 Revision Changes Path 1.14 +3 -2 src/sys/kern/subr_clock.c From marius at alchemy.franken.de Sat Apr 12 22:15:03 2008 From: marius at alchemy.franken.de (Marius Strobl) Date: Sat Apr 12 22:15:23 2008 Subject: cvs commit: src/sys/boot/common dev_net.c src/sys/boot/uboot/lib console.c copy.c glue.c libuboot.h net.c time.c In-Reply-To: <200803121601.m2CG1ZbG072258@repoman.freebsd.org> References: <200803121601.m2CG1ZbG072258@repoman.freebsd.org> Message-ID: <20080412221501.GB44768@alchemy.franken.de> On Wed, Mar 12, 2008 at 04:01:34PM +0000, Rafal Jaworowski wrote: > raj 2008-03-12 16:01:34 UTC > > FreeBSD src repository > > Modified files: > sys/boot/common dev_net.c > sys/boot/uboot/lib console.c copy.c glue.c libuboot.h net.c > time.c > Log: > Eliminate artificial increasing of 'netdev_opens' counter in loader's net_open(). > > This was introduced as a workaround long time ago for some Alpha firmware > (which is now gone), and actually prevented net_close() to ever be > called. > > Certain firmwares (U-Boot) need local shutdown operations to be performed on a > network controller upon transaction end: such platform-specific hooks are > supposed to be called via netif_close() (from within net_close()). > > This change effectively reverts the following CVS commit: > > sys/boot/common/dev_net.c > > revision 1.7 > date: 2000/05/13 15:40:46; author: dfr; state: Exp; lines: +2 -1 > Only probe network settings on the first open of the network device. > The alpha firmware takes a seriously long time to open the network device > the first time. > On at least sparc64 reverting this causes ofwn_init() to be called over and over again, which doesn't seem to be the right thing to do either. Marius Sun Fire V100 (UltraSPARC-IIe 500MHz), No Keyboard OpenBoot 4.0, 256 MB memory installed, Serial #51583895. Ethernet address 0:3:ba:13:1b:97, Host ID: 83131b97. Executing last command: boot net:dhcp Boot device: /pci@1f,0/ethernet@c:dhcp File and args: 36800 Consoles: Open Firmware console Booting with sun4u support. FreeBSD/sparc64 bootstrap loader, Revision 1.0 (marius@flak.lan.zeist.de, Sat Apr 12 22:48:49 CEST 2008) bootpath="/pci@1f,0/ethernet@c:dhcp" boot: ethernet address: 00:03:ba:13:1b:97 boot: ethernet address: 00:03:ba:13:1b:97 boot: ethernet address: 00:03:ba:13:1b:97 boot: ethernet address: 00:03:ba:13:1b:97 boot: ethernet address: 00:03:ba:13:1b:97 Loading /boot/defaults/loader.conf boot: ethernet address: 00:03:ba:13:1b:97 boot: ethernet address: 00:03:ba:13:1b:97 boot: ethernet address: 00:03:ba:13:1b:97 boot: ethernet address: 00:03:ba:13:1b:97 boot: ethernet address: 00:03:ba:13:1b:97 boot: ethernet address: 00:03:ba:13:1b:97 boot: ethernet address: 00:03:ba:13:1b:97 boot: ethernet address: 00:03:ba:13:1b:97 boot: ethernet address: 00:03:ba:13:1b:97 /boot/kernel/kernel data=0x6abd48+0x70568 syms=[0x8+0x75630+0x8+0x63cc2] boot: ethernet address: 00:03:ba:13:1b:97 boot: ethernet address: 00:03:ba:13:1b:97 From marius at alchemy.franken.de Sat Apr 12 23:01:59 2008 From: marius at alchemy.franken.de (Marius Strobl) Date: Sat Apr 12 23:02:08 2008 Subject: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h In-Reply-To: <200804121721.m3CHLNqu095189@repoman.freebsd.org> References: <200804121721.m3CHLNqu095189@repoman.freebsd.org> Message-ID: <20080412230157.GC44768@alchemy.franken.de> On Sat, Apr 12, 2008 at 05:21:23PM +0000, Sren Schmidt wrote: > sos 2008-04-12 17:21:23 UTC > > FreeBSD src repository > > Modified files: > sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h > Log: > Dont call hw.status recursively. > > Spotted by: Marcel Moolenaar > > Revision Changes Path > 1.215 +5 -7 src/sys/dev/ata/ata-chipset.c > 1.125 +1 -1 src/sys/dev/ata/ata-pci.c > 1.85 +1 -0 src/sys/dev/ata/ata-pci.h Even with these fixes in place your latest round of ata(4) changes causes acd0 to disappear on a sparc64 machine for me. Reverting to ata(4) sources of April 9th fixes these. Verbose before and after dmesg output is at: http://people.freebsd.org/~marius/v100_1.txt http://people.freebsd.org/~marius/v100_2.txt Btw., `atacontrol list` is broken on archs where ata2 is the first ata(4) device (probably all except amd64 and i386) as atacontrol(8) assumes channels from 0 to IOCATAGMAXCHANNEL exist: # atacontrol list atacontrol: ioctl(IOCATADEVICES): Device not configured Marius From attilio at FreeBSD.org Sun Apr 13 01:20:48 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Sun Apr 13 01:20:52 2008 Subject: cvs commit: src/sys/kern subr_witness.c src/sys/sys lock.h Message-ID: <200804130120.m3D1KlqH058906@repoman.freebsd.org> attilio 2008-04-13 01:20:47 UTC FreeBSD src repository Modified files: sys/kern subr_witness.c sys/sys lock.h Log: struct lock_instance and struct lock_list_entry don't need to be in the public namespace for WITNESS as they are only used internally so just move them in the private namespace for the subsystem (with all related supporting definitions). Revision Changes Path 1.246 +34 -0 src/sys/kern/subr_witness.c 1.72 +1 -34 src/sys/sys/lock.h From attilio at FreeBSD.org Sun Apr 13 01:21:57 2008 From: attilio at FreeBSD.org (Attilio Rao) Date: Sun Apr 13 01:22:05 2008 Subject: cvs commit: src/sys/kern kern_lock.c Message-ID: <200804130121.m3D1LuQv058951@repoman.freebsd.org> attilio 2008-04-13 01:21:56 UTC FreeBSD src repository Modified files: sys/kern kern_lock.c Log: Use a "rel" memory barrier for disowning the lock as it cames from an exclusive locking operation. Revision Changes Path 1.132 +1 -1 src/sys/kern/kern_lock.c From qingli at FreeBSD.org Sun Apr 13 05:45:15 2008 From: qingli at FreeBSD.org (Qing Li) Date: Sun Apr 13 05:45:20 2008 Subject: cvs commit: src/sys/conf files options src/sys/net radix.c radix.h route.c route.h rtsock.c src/sys/netinet in_proto.c ip_output.c src/sys/netinet6 in6_proto.c in6_src.c nd6_nbr.c Message-ID: <200804130545.m3D5jEtd081771@repoman.freebsd.org> qingli 2008-04-13 05:45:14 UTC FreeBSD src repository Modified files: sys/conf files options sys/net radix.c radix.h route.c route.h rtsock.c sys/netinet in_proto.c ip_output.c sys/netinet6 in6_proto.c in6_src.c nd6_nbr.c Log: This patch provides the back end support for equal-cost multi-path (ECMP) for both IPv4 and IPv6. Previously, multipath route insertion is disallowed. For example, route add -net 192.103.54.0/24 10.9.44.1 route add -net 192.103.54.0/24 10.9.44.2 The second route insertion will trigger an error message of "add net 192.103.54.0/24: gateway 10.2.5.2: route already in table" Multiple default routes can also be inserted. Here is the netstat output: default 10.2.5.1 UGS 0 3074 bge0 => default 10.2.5.2 UGS 0 0 bge0 When multipath routes exist, the "route delete" command requires a specific gateway to be specified or else an error message would be displayed. For example, route delete default would fail and trigger the following error message: "route: writing to routing socket: No such process" "delete net default: not in table" On the other hand, route delete default 10.2.5.2 would be successful: "delete net default: gateway 10.2.5.2" One does not have to specify a gateway if there is only a single route for a particular destination. I need to perform more testings on address aliases and multiple interfaces that have the same IP prefixes. This patch as it stands today is not yet ready for prime time. Therefore, the ECMP code fragments are fully guarded by the RADIX_MPATH macro. Include the "options RADIX_MPATH" in the kernel configuration to enable this feature. Reviewed by: robert, sam, gnn, julian, kmacy Revision Changes Path 1.1289 +1 -0 src/sys/conf/files 1.625 +1 -0 src/sys/conf/options 1.39 +22 -0 src/sys/net/radix.c 1.27 +1 -0 src/sys/net/radix.h 1.127 +121 -1 src/sys/net/route.c 1.69 +3 -0 src/sys/net/route.h 1.145 +20 -0 src/sys/net/rtsock.c 1.88 +8 -0 src/sys/netinet/in_proto.c 1.280 +9 -0 src/sys/netinet/ip_output.c 1.49 +8 -0 src/sys/netinet6/in6_proto.c 1.50 +9 -0 src/sys/netinet6/in6_src.c 1.50 +14 -0 src/sys/netinet6/nd6_nbr.c From qingli at FreeBSD.org Sun Apr 13 06:12:14 2008 From: qingli at FreeBSD.org (Qing Li) Date: Sun Apr 13 06:12:15 2008 Subject: cvs commit: src/sys/net radix_mpath.c radix_mpath.h Message-ID: <200804130612.m3D6CDcm083732@repoman.freebsd.org> qingli 2008-04-13 06:12:13 UTC FreeBSD src repository Added files: sys/net radix_mpath.c radix_mpath.h Log: These files handle the radix tree for the ECMP routes. The original code from KAME did not take care of address aliases or multiple ip addresses that have the same prefix. Reviewed by: rwatson, gnn, sam, kmacy, julian Revision Changes Path 1.1 +334 -0 src/sys/net/radix_mpath.c (new) 1.1 +62 -0 src/sys/net/radix_mpath.h (new) From nyan at FreeBSD.org Sun Apr 13 06:18:35 2008 From: nyan at FreeBSD.org (Takahashi Yoshihiro) Date: Sun Apr 13 06:18:41 2008 Subject: cvs commit: src/sys/conf files.pc98 src/sys/pc98/conf GENERIC.hints src/sys/pc98/cbus clock.c Message-ID: <200804130618.m3D6IYB9083996@repoman.freebsd.org> nyan 2008-04-13 06:18:34 UTC FreeBSD src repository Modified files: sys/conf files.pc98 sys/pc98/conf GENERIC.hints sys/pc98/cbus clock.c Log: MFi386: RTC related cleanups. - Use generic RTC handling code. - Make clock_if.m and subr_rtc.c standard. - Nuke MD inittodr(), resettodr() functions. - Add new "pcrtc" device driver. - Add hints for "pcrtc" driver. Revision Changes Path 1.360 +2 -0 src/sys/conf/files.pc98 1.167 +214 -141 src/sys/pc98/cbus/clock.c 1.27 +2 -0 src/sys/pc98/conf/GENERIC.hints From imp at FreeBSD.org Sun Apr 13 06:25:44 2008 From: imp at FreeBSD.org (Warner Losh) Date: Sun Apr 13 06:25:54 2008 Subject: cvs commit: src/sys/conf Makefile.mips files.mips ldscript.mips ldscript.mips.cfe options.mips Message-ID: <200804130625.m3D6PhDV084328@repoman.freebsd.org> imp 2008-04-13 06:25:43 UTC FreeBSD src repository Added files: sys/conf Makefile.mips files.mips ldscript.mips ldscript.mips.cfe options.mips Log: Merge in the mips specific configuration files and such from the merged juniper and mips2 code base. This represents the work of Juniper Engineers, plus Oleksandr Tymoshenko, Wojciech Koszek, Warner Losh, Olivier Houchard, Randall Stewert and others that have contributed to the mips2 and/or mips2-jnpr perforce branches. Revision Changes Path 1.1 +74 -0 src/sys/conf/Makefile.mips (new) 1.1 +105 -0 src/sys/conf/files.mips (new) 1.1 +270 -0 src/sys/conf/ldscript.mips (new) 1.1 +277 -0 src/sys/conf/ldscript.mips.cfe (new) 1.1 +29 -0 src/sys/conf/options.mips (new) From imp at FreeBSD.org Sun Apr 13 07:07:58 2008 From: imp at FreeBSD.org (Warner Losh) Date: Sun Apr 13 07:07:59 2008 Subject: cvs commit: src/sys/mips/conf ADM5120 ADM5120.hints IDT IDT.hints MALTA MALTA.hints QEMU SENTRY5 SENTRY5.hints src/sys/mips/compile .cvsignore Message-ID: <200804130707.m3D77v4C086858@repoman.freebsd.org> imp 2008-04-13 07:07:57 UTC FreeBSD src repository Added files: sys/mips/conf ADM5120 ADM5120.hints IDT IDT.hints MALTA MALTA.hints QEMU SENTRY5 SENTRY5.hints sys/mips/compile .cvsignore Log: FreeBSD/mips port. The FreeBSD/mips port targets mips32, mips64, mips32r2 and mips64r2 (and close relatives) processors. There presently is support for ADMtek ADM5120, A mips 4Kc in a malta board, the RB533 routerboard (based on IDT RC32434) and some preliminary support for sibtye/broadcom designs. Other hardware support will be forthcomcing. This port boots multiuser under gxemul emulating the malta board and also bootstraps on the hardware whose support is forthcoming... Oleksandr Tymoshenko, Wojciech Koszek, Warner Losh, Olivier Houchard, Randall Stewert and others that have contributed to the mips2 and/or mips2-jnpr perforce branches. Juniper contirbuted a generic mips port late in the life cycle of the misp2 branch. Warner Losh merged the mips2 and Juniper code bases, and others list above have worked for the past several months to get to multiuser. In addition, the mips2 work owe a debt to the trail blazing efforts of the original mips branch in perforce done by Juli Mallett. Revision Changes Path 1.1 +1 -0 src/sys/mips/compile/.cvsignore (new) 1.1 +71 -0 src/sys/mips/conf/ADM5120 (new) 1.1 +24 -0 src/sys/mips/conf/ADM5120.hints (new) 1.1 +54 -0 src/sys/mips/conf/IDT (new) 1.1 +22 -0 src/sys/mips/conf/IDT.hints (new) 1.1 +72 -0 src/sys/mips/conf/MALTA (new) 1.1 +5 -0 src/sys/mips/conf/MALTA.hints (new) 1.1 +58 -0 src/sys/mips/conf/QEMU (new) 1.1 +99 -0 src/sys/mips/conf/SENTRY5 (new) 1.1 +5 -0 src/sys/mips/conf/SENTRY5.hints (new) From imp at FreeBSD.org Sun Apr 13 07:22:54 2008 From: imp at FreeBSD.org (Warner Losh) Date: Sun Apr 13 07:23:00 2008 Subject: cvs commit: src/sys/mips/include _bus.h _bus_octeon.h _inttypes.h _limits.h _stdint.h _types.h am29lv081b.h archtype.h asm.h asmacros.h atomic.h bootinfo.h bswap.h bus.h bus_dma.h bus_octeon.h cache.h cache_mipsNN.h cache_r4k.h clock.h clockvar.h ... Message-ID: <200804130722.m3D7Msau087826@repoman.freebsd.org> imp 2008-04-13 07:22:54 UTC FreeBSD src repository Added files: sys/mips/include _bus.h _bus_octeon.h _inttypes.h _limits.h _stdint.h _types.h am29lv081b.h archtype.h asm.h asmacros.h atomic.h bootinfo.h bswap.h bus.h bus_dma.h bus_octeon.h cache.h cache_mipsNN.h cache_r4k.h clock.h clockvar.h cp0.h cpu.h cpufunc.h cpuinfo.h cpuregs.h cputypes.h db_machdep.h defs.h elf.h endian.h exec.h float.h floatingpoint.h fpu.h frame.h gdb_machdep.h hwfunc.h ieee.h ieeefp.h in_cksum.h intr.h intr_machdep.h iodev.h kdb.h limits.h locore.h md_var.h memdev.h metadata.h minidump.h mips_opcode.h mp_watchdog.h mutex.h ns16550.h param.h pcb.h pcb_ext.h pci_cfgreg.h pcpu.h pltfm.h pmap.h pmc_mdep.h ppireg.h proc.h profile.h psl.h pte.h ptrace.h queue.h reg.h regdef.h regnum.h reloc.h resource.h rm7000.h runq.h segments.h setjmp.h sf_buf.h sigframe.h signal.h smp.h stdarg.h sysarch.h timerreg.h trap.h ucontext.h varargs.h vmparam.h Log: FreeBSD/mips port. The FreeBSD/mips port targets mips32, mips64, mips32r2 and mips64r2 (and close relatives) processors. There presently is support for ADMtek ADM5120, A mips 4Kc in a malta board, the RB533 routerboard (based on IDT RC32434) and some preliminary support for sibtye/broadcom designs. Other hardware support will be forthcomcing. This port boots multiuser under gxemul emulating the malta board and also bootstraps on the hardware whose support is forthcoming... Oleksandr Tymoshenko, Wojciech Koszek, Warner Losh, Olivier Houchard, Randall Stewert and others that have contributed to the mips2 and/or mips2-jnpr perforce branches. Juniper contirbuted a generic mips port late in the life cycle of the misp2 branch. Warner Losh merged the mips2 and Juniper code bases, and others list above have worked for the past several months to get to multiuser. In addition, the mips2 work owe a debt to the trail blazing efforts of the original mips branch in perforce done by Juli Mallett. Revision Changes Path 1.1 +49 -0 src/sys/mips/include/_bus.h (new) 1.1 +46 -0 src/sys/mips/include/_bus_octeon.h (new) 1.1 +221 -0 src/sys/mips/include/_inttypes.h (new) 1.1 +100 -0 src/sys/mips/include/_limits.h (new) 1.1 +172 -0 src/sys/mips/include/_stdint.h (new) 1.1 +169 -0 src/sys/mips/include/_types.h (new) 1.1 +111 -0 src/sys/mips/include/am29lv081b.h (new) 1.1 +49 -0 src/sys/mips/include/archtype.h (new) 1.1 +553 -0 src/sys/mips/include/asm.h (new) 1.1 +195 -0 src/sys/mips/include/asmacros.h (new) 1.1 +441 -0 src/sys/mips/include/atomic.h (new) 1.1 +142 -0 src/sys/mips/include/bootinfo.h (new) 1.1 +11 -0 src/sys/mips/include/bswap.h (new) 1.1 +909 -0 src/sys/mips/include/bus.h (new) 1.1 +34 -0 src/sys/mips/include/bus_dma.h (new) 1.1 +883 -0 src/sys/mips/include/bus_octeon.h (new) 1.1 +261 -0 src/sys/mips/include/cache.h (new) 1.1 +67 -0 src/sys/mips/include/cache_mipsNN.h (new) 1.1 +383 -0 src/sys/mips/include/cache_r4k.h (new) 1.1 +39 -0 src/sys/mips/include/clock.h (new) 1.1 +55 -0 src/sys/mips/include/clockvar.h (new) 1.1 +310 -0 src/sys/mips/include/cp0.h (new) 1.1 +564 -0 src/sys/mips/include/cpu.h (new) 1.1 +346 -0 src/sys/mips/include/cpufunc.h (new) 1.1 +120 -0 src/sys/mips/include/cpuinfo.h (new) 1.1 +899 -0 src/sys/mips/include/cpuregs.h (new) 1.1 +38 -0 src/sys/mips/include/cputypes.h (new) 1.1 +99 -0 src/sys/mips/include/db_machdep.h (new) 1.1 +256 -0 src/sys/mips/include/defs.h (new) 1.1 +215 -0 src/sys/mips/include/elf.h (new) 1.1 +146 -0 src/sys/mips/include/endian.h (new) 1.1 +40 -0 src/sys/mips/include/exec.h (new) 1.1 +81 -0 src/sys/mips/include/float.h (new) 1.1 +43 -0 src/sys/mips/include/floatingpoint.h (new) 1.1 +109 -0 src/sys/mips/include/fpu.h (new) 1.1 +138 -0 src/sys/mips/include/frame.h (new) 1.1 +56 -0 src/sys/mips/include/gdb_machdep.h (new) 1.1 +42 -0 src/sys/mips/include/hwfunc.h (new) 1.1 +154 -0 src/sys/mips/include/ieee.h (new) 1.1 +32 -0 src/sys/mips/include/ieeefp.h (new) 1.1 +77 -0 src/sys/mips/include/in_cksum.h (new) 1.1 +94 -0 src/sys/mips/include/intr.h (new) 1.1 +43 -0 src/sys/mips/include/intr_machdep.h (new) 1.1 +33 -0 src/sys/mips/include/iodev.h (new) 1.1 +50 -0 src/sys/mips/include/kdb.h (new) 1.1 +45 -0 src/sys/mips/include/limits.h (new) 1.1 +70 -0 src/sys/mips/include/locore.h (new) 1.1 +72 -0 src/sys/mips/include/md_var.h (new) 1.1 +39 -0 src/sys/mips/include/memdev.h (new) 1.1 +34 -0 src/sys/mips/include/metadata.h (new) 1.1 +46 -0 src/sys/mips/include/minidump.h (new) 1.1 +413 -0 src/sys/mips/include/mips_opcode.h (new) 1.1 +34 -0 src/sys/mips/include/mp_watchdog.h (new) 1.1 +2 -0 src/sys/mips/include/mutex.h (new) 1.1 +194 -0 src/sys/mips/include/ns16550.h (new) 1.1 +196 -0 src/sys/mips/include/param.h (new) 1.1 +82 -0 src/sys/mips/include/pcb.h (new) 1.1 +4 -0 src/sys/mips/include/pcb_ext.h (new) 1.1 +47 -0 src/sys/mips/include/pci_cfgreg.h (new) 1.1 +79 -0 src/sys/mips/include/pcpu.h (new) 1.1 +29 -0 src/sys/mips/include/pltfm.h (new) 1.1 +231 -0 src/sys/mips/include/pmap.h (new) 1.1 +24 -0 src/sys/mips/include/pmc_mdep.h (new) 1.1 +49 -0 src/sys/mips/include/ppireg.h (new) 1.1 +71 -0 src/sys/mips/include/proc.h (new) 1.1 +172 -0 src/sys/mips/include/profile.h (new) 1.1 +54 -0 src/sys/mips/include/psl.h (new) 1.1 +149 -0 src/sys/mips/include/pte.h (new) 1.1 +37 -0 src/sys/mips/include/ptrace.h (new) 1.1 +171 -0 src/sys/mips/include/queue.h (new) 1.1 +78 -0 src/sys/mips/include/reg.h (new) 1.1 +53 -0 src/sys/mips/include/regdef.h (new) 1.1 +203 -0 src/sys/mips/include/regnum.h (new) 1.1 +35 -0 src/sys/mips/include/reloc.h (new) 1.1 +46 -0 src/sys/mips/include/resource.h (new) 1.1 +95 -0 src/sys/mips/include/rm7000.h (new) 1.1 +47 -0 src/sys/mips/include/runq.h (new) 1.1 +40 -0 src/sys/mips/include/segments.h (new) 1.1 +59 -0 src/sys/mips/include/setjmp.h (new) 1.1 +65 -0 src/sys/mips/include/sf_buf.h (new) 1.1 +49 -0 src/sys/mips/include/sigframe.h (new) 1.1 +80 -0 src/sys/mips/include/signal.h (new) 1.1 +43 -0 src/sys/mips/include/smp.h (new) 1.1 +144 -0 src/sys/mips/include/stdarg.h (new) 1.1 +53 -0 src/sys/mips/include/sysarch.h (new) 1.1 +65 -0 src/sys/mips/include/timerreg.h (new) 1.1 +117 -0 src/sys/mips/include/trap.h (new) 1.1 +101 -0 src/sys/mips/include/ucontext.h (new) 1.1 +59 -0 src/sys/mips/include/varargs.h (new) 1.1 +201 -0 src/sys/mips/include/vmparam.h (new) From imp at FreeBSD.org Sun Apr 13 07:27:38 2008 From: imp at FreeBSD.org (Warner Losh) Date: Sun Apr 13 07:27:49 2008 Subject: cvs commit: src/sys/mips/mips autoconf.c busdma_machdep.c cache.c cache_mipsNN.c copystr.S cpu.c db_disasm.c db_interface.c db_trace.c dump_machdep.c elf_machdep.c exception.S fp.S gdb_machdep.c genassym.c in_cksum.c intr_machdep.c locore.S ... Message-ID: <200804130727.m3D7RcPR088078@repoman.freebsd.org> imp 2008-04-13 07:27:38 UTC FreeBSD src repository Added files: sys/mips/mips autoconf.c busdma_machdep.c cache.c cache_mipsNN.c copystr.S cpu.c db_disasm.c db_interface.c db_trace.c dump_machdep.c elf_machdep.c exception.S fp.S gdb_machdep.c genassym.c in_cksum.c intr_machdep.c locore.S machdep.c mainbus.c mem.c mips_subr.c mp_machdep.c nexus.c pm_machdep.c pmap.c psraccess.S stack_machdep.c support.S swtch.S tick.c tlb.S trap.c uio_machdep.c vm_machdep.c Log: FreeBSD/mips port. The FreeBSD/mips port targets mips32, mips64, mips32r2 and mips64r2 (and close relatives) processors. There presently is support for ADMtek ADM5120, A mips 4Kc in a malta board, the RB533 routerboard (based on IDT RC32434) and some preliminary support for sibtye/broadcom designs. Other hardware support will be forthcomcing. This port boots multiuser under gxemul emulating the malta board and also bootstraps on the hardware whose support is forthcoming... Oleksandr Tymoshenko, Wojciech Koszek, Warner Losh, Olivier Houchard, Randall Stewert and others that have contributed to the mips2 and/or mips2-jnpr perforce branches. Juniper contirbuted a generic mips port late in the life cycle of the misp2 branch. Warner Losh merged the mips2 and Juniper code bases, and others list above have worked for the past several months to get to multiuser. In addition, the mips2 work owe a debt to the trail blazing efforts of the original mips branch in perforce done by Juli Mallett. Revision Changes Path 1.1 +112 -0 src/sys/mips/mips/autoconf.c (new) 1.1 +841 -0 src/sys/mips/mips/busdma_machdep.c (new) 1.1 +220 -0 src/sys/mips/mips/cache.c (new) 1.1 +608 -0 src/sys/mips/mips/cache_mipsNN.c (new) 1.1 +148 -0 src/sys/mips/mips/copystr.S (new) 1.1 +328 -0 src/sys/mips/mips/cpu.c (new) 1.1 +392 -0 src/sys/mips/mips/db_disasm.c (new) 1.1 +339 -0 src/sys/mips/mips/db_interface.c (new) 1.1 +77 -0 src/sys/mips/mips/db_trace.c (new) 1.1 +35 -0 src/sys/mips/mips/dump_machdep.c (new) 1.1 +268 -0 src/sys/mips/mips/elf_machdep.c (new) 1.1 +1287 -0 src/sys/mips/mips/exception.S (new) 1.1 +3608 -0 src/sys/mips/mips/fp.S (new) 1.1 +189 -0 src/sys/mips/mips/gdb_machdep.c (new) 1.1 +99 -0 src/sys/mips/mips/genassym.c (new) 1.1 +248 -0 src/sys/mips/mips/in_cksum.c (new) 1.1 +199 -0 src/sys/mips/mips/intr_machdep.c (new) 1.1 +279 -0 src/sys/mips/mips/locore.S (new) 1.1 +557 -0 src/sys/mips/mips/machdep.c (new) 1.1 +343 -0 src/sys/mips/mips/mainbus.c (new) 1.1 +185 -0 src/sys/mips/mips/mem.c (new) 1.1 +48 -0 src/sys/mips/mips/mips_subr.c (new) 1.1 +313 -0 src/sys/mips/mips/mp_machdep.c (new) 1.1 +474 -0 src/sys/mips/mips/nexus.c (new) 1.1 +541 -0 src/sys/mips/mips/pm_machdep.c (new) 1.1 +3229 -0 src/sys/mips/mips/pmap.c (new) 1.1 +196 -0 src/sys/mips/mips/psraccess.S (new) 1.1 +153 -0 src/sys/mips/mips/stack_machdep.c (new) 1.1 +1537 -0 src/sys/mips/mips/support.S (new) 1.1 +650 -0 src/sys/mips/mips/swtch.S (new) 1.1 +369 -0 src/sys/mips/mips/tick.c (new) 1.1 +509 -0 src/sys/mips/mips/tlb.S (new) 1.1 +1815 -0 src/sys/mips/mips/trap.c (new) 1.1 +128 -0 src/sys/mips/mips/uio_machdep.c (new) 1.1 +541 -0 src/sys/mips/mips/vm_machdep.c (new) From imp at FreeBSD.org Sun Apr 13 07:44:56 2008 From: imp at FreeBSD.org (Warner Losh) Date: Sun Apr 13 07:45:03 2008 Subject: cvs commit: src/sys/mips/mips32/adm5120 adm5120_machdep.c adm5120reg.h admpci.c console.c files.adm5120 if_admsw.c if_admswreg.h if_admswvar.h obio.c obiovar.h std.adm5120 uart_bus_adm5120.c uart_cpu_adm5120.c uart_dev_adm5120.c uart_dev_adm5120.h ... Message-ID: <200804130744.m3D7iuVo088948@repoman.freebsd.org> imp 2008-04-13 07:44:55 UTC FreeBSD src repository Added files: sys/mips/mips32/adm5120 adm5120_machdep.c adm5120reg.h admpci.c console.c files.adm5120 if_admsw.c if_admswreg.h if_admswvar.h obio.c obiovar.h std.adm5120 uart_bus_adm5120.c uart_cpu_adm5120.c uart_dev_adm5120.c uart_dev_adm5120.h sys/mips/mips32/idt files.idt idt_machdep.c idtpci.c idtreg.h if_kr.c if_krreg.h obio.c obiovar.h std.idt uart_bus_rc32434.c uart_cpu_rc32434.c sys/mips/mips32/malta files.malta gt.c gt_pci.c gtreg.h gtvar.h malta_machdep.c maltareg.h obio.c obiovar.h std.malta uart_bus_maltausart.c uart_cpu_maltausart.c yamon.c yamon.h sys/mips/mips32/sentry5 files.sentry5 obio.c obiovar.h s5_machdep.c s5reg.h siba_cc.c siba_mips.c siba_sdram.c uart_bus_sbusart.c uart_cpu_sbusart.c Log: FreeBSD/mips port. The FreeBSD/mips port targets mips32, mips64, mips32r2 and mips64r2 (and close relatives) processors. There presently is support for ADMtek ADM5120, A mips 4Kc in a malta board, the RB533 routerboard (based on IDT RC32434) and some preliminary support for sibtye/broadcom designs. Other hardware support will be forthcomcing. This port boots multiuser under gxemul emulating the malta board and also bootstraps on the hardware whose support is forthcoming... Oleksandr Tymoshenko, Wojciech Koszek, Warner Losh, Olivier Houchard, Randall Stewert and others that have contributed to the mips2 and/or mips2-jnpr perforce branches. Juniper contirbuted a generic mips port late in the life cycle of the misp2 branch. Warner Losh merged the mips2 and Juniper code bases, and others list above have worked for the past several months to get to multiuser. In addition, the mips2 work owe a debt to the trail blazing efforts of the original mips branch in perforce done by Juli Mallett. Revision Changes Path 1.1 +157 -0 src/sys/mips/mips32/adm5120/adm5120_machdep.c (new) 1.1 +294 -0 src/sys/mips/mips32/adm5120/adm5120reg.h (new) 1.1 +503 -0 src/sys/mips/mips32/adm5120/admpci.c (new) 1.1 +93 -0 src/sys/mips/mips32/adm5120/console.c (new) 1.1 +11 -0 src/sys/mips/mips32/adm5120/files.adm5120 (new) 1.1 +1339 -0 src/sys/mips/mips32/adm5120/if_admsw.c (new) 1.1 +678 -0 src/sys/mips/mips32/adm5120/if_admswreg.h (new) 1.1 +212 -0 src/sys/mips/mips32/adm5120/if_admswvar.h (new) 1.1 +510 -0 src/sys/mips/mips32/adm5120/obio.c (new) 1.1 +66 -0 src/sys/mips/mips32/adm5120/obiovar.h (new) 1.1 +10 -0 src/sys/mips/mips32/adm5120/std.adm5120 (new) 1.1 +93 -0 src/sys/mips/mips32/adm5120/uart_bus_adm5120.c (new) 1.1 +83 -0 src/sys/mips/mips32/adm5120/uart_cpu_adm5120.c (new) 1.1 +452 -0 src/sys/mips/mips32/adm5120/uart_dev_adm5120.c (new) 1.1 +80 -0 src/sys/mips/mips32/adm5120/uart_dev_adm5120.h (new) 1.1 +8 -0 src/sys/mips/mips32/idt/files.idt (new) 1.1 +188 -0 src/sys/mips/mips32/idt/idt_machdep.c (new) 1.1 +565 -0 src/sys/mips/mips32/idt/idtpci.c (new) 1.1 +153 -0 src/sys/mips/mips32/idt/idtreg.h (new) 1.1 +1615 -0 src/sys/mips/mips32/idt/if_kr.c (new) 1.1 +284 -0 src/sys/mips/mips32/idt/if_krreg.h (new) 1.1 +514 -0 src/sys/mips/mips32/idt/obio.c (new) 1.1 +67 -0 src/sys/mips/mips32/idt/obiovar.h (new) 1.1 +5 -0 src/sys/mips/mips32/idt/std.idt (new) 1.1 +100 -0 src/sys/mips/mips32/idt/uart_bus_rc32434.c (new) 1.1 +85 -0 src/sys/mips/mips32/idt/uart_cpu_rc32434.c (new) 1.1 +9 -0 src/sys/mips/mips32/malta/files.malta (new) 1.1 +131 -0 src/sys/mips/mips32/malta/gt.c (new) 1.1 +723 -0 src/sys/mips/mips32/malta/gt_pci.c (new) 1.1 +126 -0 src/sys/mips/mips32/malta/gtreg.h (new) 1.1 +36 -0 src/sys/mips/mips32/malta/gtvar.h (new) 1.1 +305 -0 src/sys/mips/mips32/malta/malta_machdep.c (new) 1.1 +243 -0 src/sys/mips/mips32/malta/maltareg.h (new) 1.1 +185 -0 src/sys/mips/mips32/malta/obio.c (new) 1.1 +58 -0 src/sys/mips/mips32/malta/obiovar.h (new) 1.1 +9 -0 src/sys/mips/mips32/malta/std.malta (new) 1.1 +98 -0 src/sys/mips/mips32/malta/uart_bus_maltausart.c (new) 1.1 +82 -0 src/sys/mips/mips32/malta/uart_cpu_maltausart.c (new) 1.1 +65 -0 src/sys/mips/mips32/malta/yamon.c (new) 1.1 +93 -0 src/sys/mips/mips32/malta/yamon.h (new) 1.1 +14 -0 src/sys/mips/mips32/sentry5/files.sentry5 (new) 1.1 +187 -0 src/sys/mips/mips32/sentry5/obio.c (new) 1.1 +58 -0 src/sys/mips/mips32/sentry5/obiovar.h (new) 1.1 +241 -0 src/sys/mips/mips32/sentry5/s5_machdep.c (new) 1.1 +58 -0 src/sys/mips/mips32/sentry5/s5reg.h (new) 1.1 +154 -0 src/sys/mips/mips32/sentry5/siba_cc.c (new) 1.1 +113 -0 src/sys/mips/mips32/sentry5/siba_mips.c (new) 1.1 +114 -0 src/sys/mips/mips32/sentry5/siba_sdram.c (new) 1.1 +95 -0 src/sys/mips/mips32/sentry5/uart_bus_sbusart.c (new) 1.1 +82 -0 src/sys/mips/mips32/sentry5/uart_cpu_sbusart.c (new) From remko at FreeBSD.org Sun Apr 13 07:48:06 2008 From: remko at FreeBSD.org (Remko Lodder) Date: Sun Apr 13 07:48:13 2008 Subject: cvs commit: src/sbin/geom/class/journal gjournal.8 Message-ID: <200804130748.m3D7m5iL089110@repoman.freebsd.org> remko 2008-04-13 07:48:05 UTC FreeBSD src repository Modified files: sbin/geom/class/journal gjournal.8 Log: Add missing device in tunefs entry. PR: docs/122702 Submitted by: Yoshihiro Ota MFC After: 3 days Revision Changes Path 1.4 +2 -2 src/sbin/geom/class/journal/gjournal.8 From delphij at FreeBSD.org Sun Apr 13 08:05:09 2008 From: delphij at FreeBSD.org (Xin LI) Date: Sun Apr 13 08:05:13 2008 Subject: cvs commit: src/lib/libc/stdlib strfmon.c Message-ID: <200804130805.m3D858fZ091215@repoman.freebsd.org> delphij 2008-04-13 08:05:08 UTC FreeBSD src repository Modified files: lib/libc/stdlib strfmon.c Log: Use calloc() instaed of zeroing memory ourselves. Revision Changes Path 1.16 +1 -2 src/lib/libc/stdlib/strfmon.c From ceri at submonkey.net Sun Apr 13 10:04:41 2008 From: ceri at submonkey.net (Ceri Davies) Date: Sun Apr 13 10:04:46 2008 Subject: cvs commit: src/sbin/geom/class/journal gjournal.8 In-Reply-To: <200804130748.m3D7m5iL089110@repoman.freebsd.org> References: <200804130748.m3D7m5iL089110@repoman.freebsd.org> Message-ID: <20080413100439.GA72943@submonkey.net> On Sun, Apr 13, 2008 at 07:48:05AM +0000, Remko Lodder wrote: > remko 2008-04-13 07:48:05 UTC > > FreeBSD src repository > > Modified files: > sbin/geom/class/journal gjournal.8 > Log: > Add missing device in tunefs entry. > > PR: docs/122702 > Submitted by: Yoshihiro Ota > MFC After: 3 days > > Revision Changes Path > 1.4 +2 -2 src/sbin/geom/class/journal/gjournal.8 > > http://cvsweb.FreeBSD.org/src/sbin/geom/class/journal/gjournal.8.diff?r1=1.3&r2=1.4 > | --- src/sbin/geom/class/journal/gjournal.8 2007/11/15 06:31:18 1.3 > | +++ src/sbin/geom/class/journal/gjournal.8 2008/04/13 07:48:05 1.4 > | @@ -22,9 +22,9 @@ > | .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > | .\" SUCH DAMAGE. > | .\" > | -.\" $FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/sbin/geom/class/journal/gjournal.8,v 1.3 2007/11/15 06:31:18 ru Exp $ > | +.\" $FreeBSD: /usr/local/www/cvsroot/FreeBSD/src/sbin/geom/class/journal/gjournal.8,v 1.4 2008/04/13 07:48:05 remko Exp $ > | .\" > | -.Dd November 14, 2007 > | +.Dd April 13, 2007 > | .Dt GJOURNAL 8 > | .Os > | .Sh NAME 2008, calling Remko. Remko, come in, Remko... Ceri -- That must be wonderful! I don't understand it at all. -- Moliere -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080413/ae6b15ab/attachment.pgp From bz at FreeBSD.org Sun Apr 13 10:23:01 2008 From: bz at FreeBSD.org (Bjoern A. Zeeb) Date: Sun Apr 13 10:23:03 2008 Subject: cvs commit: src/sys/net route.c Message-ID: <200804131023.m3DAN0IG014483@repoman.freebsd.org> bz 2008-04-13 10:22:59 UTC FreeBSD src repository Modified files: sys/net route.c Log: Fix the build in case RADIX_MPATH is not defined. Revision Changes Path 1.128 +3 -1 src/sys/net/route.c From remko at FreeBSD.org Sun Apr 13 11:05:59 2008 From: remko at FreeBSD.org (Remko Lodder) Date: Sun Apr 13 11:06:06 2008 Subject: cvs commit: src/sbin/geom/class/journal gjournal.8 Message-ID: <200804131105.m3DB5xYR017119@repoman.freebsd.org> remko 2008-04-13 11:05:59 UTC FreeBSD src repository Modified files: sbin/geom/class/journal gjournal.8 Log: I keep taking timemachines to get back in time. Update the year to 2008. Noticed by: ceri Revision Changes Path 1.5 +1 -1 src/sbin/geom/class/journal/gjournal.8 From rpaulo at FreeBSD.org Sun Apr 13 14:34:45 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Sun Apr 13 14:34:52 2008 Subject: cvs commit: src/sys/conf files options src/sys/net radix.c radix.h route.c route.h rtsock.c src/sys/netinet in_proto.c ip_output.c src/sys/netinet6 in6_proto.c in6_src.c nd6_nbr.c In-Reply-To: <200804130545.m3D5jEtd081771@repoman.freebsd.org> References: <200804130545.m3D5jEtd081771@repoman.freebsd.org> Message-ID: <20080413143407.GA973@fnop.net> On Sun, Apr 13, 2008 at 05:45:14AM +0000, Qing Li wrote: > qingli 2008-04-13 05:45:14 UTC > > FreeBSD src repository > > Modified files: > sys/conf files options > sys/net radix.c radix.h route.c route.h rtsock.c > sys/netinet in_proto.c ip_output.c > sys/netinet6 in6_proto.c in6_src.c nd6_nbr.c > Log: > This patch provides the back end support for equal-cost multi-path > (ECMP) for both IPv4 and IPv6. Previously, multipath route insertion > is disallowed. For example, > > route add -net 192.103.54.0/24 10.9.44.1 > route add -net 192.103.54.0/24 10.9.44.2 > > The second route insertion will trigger an error message of > "add net 192.103.54.0/24: gateway 10.2.5.2: route already in table" > > Multiple default routes can also be inserted. Here is the netstat > output: > > default 10.2.5.1 UGS 0 3074 bge0 => > default 10.2.5.2 UGS 0 0 bge0 > > When multipath routes exist, the "route delete" command requires > a specific gateway to be specified or else an error message would > be displayed. For example, > > route delete default > > would fail and trigger the following error message: > > "route: writing to routing socket: No such process" > "delete net default: not in table" > > On the other hand, > > route delete default 10.2.5.2 > > would be successful: "delete net default: gateway 10.2.5.2" > > One does not have to specify a gateway if there is only a single > route for a particular destination. > > I need to perform more testings on address aliases and multiple > interfaces that have the same IP prefixes. This patch as it > stands today is not yet ready for prime time. Therefore, the ECMP > code fragments are fully guarded by the RADIX_MPATH macro. > Include the "options RADIX_MPATH" in the kernel configuration > to enable this feature. > > Reviewed by: robert, sam, gnn, julian, kmacy > > Revision Changes Path > 1.1289 +1 -0 src/sys/conf/files > 1.625 +1 -0 src/sys/conf/options > 1.39 +22 -0 src/sys/net/radix.c > 1.27 +1 -0 src/sys/net/radix.h > 1.127 +121 -1 src/sys/net/route.c > 1.69 +3 -0 src/sys/net/route.h > 1.145 +20 -0 src/sys/net/rtsock.c > 1.88 +8 -0 src/sys/netinet/in_proto.c > 1.280 +9 -0 src/sys/netinet/ip_output.c > 1.49 +8 -0 src/sys/netinet6/in6_proto.c > 1.50 +9 -0 src/sys/netinet6/in6_src.c > 1.50 +14 -0 src/sys/netinet6/nd6_nbr.c Great work, thanks! -- Rui Paulo From rpaulo at FreeBSD.org Sun Apr 13 14:40:03 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Sun Apr 13 14:40:19 2008 Subject: cvs commit: src/sys/dev/acpi_support acpi_asus.c Message-ID: <200804131440.m3DEe3kN036607@repoman.freebsd.org> rpaulo 2008-04-13 14:40:03 UTC FreeBSD src repository Modified files: sys/dev/acpi_support acpi_asus.c Log: Add support for Asus EeePC backlight control. Submitted by: Akira Funahashi MFC after: 1 week Revision Changes Path 1.32 +29 -3 src/sys/dev/acpi_support/acpi_asus.c From freebsd-listen at fabiankeil.de Sun Apr 13 14:53:00 2008 From: freebsd-listen at fabiankeil.de (Fabian Keil) Date: Sun Apr 13 14:53:10 2008 Subject: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h In-Reply-To: <20080412230157.GC44768@alchemy.franken.de> References: <200804121721.m3CHLNqu095189@repoman.freebsd.org> <20080412230157.GC44768@alchemy.franken.de> Message-ID: <20080413164141.63091ef5@fabiankeil.de> Marius Strobl wrote: > On Sat, Apr 12, 2008 at 05:21:23PM +0000, Sren Schmidt wrote: > > sos 2008-04-12 17:21:23 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h > > Log: > > Dont call hw.status recursively. > > > > Spotted by: Marcel Moolenaar > Even with these fixes in place your latest round of ata(4) > changes causes acd0 to disappear on a sparc64 machine for > me. Reverting to ata(4) sources of April 9th fixes these. > Verbose before and after dmesg output is at: > http://people.freebsd.org/~marius/v100_1.txt > http://people.freebsd.org/~marius/v100_2.txt On one of my i386 systems, ad1 (the disk with the root partition) is no longer detected. As acd0 in the dmesg output above, it's configured as slave and the master on the same controller is still detected. With a kernel build a month ago the detection looks like this: atapci0: port 0xa000-0xa007,0xa400-0xa403,0xa800-0xa807,0xac00-0xac03,0xb000-0xb0ff irq 10 at device 14.0 on pci0 atapci0: Reserved 0x100 bytes for rid 0x20 type 4 at 0xb000 atapci0: [MPSAFE] atapci0: [ITHREAD] ata2: on atapci0 atapci0: Reserved 0x8 bytes for rid 0x10 type 4 at 0xa000 atapci0: Reserved 0x4 bytes for rid 0x14 type 4 at 0xa400 ata2: reset tp1 mask=03 ostat0=50 ostat1=00 ata2: stat0=0x50 err=0x01 lsb=0x00 msb=0x00 ata2: stat1=0x00 err=0x01 lsb=0x00 msb=0x00 ata2: reset tp2 stat0=50 stat1=00 devices=0x1 ata2: [MPSAFE] ata2: [ITHREAD] ata3: on atapci0 atapci0: Reserved 0x8 bytes for rid 0x18 type 4 at 0xa800 atapci0: Reserved 0x4 bytes for rid 0x1c type 4 at 0xac00 ata3: reset tp1 mask=03 ostat0=60 ostat1=70 ata3: stat0=0x20 err=0x20 lsb=0x20 msb=0x20 ata3: stat1=0x30 err=0x30 lsb=0x30 msb=0x30 ata3: reset tp2 stat0=20 stat1=30 devices=0x0 ata3: [MPSAFE] ata3: [ITHREAD] isab0: at device 17.0 on pci0 isa0: on isab0 atapci1: port 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xb400-0xb40f at device 17.1 on pci0 atapci1: Reserved 0x10 bytes for rid 0x20 type 4 at 0xb400 ata0: on atapci1 atapci1: Reserved 0x8 bytes for rid 0x10 type 4 at 0x1f0 atapci1: Reserved 0x1 bytes for rid 0x14 type 4 at 0x3f6 ata0: reset tp1 mask=03 ostat0=50 ostat1=50 ata0: stat0=0x00 err=0x01 lsb=0x14 msb=0xeb ata0: stat1=0x50 err=0x01 lsb=0x00 msb=0x00 ata0: reset tp2 stat0=00 stat1=50 devices=0x6 ata0: [MPSAFE] ata0: [ITHREAD] ata1: on atapci1 atapci1: Reserved 0x8 bytes for rid 0x18 type 4 at 0x170 atapci1: Reserved 0x1 bytes for rid 0x1c type 4 at 0x376 ata1: reset tp1 mask=03 ostat0=50 ostat1=50 ata1: stat0=0x00 err=0x01 lsb=0x14 msb=0xeb ata1: stat1=0x00 err=0x01 lsb=0x14 msb=0xeb ata1: reset tp2 stat0=00 stat1=00 devices=0xc ata1: [MPSAFE] ata1: [ITHREAD] [...] ata0-slave: pio=PIO4 wdma=WDMA2 udma=UDMA100 cable=80 wire ata0-master: pio=PIO4 wdma=WDMA2 udma=UDMA66 cable=40 wire acd0: setting PIO4 on 8233A chip acd0: DMA limited to UDMA33, device found non-ATA66 cable acd0: setting UDMA33 on 8233A chip acd0: DVDR drive at ata0 as master acd0: read 8268KB/s (8268KB/s) write 8268KB/s (8268KB/s), 2048KB buffer, UDMA33 acd0: Reads: CDR, CDRW, CDDA stream, DVDROM, DVDR, packet acd0: Writes: CDR, CDRW, DVDR, test write, burnproof acd0: Audio: play, 256 volume levels acd0: Mechanism: ejectable tray, unlocked acd0: Medium: no/blank disc ad1: setting PIO4 on 8233A chip ad1: setting UDMA100 on 8233A chip ad1: 381554MB at ata0-slave UDMA100 ad1: 781422768 sectors [12403536C/1H/63S] 16 sectors/interrupt 1 depth queue ad1: VIA check1 failed ad1: Adaptec check1 failed ad1: LSI (v3) check1 failed ad1: LSI (v2) check1 failed ad1: FreeBSD check1 failed ata1-slave: pio=PIO4 wdma=WDMA2 udma=UDMA33 cable=40 wire ata1-master: pio=PIO4 wdma=WDMA2 udma=UDMA33 cable=40 wire GEOM: new disk ad1 acd1: setting PIO4 on 8233A chip acd1: setting UDMA33 on 8233A chip acd1: CDRW drive at ata1 as master acd1: read 10820KB/s (10820KB/s) write 10820KB/s (10820KB/s), 2048KB buffer, UDMA33 acd1: Reads: CDR, CDRW, CDDA stream, DVDROM, DVDR, packet acd1: Writes: CDR, CDRW, test write, burnproof acd1: Audio: play, 256 volume levels acd1: Mechanism: ejectable tray, unlocked acd1: Medium: DVD 120mm data disc acd2: setting PIO4 on 8233A chip acd2: setting UDMA33 on 8233A chip acd2: CDRW drive at ata1 as slave acd2: read 8958KB/s (6890KB/s) write 8958KB/s (8958KB/s), 8192KB buffer, UDMA33 acd2: Reads: CDR, CDRW, CDDA stream, packet acd2: Writes: CDR, CDRW, test write, burnproof acd2: Audio: play, 256 volume levels acd2: Mechanism: ejectable tray, unlocked acd2: Medium: CD-ROM unknown ata2-master: pio=PIO4 wdma=WDMA2 udma=UDMA100 cable=80 wire ad4: setting PIO4 on HighPoint chip ad4: setting UDMA100 on HighPoint chip ad4: 381554MB at ata2-master UDMA100 ad4: 781422768 sectors [775221C/16H/63S] 16 sectors/interrupt 1 depth queue GEOM: new disk ad4 GEOM_LABEL: Label for provider ad1s1 is ext2fs//12. ad4: HighPoint (v3) check1 failed ad4: HighPoint (v2) check1 failed ad4: Adaptec check1 failed ad4: LSI (v3) check1 failed ad4: LSI (v2) check1 failed ad4: FreeBSD check1 failed ATA PseudoRAID loaded With a kernel from today the line: ata0: reset tp2 stat0=00 stat1=50 devices=0x6 changes to: ata0: reset tp2 stat0=00 stat1=50 devices=0x10002 Note that the slave (ad1) is the missing drive while the master (acd0) is detected later on. Fabian -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 195 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080413/67e3abb6/signature.pgp From sos at FreeBSD.ORG Sun Apr 13 14:55:41 2008 From: sos at FreeBSD.ORG (=?ISO-8859-1?Q?S=F8ren_Schmidt?=) Date: Sun Apr 13 14:55:49 2008 Subject: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h In-Reply-To: <20080413164141.63091ef5@fabiankeil.de> References: <200804121721.m3CHLNqu095189@repoman.freebsd.org> <20080412230157.GC44768@alchemy.franken.de> <20080413164141.63091ef5@fabiankeil.de> Message-ID: <100600C8-451A-4ECA-8586-1C98FFB3F6D2@FreeBSD.ORG> I'm aware of an issue with master/slave comboes, I'll lok into it as soon as I have time. -S?ren On 13Apr, 2008, at 16:41 , Fabian Keil wrote: > Marius Strobl wrote: > >> On Sat, Apr 12, 2008 at 05:21:23PM +0000, Sren Schmidt wrote: >>> sos 2008-04-12 17:21:23 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h >>> Log: >>> Dont call hw.status recursively. >>> >>> Spotted by: Marcel Moolenaar > >> Even with these fixes in place your latest round of ata(4) >> changes causes acd0 to disappear on a sparc64 machine for >> me. Reverting to ata(4) sources of April 9th fixes these. >> Verbose before and after dmesg output is at: >> http://people.freebsd.org/~marius/v100_1.txt >> http://people.freebsd.org/~marius/v100_2.txt > > On one of my i386 systems, ad1 (the disk with > the root partition) is no longer detected. > > As acd0 in the dmesg output above, it's configured > as slave and the master on the same controller is > still detected. > > With a kernel build a month ago the detection looks like this: > > atapci0: port > 0xa000 > -0xa007,0xa400-0xa403,0xa800-0xa807,0xac00-0xac03,0xb000-0xb0ff irq > 10 at device 14.0 on pci0 > atapci0: Reserved 0x100 bytes for rid 0x20 type 4 at 0xb000 > atapci0: [MPSAFE] > atapci0: [ITHREAD] > ata2: on atapci0 > atapci0: Reserved 0x8 bytes for rid 0x10 type 4 at 0xa000 > atapci0: Reserved 0x4 bytes for rid 0x14 type 4 at 0xa400 > ata2: reset tp1 mask=03 ostat0=50 ostat1=00 > ata2: stat0=0x50 err=0x01 lsb=0x00 msb=0x00 > ata2: stat1=0x00 err=0x01 lsb=0x00 msb=0x00 > ata2: reset tp2 stat0=50 stat1=00 devices=0x1 > ata2: [MPSAFE] > ata2: [ITHREAD] > ata3: on atapci0 > atapci0: Reserved 0x8 bytes for rid 0x18 type 4 at 0xa800 > atapci0: Reserved 0x4 bytes for rid 0x1c type 4 at 0xac00 > ata3: reset tp1 mask=03 ostat0=60 ostat1=70 > ata3: stat0=0x20 err=0x20 lsb=0x20 msb=0x20 > ata3: stat1=0x30 err=0x30 lsb=0x30 msb=0x30 > ata3: reset tp2 stat0=20 stat1=30 devices=0x0 > ata3: [MPSAFE] > ata3: [ITHREAD] > isab0: at device 17.0 on pci0 > isa0: on isab0 > atapci1: port > 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xb400-0xb40f at device 17.1 on > pci0 > atapci1: Reserved 0x10 bytes for rid 0x20 type 4 at 0xb400 > ata0: on atapci1 > atapci1: Reserved 0x8 bytes for rid 0x10 type 4 at 0x1f0 > atapci1: Reserved 0x1 bytes for rid 0x14 type 4 at 0x3f6 > ata0: reset tp1 mask=03 ostat0=50 ostat1=50 > ata0: stat0=0x00 err=0x01 lsb=0x14 msb=0xeb > ata0: stat1=0x50 err=0x01 lsb=0x00 msb=0x00 > ata0: reset tp2 stat0=00 stat1=50 devices=0x6 > ata0: [MPSAFE] > ata0: [ITHREAD] > ata1: on atapci1 > atapci1: Reserved 0x8 bytes for rid 0x18 type 4 at 0x170 > atapci1: Reserved 0x1 bytes for rid 0x1c type 4 at 0x376 > ata1: reset tp1 mask=03 ostat0=50 ostat1=50 > ata1: stat0=0x00 err=0x01 lsb=0x14 msb=0xeb > ata1: stat1=0x00 err=0x01 lsb=0x14 msb=0xeb > ata1: reset tp2 stat0=00 stat1=00 > devices=0xc > ata1: [MPSAFE] > ata1: [ITHREAD] > [...] > ata0-slave: pio=PIO4 wdma=WDMA2 udma=UDMA100 cable=80 wire > ata0-master: pio=PIO4 wdma=WDMA2 udma=UDMA66 cable=40 wire > acd0: setting PIO4 on 8233A chip > acd0: DMA limited to UDMA33, device found non-ATA66 cable > acd0: setting UDMA33 on 8233A chip > acd0: DVDR drive at ata0 as master > acd0: read 8268KB/s (8268KB/s) write 8268KB/s (8268KB/s), 2048KB > buffer, UDMA33 > acd0: Reads: CDR, CDRW, CDDA stream, DVDROM, DVDR, packet > acd0: Writes: CDR, CDRW, DVDR, test write, burnproof > acd0: Audio: play, 256 volume levels > acd0: Mechanism: ejectable tray, unlocked > acd0: Medium: no/blank disc > ad1: setting PIO4 on 8233A chip > ad1: setting UDMA100 on 8233A chip > ad1: 381554MB at ata0-slave UDMA100 > ad1: 781422768 sectors [12403536C/1H/63S] 16 sectors/interrupt 1 > depth queue > ad1: VIA check1 failed > ad1: Adaptec check1 failed > ad1: LSI (v3) check1 failed > ad1: LSI (v2) check1 failed > ad1: FreeBSD check1 failed > ata1-slave: pio=PIO4 wdma=WDMA2 udma=UDMA33 cable=40 wire > ata1-master: pio=PIO4 wdma=WDMA2 udma=UDMA33 cable=40 wire > GEOM: new disk ad1 > acd1: setting PIO4 on 8233A chip > acd1: setting UDMA33 on 8233A chip > acd1: CDRW drive at ata1 as master > acd1: read 10820KB/s (10820KB/s) write 10820KB/s (10820KB/s), 2048KB > buffer, UDMA33 > acd1: Reads: CDR, CDRW, CDDA stream, DVDROM, DVDR, packet > acd1: Writes: CDR, CDRW, test write, burnproof > acd1: Audio: play, 256 volume levels > acd1: Mechanism: ejectable tray, unlocked > acd1: Medium: DVD 120mm data disc > acd2: setting PIO4 on 8233A chip > acd2: setting UDMA33 on 8233A chip > acd2: CDRW drive at ata1 as slave > acd2: read 8958KB/s (6890KB/s) write 8958KB/s (8958KB/s), 8192KB > buffer, UDMA33 > acd2: Reads: CDR, CDRW, CDDA stream, packet > acd2: Writes: CDR, CDRW, test write, burnproof > acd2: Audio: play, 256 volume levels > acd2: Mechanism: ejectable tray, unlocked > acd2: Medium: CD-ROM unknown > ata2-master: pio=PIO4 wdma=WDMA2 udma=UDMA100 cable=80 wire > ad4: setting PIO4 on HighPoint chip > ad4: setting UDMA100 on HighPoint chip > ad4: 381554MB at ata2-master UDMA100 > ad4: 781422768 sectors [775221C/16H/63S] 16 sectors/interrupt 1 > depth queue > GEOM: new disk ad4 > GEOM_LABEL: Label for provider ad1s1 is ext2fs//12. > ad4: HighPoint (v3) check1 failed > ad4: HighPoint (v2) check1 failed > ad4: Adaptec check1 failed > ad4: LSI (v3) check1 failed > ad4: LSI (v2) check1 failed > ad4: FreeBSD check1 failed > ATA PseudoRAID loaded > > With a kernel from today the line: > > ata0: reset tp2 stat0=00 stat1=50 devices=0x6 > > changes to: > > ata0: reset tp2 stat0=00 stat1=50 devices=0x10002 > > Note that the slave (ad1) is the missing drive > while the master (acd0) is detected later on. > > Fabian From dwmalone at maths.tcd.ie Sun Apr 13 15:31:26 2008 From: dwmalone at maths.tcd.ie (David Malone) Date: Sun Apr 13 15:31:34 2008 Subject: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h In-Reply-To: <20080413164141.63091ef5@fabiankeil.de> References: <200804121721.m3CHLNqu095189@repoman.freebsd.org> <20080412230157.GC44768@alchemy.franken.de> <20080413164141.63091ef5@fabiankeil.de> Message-ID: <20080413153122.GA12098@walton.maths.tcd.ie> On Sun, Apr 13, 2008 at 04:41:41PM +0200, Fabian Keil wrote: > On one of my i386 systems, ad1 (the disk with > the root partition) is no longer detected. I'm seeing something slightly different. Both disks are detected: ad0: DMA limited to UDMA33, device found non-ATA66 cable ad0: 78167MB at ata0-master UDMA33 ad1: DMA limited to UDMA33, device found non-ATA66 cable ad1: 78167MB at ata0-slave UDMA33 However, the partitions on the second disk are no longer detected. In fact, the bsdlabels for ad0s1 and ad1s1 now look suspiciously similar, and they shouldn't! Could some cross-wiring of GEOMs have happened? David. This is what the label should look like: # /dev/ad1s1: 8 partitions: # size offset fstype [fsize bsize bps/cpg] c: 160086465 0 unused 0 0 # "raw" part, don't edit d: 20971520 16 4.2BSD 2048 16384 28528 This is what it looks like with a kernel from this weekend: sweetums# bsdlabel ad1s1 # /dev/ad1s1: 8 partitions: # size offset fstype [fsize bsize bps/cpg] a: 524288 0 4.2BSD 0 0 0 b: 8333824 524288 swap c: 160071597 0 unused 0 0 # "raw" part, don't edit d: 524288 8858112 4.2BSD 0 0 0 e: 524288 9382400 4.2BSD 0 0 0 f: 20971520 9906688 4.2BSD 0 0 0 g: 129193389 30878208 4.2BSD 2048 16384 28528 This is what the label looks like from ad0s1 sweetums# bsdlabel ad0s1 # /dev/ad0s1: 8 partitions: # size offset fstype [fsize bsize bps/cpg] a: 524288 0 4.2BSD 0 0 0 b: 8333824 524288 swap c: 160071597 0 unused 0 0 # "raw" part, don't edit d: 524288 8858112 4.2BSD 0 0 0 e: 524288 9382400 4.2BSD 0 0 0 f: 20971520 9906688 4.2BSD 0 0 0 g: 129193389 30878208 4.2BSD 2048 16384 28528 From rwatson at FreeBSD.org Sun Apr 13 16:04:49 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sun Apr 13 16:05:00 2008 Subject: cvs commit: src/sys/conf files.i386 src/sys/i386/conf GENERIC.hints src/sys/i386/isa clock.c In-Reply-To: <200804122046.m3CKk7VE006841@repoman.freebsd.org> References: <200804122046.m3CKk7VE006841@repoman.freebsd.org> Message-ID: <20080413170414.D6735@fledge.watson.org> On Sat, 12 Apr 2008, Poul-Henning Kamp wrote: > Add hints for "atrtc" driver, for non-PnP, non-ACPI systems. > NB: Make sure to install GENERIC.hints into /boot/device.hints in these! May want to add an entry to UPDATING about this (assuming you haven't already). Robert N M Watson Computer Laboratory University of Cambridge From sos at FreeBSD.org Sun Apr 13 16:05:35 2008 From: sos at FreeBSD.org (Søren Schmidt) Date: Sun Apr 13 16:05:43 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-raid.c Message-ID: <200804131605.m3DG5Z9P041647@repoman.freebsd.org> sos 2008-04-13 16:05:34 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.h ata-raid.c Log: Fix identify of slave devices. Revision Changes Path 1.131 +1 -1 src/sys/dev/ata/ata-all.h 1.129 +7 -8 src/sys/dev/ata/ata-raid.c From sos at FreeBSD.ORG Sun Apr 13 16:06:06 2008 From: sos at FreeBSD.ORG (=?ISO-8859-1?Q?S=F8ren_Schmidt?=) Date: Sun Apr 13 16:06:17 2008 Subject: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h In-Reply-To: <20080413153122.GA12098@walton.maths.tcd.ie> References: <200804121721.m3CHLNqu095189@repoman.freebsd.org> <20080412230157.GC44768@alchemy.franken.de> <20080413164141.63091ef5@fabiankeil.de> <20080413153122.GA12098@walton.maths.tcd.ie> Message-ID: Should be fixed now, let me know if it still fails, thanks! -S?ren On 13Apr, 2008, at 17:31 , David Malone wrote: > On Sun, Apr 13, 2008 at 04:41:41PM +0200, Fabian Keil wrote: >> On one of my i386 systems, ad1 (the disk with >> the root partition) is no longer detected. > > I'm seeing something slightly different. Both disks are detected: > > ad0: DMA limited to UDMA33, device found non-ATA66 cable > ad0: 78167MB at ata0-master UDMA33 > ad1: DMA limited to UDMA33, device found non-ATA66 cable > ad1: 78167MB at ata0-slave UDMA33 > > However, the partitions on the second disk are no longer detected. > In fact, the bsdlabels for ad0s1 and ad1s1 now look suspiciously > similar, and they shouldn't! Could some cross-wiring of GEOMs have > happened? > > David. > > This is what the label should look like: > > # /dev/ad1s1: > 8 partitions: > # size offset fstype [fsize bsize bps/cpg] > c: 160086465 0 unused 0 0 # "raw" > part, don't edit > d: 20971520 16 4.2BSD 2048 16384 28528 > > This is what it looks like with a kernel from this weekend: > > sweetums# bsdlabel ad1s1 > # /dev/ad1s1: > 8 partitions: > # size offset fstype [fsize bsize bps/cpg] > a: 524288 0 4.2BSD 0 0 0 > b: 8333824 524288 swap > c: 160071597 0 unused 0 0 # "raw" > part, don't edit > d: 524288 8858112 4.2BSD 0 0 0 > e: 524288 9382400 4.2BSD 0 0 0 > f: 20971520 9906688 4.2BSD 0 0 0 > g: 129193389 30878208 4.2BSD 2048 16384 28528 > > This is what the label looks like from ad0s1 > > sweetums# bsdlabel ad0s1 > # /dev/ad0s1: > 8 partitions: > # size offset fstype [fsize bsize bps/cpg] > a: 524288 0 4.2BSD 0 0 0 > b: 8333824 524288 swap > c: 160071597 0 unused 0 0 # "raw" > part, don't edit > d: 524288 8858112 4.2BSD 0 0 0 > e: 524288 9382400 4.2BSD 0 0 0 > f: 20971520 9906688 4.2BSD 0 0 0 > g: 129193389 30878208 4.2BSD 2048 16384 28528 > From rwatson at FreeBSD.org Sun Apr 13 16:07:17 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sun Apr 13 16:07:38 2008 Subject: cvs commit: src/sys/conf Makefile.mips files.mips ldscript.mips ldscript.mips.cfe options.mips In-Reply-To: <200804130625.m3D6PhDV084328@repoman.freebsd.org> References: <200804130625.m3D6PhDV084328@repoman.freebsd.org> Message-ID: <20080413170629.W6735@fledge.watson.org> On Sun, 13 Apr 2008, Warner Losh wrote: > Merge in the mips specific configuration files and such from the > merged juniper and mips2 code base. This represents the work of > Juniper Engineers, plus Oleksandr Tymoshenko, Wojciech Koszek, Warner > Losh, Olivier Houchard, Randall Stewert and others that have > contributed to the mips2 and/or mips2-jnpr perforce branches. Many congratulations to everyone involved in this project, and many thanks especially to Juniper for donating the base for the MIPS architecture port! Robert N M Watson Computer Laboratory University of Cambridge From ariff at FreeBSD.org Sun Apr 13 16:37:24 2008 From: ariff at FreeBSD.org (Ariff Abdullah) Date: Sun Apr 13 16:37:26 2008 Subject: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h In-Reply-To: References: <200804121721.m3CHLNqu095189@repoman.freebsd.org> <20080412230157.GC44768@alchemy.franken.de> <20080413164141.63091ef5@fabiankeil.de> <20080413153122.GA12098@walton.maths.tcd.ie> Message-ID: <20080414003700.1fe8c346.ariff@FreeBSD.org> On Sun, 13 Apr 2008 18:06:04 +0200 S?ren Schmidt wrote: > Should be fixed now, let me know if it still fails, thanks! > > -S?ren > Still no dice. Since the PM support updates, my drive no longer detected. Nvidia MCP67, AHCI. atapci0: port 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0x30c0-0x30cf at device 6.0 on pci0 ata0: on atapci0 ata0: [ITHREAD] ata1: on atapci0 ata1: [ITHREAD] atapci1: port 0x30f0-0x30f7,0x30e4-0x30e7,0x30e8-0x30ef,0x30e0-0x30e3,0x30d0-0x30df mem 0xf4484000-0xf4485fff irq 18 at device 9.0 on pci0 atapci1: [ITHREAD] atapci1: AHCI Version 01.10 controller with 4 ports detected ata2: on atapci1 ata2: [ITHREAD] ata3: on atapci1 ata3: [ITHREAD] ata4: on atapci1 ata4: [ITHREAD] ata5: on atapci1 ata5: [ITHREAD] acd0: DVDR at ata0-master UDMA33 ad4: 114473MB at ata2-master SATA150 cd0 at ata0 bus 0 target 0 lun 0 -- Ariff Abdullah FreeBSD ... Recording in stereo is obviously too advanced and confusing for us idiot ***** users :P ........ -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 195 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080413/606678ba/attachment.pgp From remko at elvandar.org Sun Apr 13 17:38:54 2008 From: remko at elvandar.org (Remko Lodder) Date: Sun Apr 13 17:39:04 2008 Subject: cvs commit: src/sys/mips/conf ADM5120 ADM5120.hints IDT IDT.hints MALTA MALTA.hints QEMU SENTRY5 SENTRY5.hints src/sys/mips/compile .cvsignore In-Reply-To: <200804130707.m3D77v4C086858@repoman.freebsd.org> References: <200804130707.m3D77v4C086858@repoman.freebsd.org> Message-ID: <48024527.20301@elvandar.org> Warner Losh wrote: > imp 2008-04-13 07:07:57 UTC > > FreeBSD src repository > > Added files: > sys/mips/conf ADM5120 ADM5120.hints IDT IDT.hints MALTA > MALTA.hints QEMU SENTRY5 SENTRY5.hints > sys/mips/compile .cvsignore > Log: > FreeBSD/mips port. The FreeBSD/mips port targets mips32, mips64, > mips32r2 and mips64r2 (and close relatives) processors. There > presently is support for ADMtek ADM5120, A mips 4Kc in a malta board, > the RB533 routerboard (based on IDT RC32434) and some preliminary > support for sibtye/broadcom designs. Other hardware support will be > forthcomcing. > > This port boots multiuser under gxemul emulating the malta board and > also bootstraps on the hardware whose support is forthcoming... > > Oleksandr Tymoshenko, Wojciech Koszek, Warner Losh, Olivier Houchard, > Randall Stewert and others that have contributed to the mips2 and/or > mips2-jnpr perforce branches. Juniper contirbuted a generic mips port > late in the life cycle of the misp2 branch. Warner Losh merged the > mips2 and Juniper code bases, and others list above have worked for > the past several months to get to multiuser. > > In addition, the mips2 work owe a debt to the trail blazing efforts of > the original mips branch in perforce done by Juli Mallett. > Dear all involved, thanks a lot for this very good work! Cheers remko -- /"\ Best regards, | remko@FreeBSD.org \ / Remko Lodder | remko@EFnet X http://www.evilcoder.org/ | / \ ASCII Ribbon Campaign | Against HTML Mail and News From freebsd-listen at fabiankeil.de Sun Apr 13 18:06:42 2008 From: freebsd-listen at fabiankeil.de (Fabian Keil) Date: Sun Apr 13 18:06:51 2008 Subject: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h In-Reply-To: References: <200804121721.m3CHLNqu095189@repoman.freebsd.org> <20080412230157.GC44768@alchemy.franken.de> <20080413164141.63091ef5@fabiankeil.de> <20080413153122.GA12098@walton.maths.tcd.ie> Message-ID: <20080413200630.36ae04c1@fabiankeil.de> S?ren Schmidt wrote: > Should be fixed now, let me know if it still fails, thanks! Thanks a lot for the quick fix, ad1 is indeed back: ata0: reset tp1 mask=03 ostat0=50 ostat1=50 ata0: stat0=0x00 err=0x01 lsb=0x14 msb=0xeb ata0: stat1=0x50 err=0x01 lsb=0x00 msb=0x00 ata0: reset tp2 stat0=00 stat1=50 devices=0x10002 ata0: [MPSAFE] ata0: [ITHREAD] [...] ata0-master: pio=PIO4 wdma=WDMA2 udma=UDMA66 cable=40 wire ata0-slave: pio=PIO4 wdma=WDMA2 udma=UDMA100 cable=80 wire acd0: setting PIO4 on 8233A chip acd0: DMA limited to UDMA33, device found non-ATA66 cable acd0: setting UDMA33 on 8233A chip acd0: DVDR drive at ata0 as master acd0: read 8268KB/s (8268KB/s) write 8268KB/s (8268KB/s), 2048KB buffer, UDMA33 acd0: Reads: CDR, CDRW, CDDA stream, DVDROM, DVDR, packet acd0: Writes: CDR, CDRW, DVDR, test write, burnproof acd0: Audio: play, 256 volume levels acd0: Mechanism: ejectable tray, unlocked acd0: Medium: no/blank disc ad1: setting PIO4 on 8233A chip ad1: setting UDMA100 on 8233A chip ad1: 381554MB at ata0-slave UDMA100 ad1: 781422768 sectors [12403536C/1H/63S] 16 sectors/interrupt 1 depth queue ad1: VIA check1 failed ad1: Adaptec check1 failed ad1: LSI (v3) check1 failed ad1: LSI (v2) check1 failed ad1: FreeBSD check1 failed Interestingly enough, atacontrol doesn't see it: fk@africanqueen ~ $atacontrol list ATA channel 0: Master: acd0 ATA/ATAPI revision 5 Slave: no device present ATA channel 1: Master: acd2 ATA/ATAPI revision 5 Slave: no device present ATA channel 2: Master: ad4 ATA/ATAPI revision 7 Slave: no device present ATA channel 3: Master: no device present Slave: no device present The slave on ata1 isn't shown either: ata1: identify ch->devices=00030000 ata1-master: pio=PIO4 wdma=WDMA2 udma=UDMA33 cable=40 wire ata1-slave: pio=PIO4 wdma=WDMA2 udma=UDMA33 cable=40 wire acd0: FAILURE - INQUIRY ILLEGAL REQUEST asc=0x24 ascq=0x00 (probe0:ata0:0:0:0): error 22 (probe0:ata0:0:0:0): Unretryable Error acd2: setting PIO4 on 8233A chip acd2: setting UDMA33 on 8233A chip GEOM: new disk ad1 acd2: CDRW drive at ata1 as master acd2: read 6890KB/s (6890KB/s) write 6890KB/s (6890KB/s), 2048KB buffer, UDMA33 acd2: Reads: CDR, CDRW, CDDA stream, DVDROM, DVDR, packet acd2: Writes: CDR, CDRW, test write, burnproof acd2: Audio: play, 256 volume levels acd2: Mechanism: ejectable tray, unlocked acd2: Medium: no/blank disc acd3: setting PIO4 on 8233A chip acd3: setting UDMA33 on 8233A chip acd3: CDRW drive at ata1 as slave acd3: read 8958KB/s (6890KB/s) write 8958KB/s (8958KB/s), 8192KB buffer, UDMA33 acd3: Reads: CDR, CDRW, CDDA stream, packet acd3: Writes: CDR, CDRW, test write, burnproof acd3: Audio: play, 256 volume levels acd3: Mechanism: ejectable tray, unlocked acd3: Medium: CD-ROM unknown Fabian -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 195 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080413/fc6bc1fb/signature.pgp From dwmalone at maths.tcd.ie Sun Apr 13 18:36:17 2008 From: dwmalone at maths.tcd.ie (David Malone) Date: Sun Apr 13 18:36:23 2008 Subject: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h In-Reply-To: <20080413200630.36ae04c1@fabiankeil.de> References: <200804121721.m3CHLNqu095189@repoman.freebsd.org> <20080412230157.GC44768@alchemy.franken.de> <20080413164141.63091ef5@fabiankeil.de> <20080413153122.GA12098@walton.maths.tcd.ie> <20080413200630.36ae04c1@fabiankeil.de> Message-ID: <20080413183612.GA15564@walton.maths.tcd.ie> On Sun, Apr 13, 2008 at 08:06:30PM +0200, Fabian Keil wrote: > S?ren Schmidt wrote: > > > Should be fixed now, let me know if it still fails, thanks! > > Thanks a lot for the quick fix, ad1 is indeed back: All good here too - thanks! David. From attilio at freebsd.org Sun Apr 13 19:07:23 2008 From: attilio at freebsd.org (Attilio Rao) Date: Sun Apr 13 19:07:29 2008 Subject: cvs commit: src/sys/conf files.i386 src/sys/i386/conf GENERIC.hints src/sys/i386/isa clock.c In-Reply-To: <200804122046.m3CKk7VE006841@repoman.freebsd.org> References: <200804122046.m3CKk7VE006841@repoman.freebsd.org> Message-ID: <3bbf2fe10804131207n4c9543b2x4cc50c3e9ec0943c@mail.gmail.com> 2008/4/12, Poul-Henning Kamp : > phk 2008-04-12 20:46:07 UTC > > FreeBSD src repository > > Modified files: > sys/conf files.i386 > sys/i386/conf GENERIC.hints > sys/i386/isa clock.c > Log: > Move i386 to generic RTC handling code. > > Make clock_if.m and subr_rtc.c standard on i386 > > Add hints for "atrtc" driver, for non-PnP, non-ACPI systems. > NB: Make sure to install GENERIC.hints into /boot/device.hints in these! > > Nuke MD inittodr(), resettodr() functions. > > Don't attach to PHP0B00 in the "attimer" dummy driver any more, and remove > comments that no longer apply for that reason. > > Add new "atrtc" device driver, which handles IBM PC AT Real Time > Clock compatible devices using subr_rtc and clock_if. > > This driver is not entirely clean: other code still fondles the > hardware to get a statclock interrupt on non-ACPI timer systems. > > Wrap some overly long lines. > > After it has settled in -current, this will be ported to amd64. > > Technically this is MFC'able, but I fail to see a good reason. Very good hint! Thanks. Attilio -- Peace can only be achieved by understanding - A. Einstein From marcel at FreeBSD.org Sun Apr 13 19:54:55 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Sun Apr 13 19:55:03 2008 Subject: cvs commit: src/sbin/geom/class/part geom_part.c src/sys/geom/part g_part.c g_part.h g_part_gpt.c g_part_if.m g_part_mbr.c g_part_pc98.c Message-ID: <200804131954.m3DJssK2083709@repoman.freebsd.org> marcel 2008-04-13 19:54:54 UTC FreeBSD src repository Modified files: sbin/geom/class/part geom_part.c sys/geom/part g_part.c g_part.h g_part_gpt.c g_part_if.m g_part_mbr.c g_part_pc98.c Log: Add the bootcode verb for installing boot code. Boot code is supported for the MBR, GPT and PC98 schemes, where GPT installs boot code into the PMBR. Revision Changes Path 1.5 +47 -3 src/sbin/geom/class/part/geom_part.c 1.17 +66 -2 src/sys/geom/part/g_part.c 1.9 +4 -0 src/sys/geom/part/g_part.h 1.7 +45 -21 src/sys/geom/part/g_part_gpt.c 1.3 +6 -0 src/sys/geom/part/g_part_if.m 1.6 +13 -0 src/sys/geom/part/g_part_mbr.c 1.2 +13 -0 src/sys/geom/part/g_part_pc98.c From Danovitsch at vitsch.net Sun Apr 13 20:14:13 2008 From: Danovitsch at vitsch.net (Daan Vreeken [PA4DAN]) Date: Sun Apr 13 20:14:19 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-raid.c In-Reply-To: <200804131605.m3DG5Z9P041647@repoman.freebsd.org> References: <200804131605.m3DG5Z9P041647@repoman.freebsd.org> Message-ID: <200804132150.33382.Danovitsch@vitsch.net> On Sunday 13 April 2008 18:05:34 S?ren Schmidt wrote: > sos 2008-04-13 16:05:34 UTC > > FreeBSD src repository > > Modified files: > sys/dev/ata ata-all.h ata-raid.c > Log: > Fix identify of slave devices. This fixes the problem I was having with the miss-identified 1TB disk. With the detection fixed, I tried to connect a Port Multiplier with a single disk connected and the disk is correctly detected. Next step : adding more disks ;-) Thanks, -- Daan From alc at FreeBSD.org Sun Apr 13 21:08:35 2008 From: alc at FreeBSD.org (Alan Cox) Date: Sun Apr 13 21:08:45 2008 Subject: cvs commit: src/sys/kern uipc_shm.c Message-ID: <200804132108.m3DL8Zxn097469@repoman.freebsd.org> alc 2008-04-13 21:08:35 UTC FreeBSD src repository Modified files: sys/kern uipc_shm.c Log: Initialize the vm object's flags to include OBJ_NOSPLIT, just like the vm objects that are used by System V shared memory segments. Revision Changes Path 1.4 +4 -0 src/sys/kern/uipc_shm.c From phk at FreeBSD.org Sun Apr 13 21:20:27 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Sun Apr 13 21:20:33 2008 Subject: cvs commit: src/sys/powerpc/booke clock.c src/sys/powerpc/conf MPC85XX Message-ID: <200804132120.m3DLKQtq097864@repoman.freebsd.org> phk 2008-04-13 21:20:26 UTC FreeBSD src repository Modified files: sys/powerpc/booke clock.c sys/powerpc/conf MPC85XX Log: Get rid of an empty RTC implementation and hook up genclock instead. Revision Changes Path 1.3 +0 -44 src/sys/powerpc/booke/clock.c 1.2 +1 -0 src/sys/powerpc/conf/MPC85XX From phk at FreeBSD.org Sun Apr 13 21:38:06 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Sun Apr 13 21:38:10 2008 Subject: cvs commit: src/sys/net radix_mpath.c Message-ID: <200804132138.m3DLc5JA098667@repoman.freebsd.org> phk 2008-04-13 21:38:05 UTC FreeBSD src repository Modified files: sys/net radix_mpath.c Log: Make this compile also on non-IPv6 kernels. Revision Changes Path 1.2 +2 -0 src/sys/net/radix_mpath.c From rwatson at FreeBSD.org Sun Apr 13 21:45:54 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sun Apr 13 21:46:00 2008 Subject: cvs commit: src/sys/security/mac mac_framework.h mac_internal.h mac_policy.h Message-ID: <200804132145.m3DLjrKZ099267@repoman.freebsd.org> rwatson 2008-04-13 21:45:53 UTC FreeBSD src repository Modified files: sys/security/mac mac_framework.h mac_internal.h mac_policy.h Log: Make naming of include guards for MAC Framework include files more consistent with other kernel include guards (don't start with _SYS). MFC after: 3 days Revision Changes Path 1.97 +3 -3 src/sys/security/mac/mac_framework.h 1.124 +3 -3 src/sys/security/mac/mac_internal.h 1.107 +3 -3 src/sys/security/mac/mac_policy.h From imp at FreeBSD.org Sun Apr 13 22:04:56 2008 From: imp at FreeBSD.org (Warner Losh) Date: Sun Apr 13 22:04:58 2008 Subject: cvs commit: src/sys/mips/conf ADM5120 MALTA Message-ID: <200804132204.m3DM4uxu007185@repoman.freebsd.org> imp 2008-04-13 22:04:56 UTC FreeBSD src repository Modified files: sys/mips/conf ADM5120 MALTA Log: fix comments for these files. Noticed by: stass Revision Changes Path 1.2 +1 -1 src/sys/mips/conf/ADM5120 1.2 +1 -1 src/sys/mips/conf/MALTA From rwatson at FreeBSD.org Sun Apr 13 22:06:57 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sun Apr 13 22:07:05 2008 Subject: cvs commit: src/sys/security/audit audit.c audit_arg.c audit_bsm.c audit_bsm_klib.c audit_bsm_token.c audit_pipe.c audit_syscalls.c audit_trigger.c audit_worker.c Message-ID: <200804132206.m3DM6v5N008337@repoman.freebsd.org> rwatson 2008-04-13 22:06:57 UTC FreeBSD src repository Modified files: sys/security/audit audit.c audit_arg.c audit_bsm.c audit_bsm_klib.c audit_bsm_token.c audit_pipe.c audit_syscalls.c audit_trigger.c audit_worker.c Log: Use __FBSDID() for $FreeBSD$ IDs in the audit code. MFC after: 3 days Revision Changes Path 1.41 +3 -2 src/sys/security/audit/audit.c 1.19 +3 -2 src/sys/security/audit/audit_arg.c 1.26 +3 -2 src/sys/security/audit/audit_bsm.c 1.12 +3 -2 src/sys/security/audit/audit_bsm_klib.c 1.15 +3 -2 src/sys/security/audit/audit_bsm_token.c 1.15 +3 -2 src/sys/security/audit/audit_pipe.c 1.26 +3 -2 src/sys/security/audit/audit_syscalls.c 1.8 +3 -2 src/sys/security/audit/audit_trigger.c 1.23 +3 -2 src/sys/security/audit/audit_worker.c From qingli at FreeBSD.org Sun Apr 13 23:04:47 2008 From: qingli at FreeBSD.org (Qing Li) Date: Sun Apr 13 23:04:52 2008 Subject: cvs commit: src/sys/net radix_mpath.c Message-ID: <200804132304.m3DN4k5M011225@repoman.freebsd.org> qingli 2008-04-13 23:04:46 UTC FreeBSD src repository Modified files: sys/net radix_mpath.c Log: Make this file compile on IPv6 kernels. Revision Changes Path 1.3 +2 -0 src/sys/net/radix_mpath.c From pyunyh at gmail.com Mon Apr 14 00:33:46 2008 From: pyunyh at gmail.com (Pyun YongHyeon) Date: Mon Apr 14 00:33:52 2008 Subject: cvs commit: src/sys/conf files options src/sys/net radix.c radix.h route.c route.h rtsock.c src/sys/netinet in_proto.c ip_output.c src/sys/netinet6 in6_proto.c in6_src.c nd6_nbr.c In-Reply-To: <200804130545.m3D5jEtd081771@repoman.freebsd.org> References: <200804130545.m3D5jEtd081771@repoman.freebsd.org> Message-ID: <20080414003337.GA15616@cdnetworks.co.kr> On Sun, Apr 13, 2008 at 05:45:14AM +0000, Qing Li wrote: > qingli 2008-04-13 05:45:14 UTC > > FreeBSD src repository > > Modified files: > sys/conf files options > sys/net radix.c radix.h route.c route.h rtsock.c > sys/netinet in_proto.c ip_output.c > sys/netinet6 in6_proto.c in6_src.c nd6_nbr.c > Log: > This patch provides the back end support for equal-cost multi-path > (ECMP) for both IPv4 and IPv6. Previously, multipath route insertion > is disallowed. For example, > > route add -net 192.103.54.0/24 10.9.44.1 > route add -net 192.103.54.0/24 10.9.44.2 > > The second route insertion will trigger an error message of > "add net 192.103.54.0/24: gateway 10.2.5.2: route already in table" > > Multiple default routes can also be inserted. Here is the netstat > output: > > default 10.2.5.1 UGS 0 3074 bge0 => > default 10.2.5.2 UGS 0 0 bge0 > > When multipath routes exist, the "route delete" command requires > a specific gateway to be specified or else an error message would > be displayed. For example, > > route delete default > > would fail and trigger the following error message: > > "route: writing to routing socket: No such process" > "delete net default: not in table" > > On the other hand, > > route delete default 10.2.5.2 > > would be successful: "delete net default: gateway 10.2.5.2" > > One does not have to specify a gateway if there is only a single > route for a particular destination. > > I need to perform more testings on address aliases and multiple > interfaces that have the same IP prefixes. This patch as it > stands today is not yet ready for prime time. Therefore, the ECMP > code fragments are fully guarded by the RADIX_MPATH macro. > Include the "options RADIX_MPATH" in the kernel configuration > to enable this feature. > > Reviewed by: robert, sam, gnn, julian, kmacy > Nice work! -- Regards, Pyun YongHyeon From pyunyh at gmail.com Mon Apr 14 01:09:04 2008 From: pyunyh at gmail.com (Pyun YongHyeon) Date: Mon Apr 14 01:09:10 2008 Subject: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h In-Reply-To: <968902.70296.qm@web33708.mail.mud.yahoo.com> References: <968902.70296.qm@web33708.mail.mud.yahoo.com> Message-ID: <20080414010849.GF15616@cdnetworks.co.kr> On Wed, Apr 09, 2008 at 12:34:01PM -0700, Abdullah Ibn Hamad Al-Marri wrote: > ----- Original Message ---- > > From: Pyun YongHyeon > > To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; cvs-all@FreeBSD.org > > Sent: Monday, March 31, 2008 7:03:14 AM > > Subject: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h > > > > yongari 2008-03-31 04:03:14 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/re if_re.c > > sys/pci if_rlreg.h > > Log: > > Padding more bytes than necessary one broke another variants of > > PCIe RealTek chips. Only pad IP packets if the payload is less than > > 28 bytes. > > > > Obtained from: NetBSD > > PR: kern/122221 > > > > Revision Changes Path > > 1.113 +1 -1 src/sys/dev/re/if_re.c > > 1.74 +6 -0 src/sys/pci/if_rlreg.h > > Hello Pyun, > > I hope you are doing well. > > This is a friendly reminder... > > It has been more than a week since you said you'll MFC the re changes to RELENG_7 > > I still suffer of the current patch and the re poor performance. > > Thank you in advance, > There was one regression report from remko so we are testing a patch. It seems that the regression is hard to reproduce at will it may take more time. I'll MFC all changes to RELENG_7 as soon as he say Ok. Thanks for remiding this! -- Regards, Pyun YongHyeon From yongari at FreeBSD.org Mon Apr 14 06:21:35 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Mon Apr 14 06:21:47 2008 Subject: cvs commit: src/sys/conf files src/sys/modules/sf Makefile src/sys/dev/sf if_sf.c if_sfreg.h starfire_rx.h starfire_tx.h src/sys/pci if_sf.c if_sfreg.h Message-ID: <200804140621.m3E6LZpR053198@repoman.freebsd.org> yongari 2008-04-14 06:21:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/conf files sys/modules/sf Makefile Added files: (Branch: RELENG_7) sys/dev/sf if_sf.c if_sfreg.h starfire_rx.h starfire_tx.h Removed files: (Branch: RELENG_7) sys/pci if_sf.c if_sfreg.h Log: MFC sf(4) to latest HEAD. o sf(4) repocopied from sys/pci to sys/dev/sf Overhaul sf(4) to make it run on all architectures and implement checksum offoload by downloading AIC-6915 firmware. Changes are o Header file cleanup. o Simplified probe logic. o s/u_int{8,16,32}_t/uint{8,16,32}_t/g o K&R -> ANSI C. o In register access function, added support both memory mapped and IO space register acccess. The function will dynamically detect which method would be choosed. o sf_setperf() was modified to support strict-alignment architectures. o Use SF_MII_DATAPORT instead of hardcoded value 0xffff. o Added link state/speed, duplex changes handling task q. The task q is also responsible for flow control settings. o Always hornor link up/down state reported by mii layers. The link state information is used in sf_start() to determine whether we got a valid link. o Added experimental flow-control setup. It was commented out but will be activated once we have flow-cotrol infrastructure in mii layer. o Simplify IFF_UP/IFCAP_POLLING and IFF_PROMISC handling logic. Rx filter always honors promiscuous mode. o Implemented suspend/resume methods. o Reorganized Rx filter routine so promiscuous mode changes doesn't require interface re-initialization. o Reimplemnted driver probe routine such that it looks for matching device from supported hardware list table. This change will help to add newer hardware revision to the driver. o Use ETHER_ADDR_LEN instead of hardcoded value. o Prefer memory space register mapping over I/O space as the hardware requires lots of register access to get various consumer/producer index. Failing to get memory space mapping, sf(4) falls back to I/O space mapping. Use of memory space register mapping requires somewhat large memory space(512K), though. o Switch to simpler bus_{read,write}_{1,2,4}. o Use PCIR_BAR macro to get BARs. o Program PCI cache line size if the cache line size was set to 0 and enable PCI MWI. o Add a new sysctl node 'dev.sf.N.stats' that shows various MAC counters for Rx/Tx statistics. o Add a sysctl node to configure interrupt moderation timer. The timer defers interrupts generation until time specified in timer control register is expired. The value in the timer register is in units of 102.4us. The allowable range for the timer is 0 - 31 (0 ~ 3.276ms). The default value is 1(102.4us). Users can change the timer value with dev.sf.N.int_mod sysctl(8) variable/loader(8) tunable. o bus_dma(9) conversion - Enable 64bit DMA addressing. - Enable 64bit descriptor format support. - Apply descriptor ring alignment requirements(256 bytes alignment). - Apply Rx buffer address alignment requirements(4 bytes alignment). - Apply 4GB boundary restrictions(Tx/Rx ring and its completion ring should live in the same 4GB address space.) - Set number of allowable number of DMA segments to 16. In fact, AIC-6915 doesn't have a limit for number of DMA segments but it would be waste of Tx descriptor resource if we allow more than 16. - Rx/Tx side bus_dmamap_load_mbuf_sg(9) support. - Added alignment fixup code for strict-alignment architectures. - Added endianness support code in Tx/Rx descriptor access. With these changes sf(4) should work on all platforms. o Don't set if_mtu in device attach, it's handled in ether_ifattach. o Use our own callout to drive watchdog timer. o Enable VLAN oversized frames and announce sf(4)'s VLAN capability to upper layer. o In sf_detach(), remove mtx_initialized KASSERT as it's not possible to get there without initialzing the mutex. Also mark that we're about to detaching so active bpf listeners do not panic the system. o To reduce PCI register access cycles, Rx completion ring is directly scanned instead of reading consumer/producer index registers. In theory, Tx completion ring also can be directly scanned. However the completion ring is composed of two types completion(1 for Tx done and 1 and DMA done). So reading producer index via register access would be more safer way to detect the ring wrap-around. o In sf_rxeof(), don't use m_devget(9) to align recevied frames. The alignment is required only for strict-alignment architectures and now the alignment is handled by sf_fixup_rx() if required. The removal of the copy operation in fast path should increase Rx performance a lot on non-strict-alignemnt architectures such as i386 and amd64. o In sf_newbuf(), don't set descriptor valid bit as sf(4) is programmed to run with normal mode. In normal mode, the valid bit have no meaning. The valid bit should be used only when the hardware uses polling(prefetch) mode. The end of descriptor queue bit could be used if needed, but sf(4) relys on auto-wrapping of hardware on 256 descriptor queue entries so both valid and descriptor end bit are not used anymore. o Don't disable generation of Tx DMA completion as said in datasheet and use the Tx DMA completion entry instead of relying on Tx done completion entry. Also added additional Tx completion entry type check in Tx completion handler. o Don't blindly reset watchdog timer in sf_txeof(). sf(4) now unarm the the watchdog only if there are no active Tx descriptors in Tx queue. o Don't manually update various counters in driver, instead, use built-in MAC statistic registers to update them. The statistic registers are updated in every second. o Modified Tx underrun handlers to increase the threshold value in units of 256 bytes. Previously it used to increase 16 bytes at a time which seems to take too long to stabalize whenever Tx underrun occurrs. o In interrupt handler, additional check for the interrupt is performed such that interrupts only for this device is allowed to process descriptor rings. Because reading SF_ISR register clears all interrtups, nuke writing to a SF_ISR register. o Tx underrun is abonormal condition and SF_ISR_ABNORMALINTR includes the interrupt. So there is no need to inspect the Tx underrun again in main interrupt loop. o Don't blindly reinitialize hardware for abnormal interrupt condition. sf(4) reintializes the hardware only when it encounters DMA error which requires an explicit hardware reinitialization. o Fix a long standing bug that incorrectly clears MAC statistic registers in sf_init_locked. o Added strict-alignment safe way of ethernet address reprogramming as IF_LLADDR may return unaligned address. o Move sf_reset() to sf_init_locked in order to always reset the hardware to a known state prior to configuring hardware. o Set default Rx DMA, Tx DMA paramters as shown in datasheet. o Enable PCI busmaster logic and autopadding for VLAN frames. o Rework sf_encap. - Previously sf(4) used to type 0 of Tx descriptor with padding enabled to store driver private data. Emebedding private data structures into descriptors is bad idea as the structure size would be different between 64bit and 32bit architectures. The type 0 descriptor allows fixed number of DMA segments in a descriptor format and provides relatively simple interface to manage multi-fragmented frames. However, it wastes lots of Tx descriptors as not all frames are fragmented as the number of allowable segments in a descriptor. - To overcome the limitation of type 0 descriptor, switch to type 2 descriptor which allows 64bit DMA addressing and can handle unliumited number of fragmented DMA segments. The drawback of type 2 descriptor is in its complexity in managing descriptors as driver should handle the end of Tx ring manually. - Manually set Tx desciptor queue end mark and record number of used descriptors to reclaim used descriptors in sf_txeof(). o Rework sf_start. - Honor link up/down state before attempting transmission. - Because sf(4) uses only one of two Tx queues, use low priority queue instead of high one. This will remove one shift operation in each Tx kick command. - Cache last produder index into softc such that subsequenet Tx operation doesn't need to access producer index register. o Rewrote sf_stats_update to include all available MAC statistic counters. o Employ AIC-6915 firmware from Adaptec and implement firmware download routine and TCP/UDP checksum offload. Partial checksum offload support was commented out due to the possibility of firmware bug in RxGFP. The firmware can strip VLAN tag in Rx path but the lack of firmware assistance of VLAN tag insertion in transmit side made it useless on FreeBSD. Unlike checksum offload, FreeBSD requires both Tx/Rx hardware VLAN assistance capability. The firmware may also detect wakeup frame and can wake system up from states other than D0. However, the lack of wakeup support form D3cold state keep me from adding WOL capability. Also detecting WOL frame requires firmware support but it's not yet known to me whether the firmware can process the WOL frame. o Changed *_ADDR_HIADDR to *_ADDR_HI to match other definitions of registers. o Added definitioan to interrupt moderation related constants. o Redefined SF_INTRS to include Tx DMA done and DMA errors. Removed Tx done as it's not needed anymore. o Added definition for Rx/Tx DMA high priority threshold. o Nuked unused marco SF_IDX_LO, SF_IDX_HI. o Added complete MAC statistic register definition. o Modified sf_stats structure to hold all MAC statistic regiters. o Nuke various driver private padding data in Tx/Rx descriptor definition. sf(4) no longer requires private padding. Also remove unused padding related definitions. This greatly simplifies descriptor manipulation on 64bit architectures. o Becase we no longer pad driver private data into descriptor, remove deprecated/not-applicable comments for padding. o Redefine Rx/Tx desciptor status. sf(4) doesn't use bit fileds anymore to support endianness. o Import AIC-6915 firmware for GFP from Adaptec. Revision Changes Path 1.1243.2.16 +1 -1 src/sys/conf/files 1.99.2.1 +2716 -0 src/sys/dev/sf/if_sf.c (new) 1.21.2.1 +1104 -0 src/sys/dev/sf/if_sfreg.h (new) 1.1.2.1 +118 -0 src/sys/dev/sf/starfire_rx.h (new) 1.2.2.1 +118 -0 src/sys/dev/sf/starfire_tx.h (new) 1.14.2.1 +1 -1 src/sys/modules/sf/Makefile 1.95.2.2 +0 -1604 src/sys/pci/if_sf.c (dead) 1.19.2.1 +0 -1059 src/sys/pci/if_sfreg.h (dead) From yongari at FreeBSD.org Mon Apr 14 06:25:33 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Mon Apr 14 06:25:35 2008 Subject: cvs commit: src/share/man/man4 vlan.4 Message-ID: <200804140625.m3E6PXOo053385@repoman.freebsd.org> yongari 2008-04-14 06:25:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man4 vlan.4 Log: MFC vlan.4, rev 1.45 to RELENG_7. sf(4) gained VLAN_MTU support. Revision Changes Path 1.44.2.1 +2 -1 src/share/man/man4/vlan.4 From yongari at FreeBSD.org Mon Apr 14 06:28:21 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Mon Apr 14 06:28:26 2008 Subject: cvs commit: src/share/man/man4 sf.4 Message-ID: <200804140628.m3E6SLRJ053484@repoman.freebsd.org> yongari 2008-04-14 06:28:21 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) share/man/man4 sf.4 Log: MFC sf.4 rev 1.25 to RELENG_7. Document two new sysctl variables, dev.sf.%d.int_mod and dev.sf.%d.stats. Xref vlan(4). Revision Changes Path 1.24.2.1 +19 -1 src/share/man/man4/sf.4 From yongari at FreeBSD.org Mon Apr 14 06:30:47 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Mon Apr 14 06:30:54 2008 Subject: cvs commit: src/sys/sparc64/conf GENERIC Message-ID: <200804140630.m3E6Ukpp053659@repoman.freebsd.org> yongari 2008-04-14 06:30:46 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/sparc64/conf GENERIC Log: MFC GENERIC rev 1.131 to RELENG_7. Uncomment sf(4), sf(4) should work on all architectures. Revision Changes Path 1.127.2.5 +1 -1 src/sys/sparc64/conf/GENERIC From phk at FreeBSD.org Mon Apr 14 07:57:15 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Mon Apr 14 07:57:26 2008 Subject: cvs commit: src/sys/isa atrtc.c rtc.h Message-ID: <200804140757.m3E7vF1N058336@repoman.freebsd.org> phk 2008-04-14 07:57:15 UTC FreeBSD src repository Modified files: sys/isa atrtc.c rtc.h Log: atrtc.c is a repocopy of the RTC device driver from i386/isa/clock.c In addition to the device driver functionality, it exposes a number of functions which various other bits of code use to fondle the RTC chip. Revision Changes Path 1.247 +29 -599 src/sys/isa/atrtc.c 1.14 +11 -0 src/sys/isa/rtc.h From phk at FreeBSD.org Mon Apr 14 08:00:01 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Mon Apr 14 08:00:09 2008 Subject: cvs commit: src/sys/amd64/include clock.h src/sys/amd64/isa clock.c src/sys/conf files.amd64 files.i386 src/sys/dev/acpi_support acpi_ibm.c src/sys/dev/fb vga.c src/sys/dev/nvram nvram.c src/sys/i386/include clock.h ... Message-ID: <200804140800.m3E801wf058700@repoman.freebsd.org> phk 2008-04-14 08:00:01 UTC FreeBSD src repository Modified files: sys/amd64/include clock.h sys/amd64/isa clock.c sys/conf files.amd64 files.i386 sys/dev/acpi_support acpi_ibm.c sys/dev/fb vga.c sys/dev/nvram nvram.c sys/i386/include clock.h sys/i386/isa clock.c Log: Convert amd64 and i386 to share the atrtc device driver. Revision Changes Path 1.59 +0 -2 src/sys/amd64/include/clock.h 1.242 +19 -235 src/sys/amd64/isa/clock.c 1.120 +3 -0 src/sys/conf/files.amd64 1.594 +1 -0 src/sys/conf/files.i386 1.16 +1 -1 src/sys/dev/acpi_support/acpi_ibm.c 1.38 +1 -1 src/sys/dev/fb/vga.c 1.2 +0 -1 src/sys/dev/nvram/nvram.c 1.61 +0 -2 src/sys/i386/include/clock.h 1.247 +10 -252 src/sys/i386/isa/clock.c From davidxu at FreeBSD.org Mon Apr 14 08:08:41 2008 From: davidxu at FreeBSD.org (David Xu) Date: Mon Apr 14 08:08:53 2008 Subject: cvs commit: src/lib/libthr/thread thr_rwlock.c Message-ID: <200804140808.m3E88fkP060375@repoman.freebsd.org> davidxu 2008-04-14 08:08:41 UTC FreeBSD src repository Modified files: lib/libthr/thread thr_rwlock.c Log: don't include pthread_np.h, it is not used. Revision Changes Path 1.15 +0 -1 src/lib/libthr/thread/thr_rwlock.c From dfr at FreeBSD.org Mon Apr 14 09:22:48 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Mon Apr 14 09:22:59 2008 Subject: cvs commit: src/sys/fs/smbfs smbfs_vnops.c Message-ID: <200804140922.m3E9MmGX089708@repoman.freebsd.org> dfr 2008-04-14 09:22:48 UTC FreeBSD src repository Modified files: sys/fs/smbfs smbfs_vnops.c Log: When calling lf_advlock to unlock a record, make sure that ap->a_fl->l_type is F_UNLCK otherwise we trigger a LOCKF_DEBUG panic. MFC after: 3 days Revision Changes Path 1.68 +3 -0 src/sys/fs/smbfs/smbfs_vnops.c From cokane at FreeBSD.org Mon Apr 14 13:48:47 2008 From: cokane at FreeBSD.org (Coleman Kane) Date: Mon Apr 14 13:48:58 2008 Subject: cvs commit: src/sys/conf files options src/sys/net radix.c radix.h route.c route.h rtsock.c src/sys/netinet in_proto.c ip_output.c src/sys/netinet6 in6_proto.c in6_src.c nd6_nbr.c In-Reply-To: <20080414003337.GA15616@cdnetworks.co.kr> References: <200804130545.m3D5jEtd081771@repoman.freebsd.org> <20080414003337.GA15616@cdnetworks.co.kr> Message-ID: <1208180897.1279.27.camel@localhost> On Mon, 2008-04-14 at 09:33 +0900, Pyun YongHyeon wrote: > On Sun, Apr 13, 2008 at 05:45:14AM +0000, Qing Li wrote: > > qingli 2008-04-13 05:45:14 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/conf files options > > sys/net radix.c radix.h route.c route.h rtsock.c > > sys/netinet in_proto.c ip_output.c > > sys/netinet6 in6_proto.c in6_src.c nd6_nbr.c > > Log: > > This patch provides the back end support for equal-cost multi-path > > (ECMP) for both IPv4 and IPv6. Previously, multipath route insertion > > is disallowed. For example, > > > > route add -net 192.103.54.0/24 10.9.44.1 > > route add -net 192.103.54.0/24 10.9.44.2 > > > > The second route insertion will trigger an error message of > > "add net 192.103.54.0/24: gateway 10.2.5.2: route already in table" > > > > Multiple default routes can also be inserted. Here is the netstat > > output: > > > > default 10.2.5.1 UGS 0 3074 bge0 => > > default 10.2.5.2 UGS 0 0 bge0 > > > > When multipath routes exist, the "route delete" command requires > > a specific gateway to be specified or else an error message would > > be displayed. For example, > > > > route delete default > > > > would fail and trigger the following error message: > > > > "route: writing to routing socket: No such process" > > "delete net default: not in table" > > > > On the other hand, > > > > route delete default 10.2.5.2 > > > > would be successful: "delete net default: gateway 10.2.5.2" > > > > One does not have to specify a gateway if there is only a single > > route for a particular destination. > > > > I need to perform more testings on address aliases and multiple > > interfaces that have the same IP prefixes. This patch as it > > stands today is not yet ready for prime time. Therefore, the ECMP > > code fragments are fully guarded by the RADIX_MPATH macro. > > Include the "options RADIX_MPATH" in the kernel configuration > > to enable this feature. > > > > Reviewed by: robert, sam, gnn, julian, kmacy > > > > Nice work! > Congrats! Thank you for this. -- Coleman -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 195 bytes Desc: This is a digitally signed message part Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080414/6c4e5a37/attachment.pgp From des at des.no Mon Apr 14 13:53:36 2008 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Mon Apr 14 13:53:50 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-raid.c In-Reply-To: <200804131605.m3DG5Z9P041647@repoman.freebsd.org> (SXren Schmidt's message of "Sun\, 13 Apr 2008 16\:05\:34 +0000 \(UTC\)") References: <200804131605.m3DG5Z9P041647@repoman.freebsd.org> Message-ID: <86k5j01r1f.fsf@ds4.des.no> SXren Schmidt writes: > Log: > Fix identify of slave devices. Speaking of slave devices, why are SATA devices listed as master / slave pairs, instead of each on their own channel? DES -- Dag-Erling Sm?rgrav - des@des.no From sos at FreeBSD.ORG Mon Apr 14 14:10:59 2008 From: sos at FreeBSD.ORG (=?ISO-8859-1?Q?S=F8ren_Schmidt?=) Date: Mon Apr 14 14:11:09 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-raid.c In-Reply-To: <86k5j01r1f.fsf@ds4.des.no> References: <200804131605.m3DG5Z9P041647@repoman.freebsd.org> <86k5j01r1f.fsf@ds4.des.no> Message-ID: Hi They arent, unless your HW runs in legacy emulation mode, then some chipsets emulates master/slave pairs. -S?ren On 14Apr, 2008, at 15:53 , Dag-Erling Sm?rgrav wrote: > SXren Schmidt writes: >> Log: >> Fix identify of slave devices. > > Speaking of slave devices, why are SATA devices listed as master / > slave > pairs, instead of each on their own channel? > > DES > -- > Dag-Erling Sm?rgrav - des@des.no > > From rrs at FreeBSD.org Mon Apr 14 14:32:33 2008 From: rrs at FreeBSD.org (Randall Stewart) Date: Mon Apr 14 14:32:39 2008 Subject: cvs commit: src/sys/netinet sctp_output.c Message-ID: <200804141432.m3EEWXZ6022219@repoman.freebsd.org> rrs 2008-04-14 14:32:32 UTC FreeBSD src repository Modified files: sys/netinet sctp_output.c Log: 1) adds some additional logging 2) changes to use a inqueue_bytes calculated value in max_len calc's. MFC after: 1 week Revision Changes Path 1.68 +106 -1 src/sys/netinet/sctp_output.c From rrs at FreeBSD.org Mon Apr 14 14:33:08 2008 From: rrs at FreeBSD.org (Randall Stewart) Date: Mon Apr 14 14:33:19 2008 Subject: cvs commit: src/sys/netinet sctp_constants.h Message-ID: <200804141433.m3EEX7OA022272@repoman.freebsd.org> rrs 2008-04-14 14:33:07 UTC FreeBSD src repository Modified files: sys/netinet sctp_constants.h Log: New logging values. Revision Changes Path 1.35 +29 -28 src/sys/netinet/sctp_constants.h From rrs at FreeBSD.org Mon Apr 14 14:34:30 2008 From: rrs at FreeBSD.org (Randall Stewart) Date: Mon Apr 14 14:34:37 2008 Subject: cvs commit: src/sys/netinet sctp_indata.c Message-ID: <200804141434.m3EEYTpr022344@repoman.freebsd.org> rrs 2008-04-14 14:34:29 UTC FreeBSD src repository Modified files: sys/netinet sctp_indata.c Log: Protection against errant sender sending a stream seq number out of order with no missing TSN's (a cisco box has this problem which will make a ssn be held forever). MFC after: 1 week Revision Changes Path 1.49 +7 -1 src/sys/netinet/sctp_indata.c From des at des.no Mon Apr 14 15:31:56 2008 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Mon Apr 14 15:32:07 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-raid.c In-Reply-To: (=?utf-8?Q?=22S=C3=B8ren?= Schmidt"'s message of "Mon\, 14 Apr 2008 16\:10\:56 +0200") References: <200804131605.m3DG5Z9P041647@repoman.freebsd.org> <86k5j01r1f.fsf@ds4.des.no> Message-ID: <86fxto1mhi.fsf@ds4.des.no> S?ren Schmidt writes: > They arent, unless your HW runs in legacy emulation mode, then some > chipsets emulates master/slave pairs. Hmm, isn't that a matter of software more than hardware, i.e. the driver switches to "native" mode when FreeBSD boots? Or perhaps I should double-check that the BIOS is set to "AHCI mode"? The hardware is ICH8, except for the DVDR drive which is on a POS JMicron controller: des@ds4 ~% grep \^ata /var/run/dmesg.boot atapci0: mem 0xf9000000-0xf9001fff irq 17 at device 0.0 on pci4 atapci0: [ITHREAD] atapci0: AHCI Version 01.00 controller with 2 ports detected ata2: on atapci0 ata2: [ITHREAD] ata3: on atapci0 ata3: [ITHREAD] atapci1: port 0xa000-0xa007,0xa400-0xa403,0xa800-0xa807,0xac00-0xac03,0xb000-0xb00f irq 18 at device 0.1 on pci4 atapci1: [ITHREAD] ata4: on atapci1 ata4: [ITHREAD] atapci2: port 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xf000-0xf00f,0xfc00-0xfc0f at device 31.2 on pci0 ata0: on atapci2 ata0: [ITHREAD] ata1: on atapci2 ata1: [ITHREAD] atapci3: port 0xd800-0xd807,0xdc00-0xdc03,0xe000-0xe007,0xe400-0xe403,0xe800-0xe80f,0xec00-0xec0f irq 19 at device 31.5 on pci0 atapci3: [ITHREAD] ata5: on atapci3 ata5: [ITHREAD] ata6: on atapci3 ata6: [ITHREAD] des@ds4 ~% sudo atacontrol list ATA channel 0: Master: ad0 Serial ATA v1.0 Slave: ad1 Serial ATA II ATA channel 1: Master: ad2 Serial ATA II Slave: ad3 Serial ATA II ATA channel 2: Master: no device present Slave: no device present ATA channel 3: Master: no device present Slave: no device present ATA channel 4: Master: acd0 ATA/ATAPI revision 6 Slave: no device present ATA channel 5: Master: ad10 Serial ATA II Slave: no device present ATA channel 6: Master: ad12 Serial ATA II Slave: no device present DES -- Dag-Erling Sm?rgrav - des@des.no From sos at FreeBSD.org Mon Apr 14 15:42:38 2008 From: sos at FreeBSD.org (=?ISO-8859-1?Q?S=F8ren_Schmidt?=) Date: Mon Apr 14 15:42:49 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-raid.c In-Reply-To: <86fxto1mhi.fsf@ds4.des.no> References: <200804131605.m3DG5Z9P041647@repoman.freebsd.org> <86k5j01r1f.fsf@ds4.des.no> <86fxto1mhi.fsf@ds4.des.no> Message-ID: Hi You have to set AHCI mode in the BIOS or the resources needed to use it wont be available, so yes its software but not ours :) -S?ren On 14Apr, 2008, at 17:31 , Dag-Erling Sm?rgrav wrote: > S?ren Schmidt writes: >> They arent, unless your HW runs in legacy emulation mode, then some >> chipsets emulates master/slave pairs. > > Hmm, isn't that a matter of software more than hardware, i.e. the > driver > switches to "native" mode when FreeBSD boots? > > Or perhaps I should double-check that the BIOS is set to "AHCI mode"? > > The hardware is ICH8, except for the DVDR drive which is on a POS > JMicron controller: > > des@ds4 ~% grep \^ata /var/run/dmesg.boot > atapci0: mem 0xf9000000-0xf9001fff irq 17 > at device 0.0 on pci4 > atapci0: [ITHREAD] > atapci0: AHCI Version 01.00 controller with 2 ports detected > ata2: on atapci0 > ata2: [ITHREAD] > ata3: on atapci0 > ata3: [ITHREAD] > atapci1: port > 0xa000 > -0xa007,0xa400-0xa403,0xa800-0xa807,0xac00-0xac03,0xb000-0xb00f irq > 18 at device 0.1 on pci4 > atapci1: [ITHREAD] > ata4: on atapci1 > ata4: [ITHREAD] > atapci2: port > 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xf000-0xf00f,0xfc00-0xfc0f at > device 31.2 on pci0 > ata0: on atapci2 > ata0: [ITHREAD] > ata1: on atapci2 > ata1: [ITHREAD] > atapci3: port > 0xd800 > -0xd807,0xdc00-0xdc03,0xe000-0xe007,0xe400-0xe403,0xe800-0xe80f, > 0xec00-0xec0f irq 19 at device 31.5 on pci0 > atapci3: [ITHREAD] > ata5: on atapci3 > ata5: [ITHREAD] > ata6: on atapci3 > ata6: [ITHREAD] > des@ds4 ~% sudo atacontrol list > ATA channel 0: > Master: ad0 Serial ATA v1.0 > Slave: ad1 Serial ATA II > ATA channel 1: > Master: ad2 Serial ATA II > Slave: ad3 Serial ATA II > ATA channel 2: > Master: no device present > Slave: no device present > ATA channel 3: > Master: no device present > Slave: no device present > ATA channel 4: > Master: acd0 ATA/ATAPI revision 6 > Slave: no device present > ATA channel 5: > Master: ad10 Serial ATA II > Slave: no device present > ATA channel 6: > Master: ad12 Serial ATA II > Slave: no device present > > DES > -- > Dag-Erling Sm?rgrav - des@des.no > > From des at des.no Mon Apr 14 16:00:40 2008 From: des at des.no (=?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?=) Date: Mon Apr 14 16:00:48 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-raid.c In-Reply-To: (=?utf-8?Q?=22S=C3=B8ren?= Schmidt"'s message of "Mon\, 14 Apr 2008 17\:42\:36 +0200") References: <200804131605.m3DG5Z9P041647@repoman.freebsd.org> <86k5j01r1f.fsf@ds4.des.no> <86fxto1mhi.fsf@ds4.des.no> Message-ID: <86wsn0zasa.fsf@ds4.des.no> S?ren Schmidt writes: > You have to set AHCI mode in the BIOS or the resources needed to use > it wont be available, so yes its software but not ours :) Thanks S?ren, I will make sure the BIOS is correctly configured. Does this also affect hotswap? I assume that the ICH8 supports it, but I haven't been able to make it work. DES -- Dag-Erling Sm?rgrav - des@des.no From jkim at FreeBSD.org Mon Apr 14 16:50:57 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Mon Apr 14 16:51:02 2008 Subject: cvs commit: src/sys/dev/acpi_support acpi_asus.c Message-ID: <200804141650.m3EGouIP038997@repoman.freebsd.org> jkim 2008-04-14 16:50:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/acpi_support acpi_asus.c Log: MFC: 1.31 - Add ASUS G2K laptop support. - Add DLED and GLED found on newer ASUS laptops. - Turn on BLED, TLED, and WLED by default as other OSes. Revision Changes Path 1.30.2.1 +104 -33 src/sys/dev/acpi_support/acpi_asus.c From sos at FreeBSD.ORG Mon Apr 14 17:09:26 2008 From: sos at FreeBSD.ORG (=?ISO-8859-1?Q?S=F8ren_Schmidt?=) Date: Mon Apr 14 17:09:35 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-raid.c In-Reply-To: <86wsn0zasa.fsf@ds4.des.no> References: <200804131605.m3DG5Z9P041647@repoman.freebsd.org> <86k5j01r1f.fsf@ds4.des.no> <86fxto1mhi.fsf@ds4.des.no> <86wsn0zasa.fsf@ds4.des.no> Message-ID: Hi Yes, the registers used for setting up events when hotswap happens are not accessible when in legacy compat mode. -S?ren On 14Apr, 2008, at 18:00 , Dag-Erling Sm?rgrav wrote: > S?ren Schmidt writes: >> You have to set AHCI mode in the BIOS or the resources needed to use >> it wont be available, so yes its software but not ours :) > > Thanks S?ren, I will make sure the BIOS is correctly configured. > > Does this also affect hotswap? I assume that the ICH8 supports it, > but > I haven't been able to make it work. > > DES > -- > Dag-Erling Sm?rgrav - des@des.no > > From remko at elvandar.org Mon Apr 14 17:35:13 2008 From: remko at elvandar.org (Remko Lodder) Date: Mon Apr 14 17:35:27 2008 Subject: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h In-Reply-To: <20080414010849.GF15616@cdnetworks.co.kr> References: <968902.70296.qm@web33708.mail.mud.yahoo.com> <20080414010849.GF15616@cdnetworks.co.kr> Message-ID: <480395C8.5010003@elvandar.org> Pyun YongHyeon wrote: > On Wed, Apr 09, 2008 at 12:34:01PM -0700, Abdullah Ibn Hamad Al-Marri wrote: > > ----- Original Message ---- > > > From: Pyun YongHyeon > > > To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; cvs-all@FreeBSD.org > > > Sent: Monday, March 31, 2008 7:03:14 AM > > > Subject: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h > > > > > > yongari 2008-03-31 04:03:14 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/re if_re.c > > > sys/pci if_rlreg.h > > > Log: > > > Padding more bytes than necessary one broke another variants of > > > PCIe RealTek chips. Only pad IP packets if the payload is less than > > > 28 bytes. > > > > > > Obtained from: NetBSD > > > PR: kern/122221 > > > > > > Revision Changes Path > > > 1.113 +1 -1 src/sys/dev/re/if_re.c > > > 1.74 +6 -0 src/sys/pci/if_rlreg.h > > > > Hello Pyun, > > > > I hope you are doing well. > > > > This is a friendly reminder... > > > > It has been more than a week since you said you'll MFC the re changes to RELENG_7 > > > > I still suffer of the current patch and the re poor performance. > > > > Thank you in advance, > > > > There was one regression report from remko so we are testing a patch. > It seems that the regression is hard to reproduce at will it may > take more time. I'll MFC all changes to RELENG_7 as soon as he say Ok. > > Thanks for remiding this! Hi all, I think Pyun can MFC the changes where needed / possible because I couldn't trigger it so far. Last time it took me several days to get the machine down, so one never knows when I can reproduce it again. I am getting a new (Second) machine to test this with somewhere this week so that I can 'dedicatedly' test the patch and try to reproduce it even quicker :-) That said; I think the changes made by pyun are a substantial improvement nevertheless and should (Where possible) not be withheld from people :) Pyun please process this when possible :-) Cheers remko -- /"\ Best regards, | remko@FreeBSD.org \ / Remko Lodder | remko@EFnet X http://www.evilcoder.org/ | / \ ASCII Ribbon Campaign | Against HTML Mail and News From rrs at FreeBSD.org Mon Apr 14 18:06:04 2008 From: rrs at FreeBSD.org (Randall Stewart) Date: Mon Apr 14 18:06:08 2008 Subject: cvs commit: src/sys/kern uipc_socket.c src/sys/sys protosw.h socket.h Message-ID: <200804141806.m3EI64St043794@repoman.freebsd.org> rrs 2008-04-14 18:06:04 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c sys/sys protosw.h socket.h Log: Add pru_flush routine so a transport can flush itself during Shutdown MFC after: 1 week Revision Changes Path 1.309 +3 -1 src/sys/kern/uipc_socket.c 1.58 +2 -1 src/sys/sys/protosw.h 1.99 +6 -0 src/sys/sys/socket.h From rrs at FreeBSD.org Mon Apr 14 18:12:38 2008 From: rrs at FreeBSD.org (Randall Stewart) Date: Mon Apr 14 18:12:39 2008 Subject: cvs commit: src/sys/netinet6 sctp6_usrreq.c Message-ID: <200804141812.m3EICbDB044022@repoman.freebsd.org> rrs 2008-04-14 18:12:37 UTC FreeBSD src repository Modified files: sys/netinet6 sctp6_usrreq.c Log: - Have SCTP use the new pru_flush functionality PR: 122710 MFC after: 1 week Revision Changes Path 1.43 +1 -0 src/sys/netinet6/sctp6_usrreq.c From rrs at FreeBSD.org Mon Apr 14 18:13:33 2008 From: rrs at FreeBSD.org (Randall Stewart) Date: Mon Apr 14 18:13:36 2008 Subject: cvs commit: src/sys/netinet sctp_input.c sctp_usrreq.c sctp_var.h Message-ID: <200804141813.m3EIDX6e044085@repoman.freebsd.org> rrs 2008-04-14 18:13:33 UTC FreeBSD src repository Modified files: sys/netinet sctp_input.c sctp_usrreq.c sctp_var.h Log: Use the pru_flush infrastructure to avoid a panic PR: 122710 MFC after: 1 week Revision Changes Path 1.68 +28 -1 src/sys/netinet/sctp_input.c 1.53 +35 -2 src/sys/netinet/sctp_usrreq.c 1.22 +2 -0 src/sys/netinet/sctp_var.h From bu7cher at yandex.ru Mon Apr 14 18:14:25 2008 From: bu7cher at yandex.ru (Andrey V. Elsukov) Date: Mon Apr 14 18:14:36 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-raid.c In-Reply-To: 9060000000209253504 References: <200804131605.m3DG5Z9P041647@repoman.freebsd.org> <86k5j01r1f.fsf@ds4.des.no> 9060000000209253504 Message-ID: <191931208196860@webmail28.yandex.ru> 14.04.08, 18:10, "S?ren Schmidt" : > They arent, unless your HW runs in legacy emulation mode, then some > chipsets emulates master/slave pairs. I see problem here. ata(4) uses atadev->unit==ATA_SLAVE to determine which device is slave, but it never sets atadev->unit to ATA_SLAVE. So, now we have broken `atacontrol list` command. On my old system it doesn't show any of slave devices. Also, it shows "Device not configured" error at the end of its output. -- WBR, Andrey V. Elsukov From sos at FreeBSD.org Mon Apr 14 18:34:25 2008 From: sos at FreeBSD.org (Søren Schmidt) Date: Mon Apr 14 18:34:40 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-chipset.c ata-dma.c ata-lowlevel.c Message-ID: <200804141834.m3EIYOXP044870@repoman.freebsd.org> sos 2008-04-14 18:34:24 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.h ata-chipset.c ata-dma.c ata-lowlevel.c Log: Fix problem with slave devices. Fix or rather bring ENOMEM problems back to the state it was before. Temporarily disable PortMultipliers on AHCI devices. Revision Changes Path 1.132 +1 -1 src/sys/dev/ata/ata-all.h 1.216 +4 -3 src/sys/dev/ata/ata-chipset.c 1.153 +4 -4 src/sys/dev/ata/ata-dma.c 1.82 +7 -8 src/sys/dev/ata/ata-lowlevel.c From obrien at FreeBSD.org Mon Apr 14 18:56:49 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Mon Apr 14 18:56:54 2008 Subject: cvs commit: src/sys/i386/i386 pmap.c Message-ID: <200804141856.m3EIunhj048177@repoman.freebsd.org> obrien 2008-04-14 18:56:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/i386/i386 pmap.c Log: style(9) Revision Changes Path 1.523.2.24 +2 -2 src/sys/i386/i386/pmap.c From ariff at FreeBSD.org Mon Apr 14 19:18:50 2008 From: ariff at FreeBSD.org (Ariff Abdullah) Date: Mon Apr 14 19:18:55 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-chipset.c ata-dma.c ata-lowlevel.c In-Reply-To: <200804141834.m3EIYOXP044870@repoman.freebsd.org> References: <200804141834.m3EIYOXP044870@repoman.freebsd.org> Message-ID: <20080415031825.2a1259ac.ariff@FreeBSD.org> On Mon, 14 Apr 2008 18:34:24 +0000 (UTC) S?ren Schmidt wrote: > sos 2008-04-14 18:34:24 UTC > > FreeBSD src repository > > Modified files: > sys/dev/ata ata-all.h ata-chipset.c ata-dma.c > ata-lowlevel.c > Log: > Fix problem with slave devices. > Fix or rather bring ENOMEM problems back to the state it was > before. Temporarily disable PortMultipliers on AHCI devices. > > Revision Changes Path > 1.132 +1 -1 src/sys/dev/ata/ata-all.h > 1.216 +4 -3 src/sys/dev/ata/ata-chipset.c > 1.153 +4 -4 src/sys/dev/ata/ata-dma.c > 1.82 +7 -8 src/sys/dev/ata/ata-lowlevel.c I can confirm that this fix my issues with MCP67/AHCI. Thanks! -- Ariff Abdullah FreeBSD ... Recording in stereo is obviously too advanced and confusing for us idiot ***** users :P ........ -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 195 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080414/6a79193e/attachment.pgp From rwatson at FreeBSD.org Mon Apr 14 20:15:45 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Mon Apr 14 20:15:54 2008 Subject: cvs commit: src/sys/kern uipc_socket.c src/sys/sys protosw.h socket.h In-Reply-To: <200804141806.m3EI64St043794@repoman.freebsd.org> References: <200804141806.m3EI64St043794@repoman.freebsd.org> Message-ID: <20080414210941.U72408@fledge.watson.org> On Mon, 14 Apr 2008, Randall Stewart wrote: > Add pru_flush routine so a transport can > flush itself during Shutdown > > MFC after: 1 week I'm not sure this is an MFCable change because: (a) The new function pointer is inserted in the middle of the data protosw data structure, changing the interpretation of existing compiled protosw structures. (b) Even if they were at the end of the structure, existing compiled protocols might well have garbage (or un-related data) beyond the end of the data structure, leading to a non-NULL pointer that is not a pointer to a flush function. Robert N M Watson Computer Laboratory University of Cambridge From mckusick at FreeBSD.org Mon Apr 14 20:15:53 2008 From: mckusick at FreeBSD.org (Kirk McKusick) Date: Mon Apr 14 20:16:07 2008 Subject: cvs commit: src/sbin/restore dirs.c Message-ID: <200804142015.m3EKFrDG058555@repoman.freebsd.org> mckusick 2008-04-14 20:15:53 UTC FreeBSD src repository Modified files: sbin/restore dirs.c Log: restore(8) does not check for write failure while building two temp files containing directory and ownership data. If /tmp fills, the console is blasted with zillions of "file system full" errors, and restore continues on, even though directory and/or ownership data has been lost. This is particularly likely to happen when running from the live CD, which has little /tmp space. PR: bin/93603, also probably bin/107213 Fix from: Ken Lalonde Revision Changes Path 1.34 +68 -24 src/sbin/restore/dirs.c From wearabnet at yahoo.ca Mon Apr 14 20:32:43 2008 From: wearabnet at yahoo.ca (Abdullah Ibn Hamad Al-Marri) Date: Mon Apr 14 20:32:49 2008 Subject: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h Message-ID: <869542.84426.qm@web33701.mail.mud.yahoo.com> ----- Original Message ---- > From: Remko Lodder > To: pyunyh@gmail.com > Cc: Abdullah Ibn Hamad Al-Marri ; src-committers@FreeBSD.org; cvs-src@FreeBSD.org > Sent: Monday, April 14, 2008 8:35:04 PM > Subject: Re: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h > > Pyun YongHyeon wrote: > > On Wed, Apr 09, 2008 at 12:34:01PM -0700, Abdullah Ibn Hamad Al-Marri wrote: > > > ----- Original Message ---- > > > > From: Pyun YongHyeon > > > > To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; cvs-all@FreeBSD.org > > > > Sent: Monday, March 31, 2008 7:03:14 AM > > > > Subject: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h > > > > > > > > yongari 2008-03-31 04:03:14 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/dev/re if_re.c > > > > sys/pci if_rlreg.h > > > > Log: > > > > Padding more bytes than necessary one broke another variants of > > > > PCIe RealTek chips. Only pad IP packets if the payload is less than > > > > 28 bytes. > > > > > > > > Obtained from: NetBSD > > > > PR: kern/122221 > > > > > > > > Revision Changes Path > > > > 1.113 +1 -1 src/sys/dev/re/if_re.c > > > > 1.74 +6 -0 src/sys/pci/if_rlreg.h > > > > > > Hello Pyun, > > > > > > I hope you are doing well. > > > > > > This is a friendly reminder... > > > > > > It has been more than a week since you said you'll MFC the re changes to > RELENG_7 > > > > > > I still suffer of the current patch and the re poor performance. > > > > > > Thank you in advance, > > > > > > > There was one regression report from remko so we are testing a patch. > > It seems that the regression is hard to reproduce at will it may > > take more time. I'll MFC all changes to RELENG_7 as soon as he say Ok. > > > > Thanks for remiding this! > > Hi all, > > I think Pyun can MFC the changes where needed / possible because I > couldn't trigger it so far. Last time it took me several days to get > the machine down, so one never knows when I can reproduce it again. I > am getting a new (Second) machine to test this with somewhere this week > so that I can 'dedicatedly' test the patch and try to reproduce it even > quicker :-) > > That said; I think the changes made by pyun are a substantial > improvement nevertheless and should (Where possible) not be withheld > from people :) > > Pyun please process this when possible :-) > > Cheers > remko > > -- > > /"\ Best regards, | remko@FreeBSD.org > \ / Remko Lodder | remko@EFnet > X http://www.evilcoder.org/ | > / \ ASCII Ribbon Campaign | Against HTML Mail and News Thank you Pyun and Remko, I hope it will hit RELENG_7 ASAP. I face connection time out issues with current RELENG_7 patch, beside I get bad packet length when I try sshing to it. Thank you, Regards, -Abdullah Ibn Hamad Al-Marri Arab Portal http://www.WeArab.Net/ ____________________________________________________________________________________ Be a better friend, newshound, and know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ From marcel at FreeBSD.org Mon Apr 14 20:34:45 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Mon Apr 14 20:34:51 2008 Subject: cvs commit: src/sys/ia64/ia64 sapic.c Message-ID: <200804142034.m3EKYjfs059229@repoman.freebsd.org> marcel 2008-04-14 20:34:45 UTC FreeBSD src repository Modified files: sys/ia64/ia64 sapic.c Log: Revision 1.9 changes the delivery mode from the magic constant 0 (i.e. fixed delivery) to SAPIC_DELMODE_LOWPRI. While the commit log doesn't mention the change in behaviour, it is believed to be deliberate. In the last 5.5 years this hasn't been a problem. Nor do I think did it make any difference, but who knows. However, I do know that it break SMP support for Montecito-based machines. Switch back to fixed-CPU delivery so that SMP works again. This gives me some time to look more closely at the problem, as well as make sure the I-cache validation as it's implemented currently is sufficient in SMP configurations... Revision Changes Path 1.15 +1 -1 src/sys/ia64/ia64/sapic.c From niclas.zeising at gmail.com Mon Apr 14 21:57:43 2008 From: niclas.zeising at gmail.com (Niclas Zeising) Date: Mon Apr 14 21:58:09 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-chipset.c ata-dma.c ata-lowlevel.c In-Reply-To: <200804141834.m3EIYOXP044870@repoman.freebsd.org> References: <200804141834.m3EIYOXP044870@repoman.freebsd.org> Message-ID: <4803D34C.4030706@gmail.com> S?ren Schmidt wrote: > sos 2008-04-14 18:34:24 UTC > > FreeBSD src repository > > Modified files: > sys/dev/ata ata-all.h ata-chipset.c ata-dma.c > ata-lowlevel.c > Log: > Fix problem with slave devices. > Fix or rather bring ENOMEM problems back to the state it was before. > Temporarily disable PortMultipliers on AHCI devices. > > Revision Changes Path > 1.132 +1 -1 src/sys/dev/ata/ata-all.h > 1.216 +4 -3 src/sys/dev/ata/ata-chipset.c > 1.153 +4 -4 src/sys/dev/ata/ata-dma.c > 1.82 +7 -8 src/sys/dev/ata/ata-lowlevel.c Hi! I still have problems with my install blowing up with the panic message "to many DMA segment entries". I haven't tried this last change though. Unfortunately I can't send a decent backtrace since doing "call doadump" fom ddb only makes the machine panic again. The panic occurs when trying to do a installworld, probably because of high disc I/O. The march snapshot doesn't inhibit this problem. I can at least do a cvsup followed by a buildworld and make kernel. The harddrive is a 114473MB Hitachi SATA150 drive, in my system on ad8 (ata4-master). The bios runs sata in native mode. The controller is an Intel AHCI controller. I've compiled a custom kernel (removed raid and scsi devices I don't use, along with ethernet devices I don't use, and added sound device and crypto device as well as GEOM_ELI and GEOM_BDE. Also removed some compat options. Everything is compiled with standard options except cputype?=core2. The machine runs amd64. The following is the hand-transcribed backtrace from the panic: panic: too many DMA segment entries cpuid = 1 KDB: stack backtrace: db_trace_self_wrappoer() at db_trace_self_wrapper+0x2a panic() at panic+0x173 ata_setup_interrupt at ata_setup_interrupt bus_dmamap_load() at ata_dmaload+0x17e ata_ahci_begin_transaction() at ata_ahci_begin_transaction+0x1f9 ata_start() at ata_start+0x1a4 g_io_schedule_up() at g_io_schedule_up+0x4d g_up_procvody() at g_up_procbody+0x6f fork_exit() at fork_exit+0x12a fork_trampoline at fork_trampoline+0xe --- trap 0, rip = 0 rsp = 0xffffffffab899d30, rbp = 0 --- KDB: enter: panic [thread pid 3 tid 100009 ] Stopped at kdb_enter+0x3d: movq $0,0x4060f6(%rip) db> show locs exclusive sleep mutex ATA state lock r = 0 (0xffffff000130a78) locked @ /usr/src/sys/dev/ata/ata-queue.c:192 exclusive sleep mutex ATA queue lock r = 0 (0xffffff0001303ab0 locked @ /usr/src/sys/dev/ata/ata-queue.c:175 Then I try 'call doadump' and get the following panic. Don't know if it's because of the earlier one or if it's another bug. Probably the former, but I include the transcription anyway. db> call doadump Physical memory: 1998MB Dumping 132MB:panic: _mtx_lock_sleep: recursed on non-recursive mutex ATA queue lock @ /usr/src/sys/dev/ata/ata-queue.c:86 cpuid = 1 KDB: stack backtrace: db_trace_self_wrapper at db_trace_self_wrapper+0x2a mi_switch() at mi_switch+0x363 sched_bind() at sched_bind+0x78 boot() at boot+0x3f panic() at panic+0x15d _mtx_lock_flags() at _mtx_lock_flags _mtx_lock_flags() at _mtx_lock_flags+0xc0 ata_queue_request() at ata_queue_request+0x9a ad_dump() at ad_dump+0x90 minidumpsys() at minidumpsys+0x23 dumpsys() at dumpsys+0x23 doadump() at doadump()+0x49 db_fncall() at db_fncall+0x88 db_command() at db_command+0x1eb db_command_loop() at db_command_loop+0x50 db_trap() at db_trap+0x87 kdb_trap() at kdb_trap+0x82 trap() at trap+0x159 calltrap() at calltrap+0x8 --- trap 0x3, rip = 0xffffffff80305aaf, rsp = 0xffffffffab899940, rbp = 0xffffffffab099960 --- kdb_enter() at kdb_enter+0x3d panic() at panic+0x16c ata_setup_interrupt() at ata_setup_interrupt bus_dmamap_load() at bus_dmamap_load+0x353 ata_dmaload() at ata_dmaload+0x17e ata_ahci_begin_transaction() at ata_ahci_begin_transaction+0x1f9 ata_start() at ata_start+0x1a4 g_io_schedule_up() at g_io_schedule_up+0x4d g_up_procbody() at g_up_procbody+0x6f fork_exit() at fork_exit+0x12a fork_trampoline() at fork_trampoline+0xe --- trap 0, rip = 0, rsp = 0xffffffffab899d30, rbp = 0 --- That's pretty much all I can get for now. Tell me if you need more information. Regards! Niclas Zeising From andre at freebsd.org Mon Apr 14 22:43:47 2008 From: andre at freebsd.org (Andre Oppermann) Date: Mon Apr 14 22:43:53 2008 Subject: cvs commit: src/sys/conf files options src/sys/net radix.c radix.h route.c route.h rtsock.c src/sys/netinet in_proto.c ip_output.c src/sys/netinet6 in6_proto.c in6_src.c nd6_nbr.c In-Reply-To: <200804130545.m3D5jEtd081771@repoman.freebsd.org> References: <200804130545.m3D5jEtd081771@repoman.freebsd.org> Message-ID: <4803D7E2.80000@freebsd.org> Qing Li wrote: > qingli 2008-04-13 05:45:14 UTC > > FreeBSD src repository > > Modified files: > sys/conf files options > sys/net radix.c radix.h route.c route.h rtsock.c > sys/netinet in_proto.c ip_output.c > sys/netinet6 in6_proto.c in6_src.c nd6_nbr.c > Log: > This patch provides the back end support for equal-cost multi-path > (ECMP) for both IPv4 and IPv6. Previously, multipath route insertion Nice! Long overdue that we get this functionality. :-) Do you do hash-based next-hop balancing ("flow"-aware) or packet based round robin? Should it be made an option to switch between them (globally) like on Cisco routers? > is disallowed. For example, > > route add -net 192.103.54.0/24 10.9.44.1 > route add -net 192.103.54.0/24 10.9.44.2 > > The second route insertion will trigger an error message of > "add net 192.103.54.0/24: gateway 10.2.5.2: route already in table" Would it make sense to retain this behavior by default (POLA) and have multi-path being enabled via sysctl like packet forwarding in general? Just adding the same route twice with different next-hops can lead to very confusing situations for the users which are not used to multi-path. > Multiple default routes can also be inserted. Here is the netstat > output: > > default 10.2.5.1 UGS 0 3074 bge0 => > default 10.2.5.2 UGS 0 0 bge0 > > When multipath routes exist, the "route delete" command requires > a specific gateway to be specified or else an error message would > be displayed. For example, > > route delete default > > would fail and trigger the following error message: > > "route: writing to routing socket: No such process" > "delete net default: not in table" Can this be made more descriptive? This messages are about as confusing and non-descript as possible. Not being aware of the multipath functionality I would pull out my last hair try to get rid of a route. > On the other hand, > > route delete default 10.2.5.2 > > would be successful: "delete net default: gateway 10.2.5.2" > > One does not have to specify a gateway if there is only a single > route for a particular destination. > > I need to perform more testings on address aliases and multiple > interfaces that have the same IP prefixes. This patch as it > stands today is not yet ready for prime time. Therefore, the ECMP > code fragments are fully guarded by the RADIX_MPATH macro. > Include the "options RADIX_MPATH" in the kernel configuration > to enable this feature. How does this behave with common routing daemons; Quagga/Zebra, OpenBGPD, OpenOSPFD? Do they have to be aware of the multipath functionality? Will it confuse them? What about the other big missing piece; new-arp? ;-) Something for BSDCan? -- Andre From yongari at FreeBSD.org Tue Apr 15 00:46:16 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Tue Apr 15 00:46:22 2008 Subject: cvs commit: src/sys/dev/re if_re.c Message-ID: <200804150046.m3F0kGxL082409@repoman.freebsd.org> yongari 2008-04-15 00:46:15 UTC FreeBSD src repository Modified files: sys/dev/re if_re.c Log: Don't touch MSI enable bit in RL_CFG2 register. For unknown reason clearing MSI enable bit for MSI capable hardwares resulted in Tx problems. MSI enable bit is set only when MSI is requested from user. Tested by: remko Revision Changes Path 1.114 +6 -12 src/sys/dev/re/if_re.c From jkim at FreeBSD.org Tue Apr 15 00:50:02 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Tue Apr 15 00:50:12 2008 Subject: cvs commit: src/sys/net bpf.c Message-ID: <200804150050.m3F0o1aV091591@repoman.freebsd.org> jkim 2008-04-15 00:50:01 UTC FreeBSD src repository Modified files: sys/net bpf.c Log: Remove M_SKIP_FIREWALL abuse and add more appropriate check. Pointyhat to: jkim Reported by: Eugene Grosbein (eugen at kuzbass dot ru) MFC after: 3 days Revision Changes Path 1.192 +11 -20 src/sys/net/bpf.c From pyunyh at gmail.com Tue Apr 15 00:51:46 2008 From: pyunyh at gmail.com (Pyun YongHyeon) Date: Tue Apr 15 00:51:51 2008 Subject: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h In-Reply-To: <480395C8.5010003@elvandar.org> References: <968902.70296.qm@web33708.mail.mud.yahoo.com> <20080414010849.GF15616@cdnetworks.co.kr> <480395C8.5010003@elvandar.org> Message-ID: <20080415005136.GA19926@cdnetworks.co.kr> On Mon, Apr 14, 2008 at 07:35:04PM +0200, Remko Lodder wrote: > Pyun YongHyeon wrote: > >On Wed, Apr 09, 2008 at 12:34:01PM -0700, Abdullah Ibn Hamad Al-Marri > >wrote: > > > ----- Original Message ---- > > > > From: Pyun YongHyeon > > > > To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; > > cvs-all@FreeBSD.org > > > > Sent: Monday, March 31, 2008 7:03:14 AM > > > > Subject: cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h > > > > > > > > yongari 2008-03-31 04:03:14 UTC > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/dev/re if_re.c > > > > sys/pci if_rlreg.h > > > > Log: > > > > Padding more bytes than necessary one broke another variants of > > > > PCIe RealTek chips. Only pad IP packets if the payload is less than > > > > 28 bytes. > > > > > > > > Obtained from: NetBSD > > > > PR: kern/122221 > > > > > > > > Revision Changes Path > > > > 1.113 +1 -1 src/sys/dev/re/if_re.c > > > > 1.74 +6 -0 src/sys/pci/if_rlreg.h > > > > > > Hello Pyun, > > > > > > I hope you are doing well. > > > > > > This is a friendly reminder... > > > > > > It has been more than a week since you said you'll MFC the re changes > > to RELENG_7 > > > > > > I still suffer of the current patch and the re poor performance. > > > > > > Thank you in advance, > > > > > > >There was one regression report from remko so we are testing a patch. > >It seems that the regression is hard to reproduce at will it may > >take more time. I'll MFC all changes to RELENG_7 as soon as he say Ok. > > > >Thanks for remiding this! > > Hi all, > > I think Pyun can MFC the changes where needed / possible because I > couldn't trigger it so far. Last time it took me several days to get > the machine down, so one never knows when I can reproduce it again. I > am getting a new (Second) machine to test this with somewhere this week > so that I can 'dedicatedly' test the patch and try to reproduce it even > quicker :-) > > That said; I think the changes made by pyun are a substantial > improvement nevertheless and should (Where possible) not be withheld > from people :) > > Pyun please process this when possible :-) > First, I'll commit the patch you tested and wait a couple of days before MFCing re(4) to RELENG_7. Thanks for all your hardwork and continuous support! -- Regards, Pyun YongHyeon From imp at FreeBSD.org Tue Apr 15 02:09:28 2008 From: imp at FreeBSD.org (Warner Losh) Date: Tue Apr 15 02:09:38 2008 Subject: cvs commit: src/sys/mips/conf SENTRY5 Message-ID: <200804150209.m3F29SeR099966@repoman.freebsd.org> imp 2008-04-15 02:09:28 UTC FreeBSD src repository Modified files: sys/mips/conf SENTRY5 Log: Remove $P4$ tag. Rumor has it that p4 importer hates it. Revision Changes Path 1.2 +0 -1 src/sys/mips/conf/SENTRY5 From imp at FreeBSD.org Tue Apr 15 02:10:14 2008 From: imp at FreeBSD.org (Warner Losh) Date: Tue Apr 15 02:10:26 2008 Subject: cvs commit: src/sys/amd64/include pcb_ext.h Message-ID: <200804150210.m3F2AElp000161@repoman.freebsd.org> imp 2008-04-15 02:10:14 UTC FreeBSD src repository Removed files: sys/amd64/include pcb_ext.h Log: This file is unused on amd64. Revision Changes Path 1.11 +0 -32 src/sys/amd64/include/pcb_ext.h (dead) From imp at FreeBSD.org Tue Apr 15 02:11:57 2008 From: imp at FreeBSD.org (Warner Losh) Date: Tue Apr 15 02:12:02 2008 Subject: cvs commit: src/sys/mips/include pcb_ext.h Message-ID: <200804150211.m3F2BvaO000291@repoman.freebsd.org> imp 2008-04-15 02:11:57 UTC FreeBSD src repository Removed files: sys/mips/include pcb_ext.h Log: Copied from amd64, where it wasn't used, into mips, where it wasn't used. Remove it. Revision Changes Path 1.2 +0 -4 src/sys/mips/include/pcb_ext.h (dead) From imp at FreeBSD.org Tue Apr 15 02:50:08 2008 From: imp at FreeBSD.org (Warner Losh) Date: Tue Apr 15 02:50:10 2008 Subject: cvs commit: src/sys/mips/include ns16550.h src/sys/mips/mips machdep.c mainbus.c Message-ID: <200804150250.m3F2o7wG001611@repoman.freebsd.org> imp 2008-04-15 02:50:07 UTC FreeBSD src repository Modified files: sys/mips/mips machdep.c mainbus.c Removed files: sys/mips/include ns16550.h Log: This isn't used, so remove it. It isn't relevant to most mips platforms. Revision Changes Path 1.2 +0 -194 src/sys/mips/include/ns16550.h (dead) 1.2 +0 -14 src/sys/mips/mips/machdep.c 1.2 +0 -11 src/sys/mips/mips/mainbus.c From thompsa at FreeBSD.org Tue Apr 15 04:17:14 2008 From: thompsa at FreeBSD.org (Andrew Thompson) Date: Tue Apr 15 04:17:21 2008 Subject: cvs commit: src/usr.sbin/ndiscvt ndiscvt.c ndisgen.sh Message-ID: <200804150417.m3F4HEcs006822@repoman.freebsd.org> thompsa 2008-04-15 04:17:14 UTC FreeBSD src repository Modified files: usr.sbin/ndiscvt ndiscvt.c ndisgen.sh Log: Use a ndis_ prefix on the C variable instead of directly using the .sys filename, this would fail if the filename started with a number. PR: bin/84911 Submitted by: Fredrik Lindberg Revision Changes Path 1.14 +4 -4 src/usr.sbin/ndiscvt/ndiscvt.c 1.6 +3 -3 src/usr.sbin/ndiscvt/ndisgen.sh From qingli at speakeasy.net Tue Apr 15 04:38:28 2008 From: qingli at speakeasy.net (Qing Li) Date: Tue Apr 15 04:38:37 2008 Subject: cvs commit: src/sys/conf files options src/sys/net radix.c radix.h route.c route.h rtsock.c src/sys/netinet in_proto.c ip_output.c src/sys/netinet6 in6_proto.c in6_src.c nd6_nbr.c In-Reply-To: <4803D7E2.80000@freebsd.org> References: <200804130545.m3D5jEtd081771@repoman.freebsd.org> <4803D7E2.80000@freebsd.org> Message-ID: <000201c89eae$d4dcfe10$b1335140@SAINTS> Hi Andre, > > Do you do hash-based next-hop balancing ("flow"-aware) or > packet based round robin? Should it be made an option to > switch between them > (globally) like on Cisco routers? > This is hash-based next-hop balancing. > > > > is disallowed. For example, > > > > route add -net 192.103.54.0/24 10.9.44.1 > > route add -net 192.103.54.0/24 10.9.44.2 > > > > The second route insertion will trigger an error message of > > "add net 192.103.54.0/24: gateway 10.2.5.2: route already > in table" > > Would it make sense to retain this behavior by default (POLA) > and have multi-path being enabled via sysctl like packet > forwarding in general? > Just adding the same route twice with different next-hops can > lead to very confusing situations for the users which are not > used to multi-path. > I think that is possible. Were you thinking more along the line of accidental route insertion ... Because users who are not familiar with ecmp probably won't ever bother with more than one route per destination. > > > > "route: writing to routing socket: No such process" > > "delete net default: not in table" > > Can this be made more descriptive? This messages are about > as confusing and non-descript as possible. > We should fix the above error message in general. > > Not being aware of the multipath functionality I would pull > out my last hair try to get rid of a route. > I think updating the manpage would be a necessary next step. > > How does this behave with common routing daemons; > Quagga/Zebra, OpenBGPD, OpenOSPFD? > Hmm... Good question, I haven't tried them but I will. Is this something you could help me with ? > > Do they have to be aware > of the multipath functionality? Will it confuse them? > I don't believe these routing protocols necessarily have to know about the multipath functionality. The routing protocols should continue to function wrt route insertion/deletion. You do bring up a good question about whether we should associate ownership with a route entry if multiple routing protocols are running in parallel. Is this a common practice from your experience ? And should we allow multiple routes with the same next-hop but different owners in the FIB ?? > > What about the other big missing piece; new-arp? ;-) > That's on its way. Julian is helping me testing the patch and reviewing the code etc. I am still debugging a locking/reference count issue and I hope to make good progress in the coming week. Soon ;-) > > Something for BSDCan? > Not for this May event ... -- Qing From thompsa at FreeBSD.org Tue Apr 15 04:44:33 2008 From: thompsa at FreeBSD.org (Andrew Thompson) Date: Tue Apr 15 04:44:39 2008 Subject: cvs commit: src/usr.sbin/ndiscvt inf.c Message-ID: <200804150444.m3F4iXxu007639@repoman.freebsd.org> thompsa 2008-04-15 04:44:33 UTC FreeBSD src repository Modified files: usr.sbin/ndiscvt inf.c Log: If the .inf file did not have a Default entry for the registry key then write out a blank value and close the brackets on the ndis_regvals array. Revision Changes Path 1.17 +3 -1 src/usr.sbin/ndiscvt/inf.c From marcel at FreeBSD.org Tue Apr 15 05:02:42 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Tue Apr 15 05:02:47 2008 Subject: cvs commit: src/sys/ia64/conf GENERIC SKI src/sys/ia64/ia64 interrupt.c machdep.c src/sys/kern sched_ule.c Message-ID: <200804150502.m3F52gab023225@repoman.freebsd.org> marcel 2008-04-15 05:02:42 UTC FreeBSD src repository Modified files: sys/ia64/conf GENERIC SKI sys/ia64/ia64 interrupt.c machdep.c sys/kern sched_ule.c Log: Support and switch to the ULE scheduler: o Implement IPI_PREEMPT, o Set td_lock for the thread being switched out, o For ULE & SMP, loop while td_lock points to blocked_lock for the thread being switched in, o Enable ULE by default in GENERIC and SKI, Revision Changes Path 1.97 +1 -1 src/sys/ia64/conf/GENERIC 1.25 +2 -2 src/sys/ia64/conf/SKI 1.68 +4 -0 src/sys/ia64/ia64/interrupt.c 1.236 +11 -0 src/sys/ia64/ia64/machdep.c 1.241 +1 -1 src/sys/kern/sched_ule.c From ru at FreeBSD.org Tue Apr 15 05:14:43 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Tue Apr 15 05:14:50 2008 Subject: cvs commit: src Makefile.inc1 Message-ID: <200804150514.m3F5Eh38024750@repoman.freebsd.org> ru 2008-04-15 05:14:43 UTC FreeBSD src repository Modified files: . Makefile.inc1 Log: Bootstrap the build of btxld. Revision Changes Path 1.603 +3 -1 src/Makefile.inc1 From imp at FreeBSD.org Tue Apr 15 05:31:20 2008 From: imp at FreeBSD.org (Warner Losh) Date: Tue Apr 15 05:31:26 2008 Subject: cvs commit: src/sys/mips/mips copystr.S Message-ID: <200804150531.m3F5VJ78028637@repoman.freebsd.org> imp 2008-04-15 05:31:19 UTC FreeBSD src repository Modified files: sys/mips/mips copystr.S Log: Add copyright notice and license to reflect origin of most of the routines in this file. Remove 'place holder' copyright since the amount that's actually original is small relative to the length of the file. The contents of this file appear to have originated at DECWRL by way of NetBSD. Noticed by: Simon Burge Revision Changes Path 1.2 +28 -5 src/sys/mips/mips/copystr.S From imp at FreeBSD.org Tue Apr 15 05:35:01 2008 From: imp at FreeBSD.org (Warner Losh) Date: Tue Apr 15 05:35:03 2008 Subject: cvs commit: src/sys/mips/mips cache.c Message-ID: <200804150535.m3F5Z1Tr028782@repoman.freebsd.org> imp 2008-04-15 05:35:01 UTC FreeBSD src repository Modified files: sys/mips/mips cache.c Log: This file shows signs of heavy borrowing from NetBSD's cache.c file, so credit its authors with contributions to this file. Remove prototype copyright notice, although one might be warranted if someone wanted to claim it badly enough. Noticed by: Simon Burge. Revision Changes Path 1.2 +58 -16 src/sys/mips/mips/cache.c From rwatson at FreeBSD.org Tue Apr 15 08:30:12 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Tue Apr 15 08:30:23 2008 Subject: cvs commit: src/sys/mips/conf SENTRY5 In-Reply-To: <200804150209.m3F29SeR099966@repoman.freebsd.org> References: <200804150209.m3F29SeR099966@repoman.freebsd.org> Message-ID: <20080415092841.U14695@fledge.watson.org> On Tue, 15 Apr 2008, Warner Losh wrote: > imp 2008-04-15 02:09:28 UTC > > FreeBSD src repository > > Modified files: > sys/mips/conf SENTRY5 > Log: > Remove $P4$ tag. Rumor has it that p4 importer hates it. What I've done with the Audit files is remove the $ symbols around the tag on commit, so that I can still keep a static P4 version in CVS. You have to resolve it as a conflict when it end up back in your P4 branch, but this is workable. Robert N M Watson Computer Laboratory University of Cambridge From davidxu at FreeBSD.org Tue Apr 15 08:33:33 2008 From: davidxu at FreeBSD.org (David Xu) Date: Tue Apr 15 08:33:52 2008 Subject: cvs commit: src/sys/sys ttycom.h src/sys/kern tty.c src/lib/libc/gen Makefile.inc Symbol.map tcgetsid.3 termios.c Message-ID: <200804150833.m3F8XX5A039392@repoman.freebsd.org> davidxu 2008-04-15 08:33:32 UTC FreeBSD src repository Modified files: sys/sys ttycom.h sys/kern tty.c lib/libc/gen Makefile.inc Symbol.map termios.c Added files: lib/libc/gen tcgetsid.3 Log: Implement POSIX function tcgetsid() which returns session id. PR: stand/107561 Revision Changes Path 1.134 +1 -1 src/lib/libc/gen/Makefile.inc 1.9 +1 -0 src/lib/libc/gen/Symbol.map 1.1 +71 -0 src/lib/libc/gen/tcgetsid.3 (new) 1.15 +11 -0 src/lib/libc/gen/termios.c 1.276 +5 -0 src/sys/kern/tty.c 1.26 +1 -1 src/sys/sys/ttycom.h From bms at FreeBSD.org Tue Apr 15 09:24:21 2008 From: bms at FreeBSD.org (Bruce M. Simpson) Date: Tue Apr 15 09:24:30 2008 Subject: cvs commit: src/sys/conf files options src/sys/net radix.c radix.h route.c route.h rtsock.c src/sys/netinet in_proto.c ip_output.c src/sys/netinet6 in6_proto.c in6_src.c nd6_nbr.c In-Reply-To: <000201c89eae$d4dcfe10$b1335140@SAINTS> References: <200804130545.m3D5jEtd081771@repoman.freebsd.org> <4803D7E2.80000@freebsd.org> <000201c89eae$d4dcfe10$b1335140@SAINTS> Message-ID: <48047442.1030609@FreeBSD.org> Qing Li, First of all thanks for doing this. It would have been nice to have had some advance warning though. Qing Li wrote: >> How does this behave with common routing daemons; >> Quagga/Zebra, OpenBGPD, OpenOSPFD? >> > > Hmm... Good question, I haven't tried them but > I will. Is this something you could help me > with ? > I'm surprised XORP hasn't been mentioned here, so I'll mention it now... For what it's worth this should not make any operational changes to XORP's behaviour, it already plumbs routes to the FIB from its RIB with the next-hop field, and always parses the next-hop in any PF_ROUTE messages it sees. I can't speak for the others. Questions: * So, does this RADIX_MPATH code originate from KAME? * If so, to what extent does it share heritage with the OpenBSD code? I looked at this stuff in some depth last year, with a view to implementing new forwarding code. However without a source of ongoing financial support it was difficult to make real progress with anything, and other things came onto my plate at that stage. It will be useful as a baseline for other work, in particular removing the 32 (S,G) channel limitation from the multicast forwarding code -- with such a change it would be possible to move multicasting into the usual radix trie lookup by adding a new flag which says "flood this to all next-hops specified as AF_LINK sockaddrs". We really need to get ARP out of there now. :-) It would be nice if rt_mpath_matchgate() used the sa_dl_equal() macros from if.c, it reads a bit quirky. The questions you raise about ownership of FIB entries bear some scrutiny. Microsoft, for example, are pretty strict about only exposing the forwarding table to consumers which are willing to play by all rules of the API. What they have could be termed a RIB in of itself, you never get to interact with the forwarding tables directly outside of the TCPIP.SYS driver, except for read-only access e.g. SNMP. There is locking capability in their API. At the moment in the open source sphere what we have are mechanisms which build on top of this in userland (e.g. the quagga approach), or things which push these issues into a lower layer (such as the Linux rtnetlink socket). It really is worth looking at Linux, rtnetlink has an informational RFC, it uses a tag-length-value protocol which addresses a number of the issues blocking further progress in this area, and whilst we can't take the code, the design, and the idea, are not subject to the GPL -- particularly so given the informational RFC status. cheers BMS From ru at FreeBSD.org Tue Apr 15 10:02:24 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Tue Apr 15 10:02:26 2008 Subject: cvs commit: src/sbin/route route.c Message-ID: <200804151002.m3FA2Ojc052396@repoman.freebsd.org> ru 2008-04-15 10:02:24 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sbin/route route.c Log: MFC: 1.85: Fix printing of sockaddr prefixes in verbose mode. PR: bin/122403 Revision Changes Path 1.81.2.3 +1 -1 src/sbin/route/route.c From sos at FreeBSD.org Tue Apr 15 12:28:19 2008 From: sos at FreeBSD.org (=?ISO-8859-1?Q?S=F8ren_Schmidt?=) Date: Tue Apr 15 12:28:31 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-chipset.c ata-dma.c ata-lowlevel.c In-Reply-To: <4803D34C.4030706@gmail.com> References: <200804141834.m3EIYOXP044870@repoman.freebsd.org> <4803D34C.4030706@gmail.com> Message-ID: <1DFDA463-5E5E-4EE5-BF2D-E738D10E57F7@FreeBSD.org> Hi Thats actually a separate problem. I've put in stops to check that the PRD table size doesn't get out of hand. Until now that wasn't a problem but now that we move to having more than on request flying pr channel it needs to be within bounds. The check correctly panic's as we outgrow the table, however thats not very usefull :) Fix coming up with the next round of updates, I also need to go back to the old way of preallocing the SG tables etc, busdma is simply too cycle greedy to be called for each request, as performance has been shown to decrease quite a bit. -S?ren On 14Apr, 2008, at 23:57 , Niclas Zeising wrote: > S?ren Schmidt wrote: >> sos 2008-04-14 18:34:24 UTC >> FreeBSD src repository >> Modified files: >> sys/dev/ata ata-all.h ata-chipset.c ata- >> dma.c ata-lowlevel.c Log: >> Fix problem with slave devices. >> Fix or rather bring ENOMEM problems back to the state it was before. >> Temporarily disable PortMultipliers on AHCI devices. >> Revision Changes Path >> 1.132 +1 -1 src/sys/dev/ata/ata-all.h >> 1.216 +4 -3 src/sys/dev/ata/ata-chipset.c >> 1.153 +4 -4 src/sys/dev/ata/ata-dma.c >> 1.82 +7 -8 src/sys/dev/ata/ata-lowlevel.c > > > Hi! > I still have problems with my install blowing up with the panic > message "to many DMA segment entries". I haven't tried this last > change though. > Unfortunately I can't send a decent backtrace since doing "call > doadump" fom ddb only makes the machine panic again. > > The panic occurs when trying to do a installworld, probably because > of high disc I/O. The march snapshot doesn't inhibit this problem. I > can at least do a cvsup followed by a buildworld and make kernel. > The harddrive is a 114473MB Hitachi SATA150 drive, in my system on > ad8 (ata4-master). The bios runs sata in native mode. The controller > is an Intel AHCI controller. I've compiled a custom kernel (removed > raid and scsi devices I don't use, along with ethernet devices I > don't use, and added sound device and crypto device as well as > GEOM_ELI and GEOM_BDE. Also removed some compat options. Everything > is compiled with standard options except cputype?=core2. > The machine runs amd64. > > The following is the hand-transcribed backtrace from the panic: > > panic: too many DMA segment entries > > cpuid = 1 > KDB: stack backtrace: > db_trace_self_wrappoer() at db_trace_self_wrapper+0x2a > panic() at panic+0x173 > ata_setup_interrupt at ata_setup_interrupt > bus_dmamap_load() at ata_dmaload+0x17e > ata_ahci_begin_transaction() at ata_ahci_begin_transaction+0x1f9 > ata_start() at ata_start+0x1a4 > g_io_schedule_up() at g_io_schedule_up+0x4d > g_up_procvody() at g_up_procbody+0x6f > fork_exit() at fork_exit+0x12a > fork_trampoline at fork_trampoline+0xe > --- trap 0, rip = 0 rsp = 0xffffffffab899d30, rbp = 0 --- > KDB: enter: panic > [thread pid 3 tid 100009 ] > Stopped at kdb_enter+0x3d: movq $0,0x4060f6(%rip) > db> show locs > exclusive sleep mutex ATA state lock r = 0 (0xffffff000130a78) > locked @ /usr/src/sys/dev/ata/ata-queue.c:192 > exclusive sleep mutex ATA queue lock r = 0 (0xffffff0001303ab0 > locked @ /usr/src/sys/dev/ata/ata-queue.c:175 > > Then I try 'call doadump' and get the following panic. Don't know if > it's because of the earlier one or if it's another bug. Probably the > former, but I include the transcription anyway. > > db> call doadump > Physical memory: 1998MB > Dumping 132MB:panic: _mtx_lock_sleep: recursed on non-recursive > mutex ATA queue lock @ /usr/src/sys/dev/ata/ata-queue.c:86 > > cpuid = 1 > KDB: stack backtrace: > db_trace_self_wrapper at db_trace_self_wrapper+0x2a > mi_switch() at mi_switch+0x363 > sched_bind() at sched_bind+0x78 > boot() at boot+0x3f > panic() at panic+0x15d > _mtx_lock_flags() at _mtx_lock_flags > _mtx_lock_flags() at _mtx_lock_flags+0xc0 > ata_queue_request() at ata_queue_request+0x9a > ad_dump() at ad_dump+0x90 > minidumpsys() at minidumpsys+0x23 > dumpsys() at dumpsys+0x23 > doadump() at doadump()+0x49 > db_fncall() at db_fncall+0x88 > db_command() at db_command+0x1eb > db_command_loop() at db_command_loop+0x50 > db_trap() at db_trap+0x87 > kdb_trap() at kdb_trap+0x82 > trap() at trap+0x159 > calltrap() at calltrap+0x8 > --- trap 0x3, rip = 0xffffffff80305aaf, rsp = 0xffffffffab899940, > rbp = 0xffffffffab099960 --- > kdb_enter() at kdb_enter+0x3d > panic() at panic+0x16c > ata_setup_interrupt() at ata_setup_interrupt > bus_dmamap_load() at bus_dmamap_load+0x353 > ata_dmaload() at ata_dmaload+0x17e > ata_ahci_begin_transaction() at ata_ahci_begin_transaction+0x1f9 > ata_start() at ata_start+0x1a4 > g_io_schedule_up() at g_io_schedule_up+0x4d > g_up_procbody() at g_up_procbody+0x6f > fork_exit() at fork_exit+0x12a > fork_trampoline() at fork_trampoline+0xe > --- trap 0, rip = 0, rsp = 0xffffffffab899d30, rbp = 0 --- > > That's pretty much all I can get for now. Tell me if you need more > information. > > Regards! > Niclas Zeising > From niclas.zeising at gmail.com Tue Apr 15 13:11:24 2008 From: niclas.zeising at gmail.com (Niclas Zeising) Date: Tue Apr 15 13:12:02 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-chipset.c ata-dma.c ata-lowlevel.c In-Reply-To: <1DFDA463-5E5E-4EE5-BF2D-E738D10E57F7@FreeBSD.org> References: <200804141834.m3EIYOXP044870@repoman.freebsd.org> <4803D34C.4030706@gmail.com> <1DFDA463-5E5E-4EE5-BF2D-E738D10E57F7@FreeBSD.org> Message-ID: On Tue, Apr 15, 2008 at 2:28 PM, S?ren Schmidt wrote: > Hi > > Thats actually a separate problem. I've put in stops to check that the PRD > table size doesn't get out of hand. Until now that wasn't a problem but now > that we move to having more than on request flying pr channel it needs to be > within bounds. > The check correctly panic's as we outgrow the table, however thats not very > usefull :) Not really, no ;) Just a (perhaps silly) question, is my hardware wierd as no-one else has reported this problem (as I've seen anyway). I'm just curious. > > Fix coming up with the next round of updates, I also need to go back to the > old way of preallocing the SG tables etc, busdma is simply too cycle greedy > to be called for each request, as performance has been shown to decrease > quite a bit. Okay. I'll sit tight and wait for the fix. If you need some testing just drop me a note. Thanks for the quick reply! > > -S?ren > > [SNIP old messages] Regards! Niclas From andre at freebsd.org Tue Apr 15 15:53:11 2008 From: andre at freebsd.org (Andre Oppermann) Date: Tue Apr 15 15:53:17 2008 Subject: cvs commit: src/sys/conf files options src/sys/net radix.c radix.h route.c route.h rtsock.c src/sys/netinet in_proto.c ip_output.c src/sys/netinet6 in6_proto.c in6_src.c nd6_nbr.c In-Reply-To: <000201c89eae$d4dcfe10$b1335140@SAINTS> References: <200804130545.m3D5jEtd081771@repoman.freebsd.org> <4803D7E2.80000@freebsd.org> <000201c89eae$d4dcfe10$b1335140@SAINTS> Message-ID: <4804CF68.9060109@freebsd.org> Qing Li wrote: > Hi Andre, >>> is disallowed. For example, >>> >>> route add -net 192.103.54.0/24 10.9.44.1 >>> route add -net 192.103.54.0/24 10.9.44.2 >>> >>> The second route insertion will trigger an error message of >>> "add net 192.103.54.0/24: gateway 10.2.5.2: route already >> in table" >> >> Would it make sense to retain this behavior by default (POLA) >> and have multi-path being enabled via sysctl like packet >> forwarding in general? >> Just adding the same route twice with different next-hops can >> lead to very confusing situations for the users which are not >> used to multi-path. >> > > I think that is possible. Were you thinking more along the > line of accidental route insertion ... Because users who > are not familiar with ecmp probably won't ever bother > with more than one route per destination. If there is no error message when adding a second route it easily happens. Due to hash based balancing some connections work and some do not. Very confusing. >>> "route: writing to routing socket: No such process" >>> "delete net default: not in table" >> Can this be made more descriptive? This messages are about >> as confusing and non-descript as possible. >> > > We should fix the above error message in general. > >> Not being aware of the multipath functionality I would pull >> out my last hair try to get rid of a route. >> > > I think updating the manpage would be a necessary > next step. > >> How does this behave with common routing daemons; >> Quagga/Zebra, OpenBGPD, OpenOSPFD? >> > > Hmm... Good question, I haven't tried them but > I will. Is this something you could help me > with ? I've chatted with Claudio Jeker (claudio@openbsd.org). He's the author of OpenBGPD and OpenOSPFD plus some work on the OpenBSD multipath support. He says the implicit multipath doesn't work out right and is very difficult to manage from the routing daemons. In OpenBSD they had to change it to explicit mark multipath routes with the RTM_MPATH flag in the table, during creation and removal. The problem is that many daemons and programs (dhclient, ppp, ...) do not properly remove routes and simply re-add a new one with different parameters. This obviously leads to chaos. In OpenBSD multipath one has to install an multipath route explicitly with the -mpath modifier to route(8) and for daemons with RTF_MPATH in the routing message. Multipath routes also retain this flag during their lifetime. If not set, the normal one-route-only behavior is kept. This allows all non-mpath aware programs to continue to work. I think this is the model to follow. Also for inter-BSD compatibility. >> Do they have to be aware >> of the multipath functionality? Will it confuse them? >> > > I don't believe these routing protocols necessarily > have to know about the multipath functionality. > The routing protocols should continue to function > wrt route insertion/deletion. It's easy to throw them into disarray as they do not expect routes to persist when they delete (one of) them. > You do bring up a good question about whether > we should associate ownership with a route entry > if multiple routing protocols are running > in parallel. Is this a common practice from your > experience ? And should we allow multiple routes > with the same next-hop but different owners in > the FIB ?? Yes. Let me explain. There are two approaches here: The Quagga/Zebra approach where all routing protocol daemons communicate with a central daemon that is the single point of contact to the kernel. The other approach is the OpenBGPD/OpenOSPFD approach where each daemon runs on its own (because most of the time there is little to no overlap) and does its own routing table manipulations. The second approach is a bit tricky at the moment as the routing socket is not really intended for operating in this way and the daemons have to be aware of each other in certain ways. Ideally, and this is what Claudio says as well, we should end up with the following functionality: - equal cost multipath where one prefix can have multiple next-hops. - ecmp should be explicit with the RTM_MPATH flag. - a hierarchy of multiple prefixes where the one with the highest priority carries the traffic (possibly with ecmp). - the hierarchy should have a number of precedence levels (interface route, static route, IGP route, EGP route, other). - within those precedence levels it should have further subdivision to prefer OSPF over RIP in the IGP category for example. - a change/delete applies to a specific precedence level if specified. - routing socket filters on reading so that routing daemons can select which precendence levels they want to track (IGP doesn't have to track EGP route changes for example). With this functionality a number of independent but complementary routing daemons can work together is a useful and -more important- standardized way. The ospfd inserts a multipath for 10.0.0.0/8 via 192.168.1.1 and 192.168.1.2 and precedence 4. The bgpd inserts a single route for 10.0.0.0/8 via 192.168.1.3 with precedence 8. All traffic goes through 192.68.1.1 and .2. If the ospfd removes both routes .3 will become active right away. Normally bgpd would have to notice the removal and then has to insert the new prefix. If ospfd then wants to insert them again it has to remove or modify the route bgpd installed. With precedence multipath these problems go away. >> What about the other big missing piece; new-arp? ;-) >> > > That's on its way. Julian is helping me testing the > patch and reviewing the code etc. I am still > debugging a locking/reference count issue and > I hope to make good progress in the coming week. May I have a look too before it goes into CVS? -- Andre From emax at FreeBSD.org Tue Apr 15 16:54:40 2008 From: emax at FreeBSD.org (Maksim Yevmenkin) Date: Tue Apr 15 16:54:41 2008 Subject: cvs commit: src/sys/net if_tap.c Message-ID: <200804151654.m3FGsdqA098616@repoman.freebsd.org> emax 2008-04-15 16:54:39 UTC FreeBSD src repository Modified files: sys/net if_tap.c Log: Fix possible buffer overrun on 64-bit arch when generating MAC address for tap interface. Reported by: Marc Lorner < marc dot loerner at hob dot de > Reviewed by: bms MFC after: 3 days Revision Changes Path 1.72 +3 -1 src/sys/net/if_tap.c From marcel at FreeBSD.org Tue Apr 15 17:02:24 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Tue Apr 15 17:02:30 2008 Subject: cvs commit: src/sys/ia64/conf DEFAULTS src/sys/ia64/ia64 clock.c nexus.c Message-ID: <200804151702.m3FH2OUv099113@repoman.freebsd.org> marcel 2008-04-15 17:02:24 UTC FreeBSD src repository Modified files: sys/ia64/conf DEFAULTS sys/ia64/ia64 clock.c nexus.c Log: Use genclock for RTC handling. This eliminates the MD versions for inittodr() and resettodr(). Have nexus double as the clock device, because it's the firmware that provides RTC services. We could create a special (pseudo-) device for it, but that wasn't superior enough to actually do it. Maybe later... Requested by: phk Revision Changes Path 1.14 +1 -0 src/sys/ia64/conf/DEFAULTS 1.33 +0 -92 src/sys/ia64/ia64/clock.c 1.20 +51 -44 src/sys/ia64/ia64/nexus.c From jkim at FreeBSD.org Tue Apr 15 17:08:24 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Tue Apr 15 17:08:40 2008 Subject: cvs commit: src/sys/net bpf.c Message-ID: <200804151708.m3FH8OXG001024@repoman.freebsd.org> jkim 2008-04-15 17:08:24 UTC FreeBSD src repository Modified files: sys/net bpf.c Log: Revert the previous commit and use M_PROMISC flag instead. It is safer because it will never be used for outgoing packets. Revision Changes Path 1.193 +17 -8 src/sys/net/bpf.c From jkim at FreeBSD.org Tue Apr 15 17:41:53 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Tue Apr 15 17:41:58 2008 Subject: cvs commit: src/sys/dev/atkbdc psm.c Message-ID: <200804151741.m3FHfqHe003555@repoman.freebsd.org> jkim 2008-04-15 17:41:52 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/atkbdc psm.c Log: MFC: 1.95, 1.96 - Add write(2) support for psm(4) in native operation level. Now arbitrary commands can be written to /dev/psm%d and status can be read back from it. - Clean up and fix style(9) nits. Revision Changes Path 1.93.2.2 +2915 -2783 src/sys/dev/atkbdc/psm.c From jkim at FreeBSD.org Tue Apr 15 17:43:41 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Tue Apr 15 17:43:50 2008 Subject: cvs commit: src/sys/sys param.h Message-ID: <200804151743.m3FHhe5K003653@repoman.freebsd.org> jkim 2008-04-15 17:43:40 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/sys param.h Log: Bump __FreeBSD_version to reflect write(2) support for psm(4). Revision Changes Path 1.308.2.10 +1 -1 src/sys/sys/param.h From emax at FreeBSD.org Tue Apr 15 20:24:00 2008 From: emax at FreeBSD.org (Maksim Yevmenkin) Date: Tue Apr 15 20:24:07 2008 Subject: cvs commit: src/etc/defaults rc.conf src/etc/rc.d Makefile rfcomm_pppd_server src/share/man/man5 rc.conf.5 Message-ID: <200804152023.m3FKNxu8012723@repoman.freebsd.org> emax 2008-04-15 20:23:59 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) etc/defaults rc.conf etc/rc.d Makefile share/man/man5 rc.conf.5 Added files: (Branch: RELENG_7) etc/rc.d rfcomm_pppd_server Log: MFC: Add rfcomm_pppd_server rc script to allow start rfcomm_pppd(8) in server mode at boot time. Multiple profiles can be started at the same time. The whole idea is very similar to the ppp rc script. Document Bluetooth knobs in rc.conf(5) Set defaults for the rfcomm_pppd_server rc script Revision Changes Path 1.318.2.7 +13 -0 src/etc/defaults/rc.conf 1.84.2.4 +1 -1 src/etc/rc.d/Makefile 1.1.2.1 +122 -0 src/etc/rc.d/rfcomm_pppd_server (new) 1.327.2.4 +107 -1 src/share/man/man5/rc.conf.5 From emax at FreeBSD.org Tue Apr 15 20:31:15 2008 From: emax at FreeBSD.org (Maksim Yevmenkin) Date: Tue Apr 15 20:31:20 2008 Subject: cvs commit: src/etc/defaults rc.conf src/etc/rc.d Makefile rfcomm_pppd_server src/share/man/man5 rc.conf.5 Message-ID: <200804152031.m3FKVFTE014277@repoman.freebsd.org> emax 2008-04-15 20:31:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) etc/defaults rc.conf etc/rc.d Makefile share/man/man5 rc.conf.5 Added files: (Branch: RELENG_6) etc/rc.d rfcomm_pppd_server Log: MFC: Add rfcomm_pppd_server rc script to allow start rfcomm_pppd(8) in server mode at boot time. Multiple profiles can be started at the same time. The whole idea is very similar to the ppp rc script. Document Bluetooth knobs in rc.conf(5) Set defaults for the rfcomm_pppd_server rc script Revision Changes Path 1.252.2.44 +13 -0 src/etc/defaults/rc.conf 1.53.2.21 +1 -1 src/etc/rc.d/Makefile 1.1.4.1 +122 -0 src/etc/rc.d/rfcomm_pppd_server (new) 1.256.2.37 +107 -1 src/share/man/man5/rc.conf.5 From mav at FreeBSD.org Tue Apr 15 21:15:32 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Tue Apr 15 21:15:37 2008 Subject: cvs commit: src/sys/netgraph netgraph.h ng_base.c src/sys/netgraph/bluetooth/include ng_bluetooth.h Message-ID: <200804152115.m3FLFWnK026345@repoman.freebsd.org> mav 2008-04-15 21:15:32 UTC FreeBSD src repository Modified files: sys/netgraph netgraph.h ng_base.c sys/netgraph/bluetooth/include ng_bluetooth.h Log: Several changes breaking netgraph module ABI collected together: - reorder structures fields (XX_refs) a bit to group fields modified same time together. According to my tests it gives up to 10% SMP performance benefit on real workload due to reduced inter-CPU cache trashing. - change q_flags from long to int as long is not really needed there and it's usage with atomics is argued by some people. - move NGF_WORKQ flag into the separate field q_flags2 as it protected by queue mutex instead of node writer protection used by the rest of flags. - move nd_work queue entry to ng_queue structure to which it is more related and make it STAILQ instead of TAILQ as now it is a classic FIFO. - remove q_node pointer from ng_queue structure as it is not really needed. - reimplement item queue using STAILQ instead of own equal implementation. As soon as BT subsystem has own item queues using ng_item.el_next update it also. - change depth field in ng_item from uintptr_t to u_int. It was made uintptr_t to keep ABI compatibility. Reviewed by: julian, emax Tested with: Netperf cluster Revision Changes Path 1.5 +15 -23 src/sys/netgraph/bluetooth/include/ng_bluetooth.h 1.73 +9 -12 src/sys/netgraph/netgraph.h 1.157 +91 -104 src/sys/netgraph/ng_base.c From brooks at FreeBSD.org Tue Apr 15 22:34:40 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Tue Apr 15 22:34:46 2008 Subject: cvs commit: src/etc/rc.d ppp Message-ID: <200804152234.m3FMYdDc033824@repoman.freebsd.org> brooks 2008-04-15 22:34:39 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) etc/rc.d ppp Log: MFC rev 1.20: Declare _ppp_profile_cleaned, _punct, and _punct_c local in ppp_start_profile(). Reported by: yar Revision Changes Path 1.13.2.3 +2 -0 src/etc/rc.d/ppp From brooks at FreeBSD.org Tue Apr 15 22:37:44 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Tue Apr 15 22:37:51 2008 Subject: cvs commit: src/etc/rc.d ppp Message-ID: <200804152237.m3FMbiiJ033963@repoman.freebsd.org> brooks 2008-04-15 22:37:43 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) etc/rc.d ppp Log: MFC revs 1.17-1.20, the functional components of which are: 1.17: Allow the characters .-+/ to appear in ppp profile names by folding them to _ when evaluating ppp__nat and ppp__mode. Document the per-profile variables. 1.18: Add support for hardwiring ppp sessions to particular devices with new per-profile variables of the form ppp__unit. No ppp_unit variable is supported since tying the same unit to more than one profile won't work. PR: conf/121452, conf/122127 Revision Changes Path 1.11.2.5 +16 -3 src/etc/rc.d/ppp From rpaulo at FreeBSD.org Tue Apr 15 22:47:01 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Tue Apr 15 22:47:12 2008 Subject: cvs commit: src/sys/dev/acpi_support acpi_asus.c Message-ID: <200804152247.m3FMl11K034321@repoman.freebsd.org> rpaulo 2008-04-15 22:47:01 UTC FreeBSD src repository Modified files: sys/dev/acpi_support acpi_asus.c Log: style(9). Noticed by: jkim Revision Changes Path 1.33 +1 -1 src/sys/dev/acpi_support/acpi_asus.c From brooks at FreeBSD.org Tue Apr 15 22:48:56 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Tue Apr 15 22:49:02 2008 Subject: cvs commit: src/sbin/dhclient bpf.c Message-ID: <200804152248.m3FMmuuE034370@repoman.freebsd.org> brooks 2008-04-15 22:48:56 UTC FreeBSD src repository Modified files: sbin/dhclient bpf.c Log: When sending packets directly to the DHCP server, use a socket and send directly rather than bogusly sending it out as a link layer broadcast (which fails to be received on some networks). PR: bin/96018 MFC after: 2 weeks Revision Changes Path 1.8 +15 -0 src/sbin/dhclient/bpf.c From brooks at FreeBSD.org Tue Apr 15 23:03:36 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Tue Apr 15 23:03:46 2008 Subject: cvs commit: src/etc/rc.d dhclient Message-ID: <200804152303.m3FN3Z4W036034@repoman.freebsd.org> brooks 2008-04-15 23:03:35 UTC FreeBSD src repository Modified files: etc/rc.d dhclient Log: Add very limited support for the isc-dhclient. It will almostly certaintly only work if there's just one interface doing dhcp. This version implements the same logic as the version in the PR, but uses pgrep to be less verbose. PR: conf/95905 MFC after: 1 week Revision Changes Path 1.32 +4 -0 src/etc/rc.d/dhclient From claudio at openbsd.org Tue Apr 15 23:07:00 2008 From: claudio at openbsd.org (Claudio Jeker) Date: Tue Apr 15 23:07:08 2008 Subject: cvs commit: src/sys/conf files options src/sys/net radix.c radix.h route.c route.h rtsock.c src/sys/netinet in_proto.c ip_output.c src/sys/netinet6 in6_proto.c in6_src.c nd6_nbr.c In-Reply-To: <4804CF68.9060109@freebsd.org> References: <200804130545.m3D5jEtd081771@repoman.freebsd.org> <4803D7E2.80000@freebsd.org> <000201c89eae$d4dcfe10$b1335140@SAINTS> <4804CF68.9060109@freebsd.org> Message-ID: <20080415224015.GA17244@diehard.n-r-g.com> On Tue, Apr 15, 2008 at 05:53:12PM +0200, Andre Oppermann wrote: > Qing Li wrote: >> Hi Andre, >>>> is disallowed. For example, >>>> route add -net 192.103.54.0/24 10.9.44.1 >>>> route add -net 192.103.54.0/24 10.9.44.2 >>>> The second route insertion will trigger an error message of >>>> "add net 192.103.54.0/24: gateway 10.2.5.2: route already >>> in table" >>> >>> Would it make sense to retain this behavior by default (POLA) and have >>> multi-path being enabled via sysctl like packet forwarding in general? >>> Just adding the same route twice with different next-hops can lead to >>> very confusing situations for the users which are not used to multi-path. >>> >> I think that is possible. Were you thinking more along the >> line of accidental route insertion ... Because users who >> are not familiar with ecmp probably won't ever bother >> with more than one route per destination. > > If there is no error message when adding a second route it easily > happens. Due to hash based balancing some connections work and > some do not. Very confusing. > >>>> "route: writing to routing socket: No such process" >>>> "delete net default: not in table" >>> Can this be made more descriptive? This messages are about as confusing >>> and non-descript as possible. >> We should fix the above error message in general. >>> Not being aware of the multipath functionality I would pull out my last >>> hair try to get rid of a route. >>> >> I think updating the manpage would be a necessary >> next step. >>> How does this behave with common routing daemons; Quagga/Zebra, OpenBGPD, >>> OpenOSPFD? >> Hmm... Good question, I haven't tried them but >> I will. Is this something you could help me >> with ? > > I've chatted with Claudio Jeker (claudio@openbsd.org). He's the author > of OpenBGPD and OpenOSPFD plus some work on the OpenBSD multipath support. > > He says the implicit multipath doesn't work out right and is very difficult > to manage from the routing daemons. In OpenBSD they had to change it to > explicit mark multipath routes with the RTM_MPATH flag in the table, during > creation and removal. > > The problem is that many daemons and programs (dhclient, ppp, ...) do not > properly remove routes and simply re-add a new one with different > parameters. > This obviously leads to chaos. > > In OpenBSD multipath one has to install an multipath route explicitly with > the -mpath modifier to route(8) and for daemons with RTF_MPATH in the > routing > message. Multipath routes also retain this flag during their lifetime. If > not set, the normal one-route-only behavior is kept. This allows all > non-mpath > aware programs to continue to work. > > I think this is the model to follow. Also for inter-BSD compatibility. > We did the same misstake on the initial commit the result was unexpected behaviour by many aplications playing with the routing socket. Tools like ppp(8), openvpn and many others (IIRC even zebra/quagga were afected) do routing updates blindly. First an RTM_ADD is tried and on an EEXIST it falls back to RTM_CHANGE. With multipath routing the EEXIST did not happen and so a stale route was suddenly around. We then added the RTF_MPATH flag to retain the original behaviour unless the flag is set. By doing that we did not need to change all 3rd party tools. Later on we decided to keep the RTF_MPATH flag in the kernel to identify multipath routes more easily. Additionally some userland tools filter on or use the flag to handle the routes specially. >>> Do they have to be aware of the multipath functionality? Will it confuse >>> them? >>> >> I don't believe these routing protocols necessarily >> have to know about the multipath functionality. >> The routing protocols should continue to function >> wrt route insertion/deletion. > > It's easy to throw them into disarray as they do not expect routes to > persist when they delete (one of) them. > Routing protocols must know about multipath routes as soon as they do decisions based on gateway reachability. e.g. the BGP redistribution logic uses the gateway address, OSPF has a similar behaviour. >> You do bring up a good question about whether >> we should associate ownership with a route entry >> if multiple routing protocols are running >> in parallel. Is this a common practice from your >> experience ? And should we allow multiple routes >> with the same next-hop but different owners in >> the FIB ?? > > Yes. Let me explain. There are two approaches here: The Quagga/Zebra > approach where all routing protocol daemons communicate with a central > daemon that is the single point of contact to the kernel. The other > approach is the OpenBGPD/OpenOSPFD approach where each daemon runs on > its own (because most of the time there is little to no overlap) and > does its own routing table manipulations. The second approach is a > bit tricky at the moment as the routing socket is not really intended > for operating in this way and the daemons have to be aware of each > other in certain ways. > > Ideally, and this is what Claudio says as well, we should end up with > the following functionality: > > - equal cost multipath where one prefix can have multiple next-hops. > - ecmp should be explicit with the RTM_MPATH flag. > - a hierarchy of multiple prefixes where the one with the highest > priority carries the traffic (possibly with ecmp). > - the hierarchy should have a number of precedence levels (interface > route, static route, IGP route, EGP route, other). > - within those precedence levels it should have further subdivision > to prefer OSPF over RIP in the IGP category for example. > - a change/delete applies to a specific precedence level if specified. > - routing socket filters on reading so that routing daemons can > select which precendence levels they want to track (IGP doesn't > have to track EGP route changes for example). > > With this functionality a number of independent but complementary routing > daemons can work together is a useful and -more important- standardized > way. > > The ospfd inserts a multipath for 10.0.0.0/8 via 192.168.1.1 and > 192.168.1.2 > and precedence 4. The bgpd inserts a single route for 10.0.0.0/8 via > 192.168.1.3 > with precedence 8. All traffic goes through 192.68.1.1 and .2. If the > ospfd > removes both routes .3 will become active right away. Normally bgpd would > have > to notice the removal and then has to insert the new prefix. If ospfd then > wants to insert them again it has to remove or modify the route bgpd > installed. > With precedence multipath these problems go away. > Yes, this is where we're heading right now. By having such routing priorities many current issues can be solved in a very nice way. >>> What about the other big missing piece; new-arp? ;-) >> That's on its way. Julian is helping me testing the >> patch and reviewing the code etc. I am still >> debugging a locking/reference count issue and >> I hope to make good progress in the coming week. > > May I have a look too before it goes into CVS? > > -- > Andre > -- :wq Claudio From cperciva at FreeBSD.org Tue Apr 15 23:29:52 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Tue Apr 15 23:30:00 2008 Subject: cvs commit: src/lib/libfetch common.c Message-ID: <200804152329.m3FNTpVf036806@repoman.freebsd.org> cperciva 2008-04-15 23:29:51 UTC FreeBSD src repository Modified files: lib/libfetch common.c Log: Fix one-byte buffer overflow: NUL gets written to the buffer, but isn't counted in the width specification in scanf. This is not a security problem, since this function is only used to parse a user's configuration file. Submitted by: Joerg Sonnenberger Obtained from: dragonflybsd MFC after: 1 week Revision Changes Path 1.56 +1 -1 src/lib/libfetch/common.c From yongari at FreeBSD.org Wed Apr 16 00:17:24 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Wed Apr 16 00:17:34 2008 Subject: cvs commit: src/share/man/man4 nfe.4 Message-ID: <200804160017.m3G0HOIS039488@repoman.freebsd.org> yongari 2008-04-16 00:17:24 UTC FreeBSD src repository Modified files: share/man/man4 nfe.4 Log: Mention support for nForce MCP73. Touch Dd. Revision Changes Path 1.10 +4 -2 src/share/man/man4/nfe.4 From davidxu at FreeBSD.org Wed Apr 16 03:19:11 2008 From: davidxu at FreeBSD.org (David Xu) Date: Wed Apr 16 03:19:23 2008 Subject: cvs commit: src/lib/libthr/thread thr_init.c Message-ID: <200804160319.m3G3JBe2062766@repoman.freebsd.org> davidxu 2008-04-16 03:19:11 UTC FreeBSD src repository Modified files: lib/libthr/thread thr_init.c Log: _vfork is not in libthr, remove the reference. Revision Changes Path 1.50 +0 -1 src/lib/libthr/thread/thr_init.c From imp at FreeBSD.org Wed Apr 16 05:06:12 2008 From: imp at FreeBSD.org (Warner Losh) Date: Wed Apr 16 05:06:17 2008 Subject: cvs commit: src/lib/libc/mips/mips/sys Makefile.inc Ovfork.S brk.S cerror.S exect.S fork.S pipe.S ptrace.S sbrk.S shmat.S syscall.S Message-ID: <200804160506.m3G56Cow077626@repoman.freebsd.org> imp 2008-04-16 05:06:12 UTC FreeBSD src repository Added files: lib/libc/mips/mips/sys Makefile.inc Ovfork.S brk.S cerror.S exect.S fork.S pipe.S ptrace.S sbrk.S shmat.S syscall.S Log: FreeBSD/mips libc support. Merged from perforce mips2-jnpr branch. Revision Changes Path 1.1 +14 -0 src/lib/libc/mips/mips/sys/Makefile.inc (new) 1.1 +73 -0 src/lib/libc/mips/mips/sys/Ovfork.S (new) 1.1 +76 -0 src/lib/libc/mips/mips/sys/brk.S (new) 1.1 +70 -0 src/lib/libc/mips/mips/sys/cerror.S (new) 1.1 +56 -0 src/lib/libc/mips/mips/sys/exect.S (new) 1.1 +63 -0 src/lib/libc/mips/mips/sys/fork.S (new) 1.1 +62 -0 src/lib/libc/mips/mips/sys/pipe.S (new) 1.1 +60 -0 src/lib/libc/mips/mips/sys/ptrace.S (new) 1.1 +85 -0 src/lib/libc/mips/mips/sys/sbrk.S (new) 1.1 +8 -0 src/lib/libc/mips/mips/sys/shmat.S (new) 1.1 +44 -0 src/lib/libc/mips/mips/sys/syscall.S (new) From imp at FreeBSD.org Wed Apr 16 05:08:28 2008 From: imp at FreeBSD.org (Warner Losh) Date: Wed Apr 16 05:08:35 2008 Subject: cvs commit: src/lib/libc/mips/mips/sys Ovfork.S brk.S cerror.S exect.S fork.S pipe.S ptrace.S sbrk.S shmat.S syscall.S Message-ID: <200804160508.m3G58RBl077710@repoman.freebsd.org> imp 2008-04-16 05:08:27 UTC FreeBSD src repository Modified files: lib/libc/mips/mips/sys Ovfork.S brk.S cerror.S exect.S fork.S pipe.S ptrace.S sbrk.S shmat.S syscall.S Log: Turns out the machine/asm.h isn't needed here, since SYS.h already included it. Revision Changes Path 1.2 +0 -1 src/lib/libc/mips/mips/sys/Ovfork.S 1.2 +0 -1 src/lib/libc/mips/mips/sys/brk.S 1.2 +0 -1 src/lib/libc/mips/mips/sys/cerror.S 1.2 +0 -1 src/lib/libc/mips/mips/sys/exect.S 1.2 +0 -1 src/lib/libc/mips/mips/sys/fork.S 1.2 +0 -1 src/lib/libc/mips/mips/sys/pipe.S 1.2 +0 -1 src/lib/libc/mips/mips/sys/ptrace.S 1.2 +0 -1 src/lib/libc/mips/mips/sys/sbrk.S 1.2 +1 -3 src/lib/libc/mips/mips/sys/shmat.S 1.2 +0 -1 src/lib/libc/mips/mips/sys/syscall.S From imp at FreeBSD.org Wed Apr 16 05:11:25 2008 From: imp at FreeBSD.org (Warner Losh) Date: Wed Apr 16 05:11:30 2008 Subject: cvs commit: src/lib/libc/mips/mips/sys Makefile.inc Ovfork.S brk.S cerror.S exect.S fork.S pipe.S ptrace.S sbrk.S shmat.S syscall.S Message-ID: <200804160511.m3G5BPtW077921@repoman.freebsd.org> imp 2008-04-16 05:11:25 UTC FreeBSD src repository Removed files: lib/libc/mips/mips/sys Makefile.inc Ovfork.S brk.S cerror.S exect.S fork.S pipe.S ptrace.S sbrk.S shmat.S syscall.S Log: Doh! Extra mips in the path. Remove these and wait until tomorrow when I have more brain cells to try again. Revision Changes Path 1.2 +0 -14 src/lib/libc/mips/mips/sys/Makefile.inc (dead) 1.3 +0 -72 src/lib/libc/mips/mips/sys/Ovfork.S (dead) 1.3 +0 -75 src/lib/libc/mips/mips/sys/brk.S (dead) 1.3 +0 -69 src/lib/libc/mips/mips/sys/cerror.S (dead) 1.3 +0 -55 src/lib/libc/mips/mips/sys/exect.S (dead) 1.3 +0 -62 src/lib/libc/mips/mips/sys/fork.S (dead) 1.3 +0 -61 src/lib/libc/mips/mips/sys/pipe.S (dead) 1.3 +0 -59 src/lib/libc/mips/mips/sys/ptrace.S (dead) 1.3 +0 -84 src/lib/libc/mips/mips/sys/sbrk.S (dead) 1.3 +0 -6 src/lib/libc/mips/mips/sys/shmat.S (dead) 1.3 +0 -43 src/lib/libc/mips/mips/sys/syscall.S (dead) From dfr at FreeBSD.org Wed Apr 16 09:08:55 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Wed Apr 16 09:09:01 2008 Subject: cvs commit: src/sys/nlm nlm_prot_impl.c src/sys/rpc clnt_rc.c Message-ID: <200804160908.m3G98taD000267@repoman.freebsd.org> dfr 2008-04-16 09:08:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/nlm nlm_prot_impl.c sys/rpc clnt_rc.c Log: MFC: nlm_prot_impl.c 1.5, clnt_rc.c 1.3 Avoid error cascades when trying to monitor a host that doesn't resolve in DNS. Tighten error handling when attempting to communicate with the userland part of rpc.lockd. Revision Changes Path 1.4.2.2 +28 -14 src/sys/nlm/nlm_prot_impl.c 1.2.2.2 +8 -2 src/sys/rpc/clnt_rc.c From dfr at FreeBSD.org Wed Apr 16 09:09:51 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Wed Apr 16 09:10:08 2008 Subject: cvs commit: src/sys/nlm nlm_prot_impl.c Message-ID: <200804160909.m3G99oDE000306@repoman.freebsd.org> dfr 2008-04-16 09:09:50 UTC FreeBSD src repository Modified files: sys/nlm nlm_prot_impl.c Log: Tighten up the error-handling in nlm_get_rpc. While I'm here, fix a couple of spelling mistakes in comments. Revision Changes Path 1.6 +7 -3 src/sys/nlm/nlm_prot_impl.c From raj at semihalf.com Wed Apr 16 11:30:18 2008 From: raj at semihalf.com (Rafal Jaworowski) Date: Wed Apr 16 11:30:21 2008 Subject: cvs commit: src/sys/boot/common dev_net.c src/sys/boot/uboot/lib console.c copy.c glue.c libuboot.h net.c time.c In-Reply-To: <20080412221501.GB44768@alchemy.franken.de> References: <200803121601.m2CG1ZbG072258@repoman.freebsd.org> <20080412221501.GB44768@alchemy.franken.de> Message-ID: <4805DE07.8050008@semihalf.com> Marius Strobl wrote: >> raj 2008-03-12 16:01:34 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/boot/common dev_net.c >> sys/boot/uboot/lib console.c copy.c glue.c libuboot.h net.c >> time.c >> Log: >> Eliminate artificial increasing of 'netdev_opens' counter in loader's net_open(). >> >> This was introduced as a workaround long time ago for some Alpha firmware >> (which is now gone), and actually prevented net_close() to ever be >> called. >> >> Certain firmwares (U-Boot) need local shutdown operations to be performed on a >> network controller upon transaction end: such platform-specific hooks are >> supposed to be called via netif_close() (from within net_close()). >> >> This change effectively reverts the following CVS commit: >> >> sys/boot/common/dev_net.c >> >> revision 1.7 >> date: 2000/05/13 15:40:46; author: dfr; state: Exp; lines: +2 -1 >> Only probe network settings on the first open of the network device. >> The alpha firmware takes a seriously long time to open the network device >> the first time. >> > > On at least sparc64 reverting this causes ofwn_init() to be called > over and over again, which doesn't seem to be the right thing to do > either. I think this is expected: the loader/libstand seem to call devopen()->net_open(), devclose()->net_close() upon each file access, but it doesn't seem harmful, only additional output is seen in this case. Previously, due to this artificial increase of 'netdev_opens' counter, the devclose() method for network device was never called. Rafal From kib at FreeBSD.org Wed Apr 16 11:33:32 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Wed Apr 16 11:33:39 2008 Subject: cvs commit: src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys zfs_znode.h src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c zfs_znode.c src/sys/fs/msdosfs denode.h msdosfs_vnops.c src/sys/fs/smbfs smbfs_node.h smbfs_vnops.c src/sys/fs/tmpfs tmpfs.h tmpfs_vfsops.c tmpfs_vnops.c ... Message-ID: <200804161133.m3GBXWma012543@repoman.freebsd.org> kib 2008-04-16 11:33:32 UTC FreeBSD src repository Modified files: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys zfs_znode.h sys/cddl/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c zfs_znode.c sys/fs/msdosfs denode.h msdosfs_vnops.c sys/fs/smbfs smbfs_node.h smbfs_vnops.c sys/fs/tmpfs tmpfs.h tmpfs_vfsops.c tmpfs_vnops.c sys/gnu/fs/ext2fs ext2_vnops.c inode.h sys/gnu/fs/xfs/FreeBSD xfs_vnops.c sys/kern kern_lockf.c vfs_default.c vfs_subr.c sys/nfs4client nfs4_vnops.c sys/nfsclient nfs_lock.c nfs_vnops.c nfsnode.h sys/sys lockf.h vnode.h sys/ufs/ufs inode.h ufs_vnops.c Log: Move the head of byte-level advisory lock list from the filesystem-specific vnode data to the struct vnode. Provide the default implementation for the vop_advlock and vop_advlockasync. Purge the locks on the vnode reclaim by using the lf_purgelocks(). The default implementation is augmented for the nfs and smbfs. In the nfs_advlock, push the Giant inside the nfs_dolock. Before the change, the vop_advlock and vop_advlockasync have taken the unlocked vnode and dereferenced the fs-private inode data, racing with with the vnode reclamation due to forced unmount. Now, the vop_getattr under the shared vnode lock is used to obtain the inode size, and later, in the lf_advlockasync, after locking the vnode interlock, the VI_DOOMED flag is checked to prevent an operation on the doomed vnode. The implementation of the lf_purgelocks() is submitted by dfr. Reported by: kris Tested by: kris, pho Discussed with: jeff, dfr MFC after: 2 weeks Revision Changes Path 1.3 +0 -1 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_znode.h 1.31 +0 -39 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c 1.15 +0 -1 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_znode.c 1.39 +0 -1 src/sys/fs/msdosfs/denode.h 1.185 +0 -35 src/sys/fs/msdosfs/msdosfs_vnops.c 1.8 +0 -1 src/sys/fs/smbfs/smbfs_node.h 1.69 +4 -4 src/sys/fs/smbfs/smbfs_vnops.c 1.13 +0 -3 src/sys/fs/tmpfs/tmpfs.h 1.18 +0 -1 src/sys/fs/tmpfs/tmpfs_vfsops.c 1.18 +0 -32 src/sys/fs/tmpfs/tmpfs_vnops.c 1.113 +0 -20 src/sys/gnu/fs/ext2fs/ext2_vnops.c 1.45 +0 -1 src/sys/gnu/fs/ext2fs/inode.h 1.9 +4 -4 src/sys/gnu/fs/xfs/FreeBSD/xfs_vnops.c 1.62 +96 -1 src/sys/kern/kern_lockf.c 1.144 +40 -1 src/sys/kern/vfs_default.c 1.728 +5 -0 src/sys/kern/vfs_subr.c 1.44 +29 -11 src/sys/nfs4client/nfs4_vnops.c 1.47 +18 -8 src/sys/nfsclient/nfs_lock.c 1.284 +23 -19 src/sys/nfsclient/nfs_vnops.c 1.62 +0 -1 src/sys/nfsclient/nfsnode.h 1.22 +6 -0 src/sys/sys/lockf.h 1.336 +3 -0 src/sys/sys/vnode.h 1.52 +0 -1 src/sys/ufs/ufs/inode.h 1.297 +0 -41 src/sys/ufs/ufs/ufs_vnops.c From kib at FreeBSD.org Wed Apr 16 13:03:13 2008 From: kib at FreeBSD.org (Konstantin Belousov) Date: Wed Apr 16 13:03:22 2008 Subject: cvs commit: src/lib/libc/sys access.2 chmod.2 chown.2 execve.2 link.2 mkdir.2 mkfifo.2 mknod.2 open.2 readlink.2 rename.2 stat.2 symlink.2 unlink.2 utimes.2 Message-ID: <200804161303.m3GD3DDJ027427@repoman.freebsd.org> kib 2008-04-16 13:03:12 UTC FreeBSD src repository Modified files: lib/libc/sys access.2 chmod.2 chown.2 execve.2 link.2 mkdir.2 mkfifo.2 mknod.2 open.2 readlink.2 rename.2 stat.2 symlink.2 unlink.2 utimes.2 Log: Man pages for the openat(2), fexecve(2) and related syscalls. Reviewed by: ru Revision Changes Path 1.24 +72 -2 src/lib/libc/sys/access.2 1.38 +79 -2 src/lib/libc/sys/chmod.2 1.26 +86 -2 src/lib/libc/sys/chown.2 1.41 +55 -2 src/lib/libc/sys/execve.2 1.28 +112 -4 src/lib/libc/sys/link.2 1.25 +58 -2 src/lib/libc/sys/mkdir.2 1.23 +58 -2 src/lib/libc/sys/mkfifo.2 1.18 +58 -2 src/lib/libc/sys/mknod.2 1.39 +76 -9 src/lib/libc/sys/open.2 1.17 +60 -2 src/lib/libc/sys/readlink.2 1.28 +78 -1 src/lib/libc/sys/rename.2 1.48 +82 -2 src/lib/libc/sys/stat.2 1.23 +58 -2 src/lib/libc/sys/symlink.2 1.23 +103 -4 src/lib/libc/sys/unlink.2 1.22 +63 -2 src/lib/libc/sys/utimes.2 From flz at FreeBSD.org Wed Apr 16 13:05:36 2008 From: flz at FreeBSD.org (Florent Thoumie) Date: Wed Apr 16 13:05:47 2008 Subject: cvs commit: src/usr.sbin/pkg_install/info main.c perform.c Message-ID: <200804161305.m3GD5ZJk027553@repoman.freebsd.org> flz 2008-04-16 13:05:35 UTC FreeBSD src repository Modified files: usr.sbin/pkg_install/info main.c perform.c Log: Fix pkg_info when specifying a remote package. MFC after: 1 week Revision Changes Path 1.52 +1 -1 src/usr.sbin/pkg_install/info/main.c 1.55 +22 -17 src/usr.sbin/pkg_install/info/perform.c From dfr at FreeBSD.org Wed Apr 16 14:08:13 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Wed Apr 16 14:08:28 2008 Subject: cvs commit: src/sys/kern kern_lockf.c Message-ID: <200804161408.m3GE8ChT032943@repoman.freebsd.org> dfr 2008-04-16 14:08:12 UTC FreeBSD src repository Modified files: sys/kern kern_lockf.c Log: Fix compilation with LOCKF_DEBUG. Revision Changes Path 1.63 +1 -1 src/sys/kern/kern_lockf.c From ru at FreeBSD.org Wed Apr 16 14:44:44 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Wed Apr 16 14:45:01 2008 Subject: cvs commit: src/lib/libc/sys Makefile.inc Message-ID: <200804161444.m3GEiiCM039129@repoman.freebsd.org> ru 2008-04-16 14:44:43 UTC FreeBSD src repository Modified files: lib/libc/sys Makefile.inc Log: Connect newly added manpages to the build. Submitted by: kib Revision Changes Path 1.134 +15 -5 src/lib/libc/sys/Makefile.inc From jhb at freebsd.org Wed Apr 16 14:47:12 2008 From: jhb at freebsd.org (John Baldwin) Date: Wed Apr 16 14:47:45 2008 Subject: cvs commit: src/sys/ia64/ia64 sapic.c In-Reply-To: <200804142034.m3EKYjfs059229@repoman.freebsd.org> References: <200804142034.m3EKYjfs059229@repoman.freebsd.org> Message-ID: <200804160940.56271.jhb@freebsd.org> On Monday 14 April 2008 04:34:45 pm Marcel Moolenaar wrote: > marcel 2008-04-14 20:34:45 UTC > > FreeBSD src repository > > Modified files: > sys/ia64/ia64 sapic.c > Log: > Revision 1.9 changes the delivery mode from the magic constant 0 > (i.e. fixed delivery) to SAPIC_DELMODE_LOWPRI. While the commit > log doesn't mention the change in behaviour, it is believed to be > deliberate. In the last 5.5 years this hasn't been a problem. Nor > do I think did it make any difference, but who knows. However, I > do know that it break SMP support for Montecito-based machines. > Switch back to fixed-CPU delivery so that SMP works again. This > gives me some time to look more closely at the problem, as well > as make sure the I-cache validation as it's implemented currently > is sufficient in SMP configurations... Intel is deprecating the LOWPRI delivery mode on x86 CPUs with x2APIC, so I think it is probably best to switch to using FIXED mode on ia64 as well (x86 has used fixed mode since the new APIC code came in due to LOWPRI being effectively useless on P4 CPUs). -- John Baldwin From jhb at freebsd.org Wed Apr 16 14:47:13 2008 From: jhb at freebsd.org (John Baldwin) Date: Wed Apr 16 14:47:56 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-raid.c In-Reply-To: References: <200804131605.m3DG5Z9P041647@repoman.freebsd.org> <86wsn0zasa.fsf@ds4.des.no> Message-ID: <200804161008.01661.jhb@freebsd.org> On Monday 14 April 2008 01:09:23 pm S?ren Schmidt wrote: > Hi > > Yes, the registers used for setting up events when hotswap happens are > not accessible when in legacy compat mode. If all you need is for the AHCI BAR to have resources assigned newer FreeBSD kernels (at least 6.x and later) are smart enough to alloc resources for a BAR that the BIOS doesn't assign resources for when you do a bus_alloc_resource(). > -S?ren > > On 14Apr, 2008, at 18:00 , Dag-Erling Sm?rgrav wrote: > > S?ren Schmidt writes: > >> You have to set AHCI mode in the BIOS or the resources needed to use > >> it wont be available, so yes its software but not ours :) > > > > Thanks S?ren, I will make sure the BIOS is correctly configured. > > > > Does this also affect hotswap? I assume that the ICH8 supports it, > > but > > I haven't been able to make it work. > > > > DES > > -- > > Dag-Erling Sm?rgrav - des@des.no -- John Baldwin From ru at FreeBSD.org Wed Apr 16 14:57:41 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Wed Apr 16 14:57:47 2008 Subject: cvs commit: src/lib/libc/sys Makefile.inc Message-ID: <200804161457.m3GEvenD039688@repoman.freebsd.org> ru 2008-04-16 14:57:40 UTC FreeBSD src repository Modified files: lib/libc/sys Makefile.inc Log: Sort MAN and MLINKS. Revision Changes Path 1.135 +26 -25 src/lib/libc/sys/Makefile.inc From xcllnt at mac.com Wed Apr 16 16:39:07 2008 From: xcllnt at mac.com (Marcel Moolenaar) Date: Wed Apr 16 16:39:17 2008 Subject: cvs commit: src/sys/ia64/ia64 sapic.c In-Reply-To: <200804160940.56271.jhb@freebsd.org> References: <200804142034.m3EKYjfs059229@repoman.freebsd.org> <200804160940.56271.jhb@freebsd.org> Message-ID: <46D21F70-BEC7-4627-97D4-1DE71D0BEAD2@mac.com> On Apr 16, 2008, at 6:40 AM, John Baldwin wrote: > On Monday 14 April 2008 04:34:45 pm Marcel Moolenaar wrote: >> marcel 2008-04-14 20:34:45 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/ia64/ia64 sapic.c >> Log: >> Revision 1.9 changes the delivery mode from the magic constant 0 >> (i.e. fixed delivery) to SAPIC_DELMODE_LOWPRI. While the commit >> log doesn't mention the change in behaviour, it is believed to be >> deliberate. In the last 5.5 years this hasn't been a problem. Nor >> do I think did it make any difference, but who knows. However, I >> do know that it break SMP support for Montecito-based machines. >> Switch back to fixed-CPU delivery so that SMP works again. This >> gives me some time to look more closely at the problem, as well >> as make sure the I-cache validation as it's implemented currently >> is sufficient in SMP configurations... > > Intel is deprecating the LOWPRI delivery mode on x86 CPUs with > x2APIC, so I > think it is probably best to switch to using FIXED mode on ia64 as > well (x86 > has used fixed mode since the new APIC code came in due to LOWPRI > being > effectively useless on P4 CPUs). That's good to know. If LOWPRI has the same destiny in Itanium chipsets as it has in Pentium chipsets, then I might as well avoid the hassle of getting it to work. Though, I do like it when all CPUs share in the interrupt handling. Maybe I can do that more easily with MSI (which I still need to implement :-) Thanks, -- Marcel Moolenaar xcllnt@mac.com From kris at FreeBSD.org Wed Apr 16 16:47:18 2008 From: kris at FreeBSD.org (Kris Kennaway) Date: Wed Apr 16 16:47:29 2008 Subject: cvs commit: src/sys/dev/ieee488 ibfoo.c src/sys/dev/mfi mfi.c src/sys/dev/sound/midi mpu401.c src/sys/dev/usb if_aue.c src/sys/netgraph/netflow ng_netflow.c Message-ID: <200804161647.m3GGlG5n053270@repoman.freebsd.org> kris 2008-04-16 16:47:14 UTC FreeBSD src repository Modified files: sys/dev/ieee488 ibfoo.c sys/dev/mfi mfi.c sys/dev/sound/midi mpu401.c sys/dev/usb if_aue.c sys/netgraph/netflow ng_netflow.c Log: Replace callout_init(..., 1) with callout_init(..., CALLOUT_MPSAFE) for better grep-compliance and to standardize with the rest of the kernel. Reviewed by: jhb MFC after: 1 week Revision Changes Path 1.6 +1 -1 src/sys/dev/ieee488/ibfoo.c 1.37 +1 -1 src/sys/dev/mfi/mfi.c 1.4 +1 -1 src/sys/dev/sound/midi/mpu401.c 1.118 +1 -1 src/sys/dev/usb/if_aue.c 1.17 +1 -1 src/sys/netgraph/netflow/ng_netflow.c From xcllnt at mac.com Wed Apr 16 17:17:48 2008 From: xcllnt at mac.com (Marcel Moolenaar) Date: Wed Apr 16 17:17:54 2008 Subject: cvs commit: src/sys/boot/common dev_net.c src/sys/boot/uboot/lib console.c copy.c glue.c libuboot.h net.c time.c In-Reply-To: <4805DE07.8050008@semihalf.com> References: <200803121601.m2CG1ZbG072258@repoman.freebsd.org> <20080412221501.GB44768@alchemy.franken.de> <4805DE07.8050008@semihalf.com> Message-ID: <5B2C1F89-ADF7-4322-9753-5E7E1A79CD0E@mac.com> On Apr 16, 2008, at 4:07 AM, Rafal Jaworowski wrote: >> On at least sparc64 reverting this causes ofwn_init() to be called >> over and over again, which doesn't seem to be the right thing to do >> either. > > I think this is expected: the loader/libstand seem to call > devopen()->net_open(), devclose()->net_close() upon each file > access, but it > doesn't seem harmful, only additional output is seen in this case. The additional output is still an eyesore :-) Your change is correct, but it does expose a more fundamental problem with the loader for which we may not have the gumption to fix (as demonstrated by revision 1.7). The bottom-line being that we should not open and close devices wishy-washy. -- Marcel Moolenaar xcllnt@mac.com From rrs at FreeBSD.org Wed Apr 16 17:24:19 2008 From: rrs at FreeBSD.org (Randall Stewart) Date: Wed Apr 16 17:24:29 2008 Subject: cvs commit: src/sys/netinet sctp_asconf.c sctp_bsd_addr.c sctp_bsd_addr.h sctp_input.c sctp_output.c sctp_pcb.c sctp_pcb.h sctp_sysctl.c sctp_usrreq.c sctp_var.h sctputil.c sctputil.h src/sys/conf files Message-ID: <200804161724.m3GHOIlj058097@repoman.freebsd.org> rrs 2008-04-16 17:24:18 UTC FreeBSD src repository Modified files: sys/netinet sctp_asconf.c sctp_bsd_addr.c sctp_bsd_addr.h sctp_input.c sctp_output.c sctp_pcb.c sctp_pcb.h sctp_sysctl.c sctp_usrreq.c sctp_var.h sctputil.c sctputil.h sys/conf files Log: Allow SCTP to compile without INET6. PR: 116816 Obtained from tuexen@fh-muenster.de: MFC after: 2 weeks Revision Changes Path 1.1290 +14 -14 src/sys/conf/files 1.35 +138 -102 src/sys/netinet/sctp_asconf.c 1.18 +2 -1 src/sys/netinet/sctp_bsd_addr.c 1.7 +3 -0 src/sys/netinet/sctp_bsd_addr.h 1.69 +42 -25 src/sys/netinet/sctp_input.c 1.69 +490 -279 src/sys/netinet/sctp_output.c 1.67 +471 -316 src/sys/netinet/sctp_pcb.c 1.33 +3 -0 src/sys/netinet/sctp_pcb.h 1.17 +37 -22 src/sys/netinet/sctp_sysctl.c 1.54 +132 -83 src/sys/netinet/sctp_usrreq.c 1.23 +0 -2 src/sys/netinet/sctp_var.h 1.74 +201 -119 src/sys/netinet/sctputil.c 1.31 +3 -1 src/sys/netinet/sctputil.h From rrs at FreeBSD.org Wed Apr 16 17:40:31 2008 From: rrs at FreeBSD.org (Randall Stewart) Date: Wed Apr 16 17:40:42 2008 Subject: cvs commit: src/usr.bin/netstat sctp.c Message-ID: <200804161740.m3GHeVqK058781@repoman.freebsd.org> rrs 2008-04-16 17:40:30 UTC FreeBSD src repository Modified files: usr.bin/netstat sctp.c Log: Fixes typo's in sctp.c Revision Changes Path 1.10 +4 -4 src/usr.bin/netstat/sctp.c From sos at FreeBSD.org Wed Apr 16 17:56:27 2008 From: sos at FreeBSD.org (=?ISO-8859-1?Q?S=F8ren_Schmidt?=) Date: Wed Apr 16 17:56:34 2008 Subject: cvs commit: src/sys/dev/ata ata-all.h ata-raid.c In-Reply-To: <200804161008.01661.jhb@freebsd.org> References: <200804131605.m3DG5Z9P041647@repoman.freebsd.org> <86wsn0zasa.fsf@ds4.des.no> <200804161008.01661.jhb@freebsd.org> Message-ID: Hi ATA has done this for a long time for AHCI, if needed resources are there it will go for AHCI and try to use it for known chipsets. What is relatively new in ATA is that it will go for chipsets that claim to be AHCI compliant via the PCI "progif" register, however the AHCI BAR still needs to be populated for it to be able to grap resources needed. However some BIOS's effectively disables AHCI BAR's etc when its not selected, not much we can do about that, or at least it will be a nightmare to support. -S?ren On 16Apr, 2008, at 16:08 , John Baldwin wrote: > On Monday 14 April 2008 01:09:23 pm S?ren Schmidt wrote: >> Hi >> >> Yes, the registers used for setting up events when hotswap happens >> are >> not accessible when in legacy compat mode. > > If all you need is for the AHCI BAR to have resources assigned newer > FreeBSD > kernels (at least 6.x and later) are smart enough to alloc resources > for a > BAR that the BIOS doesn't assign resources for when you do a > bus_alloc_resource(). > >> -S?ren >> >> On 14Apr, 2008, at 18:00 , Dag-Erling Sm?rgrav wrote: >>> S?ren Schmidt writes: >>>> You have to set AHCI mode in the BIOS or the resources needed to >>>> use >>>> it wont be available, so yes its software but not ours :) >>> >>> Thanks S?ren, I will make sure the BIOS is correctly configured. >>> >>> Does this also affect hotswap? I assume that the ICH8 supports it, >>> but >>> I haven't been able to make it work. >>> >>> DES >>> -- >>> Dag-Erling Sm?rgrav - des@des.no > > > > -- > John Baldwin > > From delphij at FreeBSD.org Wed Apr 16 18:40:52 2008 From: delphij at FreeBSD.org (Xin LI) Date: Wed Apr 16 18:41:02 2008 Subject: cvs commit: src/lib/libc/gen opendir.c Message-ID: <200804161840.m3GIeq7T062093@repoman.freebsd.org> delphij 2008-04-16 18:40:52 UTC FreeBSD src repository Modified files: lib/libc/gen opendir.c Log: Style fixes to opendir.c: - Use /*- for copyright block; - ANSIfy. Revision Changes Path 1.24 +3 -6 src/lib/libc/gen/opendir.c From remko at FreeBSD.org Wed Apr 16 18:49:16 2008 From: remko at FreeBSD.org (Remko Lodder) Date: Wed Apr 16 18:49:26 2008 Subject: cvs commit: src/usr.sbin/sysinstall menus.c Message-ID: <200804161849.m3GInFBk062347@repoman.freebsd.org> remko 2008-04-16 18:49:15 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) usr.sbin/sysinstall menus.c Log: MFC rev 1.431 menus.c Remove ftp.hk.super.net, the DNS isn't pointing to anything at the moment. I tested this as well as the submitter and couldn't resolve this either, since I dont want to "announce" dead mirrors, I'll remove it from the list. PR: 122567 Submitted by: vs Approved by: imp (mentor, implicit for trivial changes) MFC after: 1 week Approved by: imp (mentor, implicit) Revision Changes Path 1.425.2.6 +0 -3 src/usr.sbin/sysinstall/menus.c From remko at FreeBSD.org Wed Apr 16 18:50:05 2008 From: remko at FreeBSD.org (Remko Lodder) Date: Wed Apr 16 18:50:16 2008 Subject: cvs commit: src/usr.sbin/sysinstall menus.c Message-ID: <200804161850.m3GIo4mN062425@repoman.freebsd.org> remko 2008-04-16 18:50:04 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) usr.sbin/sysinstall menus.c Log: MFC rev 1.431 menus.c Remove ftp.hk.super.net, the DNS isn't pointing to anything at the moment. I tested this as well as the submitter and couldn't resolve this either, since I dont want to "announce" dead mirrors, I'll remove it from the list. PR: 122567 Submitted by: vs Approved by: imp (mentor, implicit for trivial changes) MFC after: 1 week Approved by: imp (mentor, implicit) Revision Changes Path 1.410.2.15 +0 -3 src/usr.sbin/sysinstall/menus.c From remko at FreeBSD.org Wed Apr 16 18:54:09 2008 From: remko at FreeBSD.org (Remko Lodder) Date: Wed Apr 16 18:54:21 2008 Subject: cvs commit: src/sbin/geom/class/journal gjournal.8 Message-ID: <200804161854.m3GIs8Qn062543@repoman.freebsd.org> remko 2008-04-16 18:54:08 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sbin/geom/class/journal gjournal.8 Log: MFC rev 1.4 gjournal.8 Add missing device in tunefs entry. PR: docs/122702 Submitted by: Yoshihiro Ota MFC After: 3 days MFC rev 1.5 gjournal.8 I keep taking timemachines to get back in time. Update the year to 2008. Noticed by: ceri Revision Changes Path 1.1.2.2 +2 -2 src/sbin/geom/class/journal/gjournal.8 From delphij at FreeBSD.org Wed Apr 16 18:59:36 2008 From: delphij at FreeBSD.org (Xin LI) Date: Wed Apr 16 18:59:38 2008 Subject: cvs commit: src/include dirent.h src/lib/libc/gen Makefile.inc Symbol.map directory.3 opendir.c src/sys/sys param.h Message-ID: <200804161859.m3GIxaBq062780@repoman.freebsd.org> delphij 2008-04-16 18:59:36 UTC FreeBSD src repository Modified files: include dirent.h lib/libc/gen Makefile.inc Symbol.map directory.3 opendir.c sys/sys param.h Log: Implement fdopendir(3) by splitting __opendir2() into two parts, the upper part deals with the usual __opendir2() calls, and the rest part with an interface translator to expose fdopendir(3) functionality. Manual page was obtained from kib@'s work for *at(2) system calls. Revision Changes Path 1.16 +1 -0 src/include/dirent.h 1.135 +1 -0 src/lib/libc/gen/Makefile.inc 1.10 +1 -0 src/lib/libc/gen/Symbol.map 1.17 +38 -1 src/lib/libc/gen/directory.3 1.25 +31 -5 src/lib/libc/gen/opendir.c 1.351 +1 -1 src/sys/sys/param.h From jkim at FreeBSD.org Wed Apr 16 19:25:40 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Wed Apr 16 19:25:42 2008 Subject: cvs commit: src/sys/amd64/linux32 linux32_dummy.c syscalls.master src/sys/i386/linux linux_dummy.c syscalls.master Message-ID: <200804161925.m3GJPeEi066193@repoman.freebsd.org> jkim 2008-04-16 19:25:39 UTC FreeBSD src repository Modified files: sys/amd64/linux32 linux32_dummy.c syscalls.master sys/i386/linux linux_dummy.c syscalls.master Log: Add stubs for syscalls introduced in Linux 2.6.17 kernel. Some GNU libc version started using them before 2.6.17 was officially out. MFC after: 3 days Revision Changes Path 1.11 +6 -0 src/sys/amd64/linux32/linux32_dummy.c 1.33 +6 -0 src/sys/amd64/linux32/syscalls.master 1.48 +6 -0 src/sys/i386/linux/linux_dummy.c 1.92 +6 -0 src/sys/i386/linux/syscalls.master From jkim at FreeBSD.org Wed Apr 16 19:27:36 2008 From: jkim at FreeBSD.org (Jung-uk Kim) Date: Wed Apr 16 19:27:48 2008 Subject: cvs commit: src/sys/amd64/linux32 linux32_proto.h linux32_syscall.h linux32_sysent.c src/sys/i386/linux linux_proto.h linux_syscall.h linux_sysent.c Message-ID: <200804161927.m3GJRak5066349@repoman.freebsd.org> jkim 2008-04-16 19:27:36 UTC FreeBSD src repository Modified files: sys/amd64/linux32 linux32_proto.h linux32_syscall.h linux32_sysent.c sys/i386/linux linux_proto.h linux_syscall.h linux_sysent.c Log: Regenerate. Revision Changes Path 1.36 +31 -1 src/sys/amd64/linux32/linux32_proto.h 1.36 +8 -2 src/sys/amd64/linux32/linux32_syscall.h 1.36 +7 -1 src/sys/amd64/linux32/linux32_sysent.c 1.98 +31 -1 src/sys/i386/linux/linux_proto.h 1.90 +8 -2 src/sys/i386/linux/linux_syscall.h 1.97 +7 -1 src/sys/i386/linux/linux_sysent.c From mav at FreeBSD.org Wed Apr 16 19:52:30 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Wed Apr 16 19:52:36 2008 Subject: cvs commit: src/sys/netgraph ng_base.c Message-ID: <200804161952.m3GJqTZb067227@repoman.freebsd.org> mav 2008-04-16 19:52:29 UTC FreeBSD src repository Modified files: sys/netgraph ng_base.c Log: Use separate UMA zone for data items allocation. It is a partial rev. 1.149 rework. It allows to save several percents of CPU time on SMP by using UMA's internal per-CPU allocation limits instead of own global variable each time updated with atomics. Tested with: Netperf cluster Revision Changes Path 1.158 +70 -40 src/sys/netgraph/ng_base.c From stas at FreeBSD.org Wed Apr 16 21:15:11 2008 From: stas at FreeBSD.org (Stanislav Sedov) Date: Wed Apr 16 21:15:18 2008 Subject: cvs commit: src/sys/dev/usb uipaq.c Message-ID: <200804162115.m3GLFAGS081169@repoman.freebsd.org> stas 2008-04-16 21:15:10 UTC FreeBSD src repository (ports committer) Modified files: sys/dev/usb uipaq.c Log: - Correctly destroy assoiciated ucom device on detach. MFC after: 2 weeks Reported by: Ilya Bakulin Approved by: imp, cognet Revision Changes Path 1.9 +2 -0 src/sys/dev/usb/uipaq.c From marcel at FreeBSD.org Wed Apr 16 23:28:12 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Wed Apr 16 23:28:19 2008 Subject: cvs commit: src/sys/powerpc/aim locore.S machdep.c mmu_oea.c Message-ID: <200804162328.m3GNSCGj088725@repoman.freebsd.org> marcel 2008-04-16 23:28:12 UTC FreeBSD src repository Modified files: sys/powerpc/aim locore.S machdep.c mmu_oea.c Log: Allocate a stack (with optional guard pages) for thread0 and switch to it before calling mi_startup(). Revision Changes Path 1.26 +3 -0 src/sys/powerpc/aim/locore.S 1.112 +9 -14 src/sys/powerpc/aim/machdep.c 1.118 +48 -56 src/sys/powerpc/aim/mmu_oea.c From cperciva at FreeBSD.org Wed Apr 16 23:58:34 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Wed Apr 16 23:58:43 2008 Subject: cvs commit: src/crypto/openssh channels.c Message-ID: <200804162358.m3GNwXTk089709@repoman.freebsd.org> cperciva 2008-04-16 23:58:33 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) crypto/openssh channels.c Log: Fix logic error in sshd(8) concerning the handling of failed attempts to bind ports for X11 forwarding. Security: FreeBSD-SA-08:05.openssh Revision Changes Path 1.23.2.1 +0 -3 src/crypto/openssh/channels.c From cperciva at FreeBSD.org Wed Apr 16 23:58:53 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Wed Apr 16 23:59:04 2008 Subject: cvs commit: src UPDATING src/crypto/openssh channels.c src/sys/conf newvers.sh Message-ID: <200804162358.m3GNwqvU089781@repoman.freebsd.org> cperciva 2008-04-16 23:58:52 UTC FreeBSD src repository Modified files: (Branch: RELENG_7_0) . UPDATING crypto/openssh channels.c sys/conf newvers.sh Log: Fix logic error in sshd(8) concerning the handling of failed attempts to bind ports for X11 forwarding. Security: FreeBSD-SA-08:05.openssh Approved by: so (cperciva) Revision Changes Path 1.507.2.3.2.5 +4 -0 src/UPDATING 1.23.4.1 +0 -3 src/crypto/openssh/channels.c 1.72.2.5.2.5 +1 -1 src/sys/conf/newvers.sh From cperciva at FreeBSD.org Wed Apr 16 23:59:35 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Wed Apr 16 23:59:46 2008 Subject: cvs commit: src/crypto/openssh channels.c Message-ID: <200804162359.m3GNxZlK089819@repoman.freebsd.org> cperciva 2008-04-16 23:59:35 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) crypto/openssh channels.c Log: Fix logic error in sshd(8) concerning the handling of failed attempts to bind ports for X11 forwarding. Security: FreeBSD-SA-08:05.openssh Revision Changes Path 1.20.2.3 +0 -3 src/crypto/openssh/channels.c From cperciva at FreeBSD.org Wed Apr 16 23:59:49 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Wed Apr 16 23:59:54 2008 Subject: cvs commit: src UPDATING src/crypto/openssh channels.c src/lib/libpthread/sys lock.c src/lib/libpthread/thread thr_kern.c src/sys/conf newvers.sh Message-ID: <200804162359.m3GNxmQL089930@repoman.freebsd.org> cperciva 2008-04-16 23:59:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) . UPDATING crypto/openssh channels.c lib/libpthread/sys lock.c lib/libpthread/thread thr_kern.c sys/conf newvers.sh Log: Fix logic error in sshd(8) concerning the handling of failed attempts to bind ports for X11 forwarding. Security: FreeBSD-SA-08:05.openssh Approved by: so (cperciva) Revision Changes Path 1.416.2.37.2.6 +7 -0 src/UPDATING 1.20.2.2.4.1 +0 -3 src/crypto/openssh/channels.c 1.9.2.1.8.1 +17 -8 src/lib/libpthread/sys/lock.c 1.116.2.1.6.1 +25 -0 src/lib/libpthread/thread/thr_kern.c 1.69.2.15.2.5 +1 -1 src/sys/conf/newvers.sh From cperciva at FreeBSD.org Thu Apr 17 00:00:04 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Thu Apr 17 00:00:15 2008 Subject: cvs commit: src UPDATING src/crypto/openssh channels.c src/sys/conf newvers.sh Message-ID: <200804170000.m3H004Cl090022@repoman.freebsd.org> cperciva 2008-04-17 00:00:04 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_2) . UPDATING crypto/openssh channels.c sys/conf newvers.sh Log: Fix logic error in sshd(8) concerning the handling of failed attempts to bind ports for X11 forwarding. Security: FreeBSD-SA-08:05.openssh Approved by: so (cperciva) Revision Changes Path 1.416.2.29.2.16 +4 -0 src/UPDATING 1.20.2.2.2.1 +0 -3 src/crypto/openssh/channels.c 1.69.2.13.2.15 +1 -1 src/sys/conf/newvers.sh From cperciva at FreeBSD.org Thu Apr 17 00:00:29 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Thu Apr 17 00:00:35 2008 Subject: cvs commit: src UPDATING src/crypto/openssh channels.c src/sys/conf newvers.sh Message-ID: <200804170000.m3H00SID090154@repoman.freebsd.org> cperciva 2008-04-17 00:00:28 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_1) . UPDATING crypto/openssh channels.c sys/conf newvers.sh Log: Fix logic error in sshd(8) concerning the handling of failed attempts to bind ports for X11 forwarding. Security: FreeBSD-SA-08:05.openssh Approved by: so (cperciva) Revision Changes Path 1.416.2.22.2.27 +4 -0 src/UPDATING 1.20.2.1.4.1 +0 -3 src/crypto/openssh/channels.c 1.69.2.11.2.26 +1 -1 src/sys/conf/newvers.sh From cperciva at FreeBSD.org Thu Apr 17 00:00:42 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Thu Apr 17 00:00:44 2008 Subject: cvs commit: src/crypto/openssh channels.c Message-ID: <200804170000.m3H00fcA090199@repoman.freebsd.org> cperciva 2008-04-17 00:00:41 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) crypto/openssh channels.c Log: Fix logic error in sshd(8) concerning the handling of failed attempts to bind ports for X11 forwarding. Security: FreeBSD-SA-08:05.openssh Revision Changes Path 1.18.2.1 +0 -3 src/crypto/openssh/channels.c From cperciva at FreeBSD.org Thu Apr 17 00:00:54 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Thu Apr 17 00:01:00 2008 Subject: cvs commit: src UPDATING src/crypto/openssh channels.c src/sys/conf newvers.sh Message-ID: <200804170000.m3H00sA7090286@repoman.freebsd.org> cperciva 2008-04-17 00:00:54 UTC FreeBSD src repository Modified files: (Branch: RELENG_5_5) . UPDATING crypto/openssh channels.c sys/conf newvers.sh Log: Fix logic error in sshd(8) concerning the handling of failed attempts to bind ports for X11 forwarding. Security: FreeBSD-SA-08:05.openssh Approved by: so (cperciva) Revision Changes Path 1.342.2.35.2.21 +4 -0 src/UPDATING 1.18.8.1 +0 -3 src/crypto/openssh/channels.c 1.62.2.21.2.22 +1 -1 src/sys/conf/newvers.sh From cperciva at FreeBSD.org Thu Apr 17 00:02:20 2008 From: cperciva at FreeBSD.org (Colin Percival) Date: Thu Apr 17 00:02:22 2008 Subject: cvs commit: src UPDATING src/sys/conf newvers.sh src/crypto/openssh channels.c src/lib/libpthread/sys lock.c src/lib/libpthread/thread thr_kern.c Message-ID: <200804170002.m3H02KSS090421@repoman.freebsd.org> cperciva 2008-04-17 00:02:20 UTC FreeBSD src repository Modified files: (Branch: RELENG_6_3) . UPDATING sys/conf newvers.sh crypto/openssh channels.c lib/libpthread/sys lock.c lib/libpthread/thread thr_kern.c Log: Forced commit to note that the previous commit message should have been: Fix logic error in sshd(8) concerning the handling of failed attempts to bind ports for X11 forwarding. [SA-08:05] Fix issues with threaded programs calling fork(2). [EN-08:01] Security: FreeBSD-SA-08:05.openssh Errata: FreeBSD-EN-08:01.libpthread Approved by: so (cperciva) Revision Changes Path 1.416.2.37.2.7 +0 -0 src/UPDATING 1.20.2.2.4.2 +0 -0 src/crypto/openssh/channels.c 1.9.2.1.8.2 +0 -0 src/lib/libpthread/sys/lock.c 1.116.2.1.6.2 +0 -0 src/lib/libpthread/thread/thr_kern.c 1.69.2.15.2.6 +0 -0 src/sys/conf/newvers.sh From marcel at FreeBSD.org Thu Apr 17 00:37:41 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Thu Apr 17 00:37:52 2008 Subject: cvs commit: src/sys/powerpc/aim mmu_oea.c Message-ID: <200804170037.m3H0bfLn092821@repoman.freebsd.org> marcel 2008-04-17 00:37:40 UTC FreeBSD src repository Modified files: sys/powerpc/aim mmu_oea.c Log: Simplify the pmap_zero_page family of functions by making use of the fact that we have a 1:1 mapping by virtue of the BATs. Eliminate the now unused moea_rkva_alloc(), moea_pa_map() and moea_pa_unmap() functions. Pointed out by: grehan. Revision Changes Path 1.119 +6 -160 src/sys/powerpc/aim/mmu_oea.c From delphij at FreeBSD.org Thu Apr 17 00:48:32 2008 From: delphij at FreeBSD.org (Xin LI) Date: Thu Apr 17 00:48:34 2008 Subject: cvs commit: src/contrib/bzip2 CHANGES FREEBSD-Xlist FREEBSD-upgrade LICENSE Makefile Makefile-libbz2_so README README.COMPILATION.PROBLEMS blocksort.c bzip2.c bzip2recover.c bzlib.c bzlib.h bzlib_private.h compress.c crctable.c decompress.c ... Message-ID: <200804170048.m3H0mUxM002608@repoman.freebsd.org> delphij 2008-04-17 00:48:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) contrib/bzip2 CHANGES LICENSE Makefile Makefile-libbz2_so README README.COMPILATION.PROBLEMS blocksort.c bzip2.c bzip2recover.c bzlib.c bzlib.h bzlib_private.h compress.c crctable.c decompress.c huffman.c randtable.c spewG.c unzcrash.c Removed files: (Branch: RELENG_7) contrib/bzip2 FREEBSD-Xlist FREEBSD-upgrade Log: MFC: bzip2 1.0.5 Revision Changes Path 1.1.1.4.2.1 +7 -2 src/contrib/bzip2/CHANGES 1.1.10.1 +0 -24 src/contrib/bzip2/FREEBSD-Xlist (dead) 1.4.2.1 +0 -27 src/contrib/bzip2/FREEBSD-upgrade (dead) 1.1.1.4.2.1 +3 -4 src/contrib/bzip2/LICENSE 1.1.1.4.2.1 +3 -3 src/contrib/bzip2/Makefile 1.1.1.4.2.1 +2 -2 src/contrib/bzip2/Makefile-libbz2_so 1.1.1.4.2.1 +7 -2 src/contrib/bzip2/README 1.1.1.4.2.1 +3 -3 src/contrib/bzip2/README.COMPILATION.PROBLEMS 1.1.1.4.2.1 +2 -2 src/contrib/bzip2/blocksort.c 1.3.2.1 +4 -4 src/contrib/bzip2/bzip2.c 1.1.1.4.2.1 +3 -3 src/contrib/bzip2/bzip2recover.c 1.3.2.1 +5 -4 src/contrib/bzip2/bzlib.c 1.1.1.4.2.1 +2 -2 src/contrib/bzip2/bzlib.h 1.1.1.4.2.1 +11 -5 src/contrib/bzip2/bzlib_private.h 1.1.1.4.2.1 +2 -2 src/contrib/bzip2/compress.c 1.1.1.4.2.1 +2 -2 src/contrib/bzip2/crctable.c 1.1.1.4.2.1 +2 -2 src/contrib/bzip2/decompress.c 1.1.1.4.2.1 +2 -2 src/contrib/bzip2/huffman.c 1.1.1.4.2.1 +2 -2 src/contrib/bzip2/randtable.c 1.1.1.2.2.1 +2 -2 src/contrib/bzip2/spewG.c 1.1.1.2.2.1 +2 -2 src/contrib/bzip2/unzcrash.c From delphij at FreeBSD.org Thu Apr 17 00:49:20 2008 From: delphij at FreeBSD.org (Xin LI) Date: Thu Apr 17 00:49:26 2008 Subject: cvs commit: src/contrib/bzip2 CHANGES FREEBSD-Xlist FREEBSD-upgrade LICENSE Makefile Makefile-libbz2_so README README.COMPILATION.PROBLEMS blocksort.c bzip2.c bzip2recover.c bzlib.c bzlib.h bzlib_private.h compress.c crctable.c decompress.c ... Message-ID: <200804170049.m3H0nJvo002716@repoman.freebsd.org> delphij 2008-04-17 00:49:19 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) contrib/bzip2 CHANGES LICENSE Makefile Makefile-libbz2_so README README.COMPILATION.PROBLEMS blocksort.c bzip2.c bzip2recover.c bzlib.c bzlib.h bzlib_private.h compress.c crctable.c decompress.c huffman.c randtable.c spewG.c unzcrash.c Removed files: (Branch: RELENG_6) contrib/bzip2 FREEBSD-Xlist FREEBSD-upgrade Log: MFC: bzip2 1.0.5 Revision Changes Path 1.1.1.3.2.2 +7 -2 src/contrib/bzip2/CHANGES 1.1.2.1 +0 -24 src/contrib/bzip2/FREEBSD-Xlist (dead) 1.2.2.2 +0 -27 src/contrib/bzip2/FREEBSD-upgrade (dead) 1.1.1.3.2.2 +3 -4 src/contrib/bzip2/LICENSE 1.1.1.3.2.2 +3 -3 src/contrib/bzip2/Makefile 1.1.1.3.2.2 +2 -2 src/contrib/bzip2/Makefile-libbz2_so 1.1.1.3.2.2 +7 -2 src/contrib/bzip2/README 1.1.1.3.2.2 +3 -3 src/contrib/bzip2/README.COMPILATION.PROBLEMS 1.1.1.3.2.2 +2 -2 src/contrib/bzip2/blocksort.c 1.2.2.2 +4 -4 src/contrib/bzip2/bzip2.c 1.1.1.3.2.2 +3 -3 src/contrib/bzip2/bzip2recover.c 1.2.2.2 +4 -3 src/contrib/bzip2/bzlib.c 1.1.1.3.2.2 +2 -2 src/contrib/bzip2/bzlib.h 1.1.1.3.2.2 +11 -5 src/contrib/bzip2/bzlib_private.h 1.1.1.3.2.2 +2 -2 src/contrib/bzip2/compress.c 1.1.1.3.2.2 +2 -2 src/contrib/bzip2/crctable.c 1.1.1.3.2.2 +2 -2 src/contrib/bzip2/decompress.c 1.1.1.3.2.2 +2 -2 src/contrib/bzip2/huffman.c 1.1.1.3.2.2 +2 -2 src/contrib/bzip2/randtable.c 1.1.1.1.16.2 +2 -2 src/contrib/bzip2/spewG.c 1.1.1.1.16.2 +2 -2 src/contrib/bzip2/unzcrash.c From delphij at FreeBSD.org Thu Apr 17 00:53:16 2008 From: delphij at FreeBSD.org (Xin LI) Date: Thu Apr 17 00:53:21 2008 Subject: cvs commit: src/contrib/bzip2 CHANGES FREEBSD-upgrade LICENSE Makefile Makefile-libbz2_so README README.COMPILATION.PROBLEMS Y2K_INFO blocksort.c bzip2.1 bzip2.c bzip2recover.c bzlib.c bzlib.h bzlib_private.h compress.c crctable.c decompress.c ... Message-ID: <200804170053.m3H0rFxA003001@repoman.freebsd.org> delphij 2008-04-17 00:53:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) contrib/bzip2 CHANGES LICENSE Makefile Makefile-libbz2_so README README.COMPILATION.PROBLEMS blocksort.c bzip2.1 bzip2.c bzip2recover.c bzlib.c bzlib.h bzlib_private.h compress.c crctable.c decompress.c dlltest.c huffman.c randtable.c sample1.ref.gz.uu sample2.ref.gz.uu sample3.ref.gz.uu spewG.c unzcrash.c words0 words2 words3 usr.bin/bzip2 Makefile Removed files: (Branch: RELENG_5) contrib/bzip2 FREEBSD-upgrade Y2K_INFO manual.texi usr.bin/bzip2/doc Makefile manual.texi.diff Log: MFC: bzip2 1.0.5 Revision Changes Path 1.1.1.2.8.1 +66 -0 src/contrib/bzip2/CHANGES 1.1.14.1 +0 -32 src/contrib/bzip2/FREEBSD-upgrade (dead) 1.1.1.2.8.1 +8 -5 src/contrib/bzip2/LICENSE 1.1.1.2.8.1 +51 -26 src/contrib/bzip2/Makefile 1.1.1.2.8.1 +23 -8 src/contrib/bzip2/Makefile-libbz2_so 1.1.1.2.8.1 +75 -46 src/contrib/bzip2/README 1.1.1.2.8.1 +29 -101 src/contrib/bzip2/README.COMPILATION.PROBLEMS 1.1.1.1.10.1 +0 -34 src/contrib/bzip2/Y2K_INFO (dead) 1.1.1.2.8.1 +15 -62 src/contrib/bzip2/blocksort.c 1.1.1.2.8.1 +9 -8 src/contrib/bzip2/bzip2.1 1.1.1.2.8.2 +55 -149 src/contrib/bzip2/bzip2.c 1.1.1.2.8.1 +29 -61 src/contrib/bzip2/bzip2recover.c 1.1.1.2.8.2 +37 -72 src/contrib/bzip2/bzlib.c 1.1.1.2.8.1 +16 -55 src/contrib/bzip2/bzlib.h 1.1.1.2.8.1 +35 -63 src/contrib/bzip2/bzlib_private.h 1.1.1.2.8.2 +21 -65 src/contrib/bzip2/compress.c 1.1.1.2.8.1 +13 -53 src/contrib/bzip2/crctable.c 1.1.1.2.8.2 +13 -53 src/contrib/bzip2/decompress.c 1.1.1.2.8.1 +2 -3 src/contrib/bzip2/dlltest.c 1.1.1.2.8.2 +13 -53 src/contrib/bzip2/huffman.c 1.1.1.2.8.1 +0 -2243 src/contrib/bzip2/manual.texi (dead) 1.1.1.2.8.1 +13 -53 src/contrib/bzip2/randtable.c 1.1.1.2.8.1 +847 -845 src/contrib/bzip2/sample1.ref.gz.uu 1.1.1.1.10.1 +1343 -1342 src/contrib/bzip2/sample2.ref.gz.uu 1.1.1.1.10.1 +1 -1 src/contrib/bzip2/sample3.ref.gz.uu 1.1.1.1.10.1 +15 -0 src/contrib/bzip2/spewG.c 1.1.1.1.10.1 +16 -1 src/contrib/bzip2/unzcrash.c 1.1.1.1.10.1 +5 -1 src/contrib/bzip2/words0 1.1.1.1.10.1 +1 -1 src/contrib/bzip2/words2 1.1.1.2.8.1 +10 -3 src/contrib/bzip2/words3 1.7.4.1 +0 -3 src/usr.bin/bzip2/Makefile 1.2.8.1 +0 -14 src/usr.bin/bzip2/doc/Makefile (dead) 1.1.14.1 +0 -22 src/usr.bin/bzip2/doc/manual.texi.diff (dead) From delphij at FreeBSD.org Thu Apr 17 00:57:35 2008 From: delphij at FreeBSD.org (Xin LI) Date: Thu Apr 17 00:57:39 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml Message-ID: <200804170057.m3H0vY0k003214@repoman.freebsd.org> delphij 2008-04-17 00:57:34 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes article.sgml Log: Mention bzip2 1.0.5 MFC. Revision Changes Path 1.1085 +1 -1 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml From delphij at FreeBSD.org Thu Apr 17 00:58:51 2008 From: delphij at FreeBSD.org (Xin LI) Date: Thu Apr 17 00:58:52 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml Message-ID: <200804170058.m3H0wovK003255@repoman.freebsd.org> delphij 2008-04-17 00:58:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) release/doc/en_US.ISO8859-1/relnotes article.sgml Log: Mention bzip2 1.0.5 MFC. Revision Changes Path 1.1068.2.25 +3 -0 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml From delphij at FreeBSD.org Thu Apr 17 01:00:55 2008 From: delphij at FreeBSD.org (Xin LI) Date: Thu Apr 17 01:01:03 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml Message-ID: <200804170100.m3H10taf003403@repoman.freebsd.org> delphij 2008-04-17 01:00:55 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: Mention bzip2 1.0.5 MFC. Revision Changes Path 1.883.2.92 +3 -0 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From delphij at FreeBSD.org Thu Apr 17 01:02:03 2008 From: delphij at FreeBSD.org (Xin LI) Date: Thu Apr 17 01:02:12 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes/common new.sgml Message-ID: <200804170102.m3H123gP003465@repoman.freebsd.org> delphij 2008-04-17 01:02:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) release/doc/en_US.ISO8859-1/relnotes/common new.sgml Log: Mention bzip2 1.0.5 MFC. Revision Changes Path 1.761.2.88 +3 -0 src/release/doc/en_US.ISO8859-1/relnotes/common/new.sgml From jb at FreeBSD.org Thu Apr 17 01:23:40 2008 From: jb at FreeBSD.org (John Birrell) Date: Thu Apr 17 01:23:49 2008 Subject: cvs commit: src/cddl/compat/opensolaris/include devid.h fsshare.h libintl.h mnttab.h priv.h solaris.h zone.h src/cddl/compat/opensolaris/lib/libumem umem.c umem.h src/cddl/compat/opensolaris/misc deviceid.c fsshare.c mkdirp.c ... Message-ID: <200804170123.m3H1Ne1j006534@repoman.freebsd.org> jb 2008-04-17 01:23:40 UTC FreeBSD src repository Added files: (Branch: RELENG_7) cddl/compat/opensolaris/include devid.h fsshare.h libintl.h mnttab.h priv.h solaris.h zone.h cddl/compat/opensolaris/lib/libumem umem.c umem.h cddl/compat/opensolaris/misc deviceid.c fsshare.c mkdirp.c mnttab.c zmount.c zone.c cddl/contrib/opensolaris OPENSOLARIS.LICENSE cddl/contrib/opensolaris/cmd/zdb zdb.8 zdb.c zdb_il.c cddl/contrib/opensolaris/cmd/zfs zfs.8 zfs_iter.c zfs_iter.h zfs_main.c zfs_util.h cddl/contrib/opensolaris/cmd/zpool zpool.8 zpool_iter.c zpool_main.c zpool_util.c zpool_util.h zpool_vdev.c cddl/contrib/opensolaris/cmd/ztest ztest.c cddl/contrib/opensolaris/head assert.h atomic.h libintl.h stdio_ext.h synch.h thread.h cddl/contrib/opensolaris/lib/libnvpair libnvpair.c libnvpair.h nvpair_alloc_system.c cddl/contrib/opensolaris/lib/libuutil/common libuutil.h libuutil_common.h libuutil_impl.h uu_alloc.c uu_avl.c uu_dprintf.c uu_ident.c uu_list.c uu_misc.c uu_open.c uu_pname.c uu_strtoint.c cddl/contrib/opensolaris/lib/libzfs/common libzfs.h libzfs_changelist.c libzfs_config.c libzfs_dataset.c libzfs_graph.c libzfs_impl.h libzfs_import.c libzfs_mount.c libzfs_pool.c libzfs_status.c libzfs_util.c cddl/contrib/opensolaris/lib/libzpool/common kernel.c taskq.c util.c cddl/contrib/opensolaris/lib/libzpool/common/sys zfs_context.h sys/cddl/compat/opensolaris/kern opensolaris_atomic.c opensolaris_kmem.c opensolaris_kobj.c opensolaris_kstat.c opensolaris_misc.c opensolaris_policy.c opensolaris_string.c opensolaris_vfs.c opensolaris_zone.c sys/cddl/compat/opensolaris/machine endian.h sys/cddl/compat/opensolaris/rpc xdr.h sys/cddl/compat/opensolaris/sys acl.h atomic.h byteorder.h callb.h cmn_err.h cred.h debug.h dirent.h dkio.h dnlc.h kcondvar.h kmem.h kobj.h kstat.h lock.h misc.h mntent.h mnttab.h mount.h mutex.h policy.h proc.h random.h rwlock.h sdt.h string.h sunddi.h sysmacros.h systm.h taskq.h taskq_impl.h time.h types.h uio.h varargs.h vfs.h vnode.h zone.h sys/cddl/contrib/opensolaris/common/acl acl_common.c acl_common.h sys/cddl/contrib/opensolaris/common/atomic/amd64 atomic.S sys/cddl/contrib/opensolaris/common/atomic/i386 atomic.S sys/cddl/contrib/opensolaris/common/atomic/ia64 atomic.S sys/cddl/contrib/opensolaris/common/avl avl.c sys/cddl/contrib/opensolaris/common/nvpair nvpair.c nvpair_alloc_fixed.c sys/cddl/contrib/opensolaris/common/zfs zfs_namecheck.c zfs_namecheck.h zfs_prop.c zfs_prop.h sys/cddl/contrib/opensolaris/uts/common/fs gfs.c sys/cddl/contrib/opensolaris/uts/common/fs/zfs arc.c bplist.c dbuf.c dmu.c dmu_object.c dmu_objset.c dmu_send.c dmu_traverse.c dmu_tx.c dmu_zfetch.c dnode.c dnode_sync.c dsl_dataset.c dsl_dir.c dsl_pool.c dsl_prop.c dsl_synctask.c fletcher.c gzip.c lzjb.c metaslab.c refcount.c sha256.c spa.c spa_config.c spa_errlog.c spa_history.c spa_misc.c space_map.c txg.c uberblock.c unique.c vdev.c vdev_cache.c vdev_disk.c vdev_file.c vdev_geom.c vdev_label.c vdev_mirror.c vdev_missing.c vdev_queue.c vdev_raidz.c vdev_root.c zap.c zap_leaf.c zap_micro.c zfs.conf zfs_acl.c zfs_byteswap.c zfs_ctldir.c zfs_dir.c zfs_fm.c zfs_ioctl.c zfs_log.c zfs_replay.c zfs_rlock.c zfs_vfsops.c zfs_vnops.c zfs_znode.c zil.c zio.c zio_checksum.c zio_compress.c zio_inject.c zvol.c sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys arc.h bplist.h dbuf.h dmu.h dmu_impl.h dmu_objset.h dmu_traverse.h dmu_tx.h dmu_zfetch.h dnode.h dsl_dataset.h dsl_dir.h dsl_pool.h dsl_prop.h dsl_synctask.h metaslab.h metaslab_impl.h refcount.h spa.h spa_impl.h space_map.h txg.h txg_impl.h uberblock.h uberblock_impl.h unique.h vdev.h vdev_disk.h vdev_file.h vdev_impl.h zap.h zap_impl.h zap_leaf.h zfs_acl.h zfs_context.h zfs_ctldir.h zfs_debug.h zfs_dir.h zfs_ioctl.h zfs_rlock.h zfs_vfsops.h zfs_znode.h zil.h zil_impl.h zio.h zio_checksum.h zio_compress.h zio_impl.h zvol.h sys/cddl/contrib/opensolaris/uts/common/os callb.c list.c nvpair_alloc_system.c taskq.c sys/cddl/contrib/opensolaris/uts/common/rpc xdr.c xdr.h xdr_array.c xdr_mem.c sys/cddl/contrib/opensolaris/uts/common/sys asm_linkage.h avl.h avl_impl.h bitmap.h byteorder.h callb.h ccompile.h compress.h cred.h debug.h dkio.h dklabel.h errorq.h feature_tests.h gfs.h isa_defs.h list.h list_impl.h note.h nvpair.h nvpair_impl.h processor.h procset.h sdt.h synch.h sysevent.h sysmacros.h vfs.h vmem.h zmod.h sys/cddl/contrib/opensolaris/uts/common/sys/fm protocol.h util.h sys/cddl/contrib/opensolaris/uts/common/sys/fm/fs zfs.h sys/cddl/contrib/opensolaris/uts/common/sys/fs zfs.h sys/cddl/contrib/opensolaris/uts/common/zmod adler32.c crc32.c crc32.h deflate.c deflate.h inffast.c inffast.h inffixed.h inflate.c inflate.h inftrees.c inftrees.h trees.c zconf.h zlib.h zmod.c zmod_subr.c zutil.c zutil.h Log: MFC. The great CDDL file move. These files were repocopied for HEAD. The repo copy process renames tags, adding a prefix of 'old_', so the history for these files is in old_RELENG_7 etc. Revision Changes Path 1.3.2.1 +54 -0 src/cddl/compat/opensolaris/include/devid.h (new) 1.2.2.1 +35 -0 src/cddl/compat/opensolaris/include/fsshare.h (new) 1.2.2.1 +11 -0 src/cddl/compat/opensolaris/include/libintl.h (new) 1.2.2.1 +19 -0 src/cddl/compat/opensolaris/include/mnttab.h (new) 1.2.2.1 +18 -0 src/cddl/compat/opensolaris/include/priv.h (new) 1.2.2.1 +8 -0 src/cddl/compat/opensolaris/include/solaris.h (new) 1.2.2.1 +6 -0 src/cddl/compat/opensolaris/include/zone.h (new) 1.2.2.1 +167 -0 src/cddl/compat/opensolaris/lib/libumem/umem.c (new) 1.2.2.1 +85 -0 src/cddl/compat/opensolaris/lib/libumem/umem.h (new) 1.2.2.1 +119 -0 src/cddl/compat/opensolaris/misc/deviceid.c (new) 1.3.2.1 +259 -0 src/cddl/compat/opensolaris/misc/fsshare.c (new) 1.2.2.1 +213 -0 src/cddl/compat/opensolaris/misc/mkdirp.c (new) 1.2.2.1 +160 -0 src/cddl/compat/opensolaris/misc/mnttab.c (new) 1.2.2.1 +102 -0 src/cddl/compat/opensolaris/misc/zmount.c (new) 1.2.2.1 +46 -0 src/cddl/compat/opensolaris/misc/zone.c (new) 1.2.2.1 +384 -0 src/cddl/contrib/opensolaris/OPENSOLARIS.LICENSE (new) 1.3.2.1 +93 -0 src/cddl/contrib/opensolaris/cmd/zdb/zdb.8 (new) 1.4.2.1 +2193 -0 src/cddl/contrib/opensolaris/cmd/zdb/zdb.c (new) 1.2.2.1 +354 -0 src/cddl/contrib/opensolaris/cmd/zdb/zdb_il.c (new) 1.3.2.1 +1843 -0 src/cddl/contrib/opensolaris/cmd/zfs/zfs.8 (new) 1.2.2.1 +405 -0 src/cddl/contrib/opensolaris/cmd/zfs/zfs_iter.c (new) 1.2.2.1 +52 -0 src/cddl/contrib/opensolaris/cmd/zfs/zfs_iter.h (new) 1.3.2.1 +3253 -0 src/cddl/contrib/opensolaris/cmd/zfs/zfs_main.c (new) 1.2.2.1 +44 -0 src/cddl/contrib/opensolaris/cmd/zfs/zfs_util.h (new) 1.3.2.1 +1140 -0 src/cddl/contrib/opensolaris/cmd/zpool/zpool.8 (new) 1.2.2.1 +245 -0 src/cddl/contrib/opensolaris/cmd/zpool/zpool_iter.c (new) 1.3.2.1 +3602 -0 src/cddl/contrib/opensolaris/cmd/zpool/zpool_main.c (new) 1.2.2.1 +79 -0 src/cddl/contrib/opensolaris/cmd/zpool/zpool_util.c (new) 1.2.2.1 +72 -0 src/cddl/contrib/opensolaris/cmd/zpool/zpool_util.h (new) 1.3.2.1 +883 -0 src/cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c (new) 1.4.2.1 +3495 -0 src/cddl/contrib/opensolaris/cmd/ztest/ztest.c (new) 1.2.2.1 +82 -0 src/cddl/contrib/opensolaris/head/assert.h (new) 1.2.2.1 +34 -0 src/cddl/contrib/opensolaris/head/atomic.h (new) 1.2.2.1 +124 -0 src/cddl/contrib/opensolaris/head/libintl.h (new) 1.2.2.1 +32 -0 src/cddl/contrib/opensolaris/head/stdio_ext.h (new) 1.2.2.1 +264 -0 src/cddl/contrib/opensolaris/head/synch.h (new) 1.2.2.1 +99 -0 src/cddl/contrib/opensolaris/head/thread.h (new) 1.2.2.1 +266 -0 src/cddl/contrib/opensolaris/lib/libnvpair/libnvpair.c (new) 1.2.2.1 +46 -0 src/cddl/contrib/opensolaris/lib/libnvpair/libnvpair.h (new) 1.2.2.1 +59 -0 src/cddl/contrib/opensolaris/lib/libnvpair/nvpair_alloc_system.c (new) 1.2.2.1 +384 -0 src/cddl/contrib/opensolaris/lib/libuutil/common/libuutil.h (new) 1.2.2.1 +46 -0 src/cddl/contrib/opensolaris/lib/libuutil/common/libuutil_common.h (new) 1.2.2.1 +181 -0 src/cddl/contrib/opensolaris/lib/libuutil/common/libuutil_impl.h (new) 1.2.2.1 +85 -0 src/cddl/contrib/opensolaris/lib/libuutil/common/uu_alloc.c (new) 1.2.2.1 +567 -0 src/cddl/contrib/opensolaris/lib/libuutil/common/uu_avl.c (new) 1.2.2.1 +128 -0 src/cddl/contrib/opensolaris/lib/libuutil/common/uu_dprintf.c (new) 1.2.2.1 +122 -0 src/cddl/contrib/opensolaris/lib/libuutil/common/uu_ident.c (new) 1.2.2.1 +711 -0 src/cddl/contrib/opensolaris/lib/libuutil/common/uu_list.c (new) 1.2.2.1 +250 -0 src/cddl/contrib/opensolaris/lib/libuutil/common/uu_misc.c (new) 1.2.2.1 +70 -0 src/cddl/contrib/opensolaris/lib/libuutil/common/uu_open.c (new) 1.2.2.1 +205 -0 src/cddl/contrib/opensolaris/lib/libuutil/common/uu_pname.c (new) 1.2.2.1 +300 -0 src/cddl/contrib/opensolaris/lib/libuutil/common/uu_strtoint.c (new) 1.4.2.1 +443 -0 src/cddl/contrib/opensolaris/lib/libzfs/common/libzfs.h (new) 1.3.2.1 +599 -0 src/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_changelist.c (new) 1.3.2.1 +360 -0 src/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_config.c (new) 1.3.2.1 +3855 -0 src/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c (new) 1.2.2.1 +646 -0 src/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_graph.c (new) 1.2.2.1 +171 -0 src/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_impl.h (new) 1.4.2.1 +1023 -0 src/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c (new) 1.2.2.1 +986 -0 src/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_mount.c (new) 1.2.2.1 +2055 -0 src/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c (new) 1.3.2.1 +303 -0 src/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_status.c (new) 1.4.2.1 +853 -0 src/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_util.c (new) 1.4.2.1 +852 -0 src/cddl/contrib/opensolaris/lib/libzpool/common/kernel.c (new) 1.9.2.1 +511 -0 src/cddl/contrib/opensolaris/lib/libzpool/common/sys/zfs_context.h (new) 1.2.2.1 +250 -0 src/cddl/contrib/opensolaris/lib/libzpool/common/taskq.c (new) 1.2.2.1 +144 -0 src/cddl/contrib/opensolaris/lib/libzpool/common/util.c (new) 1.2.2.1 +133 -0 src/sys/cddl/compat/opensolaris/kern/opensolaris_atomic.c (new) 1.4.2.1 +260 -0 src/sys/cddl/compat/opensolaris/kern/opensolaris_kmem.c (new) 1.7.2.1 +220 -0 src/sys/cddl/compat/opensolaris/kern/opensolaris_kobj.c (new) 1.3.2.1 +131 -0 src/sys/cddl/compat/opensolaris/kern/opensolaris_kstat.c (new) 1.3.2.1 +56 -0 src/sys/cddl/compat/opensolaris/kern/opensolaris_misc.c (new) 1.3.2.1 +261 -0 src/sys/cddl/compat/opensolaris/kern/opensolaris_policy.c (new) 1.3.2.1 +71 -0 src/sys/cddl/compat/opensolaris/kern/opensolaris_string.c (new) 1.10.2.1 +276 -0 src/sys/cddl/compat/opensolaris/kern/opensolaris_vfs.c (new) 1.2.2.1 +237 -0 src/sys/cddl/compat/opensolaris/kern/opensolaris_zone.c (new) 1.2.2.1 +44 -0 src/sys/cddl/compat/opensolaris/machine/endian.h (new) 1.3.2.1 +123 -0 src/sys/cddl/compat/opensolaris/rpc/xdr.h (new) 1.2.2.1 +241 -0 src/sys/cddl/compat/opensolaris/sys/acl.h (new) 1.3.2.1 +114 -0 src/sys/cddl/compat/opensolaris/sys/atomic.h (new) 1.2.2.1 +65 -0 src/sys/cddl/compat/opensolaris/sys/byteorder.h (new) 1.2.2.1 +217 -0 src/sys/cddl/compat/opensolaris/sys/callb.h (new) 1.2.2.1 +90 -0 src/sys/cddl/compat/opensolaris/sys/cmn_err.h (new) 1.2.2.1 +51 -0 src/sys/cddl/compat/opensolaris/sys/cred.h (new) 1.2.2.1 +48 -0 src/sys/cddl/compat/opensolaris/sys/debug.h (new) 1.2.2.1 +44 -0 src/sys/cddl/compat/opensolaris/sys/dirent.h (new) 1.2.2.1 +85 -0 src/sys/cddl/compat/opensolaris/sys/dkio.h (new) 1.3.2.1 +40 -0 src/sys/cddl/compat/opensolaris/sys/dnlc.h (new) 1.3.2.1 +55 -0 src/sys/cddl/compat/opensolaris/sys/kcondvar.h (new) 1.5.2.1 +77 -0 src/sys/cddl/compat/opensolaris/sys/kmem.h (new) 1.3.2.1 +60 -0 src/sys/cddl/compat/opensolaris/sys/kobj.h (new) 1.2.2.1 +66 -0 src/sys/cddl/compat/opensolaris/sys/kstat.h (new) 1.2.2.1 +46 -0 src/sys/cddl/compat/opensolaris/sys/lock.h (new) 1.3.2.1 +45 -0 src/sys/cddl/compat/opensolaris/sys/misc.h (new) 1.2.2.1 +56 -0 src/sys/cddl/compat/opensolaris/sys/mntent.h (new) 1.2.2.1 +36 -0 src/sys/cddl/compat/opensolaris/sys/mnttab.h (new) 1.2.2.1 +39 -0 src/sys/cddl/compat/opensolaris/sys/mount.h (new) 1.5.2.1 +72 -0 src/sys/cddl/compat/opensolaris/sys/mutex.h (new) 1.2.2.1 +63 -0 src/sys/cddl/compat/opensolaris/sys/policy.h (new) 1.5.2.1 +89 -0 src/sys/cddl/compat/opensolaris/sys/proc.h (new) 1.2.2.1 +37 -0 src/sys/cddl/compat/opensolaris/sys/random.h (new) 1.5.2.1 +88 -0 src/sys/cddl/compat/opensolaris/sys/rwlock.h (new) 1.2.2.1 +46 -0 src/sys/cddl/compat/opensolaris/sys/sdt.h (new) 1.3.2.1 +37 -0 src/sys/cddl/compat/opensolaris/sys/string.h (new) 1.2.2.1 +36 -0 src/sys/cddl/compat/opensolaris/sys/sunddi.h (new) 1.2.2.1 +137 -0 src/sys/cddl/compat/opensolaris/sys/sysmacros.h (new) 1.2.2.1 +49 -0 src/sys/cddl/compat/opensolaris/sys/systm.h (new) 1.2.2.1 +84 -0 src/sys/cddl/compat/opensolaris/sys/taskq.h (new) 1.2.2.1 +135 -0 src/sys/cddl/compat/opensolaris/sys/taskq_impl.h (new) 1.3.2.1 +58 -0 src/sys/cddl/compat/opensolaris/sys/time.h (new) 1.4.2.1 +68 -0 src/sys/cddl/compat/opensolaris/sys/types.h (new) 1.2.2.1 +63 -0 src/sys/cddl/compat/opensolaris/sys/uio.h (new) 1.2.2.1 +38 -0 src/sys/cddl/compat/opensolaris/sys/varargs.h (new) 1.3.2.1 +116 -0 src/sys/cddl/compat/opensolaris/sys/vfs.h (new) 1.6.2.1 +268 -0 src/sys/cddl/compat/opensolaris/sys/vnode.h (new) 1.2.2.1 +68 -0 src/sys/cddl/compat/opensolaris/sys/zone.h (new) 1.2.2.1 +217 -0 src/sys/cddl/contrib/opensolaris/common/acl/acl_common.c (new) 1.2.2.1 +56 -0 src/sys/cddl/contrib/opensolaris/common/acl/acl_common.h (new) 1.4.2.1 +68 -0 src/sys/cddl/contrib/opensolaris/common/atomic/amd64/atomic.S (new) 1.4.2.1 +98 -0 src/sys/cddl/contrib/opensolaris/common/atomic/i386/atomic.S (new) 1.3.2.1 +82 -0 src/sys/cddl/contrib/opensolaris/common/atomic/ia64/atomic.S (new) 1.3.2.1 +968 -0 src/sys/cddl/contrib/opensolaris/common/avl/avl.c (new) 1.3.2.1 +2953 -0 src/sys/cddl/contrib/opensolaris/common/nvpair/nvpair.c (new) 1.2.2.1 +118 -0 src/sys/cddl/contrib/opensolaris/common/nvpair/nvpair_alloc_fixed.c (new) 1.2.2.1 +287 -0 src/sys/cddl/contrib/opensolaris/common/zfs/zfs_namecheck.c (new) 1.2.2.1 +56 -0 src/sys/cddl/contrib/opensolaris/common/zfs/zfs_namecheck.h (new) 1.2.2.1 +657 -0 src/sys/cddl/contrib/opensolaris/common/zfs/zfs_prop.c (new) 1.2.2.1 +56 -0 src/sys/cddl/contrib/opensolaris/common/zfs/zfs_prop.h (new) 1.5.2.1 +884 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/gfs.c (new) 1.15.2.1 +2858 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c (new) 1.2.2.1 +312 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/bplist.c (new) 1.4.2.1 +2247 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dbuf.c (new) 1.2.2.1 +1029 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu.c (new) 1.2.2.1 +160 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_object.c (new) 1.3.2.1 +1037 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_objset.c (new) 1.3.2.1 +1009 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_send.c (new) 1.2.2.1 +888 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_traverse.c (new) 1.2.2.1 +992 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_tx.c (new) 1.2.2.1 +655 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_zfetch.c (new) 1.3.2.1 +1369 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dnode.c (new) 1.3.2.1 +623 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dnode_sync.c (new) 1.4.2.1 +2035 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c (new) 1.3.2.1 +1215 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dir.c (new) 1.3.2.1 +256 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_pool.c (new) 1.2.2.1 +501 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_prop.c (new) 1.2.2.1 +196 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_synctask.c (new) 1.2.2.1 +145 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/fletcher.c (new) 1.2.2.1 +69 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/gzip.c (new) 1.2.2.1 +129 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lzjb.c (new) 1.2.2.1 +1023 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/metaslab.c (new) 1.2.2.1 +194 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/refcount.c (new) 1.2.2.1 +131 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sha256.c (new) 1.8.2.1 +3301 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c (new) 1.6.2.1 +375 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_config.c (new) 1.2.2.1 +440 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_errlog.c (new) 1.2.2.1 +354 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_history.c (new) 1.3.2.1 +1130 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_misc.c (new) 1.2.2.1 +501 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/space_map.c (new) 1.2.2.1 +109 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/arc.h (new) 1.2.2.1 +89 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/bplist.h (new) 1.2.2.1 +334 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dbuf.h (new) 1.3.2.1 +587 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dmu.h (new) 1.2.2.1 +237 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dmu_impl.h (new) 1.2.2.1 +125 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dmu_objset.h (new) 1.2.2.1 +120 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dmu_traverse.h (new) 1.2.2.1 +134 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dmu_tx.h (new) 1.2.2.1 +75 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dmu_zfetch.h (new) 1.2.2.1 +267 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dnode.h (new) 1.3.2.1 +185 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dsl_dataset.h (new) 1.3.2.1 +143 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dsl_dir.h (new) 1.2.2.1 +82 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dsl_pool.h (new) 1.2.2.1 +77 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dsl_prop.h (new) 1.2.2.1 +77 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dsl_synctask.h (new) 1.2.2.1 +69 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/metaslab.h (new) 1.2.2.1 +81 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/metaslab_impl.h (new) 1.2.2.1 +103 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/refcount.h (new) 1.3.2.1 +491 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/spa.h (new) 1.2.2.1 +168 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/spa_impl.h (new) 1.2.2.1 +162 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/space_map.h (new) 1.2.2.1 +120 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/txg.h (new) 1.2.2.1 +77 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/txg_impl.h (new) 1.2.2.1 +50 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/uberblock.h (new) 1.2.2.1 +63 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/uberblock_impl.h (new) 1.2.2.1 +56 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/unique.h (new) 1.2.2.1 +132 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/vdev.h (new) 1.2.2.1 +52 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/vdev_disk.h (new) 1.2.2.1 +46 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/vdev_file.h (new) 1.2.2.1 +298 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/vdev_impl.h (new) 1.2.2.1 +359 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zap.h (new) 1.2.2.1 +204 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zap_impl.h (new) 1.2.2.1 +234 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zap_leaf.h (new) 1.2.2.1 +115 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_acl.h (new) 1.4.2.1 +120 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_context.h (new) 1.2.2.1 +71 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_ctldir.h (new) 1.2.2.1 +75 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_debug.h (new) 1.2.2.1 +71 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_dir.h (new) 1.3.2.1 +163 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_ioctl.h (new) 1.2.2.1 +89 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_rlock.h (new) 1.2.2.1 +100 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_vfsops.h (new) 1.3.2.1 +298 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_znode.h (new) 1.2.2.1 +276 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zil.h (new) 1.2.2.1 +111 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zil_impl.h (new) 1.2.2.1 +366 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zio.h (new) 1.2.2.1 +75 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zio_checksum.h (new) 1.2.2.1 +82 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zio_compress.h (new) 1.2.2.1 +205 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zio_impl.h (new) 1.2.2.1 +68 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zvol.h (new) 1.2.2.1 +611 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c (new) 1.2.2.1 +63 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/uberblock.c (new) 1.2.2.1 +107 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/unique.c (new) 1.5.2.1 +1915 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev.c (new) 1.3.2.1 +394 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_cache.c (new) 1.2.2.1 +363 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_disk.c (new) 1.2.2.1 +225 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_file.c (new) 1.6.2.1 +583 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_geom.c (new) 1.2.2.1 +1011 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_label.c (new) 1.2.2.1 +495 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_mirror.c (new) 1.2.2.1 +89 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_missing.c (new) 1.3.2.1 +323 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_queue.c (new) 1.3.2.1 +1237 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_raidz.c (new) 1.2.2.1 +118 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_root.c (new) 1.4.2.1 +1071 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zap.c (new) 1.2.2.1 +741 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zap_leaf.c (new) 1.3.2.1 +857 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zap_micro.c (new) 1.2.2.1 +28 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs.conf (new) 1.3.2.1 +1608 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_acl.c (new) 1.2.2.1 +99 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c (new) 1.8.2.1 +1119 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ctldir.c (new) 1.3.2.1 +797 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_dir.c (new) 1.5.2.1 +335 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_fm.c (new) 1.7.2.1 +1826 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c (new) 1.3.2.1 +349 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_log.c (new) 1.6.2.1 +430 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_replay.c (new) 1.2.2.1 +594 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_rlock.c (new) 1.14.2.1 +1021 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c (new) 1.31.2.1 +3619 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c (new) 1.15.2.1 +1068 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_znode.c (new) 1.4.2.1 +1607 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c (new) 1.5.2.1 +1861 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio.c (new) 1.2.2.1 +172 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio_checksum.c (new) 1.2.2.1 +148 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio_compress.c (new) 1.2.2.1 +315 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio_inject.c (new) 1.5.2.1 +801 -0 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zvol.c (new) 1.3.2.1 +363 -0 src/sys/cddl/contrib/opensolaris/uts/common/os/callb.c (new) 1.2.2.1 +193 -0 src/sys/cddl/contrib/opensolaris/uts/common/os/list.c (new) 1.2.2.1 +63 -0 src/sys/cddl/contrib/opensolaris/uts/common/os/nvpair_alloc_system.c (new) 1.4.2.1 +1020 -0 src/sys/cddl/contrib/opensolaris/uts/common/os/taskq.c (new) 1.3.2.1 +671 -0 src/sys/cddl/contrib/opensolaris/uts/common/rpc/xdr.c (new) 1.3.2.1 +605 -0 src/sys/cddl/contrib/opensolaris/uts/common/rpc/xdr.h (new) 1.2.2.1 +123 -0 src/sys/cddl/contrib/opensolaris/uts/common/rpc/xdr_array.c (new) 1.2.2.1 +209 -0 src/sys/cddl/contrib/opensolaris/uts/common/rpc/xdr_mem.c (new) 1.4.2.1 +110 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/asm_linkage.h (new) 1.2.2.1 +298 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/avl.h (new) 1.2.2.1 +164 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/avl_impl.h (new) 1.2.2.1 +194 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/bitmap.h (new) 1.3.2.1 +137 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/byteorder.h (new) 1.2.2.1 +214 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/callb.h (new) 1.2.2.1 +127 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/ccompile.h (new) 1.2.2.1 +46 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/compress.h (new) 1.2.2.1 +154 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/cred.h (new) 1.2.2.1 +129 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/debug.h (new) 1.2.2.1 +477 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/dkio.h (new) 1.2.2.1 +268 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/dklabel.h (new) 1.2.2.1 +83 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/errorq.h (new) 1.2.2.1 +397 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/feature_tests.h (new) 1.2.2.1 +75 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/fm/fs/zfs.h (new) 1.2.2.1 +301 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/fm/protocol.h (new) 1.2.2.1 +103 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/fm/util.h (new) 1.4.2.1 +437 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/fs/zfs.h (new) 1.2.2.1 +139 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/gfs.h (new) 1.3.2.1 +479 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/isa_defs.h (new) 1.2.2.1 +63 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/list.h (new) 1.2.2.1 +53 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/list_impl.h (new) 1.2.2.1 +56 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/note.h (new) 1.2.2.1 +260 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/nvpair.h (new) 1.2.2.1 +73 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/nvpair_impl.h (new) 1.2.2.1 +146 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/processor.h (new) 1.3.2.1 +160 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/procset.h (new) 1.2.2.1 +176 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/sdt.h (new) 1.2.2.1 +161 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/synch.h (new) 1.2.2.1 +227 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/sysevent.h (new) 1.3.2.1 +287 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/sysmacros.h (new) 1.2.2.1 +569 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/vfs.h (new) 1.3.2.1 +142 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/vmem.h (new) 1.2.2.1 +68 -0 src/sys/cddl/contrib/opensolaris/uts/common/sys/zmod.h (new) 1.2.2.1 +149 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/adler32.c (new) 1.2.2.1 +428 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/crc32.c (new) 1.2.2.1 +443 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/crc32.h (new) 1.2.2.1 +1742 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/deflate.c (new) 1.2.2.1 +331 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/deflate.h (new) 1.2.2.1 +320 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/inffast.c (new) 1.2.2.1 +13 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/inffast.h (new) 1.2.2.1 +96 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/inffixed.h (new) 1.2.2.1 +1395 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/inflate.c (new) 1.2.2.1 +117 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/inflate.h (new) 1.2.2.1 +331 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/inftrees.c (new) 1.2.2.1 +57 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/inftrees.h (new) 1.2.2.1 +1219 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/trees.c (new) 1.2.2.1 +117 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/zconf.h (new) 1.2.2.1 +1359 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/zlib.h (new) 1.2.2.1 +109 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/zmod.c (new) 1.2.2.1 +84 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/zmod_subr.c (new) 1.2.2.1 +324 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/zutil.c (new) 1.2.2.1 +274 -0 src/sys/cddl/contrib/opensolaris/uts/common/zmod/zutil.h (new) From jb at FreeBSD.org Thu Apr 17 02:41:05 2008 From: jb at FreeBSD.org (John Birrell) Date: Thu Apr 17 02:41:11 2008 Subject: cvs commit: src/sys/cddl/contrib/opensolaris/uts/common Makefile.files Message-ID: <200804170241.m3H2f5pi010612@repoman.freebsd.org> jb 2008-04-17 02:41:05 UTC FreeBSD src repository Added files: (Branch: RELENG_7) sys/cddl/contrib/opensolaris/uts/common Makefile.files Log: MFC. Par of the big CDDL file move I missed. Revision Changes Path 1.2.2.1 +101 -0 src/sys/cddl/contrib/opensolaris/uts/common/Makefile.files (new) From yongari at FreeBSD.org Thu Apr 17 04:16:52 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Thu Apr 17 04:16:58 2008 Subject: cvs commit: src/sys/pci if_rl.c Message-ID: <200804170416.m3H4Gpos032561@repoman.freebsd.org> yongari 2008-04-17 04:16:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/pci if_rl.c Log: MFC if_rl.c, rev 1.174 to RELENG_7. It seems that RealTek 8129/8139 chip reports invalid length of received frame under certain conditions. wpaul said the length 0xfff0 is special meaning that indicates hardware is in the process of copying a packet into host memory. But it seems there are other cases that hardware is busy or stuck in bad situation even if the received frame length is not 0xfff0. To work-around this condition, add a check that verifys that recevied frame length is in valid range. If received length is out of range reinitialize hardware to recover from stuck condition. Revision Changes Path 1.170.2.3 +5 -3 src/sys/pci/if_rl.c From yongari at FreeBSD.org Thu Apr 17 04:18:30 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Thu Apr 17 04:18:36 2008 Subject: cvs commit: src/sys/pci if_rl.c Message-ID: <200804170418.m3H4ITGv032630@repoman.freebsd.org> yongari 2008-04-17 04:18:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/pci if_rl.c Log: MFC if_rl.c, rev 1.174 to RELENG_6. It seems that RealTek 8129/8139 chip reports invalid length of received frame under certain conditions. wpaul said the length 0xfff0 is special meaning that indicates hardware is in the process of copying a packet into host memory. But it seems there are other cases that hardware is busy or stuck in bad situation even if the received frame length is not 0xfff0. To work-around this condition, add a check that verifys that recevied frame length is in valid range. If received length is out of range reinitialize hardware to recover from stuck condition. Revision Changes Path 1.152.2.9 +5 -3 src/sys/pci/if_rl.c From jeff at FreeBSD.org Thu Apr 17 04:20:11 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Thu Apr 17 04:20:17 2008 Subject: cvs commit: src/sys/kern kern_intr.c kern_subr.c kern_switch.c kern_synch.c kern_thread.c sched_4bsd.c sched_ule.c subr_sleepqueue.c subr_trap.c subr_turnstile.c src/sys/sys proc.h sched.h sysctl.h src/sys/vm vm_glue.c vm_zeroidle.c Message-ID: <200804170420.m3H4KBOj032841@repoman.freebsd.org> jeff 2008-04-17 04:20:11 UTC FreeBSD src repository Modified files: sys/kern kern_intr.c kern_subr.c kern_switch.c kern_synch.c kern_thread.c sched_4bsd.c sched_ule.c subr_sleepqueue.c subr_trap.c subr_turnstile.c sys/sys proc.h sched.h sysctl.h sys/vm vm_glue.c vm_zeroidle.c Log: - Make SCHED_STATS more generic by adding a wrapper to create the variables and sysctl nodes. - In reset walk the children of kern_sched_stats and reset the counters via the oid_arg1 pointer. This allows us to add arbitrary counters to the tree and still reset them properly. - Define a set of switch types to be passed with flags to mi_switch(). These types are named SWT_*. These types correspond to SCHED_STATS counters and are automatically handled in this way. - Make the new SWT_ types more specific than the older switch stats. There are now stats for idle switches, remote idle wakeups, remote preemption ithreads idling, etc. - Add switch statistics for ULE's pickcpu algorithm. These stats include how much migration there is, how often affinity was successful, how often threads were migrated to the local cpu on wakeup, etc. Sponsored by: Nokia Revision Changes Path 1.163 +2 -2 src/sys/kern/kern_intr.c 1.104 +1 -1 src/sys/kern/kern_subr.c 1.144 +41 -25 src/sys/kern/kern_switch.c 1.311 +5 -1 src/sys/kern/kern_synch.c 1.274 +2 -2 src/sys/kern/kern_thread.c 1.124 +4 -6 src/sys/kern/sched_4bsd.c 1.242 +30 -8 src/sys/kern/sched_ule.c 1.53 +2 -4 src/sys/kern/subr_sleepqueue.c 1.304 +1 -2 src/sys/kern/subr_trap.c 1.173 +1 -2 src/sys/kern/subr_turnstile.c 1.511 +20 -4 src/sys/sys/proc.h 1.39 +10 -8 src/sys/sys/sched.h 1.157 +1 -0 src/sys/sys/sysctl.h 1.231 +1 -1 src/sys/vm/vm_glue.c 1.52 +1 -1 src/sys/vm/vm_zeroidle.c From yongari at FreeBSD.org Thu Apr 17 04:22:33 2008 From: yongari at FreeBSD.org (Pyun YongHyeon) Date: Thu Apr 17 04:22:38 2008 Subject: cvs commit: src/sys/dev/nfe if_nfe.c if_nfereg.h Message-ID: <200804170422.m3H4MX05033026@repoman.freebsd.org> yongari 2008-04-17 04:22:33 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/nfe if_nfe.c if_nfereg.h Log: MFC if_nfe.c rev 1.28, if_nfereg.h rev 1.12 to RELENG_7. Add support for MCP73 chips. Revision Changes Path 1.21.2.5 +12 -0 src/sys/dev/nfe/if_nfe.c 1.10.2.1 +4 -0 src/sys/dev/nfe/if_nfereg.h From brueffer at FreeBSD.org Thu Apr 17 04:27:45 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Thu Apr 17 04:27:47 2008 Subject: cvs commit: src/release/doc/share/misc dev.archlist.txt Message-ID: <200804170427.m3H4Rjk6033184@repoman.freebsd.org> brueffer 2008-04-17 04:27:44 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) release/doc/share/misc dev.archlist.txt Log: MFC: rev. 1.102 sf(4) should work on all archs now, remove it from here. Revision Changes Path 1.100.2.3 +0 -1 src/release/doc/share/misc/dev.archlist.txt From jb at FreeBSD.org Thu Apr 17 04:59:18 2008 From: jb at FreeBSD.org (John Birrell) Date: Thu Apr 17 04:59:25 2008 Subject: cvs commit: src/cddl/lib/libavl Makefile src/cddl/lib/libnvpair Makefile src/cddl/lib/libumem Makefile src/cddl/lib/libuutil Makefile src/cddl/lib/libzfs Makefile src/cddl/lib/libzpool Makefile src/cddl/sbin/zfs Makefile src/cddl/sbin/zpool Makefile ... Message-ID: <200804170459.m3H4xI5I043393@repoman.freebsd.org> jb 2008-04-17 04:59:18 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) cddl/lib/libavl Makefile cddl/lib/libnvpair Makefile cddl/lib/libumem Makefile cddl/lib/libuutil Makefile cddl/lib/libzfs Makefile cddl/lib/libzpool Makefile cddl/sbin/zfs Makefile cddl/sbin/zpool Makefile cddl/usr.bin/ztest Makefile cddl/usr.sbin/zdb Makefile sys/modules/zfs Makefile Log: MFC. Step 2 of the big CDDL file move. Use the files in their new locations. The next step will be to remove the files from their old locations. Revision Changes Path 1.2.2.1 +3 -3 src/cddl/lib/libavl/Makefile 1.2.2.1 +4 -4 src/cddl/lib/libnvpair/Makefile 1.2.2.1 +2 -2 src/cddl/lib/libumem/Makefile 1.2.2.1 +7 -7 src/cddl/lib/libuutil/Makefile 1.3.2.1 +16 -16 src/cddl/lib/libzfs/Makefile 1.5.2.1 +17 -17 src/cddl/lib/libzpool/Makefile 1.3.2.1 +13 -13 src/cddl/sbin/zfs/Makefile 1.3.2.1 +13 -13 src/cddl/sbin/zpool/Makefile 1.4.2.1 +9 -9 src/cddl/usr.bin/ztest/Makefile 1.4.2.1 +9 -9 src/cddl/usr.sbin/zdb/Makefile 1.6.2.1 +19 -19 src/sys/modules/zfs/Makefile From qingli at speakeasy.net Thu Apr 17 07:02:55 2008 From: qingli at speakeasy.net (Qing Li) Date: Thu Apr 17 07:03:05 2008 Subject: multipath stuff In-Reply-To: <48047442.1030609@FreeBSD.org> References: <200804130545.m3D5jEtd081771@repoman.freebsd.org> <4803D7E2.80000@freebsd.org> <000201c89eae$d4dcfe10$b1335140@SAINTS> <48047442.1030609@FreeBSD.org> Message-ID: <004901c8a059$135ffb50$b1335140@SAINTS> Hi Bruce, > > First of all thanks for doing this. It would have been nice > to have had some advance warning though. > Hopefully it wasn't too much of a grief ... > > I'm surprised XORP hasn't been mentioned here, so I'll > mention it now... > > For what it's worth this should not make any operational changes to > XORP's behaviour, it already plumbs routes to the FIB from > its RIB with > the next-hop field, and always parses the next-hop in any PF_ROUTE > messages it sees. I can't speak for the others. > I was hoping that would be the case, and that should be how it's done in theory, no ? > > Questions: > * So, does this RADIX_MPATH code originate from KAME? > Yes, this work originated from the KAME project. > > * If so, to what extent does it share heritage with the OpenBSD code? > I don't know much about the OpenBSD code and never looked at that branch. What I do know, is the original code from KAME worked on all except FreeBSD, at least that was the case when I did the initial work in FreeBSD 5.4, and the original code has not changed for quite some time even before that. The bulk of the addition/change is actually in route.c With the original code, the box would boot-up and crash immediately. If my memory serves me right, the crash was due to the address alias was not being properly taken care of. Also in the original code, the deletion did not really work and also crashed often. > > It will be useful as a baseline for other work, in particular > removing the 32 (S,G) channel limitation from the multicast > forwarding code -- with such a change it would be possible to > move multicasting into the usual radix trie lookup by adding a > new flag which says "flood this to > all next-hops specified as AF_LINK sockaddrs". > That would be good. I'd like to learn more about what you have in mind and would be happy to help you out on that front. > > We really need to get ARP out of there now. :-) > Yes. I am going to be focused on getting this work revised and hope to wrap it up in a couple of weeks. Julian is helping me out on the debugging and testing front. > > It would be nice if rt_mpath_matchgate() used the sa_dl_equal() macros > from if.c, it reads a bit quirky. > I will update the code. Thanks. > > The questions you raise about ownership of FIB entries bear some > scrutiny. Microsoft, for example, are pretty strict about > only exposing the forwarding table to consumers which are willing > to play by all rules of the API. What they have could be termed > a RIB in of itself, you never get to interact with the forwarding > tables directly outside of the TCPIP.SYS driver, except for read-only > access e.g. SNMP. There is locking capability in their API. > I am going to postpone this discussion until I get done with the new ARP work. However, one thing I do want to mention, is I doubt one can get the proper entries out of the table using SNMP because I do know the forwarding table MIB is and has been broken for years. The table does not support these concepts with the proper table index. > > It really is worth looking at Linux, rtnetlink has an > informational RFC, it uses a tag-length-value protocol which > addresses a number of the issues blocking further progress in this > area, and whilst we can't take > the code, the design, and the idea, are not subject to the GPL -- > particularly so given the informational RFC status. > Interesting. Is this the RFC you are referring to ? 3549 Linux Netlink as an IP Services Protocol. J. Salim, H. Khosravi, A. Kleen, A. Kuznetsov. July 2003. (Format: TXT=72161 bytes) (Status: INFORMATIONAL) -- Qing From dfr at FreeBSD.org Thu Apr 17 07:53:50 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Thu Apr 17 07:53:55 2008 Subject: cvs commit: src/sys/fs/smbfs smbfs_vnops.c Message-ID: <200804170753.m3H7rnn0053016@repoman.freebsd.org> dfr 2008-04-17 07:53:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/fs/smbfs smbfs_vnops.c Log: MFC: smbfs_vnops.c 1.68 - make sure l_type is F_UNLCK when trying to unlock a byte range. Revision Changes Path 1.65.2.1 +3 -0 src/sys/fs/smbfs/smbfs_vnops.c From jeff at FreeBSD.org Thu Apr 17 09:56:01 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Thu Apr 17 09:56:07 2008 Subject: cvs commit: src/sys/kern sched_ule.c Message-ID: <200804170956.m3H9u1nm075979@repoman.freebsd.org> jeff 2008-04-17 09:56:01 UTC FreeBSD src repository Modified files: sys/kern sched_ule.c Log: - Add a metric to describe how busy a processor has been over the last two ticks by counting the number of switches and the load when sched_clock() is called. - If the busy metric exceeds a threshold allow the idle thread to spin waiting for new work for a brief period to avoid using IPIs. This reduces the cost on the sender and receiver as well as reducing wakeup latency considerably when it works. Sponsored by: Nokia Revision Changes Path 1.243 +71 -7 src/sys/kern/sched_ule.c From bms at FreeBSD.org Thu Apr 17 11:12:23 2008 From: bms at FreeBSD.org (Bruce M. Simpson) Date: Thu Apr 17 11:12:33 2008 Subject: cvs commit: src/sys/conf files options src/sys/net radix.c radix.h route.c route.h rtsock.c src/sys/netinet in_proto.c ip_output.c src/sys/netinet6 in6_proto.c in6_src.c nd6_nbr.c In-Reply-To: <4804CF68.9060109@freebsd.org> References: <200804130545.m3D5jEtd081771@repoman.freebsd.org> <4803D7E2.80000@freebsd.org> <000201c89eae$d4dcfe10$b1335140@SAINTS> <4804CF68.9060109@freebsd.org> Message-ID: <48073093.7090103@FreeBSD.org> Andre Oppermann wrote: > In OpenBSD multipath one has to install an multipath route explicitly > with > the -mpath modifier to route(8) and for daemons with RTF_MPATH in the > routing > message. Multipath routes also retain this flag during their > lifetime. If > not set, the normal one-route-only behavior is kept. This allows all > non-mpath > aware programs to continue to work. > > I think this is the model to follow. Also for inter-BSD compatibility. I think it's fair to do this until such time as PF_ROUTE itself may evolve. The API has limitations as we know, and it has had a fair share of bugs attached to its use of legacy structure, lack of bounds checking etc. which has accumulated patches over the years. There is only 1 bit, RTF_PROTO1, which can be used to tell if a FIB entry in PF_ROUTE was dynamically added or not. Everything out there overloads this bit, so there is no way to stop daemons from clobbering each other. At the moment, anything written to follow the model of e.g. routed is just very likely to clobber other consumers. It is written to assume it controls the whole table. This is not good, considering our implementation of IRDP (Internet Router Discovery, RFC 1256) uses the routed code base. > Yes. Let me explain. There are two approaches here: The Quagga/Zebra > approach where all routing protocol daemons communicate with a central > daemon that is the single point of contact to the kernel. The other > approach is the OpenBGPD/OpenOSPFD approach where each daemon runs on > its own (because most of the time there is little to no overlap) and > does its own routing table manipulations. XORP uses the first approach. It tries to do some side-stepping to prevent clobbering other consumers, by e.g. inferring if a route would have been created automatically for an interface's subnet address and leaving other routes alone. There is code to restore the previous FIB contents on exit, however because of the above lack re RTF_PROTO1, this is not foolproof. > The second approach is a > bit tricky at the moment as the routing socket is not really intended > for operating in this way and the daemons have to be aware of each > other in certain ways. OK, let me just say: I don't believe kernel FIBs should be used as RIBs. I am definitely in favour of making changes which allow daemons to interoperate, but I don't believe we should be doing things which encourage people to use the kernel FIB as a place to exchange routes between processes. Other than perhaps a "quick hack" for testing something, but it really isn't the way to do it on an embedded box (racking up those context switches and dirty pages), and the problem with allowing quick hacks is that they tend to get perpetuated as kludges. After all, if something "kinda" works, people will keep doing it. However as you quite correctly point out, when you introduce multipath into the kernel FIB, you need to make sure there is no collision between old consumers (who know nothing of multiple next-hops) and new consumers (who will be checking and using multiple next-hop information). > > Ideally, and this is what Claudio says as well, we should end up with > the following functionality: > > - equal cost multipath where one prefix can have multiple next-hops. > - ecmp should be explicit with the RTM_MPATH flag. > - a hierarchy of multiple prefixes where the one with the highest > priority carries the traffic (possibly with ecmp). > - the hierarchy should have a number of precedence levels (interface > route, static route, IGP route, EGP route, other). > - within those precedence levels it should have further subdivision > to prefer OSPF over RIP in the IGP category for example. > - a change/delete applies to a specific precedence level if specified. > - routing socket filters on reading so that routing daemons can > select which precendence levels they want to track (IGP doesn't > have to track EGP route changes for example). > > With this functionality a number of independent but complementary routing > daemons can work together is a useful and -more important- > standardized way. Linux implements a form of update filtering on the rtnetlink socket. Re the rest of it: This is pretty much what Microsoft does -- up to a point. The API for the RIB there isn't really that open, you certainly can't just port a Linux or BSD daemon and expect it to work -- it's totally different. But they do implement explicit tagging of who owns which route. You can see all of these routes with the "route print" or "netsh ip show routes" commands, however routes added with either of these CLI tools go into a separate RIB table of their own -- you aren't modifying the final table. To an extent, you can modify the admin distance controlling which entries go where in NT, although some things stay hard-coded. I actually wrote a DLL for Windows which drops in like any other routing protocol, and allows you to inject routes into its RIB manager using the BSD routing socket. It uses an NT named pipe for this. Coding it wasn't easy as they don't provide a completely working example of how to do it -- but their code will get you say 80% of the way there. The fact that the BSD PF_ROUTE message format doesn't have support for multipath, means that this DLL has to do some side-stepping of its own to make sure the routes we plumb into TCPIP.SYS using the RTM API are removed properly. later BMS From bms at FreeBSD.org Thu Apr 17 11:15:27 2008 From: bms at FreeBSD.org (Bruce M. Simpson) Date: Thu Apr 17 11:15:43 2008 Subject: multipath stuff In-Reply-To: <004901c8a059$135ffb50$b1335140@SAINTS> References: <200804130545.m3D5jEtd081771@repoman.freebsd.org> <4803D7E2.80000@freebsd.org> <000201c89eae$d4dcfe10$b1335140@SAINTS> <48047442.1030609@FreeBSD.org> <004901c8a059$135ffb50$b1335140@SAINTS> Message-ID: <4807314D.5020707@FreeBSD.org> Qing Li wrote: > I don't know much about the OpenBSD code and never looked at that > branch. What I do know, is the original code from KAME worked on > all except FreeBSD, .. If my memory serves me right, > the crash was due to the address alias was not being properly taken > care of. Andre's got some interesting comments here. What I can say is based on a first reading it looks like the two share ancestors. I am glad you have picked it up. There are a few features from KAME in the tree which aren't completely used, and broadly related, e.g. source address selection policies, though they probably should be. I believe NetBSD ended up doing their own thing for that. > I am going to postpone this discussion until I get done > with the new ARP work. However, one thing I do want to mention, > is I doubt one can get the proper entries out of the table > using SNMP because I do know the forwarding table MIB is > and has been broken for years. The table does not support > these concepts with the proper table index. > Hmm, which MIB are you referring to? > Interesting. Is this the RFC you are referring to ? > > 3549 Linux Netlink as an IP Services Protocol. J. Salim, H. Khosravi, > A. Kleen, A. Kuznetsov. July 2003. (Format: TXT=72161 bytes) (Status: > INFORMATIONAL) > Yes, that's the one, although it doesn't document all of the TLVs in current use by iproute2. rtnetlink has become a bit of a kitchen sink protocol. Linux's equivalent of PF_KEY for example is buried in there. XORP has a class for the rtnetlink socket which presents a similar internal API to that of the BSD routing socket. cheers BMS From sos at FreeBSD.org Thu Apr 17 12:29:36 2008 From: sos at FreeBSD.org (Søren Schmidt) Date: Thu Apr 17 12:29:43 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-chipset.c ata-disk.c ata-dma.c ata-lowlevel.c ata-pci.c ata-queue.c ata-raid.c atapi-cam.c atapi-cd.c atapi-fd.c atapi-tape.c Message-ID: <200804171229.m3HCTaG4089203@repoman.freebsd.org> sos 2008-04-17 12:29:36 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.c ata-all.h ata-chipset.c ata-disk.c ata-dma.c ata-lowlevel.c ata-pci.c ata-queue.c ata-raid.c atapi-cam.c atapi-cd.c atapi-fd.c atapi-tape.c Log: Go back to preallocating everything possible on init. This avoids calling busdma in the request processing path which caused a traumatic performance degradation. Allocation has be postponed to after we know how many devices we possible can have on portmulitpliers to save some space. Revision Changes Path 1.285 +7 -58 src/sys/dev/ata/ata-all.c 1.133 +27 -18 src/sys/dev/ata/ata-all.h 1.217 +30 -26 src/sys/dev/ata/ata-chipset.c 1.210 +6 -3 src/sys/dev/ata/ata-disk.c 1.154 +139 -59 src/sys/dev/ata/ata-dma.c 1.83 +4 -4 src/sys/dev/ata/ata-lowlevel.c 1.126 +8 -8 src/sys/dev/ata/ata-pci.c 1.72 +6 -4 src/sys/dev/ata/ata-queue.c 1.130 +4 -2 src/sys/dev/ata/ata-raid.c 1.57 +2 -1 src/sys/dev/ata/atapi-cam.c 1.199 +6 -3 src/sys/dev/ata/atapi-cd.c 1.114 +2 -1 src/sys/dev/ata/atapi-fd.c 1.107 +2 -1 src/sys/dev/ata/atapi-tape.c From marius at FreeBSD.org Thu Apr 17 12:38:02 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Thu Apr 17 12:38:13 2008 Subject: cvs commit: src/sys/sparc64/pci apb.c ofw_pci_if.m ofw_pcib.c ofw_pcib_subr.c ofw_pcib_subr.h ofw_pcibus.c psycho.c psychovar.h Message-ID: <200804171238.m3HCc1Do089604@repoman.freebsd.org> marius 2008-04-17 12:38:00 UTC FreeBSD src repository Modified files: sys/sparc64/pci apb.c ofw_pci_if.m ofw_pcib.c ofw_pcib_subr.c ofw_pcib_subr.h ofw_pcibus.c psycho.c psychovar.h Log: On sparc64 machines with multiple host-PCI-bridges these bridges have separate configuration spaces so by definition they implement different PCI domains. Thus change psycho(4) to use PCI domains instead of reenumerating all PCI busses so they have globally unique bus numbers and drop support for reenumerating busses in the OFW PCI code. According to CVS history reenumeration was also required in order to get some E450 to boot but given that no other open source kernel changes the PCI bus numbers assigned by the firmware I believe the real problem was that the old code used the bus number as the device number for the PCI busses and unlike most of the other machines the firmwares of the problematic ones don't use disjoint PCI bus numbers across the host-PCI-bridges. MFC after: 1 month Revision Changes Path 1.15 +7 -5 src/sys/sparc64/pci/apb.c 1.9 +0 -35 src/sys/sparc64/pci/ofw_pci_if.m 1.9 +0 -3 src/sys/sparc64/pci/ofw_pcib.c 1.9 +0 -39 src/sys/sparc64/pci/ofw_pcib_subr.c 1.4 +0 -1 src/sys/sparc64/pci/ofw_pcib_subr.h 1.18 +0 -4 src/sys/sparc64/pci/ofw_pcibus.c 1.74 +12 -59 src/sys/sparc64/pci/psycho.c 1.18 +2 -3 src/sys/sparc64/pci/psychovar.h From gnn at FreeBSD.org Thu Apr 17 12:50:43 2008 From: gnn at FreeBSD.org (George V. Neville-Neil) Date: Thu Apr 17 12:50:54 2008 Subject: cvs commit: src/sys/netinet in.h ip_icmp.c Message-ID: <200804171250.m3HCohTP002217@repoman.freebsd.org> gnn 2008-04-17 12:50:43 UTC FreeBSD src repository Modified files: sys/netinet in.h ip_icmp.c Log: Clean up the code that checks the types of address so that it is done by understandable macros. Fix the bug that prevented the system from responding on interfaces with link local addresses assigned. PR: 120958 Submitted by: James Snow MFC after: 2 weeks Revision Changes Path 1.102 +2 -0 src/sys/netinet/in.h 1.121 +4 -3 src/sys/netinet/ip_icmp.c From brd at FreeBSD.org Thu Apr 17 14:43:30 2008 From: brd at FreeBSD.org (Brad Davis) Date: Thu Apr 17 14:43:41 2008 Subject: cvs commit: CVSROOT access Message-ID: <200804171443.m3HEhTAB063543@repoman.freebsd.org> brd 2008-04-17 14:43:29 UTC FreeBSD src repository (doc committer) Modified files: . access Log: Remove the non-contributers committers from CVSROOT-src/access since we now have the aliases in place to allow them to get what they need. Approved by: core-secretary (philip@) With hat: postmaster@ Revision Changes Path 1.873 +0 -11 CVSROOT/access From niclas.zeising at gmail.com Thu Apr 17 16:35:52 2008 From: niclas.zeising at gmail.com (Niclas Zeising) Date: Thu Apr 17 16:35:58 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-chipset.c ata-disk.c ata-dma.c ata-lowlevel.c ata-pci.c ata-queue.c ata-raid.c atapi-cam.c atapi-cd.c atapi-fd.c atapi-tape.c In-Reply-To: <200804171229.m3HCTaG4089203@repoman.freebsd.org> References: <200804171229.m3HCTaG4089203@repoman.freebsd.org> Message-ID: <48077C59.3070106@gmail.com> S?ren Schmidt wrote: > sos 2008-04-17 12:29:36 UTC > > FreeBSD src repository > > Modified files: > sys/dev/ata ata-all.c ata-all.h ata-chipset.c > ata-disk.c ata-dma.c ata-lowlevel.c > ata-pci.c ata-queue.c ata-raid.c > atapi-cam.c atapi-cd.c atapi-fd.c > atapi-tape.c > Log: > Go back to preallocating everything possible on init. > This avoids calling busdma in the request processing path which caused a traumatic performance degradation. > Allocation has be postponed to after we know how many devices we possible can have on portmulitpliers to save some space. > > Revision Changes Path > 1.285 +7 -58 src/sys/dev/ata/ata-all.c > 1.133 +27 -18 src/sys/dev/ata/ata-all.h > 1.217 +30 -26 src/sys/dev/ata/ata-chipset.c > 1.210 +6 -3 src/sys/dev/ata/ata-disk.c > 1.154 +139 -59 src/sys/dev/ata/ata-dma.c > 1.83 +4 -4 src/sys/dev/ata/ata-lowlevel.c > 1.126 +8 -8 src/sys/dev/ata/ata-pci.c > 1.72 +6 -4 src/sys/dev/ata/ata-queue.c > 1.130 +4 -2 src/sys/dev/ata/ata-raid.c > 1.57 +2 -1 src/sys/dev/ata/atapi-cam.c > 1.199 +6 -3 src/sys/dev/ata/atapi-cd.c > 1.114 +2 -1 src/sys/dev/ata/atapi-fd.c > 1.107 +2 -1 src/sys/dev/ata/atapi-tape.c Will this also remedy the panic I've had? panic: to many DMA segment entries. Regards! //Niclas From qingli at speakeasy.net Thu Apr 17 17:16:28 2008 From: qingli at speakeasy.net (Qing Li) Date: Thu Apr 17 17:16:33 2008 Subject: cvs commit: src/sys/conf files options src/sys/net radix.c radix.h route.c route.h rtsock.c src/sys/netinet in_proto.c ip_output.c src/sys/netinet6 in6_proto.c in6_src.c nd6_nbr.c Message-ID: <46872.1208452587@speakeasy.net> Andre, Bruce, Claudio: What's the timeline you have in mind for these enhancements in the routing infrastructure? 8.0 release? Are we going to divide this work up among the four of us ? What's the regression environment and regression tests you use for verifying the kernel routing code? -- Qing On Thu Apr 17 4:12 , "Bruce M. Simpson" sent: Andre Oppermann wrote: > In OpenBSD multipath one has to install an multipath route explicitly > with > the -mpath modifier to route(8) and for daemons with RTF_MPATH in the > routing > message. Multipath routes also retain this flag during their > lifetime. If > not set, the normal one-route-only behavior is kept. This allows all > non-mpath > aware programs to continue to work. > > I think this is the model to follow. Also for inter-BSD compatibility. I think it's fair to do this until such time as PF_ROUTE itself may evolve. The API has limitations as we know, and it has had a fair share of bugs attached to its use of legacy structure, lack of bounds checking etc. which has accumulated patches over the years. There is only 1 bit, RTF_PROTO1, which can be used to tell if a FIB entry in PF_ROUTE was dynamically added or not. Everything out there overloads this bit, so there is no way to stop daemons from clobbering each other. At the moment, anything written to follow the model of e.g. routed is just very likely to clobber other consumers. It is written to assume it controls the whole table. This is not good, considering our implementation of IRDP (Internet Router Discovery, RFC 1256) uses the routed code base. > Yes. Let me explain. There are two approaches here: The Quagga/Zebra > approach where all routing protocol daemons communicate with a central > daemon that is the single point of contact to the kernel. The other > approach is the OpenBGPD/OpenOSPFD approach where each daemon runs on > its own (because most of the time there is little to no overlap) and > does its own routing table manipulations. XORP uses the first approach. It tries to do some side-stepping to prevent clobbering other consumers, by e.g. inferring if a route would have been created automatically for an interface's subnet address and leaving other routes alone. There is code to restore the previous FIB contents on exit, however because of the above lack re RTF_PROTO1, this is not foolproof. > The second approach is a > bit tricky at the moment as the routing socket is not really intended > for operating in this way and the daemons have to be aware of each > other in certain ways. OK, let me just say: I don't believe kernel FIBs should be used as RIBs. I am definitely in favour of making changes which allow daemons to interoperate, but I don't believe we should be doing things which encourage people to use the kernel FIB as a place to exchange routes between processes. Other than perhaps a "quick hack" for testing something, but it really isn't the way to do it on an embedded box (racking up those context switches and dirty pages), and the problem with allowing quick hacks is that they tend to get perpetuated as kludges. After all, if something "kinda" works, people will keep doing it. However as you quite correctly point out, when you introduce multipath into the kernel FIB, you need to make sure there is no collision between old consumers (who know nothing of multiple next-hops) and new consumers (who will be checking and using multiple next-hop information). > > Ideally, and this is what Claudio says as well, we should end up with > the following functionality: > > - equal cost multipath where one prefix can have multiple next-hops. > - ecmp should be explicit with the RTM_MPATH flag. > - a hierarchy of multiple prefixes where the one with the highest > priority carries the traffic (possibly with ecmp). > - the hierarchy should have a number of precedence levels (interface > route, static route, IGP route, EGP route, other). > - within those precedence levels it should have further subdivision > to prefer OSPF over RIP in the IGP category for example. > - a change/delete applies to a specific precedence level if specified. > - routing socket filters on reading so that routing daemons can > select which precendence levels they want to track (IGP doesn't > have to track EGP route changes for example). > > With this functionality a number of independent but complementary routing > daemons can work together is a useful and -more important- > standardized way. Linux implements a form of update filtering on the rtnetlink socket. Re the rest of it: This is pretty much what Microsoft does -- up to a point. The API for the RIB there isn't really that open, you certainly can't just port a Linux or BSD daemon and expect it to work -- it's totally different. But they do implement explicit tagging of who owns which route. You can see all of these routes with the "route print" or "netsh ip show routes" commands, however routes added with either of these CLI tools go into a separate RIB table of their own -- you aren't modifying the final table. To an extent, you can modify the admin distance controlling which entries go where in NT, although some things stay hard-coded. I actually wrote a DLL for Windows which drops in like any other routing protocol, and allows you to inject routes into its RIB manager using the BSD routing socket. It uses an NT named pipe for this. Coding it wasn't easy as they don't provide a completely working example of how to do it -- but their code will get you say 80% of the way there. The fact that the BSD PF_ROUTE message format doesn't have support for multipath, means that this DLL has to do some side-stepping of its own to make sure the routes we plumb into TCPIP.SYS using the RTM API are removed properly. later BMS From freebsd-listen at fabiankeil.de Thu Apr 17 17:54:05 2008 From: freebsd-listen at fabiankeil.de (Fabian Keil) Date: Thu Apr 17 17:54:11 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-chipset.c ata-disk.c ata-dma.c ata-lowlevel.c ata-pci.c ata-queue.c ata-raid.c atapi-cam.c atapi-cd.c atapi-fd.c atapi-tape.c In-Reply-To: <200804171229.m3HCTaG4089203@repoman.freebsd.org> References: <200804171229.m3HCTaG4089203@repoman.freebsd.org> Message-ID: <20080417195338.257a1df2@fabiankeil.de> S?ren Schmidt wrote: > sos 2008-04-17 12:29:36 UTC > > FreeBSD src repository > > Modified files: > sys/dev/ata ata-all.c ata-all.h ata-chipset.c > ata-disk.c ata-dma.c ata-lowlevel.c > ata-pci.c ata-queue.c ata-raid.c > atapi-cam.c atapi-cd.c atapi-fd.c > atapi-tape.c > Log: > Go back to preallocating everything possible on init. > This avoids calling busdma in the request processing path which caused > a traumatic performance degradation. Allocation has be postponed to > after we know how many devices we possible can have on portmulitpliers > to save some space. With this commit, I'm getting a page fault in bus_dmamap_load() reached through ata_dmaload(), right after ad1 is detected: http://www.fabiankeil.de/tmp/freebsd/ata-bus-dmamap-load-page-fault-600x383.jpg http://www.fabiankeil.de/tmp/freebsd/ata-bus-dmamap-load-page-fault-where-600x440.jpg Fabian -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 195 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080417/51507c20/signature.pgp From sos at FreeBSD.org Thu Apr 17 18:11:48 2008 From: sos at FreeBSD.org (Søren Schmidt) Date: Thu Apr 17 18:11:57 2008 Subject: cvs commit: src/sys/dev/ata ata-dma.c Message-ID: <200804171811.m3HIBmJq084807@repoman.freebsd.org> sos 2008-04-17 18:11:47 UTC FreeBSD src repository Modified files: sys/dev/ata ata-dma.c Log: Alloc two DMA slots pr default, silly me forgot that slaves still exists. Revision Changes Path 1.155 +1 -1 src/sys/dev/ata/ata-dma.c From delphij at FreeBSD.org Thu Apr 17 19:03:44 2008 From: delphij at FreeBSD.org (Xin LI) Date: Thu Apr 17 19:03:55 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml Message-ID: <200804171903.m3HJ3hrI087848@repoman.freebsd.org> delphij 2008-04-17 19:03:43 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) release/doc/en_US.ISO8859-1/errata article.sgml Log: Document SA-08:05.openssh Revision Changes Path 1.73.4.4 +27 -1 src/release/doc/en_US.ISO8859-1/errata/article.sgml From jhb at FreeBSD.org Thu Apr 17 19:06:01 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Apr 17 19:06:07 2008 Subject: cvs commit: src/include stdio.h Message-ID: <200804171906.m3HJ60Lo087986@repoman.freebsd.org> jhb 2008-04-17 19:06:00 UTC FreeBSD src repository Modified files: include stdio.h Log: Specifically mark the members of 'FILE' that are accessed via inline functions or macros since they are part of the public ABI as a result. MFC after: 1 month Revision Changes Path 1.63 +10 -6 src/include/stdio.h From delphij at FreeBSD.org Thu Apr 17 19:08:42 2008 From: delphij at FreeBSD.org (Xin LI) Date: Thu Apr 17 19:08:50 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml Message-ID: <200804171908.m3HJ8gd9088098@repoman.freebsd.org> delphij 2008-04-17 19:08:42 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/errata article.sgml Log: Document SA-08:05.openssh Revision Changes Path 1.73.2.57 +6 -0 src/release/doc/en_US.ISO8859-1/errata/article.sgml From delphij at FreeBSD.org Thu Apr 17 19:10:58 2008 From: delphij at FreeBSD.org (Xin LI) Date: Thu Apr 17 19:11:09 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml Message-ID: <200804171910.m3HJAw20088239@repoman.freebsd.org> delphij 2008-04-17 19:10:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) release/doc/en_US.ISO8859-1/errata article.sgml Log: Document SA-08:05.openssh Revision Changes Path 1.69.2.53 +7 -0 src/release/doc/en_US.ISO8859-1/errata/article.sgml From remko at elvandar.org Thu Apr 17 19:13:29 2008 From: remko at elvandar.org (Remko Lodder) Date: Thu Apr 17 19:13:34 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml In-Reply-To: <200804171903.m3HJ3hrI087848@repoman.freebsd.org> References: <200804171903.m3HJ3hrI087848@repoman.freebsd.org> Message-ID: <4807A154.4000308@elvandar.org> Xin LI wrote: > delphij 2008-04-17 19:03:43 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_7) > release/doc/en_US.ISO8859-1/errata article.sgml > Log: > Document SA-08:05.openssh > > Revision Changes Path > 1.73.4.4 +27 -1 src/release/doc/en_US.ISO8859-1/errata/article.sgml Thanks for working on this! -- /"\ Best regards, | remko@FreeBSD.org \ / Remko Lodder | remko@EFnet X http://www.evilcoder.org/ | / \ ASCII Ribbon Campaign | Against HTML Mail and News From pjd at FreeBSD.org Thu Apr 17 19:19:41 2008 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Thu Apr 17 19:19:45 2008 Subject: cvs commit: src/sys/kern kern_linker.c Message-ID: <200804171919.m3HJJeRg088523@repoman.freebsd.org> pjd 2008-04-17 19:19:40 UTC FreeBSD src repository Modified files: sys/kern kern_linker.c Log: Allow linker_search_symbol_name() to be called with KLD lock held. The linker_search_symbol_name() function is used by stack_print() and stack_print() can be called from kernel module unload method. MFC after: 1 week Revision Changes Path 1.156 +6 -3 src/sys/kern/kern_linker.c From rwatson at FreeBSD.org Thu Apr 17 21:38:18 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Apr 17 21:38:21 2008 Subject: cvs commit: src/sys/contrib/pf/net pf.c src/sys/dev/cxgb/ulp/tom cxgb_cpl_socket.c src/sys/kern subr_witness.c src/sys/netinet in_mcast.c in_pcb.c in_pcb.h ip_divert.c ip_fw2.c ip_options.c ip_output.c raw_ip.c tcp_input.c tcp_output.c tcp_reass.c ... Message-ID: <200804172138.m3HLcIr4007493@repoman.freebsd.org> rwatson 2008-04-17 21:38:18 UTC FreeBSD src repository Modified files: sys/contrib/pf/net pf.c sys/dev/cxgb/ulp/tom cxgb_cpl_socket.c sys/kern subr_witness.c sys/netinet in_mcast.c in_pcb.c in_pcb.h ip_divert.c ip_fw2.c ip_options.c ip_output.c raw_ip.c tcp_input.c tcp_output.c tcp_reass.c tcp_sack.c tcp_subr.c tcp_syncache.c tcp_timer.c tcp_timewait.c tcp_usrreq.c udp_usrreq.c sys/netinet6 icmp6.c in6_pcb.c in6_src.c raw_ip6.c udp6_usrreq.c sys/security/audit audit_arg.c sys/security/mac mac_inet.c Log: Convert pcbinfo and inpcb mutexes to rwlocks, and modify macros to explicitly select write locking for all use of the inpcb mutex. Update some pcbinfo lock assertions to assert locked rather than write-locked, although in practice almost all uses of the pcbinfo rwlock main exclusive, and all instances of inpcb lock acquisition are exclusive. This change should introduce (ideally) little functional change. However, it lays the groundwork for significantly increased parallelism in the TCP/IP code. MFC after: 3 months Tested by: kris (superset of committered patch) Revision Changes Path 1.52 +4 -4 src/sys/contrib/pf/net/pf.c 1.8 +2 -2 src/sys/dev/cxgb/ulp/tom/cxgb_cpl_socket.c 1.247 +5 -5 src/sys/kern/subr_witness.c 1.4 +28 -28 src/sys/netinet/in_mcast.c 1.204 +40 -31 src/sys/netinet/in_pcb.c 1.105 +27 -17 src/sys/netinet/in_pcb.h 1.132 +17 -17 src/sys/netinet/ip_divert.c 1.184 +3 -3 src/sys/netinet/ip_fw2.c 1.9 +1 -1 src/sys/netinet/ip_options.c 1.281 +7 -7 src/sys/netinet/ip_output.c 1.182 +31 -31 src/sys/netinet/raw_ip.c 1.375 +20 -20 src/sys/netinet/tcp_input.c 1.150 +1 -1 src/sys/netinet/tcp_output.c 1.354 +1 -1 src/sys/netinet/tcp_reass.c 1.41 +8 -8 src/sys/netinet/tcp_sack.c 1.305 +29 -29 src/sys/netinet/tcp_subr.c 1.142 +6 -6 src/sys/netinet/tcp_syncache.c 1.100 +16 -16 src/sys/netinet/tcp_timer.c 1.289 +14 -14 src/sys/netinet/tcp_timewait.c 1.168 +68 -68 src/sys/netinet/tcp_usrreq.c 1.220 +36 -34 src/sys/netinet/udp_usrreq.c 1.83 +4 -4 src/sys/netinet6/icmp6.c 1.89 +18 -18 src/sys/netinet6/in6_pcb.c 1.51 +1 -1 src/sys/netinet6/in6_src.c 1.77 +17 -17 src/sys/netinet6/raw_ip6.c 1.86 +25 -25 src/sys/netinet6/udp6_usrreq.c 1.20 +2 -2 src/sys/security/audit/audit_arg.c 1.17 +3 -3 src/sys/security/mac/mac_inet.c From rwatson at FreeBSD.org Thu Apr 17 21:50:14 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Apr 17 21:50:20 2008 Subject: cvs commit: src/sys/contrib/pf/net pf.c src/sys/dev/cxgb/ulp/tom cxgb_cpl_socket.c src/sys/kern subr_witness.c src/sys/netinet in_mcast.c in_pcb.c in_pcb.h ip_divert.c ip_fw2.c ip_options.c ip_output.c raw_ip.c tcp_input.c tcp_output.c tcp_reass.c ... In-Reply-To: <200804172138.m3HLcIr4007493@repoman.freebsd.org> References: <200804172138.m3HLcIr4007493@repoman.freebsd.org> Message-ID: <20080417224830.E94395@fledge.watson.org> On Thu, 17 Apr 2008, Robert Watson wrote: > Convert pcbinfo and inpcb mutexes to rwlocks, and modify macros to > explicitly select write locking for all use of the inpcb mutex. > Update some pcbinfo lock assertions to assert locked rather than > write-locked, although in practice almost all uses of the pcbinfo > rwlock main exclusive, and all instances of inpcb lock acquisition > are exclusive. > > This change should introduce (ideally) little functional change. > However, it lays the groundwork for significantly increased > parallelism in the TCP/IP code. > > MFC after: 3 months > Tested by: kris (superset of committered patch) In a week or so, once this change has settled out, I'll merge the UDP locking changes that Kris and I developed to improve performance with BIND9 and nsd. Kris has reported significant (>20%) performance improvements in DNS workloads by virtue of eliminating UDP-layer lock contention by using read locks on the inpcb on input/output processing, and read locks on the pcbinfo in input processing. Those changes do, however, increase contention on routing and device driver/ifqeueu layer locks, which also require attention. These changes are on the slow path to an MFC, assuming now ABI (or more general) problems arise. If you experience any performance loss as a result of this change, please let me know ASAP -- in principle exclusive rwlocks are very much lock mutexes, but perhaps something has been missed (or misunderstood). Thanks, Robert N M Watson Computer Laboratory University of Cambridge From rwatson at FreeBSD.org Thu Apr 17 21:54:08 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Thu Apr 17 21:54:15 2008 Subject: cvs commit: src/sys/kern kern_linker.c In-Reply-To: <200804171919.m3HJJeRg088523@repoman.freebsd.org> References: <200804171919.m3HJJeRg088523@repoman.freebsd.org> Message-ID: <20080417225220.A94395@fledge.watson.org> On Thu, 17 Apr 2008, Pawel Jakub Dawidek wrote: > pjd 2008-04-17 19:19:40 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_linker.c > Log: > Allow linker_search_symbol_name() to be called with KLD lock held. > The linker_search_symbol_name() function is used by stack_print() > and stack_print() can be called from kernel module unload method. I'm not sure I'm entirely comfortable with this locking change; conditional locking of this type is something we've generally tried to eliminate. If this is for debugging code used in locking sensitive contexts, it is probably preferable to use one of the _ddb variations on the stack(9) routines, which bypass locking. Or, in this case, it simply uses the locks that are already, conveniently, held. Robert N M Watson Computer Laboratory University of Cambridge From cokane at FreeBSD.org Thu Apr 17 22:01:39 2008 From: cokane at FreeBSD.org (Coleman Kane) Date: Thu Apr 17 22:01:46 2008 Subject: cvs commit: src/sys/dev/if_ndis if_ndis.c if_ndisvar.h Message-ID: <200804172201.m3HM1djs008290@repoman.freebsd.org> cokane 2008-04-17 22:01:39 UTC FreeBSD src repository Modified files: sys/dev/if_ndis if_ndis.c if_ndisvar.h Log: Change the timeout(9) usage in if_ndis to a callout(9) implementation, as the former is becoming deprecated and exhibits some extraneous Giant-locking. The new callout(9) is declared MPSAFE, so it may improve concurrency. Tested by: matteo Silence from: wpaul MFC after: 1 month Revision Changes Path 1.132 +6 -9 src/sys/dev/if_ndis/if_ndis.c 1.29 +1 -1 src/sys/dev/if_ndis/if_ndisvar.h From jhb at FreeBSD.org Thu Apr 17 22:17:55 2008 From: jhb at FreeBSD.org (John Baldwin) Date: Thu Apr 17 22:18:04 2008 Subject: cvs commit: src/include stdio.h src/lib/libc/stdio _flock_stub.c asprintf.c fgetwc.c fgetws.c findfp.c fputwc.c fputws.c freopen.c fseek.c fwide.c local.h refill.c snprintf.c sprintf.c sscanf.c ungetc.c ungetwc.c vasprintf.c vfprintf.c vfwprintf.c vsnprintf.c ... Message-ID: <200804172217.m3HMHtIG010014@repoman.freebsd.org> jhb 2008-04-17 22:17:54 UTC FreeBSD src repository Modified files: include stdio.h lib/libc/stdio _flock_stub.c asprintf.c fgetwc.c fgetws.c findfp.c fputwc.c fputws.c freopen.c fseek.c fwide.c local.h refill.c snprintf.c sprintf.c sscanf.c ungetc.c ungetwc.c vasprintf.c vfprintf.c vfwprintf.c vsnprintf.c vsprintf.c vsscanf.c vswprintf.c vswscanf.c xprintf.c Log: Next stage of stdio cleanup: Retire __sFILEX and merge the fields back into __sFILE. This was supposed to be done in 6.0. Some notes: - Where possible I restored the various lines to their pre-__sFILEX state. - Retire INITEXTRA() and just initialize the wchar bits (orientation and mbstate) explicitly instead. The various places that used INITEXTRA didn't need the locking fields or _up initialized. (Some places needed _up to exist and not be off the end of a NULL or garbage pointer, but they didn't require it to be initialized to a specific value.) - For now, stdio.h "knows" that pthread_t is a 'struct pthread *' to avoid namespace pollution of including all the pthread types in stdio.h. Once we remove all the inlines and make __sFILE private it can go back to using pthread_t, etc. - This does not remove any of the inlines currently and does not change any of the public ABI of 'FILE'. MFC after: 1 month Reviewed by: peter Revision Changes Path 1.64 +7 -4 src/include/stdio.h 1.16 +16 -26 src/lib/libc/stdio/_flock_stub.c 1.14 +2 -3 src/lib/libc/stdio/asprintf.c 1.13 +1 -1 src/lib/libc/stdio/fgetwc.c 1.7 +2 -2 src/lib/libc/stdio/fgetws.c 1.32 +11 -45 src/lib/libc/stdio/findfp.c 1.11 +1 -2 src/lib/libc/stdio/fputwc.c 1.7 +1 -1 src/lib/libc/stdio/fputws.c 1.21 +2 -2 src/lib/libc/stdio/freopen.c 1.44 +4 -4 src/lib/libc/stdio/fseek.c 1.2 +3 -3 src/lib/libc/stdio/fwide.c 1.31 +2 -21 src/lib/libc/stdio/local.h 1.20 +1 -1 src/lib/libc/stdio/refill.c 1.22 +2 -3 src/lib/libc/stdio/snprintf.c 1.16 +2 -3 src/lib/libc/stdio/sprintf.c 1.13 +2 -3 src/lib/libc/stdio/sscanf.c 1.18 +1 -1 src/lib/libc/stdio/ungetc.c 1.11 +1 -1 src/lib/libc/stdio/ungetwc.c 1.19 +2 -3 src/lib/libc/stdio/vasprintf.c 1.78 +2 -1 src/lib/libc/stdio/vfprintf.c 1.29 +2 -1 src/lib/libc/stdio/vfwprintf.c 1.24 +2 -3 src/lib/libc/stdio/vsnprintf.c 1.16 +2 -3 src/lib/libc/stdio/vsprintf.c 1.14 +2 -3 src/lib/libc/stdio/vsscanf.c 1.7 +2 -3 src/lib/libc/stdio/vswprintf.c 1.5 +2 -3 src/lib/libc/stdio/vswscanf.c 1.6 +2 -1 src/lib/libc/stdio/xprintf.c From thompsa at FreeBSD.org Thu Apr 17 22:44:36 2008 From: thompsa at FreeBSD.org (Andrew Thompson) Date: Thu Apr 17 22:45:03 2008 Subject: cvs commit: src/sys/dev/if_ndis if_ndis.c if_ndisvar.h In-Reply-To: <200804172201.m3HM1djs008290@repoman.freebsd.org> References: <200804172201.m3HM1djs008290@repoman.freebsd.org> Message-ID: <20080417221427.GD21457@citylink.fud.org.nz> On Thu, Apr 17, 2008 at 10:01:39PM +0000, Coleman Kane wrote: > cokane 2008-04-17 22:01:39 UTC > > FreeBSD src repository > > Modified files: > sys/dev/if_ndis if_ndis.c if_ndisvar.h > Log: > Change the timeout(9) usage in if_ndis to a callout(9) implementation, > as the former is becoming deprecated and exhibits some extraneous > Giant-locking. The new callout(9) is declared MPSAFE, so it may > improve concurrency. > > Tested by: matteo > Silence from: wpaul > MFC after: 1 month > > --- src/sys/dev/if_ndis/if_ndis.c 2008/01/17 20:11:58 1.131 > +++ src/sys/dev/if_ndis/if_ndis.c 2008/04/17 22:01:38 1.132 > > return; > } > @@ -1939,8 +1935,9 @@ ndis_init(xsc) > if (sc->ndis_block->nmb_checkforhangsecs == 0) > sc->ndis_block->nmb_checkforhangsecs = 3; > > - sc->ndis_stat_ch = timeout(ndis_tick, sc, > - hz * sc->ndis_block->nmb_checkforhangsecs); > + callout_init(&sc->ndis_stat_callout, 1); ^^^^^^^ This should be spelled CALLOUT_MPSAFE :) Andrew From cokane at FreeBSD.org Thu Apr 17 22:57:34 2008 From: cokane at FreeBSD.org (Coleman Kane) Date: Thu Apr 17 22:57:42 2008 Subject: cvs commit: src/sys/dev/if_ndis if_ndis.c Message-ID: <200804172257.m3HMvYPf011333@repoman.freebsd.org> cokane 2008-04-17 22:57:33 UTC FreeBSD src repository Modified files: sys/dev/if_ndis if_ndis.c Log: Change the 1 in callout_init to CALLOUT_MPSAFE. I made the change in my tree, but never committed it into git before making my patch! Submitted by: thompsa MFC after: 1 month Revision Changes Path 1.133 +1 -1 src/sys/dev/if_ndis/if_ndis.c From gad at FreeBSD.org Thu Apr 17 23:17:13 2008 From: gad at FreeBSD.org (Garance A Drosehn) Date: Thu Apr 17 23:17:19 2008 Subject: cvs commit: src/usr.bin/env env.1 env.c Message-ID: <200804172317.m3HNHCGw013115@repoman.freebsd.org> gad 2008-04-17 23:17:09 UTC FreeBSD src repository Modified files: usr.bin/env env.1 env.c Log: Add the '-u name' option to the env command, which will completely unset the given variable name (removing it from the environment, instead of just setting it to a null value). PR: bin/65649 MFC after: 2 weeks Revision Changes Path 1.10 +21 -5 src/usr.bin/env/env.1 1.20 +10 -3 src/usr.bin/env/env.c From gnn at FreeBSD.org Thu Apr 17 23:24:58 2008 From: gnn at FreeBSD.org (George V. Neville-Neil) Date: Thu Apr 17 23:25:04 2008 Subject: cvs commit: src/sys/netinet ip_icmp.c Message-ID: <200804172324.m3HNOwaI013427@repoman.freebsd.org> gnn 2008-04-17 23:24:58 UTC FreeBSD src repository Modified files: sys/netinet ip_icmp.c Log: Add in check for loopback as well, which was missing from the original patch. PR: 120958 Submitted by: James Snow MFC after: 2 weeks Revision Changes Path 1.122 +1 -0 src/sys/netinet/ip_icmp.c From marcel at FreeBSD.org Thu Apr 17 23:36:36 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Thu Apr 17 23:36:48 2008 Subject: cvs commit: src/gnu/usr.bin/binutils/libbfd Makefile.i386 Message-ID: <200804172336.m3HNaZcU013883@repoman.freebsd.org> marcel 2008-04-17 23:36:35 UTC FreeBSD src repository Modified files: gnu/usr.bin/binutils/libbfd Makefile.i386 Log: Add support for the 32-bit EFI target. Revision Changes Path 1.18 +10 -3 src/gnu/usr.bin/binutils/libbfd/Makefile.i386 From delphij at FreeBSD.org Fri Apr 18 00:01:56 2008 From: delphij at FreeBSD.org (Xin LI) Date: Fri Apr 18 00:02:01 2008 Subject: cvs commit: src/lib/libstand Makefile bzipfs.c bzlib.c.diff bzlib.h.diff bzlib_private.h.diff zutil.h.diff Message-ID: <200804180001.m3I01unx015154@repoman.freebsd.org> delphij 2008-04-18 00:01:56 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) lib/libstand Makefile bzipfs.c Removed files: (Branch: RELENG_5) lib/libstand bzlib.c.diff bzlib.h.diff bzlib_private.h.diff zutil.h.diff Log: MFC: Handle bzip2/zlib changes without using patches, by doing the work in a programmatical way. This is an accumulative patch of the following changes: Makefile: 1.46-1.53 bzipfs.c: 1.7 as well as removal of the now unneeded files. Revision Changes Path 1.43.2.2 +30 -31 src/lib/libstand/Makefile 1.6.2.1 +1 -1 src/lib/libstand/bzipfs.c 1.2.8.1 +0 -58 src/lib/libstand/bzlib.c.diff (dead) 1.1.12.1 +0 -15 src/lib/libstand/bzlib.h.diff (dead) 1.2.6.1 +0 -22 src/lib/libstand/bzlib_private.h.diff (dead) 1.1.8.1 +0 -15 src/lib/libstand/zutil.h.diff (dead) From emax at FreeBSD.org Fri Apr 18 00:52:33 2008 From: emax at FreeBSD.org (Maksim Yevmenkin) Date: Fri Apr 18 00:52:40 2008 Subject: cvs commit: src/sys/net if_tap.c Message-ID: <200804180052.m3I0qWGx027208@repoman.freebsd.org> emax 2008-04-18 00:52:32 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/net if_tap.c Log: MFC: Fix possible buffer overrun on 64-bit arch when generating MAC address for tap interface. Reported by: Marc Lorner < marc dot loerner at hob dot de > Reviewed by: bms Revision Changes Path 1.71.2.1 +3 -1 src/sys/net/if_tap.c From emax at FreeBSD.org Fri Apr 18 00:55:03 2008 From: emax at FreeBSD.org (Maksim Yevmenkin) Date: Fri Apr 18 00:55:09 2008 Subject: cvs commit: src/sys/net if_tap.c Message-ID: <200804180055.m3I0t30k027324@repoman.freebsd.org> emax 2008-04-18 00:55:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/net if_tap.c Log: MFC: Fix possible buffer overrun on 64-bit arch when generating MAC address for tap interface. Reported by: Marc Lorner < marc dot loerner at hob dot de > Reviewed by: bms MFC after: 3 days Revision Changes Path 1.55.2.12 +3 -1 src/sys/net/if_tap.c From davidxu at FreeBSD.org Fri Apr 18 02:02:33 2008 From: davidxu at FreeBSD.org (David Xu) Date: Fri Apr 18 02:02:43 2008 Subject: cvs commit: src/sys/sys termios.h Message-ID: <200804180202.m3I22X5H030690@repoman.freebsd.org> davidxu 2008-04-18 02:02:33 UTC FreeBSD src repository Modified files: sys/sys termios.h Log: Add missing function prototype for tcgetsid(). Revision Changes Path 1.21 +10 -0 src/sys/sys/termios.h From marcel at FreeBSD.org Fri Apr 18 02:21:11 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Fri Apr 18 02:21:18 2008 Subject: cvs commit: src/sys/ia64/include vmparam.h Message-ID: <200804180221.m3I2LBdQ032575@repoman.freebsd.org> marcel 2008-04-18 02:21:11 UTC FreeBSD src repository Modified files: sys/ia64/include vmparam.h Log: Remove cruft we got from Alpha, which was probably inherited from NetBSD. I.e. make it more like a FreeBSD header. Revision Changes Path 1.19 +6 -31 src/sys/ia64/include/vmparam.h From kmacy at FreeBSD.org Fri Apr 18 02:45:41 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Fri Apr 18 02:45:47 2008 Subject: cvs commit: src/sys/conf files src/sys/dev/cxgb cxgb_adapter.h cxgb_config.h cxgb_include.h cxgb_ioctl.h cxgb_l2t.c cxgb_l2t.h cxgb_lro.c cxgb_main.c cxgb_multiq.c cxgb_offload.c cxgb_offload.h cxgb_osdep.h cxgb_sge.c cxgb_t3fw.c cxgb_t3fw.h ... Message-ID: <200804180245.m3I2jeqa034250@repoman.freebsd.org> kmacy 2008-04-18 02:45:39 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/conf files sys/dev/cxgb cxgb_adapter.h cxgb_config.h cxgb_include.h cxgb_ioctl.h cxgb_lro.c cxgb_main.c cxgb_offload.c cxgb_offload.h cxgb_osdep.h cxgb_sge.c sys/dev/cxgb/common cxgb_ael1002.c cxgb_common.h cxgb_ctl_defs.h cxgb_firmware_exports.h cxgb_mc5.c cxgb_mv88e1xxx.c cxgb_regs.h cxgb_t3_cpl.h cxgb_t3_hw.c cxgb_tcb.h cxgb_version.h cxgb_vsc8211.c cxgb_xgmac.c sys/dev/cxgb/sys mvec.h uipc_mvec.c sys/modules/cxgb Makefile Added files: (Branch: RELENG_7) sys/dev/cxgb cxgb_multiq.c cxgb_t3fw.c cxgb_t3fw.h t3b_protocol_sram.h t3b_tp_eeprom.h t3cdev.h sys/dev/cxgb/sys cxgb_support.c sys/dev/cxgb/ulp/toecore cxgb_toedev.h sys/modules/cxgb/cxgb Makefile sys/modules/cxgb/cxgb_t3fw Makefile Removed files: (Branch: RELENG_7) sys/dev/cxgb cxgb_l2t.c cxgb_l2t.h t3b_protocol_sram-1.1.0.bin.gz.uu t3b_tp_eeprom-1.1.0.bin.gz.uu t3fw-4.7.0.bin.gz.uu sys/dev/cxgb/ulp/toecore toedev.h Log: MFC of 1.133 import and fixes: - add support for T3C - add multicast support - update copyrights - add infrastructure for multiple transmit queues - add support for compiling firmware in to the kernel - add conditional define for enabling link at device attach - exit tick handler if shutdown is in progress - add sysctls for dumping transmit queues - use jumbo clusters for large packets - add pcpu caching - add inline mbuf header on receive - upgrade to version 5.0 of the firmware Supported by: Chelsio Inc. Revision Changes Path 1.1243.2.17 +3 -1 src/sys/conf/files 1.3.2.1 +30 -19 src/sys/dev/cxgb/common/cxgb_ael1002.c 1.7.2.1 +27 -19 src/sys/dev/cxgb/common/cxgb_common.h 1.3.2.1 +2 -2 src/sys/dev/cxgb/common/cxgb_ctl_defs.h 1.2.2.1 +2 -0 src/sys/dev/cxgb/common/cxgb_firmware_exports.h 1.5.2.1 +16 -3 src/sys/dev/cxgb/common/cxgb_mc5.c 1.2.2.1 +26 -9 src/sys/dev/cxgb/common/cxgb_mv88e1xxx.c 1.3.2.1 +1209 -492 src/sys/dev/cxgb/common/cxgb_regs.h 1.4.2.1 +21 -2 src/sys/dev/cxgb/common/cxgb_t3_cpl.h 1.9.2.1 +295 -83 src/sys/dev/cxgb/common/cxgb_t3_hw.c 1.2.2.1 +5 -2 src/sys/dev/cxgb/common/cxgb_tcb.h 1.4.2.1 +2 -2 src/sys/dev/cxgb/common/cxgb_version.h 1.3.2.1 +169 -7 src/sys/dev/cxgb/common/cxgb_vsc8211.c 1.7.2.1 +115 -28 src/sys/dev/cxgb/common/cxgb_xgmac.c 1.20.2.1 +104 -32 src/sys/dev/cxgb/cxgb_adapter.h 1.4.2.1 +4 -2 src/sys/dev/cxgb/cxgb_config.h 1.2.2.1 +9 -11 src/sys/dev/cxgb/cxgb_include.h 1.5.2.1 +13 -10 src/sys/dev/cxgb/cxgb_ioctl.h 1.3.2.1 +0 -668 src/sys/dev/cxgb/cxgb_l2t.c (dead) 1.2.2.1 +0 -165 src/sys/dev/cxgb/cxgb_l2t.h (dead) 1.8.2.1 +1 -1 src/sys/dev/cxgb/cxgb_lro.c 1.36.2.2 +391 -298 src/sys/dev/cxgb/cxgb_main.c 1.7.2.1 +799 -0 src/sys/dev/cxgb/cxgb_multiq.c (new) 1.8.2.1 +125 -1301 src/sys/dev/cxgb/cxgb_offload.c 1.5.2.1 +40 -32 src/sys/dev/cxgb/cxgb_offload.h 1.14.2.1 +216 -36 src/sys/dev/cxgb/cxgb_osdep.h 1.30.2.1 +1157 -508 src/sys/dev/cxgb/cxgb_sge.c 1.2.2.1 +115 -0 src/sys/dev/cxgb/cxgb_t3fw.c (new) 1.1.2.1 +6621 -0 src/sys/dev/cxgb/cxgb_t3fw.h (new) 1.7.2.1 +340 -0 src/sys/dev/cxgb/sys/cxgb_support.c (new) 1.6.2.2 +212 -63 src/sys/dev/cxgb/sys/mvec.h 1.14.2.2 +315 -501 src/sys/dev/cxgb/sys/uipc_mvec.c 1.1.4.1 +0 -46 src/sys/dev/cxgb/t3b_protocol_sram-1.1.0.bin.gz.uu (dead) 1.1.2.1 +678 -0 src/sys/dev/cxgb/t3b_protocol_sram.h (new) 1.1.4.1 +0 -46 src/sys/dev/cxgb/t3b_tp_eeprom-1.1.0.bin.gz.uu (dead) 1.1.2.1 +566 -0 src/sys/dev/cxgb/t3b_tp_eeprom.h (new) 1.3.2.1 +62 -0 src/sys/dev/cxgb/t3cdev.h (new) 1.1.2.1 +0 -451 src/sys/dev/cxgb/t3fw-4.7.0.bin.gz.uu (dead) 1.2.2.1 +47 -0 src/sys/dev/cxgb/ulp/toecore/cxgb_toedev.h (new) 1.1.4.1 +0 -172 src/sys/dev/cxgb/ulp/toecore/toedev.h (dead) 1.10.2.1 +3 -43 src/sys/modules/cxgb/Makefile 1.8.2.1 +18 -0 src/sys/modules/cxgb/cxgb/Makefile (new) 1.2.2.1 +8 -0 src/sys/modules/cxgb/cxgb_t3fw/Makefile (new) From delphij at FreeBSD.org Fri Apr 18 04:23:06 2008 From: delphij at FreeBSD.org (Xin LI) Date: Fri Apr 18 04:23:17 2008 Subject: cvs commit: src/lib/libstand stand.h Message-ID: <200804180423.m3I4N69R040148@repoman.freebsd.org> delphij 2008-04-18 04:23:06 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) lib/libstand stand.h Log: MFC: Allow stand.h to be included for multiple times Revision Changes Path 1.39.2.1 +5 -0 src/lib/libstand/stand.h From jeff at FreeBSD.org Fri Apr 18 05:47:57 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Fri Apr 18 05:48:02 2008 Subject: cvs commit: src/sys/amd64/include cpufunc.h src/sys/i386/include cpufunc.h Message-ID: <200804180547.m3I5luMu053131@repoman.freebsd.org> jeff 2008-04-18 05:47:56 UTC FreeBSD src repository Modified files: sys/amd64/include cpufunc.h sys/i386/include cpufunc.h Log: - Add inlines for the monitor and mwait instructions. Sponsored by: Nokia Revision Changes Path 1.149 +13 -0 src/sys/amd64/include/cpufunc.h 1.146 +13 -0 src/sys/i386/include/cpufunc.h From pjd at FreeBSD.org Fri Apr 18 07:14:14 2008 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Fri Apr 18 07:14:20 2008 Subject: cvs commit: src/sys/kern kern_linker.c In-Reply-To: <20080417225220.A94395@fledge.watson.org> References: <200804171919.m3HJJeRg088523@repoman.freebsd.org> <20080417225220.A94395@fledge.watson.org> Message-ID: <20080418064956.GA6029@garage.freebsd.pl> On Thu, Apr 17, 2008 at 10:54:08PM +0100, Robert Watson wrote: > > On Thu, 17 Apr 2008, Pawel Jakub Dawidek wrote: > > >pjd 2008-04-17 19:19:40 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_linker.c > > Log: > > Allow linker_search_symbol_name() to be called with KLD lock held. > > The linker_search_symbol_name() function is used by stack_print() > > and stack_print() can be called from kernel module unload method. > > I'm not sure I'm entirely comfortable with this locking change; conditional > locking of this type is something we've generally tried to eliminate. If > this is for debugging code used in locking sensitive contexts, it is > probably preferable to use one of the _ddb variations on the stack(9) > routines, which bypass locking. Or, in this case, it simply uses the locks > that are already, conveniently, held. We would need to change all stack(9) consumers to grab KLD_LOCK() before calling its functions, which I don't find very nice. Currently stack(9) functions are mostly called from contexts where KLD lock is not yet held, but in this case where I want to print leaked objects on module unload, the KLD lock is already held. -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080418/1ac03ce7/attachment.pgp From kris at FreeBSD.org Fri Apr 18 07:48:25 2008 From: kris at FreeBSD.org (Kris Kennaway) Date: Fri Apr 18 07:48:32 2008 Subject: cvs commit: src/sys/dev/if_ndis if_ndis.c if_ndisvar.h In-Reply-To: <20080417221427.GD21457@citylink.fud.org.nz> References: <200804172201.m3HM1djs008290@repoman.freebsd.org> <20080417221427.GD21457@citylink.fud.org.nz> Message-ID: <20080418074825.GT25623@hub.freebsd.org> On Fri, Apr 18, 2008 at 10:14:27AM +1200, Andrew Thompson wrote: > On Thu, Apr 17, 2008 at 10:01:39PM +0000, Coleman Kane wrote: > > cokane 2008-04-17 22:01:39 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/if_ndis if_ndis.c if_ndisvar.h > > Log: > > Change the timeout(9) usage in if_ndis to a callout(9) implementation, > > as the former is becoming deprecated and exhibits some extraneous > > Giant-locking. The new callout(9) is declared MPSAFE, so it may > > improve concurrency. > > > > Tested by: matteo > > Silence from: wpaul > > MFC after: 1 month > > > > --- src/sys/dev/if_ndis/if_ndis.c 2008/01/17 20:11:58 1.131 > > +++ src/sys/dev/if_ndis/if_ndis.c 2008/04/17 22:01:38 1.132 > > > > return; > > } > > @@ -1939,8 +1935,9 @@ ndis_init(xsc) > > if (sc->ndis_block->nmb_checkforhangsecs == 0) > > sc->ndis_block->nmb_checkforhangsecs = 3; > > > > - sc->ndis_stat_ch = timeout(ndis_tick, sc, > > - hz * sc->ndis_block->nmb_checkforhangsecs); > > + callout_init(&sc->ndis_stat_callout, 1); > ^^^^^^^ > This should be spelled CALLOUT_MPSAFE :) Hah, I had made a note to check that later. Thanks! :) Kris -- In God we Trust -- all others must submit an X.509 certificate. -- Charles Forsythe From palmershotel at yahoo.ca Fri Apr 18 14:40:16 2008 From: palmershotel at yahoo.ca (Brenda) Date: Fri Apr 18 14:40:21 2008 Subject: (no subject) Message-ID: <20080418144008.A48461E6A2D@contactar01> am Brenda from Canada, i am the assistant manager of Canadian Hotels,i wish to inform you that the hotel need man and woman who can work and live in omni hotel Canada , A Division Of Delta Chelsea Canadian Hotel Canada , hotel will care of your tickets,accommodation lodging and the visa assistance in your country,if you are interested ,you should please contact me back via the mail box, omini_ottawa@yahoo.ca N/B MANAGEMENT ARE NOT RESPONSIBLE FOR YOUR CANADA CLEARANCE VISA FEE. TAKE CARE From palmershotel at yahoo.ca Fri Apr 18 14:40:36 2008 From: palmershotel at yahoo.ca (Brenda) Date: Fri Apr 18 14:40:42 2008 Subject: (no subject) Message-ID: <20080418144030.526301E6C1F@contactar01> am Brenda from Canada, i am the assistant manager of Canadian Hotels,i wish to inform you that the hotel need man and woman who can work and live in omni hotel Canada , A Division Of Delta Chelsea Canadian Hotel Canada , hotel will care of your tickets,accommodation lodging and the visa assistance in your country,if you are interested ,you should please contact me back via the mail box, omini_ottawa@yahoo.ca N/B MANAGEMENT ARE NOT RESPONSIBLE FOR YOUR CANADA CLEARANCE VISA FEE. TAKE CARE From sos at FreeBSD.org Fri Apr 18 15:15:06 2008 From: sos at FreeBSD.org (Søren Schmidt) Date: Fri Apr 18 15:15:17 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c ata-dma.c Message-ID: <200804181515.m3IFF6Nr005172@repoman.freebsd.org> sos 2008-04-18 15:15:04 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.c ata-dma.c Log: Fix the breakage that caused AHCI devices to vanish. Editor droppings :( Put the ATAPI device numbering back to the old ways. Revision Changes Path 1.286 +3 -1 src/sys/dev/ata/ata-all.c 1.156 +0 -25 src/sys/dev/ata/ata-dma.c From obrien at FreeBSD.org Fri Apr 18 16:06:46 2008 From: obrien at FreeBSD.org (David E. O'Brien) Date: Fri Apr 18 16:06:57 2008 Subject: cvs commit: src/contrib/gcc/config/i386 freebsd64.h src/gnu/usr.bin/cc/cc_tools Makefile freebsd64-fix.h Message-ID: <200804181606.m3IG6k0D038568@repoman.freebsd.org> obrien 2008-04-18 16:06:46 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) contrib/gcc/config/i386 freebsd64.h gnu/usr.bin/cc/cc_tools Makefile Removed files: (Branch: RELENG_6) gnu/usr.bin/cc/cc_tools freebsd64-fix.h Log: Move our ".mcount" bits around a little. Revision Changes Path 1.9.8.1 +4 -1 src/contrib/gcc/config/i386/freebsd64.h 1.81.2.3 +0 -1 src/gnu/usr.bin/cc/cc_tools/Makefile 1.1.8.1 +0 -9 src/gnu/usr.bin/cc/cc_tools/freebsd64-fix.h (dead) From kmacy at FreeBSD.org Sat Apr 19 03:22:44 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sat Apr 19 03:22:48 2008 Subject: cvs commit: src/sys/conf files src/sys/dev/cxgb cxgb_l2t.c cxgb_l2t.h cxgb_main.c cxgb_offload.c cxgb_offload.h src/sys/dev/cxgb/ulp/tom cxgb_cpl_io.c cxgb_cpl_socket.c cxgb_ddp.c cxgb_defs.h cxgb_l2t.c cxgb_l2t.h cxgb_listen.c ... Message-ID: <200804190322.m3J3Mh7J034044@repoman.freebsd.org> kmacy 2008-04-19 03:22:43 UTC FreeBSD src repository Modified files: sys/conf files sys/dev/cxgb cxgb_main.c cxgb_offload.c cxgb_offload.h sys/dev/cxgb/ulp/tom cxgb_cpl_io.c cxgb_cpl_socket.c cxgb_ddp.c cxgb_defs.h cxgb_listen.c cxgb_t3_ddp.h cxgb_tom.c cxgb_tom_sysctl.c sys/modules/cxgb/cxgb Makefile sys/modules/cxgb/tom Makefile sys/netinet tcp_offload.h Added files: sys/dev/cxgb/ulp/tom cxgb_l2t.c cxgb_l2t.h cxgb_tcp_offload.c cxgb_tcp_offload.h Removed files: sys/dev/cxgb cxgb_l2t.c cxgb_l2t.h Log: move cxgb_lt2.[ch] from NIC to TOE move most offload functionality from NIC to TOE factor out all socket and inpcb direct access factor out access to locking in incpb, pcbinfo, and sockbuf Revision Changes Path 1.1291 +0 -1 src/sys/conf/files 1.8 +0 -543 src/sys/dev/cxgb/cxgb_l2t.c (dead) 1.6 +0 -161 src/sys/dev/cxgb/cxgb_l2t.h (dead) 1.54 +4 -12 src/sys/dev/cxgb/cxgb_main.c 1.13 +54 -1076 src/sys/dev/cxgb/cxgb_offload.c 1.9 +2 -2 src/sys/dev/cxgb/cxgb_offload.h 1.10 +545 -402 src/sys/dev/cxgb/ulp/tom/cxgb_cpl_io.c 1.9 +164 -94 src/sys/dev/cxgb/ulp/tom/cxgb_cpl_socket.c 1.3 +62 -62 src/sys/dev/cxgb/ulp/tom/cxgb_ddp.c 1.4 +8 -6 src/sys/dev/cxgb/ulp/tom/cxgb_defs.h 1.1 +542 -0 src/sys/dev/cxgb/ulp/tom/cxgb_l2t.c (new) 1.1 +161 -0 src/sys/dev/cxgb/ulp/tom/cxgb_l2t.h (new) 1.4 +0 -1 src/sys/dev/cxgb/ulp/tom/cxgb_listen.c 1.3 +10 -8 src/sys/dev/cxgb/ulp/tom/cxgb_t3_ddp.h 1.1 +360 -0 src/sys/dev/cxgb/ulp/tom/cxgb_tcp_offload.c (new) 1.1 +205 -0 src/sys/dev/cxgb/ulp/tom/cxgb_tcp_offload.h (new) 1.5 +1032 -33 src/sys/dev/cxgb/ulp/tom/cxgb_tom.c 1.3 +0 -1 src/sys/dev/cxgb/ulp/tom/cxgb_tom_sysctl.c 1.9 +3 -4 src/sys/modules/cxgb/cxgb/Makefile 1.5 +1 -1 src/sys/modules/cxgb/tom/Makefile 1.3 +8 -2 src/sys/netinet/tcp_offload.h From kmacy at FreeBSD.org Sat Apr 19 03:39:18 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sat Apr 19 03:39:22 2008 Subject: cvs commit: src/sys/netinet tcp_syncache.c Message-ID: <200804190339.m3J3dHfD034584@repoman.freebsd.org> kmacy 2008-04-19 03:39:17 UTC FreeBSD src repository Modified files: sys/netinet tcp_syncache.c Log: move tcbinfo lock acquisition in to syncache Revision Changes Path 1.143 +3 -0 src/sys/netinet/tcp_syncache.c From kmacy at FreeBSD.org Sat Apr 19 03:43:07 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sat Apr 19 03:43:09 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_offload.c Message-ID: <200804190343.m3J3h7QY034874@repoman.freebsd.org> kmacy 2008-04-19 03:43:07 UTC FreeBSD src repository Modified files: sys/dev/cxgb cxgb_offload.c Log: remove kdb_backtrace() call Revision Changes Path 1.14 +0 -1 src/sys/dev/cxgb/cxgb_offload.c From kmacy at FreeBSD.org Sat Apr 19 03:46:26 2008 From: kmacy at FreeBSD.org (Kip Macy) Date: Sat Apr 19 03:46:30 2008 Subject: cvs commit: src/sys/dev/cxgb cxgb_offload.c Message-ID: <200804190346.m3J3kQ1w035040@repoman.freebsd.org> kmacy 2008-04-19 03:46:26 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/dev/cxgb cxgb_offload.c Log: fix build breakage caused by undeclared kdb_backtrace() Revision Changes Path 1.8.2.2 +0 -1 src/sys/dev/cxgb/cxgb_offload.c From jeff at FreeBSD.org Sat Apr 19 04:45:52 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Sat Apr 19 04:45:56 2008 Subject: cvs commit: src/sys/kern subr_sleepqueue.c Message-ID: <200804190445.m3J4jpIQ038339@repoman.freebsd.org> jeff 2008-04-19 04:45:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern subr_sleepqueue.c Log: MFC 1.48: Fix a sleepq race when checking signals. Revision Changes Path 1.39.2.3 +5 -2 src/sys/kern/subr_sleepqueue.c From jeff at FreeBSD.org Sat Apr 19 04:47:40 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Sat Apr 19 04:47:41 2008 Subject: cvs commit: src/sys/kern kern_sig.c Message-ID: <200804190447.m3J4ldWe047482@repoman.freebsd.org> jeff 2008-04-19 04:47:39 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern kern_sig.c Log: MFC parts of 1.359: Don't hold the proc slock while calling sigqueue_delete* Revision Changes Path 1.349.2.4 +0 -6 src/sys/kern/kern_sig.c From jeff at FreeBSD.org Sat Apr 19 04:50:31 2008 From: jeff at FreeBSD.org (Jeff Roberson) Date: Sat Apr 19 04:50:35 2008 Subject: cvs commit: src/sys/kern sched_ule.c Message-ID: <200804190450.m3J4oUxi047624@repoman.freebsd.org> jeff 2008-04-19 04:50:29 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern sched_ule.c Log: MFC 1.220, 1.221, parts of 1.222 - Improve performance with heavy interrupt loads - Fix compile with gcc3 - Fix timeslicing code for non TIMESHARE threads. Revision Changes Path 1.214.2.3 +30 -31 src/sys/kern/sched_ule.c From marcel at FreeBSD.org Sat Apr 19 04:56:17 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Sat Apr 19 04:56:20 2008 Subject: cvs commit: src/sys/ia64/ia64 mp_machdep.c pmap.c Message-ID: <200804190456.m3J4uGVx047888@repoman.freebsd.org> marcel 2008-04-19 04:56:16 UTC FreeBSD src repository Modified files: sys/ia64/ia64 mp_machdep.c pmap.c Log: Sanitize the malloc types: M_PMAP is not used in pmap.c, so don't define it there. Don't use M_PMAP in mp_machdep.c; define M_SMP instead. Revision Changes Path 1.69 +3 -3 src/sys/ia64/ia64/mp_machdep.c 1.199 +0 -2 src/sys/ia64/ia64/pmap.c From nyan at FreeBSD.org Sat Apr 19 05:07:50 2008 From: nyan at FreeBSD.org (Takahashi Yoshihiro) Date: Sat Apr 19 05:07:54 2008 Subject: cvs commit: src/sys/pc98/include clock.h Message-ID: <200804190507.m3J57oVa049434@repoman.freebsd.org> nyan 2008-04-19 05:07:50 UTC FreeBSD src repository Modified files: sys/pc98/include clock.h Log: Remove my copyright. This file includes simply i386's one now. Revision Changes Path 1.4 +2 -29 src/sys/pc98/include/clock.h From mav at FreeBSD.org Sat Apr 19 05:30:50 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Sat Apr 19 05:30:51 2008 Subject: cvs commit: src/sys/netgraph ng_base.c Message-ID: <200804190530.m3J5UnJb050154@repoman.freebsd.org> mav 2008-04-19 05:30:49 UTC FreeBSD src repository Modified files: sys/netgraph ng_base.c Log: ng_address_hook() microoptimization. Use local variables as they should be. It helps compiller to avoid some extra memory accesses. Revision Changes Path 1.159 +5 -7 src/sys/netgraph/ng_base.c From ru at FreeBSD.org Sat Apr 19 07:18:24 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Sat Apr 19 07:18:32 2008 Subject: cvs commit: src/lib/libc/stdlib strfmon.c Message-ID: <200804190718.m3J7INvU056013@repoman.freebsd.org> ru 2008-04-19 07:18:22 UTC FreeBSD src repository Modified files: lib/libc/stdlib strfmon.c Log: Better strfmon(3) conversion specifiers sanity checking. There were no checks for left and right precisions at all, and a check for field width had integer overflow bug. Reported by: Maksymilian Arciemowicz Security: http://securityreason.com/achievement_securityalert/53 Submitted by: Maxim Dounin MFC after: 3 days Revision Changes Path 1.17 +8 -1 src/lib/libc/stdlib/strfmon.c From ru at FreeBSD.org Sat Apr 19 07:22:59 2008 From: ru at FreeBSD.org (Ruslan Ermilov) Date: Sat Apr 19 07:23:06 2008 Subject: cvs commit: src/lib/libc/stdlib strfmon.c Message-ID: <200804190722.m3J7Mww3056230@repoman.freebsd.org> ru 2008-04-19 07:22:58 UTC FreeBSD src repository Modified files: lib/libc/stdlib strfmon.c Log: Don't forget to free() currency_symbol and asciivalue when multiple conversion specifiers for them are present. Submitted by: Maxim Dounin Obtained from: NetBSD (partially) MFC after: 3 days Revision Changes Path 1.18 +4 -0 src/lib/libc/stdlib/strfmon.c From peter at FreeBSD.org Sat Apr 19 07:25:58 2008 From: peter at FreeBSD.org (Peter Wemm) Date: Sat Apr 19 07:26:02 2008 Subject: cvs commit: src/sys/amd64/amd64 machdep.c Message-ID: <200804190725.m3J7Pvie056329@repoman.freebsd.org> peter 2008-04-19 07:25:57 UTC FreeBSD src repository Modified files: sys/amd64/amd64 machdep.c Log: Put in a real isa_irq_pending() stub in order to remove two lines of dmesg noise from sio per unit. sio likes to probe if interrupts are configured correctly by looking at the pending bits of the atpic in order to put a non-fatal warning on the console. I think I'd rather read the pending bits from the apics, but I'm not sure its worth the hassle. Revision Changes Path 1.684 +14 -2 src/sys/amd64/amd64/machdep.c From nyan at FreeBSD.org Sat Apr 19 08:18:48 2008 From: nyan at FreeBSD.org (Takahashi Yoshihiro) Date: Sat Apr 19 08:18:54 2008 Subject: cvs commit: src/sys/conf files.pc98 src/sys/pc98/cbus clock.c pcrtc.c Message-ID: <200804190818.m3J8Im7n059081@repoman.freebsd.org> nyan 2008-04-19 08:18:48 UTC FreeBSD src repository Modified files: sys/conf files.pc98 sys/pc98/cbus clock.c pcrtc.c Log: MFi386: Merge yet another the RTC related work. Split the pcrtc driver into pcrtc.c which is repo-copied from clock.c Revision Changes Path 1.361 +1 -0 src/sys/conf/files.pc98 1.168 +1 -222 src/sys/pc98/cbus/clock.c 1.168 +13 -516 src/sys/pc98/cbus/pcrtc.c From rwatson at FreeBSD.org Sat Apr 19 12:39:16 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Apr 19 12:39:25 2008 Subject: cvs commit: src/usr.bin/procstat procstat.1 Message-ID: <200804191239.m3JCdGCe082750@repoman.freebsd.org> rwatson 2008-04-19 12:39:15 UTC FreeBSD src repository Modified files: usr.bin/procstat procstat.1 Log: It is a bug that procstat(8) works only on live kernels and not crashdumps; document in case anyone wants to work on fixing this. MFC after: 3 days Revision Changes Path 1.2 +4 -0 src/usr.bin/procstat/procstat.1 From rwatson at FreeBSD.org Sat Apr 19 13:40:43 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Apr 19 13:40:50 2008 Subject: cvs commit: src/usr.bin/procstat procstat.1 Message-ID: <200804191340.m3JDegxr095378@repoman.freebsd.org> rwatson 2008-04-19 13:40:42 UTC FreeBSD src repository Modified files: usr.bin/procstat procstat.1 Log: Provide more detailed information about each procstat(1) display mode, including a key to fields in each mode and flag abbreviations. MFC after: 3 days X-MFC-note: POSIX shared memory memory objects aren't in 7-STABLE yet Revision Changes Path 1.3 +248 -7 src/usr.bin/procstat/procstat.1 From rwatson at FreeBSD.org Sat Apr 19 14:34:39 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Apr 19 14:34:49 2008 Subject: cvs commit: src/sys/netinet in_pcb.c Message-ID: <200804191434.m3JEYdwx098144@repoman.freebsd.org> rwatson 2008-04-19 14:34:38 UTC FreeBSD src repository Modified files: sys/netinet in_pcb.c Log: When querying the local or foreign address from an IP socket, acquire only a read lock on the inpcb. When an external module requests a read lock, acquire only a read lock. MFC after: 3 months Revision Changes Path 1.205 +6 -6 src/sys/netinet/in_pcb.c From rwatson at FreeBSD.org Sat Apr 19 14:35:18 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Apr 19 14:35:24 2008 Subject: cvs commit: src/sys/netinet ip_output.c Message-ID: <200804191435.m3JEZH7P098261@repoman.freebsd.org> rwatson 2008-04-19 14:35:17 UTC FreeBSD src repository Modified files: sys/netinet ip_output.c Log: In ip_output(), allow a read lock as well as a write lock when asserting a lock on the passed inpcb. MFC after: 3 months Revision Changes Path 1.282 +1 -1 src/sys/netinet/ip_output.c From rwatson at FreeBSD.org Sat Apr 19 14:36:19 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Apr 19 14:36:28 2008 Subject: cvs commit: src/sys/netinet6 in6_pcb.c Message-ID: <200804191436.m3JEaJG1098312@repoman.freebsd.org> rwatson 2008-04-19 14:36:19 UTC FreeBSD src repository Modified files: sys/netinet6 in6_pcb.c Log: When querying a local or remote address on an IPv6 socket, use only a read lock on the inpcb. MFC after: 3 months Revision Changes Path 1.90 +4 -4 src/sys/netinet6/in6_pcb.c From rwatson at FreeBSD.org Sat Apr 19 18:35:28 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Apr 19 18:35:30 2008 Subject: cvs commit: src/sys/security/mac mac_inet.c Message-ID: <200804191835.m3JIZSad017812@repoman.freebsd.org> rwatson 2008-04-19 18:35:28 UTC FreeBSD src repository Modified files: sys/security/mac mac_inet.c Log: When propagating a MAC label from an inpcb to an mbuf, allow read and write locks on the inpcb, not just write locks. MFC after: 3 months Revision Changes Path 1.18 +1 -1 src/sys/security/mac/mac_inet.c From rwatson at FreeBSD.org Sat Apr 19 18:37:08 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sat Apr 19 18:37:17 2008 Subject: cvs commit: src/sys/security/audit audit_arg.c Message-ID: <200804191837.m3JIb8ai017865@repoman.freebsd.org> rwatson 2008-04-19 18:37:08 UTC FreeBSD src repository Modified files: sys/security/audit audit_arg.c Log: When auditing state from an IPv4 or IPv6 socket, use read locks on the inpcb rather than write locks. MFC after: 3 months Revision Changes Path 1.21 +2 -2 src/sys/security/audit/audit_arg.c From brooks at FreeBSD.org Sat Apr 19 22:04:52 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Sat Apr 19 22:04:54 2008 Subject: cvs commit: src/sys/net if.c Message-ID: <200804192204.m3JM4qGW041648@repoman.freebsd.org> brooks 2008-04-19 22:04:51 UTC FreeBSD src repository Modified files: sys/net if.c Log: Delay the global registration of the struct ifnet in if_alloc() until after we're certain the allocation will entierly succeed. This fixes a leak in a fairly unlikely case. Reported by: vijay singh MFC after: 1 week Revision Changes Path 1.278 +1 -1 src/sys/net/if.c From ariff at FreeBSD.org Sat Apr 19 22:32:23 2008 From: ariff at FreeBSD.org (Ariff Abdullah) Date: Sat Apr 19 22:32:32 2008 Subject: cvs commit: src/sys/dev/sound/pci/hda hdac.c Message-ID: <200804192232.m3JMWNPV043361@repoman.freebsd.org> ariff 2008-04-19 22:32:23 UTC FreeBSD src repository Modified files: sys/dev/sound/pci/hda hdac.c Log: Fix no sound issues for ASUS W6F (ALC861) laptops (buggy BIOS config that deserves its own internet memes). The trick is to force all available, unused pins (that being advertised as "speaker") to behave as microphone pins instead. Reported / Tested by: Dmitry Kutsenko MFC after: 3 days Revision Changes Path 1.53 +11 -3 src/sys/dev/sound/pci/hda/hdac.c From cokane at cokane.org Sat Apr 19 22:59:48 2008 From: cokane at cokane.org (Coleman Kane) Date: Sat Apr 19 22:59:55 2008 Subject: cvs commit: src/sys/ufs/ffs ffs_softdep.c In-Reply-To: <47D9CC76.9020000@FreeBSD.org> References: <200803132015.m2DKFndQ008412@repoman.freebsd.org> <20080313215520.X83983@fledge.watson.org> <47D9CC76.9020000@FreeBSD.org> Message-ID: <1208644987.4453.10.camel@localhost> On Thu, 2008-03-13 at 20:53 -0400, Coleman Kane wrote: > Robert Watson wrote: > > > > On Thu, 13 Mar 2008, Coleman Kane wrote: > > > >> cokane 2008-03-13 20:15:49 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/ufs/ffs ffs_softdep.c > >> Log: > >> Replace the non-MPSAFE timeout(9) API in ffs_softdep.c with the MPSAFE > >> callout_* API (e.g. callout_init_mtx(9)). This was one of the numerous > >> items on the http://wiki.freebsd.org/SMPTODO list. > >> > >> Reviewed by: imp, obrien, jhb > >> MFC after: 1 week > > > > I might give this one a month to MFC rather than a week -- it can take > > a while for bugs in this sort of thing to get diagnosed, especially > > with lots of other changes in the tree at the same time relating to > > schedulers, etc. > > > > Robert N M Watson > > Computer Laboratory > > University of Cambridge > > > Thanks, that's a good idea. I'll hold onto it for a month before it goes > into RELENG_7. > > -- > Coleman > Robert, About a month later... I haven't gotten any problem reports from this. One question: do you know if this applies to RELENG_6 as well? -- Coleman Kane From rwatson at FreeBSD.org Sun Apr 20 00:21:55 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sun Apr 20 00:21:59 2008 Subject: cvs commit: src/sys/contrib/pf/net pf.c src/sys/netinet ip_fw2.c Message-ID: <200804200021.m3K0Lti7050661@repoman.freebsd.org> rwatson 2008-04-20 00:21:54 UTC FreeBSD src repository Modified files: sys/contrib/pf/net pf.c sys/netinet ip_fw2.c Log: Teach pf and ipfw to use read locks in inpcbs write than write locks when reading credential data from sockets. Teach pf to unlock the pcbinfo more quickly once it has acquired an inpcb lock, as the inpcb lock is sufficient to protect the reference. Assert locks, rather than read locks or write locks, on inpcbs in subroutines--this is necessary as the inpcb may be passed down with a write lock from the protocol, or may be passed down with a read lock from the firewall lookup routine, and either is sufficient. MFC after: 3 months Revision Changes Path 1.53 +5 -6 src/sys/contrib/pf/net/pf.c 1.185 +3 -3 src/sys/netinet/ip_fw2.c From mav at FreeBSD.org Sun Apr 20 11:28:22 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Sun Apr 20 11:28:23 2008 Subject: cvs commit: src/sys/netgraph ng_base.c Message-ID: <200804201128.m3KBSGkJ017364@repoman.freebsd.org> mav 2008-04-20 11:28:16 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/netgraph ng_base.c Log: MFC some small optimizations: rev. 1.151: Remove impossible (hk_peer == NULL) check. rev. 1.152: Remove ng_setisr() call from ng_dequeue(). rev. 1.153: There is no need to erase hook->hk_node before freeing hook. rev. 1.154: Use new atomic_fetchadd() primitive instead of looping atomic_cmpset(). rev. 1.158: ng_address_hook() microoptimization. Revision Changes Path 1.135.2.8 +11 -30 src/sys/netgraph/ng_base.c From mav at FreeBSD.org Sun Apr 20 11:34:57 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Sun Apr 20 11:35:07 2008 Subject: cvs commit: src/sys/netgraph ng_base.c Message-ID: <200804201134.m3KBYv7c017578@repoman.freebsd.org> mav 2008-04-20 11:34:56 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/netgraph ng_base.c Log: MFC some small optimizations: rev. 1.151: Remove impossible (hk_peer == NULL) check. rev. 1.152: Remove ng_setisr() call from ng_dequeue(). rev. 1.153: There is no need to erase hook->hk_node before freeing hook. rev. 1.154: Use new atomic_fetchadd() primitive instead of looping atomic_cmpset(). rev. 1.158: ng_address_hook() microoptimization. Revision Changes Path 1.102.2.19 +11 -30 src/sys/netgraph/ng_base.c From bzeeb-lists at lists.zabbadoz.net Sun Apr 20 12:00:08 2008 From: bzeeb-lists at lists.zabbadoz.net (Bjoern A. Zeeb) Date: Sun Apr 20 12:00:12 2008 Subject: cvs commit: src/sys/netinet ip_fw_pfil.c In-Reply-To: <200803031012.m23ACldZ014651@repoman.freebsd.org> References: <200803031012.m23ACldZ014651@repoman.freebsd.org> Message-ID: <20080420115452.U66744@maildrop.int.zabbadoz.net> On Mon, 3 Mar 2008, Paolo Pisati wrote: > piso 2008-03-03 10:12:46 UTC > > FreeBSD src repository > > Modified files: > sys/netinet ip_fw_pfil.c > Log: > Raise a bit ipfw kld priority. > > Discussed on: net-, ipfw-. > > Revision Changes Path > 1.27 +1 -1 src/sys/netinet/ip_fw_pfil.c This needs to be MFCed. We hit the initialization problem (lock not yet initialized because of ipfw_nat was intiialized before ipfw). I was about to commit a change discussed with jhb like -DECLARE_MODULE(ipfw, ipfwmod, SI_SUB_PROTO_IFATTACHDOMAIN, SI_ORDER_ANY); +DECLARE_MODULE(ipfw, ipfwmod, SI_SUB_PROTO_IFATTACHDOMAIN, SI_ORDER_FIRST); when I noticed that HEAD had SI_ORDER_ANY - 256. /bz -- Bjoern A. Zeeb Stop bit received. Insert coin for new game. From rwatson at FreeBSD.org Sun Apr 20 15:42:13 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sun Apr 20 15:42:20 2008 Subject: cvs commit: src/sys/security/mac mac_framework.h mac_internal.h mac_policy.h Message-ID: <200804201542.m3KFgDnX046824@repoman.freebsd.org> rwatson 2008-04-20 15:42:12 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/security/mac mac_framework.h mac_internal.h mac_policy.h Log: Merge mac_framework.h:1.97, mac_internal.h:1.124, mac_policy.h:1.107 from HEAD to REENG_7: Make naming of include guards for MAC Framework include files more consistent with other kernel include guards (don't start with _SYS). Revision Changes Path 1.84.2.2 +3 -3 src/sys/security/mac/mac_framework.h 1.121.2.1 +3 -3 src/sys/security/mac/mac_internal.h 1.94.2.2 +3 -3 src/sys/security/mac/mac_policy.h From antoine at FreeBSD.org Sun Apr 20 15:51:57 2008 From: antoine at FreeBSD.org (Antoine Brodin) Date: Sun Apr 20 15:52:05 2008 Subject: cvs commit: src/lib/libc/sys cpuset.2 cpuset_getaffinity.2 Message-ID: <200804201551.m3KFpuWP047131@repoman.freebsd.org> antoine 2008-04-20 15:51:56 UTC FreeBSD src repository Modified files: lib/libc/sys cpuset.2 cpuset_getaffinity.2 Log: Document that you must include before . Approved by: rwatson (mentor) Revision Changes Path 1.2 +1 -0 src/lib/libc/sys/cpuset.2 1.2 +1 -0 src/lib/libc/sys/cpuset_getaffinity.2 From antoine at FreeBSD.org Sun Apr 20 15:57:00 2008 From: antoine at FreeBSD.org (Antoine Brodin) Date: Sun Apr 20 15:57:10 2008 Subject: cvs commit: src/sys/dev/iscsi/initiator iscsi.c Message-ID: <200804201556.m3KFuxL1047311@repoman.freebsd.org> antoine 2008-04-20 15:56:59 UTC FreeBSD src repository Modified files: sys/dev/iscsi/initiator iscsi.c Log: Record the dependency of the iscsi initiator on cam. PR: 116745 Submitted by: OISHI Masakuni Approved by: rwatson (mentor) MFC after: 1 month Revision Changes Path 1.2 +1 -0 src/sys/dev/iscsi/initiator/iscsi.c From antoine at FreeBSD.org Sun Apr 20 16:03:19 2008 From: antoine at FreeBSD.org (Antoine Brodin) Date: Sun Apr 20 16:03:31 2008 Subject: cvs commit: src ObsoleteFiles.inc Message-ID: <200804201603.m3KG3JFR048640@repoman.freebsd.org> antoine 2008-04-20 16:03:19 UTC FreeBSD src repository Modified files: . ObsoleteFiles.inc Log: Add recent obsolete files. Approved by: rwatson (mentor) Revision Changes Path 1.137 +16 -0 src/ObsoleteFiles.inc From antoine at FreeBSD.org Sun Apr 20 16:11:15 2008 From: antoine at FreeBSD.org (Antoine Brodin) Date: Sun Apr 20 16:11:25 2008 Subject: cvs commit: src/sys/modules/firmware Makefile Message-ID: <200804201611.m3KGBECH048952@repoman.freebsd.org> antoine 2008-04-20 16:11:14 UTC FreeBSD src repository Modified files: sys/modules/firmware Makefile Log: Unbreak firmware.ko build without kernel. Approved by: rwatson (mentor) MFC after: 1 month Revision Changes Path 1.2 +1 -1 src/sys/modules/firmware/Makefile From antoine at FreeBSD.org Sun Apr 20 16:17:45 2008 From: antoine at FreeBSD.org (Antoine Brodin) Date: Sun Apr 20 16:17:47 2008 Subject: cvs commit: src/sys/net if_media.h Message-ID: <200804201617.m3KGHjI1049134@repoman.freebsd.org> antoine 2008-04-20 16:17:45 UTC FreeBSD src repository Modified files: sys/net if_media.h Log: Move "1000baseT" from IFM_SUBTYPE_ETHERNET_DESCRIPTIONS to IFM_SUBTYPE_ETHERNET_ALIASES: there is already "1000baseTX" in IFM_SUBTYPE_ETHERNET_DESCRIPTIONS. This doesn't change ifconfig behaviour. PR: 45793 (maybe) Approved by: rwatson (mentor) MFC after: 1 month Revision Changes Path 1.42 +1 -1 src/sys/net/if_media.h From antoine at FreeBSD.org Sun Apr 20 16:29:02 2008 From: antoine at FreeBSD.org (Antoine Brodin) Date: Sun Apr 20 16:29:09 2008 Subject: cvs commit: src/lib/libutil humanize_number.c Message-ID: <200804201629.m3KGT1Mr049649@repoman.freebsd.org> antoine 2008-04-20 16:29:01 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libutil humanize_number.c Log: MFC to RELENG_7: Merge changes from NetBSD on humanize_number.c, 1.8 -> 1.13 Significant changes: - rev. 1.11: Use PRId64 instead of a cast to long long and %lld to print an int64_t. - rev. 1.12: Fix a bug that humanize_number() produces "1000" where it should be "1.0G" or "1.0M". The bug reported by Greg Troxel. PR: 118461 PR: 102694 Approved by: rwatson (mentor) Obtained from: NetBSD MFC after: 1 month Revision Changes Path 1.2.10.1 +10 -5 src/lib/libutil/humanize_number.c From antoine at FreeBSD.org Sun Apr 20 16:32:21 2008 From: antoine at FreeBSD.org (Antoine Brodin) Date: Sun Apr 20 16:32:26 2008 Subject: cvs commit: src/lib/libutil humanize_number.c Message-ID: <200804201632.m3KGWKrP049793@repoman.freebsd.org> antoine 2008-04-20 16:32:20 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) lib/libutil humanize_number.c Log: MFC to RELENG_6: Merge changes from NetBSD on humanize_number.c, 1.8 -> 1.13 Significant changes: - rev. 1.11: Use PRId64 instead of a cast to long long and %lld to print an int64_t. - rev. 1.12: Fix a bug that humanize_number() produces "1000" where it should be "1.0G" or "1.0M". The bug reported by Greg Troxel. PR: 118461 PR: 102694 Approved by: rwatson (mentor) Obtained from: NetBSD MFC after: 1 month Revision Changes Path 1.2.2.1 +10 -5 src/lib/libutil/humanize_number.c From rwatson at FreeBSD.org Sun Apr 20 16:34:51 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Sun Apr 20 16:34:56 2008 Subject: cvs commit: src/sys/security/audit audit.c audit_arg.c audit_bsm.c audit_bsm_klib.c audit_bsm_token.c audit_pipe.c audit_syscalls.c audit_trigger.c audit_worker.c Message-ID: <200804201634.m3KGYork049922@repoman.freebsd.org> rwatson 2008-04-20 16:34:50 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/security/audit audit.c audit_arg.c audit_bsm.c audit_bsm_klib.c audit_bsm_token.c audit_pipe.c audit_syscalls.c audit_trigger.c audit_worker.c Log: Merge audit.c:1.41, audit_arg.c:1.19, audit_bsm.c:1.26, audit_bsm_klib.c:1.15, audit_bsm_token.c:1.15, audit_pipe.c:1.15, audit_syscalls.c:1.26, audit_trigger.c:1.8, audit_worker.c:1.23 from HEAD to RELENG_7: Use __FBSDID() for $FreeBSD$ IDs in the audit code. Revision Changes Path 1.33.2.3 +3 -2 src/sys/security/audit/audit.c 1.15.2.2 +3 -2 src/sys/security/audit/audit_arg.c 1.20.2.5 +3 -2 src/sys/security/audit/audit_bsm.c 1.7.2.4 +3 -2 src/sys/security/audit/audit_bsm_klib.c 1.14.2.1 +3 -2 src/sys/security/audit/audit_bsm_token.c 1.11.2.3 +3 -2 src/sys/security/audit/audit_pipe.c 1.21.2.3 +3 -2 src/sys/security/audit/audit_syscalls.c 1.5.2.3 +3 -2 src/sys/security/audit/audit_trigger.c 1.16.2.4 +3 -2 src/sys/security/audit/audit_worker.c From antoine at FreeBSD.org Sun Apr 20 16:44:51 2008 From: antoine at FreeBSD.org (Antoine Brodin) Date: Sun Apr 20 16:44:58 2008 Subject: cvs commit: src ObsoleteFiles.inc Message-ID: <200804201644.m3KGipQf050455@repoman.freebsd.org> antoine 2008-04-20 16:44:51 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) . ObsoleteFiles.inc Log: MFC to RELENG_7: Add some obsolete usr/lib32 libraries. PR: 117189 Submitted by: Scot Hetzel Approved by: rwatson (mentor) MFC after: 1 month Revision Changes Path 1.112.2.13 +50 -0 src/ObsoleteFiles.inc From mav at FreeBSD.org Sun Apr 20 17:12:15 2008 From: mav at FreeBSD.org (Alexander Motin) Date: Sun Apr 20 17:12:20 2008 Subject: cvs commit: src/sys/dev/usb uipaq.c usbdevs Message-ID: <200804201712.m3KHCDWQ061607@repoman.freebsd.org> mav 2008-04-20 17:12:11 UTC FreeBSD src repository Modified files: sys/dev/usb uipaq.c usbdevs Log: Add one more HTC PocketPC device id. Tested on HTC TyTN. Submitted by: Alexander Logvinov Revision Changes Path 1.10 +1 -0 src/sys/dev/usb/uipaq.c 1.347 +1 -0 src/sys/dev/usb/usbdevs From bz at FreeBSD.org Sun Apr 20 17:45:32 2008 From: bz at FreeBSD.org (Bjoern A. Zeeb) Date: Sun Apr 20 17:45:38 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c Message-ID: <200804201745.m3KHjWma066842@repoman.freebsd.org> bz 2008-04-20 17:45:32 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.c Log: devclass_get_maxunit() returns n+1 with n starting at 0. So if we have channel 0..3 devclass_get_maxunit is 4. It's never been a problem as devclass_get_device() has catched a possibly bad input. Discussed with: scottl Revision Changes Path 1.287 +5 -4 src/sys/dev/ata/ata-all.c From stefanf at FreeBSD.org Sun Apr 20 17:55:32 2008 From: stefanf at FreeBSD.org (Stefan Farfeleder) Date: Sun Apr 20 17:55:38 2008 Subject: cvs commit: src/bin/sh cd.c Message-ID: <200804201755.m3KHtVIB067286@repoman.freebsd.org> stefanf 2008-04-20 17:55:31 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) bin/sh cd.c Log: MFC 1.36: Leave working directory variables unchanged if chdir() fails. Revision Changes Path 1.35.2.1 +45 -38 src/bin/sh/cd.c From bmah at FreeBSD.org Sun Apr 20 17:55:48 2008 From: bmah at FreeBSD.org (Bruce A. Mah) Date: Sun Apr 20 17:55:54 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/errata article.sgml Message-ID: <200804201755.m3KHtmtD067316@repoman.freebsd.org> bmah 2008-04-20 17:55:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) release/doc/en_US.ISO8859-1/errata article.sgml Log: Update pthread errata note with errata notice. Mention multicast refcounting kernel panic. Revision Changes Path 1.73.2.58 +12 -4 src/release/doc/en_US.ISO8859-1/errata/article.sgml From hrs at FreeBSD.org Sun Apr 20 17:58:06 2008 From: hrs at FreeBSD.org (Hiroki Sato) Date: Sun Apr 20 17:58:16 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml src/release/doc/share/sgml release.dsl release.ent Message-ID: <200804201758.m3KHw5KL067413@repoman.freebsd.org> hrs 2008-04-20 17:58:05 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes article.sgml release/doc/share/sgml release.dsl release.ent Log: Use role="merged" and arch="amd64,i386,..." attributes to mark a paragraph as MFC'd or one for specific platforms. This should make no content change with the rendered output. Revision Changes Path 1.1086 +46 -50 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml 1.11 +67 -74 src/release/doc/share/sgml/release.dsl 1.32 +2 -0 src/release/doc/share/sgml/release.ent From stefanf at FreeBSD.org Sun Apr 20 18:02:42 2008 From: stefanf at FreeBSD.org (Stefan Farfeleder) Date: Sun Apr 20 18:02:52 2008 Subject: cvs commit: src/bin/sh options.c Message-ID: <200804201802.m3KI2fhF067623@repoman.freebsd.org> stefanf 2008-04-20 18:02:41 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) bin/sh options.c Log: MFC 1.26: Reset the internal state used for the 'getopts' built-in when 'shift' or 'set' are used to modify the arguments. Revision Changes Path 1.25.2.1 +2 -2 src/bin/sh/options.c From hrs at FreeBSD.org Sun Apr 20 18:03:22 2008 From: hrs at FreeBSD.org (Hiroki Sato) Date: Sun Apr 20 18:03:29 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml Message-ID: <200804201803.m3KI3Mx7068773@repoman.freebsd.org> hrs 2008-04-20 18:03:22 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes article.sgml Log: New release notes: env(1) -u name option. Revision Changes Path 1.1087 +6 -0 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml From stefanf at FreeBSD.org Sun Apr 20 18:08:13 2008 From: stefanf at FreeBSD.org (Stefan Farfeleder) Date: Sun Apr 20 18:08:18 2008 Subject: cvs commit: src/bin/sh cd.c Message-ID: <200804201808.m3KI8DA3068937@repoman.freebsd.org> stefanf 2008-04-20 18:08:13 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) bin/sh cd.c Log: MFC 1.36: Leave working directory variables unchanged if chdir() fails. Revision Changes Path 1.34.8.2 +45 -38 src/bin/sh/cd.c From stefanf at FreeBSD.org Sun Apr 20 18:08:47 2008 From: stefanf at FreeBSD.org (Stefan Farfeleder) Date: Sun Apr 20 18:08:55 2008 Subject: cvs commit: src/bin/sh options.c Message-ID: <200804201808.m3KI8kC9068976@repoman.freebsd.org> stefanf 2008-04-20 18:08:46 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) bin/sh options.c Log: MFC 1.26: Reset the internal state used for the 'getopts' built-in when 'shift' or 'set' are used to modify the arguments. Revision Changes Path 1.23.2.3 +2 -2 src/bin/sh/options.c From hrs at FreeBSD.org Sun Apr 20 18:17:34 2008 From: hrs at FreeBSD.org (Hiroki Sato) Date: Sun Apr 20 18:17:36 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml Message-ID: <200804201817.m3KIHYar069329@repoman.freebsd.org> hrs 2008-04-20 18:17:34 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/relnotes article.sgml Log: New release notes: ULE scheduler enabled by default in GENERIC for ia64, fdopendir(3) added, and tcgetsid(3) added. Revision Changes Path 1.1088 +8 -1 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml From hrs at FreeBSD.org Sun Apr 20 18:28:31 2008 From: hrs at FreeBSD.org (Hiroki Sato) Date: Sun Apr 20 18:28:39 2008 Subject: cvs commit: src/release/doc/share/sgml release.dsl Message-ID: <200804201828.m3KISVsw069777@repoman.freebsd.org> hrs 2008-04-20 18:28:31 UTC FreeBSD src repository Modified files: release/doc/share/sgml release.dsl Log: Move (define ($paragraph$)) to the marked section for HTML output. It should not be applied to printed output. Revision Changes Path 1.12 +49 -49 src/release/doc/share/sgml/release.dsl From bmah at freebsd.org Sun Apr 20 18:28:56 2008 From: bmah at freebsd.org (Bruce A. Mah) Date: Sun Apr 20 18:29:03 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/relnotes article.sgml src/release/doc/share/sgml release.dsl release.ent In-Reply-To: <200804201758.m3KHw5KL067413@repoman.freebsd.org> References: <200804201758.m3KHw5KL067413@repoman.freebsd.org> Message-ID: <480B8B67.7050007@freebsd.org> If memory serves me right, Hiroki Sato wrote: > hrs 2008-04-20 17:58:05 UTC > > FreeBSD src repository > > Modified files: > release/doc/en_US.ISO8859-1/relnotes article.sgml > release/doc/share/sgml release.dsl release.ent > Log: > Use role="merged" and arch="amd64,i386,..." attributes to mark a > paragraph as MFC'd or one for specific platforms. This should > make no content change with the rendered output. > > Revision Changes Path > 1.1086 +46 -50 src/release/doc/en_US.ISO8859-1/relnotes/article.sgml > 1.11 +67 -74 src/release/doc/share/sgml/release.dsl > 1.32 +2 -0 src/release/doc/share/sgml/release.ent Nice! (But reading the diff for release.dsl made my brain implode.) Bruce. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 249 bytes Desc: OpenPGP digital signature Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080420/3a6df3b7/signature.pgp From bz at FreeBSD.org Sun Apr 20 18:36:59 2008 From: bz at FreeBSD.org (Bjoern A. Zeeb) Date: Sun Apr 20 18:37:06 2008 Subject: cvs commit: src/sys/netinet tcp_var.h Message-ID: <200804201836.m3KIax4S070088@repoman.freebsd.org> bz 2008-04-20 18:36:59 UTC FreeBSD src repository Modified files: sys/netinet tcp_var.h Log: Revert to rev. 1.161 - switch back to optimized TCP options ordering. A lot of testing has shown that the problem people were seeing was due to invalid padding after the end of option list option, which was corrected in tcp_output.c rev. 1.146. Thanks to: anders@, s3raphi, Matt Reimer Thanks to: Doug Hardie and Randy Rose, John Mayer, Susan Guzzardi Special thanks to: dwhite@ and BitGravity Discussed with: silby MFC after: 1 day Revision Changes Path 1.162 +2 -5 src/sys/netinet/tcp_var.h From hrs at FreeBSD.org Sun Apr 20 18:41:17 2008 From: hrs at FreeBSD.org (Hiroki Sato) Date: Sun Apr 20 18:41:23 2008 Subject: cvs commit: src/release/doc/share/sgml release.dsl Message-ID: <200804201841.m3KIfHDO070270@repoman.freebsd.org> hrs 2008-04-20 18:41:17 UTC FreeBSD src repository Modified files: release/doc/share/sgml release.dsl Log: - Add ($paragraph$) for printed version. - Fix a bug that role="" does not work when arch="" is not specified. Revision Changes Path 1.13 +86 -4 src/release/doc/share/sgml/release.dsl From bz at FreeBSD.org Sun Apr 20 18:50:07 2008 From: bz at FreeBSD.org (Bjoern A. Zeeb) Date: Sun Apr 20 18:50:11 2008 Subject: cvs commit: src/sys/netinet tcp_var.h In-Reply-To: <200804201836.m3KIax4S070088@repoman.freebsd.org> References: <200804201836.m3KIax4S070088@repoman.freebsd.org> Message-ID: <20080420183726.R66744@maildrop.int.zabbadoz.net> On Sun, 20 Apr 2008, Bjoern A. Zeeb wrote: > bz 2008-04-20 18:36:59 UTC > > FreeBSD src repository > > Modified files: > sys/netinet tcp_var.h > Log: > Revert to rev. 1.161 - switch back to optimized TCP options ordering. > > A lot of testing has shown that the problem people were seeing was due > to invalid padding after the end of option list option, which was corrected > in tcp_output.c rev. 1.146. > > Thanks to: anders@, s3raphi, Matt Reimer > Thanks to: Doug Hardie and Randy Rose, John Mayer, Susan Guzzardi > Special thanks to: dwhite@ and BitGravity > Discussed with: silby > MFC after: 1 day > > Revision Changes Path > 1.162 +2 -5 src/sys/netinet/tcp_var.h A few more words on this: 1) the short MFC time is because the past has shown that HEAD does not uncover any problems with changes like this and we'd like to move towards an errata for this so RELENG_7 exposure time should be as long as possible. 2) With all the testing I have only seen 1 client having problems with the optimized ordering but that client also had other (connectivity) problems so I was told to ignore that one. 3) I have seen clients failing with the RELENG_6 (now old again) option ordering as well. 4) The cable modems/routers blamed before in any of the threads actually worked correctly not accepting a TCP packet with bad padding violating the TCP RFC. Lats but not least, I hope to be able to find the time to further summarize the problems seen, the things discovered, etc. at a later time. I have yet to look at another few strange TCP connections found during all of the testing (some of which seem to have hit net@ or stable@ the last days as well.) /bz -- Bjoern A. Zeeb Stop bit received. Insert coin for new game. From piso at FreeBSD.org Sun Apr 20 18:55:03 2008 From: piso at FreeBSD.org (Paolo Pisati) Date: Sun Apr 20 18:55:14 2008 Subject: cvs commit: src/sys/netinet ip_fw_pfil.c Message-ID: <200804201855.m3KIt3f8070745@repoman.freebsd.org> piso 2008-04-20 18:55:03 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/netinet ip_fw_pfil.c Log: MFC rev. 1.27: Raise a bit ipfw kld priority. Revision Changes Path 1.25.2.1 +1 -1 src/sys/netinet/ip_fw_pfil.c From piso at FreeBSD.org Sun Apr 20 18:55:47 2008 From: piso at FreeBSD.org (Paolo Pisati) Date: Sun Apr 20 18:55:53 2008 Subject: cvs commit: src/sys/netinet ip_fw_pfil.c In-Reply-To: <20080420115452.U66744@maildrop.int.zabbadoz.net> References: <200803031012.m23ACldZ014651@repoman.freebsd.org> <20080420115452.U66744@maildrop.int.zabbadoz.net> Message-ID: <20080420185713.GB56077@tin.it> On Sun, Apr 20, 2008 at 11:59:48AM +0000, Bjoern A. Zeeb wrote: > > > This needs to be MFCed. We hit the initialization problem (lock not > yet initialized because of ipfw_nat was intiialized before ipfw). Done. -- bye, P. From bzeeb-lists at lists.zabbadoz.net Sun Apr 20 19:15:06 2008 From: bzeeb-lists at lists.zabbadoz.net (Bjoern A. Zeeb) Date: Sun Apr 20 19:15:13 2008 Subject: cvs commit: src/sys/netinet ip_fw_pfil.c In-Reply-To: <20080420185713.GB56077@tin.it> References: <200803031012.m23ACldZ014651@repoman.freebsd.org> <20080420115452.U66744@maildrop.int.zabbadoz.net> <20080420185713.GB56077@tin.it> Message-ID: <20080420191211.C66744@maildrop.int.zabbadoz.net> On Sun, 20 Apr 2008, Paolo Pisati wrote: > On Sun, Apr 20, 2008 at 11:59:48AM +0000, Bjoern A. Zeeb wrote: >> >> >> This needs to be MFCed. We hit the initialization problem (lock not >> yet initialized because of ipfw_nat was intiialized before ipfw). > > Done. Thanks & -- Bjoern A. Zeeb Stop bit received. Insert coin for new game. From sam at FreeBSD.org Sun Apr 20 19:20:39 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Sun Apr 20 19:20:42 2008 Subject: cvs commit: src/sys/amd64/conf GENERIC src/sys/conf NOTES files src/sys/dev/awi am79c930.c am79c930reg.h am79c930var.h awi.c awireg.h awivar.h if_awi_pccard.c src/sys/i386/conf GENERIC PAE src/sys/modules Makefile src/sys/modules/awi Makefile ... Message-ID: <200804201920.m3KJKdQQ072950@repoman.freebsd.org> sam 2008-04-20 19:20:39 UTC FreeBSD src repository Modified files: sys/amd64/conf GENERIC sys/conf NOTES files sys/i386/conf GENERIC PAE sys/modules Makefile sys/pc98/conf GENERIC share/man/man4 Makefile altq.4 cnw.4 wlan.4 Removed files: sys/dev/awi am79c930.c am79c930reg.h am79c930var.h awi.c awireg.h awivar.h if_awi_pccard.c sys/modules/awi Makefile share/man/man4 awi.4 Log: move awi to the Attic; it will not make the jump to the new world order Reviewed by: imp Revision Changes Path 1.415 +0 -2 src/share/man/man4/Makefile 1.33 +0 -1 src/share/man/man4/altq.4 1.25 +0 -155 src/share/man/man4/awi.4 (dead) 1.3 +0 -4 src/share/man/man4/cnw.4 1.15 +0 -2 src/share/man/man4/wlan.4 1.496 +0 -1 src/sys/amd64/conf/GENERIC 1.1480 +1 -4 src/sys/conf/NOTES 1.1292 +0 -3 src/sys/conf/files 1.8 +0 -419 src/sys/dev/awi/am79c930.c (dead) 1.3 +0 -126 src/sys/dev/awi/am79c930reg.h (dead) 1.4 +0 -79 src/sys/dev/awi/am79c930var.h (dead) 1.46 +0 -2219 src/sys/dev/awi/awi.c (dead) 1.3 +0 -464 src/sys/dev/awi/awireg.h (dead) 1.15 +0 -161 src/sys/dev/awi/awivar.h (dead) 1.26 +0 -283 src/sys/dev/awi/if_awi_pccard.c (dead) 1.484 +0 -1 src/sys/i386/conf/GENERIC 1.30 +0 -1 src/sys/i386/conf/PAE 1.563 +0 -2 src/sys/modules/Makefile 1.5 +0 -14 src/sys/modules/awi/Makefile (dead) 1.303 +0 -1 src/sys/pc98/conf/GENERIC From antoine at FreeBSD.org Sun Apr 20 19:32:46 2008 From: antoine at FreeBSD.org (Antoine Brodin) Date: Sun Apr 20 19:32:48 2008 Subject: cvs commit: src/lib/libc/sys fcntl.2 src/sys/kern kern_descrip.c src/sys/sys fcntl.h param.h src/tools/regression/file/dup dup.c Message-ID: <200804201932.m3KJWkkr073491@repoman.freebsd.org> antoine 2008-04-20 19:32:46 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) lib/libc/sys fcntl.2 sys/kern kern_descrip.c sys/sys fcntl.h param.h tools/regression/file/dup dup.c Log: MFC to RELENG_7: Introduce a new F_DUP2FD command to fcntl(2), for compatibility with Solaris and AIX. fcntl(fd, F_DUP2FD, arg) and dup2(fd, arg) are functionnaly equivalent. Document it. Add some regression tests (identical to the dup2(2) regression tests). PR: 120233 Submitted by: Jukka Ukkonen Approved by: rwaston (mentor) MFC after: 1 month Revision Changes Path 1.45.2.2 +37 -1 src/lib/libc/sys/fcntl.2 1.313.2.5 +6 -1 src/sys/kern/kern_descrip.c 1.16.18.2 +1 -1 src/sys/sys/fcntl.h 1.308.2.11 +1 -1 src/sys/sys/param.h 1.2.2.1 +71 -2 src/tools/regression/file/dup/dup.c From sam at FreeBSD.org Sun Apr 20 20:35:47 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Sun Apr 20 20:35:49 2008 Subject: cvs commit: src/sys/amd64/conf GENERIC src/sys/arm/conf AVILA HL200 KB920X src/sys/conf NOTES files options src/sys/contrib/dev/ral LICENSE Makefile rt2561.fw.uu rt2561s.fw.uu rt2661.fw.uu rt2661_ucode.h rt2860.fw.uu ... Message-ID: <200804202035.m3KKZk4X079263@repoman.freebsd.org> sam 2008-04-20 20:35:46 UTC FreeBSD src repository Modified files: sys/amd64/conf GENERIC sys/arm/conf AVILA HL200 KB920X sys/conf NOTES files options sys/dev/ath ah_osdep.c ah_osdep.h if_ath.c if_ath_pci.c if_athioctl.h if_athrate.h if_athvar.h sys/dev/ath/ath_rate/amrr amrr.c amrr.h sys/dev/ath/ath_rate/onoe onoe.c onoe.h sys/dev/ath/ath_rate/sample sample.c sample.h sys/dev/if_ndis if_ndis.c if_ndisvar.h sys/dev/ipw if_ipw.c if_ipwvar.h sys/dev/iwi if_iwi.c if_iwivar.h sys/dev/malo if_malo.c if_malo.h sys/dev/ral if_ral_pci.c rt2560.c rt2560reg.h rt2560var.h rt2661.c rt2661var.h sys/dev/usb if_rum.c if_rumvar.h if_ural.c if_uralvar.h if_zyd.c if_zydreg.h sys/dev/wi if_wavelan_ieee.h if_wi.c if_wi_pccard.c if_wi_pci.c if_wivar.h sys/dev/wpi if_wpi.c if_wpivar.h sys/i386/conf GENERIC sys/mips/conf IDT sys/modules Makefile sys/modules/ath_rate_amrr Makefile sys/modules/ath_rate_onoe Makefile sys/modules/ath_rate_sample Makefile sys/modules/malo Makefile sys/modules/ral Makefile sys/modules/wlan Makefile sys/modules/wlan_acl Makefile sys/modules/wlan_amrr Makefile sys/modules/wlan_ccmp Makefile sys/modules/wlan_tkip Makefile sys/modules/wlan_wep Makefile sys/modules/wlan_xauth Makefile sys/net80211 _ieee80211.h ieee80211.c ieee80211.h ieee80211_acl.c ieee80211_amrr.c ieee80211_amrr.h ieee80211_crypto.c ieee80211_crypto.h ieee80211_crypto_ccmp.c ieee80211_crypto_none.c ieee80211_crypto_tkip.c ieee80211_crypto_wep.c ieee80211_freebsd.c ieee80211_freebsd.h ieee80211_ht.c ieee80211_ht.h ieee80211_input.c ieee80211_ioctl.c ieee80211_ioctl.h ieee80211_node.c ieee80211_node.h ieee80211_output.c ieee80211_power.c ieee80211_power.h ieee80211_proto.c ieee80211_proto.h ieee80211_regdomain.c ieee80211_regdomain.h ieee80211_scan.c ieee80211_scan.h ieee80211_scan_sta.c ieee80211_var.h ieee80211_xauth.c sys/pc98/conf GENERIC sys/sparc64/conf GENERIC share/man/man4 ath.4 ipw.4 iwi.4 malo.4 ral.4 rum.4 ural.4 wi.4 wlan.4 wlan_acl.4 wlan_amrr.4 wlan_xauth.4 wpi.4 zyd.4 share/man/man5 Makefile sbin/ifconfig Makefile ifconfig.8 ifieee80211.c ifmedia.c Added files: sys/contrib/dev/ral LICENSE Makefile rt2561.fw.uu rt2561s.fw.uu rt2661.fw.uu rt2661_ucode.h rt2860.fw.uu sys/modules/ralfw Makefile Makefile.inc sys/modules/ralfw/rt2561 Makefile sys/modules/ralfw/rt2561s Makefile sys/modules/ralfw/rt2661 Makefile sys/modules/wlan_rssadapt Makefile sys/net80211 ieee80211_adhoc.c ieee80211_adhoc.h ieee80211_ddb.c ieee80211_dfs.c ieee80211_dfs.h ieee80211_hostap.c ieee80211_hostap.h ieee80211_input.h ieee80211_monitor.c ieee80211_monitor.h ieee80211_phy.c ieee80211_phy.h ieee80211_rssadapt.c ieee80211_rssadapt.h ieee80211_sta.c ieee80211_sta.h ieee80211_wds.c ieee80211_wds.h share/man/man5 regdomain.5 sbin/ifconfig regdomain.c regdomain.h Removed files: sys/dev/ral if_ralrate.c if_ralrate.h rt2661_ucode.h sys/dev/wi spectrum24t_cf.h sys/modules/wlan_scan_ap Makefile sys/modules/wlan_scan_sta Makefile sys/net80211 ieee80211_scan_ap.c Log: Multi-bss (aka vap) support for 802.11 devices. Note this includes changes to all drivers and moves some device firmware loading to use firmware(9) and a separate module (e.g. ral). Also there no longer are separate wlan_scan* modules; this functionality is now bundled into the wlan module. Supported by: Hobnob and Marvell Reviewed by: many Obtained from: Atheros (some bits) Revision Changes Path 1.34 +6 -3 src/sbin/ifconfig/Makefile 1.147 +518 -197 src/sbin/ifconfig/ifconfig.8 1.51 +1207 -126 src/sbin/ifconfig/ifieee80211.c 1.26 +12 -4 src/sbin/ifconfig/ifmedia.c 1.1 +636 -0 src/sbin/ifconfig/regdomain.c (new) 1.1 +112 -0 src/sbin/ifconfig/regdomain.h (new) 1.45 +59 -62 src/share/man/man4/ath.4 1.18 +39 -32 src/share/man/man4/ipw.4 1.20 +39 -32 src/share/man/man4/iwi.4 1.3 +39 -35 src/share/man/man4/malo.4 1.14 +47 -20 src/share/man/man4/ral.4 1.4 +42 -30 src/share/man/man4/rum.4 1.16 +33 -19 src/share/man/man4/ural.4 1.75 +61 -117 src/share/man/man4/wi.4 1.16 +88 -42 src/share/man/man4/wlan.4 1.4 +5 -6 src/share/man/man4/wlan_acl.4 1.3 +6 -6 src/share/man/man4/wlan_amrr.4 1.4 +7 -8 src/share/man/man4/wlan_xauth.4 1.4 +50 -41 src/share/man/man4/wpi.4 1.4 +22 -41 src/share/man/man4/zyd.4 1.80 +1 -0 src/share/man/man5/Makefile 1.1 +48 -0 src/share/man/man5/regdomain.5 (new) 1.497 +0 -2 src/sys/amd64/conf/GENERIC 1.12 +0 -2 src/sys/arm/conf/AVILA 1.4 +0 -2 src/sys/arm/conf/HL200 1.16 +0 -2 src/sys/arm/conf/KB920X 1.1481 +0 -2 src/sys/conf/NOTES 1.1293 +13 -3 src/sys/conf/files 1.626 +10 -0 src/sys/conf/options 1.1 +16 -0 src/sys/contrib/dev/ral/LICENSE (new) 1.1 +36 -0 src/sys/contrib/dev/ral/Makefile (new) 1.1 +202 -0 src/sys/contrib/dev/ral/rt2561.fw.uu (new) 1.1 +202 -0 src/sys/contrib/dev/ral/rt2561s.fw.uu (new) 1.1 +202 -0 src/sys/contrib/dev/ral/rt2661.fw.uu (new) 1.1 +3016 -0 src/sys/contrib/dev/ral/rt2661_ucode.h (new) 1.1 +202 -0 src/sys/contrib/dev/ral/rt2860.fw.uu (new) 1.4 +1 -1 src/sys/dev/ath/ah_osdep.c 1.3 +1 -1 src/sys/dev/ath/ah_osdep.h 1.15 +53 -93 src/sys/dev/ath/ath_rate/amrr/amrr.c 1.3 +3 -1 src/sys/dev/ath/ath_rate/amrr/amrr.h 1.16 +36 -81 src/sys/dev/ath/ath_rate/onoe/onoe.c 1.4 +4 -1 src/sys/dev/ath/ath_rate/onoe/onoe.h 1.20 +58 -74 src/sys/dev/ath/ath_rate/sample/sample.c 1.8 +2 -1 src/sys/dev/ath/ath_rate/sample/sample.h 1.180 +1312 -869 src/sys/dev/ath/if_ath.c 1.21 +1 -1 src/sys/dev/ath/if_ath_pci.c 1.20 +1 -1 src/sys/dev/ath/if_athioctl.h 1.7 +2 -2 src/sys/dev/ath/if_athrate.h 1.63 +76 -42 src/sys/dev/ath/if_athvar.h 1.134 +221 -328 src/sys/dev/if_ndis/if_ndis.c 1.30 +8 -1 src/sys/dev/if_ndis/if_ndisvar.h 1.35 +503 -568 src/sys/dev/ipw/if_ipw.c 1.8 +25 -27 src/sys/dev/ipw/if_ipwvar.h 1.60 +522 -550 src/sys/dev/iwi/if_iwi.c 1.17 +32 -35 src/sys/dev/iwi/if_iwivar.h 1.2 +234 -363 src/sys/dev/malo/if_malo.c 1.2 +8 -6 src/sys/dev/malo/if_malo.h 1.8 +3 -1 src/sys/dev/ral/if_ral_pci.c 1.2 +0 -192 src/sys/dev/ral/if_ralrate.c (dead) 1.2 +0 -98 src/sys/dev/ral/if_ralrate.h (dead) 1.20 +537 -684 src/sys/dev/ral/rt2560.c 1.4 +2 -0 src/sys/dev/ral/rt2560reg.h 1.5 +22 -24 src/sys/dev/ral/rt2560var.h 1.20 +584 -671 src/sys/dev/ral/rt2661.c 1.2 +0 -2268 src/sys/dev/ral/rt2661_ucode.h (dead) 1.4 +25 -23 src/sys/dev/ral/rt2661var.h 1.18 +465 -513 src/sys/dev/usb/if_rum.c 1.3 +22 -23 src/sys/dev/usb/if_rumvar.h 1.71 +453 -496 src/sys/dev/usb/if_ural.c 1.10 +23 -22 src/sys/dev/usb/if_uralvar.h 1.14 +266 -293 src/sys/dev/usb/if_zyd.c 1.4 +12 -9 src/sys/dev/usb/if_zydreg.h 1.22 +3 -0 src/sys/dev/wi/if_wavelan_ieee.h 1.215 +704 -2171 src/sys/dev/wi/if_wi.c 1.60 +17 -46 src/sys/dev/wi/if_wi_pccard.c 1.28 +2 -5 src/sys/dev/wi/if_wi_pci.c 1.32 +24 -78 src/sys/dev/wi/if_wivar.h 1.3 +0 -4327 src/sys/dev/wi/spectrum24t_cf.h (dead) 1.11 +360 -383 src/sys/dev/wpi/if_wpi.c 1.3 +24 -24 src/sys/dev/wpi/if_wpivar.h 1.485 +0 -2 src/sys/i386/conf/GENERIC 1.2 +0 -2 src/sys/mips/conf/IDT 1.564 +1 -2 src/sys/modules/Makefile 1.6 +7 -1 src/sys/modules/ath_rate_amrr/Makefile 1.5 +7 -1 src/sys/modules/ath_rate_onoe/Makefile 1.5 +7 -1 src/sys/modules/ath_rate_sample/Makefile 1.2 +5 -1 src/sys/modules/malo/Makefile 1.4 +3 -3 src/sys/modules/ral/Makefile 1.1 +5 -0 src/sys/modules/ralfw/Makefile (new) 1.1 +15 -0 src/sys/modules/ralfw/Makefile.inc (new) 1.1 +5 -0 src/sys/modules/ralfw/rt2561/Makefile (new) 1.1 +5 -0 src/sys/modules/ralfw/rt2561s/Makefile (new) 1.1 +6 -0 src/sys/modules/ralfw/rt2661/Makefile (new) 1.9 +9 -7 src/sys/modules/wlan/Makefile 1.2 +6 -0 src/sys/modules/wlan_acl/Makefile 1.2 +6 -0 src/sys/modules/wlan_amrr/Makefile 1.4 +6 -0 src/sys/modules/wlan_ccmp/Makefile 1.1 +14 -0 src/sys/modules/wlan_rssadapt/Makefile (new) 1.2 +0 -8 src/sys/modules/wlan_scan_ap/Makefile (dead) 1.2 +0 -8 src/sys/modules/wlan_scan_sta/Makefile (dead) 1.2 +6 -0 src/sys/modules/wlan_tkip/Makefile 1.2 +6 -0 src/sys/modules/wlan_wep/Makefile 1.2 +6 -0 src/sys/modules/wlan_xauth/Makefile 1.15 +93 -28 src/sys/net80211/_ieee80211.h 1.46 +640 -360 src/sys/net80211/ieee80211.c 1.19 +13 -6 src/sys/net80211/ieee80211.h 1.7 +54 -62 src/sys/net80211/ieee80211_acl.c 1.1 +877 -0 src/sys/net80211/ieee80211_adhoc.c (new) 1.1 +35 -0 src/sys/net80211/ieee80211_adhoc.h (new) 1.4 +120 -58 src/sys/net80211/ieee80211_amrr.c 1.2 +45 -8 src/sys/net80211/ieee80211_amrr.h 1.17 +137 -119 src/sys/net80211/ieee80211_crypto.c 1.14 +48 -45 src/sys/net80211/ieee80211_crypto.h 1.11 +29 -24 src/sys/net80211/ieee80211_crypto_ccmp.c 1.8 +19 -18 src/sys/net80211/ieee80211_crypto_none.c 1.14 +52 -46 src/sys/net80211/ieee80211_crypto_tkip.c 1.11 +26 -22 src/sys/net80211/ieee80211_crypto_wep.c 1.1 +789 -0 src/sys/net80211/ieee80211_ddb.c (new) 1.1 +372 -0 src/sys/net80211/ieee80211_dfs.c (new) 1.1 +57 -0 src/sys/net80211/ieee80211_dfs.h (new) 1.18 +333 -68 src/sys/net80211/ieee80211_freebsd.c 1.17 +257 -69 src/sys/net80211/ieee80211_freebsd.h 1.1 +2236 -0 src/sys/net80211/ieee80211_hostap.c (new) 1.1 +35 -0 src/sys/net80211/ieee80211_hostap.h (new) 1.9 +366 -227 src/sys/net80211/ieee80211_ht.c 1.5 +78 -6 src/sys/net80211/ieee80211_ht.h 1.116 +406 -2904 src/sys/net80211/ieee80211_input.c 1.1 +156 -0 src/sys/net80211/ieee80211_input.h (new) 1.59 +1583 -932 src/sys/net80211/ieee80211_ioctl.c 1.27 +223 -32 src/sys/net80211/ieee80211_ioctl.h 1.1 +136 -0 src/sys/net80211/ieee80211_monitor.c (new) 1.1 +35 -0 src/sys/net80211/ieee80211_monitor.h (new) 1.92 +1001 -606 src/sys/net80211/ieee80211_node.c 1.31 +165 -92 src/sys/net80211/ieee80211_node.h 1.58 +1299 -749 src/sys/net80211/ieee80211_output.c 1.1 +472 -0 src/sys/net80211/ieee80211_phy.c (new) 1.1 +149 -0 src/sys/net80211/ieee80211_phy.h (new) 1.3 +138 -101 src/sys/net80211/ieee80211_power.c 1.2 +5 -3 src/sys/net80211/ieee80211_power.h 1.46 +775 -474 src/sys/net80211/ieee80211_proto.c 1.28 +120 -72 src/sys/net80211/ieee80211_proto.h 1.4 +252 -179 src/sys/net80211/ieee80211_regdomain.c 1.2 +85 -11 src/sys/net80211/ieee80211_regdomain.h 1.1 +273 -0 src/sys/net80211/ieee80211_rssadapt.c (new) 1.1 +101 -0 src/sys/net80211/ieee80211_rssadapt.h (new) 1.5 +472 -231 src/sys/net80211/ieee80211_scan.c 1.4 +109 -38 src/sys/net80211/ieee80211_scan.h 1.3 +0 -408 src/sys/net80211/ieee80211_scan_ap.c (dead) 1.10 +478 -359 src/sys/net80211/ieee80211_scan_sta.c 1.1 +1647 -0 src/sys/net80211/ieee80211_sta.c (new) 1.1 +36 -0 src/sys/net80211/ieee80211_sta.h (new) 1.55 +328 -183 src/sys/net80211/ieee80211_var.h 1.1 +865 -0 src/sys/net80211/ieee80211_wds.c (new) 1.1 +39 -0 src/sys/net80211/ieee80211_wds.h (new) 1.4 +9 -28 src/sys/net80211/ieee80211_xauth.c 1.304 +0 -2 src/sys/pc98/conf/GENERIC 1.134 +0 -2 src/sys/sparc64/conf/GENERIC From sam at FreeBSD.org Sun Apr 20 20:37:02 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Sun Apr 20 20:37:07 2008 Subject: cvs commit: src/etc Makefile regdomain.xml Message-ID: <200804202037.m3KKb2KM079362@repoman.freebsd.org> sam 2008-04-20 20:37:02 UTC FreeBSD src repository Modified files: etc Makefile Added files: etc regdomain.xml Log: 802.11 regulatory definitions used by ifconfig Support by: Hobnob Revision Changes Path 1.367 +1 -1 src/etc/Makefile 1.1 +1580 -0 src/etc/regdomain.xml (new) From sam at FreeBSD.org Sun Apr 20 20:37:21 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Sun Apr 20 20:37:24 2008 Subject: cvs commit: src/etc network.subr src/etc/defaults rc.conf src/etc/rc.d hostapd netif wpa_supplicant Message-ID: <200804202037.m3KKbLUq079453@repoman.freebsd.org> sam 2008-04-20 20:37:21 UTC FreeBSD src repository Modified files: etc network.subr etc/defaults rc.conf etc/rc.d hostapd netif wpa_supplicant Log: rc support for vaps Revision Changes Path 1.331 +1 -0 src/etc/defaults/rc.conf 1.183 +89 -1 src/etc/network.subr 1.3 +1 -0 src/etc/rc.d/hostapd 1.26 +9 -58 src/etc/rc.d/netif 1.6 +15 -11 src/etc/rc.d/wpa_supplicant From sam at FreeBSD.org Sun Apr 20 20:38:03 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Sun Apr 20 20:38:14 2008 Subject: cvs commit: src/usr.sbin/wlandebug wlandebug.c Message-ID: <200804202038.m3KKc2c8079513@repoman.freebsd.org> sam 2008-04-20 20:38:02 UTC FreeBSD src repository Modified files: usr.sbin/wlandebug wlandebug.c Log: update for vaps Supported by: Hobnob Revision Changes Path 1.6 +27 -22 src/usr.sbin/wlandebug/wlandebug.c From sam at FreeBSD.org Sun Apr 20 20:39:08 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Sun Apr 20 20:39:16 2008 Subject: cvs commit: src/usr.sbin/wpa/hostapd Makefile driver_freebsd.c Message-ID: <200804202039.m3KKd8iu079624@repoman.freebsd.org> sam 2008-04-20 20:39:08 UTC FreeBSD src repository Modified files: usr.sbin/wpa/hostapd Makefile driver_freebsd.c Log: o update for vaps o add+enable radius acl support Supported by: Hobnob Submitted by: Chris Zimmermann (acl support) Revision Changes Path 1.6 +1 -0 src/usr.sbin/wpa/hostapd/Makefile 1.7 +159 -112 src/usr.sbin/wpa/hostapd/driver_freebsd.c From sam at FreeBSD.org Sun Apr 20 20:40:46 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Sun Apr 20 20:40:51 2008 Subject: cvs commit: src/usr.sbin/wpa/wpa_supplicant Packet32.c driver_freebsd.c driver_wired.c Message-ID: <200804202040.m3KKejRv080106@repoman.freebsd.org> sam 2008-04-20 20:40:45 UTC FreeBSD src repository Modified files: usr.sbin/wpa/wpa_supplicant Packet32.c driver_freebsd.c Added files: usr.sbin/wpa/wpa_supplicant driver_wired.c Log: o update for vaps o add private wired driver that fixes various bugs in the vendor version Submitted by: thompsa (ndis fixups) Revision Changes Path 1.5 +2 -2 src/usr.sbin/wpa/wpa_supplicant/Packet32.c 1.16 +127 -19 src/usr.sbin/wpa/wpa_supplicant/driver_freebsd.c 1.1 +185 -0 src/usr.sbin/wpa/wpa_supplicant/driver_wired.c (new) From sam at FreeBSD.org Sun Apr 20 20:41:48 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Sun Apr 20 20:41:50 2008 Subject: cvs commit: src/tools/tools/net80211/wlanstats main.c wlanstats.c Message-ID: <200804202041.m3KKfldS080170@repoman.freebsd.org> sam 2008-04-20 20:41:47 UTC FreeBSD src repository Modified files: tools/tools/net80211/wlanstats main.c wlanstats.c Log: update for vaps Supported by: Hobnob Revision Changes Path 1.4 +4 -2 src/tools/tools/net80211/wlanstats/main.c 1.7 +117 -9 src/tools/tools/net80211/wlanstats/wlanstats.c From sam at FreeBSD.org Sun Apr 20 20:43:14 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Sun Apr 20 20:43:24 2008 Subject: cvs commit: src/tools/tools/net80211 Makefile src/tools/tools/net80211/wlanwds Makefile wlanwds.c Message-ID: <200804202043.m3KKhECJ080268@repoman.freebsd.org> sam 2008-04-20 20:43:13 UTC FreeBSD src repository Modified files: tools/tools/net80211 Makefile Added files: tools/tools/net80211/wlanwds Makefile wlanwds.c Log: add dwds test app Supported by: Hobnob Obtained from: Atheros (earlier version) Revision Changes Path 1.5 +1 -1 src/tools/tools/net80211/Makefile 1.1 +7 -0 src/tools/tools/net80211/wlanwds/Makefile (new) 1.1 +351 -0 src/tools/tools/net80211/wlanwds/wlanwds.c (new) From sam at FreeBSD.org Sun Apr 20 20:43:42 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Sun Apr 20 20:43:49 2008 Subject: cvs commit: src/tools/tools/net80211/scripts config setup.dfs setup.fixed setup.local setup.mixed setup.simple setup.simple2 setup.sta setup.tsn setup.updown setup.updown.wpa setup.wds setup.wdsmain setup.wdsrelay setup.wep setup.wpa setup.wpa1.aes ... Message-ID: <200804202043.m3KKhgF3080364@repoman.freebsd.org> sam 2008-04-20 20:43:42 UTC FreeBSD src repository Added files: tools/tools/net80211/scripts config setup.dfs setup.fixed setup.local setup.mixed setup.simple setup.simple2 setup.sta setup.tsn setup.updown setup.updown.wpa setup.wds setup.wdsmain setup.wdsrelay setup.wep setup.wpa setup.wpa1.aes setup.wpa1.tkip setup.wpa2 setup.wpa2.tkip Log: test scripts for vaps and other 802.11 features Supported by: Hobnob and Marvell Revision Changes Path 1.1 +54 -0 src/tools/tools/net80211/scripts/config (new) 1.1 +25 -0 src/tools/tools/net80211/scripts/setup.dfs (new) 1.1 +17 -0 src/tools/tools/net80211/scripts/setup.fixed (new) 1.1 +16 -0 src/tools/tools/net80211/scripts/setup.local (new) 1.1 +62 -0 src/tools/tools/net80211/scripts/setup.mixed (new) 1.1 +16 -0 src/tools/tools/net80211/scripts/setup.simple (new) 1.1 +24 -0 src/tools/tools/net80211/scripts/setup.simple2 (new) 1.1 +15 -0 src/tools/tools/net80211/scripts/setup.sta (new) 1.1 +55 -0 src/tools/tools/net80211/scripts/setup.tsn (new) 1.1 +26 -0 src/tools/tools/net80211/scripts/setup.updown (new) 1.1 +61 -0 src/tools/tools/net80211/scripts/setup.updown.wpa (new) 1.1 +21 -0 src/tools/tools/net80211/scripts/setup.wds (new) 1.1 +40 -0 src/tools/tools/net80211/scripts/setup.wdsmain (new) 1.1 +35 -0 src/tools/tools/net80211/scripts/setup.wdsrelay (new) 1.1 +21 -0 src/tools/tools/net80211/scripts/setup.wep (new) 1.1 +53 -0 src/tools/tools/net80211/scripts/setup.wpa (new) 1.1 +53 -0 src/tools/tools/net80211/scripts/setup.wpa1.aes (new) 1.1 +53 -0 src/tools/tools/net80211/scripts/setup.wpa1.tkip (new) 1.1 +54 -0 src/tools/tools/net80211/scripts/setup.wpa2 (new) 1.1 +54 -0 src/tools/tools/net80211/scripts/setup.wpa2.tkip (new) From sam at freebsd.org Sun Apr 20 20:54:28 2008 From: sam at freebsd.org (Sam Leffler) Date: Sun Apr 20 20:54:37 2008 Subject: cvs commit: src/sys/amd64/conf GENERIC src/sys/arm/conf AVILA HL200 KB920X src/sys/conf NOTES files options src/sys/contrib/dev/ral LICENSE Makefile rt2561.fw.uu rt2561s.fw.uu rt2661.fw.uu rt2661_ucode.h rt2860.fw.uu ... In-Reply-To: <200804202035.m3KKZk4X079263@repoman.freebsd.org> References: <200804202035.m3KKZk4X079263@repoman.freebsd.org> Message-ID: <480BAD82.1050305@freebsd.org> Expect fallout from these changes. Known issues: o kernel configs must be updated to remove wlan_scan_* o ipw is broken o wi works for Prism cards with newer firmware (1.7.x tested w/ wpa!) but older cards/firmware and Lucent cards are known broken o adhoc mode is little tested and may be broken o monitor mode radiotap support is available only on the "parent device" I promise to look at ipw but it won't happen immediately so anyone that's affected should feel free to dig in. I have no plans to touch wi; folks that persist in using these cards should fix issues now that I've rewritten the driver so that it is more properly integrated with net80211. OTOH wi now does wpa and adding wds support should be straightforward. Sam From sam at freebsd.org Sun Apr 20 20:55:16 2008 From: sam at freebsd.org (Sam Leffler) Date: Sun Apr 20 20:55:26 2008 Subject: cvs commit: src/etc network.subr src/etc/defaults rc.conf src/etc/rc.d hostapd netif wpa_supplicant In-Reply-To: <200804202037.m3KKbLUq079453@repoman.freebsd.org> References: <200804202037.m3KKbLUq079453@repoman.freebsd.org> Message-ID: <480BADB3.8050209@freebsd.org> Sam Leffler wrote: > sam 2008-04-20 20:37:21 UTC > > FreeBSD src repository > > Modified files: > etc network.subr > etc/defaults rc.conf > etc/rc.d hostapd netif wpa_supplicant > Log: > rc support for vaps > > Forgot to say that Brooks did most of this. Sam From cvs-src at yandex.ru Sun Apr 20 21:00:10 2008 From: cvs-src at yandex.ru (R.Mahmatkhanov) Date: Sun Apr 20 21:00:14 2008 Subject: cvs commit: src/sys/amd64/conf GENERIC src/sys/arm/conf AVILA HL200 KB920X src/sys/conf NOTES files options src/sys/contrib/dev/ral LICENSE Makefile rt2561.fw.uu rt2561s.fw.uu rt2661.fw.uu rt2661_ucode.h rt2860.fw.uu ... In-Reply-To: <200804202035.m3KKZk4X079263@repoman.freebsd.org> References: <200804202035.m3KKZk4X079263@repoman.freebsd.org> Message-ID: <480BA9A2.2050207@yandex.ru> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 That is great! Much thanks! When you plan to MFC it and is there any plans to import and MFC bwi driver? Sam Leffler ?????: > sam 2008-04-20 20:35:46 UTC > > FreeBSD src repository > > Modified files: > sys/amd64/conf GENERIC > sys/arm/conf AVILA HL200 KB920X > sys/conf NOTES files options > sys/dev/ath ah_osdep.c ah_osdep.h if_ath.c > if_ath_pci.c if_athioctl.h if_athrate.h > if_athvar.h > sys/dev/ath/ath_rate/amrr amrr.c amrr.h > sys/dev/ath/ath_rate/onoe onoe.c onoe.h > sys/dev/ath/ath_rate/sample sample.c sample.h > sys/dev/if_ndis if_ndis.c if_ndisvar.h > sys/dev/ipw if_ipw.c if_ipwvar.h > sys/dev/iwi if_iwi.c if_iwivar.h > sys/dev/malo if_malo.c if_malo.h > sys/dev/ral if_ral_pci.c rt2560.c rt2560reg.h > rt2560var.h rt2661.c rt2661var.h > sys/dev/usb if_rum.c if_rumvar.h if_ural.c > if_uralvar.h if_zyd.c if_zydreg.h > sys/dev/wi if_wavelan_ieee.h if_wi.c if_wi_pccard.c > if_wi_pci.c if_wivar.h > sys/dev/wpi if_wpi.c if_wpivar.h > sys/i386/conf GENERIC > sys/mips/conf IDT > sys/modules Makefile > sys/modules/ath_rate_amrr Makefile > sys/modules/ath_rate_onoe Makefile > sys/modules/ath_rate_sample Makefile > sys/modules/malo Makefile > sys/modules/ral Makefile > sys/modules/wlan Makefile > sys/modules/wlan_acl Makefile > sys/modules/wlan_amrr Makefile > sys/modules/wlan_ccmp Makefile > sys/modules/wlan_tkip Makefile > sys/modules/wlan_wep Makefile > sys/modules/wlan_xauth Makefile > sys/net80211 _ieee80211.h ieee80211.c ieee80211.h > ieee80211_acl.c ieee80211_amrr.c > ieee80211_amrr.h ieee80211_crypto.c > ieee80211_crypto.h > ieee80211_crypto_ccmp.c > ieee80211_crypto_none.c > ieee80211_crypto_tkip.c > ieee80211_crypto_wep.c > ieee80211_freebsd.c ieee80211_freebsd.h > ieee80211_ht.c ieee80211_ht.h > ieee80211_input.c ieee80211_ioctl.c > ieee80211_ioctl.h ieee80211_node.c > ieee80211_node.h ieee80211_output.c > ieee80211_power.c ieee80211_power.h > ieee80211_proto.c ieee80211_proto.h > ieee80211_regdomain.c > ieee80211_regdomain.h ieee80211_scan.c > ieee80211_scan.h ieee80211_scan_sta.c > ieee80211_var.h ieee80211_xauth.c > sys/pc98/conf GENERIC > sys/sparc64/conf GENERIC > share/man/man4 ath.4 ipw.4 iwi.4 malo.4 ral.4 rum.4 > ural.4 wi.4 wlan.4 wlan_acl.4 wlan_amrr.4 > wlan_xauth.4 wpi.4 zyd.4 > share/man/man5 Makefile > sbin/ifconfig Makefile ifconfig.8 ifieee80211.c > ifmedia.c > Added files: > sys/contrib/dev/ral LICENSE Makefile rt2561.fw.uu > rt2561s.fw.uu rt2661.fw.uu rt2661_ucode.h > rt2860.fw.uu > sys/modules/ralfw Makefile Makefile.inc > sys/modules/ralfw/rt2561 Makefile > sys/modules/ralfw/rt2561s Makefile > sys/modules/ralfw/rt2661 Makefile > sys/modules/wlan_rssadapt Makefile > sys/net80211 ieee80211_adhoc.c ieee80211_adhoc.h > ieee80211_ddb.c ieee80211_dfs.c > ieee80211_dfs.h ieee80211_hostap.c > ieee80211_hostap.h ieee80211_input.h > ieee80211_monitor.c ieee80211_monitor.h > ieee80211_phy.c ieee80211_phy.h > ieee80211_rssadapt.c ieee80211_rssadapt.h > ieee80211_sta.c ieee80211_sta.h > ieee80211_wds.c ieee80211_wds.h > share/man/man5 regdomain.5 > sbin/ifconfig regdomain.c regdomain.h > Removed files: > sys/dev/ral if_ralrate.c if_ralrate.h rt2661_ucode.h > sys/dev/wi spectrum24t_cf.h > sys/modules/wlan_scan_ap Makefile > sys/modules/wlan_scan_sta Makefile > sys/net80211 ieee80211_scan_ap.c > Log: > Multi-bss (aka vap) support for 802.11 devices. > > Note this includes changes to all drivers and moves some device firmware > loading to use firmware(9) and a separate module (e.g. ral). Also there > no longer are separate wlan_scan* modules; this functionality is now > bundled into the wlan module. > > Supported by: Hobnob and Marvell > Reviewed by: many > Obtained from: Atheros (some bits) > > Revision Changes Path > 1.34 +6 -3 src/sbin/ifconfig/Makefile > 1.147 +518 -197 src/sbin/ifconfig/ifconfig.8 > 1.51 +1207 -126 src/sbin/ifconfig/ifieee80211.c > 1.26 +12 -4 src/sbin/ifconfig/ifmedia.c > 1.1 +636 -0 src/sbin/ifconfig/regdomain.c (new) > 1.1 +112 -0 src/sbin/ifconfig/regdomain.h (new) > 1.45 +59 -62 src/share/man/man4/ath.4 > 1.18 +39 -32 src/share/man/man4/ipw.4 > 1.20 +39 -32 src/share/man/man4/iwi.4 > 1.3 +39 -35 src/share/man/man4/malo.4 > 1.14 +47 -20 src/share/man/man4/ral.4 > 1.4 +42 -30 src/share/man/man4/rum.4 > 1.16 +33 -19 src/share/man/man4/ural.4 > 1.75 +61 -117 src/share/man/man4/wi.4 > 1.16 +88 -42 src/share/man/man4/wlan.4 > 1.4 +5 -6 src/share/man/man4/wlan_acl.4 > 1.3 +6 -6 src/share/man/man4/wlan_amrr.4 > 1.4 +7 -8 src/share/man/man4/wlan_xauth.4 > 1.4 +50 -41 src/share/man/man4/wpi.4 > 1.4 +22 -41 src/share/man/man4/zyd.4 > 1.80 +1 -0 src/share/man/man5/Makefile > 1.1 +48 -0 src/share/man/man5/regdomain.5 (new) > 1.497 +0 -2 src/sys/amd64/conf/GENERIC > 1.12 +0 -2 src/sys/arm/conf/AVILA > 1.4 +0 -2 src/sys/arm/conf/HL200 > 1.16 +0 -2 src/sys/arm/conf/KB920X > 1.1481 +0 -2 src/sys/conf/NOTES > 1.1293 +13 -3 src/sys/conf/files > 1.626 +10 -0 src/sys/conf/options > 1.1 +16 -0 src/sys/contrib/dev/ral/LICENSE (new) > 1.1 +36 -0 src/sys/contrib/dev/ral/Makefile (new) > 1.1 +202 -0 src/sys/contrib/dev/ral/rt2561.fw.uu (new) > 1.1 +202 -0 src/sys/contrib/dev/ral/rt2561s.fw.uu (new) > 1.1 +202 -0 src/sys/contrib/dev/ral/rt2661.fw.uu (new) > 1.1 +3016 -0 src/sys/contrib/dev/ral/rt2661_ucode.h (new) > 1.1 +202 -0 src/sys/contrib/dev/ral/rt2860.fw.uu (new) > 1.4 +1 -1 src/sys/dev/ath/ah_osdep.c > 1.3 +1 -1 src/sys/dev/ath/ah_osdep.h > 1.15 +53 -93 src/sys/dev/ath/ath_rate/amrr/amrr.c > 1.3 +3 -1 src/sys/dev/ath/ath_rate/amrr/amrr.h > 1.16 +36 -81 src/sys/dev/ath/ath_rate/onoe/onoe.c > 1.4 +4 -1 src/sys/dev/ath/ath_rate/onoe/onoe.h > 1.20 +58 -74 src/sys/dev/ath/ath_rate/sample/sample.c > 1.8 +2 -1 src/sys/dev/ath/ath_rate/sample/sample.h > 1.180 +1312 -869 src/sys/dev/ath/if_ath.c > 1.21 +1 -1 src/sys/dev/ath/if_ath_pci.c > 1.20 +1 -1 src/sys/dev/ath/if_athioctl.h > 1.7 +2 -2 src/sys/dev/ath/if_athrate.h > 1.63 +76 -42 src/sys/dev/ath/if_athvar.h > 1.134 +221 -328 src/sys/dev/if_ndis/if_ndis.c > 1.30 +8 -1 src/sys/dev/if_ndis/if_ndisvar.h > 1.35 +503 -568 src/sys/dev/ipw/if_ipw.c > 1.8 +25 -27 src/sys/dev/ipw/if_ipwvar.h > 1.60 +522 -550 src/sys/dev/iwi/if_iwi.c > 1.17 +32 -35 src/sys/dev/iwi/if_iwivar.h > 1.2 +234 -363 src/sys/dev/malo/if_malo.c > 1.2 +8 -6 src/sys/dev/malo/if_malo.h > 1.8 +3 -1 src/sys/dev/ral/if_ral_pci.c > 1.2 +0 -192 src/sys/dev/ral/if_ralrate.c (dead) > 1.2 +0 -98 src/sys/dev/ral/if_ralrate.h (dead) > 1.20 +537 -684 src/sys/dev/ral/rt2560.c > 1.4 +2 -0 src/sys/dev/ral/rt2560reg.h > 1.5 +22 -24 src/sys/dev/ral/rt2560var.h > 1.20 +584 -671 src/sys/dev/ral/rt2661.c > 1.2 +0 -2268 src/sys/dev/ral/rt2661_ucode.h (dead) > 1.4 +25 -23 src/sys/dev/ral/rt2661var.h > 1.18 +465 -513 src/sys/dev/usb/if_rum.c > 1.3 +22 -23 src/sys/dev/usb/if_rumvar.h > 1.71 +453 -496 src/sys/dev/usb/if_ural.c > 1.10 +23 -22 src/sys/dev/usb/if_uralvar.h > 1.14 +266 -293 src/sys/dev/usb/if_zyd.c > 1.4 +12 -9 src/sys/dev/usb/if_zydreg.h > 1.22 +3 -0 src/sys/dev/wi/if_wavelan_ieee.h > 1.215 +704 -2171 src/sys/dev/wi/if_wi.c > 1.60 +17 -46 src/sys/dev/wi/if_wi_pccard.c > 1.28 +2 -5 src/sys/dev/wi/if_wi_pci.c > 1.32 +24 -78 src/sys/dev/wi/if_wivar.h > 1.3 +0 -4327 src/sys/dev/wi/spectrum24t_cf.h (dead) > 1.11 +360 -383 src/sys/dev/wpi/if_wpi.c > 1.3 +24 -24 src/sys/dev/wpi/if_wpivar.h > 1.485 +0 -2 src/sys/i386/conf/GENERIC > 1.2 +0 -2 src/sys/mips/conf/IDT > 1.564 +1 -2 src/sys/modules/Makefile > 1.6 +7 -1 src/sys/modules/ath_rate_amrr/Makefile > 1.5 +7 -1 src/sys/modules/ath_rate_onoe/Makefile > 1.5 +7 -1 src/sys/modules/ath_rate_sample/Makefile > 1.2 +5 -1 src/sys/modules/malo/Makefile > 1.4 +3 -3 src/sys/modules/ral/Makefile > 1.1 +5 -0 src/sys/modules/ralfw/Makefile (new) > 1.1 +15 -0 src/sys/modules/ralfw/Makefile.inc (new) > 1.1 +5 -0 src/sys/modules/ralfw/rt2561/Makefile (new) > 1.1 +5 -0 src/sys/modules/ralfw/rt2561s/Makefile (new) > 1.1 +6 -0 src/sys/modules/ralfw/rt2661/Makefile (new) > 1.9 +9 -7 src/sys/modules/wlan/Makefile > 1.2 +6 -0 src/sys/modules/wlan_acl/Makefile > 1.2 +6 -0 src/sys/modules/wlan_amrr/Makefile > 1.4 +6 -0 src/sys/modules/wlan_ccmp/Makefile > 1.1 +14 -0 src/sys/modules/wlan_rssadapt/Makefile (new) > 1.2 +0 -8 src/sys/modules/wlan_scan_ap/Makefile (dead) > 1.2 +0 -8 src/sys/modules/wlan_scan_sta/Makefile (dead) > 1.2 +6 -0 src/sys/modules/wlan_tkip/Makefile > 1.2 +6 -0 src/sys/modules/wlan_wep/Makefile > 1.2 +6 -0 src/sys/modules/wlan_xauth/Makefile > 1.15 +93 -28 src/sys/net80211/_ieee80211.h > 1.46 +640 -360 src/sys/net80211/ieee80211.c > 1.19 +13 -6 src/sys/net80211/ieee80211.h > 1.7 +54 -62 src/sys/net80211/ieee80211_acl.c > 1.1 +877 -0 src/sys/net80211/ieee80211_adhoc.c (new) > 1.1 +35 -0 src/sys/net80211/ieee80211_adhoc.h (new) > 1.4 +120 -58 src/sys/net80211/ieee80211_amrr.c > 1.2 +45 -8 src/sys/net80211/ieee80211_amrr.h > 1.17 +137 -119 src/sys/net80211/ieee80211_crypto.c > 1.14 +48 -45 src/sys/net80211/ieee80211_crypto.h > 1.11 +29 -24 src/sys/net80211/ieee80211_crypto_ccmp.c > 1.8 +19 -18 src/sys/net80211/ieee80211_crypto_none.c > 1.14 +52 -46 src/sys/net80211/ieee80211_crypto_tkip.c > 1.11 +26 -22 src/sys/net80211/ieee80211_crypto_wep.c > 1.1 +789 -0 src/sys/net80211/ieee80211_ddb.c (new) > 1.1 +372 -0 src/sys/net80211/ieee80211_dfs.c (new) > 1.1 +57 -0 src/sys/net80211/ieee80211_dfs.h (new) > 1.18 +333 -68 src/sys/net80211/ieee80211_freebsd.c > 1.17 +257 -69 src/sys/net80211/ieee80211_freebsd.h > 1.1 +2236 -0 src/sys/net80211/ieee80211_hostap.c (new) > 1.1 +35 -0 src/sys/net80211/ieee80211_hostap.h (new) > 1.9 +366 -227 src/sys/net80211/ieee80211_ht.c > 1.5 +78 -6 src/sys/net80211/ieee80211_ht.h > 1.116 +406 -2904 src/sys/net80211/ieee80211_input.c > 1.1 +156 -0 src/sys/net80211/ieee80211_input.h (new) > 1.59 +1583 -932 src/sys/net80211/ieee80211_ioctl.c > 1.27 +223 -32 src/sys/net80211/ieee80211_ioctl.h > 1.1 +136 -0 src/sys/net80211/ieee80211_monitor.c (new) > 1.1 +35 -0 src/sys/net80211/ieee80211_monitor.h (new) > 1.92 +1001 -606 src/sys/net80211/ieee80211_node.c > 1.31 +165 -92 src/sys/net80211/ieee80211_node.h > 1.58 +1299 -749 src/sys/net80211/ieee80211_output.c > 1.1 +472 -0 src/sys/net80211/ieee80211_phy.c (new) > 1.1 +149 -0 src/sys/net80211/ieee80211_phy.h (new) > 1.3 +138 -101 src/sys/net80211/ieee80211_power.c > 1.2 +5 -3 src/sys/net80211/ieee80211_power.h > 1.46 +775 -474 src/sys/net80211/ieee80211_proto.c > 1.28 +120 -72 src/sys/net80211/ieee80211_proto.h > 1.4 +252 -179 src/sys/net80211/ieee80211_regdomain.c > 1.2 +85 -11 src/sys/net80211/ieee80211_regdomain.h > 1.1 +273 -0 src/sys/net80211/ieee80211_rssadapt.c (new) > 1.1 +101 -0 src/sys/net80211/ieee80211_rssadapt.h (new) > 1.5 +472 -231 src/sys/net80211/ieee80211_scan.c > 1.4 +109 -38 src/sys/net80211/ieee80211_scan.h > 1.3 +0 -408 src/sys/net80211/ieee80211_scan_ap.c (dead) > 1.10 +478 -359 src/sys/net80211/ieee80211_scan_sta.c > 1.1 +1647 -0 src/sys/net80211/ieee80211_sta.c (new) > 1.1 +36 -0 src/sys/net80211/ieee80211_sta.h (new) > 1.55 +328 -183 src/sys/net80211/ieee80211_var.h > 1.1 +865 -0 src/sys/net80211/ieee80211_wds.c (new) > 1.1 +39 -0 src/sys/net80211/ieee80211_wds.h (new) > 1.4 +9 -28 src/sys/net80211/ieee80211_xauth.c > 1.304 +0 -2 src/sys/pc98/conf/GENERIC > 1.134 +0 -2 src/sys/sparc64/conf/GENERIC > _______________________________________________ > cvs-src@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/cvs-src > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEARECAAYFAkgLqaIACgkQmY+KeAh7t3CvdgCg56qR27gbXVmuz3Sk9VnTue6P /FAAn2h/L7fRpYyEn+QaY228SPS+6fkA =8ELm -----END PGP SIGNATURE----- From sam at freebsd.org Sun Apr 20 21:18:57 2008 From: sam at freebsd.org (Sam Leffler) Date: Sun Apr 20 21:19:01 2008 Subject: cvs commit: src/sys/amd64/conf GENERIC src/sys/arm/conf AVILA HL200 KB920X src/sys/conf NOTES files options src/sys/contrib/dev/ral LICENSE Makefile rt2561.fw.uu rt2561s.fw.uu rt2661.fw.uu rt2661_ucode.h rt2860.fw.uu ... In-Reply-To: <480BA9A2.2050207@yandex.ru> References: <200804202035.m3KKZk4X079263@repoman.freebsd.org> <480BA9A2.2050207@yandex.ru> Message-ID: <480BB33F.8050900@freebsd.org> R.Mahmatkhanov wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > That is great! Much thanks! > > When you plan to MFC it and is there any plans to import and MFC bwi driver? > > This work will not be mfc'd. Sam From sam at FreeBSD.org Sun Apr 20 21:25:38 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Sun Apr 20 21:25:48 2008 Subject: cvs commit: src/sys/sys param.h src UPDATING Message-ID: <200804202125.m3KLPcgW091808@repoman.freebsd.org> sam 2008-04-20 21:25:37 UTC FreeBSD src repository Modified files: sys/sys param.h . UPDATING Log: 802.11 support moves to vaps Revision Changes Path 1.525 +10 -0 src/UPDATING 1.352 +1 -1 src/sys/sys/param.h From sam at FreeBSD.org Sun Apr 20 21:39:07 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Sun Apr 20 21:39:17 2008 Subject: cvs commit: src/contrib/hostapd driver_wired.c Message-ID: <200804202139.m3KLd6gY092220@repoman.freebsd.org> sam 2008-04-20 21:39:06 UTC FreeBSD src repository Removed files: (Branch: MALINEN) contrib/hostapd driver_wired.c Log: remove this; we now use private code Revision Changes Path 1.1.1.4 +0 -391 src/contrib/hostapd/driver_wired.c (dead) From andre at freebsd.org Sun Apr 20 21:49:47 2008 From: andre at freebsd.org (Andre Oppermann) Date: Sun Apr 20 21:49:51 2008 Subject: cvs commit: src/sys/amd64/conf GENERIC src/sys/arm/conf AVILA HL200 KB920X src/sys/conf NOTES files options src/sys/contrib/dev/ral LICENSE Makefile rt2561.fw.uu rt2561s.fw.uu rt2661.fw.uu rt2661_ucode.h rt2860.fw.uu ... In-Reply-To: <200804202035.m3KKZk4X079263@repoman.freebsd.org> References: <200804202035.m3KKZk4X079263@repoman.freebsd.org> Message-ID: <480BBA7A.9030304@freebsd.org> Sam Leffler wrote: > sam 2008-04-20 20:35:46 UTC > > FreeBSD src repository > > Modified files: > lots... > Log: > Multi-bss (aka vap) support for 802.11 devices. > > Note this includes changes to all drivers and moves some device firmware > loading to use firmware(9) and a separate module (e.g. ral). Also there > no longer are separate wlan_scan* modules; this functionality is now > bundled into the wlan module. Wow! > Supported by: Hobnob and Marvell Hell has frozen over!? Marvell supporting something OpenSource??? > Reviewed by: many > Obtained from: Atheros (some bits) -- Andre From sam at freebsd.org Sun Apr 20 22:22:25 2008 From: sam at freebsd.org (Sam Leffler) Date: Sun Apr 20 22:22:33 2008 Subject: cvs commit: src/sys/amd64/conf GENERIC src/sys/arm/conf AVILA HL200 KB920X src/sys/conf NOTES files options src/sys/contrib/dev/ral LICENSE Makefile rt2561.fw.uu rt2561s.fw.uu rt2661.fw.uu rt2661_ucode.h rt2860.fw.uu ... In-Reply-To: <480BBA7A.9030304@freebsd.org> References: <200804202035.m3KKZk4X079263@repoman.freebsd.org> <480BBA7A.9030304@freebsd.org> Message-ID: <480BC220.9060504@freebsd.org> Andre Oppermann wrote: > Supported by: Hobnob and Marvell > > Hell has frozen over!? Marvell supporting something OpenSource??? > Marvell has been cooperative on many issues over the past 2 years. Sam From andre at freebsd.org Sun Apr 20 22:42:11 2008 From: andre at freebsd.org (Andre Oppermann) Date: Sun Apr 20 22:42:22 2008 Subject: cvs commit: src/sys/amd64/conf GENERIC src/sys/arm/conf AVILA HL200 KB920X src/sys/conf NOTES files options src/sys/contrib/dev/ral LICENSE Makefile rt2561.fw.uu rt2561s.fw.uu rt2661.fw.uu rt2661_ucode.h rt2860.fw.uu ... In-Reply-To: <480BC220.9060504@freebsd.org> References: <200804202035.m3KKZk4X079263@repoman.freebsd.org> <480BBA7A.9030304@freebsd.org> <480BC220.9060504@freebsd.org> Message-ID: <480BC6C2.7090307@freebsd.org> Sam Leffler wrote: > Andre Oppermann wrote: >> Supported by: Hobnob and Marvell >> >> Hell has frozen over!? Marvell supporting something OpenSource??? >> > > Marvell has been cooperative on many issues over the past 2 years. The last time I was talking to them (up to senior management) regarding documentation on their gigabit network chips all I got after many month of discussion was a "no" from high up and a NDA to sign. That was about 2 years ago. The interesting thing was that all people I was actually talking to were in support of releasing the documentation (under an NDA but with an explicit statement that all information gathered from it may be freely used in an OpenSource driver). Do you think they would reconsider? Pyun would be more than happy to have access to the documentation to improve the msk driver. -- Andre From sam at FreeBSD.org Sun Apr 20 23:10:44 2008 From: sam at FreeBSD.org (Sam Leffler) Date: Sun Apr 20 23:11:03 2008 Subject: cvs commit: src/sys/dev/malo if_malo.c Message-ID: <200804202310.m3KNAiWf098924@repoman.freebsd.org> sam 2008-04-20 23:10:44 UTC FreeBSD src repository Modified files: sys/dev/malo if_malo.c Log: fix build Revision Changes Path 1.3 +1 -1 src/sys/dev/malo/if_malo.c From cognet at FreeBSD.org Sun Apr 20 23:29:07 2008 From: cognet at FreeBSD.org (Olivier Houchard) Date: Sun Apr 20 23:29:12 2008 Subject: cvs commit: src/sys/arm/arm intr.c src/sys/arm/at91 at91.c src/sys/arm/include intr.h Message-ID: <200804202329.m3KNT79e099887@repoman.freebsd.org> cognet 2008-04-20 23:29:07 UTC FreeBSD src repository Modified files: sys/arm/arm intr.c sys/arm/at91 at91.c sys/arm/include intr.h Log: On the AT91, we need to write on the EOI register after we handle an interrupt. So, add a new function pointer, arm_post_filter, which defaults to NULL, and which will be used as the post_filter arg for intr_event_create(). Set it properly for the AT91, so that it boots again. Reported by: hps Revision Changes Path 1.22 +3 -1 src/sys/arm/arm/intr.c 1.16 +10 -0 src/sys/arm/at91/at91.c 1.8 +1 -0 src/sys/arm/include/intr.h From dandee at hellteam.net Mon Apr 21 00:23:14 2008 From: dandee at hellteam.net (=?iso-8859-2?Q?Daniel_Dvo=F8=E1k?=) Date: Mon Apr 21 00:23:21 2008 Subject: cvs commit: src/sys/sys param.h src UPDATING In-Reply-To: <200804202125.m3KLPcgW091808@repoman.freebsd.org> References: <200804202125.m3KLPcgW091808@repoman.freebsd.org> Message-ID: <000b01c8a341$61f6b8e0$6508280a@tocnet28.jspoj.czf> Hi Sam, At the end ...later than never. Many thanks to you and others in wifi team. This is fantastic great work. Bye Dan -----Original Message----- From: owner-cvs-all@freebsd.org [mailto:owner-cvs-all@freebsd.org] On Behalf Of Sam Leffler Sent: Sunday, April 20, 2008 11:26 PM To: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; cvs-all@FreeBSD.org Subject: cvs commit: src/sys/sys param.h src UPDATING sam 2008-04-20 21:25:37 UTC FreeBSD src repository Modified files: sys/sys param.h . UPDATING Log: 802.11 support moves to vaps Revision Changes Path 1.525 +10 -0 src/UPDATING 1.352 +1 -1 src/sys/sys/param.h _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" From marcel at FreeBSD.org Mon Apr 21 04:41:38 2008 From: marcel at FreeBSD.org (Marcel Moolenaar) Date: Mon Apr 21 04:41:40 2008 Subject: cvs commit: src/sys/powerpc/aim clock.c nexus.c src/sys/powerpc/conf DEFAULTS Message-ID: <200804210441.m3L4fcXL041251@repoman.freebsd.org> marcel 2008-04-21 04:41:37 UTC FreeBSD src repository Modified files: sys/powerpc/aim clock.c nexus.c sys/powerpc/conf DEFAULTS Log: Switch to using genclock. Have nexus double as clock device for now. While here, add a proper attach() method to nexus. Requested by: phk Revision Changes Path 1.32 +0 -68 src/sys/powerpc/aim/clock.c 1.17 +77 -9 src/sys/powerpc/aim/nexus.c 1.11 +1 -0 src/sys/powerpc/conf/DEFAULTS From brueffer at FreeBSD.org Mon Apr 21 05:43:08 2008 From: brueffer at FreeBSD.org (Christian Brueffer) Date: Mon Apr 21 05:43:14 2008 Subject: cvs commit: src/release/doc/en_US.ISO8859-1/hardware article.sgml src/release/doc/share/misc dev.archlist.txt Message-ID: <200804210543.m3L5h8xV053322@repoman.freebsd.org> brueffer 2008-04-21 05:43:08 UTC FreeBSD src repository Modified files: release/doc/en_US.ISO8859-1/hardware article.sgml release/doc/share/misc dev.archlist.txt Log: awi(4) has been removed. Revision Changes Path 1.330 +0 -2 src/release/doc/en_US.ISO8859-1/hardware/article.sgml 1.105 +0 -1 src/release/doc/share/misc/dev.archlist.txt From phk at FreeBSD.org Mon Apr 21 06:22:28 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Mon Apr 21 06:22:37 2008 Subject: cvs commit: src/tools/tools/nanobsd/Files/root save_cfg Message-ID: <200804210622.m3L6MRAE055805@repoman.freebsd.org> phk 2008-04-21 06:22:27 UTC FreeBSD src repository Added files: tools/tools/nanobsd/Files/root save_cfg Log: Add a small script that will examine all files which exist on /cfg and if they are different in /etc, copy them to /cfg. Submitted by: mat Revision Changes Path 1.1 +42 -0 src/tools/tools/nanobsd/Files/root/save_cfg (new) From kevlo at FreeBSD.org Mon Apr 21 07:25:27 2008 From: kevlo at FreeBSD.org (Kevin Lo) Date: Mon Apr 21 07:25:36 2008 Subject: cvs commit: src/usr.sbin/ancontrol ancontrol.c Message-ID: <200804210725.m3L7PQdN059875@repoman.freebsd.org> kevlo 2008-04-21 07:25:26 UTC FreeBSD src repository Modified files: usr.sbin/ancontrol ancontrol.c Log: Remove duplicate headers Revision Changes Path 1.26 +0 -1 src/usr.sbin/ancontrol/ancontrol.c From dfr at FreeBSD.org Mon Apr 21 09:23:31 2008 From: dfr at FreeBSD.org (Doug Rabson) Date: Mon Apr 21 09:23:42 2008 Subject: cvs commit: src/sys/nlm nlm_prot_impl.c Message-ID: <200804210923.m3L9NVvg075482@repoman.freebsd.org> dfr 2008-04-21 09:23:31 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/nlm nlm_prot_impl.c Log: MFC: nlm_prot_impl.c 1.6 - Fix error handling in nlm_get_rpc and correct some spelling mistakes in comments. Revision Changes Path 1.4.2.3 +7 -3 src/sys/nlm/nlm_prot_impl.c From phk at FreeBSD.org Mon Apr 21 10:09:58 2008 From: phk at FreeBSD.org (Poul-Henning Kamp) Date: Mon Apr 21 10:10:12 2008 Subject: cvs commit: src/sys/conf files files.amd64 files.i386 files.pc98 src/sys/arm/conf AVILA BWCT CRB EP80219 HL200 IQ31244 KB920X SIMICS SKYEYE src/sys/ia64/conf DEFAULTS src/sys/mips/conf ADM5120 IDT MALTA QEMU SENTRY5 src/sys/powerpc/conf DEFAULTS MPC85XX ... Message-ID: <200804211009.m3LA9v5j078072@repoman.freebsd.org> phk 2008-04-21 10:09:55 UTC FreeBSD src repository Modified files: sys/conf files files.amd64 files.i386 files.pc98 sys/arm/conf AVILA BWCT CRB EP80219 HL200 IQ31244 KB920X SIMICS SKYEYE sys/ia64/conf DEFAULTS sys/mips/conf ADM5120 IDT MALTA QEMU SENTRY5 sys/powerpc/conf DEFAULTS MPC85XX sys/sparc64/conf GENERIC NOTES sys/sun4v/conf DEFAULTS NOTES Log: Make genclock standard on all platforms. Thanks to: grehan & marcel for platform support on ia64 and ppc. Revision Changes Path 1.13 +0 -1 src/sys/arm/conf/AVILA 1.5 +0 -1 src/sys/arm/conf/BWCT 1.5 +0 -1 src/sys/arm/conf/CRB 1.8 +0 -1 src/sys/arm/conf/EP80219 1.5 +0 -1 src/sys/arm/conf/HL200 1.22 +0 -1 src/sys/arm/conf/IQ31244 1.17 +0 -1 src/sys/arm/conf/KB920X 1.16 +0 -1 src/sys/arm/conf/SIMICS 1.10 +0 -1 src/sys/arm/conf/SKYEYE 1.1294 +2 -2 src/sys/conf/files 1.121 +0 -2 src/sys/conf/files.amd64 1.595 +0 -2 src/sys/conf/files.i386 1.362 +0 -2 src/sys/conf/files.pc98 1.15 +0 -1 src/sys/ia64/conf/DEFAULTS 1.3 +0 -1 src/sys/mips/conf/ADM5120 1.3 +0 -1 src/sys/mips/conf/IDT 1.3 +0 -1 src/sys/mips/conf/MALTA 1.2 +0 -1 src/sys/mips/conf/QEMU 1.3 +0 -1 src/sys/mips/conf/SENTRY5 1.12 +0 -1 src/sys/powerpc/conf/DEFAULTS 1.3 +0 -1 src/sys/powerpc/conf/MPC85XX 1.135 +0 -1 src/sys/sparc64/conf/GENERIC 1.31 +0 -1 src/sys/sparc64/conf/NOTES 1.7 +0 -1 src/sys/sun4v/conf/DEFAULTS 1.10 +0 -1 src/sys/sun4v/conf/NOTES From sos at FreeBSD.org Mon Apr 21 10:34:32 2008 From: sos at FreeBSD.org (Søren Schmidt) Date: Mon Apr 21 10:34:39 2008 Subject: cvs commit: src/sys/dev/ata ata-chipset.c Message-ID: <200804211034.m3LAYWbH078874@repoman.freebsd.org> sos 2008-04-21 10:34:32 UTC FreeBSD src repository Modified files: sys/dev/ata ata-chipset.c Log: Do not enable FIS based PM switching, even if not used some controllers barf. Revision Changes Path 1.218 +2 -2 src/sys/dev/ata/ata-chipset.c From sos at FreeBSD.org Mon Apr 21 10:35:19 2008 From: sos at FreeBSD.org (Søren Schmidt) Date: Mon Apr 21 10:35:26 2008 Subject: cvs commit: src/sys/dev/ata ata-queue.c Message-ID: <200804211035.m3LAZJvr078954@repoman.freebsd.org> sos 2008-04-21 10:35:19 UTC FreeBSD src repository Modified files: sys/dev/ata ata-queue.c Log: Unload DMA slot on device timeouts. Revision Changes Path 1.73 +1 -0 src/sys/dev/ata/ata-queue.c From ache at nagual.pp.ru Mon Apr 21 10:35:55 2008 From: ache at nagual.pp.ru (Andrey Chernov) Date: Mon Apr 21 10:36:05 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c ata-dma.c In-Reply-To: <20080419015030.GA42329@nagual.pp.ru> References: <200804181515.m3IFF6Nr005172@repoman.freebsd.org> <20080419015030.GA42329@nagual.pp.ru> Message-ID: <20080421103553.GA88956@nagual.pp.ru> On Sat, Apr 19, 2008 at 05:50:31AM +0400, Andrey Chernov wrote: > On Fri, Apr 18, 2008 at 03:15:04PM +0000, S?ren Schmidt wrote: > > Modified files: > > sys/dev/ata ata-all.c ata-dma.c > > Log: > > Fix the breakage that caused AHCI devices to vanish. Editor droppings :( > > Even with this change ATA driver still can't mount root. > ata* disks are not visible through mountroot '?' command too. > ICH6, AHCI mode, ATA_STATIC_ID More details follows. With old ATA driver I got this devices: acd0: DVDROM at ata0-master UDMA100 acd1: DVDR at ata0-slave UDMA33 ad8: 114473MB at ata4-master SATA150 ad12: 238475MB at ata6-master SATA150 ... Trying to mount root from ufs:/dev/ad8s1a With new one only acd0: DVDROM at ata0-master UDMA100 acd1: DVDR at ata0-slave UDMA33 detected, and of course mount root from ufs:/dev/ad8s1a failed. -- http://ache.pp.ru/ From sos at FreeBSD.org Mon Apr 21 10:51:39 2008 From: sos at FreeBSD.org (Søren Schmidt) Date: Mon Apr 21 10:51:50 2008 Subject: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h Message-ID: <200804211051.m3LApcex079459@repoman.freebsd.org> sos 2008-04-21 10:51:38 UTC FreeBSD src repository Modified files: sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h Log: Add HW level support for the Adaptec 1420SA controller. Revision Changes Path 1.219 +21 -0 src/sys/dev/ata/ata-chipset.c 1.127 +5 -0 src/sys/dev/ata/ata-pci.c 1.86 +11 -7 src/sys/dev/ata/ata-pci.h From rwatson at FreeBSD.org Mon Apr 21 12:03:59 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Mon Apr 21 12:04:02 2008 Subject: cvs commit: src/sys/netinet ip_divert.c Message-ID: <200804211203.m3LC3x9P084061@repoman.freebsd.org> rwatson 2008-04-21 12:03:59 UTC FreeBSD src repository Modified files: sys/netinet ip_divert.c Log: Read lock, rather than write lock, the inpcb when transmitting with or delivering to an IP divert socket. MFC after: 3 months Revision Changes Path 1.133 +11 -11 src/sys/netinet/ip_divert.c From rwatson at FreeBSD.org Mon Apr 21 12:06:42 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Mon Apr 21 12:06:52 2008 Subject: cvs commit: src/sys/netinet raw_ip.c src/sys/netinet6 raw_ip6.c Message-ID: <200804211206.m3LC6fXa084275@repoman.freebsd.org> rwatson 2008-04-21 12:06:41 UTC FreeBSD src repository Modified files: sys/netinet raw_ip.c sys/netinet6 raw_ip6.c Log: With IPv4 raw sockets, read lock rather than write lock the inpcb when receiving or transmitting. With IPv6 raw sockets, read lock rather than write lock the inpcb when receiving. Unfortunately, IPv6 source address selection appears to require a write lock on the inpcb for the time being. MFC after: 3 months Revision Changes Path 1.183 +15 -15 src/sys/netinet/raw_ip.c 1.78 +5 -5 src/sys/netinet6/raw_ip6.c From rwatson at FreeBSD.org Mon Apr 21 12:08:45 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Mon Apr 21 12:08:47 2008 Subject: cvs commit: src/sys/netinet6 icmp6.c Message-ID: <200804211208.m3LC8eY3084332@repoman.freebsd.org> rwatson 2008-04-21 12:08:40 UTC FreeBSD src repository Modified files: sys/netinet6 icmp6.c Log: In ICMPv6, read lock rather than write lock the inpcb on receive. MFC after: 3 months Revision Changes Path 1.84 +4 -4 src/sys/netinet6/icmp6.c From rwatson at FreeBSD.org Mon Apr 21 17:09:54 2008 From: rwatson at FreeBSD.org (Robert Watson) Date: Mon Apr 21 17:10:06 2008 Subject: cvs commit: src/share/man/man4 textdump.4 src/usr.bin/procstat procstat.1 Message-ID: <200804211709.m3LH9sV3027422@repoman.freebsd.org> rwatson 2008-04-21 17:09:54 UTC FreeBSD src repository Modified files: share/man/man4 textdump.4 usr.bin/procstat procstat.1 Log: Use ddb(4), not DDB(4) for man page cross-references. MFC after: 3 days Reported by: novel Revision Changes Path 1.4 +4 -4 src/share/man/man4/textdump.4 1.4 +1 -1 src/usr.bin/procstat/procstat.1 From pjd at FreeBSD.org Mon Apr 21 17:22:36 2008 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Mon Apr 21 17:22:42 2008 Subject: cvs commit: src/sys/kern kern_linker.c Message-ID: <200804211722.m3LHMZOT028189@repoman.freebsd.org> pjd 2008-04-21 17:22:35 UTC FreeBSD src repository Modified files: sys/kern kern_linker.c Log: Back-out previous revision. For now I can use _ddb() variants of stack(9) KPI, as I use it for debugging only. Once someone will need it for more production features, the change should be reconsider. Requested by: rwatson Revision Changes Path 1.157 +3 -6 src/sys/kern/kern_linker.c From brooks at FreeBSD.org Mon Apr 21 18:06:32 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Mon Apr 21 18:06:41 2008 Subject: cvs commit: src/sys/amd64/conf GENERIC src/sys/arm/conf AVILA HL200 KB920X src/sys/conf NOTES files options src/sys/contrib/dev/ral LICENSE Makefile rt2561.fw.uu rt2561s.fw.uu rt2661.fw.uu rt2661_ucode.h rt2860.fw.uu ... In-Reply-To: <480BAD82.1050305@freebsd.org> References: <200804202035.m3KKZk4X079263@repoman.freebsd.org> <480BAD82.1050305@freebsd.org> Message-ID: <20080421180643.GA20417@lor.one-eyed-alien.net> On Sun, Apr 20, 2008 at 01:54:26PM -0700, Sam Leffler wrote: > Expect fallout from these changes. Known issues: > > o kernel configs must be updated to remove wlan_scan_* > o ipw is broken > o wi works for Prism cards with newer firmware (1.7.x tested w/ wpa!) but > older cards/firmware and Lucent cards are known broken > o adhoc mode is little tested and may be broken > o monitor mode radiotap support is available only on the "parent device" > > I promise to look at ipw but it won't happen immediately so anyone that's > affected should feel free to dig in. I have no plans to touch wi; folks > that persist in using these cards should fix issues now that I've rewritten > the driver so that it is more properly integrated with net80211. OTOH wi > now does wpa and adding wds support should be straightforward. Also, the required rc.conf options have changed and are mostly incompatible. The infrastructure is subject to change, but it's the best I've been able to come up with so far. Some sort of transition tool might be in order. If you the following in your rc.conf file: ifconfig_ath0="DHCP WPA" you should change it to: vaps_ath0="wlan0" # Any name will work ifconfig_wlan0="DHCP WPA" # Also change any other ath0 related # variables... You if you wanted a more informative naming scheme you could do something like: vaps_ath0="ath0.sta" ifconfig_ath0_sta="DHCP WPA" -- Brooks -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20080421/8773d5bb/attachment.pgp From brooks at FreeBSD.org Mon Apr 21 18:17:48 2008 From: brooks at FreeBSD.org (Brooks Davis) Date: Mon Apr 21 18:18:01 2008 Subject: cvs commit: src/etc/defaults rc.conf Message-ID: <200804211817.m3LIHm97031507@repoman.freebsd.org> brooks 2008-04-21 18:17:48 UTC FreeBSD src repository Modified files: etc/defaults rc.conf Log: Change the default of ddb_enable to YES so we default to generating textdumps on panic. This means you get a potentially useful dump even if your system is running X when you panic. X-MFC after: never Revision Changes Path 1.332 +1 -1 src/etc/defaults/rc.conf From delphij at FreeBSD.org Mon Apr 21 18:30:27 2008 From: delphij at FreeBSD.org (Xin LI) Date: Mon Apr 21 18:30:38 2008 Subject: cvs commit: src/contrib/netcat - Imported sources Message-ID: <200804211830.m3LIUREN032050@repoman.freebsd.org> delphij 2008-04-21 18:30:27 UTC FreeBSD src repository src/contrib/netcat - Imported sources Update of /home/ncvs/src/contrib/netcat In directory repoman.freebsd.org:/tmp/cvs-serv32038 Log Message: Import netcat as of today's OPENBSD_4_3 snapshot. Status: Vendor Tag: OPENBSD Release Tags: OPENBSD_4_3 C src/contrib/netcat/nc.1 U src/contrib/netcat/atomicio.h U src/contrib/netcat/socks.c U src/contrib/netcat/netcat.c U src/contrib/netcat/atomicio.c 1 conflicts created by this import. Use the following command to help the merge: cvs checkout -jOPENBSD:yesterday -jOPENBSD src/contrib/netcat From delphij at FreeBSD.org Mon Apr 21 18:31:50 2008 From: delphij at FreeBSD.org (Xin LI) Date: Mon Apr 21 18:32:09 2008 Subject: cvs commit: src/contrib/netcat nc.1 Message-ID: <200804211831.m3LIVoD3032167@repoman.freebsd.org> delphij 2008-04-21 18:31:50 UTC FreeBSD src repository Modified files: contrib/netcat nc.1 Log: Resolve conflicts. Revision Changes Path 1.9 +2 -2 src/contrib/netcat/nc.1 From delphij at FreeBSD.org Mon Apr 21 18:36:53 2008 From: delphij at FreeBSD.org (Xin LI) Date: Mon Apr 21 18:36:58 2008 Subject: cvs commit: src/contrib/netcat FREEBSD-vendor Message-ID: <200804211836.m3LIaqpU032364@repoman.freebsd.org> delphij 2008-04-21 18:36:52 UTC FreeBSD src repository Added files: contrib/netcat FREEBSD-vendor Log: Add vendor metadata Revision Changes Path 1.1 +7 -0 src/contrib/netcat/FREEBSD-vendor (new) From delphij at FreeBSD.org Mon Apr 21 18:37:08 2008 From: delphij at FreeBSD.org (Xin LI) Date: Mon Apr 21 18:37:19 2008 Subject: cvs commit: src/contrib/netcat FREEBSD-upgrade Message-ID: <200804211837.m3LIb8io032398@repoman.freebsd.org> delphij 2008-04-21 18:37:08 UTC FreeBSD src repository Modified files: contrib/netcat FREEBSD-upgrade Log: Update instructions to match recent practices Revision Changes Path 1.2 +5 -3 src/contrib/netcat/FREEBSD-upgrade From marius at FreeBSD.org Mon Apr 21 20:40:44 2008 From: marius at FreeBSD.org (Marius Strobl) Date: Mon Apr 21 20:41:00 2008 Subject: cvs commit: src/contrib/gcc - Imported sources Message-ID: <200804212040.m3LKehHW038565@repoman.freebsd.org> marius 2008-04-21 20:40:43 UTC FreeBSD src repository src/contrib/gcc - Imported sources Update of /home/ncvs/src/contrib/gcc In directory repoman.freebsd.org:/tmp/cvs-serv38448 Log Message: * gthr-posix.h (__gthread_active_p): Use the Solaris implementation for FreeBSD as well. This is the fix for __gthread_active_p() returning false positives which was committed as rev. 1.1.1.8.2.1 to RELENG_7 but now looped back to the vendor branch via the GCC repository and relicensed to be GPLv2 by me. Thanks go to gerald@ for getting the fix approved upstream and for committing to the GCC repository. PR: 119289 Approved by: core Status: Vendor Tag: FSF Release Tags: gcc_trunk_20080418_SVN134423 U src/contrib/gcc/gthr-posix.h No conflicts created by this import From rdivacky at FreeBSD.org Mon Apr 21 21:24:08 2008 From: rdivacky at FreeBSD.org (Roman Divacky) Date: Mon Apr 21 21:24:15 2008 Subject: cvs commit: src/sys/compat/svr4 svr4_misc.c Message-ID: <200804212124.m3LLO8lQ050235@repoman.freebsd.org> rdivacky 2008-04-21 21:24:08 UTC FreeBSD src repository Modified files: sys/compat/svr4 svr4_misc.c Log: The vmspace->vm_daddr is constant until freed, there is no need to hold lock while accessing it. Approved by: kib (mentor) Revision Changes Path 1.101 +0 -2 src/sys/compat/svr4/svr4_misc.c From jmg at funkthat.com Mon Apr 21 21:54:31 2008 From: jmg at funkthat.com (John-Mark Gurney) Date: Mon Apr 21 21:54:42 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c In-Reply-To: <200804201745.m3KHjWma066842@repoman.freebsd.org> References: <200804201745.m3KHjWma066842@repoman.freebsd.org> Message-ID: <20080421213724.GL82555@funkthat.com> Bjoern A. Zeeb wrote this message on Sun, Apr 20, 2008 at 17:45 +0000: > bz 2008-04-20 17:45:32 UTC > > FreeBSD src repository > > Modified files: > sys/dev/ata ata-all.c > Log: > devclass_get_maxunit() returns n+1 with n starting at 0. > So if we have channel 0..3 devclass_get_maxunit is 4. > > It's never been a problem as devclass_get_device() has > catched a possibly bad input. Any one object to changing: .Nm devclass_get_maxunit .Nd find the maximum unit number in the class to: .Nm devclass_get_maxunit .Nd find the next free unit number in the class It looks like we may also want to change the description, as it doesn't: Returns the next unit number to be allocated to device instances in the devclass. That's what devclass_find_free_unit does, though devclass_alloc_unit doesn't use it. devclass_find_free_unit is also missing a man page. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From phk at phk.freebsd.dk Mon Apr 21 21:55:55 2008 From: phk at phk.freebsd.dk (Poul-Henning Kamp) Date: Mon Apr 21 21:55:59 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c In-Reply-To: Your message of "Mon, 21 Apr 2008 14:37:25 MST." <20080421213724.GL82555@funkthat.com> Message-ID: <99531.1208814953@critter.freebsd.dk> In message <20080421213724.GL82555@funkthat.com>, John-Mark Gurney writes: >Any one object to changing: >.Nm devclass_get_maxunit >.Nd find the maximum unit number in the class > >to: >.Nm devclass_get_maxunit >.Nd find the next free unit number in the class Those are very different semantics, the name should change as well then. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From rpaulo at FreeBSD.org Mon Apr 21 22:00:02 2008 From: rpaulo at FreeBSD.org (Rui Paulo) Date: Mon Apr 21 22:00:06 2008 Subject: cvs commit: src/sys/dev/k8temp k8temp.c Message-ID: <200804212200.m3LM01gD051794@repoman.freebsd.org> rpaulo 2008-04-21 22:00:01 UTC FreeBSD src repository Modified files: sys/dev/k8temp k8temp.c Log: Kill $P4$ id. Noticed by: rwatson Revision Changes Path 1.2 +0 -2 src/sys/dev/k8temp/k8temp.c From scottl at samsco.org Mon Apr 21 22:38:35 2008 From: scottl at samsco.org (Scott Long) Date: Mon Apr 21 22:38:41 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c In-Reply-To: <20080421213724.GL82555@funkthat.com> References: <200804201745.m3KHjWma066842@repoman.freebsd.org> <20080421213724.GL82555@funkthat.com> Message-ID: <480D0E44.9070201@samsco.org> John-Mark Gurney wrote: > Bjoern A. Zeeb wrote this message on Sun, Apr 20, 2008 at 17:45 +0000: >> bz 2008-04-20 17:45:32 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/ata ata-all.c >> Log: >> devclass_get_maxunit() returns n+1 with n starting at 0. >> So if we have channel 0..3 devclass_get_maxunit is 4. >> >> It's never been a problem as devclass_get_device() has >> catched a possibly bad input. > > Any one object to changing: > .Nm devclass_get_maxunit > .Nd find the maximum unit number in the class > > to: > .Nm devclass_get_maxunit > .Nd find the next free unit number in the class > That's not what it actually returns though. It returned the highest allocated unit number plus 1. The unit numbering can be sparse, with the next available unit number being less than the highest allocated unit number. Most callers use this value as the limit in a for loop, hence why it's convenient for it to return the +1. Scott From jmg at funkthat.com Mon Apr 21 23:38:49 2008 From: jmg at funkthat.com (John-Mark Gurney) Date: Mon Apr 21 23:38:58 2008 Subject: cvs commit: src/sys/dev/ata ata-all.c In-Reply-To: <480D0E44.9070201@samsco.org> References: <200804201745.m3KHjWma066842@repoman.freebsd.org> <20080421213724.GL82555@funkthat.com> <480D0E44.9070201@samsco.org> Message-ID: <20080421233847.GM82555@funkthat.com> Scott Long wrote this message on Mon, Apr 21, 2008 at 15:59 -0600: > John-Mark Gurney wrote: > >Bjoern A. Zeeb wrote this message on Sun, Apr 20, 2008 at 17:45 +0000: > >>bz 2008-04-20 17:45:32 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/dev/ata ata-all.c > >> Log: > >> devclass_get_maxunit() returns n+1 with n starting at 0. > >> So if we have channel 0..3 devclass_get_maxunit is 4. > >> > >> It's never been a problem as devclass_get_device() has > >> catched a possibly bad input. > > > >Any one object to changing: > >.Nm devclass_get_maxunit > >.Nd find the maximum unit number in the class > > > >to: > >.Nm devclass_get_maxunit > >.Nd find the next free unit number in the class > > That's not what it actually returns though. It returned the highest > allocated unit number plus 1. The unit numbering can be sparse, with > the next available unit number being less than the highest allocated > unit number. Yeh, that was partly about changing the description... Can you think of a better name besides devclass_get_maxunitplusone? > Most callers use this value as the limit in a for loop, hence why it's > convenient for it to return the +1. Yeh, but it definately does not return maxunit.. :) unitarraysize? Hmmm... find isn't a useful verb, since it doesn't do any finding... it returns a stored value... How about: .Nd return the max number of units in the class And then flush out the description about using it for an array? Though it doesn't solve the naming issue... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From jb at FreeBSD.org Mon Apr 21 23:57:24 2008 From: jb at FreeBSD.org (John Birrell) Date: Mon Apr 21 23:57:29 2008 Subject: cvs commit: src/compat/opensolaris/include devid.h fsshare.h libintl.h mnttab.h priv.h solaris.h zone.h src/compat/opensolaris/lib/libumem umem.c umem.h src/compat/opensolaris/misc deviceid.c fsshare.c mkdirp.c mnttab.c ... Message-ID: <200804212357.m3LNvNPI060113@repoman.freebsd.org> jb 2008-04-21 23:57:23 UTC FreeBSD src repository Removed files: (Branch: RELENG_7) compat/opensolaris/include devid.h fsshare.h libintl.h mnttab.h priv.h solaris.h zone.h compat/opensolaris/lib/libumem umem.c umem.h compat/opensolaris/misc deviceid.c fsshare.c mkdirp.c mnttab.c zmount.c zone.c contrib/opensolaris OPENSOLARIS.LICENSE contrib/opensolaris/cmd/zdb zdb.8 zdb.c zdb_il.c contrib/opensolaris/cmd/zfs zfs.8 zfs_iter.c zfs_iter.h zfs_main.c zfs_util.h contrib/opensolaris/cmd/zpool zpool.8 zpool_iter.c zpool_main.c zpool_util.c zpool_util.h zpool_vdev.c contrib/opensolaris/cmd/ztest ztest.c contrib/opensolaris/head assert.h atomic.h libintl.h stdio_ext.h synch.h thread.h contrib/opensolaris/lib/libnvpair libnvpair.c libnvpair.h nvpair_alloc_system.c contrib/opensolaris/lib/libuutil/common libuutil.h libuutil_common.h libuutil_impl.h uu_alloc.c uu_avl.c uu_dprintf.c uu_ident.c uu_list.c uu_misc.c uu_open.c uu_pname.c uu_strtoint.c contrib/opensolaris/lib/libzfs/common libzfs.h libzfs_changelist.c libzfs_config.c libzfs_dataset.c libzfs_graph.c libzfs_impl.h libzfs_import.c libzfs_mount.c libzfs_pool.c libzfs_status.c libzfs_util.c contrib/opensolaris/lib/libzpool/common kernel.c taskq.c util.c contrib/opensolaris/lib/libzpool/common/sys zfs_context.h sys/compat/opensolaris/kern opensolaris_atomic.c opensolaris_kmem.c opensolaris_kobj.c opensolaris_kstat.c opensolaris_misc.c opensolaris_policy.c opensolaris_string.c opensolaris_vfs.c opensolaris_zone.c sys/compat/opensolaris/machine endian.h sys/compat/opensolaris/rpc xdr.h sys/compat/opensolaris/sys acl.h atomic.h byteorder.h callb.h cmn_err.h cred.h debug.h dirent.h dkio.h dnlc.h kcondvar.h kmem.h kobj.h kstat.h lock.h misc.h mntent.h mnttab.h mount.h mutex.h policy.h proc.h random.h rwlock.h sdt.h string.h sunddi.h sysmacros.h systm.h taskq.h taskq_impl.h time.h types.h uio.h varargs.h vfs.h vnode.h zone.h sys/contrib/opensolaris OPENSOLARIS.LICENSE sys/contrib/opensolaris/common/acl acl_common.c acl_common.h sys/contrib/opensolaris/common/atomic/amd64 atomic.S sys/contrib/opensolaris/common/atomic/i386 atomic.S sys/contrib/opensolaris/common/atomic/ia64 atomic.S sys/contrib/opensolaris/common/avl avl.c sys/contrib/opensolaris/common/nvpair nvpair.c nvpair_alloc_fixed.c sys/contrib/opensolaris/common/zfs zfs_namecheck.c zfs_namecheck.h zfs_prop.c zfs_prop.h sys/contrib/opensolaris/uts/common Makefile.files sys/contrib/opensolaris/uts/common/fs gfs.c sys/contrib/opensolaris/uts/common/fs/zfs arc.c bplist.c dbuf.c dmu.c dmu_object.c dmu_objset.c dmu_send.c dmu_traverse.c dmu_tx.c dmu_zfetch.c dnode.c dnode_sync.c dsl_dataset.c dsl_dir.c dsl_pool.c dsl_prop.c dsl_synctask.c fletcher.c gzip.c lzjb.c metaslab.c refcount.c sha256.c spa.c spa_config.c spa_errlog.c spa_history.c spa_misc.c space_map.c txg.c uberblock.c unique.c vdev.c vdev_cache.c vdev_disk.c vdev_file.c vdev_geom.c vdev_label.c vdev_mirror.c vdev_missing.c vdev_queue.c vdev_raidz.c vdev_root.c zap.c zap_leaf.c zap_micro.c zfs.conf zfs_acl.c zfs_byteswap.c zfs_ctldir.c zfs_dir.c zfs_fm.c zfs_ioctl.c zfs_log.c zfs_replay.c zfs_rlock.c zfs_vfsops.c zfs_vnops.c zfs_znode.c zil.c zio.c zio_checksum.c zio_compress.c zio_inject.c zvol.c sys/contrib/opensolaris/uts/common/fs/zfs/sys arc.h bplist.h dbuf.h dmu.h dmu_impl.h dmu_objset.h dmu_traverse.h dmu_tx.h dmu_zfetch.h dnode.h dsl_dataset.h dsl_dir.h dsl_pool.h dsl_prop.h dsl_synctask.h metaslab.h metaslab_impl.h refcount.h spa.h spa_impl.h space_map.h txg.h txg_impl.h uberblock.h uberblock_impl.h unique.h vdev.h vdev_disk.h vdev_file.h vdev_impl.h zap.h zap_impl.h zap_leaf.h zfs_acl.h zfs_context.h zfs_ctldir.h zfs_debug.h zfs_dir.h zfs_ioctl.h zfs_rlock.h zfs_vfsops.h zfs_znode.h zil.h zil_impl.h zio.h zio_checksum.h zio_compress.h zio_impl.h zvol.h sys/contrib/opensolaris/uts/common/os callb.c list.c nvpair_alloc_system.c taskq.c sys/contrib/opensolaris/uts/common/rpc xdr.c xdr.h xdr_array.c xdr_mem.c sys/contrib/opensolaris/uts/common/sys asm_linkage.h avl.h avl_impl.h bitmap.h byteorder.h callb.h ccompile.h compress.h cred.h debug.h dkio.h dklabel.h errorq.h feature_tests.h gfs.h isa_defs.h list.h list_impl.h note.h nvpair.h nvpair_impl.h processor.h procset.h sdt.h synch.h sysevent.h sysmacros.h vfs.h vmem.h zmod.h sys/contrib/opensolaris/uts/common/sys/fm protocol.h util.h sys/contrib/opensolaris/uts/common/sys/fm/fs zfs.h sys/contrib/opensolaris/uts/common/sys/fs zfs.h sys/contrib/opensolaris/uts/common/zmod adler32.c crc32.c crc32.h deflate.c deflate.h inffast.c inffast.h inffixed.h inflate.c inflate.h inftrees.c inftrees.h trees.c zconf.h zlib.h zmod.c zmod_subr.c zutil.c zutil.h Log: MFC. The final stage of the big CDDL file move. These files were repo copied in head to their new location under the 'cddl' directories of src and src/sys and then added for this branch. The build has been using the files in their new locations for a few days now. Revision Changes Path 1.2.2.1 +0 -54 src/compat/opensolaris/include/devid.h (dead) 1.1.2.1 +0 -35 src/compat/opensolaris/include/fsshare.h (dead) 1.1.2.1 +0 -11 src/compat/opensolaris/include/libintl.h (dead) 1.1.2.1 +0 -19 src/compat/opensolaris/include/mnttab.h (dead) 1.1.2.1 +0 -18 src/compat/opensolaris/include/priv.h (dead) 1.1.2.1 +0 -8 src/compat/opensolaris/include/solaris.h (dead) 1.1.2.1 +0 -6 src/compat/opensolaris/include/zone.h (dead) 1.1.2.1 +0 -167 src/compat/opensolaris/lib/libumem/umem.c (dead) 1.1.2.1 +0 -85 src/compat/opensolaris/lib/libumem/umem.h (dead) 1.1.2.1 +0 -119 src/compat/opensolaris/misc/deviceid.c (dead) 1.2.2.1 +0 -259 src/compat/opensolaris/misc/fsshare.c (dead) 1.1.2.1 +0 -213 src/compat/opensolaris/misc/mkdirp.c (dead) 1.1.2.1 +0 -160 src/compat/opensolaris/misc/mnttab.c (dead) 1.1.2.1 +0 -102 src/compat/opensolaris/misc/zmount.c (dead) 1.1.2.1 +0 -46 src/compat/opensolaris/misc/zone.c (dead) 1.1.2.1 +0 -384 src/contrib/opensolaris/OPENSOLARIS.LICENSE (dead) 1.2.2.1 +0 -93 src/contrib/opensolaris/cmd/zdb/zdb.8 (dead) 1.3.2.1 +0 -2193 src/contrib/opensolaris/cmd/zdb/zdb.c (dead) 1.1.2.1 +0 -354 src/contrib/opensolaris/cmd/zdb/zdb_il.c (dead) 1.2.2.1 +0 -1843 src/contrib/opensolaris/cmd/zfs/zfs.8 (dead) 1.1.2.1 +0 -405 src/contrib/opensolaris/cmd/zfs/zfs_iter.c (dead) 1.1.2.1 +0 -52 src/contrib/opensolaris/cmd/zfs/zfs_iter.h (dead) 1.2.2.1 +0 -3253 src/contrib/opensolaris/cmd/zfs/zfs_main.c (dead) 1.1.2.1 +0 -44 src/contrib/opensolaris/cmd/zfs/zfs_util.h (dead) 1.2.2.1 +0 -1140 src/contrib/opensolaris/cmd/zpool/zpool.8 (dead) 1.1.2.1 +0 -245 src/contrib/opensolaris/cmd/zpool/zpool_iter.c (dead) 1.2.2.1 +0 -3602 src/contrib/opensolaris/cmd/zpool/zpool_main.c (dead) 1.1.2.1 +0 -79 src/contrib/opensolaris/cmd/zpool/zpool_util.c (dead) 1.1.2.1 +0 -72 src/contrib/opensolaris/cmd/zpool/zpool_util.h (dead) 1.2.2.1 +0 -883 src/contrib/opensolaris/cmd/zpool/zpool_vdev.c (dead) 1.3.2.1 +0 -3495 src/contrib/opensolaris/cmd/ztest/ztest.c (dead) 1.1.2.1 +0 -82 src/contrib/opensolaris/head/assert.h (dead) 1.1.2.1 +0 -34 src/contrib/opensolaris/head/atomic.h (dead) 1.1.2.1 +0 -124 src/contrib/opensolaris/head/libintl.h (dead) 1.1.2.1 +0 -32 src/contrib/opensolaris/head/stdio_ext.h (dead) 1.1.2.1 +0 -264 src/contrib/opensolaris/head/synch.h (dead) 1.1.2.1 +0 -99 src/contrib/opensolaris/head/thread.h (dead) 1.1.2.1 +0 -266 src/contrib/opensolaris/lib/libnvpair/libnvpair.c (dead) 1.1.2.1 +0 -46 src/contrib/opensolaris/lib/libnvpair/libnvpair.h (dead) 1.1.2.1 +0 -59 src/contrib/opensolaris/lib/libnvpair/nvpair_alloc_system.c (dead) 1.1.2.1 +0 -384 src/contrib/opensolaris/lib/libuutil/common/libuutil.h (dead) 1.1.2.1 +0 -46 src/contrib/opensolaris/lib/libuutil/common/libuutil_common.h (dead) 1.1.2.1 +0 -181 src/contrib/opensolaris/lib/libuutil/common/libuutil_impl.h (dead) 1.1.2.1 +0 -85 src/contrib/opensolaris/lib/libuutil/common/uu_alloc.c (dead) 1.1.2.1 +0 -567 src/contrib/opensolaris/lib/libuutil/common/uu_avl.c (dead) 1.1.2.1 +0 -128 src/contrib/opensolaris/lib/libuutil/common/uu_dprintf.c (dead) 1.1.2.1 +0 -122 src/contrib/opensolaris/lib/libuutil/common/uu_ident.c (dead) 1.1.2.1 +0 -711 src/contrib/opensolaris/lib/libuutil/common/uu_list.c (dead) 1.1.2.1 +0 -250 src/contrib/opensolaris/lib/libuutil/common/uu_misc.c (dead) 1.1.2.1 +0 -70 src/contrib/opensolaris/lib/libuutil/common/uu_open.c (dead) 1.1.2.1 +0 -205 src/contrib/opensolaris/lib/libuutil/common/uu_pname.c (dead) 1.1.2.1 +0 -300 src/contrib/opensolaris/lib/libuutil/common/uu_strtoint.c (dead) 1.3.2.1 +0 -443 src/contrib/opensolaris/lib/libzfs/common/libzfs.h (dead) 1.2.2.1 +0 -599 src/contrib/opensolaris/lib/libzfs/common/libzfs_changelist.c (dead) 1.2.2.1 +0 -360 src/contrib/opensolaris/lib/libzfs/common/libzfs_config.c (dead) 1.2.2.1 +0 -3855 src/contrib/opensolaris/lib/libzfs/common/libzfs_dataset.c (dead) 1.1.2.1 +0 -646 src/contrib/opensolaris/lib/libzfs/common/libzfs_graph.c (dead) 1.1.2.1 +0 -171 src/contrib/opensolaris/lib/libzfs/common/libzfs_impl.h (dead) 1.3.2.1 +0 -1023 src/contrib/opensolaris/lib/libzfs/common/libzfs_import.c (dead) 1.1.2.1 +0 -986 src/contrib/opensolaris/lib/libzfs/common/libzfs_mount.c (dead) 1.1.2.1 +0 -2055 src/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c (dead) 1.2.2.1 +0 -303 src/contrib/opensolaris/lib/libzfs/common/libzfs_status.c (dead) 1.3.2.1 +0 -853 src/contrib/opensolaris/lib/libzfs/common/libzfs_util.c (dead