cvs commit: src/sys/amd64/isa clock.c src/sys/kern subr_lock.c
attilio at FreeBSD.org
Thu Sep 13 18:12:40 PDT 2007
attilio 2007-09-14 01:12:39 UTC
FreeBSD src repository
Currently the LO_NOPROFILE flag (which is masked on upper level code by
per-primitive macros like MTX_NOPROFILE, SX_NOPROFILE or RW_NOPROFILE) is
not really honoured. In particular lock_profile_obtain_lock_failure() and
lock_profile_obtain_lock_success() are naked respect this flag.
The bug leads to locks marked with no-profiling to be profiled as well.
In the case of the clock_lock, used by the timer i8254 this leads to
unpredictable behaviour both on amd64 and ia32 (double faults panic,
sudden reboots, etc.). The amd64 clock_lock is also not marked as
not profilable as it should be.
Fix these bugs adding proper checks in the lock profiling code and at
clock_lock initialization time.
i8254 bug pointed out by: kris
Tested by: matteo, Giuseppe Cocomazzi <sbudella at libero dot it>
Approved by: jeff (mentor)
Approved by: re
Revision Changes Path
1.234 +1 -1 src/sys/amd64/isa/clock.c
1.17 +1 -1 src/sys/kern/subr_lock.c
1.15 +5 -3 src/sys/sys/lock_profile.h
More information about the cvs-src