cvs commit: src/etc Makefile sensorsd.conf src/etc/defaults
rc.conf src/etc/rc.d Makefile sensorsd src/lib/libc/gen
sysctl.3 src/sbin/sysctl sysctl.8 sysctl.c src/share/man/man5
rc.conf.5 src/share/man/man9 Makefile sensor_attach.9
src/sys/conf files ...
jhb at FreeBSD.org
Tue Oct 16 14:27:54 PDT 2007
On Tuesday 16 October 2007 12:33:11 pm Alexander Leidinger wrote:
> Constantine asked for review several times on -current. He got some
> reviews several times for commits to perforce. He incorporated
> suggestions from those reviews, or explained why it is like it is and
> why he can not switch (with no replies with suggestions how to solve
> the problems he sees with the suggestions). Now you come and ask why
> nobody pointed out some flaws before (without telling us which
> technical flaws you talk about).
At least from my point of view this is not quite accurate as pretty much all
my feedback to the p4 commits was ignored with basically "Well, I don't like
doing it that way". Specifically, with regards to creating dynamic sysctl
trees, Constantine feels that sysctl_add_oid(9) is a hack rather than
recognizing that this is a feature of FreeBSD's sysctl system despite
repeated e-mails on the subject.
More information about the cvs-src