cvs commit: src/sys/compat/linprocfs linprocfs.c src/sys/kern kern_clock.c src/sys/sys pcpu.h resource.h

[Joe Marcus Clarke]

On Fri, 2007-11-30 at 12:48 -0800, Peter Wemm wrote:
> On Thursday 29 November 2007, Joe Marcus Clarke wrote:
> > Peter Wemm wrote:
> > > peter       2007-11-29 06:34:30 UTC
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     sys/compat/linprocfs linprocfs.c
> > >     sys/kern             kern_clock.c
> > >     sys/sys              pcpu.h resource.h
> > >   Log:
> > >   Move the shared cp_time array (counts %sys, %user, %idle etc) to
> > > the per-cpu area.  cp_time[] goes away and a new function creates a
> > > merged cp_time-like array for things like linprocfs, sysctl etc. 
> > > The atomic ops for updating cp_time[] in statclock go away, and the
> > > scope of the thread lock is reduced.
> > >
> > >   sysctl kern.cp_time returns a backwards compatible cp_time[]
> > > array. A new kern.cp_times sysctl returns the individual per-cpu
> > > stats.
> > >
> > >   I have pending changes to make top and vmstat optionally show
> > > per-cpu stats.
> > >
> > >   I'm very aware that there are something like 5 or 6 other
> > > versions "out there" for doing this - but none were handy when I
> > > needed them.
> > >
> > >   I did merge my changes with John Baldwin's, and ended up
> > > replacing a few chunks of my stuff with his, and stealing some
> > > other code.
> >
> > libgtop uses the cp_time interface.  Can __FreeBSD_version be bumped
> > for this?  And thanks for doing this work.
> >
> > Joe
> 
> If it uses sysctl kern.cp_time, then there is no change required...
> 
> If you want to get the new per-cpu stats, then just test for the 
> existence of kern.cp_times at runtime.  There's no compile-time visible 
> changes.

But cpu_time from sys/resource.h did go away.  As it turns out, I did
convert libgtop to using sysctl instead of kvm a while ago, so this is
moot.

Joe

> 
-- 
Joe Marcus Clarke
FreeBSD GNOME Team      ::      gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20071130/1d9e492b/attachment.pgp