cvs commit: src/usr.bin/tar write.c

Colin Percival cperciva at freebsd.org
Thu May 3 17:27:08 UTC 2007


Tim Kientzle wrote:
> I wonder if it would be simpler to set non-zero exit only
> if this is the first path returned from tree_next() (which
> should be the path given on the command line).  That
> would avoid the headache of having to perform a textual
> path comparison.
> 
> A simple flag to indicate if this is the first time
> through the loop should suffice, I think.

Hmm... I considered this, but I wasn't sure if there were any edge
cases where the first path returned by tree_next might not be the
path passed to tree_open; so I decided to take the route which I
knew would always work.

If you're sure that a first-time-through-the-loop flag will work,
feel free to change this. :-)

Colin Percival



More information about the cvs-src mailing list