cvs commit: src/sys/sys socketvar.h

Tue Jul 3 10:14:14 UTC 2007

rwatson     2007-07-03 10:14:13 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_6)
    sys/sys              socketvar.h 
  Log:
  Fix a bug in sblock() that has existed since revision 1.1 from BSD:
  correctly return an error if M_NOWAIT is passed to sblock() and the
  operation might block.  This remarkably subtle macro bug appears to
  be responsible for quite a few undiagnosed socket buffer corruption
  and mbuf-related kernel panics.

  This bug has already been fixed in 7-CURRENT as part of the move to
  using sx(9) locks to serialize simultaneous socket I/O, but is an
  MFC candidate for all earlier FreeBSD -STABLE branches.

  MFC after:      2 weeks
  Found by:       Isilon
  Submitted by:   jeff
  Tested by:      jhb, Yahoo!

  Revision   Changes    Path
  1.141.2.3  +1 -1      src/sys/sys/socketvar.h