cvs commit: src/sys/netinet if_ether.c

[Kip Macy]

On Dec 16, 2007 9:34 PM, Sam Leffler <sam at errno.com> wrote:
> Kip Macy wrote:
> > kmacy       2007-12-17 04:19:25 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/netinet          if_ether.c
> >   Log:
> >   Don't panic in arpresolve if we're given a null mbuf. We could
> >   insist that the caller just pass in an initialized mbuf even
> >   if didn't have any data - but that seems rather contrived.
> >
>
> You don't explain the purpose of this change.  arpresolve has been
> designed for use in the xmit path where there is always an mbuf.  This
> feels like you are now applying it for a different purpose and it might
> be better to define a different api than overload arpresolve's intended
> purpose.


 I will do that.

I did it this way because adding an interface felt redundant as I
basically need the exact same functionality without the mbuf checks.

 -Kip