cvs commit: src/bin/mv mv.c

Alfred Perlstein alfred at freebsd.org
Sun Dec 16 22:21:54 PST 2007


* Diomidis Spinellis <dds at FreeBSD.org> [071216 09:47] wrote:
> dds         2007-12-16 17:47:34 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     bin/mv               mv.c 
>   Log:
>   Eliminate gcc "variable clobbered" warnings by declaring the variables
>   living across the vfork as volatile.
>   
>   Noted by:       kan
>   
>   Revision  Changes    Path
>   1.48      +2 -1      src/bin/mv/mv.c

I'm pretty sure that calling warn(3) under vfork() is not allowed
as it can clobber stdio state.

To fix this, have the parent catch a return value from the child
and emit the warning.

-Alfred


More information about the cvs-src mailing list