cvs commit: src/sys/net if.c

[Ruslan Ermilov]

On Thu, Nov 30, 2006 at 08:48:49AM -0800, Sam Leffler wrote:
> Gleb Smirnoff wrote:
> > glebius     2006-11-30 15:02:01 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/net              if.c 
> >   Log:
> >   The recent issues with em(4) interface has shown that the old 4.4BSD
> >   if_watchdog/if_timer interface doesn't fit modern SMP network
> >   stack design.
> >   
> >   Device drivers that need watchdog to monitor their hardware should
> >   implement it theirselves.
> >   
> >   Eventually the if_watchdog/if_timer API will be removed. For now,
> >   warn that driver uses it.
> >   
> >   Reviewed by:    scottl
> 
> Did I miss a headsup on this?  Seems like something you should
> coordinate with folks so people can convert drivers beforehand.  I
> understand the problem and I see this is just a printf but now we're
> going to have people asking what's going on.
> 
Yeah, with only two drivers in the tree using a new approach (if I'm
not mistaken based on what Gleb told me today) calling it "obsolete"
was I think (ahem) a bit premature.  However, calling it "dangerous"
would be accurate and more threatening!

That way, I hope Sam's concern will be addressed as well, as it IS
dangerous, and there's no reason to hide the truth waiting for most
drivers to be converted.

BTW, is if_{watchdog|timer} also dangerous for !MPSAFE drivers?


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20061130/38328bf2/attachment.pgp