cvs commit: src/sys/netipsec xform.h xform_ipip.c
max at love2party.net
Thu Mar 30 19:47:09 UTC 2006
On Thursday 30 March 2006 21:17, Bjoern A. Zeeb wrote:
> On Thu, 30 Mar 2006, Bjoern A. Zeeb wrote:
> > bz 2006-03-30 18:57:04 UTC
> > FreeBSD src repository
> > Modified files:
> > sys/netipsec xform.h xform_ipip.c
> > Log:
> > Fix more stack corruptions on amd64.
> > Vararg functions have a different calling convention than regular
> > functions on amd64. Casting a varag function to a regular one to
> > match the function pointer declaration will hide the varargs from
> > the caller and we will end up with an incorrectly setup stack.
> I will try to go over sys/net*/** or even sys/** somewhen the next
> days and see if I can find more of them.
> If anybody knows an easy way to find all casted function pointers
> that are using varargs let me know ;-)
Shouldn't we be able to teach Coverity? It certainly has the information
/"\ Best regards, | mlaier at freebsd.org
\ / Max Laier | ICQ #67774661
X http://pf4freebsd.love2party.net/ | mlaier at EFnet
/ \ ASCII Ribbon Campaign | Against HTML Mail and News
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20060330/8ce25bde/attachment.pgp
More information about the cvs-src