cvs commit: src/sys/geom/raid3 g_raid3.c

Pawel Jakub Dawidek pjd at FreeBSD.org
Tue Mar 7 05:33:25 PST 2006


On Mon, Mar 06, 2006 at 07:39:11PM -0500, Brian Fundakowski Feldman wrote:
+> On Wed, Feb 22, 2006 at 10:21:05AM +0000, Pawel Jakub Dawidek wrote:
+> > pjd         2006-02-22 10:21:05 UTC
+> > 
+> >   FreeBSD src repository
+> > 
+> >   Modified files:
+> >     sys/geom/raid3       g_raid3.c 
+> >   Log:
+> >   Do not use bio structure after g_io_deliver(), it may not longer by valid.
+> >   
+> >   Found and fixed by:     Vsevolod Lobko <seva at ip.net.ua>
+> >   MFC after:              3 days
+> 
+> I actually found and fixed it half a year ago... could you please
+> integrate the rest of the fixes from my changes back then?  A
+> short-term low-memory deadlock is still possible (observed in
+> practice).  I think the changes also improve readability -- see
+> for example the reason r1.46 existed.

Heh. I own you apology. I haven't had time to work on graid3 back then
and I also overlooked fix of this very problem.

I integrated you fixes to my last patch which I'm planning to commit
after receiving some feedback:

	http://people.freebsd.org/~pjd/patches/graid3.patch

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20060307/257f2f29/attachment.bin


More information about the cvs-src mailing list