cvs commit: src/sys/pci agp.c

Maxime Henrion mux at FreeBSD.org
Tue Jan 17 08:47:02 PST 2006


Alexey Dokuchaev wrote:
> On Tue, Jan 17, 2006 at 04:19:07PM +0000, Doug Rabson wrote:
> > 
> > On 17 Jan 2006, at 16:11, John Baldwin wrote:
> > 
> > >On Tuesday 17 January 2006 06:51, Doug Rabson wrote:
> > >>On 20 Dec 2005, at 21:06, John Baldwin wrote:
> > >>>jhb         2005-12-20 21:06:43 UTC
> > >>>
> > >>>  FreeBSD src repository
> > >>>
> > >>>  Modified files:
> > >>>    sys/pci              agp.c
> > >>>  Log:
> > >>>  Change the agp_find_device() to return the first agp device that
> > >>>has been
> > >>>  attached to a driver rather than always returning agp0.
> > >>
> > >>According to Coverity, this introduces a memory leak
> > >>(devclass_get_devices() allocates memory).
> > >
> > >That it does.  How about this fix:
> > 
> > Looks good to me.
> 
> Except for style bugs (parens around return value).

It rather looks like John has followed the existing style in this file,
which is perfectly legitimate.

Cheers,
Maxime


More information about the cvs-src mailing list