cvs commit: src/sys/security/audit audit_arg.c
max at love2party.net
Fri Feb 3 16:09:48 PST 2006
On Saturday 04 February 2006 00:56, Devon H. O'Dell wrote:
> On Fri, Feb 03, 2006 at 11:50:26PM +0000, Robert Watson wrote:
> > rwatson 2006-02-03 23:50:26 UTC
> > FreeBSD src repository
> > Modified files:
> > sys/security/audit audit_arg.c
> > Log:
> > Fix INVARIANTS build on amd64; (unsigned unsigned long) != u_int64_t.
> Not to be pedantic or rude or anything, but don't we use
> uint64_t these days? And shouldn't we use %ju for printing
> these types?
As this is somewhat vendor code, I think u_int64_t is okay. As for %ju, I
think it's stupid. I even believe that %llu shouldn't raise an error when
printing unsigned integers with sizeof(arg_type) == sizeof(long long) - this
should be possible as a compile time assert in whatever code is responsible
We are seeing this type of porting problem over and over again, there should
be a better sollution.
/"\ Best regards, | mlaier at freebsd.org
\ / Max Laier | ICQ #67774661
X http://pf4freebsd.love2party.net/ | mlaier at EFnet
/ \ ASCII Ribbon Campaign | Against HTML Mail and News
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20060204/25508aa0/attachment.bin
More information about the cvs-src