cvs commit: src/sys/conf kern.post.mk kmod.mk src/sys/modules/if_ef Makefile src/sys/modules/if_ppp Makefile src/sys/modules/netgraph/mppc Makefile src/sys/modules/sound/sound Makefile

[Ruslan Ermilov]

Hi Bruce,

On Tue, Aug 15, 2006 at 09:40:36AM +1000, Bruce Evans wrote:
> On Mon, 14 Aug 2006, Dag-Erling Smorgrav wrote:
> 
> >des         2006-08-14 13:28:53 UTC
> >
> > FreeBSD src repository
> >
> > Modified files:
> >   sys/conf             kern.post.mk kmod.mk
> >   sys/modules/if_ef    Makefile
> >   sys/modules/if_ppp   Makefile
> >   sys/modules/netgraph/mppc Makefile
> >   sys/modules/sound/sound Makefile
> > Log:
> > Don't use touch when what is really meant is :> (create an empty file, or
> > truncate it if it exists) or :>> (ensure the file exists, but don't change
> > it if it already does)
> 
> Why not just ">" or ">>"?
> 
> > Reviewed by:    ru
> > MFC after:      2 weeks
> >
> > Revision  Changes    Path
> > 1.96      +1 -1      src/sys/conf/kern.post.mk
> > 1.210     +2 -2      src/sys/conf/kmod.mk
> > 1.14      +4 -4      src/sys/modules/if_ef/Makefile
> > 1.36      +3 -3      src/sys/modules/if_ppp/Makefile
> > 1.14      +1 -1      src/sys/modules/netgraph/mppc/Makefile
> > 1.19      +1 -1      src/sys/modules/sound/sound/Makefile
> 
> I use echo -n for one of these.  "echo" is less cryptic than ">", and
> is probably faster since /bin/echo is smaller than /bin/sh and is used
> enough to keep it cached.
> 
make(1) will still use sh(1) when it sees ">", so what's the point?

> In sound/Makefile, the cleanup should be to remove the touching (now
> emptying) since the touching used to be just worse than the default of
> emptying and is now just the same as the default (but takes extra code).
> 
No.  It has a preceding comment explaining why it's needed on sparc64:
to always build sound.ko without isadma dependency; see rev. 1.16 by
marius at .


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20060815/2d0ac985/attachment.pgp