cvs commit: src/share/examples/drivers make_device_driver.sh

Robert Watson rwatson at FreeBSD.org
Tue Aug 8 14:25:06 UTC 2006


On Tue, 8 Aug 2006, Roman Kurakin wrote:

> We could add a "foo" driver to the LINT generated by this script with 
> notification that it was generated and all changes should be placed to 
> script.

I guess I can't help but wonder if a script is necessarily better than a 
well-commented template.

Robert N M Watson
Computer Laboratory
University of Cambridge

>
> rik
>
> Robert Watson wrote:
>> 
>> On Tue, 8 Aug 2006, Yar Tikhiy wrote:
>> 
>>> On Sun, Aug 06, 2006 at 05:46:41PM +0400, Roman Kurakin wrote:
>>>> Example is for developers mostly, so I in doubts about MFC compilation
>>>> fixup and this
>>>> one commit.
>>> 
>>> I still can remeber that, when the world and I were younger, I used to 
>>> study FreeBSD examples and sources for any release I had on hand at the 
>>> moment. There still are plenty of places on the globe where off-line is 
>>> the normal state of being, so we should provide good reference material 
>>> for developers on our release CD's, to my mind. This also warrants MFC of 
>>> fixes to source comments as long as they help to understand the code.  Of 
>>> course, all this is just my private opinion.
>> 
>> In general, I think we're better served by providing skeleton or stub 
>> implementations of code that are part of the base source tree (and compiled 
>> as part of it) than providing scripts and detached sample source code.  The 
>> reason is that any code not attached to the tree almost instantly rots into 
>> uselessness.
>> 
>> Robert N M Watson
>> Computer Laboratory
>> University of Cambridge
>> 
>>> 
>>>> Roman Kurakin:
>>>> 
>>>>> rik         2006-08-06 11:06:36 UTC
>>>>> 
>>>>> FreeBSD src repository
>>>>> 
>>>>> Modified files:
>>>>>   share/examples/drivers make_device_driver.sh
>>>>> Log:
>>>>> - Added ability to provide (optional) path to the kernel sources
>>>>> - Fixed path for ${s}/conf/files.FOO and a note that it should be merged
>>>>> into
>>>>> corresponding file to be able to compile the kernel
>>>>> - Changed kernel configuration example with the driver: it is not
>>>>> produced by
>>>>> copying Generic but by including it
>>>>> - Changed from automatic module building to asking an user if it whants 
>>>>> to
>>>>> 
>>>>> Reviewed by:    julian@
>>>>> 
>>>>> Revision  Changes    Path
>>>>> 1.23      +32 -19    src/share/examples/drivers/make_device_driver.sh
>>>>> 
>>>>> 
>>> 
>>> -- 
>>> Yar
>>> 
>
>


More information about the cvs-src mailing list