cvs commit: src/sys/modules/iwi Makefile src/sys/dev/iwi if_iwi.c if_iwireg.h if_iwivar.h

[Nate Lawson]

Damien Bergamini wrote:
> damien      2005-11-19 16:54:55 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/modules/iwi      Makefile 
>     sys/dev/iwi          if_iwi.c if_iwireg.h if_iwivar.h 
>   Log:
>   Load firmware images directly from the filesystem (looks into /etc/firmware
>   directory by default) without requiring the user to load them by hand using
>   e.g iwicontrol.  Get rid of the old ioctl crud.
>   Updated iwi-firmware port coming soon.
>   
>   Obtained from:  OpenBSD
>   
>   Revision  Changes    Path
>   1.24      +157 -136  src/sys/dev/iwi/if_iwi.c
>   1.8       +6 -0      src/sys/dev/iwi/if_iwireg.h
>   1.8       +2 -17     src/sys/dev/iwi/if_iwivar.h
>   1.3       +1 -1      src/sys/modules/iwi/Makefile

I'm a little concerned about this change.  The notes claim the firmware 
is loaded after a resume from the filesystem as well as at 
initialization time.  So your driver is then assuming the ATA driver is 
fully reinitialized before your driver's resume method can be called. 
You can't assume that since it's not a child device of ATA.

Also, I'm concerned about the unnecessary use of caddr_t (which I don't 
think will work on PAE or 64 bit systems).

-- 
Nate