cvs commit: src/release Makefile

[Ruslan Ermilov]

On Thu, Nov 03, 2005 at 09:31:15AM +0000, Ceri Davies wrote:
> On Thu, Nov 03, 2005 at 07:27:50AM +0000, Ruslan Ermilov wrote:
> > ru          2005-11-03 07:27:50 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     release              Makefile 
> >   Log:
> >   Be cross-arch friendly.
> 
> > | @@ -714,7 +714,7 @@ release.8:
> > |  .endif
> > |  	cp ${.CURDIR}/../etc/usbd.conf ${RD}/mfsfd/etc/usbd.conf
> > |  	cp ${.CURDIR}/../etc/master.passwd ${RD}/mfsfd/etc/master.passwd
> > | -	pwd_mkdb -d ${RD}/mfsfd/etc -p ${RD}/mfsfd/etc/master.passwd
> > | +	cp ${RD}/trees/base/etc/*pwd.db ${RD}/mfsfd/etc/
> > |  	( for F in defaults/rc.conf netconfig protocols ; do \
> > |  		sed -e '/^#.*$$/d' -e 's/[:space:]*#.*$$//g' \
> > |  		${RD}/trees/base/etc/$$F > ${RD}/mfsfd/stand/etc/$$F ; \
> 
> I don't understand the logic.  I thought that pwd_mkdb was supposed to
> *be* cross-arch friendly these days, and aren't we now just copying in
> password databases that were created with the same pwd_mkdb during "make
> distribution", so where's the win?
> 
Target endianness can be different.  PWD_MKDB_ENDIAN in src/etc/Makefile
handles this, but not here.  We could copy the same code here with some
effort, there's just no sense in building the same files again.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20051103/4a3129ca/attachment.bin