cvs commit: src/sys/amd64/conf GENERIC src/sys/conf files.amd64 files.i386 src/sys/dev/nve if_nve.c if_nvereg.h src/sys/i386/conf GENERIC src/sys/modules Makefile src/sys/modules/nve Makefile

[John Baldwin]

On Wednesday 16 March 2005 03:20 pm, David O'Brien wrote:
> On Wed, Mar 16, 2005 at 09:03:45AM -0500, John Baldwin wrote:
> > On Sunday 13 March 2005 05:22 pm, David O'Brien wrote:
> > > On Sat, Mar 12, 2005 at 12:02:25AM -0500, Adam Gregoire wrote:
> > > > On Sat, 2005-03-12 at 00:29 +0000, David E. O'Brien wrote:
> > > > This needs to be moved to where the rest of miibus interfaces are in
> > > > amd64 and i386 GENERIC kernel config files.
> > >
> > > ..snip..
> > >
> > > > /usr/src/sys/dev/nve/if_nve.c:111:23: miibus_if.h: No such file or
> > > > directory
> > >
> > > Simply moving where they are in GENERIC won't fix this build problem.
> > > Is this during the kernel build, or the modules build?
> >
> > Moving it reduces PEBKAC errors from people not having miibus in their
> > custom kernel configs.  If it needs miibus, you need to move it to the
> > miibus section.
>
> John,
>
> I am not auging with moving it.  I was saying that moving it w/in GENERIC
> wouldn't fix build errors.  I guess you might have hit on the issue not
> stated in the bug report -- the build probably isn't with GENERIC as
> implied, but a majorly cut down minimal kernel config file.

Right, it's probably a custom kernel and they diked out miibus since the 
driver isn't in the miibus "section".  Moving the device line would help 
users from doing this accidentally. :)

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org