cvs commit: src/sys/kern uipc_mbuf.c

Alan Cox alc at cs.rice.edu
Thu Mar 3 06:24:59 GMT 2005


On Thu, Mar 03, 2005 at 02:41:37AM +0000, Doug White wrote:
> dwhite      2005-03-03 02:41:37 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             uipc_mbuf.c 
>   Log:
>   Insert volatile cast to discourage gcc from optimizing the read outside
>   of the while loop.
>   
>   Suggested by:   alc
>   MFC after:      1 day
>   
>   Revision  Changes    Path
>   1.144     +4 -1      src/sys/kern/uipc_mbuf.c

I tend to believe that the sparc64's casa() implementation is the real
culprit here.  Specifically, I don't believe the right asm operand
constraints are being used.  If I'm correct, the addition of volatile
here is unnecessary.  Can we hold the MFC until this hypothesis is
proven or disproven?

Alan


More information about the cvs-src mailing list