cvs commit: src/sys/compat/ndis subr_ntoskrnl.c

Roman Kurakin rik at
Fri Jul 8 21:17:52 GMT 2005

Maxim Sobolev:

> Roman Kurakin wrote:
>> rik         2005-07-08 18:36:59 UTC
>>   FreeBSD src repository
>>   Modified files:
>>     sys/compat/ndis      subr_ntoskrnl.c   Log:
>>   Use implicit type cast for ->k_lock to fix compilation of ndis
>>   as a part of the GENERIC kernel with INVARIANT* and WITNESS*
>>   turned off.
> I think the better fix is to change type of k_lock member from void* 
> to the struct mtx*,

Probably. I didn't try to find out the reason why it is void *. Probably 
there was
some reasons. I just leave it as is.

> I've already commited such change to the RELENG_5 few days ago. 

Hm. I've checked my mailbox and you commit was marked as unread that
means "to check it". If you are sure that there is no any special reason why
it is void* (other locks are normal) it worth to fix it your way.


> -Maxim

More information about the cvs-src mailing list