cvs commit: src/sys/dev/pccard pccard_cis.c
imp at FreeBSD.org
Thu Feb 17 21:05:04 GMT 2005
imp 2005-02-17 21:05:04 UTC
FreeBSD src repository
memspace is set to some value by masking off bits. When these bits
are equal to PCCARD_TPCE_FS_MEMSPACE_NONE, memspace will be zero, so
testing for this case inside of the if statement results in dead code.
We'd fail to set a value to zero that's already zero (since it is
initialized to 0 indirectly) with this code being there. Well, except
in the very rare case that we have a card that has a defualt entry
that includes a memory space followed by one that has no memory space
(these are extremely rare, I don't recall ever having seen one :-).
Fix this by setting num_memspace to 0 in a more appropriate place.
Submitted by: Coverity Prevent analysis tool
Revision Changes Path
1.31 +3 -4 src/sys/dev/pccard/pccard_cis.c
More information about the cvs-src