cvs commit: src/sys/dev/usb ums.c

[Nate Lawson]

Alexander Leidinger wrote:
> netchild    2005-12-29 18:35:28 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/usb          ums.c 
>   Log:
>   Sync the type (and size, compare mousestatus_t in /usr/include/sys/mouse.h)
>   of a variable according to the usage (after increasing the number of max
>   buttons this may matter).
>   
>   Noticed by:     flz
>   
>   Revision  Changes    Path
>   1.80      +1 -1      src/sys/dev/usb/ums.c
> 
> 
> Index: src/sys/dev/usb/ums.c
> diff -u src/sys/dev/usb/ums.c:1.79 src/sys/dev/usb/ums.c:1.80
> --- src/sys/dev/usb/ums.c:1.79	Thu Dec 29 17:44:40 2005
> +++ src/sys/dev/usb/ums.c	Thu Dec 29 18:35:28 2005
> @@ -425,7 +425,7 @@
>  	struct ums_softc *sc = addr;
>  	u_char *ibuf;
>  	int dx, dy, dz, dt;
> -	u_char buttons = 0;
> +	int buttons = 0;
>  	int i;
>  
>  #define UMS_BUT(i) ((i) < 3 ? (((i) + 2) % 3) : (i))

I think the UMS_BUT macro operates on only 2 bits.  Are you sure that's 
still right?

-- 
Nate