cvs commit: src/sys/dev/fdc fdc_isa.c

M. Warner Losh imp at bsdimp.com
Wed Sep 29 07:03:42 PDT 2004


In message: <19681.1096444779 at critter.freebsd.dk>
            "Poul-Henning Kamp" <phk at phk.freebsd.dk> writes:
: (BTW, Warner:  Shouldn't this:
: 
: 	static u_int8_t
: 	fdsts_rd(struct fdc_data *fdc)
: 	{
: 		
: 		return bus_space_read_1(fdc->portt, fdc->porth, FDSTS+fdc->port_off);
: 	}
: 
: be changed to:
: 
: 	static u_int8_t
: 	fdsts_rd(struct fdc_data *fdc)
: 	{
: 		
: 		return bus_space_read_1(fdc->stst, fdc->stsh, FDSTS+fdc->sts_off);
: 	}
: 
: )

Yes.  I think it should.  I think that it won't matter at all in
actual fact, but is pedantically incorrect.

Warner


More information about the cvs-src mailing list