cvs commit: src UPDATING src/etc/defaults rc.conf src/etc/rc.d Makefile ntpd rpcbind

[Sean Chittenden]

>>   Modified files:
>>   1.10      +1 -1      src/etc/rc.d/rpcbind
>
> The dependency to ntpd added to rpcbind creates somehow a circular
> dependency (at least that's what rcorder prints here before it
> dumps core here):

[snip]

> The last two lines are probably a bug in rcorder triggered by the
> circular dependency, but let's leave this for latter.  Any hints about
> the reason ntpd causes a circular dependency when added to the REQUIRED
> line of rpcbind?

Yeah, it's a double free(3).  If you comment out the calls to free(3) 
the bl_list, r_tmp, pnode, and fnode (and their _tmp counter parts), 
you'll prevent the double free(3).  I know that's not the correct 
solution, but since rcorder is such a short lived process with a 
limited role (albeit an important one), I think it'd be an okay 
solution for now.

> I'm positively sure it was ntpd that caused this because removing it
> from the dependencies of rpcbind lets the following finish normally:
>
>         # rcorder -k FreeBSD /etc/rc.d/*
>
> If you plan to revert the change it's probably ok to temporarily keep
> rpcbind without a dependency to ntpd in my local CVS.  If ntpdate stays
> out though, we should investigate this further.

!  Bugger I thought this was specific to my environment since I don't 
have rpcbind in my rc.d tree.  obrien (or whoever has assumed 
maintainership, couldn't find any references to someone), since you 
originally imported this code, do you have any plans on importing a 
recent snapshot of NetBSD's code?  I've noticed that they've ANSIfied 
the code, though there aren't any changes that are significant or worth 
while beyond that.

Regardless, for the time being, I have put ntpdate back in rpcbind.  -sc

-- 
Sean Chittenden