cvs commit: src/sys/pci if_vr.c

Justin T. Gibbs gibbs at scsiguy.com
Sat Oct 30 21:43:24 PDT 2004


> On Sat, Oct 30, 2004 at 10:35:58PM -0700, Justin T. Gibbs wrote:
>> > Shouldn't an API for adding or removing ISR's be responsible for
>> > handling just such a race condition?
>> 
>> bus_teardown_intr() already has these semantics, but you have
>> to know to use it and that it should only be called without
>> locks held since it may sleep waiting for another CPU to
>> leave your interrupt handler.
> 
> Unfortunately I don't have a vr(4) card to test the changes with, and
> it looks like the copy of if_vr.c in my local tree uses bus_teardown_intr()
> correctly; these changes will have to be tested and committed after 5.3R.
> 
> BMS

You should be able to get rid of the suspended check in the isr too.

--
Justin



More information about the cvs-src mailing list