cvs commit: src/sys/dev/sound/isa ad1816.c es1888.c gusc.c sbc.c

[John Baldwin]

On Monday 11 October 2004 05:51 pm, Nate Lawson wrote:
> John Baldwin wrote:
> > On Monday 11 October 2004 03:52 pm, Nate Lawson wrote:
> >>njl         2004-10-11 19:52:31 UTC
> >>
> >>  FreeBSD src repository
> >>
> >>  Modified files:
> >>    sys/dev/sound/isa    ad1816.c es1888.c gusc.c sbc.c
> >>  Log:
> >>  Add acpi attachments for ISA sound drivers.  This is needed so they'll
> >>  probe and attach when ACPI is enabled.
> >>
> >>  Submitted by:   takawata (sbc fix)
> >>  MFC after:      1 day
> >
> > This should only be needed for PnP BIOS cards, not just plain old ISA PnP
> > cards.  The es1888.c file is only a driver on Alpha in fact as it
> > basically includes a dummy identify routine to make up for the lack of
> > PnP BIOS on Alphas.
>
> Which of those cards should have the acpi attachment removed?  I think
> it should be:
>
> * Removed from es1888.c
> * Added to ess.c:esscontrol
> * Moved from mss.c:snd_mss to snd_pnpmss

My gut feeling is that only sbc(4) is actually integrated in motherboards 
(note that ACPI and PnP BIOS aren't for PNP ISA cards, but for devices 
integrated into the motherboard itself, and not PCI soundcards) but it 
doesn't hurt to have the attachment for all PNP-aware ISA sound drivers I 
guess.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org