cvs commit: src/sys/kern subr_witness.c

John Baldwin jhb at FreeBSD.org
Mon Oct 11 11:39:16 PDT 2004


On Saturday 09 October 2004 04:16 am, Brian Feldman wrote:
> green       2004-10-09 08:16:37 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/kern             subr_witness.c
>   Log:
>   Don't "implicitly order all sleep locks before spin locks" in witness
>   when the spin lock in question isn't -- it's the critical_enter() that
>   KDB set.  No more panic in DDB for console -> syscons -> tty -> knote
>   operations.

Thanks for breaking witness.  A better choice would be to fix kdb_printf() 
instead of just papering over the problem.  Having KDB block on a lock will 
have all sorts of bad results and all this does is hide the warning.

Please revert.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org


More information about the cvs-src mailing list