cvs commit: src/sys/kern kern_shutdown.c

Greg 'groggy' Lehey grog at FreeBSD.org
Mon Oct 4 16:43:56 PDT 2004


On Monday,  4 October 2004 at 16:38:08 -0600, M. Warner Losh wrote:
> In message: <20041004223426.GJ460 at wantadilla.lemis.com>
>             "Greg 'groggy' Lehey" <grog at FreeBSD.org> writes:
>> On Monday,  4 October 2004 at  9:55:38 -0600, M. Warner Losh wrote:
>>> In message: <200410041313.i94DDN1w064795 at repoman.freebsd.org>
>>>             Poul-Henning Kamp <phk at FreeBSD.org> writes:
>>>> phk         2004-10-04 13:13:23 UTC
>>>>
>>>>   FreeBSD src repository
>>>>
>>>>   Modified files:
>>>>     sys/kern             kern_shutdown.c
>>>>   Log:
>>>>   Change the perfectly precise message
>>>>          printf("No buffers busy after final sync");
>>>>   to
>>>>          printf("All buffers synced.");
>>>>   in order to not leave the users wondering if there should be.
>>>
>>> Any not reason to delete
>>>  	printf("All buffers synced.");
>>> entirely?
>>
>> I like to see some message to confirm that the process is over and
>> done with.  Something goes wrong often enough that it's good to know
>> that it worked this time.
>
> The machine will either shutoff, reboot or print the 'hit any key to
> reboot' message in addition.

... assuming everything works correctly.

> Do we really need an additional message saying that we did the right
> thing?

No.  If it always works, that's fine.  I've had too many cases where
it didn't, though.  I can't see that it does any harm to state the
fact.

Greg
--
See complete headers for address and phone numbers.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20041005/ca1223d5/attachment.bin


More information about the cvs-src mailing list