cvs commit: src/sbin/mount mntopts.h mount.8 mount.c src/sbin/mount_std mount_std.8

[Ruslan Ermilov]

On Tue, Nov 30, 2004 at 07:07:11PM +0100, Poul-Henning Kamp wrote:
> In message <20041130090553.GA691 at ip.net.ua>, Ruslan Ermilov writes:
> 
> >> FYI, this commit seems to have broken my line in fstab which has worked f
> >or
> >> a long time:
> >> 
> >> md                      /tmp    mfs     rw,-s16m,noatime,nosuid,nodev 2 0
> >> 
> >> Is it useful for the nodev option to cause a hard failure here? Note, I'm
> >> not arguing against either change, just pointing out a side effect.
> >> 
> >There's no longer a "nodev" option, please ask Poul-Henning for details.  ;)
> 
> The reason I did not remove MNT_NODEV but only #defined it to zero was
> to make it silently ignored.
> 
To make it silently ignored, you should have left it with its old value.
Most operations with MNT_* constants are "bitwise AND", and so zero was
not a good choice.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20041130/c0229a8c/attachment.bin