cvs commit: src/sys/dev/led led.h

David O'Brien obrien at FreeBSD.org
Tue May 11 11:16:00 PDT 2004


On Tue, May 11, 2004 at 10:02:59AM -0700, Nate Lawson wrote:
> On Mon, 10 May 2004, Maxime Henrion wrote:
> >   Modified files:
> >     sys/dev/led          led.h
> >   Log:
> >   - Remove the __FBSDID and put the $FreeBSD$ tag in the comment above,
> >     so that including this file more than once works.
.. 
> Do we even want __FBSDID in .h files?  It doesn't seem to make sense since
> it's not a compilation unit (i.e. no linkage).

It actually does make sense, as a header's contents does wind up in a .o
eventually :-)  And header contents can be the cause of problems as much
as a .c file.  There is no problem having multiple __FBSDID in either
a.out or ELF objects.

That said, its not something we have agreement for [that I know of].
 
-- 
-- David  (obrien at FreeBSD.org)


More information about the cvs-src mailing list