cvs commit: src/sys/net if_vlan.c

Bruce Evans bde at zeta.org.au
Tue May 4 10:45:14 PDT 2004


On Tue, 4 May 2004, Doug Barton wrote:

> Andre Oppermann wrote:
>
> > However it worked for me just fine.  The reason I just found out is that
> > I wasn't compiling if_vlan into the kernel but loaded and tested it as
> > module.  Compiling it as module doesn't give any compiler warning and
> > works w/o a hitch.  Dunno why?
>
> Testing both should be standard operating procedure before you commit.
> Of course there _should_ be no difference, but that's why you do testing
> on stuff like this.

The difference is because there is too much in kern.pre.mk.  In
particular, the setting of -Werror.  Only kern.mk is common to building
kernels and modules.

Other misplaced things: -D_KERNEL -fno-common -finline_limit=${INLINE_LIMIT}.
These are just duplicated, complete with icc ifdefs for the last 2.

Bruce


More information about the cvs-src mailing list