cvs commit: src/sys/net if_arcsubr.c

[Pawel Jakub Dawidek]

On Sat, Mar 20, 2004 at 10:34:34PM -0800, Matthew N. Dodd wrote:
+> mdodd       2004/03/20 22:34:34 PST
+> 
+>   FreeBSD src repository
+> 
+>   Modified files:
+>     sys/net              if_arcsubr.c 
+>   Log:
+>   Handle AF_ARP.
[...]
+> +		switch(ntohs(ah->ar_op)) {
+> +		case ARPOP_REVREQUEST:
+> +		case ARPOP_REVREPLY:
+> +			type = htons(ARCTYPE_REVARP);
+> +			break;
+> +		case ARPOP_REQUEST:
+> +		case ARPOP_REPLY:
+> +		default:
+> +			type = htons(ARCTYPE_ARP);
+> +			break;
+> +		}
[...]

Tinderbox is reporting failures, probably because you planned to use
'atype' here, instead of 'type', but I don't want to fix it, because I
don't understand this: 'atype' is a u_int8_t, so I think htons() will
transform in to '0' on some archs (e.g. i386) and I don't think it
was your intention.

-- 
Pawel Jakub Dawidek                       http://www.FreeBSD.org
pjd at FreeBSD.org                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040321/3f4e18ad/attachment.bin