cvs commit: src/sys/boot/arc/include arcfuncs.hsrc/sys/boot/i386/boot2 boot2.c src/sys/dev/aic7xxx/aicasm aicasm.c src/sys/dev/cx machdep.h src/sys/dev/ichsmb ichsmb.c src/sys/dev/iir iir.h src/s

[Tony Finch]

On Sat, 13 Mar 2004, Ruslan Ermilov wrote:
> On Fri, Mar 12, 2004 at 01:45:45PM -0800, Tom Rhodes wrote:
> >
> > -#ifdef __GNUC__
> > -#if __GNUC__ >= 2
> > +#if defined(__GNUC__) || defined(__INTEL_COMPILER)
> > +#if __GNUC__ >= 2 || defined(__INTEL_COMPILER)
> >  #pragma pack(4)
> >  #endif
> >  #endif
>
> These ifdefs are broken.
>
> #if (defined(__GNUC__) && __GNUC >= 2) || defined(__INTEL_COMPILER)
>
> would be more correct.

Why, given that an undefined macro is equivalent to 0 in this context?

-- 
Tony Finch  <dot at dotat.at>  http://dotat.at/