cvs commit: src/lib/libc/stdio _flock_stub.c local.h

[John Birrell]

On Tue, Mar 09, 2004 at 02:55:32PM +1100, Tim Robbins wrote:
> My concern here is that we are slowing down critical paths for the
> sake of broken applications that grope around inside FILEs. Why do
> we need to support this? Which applications require it, and why?

I'm not sure that I agree that applications are 'broken' when they
use things that are defined in the header file along with the FILE
structure itself.

As I said in my previous mail, if you want to improve performance,
then remove the locking code from libc completely in the single-threaded
case. That will have more benefit than checking a NULL pointer that
has to be resolved anyway in order to access the fields it points
to. I think you're arguing about just a few instructions on i386.

FWIW, I OpenSSL's file BIO with this functionality.

-- 
John Birrell