cvs commit: src/sys/dev/acpica acpi.c acpi_pcib.c acpi_resource.c acpivar.h

[John Baldwin]

On Wednesday 23 June 2004 01:21 pm, John Baldwin wrote:
> jhb         2004-06-23 17:21:02 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/dev/acpica       acpi.c acpi_pcib.c acpi_resource.c
>                          acpivar.h
>   Log:
>   - Defer BUS_CONFIG_INTR() on ACPI IRQ resources until the resources are
>     actually used.  For most ACPI devices this means deferring the call
>     until bus_alloc_resource().
>     - Add a function acpi_config_intr() to call BUS_CONFIG_INTR() for an
>       ACPI IRQ resource using the trigger mode and polarity information
>       stored in the ACPI resource object.
>     - Add a function acpi_lookup_irq_resource() to lookup the ACPI IRQ
>       resource that corresponds to a specified rid and new-bus resource.
>     - Have the ACPI PCI bridge driver call BUS_CONFIG_INTR() on interrupts
>       that it routes through link devices.
>   - Remove needactivate variable from acpi_alloc_resource() by changing the
>     function not modify the flags variable but just mask off RF_ACTIVE when
>     calling rman_reserve_resource().
>
>   Reviewed by:    njl (1, an earlier version)

These changes prevent BUS_CONFIG_INTR() being called on the IRQ resources for 
PCI link devices that aren't used or for it being called on the PIC resource 
when the link device hasn't been reprogrammed to use an appropriate APIC 
resource.  This should get rid of any 'atpic: Ignoring invalid level/low 
configuration' bootverbose messages.  It also allows us to enable 
bus_config_intr() when using APICs which should fix problems with various 
people's boxes.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org