cvs commit: src/usr.sbin/watchdogd watchdogd.c

[Poul-Henning Kamp]

In message <20040728233751.A31182 at newtrinity.zeist.de>, Marius Strobl writes:
>On Fri, Jul 23, 2004 at 03:24:58PM +0000, Brian Feldman wrote:
>> green       2004-07-23 15:24:58 UTC
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     usr.sbin/watchdogd   watchdogd.c 
>>   Log:
>>   Now that mlockall(2) is unbroken, use it to keep watchdogd(8) permanently
>>   out of swap.
>>   
>
>This broke watchdogd(8) on at least alpha and sparc64:
>omega# watchdogd
>watchdogd: mlockall: Resource temporarily unavailable
>
>Like I told you before, every call of mlockall(MCL_CURRENT) returns -1
>and sets errno to EAGAIN on these platforms.

Worse, if it had worked it would have prevented watchdogd from
detecting swap disk related issues.

The only kind of special treatment you should give a watchdog daemons
is negative benefits so that it will be more sensitive to trouble.

Please back this out.


-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.