cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h

Don Lewis truckman at
Tue Jan 20 20:54:22 PST 2004

On 20 Jan, Bruce Evans wrote:
> On Mon, 19 Jan 2004, Poul-Henning Kamp wrote:
>> phk         2004/01/19 13:27:11 PST
>>   FreeBSD src repository
>>   Modified files:
>>     sys/alpha/alpha      support.s
>>     sys/i386/i386        swtch.s
>>     sys/kern             kern_shutdown.c
>>     sys/sys              systm.h
>>   Log:
>>   Add linenumber and source filename to panic(9) output.
> This was rejected in all reviews.  It gives less information than
> grepping the sources, at some cost (grep at least gives correct line
> numbers when the sources don't quite match the binary).

One point in favor of including the file name is that it allows the
consumer of this information to grep the correct file instead of having
to grep all of /usr/src/sys.  The line number is pretty useless, though.

What about the case of macros like KASSERT() and the vnode lock
assertions?  Won't they report the name and line number of the #define?

More information about the cvs-src mailing list